WebKit-https.git
8 years agoAdd links to regression ranges in Trac to the TestFailures page
aroben@apple.com [Fri, 24 Jun 2011 19:36:44 +0000 (19:36 +0000)]
Add links to regression ranges in Trac to the TestFailures page

Fixes <http://webkit.org/b/61060> <rdar://problem/9452153> TestFailures page should provide
links to regression ranges in Trac

Reviewed by David Kilzer.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Added.
(Trac): This new class represents a particular instance of Trac for a single project.
(Trac.prototype.logURL): Returns the URL that can be used to see the log of the given
repository path between the two specified revisions
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
(ViewController): Added new trac argument.
(ViewController.prototype._displayBuilder): Moved code to create the DOM for the
passed/failed builds from here...
(ViewController.prototype._domForRegressionRange): ...to here. Now also includes a link to
Trac if there are multiple suspect revisions.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
Trac.js and pass a Trac instance for trac.webkit.org to the ViewController.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-17 Nat Duca <nduca@chromium.org>
nduca@chromium.org [Fri, 24 Jun 2011 19:29:16 +0000 (19:29 +0000)]
2011-05-17  Nat Duca  <nduca@chromium.org>

        Reviewed by James Robinson.

        [chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor
        https://bugs.webkit.org/show_bug.cgi?id=58408

        Create CCLayerTreeHost and CCLayerTreeHostImpl, which are the main
        thread and compositor thread halves of a composited view. Communication
        between the two is based on the design used in FileStreamProxy.

        * WebCore.gypi:
        * platform/chromium/TraceEvent.h:
        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::create):
        (WebCore::LayerRendererChromium::LayerRendererChromium):
        (WebCore::LayerRendererChromium::setViewport):
        (WebCore::LayerRendererChromium::updateLayers):
        (WebCore::LayerRendererChromium::drawLayers):
        (WebCore::LayerRendererChromiumImpl::create):
        (WebCore::LayerRendererChromiumImpl::drawLayersAndPresent):
        (WebCore::LayerRendererChromiumImpl::LayerRendererChromiumImpl):
        (WebCore::LayerRendererChromiumImpl::drawLayersOnMainThread):
        (WebCore::LayerRendererChromiumImplProxy::create):
        (WebCore::LayerRendererChromiumImplProxy::createLayerTreeHostImpl):
        (WebCore::LayerRendererChromiumImplProxy::LayerRendererChromiumImplProxy):
        (WebCore::LayerRendererChromium::createLayerTreeHostImplProxy):
        * platform/graphics/chromium/LayerRendererChromium.h:
        * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
        (WebCore::CCHeadsUpDisplay::setShowFPSCounter):
        (WebCore::CCHeadsUpDisplay::setShowPlatformLayerTree):
        * platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
        (WebCore::CCHeadsUpDisplay::currentFrameNumber):
        * platform/graphics/chromium/cc/CCLayerTreeHost.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp.
        (WebCore::CCLayerTreeHost::CCLayerTreeHost):
        (WebCore::CCLayerTreeHost::init):
        (WebCore::CCLayerTreeHost::~CCLayerTreeHost):
        (WebCore::CCLayerTreeHost::beginCommit):
        (WebCore::CCLayerTreeHost::commitComplete):
        (WebCore::CCLayerTreeHost::animateAndLayout):
        (WebCore::CCLayerTreeHost::createLayerTreeHostCommitter):
        (WebCore::CCLayerTreeHost::setNeedsCommitAndRedraw):
        (WebCore::CCLayerTreeHost::setNeedsRedraw):
        (WebCore::CCLayerTreeHost::updateLayers):
        * platform/graphics/chromium/cc/CCLayerTreeHost.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp.
        (WebCore::CCLayerTreeHost::frameNumber):
        * platform/graphics/chromium/cc/CCLayerTreeHostCommitter.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp.
        (WebCore::CCLayerTreeHostCommitter::create):
        (WebCore::CCLayerTreeHostCommitter::commit):
        * platform/graphics/chromium/cc/CCLayerTreeHostCommitter.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp.
        (WebCore::CCLayerTreeHostCommitter::CCLayerTreeHostCommitter):
        * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: Added.
        (WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
        (WebCore::CCLayerTreeHostImpl::~CCLayerTreeHostImpl):
        (WebCore::CCLayerTreeHostImpl::beginCommit):
        (WebCore::CCLayerTreeHostImpl::commitComplete):
        (WebCore::CCLayerTreeHostImpl::drawLayers):
        (WebCore::CCLayerTreeHostImpl::setNeedsCommitAndRedraw):
        (WebCore::CCLayerTreeHostImpl::setNeedsRedraw):
        * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp.
        (WebCore::CCLayerTreeHostImplClient::~CCLayerTreeHostImplClient):
        (WebCore::CCLayerTreeHostImpl::frameNumber):
        (WebCore::CCLayerTreeHostImpl::sourceFrameNumber):
        (WebCore::CCLayerTreeHostImpl::setSourceFrameNumber):
        * platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp: Added.
        (WebCore::CCLayerTreeHostImplProxy::CCLayerTreeHostImplProxy):
        (WebCore::CCLayerTreeHostImplProxy::start):
        (WebCore::CCLayerTreeHostImplProxy::~CCLayerTreeHostImplProxy):
        (WebCore::CCLayerTreeHostImplProxy::isStarted):
        (WebCore::CCLayerTreeHostImplProxy::setNeedsCommitAndRedraw):
        (WebCore::CCLayerTreeHostImplProxy::setNeedsRedraw):
        (WebCore::CCLayerTreeHostImplProxy::stop):
        (WebCore::CCLayerTreeHostImplProxy::postDrawLayersTaskOnCCThread):
        (WebCore::CCLayerTreeHostImplProxy::requestFrameAndCommitOnCCThread):
        (WebCore::CCLayerTreeHostImplProxy::isMainThread):
        (WebCore::CCLayerTreeHostImplProxy::isCCThread):
        (WebCore::CCLayerTreeHostImplProxy::requestFrameAndCommit):
        (WebCore::CCLayerTreeHostImplProxy::commitOnCCThread):
        (WebCore::CCLayerTreeHostImplProxy::drawLayersOnCCThread):
        (WebCore::CCLayerTreeHostImplProxy::setNeedsCommitAndRedrawOnCCThread):
        (WebCore::CCLayerTreeHostImplProxy::setNeedsRedrawOnCCThread):
        (WebCore::CCLayerTreeHostImplProxy::initImplOnCCThread):
        (WebCore::CCLayerTreeHostImplProxy::layerTreeHostClosedOnCCThread):
        * platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.h: Added.
        (WebCore::CCLayerTreeHostImplProxy::host):
        * platform/graphics/chromium/cc/CCMainThreadTask.h:
        * platform/graphics/chromium/cc/CCThread.cpp:
        (WebCore::CCThread::runLoop):
        * platform/graphics/chromium/cc/CCThreadTask.h:
2011-05-17  Nat Duca  <nduca@chromium.org>

        Reviewed by James Robinson.

        [chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor
        https://bugs.webkit.org/show_bug.cgi?id=58408

        Redirect invalidates and scheduling into compositor when in
        threaded compositing mode. Add stress tests for CCLayerTreeHost.

        * WebKit.gypi:
        * public/WebWidget.h:
        * src/WebPopupMenuImpl.cpp:
        (WebKit::WebPopupMenuImpl::animate):
        * src/WebPopupMenuImpl.h:
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::animate):
        (WebKit::WebViewImpl::paint):
        (WebKit::WebViewImpl::animateAndLayout):
        (WebKit::WebViewImpl::updateLayers):
        (WebKit::WebViewImpl::composite):
        (WebKit::WebViewImpl::setRootLayerNeedsDisplay):
        (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
        (WebKit::WebViewImpl::doComposite):
        (WebKit::WebViewImpl::createLayerTreeHostContext3D):
        (WebKit::WebViewImpl::reallocateRenderer):
        (WebKit::WebViewImpl::updateLayerRendererSettings):
        (WebKit::WebViewImpl::updateLayerRendererViewport):
        * src/WebViewImpl.h:
        * tests/CCLayerTreeHostTest.cpp: Added.
        (WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):
        (WTF::CCLayerTreeHostTest::animateAndLayout):
        (WTF::CCLayerTreeHostTest::beginCommitOnCCThread):
        (WTF::CCLayerTreeHostTest::beginCommitOnMainThread):
        (WTF::CCLayerTreeHostTest::commitOnCCThread):
        (WTF::CCLayerTreeHostTest::commitCompleteOnCCThread):
        (WTF::CCLayerTreeHostTest::commitCompleteOnMainThread):
        (WTF::CCLayerTreeHostTest::drawLayersAndPresentOnCCThread):
        (WTF::CCLayerTreeHostTest::updateLayers):
        (WTF::CCLayerTreeHostTest::onBeginTest):
        (WTF::CCLayerTreeHostTest::doEndTest):
        (WTF::CCLayerTreeHostTest::onEndTest):
        (WTF::CCLayerTreeHostTest::runTest):
        (WTF::CCLayerTreeHostTest::testTimeout):
        (WTF::MockLayerTreeHostClient::MockLayerTreeHostClient):
        (WTF::MockLayerTreeHostClient::createLayerTreeHostContext3D):
        (WTF::MockLayerTreeHostClient::animateAndLayout):
        (WTF::MockLayerTreeHostClient::updateLayers):
        (WTF::MockLayerTreeHostCommitter::create):
        (WTF::MockLayerTreeHostCommitter::commit):
        (WTF::MockLayerTreeHostCommitter::MockLayerTreeHostCommitter):
        (WTF::MockLayerTreeHostImpl::create):
        (WTF::MockLayerTreeHostImpl::beginCommit):
        (WTF::MockLayerTreeHostImpl::commitComplete):
        (WTF::MockLayerTreeHostImpl::drawLayersAndPresent):
        (WTF::MockLayerTreeHostImpl::MockLayerTreeHostImpl):
        (WTF::MockLayerTreeHostImplProxy::create):
        (WTF::MockLayerTreeHostImplProxy::createLayerTreeHostImpl):
        (WTF::MockLayerTreeHostImplProxy::MockLayerTreeHostImplProxy):
        (WTF::MockLayerTreeHost::MockLayerTreeHost):
        (WTF::MockLayerTreeHost::createLayerTreeHostImplProxy):
        (WTF::MockLayerTreeHost::updateLayers):
        (WTF::MockLayerTreeHost::createLayerTreeHostCommitter):
        (WTF::MockLayerTreeHost::beginCommit):
        (WTF::MockLayerTreeHost::commitComplete):
        (WTF::CCLayerTreeHostTest::doBeginTest):
        (WTF::CCLayerTreeHostTest::endTest):
        (WTF::CCLayerTreeHostTestShortlived1::CCLayerTreeHostTestShortlived1):
        (WTF::CCLayerTreeHostTestShortlived1::beginTest):
        (WTF::CCLayerTreeHostTestShortlived1::afterTest):
        (WTF::TEST_F):
        (WTF::CCLayerTreeHostTestShortlived2::CCLayerTreeHostTestShortlived2):
        (WTF::CCLayerTreeHostTestShortlived2::beginTest):
        (WTF::CCLayerTreeHostTestShortlived2::afterTest):
        (WTF::CCLayerTreeHostTestShortlived3::CCLayerTreeHostTestShortlived3):
        (WTF::CCLayerTreeHostTestShortlived3::beginTest):
        (WTF::CCLayerTreeHostTestShortlived3::afterTest):
        (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::CCLayerTreeHostTestCommitingWithContinuousRedraw):
        (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::beginTest):
        (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::commitCompleteOnCCThread):
        (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::drawLayersAndPresentOnCCThread):
        (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::afterTest):
        (WTF::CCLayerTreeHostTestSetNeedsCommit1::CCLayerTreeHostTestSetNeedsCommit1):
        (WTF::CCLayerTreeHostTestSetNeedsCommit1::beginTest):
        (WTF::CCLayerTreeHostTestSetNeedsCommit1::drawLayersAndPresentOnCCThread):
        (WTF::CCLayerTreeHostTestSetNeedsCommit1::commitOnCCThread):
        (WTF::CCLayerTreeHostTestSetNeedsCommit1::afterTest):
        (WTF::CCLayerTreeHostTestSetNeedsCommit2::CCLayerTreeHostTestSetNeedsCommit2):
        (WTF::CCLayerTreeHostTestSetNeedsCommit2::beginTest):
        (WTF::CCLayerTreeHostTestSetNeedsCommit2::drawLayersAndPresentOnCCThread):
        (WTF::CCLayerTreeHostTestSetNeedsCommit2::commitOnCCThread):
        (WTF::CCLayerTreeHostTestSetNeedsCommit2::afterTest):
        (WTF::CCLayerTreeHostTestSetNeedsRedraw::CCLayerTreeHostTestSetNeedsRedraw):
        (WTF::CCLayerTreeHostTestSetNeedsRedraw::beginTest):
        (WTF::CCLayerTreeHostTestSetNeedsRedraw::drawLayersAndPresentOnCCThread):
        (WTF::CCLayerTreeHostTestSetNeedsRedraw::commitOnCCThread):
        (WTF::CCLayerTreeHostTestSetNeedsRedraw::afterTest):
        * tests/CCThreadTest.cpp:
        (WebCore::TEST):
2011-05-17  Nat Duca  <nduca@chromium.org>

        Reviewed by James Robinson.

        [chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor
        https://bugs.webkit.org/show_bug.cgi?id=58408

        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::paintInvalidatedRegion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Chris Rogers <crogers@google.com>
crogers@google.com [Fri, 24 Jun 2011 19:20:42 +0000 (19:20 +0000)]
2011-06-24  Chris Rogers  <crogers@google.com>

        Reviewed by Kenneth Russell.

        Enable Web Audio for Chromium Win
        https://bugs.webkit.org/show_bug.cgi?id=63338

        * features.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Adrienne Walker <enne@google.com>
enne@google.com [Fri, 24 Jun 2011 19:16:48 +0000 (19:16 +0000)]
2011-06-24  Adrienne Walker  <enne@google.com>

        Unreviewed, remove assertion about root layers in RenderLayerBacking.
        https://bugs.webkit.org/show_bug.cgi?id=60741

        This was added in r89687, but somehow is not true on Safari Leopard.
        However, as the tests that were added with that revision are passing
        correctly, the assertion is most likely not correct.

        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Dominic Cooney <dominicc@chromium.org>
dominicc@chromium.org [Fri, 24 Jun 2011 19:11:28 +0000 (19:11 +0000)]
2011-06-24  Dominic Cooney  <dominicc@chromium.org>

        Unreviewed: Skipping failing progress-clone.html on win.

        r89682 unskipped fast/dom/HTMLProgressElement/progress-clone.html
        on win, but it should stay skipped because there is no progress
        element on win (bug 49769)

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 24 Jun 2011 18:48:25 +0000 (18:48 +0000)]
2011-06-24  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Refactor text iterator code respecting surrogate pairs from WidthIterator
        https://bugs.webkit.org/show_bug.cgi?id=63319

        WidthIterator contains a surrogate pair aware text iterator that is needed in other parts of WebCore.
        Refactor the code into its own SurrogatePairAwareTextIterator class. It can be used like this:

        UChar32 character = 0;
        unsigned clusterLength = 0;

        SurrogatePairAwareTextIterator textIterator(myString.characters(), 0, myString.length(), myString.length());
        while (textIterator.consume(character, clusterLength)) {
            // Either clusterLength is 1 and UChar32 fits into a single UChar.
            // Or     clusterLength is 2 and the UChar32 has been computed by combining the high & low surrogate pairs
            ...

            textIterator.advance(clusterLength);
        }

        SVGGlyphMap is the next candidate that wants to make use of SurrogatePairAwareTextIterator.
        Doesn't affect any tests, just refactoring.

        * CMakeLists.txt: Add SurrogatePairAwareTextIterator.* to build.
        * GNUmakefile.list.am: Ditto.
        * WebCore.gypi: Ditto.
        * WebCore.pro: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * platform/graphics/SurrogatePairAwareTextIterator.cpp: Copied from platform/graphics/WidthIterator.cpp.
        * platform/graphics/SurrogatePairAwareTextIterator.h: Added.
        (WebCore::SurrogatePairAwareTextIterator::currentCharacter):
        * platform/graphics/WidthIterator.cpp:
        (WebCore::WidthIterator::advance):
        * platform/graphics/WidthIterator.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMac build fix after r89685
aroben@apple.com [Fri, 24 Jun 2011 18:47:14 +0000 (18:47 +0000)]
Mac build fix after r89685

* WebProcess/WebKitMain.cpp: Make a Windows-only #include really be Windows-only.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agofast/css/font-face-in-shadow-DOM.html is flaky on Chromium, failing on Win XP Debug.
jberlin@webkit.org [Fri, 24 Jun 2011 18:43:59 +0000 (18:43 +0000)]
fast/css/font-face-in-shadow-DOM.html is flaky on Chromium, failing on Win XP Debug.
https://bugs.webkit.org/show_bug.cgi?id=63115

Better solution: this test appears to give different results depending on what other test
is run before it, so just disable it.

* fast/css/font-face-in-shadow-DOM.html: Removed.
* fast/css/font-face-in-shadow-DOM.html-disabled: Copied from fast/css/font-face-in-shadow-DOM.html.
* platform/win-xp/fast/css: Removed.
* platform/win-xp/fast/css/font-face-in-shadow-DOM-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Adrienne Walker <enne@google.com>
enne@google.com [Fri, 24 Jun 2011 18:35:12 +0000 (18:35 +0000)]
2011-06-24  Adrienne Walker  <enne@google.com>

        Reviewed by Simon Fraser.

        Incorrect RenderLayer transforms on overflow RTL pages
        https://bugs.webkit.org/show_bug.cgi?id=60741

        Add a number of composited positioning tests on pages with dir=rtl.
        The reference images are all identical to what the non-composited path
        generates.

        The overflow-scrolled tests on Safari do not generate the right images
        due to bug 63284, but the layer tree is correct so they are not
        skipped.

        * compositing/rtl/rtl-absolute-expected.png: Added.
        * compositing/rtl/rtl-absolute-expected.txt: Added.
        * compositing/rtl/rtl-absolute-overflow-expected.png: Added.
        * compositing/rtl/rtl-absolute-overflow-expected.txt: Added.
        * compositing/rtl/rtl-absolute-overflow-scrolled-expected.png: Added.
        * compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt: Added.
        * compositing/rtl/rtl-absolute-overflow-scrolled.html: Added.
        * compositing/rtl/rtl-absolute-overflow.html: Added.
        * compositing/rtl/rtl-absolute.html: Added.
        * compositing/rtl/rtl-fixed-expected.png: Added.
        * compositing/rtl/rtl-fixed-expected.txt: Added.
        * compositing/rtl/rtl-fixed-overflow-expected.png: Added.
        * compositing/rtl/rtl-fixed-overflow-expected.txt: Added.
        * compositing/rtl/rtl-fixed-overflow-scrolled-expected.png: Added.
        * compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt: Added.
        * compositing/rtl/rtl-fixed-overflow-scrolled.html: Added.
        * compositing/rtl/rtl-fixed-overflow.html: Added.
        * compositing/rtl/rtl-fixed.html: Added.
        * compositing/rtl/rtl-iframe-absolute-expected.png: Added.
        * compositing/rtl/rtl-iframe-absolute-expected.txt: Added.
        * compositing/rtl/rtl-iframe-absolute-overflow-expected.png: Added.
        * compositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Added.
        * compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.png: Added.
        * compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Added.
        * compositing/rtl/rtl-iframe-absolute-overflow-scrolled.html: Added.
        * compositing/rtl/rtl-iframe-absolute-overflow.html: Added.
        * compositing/rtl/rtl-iframe-absolute.html: Added.
        * compositing/rtl/rtl-iframe-fixed-expected.png: Added.
        * compositing/rtl/rtl-iframe-fixed-expected.txt: Added.
        * compositing/rtl/rtl-iframe-fixed-overflow-expected.png: Added.
        * compositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Added.
        * compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.png: Added.
        * compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Added.
        * compositing/rtl/rtl-iframe-fixed-overflow-scrolled.html: Added.
        * compositing/rtl/rtl-iframe-fixed-overflow.html: Added.
        * compositing/rtl/rtl-iframe-fixed.html: Added.
        * compositing/rtl/rtl-iframe-relative-expected.png: Added.
        * compositing/rtl/rtl-iframe-relative-expected.txt: Added.
        * compositing/rtl/rtl-iframe-relative.html: Added.
        * compositing/rtl/rtl-relative-expected.png: Added.
        * compositing/rtl/rtl-relative-expected.txt: Added.
        * compositing/rtl/rtl-relative.html: Added.
        * compositing/rtlclipping/rtl-absolute-overflow-scrolled-expected.png: Added.
        * compositing/rtlclipping/rtl-absolute-overflow-scrolled-expected.txt: Added.
        * compositing/rtlclipping/rtl-absolute-overflow-scrolled.html: Added.
        * platform/chromium/test_expectations.txt:
        * platform/mac/Skipped:
2011-06-24  Adrienne Walker  <enne@google.com>

        Reviewed by Simon Fraser.

        Incorrect RenderLayer transforms on overflow RTL pages
        https://bugs.webkit.org/show_bug.cgi?id=60741

        Fix positioning of the root graphics layer for RTL pages.  The fact
        that the left side of the page is negative for pages with overflow is
        not taken into account when calculating the position.  This negative
        value ends up being double-counted for the root graphics layer (once
        in the position and once in the offset) and it shifts child layers
        into the wrong place.

        Tests: compositing/rtl/rtl-absolute-overflow-scrolled.html
               compositing/rtl/rtl-absolute-overflow.html
               compositing/rtl/rtl-absolute.html
               compositing/rtl/rtl-fixed-overflow-scrolled.html
               compositing/rtl/rtl-fixed-overflow.html
               compositing/rtl/rtl-fixed.html
               compositing/rtl/rtl-iframe-absolute-overflow-scrolled.html
               compositing/rtl/rtl-iframe-absolute-overflow.html
               compositing/rtl/rtl-iframe-absolute.html
               compositing/rtl/rtl-iframe-fixed-overflow-scrolled.html
               compositing/rtl/rtl-iframe-fixed-overflow.html
               compositing/rtl/rtl-iframe-fixed.html
               compositing/rtl/rtl-iframe-relative.html
               compositing/rtl/rtl-relative.html

        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agofast/css/font-face-in-shadow-DOM.html is flaky on Chromium, failing on Win XP Debug.
jberlin@webkit.org [Fri, 24 Jun 2011 18:24:41 +0000 (18:24 +0000)]
fast/css/font-face-in-shadow-DOM.html is flaky on Chromium, failing on Win XP Debug.
https://bugs.webkit.org/show_bug.cgi?id=63115

Add expected (failing?) results for win-xp to get the bots green.

* platform/win-xp/fast/css: Added.
* platform/win-xp/fast/css/font-face-in-shadow-DOM-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake the web process pause dialog look better on Vista/7 and robust against executabl...
aroben@apple.com [Fri, 24 Jun 2011 18:09:14 +0000 (18:09 +0000)]
Make the web process pause dialog look better on Vista/7 and robust against executable renames

Fixes <http://webkit.org/b/63335> Web process pause dialog looks bad on Vista/7

Reviewed by Brian Weinstein.

* WebProcess/WebKitMain.cpp:
(pauseProcessIfNeeded): Moved code to show the pause dialog here from WebKitMain. We now
fetch the executable name using ::GetModuleFileNameW instead of hard-coding it. The string
we pass to ::MessageBoxW no longer has embedded newlines, which improves its appearance on
Vista/7 (which were doing their own wrapping in addition to our newlines). Appearance is
different but fine on XP. Note that the message text now contains the "[_debug].exe" suffix when
referring to the process; that is different from before but seems fine.
(WebKitMain): Call the new function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Matthew Delaney <mdelaney@apple.com>
mdelaney@apple.com [Fri, 24 Jun 2011 17:52:09 +0000 (17:52 +0000)]
2011-06-24  Matthew Delaney  <mdelaney@apple.com>

        Fixing burning trees from change to tests in https://bugs.webkit.org/show_bug.cgi?id=63327
        Adding new platform specific results since the new layout in the tests changes the render tree spew.
        Pixel tests are still good.

        * platform/mac/transforms/3d/point-mapping/3d-point-mapping-expected.txt:
        * platform/mac/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 24 Jun 2011 17:45:00 +0000 (17:45 +0000)]
2011-06-24  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Enrica Casucci.

        Add BeforeChildren and AfterChildren to the Position's anchor types
        https://bugs.webkit.org/show_bug.cgi?id=63100

        Added PositionIsBeforeChildren and PositionIsAfterChildren to Position::AnchorType and deployed them in
        firstPositionInNode and lastPositionInNode.

        These new types of positions will let us express the first and the last positions in a non-text node in O(1).

        No new tests because there is no new behavior or feature exposed.

        * dom/Position.cpp:
        (WebCore::Position::Position): Assert that the anchor type is not BeforeChildren and AfterChildren for text nodes.
        (WebCore::Position::containerNode): For BeforeChildren and AfterChildren, the anchor node is the container node.
        (WebCore::Position::computeOffsetInContainerNode): The offset in the container node is 0 for BeforeChildren and
        the offset in the anchor node for AfterChildren.
        (WebCore::Position::offsetForPositionAfterAnchor): Called by deprecatedNode; the anchor type could be AfterChildren.
        (WebCore::Position::parentAnchoredEquivalent): If the anchor node is before or after children, then do the trick
        for table and ignored contents like before or after anchor.
        (WebCore::Position::computeNodeBeforePosition): Returns null for BeforeChildren and returns the last child of
        the anchor node for AfterChildren.
        (WebCore::Position::computeNodeAfterPosition): Returns the first child of the anchor node for BeforeChildren
        (WebCore::Position::atFirstEditingPositionForNode): A position is at the last editing position if the anchor type
        is BeforeChildren, or the anchor type is AfterChildren or AfterAnchor and the anchor doesn't have any children.
        (WebCore::Position::atLastEditingPositionForNode): A position is at the last editing position if the anchor type
        is AfterChildren.
        (WebCore::Position::showAnchorTypeAndOffset): Supports BeforeChildren and AfterChildren.
        * dom/Position.h:
        (WebCore::Position::deprecatedEditingOffset): Returns m_offset if the anchor type is BeforeChildren.
        (WebCore::firstPositionInNode): Returns a position in offset for a text node. Otherwise returns BeforeChildren.
        (WebCore::lastPositionInNode): Returns a position in offset for a text node. Otherwise returns AfterChildren.
        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::positionOutsideTabSpan): Since the anchor node was a text node,
        the anchor type shouldn't be BeforeChildren or AfterChildren.
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::updatePositionForNodeRemoval): Supports BeforeChildren and AfterChildren.
        (WebCore::DeleteSelectionCommand::handleGeneralDelete): Calls updatePositionForNodeRemoval on m_downstremEnd
        when its anchor node is removed instead of manually updating the offset; also avoid calling moveToOffset
        on BeforeChildren or AfterChildren position.
        * editing/FormatBlockCommand.cpp:
        (WebCore::FormatBlockCommand::formatRange): Since lastParagraphInBlockNode is used to insert a placeholder
        after paragraphs below the block is moved into, it needs to be the position after the current last child in
        the block instead of after children in the block; otherwise the position will move to the end of block.
        * editing/VisiblePosition.cpp:
        (WebCore::VisiblePosition::characterAfter): Since the container node is never a text for position before/after
        children or before/after anchor, just return null for these anchor types.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Dominic Cooney <dominicc@chromium.org>
dominicc@chromium.org [Fri, 24 Jun 2011 17:37:51 +0000 (17:37 +0000)]
2011-06-24  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Dimitri Glazkov.

        Convert shadow DOM-related tests to use window.internals
        https://bugs.webkit.org/show_bug.cgi?id=61671

        * Source/autotools/symbols.filter: Export symbols for GTK.
2011-06-24  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Dimitri Glazkov.

        Convert shadow DOM-related tests to use window.internals
        https://bugs.webkit.org/show_bug.cgi?id=61671

        Update tests to use internals.{ensureShadowRoot, shadowRoot,
        shadowPseudoId, removeShadowRoot} instead of layoutTestController.

        * fast/dom/HTMLKeygenElement/keygen-expected.txt:
        * fast/dom/HTMLKeygenElement/keygen.html:
        * fast/dom/HTMLMeterElement/meter-clone-expected.txt:
        * fast/dom/HTMLMeterElement/meter-clone.html:
        * fast/dom/HTMLProgressElement/progress-clone-expected.txt:
        * fast/dom/HTMLProgressElement/progress-clone.html:
        * fast/dom/shadow/activeelement-should-be-shadowhost.html:
        * fast/dom/shadow/create-content-element.html:
        * fast/dom/shadow/gc-shadow-expected.txt:
        * fast/dom/shadow/gc-shadow.html:
        * fast/dom/shadow/layout-tests-can-access-shadow-expected.txt: shadowRoot of non-element throws now, so verify new behavior.
        * fast/dom/shadow/layout-tests-can-access-shadow.html:
        * fast/dom/shadow/nodetype.html:
        * fast/dom/shadow/tab-order-iframe-and-shadow.html:
        * fast/events/shadow-boundary-crossing.html:
        * fast/forms/resources/common.js:
        (getValidationMessageBubbleNode):
        * fast/html/clone-keygen-expected.txt:
        * fast/html/clone-keygen.html:
        * fast/html/clone-range-expected.txt:
        * fast/html/clone-range.html:
        * fast/html/details-clone.html:
        * fullscreen/video-controls-override-expected.txt:
        * fullscreen/video-controls-override.html:
        * media/audio-controls-do-not-fade-out.html:
        * media/media-controls.js:
        (mediaControlsButtonCoordinates):
        * media/video-controls-in-media-document.html:
        * platform/win/Skipped: shadowRoot and friends now available on win.
2011-06-24  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Dimitri Glazkov.

        Convert shadow DOM-related tests to use window.internals
        https://bugs.webkit.org/show_bug.cgi?id=61671

        * WebCore.exp.in: Exports for symbols used by WebCoreTestSupport.
        * testing/Internals.cpp: The new home of shadowRoot and friends.
        (WebCore::Internals::ensureShadowRoot):
        (WebCore::Internals::shadowRoot):
        (WebCore::Internals::removeShadowRoot):
        (WebCore::Internals::shadowPseudoId):
        * testing/Internals.h:
        * testing/Internals.idl:
2011-06-24  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Dimitri Glazkov.

        Convert shadow DOM-related tests to use window.internals
        https://bugs.webkit.org/show_bug.cgi?id=61671

        Remove shadow DOM-related methods from Chromium API. These are not
        required any more.

        * public/WebElement.h:
        * src/WebElement.cpp:
2011-06-24  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Dimitri Glazkov.

        Convert shadow DOM-related tests to use window.internals
        https://bugs.webkit.org/show_bug.cgi?id=61671

        Remove shadow-DOM related methods from GTK DRT API. These are not
        required any more.

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        * WebCoreSupport/DumpRenderTreeSupportGtk.h:
2011-06-24  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Dimitri Glazkov.

        Convert shadow DOM-related tests to use window.internals
        https://bugs.webkit.org/show_bug.cgi?id=61671

        Remove shadow DOM-related methods from Mac API. These are not
        required any more.

        * DOM/WebDOMOperations.mm:
        * DOM/WebDOMOperationsPrivate.h:
2011-06-24  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Dimitri Glazkov.

        Convert shadow-DOM related tests to use window.internals
        https://bugs.webkit.org/show_bug.cgi?id=61671

        Remove shadow-DOM related methods from Qt DRT API. These are not
        required any more.

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        * WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-06-24  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Dimitri Glazkov.

        Convert shadow DOM-related tests to use window.internals
        https://bugs.webkit.org/show_bug.cgi?id=61671

        Remove shadow DOM-related methods from WebKit2 API. These are not
        required any more.

        * WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:
        * WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
        * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
        * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
        * win/WebKit2.def: Re-exports for symbols used by WebCoreTestSupport.
        * win/WebKit2CFLite.def: Same for Cairo.
2011-06-24  Dominic Cooney   <dominicc@chromium.org>

        Reviewed by Dimitri Glazkov.

        Convert shadow DOM-related tests to use window.internals
        https://bugs.webkit.org/show_bug.cgi?id=61671

        Remove ensureShadowRoot, shadowRoot, shadowPseudoId and
        removeShadowRoot from layoutTestController; these have been
        replaced by equivalents in window.internals instead.

        * DumpRenderTree/LayoutTestController.cpp:
        (LayoutTestController::staticFunctions):
        * DumpRenderTree/LayoutTestController.h:
        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        * DumpRenderTree/chromium/LayoutTestController.h:
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        * DumpRenderTree/qt/LayoutTestControllerQt.h:
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
        * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
        * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
        * WebKitTestRunner/InjectedBundle/LayoutTestController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Matthew Delaney <mdelaney@apple.com>
mdelaney@apple.com [Fri, 24 Jun 2011 16:57:47 +0000 (16:57 +0000)]
2011-06-24  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Simon Fraser.

        Change transforms/3d/point-mapping/3d-point-mapping{,-preserve-3d}.html to absolutely position divs
        https://bugs.webkit.org/show_bug.cgi?id=63327

        * transforms/3d/point-mapping/3d-point-mapping-preserve-3d.html:
        * transforms/3d/point-mapping/3d-point-mapping.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 24 Jun 2011 16:35:11 +0000 (16:35 +0000)]
2011-06-24  Tony Chang  <tony@chromium.org>

        Reviewed by Darin Adler.

        Refactor creation of primitive values in CSSParser
        https://bugs.webkit.org/show_bug.cgi?id=63270

        Covered by existing tests.

        * css/CSSParser.cpp:
        (WebCore::CSSParser::createPrimitiveNumericValue): Helper method for creating numeric values
            to keep the cast in one place.
        (WebCore::CSSParser::createPrimitiveStringValue): Helper method for creating string values.
        (WebCore::CSSParser::parseValidPrimitive):
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseWCSSInputProperty):
        (WebCore::CSSParser::parsePage):
        (WebCore::CSSParser::parseSizeParameter):
        (WebCore::CSSParser::parseContent):
        (WebCore::CSSParser::parseFillPositionX):
        (WebCore::CSSParser::parseFillPositionY):
        (WebCore::CSSParser::parseFillPositionComponent):
        (WebCore::CSSParser::parseFillSize):
        (WebCore::CSSParser::parseAnimationDelay):
        (WebCore::CSSParser::parseAnimationDuration):
        (WebCore::CSSParser::parseAnimationIterationCount):
        (WebCore::CSSParser::parseAnimationName):
        (WebCore::CSSParser::parseTransformOriginShorthand):
        (WebCore::CSSParser::parseDashboardRegions):
        (WebCore::CSSParser::parseCounterContent):
        (WebCore::CSSParser::parseShape):
        (WebCore::CSSParser::parseFont):
        (WebCore::CSSParser::parseReflect):
        (WebCore::CSSParser::parseBorderRadius):
        (WebCore::CSSParser::parseCounter):
        (WebCore::CSSParser::parseDeprecatedGradient):
        (WebCore::CSSParser::parseLinearGradient):
        (WebCore::CSSParser::parseRadialGradient):
        (WebCore::CSSParser::parseGradientColorStops):
        (WebCore::CSSParser::parseTransform):
        (WebCore::CSSParser::parseTransformOrigin):
        (WebCore::CSSParser::parseTextEmphasisStyle):
        * css/CSSParser.h:
        * css/CSSPrimitiveValueCache.h:
        (WebCore::CSSPrimitiveValueCache::createValue): pass String by const reference

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r89457-r89462): fast/forms/textfield-overflow.html failing on SnowLeopard...
jberlin@webkit.org [Fri, 24 Jun 2011 16:28:46 +0000 (16:28 +0000)]
REGRESSION (r89457-r89462): fast/forms/textfield-overflow.html failing on SnowLeopard Intel
Release (WebKit2 Tests)
https://bugs.webkit.org/show_bug.cgi?id=63328

Add win-wk2 expected results that match the mac, but not mac-wk2, results so that the test
does not start failing on win-wk2.

* platform/win-wk2/fast/forms: Added.
* platform/win-wk2/fast/forms/textfield-overflow-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Fri, 24 Jun 2011 16:26:59 +0000 (16:26 +0000)]
2011-06-24  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [X11] Do not call NPP_SetWindow with a null window handle on destroy
        https://bugs.webkit.org/show_bug.cgi?id=62981

        * WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
        (WebKit::NetscapePlugin::destroy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r89457-r89462): fast/forms/textfield-overflow.html failing on SnowLeopard...
jberlin@webkit.org [Fri, 24 Jun 2011 16:09:26 +0000 (16:09 +0000)]
REGRESSION (r89457-r89462): fast/forms/textfield-overflow.html failing on SnowLeopard Intel
Release (WebKit2 Tests)
https://bugs.webkit.org/show_bug.cgi?id=63328

Add (failing?) expected results for mac-wk2 to get the bots green.

* platform/mac-wk2/fast/forms/textfield-overflow-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Fri, 24 Jun 2011 15:59:55 +0000 (15:59 +0000)]
2011-06-24  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Alexey Proskuryakov.

        Exit immediately if the last condition tested fails.

        Make <video> app cache test exit immediately on failure
        https://bugs.webkit.org/show_bug.cgi?id=63323

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Fri, 24 Jun 2011 15:54:10 +0000 (15:54 +0000)]
2011-06-24  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Add more debug options to compilation
        https://bugs.webkit.org/show_bug.cgi?id=63318

        Add --enable-debug-symbols to enable/disable compilation with
        debug symbols and --enable-debug-features to enable/disable debug
        features. Both options are unconditionally enabled for debug
        builds.

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r89657): http/tests/inspector/extensions-headers.html,
jberlin@webkit.org [Fri, 24 Jun 2011 15:43:35 +0000 (15:43 +0000)]
REGRESSION (r89657): http/tests/inspector/extensions-headers.html,
http/tests/inspector/extensions-resources-redirect.html timing out on SnowLeopard Intel
Release (WebKit2 Tests).
https://bugs.webkit.org/show_bug.cgi?id=63325

Skip those tests to get the bots green.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Fri, 24 Jun 2011 15:42:28 +0000 (15:42 +0000)]
2011-06-24  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Fix runtime critical warnings in WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=63256

        Check whether there's a view widget before trying to use it in
        PlatformScreenGtk. If there isn't a view widget, which is the case
        in WebKit2, try to use the default GdkScreen and monitor.

        * platform/gtk/PlatformScreenGtk.cpp:
        (WebCore::getToplevel): Helper function to get the toplevel
        widget.
        (WebCore::getVisual): Use getToplevel().
        (WebCore::getScreen): Helper funtion to get the screen of a
        widget.
        (WebCore::screenRect): Use getToplevel() and getScreen().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] fast/frames/iframe-plugin-load-remove-document-crash.html crashes
ossy@webkit.org [Fri, 24 Jun 2011 14:14:48 +0000 (14:14 +0000)]
[Qt][WK2] fast/frames/iframe-plugin-load-remove-document-crash.html crashes
https://bugs.webkit.org/show_bug.cgi?id=63321

* platform/qt-wk2/Skipped: Skip fast/frames/iframe-plugin-load-remove-document-crash.html until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Balazs Kelemen <kbalazs@webkit.org>
kbalazs@webkit.org [Fri, 24 Jun 2011 13:10:31 +0000 (13:10 +0000)]
2011-06-24  Balazs Kelemen  <kbalazs@webkit.org>

        Unreviewed.
        Remove non-existent items from the qt-wk2 skipped list.

        * platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake run-bindings-tests remove its temporary directories.
ossy@webkit.org [Fri, 24 Jun 2011 12:37:33 +0000 (12:37 +0000)]
Make run-bindings-tests remove its temporary directories.
https://bugs.webkit.org/show_bug.cgi?id=63320

Reviewed by Dirk Schulze.

* Scripts/run-bindings-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Fri, 24 Jun 2011 12:18:18 +0000 (12:18 +0000)]
2011-06-24  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Adam Barth.

        WebSocket: Add run-time flag for new HyBi protocol
        https://bugs.webkit.org/show_bug.cgi?id=60348

        Add a flag in Setting so that WebSocket protocols can be switched
        dynamically. The protocol we have implemented so far is based on
        older Hixie-76 specification. A new protocol is being discussed in
        IETF HyBi working group, and I'm planning to implement the new protocol
        behind this Settings flag.

        I will add a method to LayoutTestController which flips this flag in
        a later patch. In this way, we can put tests for both protocols in
        the same place and test implementation for both protocols at the same time.

        This patch only adds a flag. The flag is not used yet, thus there is
        no change in functionality. Therefore, no tests were added.

        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        * page/Settings.h:
        (WebCore::Settings::setUseHixie76WebSocketProtocol):
        (WebCore::Settings::useHixie76WebSocketProtocol):
2011-06-24  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Adam Barth.

        WebSocket: Add run-time flag for new HyBi protocol
        https://bugs.webkit.org/show_bug.cgi?id=60348

        Make a new flag (Setting::m_useHixie76WebSocketProtocol)
        switchable from WebView and WebPreferences.

        * WebView/WebPreferenceKeysPrivate.h:
        * WebView/WebPreferences.mm:
        (+[WebPreferences initialize]):
        (-[WebPreferences setHixie76WebSocketProtocolEnabled:]):
        (-[WebPreferences isHixie76WebSocketProtocolEnabled]):
        * WebView/WebPreferencesPrivate.h:
        * WebView/WebView.mm:
        (-[WebView _preferencesChanged:]):
2011-06-24  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Adam Barth.

        WebSocket: Add run-time flag for new HyBi protocol
        https://bugs.webkit.org/show_bug.cgi?id=60348

        Make a new flag (Setting::m_useHixie76WebSocketProtocol)
        switchable from WebView and WebPreferences.

        * Interfaces/IWebPreferencesPrivate.idl:
        * WebPreferenceKeysPrivate.h:
        * WebPreferences.cpp:
        (WebPreferences::initializeDefaultSettings):
        (WebPreferences::setHixie76WebSocketProtocolEnabled):
        (WebPreferences::hixie76WebSocketProtocolEnabled):
        * WebPreferences.h:
        * WebView.cpp:
        (WebView::notifyPreferencesChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Fri, 24 Jun 2011 12:02:11 +0000 (12:02 +0000)]
2011-06-24  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        Clean up some tests for search cancel buttons.
        https://bugs.webkit.org/show_bug.cgi?id=63121

        - Introduce a function to retrieve a reliable position of a search
          cancel button.
        - Convert two tests to dumpAsText().

        * fast/forms/resources/common.js:
        (searchCancelButtonPosition): Added.
        * fast/forms/search-abs-pos-cancel-button.html: Use searchCancelButtonPosition().
        * fast/forms/search-cancel-button-mouseup.html: Use searchCancelButtonPosition().
        * fast/forms/search-transformed-expected.txt: Added.
        * fast/forms/search-transformed.html:
          - Use searchCancelButtonPosition().
          - Convert to dumpAsText().
        * fast/forms/search-zoomed-expected.txt: Added.
        * fast/forms/search-zoomed.html:
          - Use searchCancelButtonPosition().
          - Convert to dumpAsText().
        * platform/chromium/test_expectation.txt:
          search-transformed.html should pass.
        * platform/chromium-linux/fast/forms/search-zoomed-expected.png: Removed.
        * platform/chromium-mac-leopard/fast/forms/search-transformed-expected.png: Removed.
        * platform/chromium-mac-leopard/fast/forms/search-zoomed-expected.png: Removed.
        * platform/chromium-mac/fast/forms/search-transformed-expected.png: Removed.
        * platform/chromium-win/fast/forms/search-zoomed-expected.png: Removed.
        * platform/chromium-win/fast/forms/search-zoomed-expected.txt: Removed.
        * platform/gtk/fast/forms/search-transformed-expected.png: Removed.
        * platform/gtk/fast/forms/search-transformed-expected.txt: Removed.
        * platform/gtk/fast/forms/search-zoomed-expected.png: Removed.
        * platform/gtk/fast/forms/search-zoomed-expected.txt: Removed.
        * platform/mac-leopard/fast/forms/search-zoomed-expected.png: Removed.
        * platform/mac/fast/forms/search-transformed-expected.png: Removed.
        * platform/mac/fast/forms/search-transformed-expected.txt: Removed.
        * platform/mac/fast/forms/search-zoomed-expected.png: Removed.
        * platform/mac/fast/forms/search-zoomed-expected.txt: Removed.
        * platform/qt/fast/forms/search-transformed-expected.txt: Removed.
        * platform/qt/fast/forms/search-zoomed-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Fri, 24 Jun 2011 11:52:23 +0000 (11:52 +0000)]
2011-06-24  Kent Tamura  <tkent@chromium.org>

        Remove an JavaScript error in media-controls-clone.html.
        https://bugs.webkit.org/show_bug.cgi?id=63195

        * media/media-controls-clone.html: Remove run() call.
        * platform/chromium-mac/media/media-controls-clone-expected.txt: Remove an error message.
        * platform/chromium-win/media/media-controls-clone-expected.txt: ditto.
        * platform/mac/media/media-controls-clone-expected.txt: ditto.
        * platform/win/media/media-controls-clone-expected.txt: ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Fri, 24 Jun 2011 11:47:36 +0000 (11:47 +0000)]
2011-06-23  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Shorten DOMWindow URLs in heap profiles.
        https://bugs.webkit.org/show_bug.cgi?id=63238

        * inspector/front-end/DetailedHeapshotGridNodes.js:
        (WebInspector.HeapSnapshotGridNode.prototype.hasHoverMessage.false.hoverMessage):
        (WebInspector.HeapSnapshotGenericObjectNode):
        (WebInspector.HeapSnapshotGenericObjectNode.prototype.hoverMessage):
        (WebInspector.HeapSnapshotGenericObjectNode.prototype._updateHasChildren):
        (WebInspector.HeapSnapshotGenericObjectNode.prototype.isDOMWindow):
        (WebInspector.HeapSnapshotGenericObjectNode.prototype.shortenWindowURL):
        * inspector/front-end/DetailedHeapshotView.js:
        (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext.pathFound):
        (WebInspector.DetailedHeapshotView.prototype._getHoverAnchor):
        (WebInspector.DetailedHeapshotView.prototype._showStringContentPopup.displayString):
        (WebInspector.DetailedHeapshotView.prototype._showStringContentPopup):
        * inspector/front-end/utilities.js:
        ():

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Fri, 24 Jun 2011 11:18:50 +0000 (11:18 +0000)]
2011-06-24  Pavel Feldman  <pfeldman@google.com>

        Not reviewed: uncommenting chromium devtools tests.

        * platform/chromium/inspector/timeline/timeline-layout-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Fri, 24 Jun 2011 11:17:54 +0000 (11:17 +0000)]
2011-06-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Kent Tamura.

        [EFL] Add ewk_auth.h to EWebKit.h
        https://bugs.webkit.org/show_bug.cgi?id=63311

        * ewk/EWebKit.h: Add ewk_auth.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 MORITA Hajime <morrita@google.com>
morrita@google.com [Fri, 24 Jun 2011 10:42:54 +0000 (10:42 +0000)]
2011-06-23  MORITA Hajime  <morrita@google.com>

        Reviewed by Kent Tamura.

        [Chromium] Invalid write inside WebKit::FrameLoaderClientImpl::dispatchDidClearWindowObjectInWorld
        https://bugs.webkit.org/show_bug.cgi?id=63216

        Deleted m_webViewHost which looks leaked.

        * DumpRenderTree/chromium/TestShell.h:
        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::~TestShell):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Vsevolod Vlasov <vsevik@chromium.org>
commit-queue@webkit.org [Fri, 24 Jun 2011 10:39:29 +0000 (10:39 +0000)]
2011-06-24  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: HTML preview should delete old iframe on show().
        https://bugs.webkit.org/show_bug.cgi?id=63170

        * inspector/front-end/ResourceHTMLView.js:
        (WebInspector.ResourceHTMLView.prototype._createIFrame):
        * inspector/front-end/ResourcePreviewView.js:
        (WebInspector.ResourcePreviewView.prototype.contentLoaded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Fri, 24 Jun 2011 10:21:27 +0000 (10:21 +0000)]
2011-06-24  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Convert AnimatedString to SVGAnimatorFactory concept
        https://bugs.webkit.org/show_bug.cgi?id=63296

        Follow up of "SVGAnimation should use direct unit animation for SVGLength": https://bugs.webkit.org/show_bug.cgi?id=61368
        This patch continues the conversion to the new concept of SVGAnimatorFactory with SVGString.

        No new tests added. No change of functionality.

        * CMakeLists.txt: Added new file to build system.
        * GNUmakefile.list.am: Ditto.
        * WebCore.gypi: Ditto.
        * WebCore.pro: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * svg/SVGAllInOne.cpp: Ditto.
        * svg/SVGAnimateElement.cpp:
        (WebCore::SVGAnimateElement::calculateAnimatedValue):
        (WebCore::SVGAnimateElement::calculateFromAndToValues):
        (WebCore::SVGAnimateElement::calculateFromAndByValues):
        (WebCore::SVGAnimateElement::resetToBaseValue):
        (WebCore::SVGAnimateElement::applyResultsToTarget):
        (WebCore::SVGAnimateElement::calculateDistance):
        * svg/SVGAnimateElement.h:
        * svg/SVGAnimatedString.cpp: Added. Animator for SVGString.
        (WebCore::SVGAnimatedStringAnimator::SVGAnimatedStringAnimator):
        (WebCore::SVGAnimatedStringAnimator::constructFromString):
        (WebCore::SVGAnimatedStringAnimator::calculateFromAndToValues):
        (WebCore::SVGAnimatedStringAnimator::calculateFromAndByValues):
        (WebCore::SVGAnimatedStringAnimator::calculateAnimatedValue):
        (WebCore::SVGAnimatedStringAnimator::calculateDistance):
        * svg/SVGAnimatedString.h:
        (WebCore::SVGAnimatedStringAnimator::~SVGAnimatedStringAnimator):
        * svg/SVGAnimatedType.cpp:
        (WebCore::SVGAnimatedType::~SVGAnimatedType):
        (WebCore::SVGAnimatedType::createString):
        (WebCore::SVGAnimatedType::string):
        (WebCore::SVGAnimatedType::valueAsString):
        (WebCore::SVGAnimatedType::setValueAsString):
        * svg/SVGAnimatedType.h:
        * svg/SVGAnimatorFactory.h:
        (WebCore::SVGAnimatorFactory::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Fri, 24 Jun 2011 09:06:32 +0000 (09:06 +0000)]
2011-06-24  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Chris Fleizach.

        [GTK] Consider rows being ignored when adding children to tables
        https://bugs.webkit.org/show_bug.cgi?id=62718

        Unskip accessibility test that will be passing from now on.

        * platform/gtk/Skipped: Unskipped passing test.
2011-06-24  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Chris Fleizach.

        [GTK] Consider rows being ignored when adding children to tables
        https://bugs.webkit.org/show_bug.cgi?id=62718

        Hide row objects in tables in GTK's accessibility wrapper.

        This is a different approach in the way WebCore's accessible
        rows are exposed to assistive technologies in the GTK port,
        since from now on those objects are kept in WebCore (they do not
        declare to ignore accessibility) and just bypassed in the mapping
        to ATK, allowing to hide them in the ATK hierarchy while, at the
        same time, keeping them internally to be able to provide enough
        information to determine tables related information, such as rows
        counting or finding an cell for specific coordinates.

        * accessibility/gtk/AccessibilityObjectAtk.cpp:
        (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
        Do not ignore accessibility for table rows here.

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (webkit_accessible_get_parent): Bypass rows when needed.
        (getNChildrenForTable): New, find the number of children for a
        table, which will be the addition of all cells for its rows.
        (webkit_accessible_get_n_children): Call to getNChildrenForTable
        for accessibility tables if needed.
        (getChildForTable): New, bypass rows when needed, retrieving
        cells as if they were direct children for tables.
        (webkit_accessible_ref_child): Call to refChildForTable if needed.
        (getIndexInParentForCellInRow): New, get the index for a given
        cell in its parent table, considering other rows' cells.
        (webkit_accessible_get_index_in_parent): Call to
        getIndexInParentForCellInRow if needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Fri, 24 Jun 2011 08:43:28 +0000 (08:43 +0000)]
2011-06-24  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: extension panel iframes do not span entire panel client area
        https://bugs.webkit.org/show_bug.cgi?id=63165

        * inspector/front-end/ExtensionServer.js:
        (WebInspector.ExtensionServer.prototype._onCreatePanel):
        (WebInspector.ExtensionServer.prototype.createClientIframe):
        * inspector/front-end/inspector.css:
        (iframe.extension):
        (iframe.panel.extension):

2011-06-24  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: extension panel iframes do not span entire panel client area
        https://bugs.webkit.org/show_bug.cgi?id=63165

        * http/tests/inspector/extensions-test.js:
        (initialize_ExtensionsTest.InspectorTest.showPanel):
        ():
        * http/tests/inspector/inspector-test.js:
        ():
        * http/tests/inspector/resources/extension-main.html:
        * http/tests/inspector/resources/extension-main.js:
        (dumpObject):
        (dumpArray):
        (evaluateOnFrontend.callbackWrapper):
        (evaluateOnFrontend):
        ():
        * http/tests/inspector/resources/extension-panel.html:
        * inspector/extensions/extensions-events.html:
        * inspector/extensions/extensions-expected.txt:
        * inspector/extensions/extensions.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Vsevolod Vlasov <vsevik@chromium.org>
commit-queue@webkit.org [Fri, 24 Jun 2011 08:25:50 +0000 (08:25 +0000)]
2011-06-24  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Darin Fisher.

        Web Inspector: [Chromium] Successfully prefetched page shows up as an error in console
        https://bugs.webkit.org/show_bug.cgi?id=62396

        * public/WebURLError.h:
        (WebKit::WebURLError::WebURLError):
        * src/WebURLError.cpp:
        (WebKit::WebURLError::operator=):
        (WebKit::WebURLError::operator ResourceError):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 David Grogan <dgrogan@chromium.org>
pfeldman@chromium.org [Fri, 24 Jun 2011 08:24:16 +0000 (08:24 +0000)]
2011-06-24  David Grogan  <dgrogan@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [REGRESSION r86838] line numbers do not scroll when script paused
        https://bugs.webkit.org/show_bug.cgi?id=61653

        roll out r86838

        No new tests - refactoring.

        * dom/Document.h:
        * dom/EventQueue.cpp:
        (WebCore::EventQueueTimer::EventQueueTimer):
        (WebCore::EventQueueTimer::fired):
        (WebCore::EventQueue::create):
        (WebCore::EventQueue::EventQueue):
        (WebCore::EventQueue::~EventQueue):
        (WebCore::EventQueue::enqueueEvent):
        (WebCore::EventQueue::cancelEvent):
        (WebCore::EventQueue::cancelQueuedEvents):
        (WebCore::EventQueue::pendingEventTimerFired):
        (WebCore::EventQueue::dispatchEvent):
        * dom/EventQueue.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Fri, 24 Jun 2011 08:02:11 +0000 (08:02 +0000)]
2011-06-24  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [refactoring] extension tests: replace dispatchOnFrontend with a more generic evaluateOnFrontend()
        https://bugs.webkit.org/show_bug.cgi?id=63160

        * http/tests/inspector/extensions-test.js:
        (initialize_ExtensionsTest.InspectorTest._replyToExtension):
        (initialize_ExtensionsTest):
        * http/tests/inspector/resources/extension-main.html:
        * http/tests/inspector/resources/extension-main.js:
        (onError):
        (onTestsDone):
        * inspector/extensions/extensions-audits-tests.js:
        (extension_runAudits):
        (initialize_ExtensionsAuditsTest.InspectorTest.startExtensionAudits.onAuditsDone):
        (initialize_ExtensionsAuditsTest.InspectorTest.startExtensionAudits):
        (initialize_ExtensionsAuditsTest):
        * inspector/extensions/extensions-events.html:
        * inspector/extensions/extensions.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Fri, 24 Jun 2011 07:43:38 +0000 (07:43 +0000)]
2011-06-24  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r89594.
        http://trac.webkit.org/changeset/89594
        https://bugs.webkit.org/show_bug.cgi?id=63316

        It broke 5 tests on the Qt bot (Requested by Ossy_DC on
        #webkit).

        * GNUmakefile.list.am:
        * JavaScriptCore.gypi:
        * icu/unicode/uscript.h: Removed.
        * wtf/unicode/ScriptCodesFromICU.h: Removed.
        * wtf/unicode/brew/UnicodeBrew.h:
        * wtf/unicode/glib/UnicodeGLib.h:
        * wtf/unicode/icu/UnicodeIcu.h:
        * wtf/unicode/qt4/UnicodeQt4.h:
        * wtf/unicode/wince/UnicodeWinCE.h:
2011-06-24  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r89594.
        http://trac.webkit.org/changeset/89594
        https://bugs.webkit.org/show_bug.cgi?id=63316

        It broke 5 tests on the Qt bot (Requested by Ossy_DC on
        #webkit).

        * icu/unicode/uscript.h: Removed.
2011-06-24  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r89594.
        http://trac.webkit.org/changeset/89594
        https://bugs.webkit.org/show_bug.cgi?id=63316

        It broke 5 tests on the Qt bot (Requested by Ossy_DC on
        #webkit).

        * WebCore.exp.in:
        * icu/unicode/uscript.h:
        * page/Settings.cpp:
        (WebCore::Settings::setStandardFontFamily):
        (WebCore::Settings::setFixedFontFamily):
        (WebCore::Settings::setSerifFontFamily):
        (WebCore::Settings::setSansSerifFontFamily):
        (WebCore::Settings::setCursiveFontFamily):
        (WebCore::Settings::setFantasyFontFamily):
        * page/Settings.h:
        (WebCore::Settings::standardFontFamily):
        (WebCore::Settings::fixedFontFamily):
        (WebCore::Settings::serifFontFamily):
        (WebCore::Settings::sansSerifFontFamily):
        (WebCore::Settings::cursiveFontFamily):
        (WebCore::Settings::fantasyFontFamily):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Fri, 24 Jun 2011 07:09:35 +0000 (07:09 +0000)]
2011-06-24  Carlos Garcia Campos  <cgarcia@igalia.com>

        Unreviewed. Fix WebKit2 GTK build.

        * WebKitTestRunner/GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 24 Jun 2011 06:43:34 +0000 (06:43 +0000)]
2011-06-23  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        Pass Strings by const reference in bindings code
        https://bugs.webkit.org/show_bug.cgi?id=63302

        Note that since Strings hold a RefPtr to StringImpl, passing Strings
        by value isn't horrible, but it does cause ref count churn and using
        const references is more consistent with the rest of the code base.

        * bindings/generic/BindingSecurity.h:
        (WebCore::::allowSettingFrameSrcToJavascriptUrl):
        (WebCore::::allowSettingSrcToJavascriptURL):
        * bindings/js/SerializedScriptValue.cpp:
        (WebCore::CloneSerializer::serialize):
        (WebCore::SerializedScriptValue::create):
        * bindings/js/SerializedScriptValue.h:
        * bindings/v8/SerializedScriptValue.cpp:
        (WebCore::SerializedScriptValue::createFromWire):
        (WebCore::SerializedScriptValue::create):
        (WebCore::SerializedScriptValue::SerializedScriptValue):
        * bindings/v8/SerializedScriptValue.h:
        * bindings/v8/V8Binding.h:
        (WebCore::V8ParameterBase::setString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Fri, 24 Jun 2011 05:42:25 +0000 (05:42 +0000)]
2011-06-23  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        [Chromium] Web Inspector: provide context menu item for enabling native worker inspection
        https://bugs.webkit.org/show_bug.cgi?id=63258

        Added context menu checkbox item that allows to enable inspection of
        native workers. The value will be persisted as other inspector settings
        and will be restored after frontend/breowser reopening.

        * inspector/Inspector.json:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::restoreInspectorStateFromCookie):
        * inspector/InspectorInstrumentation.h:
        (WebCore::InspectorInstrumentation::didStartWorkerContext):
        * inspector/InspectorWorkerAgent.cpp:
        (WebCore::InspectorWorkerAgent::setFrontend):
        (WebCore::InspectorWorkerAgent::restore):
        (WebCore::InspectorWorkerAgent::setWorkerInspectionEnabled):
        * inspector/InspectorWorkerAgent.h:
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        (WebInspector.ScriptsPanel.prototype.reset):
        (WebInspector.ScriptsPanel.prototype._toggleFormatSourceFiles):
        (WebInspector.ScriptsPanel.prototype._contextMenu.enableWorkerInspection):
        (WebInspector.ScriptsPanel.prototype._contextMenu):
        * inspector/front-end/Settings.js:
        (WebInspector.Settings):
        * inspector/front-end/inspector.js:
        (WebInspector.didCreateWorker):
        (WebInspector.didDestroyWorker):
        * workers/Worker.cpp:
        (WebCore::Worker::notifyFinished):
2011-06-23  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        [Chromium] Web Inspector: provide context menu item for enabling native worker inspection
        https://bugs.webkit.org/show_bug.cgi?id=63258

        * src/js/DevTools.js:
        ():

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 24 Jun 2011 05:30:29 +0000 (05:30 +0000)]
2011-06-23  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Need to turn off default animations for anchorPointZ in PlatformCALayer
        https://bugs.webkit.org/show_bug.cgi?id=63159

        When the z-component of transform-origin changed, we ran an implicit
        animation of anchorPointZ on the CALayer. Turn this off.

        Test: transforms/3d/general/transform-origin-z-change.html

        * platform/graphics/ca/mac/PlatformCALayerMac.mm:
        (nullActionsDictionary):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Zhenyao Mo <zmo@google.com>
zmo@google.com [Fri, 24 Jun 2011 01:53:29 +0000 (01:53 +0000)]
2011-06-23  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Limit WebGL internal drawingBuffer size to 4k x 4k
        https://bugs.webkit.org/show_bug.cgi?id=63304

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::reshape): Limit drawing buffer size to 4k x 4k.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-20 MORITA Hajime <morrita@google.com>
morrita@google.com [Fri, 24 Jun 2011 01:35:30 +0000 (01:35 +0000)]
2011-06-20  MORITA Hajime <morrita@google.com>

        Reviewed by Dimitri Glazkov.

        [ShadowContentElement] should layout child whitespace between span.
        https://bugs.webkit.org/show_bug.cgi?id=62202

        - Added a new test case.
        - Updated expectations, which missed necessary RnederText objects.

        * platform/chromium-win/fast/html/details-add-child-2-expected.txt:
        * platform/chromium-win/fast/html/details-add-details-child-2-expected.txt:
        * platform/chromium-win/fast/html/details-no-summary4-expected.txt:
        * platform/chromium-win/fast/html/details-open-javascript-expected.txt:
        * platform/chromium-win/fast/html/details-open2-expected.txt:
        * platform/chromium-win/fast/html/details-open4-expected.txt:
        * platform/chromium-win/fast/html/details-remove-child-2-expected.txt:
        * platform/chromium-win/fast/html/details-replace-text-expected.txt:
        * platform/gtk/fast/html/details-add-child-2-expected.txt:
        * platform/gtk/fast/html/details-add-details-child-2-expected.txt:
        * platform/gtk/fast/html/details-no-summary4-expected.txt:
        * platform/gtk/fast/html/details-open-javascript-expected.txt:
        * platform/gtk/fast/html/details-open2-expected.txt:
        * platform/gtk/fast/html/details-open4-expected.txt:
        * platform/gtk/fast/html/details-remove-child-2-expected.txt:
        * platform/gtk/fast/html/details-replace-text-expected.txt:
        * platform/mac/fast/html/details-add-child-2-expected.txt:
        * platform/mac/fast/html/details-add-details-child-2-expected.txt:
        * platform/mac/fast/html/details-no-summary4-expected.txt:
        * platform/mac/fast/html/details-open-javascript-expected.txt:
        * platform/mac/fast/html/details-open2-expected.txt:
        * platform/mac/fast/html/details-open4-expected.txt:
        * platform/mac/fast/html/details-remove-child-2-expected.txt:
        * platform/mac/fast/html/details-replace-text-expected.txt:
        * platform/qt/fast/html/details-add-child-2-expected.txt:
        * platform/qt/fast/html/details-add-details-child-2-expected.txt:
        * platform/qt/fast/html/details-no-summary4-expected.txt:
        * platform/qt/fast/html/details-open-javascript-expected.txt:
        * platform/qt/fast/html/details-open2-expected.txt:
        * platform/qt/fast/html/details-open4-expected.txt:
        * platform/qt/fast/html/details-remove-child-2-expected.txt:
        * platform/qt/fast/html/details-replace-text-expected.txt:
        * fast/dom/shadow/create-content-element-expected.txt: Added.
        * fast/dom/shadow/create-content-element.html: Added.
2011-06-20  MORITA Hajime  <morrita@google.com>

        Reviewed by Dimitri Glazkov.

        [ShadowContentElement] should layout child whitespace between span.
        https://bugs.webkit.org/show_bug.cgi?id=62202

        NodeRenderingContext::nextRenderer() and previousRenderer()
        ignored forwarded content tree hierarchies and used render-object
        hierarchies instead, that caused some wrong Text node rendering.

        This change uses ShadowContentElement::m_inclusions for the lookup.
        In this way, these methods can reflect hierarchies of forward light tree.

        * dom/NodeRenderingContext.cpp:
        (WebCore::NodeRenderingContext::NodeRenderingContext):
        (WebCore::nextRendererOf): Added. This traverses content element's children for searching neighboring renderer.
        (WebCore::previousRendererOf): Added. This traverses content element's children for searching neighboring renderer.
        (WebCore::NodeRenderingContext::nextRenderer):
        (WebCore::NodeRenderingContext::previousRenderer):
        * dom/NodeRenderingContext.h:
        * dom/ShadowContentElement.h:
        (ShadowContentElement::inclusionIndexOf): Added.
        * dom/ShadowContentSelector.cpp:
        (WebCore::ShadowContentSelector::activeElement):
        * dom/ShadowContentSelector.h:
        * dom/ShadowRoot.cpp:
        (WebCore::ShadowRoot::activeContentElement):
        * dom/ShadowRoot.h:
        * rendering/RenderTreeAsText.cpp:
        (WebCore::externalRepresentation): Fixed an apparent bug introduced at r89230.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Ryuan Choi <ryuan.choi@samsung.com>
ryuan.choi@samsung.com [Fri, 24 Jun 2011 01:22:33 +0000 (01:22 +0000)]
2011-06-23  Ryuan Choi  <ryuan.choi@samsung.com>

        Unreviewed, add myself as committer.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-25 James Robinson <jamesr@chromium.org>
jamesr@google.com [Fri, 24 Jun 2011 01:17:38 +0000 (01:17 +0000)]
2011-05-25  James Robinson  <jamesr@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Fix ownership of PlatformImage for ImageLayerChromiums
        https://bugs.webkit.org/show_bug.cgi?id=61099

        For a composited image, both the ImageLayerChromium and its associated LayerTilerChromium need access to a
        PlatformImage - the ImageLayerChromium has to update the PlatformImage's contents and the LayerTilerChromium has
        to upload pixels from it.  This patch makes the ImageLayerTextureUpdater have exclusive ownership of the
        PlatformImage and moves ownership of the LayerTextureUpdater from the LayerTilerChromium to the owner of the
        tiler.  The updater is passed in as a parameter to the relevant tiler calls.

        Patch also fixes a number of minor style issues (missing explicit keyword on constructor, etc).

        Refactor only, no new tests.

        * platform/graphics/chromium/ContentLayerChromium.cpp:
        (WebCore::ContentLayerPainter::create):
        (WebCore::ContentLayerPainter::ContentLayerPainter):
        (WebCore::ContentLayerChromium::paintContentsIfDirty):
        (WebCore::ContentLayerChromium::createTextureUpdaterIfNeeded):
        (WebCore::ContentLayerChromium::draw):
        (WebCore::ContentLayerChromium::createTilerIfNeeded):
        (WebCore::ContentLayerChromium::updateCompositorResources):
        * platform/graphics/chromium/ContentLayerChromium.h:
        * platform/graphics/chromium/ImageLayerChromium.cpp:
        (WebCore::ImageLayerTextureUpdater::create):
        (WebCore::ImageLayerTextureUpdater::updateFromImage):
        (WebCore::ImageLayerTextureUpdater::imageSize):
        (WebCore::ImageLayerTextureUpdater::ImageLayerTextureUpdater):
        (WebCore::ImageLayerChromium::~ImageLayerChromium):
        (WebCore::ImageLayerChromium::paintContentsIfDirty):
        (WebCore::ImageLayerChromium::updateCompositorResources):
        (WebCore::ImageLayerChromium::setLayerRenderer):
        (WebCore::ImageLayerChromium::createTextureUpdaterIfNeeded):
        (WebCore::ImageLayerChromium::layerBounds):
        * platform/graphics/chromium/ImageLayerChromium.h:
        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::LayerRendererChromium):
        (WebCore::LayerRendererChromium::updateRootLayerContents):
        (WebCore::LayerRendererChromium::drawRootLayer):
        (WebCore::LayerRendererChromium::updateLayers):
        * platform/graphics/chromium/LayerRendererChromium.h:
        * platform/graphics/chromium/LayerTextureUpdater.h:
        (WebCore::LayerTextureUpdater::LayerTextureUpdater):
        * platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
        (WebCore::LayerTextureUpdaterBitmap::create):
        (WebCore::LayerTextureUpdaterSkPicture::create):
        * platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
        * platform/graphics/chromium/LayerTilerChromium.cpp:
        (WebCore::LayerTilerChromium::create):
        (WebCore::LayerTilerChromium::LayerTilerChromium):
        (WebCore::LayerTilerChromium::prepareToUpdate):
        (WebCore::LayerTilerChromium::updateRect):
        (WebCore::LayerTilerChromium::draw):
        * platform/graphics/chromium/LayerTilerChromium.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Nat Duca <nduca@chromium.org>
nduca@chromium.org [Fri, 24 Jun 2011 01:11:29 +0000 (01:11 +0000)]
2011-06-23  Nat Duca  <nduca@chromium.org>

        Unreviewed, add myself as committer.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Adrienne Walker <enne@google.com>
enne@google.com [Fri, 24 Jun 2011 00:59:47 +0000 (00:59 +0000)]
2011-06-23  Adrienne Walker  <enne@google.com>

        Unreviewed, rolling out r89632 and r89640.
        http://trac.webkit.org/changeset/89632
        http://trac.webkit.org/changeset/89640
        https://bugs.webkit.org/show_bug.cgi?id=60741

        Breaks ancestor-overflow-change unexpectedly

        * compositing/rtl/rtl-absolute-expected.png: Removed.
        * compositing/rtl/rtl-absolute-expected.txt: Removed.
        * compositing/rtl/rtl-absolute-overflow-expected.png: Removed.
        * compositing/rtl/rtl-absolute-overflow-expected.txt: Removed.
        * compositing/rtl/rtl-absolute-overflow-scrolled-expected.png: Removed.
        * compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt: Removed.
        * compositing/rtl/rtl-absolute-overflow-scrolled.html: Removed.
        * compositing/rtl/rtl-absolute-overflow.html: Removed.
        * compositing/rtl/rtl-absolute.html: Removed.
        * compositing/rtl/rtl-fixed-expected.png: Removed.
        * compositing/rtl/rtl-fixed-expected.txt: Removed.
        * compositing/rtl/rtl-fixed-overflow-expected.png: Removed.
        * compositing/rtl/rtl-fixed-overflow-expected.txt: Removed.
        * compositing/rtl/rtl-fixed-overflow-scrolled-expected.png: Removed.
        * compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt: Removed.
        * compositing/rtl/rtl-fixed-overflow-scrolled.html: Removed.
        * compositing/rtl/rtl-fixed-overflow.html: Removed.
        * compositing/rtl/rtl-fixed.html: Removed.
        * compositing/rtl/rtl-iframe-absolute-expected.png: Removed.
        * compositing/rtl/rtl-iframe-absolute-expected.txt: Removed.
        * compositing/rtl/rtl-iframe-absolute-overflow-expected.png: Removed.
        * compositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Removed.
        * compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.png: Removed.
        * compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Removed.
        * compositing/rtl/rtl-iframe-absolute-overflow-scrolled.html: Removed.
        * compositing/rtl/rtl-iframe-absolute-overflow.html: Removed.
        * compositing/rtl/rtl-iframe-absolute.html: Removed.
        * compositing/rtl/rtl-iframe-fixed-expected.png: Removed.
        * compositing/rtl/rtl-iframe-fixed-expected.txt: Removed.
        * compositing/rtl/rtl-iframe-fixed-overflow-expected.png: Removed.
        * compositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Removed.
        * compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.png: Removed.
        * compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Removed.
        * compositing/rtl/rtl-iframe-fixed-overflow-scrolled.html: Removed.
        * compositing/rtl/rtl-iframe-fixed-overflow.html: Removed.
        * compositing/rtl/rtl-iframe-fixed.html: Removed.
        * compositing/rtl/rtl-iframe-relative-expected.png: Removed.
        * compositing/rtl/rtl-iframe-relative-expected.txt: Removed.
        * compositing/rtl/rtl-iframe-relative.html: Removed.
        * compositing/rtl/rtl-relative-expected.png: Removed.
        * compositing/rtl/rtl-relative-expected.txt: Removed.
        * compositing/rtl/rtl-relative.html: Removed.
        * platform/chromium/test_expectations.txt:
        * platform/mac/Skipped:
2011-06-23  Adrienne Walker  <enne@google.com>

        Unreviewed, rolling out r89632 and r89640.
        http://trac.webkit.org/changeset/89632
        http://trac.webkit.org/changeset/89640
        https://bugs.webkit.org/show_bug.cgi?id=60741

        Breaks ancestor-overflow-change unexpectedly

        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Wyatt Carss <wcarss@chromium.org>
commit-queue@webkit.org [Fri, 24 Jun 2011 00:51:20 +0000 (00:51 +0000)]
2011-06-23  Wyatt Carss  <wcarss@chromium.org>

        Reviewed by Ryosuke Niwa.

        convert editing/deleting/5026848-1.html to dump-as-markup test
        https://bugs.webkit.org/show_bug.cgi?id=63289

        Renamed editing/deleting/5026848* to editing/deleting/delete-across-editable-content-boundaries*,
        and converted editing/deleting/delete-across-editable-content-boundaries-1 to a dump-as-markup test.
        Removed old png/txt test results, and added new result. Also included radr number.

        * editing/deleting/delete-across-editable-content-boundaries-1.html: Added.
        * editing/deleting/delete-across-editable-content-boundaries-1-expected.txt: Added.
        * editing/deleting/delete-across-editable-content-boundaries-2.html: Added.
        * editing/deleting/delete-across-editable-content-boundaries-2-expected.txt: Added.
        * editing/deleting/delete-across-editable-content-boundaries-3.html: Added.
        * editing/deleting/delete-across-editable-content-boundaries-3-expected.txt: Added.
        * editing/deleting/5026848-1.html: Removed.
        * editing/deleting/5026848-2.html: Removed.
        * editing/deleting/5026848-2-expected.txt: Removed.
        * editing/deleting/5026848-3.html: Removed.
        * editing/deleting/5026848-3-expected.txt: Removed.
        * platform/chromium-linux/editing/deleting/5026848-1-expected.png: Removed.
        * platform/chromium-win/editing/deleting/5026848-1-expected.png: Removed.
        * platform/chromium-win/editing/deleting/5026848-1-expected.txt: Removed.
        * platform/gtk/editing/deleting/5026848-1-expected.txt: Removed.
        * platform/mac-leopard/editing/deleting/5026848-1-expected.png: Removed.
        * platform/mac/editing/deleting/5026848-1-expected.png: Removed.
        * platform/mac/editing/deleting/5026848-1-expected.txt: Removed.
        * platform/qt/editing/deleting/5026848-1-expected.png: Removed.
        * platform/qt/editing/deleting/5026848-1-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Filip Pizlo <fpizlo@apple.com>
commit-queue@webkit.org [Fri, 24 Jun 2011 00:40:18 +0000 (00:40 +0000)]
2011-06-23  Filip Pizlo  <fpizlo@apple.com>

        Reviewed by Gavin Barraclough.

        DFG non-speculative JIT should have obvious optimizations for GetById and GetByVal
        https://bugs.webkit.org/show_bug.cgi?id=63173

        * dfg/DFGJITCodeGenerator.cpp:
        (JSC::DFG::JITCodeGenerator::cachedGetById):
        * dfg/DFGJITCodeGenerator.h:
        * dfg/DFGNonSpeculativeJIT.cpp:
        (JSC::DFG::NonSpeculativeJIT::compile):
        * dfg/DFGSpeculativeJIT.cpp:
        (JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 24 Jun 2011 00:33:42 +0000 (00:33 +0000)]
2011-06-23  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Tony Chang.

        nrwt: move http locking code into manager
        https://bugs.webkit.org/show_bug.cgi?id=63103

        * Scripts/webkitpy/layout_tests/layout_package/manager.py:
        * Scripts/webkitpy/layout_tests/layout_package/worker.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix Qt again.
oliver@apple.com [Fri, 24 Jun 2011 00:28:54 +0000 (00:28 +0000)]
Fix Qt again.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Adrienne Walker <enne@google.com>
enne@google.com [Fri, 24 Jun 2011 00:22:13 +0000 (00:22 +0000)]
2011-06-23  Adrienne Walker  <enne@google.com>

        [chromium] Unreviewed, mark a few tests failing on OSX after r89632.
        https://bugs.webkit.org/show_bug.cgi?id=60741

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 24 Jun 2011 00:19:15 +0000 (00:19 +0000)]
2011-06-23  Ryosuke Niwa  <rniwa@webkit.org>

        GTK Rebaseline after r89627.

        * platform/gtk/editing/selection/extend-inside-transforms-backward-expected.png: Added.
        * platform/gtk/editing/selection/extend-inside-transforms-backward-expected.txt: Added.
        * platform/gtk/editing/selection/extend-inside-transforms-forward-expected.png: Added.
        * platform/gtk/editing/selection/extend-inside-transforms-forward-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix Qt Build
oliver@apple.com [Fri, 24 Jun 2011 00:18:23 +0000 (00:18 +0000)]
Fix Qt Build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=63298
slewis@apple.com [Fri, 24 Jun 2011 00:16:47 +0000 (00:16 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=63298
Replace Malloc with FastMalloc to match the rest of wtf.

Reviewed by Darin Adler.

* wtf/BlockStack.h:
(WTF::::~BlockStack):
(WTF::::grow):
(WTF::::shrink):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWKTR: eventSender.keyDown is unimplemented
jberlin@webkit.org [Fri, 24 Jun 2011 00:15:26 +0000 (00:15 +0000)]
WKTR: eventSender.keyDown is unimplemented
https://bugs.webkit.org/show_bug.cgi?id=57515

Add another test that uses eventSender.keyDown to the mac-wk2 skipped list.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 John Bates <jbates@google.com>
commit-queue@webkit.org [Fri, 24 Jun 2011 00:11:51 +0000 (00:11 +0000)]
2011-06-23  John Bates  <jbates@google.com>

        Reviewed by James Robinson.

        Fix latch deadlock when GPU process crashes or context is lost.
        https://bugs.webkit.org/show_bug.cgi?id=63189
        The main bug fix is to only set/wait latches if the child context has no errors.
        Additionally, the LayerChromium classes needed to be modified to not continue drawing when
        their corresponding contexts have errors. Otherwise, they would draw with invalid texture ids.

        Test: open particles WebGL demo in chrome, kill GPU process from Task Manager; observe no deadlock.

        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::LayerRendererChromium):
        (WebCore::LayerRendererChromium::updateAndDrawLayers):
        (WebCore::LayerRendererChromium::updateLayers):
        (WebCore::LayerRendererChromium::isCompositorContextLost):
        * platform/graphics/chromium/LayerRendererChromium.h:
        * platform/graphics/chromium/WebGLLayerChromium.cpp:
        (WebCore::WebGLLayerChromium::drawsContent):
        (WebCore::WebGLLayerChromium::updateCompositorResources):
        (WebCore::WebGLLayerChromium::setContext):
        * platform/graphics/chromium/WebGLLayerChromium.h:
        * platform/graphics/chromium/Canvas2DLayerChromium.cpp:
        (WebCore::Canvas2DLayerChromium::drawsContent):
        * platform/graphics/chromium/Canvas2DLayerChromium.h:
2011-06-23  John Bates  <jbates@google.com>

        Reviewed by James Robinson.

        Fix latch deadlock when GPU process crashes or context is lost
        https://bugs.webkit.org/show_bug.cgi?id=63189

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::composite):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Alok Priyadarshi <alokp@chromium.org>
alokp@chromium.org [Thu, 23 Jun 2011 23:47:39 +0000 (23:47 +0000)]
2011-06-23  Alok Priyadarshi  <alokp@chromium.org>

        Reviewed by James Robinson.

        [chromium] Red and Blue channels are swapped in images with accelerated drawing
        https://bugs.webkit.org/show_bug.cgi?id=61442

        We were uploading BGRA pixels into RGBA textures and swapping the components in the pixel shader.
        This strategy does not work with accelerated drawing because we are directly rendering to the texture, not uploading pixels.
        This patch uses BGRA textures if available. If not it falls back to the original scheme of swapping the components in the pixel shader.

        Tests: compositing/color-matching/image-color-matching.html (existing)

        * WebCore.gypi:
        * platform/graphics/chromium/ImageLayerChromium.cpp:
        (WebCore::ImageLayerTextureUpdater::sampledTexelFormat):
        (WebCore::ImageLayerTextureUpdater::updateTextureRect):
        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::LayerRendererChromium):
        (WebCore::LayerRendererChromium::skiaContext):
        (WebCore::LayerRendererChromium::tilerProgram):
        (WebCore::LayerRendererChromium::tilerProgramSwizzle):
        (WebCore::LayerRendererChromium::cleanupSharedObjects):
        * platform/graphics/chromium/LayerRendererChromium.h:
        * platform/graphics/chromium/LayerTexture.h:
        (WebCore::LayerTexture::format):
        * platform/graphics/chromium/LayerTextureSubImage.cpp:
        (WebCore::LayerTextureSubImage::upload):
        (WebCore::LayerTextureSubImage::uploadWithTexSubImage):
        (WebCore::LayerTextureSubImage::uploadWithMapTexSubImage):
        * platform/graphics/chromium/LayerTextureSubImage.h:
        * platform/graphics/chromium/LayerTextureUpdater.h:
        * platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
        (WebCore::LayerTextureUpdaterBitmap::sampledTexelFormat):
        (WebCore::LayerTextureUpdaterBitmap::updateTextureRect):
        (WebCore::LayerTextureUpdaterSkPicture::sampledTexelFormat):
        (WebCore::LayerTextureUpdaterSkPicture::createFrameBuffer):
        * platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
        * platform/graphics/chromium/LayerTilerChromium.cpp:
        (WebCore::LayerTilerChromium::LayerTilerChromium):
        (WebCore::LayerTilerChromium::prepareToUpdate):
        (WebCore::LayerTilerChromium::updateRect):
        (WebCore::LayerTilerChromium::draw):
        (WebCore::LayerTilerChromium::growLayerToContain):
        (WebCore::LayerTilerChromium::drawTiles):
        (WebCore::LayerTilerChromium::drawTexturedQuad):
        * platform/graphics/chromium/LayerTilerChromium.h:
        * platform/graphics/chromium/PlatformColor.h: Added.
        (WebCore::PlatformColor::format):
        (WebCore::PlatformColor::bestTextureFormat):
        (WebCore::PlatformColor::sameComponentOrder):
        * platform/graphics/chromium/ShaderChromium.cpp:
        (WebCore::FragmentShaderRGBATexSwizzleAlpha::getShaderString):
        * platform/graphics/chromium/ShaderChromium.h:
        * platform/graphics/chromium/cc/CCHeadsUpDisplay.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoQt build-fix: remove warning that no other platform appears to use.
oliver@apple.com [Thu, 23 Jun 2011 23:19:45 +0000 (23:19 +0000)]
Qt build-fix: remove warning that no other platform appears to use.
Someone can add it back if they really feel it's needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Adrienne Walker <enne@google.com>
enne@google.com [Thu, 23 Jun 2011 23:13:55 +0000 (23:13 +0000)]
2011-06-23  Adrienne Walker  <enne@google.com>

        Reviewed by Simon Fraser.

        Incorrect RenderLayer transforms on overflow RTL pages
        https://bugs.webkit.org/show_bug.cgi?id=60741

        Add a number of composited positioning tests on pages with dir=rtl.
        The reference images are all identical to what the non-composited path
        generates.

        The overflow-scrolled tests on Safari do not generate the right images
        due to bug 63284, but the layer tree is correct so they are not
        skipped.

        * compositing/rtl/rtl-absolute-expected.png: Added.
        * compositing/rtl/rtl-absolute-expected.txt: Added.
        * compositing/rtl/rtl-absolute-overflow-expected.png: Added.
        * compositing/rtl/rtl-absolute-overflow-expected.txt: Added.
        * compositing/rtl/rtl-absolute-overflow-scrolled-expected.png: Added.
        * compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt: Added.
        * compositing/rtl/rtl-absolute-overflow-scrolled.html: Added.
        * compositing/rtl/rtl-absolute-overflow.html: Added.
        * compositing/rtl/rtl-absolute.html: Added.
        * compositing/rtl/rtl-fixed-expected.png: Added.
        * compositing/rtl/rtl-fixed-expected.txt: Added.
        * compositing/rtl/rtl-fixed-overflow-expected.png: Added.
        * compositing/rtl/rtl-fixed-overflow-expected.txt: Added.
        * compositing/rtl/rtl-fixed-overflow-scrolled-expected.png: Added.
        * compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt: Added.
        * compositing/rtl/rtl-fixed-overflow-scrolled.html: Added.
        * compositing/rtl/rtl-fixed-overflow.html: Added.
        * compositing/rtl/rtl-fixed.html: Added.
        * compositing/rtl/rtl-iframe-absolute-expected.png: Added.
        * compositing/rtl/rtl-iframe-absolute-expected.txt: Added.
        * compositing/rtl/rtl-iframe-absolute-overflow-expected.png: Added.
        * compositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Added.
        * compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.png: Added.
        * compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Added.
        * compositing/rtl/rtl-iframe-absolute-overflow-scrolled.html: Added.
        * compositing/rtl/rtl-iframe-absolute-overflow.html: Added.
        * compositing/rtl/rtl-iframe-absolute.html: Added.
        * compositing/rtl/rtl-iframe-fixed-expected.png: Added.
        * compositing/rtl/rtl-iframe-fixed-expected.txt: Added.
        * compositing/rtl/rtl-iframe-fixed-overflow-expected.png: Added.
        * compositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Added.
        * compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.png: Added.
        * compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Added.
        * compositing/rtl/rtl-iframe-fixed-overflow-scrolled.html: Added.
        * compositing/rtl/rtl-iframe-fixed-overflow.html: Added.
        * compositing/rtl/rtl-iframe-fixed.html: Added.
        * compositing/rtl/rtl-iframe-relative-expected.png: Added.
        * compositing/rtl/rtl-iframe-relative-expected.txt: Added.
        * compositing/rtl/rtl-iframe-relative.html: Added.
        * compositing/rtl/rtl-relative-expected.png: Added.
        * compositing/rtl/rtl-relative-expected.txt: Added.
        * compositing/rtl/rtl-relative.html: Added.
        * compositing/rtlclipping/rtl-absolute-overflow-scrolled-expected.png: Added.
        * compositing/rtlclipping/rtl-absolute-overflow-scrolled-expected.txt: Added.
        * compositing/rtlclipping/rtl-absolute-overflow-scrolled.html: Added.
        * platform/chromium/test_expectations.txt:
        * platform/mac/Skipped:
2011-06-23  Adrienne Walker  <enne@google.com>

        Reviewed by Simon Fraser.

        Incorrect RenderLayer transforms on overflow RTL pages
        https://bugs.webkit.org/show_bug.cgi?id=60741

        Fix positioning of the root graphics layer for RTL pages.  The fact
        that the left side of the page is negative for pages with overflow is
        not taken into account when calculating the position.  This negative
        value ends up being double-counted for the root graphics layer (once
        in the position and once in the offset) and it shifts child layers
        into the wrong place.

        Tests: compositing/rtl/rtl-absolute-overflow-scrolled.html
               compositing/rtl/rtl-absolute-overflow.html
               compositing/rtl/rtl-absolute.html
               compositing/rtl/rtl-fixed-overflow-scrolled.html
               compositing/rtl/rtl-fixed-overflow.html
               compositing/rtl/rtl-fixed.html
               compositing/rtl/rtl-iframe-absolute-overflow-scrolled.html
               compositing/rtl/rtl-iframe-absolute-overflow.html
               compositing/rtl/rtl-iframe-absolute.html
               compositing/rtl/rtl-iframe-fixed-overflow-scrolled.html
               compositing/rtl/rtl-iframe-fixed-overflow.html
               compositing/rtl/rtl-iframe-fixed.html
               compositing/rtl/rtl-iframe-relative.html
               compositing/rtl/rtl-relative.html

        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agocompositing/tiling/huge-layer* flakey
jberlin@webkit.org [Thu, 23 Jun 2011 23:00:01 +0000 (23:00 +0000)]
compositing/tiling/huge-layer* flakey
https://bugs.webkit.org/show_bug.cgi?id=48454

These tests have been flaking on multiple platforms, so disable the tests in order to get
the bots green.

* compositing/tiling/huge-layer-add-remove-child.html: Removed.
* compositing/tiling/huge-layer-add-remove-child.html-disabled: Copied from LayoutTests/compositing/tiling/huge-layer-add-remove-child.html.
* compositing/tiling/huge-layer-img.html: Removed.
* compositing/tiling/huge-layer-img.html-disabled: Copied from LayoutTests/compositing/tiling/huge-layer-img.html.
* compositing/tiling/huge-layer-resize.html: Removed.
* compositing/tiling/huge-layer-resize.html-disabled: Copied from LayoutTests/compositing/tiling/huge-layer-resize.html.
* compositing/tiling/huge-layer-with-layer-children-resize.html: Removed.
* compositing/tiling/huge-layer-with-layer-children-resize.html-disabled: Copied from LayoutTests/compositing/tiling/huge-layer-with-layer-children-resize.html.
* compositing/tiling/huge-layer-with-layer-children.html: Removed.
* compositing/tiling/huge-layer-with-layer-children.html-disabled: Copied from LayoutTests/compositing/tiling/huge-layer-with-layer-children.html.
* compositing/tiling/huge-layer.html: Removed.
* compositing/tiling/huge-layer.html-disabled: Copied from LayoutTests/compositing/tiling/huge-layer.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Thu, 23 Jun 2011 22:47:04 +0000 (22:47 +0000)]
2011-06-23  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Add the ability to dynamically modify linked call sites
        https://bugs.webkit.org/show_bug.cgi?id=63291

        Add JITWriteBarrier as a writebarrier class that allows
        reading and writing directly into the code stream.

        This required adding logic to all the assemblers to allow
        us to read values back out of the instruction stream.

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * assembler/ARMAssembler.h:
        (JSC::ARMAssembler::readPointer):
        * assembler/ARMv7Assembler.h:
        (JSC::ARMv7Assembler::readPointer):
        (JSC::ARMv7Assembler::readInt32):
        (JSC::ARMv7Assembler::decodeTwoWordOp5i6Imm4Reg4EncodedImmFirst):
        (JSC::ARMv7Assembler::decodeTwoWordOp5i6Imm4Reg4EncodedImmSecond):
        * assembler/AbstractMacroAssembler.h:
        (JSC::AbstractMacroAssembler::readPointer):
        * assembler/MIPSAssembler.h:
        (JSC::MIPSAssembler::readInt32):
        (JSC::MIPSAssembler::readPointer):
        * assembler/MacroAssemblerCodeRef.h:
        (JSC::MacroAssemblerCodePtr::operator!):
        * assembler/SH4Assembler.h:
        (JSC::SH4Assembler::readPCrelativeAddress):
        (JSC::SH4Assembler::readPointer):
        (JSC::SH4Assembler::readInt32):
        * assembler/X86Assembler.h:
        (JSC::X86Assembler::readPointer):
        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::visitAggregate):
        * bytecode/CodeBlock.h:
        (JSC::MethodCallLinkInfo::seenOnce):
        (JSC::MethodCallLinkInfo::setSeen):
        * heap/MarkStack.h:
        * jit/JIT.cpp:
        (JSC::JIT::privateCompile):
        (JSC::JIT::linkCall):
        (JSC::JIT::linkConstruct):
        * jit/JITPropertyAccess.cpp:
        (JSC::JIT::patchMethodCallProto):
        * jit/JITPropertyAccess32_64.cpp:
        * jit/JITWriteBarrier.h: Added.
        (JSC::JITWriteBarrierBase::operator UnspecifiedBoolType*):
        (JSC::JITWriteBarrierBase::operator!):
        (JSC::JITWriteBarrierBase::setFlagOnBarrier):
        (JSC::JITWriteBarrierBase::isFlagged):
        (JSC::JITWriteBarrierBase::setLocation):
        (JSC::JITWriteBarrierBase::location):
        (JSC::JITWriteBarrierBase::JITWriteBarrierBase):
        (JSC::JITWriteBarrierBase::set):
        (JSC::JITWriteBarrierBase::get):
        (JSC::JITWriteBarrier::JITWriteBarrier):
        (JSC::JITWriteBarrier::set):
        (JSC::JITWriteBarrier::get):
        (JSC::MarkStack::append):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agocompositing/iframes/invisible-nested-iframe-show.html failing on SnowLeopard Intel...
jberlin@webkit.org [Thu, 23 Jun 2011 22:35:48 +0000 (22:35 +0000)]
compositing/iframes/invisible-nested-iframe-show.html failing on SnowLeopard Intel Release
(WebKit2 Tests) since introduction.
https://bugs.webkit.org/show_bug.cgi?id=59864

Update the mac-wk2 results to contain the transform line and get the bots green.

* platform/mac-wk2/compositing/iframes/invisible-nested-iframe-show-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 23 Jun 2011 22:30:25 +0000 (22:30 +0000)]
2011-06-23  Ryosuke Niwa  <rniwa@webkit.org>

        Rolled DEPS.

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 23 Jun 2011 22:20:57 +0000 (22:20 +0000)]
2011-06-23  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Simon Fraser.

        Add a test for vertical caret movements inside transform
        https://bugs.webkit.org/show_bug.cgi?id=62834

        Add regression tests for vertical caret movements inside rotated contents.

        * editing/selection/extend-inside-transforms-backward.html: Added.
        * editing/selection/extend-inside-transforms-forward.html: Added.
        * platform/chromium/test_expectations.txt: Added test expectations to keep bots green
        until we rebaseline these tests on Chromium.
        * platform/mac/editing/selection/extend-inside-transforms-backward-expected.png: Added.
        * platform/mac/editing/selection/extend-inside-transforms-backward-expected.txt: Added.
        * platform/mac/editing/selection/extend-inside-transforms-forward-expected.png: Added.
        * platform/mac/editing/selection/extend-inside-transforms-forward-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Gregg Tavares <gman@google.com>
commit-queue@webkit.org [Thu, 23 Jun 2011 22:19:21 +0000 (22:19 +0000)]
2011-06-23  Gregg Tavares  <gman@google.com>

        Reviewed by Kenneth Russell.

        add test expectation fast/canvas/canvas-large-dimensions.html for new assert in command buffer.
        https://bugs.webkit.org/show_bug.cgi?id=63278

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Emil A Eklund <eae@chromium.org>
eae@chromium.org [Thu, 23 Jun 2011 22:15:00 +0000 (22:15 +0000)]
2011-06-23  Emil A Eklund  <eae@chromium.org>

        Reviewed by Eric Seidel.

        FloatRect should implement the same methods as IntRect
        https://bugs.webkit.org/show_bug.cgi?id=63273

        Add missing methods from IntRect to FloatRect in preparation for moving
        the rendering tree over to floats.

        * platform/graphics/FloatPoint.h:
        (WebCore::FloatPoint::expandedTo):
        (WebCore::FloatPoint::transposedPoint):
        * platform/graphics/FloatRect.h:
        (WebCore::FloatRect::move):
        (WebCore::FloatRect::expand):
        (WebCore::FloatRect::contract):
        (WebCore::FloatRect::shiftXEdgeTo):
        (WebCore::FloatRect::shiftMaxXEdgeTo):
        (WebCore::FloatRect::shiftYEdgeTo):
        (WebCore::FloatRect::shiftMaxYEdgeTo):
        (WebCore::FloatRect::minXMinYCorner):
        (WebCore::FloatRect::maxXMinYCorner):
        (WebCore::FloatRect::minXMaxYCorner):
        (WebCore::FloatRect::maxXMaxYCorner):
        (WebCore::FloatRect::transposedRect):
        * platform/graphics/FloatSize.h:
        (WebCore::FloatSize::expand):
        (WebCore::FloatSize::transposedSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Emil A Eklund <eae@chromium.org>
eae@chromium.org [Thu, 23 Jun 2011 22:13:30 +0000 (22:13 +0000)]
2011-06-23  Emil A Eklund  <eae@chromium.org>

        Reviewed by Dimitri Glazkov.

        input/textarea onchange doesn't fire if value is set in key listener
        https://bugs.webkit.org/show_bug.cgi?id=63092

        Add test for text field onchange when setting the value in a key listener.

        * fast/events/onchange-setvalue-expected.txt: Added.
        * fast/events/onchange-setvalue.html: Added.
2011-06-23  Emil A Eklund  <eae@chromium.org>

        Reviewed by Darin Adler.

        input/textarea onchange doesn't fire if value is set in key listener
        https://bugs.webkit.org/show_bug.cgi?id=63092

        Change setValue implementation of HTMLInputElement and HTMLTextAreaElement to
        not call setTextAsOfLastFormControlChangeEvent unless the value truly changed.
        Thus element.value = element.value will no longer reset the state
        m_textAsOfLastFormControlChangeEvent field and suppress the change event.

        Test: fast/events/onchange-setvalue.html

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::setValue):
        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::setValue):
        (WebCore::HTMLTextAreaElement::setNonDirtyValue):
        (WebCore::HTMLTextAreaElement::setValueCommon):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Wyatt Carss <wcarss@chromium.org>
commit-queue@webkit.org [Thu, 23 Jun 2011 22:11:50 +0000 (22:11 +0000)]
2011-06-23  Wyatt Carss  <wcarss@chromium.org>

        Reviewed by Ryosuke Niwa.

        convert editing/deleting/delete-select-all-00* to dumpAsText
        https://bugs.webkit.org/show_bug.cgi?id=63193

        converted editing/deleting/delete-select-all-002/003 to
        runDumpAsTextEditingTest(true), removed old test files (including a
        superfluous expected file for 001 on qt), and added new test files.

        * editing/deleting/delete-select-all-002-expected.txt: Added.
        * editing/deleting/delete-select-all-002.html:
        * editing/deleting/delete-select-all-003-expected.txt: Added.
        * editing/deleting/delete-select-all-003.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Windows Tests] http/tests/media/video-cross-site.html sometimes crashes.
jberlin@webkit.org [Thu, 23 Jun 2011 22:04:37 +0000 (22:04 +0000)]
[Windows Tests] http/tests/media/video-cross-site.html sometimes crashes.
https://bugs.webkit.org/show_bug.cgi?id=62024

Skip the test on Windows to get the bots green.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Joe Wild <joseph.wild@nokia.com>
commit-queue@webkit.org [Thu, 23 Jun 2011 22:02:45 +0000 (22:02 +0000)]
2011-06-23  Joe Wild  <joseph.wild@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] The Qt WebKit Symbian .def file needs to be updated so Symbian will build
        https://bugs.webkit.org/show_bug.cgi?id=61200

        Revert r87060 as it broke compatibility with QtWebKit 2.1 release
        and add some newly introduce symbols.

        * symbian/eabi/QtWebKitu.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Alok Priyadarshi <alokp@chromium.org>
alokp@chromium.org [Thu, 23 Jun 2011 21:55:30 +0000 (21:55 +0000)]
2011-06-23  Alok Priyadarshi  <alokp@chromium.org>

        Reviewed by James Robinson.

        [chromium] Add support for running layout tests with accelerated rendering
        https://bugs.webkit.org/show_bug.cgi?id=63274

        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAvoid fetching JSON data when possible on TestFailures page to determine if old-run...
aroben@apple.com [Thu, 23 Jun 2011 21:47:00 +0000 (21:47 +0000)]
Avoid fetching JSON data when possible on TestFailures page to determine if old-run-webkit-tests exited early

As of r89610, results.html includes information about whether old-run-webkit-tests exited
early, so we don't need to look at JSON data to get this information for builds newer than
that.

Fixes <http://webkit.org/b/63281> TestFailures page fetches build JSON for every build,
which is slow and limits history to the last build master restart

Reviewed by David Kilzer.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
(Builder.prototype._getFailingTests): Moved code dealing with results.html into a new
function. If we're dealing with a build that has early-exit information in results.html,
don't bother fetching JSON data and go straight to parsing results.html. Otherwise first use
the JSON data to determine if old-run-webkit-tests exited early, and then parse results.html
(as before).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 23 Jun 2011 21:43:33 +0000 (21:43 +0000)]
2011-06-23  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        sheriffbot can no longer restart
        https://bugs.webkit.org/show_bug.cgi?id=63221

        Fixed and unit tested.

        * Scripts/webkitpy/tool/bot/queueengine.py:
        * Scripts/webkitpy/tool/bot/sheriffircbot.py:
        * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Alexis Menard <alexis.menard@openbossa.org>
alexis.menard@openbossa.org [Thu, 23 Jun 2011 21:42:52 +0000 (21:42 +0000)]
2011-06-23  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Eric Carlson.

        [Qt] Implement fullscreen support on Mac with the QuickTime backend.
        https://bugs.webkit.org/show_bug.cgi?id=61728

        Implement fullscreen support for Qt when using the QuickTime backend.
        We mostly use what is already done for the Mac port.

        * DerivedSources.pro: We use the mac files and they have <WebCore/x> type
        of includes. We need to generate those headers.
        * WebCore.pro:
        * platform/mac/WebVideoFullscreenController.h:
        * platform/mac/WebVideoFullscreenController.mm:
        * platform/mac/WebVideoFullscreenHUDWindowController.h:
        * platform/mac/WebVideoFullscreenHUDWindowController.mm:
        * platform/qt/WebCoreSystemInterface.h:
        * platform/qt/WebCoreSystemInterface.mm:
2011-06-23  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Eric Carlson.

        [Qt] Implement fullscreen support on Mac with the QuickTime backend.
        https://bugs.webkit.org/show_bug.cgi?id=61728

        Implement fullscreen support for Qt when using the QuickTime backend.
        We mostly use what is already done for the Mac port.

        * QtWebKit.pro:
        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::ChromeClientQt):
        (WebCore::ChromeClientQt::~ChromeClientQt):
        * WebCoreSupport/ChromeClientQt.h:
        * WebCoreSupport/FullScreenVideoQt.cpp:
        (WebCore::FullScreenVideoQt::FullScreenVideoQt):
        (WebCore::FullScreenVideoQt::~FullScreenVideoQt):
        (WebCore::FullScreenVideoQt::enterFullScreenForNode):
        (WebCore::FullScreenVideoQt::exitFullScreenForNode):
        (WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback):
        (WebCore::FullScreenVideoQt::isValid):
        * WebCoreSupport/FullScreenVideoQt.h:
        * WebCoreSupport/QTKitFullScreenVideoHandler.h: Added.
        * WebCoreSupport/QTKitFullScreenVideoHandler.mm: Added.
        (QTKitFullScreenVideoHandler::QTKitFullScreenVideoHandler):
        (QTKitFullScreenVideoHandler::~QTKitFullScreenVideoHandler):
        (QTKitFullScreenVideoHandler::enterFullScreen):
        (QTKitFullScreenVideoHandler::exitFullScreen):
        * WebCoreSupport/WebSystemInterface.mm:
        (InitWebCoreSystemInterface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 23 Jun 2011 21:41:35 +0000 (21:41 +0000)]
2011-06-23  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] [WebKit2] WebKitTestRunner does not properly load TestNetscapePlugin
        https://bugs.webkit.org/show_bug.cgi?id=63287

        Send the path to the TestNetscapePlugin to the WKTR via an environment variable
        so that the plugin loads properly.

        * Scripts/old-run-webkit-tests: Pass the appropriate environment variable to WKTR.
        * WebKitTestRunner/gtk/TestControllerGtk.cpp:
        (WTR::getEnvironmentVariableAsUTF8String): Added this helper which abstracts away some
        of the work for getting an environment variable and converting it to UTF-8.
        (WTR::TestController::initializeInjectedBundlePath): Use the helper.
        (WTR::TestController::initializeTestPluginDirectory): Get the path from an environment variable now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Thu, 23 Jun 2011 21:36:59 +0000 (21:36 +0000)]
2011-06-23  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        Add a test with a single <source> element
        https://bugs.webkit.org/show_bug.cgi?id=63285

        * media/video-single-valid-source-expected.txt: Added.
        * media/video-single-valid-source.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=61585
barraclough@apple.com [Thu, 23 Jun 2011 21:35:50 +0000 (21:35 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=61585
Crash running regexp /(?:(?=g))|(?:m).{2147483648,}/

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

This is due to use of int instead of unsigned, bad math around
the 2^31 boundary.

* yarr/YarrInterpreter.cpp:
(JSC::Yarr::ByteCompiler::emitDisjunction):
    - Change some uses of int to unsigned, refactor compare logic to
      restrict to the range 0..2^32-1 (rather than -2^32-1..2^32-1).
* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::generate):
(JSC::Yarr::YarrGenerator::backtrack):
    - Ditto.

LayoutTests:

Add regression tests where an alterative has a size of ~2^31.

* fast/regex/overflow-expected.txt: Added.
* fast/regex/overflow.html: Added.
* fast/regex/script-tests/overflow.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 23 Jun 2011 21:30:15 +0000 (21:30 +0000)]
2011-06-23  Darin Adler  <darin@apple.com>

        Reviewed by Ryosuke Niwa.

        RefPtr misused as argument type in a few classes
        https://bugs.webkit.org/show_bug.cgi?id=62955

        * dom/DataTransferItem.cpp:
        (WebCore::DataTransferItem::DataTransferItem):
        * dom/DataTransferItem.h:
        * dom/DataTransferItems.cpp:
        (WebCore::DataTransferItems::DataTransferItems):
        * dom/DataTransferItems.h:
        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::rebalanceWhitespaceOnTextSubstring):
        * editing/CompositeEditCommand.h:
        * page/WebKitAnimationList.cpp:
        (WebCore::WebKitAnimationList::append):
        (WebCore::WebKitAnimationList::insertAnimation):
        * page/WebKitAnimationList.h:
        * svg/graphics/filters/SVGFEImage.cpp:
        (WebCore::FEImage::FEImage):
        (WebCore::FEImage::create):
        * svg/graphics/filters/SVGFEImage.h:
        * svg/graphics/filters/SVGFilterBuilder.cpp:
        (WebCore::SVGFilterBuilder::SVGFilterBuilder):
        (WebCore::SVGFilterBuilder::add):
        (WebCore::SVGFilterBuilder::appendEffectToEffectReferences):
        * svg/graphics/filters/SVGFilterBuilder.h:
        * websockets/ThreadableWebSocketChannelClientWrapper.cpp:
        (WebCore::ThreadableWebSocketChannelClientWrapper::didConnectCallback):
        (WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessageCallback):
        (WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshakeCallback):
        (WebCore::ThreadableWebSocketChannelClientWrapper::didCloseCallback):
        * websockets/ThreadableWebSocketChannelClientWrapper.h:
        * websockets/WorkerThreadableWebSocketChannel.cpp:
        (WebCore::WorkerThreadableWebSocketChannel::Peer::Peer):
        (WebCore::WorkerThreadableWebSocketChannel::Bridge::setWebSocketChannel):
        (WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadCreateWebSocketChannel):
        * websockets/WorkerThreadableWebSocketChannel.h:
        Use PassRefPtr or raw pointer as appropriate for RefPtr arguments.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Snow Leopard WebKit2 Tests] http/tests/appcache/interrupted-update.html failing...
jberlin@webkit.org [Thu, 23 Jun 2011 21:10:57 +0000 (21:10 +0000)]
[Snow Leopard WebKit2 Tests]  http/tests/appcache/interrupted-update.html failing, probably
since introduction in r86478.
https://bugs.webkit.org/show_bug.cgi?id=63288

Add expected failing results in order to get the bots green.

* platform/mac-wk2/http/tests/appcache/interrupted-update-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=63218
barraclough@apple.com [Thu, 23 Jun 2011 21:04:40 +0000 (21:04 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=63218
DFG JIT - remove machine type guarantees from graph

Reviewed by Sam Weinig.

The DFG JIT currently makes assumptions about the types of machine registers
that certain nodes will be loaded into. This will be broken as we generate
nodes to produce both integer and double code paths. Remove int<->double
conversions nodes. This design decision also gave rise to multiple types of
constant nodes, requiring separate handling for each type. Merge these back
into JSConstant.

* dfg/DFGAliasTracker.h:
(JSC::DFG::AliasTracker::equalIgnoringLaterNumericConversion):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getToInt32):
(JSC::DFG::ByteCodeParser::getToNumber):
(JSC::DFG::ByteCodeParser::toInt32):
(JSC::DFG::ByteCodeParser::toNumber):
(JSC::DFG::ByteCodeParser::isInt32Constant):
(JSC::DFG::ByteCodeParser::isDoubleConstant):
(JSC::DFG::ByteCodeParser::valueOfInt32Constant):
(JSC::DFG::ByteCodeParser::valueOfDoubleConstant):
(JSC::DFG::ByteCodeParser::one):
(JSC::DFG::ByteCodeParser::predictInt32):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::silentFillGPR):
(JSC::DFG::JITCodeGenerator::silentFillFPR):
(JSC::DFG::JITCodeGenerator::isJSConstant):
(JSC::DFG::JITCodeGenerator::isDoubleConstant):
(JSC::DFG::JITCodeGenerator::valueOfJSConstantAsImmPtr):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::fillNumericToDouble):
(JSC::DFG::JITCompiler::fillInt32ToInteger):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::isJSConstant):
(JSC::DFG::JITCompiler::isInt32Constant):
(JSC::DFG::JITCompiler::isDoubleConstant):
(JSC::DFG::JITCompiler::valueOfJSConstant):
(JSC::DFG::JITCompiler::valueOfInt32Constant):
(JSC::DFG::JITCompiler::valueOfDoubleConstant):
* dfg/DFGNode.h:
(JSC::DFG::Node::Node):
(JSC::DFG::Node::isConstant):
(JSC::DFG::Node::notTakenBytecodeOffset):
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::isKnownInteger):
(JSC::DFG::NonSpeculativeJIT::isKnownNumeric):
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::compilePeepHoleIntegerBranch):
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRecord whether old-run-webkit-tests aborted early in results.html
aroben@apple.com [Thu, 23 Jun 2011 20:29:56 +0000 (20:29 +0000)]
Record whether old-run-webkit-tests aborted early in results.html

Fixes <http://webkit.org/b/63280> results.html gives no indication of whether
old-run-webkit-tests stopped running tests early

Reviewed by David Kilzer.

* Scripts/old-run-webkit-tests:
(top level): Switched to heredoc syntax for printing the start of results.html for clarity.
Added a <style> element with some styles for the new message. If we stopped running early,
put the reason why at the top of results.html.
(stopRunningTestsEarlyIfNeeded): Store the message we print in the new
$stoppedRunningEarlyMessage global.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Thu, 23 Jun 2011 20:24:55 +0000 (20:24 +0000)]
2011-06-23  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r89591 and r89593.
        http://trac.webkit.org/changeset/89591
        http://trac.webkit.org/changeset/89593
        https://bugs.webkit.org/show_bug.cgi?id=63279

        Caused test crashes in SL and Chromium (Requested by dimich_
        on #webkit).

        * platform/mac/accessibility/aria-liveregion-without-element-access-expected.txt: Removed.
        * platform/mac/accessibility/aria-liveregion-without-element-access.html: Removed.
2011-06-23  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r89591 and r89593.
        http://trac.webkit.org/changeset/89591
        http://trac.webkit.org/changeset/89593
        https://bugs.webkit.org/show_bug.cgi?id=63279

        Caused test crashes in SL and Chromium (Requested by dimich_
        on #webkit).

        * accessibility/AXObjectCache.cpp:
        (WebCore::AXObjectCache::AXObjectCache):
        (WebCore::AXObjectCache::remove):
        (WebCore::AXObjectCache::childrenChanged):
        * accessibility/AXObjectCache.h:
        * accessibility/AccessibilityMenuList.cpp:
        (WebCore::AccessibilityMenuList::childrenChanged):
        * accessibility/AccessibilityMenuList.h:
        * accessibility/AccessibilityMenuListPopup.cpp:
        (WebCore::AccessibilityMenuListPopup::childrenChanged):
        * accessibility/AccessibilityMenuListPopup.h:
        * accessibility/AccessibilityObject.h:
        (WebCore::AccessibilityObject::childrenChanged):
        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::startOfContinuations):
        (WebCore::AccessibilityRenderObject::updateAccessibilityRole):
        (WebCore::AccessibilityRenderObject::childrenChanged):
        * accessibility/AccessibilityRenderObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Thu, 23 Jun 2011 20:22:43 +0000 (20:22 +0000)]
2011-06-23  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Darin Adler.

        Incorrect MIME type used for some media layout tests
        https://bugs.webkit.org/show_bug.cgi?id=63275

        * media/video-can-play-type-expected.txt: video/mpeg -> video/mp4
        * media/video-can-play-type.html: Ditto.
        * media/video-source-error.html: Ditto.
        * media/video-source-type.html: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WebKit2 Tests] svg/zoom/page/zoom-replaced-intrinsic-ratio-001.html failing since
jberlin@webkit.org [Thu, 23 Jun 2011 20:21:12 +0000 (20:21 +0000)]
[WebKit2 Tests] svg/zoom/page/zoom-replaced-intrinsic-ratio-001.html failing since
introduction in r88913.
https://bugs.webkit.org/show_bug.cgi?id=63277

Add the (failing?) expected results in order to get the WK2 bots green.

* platform/mac-wk2/svg: Added.
* platform/mac-wk2/svg/zoom: Added.
* platform/mac-wk2/svg/zoom/page: Added.
* platform/mac-wk2/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Andreas Kling <kling@webkit.org>
commit-queue@webkit.org [Thu, 23 Jun 2011 20:04:22 +0000 (20:04 +0000)]
2011-06-23  Andreas Kling  <kling@webkit.org>

        Reviewed by Benjamin Poulain.

        [Qt] Unbreak simple font fast-path after QRawFont API changes.
        https://bugs.webkit.org/show_bug.cgi?id=63272

        In the Qt 4.8 branch, the QGlyphs class has been renamed to
        QGlyphRun, and some other small things have been tweaked.

        * WebCore.pro:
        * platform/graphics/qt/FontCacheQt.cpp:
        (WebCore::rawFontForCharacters):
        * platform/graphics/qt/FontQt.cpp:
        (WebCore::Font::drawGlyphs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Jamie Cooley <james.cooley@nokia.com>
commit-queue@webkit.org [Thu, 23 Jun 2011 19:54:25 +0000 (19:54 +0000)]
2011-06-23 Jamie Cooley  <james.cooley@nokia.com>

        Reviewed by Andreas Kling.

        [Qt][WK2] Qt port needs load-from-history implementation
        https://bugs.webkit.org/show_bug.cgi?id=57784

        Created "random access" BackForwardHistory public API method,
        QWKHistory::goToItemAt(int)

        * UIProcess/API/qt/qwkhistory.cpp:
        (QWKHistoryItem::QWKHistoryItem::itemRef):
        Added access method to fetch WKBackForwardListRef

        (QWKHistoryPrivate::QWKHistoryPrivate):
        (QWKHistoryPrivate::createHistory):
        Updated createHistory method and QWKHistoryPrivate constructor to take a pointer
        to the owning QWKPage in addition to the WebBackForwardList. This will be saved so that the
        new API can ask the page to load a HistoryItem.

        (QWKHistory::goToItemAt):
        New Public API. Like QWKHistory::itemAt, callee gives an integer.
        <0 means jump back to that item, 0 means the current item, >0 means jump forwards.
        If an out-of-range index is given, the function silently fails.
        This will invoke WKPageGoToBackForwardListItem.

        * UIProcess/API/qt/qwkhistory.h:
        * UIProcess/API/qt/qwkhistory_p.h:
        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPagePrivate::QWKPagePrivate):
        Update instantiation of QWKHistory to include QWKPage.

        * UIProcess/API/qt/tests/qwkhistory/tst_qwkhistory.cpp:
        (tst_QWKHistory::historyForwardBackTest_data):
        (tst_QWKHistory::historyForwardBackTest):
        Add test content for the new API

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Tony Chang <tony@chromium.org>
tony@chromium.org [Thu, 23 Jun 2011 19:53:41 +0000 (19:53 +0000)]
2011-06-23  Tony Chang  <tony@chromium.org>

        Reviewed by Andreas Kling.

        Pass Strings as const references in NetworkResourcesData.h
        https://bugs.webkit.org/show_bug.cgi?id=63271

        * inspector/NetworkResourcesData.h:
        (WebCore::NetworkResourcesData::ResourceData::setFrameId):
        (WebCore::NetworkResourcesData::ResourceData::setUrl):
        (WebCore::NetworkResourcesData::ResourceData::setTextEncodingName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdded expected results for Snow Leopard and earlier.
mitz@apple.com [Thu, 23 Jun 2011 19:52:31 +0000 (19:52 +0000)]
Added expected results for Snow Leopard and earlier.

* platform/mac-snowleopard/platform/mac/fast/text: Added.
* platform/mac-snowleopard/platform/mac/fast/text/line-break-locale-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttp/tests/multipart/win-boundary-crash.html flakey.
jberlin@webkit.org [Thu, 23 Jun 2011 19:50:50 +0000 (19:50 +0000)]
http/tests/multipart/win-boundary-crash.html flakey.
https://bugs.webkit.org/show_bug.cgi?id=63268

Disable the test. I was wrong in thinking that the win skipped list inherits from mac.

* http/tests/multipart/win-boundary-crash.html: Removed.
* http/tests/multipart/win-boundary-crash.html-disabled: Copied from LayoutTests/http/tests/multipart/win-boundary-crash.html.
* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCache some of the TestFailures page's data in localStorage
aroben@apple.com [Thu, 23 Jun 2011 19:49:25 +0000 (19:49 +0000)]
Cache some of the TestFailures page's data in localStorage

This makes reloading TestFailures much faster. Right now we only store the number of failing
tests and the list of failing tests for each build. We may choose to store more later, but
it's easy to run up against quota limits.

Fixes <http://webkit.org/b/61520> TestFailures page should take advantage of LocalStorage
APIs (or similar) to improve loading performance

Reviewed by David Kilzer.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
(Builder.prototype.getNumberOfFailingTests): Changed to use the new PersistentCache object.
(Builder.prototype.startFetchingBuildHistory): Changed to pass whether or not we're still
fetching data to the callback.
(Builder.prototype._getFailingTests): Changed to use the new PersistentCache object. We now
store the tests in the cache just before calling the callback. (The previous code in this
function relied on being able to modify the tests object after storing it in the cache and
having the cached version be updated. This worked while it was a non-serialized cache, but
PersistentCache uses serialization.)

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js: Added.
(PersistentCache): This object wraps localStorage. It uses JSON to serialize/deserialize
values, and stores the date that each value was initially stored along with it. This is
later used for pruning the cache.
(PersistentCache.contains): Checks whether the key exists in localStorage.
(PersistentCache.get): Fetch the string we stored in localStorage and extract the original
value out of it.
(PersistentCache.set): Serialize the value, add the date to it, and store it in
localStorage. If this fails due to quota limits, empty the whole cache and try again.
(PersistentCache.prune): Delete any cached data that is deemed old enough.
(PersistentCache._addDateToJSONString): Prepend the current date to the string.
(PersistentCache._emptyCache): Delete everything from localStorage.
(PersistentCache._parseDateAndJSONFromString): Split apart the date and the JSON string and
return them.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
(ViewController.prototype._displayBuilder): Updated for change to callback signature. When
we finish fetching data, prune the PersistentCache. While I was here I also fixed a bug
where we'd never show the new bug link for tests for which we couldn't determine a passing
revision.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
PersistentCache.js.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttp/tests/multipart/win-boundary-crash.html flakey.
jberlin@webkit.org [Thu, 23 Jun 2011 19:32:44 +0000 (19:32 +0000)]
http/tests/multipart/win-boundary-crash.html flakey.
https://bugs.webkit.org/show_bug.cgi?id=63268

The flakiness is happening on mac as well, move it to the mac skipped list.

* platform/mac/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Jay Civelli <jcivelli@chromium.org>
jcivelli@chromium.org [Thu, 23 Jun 2011 19:29:36 +0000 (19:29 +0000)]
2011-06-23  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by Adam Barth.

        Fixing the SharedBufferChunkReader API so it works correctly with
        binary data (non printable characters).
        Also adding a method to peek at the data (this is needed for MHTML
        with binary parts).
        https://bugs.webkit.org/show_bug.cgi?id=63231

        * loader/archive/mhtml/MHTMLParser.cpp:
        (WebCore::skipLinesUntilBoundaryFound):
        (WebCore::MHTMLParser::parseNextPart):
        * loader/archive/mhtml/MHTMLParser.h:
        * platform/SharedBufferChunkReader.cpp:
        (WebCore::SharedBufferChunkReader::SharedBufferChunkReader):
        (WebCore::SharedBufferChunkReader::setSeparator):
        (WebCore::SharedBufferChunkReader::nextChunk):
        (WebCore::SharedBufferChunkReader::nextChunkAsUTF8StringWithLatin1Fallback):
        (WebCore::SharedBufferChunkReader::peek):
        * platform/SharedBufferChunkReader.h:
        * platform/network/MIMEHeader.cpp:
        (WebCore::retrieveKeyValuePairs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Thu, 23 Jun 2011 19:13:13 +0000 (19:13 +0000)]
2011-06-23  Nate Chapin  <japhet@chromium.org>

        Unreviewed.

        Revert production code part of r89503, since it's causing
        crashes on WebKit2/mac and failures on qt.

        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::dispatchWindowLoadEvent):
        * dom/Document.h:
        (WebCore::Document::processingLoadEvent):
        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::isLoadingInAPISense):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Young Han Lee <joybro@company100.net>
commit-queue@webkit.org [Thu, 23 Jun 2011 19:11:08 +0000 (19:11 +0000)]
2011-06-23  Young Han Lee  <joybro@company100.net>

        Reviewed by Simon Fraser.

        runAnimationTest always fails if the pause API is enabled and the test target animation has "infinite" iteration count.
        https://bugs.webkit.org/show_bug.cgi?id=63152

        The pausing conditions are modified. Now it accepts the infinite-iteration-count,
        but rejects the zero-iteration-count. There is no reason to consider the zero-count meaning no animation.

        * animations/keyframes-infinite-iterations-expected.txt: Added.
        * animations/keyframes-infinite-iterations.html: Added.
2011-06-23  Young Han Lee  <joybro@company100.net>

        Reviewed by Simon Fraser.

        runAnimationTest always fails if the pause API is enabled and the test target animation has "infinite" iteration count.
        https://bugs.webkit.org/show_bug.cgi?id=63152

        The pausing conditions are modified. Now it accepts the infinite-iteration-count,
        but rejects the zero-iteration-count. There is no reason to consider the zero-count meaning no animation.

        Test: animations/keyframes-infinite-iterations.html

        * page/animation/CompositeAnimation.cpp:
        (WebCore::CompositeAnimation::pauseAnimationAtTime):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Windows 7 Release Tests] http/tests/multipart/win-boundary-crash.html flakey.
jberlin@webkit.org [Thu, 23 Jun 2011 18:42:52 +0000 (18:42 +0000)]
[Windows 7 Release Tests] http/tests/multipart/win-boundary-crash.html flakey.
https://bugs.webkit.org/show_bug.cgi?id=63268

Add it to the Windows skipped list to get the bots green.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89596 268f45cc-cd09-0410-ab3c-d52691b4dbfc