WebKit-https.git
23 months ago[CoordGraphics] CoordinatedGraphicsLayer::updateContentBuffers() should always assume...
zandobersek@gmail.com [Fri, 24 Nov 2017 13:04:45 +0000 (13:04 +0000)]
[CoordGraphics] CoordinatedGraphicsLayer::updateContentBuffers() should always assume a non-null CoordinatedBuffer
https://bugs.webkit.org/show_bug.cgi?id=179977

Reviewed by Carlos Garcia Campos.

Source/WebCore:

CoordinatedGraphicsLayer::updateContentBuffers() retrieves a RefPtr<CoordinatedBuffer>
from the CompositingCoordinator. This pointer should never be null since if no
existing UpdateAtlas can provide the necessary memory area, a fresh UpdateAtlas is
created and its buffer returned. This can't fail in theory since the tiles that are
being updated are smaller than the UpdateAtlas area.

The CoordinatedGraphicsLayerClient::getCoordinatedBuffer() method is updated to
always return a Ref<CoordinatedBuffer> value. Code in updateContentBuffers() is
updated to remove a null-check on what is now the Ref<CoordinatedBuffer> value.

No new tests -- no change in functionality.

* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::updateContentBuffers):
* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:

Source/WebKit:

Make CompositingCoordinator::getCoordinatedBuffer() return a Ref<CoordinatedBuffer>
value. In case an UpdateAtlas with enough free area is found, its CoordinatedBuffer
is dereferenced into the return value. In case a new UpdateAtlas is created, the
returned CoordinatedBuffer pointer is asserted to be non-null and dereferenced.

The retrieved CoordinatedBuffer pointer on a newly-created UpdateAtlas should never
be null since the tiles are smaller in size than the UpdateAtlas area. The assert
is done in release configurations as well since the code in CoordinatedGraphicsLayer
assumes the returned pointer will be non-null, so it's just a matter of where to
crash first in case somehow a null value is returned.

* WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:
(WebKit::CompositingCoordinator::getCoordinatedBuffer):
* WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

23 months ago[CoordGraphics] UpdateAtlas constructor should receive an IntSize, not a dimension...
zandobersek@gmail.com [Fri, 24 Nov 2017 11:27:42 +0000 (11:27 +0000)]
[CoordGraphics] UpdateAtlas constructor should receive an IntSize, not a dimension value
https://bugs.webkit.org/show_bug.cgi?id=179976

Reviewed by Carlos Garcia Campos.

Have the UpdateAtlas constructor receive an IntSize object that specifies
the desired size for the CoordinatedBuffer. Passing in a dimension doesn't
really make sense since this value isn't dynamically configurable, and
the only value that is passed in is already a power-of-two.

* WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:
(WebKit::CompositingCoordinator::getCoordinatedBuffer):
* WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.cpp:
(WebKit::UpdateAtlas::UpdateAtlas):
* WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

23 months ago[JSC] Make empty key as deleted mark in HashMapBucket and drop m_deleted field
utatane.tea@gmail.com [Fri, 24 Nov 2017 11:04:40 +0000 (11:04 +0000)]
[JSC] Make empty key as deleted mark in HashMapBucket and drop m_deleted field
https://bugs.webkit.org/show_bug.cgi?id=179923

Reviewed by Darin Adler.

We do not set empty as a key in HashMapBucket since JSMap / JSSet can expose it to users.
So we can use it as a marker of deleted bucket.

This patch uses empty key as a deleted flag, and drop m_deleted field of HashMapBucket.
It shrinks the size of HashMapBucket much.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetMapBucketNext):
* ftl/FTLAbstractHeapRepository.h:
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileGetMapBucketNext):
* runtime/HashMapImpl.h:
(JSC::HashMapBucket::createSentinel):
We make sentinel bucket as (undefined, undefined) since DFG/FTL can load a value from sentinels.
While the sentinel's deleted flag becomes false since key is set, it is not a problem since deleted
flag of sentinel bucket is not used.

(JSC::HashMapBucket::HashMapBucket):
(JSC::HashMapBucket::deleted const):
(JSC::HashMapBucket::makeDeleted):
(JSC::HashMapImpl::remove):
(JSC::HashMapImpl::clear):
(JSC::HashMapImpl::setUpHeadAndTail):
(JSC::HashMapImpl::addNormalizedInternal):
(JSC::HashMapBucket::setDeleted): Deleted.
(JSC::HashMapBucket::offsetOfDeleted): Deleted.
(): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

23 months agoMove unsafe jsc shell test functions to the $vm object.
mark.lam@apple.com [Fri, 24 Nov 2017 10:58:16 +0000 (10:58 +0000)]
Move unsafe jsc shell test functions to the $vm object.
https://bugs.webkit.org/show_bug.cgi?id=179980

Reviewed by Yusuke Suzuki.

JSTests:

* controlFlowProfiler/driver/driver.js:
* controlFlowProfiler/execution-count.js:
* controlFlowProfiler/if-statement.js:
* controlFlowProfiler/loop-statements.js:
* controlFlowProfiler/switch-statements.js:
* controlFlowProfiler/test-jit.js:
* exceptionFuzz/3d-cube.js:
* exceptionFuzz/date-format-xparb.js:
* exceptionFuzz/earley-boyer.js:
* heapProfiler/basic-edges.js:
* heapProfiler/property-edge-types.js:
* microbenchmarks/try-get-by-id-basic.js:
* microbenchmarks/try-get-by-id-polymorphic.js:
* modules/namespace-object-try-get.js:
* stress/argument-count-bytecode.js:
* stress/argument-intrinsic-basic.js:
* stress/argument-intrinsic-inlining-use-caller-arg.js:
* stress/argument-intrinsic-inlining-with-result-escape.js:
* stress/argument-intrinsic-inlining-with-vararg-with-enough-arguments.js:
* stress/argument-intrinsic-inlining-with-vararg.js:
* stress/argument-intrinsic-nested-inlining.js:
* stress/argument-intrinsic-not-convert-to-get-argument.js:
* stress/argument-intrinsic-with-stack-write.js:
* stress/arity-mismatch-get-argument.js:
* stress/array-message-passing.js:
* stress/array-push-with-force-exit.js:
* stress/check-dom-with-signature.js:
* stress/check-sub-class.js:
* stress/compare-eq-incomplete-profile.js:
* stress/custom-get-set-inline-caching-one-level-up-proto-chain.js:
* stress/do-eval-virtual-call-correctly.js:
* stress/dom-jit-with-poly-proto.js:
* stress/domjit-exception-ic.js:
* stress/domjit-exception.js:
* stress/domjit-getter-complex-with-incorrect-object.js:
* stress/domjit-getter-complex.js:
* stress/domjit-getter-poly.js:
* stress/domjit-getter-proto.js:
* stress/domjit-getter-super-poly.js:
* stress/domjit-getter-try-catch-getter-as-get-by-id-register-restoration.js:
* stress/domjit-getter-type-check.js:
* stress/domjit-getter.js:
* stress/exit-during-inlined-arity-fixup-recover-proper-frame.js:
* stress/for-in-proxy-target-changed-structure.js:
* stress/for-in-proxy.js:
* stress/generational-opaque-roots.js:
* stress/global-const-redeclaration-setting-2.js:
* stress/global-const-redeclaration-setting-3.js:
* stress/global-const-redeclaration-setting-4.js:
* stress/global-const-redeclaration-setting-5.js:
* stress/global-const-redeclaration-setting.js:
* stress/import-basic.js:
* stress/import-from-eval.js:
* stress/import-reject-with-exception.js:
* stress/import-syntax.js:
* stress/impure-get-own-property-slot-inline-cache.js:
* stress/is-constructor.js:
* stress/istypedarrayview-intrinsic.js:
* stress/jsc-setImpureGetterDelegate-on-bad-type.js:
* stress/jsc-test-functions-should-be-more-robust.js:
* stress/object-toString-with-proxy.js:
* stress/poly-proto-custom-value-and-accessor.js:
* stress/proxy-inline-cache.js:
* stress/re-execute-error-module.js:
* stress/regress-150532.js:
* stress/regress-156992.js:
* stress/regress-179619.js:
* stress/resources/shadow-chicken-support.js:
* stress/runtime-array.js:
* stress/sampling-profiler-microtasks.js:
* stress/shadow-chicken-enabled.js:
* stress/spread-correct-global-object-on-exception.js:
* stress/super-get-by-id.js:
* stress/tailCallForwardArguments.js:
* stress/to-object-intrinsic-boolean-edge.js:
* stress/to-object-intrinsic-null-or-undefined-edge.js:
* stress/to-object-intrinsic-number-edge.js:
* stress/to-object-intrinsic-object-edge.js:
* stress/to-object-intrinsic-string-edge.js:
* stress/to-object-intrinsic-symbol-edge.js:
* stress/to-object-intrinsic.js:
* stress/try-catch-custom-getter-as-get-by-id.js:
* stress/try-get-by-id-poly-proto.js:
* stress/try-get-by-id-should-spill-registers-dfg.js:
* stress/try-get-by-id.js:
* typeProfiler/arrow-functions.js:
* typeProfiler/basic.js:
* typeProfiler/captured.js:
* typeProfiler/classes.js:
* typeProfiler/dfg-jit-optimizations.js:
* typeProfiler/dictionary-mode.js:
* typeProfiler/es6-block-scoping.js:
* typeProfiler/es6-classes.js:
* typeProfiler/inheritance.js:
* typeProfiler/int52-dfg.js:
* typeProfiler/loop.js:
* typeProfiler/optional-fields.js:
* typeProfiler/overflow.js:
* typeProfiler/return.js:
* typeProfiler/symbol.js:
* typeProfiler/weird-prototype-chain.js:

Source/JavaScriptCore:

Also removed setElementRoot() which was not used.

* jsc.cpp:
(GlobalObject::finishCreation):
(WTF::Element::Element): Deleted.
(WTF::Element::root const): Deleted.
(WTF::Element::setRoot): Deleted.
(WTF::Element::create): Deleted.
(WTF::Element::visitChildren): Deleted.
(WTF::Element::createStructure): Deleted.
(WTF::Root::Root): Deleted.
(WTF::Root::element): Deleted.
(WTF::Root::setElement): Deleted.
(WTF::Root::create): Deleted.
(WTF::Root::createStructure): Deleted.
(WTF::Root::visitChildren): Deleted.
(WTF::ImpureGetter::ImpureGetter): Deleted.
(WTF::ImpureGetter::createStructure): Deleted.
(WTF::ImpureGetter::create): Deleted.
(WTF::ImpureGetter::finishCreation): Deleted.
(WTF::ImpureGetter::getOwnPropertySlot): Deleted.
(WTF::ImpureGetter::visitChildren): Deleted.
(WTF::ImpureGetter::setDelegate): Deleted.
(WTF::CustomGetter::CustomGetter): Deleted.
(WTF::CustomGetter::createStructure): Deleted.
(WTF::CustomGetter::create): Deleted.
(WTF::CustomGetter::getOwnPropertySlot): Deleted.
(WTF::CustomGetter::customGetter): Deleted.
(WTF::CustomGetter::customGetterAcessor): Deleted.
(WTF::RuntimeArray::create): Deleted.
(WTF::RuntimeArray::~RuntimeArray): Deleted.
(WTF::RuntimeArray::destroy): Deleted.
(WTF::RuntimeArray::getOwnPropertySlot): Deleted.
(WTF::RuntimeArray::getOwnPropertySlotByIndex): Deleted.
(WTF::RuntimeArray::put): Deleted.
(WTF::RuntimeArray::deleteProperty): Deleted.
(WTF::RuntimeArray::getLength const): Deleted.
(WTF::RuntimeArray::createPrototype): Deleted.
(WTF::RuntimeArray::createStructure): Deleted.
(WTF::RuntimeArray::finishCreation): Deleted.
(WTF::RuntimeArray::RuntimeArray): Deleted.
(WTF::RuntimeArray::lengthGetter): Deleted.
(WTF::SimpleObject::SimpleObject): Deleted.
(WTF::SimpleObject::create): Deleted.
(WTF::SimpleObject::visitChildren): Deleted.
(WTF::SimpleObject::createStructure): Deleted.
(WTF::SimpleObject::hiddenValue): Deleted.
(WTF::SimpleObject::setHiddenValue): Deleted.
(WTF::DOMJITNode::DOMJITNode): Deleted.
(WTF::DOMJITNode::createStructure): Deleted.
(WTF::DOMJITNode::checkSubClassSnippet): Deleted.
(WTF::DOMJITNode::create): Deleted.
(WTF::DOMJITNode::value const): Deleted.
(WTF::DOMJITNode::offsetOfValue): Deleted.
(WTF::DOMJITGetter::DOMJITGetter): Deleted.
(WTF::DOMJITGetter::createStructure): Deleted.
(WTF::DOMJITGetter::create): Deleted.
(WTF::DOMJITGetter::DOMJITAttribute::DOMJITAttribute): Deleted.
(WTF::DOMJITGetter::DOMJITAttribute::slowCall): Deleted.
(WTF::DOMJITGetter::DOMJITAttribute::callDOMGetter): Deleted.
(WTF::DOMJITGetter::customGetter): Deleted.
(WTF::DOMJITGetter::finishCreation): Deleted.
(WTF::DOMJITGetterComplex::DOMJITGetterComplex): Deleted.
(WTF::DOMJITGetterComplex::createStructure): Deleted.
(WTF::DOMJITGetterComplex::create): Deleted.
(WTF::DOMJITGetterComplex::DOMJITAttribute::DOMJITAttribute): Deleted.
(WTF::DOMJITGetterComplex::DOMJITAttribute::slowCall): Deleted.
(WTF::DOMJITGetterComplex::DOMJITAttribute::callDOMGetter): Deleted.
(WTF::DOMJITGetterComplex::functionEnableException): Deleted.
(WTF::DOMJITGetterComplex::customGetter): Deleted.
(WTF::DOMJITGetterComplex::finishCreation): Deleted.
(WTF::DOMJITFunctionObject::DOMJITFunctionObject): Deleted.
(WTF::DOMJITFunctionObject::createStructure): Deleted.
(WTF::DOMJITFunctionObject::create): Deleted.
(WTF::DOMJITFunctionObject::safeFunction): Deleted.
(WTF::DOMJITFunctionObject::unsafeFunction): Deleted.
(WTF::DOMJITFunctionObject::checkSubClassSnippet): Deleted.
(WTF::DOMJITFunctionObject::finishCreation): Deleted.
(WTF::DOMJITCheckSubClassObject::DOMJITCheckSubClassObject): Deleted.
(WTF::DOMJITCheckSubClassObject::createStructure): Deleted.
(WTF::DOMJITCheckSubClassObject::create): Deleted.
(WTF::DOMJITCheckSubClassObject::safeFunction): Deleted.
(WTF::DOMJITCheckSubClassObject::unsafeFunction): Deleted.
(WTF::DOMJITCheckSubClassObject::finishCreation): Deleted.
(WTF::DOMJITGetterBaseJSObject::DOMJITGetterBaseJSObject): Deleted.
(WTF::DOMJITGetterBaseJSObject::createStructure): Deleted.
(WTF::DOMJITGetterBaseJSObject::create): Deleted.
(WTF::DOMJITGetterBaseJSObject::DOMJITAttribute::DOMJITAttribute): Deleted.
(WTF::DOMJITGetterBaseJSObject::DOMJITAttribute::slowCall): Deleted.
(WTF::DOMJITGetterBaseJSObject::DOMJITAttribute::callDOMGetter): Deleted.
(WTF::DOMJITGetterBaseJSObject::customGetter): Deleted.
(WTF::DOMJITGetterBaseJSObject::finishCreation): Deleted.
(WTF::Element::handleOwner): Deleted.
(WTF::Element::finishCreation): Deleted.
(JSTestCustomGetterSetter::JSTestCustomGetterSetter): Deleted.
(JSTestCustomGetterSetter::create): Deleted.
(JSTestCustomGetterSetter::createStructure): Deleted.
(customGetAccessor): Deleted.
(customGetValue): Deleted.
(customSetAccessor): Deleted.
(customSetValue): Deleted.
(JSTestCustomGetterSetter::finishCreation): Deleted.
(GlobalObject::addConstructableFunction): Deleted.
(functionCreateRoot): Deleted.
(functionCreateElement): Deleted.
(functionGetElement): Deleted.
(functionSetElementRoot): Deleted.
(functionCreateSimpleObject): Deleted.
(functionGetHiddenValue): Deleted.
(functionSetHiddenValue): Deleted.
(functionCreateProxy): Deleted.
(functionCreateRuntimeArray): Deleted.
(functionCreateImpureGetter): Deleted.
(functionCreateCustomGetterObject): Deleted.
(functionCreateDOMJITNodeObject): Deleted.
(functionCreateDOMJITGetterObject): Deleted.
(functionCreateDOMJITGetterComplexObject): Deleted.
(functionCreateDOMJITFunctionObject): Deleted.
(functionCreateDOMJITCheckSubClassObject): Deleted.
(functionCreateDOMJITGetterBaseJSObject): Deleted.
(functionSetImpureGetterDelegate): Deleted.
(functionGetGetterSetter): Deleted.
(functionShadowChickenFunctionsOnStack): Deleted.
(functionSetGlobalConstRedeclarationShouldNotThrow): Deleted.
(functionGlobalObjectForObject): Deleted.
(functionLoadGetterFromGetterSetter): Deleted.
(functionCreateCustomTestGetterSetter): Deleted.
(functionAbort): Deleted.
(functionFindTypeForExpression): Deleted.
(functionReturnTypeFor): Deleted.
(functionDumpBasicBlockExecutionRanges): Deleted.
(functionHasBasicBlockExecuted): Deleted.
(functionBasicBlockExecutionCount): Deleted.
(functionEnableExceptionFuzz): Deleted.
(functionCreateBuiltin): Deleted.
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
* tools/JSDollarVM.cpp:
(WTF::Element::Element):
(WTF::Element::root const):
(WTF::Element::setRoot):
(WTF::Element::create):
(WTF::Element::visitChildren):
(WTF::Element::createStructure):
(WTF::Root::Root):
(WTF::Root::element):
(WTF::Root::setElement):
(WTF::Root::create):
(WTF::Root::createStructure):
(WTF::Root::visitChildren):
(WTF::SimpleObject::SimpleObject):
(WTF::SimpleObject::create):
(WTF::SimpleObject::visitChildren):
(WTF::SimpleObject::createStructure):
(WTF::SimpleObject::hiddenValue):
(WTF::SimpleObject::setHiddenValue):
(WTF::ImpureGetter::ImpureGetter):
(WTF::ImpureGetter::createStructure):
(WTF::ImpureGetter::create):
(WTF::ImpureGetter::finishCreation):
(WTF::ImpureGetter::getOwnPropertySlot):
(WTF::ImpureGetter::visitChildren):
(WTF::ImpureGetter::setDelegate):
(WTF::CustomGetter::CustomGetter):
(WTF::CustomGetter::createStructure):
(WTF::CustomGetter::create):
(WTF::CustomGetter::getOwnPropertySlot):
(WTF::CustomGetter::customGetter):
(WTF::CustomGetter::customGetterAcessor):
(WTF::RuntimeArray::create):
(WTF::RuntimeArray::~RuntimeArray):
(WTF::RuntimeArray::destroy):
(WTF::RuntimeArray::getOwnPropertySlot):
(WTF::RuntimeArray::getOwnPropertySlotByIndex):
(WTF::RuntimeArray::put):
(WTF::RuntimeArray::deleteProperty):
(WTF::RuntimeArray::getLength const):
(WTF::RuntimeArray::createPrototype):
(WTF::RuntimeArray::createStructure):
(WTF::RuntimeArray::finishCreation):
(WTF::RuntimeArray::RuntimeArray):
(WTF::RuntimeArray::lengthGetter):
(WTF::DOMJITNode::DOMJITNode):
(WTF::DOMJITNode::createStructure):
(WTF::DOMJITNode::checkSubClassSnippet):
(WTF::DOMJITNode::create):
(WTF::DOMJITNode::value const):
(WTF::DOMJITNode::offsetOfValue):
(WTF::DOMJITGetter::DOMJITGetter):
(WTF::DOMJITGetter::createStructure):
(WTF::DOMJITGetter::create):
(WTF::DOMJITGetter::DOMJITAttribute::DOMJITAttribute):
(WTF::DOMJITGetter::DOMJITAttribute::slowCall):
(WTF::DOMJITGetter::DOMJITAttribute::callDOMGetter):
(WTF::DOMJITGetter::customGetter):
(WTF::DOMJITGetter::finishCreation):
(WTF::DOMJITGetterComplex::DOMJITGetterComplex):
(WTF::DOMJITGetterComplex::createStructure):
(WTF::DOMJITGetterComplex::create):
(WTF::DOMJITGetterComplex::DOMJITAttribute::DOMJITAttribute):
(WTF::DOMJITGetterComplex::DOMJITAttribute::slowCall):
(WTF::DOMJITGetterComplex::DOMJITAttribute::callDOMGetter):
(WTF::DOMJITGetterComplex::functionEnableException):
(WTF::DOMJITGetterComplex::customGetter):
(WTF::DOMJITGetterComplex::finishCreation):
(WTF::DOMJITFunctionObject::DOMJITFunctionObject):
(WTF::DOMJITFunctionObject::createStructure):
(WTF::DOMJITFunctionObject::create):
(WTF::DOMJITFunctionObject::safeFunction):
(WTF::DOMJITFunctionObject::unsafeFunction):
(WTF::DOMJITFunctionObject::checkSubClassSnippet):
(WTF::DOMJITFunctionObject::finishCreation):
(WTF::DOMJITCheckSubClassObject::DOMJITCheckSubClassObject):
(WTF::DOMJITCheckSubClassObject::createStructure):
(WTF::DOMJITCheckSubClassObject::create):
(WTF::DOMJITCheckSubClassObject::safeFunction):
(WTF::DOMJITCheckSubClassObject::unsafeFunction):
(WTF::DOMJITCheckSubClassObject::finishCreation):
(WTF::DOMJITGetterBaseJSObject::DOMJITGetterBaseJSObject):
(WTF::DOMJITGetterBaseJSObject::createStructure):
(WTF::DOMJITGetterBaseJSObject::create):
(WTF::DOMJITGetterBaseJSObject::DOMJITAttribute::DOMJITAttribute):
(WTF::DOMJITGetterBaseJSObject::DOMJITAttribute::slowCall):
(WTF::DOMJITGetterBaseJSObject::DOMJITAttribute::callDOMGetter):
(WTF::DOMJITGetterBaseJSObject::customGetter):
(WTF::DOMJITGetterBaseJSObject::finishCreation):
(WTF::Message::releaseContents):
(WTF::Message::index const):
(WTF::JSTestCustomGetterSetter::JSTestCustomGetterSetter):
(WTF::JSTestCustomGetterSetter::create):
(WTF::JSTestCustomGetterSetter::createStructure):
(WTF::customGetAccessor):
(WTF::customGetValue):
(WTF::customSetAccessor):
(WTF::customSetValue):
(WTF::JSTestCustomGetterSetter::finishCreation):
(WTF::Element::handleOwner):
(WTF::Element::finishCreation):
(JSC::functionCrash):
(JSC::functionCreateProxy):
(JSC::functionCreateRuntimeArray):
(JSC::functionCreateImpureGetter):
(JSC::functionCreateCustomGetterObject):
(JSC::functionCreateDOMJITNodeObject):
(JSC::functionCreateDOMJITGetterObject):
(JSC::functionCreateDOMJITGetterComplexObject):
(JSC::functionCreateDOMJITFunctionObject):
(JSC::functionCreateDOMJITCheckSubClassObject):
(JSC::functionCreateDOMJITGetterBaseJSObject):
(JSC::functionSetImpureGetterDelegate):
(JSC::functionCreateBuiltin):
(JSC::functionCreateRoot):
(JSC::functionCreateElement):
(JSC::functionGetElement):
(JSC::functionCreateSimpleObject):
(JSC::functionGetHiddenValue):
(JSC::functionSetHiddenValue):
(JSC::functionShadowChickenFunctionsOnStack):
(JSC::functionSetGlobalConstRedeclarationShouldNotThrow):
(JSC::functionFindTypeForExpression):
(JSC::functionReturnTypeFor):
(JSC::functionDumpBasicBlockExecutionRanges):
(JSC::functionHasBasicBlockExecuted):
(JSC::functionBasicBlockExecutionCount):
(JSC::functionEnableExceptionFuzz):
(JSC::functionGlobalObjectForObject):
(JSC::functionGetGetterSetter):
(JSC::functionLoadGetterFromGetterSetter):
(JSC::functionCreateCustomTestGetterSetter):
(JSC::JSDollarVM::finishCreation):
(JSC::JSDollarVM::addFunction):
(JSC::JSDollarVM::addConstructibleFunction):
* tools/JSDollarVM.h:
(JSC::JSDollarVM::create):

Tools:

Always set --useDollarVM=true for jsc runs of benchmarks.  This is needed because
some microbenchmarks relies on createBuiltin().

Also set --useDollarVM=true for runExceptionFuzz and runExecutableAllocationFuzz.

* Scripts/run-jsc-benchmarks:
* Scripts/run-jsc-stress-tests:

LayoutTests:

* js/script-tests/stack-trace.js:
* js/stack-trace-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

23 months agoSource/WebCore:
graouts@webkit.org [Fri, 24 Nov 2017 09:45:30 +0000 (09:45 +0000)]
Source/WebCore:
[Web Animations] Perform accelerated animations when possible
https://bugs.webkit.org/show_bug.cgi?id=179973
<rdar://problem/34953922>

Reviewed by Dean Jackson.

When we're entering and leaving the active duration of an animation effect, we now check
whether the animation can be accelerated, using the existing CSSPropertyAnimation::animationOfPropertyIsAccelerated()
utility, and start and stop animations using the startAnimation() and animationFinished() functions on RenderBoxModelObject.

This patch is only a first step towards full support for accelerated animations,
there are two known issues at the moment. Because we're not blending the styles to perform
the animation, getComputedStyle() will not return the animated value (webkit.org/b/179974).
Additionally, if other animations happen to run later during the active state of an animation
that can run accelerated, we will not fall back to software-only animation for this
element and these animations will appear not to run (webkit.org/b/179975). These will be
addressed in follow-up patches.

Tests: webanimations/left-and-opacity-animation-yields-no-compositing.html
       webanimations/opacity-animation-no-longer-composited-upon-completion.html
       webanimations/opacity-animation-yields-compositing.html
       webanimations/width-and-opacity-separate-animation-yields-no-compositing.html

* animation/DocumentTimeline.cpp:
(WebCore::DocumentTimeline::updateAnimations): Check in the map of pending accelerated animations
to see if any animation requires toggling their active state after their styles have been invalidated.
(WebCore::DocumentTimeline::animationAcceleratedRunningStateDidChange): New function to
let animations indicate that they need to have their accelerated backing animation toggled after
style invalidation has been completed.
(WebCore::DocumentTimeline::runningAnimationsForElementAreAllAccelerated): This function is used
in RenderLayerCompositor::requiresCompositingForAnimation() to identify whether an element requires
hardware compositing due to running accelerated animations. We check all running animations for the
provided element to see if they can all be running accelerated and return true in this situation only.
* animation/DocumentTimeline.h:
* animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::applyAtLocalTime): Identify if we're crossing into or out of the active state
for an animation and check if it will be or has been running accelerated such that we can notify the
DocumentTimeline, through the associated animation, that the accelerated backing animation will need to
be toggled after style invalidation has been completed.
(WebCore::KeyframeEffect::shouldRunAccelerated): Check that all properties for this animation
effect can be accelerated according to CSSPropertyAnimation::animationOfPropertyIsAccelerated().
(WebCore::KeyframeEffect::startOrStopAccelerated): Start or stop the associated accelerated
animation through the associated element's RenderBoxModelObject renderer.
* animation/KeyframeEffect.h:
* animation/WebAnimation.cpp:
(WebCore::WebAnimation::acceleratedRunningStateDidChange): Called from AnimationEffect::applyAtLocalTime(),
we forward to the DocumentTimeline the information that the animation will cross an active state boundary while
allowing to be backed by hardware compositing.
(WebCore::WebAnimation::startOrStopAccelerated): Forward to the associated KeyframeEffect that accelerated
animation backing should be toggled.
* animation/WebAnimation.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForAnimation const): Check via the renderer's element's
DocumentTimeline that all running animations for this particular element are accelerated to ensure that
the element will be hardware-composited.

LayoutTests:
[Web Animations] Perform hardware-composited animations when possible
https://bugs.webkit.org/show_bug.cgi?id=179973
<rdar://problem/34953922>

Reviewed by Dean Jackson.

Add a series of tests to check that we use hardware-compositing for animations when possible.
Specifically, we check that:

1. Specifying both accelerated and non-accelerated properties for a single animation does *not*
yield hardware compositing (left-and-opacity-animation-yields-no-compositing.html).

2. Specifying both accelerated and non-accelerated properties via multiple animations does *not*
yield hardware compositing (width-and-opacity-separate-animation-yields-no-compositing.html).

3. Specifying only accelerated properties *does* yield hardware compositing
(opacity-animation-yields-compositing.html).

4. Hardware-composited animations no longer enforce hardware compositing after their completion
(opacity-animation-no-longer-composited-upon-completion.html).

* webanimations/left-and-opacity-animation-yields-no-compositing-expected.txt: Added.
* webanimations/left-and-opacity-animation-yields-no-compositing.html: Added.
* webanimations/opacity-animation-no-longer-composited-upon-completion-expected.txt: Added.
* webanimations/opacity-animation-no-longer-composited-upon-completion.html: Added.
* webanimations/opacity-animation-yields-compositing-expected.txt: Added.
* webanimations/opacity-animation-yields-compositing.html: Added.
* webanimations/width-and-opacity-separate-animation-yields-no-compositing-expected.txt: Added.
* webanimations/width-and-opacity-separate-animation-yields-no-compositing.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

23 months ago[Win] PasteboardWin.cpp(653): error C2039: 'containsOnlyASCII': is not a member of...
commit-queue@webkit.org [Fri, 24 Nov 2017 05:39:57 +0000 (05:39 +0000)]
[Win] PasteboardWin.cpp(653): error C2039: 'containsOnlyASCII': is not a member of 'WTF::String'
https://bugs.webkit.org/show_bug.cgi?id=179991

Unreviewed build fix.

No new tests (No behaviour change).

Patch by Fujii Hironori <Hironori.Fujii@sony.com> on 2017-11-23

* platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::writeURLToDataObject): Renamed containsOnlyASCII() to isAllASCII().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

23 months agoREGRESSION(r225098): [GTK] Gardening of tests after r225098.
clopez@igalia.com [Fri, 24 Nov 2017 01:25:56 +0000 (01:25 +0000)]
REGRESSION(r225098): [GTK] Gardening of tests after r225098.
https://bugs.webkit.org/show_bug.cgi?id=179989

Unreviewed.

Mark new expected failures meanwhile the issue is not fixed.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

23 months agoIsolated Heaps caused an increase in reported leaks on the bots
fpizlo@apple.com [Fri, 24 Nov 2017 00:47:58 +0000 (00:47 +0000)]
Isolated Heaps caused an increase in reported leaks on the bots
https://bugs.webkit.org/show_bug.cgi?id=179463

Reviewed by Darin Adler.

This fixes the way isoheaps interact with system tools:

- Opts into the VMHeap API so that the leaks tool can find isoheap memory.

- Opts into the DebugHeap/Environment APIs so that we turn off isoheap allocation if memory
  debugging options are in use.

* bmalloc.xcodeproj/project.pbxproj:
* bmalloc/DebugHeap.h:
* bmalloc/IsoHeap.h:
* bmalloc/IsoPage.cpp: Added.
(bmalloc::IsoPageBase::allocatePageMemory):
* bmalloc/IsoPage.h:
* bmalloc/IsoPageInlines.h:
(bmalloc::IsoPage<Config>::tryCreate):
* bmalloc/IsoTLS.cpp:
(bmalloc::IsoTLS::deallocateSlow):
(bmalloc::IsoTLS::ensureEntries):
(bmalloc::IsoTLS::isUsingDebugHeap):
(bmalloc::IsoTLS::debugMalloc):
* bmalloc/IsoTLS.h:
* bmalloc/IsoTLSInlines.h:
(bmalloc::IsoTLS::allocate):
(bmalloc::IsoTLS::deallocate):
(bmalloc::IsoTLS::allocateImpl):
(bmalloc::IsoTLS::allocateFast):
(bmalloc::IsoTLS::allocateSlow):
(bmalloc::IsoTLS::deallocateImpl):
(bmalloc::IsoTLS::deallocateFast):
(bmalloc::IsoTLS::ensureHeapAndEntries):
(bmalloc::IsoTLS::allocator): Deleted.
(bmalloc::IsoTLS::deallocator): Deleted.
* bmalloc/bmalloc.cpp:
(bmalloc::api::tryLargeMemalignVirtual):
(bmalloc::api::freeLargeVirtual):
(bmalloc::api::scavenge):
(bmalloc::api::isEnabled):
(bmalloc::api::setScavengerThreadQOSClass):
* bmalloc/bmalloc.h:
(bmalloc::api::tryLargeMemalignVirtual): Deleted.
(bmalloc::api::freeLargeVirtual): Deleted.
(bmalloc::api::scavenge): Deleted.
(bmalloc::api::isEnabled): Deleted.
(bmalloc::api::setScavengerThreadQOSClass): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

23 months ago[GTK] [Debug] Fix build after r225117.
clopez@igalia.com [Fri, 24 Nov 2017 00:35:31 +0000 (00:35 +0000)]
[GTK] [Debug] Fix build after r225117.
https://bugs.webkit.org/show_bug.cgi?id=179907

Unreviewed build fix.

r225117 renamed containsOnlyASCII() to isAllASCII().
And this reference was not updated for the GTK Debug build.

No new tests, its a build fix.

* loader/archive/mhtml/MHTMLArchive.cpp:
(WebCore::MHTMLArchive::generateMHTMLData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

23 months agoMinor ArrayBufferView cleanup
simon.fraser@apple.com [Thu, 23 Nov 2017 22:23:15 +0000 (22:23 +0000)]
Minor ArrayBufferView cleanup
https://bugs.webkit.org/show_bug.cgi?id=179966

Reviewed by Darin Adler.

Use void* for data pointers when we don't need to do offset math. Use const for
source pointers.

Prefer uint8_t* to char*.

Add comments noting that the assertions should not be made release assertions
as recommended by the style checker, since the point is to avoid the virtual byteLength()
call in release.

* runtime/ArrayBufferView.h:
(JSC::ArrayBufferView::setImpl):
(JSC::ArrayBufferView::setRangeImpl):
(JSC::ArrayBufferView::getRangeImpl):
(JSC::ArrayBufferView::zeroRangeImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

23 months agoFELighting cleanup and optimization
simon.fraser@apple.com [Thu, 23 Nov 2017 22:20:09 +0000 (22:20 +0000)]
FELighting cleanup and optimization
https://bugs.webkit.org/show_bug.cgi?id=179933

Reviewed by Darin Adler.

Make FELighting about 25% faster by maintaining an "alpha" window of the alpha
values of the 9 pixels surrounding the current pixel, and sliding this window over
when moving to the next pixel. This avoids reading the same alpha values from the original
buffer multiple times.

Clean up LightSource and subclasses, adding SPECIALIZE_TYPE_TRAITS macros,
and turning updatePaintingData() into a function with no side effects that returns
the required data.

Remove explicit 'inline' keywords, allowing the compiler to make inlining decisions.

* platform/graphics/cpu/arm/filters/FELightingNEON.h:
(WebCore::FELighting::platformApplyNeon):
* platform/graphics/filters/DistantLightSource.cpp:
(WebCore::DistantLightSource::initPaintingData):
(WebCore::DistantLightSource::computePixelLightingData const):
(WebCore::DistantLightSource::updatePaintingData): Deleted.
* platform/graphics/filters/DistantLightSource.h:
* platform/graphics/filters/FELighting.cpp:
(WebCore::FELighting::LightingData::interiorNormal const):
(WebCore::FELighting::setPixel):
(WebCore::FELighting::setPixelInternal):
(WebCore::FELighting::platformApplyGenericPaint):
(WebCore::FELighting::platformApplyGeneric):
(WebCore::FELighting::platformApply):
(WebCore::FELighting::drawLighting):
(WebCore::FELighting::inlineSetPixel): Deleted.
* platform/graphics/filters/FELighting.h:
(WebCore::FELighting::AlphaWindow::topLeft const):
(WebCore::FELighting::AlphaWindow::left const):
(WebCore::FELighting::AlphaWindow::bottomLeft const):
(WebCore::FELighting::AlphaWindow::top const):
(WebCore::FELighting::AlphaWindow::center const):
(WebCore::FELighting::AlphaWindow::bottom const):
(WebCore::FELighting::AlphaWindow::setTop):
(WebCore::FELighting::AlphaWindow::setCenter):
(WebCore::FELighting::AlphaWindow::setBottom):
(WebCore::FELighting::AlphaWindow::setTopRight):
(WebCore::FELighting::AlphaWindow::setRight):
(WebCore::FELighting::AlphaWindow::setBottomRight):
(WebCore::FELighting::AlphaWindow::shiftRow):
(WebCore::FELighting::AlphaWindow::shift):
* platform/graphics/filters/LightSource.h:
* platform/graphics/filters/PointLightSource.cpp:
(WebCore::PointLightSource::computePixelLightingData const):
(WebCore::PointLightSource::updatePaintingData): Deleted.
* platform/graphics/filters/PointLightSource.h:
* platform/graphics/filters/SpotLightSource.cpp:
(WebCore::SpotLightSource::initPaintingData):
(WebCore::SpotLightSource::computePixelLightingData const):
(WebCore::SpotLightSource::updatePaintingData): Deleted.
* platform/graphics/filters/SpotLightSource.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

23 months agoAdd support for CanvasPattern.setTransform()
simon.fraser@apple.com [Thu, 23 Nov 2017 21:33:44 +0000 (21:33 +0000)]
Add support for CanvasPattern.setTransform()
https://bugs.webkit.org/show_bug.cgi?id=179935

Reviewed by Sam Weinig.

Source/WebCore:

Add support for setTransform() on CanvasPattern, per
<https://html.spec.whatwg.org/multipage/canvas.html#dom-canvaspattern-settransform>
It uses [MayThrowException] since the "validate and fixup" steps for DOMMatrix can throw
an exception.

Under the hood, the transform is just pushed onto Pattern as the patternSpaceTransform().

Minor cleanup in Pattern.

Test: fast/canvas/canvas-pattern-with-transform.html

* html/canvas/CanvasPattern.cpp:
(WebCore::CanvasPattern::setTransform):
* html/canvas/CanvasPattern.h:
* html/canvas/CanvasPattern.idl:
* platform/graphics/Pattern.h:

LayoutTests:

Moved the test previously known as canvas-pattern-transform.html to canvas-pattern-with-transform.html
and added a new test.

* fast/canvas/canvas-pattern-transform-expected.txt:
* fast/canvas/canvas-pattern-transform.html:
* fast/canvas/canvas-pattern-with-transform-expected.txt: Copied from LayoutTests/fast/canvas/canvas-pattern-transform-expected.txt.
* fast/canvas/canvas-pattern-with-transform.html: Copied from LayoutTests/fast/canvas/canvas-pattern-transform.html.
* fast/canvas/canvas-pattern-with-transform.js: Renamed from LayoutTests/fast/canvas/canvas-pattern-transform.js.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

23 months agoRemove unneeded ScriptController::processingUserGesture() forwarding functions
commit-queue@webkit.org [Thu, 23 Nov 2017 19:36:08 +0000 (19:36 +0000)]
Remove unneeded ScriptController::processingUserGesture() forwarding functions
https://bugs.webkit.org/show_bug.cgi?id=179954

Patch by Sam Weinig <sam@webkit.org> on 2017-11-23
Reviewed by Darin Adler.

Replace ScriptController::processingUserGesture() and ScriptController::processingUserGestureForMedia()
with direct calls to the corresponding UserGestureIndicator functions.

Source/WebCore:

* Modules/applepay/ApplePaySession.cpp:
(WebCore::ApplePaySession::create):
(WebCore::ApplePaySession::openPaymentSetup):
* Modules/speech/SpeechSynthesis.cpp:
(WebCore::SpeechSynthesis::speak):
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::processingUserGesture): Deleted.
(WebCore::ScriptController::processingUserGestureForMedia): Deleted.
* bindings/js/ScriptController.h:
* dom/Document.cpp:
(WebCore::Document::processingUserGestureForMedia const):
* html/BaseChooserOnlyDateAndTimeInputType.cpp:
(WebCore::BaseChooserOnlyDateAndTimeInputType::handleDOMActivateEvent):
* html/ColorInputType.cpp:
(WebCore::ColorInputType::handleDOMActivateEvent):
* html/FileInputType.cpp:
(WebCore::FileInputType::handleDOMActivateEvent):
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::submitFromJavaScript):
* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement):
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::submitForm):
(WebCore::shouldOpenExternalURLsPolicyToApply):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::allowPopUp):
(WebCore::DOMWindow::setLocation):
(WebCore::DOMWindow::createWindow):
(WebCore::DOMWindow::open):
* page/PointerLockController.cpp:
(WebCore::PointerLockController::requestPointerLock):

Source/WebKit:

* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::isProcessingUserGesture):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::addResourceRequest):

Source/WebKitLegacy/mac:

* Plugins/WebPluginController.mm:
(-[WebPluginController processingUserGesture]):
* WebView/WebView.mm:
(-[WebView _isProcessingUserGesture]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

23 months agoAdd a base class for HTMLCanvasElement and OffscreenCanvas
dino@apple.com [Thu, 23 Nov 2017 19:00:20 +0000 (19:00 +0000)]
Add a base class for HTMLCanvasElement and OffscreenCanvas
https://bugs.webkit.org/show_bug.cgi?id=179701
<rdar://problem/35545195>

Post-review updates from Darin Adler review.

* html/CanvasBase.cpp:
(WebCore::CanvasBase::asHTMLCanvasElement): Deleted. Replaced by having the call
sites get the reference and do the correct downcast<>.
* html/CanvasBase.h: Remove asHTMLCanvasElement. Add pure virtual ref/deref functions
so they can be overridden by subclasses. Unfortunately they can't be called ref/deref otherwise
they conflict with Node.
* html/HTMLCanvasElement.h: Add the type traits, so is<HTMLCanvasElement>(canvasBase) will
work.
* html/HTMLTagNames.in: Specify the <canvas> element as having custom type traits.
* html/OffscreenCanvas.h: Lots of overrides to finals.
* html/canvas/CanvasRenderingContext.cpp: Use canvasBase.de/refCanvasBase rather than
casting.
(WebCore::CanvasRenderingContext::ref):
(WebCore::CanvasRenderingContext::deref):
* html/canvas/CanvasRenderingContext.h: Lots of overrides to finals.
* html/canvas/CanvasRenderingContext2D.h:
* html/canvas/ImageBitmapRenderingContext.cpp:
(WebCore::ImageBitmapRenderingContext::canvas const):
* html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::create):
(WebCore::WebGLRenderingContextBase::canvas):
* html/canvas/WebGPURenderingContext.cpp:
(WebCore::WebGPURenderingContext::canvas const):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::recordCanvasAction):
* inspector/agents/InspectorCanvasAgent.cpp:
(WebCore::InspectorCanvasAgent::recordCanvasAction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

23 months agoWebSWServerConnection should register/unregister itself with the StorageProcess
cdumez@apple.com [Thu, 23 Nov 2017 17:51:46 +0000 (17:51 +0000)]
WebSWServerConnection should register/unregister itself with the StorageProcess
https://bugs.webkit.org/show_bug.cgi?id=179965

Reviewed by Darin Adler.

WebSWServerConnection should register/unregister itself with the StorageProcess instead of relying
on StorageToWebProcessConnection to do so on its behalf. This is less error-prone.

* StorageProcess/ServiceWorker/WebSWServerConnection.cpp:
(WebKit::WebSWServerConnection::WebSWServerConnection):
(WebKit::WebSWServerConnection::~WebSWServerConnection):
* StorageProcess/StorageToWebProcessConnection.cpp:
(WebKit::StorageToWebProcessConnection::~StorageToWebProcessConnection):
(WebKit::StorageToWebProcessConnection::establishSWServerConnection):
(WebKit::StorageToWebProcessConnection::removeSWServerConnection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

23 months agoReduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
darin@apple.com [Thu, 23 Nov 2017 17:32:42 +0000 (17:32 +0000)]
Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
https://bugs.webkit.org/show_bug.cgi?id=179907

Reviewed by Sam Weinig.

Source/JavaScriptCore:

* inspector/agents/InspectorDebuggerAgent.cpp:
(Inspector::matches): Removed explicit TextCaseSensitive because RegularExpression now
defaults to that.

* runtime/StringPrototype.cpp:
(JSC::stringIncludesImpl): Use String::find since there is no overload of
String::contains that takes a start offset now that we removed the one that took a
caseSensitive boolean. We can add one later if we like, but this should do for now.

* yarr/RegularExpression.h: Moved the TextCaseSensitivity enumeration here from
the StringImpl.h header because it is only used here.

Source/WebCore:

* Modules/plugins/YouTubePluginReplacement.cpp:
(WebCore::hasCaseInsensitivePrefix): Deleted.
(WebCore::processAndCreateYouTubeURL): Use startsWithLettersIgnoringASCIICase.

* Modules/websockets/WebSocketHandshake.cpp:
(WebCore::WebSocketHandshake::readHTTPHeaders): Use isAllASCII.

* accessibility/atk/AccessibilityObjectAtk.cpp:
(WebCore::AccessibilityObject::getLengthForTextRange const): Use text().length().

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::traverseToOffsetInRange): Use isHTMLSpace instead of
isSpaceOrNewline since the code is trying to skip collapsible HTML spaces, not
arbitrary Unicode whitespace.
* accessibility/AccessibilityList.cpp:
(WebCore::AccessibilityList::childHasPseudoVisibleListItemMarkers): Use
isAllSpecialCharacters<isHTMLSpace> for the same reason as above.

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::isSearchField const): Use containsIgnoringASCIICase.

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::accessibilityObjectContainsText const): Use
new findPlainText function exported from TextIterator so this can share the
same search matching logic used to find text in webpages.
(WebCore::AccessibilityObject::selectText): Use capitalize and its return value
rather than makeCapitalize modifying a string in place.

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::objectInclusionFromAltText): Use isAllSpecialCharacters<isHTMLSpace>
for the same reason as above.
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored const): Ditto.

* bindings/js/JSDOMConvertStrings.cpp:
(WebCore::stringToByteString): Use isAllLatin1.

* contentextensions/ContentExtensionParser.cpp:
(WebCore::ContentExtensions::containsOnlyASCIIWithNoUppercase): Use
StringView::codeUnits instead of String::at.

* contentextensions/ContentExtensionsBackend.cpp:
(WebCore::ContentExtensions::ContentExtensionsBackend::actionsForResourceLoad const):
Use isAllASCII.
* contentextensions/URLFilterParser.cpp:
(WebCore::ContentExtensions::URLFilterParser::addPattern): Ditto.

* css/CSSFontFaceSrcValue.cpp:
(WebCore::CSSFontFaceSrcValue::isSupportedFormat const): Use protocolIs and
endsWithIgnoringASCIICase.

* css/DOMCSSNamespace.cpp:
(WebCore::valueWithoutImportant): Use endsWithIgnoringASCIICase.

* css/parser/CSSPropertyParser.cpp:
(WebCore::parseGridTemplateAreasRow): Use isAllSpecialCharacters<isCSSSpace>,
for the preflight, which matches what the actual parsing code uses.

* dom/CharacterData.cpp:
(WebCore::CharacterData::containsOnlyWhitespace const): Deleted. Callers can
efficiently get at the data and do this kind of check on the data directly.
* dom/CharacterData.h: Updated for the above.

* dom/DataTransfer.cpp:
(WebCore::normalizeType): Use startsWith since the string is already converted
to ASCII lowercase.

* dom/Position.cpp:
(WebCore::Position::leadingWhitespacePosition const): Use isHTMLSpace since
since the code is trying to check for collapsible HTML spaces, not general
Unicode spaces. Other call sites of isSpaceOrNewline need to be checked for
this, but I did not fix them all at this time.
(WebCore::Position::trailingWhitespacePosition const): Ditto.

* editing/Editor.cpp:
(WebCore::Editor::editorUIUpdateTimerFired): Use noBreakSpace.

* editing/FrameSelection.cpp:
(WebCore::FrameSelection::debugRenderer const): Use text().length() instead
of textLength.
(WebCore::FrameSelection::selectionAtWordStart const): Use noBreakSpace.
(WebCore::FrameSelection::wordSelectionContainingCaretSelection): Ditto.
(WebCore::FrameSelection::actualSelectionAtSentenceStart const): Ditto.

* editing/TextIterator.cpp:
(WebCore::textNodeOffsetInFlow): Use text().length().
(WebCore::TextIterator::handleTextNode): Ditto.
(WebCore::collapsedSpaceLength): Updated since RenderText::text now returns
a reference rather than a pointer.
(WebCore::findPlainText): Added. Uses SearchBuffer to search for one string
within another. Exported so accessibility code can do this operation.
* editing/TextIterator.h: Updated for the above.

* editing/TypingCommand.cpp:
(WebCore::TypingCommand::markMisspellingsAfterTyping): Use noBreakSpace.

* editing/VisibleUnits.cpp:
(WebCore::findStartOfParagraph): Updated since RenderText::text now returns
a reference.
(WebCore::findEndOfParagraph): Ditto.

* editing/cocoa/HTMLConverter.mm:
(HTMLConverter::_processText): Use String::characterAt instead of String::at.
Use capitalize instead of makeCapitalized.

* editing/cocoa/WebContentReaderCocoa.mm:
(WebCore::stripMicrosoftPrefix): Use findIgnoringASCIICase.

* html/Autofill.cpp:
(WebCore::AutofillData::createFromHTMLFormControlElement): Use
startsWithLettersIgnoringASCIICase.

* html/BaseTextInputType.cpp:
(WebCore::BaseTextInputType::patternMismatch const): Removed explicit
TextCaseSensitive since it now is the default, and needed to touch this anyway
because the enumeration is now in a different namespace.

* html/EmailInputType.cpp:
(WebCore::isValidEmailAddress): Updated to use JSC::Yarr::TextCaseInsensitive.

* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::hasFallbackContent const): Use
isAllSpecialCharacters<isHTMLSpace>.
(WebCore::HTMLObjectElement::shouldAllowQuickTimeClassIdQuirk): Use
startsWithLettersIgnoringASCIICase.
(WebCore::HTMLObjectElement::hasValidClassId): Use protocolIs.
(WebCore::preventsParentObjectFromExposure): Use isAllSpecialCharacters<isHTMLSpace>.

* html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::setCompatibilityModeFromDoctype):
Use startsWithLettersIgnoringASCIICase.

* html/parser/HTMLMetaCharsetParser.cpp:
(WebCore::extractCharset): Use findIgnoringASCIICase.

* html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::isContainedInRequest): Use containsIgnoringASCIICase.

* html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::hasRequiredFileIdentifier): Don't pass the length to
the String::startsWith function. There has never been a version of that function
that takes the length, there is no need to pass the length since the function
handles null-terminated strings like the one here, and in the past the length
has been getting converted to a boolean making the comparison be case sensitive.
Removing the argument entirely leaves it case sensitive.

* inspector/InspectorNodeFinder.cpp:
(WebCore::InspectorNodeFinder::matchesElement): Use startsWithIgnoringASCIICase
and endsWithIgnoringASCIICase.

* inspector/InspectorStyleSheet.cpp:
(WebCore::selectorsFromSource): Use JSC::Yarr::TextCaseSensitive.

* inspector/agents/InspectorDOMAgent.cpp:
(WebCore::containsOnlyHTMLWhitespace): Made this a non-member function
and reimplemented using isAllSpecialCharacters<isHTMLSpace>().
(WebCore::InspectorDOMAgent::innerFirstChild): Use containsOnlyHTMLWhitespace.
(WebCore::InspectorDOMAgent::innerNextSibling): Ditto.
(WebCore::InspectorDOMAgent::innerPreviousSibling): Ditto.
(WebCore::InspectorDOMAgent::innerChildNodeCount): Ditto.
(WebCore::InspectorDOMAgent::didInsertDOMNode): Ditto.
(WebCore::InspectorDOMAgent::didRemoveDOMNode): Ditto.
* inspector/agents/InspectorDOMAgent.h: Updated for above change.

* loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::ApplicationCacheStorage::shouldStoreResourceAsFlatFile):
Use startsWithLettersIgnoringASCIICase.

* page/Base64Utilities.cpp:
(WebCore::Base64Utilities::btoa): Use isAllLatin1.

* page/Frame.cpp:
(WebCore::createRegExpForLabels): Removed TextCaseSensitive argument since
that is now the default and also used JSC::Yarr::TextCaseInsensitive.
(WebCore::matchLabelsAgainstString): More of the same.

* page/FrameView.cpp:
(WebCore::countRenderedCharactersInRenderObjectWithThreshold): Use
text().length().

* page/SecurityOrigin.cpp:
(WebCore::isFeedWithNestedProtocolInHTTPFamily): Use
startsWithLettersIgnoringASCIICase.

* page/UserContentURLPattern.cpp:
(WebCore::UserContentURLPattern::matchesHost const):
Use endsWithIgnoringASCIICase.
* page/csp/ContentSecurityPolicySource.cpp:
(WebCore::ContentSecurityPolicySource::hostMatches const): Ditto.

* page/csp/ContentSecurityPolicySourceList.cpp:
(WebCore::ContentSecurityPolicySourceList::parseNonceSource):
Use startsWithIgnoringASCIICase.

* page/ios/FrameIOS.mm:
(WebCore::Frame::wordsInCurrentParagraph const): Use noBreakSpace.

* platform/ContentType.cpp:
(WebCore::ContentType::parameter const): Use findIgnoringASCIICase.

* platform/MIMETypeRegistry.cpp:
(WebCore::MIMETypeRegistry::isSupportedFontMIMEType): Use
startsWithLettersIgnoringASCIICase.
(WebCore::MIMETypeRegistry::isSupportedJSONMIMEType): Use
mimeType.endsWithIgnoringASCIICase.
(WebCore::MIMETypeRegistry::isTextMIMEType): Use
startsWithLettersIgnoringASCIICase.
(WebCore::MIMETypeRegistry::isXMLMIMEType): Use endsWithIgnoringASCIICase.
(WebCore::MIMETypeRegistry::isJavaAppletMIMEType): Use
startsWithLettersIgnoringASCIICase.
(WebCore::MIMETypeRegistry::canShowMIMEType): Ditto.

* platform/URL.cpp:
(WebCore::isAllASCII): Renamed from containsOnlyASCII.
(WebCore::appendEncodedHostname): Use isAllASCII.

* platform/URLParser.cpp:
(WebCore::containsOnlyASCII): Deleted.
(WebCore::URLParser::domainToASCII): Use StringImpl::isAllASCII. Changed
to take StringImpl& to guarantee we won't keep doing null checks since
the caller already checks for null.
(WebCore::URLParser::parseHostAndPort): Pass StringImpl&.
* platform/URLParser.h: Updated for above.

* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::supportsType): Use endsWithIgnoringASCIICase
and startsWithLettersIgnoringASCIICase.

* platform/graphics/avfoundation/CDMPrivateMediaSourceAVFObjC.mm:
(WebCore::validKeySystemRE): Use JSC::Yarr::TextCaseInsensitive.

* platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::FontCache::similarFont): Use containsIgnoringASCIICase for
the Geeza font special cases.

* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::shouldRejectMIMEType): Use startsWithLettersIgnoringASCIICase.

* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::getUnmangledInfoLog): Removed
TextCaseSensitive since it now is the default.

* platform/mac/PublicSuffixMac.mm:
(WebCore::topPrivatelyControlledDomain): Use isAllASCII.

* platform/mac/SSLKeyGeneratorMac.mm:
(WebCore::signedPublicKeyAndChallengeString): Use isAllASCII.

* platform/mac/StringUtilities.mm:
(WebCore::stringMatchesWildcardString): Use JSC::Yarr::TextCaseInsensitive.

* platform/mediastream/RealtimeMediaSourceCenter.cpp:
(WebCore::addStringToSHA1): Use isAllASCII.

* platform/network/CacheValidation.cpp:
(WebCore::parseCacheControlDirectives): Use containsIgnoringASCIICase.

* platform/network/HTTPParsers.cpp:
(WebCore::parseHTTPRefresh): Use findIgnoringASCIICase.
(WebCore::findCharsetInMediaType): Ditto.
(WebCore::parseRange): Use startsWithLettersIgnoringASCIICase.

* platform/network/curl/AuthenticationChallengeCurl.cpp:
(WebCore::AuthenticationChallenge::protectionSpaceFromHandle):
Use findIgnoringASCIICase.
* platform/network/curl/MultipartHandle.cpp:
(WebCore::MultipartHandle::extractBoundary): Ditto.
* platform/network/curl/ResourceHandleCurlDelegate.cpp:
(WebCore::ResourceHandleCurlDelegate::handleDataURL): Use
endsWithIgnoringASCIICase.
* platform/network/curl/ResourceResponseCurl.cpp:
(WebCore::ResourceResponse::isAppendableHeader): Use
startsWithLettersIgnoringASCIICase.
(WebCore::ResourceResponse::appendHTTPHeaderField): Ditto.

* platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::extractMarkupFromCFHTML): Use findIgnoringASCIICase.
(WebCore::fragmentFromCFHTML): Ditto.

* rendering/BidiRun.cpp:
(WebCore::BidiRun::BidiRun): Use text().length().
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::absolutePDFURL const): Use
endsWithIgnoringASCIICase.
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::placeBoxRangeInInlineDirection): Use text().length().
* rendering/InlineIterator.h:
(WebCore::InlineIterator::fastIncrementInTextNode): Ditto.
(WebCore::InlineIterator::increment): Dtto.
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::isLineBreak const): Updated since RenderText::text
now returns a StringImpl&.
(WebCore::InlineTextBox::selectionStartEnd const): Use text().length().
(WebCore::InlineTextBox::text const): Updated since RenderText::text
now returns a StringImpl&.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::constructTextRun): Use text().length().
* rendering/RenderBlockFlow.cpp:
(WebCore::isVisibleRenderText): Use isAllSpecialCharacters<isHTMLSpace>().
(WebCore::RenderBlockFlow::computeInlinePreferredLogicalWidths const):
Use the new trimmedPreferredWidths that returns a structure instead of the
old one with lots of arguments. Also use text().length().
* rendering/RenderBlockLineLayout.cpp:
(WebCore::endsWithHTMLSpaces): Renamed and changed to use isHTMLSpace
instead of isASCIISpace.
(WebCore::reachedEndOfTextRenderer): Use endsWithHTMLSpaces.
(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForSegment):
Updated for hcanges to RenderText.
(WebCore::RenderBlockFlow::handleTrailingSpaces): Ditto.
(WebCore::RenderBlockFlow::determineStartPosition): Ditto.

* rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::combineTextIfNeeded): Use
isAllSpecialCharacters<isHTMLSpace>.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects const): Ditto.

* rendering/RenderListBox.cpp:
(WebCore::bolder): Added. Helper function.
(WebCore::RenderListBox::updateFromElement): Rewrote to
only compute the bolder font once rather than for every item.
(WebCore::RenderListBox::paintItemForeground): Updated for
change to applyTextTransform.

* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::adjustInnerStyle): Updated for change
to RenderText::text.
(RenderMenuList::updateOptionsWidth): Updated for change to
applyTextTransform.
(RenderMenuList::itemText const): Ditto.

* rendering/RenderText.cpp:
(WebCore::capitalize): Renamed from makeCapitalized. Changed to
take and return a String instead of taking a String*.
(WebCore::RenderText::RenderText): Use isAllASCII. Also moved
initialization of most non-bitfield members to the class definition.
(WebCore::RenderText::positionForPoint): Use text().
(WebCore::RenderText::widthFromCache const): Ditto.
(WebCore::RenderText::hangablePunctuationStartWidth const): Ditto.
(WebCore::RenderText::hangablePunctuationEndWidth const): Ditto.
(WebCore::RenderText::isHangableStopOrComma): Ditto.
(WebCore::RenderText::firstCharacterIndexStrippingSpaces const): Ditto.
(WebCore::RenderText::lastCharacterIndexStrippingSpaces const): Ditto.
(WebCore::RenderText::trimmedPreferredWidths): Changed to return values
in a structure instead of taking lots of arguments.
(WebCore::RenderText::computePreferredLogicalWidths): Updated to use
the text() function.
(WebCore::isAllCollapsibleWhitespace): Added.
(WebCore::RenderText::isAllCollapsibleWhitespace const): Updated to
use a tighter loop.
(WebCore::isAllPossiblyCollapsibleWhitespace): Added.
(WebCore::RenderText::containsOnlyHTMLWhitespace const): Updated to
use a tighter loop. Renamed from containsOnlyWhitespace.
(WebCore::RenderText::setTextWithOffset): Updated to  use text().
(WebCore::isInlineFlowOrEmptyText): Rewrote to be easier to read.
(WebCore::RenderText::previousCharacter const): Got rid of unneeded
null check and simplified.
(WebCore::applyTextTransform): Changed to return a String rather
than modifying one that is passed in.
(WebCore::RenderText::setRenderedText): Updated use of applyTextTransform.
(WebCore::RenderText::secureText): More of the same.
(WebCore::RenderText::computeCanUseSimplifiedTextMeasuring const): Ditto.
(WebCore::RenderText::textWithoutConvertingBackslashToYenSymbol const): Ditto.
(WebCore::RenderText::width const): Ditto.
(WebCore::RenderText::collectSelectionRectsForLineBoxes): Ditto.
(WebCore::RenderText::previousOffset const): Ditto.
(WebCore::RenderText::previousOffsetForBackwardDeletion const): Ditto.
(WebCore::RenderText::nextOffset const): Ditto.
(WebCore::RenderText::computeCanUseSimpleFontCodePath const): Ditto.
(WebCore::RenderText::stringView const): Ditto.

* rendering/RenderText.h: Made some more members private and final.
Updated for above, including adding the Widths structure. Got rid of the
textLength function, which existed as a workaround before we could mark
a function like length final. Made the text function return a StringImpl&,
which is good since the m_text string is never null, and so callers end
up using StringImpl directly and saving null checks. Removed functions
that are not needed, including is8Bit, characters8, characters16,
uncheckedCharacterAt, operator[], and isAllASCII.

* rendering/RenderTextFragment.cpp:
(WebCore::RenderTextFragment::setText): Use text().length().
* rendering/RenderTextLineBoxes.cpp:
(WebCore::RenderTextLineBoxes::caretMaxOffset const): Ditto.
(WebCore::RenderTextLineBoxes::positionForPoint const): Ditto.
(WebCore::RenderTextLineBoxes::setSelectionState): Ditto.
(WebCore::RenderTextLineBoxes::absoluteQuads const): Ditto.
* rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseForFontAndText): Ditto.
* rendering/SimpleLineLayoutCoverage.cpp:
(WebCore::SimpleLineLayout::textLengthForSubtree): Ditto.
(WebCore::SimpleLineLayout::collectNonEmptyLeafRenderBlockFlows): Ditto.
* rendering/SimpleLineLayoutFlowContents.cpp:
(WebCore::SimpleLineLayout::initializeSegments): Ditto.
* rendering/SimpleLineLayoutFunctions.cpp:
(WebCore::SimpleLineLayout::textOffsetForPoint): Ditto.
* rendering/SimpleLineLayoutFunctions.h:
(WebCore::SimpleLineLayout::findCaretMaximumOffset): Ditto.
* rendering/line/BreakingContext.h:
(WebCore::shouldAddBorderPaddingMargin): Ditto.
(WebCore::shouldSkipWhitespaceAfterStartObject): Ditto.
(WebCore::iteratorIsBeyondEndOfRenderCombineText): Ditto.
(WebCore::textWidth): Ditto.
(WebCore::BreakingContext::handleText): Ditto.
(WebCore::BreakingContext::optimalLineBreakLocationForTrailingWord): Ditto.
* rendering/line/TrailingObjects.cpp:
(WebCore::TrailingObjects::updateWhitespaceCollapsingTransitionsForTrailingBoxes): Ditto.

* rendering/mathml/RenderMathMLFenced.cpp:
(WebCore::RenderMathMLFenced::updateFromElement): Removed stray use of "unsigned int".

* rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::characterStartsNewTextChunk const): Use text().length().
(WebCore::RenderSVGInlineText::positionForPoint): Ditto.
* rendering/svg/SVGTextLayoutAttributesBuilder.cpp:
(WebCore::processRenderSVGInlineText): Ditto.
* rendering/svg/SVGTextLayoutEngine.cpp:
(WebCore::SVGTextLayoutEngine::currentLogicalCharacterAttributes): Ditto.
* rendering/svg/SVGTextQuery.cpp:
(WebCore::SVGTextQuery::modifyStartEndPositionsRespectingLigatures const): Ditto.

* style/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::updateRenderTree): Use isAllSpecialCharacters<isHTMLSpace>.
(WebCore::RenderTreeUpdater::textRendererIsNeeded): Ditto.

* svg/SVGTests.cpp:
(WebCore::SVGTests::hasFeatureForLegacyBindings): Use startsWithLettersIgnoringASCIICase.
* xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::shouldAllowExternalLoad): Ditto.

Source/WebKit:

* NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::isMediaMIMEType): Use startsWithLettersIgnoringASCIICase.
* NetworkProcess/cache/NetworkCacheKey.cpp:
(WebKit::NetworkCache::hashString): Use isAllASCII..
* UIProcess/API/C/WKWebsitePolicies.cpp:
(WKWebsitePoliciesSetCustomHeaderFields): Use startsWithLettersIgnoringASCIICase..
* UIProcess/API/Cocoa/_WKWebsitePolicies.mm:
(-[_WKWebsitePolicies setCustomHeaderFields:]): Ditto.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::savePDFToFileInDownloadsFolder): Use endsWithIgnoringASCIICase.
* UIProcess/WebPreferences.cpp:
(WebKit::WebPreferences::WebPreferences): Initialize m_identifier explicitly. Somehow
changing the String default constructor to be "= default" led to a warning that we
otherwise did not get about not initializing m_identifier. Arguably a compiler bug,
but legitimately strange that the copy constructor does not copy m_identifier and so
nice to be explicit about it, I guess.
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::savePDFToTemporaryFolderAndOpenWithNativeApplicationRaw): Use
endsWithIgnoringASCIICase.
(WebKit::WebPageProxy::openPDFFromTemporaryFolderWithNativeApplication): Ditto.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin): Ditto.
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::platformEditorState const): Use isAllSpecialCharacters<isHTMLSpace>.

Source/WebKitLegacy/mac:

* History/BinaryPropertyList.cpp:
(BinaryPropertyListPlan::writeStringObject): Use isAllASCII.
(BinaryPropertyListSerializer::appendStringObject): Ditto.
* WebView/WebHTMLRepresentation.mm:
(regExpForLabels): Removed TextCaseSensitive since it is now the default.
(matchLabelsAgainstString): Use JSC::Yarr::TextCaseInsensitive.

Source/WebKitLegacy/win:

* Plugins/PluginDatabaseWin.cpp:
(WebCore::PluginDatabase::getPluginPathsInDirectories const): Use
startsWithLettersIgnoringASCIICase and endsWithIgnoringASCIICase.
* WebDownloadCFNet.cpp:
(WebDownload::initToResumeWithBundle): Use endsWithIgnoringASCIICase.

* WebView.cpp:
(WebView::markAllMatchesForText): Fix old code that was passing TextCaseSensitivity
to a function that actually takes FindOptions. By luck, TextCaseSensitive happens to
be 0, which is correct FindOptions for case sensitive matching, and TextCaseInsensitive
happens to be 1, which is correct FindOptions for case insensitive matching, so fixing
the code does not cause any change in behavior.

Source/WTF:

* wtf/text/ASCIIFastPath.h: Moved the using for charactersAreAllASCII here since
the function is defined here.

* wtf/text/AtomicString.h: Removed overloads of contains, find, startsWith, and
endsWith that take a boolean indicating whether they should be "case sensitive".
When false, this was doing Unicode case folding, and no callers needed that.
Also tweaked formatting and argument names.

* wtf/text/IntegerToStringConversion.h: Added an include of LChar.h since this file
uses that. Also tweaked formatting a bit.

* wtf/text/StringImpl.cpp:
(WTF::StringImpl::containsOnlyWhitespace): Deleted. Despite its name sounding like
it used the full Unicode whitespace definition, this actually checked isASCIISpace.
Callers now all use isAllSpecialCharacters instead with the whitespace definition
that is appropriate to each call site.
(WTF::latin1CaseFoldTable): Deleted.
(WTF::equalCompatibilityCaseless): Deleted.
(WTF::StringImpl::findIgnoringCase): Deleted.
(WTF::findIgnoringCaseInner): Deleted.
(WTF::reverseFindIgnoringCaseInner): Deleted.
(WTF::StringImpl::reverseFindIgnoringCase): Deleted.
(WTF::equalInner): Removed boolean caseSensitive argument.
(WTF::StringImpl::startsWith): Ditto.
(WTF::StringImpl::endsWith): Ditto.

* wtf/text/StringImpl.h: Moved TextCaseSensitivity out into a different header.
Moved ASCIIFastPath.h include here from WTFString.h. Moved isAllSpecialCharacters
free function here from WTFString.h. Moved lots of function bodies out of class
definitions to make the class definitions easier to read. Sorted things a bit.
Tweaked formatting. Marked constructor that takes one argument explicit. Added
an isEmpty function like the one in String. Renamed copyChars to copyCharacters.
Added isAllASCII, isAllLatin1 and isAllSpecialCharacters functions. Removed
boolean caseSensitive arguments from various functions. Removed findIgnoringCase
and reverseFindIgnoringCase. Added a FIXME to codePointCompare about the way it
treats null and empty strings as equal. Changed length argument in remove to
unsigned to match other lengths.

* wtf/text/WTFString.cpp:
(WTF::String::removeInternal): Changed length argument to be unsigned.
(WTF::createWithFormatAndArguments): Use emptyString.
(WTF::String::isSafeToSendToAnotherThread const): Rewrote to be easier to read.

* wtf/text/WTFString.h: Moved ASCIIFastPath.h to StringImpl.h. Moved lots of
function bodies out of class definitions to make the class definitions easier
to read, made others one-liners. Removed the String::at function but kept the
String::characterAt function; the two were identical. Removed boolean
caseSensitive arguments from various functions. Removed findIgnoringCase and
reverseFindIgnoringCase. Renamed containsOnlyASCII to isAllASCII and
containsOnlyLatin1 to isAllLatin1 to match the naming of isAllSpecialCharacters.
Moved the inline implementations of functions that are defined above further
down, after things like the ASCIILiteral class and various functions.

* wtf/text/icu/UTextProviderLatin1.cpp: Updated name of copyChars.

Tools:

* DumpRenderTree/mac/DumpRenderTree.mm:
(changeWindowScaleIfNeeded): Use containsIgnoringASCIICase.
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::urlContains const): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

23 months ago[WPE] Mark media/media-source/media-source-paint-to-canvas.html as passing.
Ms2ger@igalia.com [Thu, 23 Nov 2017 15:50:13 +0000 (15:50 +0000)]
[WPE] Mark media/media-source/media-source-paint-to-canvas.html as passing.
https://bugs.webkit.org/show_bug.cgi?id=178706

Unreviewed test gardening.

It has passed since r225060.

* platform/wpe/TestExpectations:

[WPE] Re-enable fast/dom/Document/CaretRangeFromPoint/replace-element.html.
https://bugs.webkit.org/show_bug.cgi?id=176820

Unreviewed test gardening.

The test started passing again in r221974.

* platform/wpe/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

23 months ago[CoordGraphics] Simplify CoordinatedGraphicsLayer's content buffer updates
zandobersek@gmail.com [Thu, 23 Nov 2017 14:19:52 +0000 (14:19 +0000)]
[CoordGraphics] Simplify CoordinatedGraphicsLayer's content buffer updates
https://bugs.webkit.org/show_bug.cgi?id=179972

Reviewed by Carlos Garcia Campos.

Source/WebCore:

During layer flushes, when a CoordinatedGraphicsLayer's tiled backing store
has dirty tiles that need to be updated, the following chain of calls would
be invoked to perform the painting, starting in
CoordinatedGraphicsLayer::updateContentBuffers():
|- CoordinatedGraphicsLayer::updateContentBuffers()
 |- TiledBackingStore::updateTileBuffers()
  |- Tile::updateBackBuffer()
   |- CoordinatedGraphicsLayer::paintToSurface()
    |- CompositingCoordinator::paintToSurface()
     |- UpdateAtlas::paintOnAvailableBuffer()
      |- ThreadSafeCoordinatedSurface::paintToSurface()
       |- Tile::paintToSurfaceContext()
        |- CoordinatedGraphicsLayer::tiledBackingStorePaint()
         |- GraphicsLayer::paintGraphicsLayerContents()

That's a bit much.

In CoordinatedGraphicsLayer::updateContentBuffers(), we now first retrieve
all the dirty layers in our TiledBackingStore. We then iterate through them,
first establishing their ID and then retrieving an available CoordinatedBuffer
that we can use for painting. The CoordinatedBuffer is retrieved through
CompositingCoordinator, which is still caching these buffers via UpdateAtlas
objects.

With a CoordinatedBuffer available, we can then proceed with painting. The
painting context has to be properly set up to paint into the correct area of
the given buffer, and the alpha channel, if necessary, has to be addressed.
After properly positioning and scaling ourselves on the given context, we
can proceed with the GraphicsLayer::paintGraphicsLayerContents() call.

What's left is filling out the missing SurfaceUpdateInfo information which is
then passed to the updateTile() method that properly registers the tile
update we've just performed. The tile itself is marked clean. After the
iteration, we call the didUpdateTileBuffers() method in case any successful
tile update was indeed performed, incrementing the repaint counter.

That's it -- we clipped 8 calls from the call chain. We can now also remove
the CoordinatedBuffer::Client interface, as well as slim down the
TiledBackingStore interface. The Tile class is cleaned up a bit, with methods
shifted into a more sensible order.

No new tests -- no change in functionality.

* platform/graphics/texmap/coordinated/CoordinatedBuffer.cpp:
* platform/graphics/texmap/coordinated/CoordinatedBuffer.h:
* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::didUpdateTileBuffers):
(WebCore::CoordinatedGraphicsLayer::updateContentBuffers):
(WebCore::CoordinatedGraphicsLayer::tiledBackingStorePaint): Deleted.
(WebCore::CoordinatedGraphicsLayer::paintToSurface): Deleted.
* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
* platform/graphics/texmap/coordinated/Tile.cpp:
(WebCore::Tile::ensureTileID):
(WebCore::Tile::isDirty const):
(WebCore::Tile::invalidate):
(WebCore::Tile::markClean):
(WebCore::Tile::updateBackBuffer): Deleted.
(WebCore::Tile::paintToSurfaceContext): Deleted.
* platform/graphics/texmap/coordinated/Tile.h:
(WebCore::Tile::tileID const):
(WebCore::Tile::dirtyRect const):
* platform/graphics/texmap/coordinated/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::dirtyTiles):
(WebCore::TiledBackingStore::updateTileBuffers): Deleted.
* platform/graphics/texmap/coordinated/TiledBackingStore.h:
* platform/graphics/texmap/coordinated/TiledBackingStoreClient.h:

Source/WebKit:

In CompositingCoordinator, add the getCoordinatedBuffer() method, replacing
paintToSurface(). The new method traverses the list of UpdateAtlases and
returns any CoordinatedBuffer object that was free to use. If none exist,
a new UpdateAtlas object is created, and its CoordinatedBuffer is returned.

In  UpdateAtlas, the paintOnAvailableBuffer() method is replaced with
getCoordinatedBuffer(). The latter allocates the necessary area but then
returns a reference to the CoordinatedBuffer buffer, along with the atlas ID
and the allocated rectangle information, and does not invoke any painting
operation like paintOnAvailableBuffer() did.

* WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:
(WebKit::CompositingCoordinator::getCoordinatedBuffer):
(WebKit::CompositingCoordinator::paintToSurface): Deleted.
* WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h:
* WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.cpp:
(WebKit::UpdateAtlas::getCoordinatedBuffer):
(WebKit::UpdateAtlas::paintOnAvailableBuffer): Deleted.
* WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

23 months ago[WPE] Re-enable fast/dom/Document/CaretRangeFromPoint/replace-element.html.
Ms2ger@igalia.com [Thu, 23 Nov 2017 13:09:26 +0000 (13:09 +0000)]
[WPE] Re-enable fast/dom/Document/CaretRangeFromPoint/replace-element.html.
https://bugs.webkit.org/show_bug.cgi?id=176820

Unreviewed test gardening.

The test started passing again in r221974.

* platform/wpe/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

23 months ago[CoordGraphics] Remove relay CoordinatedBuffer::Client implementations
zandobersek@gmail.com [Thu, 23 Nov 2017 11:04:05 +0000 (11:04 +0000)]
[CoordGraphics] Remove relay CoordinatedBuffer::Client implementations
https://bugs.webkit.org/show_bug.cgi?id=179970

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Drop CoordinatedBuffer::painToSurface() in favor of a simpler
GraphicsContext reference getter that returns a reference to the
GraphicsContext object of the internal ImageBuffer.

Remove the ImageBackingSurfaceClient class that only acted as a relay
that enabled a CoordinatedBuffer to draw an image through its context.
Instead, we use the GraphicsContext of the allocated CoordinatedBuffer
to draw the image directly. We still use a rectangle whose size
matches the size of the given Image as the clipping area and as the
source and destination rectangle for the image.

No new tests -- no change in behavior.

* platform/graphics/texmap/coordinated/CoordinatedBuffer.cpp:
(WebCore::CoordinatedBuffer::context):
(WebCore::CoordinatedBuffer::paintToSurface): Deleted.
* platform/graphics/texmap/coordinated/CoordinatedBuffer.h:
* platform/graphics/texmap/coordinated/CoordinatedImageBacking.cpp:
(WebCore::CoordinatedImageBacking::update):
(WebCore::ImageBackingSurfaceClient::ImageBackingSurfaceClient): Deleted.

Source/WebKit:

Drop the helper UpdateAtlasSurfaceClient class and instead directly use
the CoordinatedBuffer's GraphicsContext to perform clip and translation
operations based on the allocated rectangle, to pre-fill the target rect
with transparent color in case the alpha channel is supported, and to
then invoke CoordinatedBuffer::Client::paintToSurfaceContext() method,
passing the GraphicsContext as the argument.

* WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.cpp:
(WebKit::UpdateAtlas::paintOnAvailableBuffer):
(): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

23 months ago[CoordGraphics] TiledBackingStore: use a reference to the client
zandobersek@gmail.com [Thu, 23 Nov 2017 11:01:11 +0000 (11:01 +0000)]
[CoordGraphics] TiledBackingStore: use a reference to the client
https://bugs.webkit.org/show_bug.cgi?id=179969

Reviewed by Carlos Garcia Campos.

TiledBackingStore should keep a C++ reference to the TiledBackingStoreClient
object, and not a pointer. client() method is updated to reflect that, and
uses of this method and the member variable are updated accordingly.

No new tests -- no change in behavior.

* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::createBackingStore):
* platform/graphics/texmap/coordinated/Tile.cpp:
(WebCore::Tile::~Tile):
(WebCore::Tile::updateBackBuffer):
(WebCore::Tile::paintToSurfaceContext):
* platform/graphics/texmap/coordinated/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::TiledBackingStore):
(WebCore::TiledBackingStore::updateTileBuffers):
(WebCore::TiledBackingStore::createTiles):
* platform/graphics/texmap/coordinated/TiledBackingStore.h:
(WebCore::TiledBackingStore::client):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

23 months ago[CoordGraphics] Early tile buffer update in TiledBackingStore::createTiles() is unnec...
zandobersek@gmail.com [Thu, 23 Nov 2017 11:00:32 +0000 (11:00 +0000)]
[CoordGraphics] Early tile buffer update in TiledBackingStore::createTiles() is unnecessary
https://bugs.webkit.org/show_bug.cgi?id=179968

Reviewed by Carlos Garcia Campos.

Under CoordinatedGraphicsLayer::updateContentBuffers(), the TiledBackingStore
object has the createTilesIfNeeded() method invoked, if necessary. This
invokes createTiles(), where the edge tiles are resized if necessary, and
the missing tiles are created. If any of those two cases is fulfilled, the
updateTileBuffers() method is invoked, updating any dirty tiles (i.e. the
ones that were resized or newly-created).

This specific invocation of updateTileBuffers() is not needed since it's the
very next method that's invoked on the TiledBackingStore object by
CoordinatedGraphicsLayer::updateContentBuffers(). It's therefore removed,
and the resizeEdgeTiles() method is changed to not return any value.

No new tests -- no change in behavior.

* platform/graphics/texmap/coordinated/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::createTiles):
(WebCore::TiledBackingStore::resizeEdgeTiles):
* platform/graphics/texmap/coordinated/TiledBackingStore.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

23 months agoRenderBlockFlow::layoutRunsAndFloatsInRange is O(n^2) for runs of inlines without...
antti@apple.com [Thu, 23 Nov 2017 10:45:26 +0000 (10:45 +0000)]
RenderBlockFlow::layoutRunsAndFloatsInRange is O(n^2) for runs of inlines without any text
https://bugs.webkit.org/show_bug.cgi?id=179950

Reviewed by Simon Fraser.

It calls createBidiRunsForLine for each line. createBidiRunsForLine traverses past the end of the line until
it finds the end of the current bidi run. If there is no text in the flow, it never finds anything and traverses
the entire flow. This is O(n^2) for the number of renderers in the flow.

Tested by PerformanceTests/Layout/inline-layout-no-text.html

* platform/text/BidiResolver.h:
(WebCore::BidiResolverBase::needsContinuePastEnd const):
(WebCore::BidiResolverBase::needsContinuePastEndInternal const):
(WebCore::DerivedClass>::createBidiRunsForLine):

    When past end of line call needsContinuePastEnd() to see if we need to continue searching for the end of the bidi run.

* rendering/InlineIterator.h:
(WebCore::InlineBidiResolver::needsContinuePastEndInternal const):

    InlineBidiResolver only returns runs up to the last renderer on the line and can bail out.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

23 months ago[WPE] Enable some more wpt tests.
Ms2ger@igalia.com [Thu, 23 Nov 2017 10:31:07 +0000 (10:31 +0000)]
[WPE] Enable some more wpt tests.
https://bugs.webkit.org/show_bug.cgi?id=179939

Reviewed by Žan Doberšek.

* TestExpectations: Add the number of a bug I filed.
* platform/wpe/TestExpectations: Enable some smaller top-level wpt
  directories.
* platform/wpe/imported/w3c/web-platform-tests/FileAPI/historical.https-expected.txt:
  Added: Service Workers are not yet enabled for WPE, which affects the
  results of this test in a harmless way.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

23 months ago[CoordGraphics] Replace CoordinatedSurface, ThreadSafeCoordinatedSurface with Coordin...
zandobersek@gmail.com [Thu, 23 Nov 2017 09:17:08 +0000 (09:17 +0000)]
[CoordGraphics] Replace CoordinatedSurface, ThreadSafeCoordinatedSurface with CoordinatedBuffer
https://bugs.webkit.org/show_bug.cgi?id=179967

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Roll the CoordinatedSurface and ThreadSafeCoordinatedSurface classes
into one CoordinatedBuffer class.

CoordinatedBuffer class mimics CoordinatedSurface in providing the
Client class that allows specifying how the client should paint using a
GraphicsContext object. supportsAlpha() and size() methods are also
present, as well as paintToSurface(). uploadImage() retrieves the
Image that's created from the contained ImageBuffer, allowing the user
to then manually upload the buffer data onto the GPU.

CoordinatedBuffer otherwise serves as a drop-in replacement for the
CoordinatedSurface class, and the remaining changes in the
CoordiantedGraphics code reflect that.

No new tests -- no change in behavior.

* platform/TextureMapper.cmake:
* platform/graphics/texmap/coordinated/CoordinatedBuffer.cpp: Added.
(WebCore::CoordinatedBuffer::create):
(WebCore::CoordinatedBuffer::CoordinatedBuffer):
(WebCore::CoordinatedBuffer::paintToSurface):
(WebCore::CoordinatedBuffer::uploadImage):
* platform/graphics/texmap/coordinated/CoordinatedBuffer.h: Added.
(WebCore::CoordinatedBuffer::supportsAlpha const):
(WebCore::CoordinatedBuffer::size const):
* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::paintToSurface):
* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
* platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:
* platform/graphics/texmap/coordinated/CoordinatedImageBacking.cpp:
(WebCore::CoordinatedImageBacking::update):
(WebCore::CoordinatedImageBacking::releaseSurfaceIfNeeded):
* platform/graphics/texmap/coordinated/CoordinatedImageBacking.h:
* platform/graphics/texmap/coordinated/CoordinatedSurface.cpp: Removed.
* platform/graphics/texmap/coordinated/CoordinatedSurface.h: Removed.
* platform/graphics/texmap/coordinated/Tile.h:
* platform/graphics/texmap/coordinated/TiledBackingStoreClient.h:

Source/WebKit:

Replace uses of CoordinatedSurface class with CoordinatedBuffer. The
ThreadSafeCoordinatedSurface class is removed, along with the code in
CoordinatedLayerTreeHost that established a CoordinatedSurface factory.

* PlatformGTK.cmake:
* PlatformWPE.cmake:
* Shared/CoordinatedGraphics/CoordinatedBackingStore.cpp:
(WebKit::CoordinatedBackingStoreTile::swapBuffers):
(WebKit::CoordinatedBackingStoreTile::setBackBuffer):
(WebKit::CoordinatedBackingStore::updateTile):
* Shared/CoordinatedGraphics/CoordinatedBackingStore.h:
Rename m_surface to m_buffer, m_surfaceOffset to m_bufferOffset.
* Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:
(WebKit::CoordinatedGraphicsScene::createUpdateAtlas):
(WebKit::CoordinatedGraphicsScene::updateImageBacking):
* Shared/CoordinatedGraphics/CoordinatedGraphicsScene.h:
* Shared/CoordinatedGraphics/threadedcompositor/ThreadSafeCoordinatedSurface.cpp: Removed.
* Shared/CoordinatedGraphics/threadedcompositor/ThreadSafeCoordinatedSurface.h: Removed.
* WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:
(WebKit::CompositingCoordinator::updateImageBacking):
(WebKit::CompositingCoordinator::createUpdateAtlas):
(WebKit::CompositingCoordinator::paintToSurface):
* WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h:
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
(WebKit::CoordinatedLayerTreeHost::createCoordinatedSurface): Deleted.
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
* WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.cpp:
(WebKit::UpdateAtlas::UpdateAtlas):
(WebKit::UpdateAtlas::~UpdateAtlas):
(WebKit::UpdateAtlas::paintOnAvailableBuffer):
* WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.h:
Rename m_surface to m_buffer.
(WebKit::UpdateAtlas::size const):
(WebKit::UpdateAtlas::supportsAlpha const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

23 months agoFEComponentTransfer cleanup and optimization
simon.fraser@apple.com [Thu, 23 Nov 2017 06:47:41 +0000 (06:47 +0000)]
FEComponentTransfer cleanup and optimization
https://bugs.webkit.org/show_bug.cgi?id=179952

Reviewed by Darin Adler.

Change terminology for FEComponentTransfer to be more explicit about the fact
that it's creating and using lookup tables. Use std::array for the lookup tables.

Use uint8_t instead of unsigned char.

Avoid confusing arrays for channels in computeLookupTables; just setup the lut for
each channel manually.

This is about 1.25x faster than before.

* platform/graphics/filters/FEComponentTransfer.cpp:
(WebCore::FEComponentTransfer::computeIdentityTable):
(WebCore::FEComponentTransfer::computeTabularTable):
(WebCore::FEComponentTransfer::computeDiscreteTable):
(WebCore::FEComponentTransfer::computeLinearTable):
(WebCore::FEComponentTransfer::computeGammaTable):
(WebCore::FEComponentTransfer::platformApplySoftware):
(WebCore::FEComponentTransfer::computeLookupTables):
(WebCore::operator<<):
(WebCore::identity): Deleted.
(WebCore::table): Deleted.
(WebCore::discrete): Deleted.
(WebCore::linear): Deleted.
(WebCore::gamma): Deleted.
(WebCore::FEComponentTransfer::getValues): Deleted.
* platform/graphics/filters/FEComponentTransfer.h:
(WebCore::ComponentTransferFunction::ComponentTransferFunction): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

23 months agoFollowup after r225084: if anyone called GenericTypedArrayView() it didn't compile,
simon.fraser@apple.com [Thu, 23 Nov 2017 06:47:36 +0000 (06:47 +0000)]
Followup after r225084: if anyone called GenericTypedArrayView() it didn't compile,
because of a getRangeUnchecked/getRangeImpl name mismatch; fixed to use getRangeImpl().

Also name the argument to zeroRange() to 'count' since it's an item count.

* runtime/GenericTypedArrayView.h:
(JSC::GenericTypedArrayView::zeroRange):
(JSC::GenericTypedArrayView::getRange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

23 months agoSanity-check feature defaults in WebKitFeatures.cmake
mcatanzaro@igalia.com [Thu, 23 Nov 2017 00:57:34 +0000 (00:57 +0000)]
Sanity-check feature defaults in WebKitFeatures.cmake
https://bugs.webkit.org/show_bug.cgi?id=179095

Reviewed by Konstantin Tokarev.

Change the default value of some features in WebKitFeatures.cmake to reduce the number of
Options*.cmake files the feature's default value must be overridden in.

Remove feature definitions where they are redundant with the definition in
WebKitFeatures.cmake, particluarly in OptionsMac.cmake.

This commit should not include any functional changes. It just aims to reduce the total
number of times we need to call WEBKIT_OPTION_DEFAULT_PORT_VALUE.

* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsJSCOnly.cmake:
* Source/cmake/OptionsMac.cmake:
* Source/cmake/OptionsWPE.cmake:
* Source/cmake/OptionsWin.cmake:
* Source/cmake/WebKitFeatures.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

23 months ago[css-grid] Refactoring and new namespace with grid related utility functions
jfernandez@igalia.com [Wed, 22 Nov 2017 23:46:15 +0000 (23:46 +0000)]
[css-grid] Refactoring and new namespace with grid related utility functions
https://bugs.webkit.org/show_bug.cgi?id=179633

Reviewed by Darin Adler.

Added a new namespace with several utility functions to share logic
between RenderGrid and GridTrackSizingAlgorithm.

No new tests, since no new functionality is added.

* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* rendering/GridLayoutUtils.cpp: Added.
(WebCore::GridLayoutUtils::computeMarginLogicalSizeForChild):
(WebCore::GridLayoutUtils::marginLogicalSizeForChild):
(WebCore::GridLayoutUtils::isOrthogonalChild):
(WebCore::GridLayoutUtils::flowAwareDirectionForChild):
* rendering/GridLayoutUtils.h: Added.
* rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::GridTrackSizingAlgorithm::assumedRowsSizeForOrthogonalChild const):
(WebCore::GridTrackSizingAlgorithmStrategy::logicalHeightForChild const):
(WebCore::GridTrackSizingAlgorithmStrategy::minContentForChild const):
(WebCore::GridTrackSizingAlgorithmStrategy::maxContentForChild const):
(WebCore::GridTrackSizingAlgorithmStrategy::minSizeForChild const):
(WebCore::DefiniteSizeStrategy::minLogicalWidthForChild const):
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutBlock):
(WebCore::RenderGrid::placeItemsOnGrid const):
(WebCore::RenderGrid::layoutPositionedObject):
(WebCore::RenderGrid::availableAlignmentSpaceForChildBeforeStretching const):
(WebCore::RenderGrid::applyStretchAlignmentToChildIfNeeded):
(WebCore::RenderGrid::isInlineBaselineAlignedChild const):
(WebCore::RenderGrid::firstLineBaseline const):
(WebCore::RenderGrid::columnAxisPositionForChild const):
(WebCore::RenderGrid::rowAxisPositionForChild const):
(WebCore::RenderGrid::columnAxisOffsetForChild const):
(WebCore::RenderGrid::rowAxisOffsetForChild const):
(WebCore::RenderGrid::findChildLogicalPosition const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

23 months agoImplement VisualViewport API attributes
commit-queue@webkit.org [Wed, 22 Nov 2017 22:20:26 +0000 (22:20 +0000)]
Implement VisualViewport API attributes
https://bugs.webkit.org/show_bug.cgi?id=179385

Patch by Ali Juma <ajuma@chromium.org> on 2017-11-22
Reviewed by Frédéric Wang.

LayoutTests/imported/w3c:

Update expectations for viewport WPTs. The new expectations are all passing,
except as mentioned below.

* web-platform-tests/viewport/viewport-no-resize-event-on-overflow-recalc-expected.txt:
* web-platform-tests/viewport/viewport-read-size-causes-layout-expected.txt:
* web-platform-tests/viewport/viewport-read-size-in-iframe-causes-layout-expected.txt:
* web-platform-tests/viewport/viewport-resize-event-on-load-overflowing-page-expected.txt:
  Fails since events are not implemented yet (wkbug.com/b/179386).
* web-platform-tests/viewport/viewport-scrollbars-cause-resize-expected.txt:
* web-platform-tests/viewport/viewport-type-expected.txt:
* web-platform-tests/viewport/viewport-unscaled-scale-expected.txt:
* web-platform-tests/viewport/viewport-unscaled-scale-iframe-expected.txt:
* web-platform-tests/viewport/viewport-unscaled-scroll-expected.txt:
* web-platform-tests/viewport/viewport-unscaled-scroll-iframe-expected.txt:
  Passing expectation for non-iOS, but fails on iOS because iframes aren't scrollable (wkbug.com/b/179794).
* web-platform-tests/viewport/viewport-unscaled-size-expected.txt:
* web-platform-tests/viewport/viewport-unscaled-size-iframe-expected.txt:
  Passing expectation for non-iOS, but fails on iOS because iframes aren't scrollable (wkbug.com/b/179794).

Source/WebCore:

Add a visualViewport attribute to Window, and implement the VisualViewport
interface (https://wicg.github.io/visual-viewport/#the-visualviewport-interface).

This is behind a newly-added VisualViewportAPI experimental feature flag.

Tests: fast/visual-viewport/viewport-dimensions-exclude-custom-scrollbars.html
       fast/visual-viewport/viewport-dimensions-exclude-scrollbars.html
       fast/visual-viewport/viewport-dimensions-iframe.html
       fast/visual-viewport/viewport-dimensions-under-page-zoom.html
       fast/visual-viewport/viewport-dimensions.html

* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/WebCoreBuiltinNames.h:
* dom/EventTargetFactory.in:
* page/DOMWindow.cpp:
(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::resetDOMWindowProperties):
(WebCore::DOMWindow::visualViewport const):
* page/DOMWindow.h:
* page/DOMWindow.idl:
* page/Settings.yaml:
* page/VisualViewport.cpp: Added.
(WebCore::VisualViewport::VisualViewport):
(WebCore::VisualViewport::eventTargetInterface const):
(WebCore::VisualViewport::scriptExecutionContext const):
(WebCore::getFrameViewAndLayoutIfNonNull):
(WebCore::VisualViewport::offsetLeft const):
(WebCore::VisualViewport::offsetTop const):
(WebCore::VisualViewport::pageLeft const):
(WebCore::VisualViewport::pageTop const):
(WebCore::VisualViewport::width const):
(WebCore::VisualViewport::height const):
(WebCore::VisualViewport::scale const):
* page/VisualViewport.h: Added.
* page/VisualViewport.idl: Added.

Source/WebKit:

Add a VisualViewportAPI experimental feature.

* Shared/WebPreferences.yaml:

Source/WebKitLegacy/mac:

Add a VisualViewportAPI preference.

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences visualViewportAPIEnabled]):
(-[WebPreferences setVisualViewportAPIEnabled:]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):

Source/WebKitLegacy/win:

Add a VisualViewportAPI preference.

* Interfaces/IWebPreferencesPrivate.idl:
* WebPreferenceKeysPrivate.h:
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
(WebPreferences::visualViewportAPIEnabled):
(WebPreferences::setVisualViewportAPIEnabled):
* WebPreferences.h:
* WebView.cpp:
(WebView::notifyPreferencesChanged):

Tools:

Enable the VisualViewportAPI in layout tests.

* DumpRenderTree/mac/DumpRenderTree.mm:
(enableExperimentalFeatures):
* DumpRenderTree/win/DumpRenderTree.cpp:
(enableExperimentalFeatures):

LayoutTests:

Add tests for the Visual Viewport API, based on Blink's layout tests but modified
to use UIScriptController.

* fast/visual-viewport/viewport-dimensions-exclude-custom-scrollbars-expected.txt: Added.
* fast/visual-viewport/viewport-dimensions-exclude-custom-scrollbars.html: Added.
* fast/visual-viewport/viewport-dimensions-exclude-scrollbars-expected.txt: Added.
* fast/visual-viewport/viewport-dimensions-exclude-scrollbars.html: Added.
* fast/visual-viewport/viewport-dimensions-expected.txt: Added.
* fast/visual-viewport/viewport-dimensions-iframe-expected.txt: Added.
* fast/visual-viewport/viewport-dimensions-iframe.html: Added.
* fast/visual-viewport/viewport-dimensions-under-page-zoom-expected.txt: Added.
* fast/visual-viewport/viewport-dimensions-under-page-zoom.html: Added.
* fast/visual-viewport/viewport-dimensions.html: Added.
* platform/gtk/TestExpectations:
  Skipped tests that use UIScriptController::zoomToScale, since this isn't implemented on GTK (webkit.org/b/168050).
* platform/ios/fast/visual-viewport/viewport-dimensions-iframe-expected.txt: Added.
  Fails because iframes aren't scrollable on iOS (webkit.org/b/179794).
* platform/ios/imported/w3c/web-platform-tests/viewport/viewport-unscaled-scroll-iframe-expected.txt: Added.
  Fails because iframes aren't scrollable on iOS (webkit.org/b/179794).
* platform/ios/imported/w3c/web-platform-tests/viewport/viewport-unscaled-size-expected.txt: Added.
  Platform-specific expectation because of the window size being different on iOS.
* platform/ios/imported/w3c/web-platform-tests/viewport/viewport-unscaled-size-iframe-expected.txt: Added.
  Fails because iframes aren't scrollable on iOS (webkit.org/b/179794).
* platform/mac-wk1/TestExpectations:
  Skipped a test that applies webkit-scrollbar to main frame scrollbars, since this is unsupported in WK1.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

23 months agoAdd performance test for inlines and inline-blocks without text
antti@apple.com [Wed, 22 Nov 2017 21:24:06 +0000 (21:24 +0000)]
Add performance test for inlines and inline-blocks without text
https://bugs.webkit.org/show_bug.cgi?id=179955

Reviewed by Darin Adler.

Test for https://bugs.webkit.org/show_bug.cgi?id=179950

* Layout/inline-layout-no-text.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

23 months agoAvailable height is wrong for positioned elements with "box-sizing: border-box"
rego@igalia.com [Wed, 22 Nov 2017 20:37:35 +0000 (20:37 +0000)]
Available height is wrong for positioned elements with "box-sizing: border-box"
https://bugs.webkit.org/show_bug.cgi?id=178783

Reviewed by Darin Adler.

Source/WebCore:

These methods were returning a wrong value for positioned items
in combination with "box-sizing: border-box".
The problem was that if the height of the element is given
by its offset properties (top and bottom) we don't need to call
adjustContentBoxLogicalHeightForBoxSizing().

Tests: fast/box-sizing/fill-available.html
       fast/box-sizing/replaced.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeReplacedLogicalHeightUsing const):
(WebCore::RenderBox::availableLogicalHeightUsing const):

LayoutTests:

There are some cases failing in fast/box-sizing/fill-available.html,
this is because of a different bug (see https://webkit.org/b/178790)
as noted down in the text comments.

* fast/box-sizing/fill-available-expected.txt: Added.
* fast/box-sizing/fill-available.html: Added.
* fast/box-sizing/replaced-expected.txt: Added.
* fast/box-sizing/replaced.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

23 months agoWebCoreObjCExtras.h is being included in too many places
commit-queue@webkit.org [Wed, 22 Nov 2017 19:44:57 +0000 (19:44 +0000)]
WebCoreObjCExtras.h is being included in too many places
https://bugs.webkit.org/show_bug.cgi?id=179931

Patch by Christopher Reid <chris.reid@sony.com> on 2017-11-22
Reviewed by Darin Adler.

Source/WebCore:

No new tests no change in behavior.

Fixing cases where WebCoreObjCExtras.h is imported but not used.

* accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
* platform/mac/WebCoreNSURLExtras.mm:

Source/WebKitLegacy/mac:

* Plugins/Hosted/WebHostedNetscapePluginView.mm:
* Plugins/WebBaseNetscapePluginView.mm:
* Plugins/WebBasePluginPackage.mm:
* Plugins/WebNetscapePluginStream.mm:
* Plugins/WebNetscapePluginView.mm:
* WebView/WebTextIterator.mm:
* WebView/WebViewData.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

23 months ago[Web Animations] Adopt KeyframeList in KeyframeEffect
graouts@webkit.org [Wed, 22 Nov 2017 19:04:21 +0000 (19:04 +0000)]
[Web Animations] Adopt KeyframeList in KeyframeEffect
https://bugs.webkit.org/show_bug.cgi?id=179941
<rdar://problem/35666924>

Reviewed by Darin Adler.

KeyframeEffect used to model its keyframes by creating a new Keyframe struct and storing them in a Vector<Keyframe>.
However, there already is a way to model keyframes in WebCore using the KeyframeList class. We now adopt this class
in KeyframeEffect, which makes it possible to run hardware-composited animations using RenderBoxModelObject::startAnimation()
in a follow-up patch, since this function expects a KeyframeList.

No news tests, this is an internals change and does not yield any changes in Web content.

* animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::KeyframeEffect): Create a default m_keyframes at construction time.
(WebCore::KeyframeEffect::processKeyframes): Create a temporary KeyframeList as we parse keyframes passed from the JS API
and assign it to m_keyframes upon successful parsing. We also use cssPropertyId to refer to a CSSPropertyID to make the code
clearer and ensure there is no confusion with JS properties that we manipulate in this function.
(WebCore::KeyframeEffect::computeStackingContextImpact): Use the list of CSS properties exposed on KeyframeList directly rather
than enumerating each keyframe and use cssPropertyId to refer to individual CSSPropertyID values for consistency.
(WebCore::KeyframeEffect::applyAtLocalTime): Use the list of CSS properties exposed on KeyframeList directly rather than
using the properties specified on the first keyframe only. We also remove a stale FIXME comment which was addressed in r224957.
* animation/KeyframeEffect.h: Remove the Keyframe struct and change the type of m_keyframes from Vector<Keyframe> to KeyframeList.
* rendering/style/KeyframeList.h:
(WebCore::KeyframeList::KeyframeList): We remove the default insertions at KeyframeList construction time since it requires
an immediate call to clear() when doing any meaningful work with a KeyframeList. We also add the default move assignment operator
to allow KeyframeEffect::processKeyframes() to make a move assignment from the temporary keyframe list we build at parsing to the
member variable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

23 months agoRemove build-webkit's notion of feature flags having a default value
mcatanzaro@igalia.com [Wed, 22 Nov 2017 18:52:52 +0000 (18:52 +0000)]
Remove build-webkit's notion of feature flags having a default value
https://bugs.webkit.org/show_bug.cgi?id=177338

Reviewed by Carlos Alberto Lopez Perez.

.:

Add an ENABLE_EXPERIMENTAL_FEATURES flag and use it to enable certain features.

* Source/cmake/OptionsGTK.cmake:
* Source/cmake/WebKitFeatures.cmake:

Source/WebKit:

Use ENABLE_EXPERIMENTAL_FEATURES instead of ENABLE_DEVELOPER_MODE to enable runtime
experimental features.

* Shared/WebPreferencesDefaultValues.h:

Tools:

Delegate feature flag default values to the build system.
(FeatureDefines.xcconfig for Xcode, WebKitFeatures.cmake and Options*.cmake for CMake, and FeatureDefines.h for everyone)

* BuildSlaveSupport/build.webkit.org-config/config.json:
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(Factory.__init__):
Update GTK and WPE buildbot configuration to use --no-experimental-features on old stable
bots instead of --default-cmake-features.

* Scripts/build-webkit:
(cMakeArgsFromFeatures): Deleted.
Default feature values to 'undef'.
Remove the --default-cmake-features argument; it is now the default.
Add --no-experimental-features to replace it.
Stop printing the default feature flag value in the help.
Avoid propagating undefined values to the build system;
only mention flags that are overridden on the command line.

This has the nice side effect of using the default CMake features
for CMake builds, but still allowing toggling of them using the
prettier --FEATURE and --no-FEATURE arguments.

* Scripts/webkitdirs.pm:
(generateBuildSystemFromCMakeProject):
No longer need to suppress CMake warnings about unused arguments.

* Scripts/webkitperl/FeatureList.pm:
Remove the default values from the feature list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

23 months ago[Re-landing] Pass --useDollarVM=true to all JSC tests.
mark.lam@apple.com [Wed, 22 Nov 2017 18:08:37 +0000 (18:08 +0000)]
[Re-landing] Pass --useDollarVM=true to all JSC tests.
https://bugs.webkit.org/show_bug.cgi?id=179647

Reviewed by Saam Barati.

* Scripts/run-jsc-stress-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

23 months agotuple related items are used in WTF without including tuple
commit-queue@webkit.org [Wed, 22 Nov 2017 17:56:11 +0000 (17:56 +0000)]
tuple related items are used in WTF without including tuple
https://bugs.webkit.org/show_bug.cgi?id=179926

Patch by Stephan Szabo <stephan.szabo@sony.com> on 2017-11-22
Reviewed by Darin Adler.

* wtf/HashFunctions.h:
* wtf/PrintStream.h:
* wtf/threads/Signals.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

23 months ago[WPE] Enable request-animation-frame-disabled.html.
Ms2ger@igalia.com [Wed, 22 Nov 2017 16:54:39 +0000 (16:54 +0000)]
[WPE] Enable request-animation-frame-disabled.html.
https://bugs.webkit.org/show_bug.cgi?id=173422

Unreviewed test gardening.

The test is passing since the change in r218754, and doesn't seem to have
crashed in months.

* platform/wpe/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, rolling out r225093.
fred.wang@free.fr [Wed, 22 Nov 2017 08:14:53 +0000 (08:14 +0000)]
Unreviewed, rolling out r225093.
https://bugs.webkit.org/show_bug.cgi?id=179938

Compilation failed on WinCairo 64-bit Release (Requested by
fredw on #webkit).

Reverted changeset:

"Implement VisualViewport API attributes"
https://bugs.webkit.org/show_bug.cgi?id=179385
https://trac.webkit.org/changeset/225093

Patch by Commit Queue <commit-queue@webkit.org> on 2017-11-22

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoImplement VisualViewport API attributes
commit-queue@webkit.org [Wed, 22 Nov 2017 07:26:16 +0000 (07:26 +0000)]
Implement VisualViewport API attributes
https://bugs.webkit.org/show_bug.cgi?id=179385

Patch by Ali Juma <ajuma@chromium.org> on 2017-11-21
Reviewed by Frédéric Wang.

LayoutTests/imported/w3c:

Update expectations for viewport WPTs. The new expectations are all passing,
except as mentioned below.

* web-platform-tests/viewport/viewport-no-resize-event-on-overflow-recalc-expected.txt:
* web-platform-tests/viewport/viewport-read-size-causes-layout-expected.txt:
* web-platform-tests/viewport/viewport-read-size-in-iframe-causes-layout-expected.txt:
* web-platform-tests/viewport/viewport-resize-event-on-load-overflowing-page-expected.txt:
  Fails since events are not implemented yet (wkbug.com/b/179386).
* web-platform-tests/viewport/viewport-scrollbars-cause-resize-expected.txt:
* web-platform-tests/viewport/viewport-type-expected.txt:
* web-platform-tests/viewport/viewport-unscaled-scale-expected.txt:
* web-platform-tests/viewport/viewport-unscaled-scale-iframe-expected.txt:
* web-platform-tests/viewport/viewport-unscaled-scroll-expected.txt:
* web-platform-tests/viewport/viewport-unscaled-scroll-iframe-expected.txt:
  Passing expectation for non-iOS, but fails on iOS because iframes aren't scrollable (wkbug.com/b/179794).
* web-platform-tests/viewport/viewport-unscaled-size-expected.txt:
* web-platform-tests/viewport/viewport-unscaled-size-iframe-expected.txt:
  Passing expectation for non-iOS, but fails on iOS because iframes aren't scrollable (wkbug.com/b/179794).

Source/WebCore:

Add a visualViewport attribute to Window, and implement the VisualViewport
interface (https://wicg.github.io/visual-viewport/#the-visualviewport-interface).

This is behind a newly-added VisualViewportAPI experimental feature flag.

Tests: fast/visual-viewport/viewport-dimensions-exclude-custom-scrollbars.html
       fast/visual-viewport/viewport-dimensions-exclude-scrollbars.html
       fast/visual-viewport/viewport-dimensions-iframe.html
       fast/visual-viewport/viewport-dimensions-under-page-zoom.html
       fast/visual-viewport/viewport-dimensions.html

* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/WebCoreBuiltinNames.h:
* dom/EventTargetFactory.in:
* page/DOMWindow.cpp:
(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::resetDOMWindowProperties):
(WebCore::DOMWindow::visualViewport const):
* page/DOMWindow.h:
* page/DOMWindow.idl:
* page/Settings.yaml:
* page/VisualViewport.cpp: Added.
(WebCore::VisualViewport::VisualViewport):
(WebCore::VisualViewport::eventTargetInterface const):
(WebCore::VisualViewport::scriptExecutionContext const):
(WebCore::getFrameViewAndLayoutIfNonNull):
(WebCore::VisualViewport::offsetLeft const):
(WebCore::VisualViewport::offsetTop const):
(WebCore::VisualViewport::pageLeft const):
(WebCore::VisualViewport::pageTop const):
(WebCore::VisualViewport::width const):
(WebCore::VisualViewport::height const):
(WebCore::VisualViewport::scale const):
* page/VisualViewport.h: Added.
* page/VisualViewport.idl: Added.

Source/WebKit:

Add a VisualViewportAPI experimental feature.

* Shared/WebPreferences.yaml:

Source/WebKitLegacy/mac:

Add a VisualViewportAPI preference.

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences visualViewportAPIEnabled]):
(-[WebPreferences setVisualViewportAPIEnabled:]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):

Source/WebKitLegacy/win:

Add a VisualViewportAPI preference.

* Interfaces/IWebPreferencesPrivate.idl:
* WebPreferenceKeysPrivate.h:
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
(WebPreferences::visualViewportAPIEnabled):
(WebPreferences::setVisualViewportAPIEnabled):
* WebPreferences.h:
* WebView.cpp:
(WebView::notifyPreferencesChanged):

Tools:

Enable the VisualViewportAPI in layout tests.

* DumpRenderTree/mac/DumpRenderTree.mm:
(enableExperimentalFeatures):
* DumpRenderTree/win/DumpRenderTree.cpp:
(enableExperimentalFeatures):

LayoutTests:

Add tests for the Visual Viewport API, based on Blink's layout tests but modified
to use UIScriptController.

* fast/visual-viewport/viewport-dimensions-exclude-custom-scrollbars-expected.txt: Added.
* fast/visual-viewport/viewport-dimensions-exclude-custom-scrollbars.html: Added.
* fast/visual-viewport/viewport-dimensions-exclude-scrollbars-expected.txt: Added.
* fast/visual-viewport/viewport-dimensions-exclude-scrollbars.html: Added.
* fast/visual-viewport/viewport-dimensions-expected.txt: Added.
* fast/visual-viewport/viewport-dimensions-iframe-expected.txt: Added.
* fast/visual-viewport/viewport-dimensions-iframe.html: Added.
* fast/visual-viewport/viewport-dimensions-under-page-zoom-expected.txt: Added.
* fast/visual-viewport/viewport-dimensions-under-page-zoom.html: Added.
* fast/visual-viewport/viewport-dimensions.html: Added.
* platform/gtk/TestExpectations:
  Skipped tests that use UIScriptController::zoomToScale, since this isn't implemented on GTK (webkit.org/b/168050).
* platform/ios/fast/visual-viewport/viewport-dimensions-iframe-expected.txt: Added.
  Fails because iframes aren't scrollable on iOS (webkit.org/b/179794).
* platform/ios/imported/w3c/web-platform-tests/viewport/viewport-unscaled-scroll-iframe-expected.txt: Added.
  Fails because iframes aren't scrollable on iOS (webkit.org/b/179794).
* platform/ios/imported/w3c/web-platform-tests/viewport/viewport-unscaled-size-expected.txt: Added.
  Platform-specific expectation because of the window size being different on iOS.
* platform/ios/imported/w3c/web-platform-tests/viewport/viewport-unscaled-size-iframe-expected.txt: Added.
  Fails because iframes aren't scrollable on iOS (webkit.org/b/179794).
* platform/mac-wk1/TestExpectations:
  Skipped a test that applies webkit-scrollbar to main frame scrollbars, since this is unsupported in WK1.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAsync frame scrolling: handle fixed root backgrounds in frames
fred.wang@free.fr [Wed, 22 Nov 2017 07:17:09 +0000 (07:17 +0000)]
Async frame scrolling: handle fixed root backgrounds in frames
https://bugs.webkit.org/show_bug.cgi?id=176261

Source/WebCore:

Based on patch by Simon Fraser <simon.fraser@apple.com>
Patch by Frederic Wang <fwang@igalia.com> on 2017-11-21
Reviewed by Antonio Gomes.

For frames with tiled backing, we register a slow-repaint object because we hit
RenderElement::styleWillChange() before we've made a backing for the iframe's RenderView so
view().compositor().supportsFixedRootBackgroundCompositing() returns false. This patch
ensures that this object is removed when setBackgroundLayerPaintsFixedRootBackground is
called. It also removes the opaque background of non-main frames with tiled backing.
This fixes a possible hit of ASSERT(!m_backgroundLayer) after r221615.

Test: compositing/tiling/tiled-drawing-async-frame-scrolling.html

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGeometry): Do not set opaque contents for frames with
tiled backing. We keep !m_isMainFrameRenderViewLayer for backward compatibility with WK1.
(WebCore::RenderLayerBacking::setBackgroundLayerPaintsFixedRootBackground): Add an early
return when m_backgroundLayerPaintsFixedRootBackground is not changed. Remove the slow
repaint object previously registered for this frame. Also add an ASSERT to ensure that a
fixed root background is only set for frames with async scrolling.
(WebCore::RenderLayerBacking::updateRootLayerConfiguration): Restrict some special handling
of background and opaqueness to the main frame.

LayoutTests:

Patch by Frederic Wang <fwang@igalia.com> on 2017-11-21
Reviewed by Antonio Gomes.

Extend tiled-drawing-async-frame-scrolling with new test cases and update expectations.

* compositing/tiling/tiled-drawing-async-frame-scrolling.html: Add two test cases with
non-white and fixed gradient background. The latter exhibits a crash fixed by that commit.
* compositing/tiling/tiled-drawing-async-frame-scrolling-expected.txt: Adjust expectation due
to spacing changes.
* platform/ios-wk2/compositing/tiling/tiled-drawing-async-frame-scrolling-expected.txt: Ditto.
Update expectation for the first case to remove the white background and add expectations for
the two new cases.
* platform/mac-wk2/compositing/tiling/tiled-drawing-async-frame-scrolling-expected.txt: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoDrop ENABLE_IMAGE_DECODER_DOWN_SAMPLING code
zandobersek@gmail.com [Wed, 22 Nov 2017 06:54:50 +0000 (06:54 +0000)]
Drop ENABLE_IMAGE_DECODER_DOWN_SAMPLING code
https://bugs.webkit.org/show_bug.cgi?id=179921

Reviewed by Carlos Garcia Campos.

.:

* Source/cmake/WebKitFeatures.cmake: Remove the CMake option that
enabled IMAGE_DECODER_DOWN_SAMPLING code.

Source/WebCore:

Drop the ENABLE_IMAGE_DECODER_DOWN_SAMPLING code, along with the build
guard definitions in WTF and CMake.

This was apparently in use in the Qt port, but since then no port
enables this. It's not exposed in the Xcode build, and the CMake option
is disabled by default, with no way to enable it through build-webkit.

While the code guarded with this build guard is removed, there's still
code in the ScalableImageDecoder class that only operated when this
feature was enabled. This should be addressed in the future, after
evaluating the need for this scaling capability.

No new tests -- no change in behavior.

* platform/graphics/Image.cpp:
(WebCore::Image::adjustSourceRectForDownSampling const): Deleted.
* platform/graphics/Image.h:
* platform/graphics/cairo/CairoOperations.cpp:
(WebCore::Cairo::drawNativeImage):
* platform/image-decoders/ScalableImageDecoder.h:
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::JPEGImageReader::decode):
* platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::PNGImageDecoder::rowAvailable):
(WebCore::PNGImageDecoder::frameComplete):

Source/WTF:

* wtf/FeatureDefines.h: Remove the ENABLE_IMAGE_DECODER_DOWN_SAMPLING
definition.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, rolling out r225089.
fred.wang@free.fr [Wed, 22 Nov 2017 06:40:24 +0000 (06:40 +0000)]
Unreviewed, rolling out r225089.
https://bugs.webkit.org/show_bug.cgi?id=179937

This patch caused compilation failures (Requested by fredw on
#webkit).

Reverted changeset:

"Async frame scrolling: handle fixed root backgrounds in
frames"
https://bugs.webkit.org/show_bug.cgi?id=176261
https://trac.webkit.org/changeset/225089

Patch by Commit Queue <commit-queue@webkit.org> on 2017-11-21

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAsync frame scrolling: handle fixed root backgrounds in frames
fred.wang@free.fr [Wed, 22 Nov 2017 06:30:21 +0000 (06:30 +0000)]
Async frame scrolling: handle fixed root backgrounds in frames
https://bugs.webkit.org/show_bug.cgi?id=176261

Source/WebCore:

Based on patch by Simon Fraser <simon.fraser@apple.com>
Patch by Frederic Wang <fwang@igalia.com> on 2017-11-21
Reviewed by Antonio Gomes.

For frames with tiled backing, we register a slow-repaint object because we hit
RenderElement::styleWillChange() before we've made a backing for the iframe's RenderView so
view().compositor().supportsFixedRootBackgroundCompositing() returns false. This patch
ensures that this object is removed when setBackgroundLayerPaintsFixedRootBackground is
called. It also removes the opaque background of non-main frames with tiled backing.
This fixes a possible hit of ASSERT(!m_backgroundLayer) after r221615.

Test: compositing/tiling/tiled-drawing-async-frame-scrolling.html

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGeometry): Do not set opaque contents for frames with
tiled backing. We keep !m_isMainFrameRenderViewLayer for backward compatibility with WK1.
(WebCore::RenderLayerBacking::setBackgroundLayerPaintsFixedRootBackground): Add an early
return when m_backgroundLayerPaintsFixedRootBackground is not changed. Remove the slow
repaint object previously registered for this frame. Also add an ASSERT to ensure that a
fixed root background is only set for frames with async scrolling.
(WebCore::RenderLayerBacking::updateRootLayerConfiguration): Restrict some special handling
of background and opaqueness to the main frame.

LayoutTests:

Patch by Frederic Wang <fwang@igalia.com> on 2017-11-21
Reviewed by Antonio Gomes.

Extend tiled-drawing-async-frame-scrolling with new test cases and update expectations.

* compositing/tiling/tiled-drawing-async-frame-scrolling.html: Add two test cases with
non-white and fixed gradient background. The latter exhibits a crash fixed by that commit.
* compositing/tiling/tiled-drawing-async-frame-scrolling-expected.txt: Adjust expectation due
to spacing changes.
* platform/ios-wk2/compositing/tiling/tiled-drawing-async-frame-scrolling-expected.txt: Ditto.
Update expectation for the first case to remove the white background and add expectations for
the two new cases.
* platform/mac-wk2/compositing/tiling/tiled-drawing-async-frame-scrolling-expected.txt: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoSome FELighting cleanup
simon.fraser@apple.com [Wed, 22 Nov 2017 01:02:24 +0000 (01:02 +0000)]
Some FELighting cleanup
https://bugs.webkit.org/show_bug.cgi?id=179924

Reviewed by Sam Weinig.

Make the normal-computation functions const and have them return an IntSize.
Replace bit shifting with multiply by two (compilers know how to do this, folks).

* platform/graphics/filters/FELighting.cpp:
(WebCore::FELighting::LightingData::topLeftNormal const):
(WebCore::FELighting::LightingData::topRowNormal const):
(WebCore::FELighting::LightingData::topRightNormal const):
(WebCore::FELighting::LightingData::leftColumnNormal const):
(WebCore::FELighting::LightingData::interiorNormal const):
(WebCore::FELighting::LightingData::rightColumnNormal const):
(WebCore::FELighting::LightingData::bottomLeftNormal const):
(WebCore::FELighting::LightingData::bottomRowNormal const):
(WebCore::FELighting::LightingData::bottomRightNormal const):
(WebCore::FELighting::inlineSetPixel):
(WebCore::FELighting::setPixel):
(WebCore::FELighting::platformApplyGenericPaint):
(WebCore::FELighting::drawLighting):
(WebCore::FELighting::LightingData::topLeft): Deleted.
(WebCore::FELighting::LightingData::topRow): Deleted.
(WebCore::FELighting::LightingData::topRight): Deleted.
(WebCore::FELighting::LightingData::leftColumn): Deleted.
(WebCore::FELighting::LightingData::interior): Deleted.
(WebCore::FELighting::LightingData::rightColumn): Deleted.
(WebCore::FELighting::LightingData::bottomLeft): Deleted.
(WebCore::FELighting::LightingData::bottomRow): Deleted.
(WebCore::FELighting::LightingData::bottomRight): Deleted.
* platform/graphics/filters/FELighting.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[PAL] Remove FileSystem's dependency on WebCoreNSStringExtras
commit-queue@webkit.org [Tue, 21 Nov 2017 23:14:58 +0000 (23:14 +0000)]
[PAL] Remove FileSystem's dependency on WebCoreNSStringExtras
https://bugs.webkit.org/show_bug.cgi?id=179504

Patch by Christopher Reid <chris.reid@sony.com> on 2017-11-21
Reviewed by Darin Adler.

Source/WebCore:

No new tests no change in behavior.

Removed WebCoreNSStringExtras.
Replaced calls to string helpers in WebCoreNSStringExtras with calls to WTF::String.
Moved filenameByFixingIllegalCharacters into LoaderNSURLExtras.
Moved preferredBundleLocalizationName into WebKitLegacy.

* PlatformMac.cmake: Removed WebCoreNSStringExtras.mm
* SourcesCocoa.txt: Removed WebCoreNSStringExtras.mm
* WebCore.xcodeproj/project.pbxproj: Removed WebCoreNSStringExtras
* loader/mac/LoaderNSURLExtras.h:
* loader/mac/LoaderNSURLExtras.mm:
* platform/graphics/mac/FontCacheMac.mm:
* platform/mac/PasteboardMac.mm:
* platform/mac/WebCoreNSURLExtras.mm:

Source/WebKit:

* UIProcess/Cocoa/WebViewImpl.mm:
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
* UIProcess/Plugins/mac/PluginInfoStoreMac.mm:

Source/WebKitLegacy/mac:

* Misc/WebKitNSStringExtras.mm:
* Plugins/Hosted/NetscapePluginHostManager.mm:
* Plugins/WebBasePluginPackage.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUse vImage to do alpha premultiplication/unpremultiplication in FilterEffect
simon.fraser@apple.com [Tue, 21 Nov 2017 22:32:49 +0000 (22:32 +0000)]
Use vImage to do alpha premultiplication/unpremultiplication in FilterEffect
https://bugs.webkit.org/show_bug.cgi?id=179928

Reviewed by Tim Horton.

The vImage functions are about twice as fast as the existing code.

* platform/graphics/filters/FilterEffect.cpp:
(WebCore::copyPremultiplyingAlpha):
(WebCore::copyUnpremultiplyingAlpha):
(WebCore::FilterEffect::copyUnmultipliedImage):
(WebCore::FilterEffect::copyPremultipliedImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoLayoutTests/imported/w3c:
Ms2ger@igalia.com [Tue, 21 Nov 2017 18:43:34 +0000 (18:43 +0000)]
LayoutTests/imported/w3c:
[GTK] Update expectations for wpt/url/failure.html.
https://bugs.webkit.org/show_bug.cgi?id=179920

Unreviewed test gardening.

* web-platform-tests/url/failure-expected.txt: update for sendBeacon support.

LayoutTests:
[GTK] Enable imported/w3c/web-platform-tests/url/failure.html
https://bugs.webkit.org/show_bug.cgi?id=179920

Unreviewed test gardening.

* platform/gtk/TestExpectations: the test is only flaky or prone to
  crashing on platforms that enable CONTENT_EXTENSIONS; i.e. mac and ios.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAllow for more efficient use of GenericTypedArrayView
simon.fraser@apple.com [Tue, 21 Nov 2017 17:16:31 +0000 (17:16 +0000)]
Allow for more efficient use of GenericTypedArrayView
https://bugs.webkit.org/show_bug.cgi?id=179899

Reviewed by Sam Weinig.

Fix ArrayBufferView::setRange() to not make two virtual function calls to byteLength()
under setRangeImpl(). There is only one caller in GenericTypedArrayView, and it can pass
in a length.

Add GenericTypedArrayView::getRange() to fetch a range of elements, also without virtual
byteLength() calls.

Renamed 'dataLength' to 'count' in setRange() to be clearer.

Added setNative() for callers who don't need clamping of doubles.

* runtime/ArrayBufferView.h:
(JSC::ArrayBufferView::setRangeImpl):
(JSC::ArrayBufferView::getRangeImpl):
* runtime/GenericTypedArrayView.h:
(JSC::GenericTypedArrayView::setRange):
(JSC::GenericTypedArrayView::setNative const):
(JSC::GenericTypedArrayView::getRange):
(JSC::GenericTypedArrayView::checkInboundData const):
(JSC::GenericTypedArrayView::internalByteLength const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWebDriver: do not try to parse http body if method is not POST
carlosgc@webkit.org [Tue, 21 Nov 2017 16:56:46 +0000 (16:56 +0000)]
WebDriver: do not try to parse http body if method is not POST
https://bugs.webkit.org/show_bug.cgi?id=179918

Reviewed by Darin Adler.

As said in the spec:

  5. If request’s method is POST:

    1. Let parse result be the result of parsing as JSON with request’s body as the argument. If this process
       throws an exception, return an error with error code invalid argument and jump back to step 1 in this
       overall algorithm.

    2. If parse result is not an Object, send an error with error code invalid argument and jump back to step 1
       in this overall algorithm.

    Otherwise, let parameters be parse result.

  Otherwise, let parameters be null.

6.3 Processing Model
https://w3c.github.io/webdriver/webdriver-spec.html#processing-model

Now, w3c tests are sending null as body of delete session command (it used to be just empty), making it fail
with invalid argument error.

* WebDriverService.cpp:
(WebDriver::WebDriverService::findCommand):
(WebDriver::WebDriverService::handleRequest):
* WebDriverService.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWebDriver: crash in Session::computeElementLayout when called without a current brows...
carlosgc@webkit.org [Tue, 21 Nov 2017 16:55:39 +0000 (16:55 +0000)]
WebDriver: crash in Session::computeElementLayout when called without a current browsing context
https://bugs.webkit.org/show_bug.cgi?id=179917

Reviewed by Darin Adler.

In the case of computeElementLayout message, the frameHandle parameter is not optional, but we still need to
provide a valid value (empty string means the default frame) when m_currentBrowsingContext is std::nullopt. The
same applies to selectOptionElement.

* Session.cpp:
(WebDriver::Session::computeElementLayout):
(WebDriver::Session::selectOptionElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[GLIB] Test FileMonitorTest.DetectChangeAndThenDelete sometimes crashes
carlosgc@webkit.org [Tue, 21 Nov 2017 16:53:41 +0000 (16:53 +0000)]
[GLIB] Test FileMonitorTest.DetectChangeAndThenDelete sometimes crashes
https://bugs.webkit.org/show_bug.cgi?id=179909

Reviewed by Michael Catanzaro.

The problem sems to be that the GFileMonitor is created in the main thread, but destroyed in the WorkQueue
thread. We can create the monitor in the WorkQueue thread and do the monitoring there.

Fixes unit test FileMonitorTest.DetectChangeAndThenDelete.

* platform/glib/FileMonitorGLib.cpp:
(WebCore::FileMonitor::FileMonitor): Create the GFileMonitor in the WorkQueue.
(WebCore::FileMonitor::didChange): No need to dispatch the handler in the WorkQueue, since this is now called in
the WorkQueue.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[WPE] Run unit tests in the bots
carlosgc@webkit.org [Tue, 21 Nov 2017 16:52:20 +0000 (16:52 +0000)]
[WPE] Run unit tests in the bots
https://bugs.webkit.org/show_bug.cgi?id=179910

Reviewed by Michael Catanzaro.

Add a step to run unit tests in WPE test bots.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunGLibAPITests):
(RunGtkAPITests):
(RunWPEAPITests):
(TestFactory.__init__):
(RunGtkAPITests.start): Deleted.
(RunGtkAPITests.commandComplete): Deleted.
(RunGtkAPITests.evaluateCommand): Deleted.
(RunGtkAPITests.getText): Deleted.
(RunGtkAPITests.getText2): Deleted.
* wpe/jhbuild.modules: Upgrade WPEBackend-mesa to fix crashes when running unit tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed compile warning fix
tpopela@redhat.com [Tue, 21 Nov 2017 15:20:04 +0000 (15:20 +0000)]
Unreviewed compile warning fix

WARNING: console.assert inside control flow statement without braces on line: 130487:
console.assert(this._loggingChannelSources.includes(channel.source));

* UserInterface/Controllers/LogManager.js:
(WI.LogManager):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[WPE] WPEWebProcess: Couldn't find current GLX or EGL context
carlosgc@webkit.org [Tue, 21 Nov 2017 13:37:48 +0000 (13:37 +0000)]
[WPE] WPEWebProcess: Couldn't find current GLX or EGL context
https://bugs.webkit.org/show_bug.cgi?id=179883

Reviewed by Žan Doberšek.

I'm seeing that message quite often when running the unit tests. The problem seems to be that some tests run so
fast that the web process never renders the first frame, so the context is created but never made current. I've
checked with apitrace that there are calls to eglQueryContext with null display, causing a EGL_BAD_DISPLAY, but
I don't know where those calls are originated. Making the context current right after it's created fixes the
problem.

* Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:
(WebKit::ThreadedCompositor::createGLContext): Always call makeContextCurrent() right after the context is created.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Cairo] drawNativeImage(), drawPattern() in CairoOperations should operate directly...
zandobersek@gmail.com [Tue, 21 Nov 2017 13:37:07 +0000 (13:37 +0000)]
[Cairo] drawNativeImage(), drawPattern() in CairoOperations should operate directly with cairo_surface_t objects
https://bugs.webkit.org/show_bug.cgi?id=179888

Reviewed by Carlos Garcia Campos.

Cairo::drawNativeImage() should receive a valid cairo_surface_t pointer
and work with that, instead of using a NativeImagePtr. Callers are thus
forced to pass the pointer into the drawNativeImage() call, and the
CairoOperations implementation file drops the need to know about the
NativeImagePtr type alias.

Cairo::drawPattern() now accepts pointer to the cairo_surface_t object,
along with an IntSize object that descibes the surface's size. This way
it's up to the caller to retrieve any valid native image for the current
frame and pass that to the drawPattern() call. The need to use IntSize
here is strange, but we should investigate this later.

No new tests -- no change in behavior.

* platform/graphics/cairo/CairoOperations.cpp:
(WebCore::Cairo::drawNativeImage):
(WebCore::Cairo::drawPattern):
* platform/graphics/cairo/CairoOperations.h: Include the Cairo header.
Also fix forward declaration of Cairo::drawGlyphs().
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawNativeImage):
(WebCore::GraphicsContext::drawPattern):
* platform/graphics/cairo/NativeImageCairo.cpp:
(WebCore::drawNativeImage): Execute operation through GraphicsContext,
kicking into effect any recording that could be done this way.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed. Update W3C WebDriver imported tests.
carlosgc@webkit.org [Tue, 21 Nov 2017 13:35:37 +0000 (13:35 +0000)]
Unreviewed. Update W3C WebDriver imported tests.

* imported/w3c/importer.json:
* imported/w3c/tools/webdriver/webdriver/client.py:
* imported/w3c/tools/webdriver/webdriver/error.py:
* imported/w3c/tools/webdriver/webdriver/protocol.py: Added.
* imported/w3c/tools/webdriver/webdriver/transport.py:
* imported/w3c/tools/wptrunner/MANIFEST.in:
* imported/w3c/tools/wptrunner/requirements_firefox.txt:
* imported/w3c/tools/wptrunner/requirements_opera.txt: Added.
* imported/w3c/tools/wptrunner/wptrunner/browsers/__init__.py:
* imported/w3c/tools/wptrunner/wptrunner/browsers/edge.py:
* imported/w3c/tools/wptrunner/wptrunner/browsers/firefox.py:
* imported/w3c/tools/wptrunner/wptrunner/browsers/opera.py: Added.
* imported/w3c/tools/wptrunner/wptrunner/environment.py:
* imported/w3c/tools/wptrunner/wptrunner/executors/base.py:
* imported/w3c/tools/wptrunner/wptrunner/executors/executoredge.py: Added.
* imported/w3c/tools/wptrunner/wptrunner/executors/executormarionette.py:
* imported/w3c/tools/wptrunner/wptrunner/executors/executoropera.py: Added.
* imported/w3c/tools/wptrunner/wptrunner/executors/executorselenium.py:
* imported/w3c/tools/wptrunner/wptrunner/executors/pytestrunner/runner.py:
* imported/w3c/tools/wptrunner/wptrunner/executors/testharness_webdriver.js:
* imported/w3c/tools/wptrunner/wptrunner/executors/testharness_webdriver_resume.js: Added.
* imported/w3c/tools/wptrunner/wptrunner/stability.py: Added.
* imported/w3c/tools/wptrunner/wptrunner/testdriver-extra.js: Added.
* imported/w3c/tools/wptrunner/wptrunner/testloader.py:
* imported/w3c/tools/wptrunner/wptrunner/testrunner.py:
* imported/w3c/tools/wptrunner/wptrunner/update/state.py:
* imported/w3c/tools/wptrunner/wptrunner/update/sync.py:
* imported/w3c/tools/wptrunner/wptrunner/webdriver_server.py:
* imported/w3c/tools/wptrunner/wptrunner/wptcommandline.py:
* imported/w3c/tools/wptrunner/wptrunner/wptlogging.py:
* imported/w3c/tools/wptrunner/wptrunner/wptrunner.py:
* imported/w3c/tools/wptrunner/wptrunner/wpttest.py:
* imported/w3c/webdriver/tests/actions/conftest.py:
* imported/w3c/webdriver/tests/actions/key.py:
* imported/w3c/webdriver/tests/actions/key_shortcuts.py: Added.
* imported/w3c/webdriver/tests/actions/modifier_click.py: Added.
* imported/w3c/webdriver/tests/actions/mouse.py:
* imported/w3c/webdriver/tests/actions/sequence.py:
* imported/w3c/webdriver/tests/actions/special_keys.py:
* imported/w3c/webdriver/tests/actions/support/keys.py:
* imported/w3c/webdriver/tests/actions/support/test_actions_wdspec.html:
* imported/w3c/webdriver/tests/cookies/add_cookie.py:
* imported/w3c/webdriver/tests/cookies/get_named_cookie.py:
* imported/w3c/webdriver/tests/element_click/stale.py: Added.
* imported/w3c/webdriver/tests/element_retrieval/get_active_element.py:
* imported/w3c/webdriver/tests/interaction/element_clear.py: Added.
* imported/w3c/webdriver/tests/navigation/get_title.py:
* imported/w3c/webdriver/tests/retrieval/find_element.py:
* imported/w3c/webdriver/tests/retrieval/find_element_from_element.py:
* imported/w3c/webdriver/tests/retrieval/find_element_from_elements.py:
* imported/w3c/webdriver/tests/retrieval/find_elements.py:
* imported/w3c/webdriver/tests/sessions/new_session/support/__init__.py:
* imported/w3c/webdriver/tests/state/get_element_attribute.py:
* imported/w3c/webdriver/tests/state/get_element_property.py:
* imported/w3c/webdriver/tests/state/get_element_tag_name.py:
* imported/w3c/webdriver/tests/state/is_element_selected.py:
* imported/w3c/webdriver/tests/support/asserts.py:
* imported/w3c/webdriver/tests/user_prompts/send_alert_text.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Cairo] Gradient::fill() should only operate on PlatformContextCairo
zandobersek@gmail.com [Tue, 21 Nov 2017 13:35:04 +0000 (13:35 +0000)]
[Cairo] Gradient::fill() should only operate on PlatformContextCairo
https://bugs.webkit.org/show_bug.cgi?id=179887

Reviewed by Carlos Garcia Campos.

In Gradient::fill(), directly invoke Cairo::save() and Cairo::restore(),
instead of doing so indirectly through GraphicsContext::save() and
GraphicsContext::restore(). The latter pair stashes the internal state
that's managed in GraphicsContext, but that doesn't get modified at all
in this case.

No new tests -- no change in behavior.

* platform/graphics/cairo/GradientCairo.cpp:
(WebCore::Gradient::fill):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoFix WebKitGTK+ compilation
tpopela@redhat.com [Tue, 21 Nov 2017 12:58:18 +0000 (12:58 +0000)]
Fix WebKitGTK+ compilation

Reviewed by Carlos Garcia Campos.

File "/builddir/build/BUILD/webkitgtk-2.19.2/Tools/gtk/generate-gtkdoc", line 31, in <module>
import common
ImportError: No module named common

* gtk/manifest.txt.in:
Add Tools/glib/common.py to the tarball.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[GTK] Avoid warning in jhbuildrc.
Ms2ger@igalia.com [Tue, 21 Nov 2017 11:28:47 +0000 (11:28 +0000)]
[GTK] Avoid warning in jhbuildrc.
https://bugs.webkit.org/show_bug.cgi?id=179913

Reviewed by Carlos Garcia Campos.

Apparently this is not quite a real python file; this declaration causes
warnings like
  I: unknown keys defined in configuration file: top_level_directory
which break run-webkit-tests.

* gtk/jhbuildrc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[DFG][FTL] Support MapSet / SetAdd intrinsics
utatane.tea@gmail.com [Tue, 21 Nov 2017 10:40:34 +0000 (10:40 +0000)]
[DFG][FTL] Support MapSet / SetAdd intrinsics
https://bugs.webkit.org/show_bug.cgi?id=179858

Reviewed by Saam Barati.

JSTests:

* microbenchmarks/map-has-and-set.js: Added.
(test):
* stress/map-set-check-failure.js: Added.
(shouldBe):
(shouldThrow):
(target):
* stress/map-set-cse.js: Added.
(shouldBe):
(test):
* stress/set-add-check-failure.js: Added.
(shouldBe):
(shouldThrow):
(set shouldThrow):
* stress/set-add-cse.js: Added.
(shouldBe):

Source/JavaScriptCore:

Map.prototype.set and Set.prototype.add uses MapHash value anyway.
By handling them as MapSet and SetAdd DFG nodes and decoupling
MapSet and SetAdd nodes from MapHash DFG node, we have a chance to
remove duplicate MapHash calculation for the same key.

One story is *set-if-not-exists*.

    if (!map.has(key))
        map.set(key, value);

In the above code, both `has` and `set` require hash value for `key`.
If we can change `set` to the series of DFG nodes:

    1: MapHash(key)
    2: MapSet(MapObjectUse:map, Untyped:key, Untyped:value, Int32Use:@1)

we can remove duplicate @1 produced by `has` operation.

This patch improves SixSpeed map-set.es6 and map-set-object.es6 by 20.5% and 20.4% respectively,

                                 baseline                  patched

    map-set.es6             246.2413+-15.2084    ^    204.3679+-11.2408       ^ definitely 1.2049x faster
    map-set-object.es6      266.5075+-17.2289    ^    221.2792+-12.2948       ^ definitely 1.2044x faster

Microbenchmarks

    map-has-and-set         148.1522+-7.6665     ^    131.4552+-7.8846        ^ definitely 1.1270x faster

* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleIntrinsicCall):
* dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
* dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGNodeType.h:
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGPredictionPropagationPhase.cpp:
* dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileSetAdd):
(JSC::DFG::SpeculativeJIT::compileMapSet):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileSetAdd):
(JSC::FTL::DFG::LowerDFGToB3::compileMapSet):
* jit/JITOperations.h:
* runtime/HashMapImpl.h:
(JSC::HashMapImpl::addNormalized):
(JSC::HashMapImpl::addNormalizedInternal):
* runtime/Intrinsic.cpp:
(JSC::intrinsicName):
* runtime/Intrinsic.h:
* runtime/MapPrototype.cpp:
(JSC::MapPrototype::finishCreation):
* runtime/SetPrototype.cpp:
(JSC::SetPrototype::finishCreation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[JSC] Allow poly proto for intrinsic getters
utatane.tea@gmail.com [Tue, 21 Nov 2017 10:07:50 +0000 (10:07 +0000)]
[JSC] Allow poly proto for intrinsic getters
https://bugs.webkit.org/show_bug.cgi?id=179550

Reviewed by Saam Barati.

JSTests:

This change is also tested by existing tests.

    1. stress/intrinsic-getter-with-poly-proto.js
    2. stress/poly-proto-intrinsic-getter-correctness.js

* stress/intrinsic-getter-with-poly-proto-getter-change.js: Added.
(shouldBe):
(makePolyProtoObject.foo.C):
(makePolyProtoObject.foo):
(makePolyProtoObject):
(target):
* stress/intrinsic-getter-with-poly-proto-proto-change.js: Added.
(shouldBe):
(makePolyProtoObject.foo.C):
(makePolyProtoObject.foo):
(makePolyProtoObject):
(target):

Source/JavaScriptCore:

This patch allows intrinsic getters to accept poly proto.
We propagate PolyProtoAccessChain in IntrinsicGetterAccessCase to perform
poly proto checks. And we extend UnderscoreProtoIntrinsic to emit
code for poly proto case.

* bytecode/IntrinsicGetterAccessCase.cpp:
(JSC::IntrinsicGetterAccessCase::IntrinsicGetterAccessCase):
(JSC::IntrinsicGetterAccessCase::create):
* bytecode/IntrinsicGetterAccessCase.h:
* jit/IntrinsicEmitter.cpp:
(JSC::IntrinsicGetterAccessCase::canEmitIntrinsicGetter):
(JSC::IntrinsicGetterAccessCase::emitIntrinsicGetter):
* jit/Repatch.cpp:
(JSC::tryCacheGetByID):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRemove unintentionally committed .orig file.
fred.wang@free.fr [Tue, 21 Nov 2017 09:19:17 +0000 (09:19 +0000)]
Remove unintentionally committed .orig file.
https://bugs.webkit.org/show_bug.cgi?id=174131

Unreviewed, fix previous commit.

Patch by Frederic Wang <fwang@igalia.com> on 2017-11-21

* rendering/mathml/RenderMathMLScripts.cpp.orig: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoASSERTION FAILED: !needsLayout() in WebCore::RenderMathMLScripts::firstLineBaseline
fred.wang@free.fr [Tue, 21 Nov 2017 08:37:59 +0000 (08:37 +0000)]
ASSERTION FAILED: !needsLayout() in WebCore::RenderMathMLScripts::firstLineBaseline
https://bugs.webkit.org/show_bug.cgi?id=174131

Patch by Frederic Wang <fwang@igalia.com> on 2017-11-21
Reviewed by Alejandro G. Castro.

Source/WebCore:

RenderMathMLScripts::firstLineBaseline() has an ASSERT at the beginning to ensure that the function
is called after the element was laid out. However, this is not respected by HTML table layout as
RenderBlock::firstLineBaseline() is called for elements in a table cell before they are laid out.
This happens for example for RenderGrid::firstLineBaseline() and probably for other renderers.
Additionally, RenderMathMLScripts::firstLineBaseline() only involves calling firstLineBaseline();
logicalTop() or logicalHeight() on the first child box so it is safe to call it before layout, even
if the return value might be wrong at that time. This patch removes this too restrictive ASSERT for
RenderMathMLScripts, for consistency with other implementations of firstLineBaseline().

Test: mathml/cells-and-scripts-crash.html

* rendering/mathml/RenderMathMLScripts.cpp:
(WebCore::RenderMathMLScripts::firstLineBaseline const): Remove the ASSERT.

LayoutTests:

Add tests for calling RenderMathMLScripts::firstLineBaseline with needsLayout() == true.

* mathml/cells-and-scripts-crash-expected.txt: Added.
* mathml/cells-and-scripts-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed. Fix WPE make distcheck.
carlosgc@webkit.org [Tue, 21 Nov 2017 08:03:52 +0000 (08:03 +0000)]
Unreviewed. Fix WPE make distcheck.

* wpe/manifest.txt.in: Add generate-inspector-gresource-manifest.py to the tarball.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed. Update OptionsGTK.cmake and NEWS for 2.19.2 release.
carlosgc@webkit.org [Tue, 21 Nov 2017 08:01:17 +0000 (08:01 +0000)]
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.19.2 release.

.:

* Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit:

* gtk/NEWS: Add release notes for 2.19.2.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed. Fix GTK+ make distcheck.
carlosgc@webkit.org [Tue, 21 Nov 2017 07:59:26 +0000 (07:59 +0000)]
Unreviewed. Fix GTK+ make distcheck.

* gtk/manifest.txt.in: Add generate-inspector-gresource-manifest.py to the tarball.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAdd declspec within WebKit API
don.olmstead@sony.com [Tue, 21 Nov 2017 02:49:35 +0000 (02:49 +0000)]
Add declspec within WebKit API
https://bugs.webkit.org/show_bug.cgi?id=179893

Reviewed by Darin Adler.

* Shared/API/c/WKDeclarationSpecifiers.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoDetect __declspec within JSBase.h
don.olmstead@sony.com [Tue, 21 Nov 2017 02:48:14 +0000 (02:48 +0000)]
Detect __declspec within JSBase.h
https://bugs.webkit.org/show_bug.cgi?id=179892

Reviewed by Darin Adler.

* API/JSBase.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, mark one more GTK test as passing
mcatanzaro@igalia.com [Tue, 21 Nov 2017 02:29:15 +0000 (02:29 +0000)]
Unreviewed, mark one more GTK test as passing

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoSkip stress/unshiftCountSlowCase-correct-postCapacity.js on embedded Linux
guijemont@igalia.com [Tue, 21 Nov 2017 01:27:02 +0000 (01:27 +0000)]
Skip stress/unshiftCountSlowCase-correct-postCapacity.js on embedded Linux
https://bugs.webkit.org/show_bug.cgi?id=179744

Reviewed by Michael Catanzaro.

This test uses too much memory for our buildbots on these platforms
and gets OOM-killed.

* stress/unshiftCountSlowCase-correct-postCapacity.js:
Skip if $memoryLimited and linux.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[WPE] Disable ACCELERATED_2D_CANVAS in FeatureList.pm
mcatanzaro@igalia.com [Tue, 21 Nov 2017 01:25:50 +0000 (01:25 +0000)]
[WPE] Disable ACCELERATED_2D_CANVAS in FeatureList.pm
https://bugs.webkit.org/show_bug.cgi?id=179889

Reviewed by Darin Adler.

* Scripts/webkitperl/FeatureList.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoLayout Test js/intl-datetimeformat.html is failing on High Sierra (GMT vs. UTC)
commit-queue@webkit.org [Tue, 21 Nov 2017 01:24:37 +0000 (01:24 +0000)]
Layout Test js/intl-datetimeformat.html is failing on High Sierra (GMT vs. UTC)
https://bugs.webkit.org/show_bug.cgi?id=179208

Patch by Andy VanWagoner <andy@thetalecrafter.com> on 2017-11-20
Reviewed by Darin Adler.

Use time zones that are unambiguous in datetimeformat tests.

* js/intl-datetimeformat-expected.txt:
* js/script-tests/intl-datetimeformat.js:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed GTK test gardening
mcatanzaro@igalia.com [Tue, 21 Nov 2017 00:58:14 +0000 (00:58 +0000)]
Unreviewed GTK test gardening

* TestExpectations:
* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoBetter unreviewed WPE test gardening
mcatanzaro@igalia.com [Mon, 20 Nov 2017 23:55:48 +0000 (23:55 +0000)]
Better unreviewed WPE test gardening

I gave this test a TIMEOUT expectation because there is an XHR timeout, but that was dumb
because the test itself does not time out.

* platform/wpe/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed WPE test gardening
mcatanzaro@igalia.com [Mon, 20 Nov 2017 23:54:04 +0000 (23:54 +0000)]
Unreviewed WPE test gardening

* platform/wpe/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, speculative attempt to fix run-gtk-tests after r225047
mcatanzaro@igalia.com [Mon, 20 Nov 2017 23:51:54 +0000 (23:51 +0000)]
Unreviewed, speculative attempt to fix run-gtk-tests after r225047
https://bugs.webkit.org/show_bug.cgi?id=173772

* jhbuild/jhbuildutils.py:
(enter_jhbuild_environment_if_available):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[GTK] New API to add, retrieve and delete cookies via WebKitCookieManager
mario@webkit.org [Mon, 20 Nov 2017 22:02:46 +0000 (22:02 +0000)]
[GTK] New API to add, retrieve and delete cookies via WebKitCookieManager
https://bugs.webkit.org/show_bug.cgi?id=177932

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Implemented setCookie(), getCookies() and deleteCookie() in the Soup
backend, and refactored some utility functions and conversions out of
NetworkStorageSessionSoup into a new CookieSoup.cpp file, so
that we now can convert between SoupCookie* and WebCore::Cookie
easily from anywhere (this is now needed from the UI Process).

* platform/Cookie.h: Add declarations for the new conversions.
* platform/SourcesSoup.txt: Add CookieSoup.cpp.
* platform/network/soup/CookieSoup.cpp: Added.
(WebCore::Cookie::Cookie): New constructor, creates a WebCore::Cookie out of a SoupCookie*.
(WebCore::msToSoupDate): Moved from NetworkStorageSessionSoup.cpp.
(WebCore::Cookie::toSoupCookie): New, based on toSoupCookie() from NetworkStorageSessionSoup.cpp.
* platform/network/soup/NetworkStorageSessionSoup.cpp:
(WebCore::NetworkStorageSession::setCookies): Used the new implicit conversion.
(WebCore::NetworkStorageSession::setCookie): Newly implemented.
(WebCore::NetworkStorageSession::deleteCookie): Newly implemented.
(WebCore::NetworkStorageSession::getCookies): Newly implemented.

Source/WebKit:

Added new API to WebKitCookieManager to add, retrieve and delete complete
cookies into/out-of a running session, and updated documentation sections.

* UIProcess/API/glib/WebKitCookieManager.cpp:
(webkit_cookie_manager_add_cookie): New function.
(webkit_cookie_manager_add_cookie_finish): Ditto.
(webkit_cookie_manager_get_cookies): Ditto.
(webkit_cookie_manager_get_cookies_finish): Ditto.
(webkit_cookie_manager_delete_cookie): Ditto.
(webkit_cookie_manager_delete_cookie_finish): Ditto.
* UIProcess/API/gtk/WebKitCookieManager.h: Added new functions.
* UIProcess/API/wpe/WebKitCookieManager.h: Ditto.
* UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt: Ditto.

Tools:

Added new test cases to cover the newly added API for WebKitCookieManager:
webkit_cookie_manager_add_cookie, webkit_cookie_manager_get_cookies and
webkit_cookie_manager_delete_cookie.

* TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
(testCookieManagerAddCookie): Added.
(testCookieManagerGetCookies): Added.
(testCookieManagerDeleteCookie): Added.
(serverCallback): Small update to avoid hardcoding strings we reuse.
(beforeAll): Added the new test cases to the test suite.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Win] Update ruby JSC test writer for gigacage changes
commit-queue@webkit.org [Mon, 20 Nov 2017 21:20:15 +0000 (21:20 +0000)]
[Win] Update ruby JSC test writer for gigacage changes
https://bugs.webkit.org/show_bug.cgi?id=178757

Patch by Stephan Szabo <stephan.szabo@sony.com> on 2017-11-20
Reviewed by Keith Miller.

* Scripts/webkitruby/jsc-stress-test-writer-ruby.rb:
Add additionalEnv to ruby test writer Plan

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRemove slow repaint object from FrameView when style changes.
zalan@apple.com [Mon, 20 Nov 2017 17:18:57 +0000 (17:18 +0000)]
Remove slow repaint object from FrameView when style changes.
https://bugs.webkit.org/show_bug.cgi?id=179871

Reviewed by Antti Koivisto.

Source/WebCore:

The "oldStyleSlowScroll" value does not need to be computed. We already know its value
by checking the HashSet. This code is also unnecessarily complicated and error prone
(could lead to UAF errors by leaving stale renderers in the slow paint list).

Test: fast/repaint/slow-repaint-object-crash.html

* rendering/RenderElement.cpp:
(WebCore::RenderElement::styleWillChange):

LayoutTests:

* fast/repaint/slow-repaint-object-crash-expected.txt: Added.
* fast/repaint/slow-repaint-object-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[WPE] GLContextEGLWPE.cpp:44:96: error: invalid cast from type ‘GLNativeWindowType...
clopez@igalia.com [Mon, 20 Nov 2017 15:57:57 +0000 (15:57 +0000)]
[WPE] GLContextEGLWPE.cpp:44:96: error: invalid cast from type ‘GLNativeWindowType {aka long long unsigned int}’ to type ‘EGLNativeWindowType {aka unsigned int}
https://bugs.webkit.org/show_bug.cgi?id=179511

Reviewed by Žan Doberšek.

r217208 changed the definition of GLNativeWindowType from EGLNativeWindowType to uint64_t for platform WPE.
This built fine on a 64-bit platform since uint64_t matches the size of a pointer, but fails on 32-bits.

This switches back the definition to EGLNativeWindowType.
And we need to include <EGL/eglplatform.h> first in order to get a definition for EGLNativeWindowType itself.

This commit pretty much reverts the changes r217208 did on platform/graphics/GLContext.h

No new tests, it is a build fix.

* platform/graphics/GLContext.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRemove ENABLE_ALLINONE_BUILD option
mcatanzaro@igalia.com [Mon, 20 Nov 2017 15:46:17 +0000 (15:46 +0000)]
Remove ENABLE_ALLINONE_BUILD option
https://bugs.webkit.org/show_bug.cgi?id=179823

Reviewed by Darin Adler.

.:

* Source/cmake/OptionsWin.cmake:
* Source/cmake/WebKitFeatures.cmake:

Source/WebCore:

* CMakeLists.txt:

Tools:

* Scripts/webkitperl/FeatureList.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoIncorrect computed style in pseudo-elements with display: contents
emilio@crisal.io [Mon, 20 Nov 2017 12:32:07 +0000 (12:32 +0000)]
Incorrect computed style in pseudo-elements with display: contents
https://bugs.webkit.org/show_bug.cgi?id=179812

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

* web-platform-tests/cssom/getComputedStyle-pseudo-expected.txt:
* web-platform-tests/cssom/getComputedStyle-pseudo.html:
  Extended the testcase to cover this bug.

Source/WebCore:

Bug 178513 gave them an anon renderer as the main renderer. Unfortunately, the
style of that box is exposed via getComputedStyle, so that needs to be handled
somehow to return the correct style.

Tests: imported/w3c/web-platform-tests/cssom/getComputedStyle-pseudo.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::styledRenderer const):
  Don't return a display: contents pseudo anon box.
* dom/Element.cpp:
(WebCore::Element::hasDisplayContents const):
  Just look at the rare data style.
(WebCore::Element::existingComputedStyle const):
  Look at the rare data first. This also fixes an inefficiency in the
  sense that before then we'd compare the anon box style to the
  pseudo-element style during style update, that may be more changes
  than needed.
* style/RenderTreeUpdaterGeneratedContent.cpp:
(WebCore::RenderTreeUpdater::GeneratedContent::updatePseudoElement):
* style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::resolvePseudoStyle):
  Move the anon box creation to render tree update instead of style
  resolution.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed. Fix WPE build after r225047.
carlosgc@webkit.org [Mon, 20 Nov 2017 11:22:30 +0000 (11:22 +0000)]
Unreviewed. Fix WPE build after r225047.

Remove changes from an old patch committed by mistake in r225047.

* WebKitTestRunner/PlatformWebView.h:
* WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:
(WTR::PlatformWebView::windowSnapshotImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[WPE] Add run-wpe-tests script to run WPE glib API tests
carlosgc@webkit.org [Mon, 20 Nov 2017 11:03:26 +0000 (11:03 +0000)]
[WPE] Add run-wpe-tests script to run WPE glib API tests
https://bugs.webkit.org/show_bug.cgi?id=173772

Reviewed by Michael Catanzaro.

Move common code from run-gtk-tests to api_test_runner.py, to be shared by both run-gtk-tests and un-wpe-tests.

* Scripts/run-gtk-tests:
(GtkTestRunner):
(GtkTestRunner.__init__):
(GtkTestRunner._start_accessibility_daemons):
(GtkTestRunner._setup_testing_environment):
(GtkTestRunner._tear_down_testing_environment):
(GtkTestRunner.is_glib_test):
(GtkTestRunner.is_google_test):
* Scripts/run-wpe-tests: Added.
(WPETestRunner):
(WPETestRunner.__init__):
(WPETestRunner.is_glib_test):
(WPETestRunner.is_google_test):
* Scripts/webkitpy/port/headlessdriver.py: Added.
(HeadlessDriver):
(HeadlessDriver._setup_environ_for_test):
(HeadlessDriver._start):
* Scripts/webkitpy/port/headlessdriver_unittest.py: Added.
(HeadlessDriverTest):
(HeadlessDriverTest.make_driver):
(HeadlessDriverTest.make_environment):
(HeadlessDriverTest.test_environment_needed_variables):
(HeadlessDriverTest.test_environment_forbidden_variables):
* Scripts/webkitpy/port/wpe.py:
(WPEPort._driver_class):
* WebKitTestRunner/PlatformWebView.h:
* WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:
(WTR::PlatformWebView::windowSnapshotImage):
* glib/api_test_runner.py: Copied from Tools/Scripts/run-gtk-tests.
(SkippedTest):
(SkippedTest.__init__):
(SkippedTest.__str__):
(SkippedTest.skip_entire_suite):
(SkippedTest.skip_for_build_type):
(TestTimeout):
(TestRunner):
(TestRunner.__init__):
(TestRunner._test_programs_base_dir):
(TestRunner._get_tests_from_dir):
(TestRunner._get_tests):
(TestRunner._create_driver):
(TestRunner._setup_testing_environment):
(TestRunner._tear_down_testing_environment):
(TestRunner._test_cases_to_skip):
(TestRunner._should_run_test_program):
(TestRunner._kill_process):
(TestRunner._start_timeout):
(TestRunner._start_timeout._alarm_handler):
(TestRunner._stop_timeout):
(TestRunner._waitpid):
(TestRunner._run_test_glib):
(TestRunner._run_test_glib.parse_line):
(TestRunner._run_test_glib.parse_line.set_test_result):
(TestRunner._get_tests_from_google_test_suite):
(TestRunner._run_google_test):
(TestRunner._run_google_test_suite):
(TestRunner.is_glib_test):
(TestRunner.is_google_test):
(TestRunner._run_test):
(TestRunner.run_tests):
(add_options):
* glib/common.py: Renamed from Tools/gtk/common.py.
(get_build_path.is_valid_build_directory):
* gtk/generate-gtkdoc:
* gtk/jhbuildrc:
* gtk/ycm_extra_conf.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[WPE] Build C API tests
carlosgc@webkit.org [Mon, 20 Nov 2017 09:51:07 +0000 (09:51 +0000)]
[WPE] Build C API tests
https://bugs.webkit.org/show_bug.cgi?id=179817

Reviewed by Michael Catanzaro.

* TestWebKitAPI/CMakeLists.txt:
* TestWebKitAPI/PlatformGTK.cmake:
* TestWebKitAPI/PlatformWPE.cmake:
* TestWebKitAPI/PlatformWebView.h:
* TestWebKitAPI/wpe/PlatformUtilitiesWPE.cpp:
(TestWebKitAPI::Util::URLForNonExistentResource):
(TestWebKitAPI::Util::isKeyDown):
* TestWebKitAPI/wpe/PlatformWebViewWPE.cpp: Added.
(TestWebKitAPI::PlatformWebView::PlatformWebView):
(TestWebKitAPI::PlatformWebView::~PlatformWebView):
(TestWebKitAPI::PlatformWebView::initialize):
(TestWebKitAPI::PlatformWebView::page const):
(TestWebKitAPI::PlatformWebView::resizeTo):
(TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
(TestWebKitAPI::PlatformWebView::simulateAltKeyPress):
(TestWebKitAPI::PlatformWebView::simulateRightClick):
(TestWebKitAPI::PlatformWebView::simulateMouseMove):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[WPE] Add env var WPE_USE_HEADLESS_VIEW_BACKEND
carlosgc@webkit.org [Mon, 20 Nov 2017 09:47:56 +0000 (09:47 +0000)]
[WPE] Add env var WPE_USE_HEADLESS_VIEW_BACKEND
https://bugs.webkit.org/show_bug.cgi?id=173770

Reviewed by Michael Catanzaro.

Move HeadlessViewBackend implementation to a common place and build it as a private static library to be used by
WTR, GLib API tests and eventually C API tests too. WTR uses the HeadlessViewBackend unconditionally, but GLib
API tests use it only when WPE_USE_HEADLESS_VIEW_BACKEND environment variable is present and not "0".

* CMakeLists.txt: Include wpe/HeadlessViewBackend directory for developer builds.
* TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
(testAutomationSessionRequestSession):
* TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
(testCookieManagerEphemeral):
* TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
(testPrivateBrowsing):
* TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
(testWebContextProxySettings):
* TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
(testWebViewWebContext):
(testWebViewEphemeral):
* TestWebKitAPI/glib/PlatformWPE.cmake:
* TestWebKitAPI/glib/WebKitGLib/TestMain.h:
(Test::createWebViewBackend):
(Test::createWebView):
* TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
(WebViewTest::initializeWebView):
* WebKitTestRunner/PlatformWPE.cmake:
* wpe/HeadlessViewBackend/CMakeLists.txt: Added.
* wpe/HeadlessViewBackend/HeadlessViewBackend.cpp: Renamed from Tools/WebKitTestRunner/wpe/HeadlessViewBackend.cpp.
(HeadlessViewBackend::HeadlessViewBackend):
* wpe/HeadlessViewBackend/HeadlessViewBackend.h: Renamed from Tools/WebKitTestRunner/wpe/HeadlessViewBackend.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[WPE] webkit_web_view_new() should enable specifying wpe_view_backend object
carlosgc@webkit.org [Mon, 20 Nov 2017 08:16:26 +0000 (08:16 +0000)]
[WPE] webkit_web_view_new() should enable specifying wpe_view_backend object
https://bugs.webkit.org/show_bug.cgi?id=178655

Reviewed by Michael Catanzaro.

Source/WebKit:

Update all WebKitWebView constructors to receive a WebKitWebViewBackend as argument. It's now required to
provide a backend to create a web view, but it can be NULL to use the default one. WebKitWebViewBackend is a
boxed type wrapping a struct wpe_view_backend* used as construct only property of WebKitWebView. The view always
takes the ownership of the WebKitWebViewBackend which owns the struct wpe_view_backend*. An optional
GDestroyNotify and user data pointer can be passed to the WebKitWebViewBackend constructor to provide a custom
deleter for the backend. In the C API the struct wpe_view_backend* is also mandatory now, but it can't be NULL
and it's owned by the caller, not the view.

* PlatformWPE.cmake:
* UIProcess/API/C/wpe/WKView.cpp:
(WKViewCreate):
* UIProcess/API/C/wpe/WKView.h:
* UIProcess/API/glib/WebKitWebView.cpp:
(_WebKitWebViewPrivate::~_WebKitWebViewPrivate):
(webkitWebViewConstructed):
(webkitWebViewSetProperty):
(webkitWebViewGetProperty):
(webkit_web_view_class_init):
(webkitWebViewCreatePage):
(webkit_web_view_get_backend):
* UIProcess/API/wpe/WPEView.cpp:
(WKWPE::m_backend):
(WKWPE::View::~View):
* UIProcess/API/wpe/WebKitWebView.h:
* UIProcess/API/wpe/WebKitWebViewBackend.cpp: Added.
(_WebKitWebViewBackend::_WebKitWebViewBackend):
(_WebKitWebViewBackend::~_WebKitWebViewBackend):
(webkitWebViewBackendRef):
(webkitWebViewBackendUnref):
(webkitWebViewBackendCreateDefault):
(webkit_web_view_backend_new):
(webkit_web_view_backend_get_wpe_backend):
* UIProcess/API/wpe/WebKitWebViewBackend.h: Added.
* UIProcess/API/wpe/WebKitWebViewBackendPrivate.h: Added.
* UIProcess/API/wpe/WebKitWebViewWPE.cpp:
(webkit_web_view_new):
(webkit_web_view_new_with_context):
(webkit_web_view_new_with_related_view):
(webkit_web_view_new_with_settings):
(webkit_web_view_new_with_user_content_manager):
* UIProcess/API/wpe/webkit.h:

Tools:

Update unit tests to create web views using helper methods that have a different implementation for GTK and
WPE. Also add a new test case to check the new API to create a WebKitWebView with a WPE backend. Use
WKViewCreate in WTR and fix a memory leak in HeadlessViewBackend.

* TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
(testAutomationSessionRequestSession):
* TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
(testWebKitWebViewSessionState):
(testWebKitWebViewSessionStateWithFormData):
(testWebKitWebViewNavigationAfterSessionRestore):
* TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
* TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
(testWebResourceGetDataError):
* TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
* TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
(testWebViewNewWithUserContentManager):
* TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
(testWebContextEphemeral):
* TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
(testWebViewWebContext):
(testWebViewWebContextLifetime):
(testWebViewWebBackend):
(testWebViewSettings):
(beforeAll):
* TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
(testWebsiteDataEphemeral):
* TestWebKitAPI/glib/WebKitGLib/TestMain.h:
(Test::createWebView):
* WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
(HeadlessViewBackend::~HeadlessViewBackend):
* WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:
(WTR::PlatformWebView::PlatformWebView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[GTK][WPE] webkit_cookie_manager_delete_all_cookies doesn't delete the cookies if...
carlosgc@webkit.org [Mon, 20 Nov 2017 08:11:29 +0000 (08:11 +0000)]
[GTK][WPE] webkit_cookie_manager_delete_all_cookies doesn't delete the cookies if called before a web process is running
https://bugs.webkit.org/show_bug.cgi?id=175265

Reviewed by Michael Catanzaro.

Source/WebKit:

This is what happens:

1- We create our WebKitWebContext that creates its WebProcessPool.
2- We set a persistent cookies storage.
3- We ask the website data store to delete all cookies, but since website data store is a web process observer
   and we haven't spawned any web process yet, it creates a new WebProcessPool with the default configuration
   (no persistent cookies) and sends the message to delete the cookies there.
4- The network process of the second process pool does nothing because it doesn't have cookies at all.

We need to set the primary data store of the WebProcessPool when WebKitWebContext is constructed to ensure that
one is used before the web process is launched.

* UIProcess/API/glib/WebKitWebContext.cpp:
(webkitWebContextConstructed):

Tools:

Add test case.

* TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
(testCookieManagerPersistentStorageDeleteAll):
(serverCallback):
(beforeAll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRemove unused TOUCH_ICON_LOADING feature flag
timothy_horton@apple.com [Mon, 20 Nov 2017 05:10:43 +0000 (05:10 +0000)]
Remove unused TOUCH_ICON_LOADING feature flag
https://bugs.webkit.org/show_bug.cgi?id=179873

Reviewed by Simon Fraser.

.:

* Source/cmake/OptionsMac.cmake:
* Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit:

* Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WTF:

* wtf/FeatureDefines.h:

Tools:

* Scripts/webkitperl/FeatureList.pm:
* TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[WPE] Enable the XMLHttpRequest/ directory of web-platform-tests.
Ms2ger@igalia.com [Mon, 20 Nov 2017 03:53:48 +0000 (03:53 +0000)]
[WPE] Enable the XMLHttpRequest/ directory of web-platform-tests.
https://bugs.webkit.org/show_bug.cgi?id=179820

Reviewed by Sam Weinig.

Added test expectations are copied from platform/gtk/

* platform/wpe/TestExpectations:
* platform/wpe/imported/w3c/web-platform-tests/XMLHttpRequest/send-entity-body-get-head-async-expected.txt: Added.
* platform/wpe/imported/w3c/web-platform-tests/XMLHttpRequest/send-entity-body-get-head-expected.txt: Added.
* platform/wpe/imported/w3c/web-platform-tests/XMLHttpRequest/send-redirect-expected.txt: Added.
* platform/wpe/imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-content-type-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAdd CPU(UNKNOWN) to cover all the unknown CPU types
utatane.tea@gmail.com [Mon, 20 Nov 2017 01:41:20 +0000 (01:41 +0000)]
Add CPU(UNKNOWN) to cover all the unknown CPU types
https://bugs.webkit.org/show_bug.cgi?id=179243

Reviewed by JF Bastien.

.:

Drop SH4, S390, and S390X explicit support. They are handled as CPU(UNKNOWN).

* CMakeLists.txt:

Source/JavaScriptCore:

* CMakeLists.txt:

Source/WTF:

This patch adds a new CPU type, `CPU(UNKNOWN)` to cover all the unknown CPUs.
This CPU architecture tells conservative assumption to make JSC work on all
the unknown generic CPUs. And we make several CPUs (ALPHA, SH4, S390, S390X, IA64, IA64_32)
UNKNOWN.

We also make InlineASM available only for !CPU(UNKNOWN). In an unknown CPU, inline asm is not useful.

And we also introduce a generic way to detect 64bit pointer environment by using
__SIZEOF_POINTER__ predefined macro, or `UINTPTR_MAX > UINT32_MAX`.

* wtf/InlineASM.h:
* wtf/Platform.h:
* wtf/dtoa/utils.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRemove unused LEGACY_VENDOR_PREFIXES feature flag
timothy_horton@apple.com [Mon, 20 Nov 2017 01:31:57 +0000 (01:31 +0000)]
Remove unused LEGACY_VENDOR_PREFIXES feature flag
https://bugs.webkit.org/show_bug.cgi?id=179872

Reviewed by Darin Adler.

.:

* Source/cmake/OptionsMac.cmake:
* Source/cmake/OptionsWin.cmake:
* Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit:

* Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WTF:

* wtf/FeatureDefines.h:

Tools:

* TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoFix potential thread safety issue in ThreadSafeIdentified
cdumez@apple.com [Mon, 20 Nov 2017 01:08:20 +0000 (01:08 +0000)]
Fix potential thread safety issue in ThreadSafeIdentified
https://bugs.webkit.org/show_bug.cgi?id=179879

Reviewed by Darin Adler.

Fix potential thread safety issue in ThreadSafeIdentified. Protect static std::atomic
initialization with an std::call_once() given that we build with
--fno-threadsafe-statics.

* wtf/Identified.h:
(WTF::Identified::Identified):
(WTF::Identified::generateIdentifier):
(WTF::ThreadSafeIdentified::ThreadSafeIdentified):
(WTF::ThreadSafeIdentified::generateIdentifier):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoEliminate some cases of double hashing, other related refactoring
darin@apple.com [Mon, 20 Nov 2017 00:56:27 +0000 (00:56 +0000)]
Eliminate some cases of double hashing, other related refactoring
https://bugs.webkit.org/show_bug.cgi?id=179867

Reviewed by Sam Weinig.

Source/WebCore:

* Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::objectStore): Use get instead of find.

* Modules/mediasource/MediaSourceRegistry.cpp:
(WebCore::MediaSourceRegistry::unregisterURL): Use take instead of find/remove.

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::~AXObjectCache): Call setAXObjectID instead of
using the removeAXID, which doesn't do anything else useful in the destructor.
(WebCore::AXObjectCache::remove): Use take instead of get/remove. Also rearrange
logic to eliminate the removeAXID function.
(WebCore::AXObjectCache::removeAXID): Deleted. This only did two things,
setAXObjectID(0) and remove from m_idsInUse, and was only called in one place
besides the destructor. Clearer to not have this funtion.
(WebCore::AXObjectCache::visiblePositionForTextMarkerData): Use m_idsInUse
directly instead of using a function.

* accessibility/AXObjectCache.h: Deleted removeAXID and isIDinUse.

* dom/Document.cpp:
(WebCore::Document::removedLastRef): Call UserActionElementSet::clear instead
of UserActionElementSet::documentDidRemoveLastRef; new name fo the same function.
(WebCore::Document::updateHoverActiveState): Use a reference when calling
setInActiveChain.

* dom/Element.cpp:
(WebCore::Element::isUserActionElementInActiveChain const): Pass reference
instead of pointer.
(WebCore::Element::isUserActionElementActive const): Ditto.
(WebCore::Element::isUserActionElementFocused const): Ditto.
(WebCore::Element::isUserActionElementHovered const): Ditto.
(WebCore::Element::setActive): Ditto.
(WebCore::Element::setFocus): Ditto.
(WebCore::Element::setHovered): Ditto.
(WebCore::Element::clearHoverAndActiveStatusBeforeDetachingRenderer): Ditto.

* dom/GenericEventQueue.cpp:
(WebCore::GenericEventQueue::resume): Removed unneeded speical case for
empty vector.

* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::checkStyleSheet): Updated now that
parseAttributes returns an optional instead of using a boolean "OK" out argument.

* dom/SelectorQuery.cpp:
(WebCore::SelectorQueryCache::add): Use get instead of find.

* dom/UserActionElementSet.cpp:
(WebCore::UserActionElementSet::didDetach): Deleted. Moved to class definition and
named clearActiveAndHovered.
(WebCore::UserActionElementSet::clear): Renamed documentDidRemoveLastRef to clear.
(WebCore::UserActionElementSet::hasFlag const): Renamed from hasFlags and also
take reference and enumeration instead of pointer and unsigned. Makes it clearer
this does not allow null and that it works on a single flag, not a set of flags.
(WebCore::UserActionElementSet::clearFlags): Changed argument types to reference
and OptionSet to make it clear this works on a set of flags.
(WebCore::UserActionElementSet::setFlags): Ditto.

* dom/UserActionElementSet.h: Updated for changes above. Also made some name
changes, and used an enum class instead of an enum.

* html/BaseCheckableInputType.cpp:
(WebCore::BaseCheckableInputType::saveFormControlState const): Updated since
FormControlState is now just a vector, not a class.
* html/FileInputType.cpp:
(WebCore::FileInputType::filesFromFormControlState): Ditto.
(WebCore::FileInputType::restoreFormControlState): Removed unneeded check that
valueSize is a multiple of 2. Code will ignore any extra strings at the end, so
there is no need for the validity check.

* html/FormController.cpp:
(WebCore::serializeFormControlStateTo): Made a non-member function since
FormControlState is now just a vector, not a class.
(WebCore::deserializeFormControlState): Ditto. Also return optional instead
of relying on a special failure state.
(WebCore::SavedFormState::deserialize): Updated for above changes.
(WebCore::SavedFormState::serializeTo const): Ditto.
(WebCore::SavedFormState::appendControlState): Use add instead of both find and add
to avoid double hashing.
(WebCore::SavedFormState::takeControlState): Removed unneeded check for empty
hash table and tweaked coding style.
(WebCore::SavedFormState::referencedFilePaths const): Renamed to remove "get".
(WebCore::FormKeyGenerator::formKey): Use ensure instead of find and add.
(WebCore::FormController::formElementsCharacterCount const): Don't call
saveFormControlState for non-text-form-controls since we ignored those values.
(WebCore::FormController::willDeleteForm): Take a reference.
(WebCore::FormController::restoreControlStateFor): Update since FormControlState
is now a vector.
(WebCore::FormController::restoreControlStateIn): Use is/downcast and update
since FormControlState is now a vector.
(WebCore::FormController::referencedFilePaths): Renamed to remove "get".
(WebCore::FormController::registerFormElementWithState):Take a reference.
(WebCore::FormController::unregisterFormElementWithState): Ditto.

* html/FormController.h: Removed FormControlState class since it was just a
Vector<String> with various unneeded features, such as a "failure" state,
and a never-looked-at type of "skip" or "restore". Updated for other changes
above.

* html/HTMLFormControlElementWithState.cpp:
(WebCore::HTMLFormControlElementWithState::insertedIntoAncestor): Pass reference.
(WebCore::HTMLFormControlElementWithState::removedFromAncestor): Ditto.
* html/HTMLFormControlElementWithState.h: Updated for the above. Also added
support for using is/downcast on this.

* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::~HTMLFormElement): Pass reference.

* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::saveFormControlState const): Use reserveInitialCapacit
and uncheckedAppend.
(WebCore::HTMLSelectElement::restoreFormControlState): Updated since state is now
a vector.
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::saveFormControlState const): Ditto.
* html/HiddenInputType.cpp:
(WebCore::HiddenInputType::saveFormControlState const): Ditto.
* html/InputType.cpp:
(WebCore::InputType::saveFormControlState const): Ditto.

* inspector/agents/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::forcePseudoState): Use get instead of find/end and got
rid of uneeded special case. In another overload, ue add and remove instead of
a find followed by a set or a remove.
(WebCore::InspectorCSSAgent::asInspectorStyleSheet): Use ensure instead of find/set.
(WebCore::InspectorCSSAgent::didRemoveDOMNode): Use take instead of find/remove.
(WebCore::InspectorCSSAgent::didModifyDOMAttr): Use get instead of find.
* inspector/agents/InspectorCSSAgent.h: Removed unneeded NodeToInspectorStyleSheet
typedef and changed value type to Ref instead of RefPtr.

* inspector/agents/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::unbind): Use remove instead of contains/remove.
(WebCore::InspectorDOMAgent::nodeForId): Use isValidKey instead of just checking for
0 and use get instead of find.
(WebCore::InspectorDOMAgent::setAttributesAsText): Take out bogus const.
(WebCore::InspectorDOMAgent::moveTo): Ditto.
(WebCore::InspectorDOMAgent::resolveNode): Ditto.
(WebCore::InspectorDOMAgent::isWhitespace): Added FIXME. Use is<Text> instead of
slower nodeType.
* inspector/agents/InspectorDOMAgent.h: Removed bogus const.

* inspector/agents/InspectorLayerTreeAgent.cpp:
(WebCore::InspectorLayerTreeAgent::bind): Use ensure instead of get/set.
(WebCore::InspectorLayerTreeAgent::unbind): Use take instead of find/remove.
(WebCore::InspectorLayerTreeAgent::bindPseudoElement): Use ensure instead of get/set.
(WebCore::InspectorLayerTreeAgent::unbindPseudoElement): Use take instead of
find/remove.

* inspector/agents/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::getCookies): Use add instead of contains/add.
(WebCore::InspectorPageAgent::frameDetached): Use take instead of find/remove.
(WebCore::InspectorPageAgent::frameId): Use ensure instead of get/set.
(WebCore::InspectorPageAgent::loaderId): Use ensure instead of get/set.
(WebCore::InspectorPageAgent::findFrameWithSecurityOrigin): Got rid of unneeded
local variable.

* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::sessionID const): Tweaked coding style and added
a null check for page.
(WebCore::CachedResourceLoader::requestResource): Call page directly on the frame
instead of first getting the main frame. Also use take instead of find/remove.
(WebCore::CachedResourceLoader::removeCachedResource): Rewrite assertion.

* platform/graphics/FontGenericFamilies.cpp:
(WebCore::setGenericFontFamilyForScript): Use remove instead of find/remove.
Simplified the logic a bit in the add case.

* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::pauseAnimation): Use add instead of find/add.
Removed code that said "if (action != Remove) action = Pause" since that is a
no-op; there are only two actions, Remove and Pause.

* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::mediaControlsScript): Use makeString instead of StringBuilder.
(WebCore::RenderThemeMac::systemColor const): Rewrote to use ensure instead of add.
Also crunched the code a little.

* testing/Internals.cpp:
(WebCore::Internals::getReferencedFilePaths const): Updated function name.

* xml/parser/XMLDocumentParser.h: Updated for change below.
* xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::attributesStartElementNsHandler): Updated to use std::optional instead of
a separate boolean for AttributeParseState.
(WebCore::parseAttributes): Ditto. Also changed the return value to work the same way.

Source/WTF:

* wtf/text/StringImpl.cpp:
(WTF::StringImpl::containsOnlyWhitespace): Added FIXME.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoClean up gradient code in preparation for conic gradients
commit-queue@webkit.org [Sun, 19 Nov 2017 23:06:03 +0000 (23:06 +0000)]
Clean up gradient code in preparation for conic gradients
https://bugs.webkit.org/show_bug.cgi?id=179595

Patch by Sam Weinig <sam@webkit.org> on 2017-11-19
Reviewed by Darin Adler.

- Switches Gradient to use a Varient with type specific data structs and makes the
  points / radii immutable.
- Replaces CSSGradientValue::addStops with template function CSSGradientValue::computeStops
  which dispatches to a helper adoptor struct which is passed in for gradient type specific
  values, rather than switching on type in the function itself. In addition, the function no
  longer mutates a Gradient, but rather mutates type specific the data struct (e.g. Linear or
  Radial for now).

* css/CSSGradientValue.cpp:
(WebCore::LinearGradientAdaptor::LinearGradientAdaptor):
(WebCore::RadialGradientAdaptor::RadialGradientAdaptor):

    Add helper structs for the now templatized CSSGradientValue::computeStops that
    implement type specific functionality.

(WebCore::CSSGradientValue::computeStops):

    Renamed from addStops. Now takes a GradientAdaptor wrapper which abstracts out
    the gradient type specific functionlity.

(WebCore::CSSLinearGradientValue::createGradient):
(WebCore::CSSRadialGradientValue::createGradient):
(WebCore::CSSConicGradientValue::createGradient):

    Update to call computeStops and use new Gradient create function.

* css/CSSGradientValue.h:

    Update for new signature for computeStops.

* html/canvas/CanvasGradient.cpp:
(WebCore::CanvasGradient::CanvasGradient):

    Update to use new Gradient create function.

* inspector/InspectorCanvas.cpp:
(WebCore::InspectorCanvas::buildArrayForCanvasGradient):

    Update to get gradient point / radii information from the data accessor.

* platform/graphics/Gradient.cpp:
(WebCore::Gradient::Gradient):

    Update constructors to the new data structs.

(WebCore::Gradient::type const):

    Add helper to get the type of the varient, need for inspector code.

(WebCore::Gradient::adjustParametersForTiledDrawing):
(WebCore::Gradient::isZeroSize const):
(WebCore::Gradient::hash const):

    Update to switch on the underlying variant to get data values.

(WebCore::Gradient::addColorStop):

    Simplify by having one addColorStop call the other.

(WebCore::Gradient::setSortedColorStops):

    Added. Replaces setStopsSorted. Used now that CSSGradientValue computes and sorts
    its color stops before creating the gradient.

* platform/graphics/Gradient.h:
(WebCore::Gradient::create):

    Replace create functions with ones that take data structs.

(WebCore::Gradient::data const):

    Add accessor for the underlying variant.

(WebCore::Gradient::isRadial const): Deleted.

    Replaced by type accessor.

(WebCore::Gradient::p0 const): Deleted.
(WebCore::Gradient::p1 const): Deleted.
(WebCore::Gradient::setP0): Deleted.
(WebCore::Gradient::setP1): Deleted.
(WebCore::Gradient::startRadius const): Deleted.
(WebCore::Gradient::endRadius const): Deleted.
(WebCore::Gradient::setStartRadius): Deleted.
(WebCore::Gradient::setEndRadius): Deleted.

    Point and radii are now immutable.

(WebCore::Gradient::setStopsSorted): Deleted.

    Replaced by setSortedColorStops function.

* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::fillRect):

    Pass the GraphicsContext by reference.

* platform/graphics/cairo/GradientCairo.cpp:
(WebCore::Gradient::createPlatformGradient):

    Update to switch on the underlying variant to get data values.

(WebCore::Gradient::fill):

    Pass the GraphicsContext by reference.

* platform/graphics/cg/GradientCG.cpp:
(WebCore::Gradient::platformDestroy):

    Use nullptr.

(WebCore::Gradient::fill):

    Pass the GraphicsContext by reference.

(WebCore::Gradient::paint):

    Update to switch on the underlying variant to get data values.

* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::strokeRect):

    Pass the GraphicsContext by reference.

* platform/graphics/win/GradientDirect2D.cpp:
(WebCore::Gradient::generateGradient):

    Update to switch on the underlying variant to get data values.

(WebCore::Gradient::fill):

    Pass the GraphicsContext by reference.

* rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::paintProgressBar):
* rendering/svg/RenderSVGResourceLinearGradient.cpp:
(WebCore::RenderSVGResourceLinearGradient::buildGradient const):
* rendering/svg/RenderSVGResourceRadialGradient.cpp:
(WebCore::RenderSVGResourceRadialGradient::buildGradient const):

    Update for new Gradient create function signature.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUse TypedArrayView's setRange() in FETurbulence
simon.fraser@apple.com [Sun, 19 Nov 2017 21:57:13 +0000 (21:57 +0000)]
Use TypedArrayView's setRange() in FETurbulence
https://bugs.webkit.org/show_bug.cgi?id=179878

Reviewed by Sam Weinig.

Writing the 4 component values at once makes the function about 10% faster.

* platform/graphics/filters/FETurbulence.cpp:
(WebCore::FETurbulence::fillRegion const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoFix potential thread safety issue in generateThreadSafeObjectIdentifier()
cdumez@apple.com [Sun, 19 Nov 2017 21:56:17 +0000 (21:56 +0000)]
Fix potential thread safety issue in generateThreadSafeObjectIdentifier()
https://bugs.webkit.org/show_bug.cgi?id=179877

Reviewed by Sam Weinig.

Fix potential thread safety issue in generateThreadSafeObjectIdentifier().
Protect std::atomic initialization with an std::call_once() given that we
build with --fno-threadsafe-statics.

* wtf/ObjectIdentifier.h:
(WTF::generateThreadSafeObjectIdentifier):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, rolling out r225016.
utatane.tea@gmail.com [Sun, 19 Nov 2017 08:19:42 +0000 (08:19 +0000)]
Unreviewed, rolling out r225016.

Break webkit-patch on Ubuntu and Debian Linux

Reverted changeset:

"webkitpy: Better name-version mapping (Part 1)"
https://bugs.webkit.org/show_bug.cgi?id=179621
https://trac.webkit.org/changeset/225016

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[WTF] Use system endianess information instead of relying CPU information
utatane.tea@gmail.com [Sun, 19 Nov 2017 08:07:04 +0000 (08:07 +0000)]
[WTF] Use system endianess information instead of relying CPU information
https://bugs.webkit.org/show_bug.cgi?id=179861

Reviewed by JF Bastien.

Currently, we use known CPU information to determine endianess of the current
architecture. But this means that unknown CPU does not work well in WebKit
withou modifying code. Instead, we use compiler or system's macro to determine
endianess. This paves the way to dropping many CPUs in Platform.h by replacing
them with CPU(UNKNOWN)[1].

[1]: https://bugs.webkit.org/show_bug.cgi?id=179243

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225032 268f45cc-cd09-0410-ab3c-d52691b4dbfc