WebKit-https.git
13 years ago Reviewed by Geoff.
andersca [Fri, 23 Feb 2007 03:38:00 +0000 (03:38 +0000)]
    Reviewed by Geoff.

        <rdar://problem/4998203>
        REGRESSION: Back-forward list gets messed up when navigating to error pages with back-forward cache turned off

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::load):
        Remove call to setPolicyDocumentLoader(), the policy document loader is set immediately after, and setting it before
        calling shouldReloadToHandleUnreachableURL causes us to get the wrong URL.

        (WebCore::FrameLoader::shouldReloadToHandleUnreachableURL):
        Check if the unreachable URL is equal to the document loader's request.

        (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
        Check the provisional document loader's unreachable URL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoVersioning.
bdash [Fri, 23 Feb 2007 01:13:19 +0000 (01:13 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by John.
adele [Fri, 23 Feb 2007 00:03:23 +0000 (00:03 +0000)]
    Reviewed by John.

        Updating this image to match the one in WebCore.

        * WebKit.vcproj/textAreaResizeCorner.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
justing [Thu, 22 Feb 2007 23:51:47 +0000 (23:51 +0000)]
LayoutTests:

        Reviewed by darin

        <rdar://problem/5007143>
        REGRESSION: WebKit doesn't remember horizontal position of caret when moving forward by line

        Added, tests the removal of the use of the
        recalc bool from xPosForVerticalArrowNavigation(...):
        * editing/selection/5007143-2-expected.checksum: Added.
        * editing/selection/5007143-2-expected.png: Added.
        * editing/selection/5007143-2-expected.txt: Added.
        * editing/selection/5007143-2.html: Added.
        Added, demonstrate the changes to modify:
        * editing/selection/5007143-expected.checksum: Added.
        * editing/selection/5007143-expected.png: Added.
        * editing/selection/5007143-expected.txt: Added.
        * editing/selection/5007143.html: Added.
        Demonstrates a bug (filed 5017312):
        * editing/style/block-style-004-expected.txt:
        * editing/style/block-style-005-expected.txt:
        * editing/style/block-style-006-expected.txt:
        Fixed:
        * editing/selection/3690703-2-expected.checksum:
        * editing/selection/3690703-2-expected.png:
        * editing/selection/3690703-2-expected.txt:
        * editing/style/create-block-for-style-009-expected.checksum:
        * editing/style/create-block-for-style-009-expected.png:
        * editing/style/create-block-for-style-009-expected.txt:
        * editing/style/create-block-for-style-011-expected.checksum:
        * editing/style/create-block-for-style-011-expected.png:
        * editing/style/create-block-for-style-011-expected.txt:

WebCore:

        Reviewed by darin

        <rdar://problem/5007143>
        REGRESSION: WebKit doesn't remember horizontal position of caret when moving forward by line

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::SelectionController): Initialize
        m_xPosForVerticalArrowNavigation.
        (WebCore::SelectionController::setSelection): Call the new setter.
        (WebCore::SelectionController::modifyMovingRightForward): For line
        and paragraph granularities, use the saved xPosForVerticalArrowNavigation
        even if the old selection was a range. Use the x position of the
        *start*, not the end of the selection if there is no saved
        xPosForVerticalArrowNavigation.  This matches TextEdit's behavior.
        (WebCore::SelectionController::modifyMovingLeftBackward): For line
        and paragraph granularities, use the saved xPosForVerticalArrowNavigation
        even if the old selection was a range.
        (WebCore::SelectionController::modify): Preserve the xPosForVerticalArrowNavigation
        for line and paragraph granularities.
        (WebCore::SelectionController::xPosForVerticalArrowNavigation): Removed
        the recalc bool because it is now always false.
        (WebCore::SelectionController::setXPosForVerticalArrowNavigation): Added.
        * editing/SelectionController.h: Moved m_xPosForVerticalArrowNavigation
        from Frame.
        * page/Frame.cpp: Moved m_xPosForVerticalArrowNavigation to SelectionController.
        * page/Frame.h: Ditto.
        * page/FramePrivate.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
bdakin [Thu, 22 Feb 2007 23:49:13 +0000 (23:49 +0000)]
WebCore:
        Reviewed by Adam. Manual test added.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=12399 REGRESSION:
        Unable to prevent default context menu from appearing. <rdar://
        problem/5017416>

        This problem appeared because of two facets of the current context
        menu design. First, all context menu events are now considered to
        be "swallowed" since we take care of building up the regular
        context menu through the defaultEventHandler(). Second, the context
        menu controller holds onto it's context menu until a new one is
        created. There would be logistical problems changing this since
        AppKit relies on the menu being around for as long as it is
        visible on the screen and we don't get any notification once the
        menu is popped-down.

        This patch fixes the problem by giving WebKit a way to clear the
        controller's context menu. WebKit now clears the menu before it
        propagates a new context menu event through the DOM.

        * WebCore.exp:
        * manual-tests/DOMContextMenuEvent.html: Added.
        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::clearContextMenu):
        * page/ContextMenuController.h:

WebKit:
        Reviewed by Adam.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=12399 REGRESSION:
        Unable to prevent default context menu from appearing. <rdar://
        problem/5017416>

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView menuForEvent:]): Clear the controller's context menu
        before propagating a new context menu event through the DOM.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Kevin and Adele
sullivan [Thu, 22 Feb 2007 23:42:30 +0000 (23:42 +0000)]
    Reviewed by Kevin and Adele

        - fixed <rdar://problem/4129417> Need final art for textarea's resize corner

        This probably broke some layout pixel tests since the image changed. I'm going to
        track those down in a moment (non-trivial since there are a bunch failing for other
        reasons).

        * Resources/textAreaResizeCorner.tiff:
        new art

        * Resources/deleteButton.tiff:
        * Resources/deleteButtonPressed.tiff:
        these got smaller when I ran compress-tiffs on this directory

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-02-22 Oliver Hunt <oliver@apple.com>
oliver [Thu, 22 Feb 2007 23:40:30 +0000 (23:40 +0000)]
2007-02-22  Oliver Hunt  <oliver@apple.com>

        Reviewed by Ada, Lou and Steve.

        Moving basic components of ClipboardMac to Clipboard,
        last of the basic common code merge will come later (namely setting the
        drag element/image).

        Tidying up in DragController including a few bad PassRefPtr uses and
        removing unnecessary accessors.  Also initialise fields properly to
        fix <rdar:/problems/5014889>

        * dom/Clipboard.cpp:
        (WebCore::Clipboard::Clipboard):
          New constructor

        * dom/Clipboard.h:
        (WebCore::Clipboard::isForDragging):
        (WebCore::Clipboard::dragLocation):
        (WebCore::Clipboard::dragImage):
        (WebCore::Clipboard::dragImageElement):
          Exposing common data

        * page/DragController.cpp:
        (WebCore::DragController::DragController):
          Initialise m_isHandlingDrag (oops)
        (WebCore::documentFragmentFromDragData):
        (WebCore::DragController::tryDocumentDrag):
          Fixing PassRefPtr misuse
        (WebCore::DragController::canProcessDrag):
        (WebCore::DragController::startDrag):
        (WebCore::DragController::doSystemDrag):
          Make sure we're using the correct coordinate space

        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleDrag):
          Reset drag source correctly

        * platform/mac/ClipboardMac.h:
        * platform/mac/ClipboardMac.mm:
        (WebCore::ClipboardMac::ClipboardMac):
          update constructor to use new Clipboard constructor

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
adele [Thu, 22 Feb 2007 22:20:24 +0000 (22:20 +0000)]
LayoutTests:

        Reviewed by Darin.

        Test for <rdar://problem/5014970> 9A374: Tabs don't work in the message body

        * fast/events/keypress-insert-tab-expected.txt: Added.
        * fast/events/keypress-insert-tab.html: Added.

WebCore:

        Reviewed by Darin.

        Fix for <rdar://problem/5014970> 9A374: Tabs don't work in the message body

        Test: fast/events/keypress-insert-tab.html

        * page/EventHandler.cpp: (WebCore::EventHandler::defaultTextInputEventHandler):
          If the defaultTabEventHandler doesn't handle the event, then go on to the insertText case.

WebKitTools:

        Reviewed by Darin.

        Added option in layoutTestController to setTabKeyCyclesThroughElements, so we
        can test <rdar://problem/5014970> 9A374: Tabs don't work in the message body

        * DumpRenderTree/DumpRenderTree.m:
        (+[LayoutTestController isSelectorExcludedFromWebScript:]):
        (+[LayoutTestController webScriptNameForSelector:]):
        (-[LayoutTestController setTabKeyCyclesThroughElements:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin Adler.
ggaren [Thu, 22 Feb 2007 22:10:38 +0000 (22:10 +0000)]
    Reviewed by Darin Adler.

        Fixed <rdar://problem/4942528> Installer.app Stuck "Examining additional
        volumes..."

        The problem was that JavaScriptGlue held a JSObject in a static pointer
        without protecting it from garbage collection.

            sUserObjectPrototypeImp  = new UserObjectPrototypeImp();
            static ProtectedPtr<UserObjectPrototypeImp> protectPrototype; // valiant, brave, but useless

        Through an interesting comedy of errors, this object would be collected
        and then assigned as the prototype of another object allocated at the
        same address, thus becoming its own prototype. (See http://www.ziplo.com/grandpa.htm
        for further explanation of this phenomenon.) Hence the infinte loop in
        property lookup.

        The solution is equally humorous: all of this code was completely useless --
        it only served to create an empty object in the prototype chain -- so
        I just removed it.

        * UserObjectImp.cpp:
        (UserObjectImp::UserObjectImp):
        * UserObjectImp.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
thatcher [Thu, 22 Feb 2007 21:00:58 +0000 (21:00 +0000)]
    Reviewed by Darin.

        <rdar://problem/4948887> REGRESSION: Correct differences in public DOM API that inadvertently changed in Leopard

        * bindings/objc/PublicDOMInterfaces.h: Changes return types for two size properties, adds deprecated DOMEventTarget methods.
        * bindings/scripts/CodeGeneratorObjC.pm: Fixed public API checking for protocols, adds support for ConvertToString.
        * dom/EventTarget.idl: Marks addEventListener and removeEventListener with the OldStyleObjC attribute.
        * html/HTMLBaseFontElement.idl: Changes the size property to a DOMString for ObjC only.
        * html/HTMLInputElement.idl: Changes the size property to a DOMString for ObjC only.
        * html/HTMLOptionsCollection.idl: Changes the length property to be unsigned.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by John.
adele [Thu, 22 Feb 2007 20:50:13 +0000 (20:50 +0000)]
    Reviewed by John.

        Fix <rdar://problem/5016969> REGRESSION: "Check Spelling As You Type" context menu item is never checked

        * platform/ContextMenu.cpp: (WebCore::ContextMenu::checkOrEnableIfNeeded): Set shouldCheck for ContextMenuItemTagCheckSpellingWhileTyping.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
ggaren [Thu, 22 Feb 2007 20:19:26 +0000 (20:19 +0000)]
LayoutTests:

        Used svn merge -r19786:19785 to roll out previous SVG results produced by
        hack to work around SVG painting issue in DRT.

        The new work-around preserves the old SVG results -- both text and pixel.
        This should fix the ~400 new pixel failures introduced in r19786.

        * svg/W3C-SVG-1.1/animate-elem-02-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-04-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-15-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-16-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-17-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-19-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt:
        * svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
        * svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
        * svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt:
        * svg/W3C-SVG-1.1/interact-events-01-b-expected.txt:
        * svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt:
        * svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt:
        * svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
        * svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
        * svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
        * svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt:
        * svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
        * svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
        * svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
        * svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
        * svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
        * svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
        * svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
        * svg/W3C-SVG-1.1/script-handle-01-b-expected.txt:
        * svg/W3C-SVG-1.1/struct-frag-06-t-expected.txt:
        * svg/W3C-SVG-1.1/struct-use-01-t-expected.txt:
        * svg/W3C-SVG-1.1/text-align-01-b-expected.txt:
        * svg/W3C-SVG-1.1/text-align-02-b-expected.txt:
        * svg/W3C-SVG-1.1/text-align-03-b-expected.txt:
        * svg/W3C-SVG-1.1/text-align-04-b-expected.txt:
        * svg/W3C-SVG-1.1/text-align-05-b-expected.txt:
        * svg/W3C-SVG-1.1/text-align-06-b-expected.txt:
        * svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
        * svg/W3C-SVG-1.1/text-deco-01-b-expected.txt:
        * svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt:
        * svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt:
        * svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
        * svg/W3C-SVG-1.1/text-text-03-b-expected.txt:
        * svg/W3C-SVG-1.1/text-text-08-b-expected.txt:
        * svg/W3C-SVG-1.1/text-tref-01-b-expected.txt:
        * svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt:
        * svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt:
        * svg/W3C-SVG-1.1/text-ws-01-t-expected.txt:
        * svg/W3C-SVG-1.1/text-ws-02-t-expected.txt:
        * svg/carto.net/button-expected.txt:
        * svg/carto.net/colourpicker-expected.txt:
        * svg/carto.net/combobox-expected.txt:
        * svg/carto.net/scrollbar-expected.txt:
        * svg/carto.net/selectionlist-expected.txt:
        * svg/carto.net/slider-expected.txt:
        * svg/carto.net/tabgroup-expected.txt:
        * svg/carto.net/textbox-expected.txt:
        * svg/carto.net/window-expected.txt:
        * svg/custom/gradient-stop-style-change-expected.txt:
        * svg/custom/js-late-clipPath-and-object-creation-expected.txt:
        * svg/custom/js-late-clipPath-creation-expected.txt:
        * svg/custom/js-late-gradient-and-object-creation-expected.txt:
        * svg/custom/non-opaque-filters-expected.txt:
        * svg/custom/pointer-events-text-expected.txt:
        * svg/custom/text-clip-expected.txt:
        * svg/custom/text-filter-expected.txt:
        * svg/custom/text-image-opacity-expected.txt:
        * svg/custom/text-repaint-including-stroke-expected.txt:
        * svg/custom/use-elementInstance-event-target-expected.txt:
        * svg/custom/use-on-text-expected.txt:

WebKitTools:

        Used svn merge -r19786:19785 to roll out previous hack to work around
        SVG painting issue in DRT.

        Implemented new work-around, which makes --paint paint *after* dumping
        the render tree instead of before, so that painting doesn't influence
        the SVG render tree.

        This should fix the ~400 new pixel failures introduced in r19786.

        * DumpRenderTree/DumpRenderTree.m:
        (dump):
        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
antti [Thu, 22 Feb 2007 19:57:49 +0000 (19:57 +0000)]
LayoutTests:

        Reviewed by Darin.

        - tests for http://bugs.webkit.org/show_bug.cgi?id=11447
        REGRESSION(NativeListBox): List not scrolled to preselected option
        <rdar://problem/4957463>

        * fast/forms/select-initial-position-expected.checksum: Added.
        * fast/forms/select-initial-position-expected.png: Added.
        * fast/forms/select-initial-position-expected.txt: Added.
        * fast/forms/select-initial-position.html: Added.

WebCore:

        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=11447
        REGRESSION(NativeListBox): List not scrolled to preselected option
        <rdar://problem/4957463>

        Initiate scroll when selected <option> is added to <select>.

        * html/HTMLOptionElement.cpp:
        (WebCore::HTMLOptionElement::insertedIntoDocument):
        * html/HTMLOptionElement.h:
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::notifyOptionSelected):
        (WebCore::HTMLSelectElement::updateListBoxSelection):
        (WebCore::HTMLSelectElement::scrollToSelection):
        * html/HTMLSelectElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix sites with fixed positioned backgrounds. (my blog =) )
zack [Thu, 22 Feb 2007 19:32:33 +0000 (19:32 +0000)]
Fix sites with fixed positioned backgrounds. (my blog =) )
r=Lars,George

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Resetting --leaks mode default to run 1000 tests at a time because setting it
ggaren [Thu, 22 Feb 2007 19:18:46 +0000 (19:18 +0000)]
    Resetting --leaks mode default to run 1000 tests at a time because setting it
        to 750 didn't stop the stack logging related crashes, and running more tests
        at a time is faster. The crashes seem to be a real bug in stack logging,
        not an out of memory condition.

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin
sullivan [Thu, 22 Feb 2007 17:38:57 +0000 (17:38 +0000)]
    Reviewed by Darin

        Removed some unused keyView-related code that I happened to run across.
        Replacement code is now in WebChromeClient.

        * WebCoreSupport/WebFrameBridge.h:
        * WebCoreSupport/WebFrameBridge.mm:
        removed unused stuff

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFixing the default scroll offset, cleaning
zack [Thu, 22 Feb 2007 16:52:15 +0000 (16:52 +0000)]
Fixing the default scroll offset, cleaning
up private methods and making the default
look not use any frames.
r=Lars

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoProperly implement canvas/scrollview's. Get
zack [Thu, 22 Feb 2007 16:17:41 +0000 (16:17 +0000)]
Properly implement canvas/scrollview's. Get
rid of ScrollViewCanvasQt and replace it with
a tailor abstractscrollview (now in qwebframe).
Scrolling of pages is finally completely smooth :)
r=Lars

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej.
weinig [Thu, 22 Feb 2007 15:59:10 +0000 (15:59 +0000)]
    Reviewed by Maciej.

        Fix ARM-specific alignment problem in FastMalloc
        http://bugs.webkit.org/show_bug.cgi?id=12841

        * wtf/FastMalloc.cpp:
        Modify how pageheap_memory is declared to ensure proper alignment
        on architectures such as ARM

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej.
weinig [Thu, 22 Feb 2007 15:45:40 +0000 (15:45 +0000)]
    Reviewed by Maciej.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12804
          REGRESSION (r19043-r19063): suggestion popup doesn't work after pressing Option+Esc

        This patch also fixes a bug where using the arrow keys while
        the suggestion popup is open moves the caret instead of changing the
        selection in the popup (for up/down) or accepting the selection and
        closing the popup (for left/right).

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView keyDown:]): Changed to close the popup only if it was open
        before the current event, so that the Option-Esc that opens the popup will
        not close it immediately.
        (-[WebHTMLView _interceptEditingKeyEvent:]): Give the completion popup a
        chance to intercept keydown events.
        (-[WebTextCompleteController popupWindowIsOpen]): Added. Returns whether the
        suggestion popup is open.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Mark (age 21).
weinig [Thu, 22 Feb 2007 15:34:00 +0000 (15:34 +0000)]
    Reviewed by Mark (age 21).

        - fix http://bugs.webkit.org/show_bug.cgi?id=12805
          REGRESSION: suggestion popup has a disabled scroll bar

        * WebView/WebHTMLView.mm:
        (-[WebTextCompleteController _buildUI]): Uncommented the call to the NSWindow
        SPI that forces the scroll bar to look active. Also replaced a call to
        the deprecated NSTableView method setAutoresizesAllColumnsToFit: with
        the new method setColumnAutoresizingStyle: to eliminate console spew.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam Roben.
kjk [Thu, 22 Feb 2007 07:20:31 +0000 (07:20 +0000)]
    Reviewed by Adam Roben.

        Improve notImplemented() macro for gdk. Rename to notImplementedGdk() to
        give it a unique name (so that it doesn't clash with notImplemented()
        for other platforms).
        Make it print a given warning only once, so that frequently called
        functions don't clutter the output.
        Don't print the warning if DISABLE_NI_WARNING env variable is set.

        * loader/gdk/FrameLoaderClientGdk.cpp:
        (WebCore::FrameLoaderClientGdk::dispatchDidReceiveAuthenticationChallenge):
        (WebCore::FrameLoaderClientGdk::dispatchDidCancelAuthenticationChallenge):
        (WebCore::FrameLoaderClientGdk::dispatchWillSendRequest):
        (WebCore::FrameLoaderClientGdk::assignIdentifierToInitialRequest):
        (WebCore::FrameLoaderClientGdk::createPlugin):
        (WebCore::FrameLoaderClientGdk::createFrame):
        (WebCore::FrameLoaderClientGdk::redirectDataToPlugin):
        (WebCore::FrameLoaderClientGdk::createJavaAppletWidget):
        (WebCore::FrameLoaderClientGdk::objectContentType):
        (WebCore::FrameLoaderClientGdk::overrideMediaType):
        (WebCore::FrameLoaderClientGdk::windowObjectCleared):
        (WebCore::FrameLoaderClientGdk::hasWebView):
        (WebCore::FrameLoaderClientGdk::hasFrameView):
        (WebCore::FrameLoaderClientGdk::frameLoadCompleted):
        (WebCore::FrameLoaderClientGdk::saveViewStateToItem):
        (WebCore::FrameLoaderClientGdk::restoreViewState):
        (WebCore::FrameLoaderClientGdk::privateBrowsingEnabled):
        (WebCore::FrameLoaderClientGdk::makeDocumentView):
        (WebCore::FrameLoaderClientGdk::makeRepresentation):
        (WebCore::FrameLoaderClientGdk::forceLayout):
        (WebCore::FrameLoaderClientGdk::forceLayoutForNonHTML):
        (WebCore::FrameLoaderClientGdk::setCopiesOnScroll):
        (WebCore::FrameLoaderClientGdk::detachedFromParent1):
        (WebCore::FrameLoaderClientGdk::detachedFromParent2):
        (WebCore::FrameLoaderClientGdk::detachedFromParent3):
        (WebCore::FrameLoaderClientGdk::detachedFromParent4):
        (WebCore::FrameLoaderClientGdk::loadedFromPageCache):
        (WebCore::FrameLoaderClientGdk::dispatchDidHandleOnloadEvents):
        (WebCore::FrameLoaderClientGdk::dispatchDidReceiveServerRedirectForProvisionalLoad):
        (WebCore::FrameLoaderClientGdk::dispatchDidCancelClientRedirect):
        (WebCore::FrameLoaderClientGdk::dispatchWillPerformClientRedirect):
        (WebCore::FrameLoaderClientGdk::dispatchDidChangeLocationWithinPage):
        (WebCore::FrameLoaderClientGdk::dispatchWillClose):
        (WebCore::FrameLoaderClientGdk::dispatchDidReceiveIcon):
        (WebCore::FrameLoaderClientGdk::dispatchDidStartProvisionalLoad):
        (WebCore::FrameLoaderClientGdk::dispatchDidReceiveTitle):
        (WebCore::FrameLoaderClientGdk::dispatchDidCommitLoad):
        (WebCore::FrameLoaderClientGdk::dispatchDidFinishDocumentLoad):
        (WebCore::FrameLoaderClientGdk::dispatchDidFirstLayout):
        (WebCore::FrameLoaderClientGdk::dispatchShow):
        (WebCore::FrameLoaderClientGdk::cancelPolicyCheck):
        (WebCore::FrameLoaderClientGdk::dispatchDidLoadMainResource):
        (WebCore::FrameLoaderClientGdk::revertToProvisionalState):
        (WebCore::FrameLoaderClientGdk::clearUnarchivingState):
        (WebCore::FrameLoaderClientGdk::willChangeTitle):
        (WebCore::FrameLoaderClientGdk::finishedLoading):
        (WebCore::FrameLoaderClientGdk::finalSetupForReplace):
        (WebCore::FrameLoaderClientGdk::setDefersLoading):
        (WebCore::FrameLoaderClientGdk::isArchiveLoadPending):
        (WebCore::FrameLoaderClientGdk::cancelPendingArchiveLoad):
        (WebCore::FrameLoaderClientGdk::clearArchivedResources):
        (WebCore::FrameLoaderClientGdk::canHandleRequest):
        (WebCore::FrameLoaderClientGdk::canShowMIMEType):
        (WebCore::FrameLoaderClientGdk::representationExistsForURLScheme):
        (WebCore::FrameLoaderClientGdk::generatedMIMETypeForURLScheme):
        (WebCore::FrameLoaderClientGdk::provisionalLoadStarted):
        (WebCore::FrameLoaderClientGdk::didFinishLoad):
        (WebCore::FrameLoaderClientGdk::prepareForDataSourceReplacement):
        (WebCore::FrameLoaderClientGdk::setTitle):
        (WebCore::FrameLoaderClientGdk::setDocumentViewFromPageCache):
        (WebCore::FrameLoaderClientGdk::dispatchDidReceiveContentLength):
        (WebCore::FrameLoaderClientGdk::dispatchDidFinishLoading):
        (WebCore::FrameLoaderClientGdk::dispatchDidFailLoading):
        (WebCore::FrameLoaderClientGdk::dispatchDidLoadResourceFromMemoryCache):
        (WebCore::FrameLoaderClientGdk::dispatchDidFailProvisionalLoad):
        (WebCore::FrameLoaderClientGdk::dispatchDidFailLoad):
        (WebCore::FrameLoaderClientGdk::download):
        (WebCore::FrameLoaderClientGdk::cancelledError):
        (WebCore::FrameLoaderClientGdk::cannotShowURLError):
        (WebCore::FrameLoaderClientGdk::interruptForPolicyChangeError):
        (WebCore::FrameLoaderClientGdk::cannotShowMIMETypeError):
        (WebCore::FrameLoaderClientGdk::fileDoesNotExistError):
        (WebCore::FrameLoaderClientGdk::shouldFallBack):
        (WebCore::FrameLoaderClientGdk::willUseArchive):
        (WebCore::FrameLoaderClientGdk::saveDocumentViewToPageCache):
        (WebCore::FrameLoaderClientGdk::canCachePage):
        (WebCore::FrameLoaderClientGdk::dispatchCreatePage):
        (WebCore::FrameLoaderClientGdk::dispatchUnableToImplementPolicy):
        (WebCore::FrameLoaderClientGdk::setMainDocumentError):
        (WebCore::FrameLoaderClientGdk::startDownload):
        (WebCore::FrameLoaderClientGdk::updateGlobalHistoryForStandardLoad):
        (WebCore::FrameLoaderClientGdk::updateGlobalHistoryForReload):
        (WebCore::FrameLoaderClientGdk::shouldGoToHistoryItem):
        * page/gdk/EventHandlerGdk.cpp:
        (WebCore::EventHandler::passMouseDownEventToWidget):
        (WebCore::EventHandler::eventActivatedView):
        (WebCore::EventHandler::passSubframeEventToSubframe):
        (WebCore::EventHandler::passWheelEventToWidget):
        (WebCore::EventHandler::createDraggingClipboard):
        * platform/gdk/EditorClientGdk.cpp:
        (WebCore::EditorClientGdk::shouldDeleteRange):
        (WebCore::EditorClientGdk::isContinuousSpellCheckingEnabled):
        (WebCore::EditorClientGdk::isGrammarCheckingEnabled):
        (WebCore::EditorClientGdk::spellCheckerDocumentTag):
        (WebCore::EditorClientGdk::shouldBeginEditing):
        (WebCore::EditorClientGdk::shouldEndEditing):
        (WebCore::EditorClientGdk::shouldInsertText):
        (WebCore::EditorClientGdk::shouldChangeSelectedRange):
        (WebCore::EditorClientGdk::shouldApplyStyle):
        (WebCore::EditorClientGdk::didBeginEditing):
        (WebCore::EditorClientGdk::respondToChangedContents):
        (WebCore::EditorClientGdk::didEndEditing):
        (WebCore::EditorClientGdk::didWriteSelectionToPasteboard):
        (WebCore::EditorClientGdk::didSetSelectionTypesForPasteboard):
        (WebCore::EditorClientGdk::selectWordBeforeMenuEvent):
        (WebCore::EditorClientGdk::isEditable):
        (WebCore::EditorClientGdk::registerCommandForUndo):
        (WebCore::EditorClientGdk::registerCommandForRedo):
        (WebCore::EditorClientGdk::clearUndoRedoOperations):
        (WebCore::EditorClientGdk::canUndo):
        (WebCore::EditorClientGdk::canRedo):
        (WebCore::EditorClientGdk::undo):
        (WebCore::EditorClientGdk::redo):
        (WebCore::EditorClientGdk::shouldInsertNode):
        (WebCore::EditorClientGdk::pageDestroyed):
        (WebCore::EditorClientGdk::smartInsertDeleteEnabled):
        (WebCore::EditorClientGdk::toggleContinuousSpellChecking):
        (WebCore::EditorClientGdk::textFieldDidBeginEditing):
        (WebCore::EditorClientGdk::textFieldDidEndEditing):
        (WebCore::EditorClientGdk::textDidChangeInTextField):
        (WebCore::EditorClientGdk::doTextFieldCommandFromEvent):
        (WebCore::EditorClientGdk::textWillBeDeletedInTextField):
        (WebCore::EditorClientGdk::textDidChangeInTextArea):
        * platform/gdk/RenderThemeGdk.cpp:
        (WebCore::RenderThemeGdk::setCheckboxSize):
        (WebCore::RenderThemeGdk::setRadioSize):
        (WebCore::RenderThemeGdk::adjustTextFieldStyle):
        * platform/gdk/TemporaryLinkStubs.cpp:
        (FrameView::updateBorder):
        (Widget::setEnabled):
        (Widget::isEnabled):
        (Widget::focusPolicy):
        (Widget::enableFlushDrawing):
        (Widget::disableFlushDrawing):
        (Widget::lockDrawingFocus):
        (Widget::unlockDrawingFocus):
        (Widget::removeFromParent):
        (Widget::paint):
        (Widget::setIsSelected):
        (Widget::invalidate):
        (Widget::invalidateRect):
        (PlatformMouseEvent::PlatformMouseEvent):
        (WebCore::findNextSentenceFromIndex):
        (WebCore::findSentenceBoundary):
        (WebCore::findNextWordFromIndex):
        (ChromeClientGdk::chromeDestroyed):
        (ChromeClientGdk::windowRect):
        (ChromeClientGdk::setWindowRect):
        (ChromeClientGdk::pageRect):
        (ChromeClientGdk::scaleFactor):
        (ChromeClientGdk::focus):
        (ChromeClientGdk::unfocus):
        (ChromeClientGdk::createWindow):
        (ChromeClientGdk::createModalDialog):
        (ChromeClientGdk::show):
        (ChromeClientGdk::canRunModal):
        (ChromeClientGdk::runModal):
        (ChromeClientGdk::setToolbarsVisible):
        (ChromeClientGdk::toolbarsVisible):
        (ChromeClientGdk::setStatusbarVisible):
        (ChromeClientGdk::statusbarVisible):
        (ChromeClientGdk::setScrollbarsVisible):
        (ChromeClientGdk::scrollbarsVisible):
        (ChromeClientGdk::setMenubarVisible):
        (ChromeClientGdk::menubarVisible):
        (ChromeClientGdk::setResizable):
        (ChromeClientGdk::closeWindowSoon):
        (ChromeClientGdk::canTakeFocus):
        (ChromeClientGdk::takeFocus):
        (ChromeClientGdk::canRunBeforeUnloadConfirmPanel):
        (ChromeClientGdk::addMessageToConsole):
        (ChromeClientGdk::runBeforeUnloadConfirmPanel):
        (ChromeClientGdk::runJavaScriptAlert):
        (ChromeClientGdk::runJavaScriptConfirm):
        (ChromeClientGdk::runJavaScriptPrompt):
        (ChromeClientGdk::setStatusbarText):
        (ChromeClientGdk::shouldInterruptJavaScript):
        (ChromeClientGdk::tabsToLinks):
        (ChromeClientGdk::windowResizerRect):
        (ChromeClientGdk::addToDirtyRegion):
        (ChromeClientGdk::scrollBackingStore):
        (ChromeClientGdk::updateBackingStore):
        (PlugInInfoStore::createPluginInfoForPluginAtIndex):
        (PlugInInfoStore::pluginCount):
        (WebCore::PlugInInfoStore::supportsMIMEType):
        (WebCore::refreshPlugins):
        (SearchPopupMenu::saveRecentSearches):
        (SearchPopupMenu::loadRecentSearches):
        (SearchPopupMenu::SearchPopupMenu):
        (PlatformScrollbar::PlatformScrollbar):
        (PlatformScrollbar::~PlatformScrollbar):
        (PlatformScrollbar::setEnabled):
        (PlatformScrollbar::paint):
        (PlatformScrollbar::updateThumbPosition):
        (PlatformScrollbar::updateThumbProportion):
        (PlatformScrollbar::setRect):
        (FileChooser::FileChooser):
        (FileChooser::~FileChooser):
        (FileChooser::openFileChooser):
        (FileChooser::basenameForWidth):
        (ResourceHandle::willLoadFromCache):
        (ResourceHandle::loadsBlocked):
        (ResourceHandle::loadResourceSynchronously):
        (Icon::Icon):
        (Icon::~Icon):
        (Icon::newIconForFile):
        (Icon::paint):
        (Font::drawComplexText):
        (Font::floatWidthForComplexText):
        (Font::offsetForPositionForComplexText):
        (PageCache::close):
        (Editor::ignoreSpelling):
        (Editor::learnSpelling):
        (Editor::isSelectionUngrammatical):
        (Editor::isSelectionMisspelled):
        (Editor::guessesForMisspelledSelection):
        (Editor::guessesForUngrammaticalSelection):
        (Editor::markMisspellingsAfterTypingToPosition):
        (Editor::newGeneralClipboard):
        (Pasteboard::generalPasteboard):
        (Pasteboard::writeSelection):
        (Pasteboard::writeURL):
        (Pasteboard::writeImage):
        (Pasteboard::clear):
        (Pasteboard::canSmartReplace):
        (Pasteboard::documentFragment):
        (Pasteboard::plainText):
        (Pasteboard::Pasteboard):
        (Pasteboard::~Pasteboard):
        (ContextMenu::ContextMenu):
        (ContextMenu::~ContextMenu):
        (ContextMenu::appendItem):
        (ContextMenuItem::ContextMenuItem):
        (ContextMenuItem::~ContextMenuItem):
        (ContextMenuItem::releasePlatformDescription):
        (ContextMenuItem::type):
        (ContextMenuItem::setType):
        (ContextMenuItem::action):
        (ContextMenuItem::setAction):
        (ContextMenuItem::title):
        (ContextMenuItem::setTitle):
        (ContextMenuItem::platformSubMenu):
        (ContextMenuItem::setSubMenu):
        (ContextMenuItem::setChecked):
        (ContextMenuItem::setEnabled):
        (WebCore::supportedKeySizes):
        (WebCore::systemBeep):
        (WebCore::userIdleTime):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd missing files from last commit
staikos [Thu, 22 Feb 2007 06:40:01 +0000 (06:40 +0000)]
Add missing files from last commit

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
ggaren [Thu, 22 Feb 2007 06:17:34 +0000 (06:17 +0000)]
LayoutTests:

        Reviewed by Adam Roben.

        Updated results to new, more correct values produced by painting SVGs
        before dumping their render trees.

        * svg/W3C-SVG-1.1/animate-elem-02-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-04-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-15-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-16-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-17-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-19-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt:
        * svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
        * svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
        * svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt:
        * svg/W3C-SVG-1.1/interact-events-01-b-expected.txt:
        * svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt:
        * svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt:
        * svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
        * svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
        * svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
        * svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt:
        * svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
        * svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
        * svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
        * svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
        * svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
        * svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
        * svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
        * svg/W3C-SVG-1.1/script-handle-01-b-expected.txt:
        * svg/W3C-SVG-1.1/struct-frag-06-t-expected.txt:
        * svg/W3C-SVG-1.1/struct-use-01-t-expected.txt:
        * svg/W3C-SVG-1.1/text-align-01-b-expected.txt:
        * svg/W3C-SVG-1.1/text-align-02-b-expected.txt:
        * svg/W3C-SVG-1.1/text-align-03-b-expected.txt:
        * svg/W3C-SVG-1.1/text-align-04-b-expected.txt:
        * svg/W3C-SVG-1.1/text-align-05-b-expected.txt:
        * svg/W3C-SVG-1.1/text-align-06-b-expected.txt:
        * svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
        * svg/W3C-SVG-1.1/text-deco-01-b-expected.txt:
        * svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt:
        * svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt:
        * svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
        * svg/W3C-SVG-1.1/text-text-03-b-expected.txt:
        * svg/W3C-SVG-1.1/text-text-08-b-expected.txt:
        * svg/W3C-SVG-1.1/text-tref-01-b-expected.txt:
        * svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt:
        * svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt:
        * svg/W3C-SVG-1.1/text-ws-01-t-expected.txt:
        * svg/W3C-SVG-1.1/text-ws-02-t-expected.txt:
        * svg/carto.net/button-expected.txt:
        * svg/carto.net/colourpicker-expected.txt:
        * svg/carto.net/combobox-expected.txt:
        * svg/carto.net/scrollbar-expected.txt:
        * svg/carto.net/selectionlist-expected.txt:
        * svg/carto.net/slider-expected.txt:
        * svg/carto.net/tabgroup-expected.txt:
        * svg/carto.net/textbox-expected.txt:
        * svg/carto.net/window-expected.txt:
        * svg/custom/gradient-stop-style-change-expected.txt:
        * svg/custom/js-late-clipPath-and-object-creation-expected.txt:
        * svg/custom/js-late-clipPath-creation-expected.txt:
        * svg/custom/js-late-gradient-and-object-creation-expected.txt:
        * svg/custom/non-opaque-filters-expected.txt:
        * svg/custom/pointer-events-text-expected.txt:
        * svg/custom/text-clip-expected.txt:
        * svg/custom/text-filter-expected.txt:
        * svg/custom/text-image-opacity-expected.txt:
        * svg/custom/text-repaint-including-stroke-expected.txt:
        * svg/custom/use-elementInstance-event-target-expected.txt:
        * svg/custom/use-on-text-expected.txt:

WebKitTools:

        Reviewed by Adam Roben.

        Added hack to force painting when running an SVG test. This is a work-around
        for http://bugs.webkit.org/show_bug.cgi?id=12849 SVG renderers update at
        paint time instead of style resolution time.

        We need this so that --leaks mode, which always paints, doesn't appear to
        fail SVG tests. We also need this if we ever want to test style application
        in SVG, since many SVGs don't apply style to their renderers until they paint.

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
weinig [Thu, 22 Feb 2007 03:12:51 +0000 (03:12 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        http://bugs.webkit.org/show_bug.cgi?id=12820
        REGRESSION (r19706): Caret not painted after popup, failing editing/pasteboard/4641033

        add test for caret before <select> case too

        * editing/selection/caret-before-select-expected.checksum: Added.
        * editing/selection/caret-before-select-expected.png: Added.
        * editing/selection/caret-before-select-expected.txt: Added.
        * editing/selection/caret-before-select.html: Added.

WebCore:

        Reviewed by Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12820
        REGRESSION (r19706): Caret not painted after popup, failing editing/pasteboard/4641033

        Yet another attempt to figure out exactly who should paint the caret.

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::isInsideNode):
        * editing/SelectionController.h:
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paintCaret):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
weinig [Thu, 22 Feb 2007 02:58:27 +0000 (02:58 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        - test for http://bugs.webkit.org/show_bug.cgi?id=12818
          REGRESSION (r19148): shacknews.com does not render completely

        * fast/dynamic/staticY-marking-parents-regression-expected.checksum: Added.
        * fast/dynamic/staticY-marking-parents-regression-expected.png: Added.
        * fast/dynamic/staticY-marking-parents-regression-expected.txt: Added.
        * fast/dynamic/staticY-marking-parents-regression.html: Added.

WebCore:

        Reviewed by Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12818
          REGRESSION (r19148): shacknews.com does not render completely

        Test: fast/dynamic/staticY-marking-parents-regression.html

        Changed calls to setChildNeedsLayout(true) during layout to
        setChildNeedsLayout(true, false). Prior to r19148, the default behavior
        of marking containers did not matter because the caller was the container
        and was already marked, but r19148 added marking of the parent of
        objects with static Y, which can be different from the caller and not
        necessarily marked already.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::collapseMargins):
        (WebCore::RenderBlock::clearFloatsIfNeeded):
        (WebCore::RenderBlock::layoutBlockChildren):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::setStaticY):
        * rendering/RenderFlexibleBox.cpp:
        (WebCore::RenderFlexibleBox::layoutVerticalBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Dave Harrison
beidson [Thu, 22 Feb 2007 02:54:49 +0000 (02:54 +0000)]
    Reviewed by Dave Harrison

        <rdar://problem/5014313> - Crash in FrameLoader::restoreScrollPositionAndViewState()
        after regaining network connection

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::restoreScrollPositionAndViewState):  Leave an assertion for debug
        build exploration, but gracefully handle the release build case

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Rubber-stamped by Darin.
thatcher [Thu, 22 Feb 2007 01:14:30 +0000 (01:14 +0000)]
    Rubber-stamped by Darin.

        * bindings/objc/PublicDOMInterfaces.h: Add missing classes that are really public.
        Also adds the deprecated selector for getComputedStyle: on DOMDocument.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Add new version with WKCGContextIsBitmapContext.
andersca [Thu, 22 Feb 2007 00:30:31 +0000 (00:30 +0000)]
    Add new version with WKCGContextIsBitmapContext.

        * WebKitSystemInterface.h:
        * libWebKitSystemInterface.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
justing [Thu, 22 Feb 2007 00:10:16 +0000 (00:10 +0000)]
LayoutTests:

        Reviewed by john

        <rdar://problem/5012665>
        Removing indent from list moves the caret to the line below

        No new layout tests needed because the new results
        for these tests and the removed FIXMEs cover the bug fix:
        * editing/execCommand/indent-list-item.html:
        * editing/execCommand/indent-list-item-expected.checksum:
        * editing/execCommand/indent-list-item-expected.png:
        * editing/execCommand/indent-list-item-expected.txt:
        * editing/execCommand/remove-list-1.html:
        * editing/execCommand/remove-list-1-expected.checksum:
        * editing/execCommand/remove-list-1-expected.png:
        * editing/execCommand/remove-list-1-expected.txt:

WebCore:

        Reviewed by john

        <rdar://problem/5012665>
        Removing indent from list moves the caret to the line below

        Selection preservation during indent, outdent and list
        operations uses rangeFromLocationAndLength.  Ranges returned
        by rangeFromLocationAndLength were incorrect for locations
        just before the line breaks that are emitted after blocks.
        This is because TextIterator emitted bad ranges for these line
        breaks (ranges that started and ended *after* the block).
        The fix corrects the start but not the end.  This is acceptible
        because there is code in rangeFromLocationAndLength that corrects
        the ends of runs using the start of the run and VisiblePosition
        creation.

        * editing/TextIterator.cpp:
        (WebCore::TextIterator::exitNode): Emit a position *inside*
        the block, after its contents.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reduced --leaks mode to running only 750 tests at a time, in the hopes
ggaren [Wed, 21 Feb 2007 22:56:33 +0000 (22:56 +0000)]
    Reduced --leaks mode to running only 750 tests at a time, in the hopes
        of fixing intermittent crasher that may be caused by out of memory
        conditions.

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin Adler.
ggaren [Wed, 21 Feb 2007 22:32:32 +0000 (22:32 +0000)]
    Reviewed by Darin Adler.

        Made DRT paint when running run-webkit-tests in --leaks mode, to check
        for painting leaks.

        * DumpRenderTree/DumpRenderTree.m: Removed some "NO" initializations, since
        that's the default for statics.
        (dumpRenderTree): Added --paint command line option, which specifies that
        DRT should paint at the end of every test.
        (displayWebView): New function, called by dump() and -[LayoutTestController display].
        * Scripts/run-webkit-tests: Use the --paint command line option when checking
        for leaks.

        * Scripts/run-webkit-tests: Added a new, painting leak to the ignore list.
        Removed stale comment about THRD leaks -- we now ignore them reliably.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
adele [Wed, 21 Feb 2007 21:49:56 +0000 (21:49 +0000)]
LayoutTests:

        Reviewed by Darin.

        Test for <rdar://problem/4999030> Indexing into select element to get to items in the options collection is broken

        * fast/forms/select-index-setter-expected.txt: Added.
        * fast/forms/select-index-setter.html: Added.

WebCore:

        Reviewed by Darin.

        Fix for <rdar://problem/4999030> Indexing into select element to get to items in the options collection is broken

        Test: fast/forms/select-index-setter.html

        Added indexSetter for HTMLSelectElement.

        * WebCore.xcodeproj/project.pbxproj: Added JSHTMLSelectElementCustom.h

        * bindings/js/JSHTMLOptionsCollectionCustom.cpp: (WebCore::JSHTMLOptionsCollection::indexSetter):
          Moved code to selectIndexSetter so it can be shared between these classes.
        * bindings/js/JSHTMLSelectElementCustom.cpp:
        (WebCore::selectIndexSetter): Added.  Moved from JSHTMLOptionsCollection::indexSetter.
        (WebCore::JSHTMLSelectElement::indexSetter): Calls selectIndexSetter.
        * bindings/js/JSHTMLSelectElementCustom.h: Added.
        * html/HTMLSelectElement.idl: Added HasCustomIndexSetter keyword.

        * bindings/scripts/CodeGeneratorJS.pm: When generating "put" methods, if the propertyName is a number, call the indexSetter first,
          and then call the version of lookupPut that will also try to use the parent's lookup table.  This matches the order of our
          old code, before we autogenerated the JSHTMLSelectElement class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Tools tweak. No review necessary.
ggaren [Wed, 21 Feb 2007 20:48:13 +0000 (20:48 +0000)]
    Tools tweak. No review necessary.

        * Scripts/parse-malloc-history: Enabled multiple merge-regexp command line
        arguments. Changed command line argument variables from special implicit
        no-op values to specific empty values that we test explicitly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim H.
thatcher [Wed, 21 Feb 2007 20:00:12 +0000 (20:00 +0000)]
    Reviewed by Tim H.

        Bug 12834: Drosera should remember scroll position of open files like Xcode
        http://bugs.webkit.org/show_bug.cgi?id=12834

        * Drosera/debugger.js: Implemented scrolling memory

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd undo/redo support and more editing commands.
staikos [Wed, 21 Feb 2007 16:55:34 +0000 (16:55 +0000)]
Add undo/redo support and more editing commands.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoImplementing popups for the Qt platform.
zack [Wed, 21 Feb 2007 13:59:55 +0000 (13:59 +0000)]
Implementing popups for the Qt platform.
r=Lars

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRemove unneeded hack
staikos [Wed, 21 Feb 2007 12:00:26 +0000 (12:00 +0000)]
Remove unneeded hack

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix rendering of lineedits and remove the spurious
zack [Wed, 21 Feb 2007 11:18:01 +0000 (11:18 +0000)]
Fix rendering of lineedits and remove the spurious
padding on push-buttons.
r=Lars

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agofixing compilation with Qt
zack [Wed, 21 Feb 2007 09:13:53 +0000 (09:13 +0000)]
fixing compilation with Qt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Preemptive build fix.
aroben [Wed, 21 Feb 2007 07:30:06 +0000 (07:30 +0000)]
    Preemptive build fix.

        * platform/mac/FontCacheMac.mm: Remove unused (and non-existent) header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix the build the right way.
aroben [Wed, 21 Feb 2007 06:02:49 +0000 (06:02 +0000)]
    Fix the build the right way.

        * platform/StringTruncator.cpp:
        (WebCore::truncateString): Keep all widths as floats.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
bdakin [Wed, 21 Feb 2007 06:00:26 +0000 (06:00 +0000)]
WebCore:
        Reviewed by Maciej.

        Implement writeImage() on Pasteboard so that the context menus can
        call into the editor for the "Copy image" command instead of
        calling across the clients.

        * WebCore.exp:
        * WebCore.xcodeproj/project.pbxproj:
        * editing/Editor.cpp:
        (WebCore::Editor::copyImage): Call into the Pasteboard.
        * editing/Editor.h:
        * loader/mac/LoaderNSURLExtras.h: A new NSURL extra needed inside
        WebCore.
        * loader/mac/LoaderNSURLExtras.m: Made this file Objective-C++
        (from Objective-C) since the call into the MIMETypeRegistry will
        return a Vector.
        (urlByRemovingComponent): Cast to build as Obj-C++
        (urlWithDataRelativeToURL): Same.
        (vectorContainsString): Helper.
        (suggestedFilenameWithMIMEType): New function.
        * page/ContextMenuClient.h: Remove copyImageToClipboard()
        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::contextMenuItemSelected): Call
        into the editor instead of the client.
        * page/mac/WebCoreViewFactory.h: New localized String.
        * platform/LocalizedStrings.h: Same.
        * platform/MimeTypeRegistry.h: Expose two additional functions for
        MIMEType information from WebCore System Interface.
        * platform/Pasteboard.h:
        * platform/SharedBuffer.h: Make platformData() and platformDataSize
        () public since they are needed to write the image to the
        pasteboard.
        * platform/mac/LocalizedStringsMac.mm: New localized string.
        (WebCore::copyImageUnknownFileLabel):
        * platform/mac/MimeTypeRegistryMac.mm:
        (WebCore::MimeTypeRegistry::getExtensionsForMIMEType):
        (WebCore::MimeTypeRegistry::getPreferredExtensionForMIMEType):
        * platform/mac/PasteboardMac.mm:
        (WebCore::writableTypesForImage):
        (WebCore::Pasteboard::writeURL): Write the correct types if the url
        is for an image.
        (WebCore::fileWrapperForImage):
        (WebCore::Pasteboard::writeFileWrapperAsRTFDAttachment):
        (WebCore::Pasteboard::writeImage):
        * platform/mac/WebCoreNSStringExtras.h: Added. Some the the
        NSStringExtras that were in WebKit are now needed by WebCore. To
        avoid having two copies of these functions, I just moved the
        implementations to WebCore. The WebKit functions just call into
        WebCore.
        * platform/mac/WebCoreNSStringExtras.mm: Added.
        (hasCaseInsensitiveSuffix):
        (hasCaseInsensitiveSubstring):
        (filenameByFixingIllegalCharacters):
        * platform/mac/WebCoreSystemInterface.h:
        wkGetPreferredExtensionForMIMEType and wkGetExtensionsForMIMEType
        are now needed in WebCore as well as WebKit.
        * platform/mac/WebCoreSystemInterface.mm:

WebKit:
        Reviewed by Maciej.

        WebKit changes needed to implement writeImage() in WebCore's
        Pasteboard class.

        * Misc/WebKitNSStringExtras.m: Call into WebCore for these
        implementations.
        (-[NSString _webkit_hasCaseInsensitiveSuffix:]):
        (-[NSString _webkit_hasCaseInsensitiveSubstring:]):
        (-[NSString _webkit_filenameByFixingIllegalCharacters]):
        * Misc/WebNSURLExtras.m: Same.
        (-[NSURL _webkit_suggestedFilenameWithMIMEType:]):
        * WebCoreSupport/WebContextMenuClient.h: Remove
        copyImageToClipboard()
        * WebCoreSupport/WebContextMenuClient.mm:
        * WebCoreSupport/WebSystemInterface.m: Expose
        GetExtensionsForMIMEType and GetPreferredExtensionForMIMEType to
        WebCore.
        (InitWebCoreSystemInterface):
        * WebCoreSupport/WebViewFactory.mm: New localized string for
        WebCore.
        (-[WebViewFactory copyImageUnknownFileLabel]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Build fix.
aroben [Wed, 21 Feb 2007 05:16:25 +0000 (05:16 +0000)]
    Build fix.

        * platform/StringTruncator.cpp:
        (WebCore::truncateString): Added explicit casts.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
aroben [Wed, 21 Feb 2007 05:03:02 +0000 (05:03 +0000)]
WebCore:

        Reviewed by Darin and Anders.

        Fix <rdar://problem/4736215> Make WebCoreStringTruncator use WebCore types

        * WebCore.exp: Updated symbols.
        * WebCore.xcodeproj/project.pbxproj: Updated file names.
        * bridge/mac/WebCoreStringTruncator.h: Removed.
        * bridge/mac/WebCoreStringTruncator.mm: Removed.
        * platform/StringTruncator.cpp: Added. Moved from bridge/mac/WebCoreStringTruncator.mm.
        (WebCore::textBreakAtOrPreceding): Added.
        (WebCore::boundedTextBreakFollowing): Added.
        (WebCore::centerTruncateToBuffer):
        (WebCore::rightTruncateToBuffer):
        (WebCore::stringWidth): Now takes a const Font& instead of a Font*.
        (WebCore::truncateString):
        (WebCore::StringTruncator::centerTruncate):
        (WebCore::StringTruncator::rightTruncate):
        (WebCore::StringTruncator::width):
        * platform/StringTruncator.h: Added.
        * platform/TextBreakIterator.h: Added isTextBreak declaration.
        * platform/TextBreakIteratorICU.cpp:
        (WebCore::isTextBreak): Implemented.
        * platform/mac/FileChooserMac.mm:
        (WebCore::FileChooser::basenameForWidth): Updated for changes to WebCoreStringTruncator.
        * platform/qt/TextBreakIteratorQt.cpp:
        (WebCore::isTextBreak): Stubbed out.

WebKit:

        Reviewed by Darin and Anders.

        Update WebKit for WebCore fix for <rdar://problem/4736215> Make
        WebCoreStringTruncator use WebCore types.

        * Misc/WebStringTruncator.m:
        (defaultMenuFont): Moved from WebCoreStringTruncator.mm.
        (core): Added.
        (+[WebStringTruncator centerTruncateString:toWidth:]):
        (+[WebStringTruncator centerTruncateString:toWidth:withFont:]):
        (+[WebStringTruncator rightTruncateString:toWidth:withFont:]):
        (+[WebStringTruncator widthOfString:font:]):
        * WebKit.xcodeproj/project.pbxproj: Changed WebStringTruncator to ObjC++.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
justing [Wed, 21 Feb 2007 03:58:51 +0000 (03:58 +0000)]
LayoutTests:

        Reviewed by harrison

        <rdar://problem/5006779>
        REGRESSION: Paste and Match Style of quoted text onto empty line yields quoted text

        * editing/pasteboard/5006779-expected.checksum: Added.
        * editing/pasteboard/5006779-expected.png: Added.
        * editing/pasteboard/5006779-expected.txt: Added.
        * editing/pasteboard/5006779.html: Added.

WebCore:

        Reviewed by harrison

        <rdar://problem/5006779>
        REGRESSION: Paste and Match Style of quoted text onto empty line yields quoted text

        We decided to change the copy/paste behavior in both
        the Paste and the Paste and Match Style cases.

        * editing/markup.cpp:
        (WebCore::createMarkup): Don't add mail blockquote wrappers
        unless the user selected one or more paragraphs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Mark Rowe.
thatcher [Wed, 21 Feb 2007 01:48:34 +0000 (01:48 +0000)]
    Reviewed by Mark Rowe.

        <rdar://problem/4912899> WebCore project ObjC @property cleanup

        * bindings/objc/DOMObject.h: Add the new style @property
        * bindings/objc/PublicDOMInterfaces.h: Update to the new style @property
        * bindings/scripts/CodeGeneratorObjC.pm: Export both new and old style @properties

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFixes the build!
thatcher [Wed, 21 Feb 2007 01:39:02 +0000 (01:39 +0000)]
Fixes the build!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBuild fix for the no-SVG build.
thatcher [Wed, 21 Feb 2007 00:54:00 +0000 (00:54 +0000)]
Build fix for the no-SVG build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBetter build fix, rolling out part of r19579.
thatcher [Wed, 21 Feb 2007 00:48:30 +0000 (00:48 +0000)]
Better build fix, rolling out part of r19579.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBuild fix.
thatcher [Wed, 21 Feb 2007 00:40:34 +0000 (00:40 +0000)]
Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Tools tweak. No review necessary.
ggaren [Wed, 21 Feb 2007 00:36:23 +0000 (00:36 +0000)]
    Tools tweak. No review necessary.

        Made parse-malloc-history executable. (Oops!)

        Made parse-malloc-history parse 'leaks' output in addition to 'malloc_history"
        output.

        Added the ability to merge callstacks by regexp, not just depth, so you
        can ask questions like, "How many of these allocations were due to that one
        call to ...?"

        * Scripts/parse-malloc-history:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix compile
staikos [Wed, 21 Feb 2007 00:12:37 +0000 (00:12 +0000)]
Fix compile

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sam Weinig.
thatcher [Wed, 21 Feb 2007 00:07:49 +0000 (00:07 +0000)]
    Reviewed by Sam Weinig.

        <rdar://problem/5007248> need to export symbols for DOM exception constants

        * WebCore.exp: Adds DOMEventException, DOMException, DOMRangeException, DOMXPathException

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by John.
thatcher [Tue, 20 Feb 2007 23:56:05 +0000 (23:56 +0000)]
    Reviewed by John.

        Fixes the version number returned when using a CFBundleVersion of "420+".

        * WebView/WebView.mm:
        (-[WebView _userVisibleBundleVersionFromFullVersion:]): Check the length up to the first
        non-decimal digit, so this works with versions that have "." and "+".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Kevin Decker
sullivan [Tue, 20 Feb 2007 23:38:41 +0000 (23:38 +0000)]
    Reviewed by Kevin Decker

        - fixed <rdar://problem/4989344> REGRESSION: After clicking on page, Find
        won't find anything if all hits are before the clicked point

        This was caused by a mismatch between WebCore's search code's notion of "selection" and
        WebView's search code's notion of "selection". WebCore's search code was starting
        just before or just after the "selection", which included collapsed, zero-length
        selections. WebKit's search code was only considering non-zero-length selections,
        and would not search all of the content when there was a zero-length selection.
        The fix was to make WebKit ignore the selection. This has a side effect of increasing
        the amount of redundantly-searched content in the case where no matches are found. To
        compensate for that, I special-cased the most common case of WebViews with a single frame,
        to avoid ever searching redundantly in those.

        * WebView/WebView.mm:
        (-[WebView searchFor:direction:caseSensitive:wrap:startInSelection:]):
        remove startHasSelection ivar; special-case WebViews with only one frame; clarify the
        code that leads to redundant searching with comments.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBuild fix.
thatcher [Tue, 20 Feb 2007 23:26:33 +0000 (23:26 +0000)]
Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago * Scripts/parse-malloc-history: Added copyright info.
ggaren [Tue, 20 Feb 2007 23:26:28 +0000 (23:26 +0000)]
    * Scripts/parse-malloc-history: Added copyright info.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
thatcher [Tue, 20 Feb 2007 22:53:51 +0000 (22:53 +0000)]
WebCore:

        Reviewed by Darin.

        <rdar://problem/4900579> WebKit -finalize methods are not thread-safe; design change needed

        Call WebCoreObjCFinalizeOnMainThread from the initialize method of all the classes
        that have a finalizer that needs called on the main thread.

        * WebCore.exp:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/objc/WebScriptObject.mm:
        (+[WebScriptObject initialize]):
        * bridge/mac/WebCoreScriptDebugger.mm:
        (+[WebCoreScriptDebugger initialize]):
        * platform/mac/SharedBufferMac.mm:
        (+[SharedBufferData initialize]):
        * platform/mac/WebCoreObjCExtras.c: Added.
        (WebCoreObjCFinalizeOnMainThread):
        * platform/mac/WebCoreObjCExtras.h: Added.

WebKit:

        Reviewed by Darin.

        <rdar://problem/4900579> WebKit -finalize methods are not thread-safe; design change needed

        Call WebCoreObjCFinalizeOnMainThread from the initialize method of all the classes
        that have a finalizer that needs called on the main thread. Assert in finalize that we
        are on the main thread.

        * Carbon/CarbonWindowAdapter.m:
        (+[CarbonWindowAdapter initialize]):
        (-[CarbonWindowAdapter finalize]):
        * History/WebBackForwardList.mm:
        (+[WebBackForwardList initialize]):
        (-[WebBackForwardList finalize]):
        * History/WebHistoryItem.mm:
        (+[WebHistoryItem initialize]):
        * Misc/WebElementDictionary.mm:
        (+[WebElementDictionary initialize]):
        (-[WebElementDictionary finalize]):
        * Plugins/WebBaseNetscapePluginStream.m:
        (+[WebBaseNetscapePluginStream initialize]):
        (-[WebBaseNetscapePluginStream finalize]):
        * Plugins/WebBaseNetscapePluginView.mm:
        (+[WebBaseNetscapePluginView initialize]):
        (-[WebBaseNetscapePluginView finalize]):
        * Plugins/WebBasePluginPackage.m:
        (+[WebBasePluginPackage initialize]):
        (-[WebBasePluginPackage finalize]):
        * Plugins/WebNetscapePluginStream.mm:
        (-[WebNetscapePluginStream finalize]):
        * WebCoreSupport/WebEditorClient.mm:
        (+[WebEditCommand initialize]):
        (-[WebEditCommand finalize]):
        * WebCoreSupport/WebFrameBridge.mm:
        (+[WebFrameBridge initialize]):
        (-[WebFrameBridge finalize]):
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (+[WebFramePolicyListener initialize]):
        (-[WebFramePolicyListener finalize]):
        * WebView/WebHTMLView.mm:
        (+[WebHTMLView initialize]):
        (-[WebHTMLView finalize]):
        * WebView/WebView.mm:
        (+[WebViewPrivate initialize]):
        (-[WebViewPrivate finalize]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by darin
justing [Tue, 20 Feb 2007 22:44:28 +0000 (22:44 +0000)]
    Reviewed by darin

        <rdar://problem/4838199>
        Integrate Mail and WebKit paste operations

        Mail overrides paste: because it has different
        preferred pasteboard types, but it should use our
        fragment creation code.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:chosePlainText:]):
        Moved fragment creation code into a new method.
        (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:]):
        Moved fragment creation code here.
        * WebView/WebHTMLViewPrivate.h: Exposed
        _documentFragmentFromPasteboard:forType:inContext: as SPI.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim Hatcher
sullivan [Tue, 20 Feb 2007 22:32:21 +0000 (22:32 +0000)]
    Reviewed by Tim Hatcher

        * Misc/WebKitNSStringExtras.h:
        * Misc/WebKitNSStringExtras.m:
        removed _webkit_userVisibleBundleVersionFromFullVersion; we decided to do this without
        adding SPI for it.

        * WebView/WebView.mm:
        (-[WebView _userVisibleBundleVersionFromFullVersion:]):
        new method, moved here from WebKitNSStringExtras, and is now a WebView method rather than
        an NSString method
        (-[WebView _computeUserAgent]):
        updated for method signature change

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin Adler.
ggaren [Tue, 20 Feb 2007 22:09:07 +0000 (22:09 +0000)]
    Reviewed by Darin Adler.

        New script to parse the output from malloc_history, so we can determine
        what's using memory in WebKit.

        * Scripts/parse-malloc-history: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Not not reviewed by Mitz Pettel.
ggaren [Tue, 20 Feb 2007 21:32:26 +0000 (21:32 +0000)]
    Not not reviewed by Mitz Pettel.

        Fixed http://bugs.webkit.org/show_bug.cgi?id=12827 | <rdar://problem/5006671>
        REGRESSION: -[DOMCSSStyleDeclaration setValue:forKey:] doesn't have an
        immediate effect

        Let's just pretend this never happened.

        I attempted a layout test but I couldn't get the old code to fail because
        there's no obvious way to isolate the ObjC bindings in a test that's
        controlled by JS.

        * bindings/objc/WebScriptObject.mm:
        (_didExecute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej S.
kjk [Tue, 20 Feb 2007 21:21:21 +0000 (21:21 +0000)]
    Reviewed by Maciej S.

        Gdk build fixes for recent refactorings.

        * Projects/gdk/webcore-gdk.bkl:
        * WebCoreSources.bkl:
        * page/gdk/DragControllerGdk.cpp:
        (WebCore::DragController::dragOperation):
        (WebCore::DragController::maxDragImageSize):
        * page/gdk/EventHandlerGdk.cpp:
        (WebCore::EventHandler::createDraggingClipboard):
        * platform/DragImage.h:
        * platform/gdk/ChromeClientGdk.h:
        * platform/gdk/CursorGdk.cpp:
        (WebCore::verticalTextCursor):
        (WebCore::cellCursor):
        (WebCore::contextMenuCursor):
        (WebCore::noDropCursor):
        (WebCore::copyCursor):
        (WebCore::progressCursor):
        (WebCore::aliasCursor):
        (WebCore::noneCursor):
        (WebCore::notAllowedCursor):
        * platform/gdk/EditorClientGdk.cpp:
        (WebCore::EditorClientGdk::shouldChangeSelectedRange):
        (WebCore::EditorClientGdk::isEditable):
        (WebCore::EditorClientGdk::textFieldDidBeginEditing):
        (WebCore::EditorClientGdk::textFieldDidEndEditing):
        (WebCore::EditorClientGdk::textDidChangeInTextField):
        (WebCore::EditorClientGdk::doTextFieldCommandFromEvent):
        (WebCore::EditorClientGdk::textWillBeDeletedInTextField):
        (WebCore::EditorClientGdk::textDidChangeInTextArea):
        * platform/gdk/EditorClientGdk.h:
        * platform/gdk/FrameGdk.cpp:
        (WebCore::Frame::print):
        (WebCore::Frame::issueTransposeCommand):
        (WebCore::Frame::respondToChangedSelection):
        (WebCore::Frame::cleanupPlatformScriptObjects):
        (WebCore::Frame::isCharacterSmartReplaceExempt):
        (WebCore::Frame::dragImageForSelection):
        * platform/gdk/FrameGdk.h:
        * platform/gdk/MimeTypeRegistryGdk.cpp: Added.
        * platform/gdk/TemporaryLinkStubs.cpp:
        (ChromeClientGdk::tabsToLinks):
        (ChromeClientGdk::windowResizerRect):
        (ChromeClientGdk::addToDirtyRegion):
        (ChromeClientGdk::scrollBackingStore):
        (ChromeClientGdk::updateBackingStore):
        * webcore-base.bkl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
kjk [Tue, 20 Feb 2007 21:13:34 +0000 (21:13 +0000)]
    Reviewed by Darin.

        Allow over-writting Product, ProductSub, Vendor and VendorSub
        js properties via #define WEBCORE_NAVIGATOR_*

        * bindings/js/kjs_navigator.cpp:
        (KJS::Navigator::getValueProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by John.
thatcher [Tue, 20 Feb 2007 20:41:54 +0000 (20:41 +0000)]
    Reviewed by John.

        * Misc/WebKitNSStringExtras.h: Added _webkit_userVisibleBundleVersionFromFullVersion.
        * Misc/WebKitNSStringExtras.m:
        (-[NSString _webkit_userVisibleBundleVersionFromFullVersion]): If the version is 4 digits long or longer,
        then the first digit represents the version of the OS. Our user agent string should not
        include this first digit, so strip it off and report the rest as the version.
        * WebView/WebView.mm:
        (-[WebView _computeUserAgent]): Call _webkit_userVisibleBundleVersionFromFullVersion on the CFBundleVersion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agogit-svn-id: https://svn.webkit.org/repository/webkit/trunk@19738 268f45cc-cd09-0410...
kmccullo [Tue, 20 Feb 2007 19:27:57 +0000 (19:27 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
darin [Tue, 20 Feb 2007 18:18:39 +0000 (18:18 +0000)]
WebCore:

        Reviewed by Anders.

        - prepare to fix some "stop loading" bugs by moving state from the
          FrameLoader class to the DocumentLoader class

        * WebCore.exp: Update since cancelMainResourceLoad is now on the document loader.

        * html/HTMLDocument.h:
        * html/HTMLDocument.cpp:
        (WebCore::HTMLDocument::HTMLDocument): Removed unused bodyElement and htmlElement
        data members.
        (WebCore::HTMLDocument::lastModified): Call getResponseModifiedHeader directly on
        the document loader.

        * loader/DocumentLoader.h: Moved m_mainResourceLoader, m_subresourceLoaders, and
        m_plugInStreamLoaders here.
        * loader/DocumentLoader.cpp:
        (WebCore::cancelAll): Moved here from FrameLoader.
        (WebCore::setAllDefersLoading): Ditto.
        (WebCore::DocumentLoader::mainResourceData): Moved the body of FrameLoader's
        mainResourceData function here.
        (WebCore::DocumentLoader::stopLoading): Replaced calls to hasMainResourceLoader
        and cancelMainResourceLoad with code that works directly on m_mainResourceLoader.
        Call the stop functions moved from FrameLoader here on ourselves.
        (WebCore::DocumentLoader::setupForReplaceByMIMEType): Ditto.
        (WebCore::DocumentLoader::setPrimaryLoadComplete): Moved the code to store the
        main resource data here; it doesn't require separate functions.
        (WebCore::DocumentLoader::isLoadingInAPISense): Removed call to isLoadingSubresources
        and instead just check if the m_subresourceLoaders set is empty.
        (WebCore::DocumentLoader::setDefersLoading): Moved code here from FrameLoader.
        (WebCore::DocumentLoader::stopLoadingPlugIns): Ditto.
        (WebCore::DocumentLoader::stopLoadingSubresources): Ditto.
        (WebCore::DocumentLoader::addSubresourceLoader): Ditto.
        (WebCore::DocumentLoader::removeSubresourceLoader): Ditto.
        (WebCore::DocumentLoader::addPlugInStreamLoader): Ditto.
        (WebCore::DocumentLoader::removePlugInStreamLoader): Ditto.
        (WebCore::DocumentLoader::isLoadingSubresources): Ditto.
        (WebCore::DocumentLoader::isLoadingPlugIns): Ditto.
        (WebCore::DocumentLoader::startLoadingMainResource): Ditto.
        (WebCore::DocumentLoader::cancelMainResourceLoad): Ditto.

        * loader/FrameLoader.h: Removed stopLoadingPlugIns, stopLoadingSubresources,
        cancelMainResourceLoad, hasMainResourceLoader, isLoadingSubresources,
        mainResourceData, releaseMainResourceLoader, lastModified, startLoadingMainResource,
        isLoadingPlugIns, m_mainResourceLoader, m_subresourceLoaders, m_plugInStreamLoaders,
        m_responseRefreshHeader, and m_responseModifiedHeader.
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::setDefersLoading): Call setDefersLoading on all the document
        loaders.
        (WebCore::FrameLoader::stopLoading): Get rid of code to set m_responseRefreshHeader
        and m_responseModifiedHeader.
        (WebCore::FrameLoader::receivedFirstData): Call httpHeaderField on the response
        here to get the Refresh, instead of storing it in a data member.
        (WebCore::FrameLoader::addPlugInStreamLoader): Change to just call this on the
        document loader.
        (WebCore::FrameLoader::removePlugInStreamLoader): Ditto.
        (WebCore::FrameLoader::isLoading): Change to call isLoadingSubresources and
        isLoadingPlugIns on the document loader.
        (WebCore::FrameLoader::addSubresourceLoader): Change to just call this on the
        document loader.
        (WebCore::FrameLoader::removeSubresourceLoader): Ditto.
        (WebCore::FrameLoader::commitProvisionalLoad): Call stopLoadingSubresources and
        stopLoadingPlugIns on the document loader. Removed code to set
        m_responseModifiedHeader.
        (WebCore::FrameLoader::startLoading): Call isLoadingMainResource and
        startLoadingMainResource on the document loader.

        * loader/ImageDocument.cpp: (WebCore::ImageTokenizer::finish): Call
        mainResourceData() on the document loader instead of the frame loader.

        - other changes

        * loader/DocLoader.cpp:
        (WebCore::DocLoader::checkCacheObjectStatus): Fixed indentation.

WebKit:

        Reviewed by Anders.

        * Plugins/WebPluginController.mm: (-[WebPluginController pluginView:receivedResponse:]):
        Call cancelMainResourceLoad on the document loader instead of the frame loader.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Mitz.
andersca [Tue, 20 Feb 2007 17:24:44 +0000 (17:24 +0000)]
    Reviewed by Mitz.

        <rdar://problem/5009627> REGRESSION: Repro overrelease of WebView in failed load, seen in DumpRenderTree

        * WebView/WebView.mm:
        (-[WebView _removeObjectForIdentifier:]):
        Return early if the identifier can't be found in the map.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix focus handling and make the forms
zack [Tue, 20 Feb 2007 17:19:59 +0000 (17:19 +0000)]
Fix focus handling and make the forms
work as expected.
r=Lars

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin and then Sam.
weinig [Tue, 20 Feb 2007 16:00:18 +0000 (16:00 +0000)]
    Reviewed by Darin and then Sam.

        - fix http://bugs.webkit.org/show_bug.cgi?id=10735
          Clicking in SVG results causes WebKit to consume 100% CPU for several minutes

        No test since there is no change in functionality.

        * CMakeLists.txt:
        * WebCore.pro:
        * WebCore.xcodeproj/project.pbxproj: Added PositionIterator.{cpp,h}.
        * WebCoreSources.bkl:
        * dom/Position.cpp:
        (WebCore::Position::Position): Added converting constructor from
        PositionIterator.
        (WebCore::Position::previous): Changed assert() to ASSERT().
        (WebCore::Position::next): Ditto.
        (WebCore::isStreamer): Changed the argument to a PositionIterator.
        (WebCore::Position::upstream): Changed to use PositionIterator.
        (WebCore::Position::downstream): Ditto.
        (WebCore::Position::inRenderedText): Made public.
        (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight): Changed
        into a static member function.
        (WebCore::Position::nodeIsUserSelectNone): Ditto.
        * dom/Position.h:
        * dom/PositionIterator.cpp: Added. A Position iterator with constant-time
        increment, decrement, and several predicates on the Position it is at.
        Conversion to/from Position is O(n) in the offset.
        (WebCore::PositionIterator::increment):
        (WebCore::PositionIterator::decrement):
        (WebCore::PositionIterator::atStart):
        (WebCore::PositionIterator::atEnd):
        (WebCore::PositionIterator::atStartOfNode):
        (WebCore::PositionIterator::atEndOfNode):
        (WebCore::PositionIterator::isCandidate):
        * dom/PositionIterator.h: Added.
        (WebCore::PositionIterator::PositionIterator):
        (WebCore::PositionIterator::node):
        (WebCore::PositionIterator::offsetInLeafNode):
        * editing/htmlediting.cpp:
        (WebCore::nextCandidate): Changed to use PositionIterator.
        (WebCore::previousCandidate): Changed to use PositionIterator.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
rwlbuis [Tue, 20 Feb 2007 15:39:04 +0000 (15:39 +0000)]
    Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=12439
        SVG parser complains about points attribute in polygon and polyline element

        Return true when the parsed points specification is valid.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoMake editing of forms work plus make sure that non-void methods
zack [Tue, 20 Feb 2007 14:46:51 +0000 (14:46 +0000)]
Make editing of forms work plus make sure that non-void methods
always return something.
r=Lars

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRedo form-theming (aka. make Qt pretty, so very, very pretty)
zack [Tue, 20 Feb 2007 12:30:12 +0000 (12:30 +0000)]
Redo form-theming (aka. make Qt pretty, so very, very pretty)
r=Lars

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-02-19 Lars Naesbye Christensen <lars@naesbye.dk>
ap [Tue, 20 Feb 2007 10:33:37 +0000 (10:33 +0000)]
2007-02-19  Lars Naesbye Christensen <lars@naesbye.dk>

        Reviewed by Maciej.

        http://bugs.webkit.org/show_bug.cgi?id=12815
        Two image files not included in project file

        * WebCore.xcodeproj/project.pbxproj: Added crossHairCursor.png and
        notAllowedCursor.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebKitTools:
gdennis [Tue, 20 Feb 2007 10:11:17 +0000 (10:11 +0000)]
WebKitTools:
        Reviewed by Darin Adler.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=12802
        WebKit.framework is built with SVG_SUPPORT for No-SVG build

        * Scripts/build-webkit: Pass the "FEATURE_DEFINES=" option when building WebKit as well.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam Roben.
ggaren [Tue, 20 Feb 2007 05:33:03 +0000 (05:33 +0000)]
    Reviewed by Adam Roben.

        Fixed some leaks in RenderThemeMac.

        No test case because 'leaks' can't detect these leaks inside DRT, even if
        DRT forces the WebView to paint. ('leaks' can detect these leaks inside
        Safari. Weird.)

        * rendering/RenderThemeMac.h:
            - Renamed data members to m_*, to match our style guidelines.
            - Renamed *Is* to is**, to match our style guidelines.
            - Removed a few unnecessary data members.
            - Made cached values like m_checkbox mutable, since they can change
            inside functions that don't change the logical state of a RenderTheme
            object. (The alternative was to make some const functions non-const.)

        (WebCore::RenderThemeMac::paintMenuList): Took CFType pointers that just
        used to leak and placed them in RetainPtrs.
        (WebCore::RenderThemeMac::paintMenuListButtonGradients): ditto

        Factored inline implementations of lazy initialization into these accessor
        functions, for better encapsulation:

        (WebCore::RenderThemeMac::checkbox):
        (WebCore::RenderThemeMac::radio):
        (WebCore::RenderThemeMac::button):
        (WebCore::RenderThemeMac::popupButton):
        (WebCore::RenderThemeMac::search):
        (WebCore::RenderThemeMac::sliderThumbHorizontal): The inline version of
        this initialization used to confuse the retained data member with a local
        stack value, causing both a leak and a failure to initialize. Fixed now.
        (WebCore::RenderThemeMac::sliderThumbVertical): ditto
        (WebCore::RenderThemeMac::resizeCornerImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff.
thatcher [Tue, 20 Feb 2007 05:19:51 +0000 (05:19 +0000)]
    Reviewed by Geoff.

        <rdar://problem/4636301> Deprecate JavaScriptGlue

        * JavaScriptGlue.h: adds DEPRECATED_IN_MAC_OS_X_VERSION_10_5_AND_LATER to everything
        * JavaScriptGlue.xcodeproj/project.pbxproj: use -Wno-deprecated-declarations to keep the project building
        * config.h: define DEPRECATED_IN_MAC_OS_X_VERSION_10_5_AND_LATER as empty on other systems

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
weinig [Tue, 20 Feb 2007 03:01:04 +0000 (03:01 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        - repaint test for http://bugs.webkit.org/show_bug.cgi?id=12817
          REGRESSION (r18634): Table border-collapse problems with right margin

        * fast/repaint/table-outer-border-expected.checksum: Added.
        * fast/repaint/table-outer-border-expected.png: Added.
        * fast/repaint/table-outer-border-expected.txt: Added.
        * fast/repaint/table-outer-border.html: Added.

WebCore:

        Reviewed by Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12817
          REGRESSION (r18634): Table border-collapse problems with right margin

        Test: fast/repaint/table-outer-border.html

        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::layout): Reordered to initialize horizontal overflow
        after table sections have computed their outer horizontal borders.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin
sullivan [Tue, 20 Feb 2007 02:39:29 +0000 (02:39 +0000)]
    Reviewed by Darin

        - fixed <rdar://problem/4613701> REGRESSION: A line break in the source HTML of a link becomes visible after drag & drop

        * page/DragController.cpp:
        (WebCore::DragController::startDrag):
        Call simplifyWhiteSpace() on the proposed link title to match what's displayed on the web page, instead of using the
        raw source HTML text.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix for Radar 4981605, regression where button grows randomly when a select is
hyatt [Tue, 20 Feb 2007 01:41:26 +0000 (01:41 +0000)]
    Fix for Radar 4981605, regression where button grows randomly when a select is
        opened.  With the new form controls, the WinIE quirk for using line width
        ended up being used for them more.

        This patch removes the quirk after verifying that Firefox doesn't implement
        the quirk at all.  usesLineWidth is being renamed to shrinksToAvoidFloats to
        make it clear that the new method only applies to block objects that avoid floats
        and that have auto width.

        Also fixed a regression where whitespace after a floating <select> at the start
        of a block got incorrectly rendered.  Make sure skipWhitespace always skips
        through floating/positioned elements regardless of the whitespace setting (this
        way the white-space:pre value on floating <select>s doesn't cause trouble).

        Reviewed by darin

        fast/block/float/float-avoidance.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::collapseMargins):
        (WebCore::RenderBlock::clearFloatsIfNeeded):
        (WebCore::RenderBlock::layoutBlockChildren):
        (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::containingBlockWidth):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::shrinkToAvoidFloats):
        * rendering/RenderObject.h:
        * rendering/bidi.cpp:
        (WebCore::RenderBlock::skipWhitespace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
weinig [Tue, 20 Feb 2007 01:22:06 +0000 (01:22 +0000)]
LayoutTests:

        Reviewed by Darin.

        1. Test for background image with relative url, when base url element
        is present. .html has a base url, which according to the html spec is supposed
        to be absolute, is actually a relative url. Absolute url would not work with file:// scheme.
        2. Test for base element and @import with relative url.
        http://bugs.webkit.org/show_bug.cgi?id=12214

        * fast/css/background-image-with-baseurl-expected.checksum: Added.
        * fast/css/background-image-with-baseurl-expected.png: Added.
        * fast/css/background-image-with-baseurl-expected.txt: Added.
        * fast/css/background-image-with-baseurl.html: Added.
        * fast/css/import_with_baseurl-expected.checksum: Added.
        * fast/css/import_with_baseurl-expected.png: Added.
        * fast/css/import_with_baseurl-expected.txt: Added.
        * fast/css/import_with_baseurl.html: Added.
        * fast/css/resources/background_image.css: Added.

WebCore:

        Reviewed by Darin.

        Update stylesheet href, when document's baseUrl changes. It needs
        update when the stylesheet is constructed before the parser hits the base tag.
        http://bugs.webkit.org/show_bug.cgi?id=12214

        * css/StyleSheet.h:
        (WebCore::StyleSheet::setHref):
        * dom/Document.cpp:
        (WebCore::Document::setBaseURL):
        * dom/Document.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam.
weinig [Tue, 20 Feb 2007 01:05:27 +0000 (01:05 +0000)]
    Reviewed by Adam.

        - fix http://bugs.webkit.org/show_bug.cgi?id=11518
          REGRESSION (r14376): View Source not available after Back navigation from a non-HTML page

        The FrameLoader's responseMIMEType was not being updated when a page was
        brought back from the page cache.

        Moved the line that updates the MIME type from commitProvisionalLoad() to
        transitionToCommitted().

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::commitProvisionalLoad):
        (WebCore::FrameLoader::transitionToCommitted):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Build fix.
ggaren [Tue, 20 Feb 2007 00:01:08 +0000 (00:01 +0000)]
    Build fix.

        * Scripts/check-for-global-initializers: Ignore the global counter I added
        for SubresourceLoaders.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Oliver.
andersca [Mon, 19 Feb 2007 23:32:12 +0000 (23:32 +0000)]
    Reviewed by Oliver.

        Make DragController::maxDragImageSize a function to get rid of the global initializer.

        * page/DragController.cpp:
        (WebCore::DragController::doImageDrag):
        * page/DragController.h:
        * page/mac/DragControllerMac.mm:
        (WebCore::DragController::maxDragImageSize):
        * page/qt/DragControllerQt.cpp:
        (WebCore::DragController::maxDragImageSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim Hatcher.
darin [Mon, 19 Feb 2007 23:19:06 +0000 (23:19 +0000)]
    Reviewed by Tim Hatcher.

        * Scripts/check-for-global-initializers: Delete the linked executable if the check fails.
        Without this, you only see the global initializer error once, which makes it very easy
        to miss them.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin Adler.
thatcher [Mon, 19 Feb 2007 23:09:51 +0000 (23:09 +0000)]
    Reviewed by Darin Adler.

        <rdar://problem/4841078> Remove the Mail.app editable link clicking behavior workaround when it is no longer needed

        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebView.mm:
        (-[WebView setPreferences:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Hyatt.
darin [Mon, 19 Feb 2007 21:44:13 +0000 (21:44 +0000)]
    Reviewed by Hyatt.

        - <rdar://problem/5006414> REGRESSION: Crash occurs at WebCore::Frame::loader()
          when loading AFL Ladder widget

        * html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::openURL):
        Add missing null check so this fails without crashing when called on an element
        that's no longer in a frame.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam.
andersca [Mon, 19 Feb 2007 21:39:26 +0000 (21:39 +0000)]
    Reviewed by Adam.

        <rdar://problem/4868242>
        http://bugs.webkit.org/show_bug.cgi?id=12670
        REGRESSION: Many 3rd Party Apps crash in WebCore::DocumentLoader::frameLoader() (12670)

        Bring back the semantic we had that a web view should be retained for as long as something is loading. Use the identifier
        to object hash map for this.

        * WebView/WebView.mm:
        (-[WebView _addObject:forIdentifier:]):
        (-[WebView _removeObjectForIdentifier:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRemove two imports of FrameMac.h, fixes clean Mac builds.
thatcher [Mon, 19 Feb 2007 19:41:01 +0000 (19:41 +0000)]
Remove two imports of FrameMac.h, fixes clean Mac builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
antti [Mon, 19 Feb 2007 15:43:42 +0000 (15:43 +0000)]
LayoutTests:

        Reviewed by Mitz.

        - test for http://bugs.webkit.org/show_bug.cgi?id=10990
          REGRESSION: Pressing a pop-up's access key doesn't focus it
          <rdar://problem/4823138>

        * fast/forms/select-accesskey-expected.checksum: Added.
        * fast/forms/select-accesskey-expected.png: Added.
        * fast/forms/select-accesskey-expected.txt: Added.
        * fast/forms/select-accesskey.html: Added.

WebCore:

        Reviewed by Mitz.

        - fix for http://bugs.webkit.org/show_bug.cgi?id=10990
          REGRESSION: Pressing a pop-up's access key doesn't focus it
          <rdar://problem/4823138>

        Focus the select element too in accessKeyAction.

        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::accessKeyAction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Hyatt.
antti [Mon, 19 Feb 2007 09:20:35 +0000 (09:20 +0000)]
    Reviewed by Hyatt.

        - really fix http://bugs.webkit.org/show_bug.cgi?id=11974
        REGRESSION: Caret drawn over input when smaller than font size on initial focus
        <rdar://problem/4960258>

        Avoid double painting caret when it is on a block element.

        Layout test for this already went in previous try (it only fails in pixel mode) in r19626.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paintCaret):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Added a one line patch from Olliej to create the
lars [Mon, 19 Feb 2007 08:13:56 +0000 (08:13 +0000)]
    Added a one line patch from Olliej to create the
        clipboard on demand (to stop things from crashing),
        and added lots of notImplemented() warnings all
        over the place.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Oliver
beidson [Mon, 19 Feb 2007 07:58:20 +0000 (07:58 +0000)]
    Reviewed by Oliver

        <rdar://problem/4985321> - Can't edit templates for Web Gallery/Web Page Export in Aperture

        * Misc/WebKitVersionChecks.h: Add a #define for this APERTURE quirk
        * WebView/WebView.mm:
        (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
         If the current app is Aperture and it was linked against Tiger WebKit, always allow selection change

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agofix compilation.
lars [Mon, 19 Feb 2007 07:57:46 +0000 (07:57 +0000)]
fix compilation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
mjs [Mon, 19 Feb 2007 07:54:13 +0000 (07:54 +0000)]
WebCore:

        Reviewed by Maciej.

        Additional coding by Maciej, additional review by Oliver.

        Get rid of the FrameMac and FrameQt classes. Instead
        move all methods into Frame directly, and implement
        some platform specific methods in foo/FrameFoo.cpp.

        Some general cleanup in Frame:
        * Move some methods out of Frame, to the place where they
        belong.
        * Unify the different ways of creating the JavaScript wrappers
        for <object>, <embed> and <applet>
        * Some cleanup of the WebCoreFrameBridge

        * ForwardingHeaders/bindings/NP_jsobject.h: Added.
        * ForwardingHeaders/bindings/npruntime_impl.h: Added.
        * ForwardingHeaders/bindings/runtime_root.h: Added.
        * WebCore.exp:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/kjs_binding.cpp:
        (KJS::ScriptInterpreter::shouldInterruptScript):
        * bindings/objc/DOM.mm:
        (-[DOMNode KJS::Bindings::]):
        * bindings/objc/DOMInternal.mm:
        (-[WebScriptObject _initializeScriptDOMNodeImp]):
        * bridge/EditorClient.h:
        * bridge/mac/FrameViewMac.mm:
        (WebCore::FrameView::updateBorder):
        (WebCore::FrameView::updateDashboardRegions):
        * bridge/mac/WebCoreAXObject.mm:
        (-[WebCoreAXObject rendererForView:]):
        * dom/Position.cpp:
        (WebCore::Position::next):
        * editing/CommandByName.cpp:
        (WebCore::Frame::execCopy):
        (WebCore::Frame::execCut):
        (WebCore::Frame::execPaste):
        * editing/Editor.cpp:
        (WebCore::Editor::canEdit):
        (WebCore::Editor::pasteWithPasteboard):
        (WebCore::Editor::paste):
        (WebCore::Editor::pasteAsPlainText):
        * editing/Editor.h:
        * editing/JSEditor.cpp:
        * html/HTMLAppletElement.cpp:
        (WebCore::HTMLAppletElement::getInstance):
        * html/HTMLEmbedElement.cpp:
        (WebCore::HTMLEmbedElement::getInstance):
        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::formData):
        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::getInstance):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::clear):
        (WebCore::FrameLoader::detachFromParent):
        * loader/mac/ImageDocumentMac.mm:
        (WebCore::finishImageLoad):
        * loader/qt/DocumentLoaderQt.cpp:
        * page/Chrome.cpp:
        (WebCore::Chrome::shouldInterruptJavaScript):
        * page/Chrome.h:
        * page/ChromeClient.h:
        * page/Frame.cpp:
        (WebCore::Frame::~Frame):
        (WebCore::Frame::markedTextRange):
        (WebCore::Frame::shouldChangeSelection):
        (WebCore::Frame::shouldDeleteSelection):
        (WebCore::Frame::isContentEditable):
        (WebCore::Frame::setSecureKeyboardEntry):
        (WebCore::Frame::isSecureKeyboardEntry):
        (WebCore::Frame::bindingRootObject):
        (WebCore::Frame::createRootObject):
        (WebCore::Frame::windowScriptNPObject):
        (WebCore::Frame::cleanupScriptObjects):
        (WebCore::FramePrivate::FramePrivate):
        * page/Frame.h:
        * page/FramePrivate.h:
        * page/FrameView.h:
        * page/mac/EventHandlerMac.mm:
        (WebCore::EventHandler::tabsToLinks):
        (WebCore::EventHandler::tabsToAllControls):
        (WebCore::EventHandler::focusDocumentView):
        (WebCore::EventHandler::passMouseDownEventToWidget):
        (WebCore::EventHandler::handleDrag):
        (WebCore::EventHandler::sendFakeEventsAfterWidgetTracking):
        (WebCore::EventHandler::keyboardUIMode):
        * page/mac/FrameMac.h: Removed.
        * page/mac/FrameMac.mm:
        (WebCore::Frame::setBridge):
        (WebCore::Frame::bridge):
        (WebCore::Frame::searchForLabelsAboveCell):
        (WebCore::Frame::searchForLabelsBeforeElement):
        (WebCore::Frame::matchLabelsAgainstElement):
        (WebCore::Frame::focusWindow):
        (WebCore::Frame::unfocusWindow):
        (WebCore::Frame::imageFromRect):
        (WebCore::Frame::selectionImage):
        (WebCore::Frame::snapshotDragImage):
        (WebCore::Frame::fontAttributesForSelectionStart):
        (WebCore::Frame::baseWritingDirectionForSelectionStart):
        (WebCore::Frame::print):
        (WebCore::Frame::issuePasteCommand):
        (WebCore::Frame::issueTransposeCommand):
        (WebCore::Frame::respondToChangedSelection):
        (WebCore::Frame::textFieldDidBeginEditing):
        (WebCore::Frame::textFieldDidEndEditing):
        (WebCore::Frame::textDidChangeInTextField):
        (WebCore::Frame::textDidChangeInTextArea):
        (WebCore::Frame::doTextFieldCommandFromEvent):
        (WebCore::Frame::textWillBeDeletedInTextField):
        (WebCore::Frame::setSecureKeyboardEntry):
        (WebCore::Frame::isSecureKeyboardEntry):
        (WebCore::Frame::setMarkedTextRange):
        (WebCore::Frame::dashboardRegionsDictionary):
        (WebCore::Frame::dashboardRegionsChanged):
        (WebCore::Frame::willPopupMenu):
        (WebCore::Frame::isCharacterSmartReplaceExempt):
        (WebCore::Frame::setNeedsReapplyStyles):
        (WebCore::Frame::customHighlightLineRect):
        (WebCore::Frame::paintCustomHighlight):
        (WebCore::Frame::createScriptInstanceForWidget):
        (WebCore::Frame::windowScriptObject):
        (WebCore::Frame::cleanupPlatformScriptObjects):
        * page/mac/WebCoreFrameBridge.h:
        * page/mac/WebCoreFrameBridge.mm:
        (createRootObject):
        (bridge):
        (-[WebCoreFrameBridge _frame]):
        * page/qt/EventHandlerQt.cpp:
        * page/qt/FrameQt.cpp:
        (WebCore::Frame::unfocusWindow):
        (WebCore::Frame::focusWindow):
        (WebCore::Frame::issueTransposeCommand):
        (WebCore::Frame::respondToChangedSelection):
        (WebCore::Frame::print):
        (WebCore::Frame::createScriptInstanceForWidget):
        (WebCore::Frame::cleanupPlatformScriptObjects):
        (WebCore::Frame::isCharacterSmartReplaceExempt):
        * page/qt/FrameQt.h: Removed.
        * platform/MimeTypeRegistry.h:
        * platform/graphics/svg/SVGImage.cpp:
        (WebCore::SVGImage::setData):
        * platform/graphics/svg/SVGImageEmptyClients.h:
        (WebCore::SVGEmptyChromeClient::shouldInterruptJavaScript):
        (WebCore::SVGEmptyEditorClient::shouldChangeSelectedRange):
        * platform/mac/ClipboardMac.h:
        * platform/mac/ClipboardMac.mm:
        (WebCore::ClipboardMac::ClipboardMac):
        * platform/mac/FileChooserMac.mm:
        (-[OpenPanelController beginSheetWithFrame:]):
        * platform/mac/MimeTypeRegistryMac.mm:
        (WebCore::MimeTypeRegistry::getMIMETypeForPath):
        * platform/mac/PopupMenuMac.mm:
        (WebCore::PopupMenu::show):
        * platform/mac/WidgetMac.mm:
        (WebCore::Widget::setFocus):
        (WebCore::Widget::setIsSelected):
        * platform/network/mac/ResourceHandleMac.mm:
        * platform/network/qt/ResourceHandleManagerQt.cpp:
        * platform/network/qt/ResourceHandleQt.cpp:
        (WebCore::ResourceHandle::start):
        * platform/qt/MimeTypeRegistryQt.cpp:
        (WebCore::MimeTypeRegistry::getMIMETypeForPath):
        * platform/qt/PopupMenuQt.cpp:
        * platform/qt/ScrollViewCanvasQt.cpp:
        * platform/qt/ScrollViewQt.cpp:
        * platform/win/TemporaryLinkStubs.cpp:
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paintCustomHighlight):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::paintCustomHighlight):
        * rendering/RootInlineBox.cpp:
        (WebCore::RootInlineBox::addHighlightOverflow):
        (WebCore::RootInlineBox::paintCustomHighlight):

WebKit:

        Reviewed by Maciej.

        Additional coding by Maciej, additional review by Oliver.

        Added implementations for the new callbacks in EditorClient
        and ChromeClient (basically moved from WebFrameBridge).
        Cleaned up some code paths that are not called anymore
        and done fully inside WebCore now.

        * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
        * Misc/WebElementDictionary.mm:
        * Misc/WebNSAttributedStringExtras.mm:
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView getVariable:value:]):
        * Plugins/WebNetscapePluginEmbeddedView.mm:
        * Plugins/WebNetscapePluginStream.mm:
        * Plugins/WebPluginContainerCheck.mm:
        * WebCoreSupport/WebChromeClient.h:
        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::shouldInterruptJavaScript):
        * WebCoreSupport/WebEditorClient.h:
        * WebCoreSupport/WebEditorClient.mm:
        (WebEditorClient::shouldChangeSelectedRange):
        * WebCoreSupport/WebFrameBridge.mm:
        (-[WebFrameBridge finishInitializingWithPage:frameName:frameView:ownerElement:]):
        (-[WebFrameBridge fini]):
        * WebCoreSupport/WebFrameLoaderClient.mm:
        * WebView/WebArchiver.mm:
        * WebView/WebFrame.mm:
        (core):
        (kit):
        (-[WebFrame _updateBackground]):
        * WebView/WebFrameInternal.h:
        * WebView/WebFrameView.mm:
        * WebView/WebHTMLRepresentation.mm:
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _updateMouseoverWithEvent:]):
        (-[WebHTMLView _isEditable]):
        (-[WebHTMLView validateUserInterfaceItem:]):
        (-[WebHTMLView maintainsInactiveSelection]):
        (-[WebHTMLView scrollWheel:]):
        (-[WebHTMLView acceptsFirstMouse:]):
        (-[WebHTMLView shouldDelayWindowOrderingForEvent:]):
        (-[WebHTMLView cut:]):
        (-[WebHTMLView paste:]):
        (-[WebHTMLView selectedAttributedString]):
        * WebView/WebScriptDebugDelegate.mm:
        * WebView/WebView.mm:
        (-[WebView _dashboardRegions]):
        (-[WebView setProhibitsMainFrameScrolling:]):
        (-[WebView _setInViewSourceMode:]):
        (-[WebView _inViewSourceMode]):
        (-[WebView shouldClose]):
        (-[WebView setEditable:]):

WebKitQt:

        Reviewed by Maciej.

        Additional coding by Maciej, additional review by Oliver.

        Add stubs for the new methods in ChormeClient and EditorClient,
        remove all references to FrameQt.

        * Api/qwebframe.cpp:
        (QWebFrame::QWebFrame):
        * Api/qwebframe_p.h:
        * Api/qwebpage.cpp:
        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::shouldInterruptJavaScript):
        * WebCoreSupport/ChromeClientQt.h:
        * WebCoreSupport/EditorClientQt.cpp:
        (WebCore::EditorClientQt::shouldChangeSelectedRange):
        (WebCore::EditorClientQt::isEditable):
        * WebCoreSupport/EditorClientQt.h:
        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::setFrame):
        (WebCore::FrameLoaderClientQt::webFrame):
        * WebCoreSupport/FrameLoaderClientQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-02-18 Oliver Hunt <oliver@apple.com>
oliver [Mon, 19 Feb 2007 07:18:06 +0000 (07:18 +0000)]
2007-02-18  Oliver Hunt  <oliver@apple.com>

        Reviewed by NOBODY (Buildfix).

        Oops, missed a 'const'

        * platform/qt/ClipboardQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-02-18 Oliver Hunt <oliver@apple.com>
oliver [Mon, 19 Feb 2007 07:04:16 +0000 (07:04 +0000)]
2007-02-18  Oliver Hunt  <oliver@apple.com>

        Reviewed by Adam.

        Adding stubbed out implementation of Clipboard for Qt to stop
        it crashing whenever someone drags the mouse.

        * WebCore.pro:
        * page/qt/EventHandlerQt.cpp:
        (WebCore::EventHandler::createDraggingClipboard):
        * platform/qt/ClipboardQt.cpp: Added.
        (WebCore::ClipboardQt::ClipboardQt):
        (WebCore::ClipboardQt::clearData):
        (WebCore::ClipboardQt::clearAllData):
        (WebCore::ClipboardQt::getData):
        (WebCore::ClipboardQt::setData):
        (WebCore::ClipboardQt::types):
        (WebCore::ClipboardQt::dragLocation):
        (WebCore::ClipboardQt::dragImage):
        (WebCore::ClipboardQt::setDragImage):
        (WebCore::ClipboardQt::dragImageElement):
        (WebCore::ClipboardQt::setDragImageElement):
        (WebCore::ClipboardQt::createDragImage):
        (WebCore::ClipboardQt::declareAndWriteDragImage):
        (WebCore::ClipboardQt::writeURL):
        (WebCore::ClipboardQt::writeRange):
        (WebCore::ClipboardQt::hasData):
        * platform/qt/ClipboardQt.h: Added.
        (WebCore::ClipboardQt::~ClipboardQt):
        (WebCore::ClipboardQt::isForDragging):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-02-18 Oliver Hunt <oliver@apple.com>
oliver [Mon, 19 Feb 2007 06:07:14 +0000 (06:07 +0000)]
2007-02-18  Oliver Hunt  <oliver@apple.com>

        Reviewed by Adam.

        Don't even attempt to do a document based drag if there isn't a document
        Fixes rdar://problem/4960109

        * page/DragController.cpp:
        (WebCore::DragController::tryDocumentDrag):
           Null check m_document
        (WebCore::DragController::tryDHTMLDrag):
           ASSERT(m_document) -- tryDocumentDrag is the only
           thing that will ever call us, but lets play it safe

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Hyatt.
aroben [Mon, 19 Feb 2007 00:26:32 +0000 (00:26 +0000)]
    Reviewed by Hyatt.

        A little preparation for <rdar://problem/5006872>.

        * platform/PopupMenu.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19698 268f45cc-cd09-0410-ab3c-d52691b4dbfc