WebKit-https.git
9 years ago[Qt] [WK2] Improve position of context menu for QDesktopWebView
caio.oliveira@openbossa.org [Wed, 3 Aug 2011 19:36:04 +0000 (19:36 +0000)]
[Qt] [WK2] Improve position of context menu for QDesktopWebView
https://bugs.webkit.org/show_bug.cgi?id=65635

Reviewed by Andreas Kling.

Do not assume that the QDesktopWebView takes the entire canvas when
positioning the context menu.

* UIProcess/API/qt/qdesktopwebview.cpp:
(QDesktopWebViewPrivate::showContextMenu):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Remove InspectorFrontendHost load/saveSessionSetting
joepeck@webkit.org [Wed, 3 Aug 2011 19:09:34 +0000 (19:09 +0000)]
Web Inspector: Remove InspectorFrontendHost load/saveSessionSetting
https://bugs.webkit.org/show_bug.cgi?id=65582

Reviewed by Pavel Feldman.

Source/WebCore:

Remove stale code. WebInspector.settings uses localStorage and
handles the "debuggerEnabled" state. So remove the only remaining
usage of load/saveSessionSetting.

* inspector/InspectorFrontendClient.h:
* inspector/InspectorFrontendHost.cpp:
* inspector/InspectorFrontendHost.h:
* inspector/InspectorFrontendHost.idl:
* inspector/front-end/InspectorFrontendHostStub.js:
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._debuggerWasDisabled):

Source/WebKit/cf:

* WebCoreSupport/WebInspectorClientCF.cpp:

Source/WebKit/mac:

* WebCoreSupport/WebInspectorClient.h:
* WebCoreSupport/WebInspectorClient.mm:

Source/WebKit/win:

* WebCoreSupport/WebInspectorClient.cpp:
* WebCoreSupport/WebInspectorClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash in DocumentWriter::endIfNotLoadingMainResource
abarth@webkit.org [Wed, 3 Aug 2011 18:56:37 +0000 (18:56 +0000)]
Crash in DocumentWriter::endIfNotLoadingMainResource
https://bugs.webkit.org/show_bug.cgi?id=65581

Reviewed by Nate Chapin.

Source/WebCore:

This function is poorly designed because isLoadingMainResource is a
poor proxy for determing whether to flush/finish the parser.  Really,
we should change how loads complete to match the model in HTML5, but
that's pretty tricky.  In the meantime, this null check fixes the
crash.

I'm sure there's another bug on file about this crash, but we've never
been able to reproduce it.  Thanks to Berend-Jan Wever for the test
case!

Test: fast/loader/reload-zero-byte-plugin.html

* loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::endIfNotLoadingMainResource):

LayoutTests:

* fast/loader/reload-zero-byte-plugin-expected.txt: Added.
* fast/loader/reload-zero-byte-plugin.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebCore images backing CG patterns should be released on the main thread
andersca@apple.com [Wed, 3 Aug 2011 18:38:26 +0000 (18:38 +0000)]
WebCore images backing CG patterns should be released on the main thread
https://bugs.webkit.org/show_bug.cgi?id=65630

Reviewed by Sam Weinig.

* platform/graphics/cg/PatternCG.cpp:
(WebCore::patternReleaseOnMainThreadCallback):
Deref the image.

(WebCore::patternReleaseCallback):
Call callOnMainThread.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTeach BuilderToPort to distinguish between Release and Debug builders.
dglazkov@chromium.org [Wed, 3 Aug 2011 18:11:12 +0000 (18:11 +0000)]
Teach BuilderToPort to distinguish between Release and Debug builders.
https://bugs.webkit.org/show_bug.cgi?id=65628

Reviewed by Adam Barth.

* Scripts/webkitpy/tool/commands/rebaseline.py: Added a smart options object and passed it to port factory.
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Added tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix API tests.
andersca@apple.com [Wed, 3 Aug 2011 17:41:51 +0000 (17:41 +0000)]
Fix API tests.

Initialize threading before trying to allocate the WebContext.

* UIProcess/WebContext.cpp:
(WebKit::WebContext::sharedProcessContext):
(WebKit::WebContext::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows nightly build fix after r91777
aroben@apple.com [Wed, 3 Aug 2011 17:22:50 +0000 (17:22 +0000)]
Windows nightly build fix after r91777

* Interfaces/IWebPreferences.idl: Moved [set]PictographFontFamily to the end of the
interface to maintain binary compatibility with Safari 5.1.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a Mac Lion skipped list.
andersca@apple.com [Wed, 3 Aug 2011 17:06:24 +0000 (17:06 +0000)]
Add a Mac Lion skipped list.

* platform/mac-lion: Added.
* platform/mac-lion/Skipped: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse appropriate macro for CSSPropertyImageRendering.
macpherson@chromium.org [Wed, 3 Aug 2011 16:48:47 +0000 (16:48 +0000)]
Use appropriate macro for CSSPropertyImageRendering.
https://bugs.webkit.org/show_bug.cgi?id=65594

Reviewed by Simon Fraser.

No new tests / trivial code cleanup only.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFontCache::getFontData() does not set the familyIndex to cAllFamiliesScanned if the...
mitz@apple.com [Wed, 3 Aug 2011 16:46:13 +0000 (16:46 +0000)]
FontCache::getFontData() does not set the familyIndex to cAllFamiliesScanned if the last font is a custom font
https://bugs.webkit.org/show_bug.cgi?id=65597

Reviewed by Simon Fraser.

No test added because behavior is unchanged, but this saves a call to getFontData().

* platform/graphics/FontCache.cpp:
(WebCore::FontCache::getFontData): Eliminated early return inside the loop, allowing execution
to continue and familyIndex to be set.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd RenderedPosition
rniwa@webkit.org [Wed, 3 Aug 2011 16:27:35 +0000 (16:27 +0000)]
Add RenderedPosition
https://bugs.webkit.org/show_bug.cgi?id=65221

Reviewed by Hajime Morita.

Add the skeleton for RenderedPosition and use it in rootBoxForLine.

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* editing/EditingAllInOne.cpp:
* editing/RenderedPosition.cpp: Added.
(WebCore::RenderedPosition::RenderedPosition):
* editing/RenderedPosition.h: Added.
(WebCore::RenderedPosition::isNull):
(WebCore::RenderedPosition::rootBox):
(WebCore::RenderedPosition::RenderedPosition):
* editing/visible_units.cpp:
(WebCore::startPositionForLine):
(WebCore::endPositionForLine):
(WebCore::logicalStartPositionForLine):
(WebCore::logicalEndPositionForLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[V8] V8CSSRuleCustom.cpp: not all enum values are listed in switch statement
rolandsteiner@chromium.org [Wed, 3 Aug 2011 16:15:21 +0000 (16:15 +0000)]
[V8] V8CSSRuleCustom.cpp: not all enum values are listed in switch statement
https://bugs.webkit.org/show_bug.cgi?id=65598

Reviewed by Dimitri Glazkov.

Added UNKNOWN_RULE to the switch statement.

No new tests. (No semantic change)

* bindings/v8/custom/V8CSSRuleCustom.cpp:
(WebCore::toV8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [Timeline] Hover on paint events and see rect outline around that...
pfeldman@chromium.org [Wed, 3 Aug 2011 16:11:21 +0000 (16:11 +0000)]
Web Inspector: [Timeline] Hover on paint events and see rect outline around that area.
https://bugs.webkit.org/show_bug.cgi?id=65510

Reviewed by Yury Semikhatsky.

Source/WebCore:

* WebCore.exp.in:
* WebCore.order:
* inspector/DOMNodeHighlighter.cpp:
(WebCore::DOMNodeHighlighter::drawRectHighlight):
* inspector/DOMNodeHighlighter.h:
* inspector/Inspector.json:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::drawHighlight):
* inspector/InspectorController.h:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::highlightRect):
(WebCore::InspectorDOMAgent::hideHighlight):
(WebCore::InspectorDOMAgent::drawHighlight):
* inspector/InspectorDOMAgent.h:
* inspector/front-end/ResourcesPanel.js:
(WebInspector.FrameTreeElement.prototype.onselect):
(WebInspector.FrameTreeElement.prototype.set hovered):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._mouseOut):
(WebInspector.TimelinePanel.prototype._mouseMove):
(WebInspector.TimelinePanel.prototype._highlightRect):
(WebInspector.TimelinePanel.prototype._hideRectHighlight):
* inspector/front-end/inspector.js:
(WebInspector.highlightDOMNode):

Source/WebKit/chromium:

* src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::paintPageOverlay):

Source/WebKit/gtk:

* webkit/webkitwebview.cpp:
(paintWebView):

Source/WebKit/mac:

* WebInspector/WebNodeHighlightView.mm:
(-[WebNodeHighlightView drawRect:]):

Source/WebKit/qt:

* Api/qwebframe.cpp:
(QWebFramePrivate::renderRelativeCoords):

Source/WebKit/win:

* WebNodeHighlight.cpp:
(WebNodeHighlight::update):

Source/WebKit2:

* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::drawRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Fix running qmltests for WK2 in the bot
caio.oliveira@openbossa.org [Wed, 3 Aug 2011 15:49:28 +0000 (15:49 +0000)]
[Qt] Fix running qmltests for WK2 in the bot
https://bugs.webkit.org/show_bug.cgi?id=65621

Reviewed by Csaba Osztrogon√°c.

The path for QML_IMPORT_PATH was assuming we were running the WK1 tests,
but now there's the case for WK2 UIProcess tests as well.

* Scripts/run-qtwebkit-tests: add both possible paths to the QML_IMPORT_PATH.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a way to edit test expectations.
dglazkov@chromium.org [Wed, 3 Aug 2011 15:33:37 +0000 (15:33 +0000)]
Add a way to edit test expectations.
https://bugs.webkit.org/show_bug.cgi?id=64922

Implements a TestExpectationsEditor, which provides a standard way to
update and remove test expectations.

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed TestExpectationSerializer to skip lines that match no test configurations,
    added TestExpectationLine.is_flaky, added BugManager, a simple interface to be fleshed out later, and a TestExpectationsEditor, the big
    enchilada.
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Loads of tests to capture desired behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Added two compositing tests whose pixel results on the
senorblanco@chromium.org [Wed, 3 Aug 2011 15:30:26 +0000 (15:30 +0000)]
[chromium] Added two compositing tests whose pixel results on the
Mesa bots are different following
http://trac.webkit.org/changeset/92255.

Unreviewed.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: make text in popover selectable + make popover re-appear faster.
pfeldman@chromium.org [Wed, 3 Aug 2011 15:09:52 +0000 (15:09 +0000)]
Web Inspector: make text in popover selectable + make popover re-appear faster.
https://bugs.webkit.org/show_bug.cgi?id=65603

Reviewed by Yury Semikhatsky.

* inspector/front-end/Popover.js:
(WebInspector.PopoverHelper.prototype.setTimeout):
(WebInspector.PopoverHelper.prototype._mouseMove):
(WebInspector.PopoverHelper.prototype._handleMouseAction):
* inspector/front-end/popover.css:
(.popover .content):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Unreviewed, GTK baselines for media/media-controls-clone.html.
philn@webkit.org [Wed, 3 Aug 2011 14:40:10 +0000 (14:40 +0000)]
    Unreviewed, GTK baselines for media/media-controls-clone.html.

        * platform/gtk/media/media-controls-clone-expected.png: Added.
        * platform/gtk/media/media-controls-clone-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Console scroll position should be saved when switching panels.
vsevik@chromium.org [Wed, 3 Aug 2011 14:33:18 +0000 (14:33 +0000)]
Web Inspector: Console scroll position should be saved when switching panels.
https://bugs.webkit.org/show_bug.cgi?id=65607

Reviewed by Pavel Feldman.

* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._formatAsArrayEntry):
(WebInspector.ConsoleView.prototype.get scrollLeft):
(WebInspector.ConsoleView.prototype.set scrollLeft):
(WebInspector.ConsoleView.prototype.get scrollTop):
(WebInspector.ConsoleView.prototype.set scrollTop):
* inspector/front-end/Drawer.js:
(WebInspector.Drawer.prototype.show):
(WebInspector.Drawer.prototype._endStatusBarDragging):
(WebInspector.Drawer.prototype.get scrollLeft):
(WebInspector.Drawer.prototype.set scrollLeft):
(WebInspector.Drawer.prototype.get scrollTop):
(WebInspector.Drawer.prototype.set scrollTop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] [WK2] Expose web view classes to QML
caio.oliveira@openbossa.org [Wed, 3 Aug 2011 14:25:23 +0000 (14:25 +0000)]
[Qt] [WK2] Expose web view classes to QML
https://bugs.webkit.org/show_bug.cgi?id=65339

Reviewed by Benjamin Poulain.

.:

* Source/WebKit.pro: Include QML plugin subdir in the build system for WK2.

Source/WebKit2:

This patch also uses QuickTest from QtDeclarative to provide the basic autotest
infrastructure for the exposed elements.

* UIProcess/API/qt/qmlplugin/plugin.cpp: Added.
(WebKit2QmlPlugin::registerTypes):
* UIProcess/API/qt/qmlplugin/qmldir: Added.
* UIProcess/API/qt/qmlplugin/qmlplugin.pro: Added.
* UIProcess/API/qt/qtouchwebpage.h: Expose load() to QML environment.
* UIProcess/API/qt/qtouchwebview.h: Since QTouchWebPage* doesn't change once set
in the constructor, we mark the page property as CONSTANT. This avoid QML
warnings for not having a NOTIFY signal for the property change.

* UIProcess/API/qt/tests/tests.pro:
* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_properties.qml: Added.
* UIProcess/API/qt/tests/qmltests/TouchWebView/tst_properties.qml: Added.
* UIProcess/API/qt/tests/qmltests/common/test1.html: Added.
* UIProcess/API/qt/tests/qmltests/qmltests.pro: Added.
* UIProcess/API/qt/tests/qmltests/tst_qmltests.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] MiniBrowser: Unbreak load progress indication.
andreas.kling@nokia.com [Wed, 3 Aug 2011 13:15:39 +0000 (13:15 +0000)]
[Qt] MiniBrowser: Unbreak load progress indication.
https://bugs.webkit.org/show_bug.cgi?id=65614

Reviewed by Kenneth Rohde Christiansen.

loadProgress() was renamed to loadProgressChanged().

* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
(BrowserWindow::onLoadProgressChanged):
* MiniBrowser/qt/BrowserWindow.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Remove flaky failures of fast/speech/input-appearance-*.html.
tkent@chromium.org [Wed, 3 Aug 2011 13:05:46 +0000 (13:05 +0000)]
[Chromium] Remove flaky failures of fast/speech/input-appearance-*.html.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix for WebKit2GTK+.
mrobinson@webkit.org [Wed, 3 Aug 2011 12:29:47 +0000 (12:29 +0000)]
Build fix for WebKit2GTK+.

* WebKitTestRunner/GNUmakefile.am: Include libInternals as one of
of the library dependencies of the injected bundle.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Install web and plugin processes in libexecdir instead of bindir
carlosgc@webkit.org [Wed, 3 Aug 2011 12:20:12 +0000 (12:20 +0000)]
[GTK] Install web and plugin processes in libexecdir instead of bindir
https://bugs.webkit.org/show_bug.cgi?id=65600

Reviewed by Martin Robinson.

.:

* GNUmakefile.am: Initialize libexec_PROGRAMS, only used by
WebKit2 in this moment.

Source/WebKit2:

Launch processes from libexecdir or WEBKIT_EXEC_PATH
environment variable when it's set. This variable will be used by
MiniBrowser and unit tests to find processes without having to
install them.

* GNUmakefile.am:
* UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
(WebKit::ProcessLauncher::launchProcess):

Tools:

Set WEBKIT_EXEC_PATH environment variable to use web and plugin
process from current directory instead of the intalled ones.

* MiniBrowser/gtk/GNUmakefile.am:
* MiniBrowser/gtk/main.c:
(main):
* WebKitTestRunner/GNUmakefile.am:
* WebKitTestRunner/gtk/main.cpp:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt]REGRESSION(r92254): It made 2 tests timeout
ossy@webkit.org [Wed, 3 Aug 2011 11:55:26 +0000 (11:55 +0000)]
[Qt]REGRESSION(r92254): It made 2 tests timeout
https://bugs.webkit.org/show_bug.cgi?id=65609

[Qt]REGRESSION(r92224): It made editing/text-iterator/basic-iteration.html timeout
https://bugs.webkit.org/show_bug.cgi?id=65605

* platform/qt/Skipped: Skip failing tests:
 - fast/frames/lots-of-objects.html
 - fast/frames/lots-of-iframes.html
 - editing/text-iterator/basic-iteration.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago libsoup-CRITICAL **: soup_message_io_pause: assertion `io != NULL' failed
philn@webkit.org [Wed, 3 Aug 2011 11:14:52 +0000 (11:14 +0000)]
    libsoup-CRITICAL **: soup_message_io_pause: assertion `io != NULL' failed
        https://bugs.webkit.org/show_bug.cgi?id=64263

        Reviewed by Martin Robinson.

        Avoid any operation on not yet started messages and completed messages.

        * platform/network/ResourceHandleInternal.h:
        (WebCore::ResourceHandleInternal::ResourceHandleInternal):
        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::finishedCallback):
        (WebCore::startHTTPRequest):
        (WebCore::ResourceHandle::platformSetDefersLoading):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Fix OOP font loading to work on 10.6.6 and above.
jeremy@chromium.org [Wed, 3 Aug 2011 10:48:22 +0000 (10:48 +0000)]
[Chromium] Fix OOP font loading to work on 10.6.6 and above.
https://bugs.webkit.org/show_bug.cgi?id=65543

In 10.6.6 the function used to get the unique ID for an NSFont in the
renderer was changed so it fails in the sandbox (it now tries to access
the on-disk font file). In order to work around this, we get the font
ID from the browser process.

To speed things up, we introduce 2 levels of caching in WebKit. A font
name cache where we can perform a quick lookup without the need for the
font id and a font id cache which we can only lookup in after getting
the unique ID from the browser process.

Reviewed by Kenneth Russell.

No new tests since this is not readily testable.

Source/WebCore:

* platform/chromium/PlatformBridge.h:
* platform/graphics/chromium/CrossProcessFontLoading.h:
* platform/graphics/chromium/CrossProcessFontLoading.mm:
(WebCore::MemoryActivatedFont::create):
(WebCore::MemoryActivatedFont::MemoryActivatedFont):
(WebCore::MemoryActivatedFont::~MemoryActivatedFont):

Source/WebKit/chromium:

* public/mac/WebSandboxSupport.h: Plumb font ID parameter through.
* src/PlatformBridge.cpp:
(WebCore::PlatformBridge::loadFont): ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Unreviewed, GTK svg rebaseline after r92047.
philn@webkit.org [Wed, 3 Aug 2011 10:46:24 +0000 (10:46 +0000)]
    Unreviewed, GTK svg rebaseline after r92047.

        * platform/gtk/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
        * platform/gtk/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt:
        * platform/gtk/svg/batik/filters/feTile-expected.txt:
        * platform/gtk/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
        * platform/gtk/svg/batik/paints/patternRegionA-expected.txt:
        * platform/gtk/svg/batik/paints/patternRegions-expected.txt:
        * platform/gtk/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
        * platform/gtk/svg/batik/text/longTextOnPath-expected.txt:
        * platform/gtk/svg/batik/text/smallFonts-expected.txt:
        * platform/gtk/svg/batik/text/textAnchor-expected.txt:
        * platform/gtk/svg/batik/text/textDecoration-expected.txt:
        * platform/gtk/svg/batik/text/textEffect-expected.txt:
        * platform/gtk/svg/batik/text/textEffect2-expected.txt:
        * platform/gtk/svg/batik/text/textEffect3-expected.txt:
        * platform/gtk/svg/batik/text/textFeatures-expected.txt:
        * platform/gtk/svg/batik/text/textLayout-expected.txt:
        * platform/gtk/svg/batik/text/textLayout2-expected.txt:
        * platform/gtk/svg/batik/text/textLength-expected.txt:
        * platform/gtk/svg/batik/text/textOnPath-expected.txt:
        * platform/gtk/svg/batik/text/textOnPathSpaces-expected.txt:
        * platform/gtk/svg/batik/text/textPosition-expected.txt:
        * platform/gtk/svg/batik/text/textPosition2-expected.txt:
        * platform/gtk/svg/batik/text/textProperties-expected.txt:
        * platform/gtk/svg/batik/text/textProperties2-expected.txt:
        * platform/gtk/svg/batik/text/textStyles-expected.txt:
        * platform/gtk/svg/batik/text/verticalText-expected.txt:
        * platform/gtk/svg/batik/text/verticalTextOnPath-expected.txt:
        * platform/gtk/svg/custom/external-paintserver-reference-expected.txt: Added.
        * platform/gtk/svg/custom/linking-base-external-reference-expected.txt: Added.
        * platform/gtk/svg/custom/text-linking-expected.txt:
        * platform/gtk/svg/custom/zero-path-square-cap-rendering2-expected.txt: Added.
        * platform/gtk/svg/hixie/error/014-expected.txt:
        * platform/gtk/svg/hixie/use/002-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake EventDispatchMediator RefCounted.
hayato@chromium.org [Wed, 3 Aug 2011 10:17:31 +0000 (10:17 +0000)]
Make EventDispatchMediator RefCounted.
https://bugs.webkit.org/show_bug.cgi?id=65529

Reviewed by Hajime Morita.

Make EventDispatchMediator RefCounted so that it can be enqueued into a
ScopedEventQueue and called later.
A necessary change for ScopedEventQueue should be addressed in another patch.

This is a minor update of r92256, which failed on chromium win builds.

No changes to functionality so no new tests.

* dom/Event.cpp:
(WebCore::EventDispatchMediator::create):
* dom/Event.h:
* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent):
* dom/EventDispatcher.h:
* dom/KeyboardEvent.cpp:
(WebCore::KeyboardEventDispatchMediator::create):
* dom/KeyboardEvent.h:
* dom/MouseEvent.cpp:
(WebCore::MouseEventDispatchMediator::create):
* dom/MouseEvent.h:
* dom/Node.cpp:
(WebCore::Node::dispatchEvent):
(WebCore::Node::dispatchKeyEvent):
(WebCore::Node::dispatchMouseEvent):
(WebCore::Node::dispatchWheelEvent):
* dom/WheelEvent.cpp:
(WebCore::WheelEventDispatchMediator::create):
* dom/WheelEvent.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: remove Node parameter from the InspectorClient::highlight
pfeldman@chromium.org [Wed, 3 Aug 2011 08:28:40 +0000 (08:28 +0000)]
Web Inspector: remove Node parameter from the InspectorClient::highlight
https://bugs.webkit.org/show_bug.cgi?id=65549

Patch by Pavel Feldman <pfeldman@chromium.org> on 2011-08-03
Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/InspectorClient.h:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::highlight):
* loader/EmptyClients.h:
(WebCore::EmptyInspectorClient::highlight):

Source/WebKit/chromium:

* src/InspectorClientImpl.cpp:
(WebKit::InspectorClientImpl::highlight):
* src/InspectorClientImpl.h:
* src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::highlight):
* src/WebDevToolsAgentImpl.h:

Source/WebKit/efl:

* WebCoreSupport/InspectorClientEfl.cpp:
(WebCore::InspectorClientEfl::highlight):
* WebCoreSupport/InspectorClientEfl.h:

Source/WebKit/gtk:

* WebCoreSupport/InspectorClientGtk.cpp:
(WebKit::InspectorClient::highlight):
* WebCoreSupport/InspectorClientGtk.h:

Source/WebKit/haiku:

* WebCoreSupport/InspectorClientHaiku.cpp:
(WebCore::InspectorClientHaiku::highlight):
* WebCoreSupport/InspectorClientHaiku.h:

Source/WebKit/mac:

* WebCoreSupport/WebInspectorClient.h:
* WebCoreSupport/WebInspectorClient.mm:
(WebInspectorClient::highlight):
* WebInspector/WebNodeHighlighter.h:
* WebInspector/WebNodeHighlighter.mm:
(-[WebNodeHighlighter highlight]):

Source/WebKit/qt:

* WebCoreSupport/InspectorClientQt.cpp:
(WebCore::InspectorClientQt::highlight):
* WebCoreSupport/InspectorClientQt.h:

Source/WebKit/win:

* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::highlight):
* WebCoreSupport/WebInspectorClient.h:

Source/WebKit/wince:

* WebCoreSupport/InspectorClientWinCE.cpp:
(WebKit::InspectorClientWinCE::highlight):
* WebCoreSupport/InspectorClientWinCE.h:

Source/WebKit/wx:

* WebKitSupport/InspectorClientWx.cpp:
(WebCore::InspectorClientWx::highlight):
* WebKitSupport/InspectorClientWx.h:

Source/WebKit2:

* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::highlight):
* WebProcess/WebCoreSupport/WebInspectorClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=65599
antti@apple.com [Wed, 3 Aug 2011 08:20:41 +0000 (08:20 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=65599
Image loads should trigger didFirstVisuallyNonEmptyLayout more easily

Reviewed by Dan Bernstein.

Tweak the heuristic pixel count so logo-sized images trigger didFirstVisuallyNonEmptyLayout.

* page/FrameView.h:
(WebCore::FrameView::incrementVisuallyNonEmptyPixelCount):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Reorganize pkg-config files
carlosgc@webkit.org [Wed, 3 Aug 2011 07:43:44 +0000 (07:43 +0000)]
[GTK] Reorganize pkg-config files
https://bugs.webkit.org/show_bug.cgi?id=65548

Reviewed by Martin Robinson.

.:

* GNUmakefile.am: Initialize pkgconfigdir and pkgconfig_DATA which
are common to all libraries.
* configure.ac: Update pkg-config files.

Source/JavaScriptCore:

* GNUmakefile.am:
* javascriptcoregtk.pc.in: Renamed from Source/WebKit/gtk/javascriptcoregtk.pc.in.

Source/WebKit/gtk:

* GNUmakefile.am: Remove javascriptcore pc file references.

Source/WebKit2:

* GNUmakefile.am: Rename pc file as webkit2gtk.pc.in. WebKit2
depends on gtk3 unconditionally so we don't need to use
WEBKITGTK_PC_NAME.
* webkit2gtk.pc.in: Renamed from Source/WebKit2/gtk/webkit2.pc.in.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebSocket: Could not handle zero length text frame.
commit-queue@webkit.org [Wed, 3 Aug 2011 07:06:56 +0000 (07:06 +0000)]
WebSocket: Could not handle zero length text frame.
https://bugs.webkit.org/show_bug.cgi?id=65592

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-08-03
Reviewed by Kent Tamura.

Source/WebCore:

Test: http/tests/websocket/tests/hybi/zero-length-text.html

* websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::processFrame):

LayoutTests:

* http/tests/websocket/tests/hybi/zero-length-text-expected.txt: Added.
* http/tests/websocket/tests/hybi/zero-length-text.html: Added.
* http/tests/websocket/tests/hybi/zero-length-text_wsh.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash in ResourceResponse::platformCompare() with USE(CFNETWORK)
psolanki@apple.com [Wed, 3 Aug 2011 05:07:51 +0000 (05:07 +0000)]
Crash in ResourceResponse::platformCompare() with USE(CFNETWORK)
https://bugs.webkit.org/show_bug.cgi?id=65584

Reviewed by David Kilzer.

* platform/network/cf/ResourceResponseCFNet.cpp:
(WebCore::ResourceResponse::platformCompare): Don't call CFEqual with 0 as an argument.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebSocket: Should be closed by receiving invalid continuation frame.
commit-queue@webkit.org [Wed, 3 Aug 2011 04:37:51 +0000 (04:37 +0000)]
WebSocket: Should be closed by receiving invalid continuation frame.

https://bugs.webkit.org/show_bug.cgi?id=65527

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-08-02
Reviewed by Kent Tamura.

Source/WebCore:

Test: http/tests/websocket/tests/hybi/invalid-continuation.html

* websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::processFrame):

LayoutTests:

* http/tests/websocket/tests/hybi/invalid-continuation-expected.txt: Added.
* http/tests/websocket/tests/hybi/invalid-continuation.html: Added.
* http/tests/websocket/tests/hybi/invalid-continuation_wsh.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r92256.
commit-queue@webkit.org [Wed, 3 Aug 2011 04:26:52 +0000 (04:26 +0000)]
Unreviewed, rolling out r92256.
http://trac.webkit.org/changeset/92256
https://bugs.webkit.org/show_bug.cgi?id=65593

Causing tons of crashes on the chromium win bots (Requested by
jamesr on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-02

* dom/Event.cpp:
* dom/Event.h:
* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent):
* dom/EventDispatcher.h:
* dom/KeyboardEvent.cpp:
* dom/KeyboardEvent.h:
* dom/MouseEvent.cpp:
* dom/MouseEvent.h:
* dom/Node.cpp:
(WebCore::Node::dispatchEvent):
(WebCore::Node::dispatchKeyEvent):
(WebCore::Node::dispatchMouseEvent):
(WebCore::Node::dispatchWheelEvent):
* dom/WheelEvent.cpp:
* dom/WheelEvent.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMore expectation updates for r92255
jamesr@google.com [Wed, 3 Aug 2011 03:59:03 +0000 (03:59 +0000)]
More expectation updates for r92255

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoExpectation follow-up for r92255
jamesr@google.com [Wed, 3 Aug 2011 03:26:43 +0000 (03:26 +0000)]
Expectation follow-up for r92255

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake EventDispatchMediator RefCounted.
hayato@chromium.org [Wed, 3 Aug 2011 03:25:57 +0000 (03:25 +0000)]
Make EventDispatchMediator RefCounted.
https://bugs.webkit.org/show_bug.cgi?id=65529

Reviewed by Dimitri Glazkov.

Make EventDispatchMediator RefCounted so that it can be enqueued into a
ScopedEventQueue and called later.
A necessary change for ScopedEventQueue should be addressed in another patch.

No changes to functionality so no new tests.

* dom/Event.cpp:
(WebCore::EventDispatchMediator::create):
* dom/Event.h:
* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent):
* dom/EventDispatcher.h:
* dom/KeyboardEvent.cpp:
(WebCore::KeyboardEventDispatchMediator::create):
* dom/KeyboardEvent.h:
* dom/MouseEvent.cpp:
(WebCore::MouseEventDispatchMediator::create):
* dom/MouseEvent.h:
* dom/Node.cpp:
(WebCore::Node::dispatchEvent):
(WebCore::Node::dispatchKeyEvent):
(WebCore::Node::dispatchMouseEvent):
(WebCore::Node::dispatchWheelEvent):
* dom/WheelEvent.cpp:
(WebCore::WheelEventDispatchMediator::create):
* dom/WheelEvent.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: [Chromium] Use edge-distance method for layer anti-aliasing.
jamesr@google.com [Wed, 3 Aug 2011 02:52:17 +0000 (02:52 +0000)]
Source/WebCore: [Chromium] Use edge-distance method for layer anti-aliasing.
https://bugs.webkit.org/show_bug.cgi?id=64942

Patch by David Reveman <reveman@chromium.org> on 2011-08-02
Reviewed by James Robinson.

Use an edge distance based method instead of the current linear
filtering method for producing anti-aliased edges on 3D transformed
layers. This removes the outer border handling from TilingData as
it's no longer needed for anti-aliasing.

Tests: platform/chromium/compositing/tiny-layer-rotated.html (existing)
       platform/chromium/compositing/huge-layer-rotated.html (existing)
       compositing/images/content-image-change.html (existing)
       TilingDataTest in webkit_unit_tests

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::screenMatrix):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::setDrawViewportRect):
(WebCore::LayerRendererChromium::tilerProgramAA):
(WebCore::LayerRendererChromium::tilerProgramSwizzleAA):
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::windowMatrix):
* platform/graphics/chromium/LayerTilerChromium.cpp:
(WebCore::LayerTilerChromium::setTileSize):
(WebCore::LayerTilerChromium::tileLayerRect):
(WebCore::LayerTilerChromium::invalidateRect):
(WebCore::LayerTilerChromium::prepareToUpdate):
(WebCore::LayerTilerChromium::updateRect):
(WebCore::LayerTilerChromium::draw):
(WebCore::LayerTilerChromium::growLayerToContain):
(WebCore::LayerTilerChromium::drawTiles):
* platform/graphics/chromium/LayerTilerChromium.h:
* platform/graphics/chromium/ShaderChromium.cpp:
(WebCore::VertexShaderTile::VertexShaderTile):
(WebCore::VertexShaderTile::init):
(WebCore::VertexShaderTile::getShaderString):
(WebCore::FragmentTexAlphaAABinding::FragmentTexAlphaAABinding):
(WebCore::FragmentTexAlphaAABinding::init):
(WebCore::FragmentShaderRGBATexAlphaAA::getShaderString):
(WebCore::FragmentShaderRGBATexSwizzleAlphaAA::getShaderString):
* platform/graphics/chromium/ShaderChromium.h:
(WebCore::VertexShaderTile::vertexTexTransformLocation):
(WebCore::FragmentTexAlphaAABinding::alphaLocation):
(WebCore::FragmentTexAlphaAABinding::samplerLocation):
(WebCore::FragmentTexAlphaAABinding::fragmentTexTransformLocation):
(WebCore::FragmentTexAlphaAABinding::edgeLocation):
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::TiledLayerChromium):
(WebCore::TiledLayerChromium::updateTileSizeAndTilingOption):
(WebCore::TiledLayerChromium::createTilerIfNeeded):
(WebCore::TiledLayerChromium::setIsMask):
* platform/graphics/chromium/TiledLayerChromium.h:
* platform/graphics/gpu/TilingData.cpp:
(WebCore::computeNumTiles):
(WebCore::TilingData::tileXIndexFromSrcCoord):
(WebCore::TilingData::tileYIndexFromSrcCoord):
(WebCore::TilingData::tileSizeX):
(WebCore::TilingData::tileSizeY):
(WebCore::TilingData::intersectDrawQuad):
(WebCore::TilingData::textureOffset):
* platform/graphics/gpu/TilingData.h:

Source/WebKit/chromium: [Chromium] Remove outer border from TilingData as it's no longer needed by layer compositor for anti-aliasing.
https://bugs.webkit.org/show_bug.cgi?id=64942

Patch by David Reveman <reveman@chromium.org> on 2011-08-02
Reviewed by James Robinson.

* tests/TilingDataTest.cpp:
(WebCore::TEST):

LayoutTests: [Chromium] Use edge-distance method for layer anti-aliasing.
https://bugs.webkit.org/show_bug.cgi?id=64942

Patch by David Reveman <reveman@chromium.org> on 2011-08-02
Reviewed by James Robinson.

Update expected results.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd asserts to RefCounted to make sure ref/deref happens on the right thread.
levin@chromium.org [Wed, 3 Aug 2011 02:28:33 +0000 (02:28 +0000)]
Add asserts to RefCounted to make sure ref/deref happens on the right thread.
https://bugs.webkit.org/show_bug.cgi?id=31639

Reviewed by Dmitry Titov.

Source/JavaScriptCore:

* GNUmakefile.list.am: Added new files to the build.
* JavaScriptCore.gypi: Ditto.
* JavaScriptCore.vcproj/WTF/WTF.vcproj: Ditto.
* JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
* jit/ExecutableAllocator.h:
(JSC::ExecutablePool::ExecutablePool): Turned off checks for this
due to not being able to figure out what was guarding it (bug 58091).
* parser/SourceProvider.h:
(JSC::SourceProvider::SourceProvider): Ditto.
* wtf/CMakeLists.txt: Added new files to the build.
* wtf/ThreadRestrictionVerifier.h: Added.
Everything is done in the header to avoid the issue with exports
that are only useful in debug but still needing to export them.
* wtf/RefCounted.h:
(WTF::RefCountedBase::ref): Added checks using the non thread safe verifier.
and filed bug 58171 about making it stricter.
(WTF::RefCountedBase::hasOneRef): Ditto.
(WTF::RefCountedBase::refCount): Ditto.
(WTF::RefCountedBase::setMutexForVerifier): Expose a way to change the checks to be based
on a mutex. This is in the header to avoid adding more exports from JavaScriptCore.
(WTF::RefCountedBase::deprecatedTurnOffVerifier): Temporary way to turn off verification.
Filed bug 58174 to remove this method.
(WTF::RefCountedBase::derefBase):
* wtf/SizeLimits.cpp: Adjusted the debug size check for RefCounted.
* wtf/text/CString.h:
(WTF::CStringBuffer::CStringBuffer): Turned off checks for this while a fix is being
done in Chromium (bug 58093).

Source/JavaScriptGlue:

* ForwardingHeaders/wtf/ThreadRestrictionVerifier.h: Added.

Source/WebCore:

No new functionality exposed so no new tests. (The change is basically adding
more testing.)

* ForwardingHeaders/wtf/ThreadRestrictionVerifier.h: Added.
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::defaultIcon): Set the mutex which does the guarding of the variable.
(WebCore::IconDatabase::setIconDataForIconURL): Ditto.
(WebCore::IconDatabase::getOrCreateIconRecord): Ditto.
(WebCore::IconDatabase::readFromDatabase): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoClean up value clampling in CSSStyleSelector and CSSPrimitiveValue.
macpherson@chromium.org [Wed, 3 Aug 2011 02:11:09 +0000 (02:11 +0000)]
Clean up value clampling in CSSStyleSelector and CSSPrimitiveValue.
https://bugs.webkit.org/show_bug.cgi?id=65441

Reviewed by Simon Fraser.

No new tests / refactoring only.

* css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::getFloatValue):
Implement in terms of the new templated getValue().
(WebCore::CSSPrimitiveValue::getIntValue):
Implement in terms of the new templated getValue().
(WebCore::CSSPrimitiveValue::getValue):
Templated getValue that works for all numeric types.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Use getValue<short> instead of rolling-your-own clamp to short.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRenderObject::computeRectForRepaint and clippedOverflowRectForRepaint should be const
jchaffraix@webkit.org [Wed, 3 Aug 2011 01:58:06 +0000 (01:58 +0000)]
RenderObject::computeRectForRepaint and clippedOverflowRectForRepaint should be const
https://bugs.webkit.org/show_bug.cgi?id=65494

Reviewed by Darin Adler.

No new tests, const-ness change only.

* rendering/RenderObject.h:
(WebCore::RenderObject::absoluteClippedOverflowRect):
(WebCore::RenderObject::computeAbsoluteRepaintRect):
Made those 2 const as they call a const method now.

* rendering/RenderInline.cpp:
(WebCore::RenderInline::clippedOverflowRectForRepaint): Use a const RenderObject* for iterating as
this is const.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::rectWithOutlineForRepaint):
* rendering/RenderBlock.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::clippedOverflowRectForRepaint):
(WebCore::RenderBox::computeRectForRepaint):
* rendering/RenderBox.h:
* rendering/RenderInline.cpp:
(WebCore::RenderInline::clippedOverflowRectForRepaint):
(WebCore::RenderInline::rectWithOutlineForRepaint):
(WebCore::RenderInline::computeRectForRepaint):
* rendering/RenderInline.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::rectWithOutlineForRepaint):
(WebCore::RenderObject::clippedOverflowRectForRepaint):
(WebCore::RenderObject::computeRectForRepaint):
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::clippedOverflowRectForRepaint):
* rendering/RenderReplaced.h:
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
(WebCore::RenderTableCell::computeRectForRepaint):
* rendering/RenderTableCell.h:
* rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::clippedOverflowRectForRepaint):
* rendering/RenderTableCol.h:
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::clippedOverflowRectForRepaint):
* rendering/RenderTableRow.h:
* rendering/RenderText.cpp:
(WebCore::RenderText::clippedOverflowRectForRepaint):
* rendering/RenderText.h:
* rendering/RenderView.cpp:
(WebCore::RenderView::computeRectForRepaint):
* rendering/RenderView.h:
* rendering/svg/RenderSVGForeignObject.cpp:
(WebCore::RenderSVGForeignObject::clippedOverflowRectForRepaint):
(WebCore::RenderSVGForeignObject::computeRectForRepaint):
* rendering/svg/RenderSVGForeignObject.h:
* rendering/svg/RenderSVGGradientStop.h:
(WebCore::RenderSVGGradientStop::clippedOverflowRectForRepaint):
* rendering/svg/RenderSVGHiddenContainer.h:
(WebCore::RenderSVGHiddenContainer::clippedOverflowRectForRepaint):
* rendering/svg/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::clippedOverflowRectForRepaint):
(WebCore::RenderSVGInline::computeRectForRepaint):
* rendering/svg/RenderSVGInline.h:
* rendering/svg/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::clippedOverflowRectForRepaint):
(WebCore::RenderSVGModelObject::computeRectForRepaint):
* rendering/svg/RenderSVGModelObject.h:
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::clippedOverflowRectForRepaint):
(WebCore::RenderSVGRoot::computeRectForRepaint):
* rendering/svg/RenderSVGRoot.h:
* rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::clippedOverflowRectForRepaint):
(WebCore::RenderSVGText::computeRectForRepaint):
* rendering/svg/RenderSVGText.h:
* rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::clippedOverflowRectForRepaint):
(WebCore::SVGRenderSupport::computeRectForRepaint):
* rendering/svg/SVGRenderSupport.h:
Updated the following method's signature to use a const object.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJSC GC may not be able to reuse partially-free blocks after a
fpizlo@apple.com [Wed, 3 Aug 2011 01:48:13 +0000 (01:48 +0000)]
JSC GC may not be able to reuse partially-free blocks after a
full collection
https://bugs.webkit.org/show_bug.cgi?id=65585

Reviewed by Darin Adler.

This fixes the linked list management bug.  This fix is performance
neutral on SunSpider.

* heap/NewSpace.cpp:
(JSC::NewSpace::removeBlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSimplify JSFunction creation for functions written in JS
oliver@apple.com [Wed, 3 Aug 2011 00:41:11 +0000 (00:41 +0000)]
Simplify JSFunction creation for functions written in JS
https://bugs.webkit.org/show_bug.cgi?id=65422

Reviewed by Gavin Barraclough.

Remove hash lookups used to write name property and transition
function structure by caching the resultant structure and property
offset in JSGlobalObject.  This doesn't impact performance, but
we can use this change to make other improvements later.

* runtime/Executable.cpp:
(JSC::FunctionExecutable::FunctionExecutable):
* runtime/Executable.h:
(JSC::ScriptExecutable::ScriptExecutable):
(JSC::FunctionExecutable::jsName):
* runtime/JSFunction.cpp:
(JSC::JSFunction::JSFunction):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::namedFunctionStructure):
(JSC::JSGlobalObject::functionNameOffset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd namespace prefix support in XML tokenizer
jpfau@apple.com [Wed, 3 Aug 2011 00:04:06 +0000 (00:04 +0000)]
Add namespace prefix support in XML tokenizer
https://bugs.webkit.org/show_bug.cgi?id=65578

Reviewed by Adam Barth.

This also changes markup debug printing to print to stderr instead of stdout

* xml/parser/MarkupTokenBase.h:
(WebCore::MarkupTokenBase::printString):
* xml/parser/XMLToken.h:
(WebCore::XMLToken::XMLDeclarationData::XMLDeclarationData):
(WebCore::XMLToken::clear):
(WebCore::XMLToken::appendToName):
(WebCore::XMLToken::name):
(WebCore::XMLToken::target):
(WebCore::XMLToken::data):
(WebCore::XMLToken::prefix):
(WebCore::XMLToken::xmlDeclarationData):
(WebCore::XMLToken::endPrefix):
(WebCore::XMLToken::hasPrefix):
(WebCore::XMLToken::endAttributePrefix):
(WebCore::XMLToken::attributeHasPrefix):
(WebCore::XMLToken::printAttrs):
(WebCore::XMLToken::print):
* xml/parser/XMLTokenizer.cpp:
(WebCore::XMLTokenizer::nextToken):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r92238.
zmo@google.com [Wed, 3 Aug 2011 00:02:01 +0000 (00:02 +0000)]
Unreviewed, rolling out r92238.
http://trac.webkit.org/changeset/92238
https://bugs.webkit.org/show_bug.cgi?id=65555

fail fast/events/scrollbar-double-click.html on Mac

* platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h:
* platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:
* platform/chromium/ScrollbarThemeChromiumMac.h:
* platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::ScrollbarThemeChromiumMac::registerScrollbar):
(WebCore::ScrollbarThemeChromiumMac::setNewPainterForScrollbar):
(WebCore::toScrollbarPainterKnobStyle):
(WebCore::ScrollbarThemeChromiumMac::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove LegacyDefaultOptionalArguments flag from History.idl
commit-queue@webkit.org [Tue, 2 Aug 2011 23:47:26 +0000 (23:47 +0000)]
Remove LegacyDefaultOptionalArguments flag from History.idl
https://bugs.webkit.org/show_bug.cgi?id=65572

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-02
Reviewed by Adam Barth.

No new tests, all existing tests pass.

* page/History.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove LegacyDefaultOptionalArguments flag from WebKitAnimationList.idl
commit-queue@webkit.org [Tue, 2 Aug 2011 23:41:25 +0000 (23:41 +0000)]
Remove LegacyDefaultOptionalArguments flag from WebKitAnimationList.idl
https://bugs.webkit.org/show_bug.cgi?id=65571

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-02
Reviewed by Adam Barth.

No new tests, all existing tests pass.

* page/WebKitAnimationList.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Decouple layer visibility calculations from render surfaces / computed...
commit-queue@webkit.org [Tue, 2 Aug 2011 23:20:44 +0000 (23:20 +0000)]
[chromium] Decouple layer visibility calculations from render surfaces / computed draw transforms
https://bugs.webkit.org/show_bug.cgi?id=58840

Patch by James Robinson <jamesr@chromium.org> on 2011-08-02
Reviewed by Kenneth Russell.

This decouples the layer visibility related calculations from the LayerChromium and CCLayerImpl trees.  This is
done by making LayerRendererChromium's "calculate the world" function (renamed
calculateDrawTransformsAndVisibility()) a templated, free function that can operate on either LayerChromium +
RenderSurfaceChromium pairs or on CCLayerImpl + CCRenderSurface pairs and invoking it twice, once before
painting and once before drawing.  Before painting, these calculations are used to determine which layers are
potentially visible and should be painted, which depends on the calculated opacity, render surface bounds, and
draw transforms.  Before drawing, these calculations are used to figure out everything needed to draw.

RenderSurfaceChromium is now used just for visibility calculations when painting.  CCRenderSurfaceChromium is
responsible for actually drawing the render surfaces.

This does mean that in the current implementation the second calculations are redundant, but in the future this
won't be the case since the pre-draw time calculations might be influenced by animations or gestures.  I've
added some traces to try to monitor if this math is a significant amount of the per-frame computation.  Note
that layer sorting only happens on the CCLayerImpl tree and the layer sort algorithm is the most expensive part
of the calculations currently.

This removes all of the weak back/forward pointers between LayerChromium and CCLayerImpls, the trees are now
truly decoupled.

Covered by compositing/ tests.

* WebCore.gypi:
* platform/graphics/chromium/CanvasLayerChromium.cpp:
(WebCore::CanvasLayerChromium::createCCLayerImpl):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::~LayerChromium):
(WebCore::LayerChromium::createCCLayerImpl):
(WebCore::LayerChromium::createRenderSurface):
(WebCore::LayerChromium::descendantsDrawsContent):
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::setUsesLayerScissor):
(WebCore::LayerChromium::usesLayerScissor):
(WebCore::LayerChromium::clearRenderSurface):
(WebCore::LayerChromium::renderSurface):
(WebCore::LayerChromium::drawOpacity):
(WebCore::LayerChromium::setDrawOpacity):
(WebCore::LayerChromium::scissorRect):
(WebCore::LayerChromium::setScissorRect):
(WebCore::LayerChromium::targetRenderSurface):
(WebCore::LayerChromium::setTargetRenderSurface):
(WebCore::LayerChromium::drawTransform):
(WebCore::LayerChromium::setDrawTransform):
(WebCore::LayerChromium::drawableContentRect):
(WebCore::LayerChromium::setDrawableContentRect):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::paintLayerContents):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::updateCompositorResources):
(WebCore::LayerRendererChromium::setCompositeOffscreen):
(WebCore::LayerRendererChromium::getOffscreenLayerTexture):
(WebCore::LayerRendererChromium::useRenderSurface):
(WebCore::LayerRendererChromium::drawLayer):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::renderSurfaceProgram):
(WebCore::LayerRendererChromium::renderSurfaceMaskProgram):
(WebCore::LayerRendererChromium::dumpRenderSurfaces):
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/graphics/chromium/PluginLayerChromium.cpp:
(WebCore::PluginLayerChromium::createCCLayerImpl):
* platform/graphics/chromium/RenderSurfaceChromium.cpp:
(WebCore::RenderSurfaceChromium::RenderSurfaceChromium):
(WebCore::RenderSurfaceChromium::~RenderSurfaceChromium):
* platform/graphics/chromium/RenderSurfaceChromium.h:
(WebCore::RenderSurfaceChromium::clearLayerList):
(WebCore::RenderSurfaceChromium::layerList):
(WebCore::RenderSurfaceChromium::setMaskLayer):
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::createCCLayerImpl):
(WebCore::TiledLayerChromium::tilingTransform):
* platform/graphics/chromium/TreeSynchronizer.cpp:
(WebCore::TreeSynchronizer::synchronizeTreeRecursive):
* platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::createCCLayerImpl):
* platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:
(WebCore::CCCanvasLayerImpl::CCCanvasLayerImpl):
* platform/graphics/chromium/cc/CCCanvasLayerImpl.h:
(WebCore::CCCanvasLayerImpl::create):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::~CCLayerImpl):
(WebCore::CCLayerImpl::createRenderSurface):
(WebCore::CCLayerImpl::bindContentsTexture):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::create):
(WebCore::CCLayerImpl::renderSurface):
(WebCore::CCLayerImpl::targetRenderSurface):
(WebCore::CCLayerImpl::setTargetRenderSurface):
* platform/graphics/chromium/cc/CCLayerSorter.cpp:
(WebCore::CCLayerSorter::createGraphNodes):
* platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:
(WebCore::CCPluginLayerImpl::CCPluginLayerImpl):
* platform/graphics/chromium/cc/CCPluginLayerImpl.h:
(WebCore::CCPluginLayerImpl::create):
* platform/graphics/chromium/cc/CCRenderSurface.cpp: Copied from Source/WebCore/platform/graphics/chromium/RenderSurfaceChromium.cpp.
(WebCore::CCRenderSurface::CCRenderSurface):
(WebCore::CCRenderSurface::~CCRenderSurface):
(WebCore::CCRenderSurface::cleanupResources):
(WebCore::CCRenderSurface::layerRenderer):
(WebCore::CCRenderSurface::drawableContentRect):
(WebCore::CCRenderSurface::prepareContentsTexture):
(WebCore::CCRenderSurface::releaseContentsTexture):
(WebCore::CCRenderSurface::drawSurface):
(WebCore::CCRenderSurface::draw):
(WebCore::CCRenderSurface::name):
(WebCore::writeIndent):
(WebCore::CCRenderSurface::dumpSurface):
(WebCore::CCRenderSurface::owningLayerId):
* platform/graphics/chromium/cc/CCRenderSurface.h: Copied from Source/WebCore/platform/graphics/chromium/RenderSurfaceChromium.h.
(WebCore::CCRenderSurface::contentRectCenter):
(WebCore::CCRenderSurface::drawOpacity):
(WebCore::CCRenderSurface::setDrawOpacity):
(WebCore::CCRenderSurface::setDrawTransform):
(WebCore::CCRenderSurface::drawTransform):
(WebCore::CCRenderSurface::setReplicaDrawTransform):
(WebCore::CCRenderSurface::replicaDrawTransform):
(WebCore::CCRenderSurface::setOriginTransform):
(WebCore::CCRenderSurface::originTransform):
(WebCore::CCRenderSurface::setScissorRect):
(WebCore::CCRenderSurface::scissorRect):
(WebCore::CCRenderSurface::setContentRect):
(WebCore::CCRenderSurface::contentRect):
(WebCore::CCRenderSurface::setSkipsDraw):
(WebCore::CCRenderSurface::skipsDraw):
(WebCore::CCRenderSurface::clearLayerList):
(WebCore::CCRenderSurface::layerList):
(WebCore::CCRenderSurface::setMaskLayer):
(WebCore::CCRenderSurface::contentsTexture):
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::CCTiledLayerImpl):
* platform/graphics/chromium/cc/CCTiledLayerImpl.h:
(WebCore::CCTiledLayerImpl::create):
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::CCVideoLayerImpl):
* platform/graphics/chromium/cc/CCVideoLayerImpl.h:
(WebCore::CCVideoLayerImpl::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd mac-lion platform to old-run-webkit-tests
andersca@apple.com [Tue, 2 Aug 2011 23:18:54 +0000 (23:18 +0000)]
Add mac-lion platform to old-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=65577

* Scripts/old-run-webkit-tests:
* Scripts/webkitdirs.pm:
(isLion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement CSSPropertyWebkitTextCombine, CSSPropertyWebkitTextEmphasisPosition and...
macpherson@chromium.org [Tue, 2 Aug 2011 23:15:27 +0000 (23:15 +0000)]
Implement CSSPropertyWebkitTextCombine, CSSPropertyWebkitTextEmphasisPosition and CSSPropertyWebkitTextEmphasisStyle in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=65517

Reviewed by Dimitri Glazkov.

No new tests. Just refactoring and moving code around.

* css/CSSStyleApplyProperty.cpp:
Added class ApplyPropertyTextEmphasisStyle to handle the special TextEmphasisStyle logic.
(WebCore::ApplyPropertyTextEmphasisStyle::applyInheritValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInitialValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
Added initializations for CSSPropertyWebkitTextCombine, CSSPropertyWebkitTextEmphasisPosition, CSSPropertyWebkitTextEmphasisStyle.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Remove existing implementations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove LegacyDefaultOptionalArguments flag from SpeechInputResultList.idl
commit-queue@webkit.org [Tue, 2 Aug 2011 22:47:08 +0000 (22:47 +0000)]
Remove LegacyDefaultOptionalArguments flag from SpeechInputResultList.idl
https://bugs.webkit.org/show_bug.cgi?id=65570

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-02
Reviewed by Adam Barth.

No new tests, all existing tests pass

* page/SpeechInputResultList.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove LegacyDefaultOptionalArguments flag from EventSource.idl
commit-queue@webkit.org [Tue, 2 Aug 2011 22:41:55 +0000 (22:41 +0000)]
Remove LegacyDefaultOptionalArguments flag from EventSource.idl
https://bugs.webkit.org/show_bug.cgi?id=65568

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-02
Reviewed by Adam Barth.

No new tests, all existing tests pass.

* page/EventSource.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMissing null check in WebViewImpl::selectionRange
commit-queue@webkit.org [Tue, 2 Aug 2011 22:19:25 +0000 (22:19 +0000)]
Missing null check in WebViewImpl::selectionRange
https://bugs.webkit.org/show_bug.cgi?id=65561

Patch by Varun Jain <varunjain@google.com> on 2011-08-02
Reviewed by Darin Fisher.

*  Source/WebKit/chromium/src/WebViewImpl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agofail earlier to track down null CachedScript execution
gavinp@chromium.org [Tue, 2 Aug 2011 22:17:51 +0000 (22:17 +0000)]
fail earlier to track down null CachedScript execution
https://bugs.webkit.org/show_bug.cgi?id=65563

Over in http://code.google.com/p/chromium/issues/detail?id=75604 I can't reproduce the problem.  Careful reading of the code hasn't led me
to an obvious cause either.  This patch should cause failure earlier, and lead to better stacks.  I'll watch Chrome Canary's crash
uploads carefully, and remove this CRASH() (and fix the underlying problem) once I understand it.

Reviewed by Alexey Proskuryakov.

No new tests, as my goal here is to get telemetry on a bug that I cannot reproduce.

* dom/ScriptRunner.cpp:
(WebCore::ScriptRunner::queueScriptForExecution):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChromium: Update forked ScrollbarThemeChromiumMac.mm
commit-queue@webkit.org [Tue, 2 Aug 2011 22:11:30 +0000 (22:11 +0000)]
Chromium: Update forked ScrollbarThemeChromiumMac.mm
https://bugs.webkit.org/show_bug.cgi?id=65555

Merge recent changes to ScrollbarThemeMac.mm to ScrollbarThemeChromiumMac.mm.

Patch by Sailesh Agrawal <sail@chromium.org> on 2011-08-02
Reviewed by James Robinson.

* platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h:
* platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:
(wkScrollbarPainterSetEnabled):
* platform/chromium/ScrollbarThemeChromiumMac.h:
(WebCore::ScrollbarThemeChromiumMac::maxOverlapBetweenPages):
* platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::ScrollbarThemeChromiumMac::registerScrollbar):
(WebCore::ScrollbarThemeChromiumMac::setNewPainterForScrollbar):
(WebCore::toScrollbarPainterKnobStyle):
(WebCore::ScrollbarThemeChromiumMac::updateScrollbarOverlayStyle):
(WebCore::ScrollbarThemeChromiumMac::updateEnabledState):
(WebCore::ScrollbarThemeChromiumMac::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove LegacyDefaultOptionalArguments flag from SVG IDL files
commit-queue@webkit.org [Tue, 2 Aug 2011 21:36:52 +0000 (21:36 +0000)]
Remove LegacyDefaultOptionalArguments flag from SVG IDL files
https://bugs.webkit.org/show_bug.cgi?id=65337

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-02
Reviewed by Nikolas Zimmermann.

No new tests, all existing tests pass.

* svg/ElementTimeControl.idl:
* svg/SVGAnimationElement.idl:
* svg/SVGDocument.idl:
* svg/SVGElementInstance.idl:
* svg/SVGElementInstanceList.idl:
* svg/SVGException.idl:
* svg/SVGFEDropShadowElement.idl:
* svg/SVGFEGaussianBlurElement.idl:
* svg/SVGFEMorphologyElement.idl:
* svg/SVGFilterElement.idl:
* svg/SVGLocatable.idl:
* svg/SVGMarkerElement.idl:
* svg/SVGPathElement.idl:
* svg/SVGSVGElement.idl:
* svg/SVGStylable.idl:
* svg/SVGStyleElement.idl:
* svg/SVGTests.idl:
* svg/SVGTextContentElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove LegacyDefaultOptionalArguments flag from CSS IDL files
commit-queue@webkit.org [Tue, 2 Aug 2011 21:35:15 +0000 (21:35 +0000)]
Remove LegacyDefaultOptionalArguments flag from CSS IDL files
https://bugs.webkit.org/show_bug.cgi?id=65341

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-02
Reviewed by Adam Barth.

No new tests. All existing tests pass.

* css/CSSMediaRule.idl:
* css/CSSPrimitiveValue.idl:
* css/CSSRuleList.idl:
* css/CSSStyleDeclaration.idl:
* css/CSSStyleSheet.idl:
* css/CSSValueList.idl:
* css/MediaList.idl:
* css/MediaQueryList.idl:
* css/MediaQueryListListener.idl:
* css/StyleMedia.idl:
* css/StyleSheetList.idl:
* css/WebKitCSSKeyframesRule.idl:
* css/WebKitCSSMatrix.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, test expectations update, gardener stuff.
zmo@google.com [Tue, 2 Aug 2011 21:33:48 +0000 (21:33 +0000)]
Unreviewed, test expectations update, gardener stuff.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Layering violations in gesture recognizer
commit-queue@webkit.org [Tue, 2 Aug 2011 21:26:02 +0000 (21:26 +0000)]
[chromium] Layering violations in gesture recognizer
https://bugs.webkit.org/show_bug.cgi?id=65044

Source/WebCore:

Patch by Robert Kroeger <rjkroege@chromium.org> on 2011-08-02
Reviewed by Adam Barth.

Divided the gesture recognizer up to correct a layering
violation by moving gesture implementation from it to
EventHandler::handleGestureEvent so that the gesture recognizer
could simply be an engine for generating gesture events from
touch events.

* dom/WheelEvent.cpp:
(WebCore::WheelEvent::WheelEvent):
(WebCore::WheelEvent::initWheelEvent):
* dom/WheelEvent.h:
Added symbolic contstant for tick multiplier.
* page/EventHandler.cpp:
(WebCore::EventHandler::EventHandler):
Removed construction of gesture recognizer.
(WebCore::EventHandler::handleGestureEvent):
Extended for new gesture events added in this patch.
(WebCore::EventHandler::handleTouchEvent):
Removed call into gesture recognizer.
* page/EventHandler.h:
* page/FrameView.cpp:
(WebCore::FrameView::reset):
Removed code to reset gesture recognizer.
* platform/PlatformGestureEvent.h:
(WebCore::PlatformGestureEvent::PlatformGestureEvent):
(WebCore::PlatformGestureEvent::deltaX):
(WebCore::PlatformGestureEvent::deltaY):
(WebCore::PlatformGestureEvent::shiftKey):
(WebCore::PlatformGestureEvent::ctrlKey):
(WebCore::PlatformGestureEvent::altKey):
(WebCore::PlatformGestureEvent::metaKey):
Added additional gesture types and parameters.
* platform/PlatformGestureRecognizer.h:
* platform/chromium/FramelessScrollView.h:
Added support for displatching gesture and touch events.
* platform/chromium/GestureRecognizerChromium.cpp:
(WebCore::InnerGestureRecognizer::InnerGestureRecognizer):
(WebCore::InnerGestureRecognizer::reset):
(WebCore::InnerGestureRecognizer::constructClickGestureEvent):
(WebCore::InnerGestureRecognizer::processTouchEventForGestures):
Removed all depedencies on EventHandler. Instead, create gesture
events from touch event stream.
(WebCore::InnerGestureRecognizer::constructScrollGesture):
(WebCore::touchDown):
(WebCore::noGesture):
(WebCore::click):
(WebCore::isClickOrScroll):
(WebCore::inScroll):
(WebCore::GestureRecognizerChromium::processTouchEventForGestures):
(WebCore::GestureRecognizerChromium::reset):
* platform/chromium/GestureRecognizerChromium.h:
* platform/chromium/PopupMenuChromium.cpp:
Added support to handle touch events and gesture events.
(WebCore::PopupContainer::handleTouchEvent):
(WebCore::PopupContainer::handleGestureEvent):
(WebCore::PopupListBox::handleTouchEvent):
(WebCore::PopupListBox::handleGestureEvent):
* platform/chromium/PopupMenuChromium.h:
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::handleGestureEvent):
Ignores the newly added gesture event types.

Source/WebKit/chromium:

       Reviewed by Adam Barth.

Moved gesture recognition higher up the event delivery code
path so that recognition of gestures is completely separated
from gesture handling.

Patch by Robert Kroeger <rjkroege@chromium.org> on 2011-08-02

* features.gypi:
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::createFrameView):
Added code to reset the gesture recognizer to preserve parallel
layout test execution.
* src/WebPopupMenuImpl.cpp:
Support dispatching touch and gesture events to Popups.
(WebKit::WebPopupMenuImpl::WebPopupMenuImpl):
(WebKit::WebPopupMenuImpl::TouchEvent):
(WebKit::WebPopupMenuImpl::handleInputEvent):
* src/WebPopupMenuImpl.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
Added gesture recognition creation.
(WebKit::WebViewImpl::touchEvent):
Added recognition of gestures and dispatch of gesture events.
(WebKit::WebViewImpl::resetGestureRecognizer):
* src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJSC GC uses dummy cells to avoid having to remember which cells
fpizlo@apple.com [Tue, 2 Aug 2011 21:22:34 +0000 (21:22 +0000)]
JSC GC uses dummy cells to avoid having to remember which cells
it has already destroyed
https://bugs.webkit.org/show_bug.cgi?id=65556

Reviewed by Oliver Hunt.

This gets rid of dummy cells, and ensures that it's not necessary
to invoke a destructor on cells that have already been swept.  In
the common case, a block knows that either all of its free cells
still need to have destructors called, or none of them do, which
minimizes the amount of branching that needs to happen per cell
when performing a sweep.

This is performance neutral on SunSpider and V8.  It is meant as
a stepping stone to simplify the implementation of more
sophisticated sweeping algorithms.

* heap/Heap.cpp:
(JSC::CountFunctor::ClearMarks::operator()):
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::initForCellSize):
(JSC::MarkedBlock::callDestructor):
(JSC::MarkedBlock::specializedReset):
(JSC::MarkedBlock::reset):
(JSC::MarkedBlock::specializedSweep):
(JSC::MarkedBlock::sweep):
(JSC::MarkedBlock::produceFreeList):
(JSC::MarkedBlock::lazySweep):
(JSC::MarkedBlock::blessNewBlockForFastPath):
(JSC::MarkedBlock::blessNewBlockForSlowPath):
(JSC::MarkedBlock::canonicalizeBlock):
* heap/MarkedBlock.h:
(JSC::MarkedBlock::FreeCell::setNoObject):
(JSC::MarkedBlock::setDestructorState):
(JSC::MarkedBlock::destructorState):
(JSC::MarkedBlock::notifyMayHaveFreshFreeCells):
* runtime/JSCell.cpp:
* runtime/JSCell.h:
(JSC::JSCell::JSCell::JSCell):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::clearBuiltinStructures):
* runtime/JSGlobalData.h:
* runtime/Structure.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd scrollbars/scrollbar-drag-thumb-with-large-content.html to the Skipped list.
andersca@apple.com [Tue, 2 Aug 2011 21:22:22 +0000 (21:22 +0000)]
Add scrollbars/scrollbar-drag-thumb-with-large-content.html to the Skipped list.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoVirtual copying of FastMalloc allocated memory causes madvise MADV_FREE_REUSABLE...
msaboff@apple.com [Tue, 2 Aug 2011 21:19:05 +0000 (21:19 +0000)]
Virtual copying of FastMalloc allocated memory causes madvise MADV_FREE_REUSABLE errors
https://bugs.webkit.org/show_bug.cgi?id=65502

Reviewed by Anders Carlsson.

Source/JavaScriptCore:

With the fix of the issues causing madvise MADV_FREE_REUSABLE to fail,
added an assert to the return code of madvise to catch any regressions.

* wtf/TCSystemAlloc.cpp:
(TCMalloc_SystemRelease):

Source/WebCore:

Change the vm_copy in PurgeableBuffer::create to be a memcpy.  The
vm_copy causes the process to have additional references to the same
memory region.  These additional reference caused madvise(MADV_FREE_REUSABLE)
to fail when it encountered such pages.

No tests added this is a resource defect and not a functional issue.

* platform/mac/PurgeableBufferMac.cpp:
(WebCore::PurgeableBuffer::create):

Source/WebKit2:

Changed OOL message to use MACH_MSG_PHYSICAL_COPY flag instead of virtual flag
so that the original memory region isn't referenced by the message and ultimately
the receiving process.  The additional reference caused madvise(MADV_FREE_REUSABLE)
to fail when it encountered such pages.

* Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::Connection::sendOutgoingMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Windows build.
andersca@apple.com [Tue, 2 Aug 2011 21:13:05 +0000 (21:13 +0000)]
Fix Windows build.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, test expectations update, gardener stuff.
zmo@google.com [Tue, 2 Aug 2011 21:08:18 +0000 (21:08 +0000)]
Unreviewed, test expectations update, gardener stuff.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReviewed by Sam Weinig.
andersca@apple.com [Tue, 2 Aug 2011 21:06:38 +0000 (21:06 +0000)]
Reviewed by Sam Weinig.

* fast/blockflow/japanese-rl-text-with-broken-font.html:
This test would create an empty RenderText after the change to make it asynchronous.
Fix this by putting the script inside the head.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Remove an unnecessary readback during accelerated
senorblanco@chromium.org [Tue, 2 Aug 2011 21:06:10 +0000 (21:06 +0000)]
[Chromium] Remove an unnecessary readback during accelerated
canvas-to-canvas draws.
https://bugs.webkit.org/show_bug.cgi?id=65560

Reviewed by James Robinson.

No new tests.  (Printing has few tests, sadly.)

* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::draw):
Revert most of the changes to this file from
http://trac.webkit.org/changeset/91870, except for the call which makes
the source context current, so that the readPixels() still works.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix a Windows build error.
andersca@apple.com [Tue, 2 Aug 2011 20:52:12 +0000 (20:52 +0000)]
Fix a Windows build error.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, mark SelectPopupMenuTest.SelectItemKeyEvent as flaky, gardener stuff.
zmo@google.com [Tue, 2 Aug 2011 20:47:40 +0000 (20:47 +0000)]
Unreviewed, mark SelectPopupMenuTest.SelectItemKeyEvent as flaky, gardener stuff.

* tests/PopupMenuTest.cpp:
(WebKit::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJSC GC is far too conservative about growing the heap size, particularly
fpizlo@apple.com [Tue, 2 Aug 2011 20:40:17 +0000 (20:40 +0000)]
JSC GC is far too conservative about growing the heap size, particularly
on desktop platforms
https://bugs.webkit.org/show_bug.cgi?id=65438

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

The minimum heap size is now 16MB instead of 512KB, provided all of the
following are true:
a) ENABLE(LARGE_HEAP) is set, which currently only happens on
   x86 targets, but could reasonably happen on any platform that is
   known to have a decent amount of RAM.
b) JSGlobalData is initialized with HeapSize = LargeHeap, which
   currently only happens when it's the JSDOMWindowBase in WebCore or
   in the jsc command-line tool.

This is a 4.1% speed-up on SunSpider.

* JavaScriptCore.exp:
* heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::collect):
* heap/Heap.h:
* jsc.cpp:
(main):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::createContextGroup):
(JSC::JSGlobalData::create):
(JSC::JSGlobalData::createLeaked):
(JSC::JSGlobalData::sharedInstance):
* runtime/JSGlobalData.h:
* wtf/Platform.h:

Source/WebCore:

No change in behavior, thus no new tests.

Pass the LargeHeap hint to JSGlobalData when creating the JSC runtime
instance corresponding to non-worker JS code.

* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::commonJSGlobalData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago--webkit-visual-word: ctrl-arrow is not able to reach the boundary of line
commit-queue@webkit.org [Tue, 2 Aug 2011 20:38:04 +0000 (20:38 +0000)]
--webkit-visual-word: ctrl-arrow is not able to reach the boundary of line
https://bugs.webkit.org/show_bug.cgi?id=61346

Patch by Van Lam <vanlam@google.com> on 2011-08-02
Reviewed by Ryosuke Niwa.

Source/WebCore:

When collecintg word boundaries in a box, explicitly check if the box
is at the end of line (so it should contain the end-of-line position)
and collect the end-of-line position.

* editing/visible_units.cpp:
(WebCore::isBoxVisuallyLastInLine):
(WebCore::appendPositionAtLogicalEndOfLine):
(WebCore::collectWordBreaksInBoxInsideBlockWithSameDirectionality):
(WebCore::collectWordBreaksInBoxInsideBlockWithDifferntDirectionality):

LayoutTests:

Updated test cases to check for visual word movement to the end-of-line
position.

* editing/selection/move-by-word-visually-multi-line-expected.txt:
* editing/selection/move-by-word-visually-multi-line.html:
* editing/selection/move-by-word-visually-multi-space-expected.txt:
* editing/selection/move-by-word-visually-multi-space.html:
* editing/selection/move-by-word-visually-single-space-inline-element-expected.txt:
* editing/selection/move-by-word-visually-single-space-inline-element.html:
* editing/selection/move-by-word-visually-single-space-one-element-expected.txt:
* editing/selection/move-by-word-visually-single-space-one-element.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, test expectations update, gardener stuff.
zmo@google.com [Tue, 2 Aug 2011 20:31:29 +0000 (20:31 +0000)]
Unreviewed, test expectations update, gardener stuff.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Should save scroll positions for network panel Response and Preview...
vsevik@chromium.org [Tue, 2 Aug 2011 20:12:07 +0000 (20:12 +0000)]
Web Inspector: Should save scroll positions for network panel Response and Preview tabs.
https://bugs.webkit.org/show_bug.cgi?id=65557

Reviewed by Pavel Feldman.

* inspector/front-end/NetworkItemView.js:
(WebInspector.ResourceContentView.prototype.get innerView):
(WebInspector.ResourceContentView.prototype.set innerView):
(WebInspector.ResourceContentView.prototype.hide):
* inspector/front-end/ResourcePreviewView.js:
(WebInspector.ResourcePreviewView.prototype.contentLoaded):
* inspector/front-end/ResourceResponseView.js:
(WebInspector.ResourceResponseView.prototype.contentLoaded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuildbot: The Properties object has no "hasProperty" method in buildbot 8.3
commit-queue@webkit.org [Tue, 2 Aug 2011 20:06:53 +0000 (20:06 +0000)]
Buildbot: The Properties object has no "hasProperty" method in buildbot 8.3
https://bugs.webkit.org/show_bug.cgi?id=65554

Using "has_key" instead of "hasProperty" in order to support buildbot 8.3.

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-02
Reviewed by Adam Roben.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTools: Implement WebPermissionClient::allowPlugins for layout tests
jochen@chromium.org [Tue, 2 Aug 2011 20:00:46 +0000 (20:00 +0000)]
Tools: Implement WebPermissionClient::allowPlugins for layout tests
https://bugs.webkit.org/show_bug.cgi?id=33991

Reviewed by Adam Barth.

* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::setPluginsAllowed):
* DumpRenderTree/chromium/LayoutTestController.h:
* DumpRenderTree/chromium/WebPermissions.cpp:
(WebPermissions::allowPlugins):
(WebPermissions::setPluginsAllowed):
(WebPermissions::reset):
* DumpRenderTree/chromium/WebPermissions.h:

LayoutTests: Add a test for FrameLoaderClient::allowPlugins
https://bugs.webkit.org/show_bug.cgi?id=33991

Reviewed by Adam Barth.

* platform/chromium/permissionclient/plugin-permission-expected.txt: Added.
* platform/chromium/permissionclient/plugin-permission.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTestFailures unit tests leak a global variable
abarth@webkit.org [Tue, 2 Aug 2011 19:57:38 +0000 (19:57 +0000)]
TestFailures unit tests leak a global variable
https://bugs.webkit.org/show_bug.cgi?id=65500

Reviewed by Adam Roben.

qunit detects the leak if you check the "noglobals" box on run-unittests.html.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJSC does a GC even when the heap still has free pages
fpizlo@apple.com [Tue, 2 Aug 2011 19:57:06 +0000 (19:57 +0000)]
JSC does a GC even when the heap still has free pages
https://bugs.webkit.org/show_bug.cgi?id=65445

Reviewed by Oliver Hunt.

If the high watermark is not reached, then we allocate new blocks as
before.  If the current watermark does reach (or exceed) the high
watermark, then we check if there is a block on the free block pool.
If there is, we simply allocation from it.  If there isn't, we
invoke a collectin as before.  This effectively couples the elastic
scavenging to the collector's decision function.  That is, if an
application rapidly varies its heap usage (sometimes using more and
sometimes less) then the collector will not thrash as it used to.
But if heap usage drops and stays low then the scavenger thread and
the GC will eventually reach a kind of consensus: the GC will set
the watermark low because of low heap usage, and the scavenger thread
will steadily eliminate pages from the free page pool, until the size
of the free pool is below the high watermark.

On command-line, this is neutral on SunSpider and Kraken and a 3% win
on V8.  In browser, this is a 1% win on V8 and neutral on the other
two.

* heap/Heap.cpp:
(JSC::Heap::allocateSlowCase):
(JSC::Heap::allocateBlock):
* heap/Heap.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Ignore empty requests on policy decisions.
commit-queue@webkit.org [Tue, 2 Aug 2011 19:50:06 +0000 (19:50 +0000)]
[EFL] Ignore empty requests on policy decisions.
https://bugs.webkit.org/show_bug.cgi?id=64536

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-02
Reviewed by Kenneth Rohde Christiansen.

This is the same fix introduced in the GTK+ port in r41313: empty
request should be ignored, so tests such as
fast/loader/empty-embed-src-attribute.html do not crash.

* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForResponse):
(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNewWindowAction):
(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNavigationAction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rebaseline, gardener stuff.
zmo@google.com [Tue, 2 Aug 2011 19:15:04 +0000 (19:15 +0000)]
Unreviewed, rebaseline, gardener stuff.

* platform/chromium-win-xp/fast/text/international/bidi-mirror-he-ar-expected.png:
* platform/chromium-win-xp/fast/text/justify-ideograph-leading-expansion-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Remove initator column for JSC, fix network resource initiator tests.
vsevik@chromium.org [Tue, 2 Aug 2011 18:41:36 +0000 (18:41 +0000)]
Web Inspector: Remove initator column for JSC, fix network resource initiator tests.
https://bugs.webkit.org/show_bug.cgi?id=65534

Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._createTable):
(WebInspector.NetworkLogView.prototype.switchToDetailedView):
(WebInspector.NetworkLogView.prototype.switchToBriefView):
(WebInspector.NetworkLogView.prototype._toggleGridMode):
(WebInspector.NetworkLogView.prototype._toggleViewingResourceMode):
(WebInspector.NetworkDataGridNode.prototype.createCells):
(WebInspector.NetworkDataGridNode.prototype.refreshResource):
* inspector/front-end/Settings.js:

Source/WebKit/chromium:

* src/js/DevTools.js:
():

LayoutTests:

* http/tests/inspector/network/network-initiator-expected.txt:
* http/tests/inspector/network/network-initiator.html:
* platform/chromium/http/tests/inspector/network/network-initiator-expected.txt: Copied from LayoutTests/http/tests/inspector/network/network-initiator-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: SourceFrame should store saved scroll positions in View.
vsevik@chromium.org [Tue, 2 Aug 2011 18:32:46 +0000 (18:32 +0000)]
Web Inspector: SourceFrame should store saved scroll positions in View.
https://bugs.webkit.org/show_bug.cgi?id=65472

Reviewed by Pavel Feldman.

* inspector/front-end/ResourcesPanel.js:
(WebInspector.FrameResourceTreeElement.prototype._recreateSourceView):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._sourceFileChanged):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.show):
(WebInspector.SourceFrame.prototype.hide):
(WebInspector.SourceFrame.prototype.get scrollLeft):
(WebInspector.SourceFrame.prototype.set scrollLeft):
(WebInspector.SourceFrame.prototype.get scrollTop):
(WebInspector.SourceFrame.prototype.set scrollTop):
* inspector/front-end/View.js:
(WebInspector.View.prototype._innerShow):
(WebInspector.View.prototype._innerHide):
(WebInspector.View.prototype.detach):
(WebInspector.View.prototype.storeScrollPositions):
(WebInspector.View.prototype.inheritScrollPositionsFromView):
(WebInspector.View.prototype.restoreScrollPositions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, test expectation updates, gardener stuff.
zmo@google.com [Tue, 2 Aug 2011 18:32:12 +0000 (18:32 +0000)]
Unreviewed, test expectation updates, gardener stuff.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove WTF_USE_AVFOUNDATION from JavaScriptCore/wtf/platform.h to WebCore/config.h
jeffm@apple.com [Tue, 2 Aug 2011 18:29:59 +0000 (18:29 +0000)]
Move WTF_USE_AVFOUNDATION from JavaScriptCore/wtf/platform.h to WebCore/config.h
https://bugs.webkit.org/show_bug.cgi?id=65552

Since this is a WebCore feature, there's no need to define it in JavaScriptCore/wtf/platform.h.

Reviewed by Adam Roben.

Source/JavaScriptCore:

* wtf/Platform.h: Removed WTF_USE_AVFOUNDATION.

Source/WebCore:

No change in functionality, so new tests.

* config.h: Added WTF_USE_AVFOUNDATION.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd Snow Leopard specific test results.
andersca@apple.com [Tue, 2 Aug 2011 18:29:24 +0000 (18:29 +0000)]
Add Snow Leopard specific test results.

* platform/mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.txt: Added.
* platform/mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.txt: Added.
* platform/mac-snowleopard/fast/forms/textarea-placeholder-visibility-1-expected.txt: Added.
* platform/mac-snowleopard/fast/forms/textarea-placeholder-visibility-2-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove time out expectation since media/track has been added to the skipped list...
rniwa@webkit.org [Tue, 2 Aug 2011 18:26:29 +0000 (18:26 +0000)]
Remove time out expectation since media/track has been added to the skipped list on GTK.

* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSplit RenderBlock::layoutRunsAndFloats into multiple methods
commit-queue@webkit.org [Tue, 2 Aug 2011 18:07:32 +0000 (18:07 +0000)]
Split RenderBlock::layoutRunsAndFloats into multiple methods
https://bugs.webkit.org/show_bug.cgi?id=65376

Extracted layoutRunsAndFloatsInRange, linkToEndLineIfNeeded and repaintDirtyFloats methods and moved
most of the locals to LineLayoutState.

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-02
Reviewed by David Hyatt.

No new tests needed because it is just refactoring existing code.

* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::LineLayoutState::LineLayoutState):
(WebCore::LineLayoutState::endLineMatched):
(WebCore::LineLayoutState::setEndLineMatched):
(WebCore::LineLayoutState::checkForFloatsFromLastLine):
(WebCore::LineLayoutState::setCheckForFloatsFromLastLine):
(WebCore::LineLayoutState::lineInfo):
(WebCore::LineLayoutState::endLineLogicalTop):
(WebCore::LineLayoutState::setEndLineLogicalTop):
(WebCore::LineLayoutState::endLine):
(WebCore::LineLayoutState::setEndLine):
(WebCore::LineLayoutState::lastFloat):
(WebCore::LineLayoutState::setLastFloat):
(WebCore::LineLayoutState::floats):
(WebCore::LineLayoutState::floatIndex):
(WebCore::LineLayoutState::setFloatIndex):
(WebCore::RenderBlock::layoutRunsAndFloats):
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::linkToEndLineIfNeeded):
(WebCore::RenderBlock::repaintDirtyFloats):
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::determineStartPosition):
(WebCore::RenderBlock::determineEndPosition):
(WebCore::RenderBlock::matchedEndLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Remove resizeOnscreenContent from LRC. It can be derived.
nduca@chromium.org [Tue, 2 Aug 2011 17:53:44 +0000 (17:53 +0000)]
[chromium] Remove resizeOnscreenContent from LRC. It can be derived.
https://bugs.webkit.org/show_bug.cgi?id=65519

Reviewed by James Robinson.

Source/WebCore:

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::setViewport):
* platform/graphics/chromium/LayerRendererChromium.h:

Source/WebKit/chromium:

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::resize):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Remove expectations for no longer crashing tests.
enne@google.com [Tue, 2 Aug 2011 17:37:47 +0000 (17:37 +0000)]
[chromium] Remove expectations for no longer crashing tests.
https://bugs.webkit.org/show_bug.cgi?id=65155

Unreviewed expectation update.

These were fixed after Chromium r94376, r94374, r94373.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Fix unresolved symbols error when linking to libwebkit.dylib
thakis@chromium.org [Tue, 2 Aug 2011 17:33:45 +0000 (17:33 +0000)]
[chromium] Fix unresolved symbols error when linking to libwebkit.dylib
https://bugs.webkit.org/show_bug.cgi?id=65498

Reviewed by Dimitri Glazkov.

* WebCore.gyp/mac/adjust_visibility.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemoved a dangling reference to Leopard Intel Release (Build).
wsiegrist@apple.com [Tue, 2 Aug 2011 17:16:23 +0000 (17:16 +0000)]
Removed a dangling reference to Leopard Intel Release (Build).

Unreviewed.

* BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohover then un-hover makes state change
commit-queue@webkit.org [Tue, 2 Aug 2011 17:08:18 +0000 (17:08 +0000)]
hover then un-hover makes state change
https://bugs.webkit.org/show_bug.cgi?id=56401

Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-08-02
Reviewed by David Hyatt.

Source/WebCore:

When a 'before' pseudo-element is re-added, we should check whether the insertion point is an anonymous
block with inline children. If it is, then we should change the insertion point to the first child of the
anonymous block, otherwise the 'before' pseudo-element ends up in a different block. We choose the insertion
point to be the first child only if the anonymous block has children, otherwise the before element ends up
in a wrong block.

Tests: fast/dynamic/hover-before-position-after-style-change.html
       fast/dynamic/hover-before-position-after-style-change2.html

* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::updateBeforeAfterContent):

LayoutTests:

* fast/dynamic/hover-before-position-after-style-change-expected.txt: Added.
* fast/dynamic/hover-before-position-after-style-change.html: Added.
* fast/dynamic/hover-before-position-after-style-change2-expected.txt: Added.
* fast/dynamic/hover-before-position-after-style-change2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Add QtWebProcess in PATH at runtime for WebKit2 API auto tests.
jocelyn.turcotte@nokia.com [Tue, 2 Aug 2011 17:00:28 +0000 (17:00 +0000)]
[Qt] Add QtWebProcess in PATH at runtime for WebKit2 API auto tests.
https://bugs.webkit.org/show_bug.cgi?id=65378

Reviewed by Benjamin Poulain.

This prevent the runner of the tests from having to add it to PATH himself.

* UIProcess/API/qt/tests/commonviewtests/tst_commonviewtests.cpp:
(tst_CommonViewTests::tst_CommonViewTests):
* UIProcess/API/qt/tests/qdesktopwebview/tst_qdesktopwebview.cpp:
(tst_QDesktopWebView::tst_QDesktopWebView):
* UIProcess/API/qt/tests/qtouchwebview/tst_qtouchwebview.cpp:
(tst_QTouchWebView::tst_QTouchWebView):
* UIProcess/API/qt/tests/tests.pri:
* UIProcess/API/qt/tests/util.cpp: Copied from Source/WebKit2/UIProcess/API/qt/tests/util.h.
Move definitions to a cpp file to prevent unused static symbol warnings.
(addQtWebProcessToPath):
(waitForSignal):
* UIProcess/API/qt/tests/util.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTiledDrawingArea: Handle update requests in the order they were received.
jocelyn.turcotte@nokia.com [Tue, 2 Aug 2011 17:00:08 +0000 (17:00 +0000)]
TiledDrawingArea: Handle update requests in the order they were received.
https://bugs.webkit.org/show_bug.cgi?id=64365

Reviewed by Andreas Kling.

TiledDrawingAreaProxy::createTiles() uses the distance of tiles to the
center of the viewport to decide which tile should be rendered first.
This logic is useless if the requests are not handled in the same order
as they were received.
Now use a list instead of a map to hold pending tile update requests.

* WebProcess/WebPage/TiledDrawingArea.cpp:
(WebKit::TiledDrawingArea::tileUpdateTimerFired):
(WebKit::TiledDrawingArea::cancelTileUpdate):
(WebKit::TiledDrawingArea::requestTileUpdate):
* WebProcess/WebPage/TiledDrawingArea.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Simplify Path::translate() implementation.
commit-queue@webkit.org [Tue, 2 Aug 2011 16:34:36 +0000 (16:34 +0000)]
[Qt] Simplify Path::translate() implementation.
https://bugs.webkit.org/show_bug.cgi?id=65540

Patch by Andreas Kling <kling@webkit.org> on 2011-08-02
Reviewed by Benjamin Poulain.

* platform/graphics/qt/PathQt.cpp:
(WebCore::Path::translate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: merge FormattedSourceFile into SourceFile.
podivilov@chromium.org [Tue, 2 Aug 2011 15:59:55 +0000 (15:59 +0000)]
Web Inspector: merge FormattedSourceFile into SourceFile.
https://bugs.webkit.org/show_bug.cgi?id=65411

Reviewed by Pavel Feldman.

Prepare for splitting SourceFile into RawSourceCode and UISourceCode:
 * merge FormattedSourceFile into SourceFile
 * rename SourceFile to RawSourceCode
 * hide formatter worker lazy creation in ScriptFormatter

Source/WebCore:

* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._scriptLocationToUILocation):
(WebInspector.DebuggerPresentationModel.prototype._uiLocationToScriptLocation):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
* inspector/front-end/ScriptFormatter.js:
(WebInspector.ScriptFormatter):
(WebInspector.ScriptFormatter.prototype._didFormatContent):
(WebInspector.ScriptFormatter.prototype.get _worker):
* inspector/front-end/SourceFile.js:
(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype.setFormatted):
(WebInspector.RawSourceCode.prototype.createSourceMappingIfNeeded.didRequestContent):
(WebInspector.RawSourceCode.prototype.createSourceMappingIfNeeded):
(WebInspector.RawSourceCode.prototype._didRequestContent.didFormatContent):
(WebInspector.RawSourceCode.prototype._didRequestContent):
(WebInspector.RawSourceCode.prototype._invokeRequestContentCallbacks):

LayoutTests:

* inspector/debugger/source-file.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CSSRegions]Fix build after changeset 92106
commit-queue@webkit.org [Tue, 2 Aug 2011 15:58:53 +0000 (15:58 +0000)]
[CSSRegions]Fix build after changeset 92106
https://bugs.webkit.org/show_bug.cgi?id=65539

Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-08-02
Reviewed by Adam Roben.

No new tests since it is just a build fix.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [REGRESSION] Console evaluations leading to resource loading cause...
vsevik@chromium.org [Tue, 2 Aug 2011 15:54:35 +0000 (15:54 +0000)]
Web Inspector: [REGRESSION] Console evaluations leading to resource loading cause errors.
https://bugs.webkit.org/show_bug.cgi?id=65466

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/network/network-initiator-from-console.html

* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):

LayoutTests:

* http/tests/inspector/network/network-initiator-from-console-expected.txt: Added.
* http/tests/inspector/network/network-initiator-from-console.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: REGRESSION(r92105): It made 2 tests fail
ossy@webkit.org [Tue, 2 Aug 2011 15:52:42 +0000 (15:52 +0000)]
Web Inspector: REGRESSION(r92105): It made 2 tests fail
https://bugs.webkit.org/show_bug.cgi?id=65525

* platform/qt/Skipped: Unskip tests, because r92185 fixed the bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: img[width=90] or align attributes shouldnt be shown above element...
apavlov@chromium.org [Tue, 2 Aug 2011 15:51:31 +0000 (15:51 +0000)]
Web Inspector: img[width=90] or align attributes shouldnt be shown above element.style block (as they have lower specificity)
https://bugs.webkit.org/show_bug.cgi?id=65514

Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/front-end/StylesSidebarPane.js:

LayoutTests:

* inspector/elements/elements-panel-styles-expected.txt:
* inspector/elements/elements-panel-styles.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92192 268f45cc-cd09-0410-ab3c-d52691b4dbfc