WebKit-https.git
12 years agoWebCore:
beidson@apple.com [Fri, 25 Jul 2008 23:20:47 +0000 (23:20 +0000)]
WebCore:

2008-07-25  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam

        Test: security/set-form-autocomplete-attribute.html

        Part of the fix for <rdar://problem/6093281> - Improper handling of autocomplete

        The autocomplete attribute works on both <form> and <input> elements, but was not
        inherited properly when someone asked an <input> if it should autocomplete.

        I fixed this up based on the rules in the current WF2 spec so if the <input> element
        has its own autocomplete attribute set, it will follow that but otherwise it will
        inherit from its parent <form>

        * WebCore.base.exp:

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::init):
        (WebCore::HTMLInputElement::autoComplete):
        (WebCore::HTMLInputElement::parseMappedAttribute):
        * html/HTMLInputElement.h:
        (WebCore::HTMLInputElement::):

WebKitTools:

2008-07-25  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam

        Add the ability to dump whether-or-not an element should have autocomplete enabled,
        from the perspective of the WebKit API

        * DumpRenderTree/LayoutTestController.cpp:
        (elementDoesAutoCompleteForElementWithIdCallback):
        (LayoutTestController::staticFunctions):

        * DumpRenderTree/LayoutTestController.h:
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (LayoutTestController::elementDoesAutoCompleteForElementWithId):
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::elementDoesAutoCompleteForElementWithId): Stub for now until I can get on Windows

LayoutTests:

2008-07-25  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam

        Test for autocomplete attribute cleanup

        * platform/win/Skipped:
        * security/set-form-autocomplete-attribute-expected.txt: Added.
        * security/set-form-autocomplete-attribute.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-25 Wouter Bolsterlee <uws+webkit@xs4all.nl>
jmalonzo@webkit.org [Fri, 25 Jul 2008 23:16:51 +0000 (23:16 +0000)]
2008-07-25  Wouter Bolsterlee  <uws+webkit@xs4all.nl>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=20078
        [GTK] Use G_* macros instead of deprecated GTK_* macros in gtk2xtbin.h

        * plugins/gtk/gtk2xtbin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-25 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 25 Jul 2008 23:12:31 +0000 (23:12 +0000)]
2008-07-25  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam.

        Add workaround for a Leopard bug which causes webarchive/test-xml-stylesheet.xml to fail.

        * platform/network/mac/WebCoreURLResponse.mm:
        (-[NSURLResponse _webcore_MIMEType]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-25 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 25 Jul 2008 22:43:00 +0000 (22:43 +0000)]
2008-07-25  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mitz.

        Make the willCacheResponse test more robust.

        * http/tests/misc/resources/willCacheResponse-success.html: Added.
        * http/tests/misc/willCacheResponse-delegate-callback-expected.txt:
        * http/tests/misc/willCacheResponse-delegate-callback.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd result for hex color test
hyatt@apple.com [Fri, 25 Jul 2008 22:13:03 +0000 (22:13 +0000)]
Add result for hex color test

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Anders Carlsson.
mitz@apple.com [Fri, 25 Jul 2008 21:42:18 +0000 (21:42 +0000)]
    Reviewed by Anders Carlsson.

        * http/tests/misc/acid3.html: Updated test 77 from acidtests.org. Added
        alert()ing the log when the score is less than 100.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Rubber-stamped by Brady Eidson.
mitz@apple.com [Fri, 25 Jul 2008 20:59:48 +0000 (20:59 +0000)]
    Rubber-stamped by Brady Eidson.

        - add missing pixel results and move the render tree results under the platform directory

        * platform/mac/svg/dom/SVGRectElement: Added.
        * platform/mac/svg/dom/SVGRectElement/rect-modify-rx-expected.checksum: Added.
        * platform/mac/svg/dom/SVGRectElement/rect-modify-rx-expected.png: Added.
        * platform/mac/svg/dom/SVGRectElement/rect-modify-rx-expected.txt: Added.
        * platform/mac/webarchive: Added.
        * platform/mac/webarchive/loading: Added.
        * platform/mac/webarchive/loading/cache-expired-subresource-expected.checksum: Added.
        * platform/mac/webarchive/loading/cache-expired-subresource-expected.png: Added.
        * platform/mac/webarchive/loading/cache-expired-subresource-expected.txt: Added.
        * svg/dom/SVGRectElement/rect-modify-rx-expected.txt: Removed.
        * webarchive/loading/cache-expired-subresource-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/6084806> AX: REGRESSION: returned line number from TextArea is incorrect
cfleizach@apple.com [Fri, 25 Jul 2008 20:35:18 +0000 (20:35 +0000)]
<rdar://problem/6084806> AX: REGRESSION: returned line number from TextArea is incorrect

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Fri, 25 Jul 2008 20:21:06 +0000 (20:21 +0000)]
WebCore:

2008-07-25  Jacob Refstrup  <jacob.refstrup@hp.com>

        Reviewed by mitz.

        - fix https://bugs.webkit.org/show_bug.cgi?id=17906
        <rdar://problem/5805741> white-space: pre-wrap or -webkit-line-break: after-white-space text can overlap float at end of line

        Test: fast/block/float/editable-text-overlapping-float.html

        * rendering/RenderBlock.h:
        * rendering/bidi.cpp:
        (WebCore::RenderBlock::skipTrailingWhitespace):
        - renamed to reflect usage and removed call to position floats;
          they only get added
        (WebCore::RenderBlock::skipLeadingWhitespace):
        - renamed to reflect usage
        (WebCore::RenderBlock::findNextLineBreak):
        - use skipTrailingWhitespace at end of line (as before but with new
          name)

LayoutTests:

2008-07-25  Jacob Refstrup  <jacob.refstrup@hp.com>

        Reviewed by mitz.

        - added test case for float being added in trailing whitespace
          of an already full line (with pre-wrap or after-white-space set).
          <rdar://problem/5805741> https://bugs.webkit.org/show_bug.cgi?id=17906

        * fast/block/float/editable-text-overlapping-float.html: Added.
        * platform/mac/fast/block/float/editable-text-overlapping-float-expected.checksum: Added.
        * platform/mac/fast/block/float/editable-text-overlapping-float-expected.png: Added.
        * platform/mac/fast/block/float/editable-text-overlapping-float-expected.txt: Added.
        * platform/qt/fast/block/float/editable-text-overlapping-float-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Try to fix the Windows build bot
aroben@apple.com [Fri, 25 Jul 2008 19:27:12 +0000 (19:27 +0000)]
    Try to fix the Windows build bot

        * DumpRenderTree/win/DumpRenderTree.vcproj: Don't try to copy files
        that don't exist for people outside of Apple.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-25 Dan Bernstein <mitz@apple.com>
mitz@apple.com [Fri, 25 Jul 2008 19:10:50 +0000 (19:10 +0000)]
2008-07-25  Dan Bernstein  <mitz@apple.com>

        Reviewed by Sam Weinig.

        - Finish fixing https://bugs.webkit.org/show_bug.cgi?id=17097
          <rdar://problem/5715471> CGFontRefs (and HFONTs on Windows) leak because FontCache grows without bound

        * platform/graphics/FontCache.cpp:
        (WebCore::FontDataCacheKeyTraits): Changed needsDestruction to true because FontPlatformData
        instances hold references to the platform resources and release them in the destructor.
        (WebCore::cTargetInactiveFontData): Added, replacing cInactiveFontDataPurgeRatio with the
        number of inactive FontData instances to leave in the cache when automatically purging.
        (WebCore::FontCache::getCachedFontData): Moved the code that checks if there are too many
        inactive FontData instances and if so calls purgeInactiveFontData() from here...
        (WebCore::FontCache::releaseFontData): ... to here.
        (WebCore::FontCache::purgeInactiveFontData): Added code to also purge the platform font data
        cache. All FontPlatformData instances that do not have entries in the font data cache are
        removed, thus releasing the platform resources (such as HFONTs and NSFonts).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
hyatt@apple.com [Fri, 25 Jul 2008 18:33:45 +0000 (18:33 +0000)]
WebCore:

2008-07-24  David Hyatt  <hyatt@apple.com>

        Add support for an alternate syntax for CSS variables.  Testers on www-style will be able to try out
        both versions of the syntax in WebKit to help us make a decision regarding which one to go with.

        Reviewed by Dan

        Added fast/css/variables/alternate-syntax/ (duplicated all existing CSS variables tests)

        * css/CSSGrammar.y:
        * css/CSSParser.cpp:
        (WebCore::CSSParser::createVariablesRule):
        (WebCore::CSSParser::checkForVariables):
        * css/CSSParser.h:
        * css/CSSParserValues.cpp:
        (WebCore::CSSParserValue::isVariable):
        (WebCore::CSSParserValueList::addValue):
        (WebCore::CSSParserValueList::deleteValueAt):
        (WebCore::CSSParserValue::createCSSValue):
        * css/CSSParserValues.h:
        * css/CSSPrimitiveValue.cpp:
        (WebCore::CSSPrimitiveValue::cleanup):
        (WebCore::CSSPrimitiveValue::getStringValue):
        (WebCore::CSSPrimitiveValue::cssText):
        (WebCore::CSSPrimitiveValue::parserValue):
        * css/CSSPrimitiveValue.h:
        (WebCore::CSSPrimitiveValue::):
        (WebCore::CSSPrimitiveValue::isVariable):
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::addMatchedDeclaration):
        * css/CSSVariablesRule.cpp:
        (WebCore::CSSVariablesRule::CSSVariablesRule):
        (WebCore::CSSVariablesRule::cssText):
        * css/CSSVariablesRule.h:
        (WebCore::CSSVariablesRule::create):
        * css/maketokenizer:
        * css/tokenizer.flex:

LayoutTests:

2008-07-24  David Hyatt  <hyatt@apple.com>

        Add support for an alternate proposed syntax for CSS variables.  This alternate syntax will allow
        testers on www-style to try out both versions of the syntax (to help make a decision regarding
        which one should be used).

        Reviewed by Dan

        * fast/css/variables/alternate-syntax: Added.
        * fast/css/variables/alternate-syntax/color-hex-test.html: Added.
        * fast/css/variables/alternate-syntax/colors-test.html: Added.
        * fast/css/variables/alternate-syntax/font-test.html: Added.
        * fast/css/variables/alternate-syntax/image-test.html: Added.
        * fast/css/variables/alternate-syntax/import-test.html: Added.
        * fast/css/variables/alternate-syntax/inline-style-test.html: Added.
        * fast/css/variables/alternate-syntax/invalid-variable-test.html: Added.
        * fast/css/variables/alternate-syntax/margin-test.html: Added.
        * fast/css/variables/alternate-syntax/misplaced-import-test.html: Added.
        * fast/css/variables/alternate-syntax/misplaced-variables-test.html: Added.
        * fast/css/variables/alternate-syntax/multiple-term-test.html: Added.
        * fast/css/variables/alternate-syntax/override-test.html: Added.
        * fast/css/variables/alternate-syntax/print-test.html: Added.
        * fast/css/variables/alternate-syntax/remove-variable-test.html: Added.
        * fast/css/variables/alternate-syntax/resources: Added.
        * fast/css/variables/alternate-syntax/resources/bad.css: Added.
        * fast/css/variables/alternate-syntax/resources/good.css: Added.
        * fast/css/variables/alternate-syntax/resources/listmark.gif: Added.
        * fast/css/variables/alternate-syntax/set-variable-test.html: Added.
        * fast/css/variables/alternate-syntax/shorthand-test.html: Added.
        * fast/css/variables/alternate-syntax/variable-iteration-test.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-25 Maxime Britto <britto@apple.com>
britto@apple.com [Fri, 25 Jul 2008 18:30:14 +0000 (18:30 +0000)]
2008-07-25  Maxime Britto  <britto@apple.com>

        Reviewed by Anders Carlsson.

        <rdar://6102387> "REGRESSION: horizontal scroll with the mouse wheel is inverted on some subframes"

        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleWheelEvent): Inverted the scroll direction relative to the delta value (positive scrolls left,negative scrolls right)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Try to fix the Windows build bot
aroben@apple.com [Fri, 25 Jul 2008 17:46:48 +0000 (17:46 +0000)]
    Try to fix the Windows build bot

        * WebKit.vcproj/WebKit.sln: Linearize the project dependencies. Each
        project now depends only on the project that should immediately
        precede it in the build. For the frameworks, this order makes sense.
        For the applications built on top of the frameworks, the order is
        arbitrary (but roughly follows the applications' complexity).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-25 Adele Peterson <adele@apple.com>
adele@apple.com [Fri, 25 Jul 2008 17:11:29 +0000 (17:11 +0000)]
2008-07-25  Adele Peterson  <adele@apple.com>

        Another build fix.

        * platform/win/PlatformScrollBarSafari.cpp:
        (WebCore::PlatformScrollbar::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-25 Adele Peterson <adele@apple.com>
adele@apple.com [Fri, 25 Jul 2008 16:54:10 +0000 (16:54 +0000)]
2008-07-25  Adele Peterson  <adele@apple.com>

        More build fixes.

        * platform/win/PlatformScrollBarSafari.cpp:
        (WebCore::PlatformScrollbar::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-25 Adele Peterson <adele@apple.com>
adele@apple.com [Fri, 25 Jul 2008 16:30:30 +0000 (16:30 +0000)]
2008-07-25  Adele Peterson  <adele@apple.com>

        Build fix.

        * platform/win/PlatformScrollBarSafari.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Windows build fix
aroben@apple.com [Fri, 25 Jul 2008 15:58:03 +0000 (15:58 +0000)]
    Windows build fix

        * JavaScriptCore.vcproj/testapi/testapi.vcproj: Add API/ to the
        include path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-25 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Fri, 25 Jul 2008 13:11:08 +0000 (13:11 +0000)]
2008-07-25  Simon Hausmann  <hausmann@webkit.org>

        Fix the build of jsc on Qt/Windows, make sure os-win32 is in the
        include search path (added by WebKit.pri).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-25 Joerg Bornemann <joerg.bornemann@trolltech.com>
hausmann@webkit.org [Fri, 25 Jul 2008 13:05:43 +0000 (13:05 +0000)]
2008-07-25  Joerg Bornemann  <joerg.bornemann@trolltech.com>

        Reviewed by Simon.

        Compile with QT_NO_PRINTER.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Simon Hausmann.
ap@webkit.org [Fri, 25 Jul 2008 12:05:16 +0000 (12:05 +0000)]
    Reviewed by Simon Hausmann.

        Move JavaScriptCore API tests into a subdirectory of their own to avoid header name
        conflicts and developer confusion.

        * API/JSNode.c: Removed.
        * API/JSNode.h: Removed.
        * API/JSNodeList.c: Removed.
        * API/JSNodeList.h: Removed.
        * API/Node.c: Removed.
        * API/Node.h: Removed.
        * API/NodeList.c: Removed.
        * API/NodeList.h: Removed.
        * API/minidom.c: Removed.
        * API/minidom.html: Removed.
        * API/minidom.js: Removed.
        * API/testapi.c: Removed.
        * API/testapi.js: Removed.
        * API/tests: Added.
        * API/tests/JSNode.c: Copied from JavaScriptCore/API/JSNode.c.
        * API/tests/JSNode.h: Copied from JavaScriptCore/API/JSNode.h.
        * API/tests/JSNodeList.c: Copied from JavaScriptCore/API/JSNodeList.c.
        * API/tests/JSNodeList.h: Copied from JavaScriptCore/API/JSNodeList.h.
        * API/tests/Node.c: Copied from JavaScriptCore/API/Node.c.
        * API/tests/Node.h: Copied from JavaScriptCore/API/Node.h.
        * API/tests/NodeList.c: Copied from JavaScriptCore/API/NodeList.c.
        * API/tests/NodeList.h: Copied from JavaScriptCore/API/NodeList.h.
        * API/tests/minidom.c: Copied from JavaScriptCore/API/minidom.c.
        * API/tests/minidom.html: Copied from JavaScriptCore/API/minidom.html.
        * API/tests/minidom.js: Copied from JavaScriptCore/API/minidom.js.
        * API/tests/testapi.c: Copied from JavaScriptCore/API/testapi.c.
        * API/tests/testapi.js: Copied from JavaScriptCore/API/testapi.js.
        * GNUmakefile.am:
        * JavaScriptCore.vcproj/testapi/testapi.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-24 Tor Arne Vestbø <tavestbo@trolltech.com>
vestbo@webkit.org [Fri, 25 Jul 2008 12:05:03 +0000 (12:05 +0000)]
2008-07-24  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon

        Provide access to the underlying QKeyEvent in PlatformKeyboardEvent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-24 Tor Arne Vestbø <tavestbo@trolltech.com>
vestbo@webkit.org [Fri, 25 Jul 2008 12:04:36 +0000 (12:04 +0000)]
2008-07-24  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon

        Don't insert text on keyDown event in EditorClientQt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-25 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Fri, 25 Jul 2008 11:43:42 +0000 (11:43 +0000)]
2008-07-25  Simon Hausmann  <hausmann@webkit.org>

        Fix linking of QtWebKit against the statically built JavaScriptCore
        library, under Windows/Mac we may need _d/_debug suffixes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-25 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Fri, 25 Jul 2008 11:02:58 +0000 (11:02 +0000)]
2008-07-25  Simon Hausmann  <hausmann@webkit.org>

        Prospective WX build fix, add JavaScriptCore/API to the include search
        path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-25 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Fri, 25 Jul 2008 10:56:18 +0000 (10:56 +0000)]
2008-07-25  Simon Hausmann  <hausmann@webkit.org>

        Rubber-stamped by Lars.

        Fix the build on Windows. operator new for ArgList is implemented using fastMalloc()
        but operator delete was not implemented. Unfortunately MSVC decides to call/reference
        the function, so a simple implementation using fastFree() fixes the build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-25 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Fri, 25 Jul 2008 10:55:59 +0000 (10:55 +0000)]
2008-07-25  Simon Hausmann  <hausmann@webkit.org>

        Rubber-stamped by Lars.

        Fix the Qt build by adapting to the latest ArgList API changes and
        replacing the inclusion of npapi.h in MainThreadScheduler with a forward
        declaration of NPP to avoid an include conflict. npapi.h on X11 includes
        X headers, which include wonderful defines such as "#define Status" that
        cause conflicts.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-25 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Fri, 25 Jul 2008 10:55:33 +0000 (10:55 +0000)]
2008-07-25  Simon Hausmann  <hausmann@webkit.org>

        Discussed with and rubber-stamped by Lars.

        Fix the build system for the Qt port.

        Recent JavaScriptCore changes require the addition of JavaScriptCore/API to the
        include search path. With a build process that combines JavaScriptCore and
        WebCore in one build process/Makefile the existance of
        JavaScriptCore/API/Node.h and WebCore/dom/Node.h causes include conflicts.

        This commit solves this by introducing a separate build of JavaScriptCore into
        a static library.

        As a result of the split-up a race-condition due to broken dependencies of
        regular source files to header files of generated sources showed up very
        frequently when doing parallel builds (which the buildbot does). This commit at
        the same time tries to address the dependency problem by making the
        addExtraCompiler() function also generate a pseudo extra compiler that
        represents the header file output, so that qmake is aware of the creation of
        the header file for dependency calculation.

        At the same time I removed a lot of cruft from the pro files to ease maintenance.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-24 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 25 Jul 2008 06:40:38 +0000 (06:40 +0000)]
2008-07-24  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Maciej Stachowiak.

        Fixed a strict aliasing violation, which caused hash tables with floating
        point keys not to find items that were indeed in the tables
        (intermittently, and only in release builds, of course).

        SunSpider reports no change.

        This bug doesn't seem to affect any existing code, but it causes obvious
        crashes in some new code I'm working on.

        * wtf/HashFunctions.h:
        (WTF::FloatHash::hash): Use a union when punning between a float / double
        and an unsigned (bucket of bits). With strict aliasing enabled, unions
        are the only safe way to do this kind of type punning.

        * wtf/HashTable.h: When rehashing, ASSERT that the item we just added to
        the table is indeed in the table. In the buggy case described above, this
        ASSERT fires.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowx build fix on Win for plugins coode.
kevino@webkit.org [Thu, 24 Jul 2008 22:57:13 +0000 (22:57 +0000)]
wx build fix on Win for plugins coode.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-24 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 24 Jul 2008 21:55:49 +0000 (21:55 +0000)]
2008-07-24  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Make isElementNode() non-virtual for a speedup on many benchmarks
        including 20% on http://ejohn.org/apps/fragment/.

        - Replace Node::m_attrWasSpecifiedOrElementHasRareData with bits in
          Element and Attr where space was available.  Use the new free bit
          to represent if an node is an element or not.

        * dom/Attr.cpp:
        (WebCore::Attr::Attr):
        * dom/Attr.h:
        (WebCore::Attr::specified):
        (WebCore::Attr::setSpecified):
        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::ContainerNode):
        * dom/ContainerNode.h:
        * dom/Element.cpp:
        (WebCore::Element::Element):
        * dom/Element.h:
        (WebCore::Element::hasRareData):
        (WebCore::Element::setHasRareData):
        * dom/EventTargetNode.cpp:
        (WebCore::EventTargetNode::EventTargetNode):
        * dom/EventTargetNode.h:
        * dom/Node.cpp:
        (WebCore::Node::Node):
        * dom/Node.h:
        (WebCore::Node::isElementNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Dave Hyatt.
mitz@apple.com [Thu, 24 Jul 2008 21:38:51 +0000 (21:38 +0000)]
    Reviewed by Dave Hyatt.

        - fix <rdar://problem/6082111> REGRESSION (r31876): Root element with percent height does not resize when resizing the window vertically

        Not testable in DumpRenderTree

        * rendering/RenderView.cpp:
        (WebCore::RenderView::layout): Ensured that all children with percentage
        heights get laid out again if the height changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWindows build fix for wx. wx doesn't implement pan scrolling yet.
kevino@webkit.org [Thu, 24 Jul 2008 21:27:17 +0000 (21:27 +0000)]
Windows build fix for wx. wx doesn't implement pan scrolling yet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Remove some redundant text accidentally checked in
aroben@apple.com [Thu, 24 Jul 2008 20:38:12 +0000 (20:38 +0000)]
    Remove some redundant text accidentally checked in

        * building/tools.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix a dead link to the Windows Platform SDK and related instructions
aroben@apple.com [Thu, 24 Jul 2008 20:36:20 +0000 (20:36 +0000)]
    Fix a dead link to the Windows Platform SDK and related instructions

        Rubberstamped by Alexey Proskuryakov.

        * building/tools.html: Fixed a dead link.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-24 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Thu, 24 Jul 2008 20:24:11 +0000 (20:24 +0000)]
2008-07-24  David Hyatt  <hyatt@apple.com>

        Fix for bug 18673, crash when using full page zoom on generated content.  Don't call
        intrinsicSizeChanged when we are first setting our style.

        Reviewed by olliej

        * ChangeLog:
        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::setStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBug 20142: REGRESSION(r35245): /=/ weirdness
oliver@apple.com [Thu, 24 Jul 2008 10:16:51 +0000 (10:16 +0000)]
Bug 20142: REGRESSION(r35245): /=/ weirdness
<https://bugs.webkit.org/show_bug.cgi?id=20142>

Reviewed by Alexey Proskuryakov.

When adding all the meta data needed for exception error messages
I accidentally clobbered the handling of regex beginning with /=.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-24 Julien Chaffraix <jchaffraix@webkit.org>
jchaffraix@webkit.org [Thu, 24 Jul 2008 08:44:28 +0000 (08:44 +0000)]
2008-07-24  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Eric.

        Bug 20053: .in files should use a custom format instead of XML

        - Remove our XML parser perl module (XML::Tiny)

        - Add a custom perl parser

        - Move XML files to the new format

        * bindings/scripts/InFilesParser.pm: Added.
        * bindings/scripts/XMLTiny.pm: Removed.
        * dom/make_names.pl: Switched to our new
        parser.

        * html/HTMLAttributeNames.in: Switched to
        our custom format.
        * html/HTMLTagNames.in: Ditto.
        * svg/svgattrs.in: Ditto.
        * svg/svgtags.in: Ditto.
        * svg/xlinkattrs.in: Ditto.
        * xml/xmlattrs.in: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
jchaffraix@webkit.org [Thu, 24 Jul 2008 07:45:28 +0000 (07:45 +0000)]
WebCore:

2008-07-23  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Eric.

        Bug 19588: CRASH doing open() on destroyed window
        https://bugs.webkit.org/show_bug.cgi?id=19588

        Add frame's page null check as it could have been
        detached from the page.

        Test: fast/frames/crash-removed-iframe.html

        * bindings/js/JSDOMWindowBase.cpp:
        (WebCore::windowProtoFuncOpen):
        * page/FrameTree.cpp:
        (WebCore::FrameTree::find):

LayoutTest:

2008-07-23  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Eric.

        Test for bug 19588: CRASH doing open() on destroyed window
        https://bugs.webkit.org/show_bug.cgi?id=19588

        Test case from Eric Roman.

        * fast/frames/crash-removed-iframe-expected.txt: Added.
        * fast/frames/crash-removed-iframe.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Thu, 24 Jul 2008 06:55:35 +0000 (06:55 +0000)]
WebCore:

        Reviewed by Alexey Proskuryakov.

        - fix a leak when using hex color values in CSS variables

        - fix CSSOM access to hex color values in variables declarations

        Test: fast/css/variables/color-hex-test.html

        Added a new unit/type, CSS_PARSER_HEXCOLOR, which serves as the unit for
        CSSParserValues coming from colors in hex notation. CSSParserValues can
        no longer have CSS_RGBCOLOR as their unit. CSS_PARSER_HEXCOLOR is also
        used as the type for CSSValues in CSS variables declarations where the
        parser value was a hex color. However the type of all other color
        CSSValues remains CSS_RGBCOLOR.

        * css/CSSGrammar.y: Changed to use the new CSS_PARSER_HEXCOLOR value
        for color values in hex notation.
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseColorFromValue): Updated for the new unit.
        * css/CSSParserValues.cpp:
        (WebCore::CSSParserValue::createCSSValue): Ditto.
        * css/CSSPrimitiveValue.cpp:
        (WebCore::CSSPrimitiveValue::cleanup): Fixed the leak by deref()ing the
        string containing the color.
        (WebCore::CSSPrimitiveValue::cssText): Added support for
        CSS_PARSER_HEXCOLOR for when serializing variable values.
        (WebCore::CSSPrimitiveValue::parserValue): Updated for the new unit.
        * css/CSSPrimitiveValue.h:
        (WebCore::CSSPrimitiveValue::): Added a new unti, CSS_PARSER_HEXCOLOR.

LayoutTests:

        Reviewed by Alexey Proskuryakov.

        - updated test to cover serializing variable values which are colors in
          hex notation

        * fast/css/variables/color-hex-test.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-23 Alp Toker <alp@nuanti.com>
alp@webkit.org [Thu, 24 Jul 2008 06:16:20 +0000 (06:16 +0000)]
2008-07-23  Alp Toker  <alp@nuanti.com>

        Build fix after r35293: Add API/ to the include path.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
bdakin@apple.com [Thu, 24 Jul 2008 03:43:36 +0000 (03:43 +0000)]
WebCore:

2008-07-23  Beth Dakin  <bdakin@apple.com>

        Reviewed by Dan Bernstein.

        Fix for <rdar://problem/5997215> display: table-row-group
        for :before content causes a crash

        The actual bug fix here is to ddd the generated content container
        as a child before adding any of the generated content to the
        container. There are two correctness fixes as well that deal with
        style changes and correctly.

        This patch also makes Node::diff() a static function.

        * dom/Node.cpp:
        (WebCore::Node::diff):
        * dom/Node.h:
        (WebCore::Node::):
        (WebCore::Node::recalcStyle):
        * rendering/RenderContainer.cpp:
        (WebCore::findBeforeAfterParent):
        (WebCore::RenderContainer::updateBeforeAfterContentForContainer):
        * svg/SVGUseElement.cpp:
        (WebCore::SVGUseElement::recalcStyle):

LayoutTests:

2008-07-23  Beth Dakin  <bdakin@apple.com>

        Reviewed by Dan Bernstein.

        Tests for <rdar://problem/5997215> display: table-row-group
        for :before content causes a crash

        * fast/css-generated-content/table-row-group-to-inline.html: Added.
        * fast/css-generated-content/table-row-group-with-before.html: Added.
        * fast/css-generated-content/table-row-with-before.html: Added.
        * fast/css-generated-content/table-with-before.html: Added.
        * platform/mac/fast/css-generated-content/table-row-group-to-inline-expected.checksum: Added.
        * platform/mac/fast/css-generated-content/table-row-group-to-inline-expected.png: Added.
        * platform/mac/fast/css-generated-content/table-row-group-to-inline-expected.txt: Added.
        * platform/mac/fast/css-generated-content/table-row-group-with-before-expected.checksum: Added.
        * platform/mac/fast/css-generated-content/table-row-group-with-before-expected.png: Added.
        * platform/mac/fast/css-generated-content/table-row-group-with-before-expected.txt: Added.
        * platform/mac/fast/css-generated-content/table-row-with-before-expected.checksum: Added.
        * platform/mac/fast/css-generated-content/table-row-with-before-expected.png: Added.
        * platform/mac/fast/css-generated-content/table-row-with-before-expected.txt: Added.
        * platform/mac/fast/css-generated-content/table-with-before-expected.checksum: Added.
        * platform/mac/fast/css-generated-content/table-with-before-expected.png: Added.
        * platform/mac/fast/css-generated-content/table-with-before-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Updates the elements DOM tree when nodes are added or removed from
timothy@apple.com [Thu, 24 Jul 2008 02:48:36 +0000 (02:48 +0000)]
    Updates the elements DOM tree when nodes are added or removed from
        the inspected document.

        https://bugs.webkit.org/show_bug.cgi?id=6590
        <rdar://problem/5712921>

        Reviewed by Adam Roben.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::dispatchWindowObjectAvailable): Added a call to
        InspectorController::inspectedWindowScriptObjectCleared.
        * page/InspectorController.cpp:
        (WebCore::InspectorController::inspectedWindowScriptObjectCleared):
        Calls the WebInspector.inspectedWindowCleared script function.
        * page/InspectorController.h:
        * page/inspector/ElementsPanel.js:
        (WebInspector.ElementsPanel): Create the event listener callback wrappers.
        (WebInspector.ElementsPanel.prototype.show): Call _updateModifiedNodes if
        there are any recently modified nodes.
        (WebInspector.ElementsPanel.prototype.reset): Remove previous mutation event listeners.
        Adds a check for InspectorController.isWindowVisible to prevent adding
        event listeners when the window isn't visible.
        (WebInspector.ElementsPanel.prototype.inspectedWindowCleared):
        (WebInspector.ElementsPanel.prototype._addMutationEventListeners): Add DOMNodeInserted,
        DOMNodeRemoved and DOMContentLoaded event listeners to the passed in window or window's document.
        (WebInspector.ElementsPanel.prototype._removeMutationEventListeners): Removes the event listeners
        added in _addMutationEventListeners.
        (WebInspector.ElementsPanel.prototype.updateMutationEventListeners): Call _addMutationEventListeners
        again to reinstate the listners if the document changed or window cleared them.
        (WebInspector.ElementsPanel.prototype.registerMutationEventListeners): Append the window to
        _mutationMonitoredWindows and call _addMutationEventListeners.
        (WebInspector.ElementsPanel.prototype.unregisterMutationEventListeners): Remove the window from
        _mutationMonitoredWindows and call _removeMutationEventListeners.
        (WebInspector.ElementsPanel.prototype.unregisterAllMutationEventListeners): Call
        _removeMutationEventListeners for all windows in _mutationMonitoredWindows and
        clear _mutationMonitoredWindows.
        (WebInspector.ElementsPanel.prototype._contentLoaded): Append the node and parent
        to the recentlyModifiedNodes array. Call _updateModifiedNodesSoon if visible.
        (WebInspector.ElementsPanel.prototype._nodeInserted): Ditto.
        (WebInspector.ElementsPanel.prototype._nodeRemoved): Ditto.
        (WebInspector.ElementsPanel.prototype._updateModifiedNodesSoon): Call
        _updateModifiedNodes on a zero timeout.
        (WebInspector.ElementsPanel.prototype._updateModifiedNodes): Iterate over
        the recentlyModifiedNodes array and call updateChildren on all the parent
        elements that had changes. Only calls updateChildren once per parent element.
        (WebInspector.ElementsPanel.prototype._isAncestorIncludingParentFrames): Return
        false if the nodes are the same. Return true if the nodes are the same while
        looking at ancestor frame elements. THis use to return false, which was incorrect.
        (WebInspector.DOMNodeTreeElement.prototype.onpopulate): Call updateChildren.
        (WebInspector.DOMNodeTreeElement.prototype.updateChildren): Copied from
        onpopulate and changed to rebuild the children elements by adding new children,
        moving existing children and removed old children.
        (WebInspector.DOMNodeTreeElement.prototype.onexpand): If the node has a contentDocument
        call registerMutationEventListeners to track any mutations.
        * page/inspector/inspector.js:
        (WebInspector.inspectedWindowCleared): Call ElementsPanel.inspectedWindowCleared.
        * page/inspector/treeoutline.js:
        (TreeElement.prototype.get hasChildren): Return _hasChildren.
        (TreeElement.prototype.set hasChildren): Set _hasChildren and update the className.
        (TreeElement.prototype.hasAncestor): Return true if the element has the passed in ancestor.
        (TreeElement.prototype.expand): Fix an exception that can happen if expand is
        called before _attach.
        * WebCore/manual-tests/inspector/dom-mutation.html: Added.
        * WebCore/manual-tests/inspector/resources/mutate-frame-2.html: Added.
        * WebCore/manual-tests/inspector/resources/mutate-frame.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix an exception that occurred when double clicking the closing tag
timothy@apple.com [Thu, 24 Jul 2008 02:48:17 +0000 (02:48 +0000)]
    Fix an exception that occurred when double clicking the closing tag
        of an element in the DOM tree.

        Reviewed by Anders Carlsson.

        * page/inspector/ElementsPanel.js:
        (WebInspector.ElementsPanel.prototype._ondblclick): Null check
        element.ondblclick.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix a regression where elements in subframes would not be revealed
timothy@apple.com [Thu, 24 Jul 2008 02:48:01 +0000 (02:48 +0000)]
    Fix a regression where elements in subframes would not be revealed
        or selected when inspected from the context menu. This was caused by
        JavaScript equality is not being true for JSInspectedObjectWrappers
        of the same node wrapped with different global ExecStates. This change
        adds a helper function that uses isSameNode to compare wrapped nodes.

        https://bugs.webkit.org/show_bug.cgi?id=19377

        Reviewed by Adam Roben.

        * page/inspector/ElementsPanel.js:
        (WebInspector.ElementsPanel.prototype.set rootDOMNode): Use objectsAreSame
        to compare nodes.
        (WebInspector.ElementsPanel.prototype.set focusedDOMNode): Ditto.
        (WebInspector.ElementsPanel.prototype.set hoveredDOMNode): Ditto.
        (WebInspector.ElementsPanel.prototype._updateModifiedNodes): Ditto.
        (WebInspector.ElementsPanel.prototype.revealNode): Ditto.
        (WebInspector.ElementsPanel.prototype.updateBreadcrumb): Ditto.
        (WebInspector.DOMNodeTreeElement.prototype.updateChildren): Ditto.
        * page/inspector/treeoutline.js:
        (TreeOutline.prototype.findTreeElement): Add an equal argument
        to accept a functions to compare two representedObjects. Defaults
        to strict equal if not supplied. All current clients pass objectsAreSame.
        * page/inspector/utilities.js:
        (Node.prototype.enclosingNodeOrSelfWithNodeNameInArray): Use objectsAreSame
        to compare nodes.
        (Node.prototype.enclosingNodeOrSelfWithClass): Ditto.
        (Element.prototype.query): Use the ownerDocument of the node, not document.
        (objectsAreSame): Added. Compares strict equal first, then uses isSameNode if
        it exists on both objects.
        (isAncestorNode): Use objectsAreSame to compare nodes.
        (firstCommonNodeAncestor): Ditto.
        (traverseNextNode): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Added InspectorController.isWindowVisible to the JavaScript class
timothy@apple.com [Thu, 24 Jul 2008 02:47:45 +0000 (02:47 +0000)]
    Added InspectorController.isWindowVisible to the JavaScript class
        for use in an upcoming change. This will allow the Inspector to not
        perform selective actions while the window is hidden.

        Reviewed by Adam Roben.

        * page/InspectorController.cpp:
        (WebCore::isWindowVisible): Call InspectorController::windowVisible.
        (WebCore::InspectorController::windowScriptObjectAvailable): Add
        the isWindowVisible function to the JavaScript class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Added TreeOutline.removeChildAtIndex and TreeElement.removeChildAtIndex
timothy@apple.com [Thu, 24 Jul 2008 02:47:33 +0000 (02:47 +0000)]
    Added TreeOutline.removeChildAtIndex and TreeElement.removeChildAtIndex
        for efficiency of callers that know the index of the child. This
        will be used in an upcoming change.

        Reviewed by Adam Roben.

        * page/inspector/treeoutline.js:
        (TreeOutline._removeChildAtIndex): Renamed from _removeChild
        and modified to take an index.
        (TreeOutline._removeChild): Call _removeChildAtIndex with the
        child index found using indexOf.
        (TreeOutline.prototype.removeChildAtIndex): Added. Calls
        TreeOutline._removeChildAtIndex.
        (TreeElement.prototype.removeChildAtIndex): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fixes a regression where TreeOutline.findTreeElement would
timothy@apple.com [Thu, 24 Jul 2008 02:46:58 +0000 (02:46 +0000)]
    Fixes a regression where TreeOutline.findTreeElement would
        return the parent TreeElement of the representedObject instead
        of the TreeElement for the representedObject. Regressed with the
        fix for bug 19164.

        Reviewed by Adam Roben.

        * page/inspector/treeoutline.js:
        (TreeOutline.prototype.findTreeElement): When performing a slow search,
        do a final search for representedObject instead of returning item, which
        is the parent of representedObject.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agospeculative build fix
barraclough@apple.com [Thu, 24 Jul 2008 02:45:47 +0000 (02:45 +0000)]
speculative build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Windows build fixes
aroben@apple.com [Thu, 24 Jul 2008 01:00:35 +0000 (01:00 +0000)]
    Windows build fixes

        Build fix after r35293:

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Add API/
        to the include path.

        Build fix after r35305:

        * VM/Machine.cpp:
        * VM/Machine.h:
        * VM/Opcode.cpp:
        * VM/Opcode.h:
        Completely compile out all sampler-related code when
        SAMPLING_TOOL_ENABLED is 0. The sampler code can't be compiled 1) on
        non-AllInOne configurations due to circular header dependencies, and
        2) on platforms that don't have a usleep() function, such as Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoImprove switch performance.
oliver@apple.com [Thu, 24 Jul 2008 00:49:46 +0000 (00:49 +0000)]
Improve switch performance.

Reviewed by Geoff Garen and Sam Weinig.

Improve switch performance by converting to a hashmap based jump
table to avoid the sequence of dispatches that would otherwise be
needed.  This results in a 9-19x performance win for string switches
based on ad hoc testing, and a 6x improvement for integer switch
statements.  SunSpider reports a 1.2% progression.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
adele@apple.com [Thu, 24 Jul 2008 00:35:06 +0000 (00:35 +0000)]
WebCore:

2008-07-23  Adele Peterson  <adele@apple.com>

        Reviewed by Adam.

        WebCore part of fix for <rdar://problem/5698672>  Add drawing callback for a WebKit app to draw its own scrollbars

        * WebCore.base.exp: Added symbols.
        * page/Chrome.cpp:
        (WebCore::ChromeClient::paintCustomScrollbar): Added. Calls up to WebKit, which will call a new delegate method.
        (WebCore::ChromeClient::paintCustomScrollCorner): ditto.
        * page/ChromeClient.h:
        * page/Settings.cpp:
        (WebCore::Settings::Settings): Added the ability to store whether or not the application has decided to draw its own scrollbars.
        (WebCore::Settings::setShouldPaintCustomScrollbars):
        * page/Settings.h: (WebCore::Settings::shouldPaintCustomScrollbars):
        * platform/ScrollBar.h: Moved ScrollbarControlSize enum to ScrollTypes.h
        * platform/ScrollTypes.h: (WebCore::): Moved some existing types, and added new ones to be used in WebCore in WebKit.
        * platform/win/PlatformScrollBar.h: Moved ScrollbarPart enum to ScrollTypes.h
        * platform/win/PlatformScrollBarSafari.cpp:
        (WebCore::ScrollbarPartToScrollBarPiece): Added helper function.
        (WebCore::ScrollBarPieceMaskToScrollbarControlPartMask): ditto.
        (WebCore::ScrollbarControlStateFromThemeState): ditto.
        (WebCore::PlatformScrollbar::paint): Consolidated painting so the logic for the individual pieces is all in one place.
         Added new code to paint the custom scrollbars if necessary.
        * platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::paint): Added code to paint the custom scroll corner if necessary.

WebKit/win:

2008-07-17  Adele Peterson  <adele@apple.com>

        Reviewed by Adam.

        WebKit part of fix for <rdar://problem/5698672>  Add drawing callback for a WebKit app to draw its own scrollbars

        Added a setting so an application can tell WebKit its going to draw custom scrollbars.  Also added delegate methods for the actual painting.

        * Interfaces/IWebPreferences.idl:  Added setShouldPaintCustomScrollbars and shouldPaintCustomScrollbars.
        * Interfaces/IWebScrollBarPrivate.idl: Moved types to WebScrollbarTypes.idl
        * Interfaces/IWebUIDelegate.idl: Added WebUIDelegate4 with new delegate methods, paintCustomScrollbar and paintCustomScrollCorner
        * Interfaces/WebKit.idl: Include new WebScrollbarTypes.idl
        * Interfaces/WebScrollbarTypes.idl: Added. Has types that the new delegate methods use.
        * WebCoreSupport/WebChromeClient.cpp:
        (WebChromeClient::paintCustomScrollbar): Added. Calls new delegate method and converts between WebCore types and types exported in WebScrollbarTypes.idl
        (WebChromeClient::paintCustomScrollCorner): Added. Calls new delegate method.
        (WebChromeClient::uiDelegate4): Added.
        * WebCoreSupport/WebChromeClient.h:
        * WebPreferenceKeysPrivate.h: Added WebKitPaintCustomScrollbarsPreferenceKey
        * WebPreferences.cpp:
        (WebPreferences::): Added.
        (WebPreferences::shouldPaintCustomScrollbars): Added.
        * WebPreferences.h:
        * WebView.cpp: (WebView::notifyPreferencesChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-23 Dean Jackson <dino@apple.com>
dino@apple.com [Thu, 24 Jul 2008 00:33:22 +0000 (00:33 +0000)]
2008-07-23  Dean Jackson  <dino@apple.com>

        Reviewed by Dan Bernstein.

        Update computed style test for transform to reflect that
        we return "none" rather than identity matrix.

        * svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agobuild fix.
adele@apple.com [Wed, 23 Jul 2008 23:15:04 +0000 (23:15 +0000)]
build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-23 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Wed, 23 Jul 2008 22:36:39 +0000 (22:36 +0000)]
2008-07-23  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Geoff Garen.

        Sampling tool to analyze cost of instruction execution and identify hot regions of JS code.
        Enable Switches by setting SAMPLING_TOOL_ENABLED in Opcode.h.

        * JavaScriptCore.exp: Export symbols for Shell.cpp.
        * VM/Machine.cpp:     Added sampling hooks.
        * VM/Machine.h:       Machine contains a pointer to a sampler, when sampling.
        * VM/Opcode.cpp:      Tool implementation.
        * VM/Opcode.h:        Tool declaration.
        * kjs/Shell.cpp:      Initialize the sampler, if enabled.
        * kjs/nodes.cpp:      Added sampling hooks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-23 Sam Weinig <sam@webkit.org>
weinig@apple.com [Wed, 23 Jul 2008 22:32:24 +0000 (22:32 +0000)]
2008-07-23  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Cleanup and pack the member variables in Node.

        * bindings/js/JSNodeCustom.cpp:
        (WebCore::JSNode::mark):
        * dom/Attr.cpp:
        (WebCore::Attr::Attr):
        * dom/Attr.h:
        (WebCore::Attr::specified):
        (WebCore::Attr::setSpecified):
        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::setFocus):
        * dom/Document.cpp:
        (WebCore::Document::adoptNode):
        * dom/Element.cpp:
        (WebCore::Element::~Element):
        (WebCore::Element::rareData):
        (WebCore::Element::createRareData):
        * dom/Element.h:
        (WebCore::Element::hasRareData):
        (WebCore::Element::setHasRareData):
        * dom/Node.h:
        (WebCore::Node::setIsLink):
        (WebCore::Node::inSubtreeMark):
        (WebCore::Node::setInSubtreeMark):
        (WebCore::Node::attrWasSpecifiedOrElementHasRareData):
        (WebCore::Node::setAttrWasSpecifiedOrElementHasRareData):
        * html/HTMLAnchorElement.cpp:
        (WebCore::HTMLAnchorElement::supportsFocus):
        (WebCore::HTMLAnchorElement::isFocusable):
        (WebCore::HTMLAnchorElement::defaultEventHandler):
        (WebCore::HTMLAnchorElement::parseMappedAttribute):
        (WebCore::HTMLAnchorElement::isLiveLink):
        * html/HTMLImageElement.cpp:
        (WebCore::HTMLImageElement::parseMappedAttribute):
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::setInputType):
        * html/HTMLTableElement.cpp:
        (WebCore::HTMLTableElement::attach):
        * svg/SVGAElement.cpp:
        (WebCore::SVGAElement::svgAttributeChanged):
        (WebCore::SVGAElement::defaultEventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-23 Kevin Calhoun <kcalhoun@apple.com>
adele@apple.com [Wed, 23 Jul 2008 21:45:51 +0000 (21:45 +0000)]
2008-07-23  Kevin Calhoun  <kcalhoun@apple.com>

        Reviewed by Adele.

        Follow-up fix for <rdar://problem/6031039> don't disable track-types when media is in a standalone document

        Associate MovieControllers with Movies to support all of the media types QuickTime is able to play in standalone media documents.

        * platform/graphics/win/QTMovieWin.cpp:
        (QTMovieWinPrivate::QTMovieWinPrivate):
        (QTMovieWinPrivate::~QTMovieWinPrivate):
        (QTMovieWinPrivate::task):
        (QTMovieWinPrivate::createMovieController):
        (QTMovieWinPrivate::createGWorld):
        (QTMovieWinPrivate::setSize):
        (QTMovieWinPrivate::deleteGWorld):
        (QTMovieWin::play):
        (QTMovieWin::pause):
        (QTMovieWin::setRate):
        (QTMovieWin::setCurrentTime):
        (QTMovieWin::load):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-23 Kevin Calhoun <kcalhoun@apple.com>
adele@apple.com [Wed, 23 Jul 2008 21:40:54 +0000 (21:40 +0000)]
2008-07-23  Kevin Calhoun  <kcalhoun@apple.com>

        Reviewed by Adele.

        Added a debug mode for viewing frames per second for videos.  This is controlled by two
        independent compiler flags DRAW_FRAME_RATE in MediaPlayerPrivateQTKit.h and MediaPlayerPrivateQuickTimeWin.h.
        Unless either flags is turned on there is no change to the code for video frame drawing.

        * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
        (WebCore::MediaPlayerPrivate::play):
        (WebCore::MediaPlayerPrivate::pause):
        (WebCore::MediaPlayerPrivate::didEnd):
        (WebCore::MediaPlayerPrivate::repaint):
        (WebCore::MediaPlayerPrivate::paint):
        * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
        (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
        (WebCore::MediaPlayerPrivate::play):
        (WebCore::MediaPlayerPrivate::pause):
        (WebCore::MediaPlayerPrivate::didEnd):
        (WebCore::MediaPlayerPrivate::paint):
        (WebCore::MediaPlayerPrivate::movieNewImageAvailable):
        * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-23 Adele Peterson <adele@apple.com>
adele@apple.com [Wed, 23 Jul 2008 21:30:42 +0000 (21:30 +0000)]
2008-07-23  Adele Peterson  <adele@apple.com>

        Reviewed by Sam.

        Fix for <rdar://problem/6080634> use lower quality CG interpolation in MediaPlayerPrivateQTKit to improve performance

        * platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawImage):
        Call setImageInterpolationQuality(InterpolationNone) instead of setUseLowQualityImageInterpolation(true).
        * platform/graphics/GraphicsContext.h:
        (WebCore::): Added InterpolationQuality enum.
        (WebCore::GraphicsContext::setImageInterpolationQuality): Renamed from setUseLowQualityImageInterpolation.
        The implementation was always setting the quality to "none", and now we want to distinguish between "none" and "low".
        (WebCore::GraphicsContext::imageInterpolationQuality): Renamed from useLowQualityImageInterpolation.
        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::setImageInterpolationQuality): Added.
        (WebCore::GraphicsContext::imageInterpolationQuality): Added.
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::paint):
        Calls setImageInterpolationQuality(InterpolationLow) which will improve the painting performance without degrading quality too much.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-23 Sam Weinig <sam@webkit.org>
weinig@apple.com [Wed, 23 Jul 2008 21:28:53 +0000 (21:28 +0000)]
2008-07-23  Sam Weinig  <sam@webkit.org>

        Reviewed by Dan Bernstein.

        Remove tiger specific result for toDataURL-supportedTypes.html as it should have the
        same results on all platforms.

        * platform/mac-tiger/fast/canvas: Removed.
        * platform/mac-tiger/fast/canvas/toDataURL-supportedTypes-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-23 Sam Weinig <sam@webkit.org>
weinig@apple.com [Wed, 23 Jul 2008 20:13:04 +0000 (20:13 +0000)]
2008-07-23  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Remove extraneous allocations by using equalIgnoringCase rather than
        String::lower.

        * dom/StyledElement.cpp:
        (WebCore::StyledElement::addCSSColor):
        * html/HTMLCollection.cpp:
        (WebCore::HTMLCollection::checkForNameMatch):
        * html/HTMLFormCollection.cpp:
        (WebCore::HTMLFormCollection::getNamedFormItem):
        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::tokenizeRelAttribute):
        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::containsJavaApplet):
        * html/PreloadScanner.cpp:
        (WebCore::PreloadScanner::emitCSSRule):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::createJavaAppletWidget):
        * page/DOMSelection.cpp:
        (WebCore::DOMSelection::modify):
        * rendering/RenderPartObject.cpp:
        (WebCore::RenderPartObject::updateWidget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-23 Maxime Britto <britto@apple.com>
britto@apple.com [Wed, 23 Jul 2008 20:12:09 +0000 (20:12 +0000)]
2008-07-23  Maxime Britto  <britto@apple.com>

        Reviewed by Adam Roben.

        <rdar://6092952> "REGRESSION: Crash beneath EventHandler::stopAutoscrollTimer() when closing Gmail"
        Add a check for the m_page member value before asking for page()->mainFrame()

        * page/EventHandler.cpp:
        (WebCore::EventHandler::stopAutoscrollTimer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-23 Kevin Calhoun <kcalhoun@apple.com>
adele@apple.com [Wed, 23 Jul 2008 18:16:19 +0000 (18:16 +0000)]
2008-07-23  Kevin Calhoun  <kcalhoun@apple.com>

       Reviewed by Adele.

       Fix for <rdar://problem/5710065> QT movies should be inactive when opened

       Implemented deferral of set-up of video rendering on Mac until the ready state is Loaded and
       until after movie tracks of unsupported types have been disabled, to make sure they never draw.

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::load):
        (WebCore::MediaPlayerPrivate::updateStates):
        (WebCore::MediaPlayerPrivate::setVisible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-22 Maxime Britto <britto@apple.com>
britto@apple.com [Wed, 23 Jul 2008 16:48:47 +0000 (16:48 +0000)]
2008-07-22  Maxime Britto  <britto@apple.com>

        Reviewed by John Sullivan.

        <rdar://problem/6083116>
        When pan-scrolling, Back then Forward causes pan-scrolling to start again

        * page/Frame.cpp:
        (WebCore::Frame::clearTimers): Ask to stop the autoscroll timer when we clear the timers from the frame
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::scrollToAnchor): When the link is an anchor we Frame::clearTimers() isn't called since we're only scrolling the page so we need to ask to stop the autoscroll timer here too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-23 Gabor Loki <loki@inf.u-szeged.hu>
ddkilzer@apple.com [Wed, 23 Jul 2008 15:00:17 +0000 (15:00 +0000)]
2008-07-23  Gabor Loki  <loki@inf.u-szeged.hu>

        Bug 20097: [Qt] 20% Sunspider slow-down

        <https://bugs.webkit.org/show_bug.cgi?id=20097>

        Reviewed by Simon Hausmann.

        * kjs/jsc.pro: Added missing NDEBUG define for release builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Geoff Garen.
ap@webkit.org [Wed, 23 Jul 2008 10:15:16 +0000 (10:15 +0000)]
    Reviewed by Geoff Garen.

        JSClassRef is created context-free, but gets infatuated with the first context it sees.

        The implicit API contract is that JSClassRef can be used with any context on any thread.
        This no longer worked, because UStrings in the class were turned into per-context
        identifiers, and the cached JSObject prototype was tied to JSGlobalData, too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Build fix.
ap@webkit.org [Wed, 23 Jul 2008 08:21:20 +0000 (08:21 +0000)]
    Build fix.

        * kjs/ArgList.h: (KJS::ArgList::operator new): removed an extraneous "ArgList::" inside the
        class definition.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
ggaren@apple.com [Wed, 23 Jul 2008 05:10:05 +0000 (05:10 +0000)]
JavaScriptCore:

2008-07-22  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt and Sam Weinig.

        Next step toward putting doubles in registers: Prepare the Register class
        and its clients for registers that don't contain JSValue*s.

        This means a few things:

        1. Register::jsValue() clients, including ArgList clients, must now supply
        an ExecState* when accessing an entry in an ArgList, in case the entry
        will need to create a JSValue* on the fly.

        2. Register clients that definitely don't want to create a JSValue* on
        the fly now use different APIs: getJSValue() for clients that know
        the register contains a JSValue*, and v() for clients who just want a
        void*.

        3. I had to change some headers around in order to resolve dependency
        problems created by using a Register in the ArgList header.

        SunSpider reports no change.

JavaScriptGlue:

2008-07-22  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt and Sam Weinig.

        Next step toward putting doubles in registers: Prepare the Register class
        and its clients for registers that don't contain JSValue*s.

WebCore:

2008-07-22  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt and Sam Weinig.

        Next step toward putting doubles in registers: Prepare the Register class
        and its clients for registers that don't contain JSValue*s.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
weinig@apple.com [Wed, 23 Jul 2008 03:11:15 +0000 (03:11 +0000)]
WebCore:

2008-07-22  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        <rdar://problem/5788451> toDataURL not implemented for Windows (need mapping of MIME type to UTI)
        Add additional support for JPEG and GIF for toDataURL encoding canvases.

        * platform/MIMETypeRegistry.cpp:
        (WebCore::initializeSupportedImageMIMETypesForEncoding):
        * platform/graphics/cg/ImageBufferCG.cpp:
        (WebCore::utiFromMIMEType):

LayoutTests:

2008-07-22  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        <rdar://problem/5788451> toDataURL not implemented for Windows (need mapping of MIME type to UTI)
        Add additional support for JPEG and GIF for toDataURL encoding canvases.

        - Turn on and simplify toDataURL-supportedTypes.html to only test for support of mimeTypes and not
          fail due to differences in image encoders.

        * fast/canvas/toDataURL-supportedTypes-expected.txt:
        * fast/canvas/toDataURL-supportedTypes.html: Copied from fast/canvas/toDataURL-supportedTypes.html-disabled.
        * fast/canvas/toDataURL-supportedTypes.html-disabled: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/6004877> internal anchors on this page are not showing up in the...
cfleizach@apple.com [Tue, 22 Jul 2008 21:45:53 +0000 (21:45 +0000)]
<rdar://problem/6004877> internal anchors on this page are not showing up in the AXLinkedUIElements

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-22 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 22 Jul 2008 20:23:10 +0000 (20:23 +0000)]
2008-07-22  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Allocate the empty StringImpl from the heap.

        * platform/text/StringImpl.cpp:
        (WebCore::StringImpl::empty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-21 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Tue, 22 Jul 2008 17:25:55 +0000 (17:25 +0000)]
2008-07-21  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Tim.

        <rdar://problem/5951532> JSProfiler: Implement heavy (or bottom-up)
        view (19228)
        - Implement UI for Heavy (Bottom Up) view.

        * English.lproj/localizedStrings.js:
        * page/JavaScriptProfile.cpp: Expose the ability to get a heavy/tree
        profile from a profile to the Web Inspector's JavaScript.
        (WebCore::getHeavyProfileCallback):
        (WebCore::getTreeProfileCallback):
        (WebCore::ProfileClass):
        * page/inspector/ProfileView.js: Implement the dropdown for changing
        profile views.
        * page/inspector/inspector.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Adam Roben.
ap@webkit.org [Tue, 22 Jul 2008 15:51:34 +0000 (15:51 +0000)]
    Reviewed by Adam Roben.

        <rdar://problem/5955602> WebKit should support charset name x-windows-949

        Test: fast/encoding/char-decoding.html

        * platform/text/TextCodecICU.cpp:
        (WebCore::TextCodecICU::registerExtendedEncodingNames): Added support for this name for
        Firefox compatibility.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
barraclough@apple.com [Tue, 22 Jul 2008 14:26:01 +0000 (14:26 +0000)]
JavaScriptCore:

2008-07-22  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Alexey Proskuryakov.

        Prevent integer overflow when reallocating storage vector for arrays.

        Sunspider reports 1.005x as fast (no change expected).

        * kjs/JSArray.cpp:

WebCore:

2008-07-22  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Alexey Proskuryakov.

        New test to check that arrays fail gracefully (throw an out of memory exception)
        when the vector grows to large.

        * manual-tests/array-out-of-memory.html:         Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Dan Bernstein.
ap@webkit.org [Tue, 22 Jul 2008 05:52:09 +0000 (05:52 +0000)]
    Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=20117
        setBaseAndExtent fails to reverse the current selection

        Test: editing/selection/setBaseAndExtent-revert-selection.html

        * editing/Selection.h: (WebCore::operator==): Compare direction, too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowx build fix. Fix pthread linkage under Linux.
kevino@webkit.org [Tue, 22 Jul 2008 04:35:20 +0000 (04:35 +0000)]
wx build fix. Fix pthread linkage under Linux.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
jchaffraix@webkit.org [Tue, 22 Jul 2008 01:43:10 +0000 (01:43 +0000)]
WebCore:

2008-07-21  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Sam Weinig.

        Bug 19919: Add selectors' string parsing in CSSParser
        https://bugs.webkit.org/show_bug.cgi?id=19919

        No functional change.

        * css/CSSGrammar.y: Added entry for parsing only a selector.
        * css/CSSParser.cpp:
        (WebCore::CSSParser::CSSParser):
        (WebCore::CSSParser::parseSelector):
        * css/CSSParser.h: Added m_floatingSelector to hold the
        Selector parsed in parseSelector.

        * css/tokenizer.flex: Added "@-webkit-selector" token.
        * dom/Node.cpp:
        (WebCore::Node::querySelector):
        (WebCore::Node::querySelectorAll): Switched to parseSelector
        method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-21 Kevin Calhoun <kcalhoun@apple.com>
adele@apple.com [Tue, 22 Jul 2008 01:19:19 +0000 (01:19 +0000)]
2008-07-21  Kevin Calhoun  <kcalhoun@apple.com>

        Reviewed by Adele.

        Fix for <rdar://problem/6081160> REGRESSION: Hang loading many pages if QuickTime isn't installed

        * platform/graphics/win/QTMovieWin.cpp:
        (initializeSupportedTypes): Do a Quicktime version minimum version check.
        (QTMovieWin::initializeQuickTime): Store the Quicktime version globally so in can be used in initializeSupportedTypes as well.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-21 Kevin Calhoun <kcalhoun@apple.com>
adele@apple.com [Tue, 22 Jul 2008 01:09:09 +0000 (01:09 +0000)]
2008-07-21  Kevin Calhoun  <kcalhoun@apple.com>

        Reviewed by Adele.

        Fix for <rdar://problem/5713336> <video> and <audio> elements that use a autoplay attribute fail to start playing when returning back to page

        * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::willSaveToCache): Reset the ready state to DATA_UNAVAILABLE when saving to the cache
        so that everything starts back up normally when the page is retrieved from the cache.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Mark Rowe.
weinig@apple.com [Tue, 22 Jul 2008 01:06:01 +0000 (01:06 +0000)]
    Reviewed by Mark Rowe.

        Remove unused interface declaration.

        * platform/network/mac/ResourceHandleMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/6091287> Revamp the handling of CFBundleShortVersionString to be...
mrowe@apple.com [Tue, 22 Jul 2008 01:05:12 +0000 (01:05 +0000)]
<rdar://problem/6091287> Revamp the handling of CFBundleShortVersionString to be fixed at the major component of the version number.

Reviewed by Sam Weinig.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-21 Kevin Calhoun <kcalhoun@apple.com>
adele@apple.com [Tue, 22 Jul 2008 01:02:13 +0000 (01:02 +0000)]
2008-07-21  Kevin Calhoun  <kcalhoun@apple.com>

        Reviewed by Adele.

        Fix for <rdar://problem/6031039> don't disable track-types when media is in a standalone document

        * platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::inMediaDocument): Added.
        * platform/graphics/MediaPlayer.h:
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::updateStates):
        * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::updateStates):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-21 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 22 Jul 2008 00:41:02 +0000 (00:41 +0000)]
2008-07-21  Anders Carlsson  <andersca@apple.com>

        Reviewed by Jon.

        Don't allow requests to be made when the document loader is stopping all loaders.

        * plugins/PluginView.cpp:
        (WebCore::PluginView::load):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebKit/mac:
andersca@apple.com [Mon, 21 Jul 2008 23:07:30 +0000 (23:07 +0000)]
WebKit/mac:

2008-07-21  Anders Carlsson  <andersca@apple.com>

        Reviewed by Geoff.

        <rdar://problem/5820667>
        CrashTracer: [USER] 3759 crashes in Safari at FrameLoader::activeDocumentLoader const + 6 while canceling plug-in load

        Don't allow URLs to be loaded in response to an NPP_DestroyStream that happens when tearing down the plug-in.

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):

LayoutTests:

2008-07-21  Anders Carlsson  <andersca@apple.com>

        Reviewed by Geoff.

        <rdar://problem/5820667>
        CrashTracer: [USER] 3759 crashes in Safari at FrameLoader::activeDocumentLoader const + 6 while canceling plug-in load

        * http/tests/plugins/geturlnotify-from-npp-destroystream-expected.txt: Added.
        * http/tests/plugins/geturlnotify-from-npp-destroystream.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-20 Maxime Britto <britto@apple.com>
britto@apple.com [Mon, 21 Jul 2008 20:23:48 +0000 (20:23 +0000)]
2008-07-20  Maxime Britto  <britto@apple.com>

        Reviewed by John Sullivan.

        [PFR] <rdar://problem/6080639> New middle click scrolling speed seems much slower than in FF
        Accelerate and enhance the smoothness of the pan scrollling.

        * page/EventHandler.cpp: Changed the TimerInterval from 0.1 to 0.05. The scrolling is way more fluid like this.
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::panScrollFromPoint): Differentiate the speed within a 200 pixel side square, around the original click location to the speed for farther distances. This way we allow easyier handle when we are close to the center and very fast scrolling when we go far from the original point.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-18 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Mon, 21 Jul 2008 20:16:38 +0000 (20:16 +0000)]
2008-07-18  David Hyatt  <hyatt@apple.com>

        Change the cached clip rects to not assume they should be infinite when the root layer has been
        shifted as the result of a transformation.

        Reviewed by Maciej

        Added fast/transforms/overflow-with-transform.html

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::calculateClipRects):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Mitz.
rwlbuis@webkit.org [Mon, 21 Jul 2008 20:15:08 +0000 (20:15 +0000)]
    Reviewed by Mitz.

        https://bugs.webkit.org/show_bug.cgi?id=19966
        CSS variables crash when using hex notation for colors

        Support hex colors as values for the css variables.

        Test: fast/css/variables/color-hex-test.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUpdate Akismet plugin to 2.1.6.
mrowe@apple.com [Mon, 21 Jul 2008 18:29:24 +0000 (18:29 +0000)]
Update Akismet plugin to 2.1.6.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUpdate to WordPress 2.6.
mrowe@apple.com [Mon, 21 Jul 2008 18:16:22 +0000 (18:16 +0000)]
Update to WordPress 2.6.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Add Vector::find
aroben@apple.com [Mon, 21 Jul 2008 17:43:05 +0000 (17:43 +0000)]
    Add Vector::find

        This is a convenience wrapper around std::find.

        Reviewed by Anders Carlsson.

        * wtf/Vector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/5624143> WebView printing doesn't work correctly in x86_64
mrowe@apple.com [Mon, 21 Jul 2008 15:13:25 +0000 (15:13 +0000)]
<rdar://problem/5624143> WebView printing doesn't work correctly in x86_64

Fix the return type of an NSView method that we override so that the correct data type is used in 64-bit.
This prevents a garbage value being used for the scale factor that the NSView print machinery applies.

Reviewed by Adam Roben.

* WebView/WebHTMLView.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix CallDelegateReturningFloat for x86_64.
mrowe@apple.com [Mon, 21 Jul 2008 15:13:22 +0000 (15:13 +0000)]
Fix CallDelegateReturningFloat for x86_64.

The x86_64 Objective-C runtime only uses objc_msgSend_fpret for
long double return values.  For float return values the standard
objc_msgSend is used, as on ppc and ppc64.

Reviewed by Adam Roben.

* WebView/WebView.mm: Use objc_msgSend_float_return as the name of our version of
objc_msgSend with the correct return type.  We can no longer call it objc_msgSend_fpret
as that method is defined by the Objective-C runtime for x86_64.
(CallDelegateReturningFloat):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRoll out r35261
barraclough@apple.com [Mon, 21 Jul 2008 14:45:40 +0000 (14:45 +0000)]
Roll out r35261

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-21 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Mon, 21 Jul 2008 13:47:04 +0000 (13:47 +0000)]
2008-07-21  Simon Hausmann  <hausmann@webkit.org>

        Reviewed by Holger.

        Fix drawing of windowless plugins on Windows with the Qt port by
        avoiding the reset of the translation of the HDC to 0, 0.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-21 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Mon, 21 Jul 2008 13:46:45 +0000 (13:46 +0000)]
2008-07-21  Simon Hausmann  <hausmann@webkit.org>

        Reviewed by Holger.

        Fix rendering of transparent windowless netscape plugins by passing
        the right conversion parameter to QPixmap::fromWinHBITMAP when
        converting from HBITMAP to QPixmap.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-21 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Mon, 21 Jul 2008 13:46:23 +0000 (13:46 +0000)]
2008-07-21  Simon Hausmann  <hausmann@webkit.org>

        Reviewed by Holger.

        In the implementation of getValue for NPNVnetscapeWindow treat
        windowHandleForPlatformWidget on the return value of
        containingWindow() to receive the correct HWND for the Qt port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-21 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Mon, 21 Jul 2008 13:46:03 +0000 (13:46 +0000)]
2008-07-21  Simon Hausmann  <hausmann@webkit.org>

        Reviewed by Holger.

        Fix windowHandleForPlatformWidget to return 0 as HWND if we don't have
        a QWidget. This can happen on page/view destruction for example.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
ddkilzer@apple.com [Mon, 21 Jul 2008 09:34:36 +0000 (09:34 +0000)]
WebCore:

2008-07-21  Anatoli Papirovski  <apapirovski@mac.com>

        Reviewed by Dave Hyatt.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=14346
        Modified the css parser:
        - not to fail when closing braces are not found for
          a declaration at the end of the file
        - not to accept "!important fail" as valid
        - to keep accepting @import when it comes after invalid @ rules
        - not to drop the whole @media block when there's an error before the
          closing brace
        + some other minor css parsing revisions.

        * css/CSSGrammar.y:

LayoutTests:

2008-07-21  Anatoli Papirovski  <apapirovski@mac.com>

        Reviewed by Dave Hyatt.

        Updated layout CSS2.1 test suite tests related to css parsing:
        https://bugs.webkit.org/show_bug.cgi?id=14346

        * platform/mac/css2.1/t040105-import-01-b-expected.checksum:
        * platform/mac/css2.1/t040105-import-01-b-expected.png:
        * platform/mac/css2.1/t040105-import-01-b-expected.txt:
        * platform/mac/css2.1/t0402-syntax-05-f-expected.checksum:
        * platform/mac/css2.1/t0402-syntax-05-f-expected.png:
        * platform/mac/css2.1/t0402-syntax-05-f-expected.txt:
        * platform/mac/css2.1/t0402-syntax-06-f-expected.checksum:
        * platform/mac/css2.1/t0402-syntax-06-f-expected.png:
        * platform/mac/css2.1/t0402-syntax-06-f-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Touch file to force rebuild for vsprops change.
sfalken@apple.com [Mon, 21 Jul 2008 03:39:12 +0000 (03:39 +0000)]
    Touch file to force rebuild for vsprops change.

        * WebCorePrefix.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Build fix.
sfalken@apple.com [Mon, 21 Jul 2008 03:38:15 +0000 (03:38 +0000)]
    Build fix.

        * win/tools/vsprops/common.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35259 268f45cc-cd09-0410-ab3c-d52691b4dbfc