WebKit-https.git
10 years ago2011-03-30 Ryuan Choi <ryuan.choi@samsung.com>
commit-queue@webkit.org [Thu, 31 Mar 2011 03:46:54 +0000 (03:46 +0000)]
2011-03-30  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Martin Robinson.

        [GTK] Fix leaked pointer in FontGtk.cpp
        https://bugs.webkit.org/show_bug.cgi?id=57307

        Fix a memory leak.

        No new functionality, so no new tests.

        * platform/graphics/gtk/FontGtk.cpp:
        (WebCore::utf16ToUtf8): Rename utf16_to_utf8 and fix indentation.
        (WebCore::convertUniCharToUTF8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 David Levin <levin@chromium.org>
levin@chromium.org [Thu, 31 Mar 2011 03:24:49 +0000 (03:24 +0000)]
2011-03-30  David Levin  <levin@chromium.org>

        Reviewed by Dmitry Titov.

        UnlockNonLocked condition reached in WorkerFileSystemsCallbackBridge::mayPostTaskToWorker
        https://bugs.webkit.org/show_bug.cgi?id=57382

        There were two issues to address:
        1. The use of a non-thread safe class (RefPtr) in a ThreadSafeRefCounted class.
           The problem was that this RefPtr could be changed on either thread.
        2. Keeping WorkerFileSystemCallbacksBridge alive for while it was being used
           including while its mutex was in use.

        * src/WorkerFileSystemCallbacksBridge.cpp:
        (WebKit::WorkerFileSystemCallbacksBridge::runTaskOnMainThread):
        Changed to take a PassRefPtr and leak the ref count as opposed to relying on
        dispatchTaskToMainThread to store the pointer in m_selfRef.
        (WebKit::WorkerFileSystemCallbacksBridge::dispatchTaskToMainThread): Remove the
        m_selfRef and hand off a PassRefPtr instead.
        (WebKit::WorkerFileSystemCallbacksBridge::mayPostTaskToWorker): Balance out the leaked ref
        and ensure that WorkerFileSystemCallbacksBridge stays alive while the mutex is held.
        * src/WorkerFileSystemCallbacksBridge.h: Removed m_selfRef and derefIfWorkerIsStopped which
          was simply due to m_selfRef.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Rollout r82240 and r82232, because they broke 2 plugin tests.
ossy@webkit.org [Thu, 31 Mar 2011 03:21:54 +0000 (03:21 +0000)]
[Qt] Rollout r82240 and r82232, because they broke 2 plugin tests.

* Source/WebKit.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Thu, 31 Mar 2011 03:19:56 +0000 (03:19 +0000)]
2011-03-30  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed, remove Chromium test expectations for two bugs that are known to be fixed.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove unnecessary Qt specific fast/canvas expected files after r82521.
ossy@webkit.org [Thu, 31 Mar 2011 02:42:13 +0000 (02:42 +0000)]
Remove unnecessary Qt specific fast/canvas expected files after r82521.

* platform/qt/fast/canvas/arc360-expected.txt: Removed.
* platform/qt/fast/canvas/canvas-before-css-expected.txt: Removed.
* platform/qt/fast/canvas/canvas-composite-expected.txt: Removed.
* platform/qt/fast/canvas/canvas-empty-image-pattern-expected.txt: Removed.
* platform/qt/fast/canvas/canvas-incremental-repaint-2-expected.txt: Removed.
* platform/qt/fast/canvas/canvas-resize-reset-expected.txt: Removed.
* platform/qt/fast/canvas/canvas-text-alignment-expected.txt: Removed.
* platform/qt/fast/canvas/canvas-text-baseline-expected.txt: Removed.
* platform/qt/fast/canvas/canvas-transform-identity-expected.txt: Removed.
* platform/qt/fast/canvas/canvas-transform-infinity-expected.txt: Removed.
* platform/qt/fast/canvas/canvas-transform-multiply-expected.txt: Removed.
* platform/qt/fast/canvas/canvas-transform-nan-expected.txt: Removed.
* platform/qt/fast/canvas/canvas-transform-non-invertible-expected.txt: Removed.
* platform/qt/fast/canvas/canvas-transform-skewed-expected.txt: Removed.
* platform/qt/fast/canvas/canvas-transforms-during-path-expected.txt: Removed.
* platform/qt/fast/canvas/canvasDrawingIntoSelf-expected.txt: Removed.
* platform/qt/fast/canvas/drawImage-expected.txt: Removed.
* platform/qt/fast/canvas/drawImage-with-globalAlpha-expected.txt: Removed.
* platform/qt/fast/canvas/fill-stroke-clip-reset-path-expected.txt: Removed.
* platform/qt/fast/canvas/fillrect-gradient-zero-stops-expected.txt: Removed.
* platform/qt/fast/canvas/fillrect_gradient-expected.txt: Removed.
* platform/qt/fast/canvas/gradient-add-second-start-end-stop-expected.txt: Removed.
* platform/qt/fast/canvas/image-object-in-canvas-expected.txt: Removed.
* platform/qt/fast/canvas/image-pattern-rotate-expected.txt: Removed.
* platform/qt/fast/canvas/patternfill-repeat-expected.txt: Removed.
* platform/qt/fast/canvas/quadraticCurveTo-expected.txt: Removed.
* platform/qt/fast/canvas/setWidthResetAfterForcedRender-expected.txt: Removed.
* platform/qt/fast/canvas/shadow-offset-1-expected.txt: Removed.
* platform/qt/fast/canvas/shadow-offset-2-expected.txt: Removed.
* platform/qt/fast/canvas/shadow-offset-3-expected.txt: Removed.
* platform/qt/fast/canvas/shadow-offset-4-expected.txt: Removed.
* platform/qt/fast/canvas/shadow-offset-5-expected.txt: Removed.
* platform/qt/fast/canvas/shadow-offset-6-expected.txt: Removed.
* platform/qt/fast/canvas/shadow-offset-7-expected.txt: Removed.
* platform/qt/fast/canvas/toDataURL-alpha-expected.txt: Removed.
* platform/qt/fast/canvas/zero-size-fill-rect-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Dominic Cooney <dominicc@google.com>
commit-queue@webkit.org [Thu, 31 Mar 2011 02:33:46 +0000 (02:33 +0000)]
2011-03-30  Dominic Cooney  <dominicc@google.com>

        Reviewed by Dimitri Glazkov.

        Adds layoutTestController.shadowRoot accessor to Mac DRT.
        https://bugs.webkit.org/show_bug.cgi?id=57415

        Updates the keygen test to exercise new DRT functionality; skips
        on other ports for now.

        * fast/dom/HTMLKeygenElement/keygen-expected.txt:
        * fast/dom/HTMLKeygenElement/keygen.html:
        * platform/chromium/test_expectations.txt:
        * platform/gtk/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
2011-03-30  Dominic Cooney  <dominicc@google.com>

        Reviewed by Dimitri Glazkov.

        Adds layoutTestController.shadowRoot accessor to Mac DRT.
        https://bugs.webkit.org/show_bug.cgi?id=57415

        * WebCore.exp.in: DRT needs to link WebCore::Element::shadowRoot
2011-03-30  Dominic Cooney  <dominicc@google.com>

        Reviewed by Dimitri Glazkov.

        Adds layoutTestController.shadowRoot accessor to Mac DRT.
        https://bugs.webkit.org/show_bug.cgi?id=57415

        * DOM/WebDOMOperations.mm:
        (-[DOMElement _shadowRoot:]):
        * DOM/WebDOMOperationsPrivate.h:
2011-03-30  Dominic Cooney  <dominicc@google.com>

        Reviewed by Dimitri Glazkov.

        Adds layoutTestController.shadowRoot accessor to Mac DRT.
        https://bugs.webkit.org/show_bug.cgi?id=57415

        * DumpRenderTree/LayoutTestController.cpp:
        (shadowRootCallback):
        (LayoutTestController::staticFunctions):
        * DumpRenderTree/LayoutTestController.h:
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (LayoutTestController::shadowRoot):
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::shadowRoot):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Thu, 31 Mar 2011 02:25:30 +0000 (02:25 +0000)]
2011-03-30  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        Simplify HTMLFormElement::validateInteractively() for asynchronous scroll event
        https://bugs.webkit.org/show_bug.cgi?id=57424

        Remove interactive-validation-lost-focusable.html because it has no
        sense since r75555.

        * fast/forms/interactive-validation-lost-focusable-expected.txt: Removed.
        * fast/forms/interactive-validation-lost-focusable.html: Removed.
        * platform/chromium/test_expectations.txt:
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
2011-03-30  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        Simplify HTMLFormElement::validateInteractively() for asynchronous scroll event
        https://bugs.webkit.org/show_bug.cgi?id=57424

        r75555 made 'scroll' event asynchronous. So we don't need to worry about
        deleting or moving a target node in scrollIntoViewIfNeeded().

        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::validateInteractively): Remove unnecessary code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Thu, 31 Mar 2011 02:21:33 +0000 (02:21 +0000)]
2011-03-30  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        REGRESSION (r74895): Crash if input.type = 'file' twice
        https://bugs.webkit.org/show_bug.cgi?id=57343

        * fast/forms/input-type-change3-expected.txt:
        * fast/forms/script-tests/input-type-change3.js: Add a new test.
2011-03-30  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        REGRESSION (r74895): Crash if input.type = 'file' twice
        https://bugs.webkit.org/show_bug.cgi?id=57343

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::updateType):
          Don't call setAttribute() if the type is not changed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Jia Pu <jpu@apple.com>
commit-queue@webkit.org [Thu, 31 Mar 2011 02:08:34 +0000 (02:08 +0000)]
2011-03-30  Jia Pu  <jpu@apple.com>

        Reviewed by Darin Adler.

        Autocorrection panel isn't positioned correctly in Safari (mac) when the zooming is not 1x.
        https://bugs.webkit.org/show_bug.cgi?id=57353
        <rdar://problem/9163983>

        Updated following test in response to recent change in AppKit spell checker.

        * platform/mac/editing/spelling/delete-autocorrected-word-1-expected.txt:
        * platform/mac/editing/spelling/delete-autocorrected-word-1.html:
2011-03-30  Jia Pu  <jpu@apple.com>

        Reviewed by Darin Adler.

        Autocorrection panel isn't positioned correctly in Safari (mac) when the zooming is not 1x.
        https://bugs.webkit.org/show_bug.cgi?id=57353
        <rdar://problem/9163983>

        We use Range::textQuads() instead of Range::boundingRect() to compute the position of correction
        panel. The latter function compensates for zooming, which we don't need in this case. We also
        dismiss correction panel when zooming factor is changed. This is done in Frame::setPageAndTextZoomFactors().

        * WebCore.exp.in:
        * dom/Range.cpp:
        (WebCore::Range::textQuads):
        * dom/Range.h:
        * editing/Editor.cpp:
        (WebCore::Editor::windowRectForRange):
        * editing/Editor.h:
        * page/Frame.cpp:
        (WebCore::Frame::setPageAndTextZoomFactors):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Chris Guillory <chris.guillory@google.com>
commit-queue@webkit.org [Thu, 31 Mar 2011 01:53:17 +0000 (01:53 +0000)]
2011-03-30  Chris Guillory  <chris.guillory@google.com>

        Reviewed by Dimitri Glazkov.

        Render fonts using skia when requested by platform context.
        https://bugs.webkit.org/show_bug.cgi?id=56441

        * platform/graphics/skia/PlatformContextSkia.cpp:
        (WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
        * platform/graphics/skia/PlatformContextSkia.h:
        * platform/graphics/skia/SkiaFontWin.cpp:
        (WebCore::windowsCanHandleTextDrawing):
        (WebCore::skiaDrawText):
        (WebCore::setupPaintForFont):
        (WebCore::paintSkiaText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 31 Mar 2011 01:48:54 +0000 (01:48 +0000)]
2011-03-30  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Sandbox violations if you navigate a file URL via something other than a click
        <rdar://problem/9016086>
        https://bugs.webkit.org/show_bug.cgi?id=57519

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::shouldReuseCommittedSandboxExtension):
        Remove unnecessary restriction on extension reuse. Any type of file to file navigation
        should be allowed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 31 Mar 2011 01:45:22 +0000 (01:45 +0000)]
2011-03-30  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Clean up the sandbox parameter code
        https://bugs.webkit.org/show_bug.cgi?id=57518

        * Shared/WebProcessCreationParameters.h:
        Make nsURLCachePath and uiProcessBundleResourcePath Strings to match the other paths we send over.

        * UIProcess/mac/WebContextMac.mm:
        (WebKit::WebContext::platformInitializeWebProcess):
        nsURLCachePath and uiProcessBundleResourcePath are now Strings.

        * WebProcess/mac/WebProcessMac.mm:
        (WebKit::appendSandboxParameterPathInternal):
        (WebKit::appendReadwriteConfDirectory):
        (WebKit::appendReadonlySandboxDirectory):
        (WebKit::appendReadwriteSandboxDirectory):
        (WebKit::initializeSandbox):
        Make it more clear whether the directories we're adding are readonly or readwrite. No functionality change.

        (WebKit::WebProcess::platformInitializeWebProcess):
        nsURLCachePath is now a string.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/9199518> Crash when focusing a styled editable element
mitz@apple.com [Thu, 31 Mar 2011 01:32:21 +0000 (01:32 +0000)]
<rdar://problem/9199518> Crash when focusing a styled editable element

Reviewed by Darin Adler.

Source/WebCore:

Test: editing/deleting/delete-button-background-image-none.html

* editing/DeleteButtonController.cpp:
(WebCore::isDeletableElement): Check all background layers for background images.
* rendering/style/RenderStyle.h: Removed backgroundImage() as it was only used, incorrectly,
in the above function.

LayoutTests:

* editing/deleting/delete-button-background-image-none-expected.txt: Added.
* editing/deleting/delete-button-background-image-none.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 31 Mar 2011 01:14:03 +0000 (01:14 +0000)]
2011-03-30  Martin Robinson  <mrobinson@igalia.com>

        Try once more to fix the EFL build.

        * platform/efl/RenderThemeEfl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 31 Mar 2011 01:11:27 +0000 (01:11 +0000)]
2011-03-30  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Downloading a file fails due to a sandbox violation if the destination path is a symlink
        https://bugs.webkit.org/show_bug.cgi?id=57517
        <rdar://problem/8943865>

        Make sure to resolve any symlinks in the given path when creating a sandbox extension handle.
        Note that we can't use realpath or -[NSString stringByResolvingSymlinksInPath], because those calls
        will fail if the pointed to file doesn't exist.

        * Shared/mac/SandboxExtensionMac.mm:
        (WebKit::resolveSymlinksInPath):
        New function that resolves all the symlinks in the given path.

        (WebKit::SandboxExtension::createHandle):
        Call resolveSymlinksInPath on the resulting path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 31 Mar 2011 01:06:24 +0000 (01:06 +0000)]
2011-03-30  Martin Robinson  <mrobinson@igalia.com>

        Fix the GTK+ WebKit2 build.

        * Shared/WebGraphicsContext.cpp:
        (WebKit::WebGraphicsContext::WebGraphicsContext):
        * WebProcess/WebPage/gtk/WebPageGtk.cpp:
        (WebKit::WebPage::platformCanHandleRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRegression: VO cursor doesn't follow KB focus back into HTML view
cfleizach@apple.com [Thu, 31 Mar 2011 00:44:39 +0000 (00:44 +0000)]
Regression: VO cursor doesn't follow KB focus back into HTML view
https://bugs.webkit.org/show_bug.cgi?id=57509

Reviewed by Darin Adler.

In WK2, because the web area never believes focus leave the area, sending the initial
focus change when moving back into the web area, does not trigger a notification.

That behavior needs to be overridden by explicitly posting a focused UI element change
at the appropriate time. This is only used in WK2, hence the absence of a layout test for now.

* page/FocusController.cpp:
(WebCore::FocusController::setInitialFocus):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Darin Adler.
ap@apple.com [Thu, 31 Mar 2011 00:11:30 +0000 (00:11 +0000)]
    Reviewed by Darin Adler.

        WebHTMLView shouldn't resend noop: commands
        https://bugs.webkit.org/show_bug.cgi?id=57504
        <rdar://problem/9209390>

        * WebView/WebHTMLView.mm: (-[WebHTMLView _executeSavedEditingCommands]): Filter out NOOPs,
        which we get e.g. when handling Cmd-key combos.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Thu, 31 Mar 2011 00:11:04 +0000 (00:11 +0000)]
2011-03-30  Mihai Parparita  <mihaip@chromium.org>

        Fix expected svg/ failures for Chromium Snow Leopard.

        * platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-36-t-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.checksum.
        * platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png.
        * platform/chromium-mac-leopard/svg/custom/dynamic-svg-document-creation-expected.checksum: Added.
        * platform/chromium-mac-leopard/svg/custom/dynamic-svg-document-creation-expected.png: Added.
        * platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Discrete-expected.checksum: Added.
        * platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Discrete-expected.png: Added.
        * platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Gamma-expected.checksum: Added.
        * platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Gamma-expected.png: Added.
        * platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Linear-expected.checksum: Added.
        * platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Linear-expected.png: Added.
        * platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Table-expected.checksum: Added.
        * platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Table-expected.png: Added.
        * platform/chromium-mac-leopard/svg/custom/foreign-object-skew-expected.checksum: Added.
        * platform/chromium-mac-leopard/svg/custom/foreign-object-skew-expected.png: Added.
        * platform/chromium-mac-leopard/svg/custom/glyph-transformation-with-hkern-expected.checksum: Added.
        * platform/chromium-mac-leopard/svg/custom/glyph-transformation-with-hkern-expected.png: Added.
        * platform/chromium-mac-leopard/svg/custom/gradient-rotated-bbox-expected.checksum: Added.
        * platform/chromium-mac-leopard/svg/custom/gradient-rotated-bbox-expected.png: Added.
        * platform/chromium-mac-leopard/svg/custom/grayscale-gradient-mask-expected.checksum: Added.
        * platform/chromium-mac-leopard/svg/custom/grayscale-gradient-mask-expected.png: Added.
        * platform/chromium-mac-leopard/svg/custom/js-late-gradient-creation-expected.checksum: Added.
        * platform/chromium-mac-leopard/svg/custom/js-late-gradient-creation-expected.png: Added.
        * platform/chromium-mac-leopard/svg/custom/js-late-pattern-and-object-creation-expected.checksum: Added.
        * platform/chromium-mac-leopard/svg/custom/js-late-pattern-and-object-creation-expected.png: Added.
        * platform/chromium-mac-leopard/svg/custom/js-late-pattern-creation-expected.checksum: Added.
        * platform/chromium-mac-leopard/svg/custom/js-late-pattern-creation-expected.png: Added.
        * platform/chromium-mac-leopard/svg/custom/non-scaling-stroke-expected.checksum: Added.
        * platform/chromium-mac-leopard/svg/custom/non-scaling-stroke-expected.png: Added.
        * platform/chromium-mac-leopard/svg/custom/pattern-skew-transformed-expected.checksum: Added.
        * platform/chromium-mac-leopard/svg/custom/pattern-skew-transformed-expected.png: Added.
        * platform/chromium-mac-leopard/svg/custom/pattern-with-transformation-expected.checksum: Added.
        * platform/chromium-mac-leopard/svg/custom/pattern-with-transformation-expected.png: Added.
        * platform/chromium-mac-leopard/svg/custom/preserve-aspect-ratio-syntax-expected.checksum: Added.
        * platform/chromium-mac-leopard/svg/custom/preserve-aspect-ratio-syntax-expected.png: Added.
        * platform/chromium-mac-leopard/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.checksum: Added.
        * platform/chromium-mac-leopard/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png: Added.
        * platform/chromium-mac-leopard/svg/custom/resource-invalidate-on-target-update-expected.checksum: Added.
        * platform/chromium-mac-leopard/svg/custom/resource-invalidate-on-target-update-expected.png: Added.
        * platform/chromium-mac-leopard/svg/custom/shapes-supporting-markers-expected.checksum: Added.
        * platform/chromium-mac-leopard/svg/custom/shapes-supporting-markers-expected.png: Added.
        * platform/chromium-mac-leopard/svg/custom/svg-curve-with-relative-cordinates-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/custom/svg-curve-with-relative-cordinates-expected.checksum.
        * platform/chromium-mac-leopard/svg/custom/svg-curve-with-relative-cordinates-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/custom/svg-curve-with-relative-cordinates-expected.png.
        * platform/chromium-mac-leopard/svg/custom/svg-fonts-with-no-element-reference-expected.checksum: Added.
        * platform/chromium-mac-leopard/svg/custom/svg-fonts-with-no-element-reference-expected.png: Added.
        * platform/chromium-mac-leopard/svg/custom/use-on-clip-path-with-transformation-expected.checksum: Added.
        * platform/chromium-mac-leopard/svg/custom/use-on-clip-path-with-transformation-expected.png: Added.
        * platform/chromium-mac-leopard/svg/custom/viewbox-syntax-expected.checksum: Added.
        * platform/chromium-mac-leopard/svg/custom/viewbox-syntax-expected.png: Added.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.checksum.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.checksum.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.checksum.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.checksum.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.checksum.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.checksum.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png.
        * platform/chromium-mac-leopard/svg/filters/feDisplacementMap-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/filters/feDisplacementMap-expected.checksum.
        * platform/chromium-mac-leopard/svg/filters/feDisplacementMap-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/filters/feDisplacementMap-expected.png.
        * platform/chromium-mac-leopard/svg/hixie/mixed/006-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/hixie/mixed/006-expected.checksum.
        * platform/chromium-mac-leopard/svg/hixie/mixed/006-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/hixie/mixed/006-expected.png.
        * platform/chromium-mac-leopard/svg/hixie/mixed/008-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/hixie/mixed/008-expected.checksum.
        * platform/chromium-mac-leopard/svg/hixie/mixed/008-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/hixie/mixed/008-expected.png.
        * platform/chromium-mac-leopard/svg/hixie/mixed/011-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/hixie/mixed/011-expected.checksum.
        * platform/chromium-mac-leopard/svg/hixie/mixed/011-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/hixie/mixed/011-expected.png.
        * platform/chromium-mac-leopard/svg/text/text-intro-05-t-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/text/text-intro-05-t-expected.checksum.
        * platform/chromium-mac-leopard/svg/text/text-intro-05-t-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/text/text-intro-05-t-expected.png.
        * platform/chromium-mac-leopard/svg/zoom/page/zoom-foreignObject-expected.checksum: Added.
        * platform/chromium-mac-leopard/svg/zoom/page/zoom-foreignObject-expected.png: Added.
        * platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.checksum:
        * platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
        * platform/chromium-mac/svg/custom/dynamic-svg-document-creation-expected.checksum: Added.
        * platform/chromium-mac/svg/custom/dynamic-svg-document-creation-expected.png: Added.
        * platform/chromium-mac/svg/custom/feComponentTransfer-Discrete-expected.checksum: Added.
        * platform/chromium-mac/svg/custom/feComponentTransfer-Discrete-expected.png: Added.
        * platform/chromium-mac/svg/custom/feComponentTransfer-Gamma-expected.checksum: Added.
        * platform/chromium-mac/svg/custom/feComponentTransfer-Gamma-expected.png: Added.
        * platform/chromium-mac/svg/custom/feComponentTransfer-Linear-expected.checksum: Added.
        * platform/chromium-mac/svg/custom/feComponentTransfer-Linear-expected.png: Added.
        * platform/chromium-mac/svg/custom/feComponentTransfer-Table-expected.checksum: Added.
        * platform/chromium-mac/svg/custom/feComponentTransfer-Table-expected.png: Added.
        * platform/chromium-mac/svg/custom/foreign-object-skew-expected.checksum: Added.
        * platform/chromium-mac/svg/custom/foreign-object-skew-expected.png: Added.
        * platform/chromium-mac/svg/custom/glyph-transformation-with-hkern-expected.checksum: Added.
        * platform/chromium-mac/svg/custom/glyph-transformation-with-hkern-expected.png: Added.
        * platform/chromium-mac/svg/custom/gradient-rotated-bbox-expected.checksum: Added.
        * platform/chromium-mac/svg/custom/gradient-rotated-bbox-expected.png: Added.
        * platform/chromium-mac/svg/custom/grayscale-gradient-mask-expected.checksum: Added.
        * platform/chromium-mac/svg/custom/grayscale-gradient-mask-expected.png: Added.
        * platform/chromium-mac/svg/custom/inline-svg-in-xhtml-expected.checksum:
        * platform/chromium-mac/svg/custom/inline-svg-in-xhtml-expected.png:
        * platform/chromium-mac/svg/custom/js-late-gradient-and-object-creation-expected.checksum: Added.
        * platform/chromium-mac/svg/custom/js-late-gradient-and-object-creation-expected.png: Added.
        * platform/chromium-mac/svg/custom/js-late-gradient-creation-expected.checksum: Added.
        * platform/chromium-mac/svg/custom/js-late-gradient-creation-expected.png: Added.
        * platform/chromium-mac/svg/custom/js-late-pattern-and-object-creation-expected.checksum: Added.
        * platform/chromium-mac/svg/custom/js-late-pattern-and-object-creation-expected.png: Added.
        * platform/chromium-mac/svg/custom/js-late-pattern-creation-expected.checksum: Added.
        * platform/chromium-mac/svg/custom/js-late-pattern-creation-expected.png: Added.
        * platform/chromium-mac/svg/custom/non-scaling-stroke-expected.checksum: Added.
        * platform/chromium-mac/svg/custom/non-scaling-stroke-expected.png: Added.
        * platform/chromium-mac/svg/custom/pattern-skew-transformed-expected.checksum: Added.
        * platform/chromium-mac/svg/custom/pattern-skew-transformed-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/filters/feDisplacementMap-expected.png.
        * platform/chromium-mac/svg/custom/pattern-with-transformation-expected.checksum: Added.
        * platform/chromium-mac/svg/custom/pattern-with-transformation-expected.png: Added.
        * platform/chromium-mac/svg/custom/preserve-aspect-ratio-syntax-expected.checksum: Added.
        * platform/chromium-mac/svg/custom/preserve-aspect-ratio-syntax-expected.png: Added.
        * platform/chromium-mac/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.checksum: Added.
        * platform/chromium-mac/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png: Added.
        * platform/chromium-mac/svg/custom/resource-invalidate-on-target-update-expected.checksum: Added.
        * platform/chromium-mac/svg/custom/resource-invalidate-on-target-update-expected.png: Added.
        * platform/chromium-mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.checksum:
        * platform/chromium-mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
        * platform/chromium-mac/svg/custom/shapes-supporting-markers-expected.checksum: Added.
        * platform/chromium-mac/svg/custom/shapes-supporting-markers-expected.png: Added.
        * platform/chromium-mac/svg/custom/svg-curve-with-relative-cordinates-expected.checksum:
        * platform/chromium-mac/svg/custom/svg-curve-with-relative-cordinates-expected.png:
        * platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.checksum:
        * platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.png:
        * platform/chromium-mac/svg/custom/svg-fonts-with-no-element-reference-expected.checksum: Added.
        * platform/chromium-mac/svg/custom/svg-fonts-with-no-element-reference-expected.png: Added.
        * platform/chromium-mac/svg/custom/text-rotated-gradient-expected.checksum: Added.
        * platform/chromium-mac/svg/custom/text-rotated-gradient-expected.png: Added.
        * platform/chromium-mac/svg/custom/use-detach-expected.checksum: Added.
        * platform/chromium-mac/svg/custom/use-detach-expected.png: Added.
        * platform/chromium-mac/svg/custom/use-on-clip-path-with-transformation-expected.checksum: Added.
        * platform/chromium-mac/svg/custom/use-on-clip-path-with-transformation-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/filters/feDisplacementMap-expected.png.
        * platform/chromium-mac/svg/custom/viewbox-syntax-expected.checksum: Added.
        * platform/chromium-mac/svg/custom/viewbox-syntax-expected.png: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.checksum:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.checksum:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.checksum:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.checksum:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.checksum:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.checksum:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png:
        * platform/chromium-mac/svg/filters/feDisplacementMap-expected.checksum:
        * platform/chromium-mac/svg/filters/feDisplacementMap-expected.png:
        * platform/chromium-mac/svg/hixie/mixed/003-expected.checksum:
        * platform/chromium-mac/svg/hixie/mixed/003-expected.png:
        * platform/chromium-mac/svg/hixie/mixed/006-expected.checksum:
        * platform/chromium-mac/svg/hixie/mixed/006-expected.png:
        * platform/chromium-mac/svg/hixie/mixed/008-expected.checksum:
        * platform/chromium-mac/svg/hixie/mixed/008-expected.png:
        * platform/chromium-mac/svg/hixie/mixed/011-expected.checksum:
        * platform/chromium-mac/svg/hixie/mixed/011-expected.png:
        * platform/chromium-mac/svg/text/text-intro-05-t-expected.checksum:
        * platform/chromium-mac/svg/text/text-intro-05-t-expected.png:
        * platform/chromium-mac/svg/zoom/page/zoom-foreignObject-expected.checksum: Added.
        * platform/chromium-mac/svg/zoom/page/zoom-foreignObject-expected.png: Added.
        * platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.checksum: Added.
        * platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoClean build fix
aroben@apple.com [Thu, 31 Mar 2011 00:01:24 +0000 (00:01 +0000)]
Clean build fix

* JavaScriptCore.vcproj/JavaScriptCore.sln: Serialized project dependencies so projects
don't try to build in parallel (which doesn't mesh with our buildfailed mechanism).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Matthew Delaney <mdelaney@apple.com>
mdelaney@apple.com [Thu, 31 Mar 2011 00:00:59 +0000 (00:00 +0000)]
2011-03-30  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Chris Marrin.

        Update fast/canvas tests to avoid dumping the render tree when possible
        https://bugs.webkit.org/show_bug.cgi?id=57493

        * DumpRenderTree/mac/DumpRenderTree.mm: Make DRT aware of new default values for
          accelerated drawing and accelerated drawing for canvas
2011-03-30  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Chris Marrin.

        Update fast/canvas tests to avoid dumping the render tree when possible
        https://bugs.webkit.org/show_bug.cgi?id=57493

        * fast/canvas/<various tests>: Added new expectations.
        * platform/mac/fast/canvas/<various tests>: Removed old expectations with Render Tree printouts.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 MORITA Hajime <morrita@google.com>
morrita@google.com [Wed, 30 Mar 2011 23:56:12 +0000 (23:56 +0000)]
2011-03-30  MORITA Hajime  <morrita@google.com>

        box-shadow radii stays the same regardless of any spread set
        https://bugs.webkit.org/show_bug.cgi?id=49726

        - Added test for multiple inset shadows.
        - Updated wrong expectations which are fixed by this change.
        - Moved some expectation file location to platform/mac because they don't match
          against non-mac platform results due to the difference between graphics backends.

        * fast/box-shadow/spread-multiple-inset-expected.txt: Added.
        * fast/box-shadow/spread-multiple-inset.html: Added.
        * fast/box-shadow/spread-multiple-normal-expected.checksum: Removed.
        * fast/box-shadow/spread-multiple-normal-expected.png: Removed.
        * fast/box-shadow/spread-multiple-normal.html: Changed to avoid overlapping boxes.
        * platform/mac/fast/box-shadow/spread-expected.checksum:
        * platform/mac/fast/box-shadow/spread-expected.png:
        * platform/mac/fast/box-shadow/spread-multiple-inset-expected.checksum: Added.
        * platform/mac/fast/box-shadow/spread-multiple-inset-expected.png: Added.
        * platform/mac/fast/box-shadow/spread-multiple-normal-expected.checksum: Added.
        * platform/mac/fast/box-shadow/spread-multiple-normal-expected.png: Added.
2011-03-30  MORITA Hajime  <morrita@google.com>

        Reviewed by Simon Fraser.

        box-shadow radii stays the same regardless of any spread set
        https://bugs.webkit.org/show_bug.cgi?id=49726

        - Removed special shadowSpread handling path
        - Fixed broken multple inset shadow border computation.

        Test: fast/box-shadow/spread-multiple-inset.html

        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintBoxShadow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRollout r82500
oliver@apple.com [Wed, 30 Mar 2011 23:53:25 +0000 (23:53 +0000)]
Rollout r82500

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFixed changelong entry typpos.
mdelaney@apple.com [Wed, 30 Mar 2011 23:33:19 +0000 (23:33 +0000)]
Fixed changelong entry typpos.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Yi Shen <yi.4.shen@nokia.com>
yi.4.shen@nokia.com [Wed, 30 Mar 2011 23:19:26 +0000 (23:19 +0000)]
2011-03-30  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt][Symbian] Fix Api test failure -- tst_QWebView::focusInputTypes
        https://bugs.webkit.org/show_bug.cgi?id=57020

        Added a macro 'VERIFY_INPUTMETHOD_HINTS' to test inputmethodhints().

        * tests/qwebview/tst_qwebview.cpp:
        (tst_QWebView::focusInputTypes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Matthew Delaney <mdelaney@apple.com>
mdelaney@apple.com [Wed, 30 Mar 2011 23:15:44 +0000 (23:15 +0000)]
2011-03-29  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Simon Fraser.

        Use the Accelerate vImage vectorized (un)premultiplyImageData functions for ImageBufferCG

        https://bugs.webkit.org/show_bug.cgi?id=53134

        * wtf/Platform.h: Added in WTF flag for using the Accelerate framework
2011-03-29  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Simon Fraser.

        Use the Accelerate vImage vectorized (un)premultiplyImageData functions for ImageBufferCG

        https://bugs.webkit.org/show_bug.cgi?id=53134

        Test: fast/canvas/getPutImageDataPairTest.html

        * platform/graphics/cg/ImageBufferCG.cpp:
2011-03-25  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Simon Fraser.

        Use Accelerate vImage vectorized (un)premultiplyImageData functions for ImageBufferCG.cpp
        https://bugs.webkit.org/show_bug.cgi?id=53134

        * fast/canvas/canvas-getImageData-expected.txt: Resetting expected results for this test due to test change.
        * fast/canvas/canvas-getImageData.html: Removed the section of this test that incorrectly assumes the
          rounding behavior of initial inputed data.
        * fast/canvas/getPutImageDataPairTest-expected.txt: Added.
        * fast/canvas/getPutImageDataPairTest.html: A new test to make sure that a batch of paired putImageData(getImageData)
          calls doesn't accumulate any error per the spec.
        * fast/canvas/rgba-parsing-expected.txt: Reset the results for this test since the initial rgba rounding values are
          now different. Note: the spec does not define how they *should* be rounded, so having them there is basically just
          for bookkeeping to know when our rounding behavior changes since it could be early warning of related real issues.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoShould turn off frame pointer omission (FPO) for Release (not Production) builds
sfalken@apple.com [Wed, 30 Mar 2011 23:04:16 +0000 (23:04 +0000)]
Should turn off frame pointer omission (FPO) for Release (not Production) builds
https://bugs.webkit.org/show_bug.cgi?id=54403

Reviewed by Adam Roben.

Leave it enabled for Windows Production builds.
Disabling this optimization improves stack traces for memory and performance tools like umdh and xperf.

We use both /Oy- and OmitFramePointers="false" since OmitFramePointers="false" isnt' enough
to override /O2.

* win/tools/vsprops/release.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoStop ignoring leaks in CGGradientCreateWithColorStops
aroben@apple.com [Wed, 30 Mar 2011 22:58:15 +0000 (22:58 +0000)]
Stop ignoring leaks in CGGradientCreateWithColorStops

Fixes <rdar://problem/7888547>.

Rubber-stamped by John Sullivan.

* Scripts/old-run-webkit-tests:
(countAndPrintLeaks): Removed some code to ignore those leaks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 30 Mar 2011 22:48:15 +0000 (22:48 +0000)]
2011-03-30  Martin Robinson  <mrobinson@igalia.com>

        Try to fix the WinCairo build.

        * platform/graphics/win/GraphicsContextCairoWin.cpp:
        (WebCore::GraphicsContext::platformInit): Fix misspelling of GraphicsContextPlatformPrivateToplevel.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoShare most vsprops between Release and Production builds in releaseproduction.vsprops
sfalken@apple.com [Wed, 30 Mar 2011 22:43:59 +0000 (22:43 +0000)]
Share most vsprops between Release and Production builds in releaseproduction.vsprops
https://bugs.webkit.org/show_bug.cgi?id=57508

Reviewed by Adam Roben.

Source/JavaScriptCore:

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreProduction.vsprops:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreRelease.vsprops:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreReleaseCairoCFLite.vsprops:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreReleasePGO.vsprops:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreReleasePGOOptimize.vsprops:
* JavaScriptCore.vcproj/WTF/WTFProduction.vsprops:
* JavaScriptCore.vcproj/WTF/WTFRelease.vsprops:
* JavaScriptCore.vcproj/WTF/WTFReleaseCairoCFLite.vsprops:
* JavaScriptCore.vcproj/WTF/WTFReleasePGO.vsprops:
* JavaScriptCore.vcproj/jsc/jscProduction.vsprops:
* JavaScriptCore.vcproj/jsc/jscRelease.vsprops:
* JavaScriptCore.vcproj/jsc/jscReleaseCairoCFLite.vsprops:
* JavaScriptCore.vcproj/jsc/jscReleasePGO.vsprops:
* JavaScriptCore.vcproj/testapi/testapiProduction.vsprops:
* JavaScriptCore.vcproj/testapi/testapiRelease.vsprops:
* JavaScriptCore.vcproj/testapi/testapiReleaseCairoCFLite.vsprops:

Source/WebCore:

* WebCore.vcproj/QTMovieWinProduction.vsprops:
* WebCore.vcproj/QTMovieWinRelease.vsprops:
* WebCore.vcproj/QTMovieWinReleaseCairoCFLite.vsprops:
* WebCore.vcproj/WebCoreProduction.vsprops:
* WebCore.vcproj/WebCoreRelease.vsprops:
* WebCore.vcproj/WebCoreReleaseCairoCFLite.vsprops:

Source/WebKit/win:

* WebKit.vcproj/InterfacesProduction.vsprops:
* WebKit.vcproj/InterfacesRelease.vsprops:
* WebKit.vcproj/InterfacesReleaseCairoCFLite.vsprops:
* WebKit.vcproj/WebKitGUIDProduction.vsprops:
* WebKit.vcproj/WebKitGUIDRelease.vsprops:
* WebKit.vcproj/WebKitGUIDReleaseCairoCFLite.vsprops:
* WebKit.vcproj/WebKitLibProduction.vsprops:
* WebKit.vcproj/WebKitLibRelease.vsprops:
* WebKit.vcproj/WebKitLibReleaseCairoCFLite.vsprops:

Source/WebKit2:

* win/WebKit2Production.vsprops:
* win/WebKit2Release.vsprops:
* win/WebKit2ReleaseCairoCFLite.vsprops:
* win/WebKit2WebProcessProduction.vsprops:
* win/WebKit2WebProcessRelease.vsprops:
* win/WebKit2WebProcessReleaseCairoCFLite.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd some dynamic annotations to JavaScriptCore/wtf
sfalken@apple.com [Wed, 30 Mar 2011 22:42:21 +0000 (22:42 +0000)]
Add some dynamic annotations to JavaScriptCore/wtf
https://bugs.webkit.org/show_bug.cgi?id=53747

Patch by Timur Iskhodzhanov <timurrrr@google.com> on 2011-03-30
Reviewed by Alexey Proskuryakov.

By using these annotations we can improve the precision of finding
WebKit errors using dynamic analysis tools like ThreadSanitizer and Valgrind.
These annotations don't affect the compiled binaries unless USE(DYNAMIC_ANNOTATIONS) is "1".

These files don't add new functionality, so don't need extra tests.

* DumpRenderTree/ForwardingHeaders/wtf/DynamicAnnotations.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoShare most vsprops between Release and Production builds in releaseproduction.vsprops
sfalken@apple.com [Wed, 30 Mar 2011 22:41:58 +0000 (22:41 +0000)]
Share most vsprops between Release and Production builds in releaseproduction.vsprops
https://bugs.webkit.org/show_bug.cgi?id=57508

Reviewed by Adam Roben.

* win/tools/vsprops/release.vsprops:
* win/tools/vsprops/releaseproduction.vsprops: Copied from WebKitLibraries/win/tools/vsprops/release.vsprops.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoExplicitly prevent testapi and minidom from being installed rather than relying
mrowe@apple.com [Wed, 30 Mar 2011 22:39:07 +0000 (22:39 +0000)]
Explicitly prevent testapi and minidom from being installed rather than relying
on Xcode's current behavior of not installing if INSTALL_PATH is not explicitly
set at the target level.

Reviewed by Adam Roben.

<rdar://problem/9206357>

* JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd some dynamic annotations to JavaScriptCore/wtf
levin@chromium.org [Wed, 30 Mar 2011 22:31:16 +0000 (22:31 +0000)]
Add some dynamic annotations to JavaScriptCore/wtf
https://bugs.webkit.org/show_bug.cgi?id=53747

Patch by Timur Iskhodzhanov <timurrrr@google.com> on 2011-03-30
Reviewed by Alexey Proskuryakov.

By using these annotations we can improve the precision of finding
WebKit errors using dynamic analysis tools like ThreadSanitizer and Valgrind.
These annotations don't affect the compiled binaries unless USE(DYNAMIC_ANNOTATIONS) is "1".

These files don't add new functionality, so don't need extra tests.

Source/JavaScriptCore:

* GNUmakefile.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
* wtf/DynamicAnnotations.cpp: Added.
(WTFAnnotateBenignRaceSized):
(WTFAnnotateHappensBefore):
(WTFAnnotateHappensAfter):
* wtf/DynamicAnnotations.h: Added.
* wtf/ThreadSafeRefCounted.h:
(WTF::ThreadSafeRefCountedBase::derefBase):
* wtf/text/StringStatics.cpp:
(WTF::StringImpl::empty):

Source/JavaScriptGlue:

* ForwardingHeaders/wtf/DynamicAnnotations.h: Added.

Source/WebCore:

* ForwardingHeaders/wtf/DynamicAnnotations.h: Added.

Tools:

* DumpRenderTree/ForwardingHeaders/wtf/DynamicAnnotations.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoEnsure consistent, readable working directory for WebProcess before entering sandbox
mjs@apple.com [Wed, 30 Mar 2011 22:27:15 +0000 (22:27 +0000)]
Ensure consistent, readable working directory for WebProcess before entering sandbox
<rdar://problem/8951176>

Patch by Ivan Krstić <ike@apple.com> on 2011-03-30
Reviewed by Oliver Hunt.

* WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::platformInitializeWebProcess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttp/tests/uri/username-with-no-hostname.html is flaky due to preload scanner
jberlin@webkit.org [Wed, 30 Mar 2011 22:13:37 +0000 (22:13 +0000)]
http/tests/uri/username-with-no-hostname.html is flaky due to preload scanner
https://bugs.webkit.org/show_bug.cgi?id=57496

Unreviewed, this test has been flakey on a bunch of platforms, so disable it to keep the
bots green.

* http/tests/uri/username-with-no-hostname.html: Removed.
* http/tests/uri/username-with-no-hostname.html-disabled: Copied from http/tests/uri/username-with-no-hostname.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 30 Mar 2011 22:09:13 +0000 (22:09 +0000)]
2011-03-30  Martin Robinson  <mrobinson@igalia.com>

        Skip a test which requires missing resource load callback dumps on GTK+.
        Better clump another failing test.

        * platform/gtk/Skipped: Update the skipped list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 30 Mar 2011 22:04:45 +0000 (22:04 +0000)]
2011-03-30  Martin Robinson  <mrobinson@igalia.com>

        Try to fix the EFL build.

        * platform/efl/RenderThemeEfl.cpp:
        (WebCore::RenderThemeEfl::paintThemePart): Use the new cairo_t accessor on the platform context.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Wed, 30 Mar 2011 22:00:06 +0000 (22:00 +0000)]
2011-03-30  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Simon Fraser.

        Tests that we do not crash when removing inline style
        from a node that is not a html element.
        https://bugs.webkit.org/show_bug.cgi?id=57348

        * editing/execCommand/remove-format-non-html-element-crash-expected.txt: Added.
        * editing/execCommand/remove-format-non-html-element-crash.html: Added.
2011-03-30  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Simon Fraser.

        Fix wrong type assumptions in editing code. Move code
        from ASSERTs to hard checks.
        https://bugs.webkit.org/show_bug.cgi?id=57348

        Test: editing/execCommand/remove-format-non-html-element-crash.html

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        * editing/ApplyStyleCommand.cpp:
        (WebCore::getRGBAFontColor):
        (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode):
        * editing/DeleteButtonController.cpp:
        (WebCore::enclosingDeletableElement):
        * editing/EditingStyle.cpp:
        (WebCore::EditingStyle::textDirection):
        (WebCore::EditingStyle::prepareToApplyAt):
        * editing/Editor.cpp:
        (WebCore::Editor::textDirectionForSelection):
        * editing/FormatBlockCommand.cpp:
        (WebCore::FormatBlockCommand::elementForFormatBlockCommand):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Wed, 30 Mar 2011 21:48:51 +0000 (21:48 +0000)]
2011-03-30  Stephen White  <senorblanco@chromium.org>

        Reviewed by Kenneth Russell.

        Speed up clipping in accelerated 2D canvas.
        https://bugs.webkit.org/show_bug.cgi?id=57464

        Instead of clearing the entire stencil buffer when removing clipping paths, we erase the path with a DECR stencil operation.
        Covered by canvas/philip/tests/2d.path.clip.intersect.html, and others.

        * platform/graphics/chromium/GLES2Canvas.cpp:
        (WebCore::PathAndTransform::PathAndTransform):
        New structure to keep track of the CTM at the time the clipping path was added.
        (WebCore::GLES2Canvas::State::State):
        Replace m_clippingEnabled with a count of total clipping paths.
        (WebCore::GLES2Canvas::clearRect):
        Check the total clipping path count, instead of m_clippingEnabled.
        (WebCore::GLES2Canvas::fillPath):
        (WebCore::GLES2Canvas::fillRect):
        Perform state application after doing shadows.  This is necessary
        since restore() may now leave clipping enabled.
        (WebCore::GLES2Canvas::clipPath):
        Explicitly specify the stencil operation as INCR.  Store the current
        transformation when saving clipping paths.
        (WebCore::GLES2Canvas::restore):
        Don't clear the stencil buffer and re-draw active paths on each restore.
        Erase the old paths with DECR.
        (WebCore::GLES2Canvas::drawTexturedRect):
        Check m_numClippingPaths instead of m_clippingEnabled.
        (WebCore::GLES2Canvas::beginShadowDraw):
        Perform state application when drawing hard shadows.
        (WebCore::GLES2Canvas::endShadowDraw):
        Check m_numClippingPaths instead of m_clippingEnabled.
        (WebCore::GLES2Canvas::beginStencilDraw):
        Make the stencil op a parameter to beginShadowDraw().
        (WebCore::GLES2Canvas::applyClipping):
        Compare against the total number of stencil paths, not just the ones in
        the current state.
        * platform/graphics/chromium/GLES2Canvas.h:
        Make the stencil op a parameter to beginShadowDraw().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 30 Mar 2011 21:44:25 +0000 (21:44 +0000)]
2011-03-29  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        Move factory-like things in EventDispatcher::dispatchMouseEvent to a factory, clean up names and ordering.
        https://bugs.webkit.org/show_bug.cgi?id=57419

        Refactoring, covered by existing tests.

        * dom/EventDispatcher.cpp:
        (WebCore::EventDispatcher::dispatchMouseEvent): Reordered and clarified names.
        * dom/MouseEvent.cpp:
        (WebCore::MouseEvent::create): Added a new factory method that takes PlatformMouseEvent.
        * dom/MouseEvent.h: Added decl.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Wed, 30 Mar 2011 21:39:20 +0000 (21:39 +0000)]
2011-03-30  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Make StructureChain GC allocated
        https://bugs.webkit.org/show_bug.cgi?id=56695

        Make StructureChain GC allocated, and make the various owners
        mark it correctly.

        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::dump):
        (JSC::CodeBlock::derefStructures):
        (JSC::CodeBlock::refStructures):
        (JSC::CodeBlock::markAggregate):
        * bytecode/Instruction.h:
        (JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set):
        (JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):
        (JSC::PolymorphicAccessStructureList::derefStructures):
        (JSC::PolymorphicAccessStructureList::markAggregate):
        (JSC::Instruction::Instruction):
        * bytecode/StructureStubInfo.cpp:
        (JSC::StructureStubInfo::deref):
        (JSC::StructureStubInfo::markAggregate):
        * bytecode/StructureStubInfo.h:
        (JSC::StructureStubInfo::initGetByIdChain):
        (JSC::StructureStubInfo::initPutByIdTransition):
        * bytecompiler/BytecodeGenerator.cpp:
        (JSC::BytecodeGenerator::emitJumpIfNotFunctionCall):
        (JSC::BytecodeGenerator::emitJumpIfNotFunctionApply):
        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::privateExecute):
        * jit/JITOpcodes.cpp:
        (JSC::JIT::emit_op_jneq_ptr):
        * jit/JITOpcodes32_64.cpp:
        (JSC::JIT::emit_op_jneq_ptr):
        * jit/JITPropertyAccess.cpp:
        (JSC::JIT::privateCompileGetByIdChainList):
        * jit/JITPropertyAccess32_64.cpp:
        (JSC::JIT::privateCompileGetByIdChainList):
        * jit/JITStubs.cpp:
        (JSC::getPolymorphicAccessStructureListSlot):
        (JSC::DEFINE_STUB_FUNCTION):
        * runtime/JSCell.h:
        * runtime/JSGlobalData.cpp:
        (JSC::JSGlobalData::JSGlobalData):
        * runtime/JSGlobalData.h:
        * runtime/JSGlobalObject.cpp:
        (JSC::markIfNeeded):
        * runtime/JSGlobalObject.h:
        (JSC::Structure::prototypeChain):
        * runtime/JSObject.h:
        (JSC::JSObject::markChildrenDirect):
        * runtime/JSPropertyNameIterator.cpp:
        (JSC::JSPropertyNameIterator::create):
        (JSC::JSPropertyNameIterator::get):
        (JSC::JSPropertyNameIterator::markChildren):
        * runtime/JSPropertyNameIterator.h:
        (JSC::JSPropertyNameIterator::setCachedPrototypeChain):
        * runtime/MarkStack.h:
        (JSC::MarkStack::append):
        * runtime/Structure.h:
        (JSC::Structure::cachedPrototypeChainSlot):
        * runtime/StructureChain.cpp:
        (JSC::StructureChain::StructureChain):
        * runtime/StructureChain.h:
        (JSC::StructureChain::create):
        (JSC::StructureChain::createStructure):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Erik Arvidsson <arv@chromium.org>
arv@chromium.org [Wed, 30 Mar 2011 21:06:08 +0000 (21:06 +0000)]
2011-03-30  Erik Arvidsson  <arv@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Missing DOM bindings for a ping
        https://bugs.webkit.org/show_bug.cgi?id=51955

        * fast/dom/ping-attribute-dom-binding-expected.txt: Added.
        * fast/dom/ping-attribute-dom-binding.html: Added.
2011-03-30  Erik Arvidsson  <arv@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Missing DOM bindings for a ping
        https://bugs.webkit.org/show_bug.cgi?id=51955

        Test: fast/dom/ping-attribute-dom-binding.html

        * html/HTMLAnchorElement.idl:
        * html/HTMLAreaElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 30 Mar 2011 21:00:13 +0000 (21:00 +0000)]
2011-03-30  Mihai Parparita  <mihaip@chromium.org>

        Fix remaining unexpected Chromium Snow Leopard image failures.

        Current Leopard baselines in chromium-mac/ are moved to
        chromium-mac-leopard/.

        * platform/chromium-mac-leopard/fast/forms/input-align-image-expected.checksum: Copied from LayoutTests/platform/chromium-mac/fast/forms/input-align-image-expected.checksum.
        * platform/chromium-mac-leopard/fast/forms/input-align-image-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/input-align-image-expected.png.
        * platform/chromium-mac-leopard/fast/forms/input-type-change-expected.checksum: Copied from LayoutTests/platform/chromium-mac/fast/forms/input-type-change-expected.checksum.
        * platform/chromium-mac-leopard/fast/forms/input-type-change-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/input-type-change-expected.png.
        * platform/chromium-mac-leopard/fast/forms/listbox-bidi-align-expected.checksum: Copied from LayoutTests/platform/chromium-mac/fast/forms/listbox-bidi-align-expected.checksum.
        * platform/chromium-mac-leopard/fast/forms/listbox-bidi-align-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/listbox-bidi-align-expected.png.
        * platform/chromium-mac-leopard/fast/text/drawBidiText-expected.checksum: Copied from LayoutTests/platform/chromium-mac/fast/text/drawBidiText-expected.checksum.
        * platform/chromium-mac-leopard/fast/text/drawBidiText-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/text/drawBidiText-expected.png.
        * platform/chromium-mac-leopard/media/video-transformed-expected.checksum: Copied from LayoutTests/platform/chromium-mac/media/video-transformed-expected.checksum.
        * platform/chromium-mac-leopard/media/video-transformed-expected.png: Copied from LayoutTests/platform/chromium-mac/media/video-transformed-expected.png.
        * platform/chromium-mac-leopard/scrollbars/listbox-scrollbar-combinations-expected.checksum: Copied from LayoutTests/platform/chromium-mac/scrollbars/listbox-scrollbar-combinations-expected.checksum.
        * platform/chromium-mac-leopard/scrollbars/listbox-scrollbar-combinations-expected.png: Copied from LayoutTests/platform/chromium-mac/scrollbars/listbox-scrollbar-combinations-expected.png.
        * platform/chromium-mac-leopard/scrollbars/overflow-scrollbar-combinations-expected.checksum: Copied from LayoutTests/platform/chromium-mac/scrollbars/overflow-scrollbar-combinations-expected.checksum.
        * platform/chromium-mac-leopard/scrollbars/overflow-scrollbar-combinations-expected.png: Copied from LayoutTests/platform/chromium-mac/scrollbars/overflow-scrollbar-combinations-expected.png.
        * platform/chromium-mac-leopard/svg/text/foreignObject-text-clipping-bug-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/text/foreignObject-text-clipping-bug-expected.checksum.
        * platform/chromium-mac-leopard/svg/text/foreignObject-text-clipping-bug-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/text/foreignObject-text-clipping-bug-expected.png.
        * platform/chromium-mac-leopard/tables/mozilla/core/col_widths_auto_autoFix-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/core/col_widths_auto_autoFix-expected.checksum.
        * platform/chromium-mac-leopard/tables/mozilla/core/col_widths_auto_autoFix-expected.png: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/core/col_widths_auto_autoFix-expected.png.
        * platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug6933-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug6933-expected.checksum.
        * platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug6933-expected.png: Copied from LayoutTests/platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug6933-expected.png.
        * platform/chromium-mac/editing/deleting/table-cells-expected.checksum: Removed.
        * platform/chromium-mac/fast/forms/input-align-image-expected.checksum:
        * platform/chromium-mac/fast/forms/input-align-image-expected.png:
        * platform/chromium-mac/fast/forms/input-type-change-expected.checksum:
        * platform/chromium-mac/fast/forms/input-type-change-expected.png:
        * platform/chromium-mac/fast/forms/listbox-bidi-align-expected.checksum:
        * platform/chromium-mac/fast/forms/listbox-bidi-align-expected.png:
        * platform/chromium-mac/fast/text/drawBidiText-expected.checksum:
        * platform/chromium-mac/fast/text/drawBidiText-expected.png:
        * platform/chromium-mac/media/video-transformed-expected.checksum:
        * platform/chromium-mac/media/video-transformed-expected.png:
        * platform/chromium-mac/scrollbars/listbox-scrollbar-combinations-expected.checksum:
        * platform/chromium-mac/scrollbars/listbox-scrollbar-combinations-expected.png:
        * platform/chromium-mac/scrollbars/overflow-scrollbar-combinations-expected.checksum:
        * platform/chromium-mac/scrollbars/overflow-scrollbar-combinations-expected.png:
        * platform/chromium-mac/svg/text/foreignObject-text-clipping-bug-expected.checksum:
        * platform/chromium-mac/svg/text/foreignObject-text-clipping-bug-expected.png:
        * platform/chromium-mac/tables/mozilla/core/col_widths_auto_autoFix-expected.checksum:
        * platform/chromium-mac/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
        * platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug6933-expected.checksum:
        * platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug6933-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Darin Adler.
ap@apple.com [Wed, 30 Mar 2011 20:57:45 +0000 (20:57 +0000)]
    Reviewed by Darin Adler.

        REGRESSION (r82320): Spacebar no longer pages down
        https://bugs.webkit.org/show_bug.cgi?id=57423
        <rdar://problem/9207702>

        Also includes some unrelated cleanup that I had in my tree.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Added an assertion that the event is
        being dispatched to the right frame.
        (-[WebHTMLView setMarkedText:selectedRange:]): Use 0 for a pointer, not NULL.
        (-[WebHTMLView doCommandBySelector:]): Update eventInterpretationHadSideEffects with "|=".
        Even if this specific command hasn't been handled, that doesn't nullify side effects from
        previous commands.
        (-[WebHTMLView insertText:]): Besides looking at the return value of insertText() to fix the
        bug, removed setting _private->interpretKeyEventsParameters to 0. I don't see any way for
        another WebHTMLView NSTextInput method to be called from within insertText:, so no one is
        going to look at it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 30 Mar 2011 20:56:40 +0000 (20:56 +0000)]
2011-03-30  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Dirk Schulze.

        [Cairo] Better separate the concerns of GraphicsContextCairo
        https://bugs.webkit.org/show_bug.cgi?id=55150

        Add a PlatformContextCairo which right now stores the cairo_t* for a
        GraphicsContextCairo. Later patches will move logic for tracking ContextShadow
        and image masking layers into this PlatformContextCairo class.

        No new tests. This patch is only a code cleanup.

        * GNUmakefile.am:
        * platform/graphics/GraphicsContext.h: The platform context is no longer a
        cairo_t, but our new class the PlatformContextCairo.
        * platform/graphics/cairo/ContextShadowCairo.cpp: Updated to reflect new class.j
        * platform/graphics/cairo/FontCairo.cpp: Ditto.
        * platform/graphics/cairo/GradientCairo.cpp: Ditto.
        * platform/graphics/cairo/GraphicsContextCairo.cpp: Mostly mechanical
        changes which now reference platformContext()->cr() to get the cairo_t.
        * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: Now hold the
        PlatformContextCairo instead of the cairo_t.
        * platform/graphics/cairo/ImageBufferCairo.cpp: Update to reflect new class.
        * platform/graphics/cairo/ImageCairo.cpp: Ditto.
        * platform/graphics/cairo/PathCairo.cpp: Ditto.
        * platform/graphics/cairo/PlatformContextCairo.cpp: Added.
        * platform/graphics/cairo/PlatformContextCairo.h: Added.
        * platform/graphics/gtk/FontGtk.cpp: Update to reflect new class.
        * platform/graphics/gtk/IconGtk.cpp: Ditto.
        * platform/graphics/win/GraphicsContextCairoWin.cpp: Now fill out
        m_data with a private section containing the platform context instead of
        just a cairo_t.
        * platform/gtk/RenderThemeGtk.cpp: Update to reflect new class.
        * platform/gtk/WidgetRenderingContext.cpp: Ditto.
        (WebCore::WidgetRenderingContext::~WidgetRenderingContext): Ditto.
        * plugins/gtk/PluginViewGtk.cpp: Ditto.
2011-03-30  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Dirk Schulze.

        [Cairo] Better separate the concerns of GraphicsContextCairo
        https://bugs.webkit.org/show_bug.cgi?id=55150

        Add a PlatformContextCairo which right now stores the cairo_t* for a
        GraphicsContextCairo. Later patches will move logic for tracking ContextShadow
        and image masking layers into this PlatformContextCairo class.

        * webkit/webkitwebframe.cpp:
        (draw_page_callback):
        * webkit/webkitwebview.cpp:
        (webkit_web_view_expose_event):
        (webkit_web_view_draw):
2011-03-30  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Dirk Schulze.

        [Cairo] Better separate the concerns of GraphicsContextCairo
        https://bugs.webkit.org/show_bug.cgi?id=55150

        * WebFrame.cpp:
        (hdcFromContext): Modify this method to take PlatformContextCairo
        instead of a cairo_t.
        (WebFrame::spoolPage): Update to reflect new platform context.
        (WebFrame::spoolPages): Ditto.
        * WebFrame.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove unnecessary NDEBUG define.
sfalken@apple.com [Wed, 30 Mar 2011 20:44:56 +0000 (20:44 +0000)]
Remove unnecessary NDEBUG define.

Rubber stamped by Adam Roben.

* win/tools/vsprops/production.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Wed, 30 Mar 2011 20:43:35 +0000 (20:43 +0000)]
2011-03-30  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed WinCE build fix for r82465.

        * CMakeListsWinCE.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Wed, 30 Mar 2011 20:38:18 +0000 (20:38 +0000)]
2011-03-30  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam Roben.

        Update Windows production build logic for new production configurations
        https://bugs.webkit.org/show_bug.cgi?id=57494

        * win/tools/vsprops/common.vsprops:
        * win/tools/vsprops/production.vsprops: Added.
2011-03-30  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam Roben.

        Update Windows production build logic for new production configurations
        https://bugs.webkit.org/show_bug.cgi?id=57494

        * JavaScriptCore.vcproj/JavaScriptCore.make:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreProduction.vsprops:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreReleasePGO.vsprops:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreReleasePGOOptimize.vsprops:
        * JavaScriptCore.vcproj/WTF/WTFProduction.vsprops:
        * JavaScriptCore.vcproj/WTF/WTFReleasePGO.vsprops:
        * JavaScriptCore.vcproj/jsc/jscProduction.vsprops:
        * JavaScriptCore.vcproj/jsc/jscReleasePGO.vsprops:
        * JavaScriptCore.vcproj/testapi/testapiProduction.vsprops:
2011-03-30  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam Roben.

        Update Windows production build logic for new production configurations
        https://bugs.webkit.org/show_bug.cgi?id=57494

        * WebKit.vcproj/InterfacesProduction.vsprops:
        * WebKit.vcproj/WebKit.make:
        * WebKit.vcproj/WebKitGUIDProduction.vsprops:
        * WebKit.vcproj/WebKitLibProduction.vsprops:
2011-03-30  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam Roben.

        Update Windows production build logic for new production configurations
        https://bugs.webkit.org/show_bug.cgi?id=57494

        * WebCore.vcproj/QTMovieWinProduction.vsprops:
        * WebCore.vcproj/WebCore.make:
        * WebCore.vcproj/WebCoreProduction.vsprops:
2011-03-30  Sam Weinig  <sam@webkit.org>

        Reviewed by Brady Eidson.

        WebKit2: Attempting to view css file from url causes it to download
        <rdar://problem/9102611>
        https://bugs.webkit.org/show_bug.cgi?id=57501

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::canShowMIMEType):
        Match WebKit1 by allowing any MIME type that starts with "text/"
        except the ones we explicitly blacklist.
2011-03-30  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam Roben.

        Update Windows production build logic for new production configurations
        https://bugs.webkit.org/show_bug.cgi?id=57494

        * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
        * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
        * DumpRenderTree/win/ImageDiffProduction.vsprops:
        * FindSafari/FindSafariProduction.vsprops:
        * FindSafari/FindSafariReleasePGO.vsprops:
        * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
        * WebKitAPITest/WebKitAPITestProduction.vsprops:
        * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
        * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
        * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
        * WinLauncher/WinLauncherProduction.vsprops:
        * record-memory-win/record-memory-winProduction.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKit2: Attempting to view css file from url causes it to download
weinig@apple.com [Wed, 30 Mar 2011 20:30:34 +0000 (20:30 +0000)]
WebKit2: Attempting to view css file from url causes it to download
<rdar://problem/9102611>
https://bugs.webkit.org/show_bug.cgi?id=57501

Reviewed by Brady Eidson.

Source/WebCore:

* WebCore.exp.in:
* platform/MIMETypeRegistry.cpp:
(WebCore::initializeUnsupportedTextMIMETypes):
(WebCore::initializeMIMETypeRegistry):
(WebCore::MIMETypeRegistry::isUnsupportedTextMIMEType):
(WebCore::MIMETypeRegistry::getUnsupportedTextMIMETypes):
* platform/MIMETypeRegistry.h:
Add set of unsupported text MIME types, taken from WebKit/mac.

Source/WebKit/mac:

* WebView/WebHTMLRepresentation.h:
* WebView/WebHTMLRepresentation.mm:
(+[WebHTMLRepresentation unsupportedTextMIMETypes]):
* WebView/WebHTMLView.mm:
(+[WebHTMLView unsupportedTextMIMETypes]):
Re-factor unsupportedTextMIMETypes to pull from WebCore's
MIMETypeRegistry, so that the list can be shared with WebKit2.

Source/WebKit2:

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::canShowMIMEType):
Match WebKit1 by allowing any MIME type that starts with "text/"
except the ones we explicitly blacklist.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 30 Mar 2011 20:29:52 +0000 (20:29 +0000)]
2011-03-30  Mihai Parparita  <mihaip@chromium.org>

        Put expected PNG for fast/multicol/max-height-columns-block.html in the
        right directory (fix after r82480).

        * platform/chromium-mac-leopard/fast/multicol/max-height-columns-block-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/max-height-columns-block-expected.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 30 Mar 2011 20:15:37 +0000 (20:15 +0000)]
2011-03-30  Mihai Parparita  <mihaip@chromium.org>

        Fix more tests for Chromium Snow Leopard.

        Most are due to mismatched checksum files (like r82480), some also
        needed updated chromium-mac baselines.

        * platform/chromium-mac-leopard/css2.1/t0804-c5510-padn-00-b-ag-expected.png: Renamed from LayoutTests/platform/chromium-mac/css2.1/t0804-c5510-padn-00-b-ag-expected.png.
        * platform/chromium-mac-leopard/css2.1/t0905-c414-flt-wrap-01-d-g-expected.png: Copied from LayoutTests/platform/chromium-mac/css2.1/t0905-c414-flt-wrap-01-d-g-expected.png.
        * platform/chromium-mac-leopard/editing/inserting/4875189-2-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/inserting/4875189-2-expected.png.
        * platform/chromium-mac-leopard/editing/pasteboard/5387578-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/pasteboard/5387578-expected.png.
        * platform/chromium-mac-leopard/editing/pasteboard/paste-table-cells-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/pasteboard/paste-table-cells-expected.png.
        * platform/chromium-mac-leopard/fast/backgrounds/repeat/negative-offset-repeat-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-expected.png.
        * platform/chromium-mac-leopard/fast/block/float/014-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/block/float/014-expected.png.
        * platform/chromium-mac-leopard/fast/block/float/clear-element-too-wide-for-containing-block-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/block/float/clear-element-too-wide-for-containing-block-expected.png.
        * platform/chromium-mac-leopard/fast/borders/border-radius-inline-flow-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/borders/border-radius-inline-flow-expected.png.
        * platform/chromium-mac-leopard/fast/canvas/canvas-zoom-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/canvas/canvas-zoom-expected.png.
        * platform/chromium-mac-leopard/fast/canvas/image-pattern-rotate-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/image-pattern-rotate-expected.png.
        * platform/chromium-mac-leopard/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png.
        * platform/chromium-mac-leopard/fast/forms/textfield-focus-ring-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/textfield-focus-ring-expected.png.
        * platform/chromium-mac-leopard/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.png.
        * platform/chromium-mac-leopard/fast/inline-block/14498-positionForCoordinates-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/inline-block/14498-positionForCoordinates-expected.png.
        * platform/chromium-mac-leopard/fast/inline/inline-focus-ring-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/inline/inline-focus-ring-expected.png.
        * platform/chromium-mac-leopard/fast/replaced/absolute-image-sizing-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/replaced/absolute-image-sizing-expected.png.
        * platform/chromium-mac-leopard/fast/replaced/image-onload-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/replaced/image-onload-expected.png.
        * platform/chromium-mac-leopard/fast/replaced/image-sizing-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/replaced/image-sizing-expected.png.
        * platform/chromium-mac-leopard/fast/text/basic/002-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/text/basic/002-expected.png.
        * platform/chromium-mac-leopard/fast/text/word-break-soft-hyphen-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/text/word-break-soft-hyphen-expected.png.
        * platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png.
        * platform/chromium-mac-leopard/svg/custom/focus-ring-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/custom/focus-ring-expected.png.
        * platform/chromium-mac-leopard/svg/filters/filterRes-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/filters/filterRes-expected.png.
        * platform/chromium-mac/css2.1/t0804-c5510-padn-00-b-ag-expected.checksum: Removed.
        * platform/chromium-mac/css2.1/t0905-c414-flt-wrap-01-d-g-expected.checksum:
        * platform/chromium-mac/css2.1/t0905-c414-flt-wrap-01-d-g-expected.png:
        * platform/chromium-mac/editing/inserting/4875189-2-expected.checksum: Removed.
        * platform/chromium-mac/editing/pasteboard/5387578-expected.checksum: Removed.
        * platform/chromium-mac/editing/pasteboard/paste-table-cells-expected.checksum: Removed.
        * platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-expected.checksum:
        * platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-expected.png:
        * platform/chromium-mac/fast/block/float/014-expected.checksum:
        * platform/chromium-mac/fast/block/float/014-expected.png:
        * platform/chromium-mac/fast/block/float/clear-element-too-wide-for-containing-block-expected.checksum: Removed.
        * platform/chromium-mac/fast/borders/border-radius-inline-flow-expected.checksum: Removed.
        * platform/chromium-mac/fast/canvas/canvas-zoom-expected.checksum: Removed.
        * platform/chromium-mac/fast/canvas/image-pattern-rotate-expected.checksum:
        * platform/chromium-mac/fast/canvas/image-pattern-rotate-expected.png:
        * platform/chromium-mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.checksum: Removed.
        * platform/chromium-mac/fast/forms/textfield-focus-ring-expected.checksum: Removed.
        * platform/chromium-mac/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.checksum:
        * platform/chromium-mac/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.png:
        * platform/chromium-mac/fast/inline-block/14498-positionForCoordinates-expected.checksum: Removed.
        * platform/chromium-mac/fast/inline/inline-focus-ring-expected.checksum: Removed.
        * platform/chromium-mac/fast/replaced/absolute-image-sizing-expected.checksum:
        * platform/chromium-mac/fast/replaced/absolute-image-sizing-expected.png:
        * platform/chromium-mac/fast/replaced/image-onload-expected.checksum:
        * platform/chromium-mac/fast/replaced/image-onload-expected.png:
        * platform/chromium-mac/fast/replaced/image-sizing-expected.checksum:
        * platform/chromium-mac/fast/replaced/image-sizing-expected.png:
        * platform/chromium-mac/fast/text/basic/002-expected.checksum: Removed.
        * platform/chromium-mac/fast/text/word-break-soft-hyphen-expected.checksum: Removed.
        * platform/chromium-mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.checksum: Removed.
        * platform/chromium-mac/svg/custom/focus-ring-expected.checksum:
        * platform/chromium-mac/svg/custom/focus-ring-expected.png:
        * platform/chromium-mac/svg/filters/filterRes-expected.checksum: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Robert Hogan <robert@webkit.org>
robert@webkit.org [Wed, 30 Mar 2011 20:14:13 +0000 (20:14 +0000)]
2011-03-30  Robert Hogan  <robert@webkit.org>

        Reviewed by Antonio Gomes.

        [Qt] Fix LoadHTMLStringItem::invoke() after r75966

        Unskip http/tests/navigation/go-back-to-error-page.html

        https://bugs.webkit.org/show_bug.cgi?id=52614

        * platform/qt/Skipped:
2011-03-30  Robert Hogan  <robert@webkit.org>

        Reviewed by Antonio Gomes.

        [Qt] Fix LoadHTMLStringItem::invoke() after r75966

        Add DRT support for loading an alternate HTML string
        for error pages. This allows Qt to unskip
        http/tests/navigation/go-back-to-error-page.html.

        https://bugs.webkit.org/show_bug.cgi?id=52614

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::setAlternateHtml):
        * WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-03-30  Robert Hogan  <robert@webkit.org>

        Reviewed by Antonio Gomes.

        [Qt] Fix LoadHTMLStringItem::invoke() after r75966
        Unskip http/tests/navigation/go-back-to-error-page.html

        Also add the location of DumpRenderTreeSupportQt.h
        to DRT's include paths.

        https://bugs.webkit.org/show_bug.cgi?id=52614

        * DumpRenderTree/qt/DumpRenderTree.pro:
        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        * DumpRenderTree/qt/DumpRenderTreeQt.h:
        * DumpRenderTree/qt/GCControllerQt.cpp:
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::queueLoadHTMLString):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:
        * DumpRenderTree/qt/PlainTextControllerQt.cpp:
        * DumpRenderTree/qt/TextInputControllerQt.cpp:
        * DumpRenderTree/qt/WorkQueueItemQt.cpp:
        (LoadAlternateHTMLStringItem::invoke):
        * DumpRenderTree/qt/WorkQueueItemQt.h:
        (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
        * QtTestBrowser/QtTestBrowser.pro:
        * QtTestBrowser/launcherwindow.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 30 Mar 2011 20:02:35 +0000 (20:02 +0000)]
2011-03-30  Mihai Parparita  <mihaip@chromium.org>

        Fix editing/deleting for Chromium Snow Leopard.

        Same mismatched checksum story as r82480.

        * platform/chromium-mac-leopard/editing/deleting/4845371-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/deleting/4845371-expected.png.
        * platform/chromium-mac-leopard/editing/deleting/5126166-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/deleting/5126166-expected.png.
        * platform/chromium-mac-leopard/editing/deleting/5483370-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/deleting/5483370-expected.png.
        * platform/chromium-mac/editing/deleting/4845371-expected.checksum: Removed.
        * platform/chromium-mac/editing/deleting/5126166-expected.checksum: Removed.
        * platform/chromium-mac/editing/deleting/5483370-expected.checksum: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCrash when closing "Add Bookmark" dialog using the Enter Key
bweinstein@apple.com [Wed, 30 Mar 2011 19:58:07 +0000 (19:58 +0000)]
Crash when closing "Add Bookmark" dialog using the Enter Key
https://bugs.webkit.org/show_bug.cgi?id=57294
<rdar://problem/9044756>

Reviewed by Darin Adler.

Protect the FrameView in EventHandler::keyEvent, like we do in other EventHandler
functions that could destroy the frame.

* page/EventHandler.cpp:
(WebCore::EventHandler::keyEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 30 Mar 2011 19:45:47 +0000 (19:45 +0000)]
2011-03-30  Mihai Parparita  <mihaip@chromium.org>

        Fix svg/dynamic-updates/SVGFEConvolveMatrixElement* for Chromium Snow Leopard.

        There were lone .checksum files in chromium-mac-leopard/ (similar to
        r82480), now they should have corresponding .pngs too.

        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png.
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 30 Mar 2011 19:43:45 +0000 (19:43 +0000)]
2011-03-30  Adam Barth  <abarth@webkit.org>

        Reviewed by Adam Roben.

        SheriffBot rollouts take too long
        https://bugs.webkit.org/show_bug.cgi?id=57498

        We used to build before landing rollouts via the commit-queue to
        prevent further breakage, but now that our individual commit-queue
        machines are slower, building takes too long.  I can't remember the
        last time a rollout broke compile.  It seems like just landing the
        patch is the better trade-off.

        * Scripts/webkitpy/tool/bot/commitqueuetask.py:
        * Scripts/webkitpy/tool/commands/queues_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 30 Mar 2011 19:41:01 +0000 (19:41 +0000)]
2011-03-30  Martin Robinson  <mrobinson@igalia.com>

        Update some GTK+ results after r82411.

        * platform/gtk/svg/text/bidi-reorder-value-lists-expected.checksum:
        * platform/gtk/svg/text/bidi-reorder-value-lists-expected.png:
        * platform/gtk/svg/text/bidi-reorder-value-lists-expected.txt:
        * platform/gtk/svg/text/font-size-below-point-five-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Sheriff Bot <webkit.review.bot@gmail.com>
abarth@webkit.org [Wed, 30 Mar 2011 19:31:26 +0000 (19:31 +0000)]
2011-03-30  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r82463.
        http://trac.webkit.org/changeset/82463
        https://bugs.webkit.org/show_bug.cgi?id=57482

        Assertion failure in Node::rendererIsEditable on multiple
        editing tests (Requested by aroben|meeting on #webkit).

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        * css/CSSPrimitiveValueMappings.h:
        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
        (WebCore::CSSPrimitiveValue::operator EUnicodeBidi):
        * css/CSSValueKeywords.in:
        * rendering/style/RenderStyle.h:
        * rendering/style/RenderStyleConstants.h:
2011-03-30  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r82463.
        http://trac.webkit.org/changeset/82463
        https://bugs.webkit.org/show_bug.cgi?id=57482

        Assertion failure in Node::rendererIsEditable on multiple
        editing tests (Requested by aroben|meeting on #webkit).

        * css3/unicode-bidi-plaintext-parse-expected.txt: Removed.
        * css3/unicode-bidi-plaintext-parse.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 John Abd-El-Malek <jam@chromium.org>
jam@chromium.org [Wed, 30 Mar 2011 19:21:03 +0000 (19:21 +0000)]
2011-03-29  John Abd-El-Malek  <jam@chromium.org>

        Reviewed by Tony Chang.

        [chromium]: Remove the code that called WebViewClient for spelling now that chromium is updated
        https://bugs.webkit.org/show_bug.cgi?id=57396

        * DEPS:
        * public/WebFrame.h:
        * public/WebView.h:
        * public/WebViewClient.h:
        (WebKit::WebViewClient::handleCurrentKeyboardEvent):
        * src/EditorClientImpl.cpp:
        (WebKit::EditorClientImpl::checkSpellingOfString):
        (WebKit::EditorClientImpl::requestCheckingOfString):
        (WebKit::EditorClientImpl::getAutoCorrectSuggestionForMisspelledWord):
        (WebKit::EditorClientImpl::updateSpellingUIWithMisspelledWord):
        (WebKit::EditorClientImpl::showSpellingUI):
        (WebKit::EditorClientImpl::spellingUIIsShowing):
        * src/WebViewImpl.cpp:
        (WebKit::WebView::create):
        * src/WebViewImpl.h:
        * src/WebWorkerBase.cpp:
        (WebKit::WebWorkerBase::initializeLoader):
        * tests/PopupMenuTest.cpp:
        (WebKit::SelectPopupMenuTest::SetUp):
        * tests/WebFrameTest.cpp:
        (WebKit::TEST_F):
        * tests/WebPageSerializerTest.cpp:
        (WebKit::WebPageSerializerTest::SetUp):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 30 Mar 2011 18:50:19 +0000 (18:50 +0000)]
2011-03-30  Mihai Parparita  <mihaip@chromium.org>

        Fix fast/multicol for Chromium Snow Leopard.

        We somehow ended up with only .checksum files in chromium-mac-leopard/
        (due to r67681 and then moved by r73376). The checksums in chromium-mac/
        were identical, so I deleted those and moved the corresponding .png
        to chromium-mac-leopard/, to live alongside its checksum.

        The mac/ baselines are correct for Snow Leopard, so we don't actually
        need any updates to get the tests to pass.

        * platform/chromium-mac-leopard/fast/max-height-columns-block-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/multicol/max-height-columns-block-expected.png.
        * platform/chromium-mac-leopard/fast/multicol/margin-collapse-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/multicol/margin-collapse-expected.png.
        * platform/chromium-mac-leopard/fast/multicol/positioned-split-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/multicol/positioned-split-expected.png.
        * platform/chromium-mac-leopard/fast/multicol/single-line-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/multicol/single-line-expected.png.
        * platform/chromium-mac-leopard/fast/multicol/table-margin-collapse-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/multicol/table-margin-collapse-expected.png.
        * platform/chromium-mac-leopard/fast/multicol/unsplittable-inline-block-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/multicol/unsplittable-inline-block-expected.png.
        * platform/chromium-mac/fast/multicol/margin-collapse-expected.checksum: Removed.
        * platform/chromium-mac/fast/multicol/max-height-columns-block-expected.checksum: Removed.
        * platform/chromium-mac/fast/multicol/positioned-split-expected.checksum: Removed.
        * platform/chromium-mac/fast/multicol/single-line-expected.checksum: Removed.
        * platform/chromium-mac/fast/multicol/table-margin-collapse-expected.checksum: Removed.
        * platform/chromium-mac/fast/multicol/unsplittable-inline-block-expected.checksum: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove platform/chromium-mac-snowleopard
abarth@webkit.org [Wed, 30 Mar 2011 18:47:17 +0000 (18:47 +0000)]
Remove platform/chromium-mac-snowleopard
https://bugs.webkit.org/show_bug.cgi?id=57486

Tools:

This directory no longer exists, so we can remove it from the fallback
chain.

* Scripts/webkitpy/layout_tests/port/chromium_mac.py:

LayoutTests:

Remove empty directories.

* platform/chromium-mac-snowleopard: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] QNetworkReplyHandler refactoring: signal sequence.
luiz@webkit.org [Wed, 30 Mar 2011 18:46:45 +0000 (18:46 +0000)]
[Qt] QNetworkReplyHandler refactoring: signal sequence.
https://bugs.webkit.org/show_bug.cgi?id=57049

Reviewed by Kenneth Rohde Christiansen.

This is the first step in QNetworkReplyHandler. The main objective here is to create simple invariants:

    1 - that the signals metadatachanged, readyRead and finished will come in this order.
    2 - that signals metadatachanged and finished will be called exactly once.

Having these invariants further simplifications will be possible and will come in future patches.

Class QNetworkReplyWrapper was created to handle QNetworkReply object. To connect to the signals of it
instead of connecting to the signals of QNetworkReply is what guarantees the sequence of the signals.
QNetworkReplyWrapper will be used in future to perform mime type sniffing before sending
metadatachanged signal.

* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper):
(WebCore::QNetworkReplyWrapper::~QNetworkReplyWrapper):
(WebCore::QNetworkReplyWrapper::release):
(WebCore::QNetworkReplyWrapper::resetConnections):
(WebCore::QNetworkReplyWrapper::receiveMetaData):
(WebCore::QNetworkReplyWrapper::didReceiveFinished):
(WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
(WebCore::QNetworkReplyHandler::resetState):
(WebCore::QNetworkReplyHandler::release):
(WebCore::QNetworkReplyHandler::finish):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::redirect):
(WebCore::QNetworkReplyHandler::forwardData):
(WebCore::QNetworkReplyHandler::sendNetworkRequest):
(WebCore::QNetworkReplyHandler::start):
* platform/network/qt/QNetworkReplyHandler.h:
(WebCore::QNetworkReplyWrapper::reply):
(WebCore::QNetworkReplyWrapper::redirectionTargetUrl):
(WebCore::QNetworkReplyWrapper::encoding):
(WebCore::QNetworkReplyWrapper::advertisedMimeType):
(WebCore::QNetworkReplyHandler::reply):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Wed, 30 Mar 2011 18:35:18 +0000 (18:35 +0000)]
2011-03-30  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam Roben.

        Rename Windows configuration Release_LTCG to Production for clarity
        https://bugs.webkit.org/show_bug.cgi?id=57465

        * JavaScriptCore.vcproj/JavaScriptCore.sln:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreProduction.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreReleaseLTCG.vsprops.
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreReleaseLTCG.vsprops: Removed.
        * JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln:
        * JavaScriptCore.vcproj/WTF/WTF.vcproj:
        * JavaScriptCore.vcproj/WTF/WTFProduction.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFReleaseLTCG.vsprops.
        * JavaScriptCore.vcproj/WTF/WTFReleaseLTCG.vsprops: Removed.
        * JavaScriptCore.vcproj/jsc/jsc.vcproj:
        * JavaScriptCore.vcproj/jsc/jscProduction.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/jsc/jscReleaseLTCG.vsprops.
        * JavaScriptCore.vcproj/jsc/jscReleaseLTCG.vsprops: Removed.
        * JavaScriptCore.vcproj/testapi/testapi.vcproj:
        * JavaScriptCore.vcproj/testapi/testapiProduction.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/testapi/testapiReleaseLTCG.vsprops.
        * JavaScriptCore.vcproj/testapi/testapiReleaseLTCG.vsprops: Removed.
2011-03-30  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam Roben.

        Rename Windows configuration Release_LTCG to Production for clarity
        https://bugs.webkit.org/show_bug.cgi?id=57465

        * WebKit.vcproj/Interfaces.vcproj:
        * WebKit.vcproj/InterfacesProduction.vsprops: Copied from Source/WebKit/win/WebKit.vcproj/InterfacesReleaseLTCG.vsprops.
        * WebKit.vcproj/InterfacesReleaseLTCG.vsprops: Removed.
        * WebKit.vcproj/WebKit.sln:
        * WebKit.vcproj/WebKit.submit.sln:
        * WebKit.vcproj/WebKit.vcproj:
        * WebKit.vcproj/WebKitGUID.vcproj:
        * WebKit.vcproj/WebKitGUIDProduction.vsprops: Copied from Source/WebKit/win/WebKit.vcproj/WebKitGUIDReleaseLTCG.vsprops.
        * WebKit.vcproj/WebKitGUIDReleaseLTCG.vsprops: Removed.
        * WebKit.vcproj/WebKitLibProduction.vsprops: Copied from Source/WebKit/win/WebKit.vcproj/WebKitLibReleaseLTCG.vsprops.
        * WebKit.vcproj/WebKitLibReleaseLTCG.vsprops: Removed.
2011-03-30  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam Roben.

        Rename Windows configuration Release_LTCG to Production for clarity
        https://bugs.webkit.org/show_bug.cgi?id=57465

        * WebCore.vcproj/QTMovieWin.vcproj:
        * WebCore.vcproj/QTMovieWinProduction.vsprops: Copied from Source/WebCore/WebCore.vcproj/QTMovieWinReleaseLTCG.vsprops.
        * WebCore.vcproj/QTMovieWinReleaseLTCG.vsprops: Removed.
        * WebCore.vcproj/WebCore.sln:
        * WebCore.vcproj/WebCore.submit.sln:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.vcproj/WebCoreGenerated.vcproj:
        * WebCore.vcproj/WebCoreProduction.vsprops: Copied from Source/WebCore/WebCore.vcproj/WebCoreReleaseLTCG.vsprops.
        * WebCore.vcproj/WebCoreReleaseLTCG.vsprops: Removed.
2011-03-30  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam Roben.

        Rename Windows configuration Release_LTCG to Production for clarity
        https://bugs.webkit.org/show_bug.cgi?id=57465

        * win/WebKit2.submit.sln:
        * win/WebKit2.vcproj:
        * win/WebKit2Generated.vcproj:
        * win/WebKit2Production.vsprops: Copied from Source/WebKit2/win/WebKit2ReleaseLTCG.vsprops.
        * win/WebKit2ReleaseLTCG.vsprops: Removed.
        * win/WebKit2WebProcess.vcproj:
        * win/WebKit2WebProcessProduction.vsprops: Copied from Source/WebKit2/win/WebKit2WebProcessReleaseLTCG.vsprops.
        * win/WebKit2WebProcessReleaseLTCG.vsprops: Removed.
2011-03-30  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam Roben.

        Rename Windows configuration Release_LTCG to Production for clarity
        https://bugs.webkit.org/show_bug.cgi?id=57465

        * DumpRenderTree/DumpRenderTree.sln:
        * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
        * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops: Copied from Tools/DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops.
        * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Removed.
        * DumpRenderTree/win/DumpRenderTree.vcproj:
        * DumpRenderTree/win/DumpRenderTreeProduction.vsprops: Copied from Tools/DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops.
        * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Removed.
        * DumpRenderTree/win/ImageDiff.vcproj:
        * DumpRenderTree/win/ImageDiffProduction.vsprops: Copied from Tools/DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops.
        * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Removed.
        * FindSafari/FindSafari.vcproj:
        * FindSafari/FindSafariProduction.vsprops: Copied from Tools/FindSafari/FindSafariReleaseLTCG.vsprops.
        * FindSafari/FindSafariReleaseLTCG.vsprops: Removed.
        * MiniBrowser/Configurations/MiniBrowserProduction.vsprops: Copied from Tools/MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops.
        * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Removed.
        * MiniBrowser/MiniBrowser.vcproj:
        * Scripts/webkitdirs.pm:
        * TestWebKitAPI/win/TestWebKitAPI.sln:
        * TestWebKitAPI/win/TestWebKitAPI.vcproj:
        * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
        * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
        * WebKitAPITest/WebKitAPITest.vcproj:
        * WebKitAPITest/WebKitAPITestProduction.vsprops: Copied from Tools/WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops.
        * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Removed.
        * WebKitLauncherWin/WebKitLauncherWin.vcproj:
        * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops: Copied from Tools/WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops.
        * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Removed.
        * WebKitTestRunner/WebKitTestRunner.sln:
        * WebKitTestRunner/win/InjectedBundle.vcproj:
        * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
        * WebKitTestRunner/win/InjectedBundleProduction.vsprops: Copied from Tools/WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops.
        * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Removed.
        * WebKitTestRunner/win/WebKitTestRunner.vcproj:
        * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops: Copied from Tools/WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops.
        * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Removed.
        * WinLauncher/WinLauncher.vcproj:
        * WinLauncher/WinLauncherProduction.vsprops: Copied from Tools/WinLauncher/WinLauncherReleaseLTCG.vsprops.
        * WinLauncher/WinLauncherReleaseLTCG.vsprops: Removed.
        * record-memory-win/record-memory-win.vcproj:
        * record-memory-win/record-memory-winProduction.vsprops: Copied from Tools/record-memory-win/record-memory-winReleaseLTCG.vsprops.
        * record-memory-win/record-memory-winReleaseLTCG.vsprops: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Add 3 failing tests to the Skipped list because of different bugs.
ossy@webkit.org [Wed, 30 Mar 2011 18:23:11 +0000 (18:23 +0000)]
[Qt] Add 3 failing tests to the Skipped list because of different bugs.
Additionally update Qt specific results after r82280 and unskip them.

* platform/qt/Skipped:
 - Add css2.1/t0805-c5519-ibrdr-r-00-a.html (https://bugs.webkit.org/show_bug.cgi?id=57459)
 - Add media/video-playbackrate.html (https://bugs.webkit.org/show_bug.cgi?id=57476)
 - Add fast/events/onsearch-enter.html (https://bugs.webkit.org/show_bug.cgi?id=57472)
 - Unskip passing tests

* platform/qt/editing/pasteboard/paste-text-011-expected.checksum: Added.
* platform/qt/editing/pasteboard/paste-text-011-expected.png: Added.
* platform/qt/editing/pasteboard/paste-text-011-expected.txt:
* platform/qt/fast/css-generated-content/014-expected.checksum:
* platform/qt/fast/css-generated-content/014-expected.png:
* platform/qt/fast/css-generated-content/014-expected.txt:
* platform/qt/fast/css/word-space-extra-expected.checksum:
* platform/qt/fast/css/word-space-extra-expected.png:
* platform/qt/fast/css/word-space-extra-expected.txt:
* platform/qt/tables/mozilla/bugs/bug16252-expected.txt:
* platform/qt/tables/mozilla/bugs/bug2123-expected.checksum:
* platform/qt/tables/mozilla/bugs/bug2123-expected.png:
* platform/qt/tables/mozilla/bugs/bug2123-expected.txt:
* platform/qt/tables/mozilla/bugs/bug43854-1-expected.checksum:
* platform/qt/tables/mozilla/bugs/bug43854-1-expected.png:
* platform/qt/tables/mozilla/bugs/bug43854-1-expected.txt:
* platform/qt/tables/mozilla/bugs/bug4523-expected.checksum:
* platform/qt/tables/mozilla/bugs/bug4523-expected.png:
* platform/qt/tables/mozilla/bugs/bug4523-expected.txt:
* platform/qt/tables/mozilla/bugs/bug57828-2-expected.checksum:
* platform/qt/tables/mozilla/bugs/bug57828-2-expected.png:
* platform/qt/tables/mozilla/bugs/bug57828-2-expected.txt:
* platform/qt/tables/mozilla/core/bloomberg-expected.checksum:
* platform/qt/tables/mozilla/core/bloomberg-expected.png:
* platform/qt/tables/mozilla/core/bloomberg-expected.txt:
* platform/qt/tables/mozilla/marvin/backgr_index-expected.checksum:
* platform/qt/tables/mozilla/marvin/backgr_index-expected.png:
* platform/qt/tables/mozilla/marvin/backgr_index-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Wed, 30 Mar 2011 18:21:52 +0000 (18:21 +0000)]
2011-03-30  Jer Noble  <jer.noble@apple.com>

        Reviewed by Dan Bernstein.

        WebKit2: WebProcess is using 89%, while viewing a PDF
        https://bugs.webkit.org/show_bug.cgi?id=57471

        Break a never ending display/update cycle between the UIProcess and the WebProcess
        by clearing the dirty region when a page has a custom representation (like a PDF).
        Also, avoid the issue where possible by not setting the dirty region in the same case.

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::setNeedsDisplay): Bail early if mainFrameHasCustomRepresentation().
        (WebKit::DrawingAreaImpl::scroll): Ditto.
        (WebKit::DrawingAreaImpl::display): Both bail early and clear m_dirtyRegion if
            mainFrameHasCustomRepresentation().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 30 Mar 2011 18:20:43 +0000 (18:20 +0000)]
2011-03-30  Adam Barth  <abarth@webkit.org>

        Move results from chromium-mac-snowleopard to chromium-mac.  We
        shouldn't have any results in chromium-mac-snowleopard until we start
        worrying about Lion.

        This patch overwrites fast/transforms/shadows in chromium-mac, which
        doesn't seem to be visible to any platform, as I understand things.

        * platform/chromium-mac-snowleopard/css1/box_properties/clear-expected.checksum: Removed.
        * platform/chromium-mac-snowleopard/css1/box_properties/clear-expected.png: Removed.
        * platform/chromium-mac-snowleopard/css1/box_properties/float-expected.checksum: Removed.
        * platform/chromium-mac-snowleopard/css1/box_properties/float-expected.png: Removed.
        * platform/chromium-mac-snowleopard/css1/text_properties/vertical_align-expected.checksum: Removed.
        * platform/chromium-mac-snowleopard/css1/text_properties/vertical_align-expected.png: Removed.
        * platform/chromium-mac-snowleopard/css2.1/t0803-c5501-imrgn-t-00-b-ag-expected.checksum: Removed.
        * platform/chromium-mac-snowleopard/css2.1/t0803-c5501-imrgn-t-00-b-ag-expected.png: Removed.
        * platform/chromium-mac-snowleopard/css2.1/t0803-c5502-mrgn-r-00-c-ag-expected.checksum: Removed.
        * platform/chromium-mac-snowleopard/css2.1/t0803-c5502-mrgn-r-00-c-ag-expected.png: Removed.
        * platform/chromium-mac-snowleopard/css2.1/t0803-c5503-imrgn-b-00-b-a-expected.checksum: Removed.
        * platform/chromium-mac-snowleopard/css2.1/t0803-c5503-imrgn-b-00-b-a-expected.png: Removed.
        * platform/chromium-mac-snowleopard/css2.1/t0803-c5504-mrgn-l-00-c-ag-expected.checksum: Removed.
        * platform/chromium-mac-snowleopard/css2.1/t0803-c5504-mrgn-l-00-c-ag-expected.png: Removed.
        * platform/chromium-mac-snowleopard/css2.1/t0803-c5505-mrgn-00-b-ag-expected.checksum: Removed.
        * platform/chromium-mac-snowleopard/css2.1/t0803-c5505-mrgn-00-b-ag-expected.png: Removed.
        * platform/chromium-mac-snowleopard/css2.1/t0905-c414-flt-01-d-g-expected.checksum: Removed.
        * platform/chromium-mac-snowleopard/css2.1/t0905-c414-flt-01-d-g-expected.png: Removed.
        * platform/chromium-mac-snowleopard/css2.1/t100304-c43-rpl-bbx-00-d-g-expected.checksum: Removed.
        * platform/chromium-mac-snowleopard/css2.1/t100304-c43-rpl-bbx-00-d-g-expected.png: Removed.
        * platform/chromium-mac-snowleopard/css2.1/t1008-c44-ln-box-00-d-ag-expected.checksum: Removed.
        * platform/chromium-mac-snowleopard/css2.1/t1008-c44-ln-box-00-d-ag-expected.png: Removed.
        * platform/chromium-mac-snowleopard/css2.1/t1008-c44-ln-box-03-d-ag-expected.checksum: Removed.
        * platform/chromium-mac-snowleopard/css2.1/t1008-c44-ln-box-03-d-ag-expected.png: Removed.
        * platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-02-d-agi-expected.checksum: Removed.
        * platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-02-d-agi-expected.png: Removed.
        * platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-04-d-agi-expected.checksum: Removed.
        * platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-04-d-agi-expected.png: Removed.
        * platform/chromium-mac-snowleopard/fast/block/positioning/047-expected.checksum: Removed.
        * platform/chromium-mac-snowleopard/fast/block/positioning/047-expected.png: Removed.
        * platform/chromium-mac-snowleopard/fast/css/resize-corner-tracking-transformed-expected.checksum: Removed.
        * platform/chromium-mac-snowleopard/fast/css/resize-corner-tracking-transformed-expected.png: Removed.
        * platform/chromium-mac-snowleopard/fast/forms/searchfield-heights-expected.checksum: Removed.
        * platform/chromium-mac-snowleopard/fast/forms/searchfield-heights-expected.png: Removed.
        * platform/chromium-mac-snowleopard/fast/forms/slider-thumb-shared-style-expected.checksum: Removed.
        * platform/chromium-mac-snowleopard/fast/forms/slider-thumb-shared-style-expected.png: Removed.
        * platform/chromium-mac-snowleopard/fast/gradients/background-clipped-expected.checksum: Removed.
        * platform/chromium-mac-snowleopard/fast/gradients/background-clipped-expected.png: Removed.
        * platform/chromium-mac-snowleopard/fast/replaced/selection-rect-transform-expected.checksum: Removed.
        * platform/chromium-mac-snowleopard/fast/replaced/selection-rect-transform-expected.png: Removed.
        * platform/chromium-mac-snowleopard/fast/text/whitespace/tab-character-basics-expected.checksum: Removed.
        * platform/chromium-mac-snowleopard/fast/text/whitespace/tab-character-basics-expected.png: Removed.
        * platform/chromium-mac-snowleopard/fast/transforms/diamond-expected.checksum: Removed.
        * platform/chromium-mac-snowleopard/fast/transforms/diamond-expected.png: Removed.
        * platform/chromium-mac-snowleopard/fast/transforms/shadows-expected.checksum: Removed.
        * platform/chromium-mac-snowleopard/fast/transforms/shadows-expected.png: Removed.
        * platform/chromium-mac-snowleopard/fast/transforms/transformed-caret-expected.checksum: Removed.
        * platform/chromium-mac-snowleopard/fast/transforms/transformed-caret-expected.png: Removed.
        * platform/chromium-mac-snowleopard/svg/text/bidi-embedded-direction-expected.checksum: Removed.
        * platform/chromium-mac-snowleopard/svg/text/bidi-embedded-direction-expected.png: Removed.
        * platform/chromium-mac-snowleopard/svg/text/bidi-embedded-direction-expected.txt: Removed.
        * platform/chromium-mac/css1/box_properties/clear-expected.checksum: Copied from LayoutTests/platform/chromium-mac-snowleopard/css1/box_properties/clear-expected.checksum.
        * platform/chromium-mac/css1/box_properties/clear-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/css1/box_properties/clear-expected.png.
        * platform/chromium-mac/css1/box_properties/float-expected.checksum: Copied from LayoutTests/platform/chromium-mac-snowleopard/css1/box_properties/float-expected.checksum.
        * platform/chromium-mac/css1/box_properties/float-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/css1/box_properties/float-expected.png.
        * platform/chromium-mac/css1/text_properties/vertical_align-expected.checksum: Copied from LayoutTests/platform/chromium-mac-snowleopard/css1/text_properties/vertical_align-expected.checksum.
        * platform/chromium-mac/css1/text_properties/vertical_align-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/css1/text_properties/vertical_align-expected.png.
        * platform/chromium-mac/css2.1/t0803-c5501-imrgn-t-00-b-ag-expected.checksum: Copied from LayoutTests/platform/chromium-mac-snowleopard/css2.1/t0803-c5501-imrgn-t-00-b-ag-expected.checksum.
        * platform/chromium-mac/css2.1/t0803-c5501-imrgn-t-00-b-ag-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/css2.1/t0803-c5501-imrgn-t-00-b-ag-expected.png.
        * platform/chromium-mac/css2.1/t0803-c5502-mrgn-r-00-c-ag-expected.checksum: Copied from LayoutTests/platform/chromium-mac-snowleopard/css2.1/t0803-c5502-mrgn-r-00-c-ag-expected.checksum.
        * platform/chromium-mac/css2.1/t0803-c5502-mrgn-r-00-c-ag-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/css2.1/t0803-c5502-mrgn-r-00-c-ag-expected.png.
        * platform/chromium-mac/css2.1/t0803-c5503-imrgn-b-00-b-a-expected.checksum: Copied from LayoutTests/platform/chromium-mac-snowleopard/css2.1/t0803-c5503-imrgn-b-00-b-a-expected.checksum.
        * platform/chromium-mac/css2.1/t0803-c5503-imrgn-b-00-b-a-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/css2.1/t0803-c5503-imrgn-b-00-b-a-expected.png.
        * platform/chromium-mac/css2.1/t0803-c5504-mrgn-l-00-c-ag-expected.checksum: Copied from LayoutTests/platform/chromium-mac-snowleopard/css2.1/t0803-c5504-mrgn-l-00-c-ag-expected.checksum.
        * platform/chromium-mac/css2.1/t0803-c5504-mrgn-l-00-c-ag-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/css2.1/t0803-c5504-mrgn-l-00-c-ag-expected.png.
        * platform/chromium-mac/css2.1/t0803-c5505-mrgn-00-b-ag-expected.checksum: Copied from LayoutTests/platform/chromium-mac-snowleopard/css2.1/t0803-c5505-mrgn-00-b-ag-expected.checksum.
        * platform/chromium-mac/css2.1/t0803-c5505-mrgn-00-b-ag-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/css2.1/t0803-c5505-mrgn-00-b-ag-expected.png.
        * platform/chromium-mac/css2.1/t0905-c414-flt-01-d-g-expected.checksum: Replaced with LayoutTests/platform/chromium-mac-snowleopard/css2.1/t0905-c414-flt-01-d-g-expected.checksum.
        * platform/chromium-mac/css2.1/t0905-c414-flt-01-d-g-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/css2.1/t0905-c414-flt-01-d-g-expected.png.
        * platform/chromium-mac/css2.1/t100304-c43-rpl-bbx-00-d-g-expected.checksum: Copied from LayoutTests/platform/chromium-mac-snowleopard/css2.1/t100304-c43-rpl-bbx-00-d-g-expected.checksum.
        * platform/chromium-mac/css2.1/t100304-c43-rpl-bbx-00-d-g-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/css2.1/t100304-c43-rpl-bbx-00-d-g-expected.png.
        * platform/chromium-mac/css2.1/t1008-c44-ln-box-00-d-ag-expected.checksum: Copied from LayoutTests/platform/chromium-mac-snowleopard/css2.1/t1008-c44-ln-box-00-d-ag-expected.checksum.
        * platform/chromium-mac/css2.1/t1008-c44-ln-box-00-d-ag-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/css2.1/t1008-c44-ln-box-00-d-ag-expected.png.
        * platform/chromium-mac/css2.1/t1008-c44-ln-box-03-d-ag-expected.checksum: Copied from LayoutTests/platform/chromium-mac-snowleopard/css2.1/t1008-c44-ln-box-03-d-ag-expected.checksum.
        * platform/chromium-mac/css2.1/t1008-c44-ln-box-03-d-ag-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/css2.1/t1008-c44-ln-box-03-d-ag-expected.png.
        * platform/chromium-mac/css2.1/t100801-c544-valgn-02-d-agi-expected.checksum: Replaced with LayoutTests/platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-02-d-agi-expected.checksum.
        * platform/chromium-mac/css2.1/t100801-c544-valgn-02-d-agi-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-02-d-agi-expected.png.
        * platform/chromium-mac/css2.1/t100801-c544-valgn-04-d-agi-expected.checksum: Replaced with LayoutTests/platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-04-d-agi-expected.checksum.
        * platform/chromium-mac/css2.1/t100801-c544-valgn-04-d-agi-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-04-d-agi-expected.png.
        * platform/chromium-mac/fast/block/positioning/047-expected.checksum: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/block/positioning/047-expected.checksum.
        * platform/chromium-mac/fast/block/positioning/047-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/block/positioning/047-expected.png.
        * platform/chromium-mac/fast/css/resize-corner-tracking-transformed-expected.checksum: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/css/resize-corner-tracking-transformed-expected.checksum.
        * platform/chromium-mac/fast/css/resize-corner-tracking-transformed-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/css/resize-corner-tracking-transformed-expected.png.
        * platform/chromium-mac/fast/forms/searchfield-heights-expected.checksum: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/searchfield-heights-expected.checksum.
        * platform/chromium-mac/fast/forms/searchfield-heights-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/searchfield-heights-expected.png.
        * platform/chromium-mac/fast/forms/slider-thumb-shared-style-expected.checksum: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/slider-thumb-shared-style-expected.checksum.
        * platform/chromium-mac/fast/forms/slider-thumb-shared-style-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/slider-thumb-shared-style-expected.png.
        * platform/chromium-mac/fast/gradients/background-clipped-expected.checksum: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/gradients/background-clipped-expected.checksum.
        * platform/chromium-mac/fast/gradients/background-clipped-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/gradients/background-clipped-expected.png.
        * platform/chromium-mac/fast/replaced/selection-rect-transform-expected.checksum: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/replaced/selection-rect-transform-expected.checksum.
        * platform/chromium-mac/fast/replaced/selection-rect-transform-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/replaced/selection-rect-transform-expected.png.
        * platform/chromium-mac/fast/text/whitespace/tab-character-basics-expected.checksum: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/text/whitespace/tab-character-basics-expected.checksum.
        * platform/chromium-mac/fast/text/whitespace/tab-character-basics-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/text/whitespace/tab-character-basics-expected.png.
        * platform/chromium-mac/fast/transforms/diamond-expected.checksum: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/transforms/diamond-expected.checksum.
        * platform/chromium-mac/fast/transforms/diamond-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/transforms/diamond-expected.png.
        * platform/chromium-mac/fast/transforms/shadows-expected.checksum: Replaced with LayoutTests/platform/chromium-mac-snowleopard/fast/transforms/shadows-expected.checksum.
        * platform/chromium-mac/fast/transforms/shadows-expected.png: Replaced with LayoutTests/platform/chromium-mac-snowleopard/fast/transforms/shadows-expected.png.
        * platform/chromium-mac/fast/transforms/transformed-caret-expected.checksum: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/transforms/transformed-caret-expected.checksum.
        * platform/chromium-mac/fast/transforms/transformed-caret-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/transforms/transformed-caret-expected.png.
        * platform/chromium-mac/svg/text/bidi-embedded-direction-expected.checksum: Copied from LayoutTests/platform/chromium-mac-snowleopard/svg/text/bidi-embedded-direction-expected.checksum.
        * platform/chromium-mac/svg/text/bidi-embedded-direction-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/svg/text/bidi-embedded-direction-expected.png.
        * platform/chromium-mac/svg/text/bidi-embedded-direction-expected.txt: Copied from LayoutTests/platform/chromium-mac-snowleopard/svg/text/bidi-embedded-direction-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoASSERT(cookieStorageAdapter) when calling stopObservingCookieChanges after WebProcess...
bweinstein@apple.com [Wed, 30 Mar 2011 18:12:21 +0000 (18:12 +0000)]
ASSERT(cookieStorageAdapter) when calling stopObservingCookieChanges after WebProcess has crashed
https://bugs.webkit.org/show_bug.cgi?id=57477
<rdar://problem/9178751>

Reviewed by Anders Carlsson.

If someone has called startObservingCookieChanges, and the WebProcess crashes and restarts, the UIProcess
will call stopObservingCookieChanges when cookieStorageAdapter is nil.

The assert is wrong when the web process crashes, and there is no harm in dispatching a message to nil,
so remove the assert.

* platform/network/mac/CookieStorageMac.mm:
(WebCore::stopObservingCookieChanges):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix Snow Leopard build.
weinig@apple.com [Wed, 30 Mar 2011 18:11:04 +0000 (18:11 +0000)]
Fix Snow Leopard build.

* UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::showContextMenu):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKit2 contextual menu looks different than the rest of the OS
weinig@apple.com [Wed, 30 Mar 2011 17:52:50 +0000 (17:52 +0000)]
WebKit2 contextual menu looks different than the rest of the OS
<rdar://problem/9172935>
https://bugs.webkit.org/show_bug.cgi?id=57475

Reviewed by Anders Carlsson.

* UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::showContextMenu):
Use correct SPI for showing a context menu. The dummy view is also
not necessary, so remove it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix Leopard build.
weinig@apple.com [Wed, 30 Mar 2011 17:50:37 +0000 (17:50 +0000)]
Fix Leopard build.

* platform/DefaultLocalizationStrategy.cpp:
(WebCore::DefaultLocalizationStrategy::contextMenuItemTagLookUpInDictionary):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 MORITA Hajime <morrita@google.com>
morrita@google.com [Wed, 30 Mar 2011 17:50:22 +0000 (17:50 +0000)]
2011-03-30  MORITA Hajime  <morrita@google.com>

        Reviewed by Dimitri Glazkov.

        [Chromium] Expose the shadow DOM to DumpRenderTree JS tests.
        https://bugs.webkit.org/show_bug.cgi?id=56573

        Added:
        - WebBindins::makeNode() to convert WebNode to a JS object, and
        - WebElement::shadowRoot().

        * public/WebBindings.h:
        * public/WebElement.h:
        * src/WebBindings.cpp:
        (WebKit::makeNodeImpl):
        (WebKit::WebBindings::makeNode):
        * src/WebElement.cpp:
        (WebKit::WebElement::shadowRoot):
2011-03-30  MORITA Hajime  <morrita@google.com>

        Reviewed by Dimitri Glazkov.

        [Chromium] Expose the shadow DOM to DumpRenderTree JS tests.
        https://bugs.webkit.org/show_bug.cgi?id=56573

        Added LayoutTestController.shadowRoot() to Chromium DRT.

        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        (LayoutTestController::shadowRoot):
        * DumpRenderTree/chromium/LayoutTestController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 30 Mar 2011 17:43:30 +0000 (17:43 +0000)]
2011-03-30  Adam Barth  <abarth@webkit.org>

        Note that this test is flaky.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 30 Mar 2011 17:38:59 +0000 (17:38 +0000)]
2011-03-30  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Crash when NPN_Evaluate removes the plug-in frame
        https://bugs.webkit.org/show_bug.cgi?id=57474
        <rdar://problem/9191396>

        Get a reference to the frame since it can be nulled out if running the JavaScript code
        causes the plug-in's containing frame to be removed from the frame tree.

        * WebProcess/Plugins/PluginView.cpp:
        (WebKit::PluginView::evaluate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove empty directories in platform/mac-snowleopard, as requested by
abarth@webkit.org [Wed, 30 Mar 2011 17:35:14 +0000 (17:35 +0000)]
Remove empty directories in platform/mac-snowleopard, as requested by
Mark Rowe.

* platform/mac-snowleopard/css2.1: Removed.
* platform/mac-snowleopard/editing: Removed.
* platform/mac-snowleopard/editing/deleting: Removed.
* platform/mac-snowleopard/editing/inserting: Removed.
* platform/mac-snowleopard/editing/pasteboard: Removed.
* platform/mac-snowleopard/fast/backgrounds: Removed.
* platform/mac-snowleopard/fast/backgrounds/repeat: Removed.
* platform/mac-snowleopard/fast/block: Removed.
* platform/mac-snowleopard/fast/block/float: Removed.
* platform/mac-snowleopard/fast/borders: Removed.
* platform/mac-snowleopard/fast/canvas: Removed.
* platform/mac-snowleopard/fast/css: Removed.
* platform/mac-snowleopard/fast/dom: Removed.
* platform/mac-snowleopard/fast/dom/HTMLMeterElement: Removed.
* platform/mac-snowleopard/fast/images: Removed.
* platform/mac-snowleopard/fast/inline: Removed.
* platform/mac-snowleopard/fast/inline-block: Removed.
* platform/mac-snowleopard/fast/multicol: Removed.
* platform/mac-snowleopard/fast/replaced: Removed.
* platform/mac-snowleopard/fast/text/basic: Removed.
* platform/mac-snowleopard/media: Removed.
* platform/mac-snowleopard/plugins: Removed.
* platform/mac-snowleopard/scrollbars: Removed.
* platform/mac-snowleopard/svg/W3C-SVG-1.1: Removed.
* platform/mac-snowleopard/svg/custom: Removed.
* platform/mac-snowleopard/svg/dynamic-updates: Removed.
* platform/mac-snowleopard/svg/filters: Removed.
* platform/mac-snowleopard/svg/text: Removed.
* platform/mac-snowleopard/tables: Removed.
* platform/mac-snowleopard/tables/mozilla: Removed.
* platform/mac-snowleopard/tables/mozilla/core: Removed.
* platform/mac-snowleopard/tables/mozilla_expected_failures: Removed.
* platform/mac-snowleopard/tables/mozilla_expected_failures/bugs: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd default localization strategy that can be shared by WebKit1 and WebKit2
weinig@apple.com [Wed, 30 Mar 2011 17:28:54 +0000 (17:28 +0000)]
Add default localization strategy that can be shared by WebKit1 and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=57406

Reviewed by Anders Carlsson.

Source/WebCore:

Currently, only WebKit2 uses this default strategy, but WebKit1 should be able
to adopt it soon.

* platform/DefaultLocalizationStrategy.cpp: Copied from Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp.
(WebCore::DefaultLocalizationStrategy::DefaultLocalizationStrategy):
* platform/DefaultLocalizationStrategy.h: Copied from Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.h.
Copy the implementation of the Localization strategy from WebKit2 into a shared default strategy.

* platform/LocalizedStrings.cpp:
(WebCore::localizedString):
Add default implementation of localization bottleneck function.

* platform/LocalizedStrings.h:
Add localization macros here, instead of defining them in the above layer.

* platform/PlatformStrategies.cpp:
(WebCore::PlatformStrategies::createLocalizationStrategy):
* platform/PlatformStrategies.h:
Add default implementation of strategy creation function which creates the default strategy.

* platform/win/LocalizedStringsWin.cpp: Copied from Source/WebCore/platform/mac/LocalizedStringsMac.mm.
(WebCore::localizedString):
Add stub for windows, this will be update to pull from the bundle in a follow up patch.

* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
Add new files.

Source/WebKit2:

* Shared/WebLocalizableStrings.h: Removed.
Removed in favor of using WebCore/LocalizedStrings.h directly.

* PluginProcess/mac/PluginProcessMac.mm:
* UIProcess/API/mac/WKView.mm:
* UIProcess/mac/WebInspectorProxyMac.mm:
* WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:
* WebProcess/mac/WebProcessMac.mm:
Use WebCore/LocalizedStrings.h directly.

* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
* WebProcess/WebCoreSupport/WebPlatformStrategies.h:
Remove localization strategy override in favor of using new default implementation.

* GNUmakefile.am:
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
Remove WebLocalizableStrings.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Andras Becsi <abecsi@webkit.org>
abecsi@webkit.org [Wed, 30 Mar 2011 17:22:01 +0000 (17:22 +0000)]
2011-03-30  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Darin Adler.

        CSS: Slow parsing of rgb() with percent values
        https://bugs.webkit.org/show_bug.cgi?id=16708

        Implement fast-path parsing for percentage color values.

        Gain ~30% speedup on  http://canvex.lazyilluminati.com/misc/3d.html

        Relanding with rounding fix after it was rolled out in r82315.

        * fast/canvas/rgba-parsing-expected.txt: Add new test cases.
        * fast/canvas/script-tests/rgba-parsing.js: Ditto.
2011-03-30  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Darin Adler.

        CSS: Slow parsing of rgb() with percent values
        https://bugs.webkit.org/show_bug.cgi?id=16708

        Implement fast-path parsing for percentage color values.

        Gain ~30% speedup on  http://canvex.lazyilluminati.com/misc/3d.html

        Relanding with rounding fix after it was rolled out in r82315.

        * css/CSSParser.cpp:
        (WebCore::checkForValidDouble): Extend to return the number of characters forming a valid double.
        (WebCore::parseDouble): Function for parsing double values if they are valid.
        (WebCore::parseColorIntOrPercentage): Extend parseColorInt to deal with percentage values.
        (WebCore::parseAlphaValue): Use the new functions.
        (WebCore::CSSParser::parseColor): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Ofri Wolfus <ofri@dhcp-172-28-40-178.tlv.corp.google.com>
commit-queue@webkit.org [Wed, 30 Mar 2011 17:20:26 +0000 (17:20 +0000)]
2011-03-30  Ofri Wolfus  <ofri@dhcp-172-28-40-178.tlv.corp.google.com>

        Reviewed by Eric Seidel.

        Add support for parsing unicode-bidi: -webkit-plaintext.
        https://bugs.webkit.org/show_bug.cgi?id=57457

        * css3/unicode-bidi-plaintext-parse-expected.txt: Added.
        * css3/unicode-bidi-plaintext-parse.html: Added.
2011-03-30  Ofri Wolfus  <ofri@dhcp-172-28-40-178.tlv.corp.google.com>

        Reviewed by Eric Seidel.

        Add support for parsing unicode-bidi: -webkit-plaintext.
        https://bugs.webkit.org/show_bug.cgi?id=57457

        Test: css3/unicode-bidi-plaintext-parse.html

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        * css/CSSPrimitiveValueMappings.h:
        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
        (WebCore::CSSPrimitiveValue::operator EUnicodeBidi):
        * css/CSSValueKeywords.in:
        * rendering/style/RenderStyle.h:
        * rendering/style/RenderStyleConstants.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Wed, 30 Mar 2011 17:18:12 +0000 (17:18 +0000)]
2011-03-30  Andreas Kling  <kling@webkit.org>

        Reviewed by Benjamin Poulain.

        [Qt] Remove unused variables in GraphicsContext::fillRect()

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::fillRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Yael Aharon <yael.aharon@nokia.com>
yael.aharon@nokia.com [Wed, 30 Mar 2011 17:10:25 +0000 (17:10 +0000)]
2011-03-30  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Eric Seidel.

        REGRESSION(r82419): New pixel test failure fast/box-shadow/basic-shadows.html
        https://bugs.webkit.org/show_bug.cgi?id=57442

        When checking the position of the inline iterator in the logicallyLastRun, we should not consider BR as text.

        No new tests as existing test covers this case.

        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::reachedEndOfTextRenderer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 30 Mar 2011 17:01:09 +0000 (17:01 +0000)]
2011-03-30  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam Roben.

        Assertion failure in plug-in process when calling WKPluginSiteDataManagerGetSitesWithData
        https://bugs.webkit.org/show_bug.cgi?id=57468
        <rdar://problem/9199089>

        Call decrementLoadCount from removeWebProcessConnection instead of startShutdownTimerIfNecessary,
        otherwise we'll get a load count underflow when a connection is never created.

        * PluginProcess/PluginProcess.cpp:
        (WebKit::PluginProcess::removeWebProcessConnection):
        (WebKit::PluginProcess::createWebProcessConnection):
        (WebKit::PluginProcess::startShutdownTimerIfNecessary):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Wed, 30 Mar 2011 16:51:08 +0000 (16:51 +0000)]
2011-03-30  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Chris Fleizach.

        AX: GTK: ARIA role is not respected on <p> <label> <div> and <form>
        https://bugs.webkit.org/show_bug.cgi?id=47636

        Added new layout test to check that roles are correct in GTK.

        * platform/gtk/accessibility/aria-roles-unignored-expected.txt: Added.
        * platform/gtk/accessibility/aria-roles-unignored.html: Added.
2011-03-30  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Chris Fleizach.

        AX: GTK: ARIA role is not respected on <p> <label> <div> and <form>
        https://bugs.webkit.org/show_bug.cgi?id=47636

        Define new roles in WebCore and map them to ATK accordingly.

        Test: platform/gtk/accessibility/aria-roles-unignored.html

        * accessibility/AccessibilityObject.h: Added new roles to
        represent paragraphs, labels, forms and div sections.
        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
        Return ParagraphRole, LabelRole, FormRole and DivRole when needed
        for the GTK platform only.
        * accessibility/gtk/AccessibilityObjectAtk.cpp:
        (WebCore::AccessibilityObject::allowsTextRanges): Consider the new
        roles now that those kind of nodes won't return true to isGroup().
        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (atkRole): Map new WebCore roles to ATK Roles.
        (webkit_accessible_get_role): Remove code to define roles for
        paragraphs, labels, forms and divs based on node's tag name.

        Update mappings for the Mac platform.

        * accessibility/mac/AccessibilityObjectWrapper.mm:
        (createAccessibilityRoleMap): Add explicit mappings from the new
        roles introduced to NSAccessibilityGroupRole.
2011-03-30  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Chris Fleizach.

        AX: GTK: ARIA role is not respected on <p> <label> <div> and <form>
        https://bugs.webkit.org/show_bug.cgi?id=47636

        Duplicate new internal WebCore roles in the Chromium port.

        * public/WebAccessibilityRole.h: Update enumeration
        WebAccessibilityRole to reflect newly added roles in WebCore.
        * src/AssertMatchingEnums.cpp: Added new assertions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKit2: Make sure to try to terminate the Web Process when any work that might requi...
jberlin@webkit.org [Wed, 30 Mar 2011 16:48:48 +0000 (16:48 +0000)]
WebKit2: Make sure to try to terminate the Web Process when any work that might require the
Web Process to be relaunched is done
https://bugs.webkit.org/show_bug.cgi?id=57462

Reviewed by Anders Carlsson.

For the ManagerProxies in the UIProcess, only return true from shouldTerminate if there are
no more callbacks waiting to be invoked.

For the the Managers in the WebProcess, call WebProcess::shared().terminateIfPossible() when
any work called for by a ManagerProxy function that called relaunchProcessIfNecessary is
finished.

* UIProcess/WebContext.cpp:
(WebKit::WebContext::shouldTerminate):
Check with each of the ManagerProxies.

* UIProcess/WebApplicationCacheManagerProxy.cpp:
(WebKit::WebApplicationCacheManagerProxy::shouldTerminate):
* UIProcess/WebApplicationCacheManagerProxy.h:
* UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::shouldTerminate):
* UIProcess/WebCookieManagerProxy.h:
* UIProcess/WebDatabaseManagerProxy.cpp:
(WebKit::WebDatabaseManagerProxy::shouldTerminate):
* UIProcess/WebDatabaseManagerProxy.h:
* UIProcess/WebKeyValueStorageManagerProxy.cpp:
(WebKit::WebKeyValueStorageManagerProxy::shouldTerminate):
* UIProcess/WebKeyValueStorageManagerProxy.h:
* UIProcess/WebMediaCacheManagerProxy.cpp:
(WebKit::WebMediaCacheManagerProxy::shouldTerminate):
* UIProcess/WebMediaCacheManagerProxy.h:
* UIProcess/WebResourceCacheManagerProxy.cpp:
(WebKit::WebResourceCacheManagerProxy::shouldTerminate):
* UIProcess/WebResourceCacheManagerProxy.h:

* WebProcess/ApplicationCache/WebApplicationCacheManager.cpp:
(WebKit::WebApplicationCacheManager::getApplicationCacheOrigins):
(WebKit::WebApplicationCacheManager::deleteEntriesForOrigin):
(WebKit::WebApplicationCacheManager::deleteAllEntries):
* WebProcess/Cookies/WebCookieManager.cpp:
(WebKit::WebCookieManager::getHostnamesWithCookies):
(WebKit::WebCookieManager::deleteCookiesForHostname):
(WebKit::WebCookieManager::deleteAllCookies):
(WebKit::WebCookieManager::startObservingCookieChanges):
(WebKit::WebCookieManager::setHTTPCookieAcceptPolicy):
(WebKit::WebCookieManager::getHTTPCookieAcceptPolicy):
* WebProcess/KeyValueStorage/WebKeyValueStorageManager.cpp:
(WebKit::WebKeyValueStorageManager::getKeyValueStorageOrigins):
(WebKit::WebKeyValueStorageManager::deleteEntriesForOrigin):
(WebKit::WebKeyValueStorageManager::deleteAllEntries):
* WebProcess/MediaCache/WebMediaCacheManager.cpp:
(WebKit::WebMediaCacheManager::getHostnamesWithMediaCache):
(WebKit::WebMediaCacheManager::clearCacheForHostname):
(WebKit::WebMediaCacheManager::clearCacheForAllHostnames):
* WebProcess/ResourceCache/WebResourceCacheManager.cpp:
(WebKit::WebResourceCacheManager::getCacheOrigins):
(WebKit::WebResourceCacheManager::clearCacheForOrigin):
(WebKit::WebResourceCacheManager::clearCacheForAllOrigins):
* WebProcess/WebCoreSupport/WebDatabaseManager.cpp:
(WebKit::WebDatabaseManager::getDatabasesByOrigin):
(WebKit::WebDatabaseManager::getDatabaseOrigins):
(WebKit::WebDatabaseManager::deleteDatabaseWithNameForOrigin):
(WebKit::WebDatabaseManager::deleteDatabasesForOrigin):
(WebKit::WebDatabaseManager::deleteAllDatabases):
(WebKit::WebDatabaseManager::setQuotaForOrigin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Leopard Intel Release Tests] fast/text/justify-ideograph-leading-expansion.html...
jberlin@webkit.org [Wed, 30 Mar 2011 16:14:31 +0000 (16:14 +0000)]
[Leopard Intel Release Tests] fast/text/justify-ideograph-leading-expansion.html failing
since r82026.
https://bugs.webkit.org/show_bug.cgi?id=57461

The Leopard results match the other Mac results, but when it started inheriting from the
Snow Leopard specific results it started failing.

Copy the mac results to the mac-leopard results to get the bots green.

* platform/mac-leopard/fast/text/justify-ideograph-leading-expansion-expected.checksum: Added.
* platform/mac-leopard/fast/text/justify-ideograph-leading-expansion-expected.png: Added.
* platform/mac-leopard/fast/text/justify-ideograph-leading-expansion-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Wed, 30 Mar 2011 16:13:15 +0000 (16:13 +0000)]
2011-03-30  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Build fix for Efl and Qt Win.

        * inspector/PageDebuggerAgent.cpp: removed ENABLE(WORKERS) guard from code that has nothing to do with workers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Wed, 30 Mar 2011 16:07:47 +0000 (16:07 +0000)]
2011-03-30  Sergio Villar Senin  <svillar@igalia.com>

        Unreviewed, rebaseline GTK+ test expectations.

        * platform/gtk/css2.1/t090501-c414-flt-ln-02-d-expected.checksum:
        * platform/gtk/css2.1/t090501-c414-flt-ln-02-d-expected.png:
        * platform/gtk/css2.1/t090501-c414-flt-ln-02-d-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Wed, 30 Mar 2011 16:04:01 +0000 (16:04 +0000)]
2011-03-30  Levi Weintraub  <leviw@chromium.org>

        Unreviewed.

        Adding editing/selection/click-below-rtl-text.html to mac-wk2 since it requires eventSender.

        * platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Wed, 30 Mar 2011 16:02:35 +0000 (16:02 +0000)]
2011-03-30  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: audit run never completes, fails in DOMAgent.js
        https://bugs.webkit.org/show_bug.cgi?id=57349

        - assure document is present before calling DOMAgent.querySelectAll()

        * inspector/front-end/AuditRules.js:
        (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):

2011-03-30  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: audit run never completes, fails in DOMAgent.js
        https://bugs.webkit.org/show_bug.cgi?id=57349

        * inspector/audits/audits-panel-functional.html: do not select Elements panel before running Audits, this hides bug 57349

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Leopard Intel Release Tests] editing/spelling/grammar.html failing since introduction in
jberlin@webkit.org [Wed, 30 Mar 2011 15:53:56 +0000 (15:53 +0000)]
[Leopard Intel Release Tests] editing/spelling/grammar.html failing since introduction in
r82159.
https://bugs.webkit.org/show_bug.cgi?id=57460

Unreviewed, commit the failing expected results in order to get the bots green.

* platform/mac-leopard/editing/spelling/grammar-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Leopard Intel Release Tests] svg/text/bidi-embedded-direction.svg failing since
jberlin@webkit.org [Wed, 30 Mar 2011 15:42:36 +0000 (15:42 +0000)]
[Leopard Intel Release Tests] svg/text/bidi-embedded-direction.svg failing since
introduction in r82411.
https://bugs.webkit.org/show_bug.cgi?id=57458

Unreviewed, add the platform-specific failing results to get the bots green.

NOTE: The platform-specific failing pixel test results still need to be added.

* platform/mac-leopard/svg/text/bidi-embedded-direction-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Wed, 30 Mar 2011 15:36:17 +0000 (15:36 +0000)]
2011-03-30  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Build fix.

        * UseJSC.cmake: fix typo PageDebugServer -> PageScriptDebugServer

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Wed, 30 Mar 2011 15:26:22 +0000 (15:26 +0000)]
2011-03-30  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: split debugger agent into Page and Worker-specific ones
        https://bugs.webkit.org/show_bug.cgi?id=57345

        ScriptDebugServer and InspectorDebuggerAgent contain only functionality common
        for Worker and Page debugger. All specifics is moved into Page/WorkerScriptDebugServer
        and Page/WorkerDebuggerAgent.

        * CMakeLists.txt:
        * GNUmakefile.am:
        * UseJSC.cmake:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSBindingsAllInOne.cpp:
        * bindings/js/JSInjectedScriptHostCustom.cpp:
        (WebCore::JSInjectedScriptHost::currentCallFrame):
        * bindings/js/PageScriptDebugServer.cpp: Added.
        (WebCore::toPage):
        (WebCore::PageScriptDebugServer::shared):
        (WebCore::PageScriptDebugServer::PageScriptDebugServer):
        (WebCore::PageScriptDebugServer::~PageScriptDebugServer):
        (WebCore::PageScriptDebugServer::addListener):
        (WebCore::PageScriptDebugServer::removeListener):
        (WebCore::PageScriptDebugServer::recompileAllJSFunctions):
        (WebCore::PageScriptDebugServer::getListenersForGlobalObject):
        (WebCore::PageScriptDebugServer::didPause):
        (WebCore::PageScriptDebugServer::didContinue):
        (WebCore::PageScriptDebugServer::didRemoveLastListener):
        (WebCore::PageScriptDebugServer::setJavaScriptPaused):
        * bindings/js/PageScriptDebugServer.h: Added.
        * bindings/js/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::ScriptDebugServer):
        (WebCore::ScriptDebugServer::sourceParsed):
        (WebCore::ScriptDebugServer::dispatchFunctionToListeners):
        (WebCore::ScriptDebugServer::createCallFrameAndPauseIfNeeded):
        (WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):
        (WebCore::ScriptDebugServer::pauseIfNeeded):
        * bindings/js/ScriptDebugServer.h:
        * bindings/js/WorkerScriptDebugServer.cpp: Added.
        (WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):
        (WebCore::WorkerScriptDebugServer::addListener):
        (WebCore::WorkerScriptDebugServer::removeListener):
        * bindings/js/WorkerScriptDebugServer.h: Added.
        (WebCore::WorkerScriptDebugServer::~WorkerScriptDebugServer):
        (WebCore::WorkerScriptDebugServer::recompileAllJSFunctions):
        (WebCore::WorkerScriptDebugServer::getListenersForGlobalObject):
        (WebCore::WorkerScriptDebugServer::didPause):
        (WebCore::WorkerScriptDebugServer::didContinue):
        * bindings/v8/PageScriptDebugServer.cpp: Added.
        (WebCore::retrieveFrame):
        (WebCore::PageScriptDebugServer::shared):
        (WebCore::PageScriptDebugServer::PageScriptDebugServer):
        (WebCore::PageScriptDebugServer::addListener):
        (WebCore::PageScriptDebugServer::removeListener):
        (WebCore::PageScriptDebugServer::setClientMessageLoop):
        (WebCore::PageScriptDebugServer::getDebugListenerForContext):
        (WebCore::PageScriptDebugServer::runMessageLoopOnPause):
        (WebCore::PageScriptDebugServer::quitMessageLoopOnPause):
        * bindings/v8/PageScriptDebugServer.h: Added.
        (WebCore::PageScriptDebugServer::setEnabled):
        (WebCore::PageScriptDebugServer::ClientMessageLoop::~ClientMessageLoop):
        (WebCore::PageScriptDebugServer::~PageScriptDebugServer):
        * bindings/v8/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::ScriptDebugServer):
        (WebCore::ScriptDebugServer::setPauseOnNextStatement):
        (WebCore::ScriptDebugServer::breakProgram):
        (WebCore::ScriptDebugServer::continueProgram):
        (WebCore::ScriptDebugServer::stepIntoStatement):
        (WebCore::ScriptDebugServer::stepOverStatement):
        (WebCore::ScriptDebugServer::stepOutOfFunction):
        (WebCore::ScriptDebugServer::editScriptSource):
        (WebCore::toScriptDebugServer):
        (WebCore::ScriptDebugServer::breakProgramCallback):
        (WebCore::ScriptDebugServer::v8DebugEventCallback):
        (WebCore::ScriptDebugServer::handleV8DebugEvent):
        (WebCore::ScriptDebugServer::isPaused):
        * bindings/v8/ScriptDebugServer.h:
        * bindings/v8/WorkerScriptDebugServer.cpp: Added.
        (WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):
        (WebCore::WorkerScriptDebugServer::addListener):
        (WebCore::WorkerScriptDebugServer::removeListener):
        * bindings/v8/WorkerScriptDebugServer.h: Added.
        (WebCore::WorkerScriptDebugServer::~WorkerScriptDebugServer):
        (WebCore::WorkerScriptDebugServer::getDebugListenerForContext):
        (WebCore::WorkerScriptDebugServer::runMessageLoopOnPause):
        (WebCore::WorkerScriptDebugServer::quitMessageLoopOnPause):
        * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
        (WebCore::V8InjectedScriptHost::currentCallFrameCallback):
        * inspector/InjectedScriptHost.h:
        (WebCore::InjectedScriptHost::init):
        (WebCore::InjectedScriptHost::debuggerAgent):
        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::InspectorAgent):
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
        (WebCore::InspectorDebuggerAgent::enable):
        (WebCore::InspectorDebuggerAgent::disable):
        (WebCore::InspectorDebuggerAgent::setBreakpointsActive):
        (WebCore::InspectorDebuggerAgent::removeBreakpoint):
        (WebCore::InspectorDebuggerAgent::continueToLocation):
        (WebCore::InspectorDebuggerAgent::resolveBreakpoint):
        (WebCore::InspectorDebuggerAgent::editScriptSource):
        (WebCore::InspectorDebuggerAgent::schedulePauseOnNextStatement):
        (WebCore::InspectorDebuggerAgent::cancelPauseOnNextStatement):
        (WebCore::InspectorDebuggerAgent::resume):
        (WebCore::InspectorDebuggerAgent::stepOver):
        (WebCore::InspectorDebuggerAgent::stepInto):
        (WebCore::InspectorDebuggerAgent::stepOut):
        (WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState):
        (WebCore::InspectorDebuggerAgent::didPause):
        (WebCore::InspectorDebuggerAgent::breakProgram):
        * inspector/InspectorDebuggerAgent.h:
        * inspector/InspectorProfilerAgent.cpp:
        (WebCore::InspectorProfilerAgent::disable):
        (WebCore::InspectorProfilerAgent::enable):
        (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
        * inspector/PageDebuggerAgent.cpp: Added.
        (WebCore::PageDebuggerAgent::create):
        (WebCore::PageDebuggerAgent::PageDebuggerAgent):
        (WebCore::PageDebuggerAgent::~PageDebuggerAgent):
        (WebCore::PageDebuggerAgent::startListeningScriptDebugServer):
        (WebCore::PageDebuggerAgent::stopListeningScriptDebugServer):
        (WebCore::PageDebuggerAgent::scriptDebugServer):
        * inspector/PageDebuggerAgent.h: Added.
        * inspector/WorkerDebuggerAgent.cpp: Added.
        (WebCore::WorkerDebuggerAgent::create):
        (WebCore::WorkerDebuggerAgent::WorkerDebuggerAgent):
        (WebCore::WorkerDebuggerAgent::~WorkerDebuggerAgent):
        (WebCore::WorkerDebuggerAgent::startListeningScriptDebugServer):
        (WebCore::WorkerDebuggerAgent::stopListeningScriptDebugServer):
        (WebCore::WorkerDebuggerAgent::scriptDebugServer):
        * inspector/WorkerDebuggerAgent.h: Added.
2011-03-30  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: split debugger agent into Page and Worker-specific ones
        https://bugs.webkit.org/show_bug.cgi?id=57345

        ScriptDebugServer and InspectorDebuggerAgent contain only functionality common
        for Worker and Page debugger. All specifics is moved into Page/WorkerScriptDebugServer
        and Page/WorkerDebuggerAgent.

        * src/DebuggerAgentManager.cpp:
        (WebKit::DebuggerAgentManager::setExposeV8DebuggerProtocol):
        * src/WebDevToolsAgentImpl.cpp:
        (WebKit::WebDevToolsAgent::interruptAndDispatch):
        (WebKit::WebDevToolsAgent::processPendingMessages):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Update expected files.
ossy@webkit.org [Wed, 30 Mar 2011 15:24:05 +0000 (15:24 +0000)]
[Qt] Update expected files.

* platform/qt/css1/box_properties/padding_right_inline-expected.checksum: Added.
* platform/qt/css1/box_properties/padding_right_inline-expected.png: Added.
* platform/qt/css1/box_properties/padding_right_inline-expected.txt:
* platform/qt/css2.1/t090501-c414-flt-ln-00-d-expected.checksum:
* platform/qt/css2.1/t090501-c414-flt-ln-00-d-expected.png:
* platform/qt/css2.1/t090501-c414-flt-ln-00-d-expected.txt:
* platform/qt/css2.1/t090501-c414-flt-ln-01-d-g-expected.checksum:
* platform/qt/css2.1/t090501-c414-flt-ln-01-d-g-expected.png:
* platform/qt/css2.1/t090501-c414-flt-ln-01-d-g-expected.txt:
* platform/qt/css2.1/t090501-c414-flt-ln-02-d-expected.checksum:
* platform/qt/css2.1/t090501-c414-flt-ln-02-d-expected.png:
* platform/qt/css2.1/t090501-c414-flt-ln-02-d-expected.txt:
* platform/qt/css2.1/t090501-c414-flt-ln-03-d-expected.checksum:
* platform/qt/css2.1/t090501-c414-flt-ln-03-d-expected.png:
* platform/qt/css2.1/t090501-c414-flt-ln-03-d-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Wed, 30 Mar 2011 15:21:44 +0000 (15:21 +0000)]
2011-03-30  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Ryosuke Niwa.

        Clicking below last line of right-to-left editable text that puts caret in the wrong place
        https://bugs.webkit.org/show_bug.cgi?id=38087

        Moving getLogical[Start/End]BoxWithNode to RootInlineBox and using it in positionForPointWithInlineChildren
        instead of lastLeafChild, which wasn't correct in the RTL case.

        Test: editing/selection/click-below-rtl-text.html

        * editing/visible_units.cpp:
        (WebCore::logicalStartPositionForLine): Moved to RootInlineBox.
        (WebCore::logicalEndPositionForLine): Ditto.
        * editing/visible_units.h:
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::positionForPointWithInlineChildren): Useing getLogicalEndBoxWithNode instead
        of lastLeafChild.
        * rendering/RootInlineBox.cpp:
        (WebCore::RootInlineBox::getLogicalStartBoxWithNode): Moved and refactored.
        (WebCore::RootInlineBox::getLogicalEndBoxWithNode): Ditto.
        * rendering/RootInlineBox.h:
2011-03-30  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Ryosuke Niwa.

        Clicking below last line of right-to-left editable text that puts caret in the wrong place
        https://bugs.webkit.org/show_bug.cgi?id=38087

        Doing the right thing when clicking below the last line box in RTL editable content.

        * editing/selection/click-below-rtl-text-expected.txt: Added.
        * editing/selection/click-below-rtl-text.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-30 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Wed, 30 Mar 2011 15:09:54 +0000 (15:09 +0000)]
2011-03-30  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed, update Chromium test expectation for fast/text/emphasis-combined-text.html.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMac build fix after r82442
aroben@apple.com [Wed, 30 Mar 2011 15:06:46 +0000 (15:06 +0000)]
Mac build fix after r82442

* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::geometryDidChange): Added a missing argument.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd a new test to the mac-wk2 Skipped file
aroben@apple.com [Wed, 30 Mar 2011 15:04:26 +0000 (15:04 +0000)]
Add a new test to the mac-wk2 Skipped file

<http://webkit.org/b/57455> tracks the failure.

* platform/mac-wk2/Skipped: Added fast/forms/validation-message-appearance.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd mac-wk2 expected failure results for plugins/embed-prefers-plugins-for-images...
aroben@apple.com [Wed, 30 Mar 2011 15:03:55 +0000 (15:03 +0000)]
Add mac-wk2 expected failure results for plugins/embed-prefers-plugins-for-images.html

The failure is tracked by <http://webkit.org/b/57456>.

* platform/mac-wk2/plugins/embed-prefers-plugins-for-images-expected.txt: Added.
* platform/win-wk2/plugins/embed-prefers-plugins-for-images-expected.txt: Added. (Since
win-wk2 falls back to mac-wk2, but the test passes on Windows, I had to copy passing results
here to override the mac-wk2 results.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd a way to specify that a ShareableBitmap has no alpha channel
aroben@apple.com [Wed, 30 Mar 2011 14:42:13 +0000 (14:42 +0000)]
Add a way to specify that a ShareableBitmap has no alpha channel

Before this patch, all ShareableBitmaps had an alpha channel. With this patch, all
ShareableBitmaps *still* have an alpha channel. But now there's a way to specify you don't
want one (which will be used in the future)!

Fixes <http://webkit.org/b/57388> Need a way to specify that a ShareableBitmap has no alpha
channel

Reviewed by Anders Carlsson.

* Shared/ShareableBitmap.cpp:
(WebKit::ShareableBitmap::Handle::Handle): Moved here from the header file, and added
initialization of m_flags.

(WebKit::ShareableBitmap::Handle::encode):
(WebKit::ShareableBitmap::Handle::decode):
Encode/decode m_flags.

(WebKit::ShareableBitmap::create):
(WebKit::ShareableBitmap::createShareable):
Pass along the new Flags argument.

(WebKit::ShareableBitmap::createHandle): Store our Flags on the Handle.
(WebKit::ShareableBitmap::ShareableBitmap): Store the Flags in m_flags.

* Shared/ShareableBitmap.h: Added Flag, Flags, and m_flags, and added a Flags argument to
some create functions.

* Shared/WebCoreArgumentCoders.cpp:
(CoreIPC::encodeImage):
* Shared/WebImage.cpp:
(WebKit::WebImage::create):
Specify that we want a bitmap that supports alpha to maintain current behavior.

* Shared/cg/ShareableBitmapCG.cpp:
(WebKit::bitmapInfo): New helper function. Includes an alpha channel only if specified in
the flags.

(WebKit::ShareableBitmap::createGraphicsContext):
(WebKit::ShareableBitmap::makeCGImage):
Use the new helper function.

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::snapshot):
* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::geometryDidChange):
* WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::convertImageToBitmap):
* WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp:
(WebKit::WebPopupMenu::setUpPlatformData):
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::display):
* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::updateFindIndicator):
Specify that we want a bitmap that supports alpha to maintain current behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd ShareableBitmap::Handle
aroben@apple.com [Wed, 30 Mar 2011 14:40:23 +0000 (14:40 +0000)]
Add ShareableBitmap::Handle

This object is used for encoding/decoding a ShareableBitmap via CoreIPC. It currently just
encapsulates a SharedMemory::Handle (which is what we were using previously) and the image's
size (which means callers no longer need to deal with the size explicitly), but in the
future could be used to store more information about the bitmap.

This should cause no behavior changes.

Fixes <http://webkit.org/b/57397> ShareableBitmap needs its own Handle type

Reviewed by Anders Carlsson.

* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::geometryDidChange): No longer need to pass a size to create,
since the Handle records the size.
(WebKit::PluginControllerProxy::snapshot): No longer need the bufferSize argument, since the
Handle records the size.

* PluginProcess/PluginControllerProxy.h:
* PluginProcess/PluginControllerProxy.messages.in:
Updated Handle types and removed unnecessary size argument to Snapshot.

* Shared/PlatformPopupMenuData.cpp:
(WebKit::PlatformPopupMenuData::encode):
(WebKit::PlatformPopupMenuData::decode):
* Shared/PlatformPopupMenuData.h:
Changed to use ShareableBitmap::Handle and removed m_backingStoreSize, which is now stored
in the Handles.

* Shared/ShareableBitmap.cpp:
(WebKit::ShareableBitmap::Handle::encode):
(WebKit::ShareableBitmap::Handle::decode):
Simple encode/decode functions.

(WebKit::ShareableBitmap::create): Get the size from the Handle instead of as a separate
argument.
(WebKit::ShareableBitmap::createHandle): Store our size in the Handle.

* Shared/ShareableBitmap.h: Added ShareableBitmap::Handle and made some functions use it.

* Shared/UpdateInfo.h: Changed to use ShareableBitmap::Handle.

* Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
* Shared/WebCoreArgumentCoders.cpp:
(CoreIPC::encodeImage):
(CoreIPC::decodeImage):
Use the size stored in the Handle instead of encoding/decoding one separately.

* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::setDragImage):
Removed the unnecessary imageSize argument. We can get it from the image itself.

* UIProcess/BackingStore.cpp:
(WebKit::BackingStore::incorporateUpdate):
* UIProcess/FindIndicator.cpp:
(WebKit::FindIndicator::create):
No longer need to pass a size when creating a ShareableBitmap from a Handle.

* UIProcess/FindIndicator.h: Changed to use ShareableBitmap::Handle.

* UIProcess/PageClient.h: Removed unnecessary imageSize argument from setDragImage.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setFindIndicator):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::setDragImage):
* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::snapshot):
(WebKit::PluginProxy::geometryDidChange):
* WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::WebDragClient::startDrag):
Changed to use ShareableBitmap::Handle and removed now-unnecessary size arguments (since we
can get the size from the Handle).

* WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp:
(WebKit::WebPopupMenu::setUpPlatformData): Don't need to store the backing store size in the
data anymore; the Handles will make sure it reaches the other process.

* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::updateFindIndicator):
(WebKit::FindController::hideFindIndicator):
Changed to use ShareableBitmap::Handle.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82441 268f45cc-cd09-0410-ab3c-d52691b4dbfc