WebKit-https.git
8 years agoRename WebKitTools to Tools
mitz@apple.com [Sat, 18 Dec 2010 00:02:12 +0000 (00:02 +0000)]
Rename WebKitTools to Tools
https://bugs.webkit.org/show_bug.cgi?id=49861

Reviewed by Simon Fraser.

.:

* DerivedSources.pro:
* GNUmakefile.am:
* MakeFile:
* MakeFile.shared:
* Tools: Renamed from WebKitTools.
* WebKit.pro:
* cmake/WebKitPackaging.cmake:
* wscript:

BugsSite:

* PrettyPatch/PrettyPatch.rb:
* committers-autocomplete.js:

Tools:

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
* CodeCoverage/README:
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::initializeFonts):
* EWSTools/start-commit-queue.sh:
* EWSTools/start-queue.sh:
* GNUmakefile.am:
* MIDLWrapper/MIDLWrapper.cpp:
(wmain):
* MiniBrowser/qt/MiniBrowser.pro:
* Scripts/build-api-tests:
* Scripts/build-dumprendertree:
* Scripts/build-webkit:
* Scripts/build-webkittestrunner:
* Scripts/generate-coverage-data:
* Scripts/old-run-webkit-tests:
* Scripts/run-api-tests:
* Scripts/run-iexploder-tests:
* Scripts/run-javascriptcore-tests:
* Scripts/run-mangleme-tests:
* Scripts/run-sunspider:
* Scripts/run-webkit-websocketserver:
* Scripts/sunspider-compare-results:
* Scripts/test-webkitperl:
* Scripts/test-webkitpy:
* Scripts/update-iexploder-cssproperties:
* Scripts/update-webkit:
* Scripts/update-webkit-localizable-strings:
* Scripts/webkitdirs.pm:
* Scripts/webkitpy/common/checkout/scm.py:
* Scripts/webkitpy/common/checkout/scm_unittest.py:
* Scripts/webkitpy/common/config/committervalidator.py:
* Scripts/webkitpy/common/config/committervalidator_unittest.py:
* Scripts/webkitpy/common/config/ports.py:
* Scripts/webkitpy/common/config/ports_unittest.py:
* Scripts/webkitpy/common/system/logutils_unittest.py:
* Scripts/webkitpy/common/system/ospath_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/layout_tests/port/config.py:
* Scripts/webkitpy/layout_tests/port/config_unittest.py:
* Scripts/webkitpy/layout_tests/port/http_server.py:
* Scripts/webkitpy/layout_tests/port/test.py:
* Scripts/webkitpy/style/checker.py:
* Scripts/webkitpy/style/checker_unittest.py:
* Scripts/webkitpy/tool/bot/feeders_unittest.py:
* Scripts/webkitpy/tool/commands/queues_unittest.py:
* Scripts/webkitpy/tool/steps/steps_unittest.py:
* WebKitTestRunner/DerivedSources.pro:
* WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
(WTR::activateFonts):
* WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
* wx/build/build_utils.py:

WebKitSite:

* asking_questions.html:
* building/tools.html:
* coding/scripts.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoClean up ChunkedUpdateDrawingAreaProxy
andersca@apple.com [Fri, 17 Dec 2010 23:35:30 +0000 (23:35 +0000)]
Clean up ChunkedUpdateDrawingAreaProxy
https://bugs.webkit.org/show_bug.cgi?id=51277

Reviewed by Simon Fraser.

Get rid of m_lastSetViewSize since it was always equal to m_size.

* UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:
(WebKit::ChunkedUpdateDrawingAreaProxy::sizeDidChange):
Call sendSetSize().

(WebKit::ChunkedUpdateDrawingAreaProxy::didSetSize):
Call sendSetSize if the size differs.

(WebKit::ChunkedUpdateDrawingAreaProxy::sendSetSize):
Move code from sizeDidChange over here.

* UIProcess/ChunkedUpdateDrawingAreaProxy.h:
* UIProcess/DrawingAreaProxy.cpp:
(WebKit::DrawingAreaProxy::setSize):
Add back the early return if the sizes are equal.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-17 Ariya Hidayat <ariya@sencha.com>
ariya@webkit.org [Fri, 17 Dec 2010 23:28:29 +0000 (23:28 +0000)]
2010-12-17  Ariya Hidayat  <ariya@sencha.com>

        Reviewed by Oliver Hunt.

        [JSC] parseAssignmentExpression should use TreeBuilder::CreatesAST
        https://bugs.webkit.org/show_bug.cgi?id=51268

        * parser/JSParser.cpp:
        (JSC::JSParser::parseAssignmentExpression):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed build fix.
bfulgham@webkit.org [Fri, 17 Dec 2010 23:03:24 +0000 (23:03 +0000)]
Unreviewed build fix.

* WebProcess/WebPage/win/WebPageWin.cpp:
(WebKit::WebPage::canHandleRequest): Provide alternative for
non-CFNetwork implementation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-17 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 17 Dec 2010 22:48:40 +0000 (22:48 +0000)]
2010-12-17  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Removed RChunk from PageAllocation/PageReservation, since it's now unused.
        https://bugs.webkit.org/show_bug.cgi?id=51276

        * wtf/PageAllocation.h:
        (WTF::PageAllocation::PageAllocation):
        * wtf/PageReservation.h:
        (WTF::PageReservation::PageReservation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago Reviewed by Anders Carlsson.
adachan@apple.com [Fri, 17 Dec 2010 22:43:49 +0000 (22:43 +0000)]
    Reviewed by Anders Carlsson.

        Implement WKView::setInitialFocus().
        https://bugs.webkit.org/show_bug.cgi?id=51274

        * UIProcess/API/C/win/WKView.cpp:
        (WKViewSetInitialFocus):
        * UIProcess/API/C/win/WKView.h:
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::setInitialFocus): Send message to the Web Process to set
        initial focus.
        * UIProcess/WebPageProxy.h:
        * UIProcess/win/WebView.cpp:
        (WebKit::WebView::setInitialFocus):
        * UIProcess/win/WebView.h:
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::setInitialFocus): Set the focused node to null initially.  Then
        ask FocusController to set the initial focus based on the focus direction.
        * WebProcess/WebPage/WebPage.h:
        * WebProcess/WebPage/WebPage.messages.in: Add a new message for SetInitialFocus.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove a check that probably uncovered a resizing bug.
andersca@apple.com [Fri, 17 Dec 2010 22:24:05 +0000 (22:24 +0000)]
Remove a check that probably uncovered a resizing bug.

Reviewed by Sam Weinig.

* UIProcess/DrawingAreaProxy.cpp:
(WebKit::DrawingAreaProxy::setSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-17 Brian Weinstein <bweinstein@apple.com>
andersca@apple.com [Fri, 17 Dec 2010 22:11:32 +0000 (22:11 +0000)]
2010-12-17  Brian Weinstein  <bweinstein@apple.com>

        Qt build fix.

        * UIProcess/qt/WebPopupMenuProxyQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-17 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 17 Dec 2010 21:54:11 +0000 (21:54 +0000)]
2010-12-17  Simon Fraser  <simon.fraser@apple.com>

        Change this test to use the pause API by testing the individual properties,
        rather than the compound property.

        * transitions/mask-transitions-expected.txt: Removed.
        * transitions/mask-transitions.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-17 Carol Szabo <carol.szabo@nokia.com>
carol.szabo@nokia.com [Fri, 17 Dec 2010 21:39:19 +0000 (21:39 +0000)]
2010-12-17  Carol Szabo  <carol.szabo@nokia.com>

        Reviewed by Darin Adler.

        A corrupted counter tree is created when renderers are added to the
        tree bypassing RenderObject::addChild
        https://bugs.webkit.org/show_bug.cgi?id=51270

        This patch replaces the hack introduced for fixing bug 43812
        with code that addresses the underlying problem for that bug.
        No new layout tests provided as there is no identified scenario when
        visible behavior would be different, the internal datastructures
        are maintained properly through this fix so the previous hack
        introduced for bug 43812 is now removed. The fact that the
        layout test introduced for 43812 continues to pass is proof that the
        code works.

        * rendering/RenderCounter.cpp:
        (WebCore::findPlaceForCounter):
          Removed hack.
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::addChild):
          Moved call to counter nodes updater to lower level
          functions to avoid bypass.
        * rendering/RenderObjectChildList.cpp:
        (WebCore::RenderObjectChildList::appendChildNode):
        (WebCore::RenderObjectChildList::insertChildNode):
          Changed to update the values of the counters that
          may be inserted in the tree.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-17 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Fri, 17 Dec 2010 21:38:49 +0000 (21:38 +0000)]
2010-12-17  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Incorrect encoding of some constants in ARMv7 JIT
        https://bugs.webkit.org/show_bug.cgi?id=51273
        <rdar://problem/8650210>

        When using immediate encoding 3 we need to write the byte
        that holds a duplicated value.

        * assembler/ARMv7Assembler.h:
        (JSC::ARMThumbImmediate::makeEncodedImm):
2010-12-17  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Incorrect encoding of some constants in ARMv7 JIT
        https://bugs.webkit.org/show_bug.cgi?id=51273

        Add a few tests for different byte patterns in immediates.

        * fast/js/constant-encoding-expected.txt: Added.
        * fast/js/constant-encoding.html: Added.
        * fast/js/script-tests/constant-encoding.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd Windows-specific expected results for the the tests added in
jberlin@webkit.org [Fri, 17 Dec 2010 21:37:16 +0000 (21:37 +0000)]
Add Windows-specific expected results for the the tests added in
http://trac.webkit.org/changeset/74281.

Rubber-stamped by Dan Bernstein.

* platform/win/fast/text/emphasis-expected.checksum: Added.
* platform/win/fast/text/emphasis-expected.png: Added.
* platform/win/fast/text/emphasis-expected.txt: Added.
* platform/win/fast/text/emphasis-vertical-expected.checksum: Added.
* platform/win/fast/text/emphasis-vertical-expected.png: Added.
* platform/win/fast/text/emphasis-vertical-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoQt build fix.
bweinstein@apple.com [Fri, 17 Dec 2010 21:29:30 +0000 (21:29 +0000)]
Qt build fix.

* UIProcess/qt/WebPopupMenuProxyQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-17 Shimeng (Simon) Wang <swang@google.com>
commit-queue@webkit.org [Fri, 17 Dec 2010 21:24:43 +0000 (21:24 +0000)]
2010-12-17  Shimeng (Simon) Wang  <swang@google.com>

        Reviewed by Steve Block.

        Fix V8 JNI binding.
        https://bugs.webkit.org/show_bug.cgi?id=51156

        There're LayoutTests in:
        http://trac.webkit.org/browser/trunk/LayoutTests/java/lc3/JSNumber
        to exercise these code paths.
        Though Chromium don't run them.
        Tested on Android fast/events/touch tests.

        * bridge/jni/v8/JNIUtilityPrivate.cpp:
        (JSC::Bindings::convertNPVariantToJValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-17 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 17 Dec 2010 21:22:47 +0000 (21:22 +0000)]
2010-12-17  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Chris Marrin.

        Interrupted accelerated animation can break later transitions
        <rdar://problem/8767714>
        https://bugs.webkit.org/show_bug.cgi?id=51264

        If we're still waiting for the 'animationDidStart' callback when renderers
        get destroyed, then the m_waitingForStartTimeResponse flag could be left
        set to 'true', which causes later transitions to never start.

        Fix by clearing the m_waitingForStartTimeResponse flag when the m_startTimeResponseWaiters
        becomes empty.

        Test: transitions/interrupted-accelerated-transition.html

        * page/animation/AnimationController.cpp:
        (WebCore::AnimationControllerPrivate::removeFromStartTimeResponseWaitList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-17 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 17 Dec 2010 21:22:34 +0000 (21:22 +0000)]
2010-12-17  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Chris Marrin.

        Interrupted accelerated animation can break later transitions
        https://bugs.webkit.org/show_bug.cgi?id=51264

        Step 1: code cleanup.
        Rename "responseWait" variables to "startTimeResponseWait", to make it clear
        the kind of response that is being waited for.

        Make a couple of methods private.

        No behavioral changes, so no tests.

        * page/animation/AnimationController.cpp:
        (WebCore::AnimationControllerPrivate::AnimationControllerPrivate):
        (WebCore::AnimationControllerPrivate::endAnimationUpdate):
        (WebCore::AnimationControllerPrivate::receivedStartTimeResponse):
        (WebCore::AnimationControllerPrivate::addToStartTimeResponseWaitList):
        (WebCore::AnimationControllerPrivate::removeFromStartTimeResponseWaitList):
        (WebCore::AnimationControllerPrivate::startTimeResponse):
        * page/animation/AnimationControllerPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoText area does not update when you arrow through a <select> in WebKit2
bweinstein@apple.com [Fri, 17 Dec 2010 21:08:36 +0000 (21:08 +0000)]
Text area does not update when you arrow through a <select> in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=51269
<rdar://problem/8612853>

Reviewed by Anders Carlsson.

Patch by Sam Weinig.

Insteaed of keeping track of the selected index of a <select> just in the UI process, we
need to pass this information along to the web process so that the web process can draw
the correct text in the text field at the top of the select, when the selection changes (via
the arrows or other typing while the select is opened).

When the selected item in a popup changes, the UI process sends a message to the web process, telling
it about the new selected index. The web process gets this message, and then sets the text that
is visible in the select element.

* UIProcess/API/mac/PageClientImpl.h: CreatePopupMenuProxy now takes a WebPageProxy.
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::createPopupMenuProxy): Pass the WebPageProxy to create.
* UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::createPopupMenuProxy):
* UIProcess/API/qt/qwkpage_p.h: CreatePopupMenuProxy now takes a WebPageProxy.
* UIProcess/PageClient.h: CreatePopupMenuProxy now takes a WebPageProxy.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::valueChangedForPopupMenu): Send that the selected index changed to the
    web process.selected
(WebKit::WebPageProxy::setTextFromItemForPopupMenu): Send that we should update the text for the
    active popup menu (with the index of the item to show).
(WebKit::WebPageProxy::showPopupMenu): Pass the WebPageProxy to createPopupMenuProxy.
* UIProcess/WebPageProxy.h:
* UIProcess/WebPopupMenuProxy.h: Add a client who has virtual functions for the state changing of the
    popup menu. ShowPopupMenu doesn't take a new selected index anymore, that is handled by the client,
    and calling down to the web process.
(WebKit::WebPopupMenuProxy::Client::~Client):
(WebKit::WebPopupMenuProxy::WebPopupMenuProxy): Initialize the client.
* UIProcess/mac/WebPopupMenuProxyMac.h:
(WebKit::WebPopupMenuProxyMac::create): Takes a WebPopupMenuProxy::Client, and passes it to the constructor.
* UIProcess/mac/WebPopupMenuProxyMac.mm:
(WebKit::WebPopupMenuProxyMac::WebPopupMenuProxyMac): Update what's initialized by the constructor.
(WebKit::WebPopupMenuProxyMac::showPopupMenu): Call through to the web process that the value changed.
* UIProcess/qt/WebPopupMenuProxyQt.cpp:
(WebKit::WebPopupMenuProxyQt::WebPopupMenuProxyQt): Update what's initialized by the constructor.
* UIProcess/win/WebPopupMenuProxyWin.cpp:
(WebKit::WebPopupMenuProxyWin::WebPopupMenuProxyWin): Ditto.
(WebKit::WebPopupMenuProxyWin::showPopupMenu): Call through to the web process that the value changed.
(WebKit::WebPopupMenuProxyWin::setFocusedIndex): Resolve a FIXME to set the text of the popup menu.
* UIProcess/win/WebPopupMenuProxyWin.h:
(WebKit::WebPopupMenuProxyWin::create): Take in a WebPopupMenuProxy::client, and pass it to the constructor.
* UIProcess/win/WebView.cpp:
(WebKit::WebView::createPopupMenuProxy): Pass the WebPageProxy to create.
* UIProcess/win/WebView.h:
* WebProcess/WebCoreSupport/WebPopupMenu.cpp:
(WebKit::WebPopupMenu::setTextForIndex): Call through to setTextFromItem to set the select text.
* WebProcess/WebCoreSupport/WebPopupMenu.h:
* WebProcess/WebPage/WebPage.cpp: Call through to setTextForIndex on the active popup menu.
(WebKit::WebPage::setTextForActivePopupMenu):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in: Add a new message.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a WebPageProxy parameter to the DrawingAreaProxy constructor
andersca@apple.com [Fri, 17 Dec 2010 21:06:48 +0000 (21:06 +0000)]
Add a WebPageProxy parameter to the DrawingAreaProxy constructor
https://bugs.webkit.org/show_bug.cgi?id=51271

Reviewed by Sam Weinig.

* UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:contextRef:pageGroupRef:]):
(-[WKView _switchToDrawingAreaTypeIfNecessary:DrawingAreaInfo::]):
* UIProcess/API/qt/qgraphicswkview.cpp:
(QGraphicsWKView::QGraphicsWKView):
* UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:
(WebKit::ChunkedUpdateDrawingAreaProxy::create):
(WebKit::ChunkedUpdateDrawingAreaProxy::ChunkedUpdateDrawingAreaProxy):
* UIProcess/ChunkedUpdateDrawingAreaProxy.h:
* UIProcess/DrawingAreaProxy.cpp:
(WebKit::DrawingAreaProxy::DrawingAreaProxy):
* UIProcess/DrawingAreaProxy.h:
* UIProcess/LayerBackedDrawingAreaProxy.cpp:
(WebKit::LayerBackedDrawingAreaProxy::create):
(WebKit::LayerBackedDrawingAreaProxy::LayerBackedDrawingAreaProxy):
* UIProcess/LayerBackedDrawingAreaProxy.h:
* UIProcess/TiledDrawingAreaProxy.cpp:
(WebKit::TiledDrawingAreaProxy::create):
(WebKit::TiledDrawingAreaProxy::TiledDrawingAreaProxy):
* UIProcess/TiledDrawingAreaProxy.h:
* UIProcess/win/WebView.cpp:
(WebKit::WebView::WebView):
(WebKit::WebView::switchToDrawingAreaTypeIfNecessary):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd API for "Always Use the Complex Text Code Path"
mitz@apple.com [Fri, 17 Dec 2010 19:45:12 +0000 (19:45 +0000)]
Add API for "Always Use the Complex Text Code Path"
https://bugs.webkit.org/show_bug.cgi?id=51265

Reviewed by Darin Adler.

* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::WebProcessCreationParameters): Initialize shouldAlwaysUseComplexTextCodePath.
(WebKit::WebProcessCreationParameters::encode): Encode shouldAlwaysUseComplexTextCodePath.
(WebKit::WebProcessCreationParameters::decode): Decode shouldAlwaysUseComplexTextCodePath.
* Shared/WebProcessCreationParameters.h:
* UIProcess/API/C/WKContext.cpp:
(_WKContextSetAlwaysUsesComplexTextCodePath): Added.
* UIProcess/API/C/WKContextPrivate.h:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext): Initialize m_alwaysUsesComplexTextCodePath.
(WebKit::WebContext::ensureWebProcess): Set shouldAlwaysUseComplexTextCodePath in the creation parameters.
(WebKit::WebContext::setAlwaysUsesComplexTextCodePath): Added. Sets m_alwaysUsesComplexTextCodePath and
sends a message to the WebProcess.
* UIProcess/WebContext.h:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess): Call setAlwaysUsesComplexTextCodePath() based on the creation
parameters.
(WebKit::WebProcess::setAlwaysUsesComplexTextCodePath): Added.
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in: Added SetAlwaysUsesComplexTextCodePath.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebKit2: Implement a title attribute per frame
weinig@apple.com [Fri, 17 Dec 2010 19:35:46 +0000 (19:35 +0000)]
WebKit2: Implement a title attribute per frame
https://bugs.webkit.org/show_bug.cgi?id=51266

Reviewed by Darin Adler.

Cache the title of each frame on the WebFrameProxy. Removes
the WebPageProxy's cache of the main frame title to just
access the main frame.

We clear the cached title on new committed loads and on failures
to load.

* UIProcess/API/C/WKFrame.cpp:
(WKFrameCopyTitle):
* UIProcess/API/C/WKFrame.h:
* UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::didCommitLoad):
(WebKit::WebFrameProxy::didFailLoad):
(WebKit::WebFrameProxy::didChangeTitle):
* UIProcess/WebFrameProxy.h:
(WebKit::WebFrameProxy::title):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::pageTitle):
(WebKit::WebPageProxy::didReceiveTitleForFrame):
(WebKit::WebPageProxy::processDidCrash):
* UIProcess/WebPageProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebCore: Layout and rendering of CSS text-emphasis
mitz@apple.com [Fri, 17 Dec 2010 19:31:16 +0000 (19:31 +0000)]
WebCore: Layout and rendering of CSS text-emphasis
Final part of <rdar://problem/7720300> Support the CSS3 text-emphasis property
https://bugs.webkit.org/show_bug.cgi?id=48539

Reviewed by Dave Hyatt.

Tests: fast/text/emphasis-vertical.html
       fast/text/emphasis.html

Emphasis marks behave like they are stuck just above the ascender (or just below the
descender). They occupy space in the leading and in padding, and only grow the line space
if they cannot fit.

* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::placeBoxesInBlockDirection): Renamed the containsRuby parameter to
hasAnnotationsBefore, and added hasAnnotationsAfter. Line annotations include ruby and text emphasis
marks.
(WebCore::InlineFlowBox::addTextBoxVisualOverflow): Added overflow from emphasis marks.
(WebCore::InlineFlowBox::computeOverAnnotationAdjustment): Remaned computeBlockDirectionRubyAdjustment()
to this and added adjustment for text emphasis marks.
(WebCore::InlineFlowBox::computeUnderAnnotationAdjustment): Added. Similar to the previous function,
but for annotations under the glyphs. These can only be text emphasis marks.
* rendering/InlineFlowBox.h:
* rendering/InlineTextBox.cpp:
(WebCore::paintTextWithShadows): Paint emphasis marks.
(WebCore::InlineTextBox::paint): Ditto.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren): Generalized the code that adjusts the last line for
ruby in flipped writing mode to also adjust the last line for emphasis marks under the line in non-
flipped writing mode.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::selectionColor): Added this helper method which generalizes selectionForegroundColor().
(WebCore::RenderObject::selectionForegroundColor): Moved most of the code to selectionColor().
(WebCore::RenderObject::selectionEmphasisMarkColor): Added.
* rendering/RenderObject.h:
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::RootInlineBox): Updated initialization for new members.
(WebCore::RootInlineBox::alignBoxesInBlockDirection): Update new members.
(WebCore::RootInlineBox::beforeAnnotationsAdjustment): Renamed blockDirectionRubyAdjustment() to this
and extended to deal with annotations over and under the line and the previous line. If both lines have
annotations into the space between the lines, maintain separation so that the annotations do not overlap.
* rendering/RootInlineBox.h:
(WebCore::RootInlineBox::hasAnnotationsBefore): Added this accessor.
(WebCore::RootInlineBox::hasAnnotationsAfter): Ditto.

LayoutTests: <rdar://problem/7720300> Support the CSS3 text-emphasis property
https://bugs.webkit.org/show_bug.cgi?id=48539

Reviewed by Dave Hyatt.

* fast/text/emphasis-vertical.html: Added.
* fast/text/emphasis.html: Added.
* platform/mac/fast/text/emphasis-expected.checksum: Added.
* platform/mac/fast/text/emphasis-expected.png: Added.
* platform/mac/fast/text/emphasis-expected.txt: Added.
* platform/mac/fast/text/emphasis-vertical-expected.checksum: Added.
* platform/mac/fast/text/emphasis-vertical-expected.png: Added.
* platform/mac/fast/text/emphasis-vertical-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-17 Antonio Gomes <agomes@rim.com>
tonikitoo@webkit.org [Fri, 17 Dec 2010 19:12:44 +0000 (19:12 +0000)]
2010-12-17  Antonio Gomes  <agomes@rim.com>

        Unreviewed fix for Windows bots.

        r74270 removed the windows specific result for extend-selection-home-end.html
        since it was matching the cross platform expectation result. However, when there is
        no win specific test result but there is a mac one for the same test, the later
        is picked before the cross platform one.

        * platform/win/editing/selection/extend-selection-home-end-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-17 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 17 Dec 2010 18:58:23 +0000 (18:58 +0000)]
2010-12-17  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Antonio Gomes.

        editing/execCommand/toggle-compound-styles-expected should use LayoutTestController::setEditingBehavior
        https://bugs.webkit.org/show_bug.cgi?id=51261

        Modified the test to run each test case using each editing behavior, eliminating the need for
        platform-specific expected results.

        * editing/execCommand/script-tests/toggle-compound-styles.js:
        (testSingleToggle):
        * platform/gtk/editing/execCommand/toggle-compound-styles-expected.txt: Removed.
        * platform/mac/editing/execCommand/toggle-compound-styles-expected.txt: Removed.
        * platform/qt/editing/execCommand/toggle-compound-styles-expected.txt: Removed.
        * platform/win/editing/execCommand/toggle-compound-styles-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-17 W. James MacLean <wjmaclean@chromium.org>
commit-queue@webkit.org [Fri, 17 Dec 2010 18:56:27 +0000 (18:56 +0000)]
2010-12-17  W. James MacLean  <wjmaclean@chromium.org>

        Reviewed by James Robinson.

        [chromium] Add support to compositor to composite to offscreen texture.
        https://bugs.webkit.org/show_bug.cgi?id=50833

        A patch to extend compositor to be able to composite into an offscreen texture instead
        of just directly to the display buffer. Builds on RenderSurfaceChromium support.

        External behaviour not changed, so no tests.

        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::LayerRendererChromium):
        (WebCore::LayerRendererChromium::prepareToDrawLayers):
        (WebCore::LayerRendererChromium::drawLayers):
        (WebCore::LayerRendererChromium::setCompositeOffscreen):
        (WebCore::LayerRendererChromium::useRenderSurface):
        (WebCore::LayerRendererChromium::setScissorToRect):
        * platform/graphics/chromium/LayerRendererChromium.h:
        (WebCore::LayerRendererChromium::isCompositingOffscreen):
        (WebCore::LayerRendererChromium::getOffscreenLayerTexture):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-17 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Fri, 17 Dec 2010 18:37:24 +0000 (18:37 +0000)]
2010-12-17  Ojan Vafai  <ojan@chromium.org>

        Increment psuedo-version number to avoid pulling cached version.

        * PrettyPatch/PrettyPatch.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-17 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Fri, 17 Dec 2010 18:33:47 +0000 (18:33 +0000)]
2010-12-17  Ojan Vafai  <ojan@chromium.org>

        Speculative fix for the code review tool in Firefox.
        Fixes a JS error and makes the status bubble mostly work
        if postMessage is not supported.

        * PrettyPatch/PrettyPatch.rb:
        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-16 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 17 Dec 2010 17:57:44 +0000 (17:57 +0000)]
2010-12-16  Darin Adler  <darin@apple.com>

        Reviewed by Maciej Stachowiak.

        Add text encoding menu API for WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=51226

        * UIProcess/API/C/WKPage.cpp:
        (WKPageSupportsTextEncoding): Added.
        (WKPageCopyCustomTextEncodingName): Added.
        (WKPageSetCustomTextEncodingName): Added.
        * UIProcess/API/C/WKPage.h: Added the functions above.

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::WebPageProxy): Initialize
        m_mainFrameHasCustomRepresentation to false.
        (WebKit::WebPageProxy::supportsTextEncoding): Added.
        (WebKit::WebPageProxy::setCustomTextEncodingName): Added.
        (WebKit::WebPageProxy::didCommitLoadForFrame): Set
        m_mainFrameHasCustomRepresentation.

        * UIProcess/WebPageProxy.h: Added supportsTextEncoding,
        setCustomTextEncodingName, customTextEncodingName, and
        m_mainFrameHasCustomRepresentation.

        * UIProcess/WebPageProxy.messages.in: Tweaked formatting
        (added a blank line).

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::setCustomTextEncodingName): Added.
        * WebProcess/WebPage/WebPage.h: Added setCustomTextEncodingName.

        * WebProcess/WebPage/WebPage.messages.in: Added the
        SetCustomTextEncodingName message. Tweaked formatting of the
        dummy message.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-17 John Knottenbelt <jknotten@chromium.org>
commit-queue@webkit.org [Fri, 17 Dec 2010 17:37:04 +0000 (17:37 +0000)]
2010-12-17  John Knottenbelt  <jknotten@chromium.org>

        Reviewed by Jeremy Orlow.

        Fix test failures where NULL GeolocationClient is provided
        https://bugs.webkit.org/show_bug.cgi?id=51256

        * src/GeolocationClientProxy.cpp:
        (WebKit::GeolocationClientProxy::geolocationDestroyed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-17 Antonio Gomes <agomes@rim.com>
tonikitoo@webkit.org [Fri, 17 Dec 2010 17:12:56 +0000 (17:12 +0000)]
2010-12-17  Antonio Gomes  <agomes@rim.com>

        Unreviewed expectation result update.

        editing/execCommand/toggle-compound-styles.html needs new expected results after r74269.

        Default editing behavior of GTK+ DRT was changed from Mac to Unix, and this test is wrongly
        going through platform specific editing behavior code path without making calls to
        LayoutTestController::setEditingBehavior. Filed bug 51261 for the proper fix.

        * platform/gtk/editing/execCommand/toggle-compound-styles-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-17 Ariya Hidayat <ariya@sencha.com>
ariya@webkit.org [Fri, 17 Dec 2010 16:43:05 +0000 (16:43 +0000)]
2010-12-17  Ariya Hidayat  <ariya@sencha.com>

        Reviewed by Andreas Kling.

        [Qt] Default image interpolation should reset the render hint
        https://bugs.webkit.org/show_bug.cgi?id=51233

        Save initial SmoothPixmapTransform render hint so that it can be used
        with default image interpolation quality to reset back the render hints.

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
        (WebCore::GraphicsContext::setImageInterpolationQuality):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-17 Ariya Hidayat <ariya@sencha.com>
ariya@webkit.org [Fri, 17 Dec 2010 16:26:55 +0000 (16:26 +0000)]
2010-12-17  Ariya Hidayat  <ariya@sencha.com>

        Reviewed by Antonio Gomes.

        [Qt] GraphicsContext should respect QWebView render hints
        https://bugs.webkit.org/show_bug.cgi?id=51208

        Adjust the test since SmoothPixmapTransform is set by default.

        * tests/qwebview/tst_qwebview.cpp:
        (tst_QWebView::renderHints):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-05 Antonio Gomes <agomes@rim.com>
tonikitoo@webkit.org [Fri, 17 Dec 2010 16:16:08 +0000 (16:16 +0000)]
2010-12-05 Antonio Gomes <agomes@rim.com>

        Reviewed by Ariya Hidayat.

        [Qt] Fix caret browsing navigation mode
        https://bugs.webkit.org/show_bug.cgi?id=50536

        WebKit/qt:

        Caret browsing can consume editing commands even when the start
        of current selection is not a editable content. r69582 missed this
        case because caret browsing feature testing is very poor today.

        This commit reintroduces part of the removed code in r69582 but
        guarded by a isCaretBrowsingEnabled() check. No regression found.

        * WebCoreSupport/EditorClientQt.cpp:
        (WebCore::EditorClientQt::handleKeyboardEvent):

        LayoutTests:

        /platform/gtk/editing/selection/caret-mode-paragraph-keys-navigation.html
        is one of the few tests actually tests the caret browsing feature.
        Patch makes the test not Gtk+ specific, and Qt now passes on it.

        * editing/selection/caret-mode-paragraph-keys-navigation-expected.txt: Renamed from LayoutTests/platform/gtk/editing/selection/caret-mode-paragraph-keys-navigation-expected.tx       t.
        * editing/selection/caret-mode-paragraph-keys-navigation.html: Renamed from LayoutTests/platform/gtk/editing/selection/caret-mode-paragraph-keys-navigation.html.
        * fast/events/multiline-link-arrow-navigation.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-16 Antonio Gomes <agomes@rim.com>
tonikitoo@webkit.org [Fri, 17 Dec 2010 16:15:41 +0000 (16:15 +0000)]
2010-12-16  Antonio Gomes  <agomes@rim.com>

        Reviewed by Martin Robinson.

        Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
        https://bugs.webkit.org/show_bug.cgi?id=51163

        WebKitTools:
        Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
        GTK+'s DRT should also reset to UNIX after each test execution.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (resetDefaultsToConsistentValues):

        LayoutTests:
        Removed platform specific expected result files for gtk and windows
        for editing/selection/extend-selection-home-end.html, since they all match
        the cross platform result file.

        Note: chromium-win and mac still have their own expected file each.

        * platform/gtk/editing/selection/extend-selection-home-end-expected.txt: Removed.
        * platform/win/editing/selection/extend-selection-home-end-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-17 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Fri, 17 Dec 2010 15:54:44 +0000 (15:54 +0000)]
2010-12-17  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r74201.
        http://trac.webkit.org/changeset/74201
        https://bugs.webkit.org/show_bug.cgi?id=51248

        It broke ~6000 layout tests (Requested by Ossy_ on #webkit).

        * UIProcess/API/qt/qgraphicswkview.cpp:
        (QGraphicsWKView::setGeometry):
        (QGraphicsWKView::itemChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-17 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Fri, 17 Dec 2010 15:11:51 +0000 (15:11 +0000)]
2010-12-17  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Remove custom expectations for fast/js/regexp-ranges-and-escaped-hyphens.html

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-17 Hans Wennborg <hans@chromium.org>
hans@chromium.org [Fri, 17 Dec 2010 15:10:21 +0000 (15:10 +0000)]
2010-12-17  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        IndexedDB: Support Date objects as keys.
        https://bugs.webkit.org/show_bug.cgi?id=51193

        Update layout tests to check that having Date objects as keys work.

        * storage/indexeddb/objectstore-basics-expected.txt:
        * storage/indexeddb/objectstore-basics.html:
2010-12-17  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        IndexedDB: Support Date objects as keys.
        https://bugs.webkit.org/show_bug.cgi?id=51193

        * bindings/v8/IDBBindingUtilities.cpp:
        (WebCore::createIDBKeyFromValue):
        Use the new IDBKey factory functions, and support Date objects.
        * bindings/v8/custom/V8IDBKeyCustom.cpp:
        (WebCore::toV8):
        Create Date objects from DateType keys.
        * storage/IDBKey.cpp:
        (WebCore::IDBKey::fromQuery):
        (WebCore::IDBKey::isEqual):
        (WebCore::IDBKey::whereSyntax):
        (WebCore::IDBKey::lowerCursorWhereFragment):
        (WebCore::IDBKey::upperCursorWhereFragment):
        (WebCore::IDBKey::bind):
        (WebCore::IDBKey::bindWithNulls):
        Update all SQL related functions to handle Date keys.
        * storage/IDBKey.h:
        (WebCore::IDBKey::createNull):
        (WebCore::IDBKey::createNumber):
        (WebCore::IDBKey::createString):
        (WebCore::IDBKey::createDate):
        Rename the create factories; since both number and date is just a
        double, function overloading can't be used to discriminate between
        the factories.
        (WebCore::IDBKey::date):
        Add getter for the date value.
2010-12-17  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        IndexedDB: Support Date objects as keys.
        https://bugs.webkit.org/show_bug.cgi?id=51193

        Update to match the underlying WebCore IDBKey class:
        add the DateType, add create() functions for each type,
        deprecate the public constructors (will be removed once
        Chromium side is updated).

        * public/WebIDBKey.h:
        (WebKit::WebIDBKey::WebIDBKey):
        * src/AssertMatchingEnums.cpp:
        * src/WebIDBKey.cpp:
        (WebKit::WebIDBKey::createString):
        (WebKit::WebIDBKey::createDate):
        (WebKit::WebIDBKey::createNumber):
        (WebKit::WebIDBKey::assignNull):
        (WebKit::WebIDBKey::assignString):
        (WebKit::WebIDBKey::assignDate):
        (WebKit::WebIDBKey::assignNumber):
        (WebKit::WebIDBKey::date):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-17 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Fri, 17 Dec 2010 14:55:18 +0000 (14:55 +0000)]
2010-12-17  Sergio Villar Senin  <svillar@igalia.com>

        Unreviewed, tests were skipped due to a bug in libsoup
        https://bugzilla.gnome.org/show_bug.cgi?id=631679. Now that it was
        fixed we can safely unskip them again.

        [GTK] Failing http/tests/xmlhttprequest tests
        https://bugs.webkit.org/show_bug.cgi?id=30582

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-17 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Fri, 17 Dec 2010 14:47:45 +0000 (14:47 +0000)]
2010-12-17  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: add scripts parsed after resource load to SourceFrame.
        https://bugs.webkit.org/show_bug.cgi?id=51243

        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._addScript):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype.addScript):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-17 Anton Muhin <antonm@chromium.org>
antonm@chromium.org [Fri, 17 Dec 2010 14:39:13 +0000 (14:39 +0000)]
2010-12-17  Anton Muhin  <antonm@chromium.org>

        Reviewed by Yury Semikhatsky.

        [v8] The last portion of CSS GC work: fixing fast/dom/StyleSheet/gc-stylesheet-wrapper.html
        https://bugs.webkit.org/show_bug.cgi?id=51121

        Properly group style elements of HTML links, style elements and processing instructions.

        * bindings/v8/V8GCController.cpp:
        (WebCore::NodeGrouperVisitor::visitDOMWrapper):
        (WebCore::NodeGrouperVisitor::addDOMObjectToGroup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-17 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Fri, 17 Dec 2010 14:37:02 +0000 (14:37 +0000)]
2010-12-17  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [REGRESSION] scripts in scripts panel are not updated on reload.
        https://bugs.webkit.org/show_bug.cgi?id=51101

        * inspector/front-end/ResourceManager.js:
        (WebInspector.ResourceTreeModel.prototype.didCommitLoadForFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-17 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Fri, 17 Dec 2010 14:33:42 +0000 (14:33 +0000)]
2010-12-17  Kent Tamura  <tkent@chromium.org>

        Unreviewed, test expectation update.

        * platform/chromium/test_expectations.txt: Collect and correct failures about vertical writing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-17 Benjamin Poulain <benjamin.poulain@nokia.com>
benjamin.poulain@nokia.com [Fri, 17 Dec 2010 14:15:57 +0000 (14:15 +0000)]
2010-12-17  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Laszlo Gombos.

        The inspector does not compile without JAVASCRIPT_DEBUGGER
        https://bugs.webkit.org/show_bug.cgi?id=51246

        Fix the build, m_extraHeaders does not depend on JAVASCRIPT_DEBUGGER.

        * inspector/InspectorController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-17 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Fri, 17 Dec 2010 13:52:53 +0000 (13:52 +0000)]
2010-12-17  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: clear extra/override headers when front-end is closed
        https://bugs.webkit.org/show_bug.cgi?id=51244

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::disconnectFrontend):
        (WebCore::InspectorController::willSendRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-17 David Levin <levin@chromium.org>
levin@chromium.org [Fri, 17 Dec 2010 13:15:23 +0000 (13:15 +0000)]
2010-12-17  David Levin  <levin@chromium.org>

        Reviewed by Eric Seidel.

        check-webkit-style should understand WTF #include guards
        https://bugs.webkit.org/show_bug.cgi?id=44911

        * Scripts/webkitpy/style/checkers/cpp.py:
        (get_header_guard_cpp_variable): modify to suggest the WTF style
        of header guard when appropriate.
        (check_for_header_guard): handle multiple return values from
        get_header_guard_cpp_variable
        * Scripts/webkitpy/style/checkers/cpp_unittest.py:
        (CppStyleTest.test_build_header_guard): Added tests for the WTF
        header style.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed.
ossy@webkit.org [Fri, 17 Dec 2010 13:07:20 +0000 (13:07 +0000)]
Unreviewed.

[Qt] Web Timing related bugs
https://bugs.webkit.org/show_bug.cgi?id=51245

* platform/qt/Skipped: http/tests/misc/webtiming-ssl.php added until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-17 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 17 Dec 2010 12:52:18 +0000 (12:52 +0000)]
2010-12-17  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [REGRESSION] Cmd (Ctrl) + G does not search next in Scripts panel.
        https://bugs.webkit.org/show_bug.cgi?id=50893

        Now Mac shortcuts are:
        - Cmd F/G = find / next
        - Cmd L = go to line

        Win/Linux:
        - Ctrl+G = go to line

        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._registerShortcuts):
        * inspector/front-end/inspector.js:
        (WebInspector._registerShortcuts):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-17 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Fri, 17 Dec 2010 12:50:38 +0000 (12:50 +0000)]
2010-12-17  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Update Chromium test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-16 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Fri, 17 Dec 2010 12:46:10 +0000 (12:46 +0000)]
2010-12-16  Sergio Villar Senin  <svillar@igalia.com>

        Reviewed by Martin Robinson.

        Wrong check in ResourceHandleSoup in error cases
        https://bugs.webkit.org/show_bug.cgi?id=51171

        Calling didReceiveData with no data causes a crash in debug
        builds. Checking for soupMsg->response_body->data is not correct as libsoup
        always creates a buffer for that. Instead we should check for
        soupMsg->response_body->length

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::sendRequestCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-17 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Fri, 17 Dec 2010 12:27:58 +0000 (12:27 +0000)]
2010-12-17  Sergio Villar Senin  <svillar@igalia.com>

        Unreviewed, skipping a failing test in the bots.

        [GTK] fast/dom/global-constructors.html failing on bots
        https://bugs.webkit.org/show_bug.cgi?id=51242

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-17 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Fri, 17 Dec 2010 12:19:02 +0000 (12:19 +0000)]
2010-12-17  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Fix typo in Chromium test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-17 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Fri, 17 Dec 2010 12:05:22 +0000 (12:05 +0000)]
2010-12-17  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Avoid unnecessary calls to GraphicsContextPlatformPrivate::p()
        https://bugs.webkit.org/show_bug.cgi?id=49954

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::pushTransparencyLayerInternal):
        (WebCore::GraphicsContext::beginTransparencyLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-17 Carlos Garcia Campos <cgarcia@igalia.com>
xan@webkit.org [Fri, 17 Dec 2010 11:13:13 +0000 (11:13 +0000)]
2010-12-17  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Compile warning introduced in r74129
        https://bugs.webkit.org/show_bug.cgi?id=51181

        * platform/gtk/RenderThemeGtk.cpp:
        (WebCore::RenderThemeGtk::gtkContainer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoVersioning.
mrowe@apple.com [Fri, 17 Dec 2010 11:05:27 +0000 (11:05 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-17 Yi Shen <yi.4.shen@nokia.com>
commit-queue@webkit.org [Fri, 17 Dec 2010 10:51:35 +0000 (10:51 +0000)]
2010-12-17  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] QWebPage sends out a RequestSoftwareInputPanel event
        incorrectly in particular case
        https://bugs.webkit.org/show_bug.cgi?id=50419

        Add HitTestResult check before firing RequestSoftwareInputPanel event.

        * Api/qwebpage.cpp:
        (QWebPagePrivate::mouseReleaseEvent):
        (QWebPagePrivate::handleSoftwareInputPanel):
        * Api/qwebpage_p.h:
        * tests/qwebpage/tst_qwebpage.cpp:
        (clickOnPage):
        (tst_QWebPage::inputMethods):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-17 James Simonsen <simonjam@chromium.org>
commit-queue@webkit.org [Fri, 17 Dec 2010 10:37:55 +0000 (10:37 +0000)]
2010-12-17  James Simonsen  <simonjam@chromium.org>

        Reviewed by Darin Fisher.

        [Web Timing] Add sslHandshakeStart to interface

        https://bugs.webkit.org/show_bug.cgi?id=50400

        * fast/dom/Window/window-properties-performance-expected.txt: Added sslHandshakeStart.
        * fast/dom/script-tests/webtiming.js: Ditto.
        (checkTimingBeforeLoad):
        (checkTimingWhileDeferred):
        (checkWebTimingOnDOMContentLoaded):
        (checkWebTimingWhileAsync):
        (checkWebTimingOnLoad):
        (checkWebTimingAfterLoad):
        * fast/dom/webtiming-document-open-expected.txt: Ditto.
        * fast/dom/webtiming-expected.txt: Ditto.
        * fast/dom/webtiming-navigate-within-document-expected.txt: Ditto.
        * http/tests/misc/resources/webtiming-ssl.html: Added.
        * http/tests/misc/webtiming-ssl-expected.txt: Added.
        * http/tests/misc/webtiming-ssl.php: Added.
        * platform/gtk/Skipped: WebTiming disabled here.
        * platform/mac/Skipped: Ditto.
        * platform/win/Skipped: Ditto.
2010-12-17  James Simonsen  <simonjam@chromium.org>

        Reviewed by Darin Fisher.

        [Web Timing] Add sslHandshakeStart to interface

        https://bugs.webkit.org/show_bug.cgi?id=50400

        Test: http/tests/misc/webtiming-ssl.php

        * page/PerformanceTiming.cpp:
        (WebCore::PerformanceTiming::connectStart): Update comment.
        (WebCore::PerformanceTiming::connectEnd): Remove SSL time.
        (WebCore::PerformanceTiming::sslHandshakeStart): Added.
        * page/PerformanceTiming.h: Added sslHandshakeStart.
        * page/PerformanceTiming.idl: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-17 James Simonsen <simonjam@chromium.org>
commit-queue@webkit.org [Fri, 17 Dec 2010 10:19:46 +0000 (10:19 +0000)]
2010-12-17  James Simonsen  <simonjam@chromium.org>

        Reviewed by Darin Fisher.

        [Web Timing] Navigation type enums should begin with TYPE_
        https://bugs.webkit.org/show_bug.cgi?id=51200

        * fast/dom/Window/window-properties-performance-expected.txt: Added TYPE_ to navigation types and added TYPE_RESERVED.
2010-12-17  James Simonsen  <simonjam@chromium.org>

        Reviewed by Darin Fisher.

        [Web Timing] Navigation type enums should begin with TYPE_
        https://bugs.webkit.org/show_bug.cgi?id=51200

        * page/PerformanceNavigation.cpp:
        (WebCore::PerformanceNavigation::type): Added TYPE_ to navigation types.
        * page/PerformanceNavigation.h: Ditto and added TYPE_RESERVED.
        * page/PerformanceNavigation.idl: Ditto.
2010-12-17  James Simonsen  <simonjam@chromium.org>

        Reviewed by Darin Fisher.

        [Web Timing] Navigation type enums should begin with TYPE_
        https://bugs.webkit.org/show_bug.cgi?id=51200

        * src/WebPerformance.cpp:
        (WebKit::WebPerformance::navigationType): Added TYPE_ to navigation types.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix build with Geolocation disabled.
steveblock@google.com [Fri, 17 Dec 2010 10:05:59 +0000 (10:05 +0000)]
Fix build with Geolocation disabled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-17 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Fri, 17 Dec 2010 09:48:06 +0000 (09:48 +0000)]
2010-12-17  Andrey Kosyakov  <caseq@chromium.org>

        Unreviewed test fix: removed real user agent from test expectations.

        * http/tests/inspector/extensions-headers-expected.txt:
        * http/tests/inspector/extensions-headers.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-17 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Fri, 17 Dec 2010 09:17:52 +0000 (09:17 +0000)]
2010-12-17  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed. WinCE build fix.

        * platform/graphics/GraphicsContext.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-17 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Fri, 17 Dec 2010 09:13:27 +0000 (09:13 +0000)]
2010-12-17  Andrey Kosyakov  <caseq@chromium.org>

        Unreviewed. Clean up extra headers set in test to avoid side effects on other tests.

        * http/tests/inspector/extensions-headers-expected.txt:
        * http/tests/inspector/extensions-headers.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-17 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Fri, 17 Dec 2010 08:29:52 +0000 (08:29 +0000)]
2010-12-17  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: remove unnecessary dependencies from InspectorBackendStub.

        InspectorBackendStub is a transport-only thing but it has dependencies with
        Callback.js and WebInspector namespace. Callback can be integrated into
        InspectorBackendStub because it is the only client.
        Without these dependencies InspectorBackendStub can be used as an API
        wrapper for Inspector Protocol.

        https://bugs.webkit.org/show_bug.cgi?id=51184

        * WebCore.gypi:
        * inspector/CodeGeneratorInspector.pm:
        * inspector/front-end/Callback.js: Removed.
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-17 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 17 Dec 2010 08:23:56 +0000 (08:23 +0000)]
2010-12-17  Eric Seidel  <eric@webkit.org>

        Unreviewed, rolling out r74229.
        http://trac.webkit.org/changeset/74229
        https://bugs.webkit.org/show_bug.cgi?id=50536

        Broken on Snow Leopard and possibly other platforms

        * platform/gtk/editing/selection/caret-mode-paragraph-keys-navigation-expected.txt: Renamed from LayoutTests/editing/selection/caret-mode-paragraph-keys-navigation-expected.txt.
        * platform/gtk/editing/selection/caret-mode-paragraph-keys-navigation.html: Renamed from LayoutTests/editing/selection/caret-mode-paragraph-keys-navigation.html.
        * platform/mac/Skipped:
        * platform/win/Skipped:
2010-12-17  Eric Seidel  <eric@webkit.org>

        Unreviewed, rolling out r74229.
        http://trac.webkit.org/changeset/74229
        https://bugs.webkit.org/show_bug.cgi?id=50536

        Broken on Snow Leopard and possibly other platforms

        * WebCoreSupport/EditorClientQt.cpp:
        (WebCore::EditorClientQt::handleKeyboardEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-15 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Fri, 17 Dec 2010 08:22:16 +0000 (08:22 +0000)]
2010-12-15  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Extension API] add support for adding/overriding HTTP request headers
        https://bugs.webkit.org/show_bug.cgi?id=50493

        Test: http/tests/inspector/extensions-headers.html

        * inspector/Inspector.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::willSendRequest): Apply extra headers.
        (WebCore::InspectorController::setExtraHeaders):
        * inspector/InspectorController.h:
        * inspector/front-end/ExtensionAPI.js:
        (WebInspector.injectedExtensionAPI.Resources.prototype.getHAR):
        (WebInspector.injectedExtensionAPI.Resources.prototype.addRequestHeaders):
        * inspector/front-end/ExtensionServer.js:
        (WebInspector.ExtensionServer):
        (WebInspector.ExtensionServer.prototype._onAddRequestHeaders):

2010-12-15  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Extension API] add support for adding/overriding HTTP request headers
        Moved extensions test frameworks under http/tests/inspector, so HTTP tests may reuse it.
        https://bugs.webkit.org/show_bug.cgi?id=50493

        * http/tests/inspector/extensions-headers-expected.txt: Added.
        * http/tests/inspector/extensions-headers.html: Added.
        * http/tests/inspector/extensions-test.js: Renamed from LayoutTests/inspector/extensions-test.js.
        (log):
        (extensionFunctions):
        (initialize_ExtensionsTest.InspectorTest.dispatchOnMessage):
        (initialize_ExtensionsTest.InspectorTest.runExtensionTests):
        (initialize_ExtensionsTest.extensionOutput):
        (initialize_ExtensionsTest.dumpSidebarContent):
        (initialize_ExtensionsTest.reloadPage):
        (test):
        * http/tests/inspector/resources/echo-headers.php: Added.
        * http/tests/inspector/resources/extension-main.html: Renamed from LayoutTests/inspector/resources/extension-main.html.
        * http/tests/inspector/resources/extension-main.js: Renamed from LayoutTests/inspector/resources/extension-main.js.
        (fetchTests.callback):
        (fetchTests):
        (runTests):
        (onTestsDone):
        (dispatchOnFrontend.callbackWrapper):
        (dispatchOnFrontend):
        (callbackAndNextTest.callbackWrapper):
        (callbackAndNextTest):
        * http/tests/inspector/resources/extension-panel.html: Renamed from LayoutTests/inspector/resources/extension-panel.html.
        * http/tests/inspector/resources/extension-sidebar.html: Renamed from LayoutTests/inspector/resources/extension-sidebar.html.
        * inspector/extensions-api-expected.txt:
        * inspector/extensions-api.html:
        * inspector/extensions-audits-api.html:
        * inspector/extensions-audits.html:
        * inspector/extensions-eval.html:
        * inspector/extensions-events.html:
        * inspector/extensions-resources-expected.txt:
        * inspector/extensions-resources.html:
        * inspector/extensions.html:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, test expectation update.
tkent@chromium.org [Fri, 17 Dec 2010 05:46:05 +0000 (05:46 +0000)]
Unreviewed, test expectation update.

Update Chromium-Linux results changed by r74232.
https://bugs.webkit.org/show_bug.cgi?id=50365

* platform/chromium-linux/fast/blockflow/japanese-rl-text-with-broken-font-expected.checksum:
* platform/chromium-linux/fast/blockflow/japanese-rl-text-with-broken-font-expected.png:
* platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum:
* platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-lr-expected.png:
* platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum:
* platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-rl-expected.png:
* platform/chromium-linux/fast/blockflow/vertical-align-table-baseline-expected.checksum:
* platform/chromium-linux/fast/blockflow/vertical-align-table-baseline-expected.png:
* platform/chromium-linux/fast/blockflow/vertical-baseline-alignment-expected.checksum:
* platform/chromium-linux/fast/blockflow/vertical-baseline-alignment-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-16 Koan-Sin Tan <koansin.tan@gmail.com>
tkent@chromium.org [Fri, 17 Dec 2010 05:19:32 +0000 (05:19 +0000)]
2010-12-16  Koan-Sin Tan  <koansin.tan@gmail.com>

        Reviewed by Kent Tamura.

        Glyphs in vertical text tests are rotated 90 degrees clockwise on Chromium Linux
        https://bugs.webkit.org/show_bug.cgi?id=50365

        No new tests. But this makes Chromimium Linux show
        fast/blockflow/japanese-*-text.html and other vertical
        writing text correctly as on WebKit and Chromimum for Mac.

        * platform/graphics/chromium/FontCacheLinux.cpp:
        (WebCore::FontCache::createFontPlatformData):
        * platform/graphics/chromium/FontLinux.cpp:
        (WebCore::Font::drawGlyphs):
        * platform/graphics/chromium/FontPlatformDataLinux.cpp:
        (WebCore::FontPlatformData::FontPlatformData):
        (WebCore::FontPlatformData::operator=):
        (WebCore::FontPlatformData::operator==):
        (WebCore::FontPlatformData::hash):
        * platform/graphics/chromium/FontPlatformDataLinux.h:
        (WebCore::FontPlatformData::FontPlatformData):
        (WebCore::FontPlatformData::orientation):
        * platform/graphics/chromium/SimpleFontDataLinux.cpp:
        (WebCore::SimpleFontData::platformInit):
        * platform/graphics/skia/FontCustomPlatformData.cpp:
        (WebCore::FontCustomPlatformData::fontPlatformData):
        * platform/graphics/skia/GlyphPageTreeNodeSkia.cpp:
        (WebCore::substituteWithVerticalGlyphs):
        (WebCore::GlyphPage::fill):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-16 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Fri, 17 Dec 2010 05:06:39 +0000 (05:06 +0000)]
2010-12-16  Kent Tamura  <tkent@chromium.org>

        Unreviewed, test expectation update.

        * platform/chromium/test_expectations.txt: Remove SLOW for fail-on-update-2.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-16 Benjamin Kalman <kalman@chromium.org>
commit-queue@webkit.org [Fri, 17 Dec 2010 03:51:59 +0000 (03:51 +0000)]
2010-12-16  Benjamin Kalman  <kalman@chromium.org>

        Reviewed by Ojan Vafai.

        Update BUG comment in test expectations files
        https://bugs.webkit.org/show_bug.cgi?id=51216

        Change the BUG[0-9]+ description to BUG(CR|WK|V8_)[0-9]+ where necessary.

        * platform/chromium/test_expectations.txt:
        * platform/mac/test_expectations.txt:
        * platform/qt/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-05 Antonio Gomes <agomes@rim.com>
tonikitoo@webkit.org [Fri, 17 Dec 2010 03:36:48 +0000 (03:36 +0000)]
2010-12-05 Antonio Gomes <agomes@rim.com>

        Reviewed by Ariya Hidayat.

        [Qt] Fix caret browsing navigation mode
        https://bugs.webkit.org/show_bug.cgi?id=50536

        WebKit/qt:

        Caret browsing can consume editing commands even when the start
        of current selection is not a editable content. r69582 missed this
        case because caret browsing feature testing is very poor today.

        This commit reintroduces part of the removed code in r69582 but
        guarded by a isCaretBrowsingEnabled() check. No regression found.

        * WebCoreSupport/EditorClientQt.cpp:
        (WebCore::EditorClientQt::handleKeyboardEvent):

        LayoutTests:

        /platform/gtk/editing/selection/caret-mode-paragraph-keys-navigation.html
        is one of the few tests actually tests the caret browsing feature.
        Patch makes the test not Gtk+ specific, and Qt now passes on it.

        * editing/selection/caret-mode-paragraph-keys-navigation-expected.txt: Renamed from LayoutTests/platform/gtk/editing/selection/caret-mode-paragraph-keys-navigation-expected.tx       t.
        * editing/selection/caret-mode-paragraph-keys-navigation.html: Renamed from LayoutTests/platform/gtk/editing/selection/caret-mode-paragraph-keys-navigation.html.
        * fast/events/multiline-link-arrow-navigation.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-16 Yi Shen <yi.4.shen@nokia.com>, Tor Arne Vestbo <tor.arne.vestbo@nokia...
commit-queue@webkit.org [Fri, 17 Dec 2010 03:28:51 +0000 (03:28 +0000)]
2010-12-16  Yi Shen  <yi.4.shen@nokia.com>, Tor Arne Vestbo <tor.arne.vestbo@nokia.com>

        Reviewed by Eric Carlson.

        Provide an interface to require using fullscreen mediaplayer
        https://bugs.webkit.org/show_bug.cgi?id=51133

        Add ChromeClient::requiresFullscreenForVideoPlayback to require webkit
        to launch fullscreen video player for playing the html5 video. The
        idea is that a browser vendor can specify this behavior through the
        platform plugin or something else by using this interface.

        No new tests because no client implements requiresFullscreenForVideoPlayback yet.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::updatePlayState):
        (WebCore::HTMLMediaElement::exitFullscreen):
        * page/Chrome.cpp:
        (WebCore::Chrome::requiresFullscreenForVideoPlayback):
        * page/Chrome.h:
        * page/ChromeClient.h:
        (WebCore::ChromeClient::requiresFullscreenForVideoPlayback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-16 David Levin <levin@chromium.org>
levin@chromium.org [Fri, 17 Dec 2010 03:05:30 +0000 (03:05 +0000)]
2010-12-16  David Levin  <levin@chromium.org>

        Reviewed by Eric Seidel.

        test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
        https://bugs.webkit.org/show_bug.cgi?id=51210

        The error only shows up when using python 2.6 or later.

        * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
        the decprecated field error,message with something equivalent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-16 Steve Block <steveblock@google.com>
steveblock@google.com [Fri, 17 Dec 2010 02:47:06 +0000 (02:47 +0000)]
2010-12-16  Steve Block  <steveblock@google.com>

        Reviewed by Steve Block.

        GeolocationPositionCache needs refactoring
        https://bugs.webkit.org/show_bug.cgi?id=50826

        No new tests, refactoring only.

        * page/Geolocation.cpp:
        (WebCore::Geolocation::Geolocation):
        (WebCore::Geolocation::makeCachedPositionCallbacks):
        (WebCore::Geolocation::haveSuitableCachedPosition):
        (WebCore::Geolocation::positionChangedInternal):
        * page/Geolocation.h:
        * page/GeolocationPositionCache.cpp:
        (WebCore::GeolocationPositionCache::instance):
        (WebCore::GeolocationPositionCache::GeolocationPositionCache):
        (WebCore::GeolocationPositionCache::addUser):
        (WebCore::GeolocationPositionCache::removeUser):
        (WebCore::GeolocationPositionCache::setDatabasePath):
        (WebCore::GeolocationPositionCache::setCachedPosition):
        (WebCore::GeolocationPositionCache::cachedPosition):
        (WebCore::GeolocationPositionCache::readFromDatabase):
        (WebCore::GeolocationPositionCache::writeToDatabase):
        * page/GeolocationPositionCache.h:
        (WebCore::GeolocationPositionCacheWrapper::GeolocationPositionCacheWrapper):
        (WebCore::GeolocationPositionCacheWrapper::~GeolocationPositionCacheWrapper):
        (WebCore::GeolocationPositionCacheWrapper::setCachedPosition):
        (WebCore::GeolocationPositionCacheWrapper::cachedPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-16 Yong Li <yoli@rim.com>
commit-queue@webkit.org [Fri, 17 Dec 2010 02:28:48 +0000 (02:28 +0000)]
2010-12-16  Yong Li  <yoli@rim.com>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=51199
        Add decoding tests for UTF-16 LE/BE and their variants.
        Also, check the full decoded text but not only the first one.

        * fast/encoding/char-decoding.html:
        * fast/encoding/char-decoding-expected.txt:
        * fast/encoding/resources/char-decoding-utils.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd svn:eol-style native to the message.in files as a favor to Darin Adler.
weinig@apple.com [Fri, 17 Dec 2010 02:20:48 +0000 (02:20 +0000)]
Add svn:eol-style native to the message.in files as a favor to Darin Adler.

Reviewed by Darin Adler.

* PluginProcess/PluginControllerProxy.messages.in: Added property svn:eol-style.
* PluginProcess/PluginProcess.messages.in: Added property svn:eol-style.
* PluginProcess/WebProcessConnection.messages.in: Added property svn:eol-style.
* Shared/Plugins/NPObjectMessageReceiver.messages.in: Added property svn:eol-style.
* UIProcess/Downloads/DownloadProxy.messages.in: Added property svn:eol-style.
* UIProcess/Plugins/PluginProcessProxy.messages.in: Added property svn:eol-style.
* UIProcess/WebContext.messages.in: Added property svn:eol-style.
* UIProcess/WebDatabaseManagerProxy.messages.in: Added property svn:eol-style.
* UIProcess/WebInspectorProxy.messages.in: Added property svn:eol-style.
* UIProcess/WebPageProxy.messages.in: Added property svn:eol-style.
* UIProcess/WebProcessProxy.messages.in: Added property svn:eol-style.
* WebProcess/Authentication/AuthenticationManager.messages.in: Added property svn:eol-style.
* WebProcess/Plugins/PluginProxy.messages.in: Added property svn:eol-style.
* WebProcess/WebCoreSupport/WebDatabaseManager.messages.in: Added property svn:eol-style.
* WebProcess/WebPage/WebInspector.messages.in: Added property svn:eol-style.
* WebProcess/WebPage/WebPage.messages.in: Added property svn:eol-style.
* WebProcess/WebProcess.messages.in: Added property svn:eol-style.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-16 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Fri, 17 Dec 2010 02:13:16 +0000 (02:13 +0000)]
2010-12-16  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Eric Seidel.

        Add --exit-after-n-failures/crashes to NRWT
        https://bugs.webkit.org/show_bug.cgi?id=51160

        Abort test run (in a similar way to how control-C is handled) when
        --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
        that number of unexpected failures/crashes/timeouts.

        * Scripts/webkitpy/layout_tests/port/test.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Updated chromium test expectations to mark
jianli@chromium.org [Fri, 17 Dec 2010 01:56:06 +0000 (01:56 +0000)]
Unreviewed. Updated chromium test expectations to mark
http/tests/appcache/fail-on-update-2.html as flaky with TIMEOUT.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-16 Evan Martin <evan@chromium.org>
evan@chromium.org [Fri, 17 Dec 2010 01:52:43 +0000 (01:52 +0000)]
2010-12-16  Evan Martin  <evan@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] useless warnings when building on Windows
        https://bugs.webkit.org/show_bug.cgi?id=50985

        Disable some compiler warnings that aren't indicative of real problems.

        * JavaScriptCore.gyp/JavaScriptCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-16 Ariya Hidayat <ariya@sencha.com>
ariya@webkit.org [Fri, 17 Dec 2010 01:44:53 +0000 (01:44 +0000)]
2010-12-16  Ariya Hidayat  <ariya@sencha.com>

        Reviewed by Andreas Kling.

        [Qt] GraphicsContext should respect QWebView render hints
        https://bugs.webkit.org/show_bug.cgi?id=51208

        GraphicsContext does not override SmoothPixmapTransform (see also
        r62762). To keep the same behavior, canvas default image interpolation
        quality is set to medium and QWebView's render hints by default also
        include SmoothPixmapTransform.

        * html/HTMLCanvasElement.h:
        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
2010-12-16  Ariya Hidayat  <ariya@sencha.com>

        Reviewed by Andreas Kling.

        [Qt] GraphicsContext should respect QWebView render hints
        https://bugs.webkit.org/show_bug.cgi?id=51208

        Add some checks to ensure that GraphicsContext (via QWebFrame)
        does not clobber the render hints.

        * Api/qwebview.cpp:
        (QWebViewPrivate::QWebViewPrivate):
        * tests/qwebframe/tst_qwebframe.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove NSURLCache initialization from the ProcessLauncherMac to the centralized
weinig@apple.com [Fri, 17 Dec 2010 00:29:49 +0000 (00:29 +0000)]
Move NSURLCache initialization from the ProcessLauncherMac to the centralized
WebContext initialize WebProcess mechanism.

Reviewed by Anders Carlsson.

* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::WebProcessCreationParameters):
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess):
* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformInitializeWebProcess):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
* WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
* WebProcess/mac/WebProcessMainMac.mm:
(WebKit::WebProcessMain):
* WebProcess/win/WebProcessWin.cpp:
(WebKit::WebProcess::platformInitializeWebProcess):
(WebKit::WebProcess::setShouldPaintNativeControls):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-16 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Thu, 16 Dec 2010 23:26:34 +0000 (23:26 +0000)]
2010-12-16  Daniel Bates  <dbates@rim.com>

        Formatting fix; un-indent one level all lines in [2793, 2808] (with respect to r74217)
        so as to be consistent with the formatting of the rest of this file.

        Also, add an empty line between the win32* and wince* conditional include blocks.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-16 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Thu, 16 Dec 2010 23:17:23 +0000 (23:17 +0000)]
2010-12-16  Daniel Bates  <dbates@rim.com>

        Reviewed by Antonio Gomes.

        [Qt] Only include ScrollAnimatorWin.h and compile ScrollAnimatorWin.cpp
        on Windows if ENABLE_SMOOTH_SCROLLING=1
        https://bugs.webkit.org/show_bug.cgi?id=51215

        Conditionally include the files ScrollAnimatorWin.h and ScrollAnimatorWin.cpp when building
        the Qt Windows with smooth scrolling enabled.

        No change in functionality since these files are guarded by ENABLE(SMOOTH_SCROLLING).

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-16 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 16 Dec 2010 23:12:51 +0000 (23:12 +0000)]
2010-12-16  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Cameron Zwarich.

        REGRESSION(r74172): 125 java tests fail on Mac
        https://bugs.webkit.org/show_bug.cgi?id=51214

        The regression was caused by an incorrectly adding sizeof(struct fat_header)
        to a pointer for uint32_t as supposed to uint8_t.

        Fixed the bug by explicitly casting it to uint8_t* before the addition.

        * Plugins/WebBasePluginPackage.mm:
        (-[WebBasePluginPackage isNativeLibraryData:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-16 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 16 Dec 2010 22:21:42 +0000 (22:21 +0000)]
2010-12-16  Xan Lopez  <xlopez@igalia.com>

        [GTK] fast/dom/gc-11.html fails in 64bit debug bot
        https://bugs.webkit.org/show_bug.cgi?id=51213

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-16 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 16 Dec 2010 22:08:01 +0000 (22:08 +0000)]
2010-12-16  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        execCommand('JustifyCenter') adds extra BR
        https://bugs.webkit.org/show_bug.cgi?id=51082

        The bug was caused by moveParagraphContentsToNewBlockIfNecessary's adding a placeholder br
        to new block and not removing it later. Fixed the bug by removing it when the paragraph
        moved into the block didn't have a br at the end.

        Test: editing/execCommand/justify.html

        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
2010-12-16  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        execCommand('JustifyCenter') adds extra BR
        https://bugs.webkit.org/show_bug.cgi?id=51082

        Added a test to ensure WebKit executes Justify* properly. In particular,
        this test ensures WebKit does not erroneously add a BR at the end of each block.

        * editing/execCommand/justify-expected.txt: Added.
        * editing/execCommand/justify.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Updated chromium test expectations.
jianli@chromium.org [Thu, 16 Dec 2010 22:06:37 +0000 (22:06 +0000)]
Unreviewed. Updated chromium test expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-16 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Thu, 16 Dec 2010 21:52:05 +0000 (21:52 +0000)]
2010-12-16  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed. Remove Chromium platform/chromium/accessibility
        expectations, that directory doesn't exist anymore as of r74039.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-16 Cosmin Truta <ctruta@chromium.org>
commit-queue@webkit.org [Thu, 16 Dec 2010 21:45:52 +0000 (21:45 +0000)]
2010-12-16  Cosmin Truta  <ctruta@chromium.org>

        Reviewed by Adam Roben.

        More rebaselining needed for new-run-webkit-tests update
        https://bugs.webkit.org/show_bug.cgi?id=51147

        Some cases were missed while rebaselining in bug 51018.

        * platform/chromium-mac/editing/execCommand/outdent-blockquote-test2-expected.txt:
        * platform/chromium-mac/editing/pasteboard/copy-standalone-image-expected.txt:
        * platform/chromium-mac/http/tests/misc/authentication-sent-to-redirect-expected.txt:
        * platform/chromium-mac/http/tests/security/cross-frame-access-get-override-expected.txt:
        * platform/chromium-mac/svg/custom/use-invalid-style-expected.txt:
        * platform/chromium-win/http/tests/misc/authentication-sent-to-redirect-expected.txt:
        * platform/chromium-win/platform/win/plugins/get-value-netscape-window-expected.txt:
        * platform/chromium/plugins/document-open-expected.txt: Added.
        * plugins/document-open-expected.txt: Rolled out change from r74097.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=51166
ggaren@apple.com [Thu, 16 Dec 2010 21:36:33 +0000 (21:36 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=51166
ExecutableAllocator::cacheFlush should call sys_cache_control

Patch by Pratik Solanki <psolanki@apple.com> on 2010-12-16
Reviewed by Geoffrey Garen.

* jit/ExecutableAllocator.h:
(JSC::ExecutableAllocator::cacheFlush): Use the more correct and forward looking API -
sys_cache_control(kCacheFunctionPrepareForExecution,...).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-16 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 16 Dec 2010 21:11:44 +0000 (21:11 +0000)]
2010-12-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Defer getting a PluginProcessConnection object until the plug-in is initialized
        https://bugs.webkit.org/show_bug.cgi?id=51207
        <rdar://problem/8731306>

        Before this change, we would pass the PluginProcessConnection to the PluginProxy constructor, but not
        call PluginProcessConnection::addPluginProxy (which associates the plug-in proxy with the connection)
        until the plug-in is initialized.

        This could lead to a PluginProxy holding a reference to a PluginProcessConnection when the PluginProxyConnection
        itself did not know anything about the PluginProxy. This would happen when a page with plug-ins is opened in a background
        tab, with the plug-ins not yet initialized.

        Because of this, we could end up in a weird state, where the PluginProcessConnection would think that there are no
        more plug-ins alive, and invalidate (and null out) the underlying CoreIPC connection, which would lead to crashes
        when trying to send messages to the connection during later initialization.

        The fix is to pass the plug-in path to the PluginProxy constructor, and get the connection from PluginProxy::initialize.

        PluginProcessConnection object
        * WebProcess/Plugins/PluginProxy.cpp:
        (WebKit::PluginProxy::create):
        (WebKit::PluginProxy::PluginProxy):
        (WebKit::PluginProxy::initialize):
        * WebProcess/Plugins/PluginProxy.h:
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::createPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Fixed chromium build break caused by r74207.
jianli@chromium.org [Thu, 16 Dec 2010 21:08:30 +0000 (21:08 +0000)]
Unreviewed. Fixed chromium build break caused by r74207.

* platform/ContextMenuItem.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-16 Leandro Pereira <leandro@profusion.mobi>
leandro@webkit.org [Thu, 16 Dec 2010 20:30:40 +0000 (20:30 +0000)]
2010-12-16  Leandro Pereira  <leandro@profusion.mobi>

        [EFL] Unreviewed build fix.

        Disable ContextMenu support for now while support for
        CROSS_PLATFORM_MENUS is written.

        * CMakeListsEfl.txt:
        * WebCoreSupport/ContextMenuClientEfl.cpp: Removed.
        * WebCoreSupport/ContextMenuClientEfl.h: Removed.
        * ewk/ewk_contextmenu.cpp:
        (ewk_context_menu_item_append):
        * ewk/ewk_view.cpp:
        (_ewk_view_priv_new):
2010-12-16  Leandro Pereira  <leandro@profusion.mobi>

        [EFL] Unreviewed build fix.

        Disable ContextMenu support for now while support for
        CROSS_PLATFORM_MENUS is written.

        * CMakeListsEfl.txt:
        * platform/ContextMenu.h:
        * platform/ContextMenuItem.h:
        * platform/efl/ContextMenuEfl.cpp:
        (WebCore::ContextMenu::ContextMenu):
        (WebCore::ContextMenu::getContextMenuItems):
        (WebCore::ContextMenu::createNativeMenuFromItems):
        (WebCore::ContextMenu::nativeMenu):
        * platform/efl/ContextMenuItemEfl.cpp:
        (WebCore::ContextMenuItem::ContextMenuItem):
        (WebCore::ContextMenuItem::~ContextMenuItem):
        (WebCore::ContextMenuItem::nativeMenuItem):
        (WebCore::ContextMenuItem::type):
        (WebCore::ContextMenuItem::setAction):
        (WebCore::ContextMenuItem::action):
        (WebCore::ContextMenuItem::setChecked):
        (WebCore::ContextMenuItem::checked):
        (WebCore::ContextMenuItem::setEnabled):
        (WebCore::ContextMenuItem::enabled):
        (WebCore::ContextMenuItem::setSubMenu):
2010-12-16  Leandro Pereira  <leandro@profusion.mobi>

        [EFL] Unreviewed build fix.

        Disable ContextMenu support for now while support for
        CROSS_PLATFORM_MENUS is written.

        * cmake/OptionsEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebKit2: Cannot copy two successive selections using cmd-c
enrica@apple.com [Thu, 16 Dec 2010 20:18:42 +0000 (20:18 +0000)]
WebKit2: Cannot copy two successive selections using cmd-c
<rdar://problem/8680309>
https://bugs.webkit.org/show_bug.cgi?id=51203

Reviewed by Maciej Stachowiak.

The previous implementation assumed a call sequence from AppKit that
was not always happening.
When the user clicks on the pulldown menu, AppKit sends validateUserInterfaceItem
calls for each element that needs validation and we used to count the number of
validation requests being sent to the web process.
All these calls are made before we have the chance to get one reply from the WebProcess.
We also delayed the menu update until we had received all the replies to the validation requests.
At that point we called update on the menu to trigger the validation one more time with
the data retrived from the WebProcess.
When the user simply presses cmd-c, only one call to vaidateUserInterfaceItem is made
and the menu update triggered the validation of all the menu entries causing the internal
state to be out of sync.
The new implementation is very simple: for each validation request from AppKit we send
a request to the WebProcess and we cache a reference to the menu item being validated.
When the WebProcess replies, we retrieve the menu item from our cache and update its state.

* UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:contextRef:pageGroupRef:]): Removed initialization of deleted memebers.
(-[WKView validateUserInterfaceItem:]): Request validation to the WebProcess and return YES to
allow AppKit to do the keyBinding processing.
(-[WKView _setUserInterfaceItemState:enabled:state:]): Called when the WebProcess replies to the
validation request to check/uncheck and enable/disable the menu item.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDon't try to call plug-in member functions if the plug-in hasn't been initialized
andersca@apple.com [Thu, 16 Dec 2010 20:07:41 +0000 (20:07 +0000)]
Don't try to call plug-in member functions if the plug-in hasn't been initialized
https://bugs.webkit.org/show_bug.cgi?id=51205
<rdar://problem/8730204>

Reviewed by Oliver Hunt.

Make sure that all PluginView functions that can be called while a plug-in has not been
initialized (if the plug-in page is in a background tab for example) have an additional
check for m_isInitialized.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::setWindowIsFocused):
(WebKit::PluginView::windowAndViewFramesChanged):
(WebKit::PluginView::platformLayer):
(WebKit::PluginView::scriptObject):
(WebKit::PluginView::privateBrowsingStateChanged):
(WebKit::PluginView::handleEvent):
(WebKit::PluginView::viewGeometryDidChange):
(WebKit::PluginView::setFocus):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-16 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 16 Dec 2010 20:01:57 +0000 (20:01 +0000)]
2010-12-16  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        execCommand('styleWithCSS') is ignored when selection isn't inside a contenteditable area
        https://bugs.webkit.org/show_bug.cgi?id=51164

        Fixed the bug by always enabling the StyleWithCSS command.

        Test: editing/style/stylewithcss-without-selection.html

        * editing/EditorCommand.cpp:
        (WebCore::createCommandMap): StyleWithCSS is enabled rather than enabledInRichlyEditableText.
2010-12-16  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        execCommand('styleWithCSS') is ignored when selection isn't inside a contenteditable area
        https://bugs.webkit.org/show_bug.cgi?id=51164

        Added a test to ensure WebKit accepts StyleWithCSS command even if the current selection
        isn't inside a contenteditable region.

        * editing/style/stylewithcss-without-selection-expected.txt: Added.
        * editing/style/stylewithcss-without-selection.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a bunch of m_isStarted assertions to plug-in code.
andersca@apple.com [Thu, 16 Dec 2010 19:45:37 +0000 (19:45 +0000)]
Add a bunch of m_isStarted assertions to plug-in code.

Reviewed by John Sullivan.

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::frameDidFinishLoading):
(WebKit::NetscapePlugin::frameDidFail):
(WebKit::NetscapePlugin::didEvaluateJavaScript):
(WebKit::NetscapePlugin::streamDidReceiveResponse):
(WebKit::NetscapePlugin::streamDidReceiveData):
(WebKit::NetscapePlugin::streamDidFinishLoading):
(WebKit::NetscapePlugin::streamDidFail):
(WebKit::NetscapePlugin::manualStreamDidReceiveResponse):
(WebKit::NetscapePlugin::manualStreamDidReceiveData):
(WebKit::NetscapePlugin::manualStreamDidFinishLoading):
(WebKit::NetscapePlugin::manualStreamDidFail):
(WebKit::NetscapePlugin::handleMouseEvent):
(WebKit::NetscapePlugin::handleWheelEvent):
(WebKit::NetscapePlugin::handleMouseEnterEvent):
(WebKit::NetscapePlugin::handleMouseLeaveEvent):
(WebKit::NetscapePlugin::handleKeyboardEvent):
(WebKit::NetscapePlugin::setFocus):
(WebKit::NetscapePlugin::pluginScriptableNPObject):
(WebKit::NetscapePlugin::privateBrowsingStateChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSave the manual plug-in stream data and redeliver it when the plug-in is initialized
andersca@apple.com [Thu, 16 Dec 2010 19:37:44 +0000 (19:37 +0000)]
Save the manual plug-in stream data and redeliver it when the plug-in is initialized
https://bugs.webkit.org/show_bug.cgi?id=51201

Reviewed by Darin Adler.

WebCore:

Export SharedBuffer related symbols.

* WebCore.exp.in:

WebKit2:

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::PluginView):
Initialize m_manualStreamState.

(WebKit::PluginView::manualLoadDidReceiveResponse):
If the plug-in hasn't been initialized, store the response.

(WebKit::PluginView::manualLoadDidReceiveData):
If the plug-in hasn't been initialized, store the data.

(WebKit::PluginView::manualLoadDidFinishLoading):
If the plug-in hasn't been initialized, update the state.

(WebKit::PluginView::manualLoadDidFail):
If the plug-in hasn't been initialized, store the error and update the state.

(WebKit::PluginView::initializePlugin):
Call redeliverManualStream.

(WebKit::PluginView::redeliverManualStream):
Redeliver the manual stream to the plug-in.

* WebProcess/Plugins/PluginView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-16 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>
andreas.kling@nokia.com [Thu, 16 Dec 2010 18:56:55 +0000 (18:56 +0000)]
2010-12-16  Kimmo Kinnunen  <kimmo.t.kinnunen@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Turn off drawing area updates if the item is not visible

        The updates are controlled by the QGraphicsItem::visible property.

        * UIProcess/API/qt/qgraphicswkview.cpp:
        (QGraphicsWKViewPrivate::updateViewportSize):
        (QGraphicsWKView::setGeometry):
        (QGraphicsWKView::itemChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-16 David Levin <levin@chromium.org>
levin@chromium.org [Thu, 16 Dec 2010 18:45:43 +0000 (18:45 +0000)]
2010-12-16  David Levin  <levin@chromium.org>

        Reviewed by Shinichiro Hamaji.

        check-webkit-style unit tests has some duplicate boilerplate code.
        https://bugs.webkit.org/show_bug.cgi?id=49519

        * Scripts/webkitpy/style/checkers/cpp.py:
        (update_include_state): Replaced the "io" parameter with the global
        configuration _unit_test_config. This allowed not calling into
        functions at a low level and also not plumbing through the injection
        information through many levels of code.
        (check_for_include_what_you_use): Ditto.
        (process_file_data): Added the ability to set up the unit test config
        to allow for injection.
        * Scripts/webkitpy/style/checkers/cpp_unittest.py:
        (ErrorCollector.__init__): Added support for having a filter for errors.
        (ErrorCollector.__call__): Ditto.
        (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
        (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
        (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
        functions in the cpp.py with generic processing and a filter that
        indicates what errors should be kept.
        (CppStyleTestBase.perform_multi_line_lint): Ditto.
        (CppStyleTestBase.perform_language_rules_check): Ditto.
        (CppStyleTestBase.perform_function_lengths_check): Ditto.
        (CppStyleTestBase.perform_pass_ptr_check): Ditto.
        (CppStyleTestBase.perform_include_what_you_use): Ditto.
        (CppStyleTest.test_multi_line_comments): Added another
        error message which applies to the test case.
        (CppStyleTest.test_spacing_for_binary_ops): Fixed test
        to not have config.h, since it is processed as a header file.
        (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
        style and indentation in checked code.
        (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
        Fixed line number.
        (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
        Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCorrecting Radar number.
ap@apple.com [Thu, 16 Dec 2010 18:06:25 +0000 (18:06 +0000)]
Correcting Radar number.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-16 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 16 Dec 2010 18:01:16 +0000 (18:01 +0000)]
2010-12-16  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: timeline records should only operate WebCore time.
        https://bugs.webkit.org/show_bug.cgi?id=51127

        * inspector/InspectorTimelineAgent.cpp:
        (WebCore::InspectorTimelineAgent::didFinishLoadingResource):
        * inspector/TimelineRecordFactory.cpp:
        (WebCore::TimelineRecordFactory::createResourceFinishData):
        * inspector/TimelineRecordFactory.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago Reviewed by Darin Adler.
ap@apple.com [Thu, 16 Dec 2010 17:54:22 +0000 (17:54 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=50996
        <rdar://problem/8086718> Consider disabling DNS prefetch when proxy is used

        No new tests, cannot test DNS.

        * platform/network/cf/DNSCFNet.cpp:
        (WebCore::proxyIsEnabledInSystemPreferences): Check if accessing example.com is going to use
        a proxy. This is only an estimate - even with a proxy is configured in system preferences, an
        actual request can go directly to the host if a PAC script says so.
        (WebCore::DNSResolveQueue::add): Check if proxy is enabled when sending immediate requests.
        (WebCore::DNSResolveQueue::fired): Ditto when sending queued ones.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74197 268f45cc-cd09-0410-ab3c-d52691b4dbfc