WebKit-https.git
6 years ago[Curl] Cookies are sometimes not set in download request.
commit-queue@webkit.org [Wed, 30 Oct 2013 17:31:40 +0000 (17:31 +0000)]
[Curl] Cookies are sometimes not set in download request.
https://bugs.webkit.org/show_bug.cgi?id=123445

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-10-30
Reviewed by Brent Fulgham.

Sometimes cookies are not set in the download request because the cookie file cannot be opened,
it's already been opened by the ResourceHandleManager for writing.
This can be fixed by getting the cookie list from the share handle in ResourceHandleManager instead.
This will also improve performance, as there is no need to read and parse the cookie file for each download.

* platform/network/curl/CurlDownload.cpp:
(WebCore::CurlDownload::init): Use share handle to get cookie list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Curl][Win] Suggested filename of download is not url decoded.
commit-queue@webkit.org [Wed, 30 Oct 2013 17:29:32 +0000 (17:29 +0000)]
[Curl][Win] Suggested filename of download is not url decoded.
https://bugs.webkit.org/show_bug.cgi?id=123511

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-10-30
Reviewed by Brent Fulgham.

* WebDownloadCurl.cpp:
(WebDownload::didReceiveResponse): Url decode suggested filename.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnguard Element::childShouldCreateRenderer
changseok.oh@collabora.com [Wed, 30 Oct 2013 17:21:10 +0000 (17:21 +0000)]
Unguard Element::childShouldCreateRenderer
https://bugs.webkit.org/show_bug.cgi?id=123496

Reviewed by Andreas Kling.

Make Element::childShouldCreateRenderer normally accessible. Guarding it with flags
just leaves potential build issues.

No new tests since no functionality changed.

* dom/Element.cpp:
(WebCore::Element::childShouldCreateRenderer):
* dom/Element.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd stubbed out WKRemoteObjectRegistry class
andersca@apple.com [Wed, 30 Oct 2013 16:44:21 +0000 (16:44 +0000)]
Add stubbed out WKRemoteObjectRegistry class
https://bugs.webkit.org/show_bug.cgi?id=123512

Reviewed by Andreas Kling.

Also add a WKRemoteObjectInterface class that represents a remote object interface.

* Shared/API/Cocoa/WKRemoteObjectInterface.h: Added.
* Shared/API/Cocoa/WKRemoteObjectInterface.mm: Added.
(-[WKRemoteObjectInterface initWithProtocol:identifier:]):
(+[WKRemoteObjectInterface remoteObjectInterfaceWithProtocol:]):
* Shared/API/Cocoa/WKRemoteObjectRegistry.h: Added.
* Shared/API/Cocoa/WKRemoteObjectRegistry.mm: Added.
(-[WKRemoteObjectRegistry registerExportedObject:interface:]):
(-[WKRemoteObjectRegistry unregisterExportedObject:interface:]):
(-[WKRemoteObjectRegistry remoteObjectProxyWithInterface:]):
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] accessibility/textarea-selected-text-range.html is failing
commit-queue@webkit.org [Wed, 30 Oct 2013 16:06:07 +0000 (16:06 +0000)]
[EFL] accessibility/textarea-selected-text-range.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112016

Patch by Robert Plociennik <r.plociennik@samsung.com> on 2013-10-30
Reviewed by Mario Sanchez Prada.

Tools:

Provided implementation for AccessibilityUIElement::selectedTextRange() and
AccessibilityUIElement::setSelectedTextRange().

* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::selectedTextRange): Implemented.
(AccessibilityUIElement::setSelectedTextRange): Implemented
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::selectedTextRange): Implemented.
(WTR::AccessibilityUIElement::setSelectedTextRange): Implemented.

LayoutTests:

Removed failure expectations.

* platform/efl-wk1/TestExpectations: The test is no longer failing.
* platform/efl-wk2/TestExpectations: The test is no longer failing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDisabled JIT on Win64.
alex.christensen@flexsim.com [Wed, 30 Oct 2013 16:05:40 +0000 (16:05 +0000)]
Disabled JIT on Win64.
https://bugs.webkit.org/show_bug.cgi?id=122472

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
Disabled building JITStubsMSVC64.

Source/WebKit:

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Added missing 64-bit linker symbol.

Source/WTF:

* wtf/Platform.h:
Disabled JIT on Win64.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] accessibility/svg-remote-element.html is failing
commit-queue@webkit.org [Wed, 30 Oct 2013 16:01:06 +0000 (16:01 +0000)]
[EFL] accessibility/svg-remote-element.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112013

Unreviewed EFL gardening. Passes after r158267.

Patch by Robert Plociennik <r.plociennik@samsung.com> on 2013-10-30

* platform/efl-wk1/TestExpectations: The test is no longer failing.
* platform/efl-wk2/TestExpectations: The test is no longer failing.
* platform/efl/accessibility/svg-remote-element-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[MSE] Make MediaSourcePrivate, SourceBufferPrivate classes RefCounted.
jer.noble@apple.com [Wed, 30 Oct 2013 15:53:49 +0000 (15:53 +0000)]
[MSE] Make MediaSourcePrivate, SourceBufferPrivate classes RefCounted.
https://bugs.webkit.org/show_bug.cgi?id=123350

Reviewed by Darin Adler.

Make the MediaSourcePrivate and SourceBufferPrivate classes RefCounted so that
they can be referenced both by MediaSource/SourceBuffer, and by the MediaPlayerPrivate
which creates them.

Change OwnPtr -> RefPtr everywhere:
* Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::addSourceBuffer):
* Modules/mediasource/MediaSourceBase.cpp:
(WebCore::MediaSourceBase::setPrivateAndOpen):
(WebCore::MediaSourceBase::createSourceBufferPrivate):
* Modules/mediasource/MediaSourceBase.h:
* Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::create):
(WebCore::SourceBuffer::SourceBuffer):
* Modules/mediasource/SourceBuffer.h:
* Modules/mediasource/WebKitMediaSource.cpp:
(WebCore::WebKitMediaSource::addSourceBuffer):
* Modules/mediasource/WebKitSourceBuffer.cpp:
(WebCore::WebKitSourceBuffer::create):
(WebCore::WebKitSourceBuffer::WebKitSourceBuffer):
* Modules/mediasource/WebKitSourceBuffer.h:
* html/HTMLMediaSource.h:
* platform/graphics/MediaSourcePrivate.h:
* platform/graphics/SourceBufferPrivate.h:
(WebCore::SourceBufferPrivate::SourceBufferPrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove unused runtime enabled
allan.jensen@digia.com [Wed, 30 Oct 2013 15:50:58 +0000 (15:50 +0000)]
Remove unused runtime enabled
https://bugs.webkit.org/show_bug.cgi?id=123509

Reviewed by Anders Carlsson.

Some of the runtime enabled features were only ever used by the V8 bindings
and can be removed as no WebKit code sets or reads them.

* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):
* bindings/generic/RuntimeEnabledFeatures.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMake SimpleLineLayout::Layout a class
antti@apple.com [Wed, 30 Oct 2013 14:12:32 +0000 (14:12 +0000)]
Make SimpleLineLayout::Layout a class
https://bugs.webkit.org/show_bug.cgi?id=123508

Reviewed by Mario Sanchez Prada.

Improve encapsulation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] accessibility/svg-remote-element.html is failing
commit-queue@webkit.org [Wed, 30 Oct 2013 12:34:42 +0000 (12:34 +0000)]
[GTK] accessibility/svg-remote-element.html is failing
https://bugs.webkit.org/show_bug.cgi?id=101185

Patch by Robert Plociennik <r.plociennik@samsung.com> on 2013-10-30
Reviewed by Chris Fleizach.

Tools:

Implemented missing methods by mimicing existing functionality in
AccessibilityObject::clickPoint() using available ATK API.

* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::clickPointX): Implemented.
(AccessibilityUIElement::clickPointY): Implemented.
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::clickPointX): Implemented.
(WTR::AccessibilityUIElement::clickPointY): Implemented.

LayoutTests:

Provided new test expectations since resulting discrepancies are believed to be
platform related.

* platform/gtk-wk2/TestExpectations: The test is no longer failing.
* platform/gtk/accessibility/svg-remote-element-expected.txt: Added.
* platform/gtk/TestExpectations: The test is no longer failing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemoved Windows platform configurations from WebKitTestRunner.
commit-queue@webkit.org [Wed, 30 Oct 2013 11:31:46 +0000 (11:31 +0000)]
Removed Windows platform configurations from WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=123152

Patch by Tamas Gergely <gertom@inf.u-szeged.hu> on 2013-10-30
Reviewed by Csaba Osztrogon√°c.

Removed Windows specific parts from the source files, Windows specific
subdirectory (win) and Visual Studio property files from the WebKitTestRunner,
as the platform is no longer supported by this tool.

* WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Removed.
* WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Removed.
* WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops: Removed.
* WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Removed.
* WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Removed.
* WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Removed.
* WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Removed.
* WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
(WTR::AccessibilityController::rootElement):
(WTR::AccessibilityController::focusedElement):
* WebKitTestRunner/InjectedBundle/AccessibilityController.h:
* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
* WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
* WebKitTestRunner/InjectedBundle/TestRunner.h:
* WebKitTestRunner/PlatformWebView.h:
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
* WebKitTestRunner/TestInvocation.cpp:
(WTR::createWKURL):
* WebKitTestRunner/cg/TestInvocationCG.cpp:
* WebKitTestRunner/config.h:
* WebKitTestRunner/win/InjectedBundle.vcproj: Removed.
* WebKitTestRunner/win/InjectedBundleDebug.vsprops: Removed.
* WebKitTestRunner/win/InjectedBundleDebugAll.vsprops: Removed.
* WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops: Removed.
* WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Removed.
* WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Removed.
* WebKitTestRunner/win/InjectedBundlePostBuild.cmd: Removed.
* WebKitTestRunner/win/InjectedBundlePreBuild.cmd: Removed.
* WebKitTestRunner/win/InjectedBundleProduction.vsprops: Removed.
* WebKitTestRunner/win/InjectedBundleRelease.vsprops: Removed.
* WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops: Removed.
* WebKitTestRunner/win/PlatformWebViewWin.cpp: Removed.
* WebKitTestRunner/win/TestControllerWin.cpp: Removed.
* WebKitTestRunner/win/TestInvocationWin.cpp: Removed.
* WebKitTestRunner/win/WebKitTestRunner.vcproj: Removed.
* WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops: Removed.
* WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops: Removed.
* WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops: Removed.
* WebKitTestRunner/win/WebKitTestRunnerLauncher.vcproj: Removed.
* WebKitTestRunner/win/WebKitTestRunnerLauncherCommon.vsprops: Removed.
* WebKitTestRunner/win/WebKitTestRunnerLauncherDebug.vsprops: Removed.
* WebKitTestRunner/win/WebKitTestRunnerLauncherDebugAll.vsprops: Removed.
* WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops: Removed.
* WebKitTestRunner/win/WebKitTestRunnerLauncherProduction.vsprops: Removed.
* WebKitTestRunner/win/WebKitTestRunnerLauncherRelease.vsprops: Removed.
* WebKitTestRunner/win/WebKitTestRunnerLauncherReleaseCairoCFLite.vsprops: Removed.
* WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd: Removed.
* WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd: Removed.
* WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops: Removed.
* WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops: Removed.
* WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops: Removed.
* WebKitTestRunner/win/build-generated-files.sh: Removed.
* WebKitTestRunner/win/main.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION(r158214): It made zillion tests crash on GTK and EFL
antti@apple.com [Wed, 30 Oct 2013 11:16:10 +0000 (11:16 +0000)]
REGRESSION(r158214): It made zillion tests crash on GTK and EFL
https://bugs.webkit.org/show_bug.cgi?id=123505

* rendering/SimpleLineLayout.h: Add WTF_MAKE_FAST_ALLOCATED

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Remove efl/accessibility/image-map1-expected.txt after r158104
commit-queue@webkit.org [Wed, 30 Oct 2013 10:39:22 +0000 (10:39 +0000)]
[EFL] Remove efl/accessibility/image-map1-expected.txt after r158104
https://bugs.webkit.org/show_bug.cgi?id=123504

Unreviewed EFL gardening.

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-10-30

* platform/efl/accessibility/image-map1-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRevert r158259 for EFL and GTK+. They're still failing everywhere according to the...
rniwa@webkit.org [Wed, 30 Oct 2013 08:50:15 +0000 (08:50 +0000)]
Revert r158259 for EFL and GTK+. They're still failing everywhere according to the flakiness dashboard.

* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRevert r158259 for Mac. They're definitely failing on Mac.
rniwa@webkit.org [Wed, 30 Oct 2013 08:45:06 +0000 (08:45 +0000)]
Revert r158259 for Mac. They're definitely failing on Mac.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd more test expectations for the bug 121452.
rniwa@webkit.org [Wed, 30 Oct 2013 08:40:52 +0000 (08:40 +0000)]
Add more test expectations for the bug 121452.

fast/frames/lots-of-objects.html is failing on Mavericks WebKit2 builders in addition to Debug builders.

fast/frames/lots-of-iframes.html is also failing on the exactly same set of builders.

* platform/mac-wk2/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] webkit_web_context_allow_tls_certificate_for_host doc is missing Since tag
carlosgc@webkit.org [Wed, 30 Oct 2013 08:31:11 +0000 (08:31 +0000)]
[GTK] webkit_web_context_allow_tls_certificate_for_host doc is missing Since tag
https://bugs.webkit.org/show_bug.cgi?id=123499

Reviewed by Philippe Normand.

* UIProcess/API/gtk/WebKitWebContext.cpp: Add Since: 2.4.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Removed some grid layout tests that are passing now.
svillar@igalia.com [Wed, 30 Oct 2013 08:17:17 +0000 (08:17 +0000)]
Unreviewed. Removed some grid layout tests that are passing now.

* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GStreamer] Store video-sink in a bin
philn@webkit.org [Wed, 30 Oct 2013 08:04:02 +0000 (08:04 +0000)]
[GStreamer] Store video-sink in a bin
https://bugs.webkit.org/show_bug.cgi?id=122831

Reviewed by Gustavo Noronha Silva.

For the upcoming mediastream playback support the player will
handle a non-playbin-based pipeline that will require a slightly
different video rendering chain. This patch generalizes the
encapsulation of the video sink in a bin, just like the audio sink
case.

No new tests, no change in functionality.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMore Mavericks specific test expectation updates.
rniwa@webkit.org [Wed, 30 Oct 2013 06:58:12 +0000 (06:58 +0000)]
More Mavericks specific test expectation updates.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoResult of focus-option-control-on-page.html depends on system preferences
ap@apple.com [Wed, 30 Oct 2013 06:53:32 +0000 (06:53 +0000)]
Result of focus-option-control-on-page.html depends on system preferences
https://bugs.webkit.org/show_bug.cgi?id=123304

Reviewed by Simon Fraser.

Source/WebKit/mac:

* WebView/WebView.mm: (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
Read the preference from its correct domain. This doesn't affect behavior in practice
and isn't part of the fix, but it's a good opportunity to correct this code.

Source/WebKit2:

* UIProcess/mac/WKFullKeyboardAccessWatcher.mm:
(-[WKFullKeyboardAccessWatcher retrieveKeyboardUIModeFromPreferences:]):
Read the preference from its correct domain. This doesn't affect behavior in practice
and isn't part of the fix, but it's a good opportunity to correct this code.

Tools:

* DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
Override a preference that WebKit reads to decide what Tab does, so that current
user default doesn't affect tests.

* WebKitTestRunner/mac/main.mm: (setDefaultsToConsistentValuesForTesting):
Ditto.

LayoutTests:

* platform/mac/TestExpectations: Remove Pass/Failure expectations, this test
should always pass now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoIt should be possible to specify extra tests to run-javascriptcore-tests
fpizlo@apple.com [Wed, 30 Oct 2013 06:03:11 +0000 (06:03 +0000)]
It should be possible to specify extra tests to run-javascriptcore-tests
https://bugs.webkit.org/show_bug.cgi?id=123495

Reviewed by Oliver Hunt.

This adds two ways to specify additional tests: the option --extra-tests=<blah>, and
the environment variable EXTRA_JSC_TESTS.

Those two values (the command-line option and the environment variable) are passed
as extra arguments to run-jsc-stress-tests.

To make this extra super useful, run-jsc-stress-tests now allows yaml configuration
files to be recursive: if a "- collection:" line is found, the string is handled
just as if it was a command-line argument. This allows you to use --extra-tests=file
where file contains a bunch of "- collection:" lines, and this is equivalent to each
of those lines being a command-line argument.

* Scripts/run-javascriptcore-tests:
* Scripts/run-jsc-stress-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION(r154614): Opening and closing a picture on Facebook resets scroll position
rniwa@webkit.org [Wed, 30 Oct 2013 05:39:37 +0000 (05:39 +0000)]
REGRESSION(r154614): Opening and closing a picture on Facebook resets scroll position
https://bugs.webkit.org/show_bug.cgi?id=122882

Reviewed by Anders Carlsson.

Source/WebCore:

scrollLeft and scrollTop have to continue to function in the strict mode for the Web compatiblity.
In particular, www.facebook.com and build.webkit.org depend on this behavior as of October 29th, 2013.

* html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::scrollLeft):
(WebCore::HTMLBodyElement::setScrollLeft):
(WebCore::HTMLBodyElement::scrollTop):
(WebCore::HTMLBodyElement::setScrollTop):

LayoutTests:

* fast/dom/Element/body-scrollLeft-expected.txt:
* fast/dom/Element/body-scrollLeft.html:
* fast/dom/Element/body-scrollTop-expected.txt:
* fast/dom/Element/body-scrollTop.html:
* fast/dom/Element/scrollLeft-expected.txt:
* fast/dom/Element/scrollLeft.html:
* fast/dom/Element/scrollTop-expected.txt:
* fast/dom/Element/scrollTop.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoIDBTransactionBackend should be cross platform
beidson@apple.com [Wed, 30 Oct 2013 05:33:04 +0000 (05:33 +0000)]
IDBTransactionBackend should be cross platform
https://bugs.webkit.org/show_bug.cgi?id=123449

Reviewed by Beth Dakin.

- Rename IDBTransactionBackendLevelDB to IDBTransactionBackendImpl
- Rename IDBTransactionBackendLevelDBOperations to IDBTransactionBackendOperations
- Move their files from the leveldb subdirectory to the indexeddb directory

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.xcodeproj/project.pbxproj:

* Modules/indexeddb/IDBTransactionBackendImpl.cpp: Renamed from Source/WebCore/Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.cpp.
* Modules/indexeddb/IDBTransactionBackendImpl.h: Renamed from Source/WebCore/Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.h.
* Modules/indexeddb/IDBTransactionBackendOperations.cpp: Renamed from Source/WebCore/Modules/indexeddb/leveldb/IDBTransactionBackendLevelDBOperations.cpp.
* Modules/indexeddb/IDBTransactionBackendOperations.h: Renamed from Source/WebCore/Modules/indexeddb/leveldb/IDBTransactionBackendLevelDBOperations.h.

* Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.cpp:
* Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.h:
* Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:
(WebCore::IDBFactoryBackendLevelDB::maybeCreateTransactionBackend):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoModernize DatasetDOMStringMap and ClassList a bit
commit-queue@webkit.org [Wed, 30 Oct 2013 05:15:27 +0000 (05:15 +0000)]
Modernize DatasetDOMStringMap and ClassList a bit
https://bugs.webkit.org/show_bug.cgi?id=123491

Patch by Sam Weinig <sam@webkit.org> on 2013-10-29
Reviewed by Andreas Kling.

* dom/DatasetDOMStringMap.cpp:
* dom/DatasetDOMStringMap.h:
* dom/Element.cpp:
* dom/ElementRareData.h:
* html/ClassList.cpp:
* html/ClassList.h:
Pass the owner Element by reference and store in a std::unique_ptr.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAttempted build-fix after http://trac.webkit.org/changeset/158234
beidson@apple.com [Wed, 30 Oct 2013 04:34:30 +0000 (04:34 +0000)]
Attempted build-fix after trac.webkit.org/changeset/158234

* Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
(WebCore::IDBBackingStoreLevelDB::createBackingStoreTransaction): Implement this!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoElementData construction helpers should return PassRef.
akling@apple.com [Wed, 30 Oct 2013 04:15:55 +0000 (04:15 +0000)]
ElementData construction helpers should return PassRef.
<https://webkit.org/b/123487>

Make functions that create new ElementData objects return appropriate
PassRef pointers instead of PassRefPtr.

Reviewed by Anders Carlsson.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoGTK+ build fix attempt after r158220.
rniwa@webkit.org [Wed, 30 Oct 2013 03:57:25 +0000 (03:57 +0000)]
GTK+ build fix attempt after r158220.

* GNUmakefile.list.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate Mavericks test expectation, tracked by bugs 123489 and 123490.
rniwa@webkit.org [Wed, 30 Oct 2013 03:53:10 +0000 (03:53 +0000)]
Update Mavericks test expectation, tracked by bugs 123489 and 123490.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd Mavericks builders to the old flakiness dashboard.
rniwa@webkit.org [Wed, 30 Oct 2013 03:52:23 +0000 (03:52 +0000)]
Add Mavericks builders to the old flakiness dashboard.

* TestResultServer/static-dashboards/builders.jsonp:
* TestResultServer/static-dashboards/flakiness_dashboard.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove IDBTransactionBackendLevelDB to generic IDBBackingStoreInterface
beidson@apple.com [Wed, 30 Oct 2013 03:11:38 +0000 (03:11 +0000)]
Move IDBTransactionBackendLevelDB to generic IDBBackingStoreInterface
https://bugs.webkit.org/show_bug.cgi?id=123483

Reviewed by Andreas Kling.

Source/WebCore:

* Modules/indexeddb/IDBCursorBackendInterface.h:
* Modules/indexeddb/IDBDatabaseBackendImpl.h:
* Modules/indexeddb/IDBDatabaseBackendInterface.h:
* Modules/indexeddb/IDBFactoryBackendInterface.h:
* Modules/indexeddb/IDBTransactionBackendInterface.h:

* Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.cpp:
(WebCore::IDBCursorBackendLevelDB::IDBCursorBackendLevelDB):
* Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.h:
(WebCore::IDBCursorBackendLevelDB::create):

* Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:
(WebCore::IDBFactoryBackendLevelDB::createCursorBackend):
* Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h:

* Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.cpp:
(WebCore::IDBTransactionBackendLevelDB::registerOpenCursor):
(WebCore::IDBTransactionBackendLevelDB::unregisterOpenCursor):
(WebCore::IDBTransactionBackendLevelDB::closeOpenCursors):
(WebCore::IDBTransactionBackendLevelDB::createCursorBackend):
* Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.h:

* WebCore.xcodeproj/project.pbxproj: Export a required header.

Source/WebKit2:

* WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:
(WebKit::WebIDBFactoryBackend::createCursorBackend): Stubbed out.
* WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h:

* WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.cpp:
(WebKit::WebProcessIDBDatabaseBackend::factoryBackend): Stubbed out.
* WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoStringImpl::isolatedCopy() should return PassRef.
akling@apple.com [Wed, 30 Oct 2013 03:05:20 +0000 (03:05 +0000)]
StringImpl::isolatedCopy() should return PassRef.
<https://webkit.org/b/123484>

Make isolatedCopy() return a PassRef<StringImpl>.

Reviewed by Anders Carlsson.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove mutable keyword from member variables of XMLHttpRequest
seokju@webkit.org [Wed, 30 Oct 2013 02:40:06 +0000 (02:40 +0000)]
Remove mutable keyword from member variables of XMLHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=123481

Reviewed by Andreas Kling.

No new tests, no change in functionality.

* xml/XMLHttpRequest.h: Remove mutable keyword as these are no longer used in const functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnderline bounds cannot be queried before underline itself is drawn
commit-queue@webkit.org [Wed, 30 Oct 2013 01:51:17 +0000 (01:51 +0000)]
Underline bounds cannot be queried before underline itself is drawn
https://bugs.webkit.org/show_bug.cgi?id=123310

Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-10-29
Reviewed by Simon Fraser

GraphicsContext's drawLineForText function is used to draw underlines,
strikethroughs, and overlines. Before drawing the line, this function
modifies the bounds given to it in order to make underlines crisp. However,
this means that it is impossible to know where an underline will be drawn
before drawing it. This patch pulls out this adjustment computation into
InlineTextBox, then passes the result to drawLineForText.

Because there should be no observable difference, no tests need to be updated.

* platform/graphics/GraphicsContext.h: Changing the signature of drawLineForText
so it can accept bounds from our helper function
* platform/graphics/blackberry/PathBlackBerry.cpp:
(WebCore::GraphicsContext::drawLineForText): Update to work with new
signature of drawLineForText
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawLineForText): Ditto
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawLineForText): Ditto
* platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::GraphicsContext::drawLineForText): Ditto
* platform/win/WebCoreTextRenderer.cpp:
(WebCore::doDrawTextAtPoint): Update the last call site of drawLineForText
* rendering/InlineTextBox.cpp:
(WebCore::computeBoundsForUnderline): Pure function that computes the adjusted
bounds of the underline about to be drawn
(WebCore::drawLineForText): calls computeBoundsForUnderline and then
GraphicsContext::drawLineForText
(WebCore::InlineTextBox::paintDecoration): Use new drawLineForText function
(WebCore::InlineTextBox::paintCompositionUnderline): Ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION(r158198): editing/execCommand/insert-list-xml.xhtml fails
bfulgham@apple.com [Wed, 30 Oct 2013 00:58:22 +0000 (00:58 +0000)]
REGRESSION(r158198): editing/execCommand/insert-list-xml.xhtml fails
https://bugs.webkit.org/show_bug.cgi?id=123460

Reviewed by Ryosuke Niwa.

The original version of this test used a MathML document root,
and attempted to add HTML content to prove that a bad cast would
not be encountered when manipulating the MathML document via
JavaScript.

r158198 broke the test, because it enforced the requirements that
MathML nodes not generate renderers for non-MathML children.

This patch revises the test to use an SVG document, which does
permit child HTML nodes.

* TestExpectations: Remove temporary exclusion landed in
  r158216.
* editing/execCommand/insert-list-xml-expected.txt:
* editing/execCommand/insert-list-xml.xhtml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMountain Lion rebaseline after r158231.
rniwa@webkit.org [Wed, 30 Oct 2013 00:52:58 +0000 (00:52 +0000)]
Mountain Lion rebaseline after r158231.

* platform/mac-mountainlion/js/dom/global-constructors-attributes-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix memory leak in Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp
seokju@webkit.org [Wed, 30 Oct 2013 00:25:07 +0000 (00:25 +0000)]
Fix memory leak in Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp
https://bugs.webkit.org/show_bug.cgi?id=123478

Reviewed by Anders Carlsson.

* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(NPP_Destroy): Add a missing free() for 'obj->evaluateScriptOnMouseDownOrKeyDown'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBeef up CryptoKey
ap@apple.com [Tue, 29 Oct 2013 23:33:02 +0000 (23:33 +0000)]
Beef up CryptoKey
https://bugs.webkit.org/show_bug.cgi?id=123462

Fix a mismerge, remove duplicate CryptoKeyType declaration.

* crypto/CryptoKey.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove the SEO bots from testers to archivers.
lforschler@apple.com [Tue, 29 Oct 2013 23:19:46 +0000 (23:19 +0000)]
Move the SEO bots from testers to archivers.

Unreviewed.

* BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoChange local variable register allocation to start at offset -1
msaboff@apple.com [Tue, 29 Oct 2013 23:15:09 +0000 (23:15 +0000)]
Change local variable register allocation to start at offset -1
https://bugs.webkit.org/show_bug.cgi?id=123182

Reviewed by Geoffrey Garen.

Adjusted the virtual register mapping down by one slot.  Reduced
the CallFrame header slots offsets by one.  They now start at 0.
Changed arity fixup to no longer skip passed register slot 0 as this
is now part of the CallFrame header.

* bytecode/VirtualRegister.h:
(JSC::operandIsLocal):
(JSC::operandIsArgument):
(JSC::VirtualRegister::localToOperand):
(JSC::VirtualRegister::operandToLocal):
  Adjusted functions for shift in mapping from local to register offset.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::findArgumentPositionForLocal):
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGVariableEventStream.cpp:
(JSC::DFG::VariableEventStream::reconstruct):
* dfg/DFGVirtualRegisterAllocationPhase.cpp:
(JSC::DFG::VirtualRegisterAllocationPhase::run):
* interpreter/CallFrame.h:
(JSC::ExecState::frameExtent):
(JSC::ExecState::offsetFor):
* interpreter/Interpreter.cpp:
(JSC::loadVarargs):
(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::executeCall):
* llint/LLIntData.cpp:
(JSC::LLInt::Data::performAssertions):
* llint/LowLevelInterpreter.asm:
  Adjusted math to accomodate for shift in call frame slots.

* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileFunction):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::calleeFrameOffset):
* interpreter/CallFrame.cpp:
(JSC::CallFrame::frameExtentInternal):
* interpreter/JSStackInlines.h:
(JSC::JSStack::pushFrame):
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
* jit/JITOperations.cpp:
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::llint_slow_path_stack_check):
* runtime/CommonSlowPaths.h:
(JSC::CommonSlowPaths::arityCheckFor):
  Fixed offset calculation to use VirtualRegister and related calculation instead of
  doing seperate calculations.

* interpreter/JSStack.h:
  Adjusted CallFrame slots down by one.  Did some miscellaneous fixing of dumpRegisters()
  in the process of testing the fixes.

* jit/ThunkGenerators.cpp:
(JSC::arityFixup):
  Changed arity fixup to no longer skip passed register slot 0 as this
  is now part of the CallFrame header.

* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:
  Changed arity fixup to no longer skip passed register slot 0 as this
  is now part of the CallFrame header.  Updated op_enter processing for
  the change in local registers.

* runtime/JSGlobalObject.h:
  Removed the now unneeded extra slot in the global callframe

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBeef up CryptoKey
ap@apple.com [Tue, 29 Oct 2013 23:12:43 +0000 (23:12 +0000)]
Beef up CryptoKey
https://bugs.webkit.org/show_bug.cgi?id=123462

Reviewed by Sam Weinig.

* WebCore.xcodeproj/project.pbxproj: Added new files.

* crypto/CryptoAlgorithmIdentifier.h: Added an enum with all registered algorithms
(they don't have to be all implemented in any port).

* crypto/CryptoKey.cpp:
(WebCore::CryptoKey::CryptoKey): Initialize base class variables.
(WebCore::CryptoKey::type): Convert internal representation for bindings use.
(WebCore::CryptoKey::buildAlgorithmDescription): Ditto. This function is supposed
to be called by derived classes before adding other keyes.
(WebCore::CryptoKey::usages): Convert internal representation for bindings use.

* crypto/CryptoKey.h:
(WebCore::CryptoKey::extractable): Expose for bindings.
(WebCore::CryptoKey::allows): A faster way to check allowed key usage from C++ code.

* crypto/CryptoKey.idl: Added SkipVTableValidation, because validation doesn't work
with derived classes. Corrected "usages" attribute name.

* crypto/CryptoKeyFormat.h: Added.
* crypto/CryptoKeyType.h: Added.
* crypto/CryptoKeyUsage.h: Added.
Added enums used by CryptoKey.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdding Nix files in Source/Platform to trunk
hugo.lima@openbossa.org [Tue, 29 Oct 2013 23:03:52 +0000 (23:03 +0000)]
Adding Nix files in Source/Platform to trunk
https://bugs.webkit.org/show_bug.cgi?id=118331

Reviewed by Benjamin Poulain.

Source/Platform:

Add files part of Nix public API used to implement
backends for some WebKit subsystems on Application side.

* nix/public/AudioDevice.h: Added.
* nix/public/Canvas.h: Added.
* nix/public/Color.h: Added.
* nix/public/Common.h: Added.
* nix/public/FFTFrame.h: Added.
* nix/public/Gamepad.h: Added.
* nix/public/Gamepads.h: Added.
* nix/public/MediaPlayer.h: Added.
* nix/public/MultiChannelPCMData.h: Added.
* nix/public/Platform.h: Added.
* nix/public/Rect.h: Added.
* nix/public/Size.h: Added.
* nix/public/ThemeEngine.h: Added.
* nix/src/DefaultWebThemeEngine.cpp: Added.
* nix/src/DefaultWebThemeEngine.h: Added.
* nix/src/Platform.cpp: Added.

Source/WebCore:

Add Nix WebAudio implementation that just forward some calls to our API.
This patch is part of the upstream process, tests will be landed by other patches.

* platform/audio/nix/AudioBusNix.cpp: Added.
* platform/audio/nix/AudioDestinationNix.cpp: Added.
* platform/audio/nix/AudioDestinationNix.h: Added.
* platform/audio/nix/FFTFrameNix.cpp: Added.
* platform/nix/support/MultiChannelPCMData.cpp: Added.

Tools:

Add a special rule for Nix API files located at Source/Platform/nix.

* Scripts/webkitpy/style/checker.py:

 2013-10-29  Nadav Rotem  <nrotem@apple.com>

 Add myself as a comitter.
 https://bugs.webkit.org/show_bug.cgi?id=123455

 Reviewed by Anders Carlsson.

 * Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove IDBTransactionBackendLevelDB to generic IDBBackingStoreInterface::Transaction.
beidson@apple.com [Tue, 29 Oct 2013 22:52:28 +0000 (22:52 +0000)]
Move IDBTransactionBackendLevelDB to generic IDBBackingStoreInterface::Transaction.
https://bugs.webkit.org/show_bug.cgi?id=123475

Reviewed by Tim Horton.

Currently it's using IDBBackingStoreLevelDB::Transaction, which hinders the goal of:
https://bugs.webkit.org/show_bug.cgi?id=123449 - IDBTransactionBackend should be cross platform

* Modules/indexeddb/IDBBackingStoreInterface.h:

* Modules/indexeddb/IDBIndexWriter.cpp:
(WebCore::IDBIndexWriter::writeIndexKeys):
(WebCore::IDBIndexWriter::verifyIndexKeys):
(WebCore::IDBIndexWriter::addingKeyAllowed):
* Modules/indexeddb/IDBIndexWriter.h:

* Modules/indexeddb/IDBTransactionBackendInterface.h:

* Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
(WebCore::IDBBackingStoreLevelDB::updateIDBDatabaseIntVersion):
(WebCore::IDBBackingStoreLevelDB::updateIDBDatabaseMetaData):
(WebCore::IDBBackingStoreLevelDB::createObjectStore):
(WebCore::IDBBackingStoreLevelDB::deleteObjectStore):
(WebCore::IDBBackingStoreLevelDB::getRecord):
(WebCore::IDBBackingStoreLevelDB::putRecord):
(WebCore::IDBBackingStoreLevelDB::clearObjectStore):
(WebCore::IDBBackingStoreLevelDB::deleteRecord):
(WebCore::IDBBackingStoreLevelDB::getKeyGeneratorCurrentNumber):
(WebCore::IDBBackingStoreLevelDB::maybeUpdateKeyGeneratorCurrentNumber):
(WebCore::IDBBackingStoreLevelDB::keyExistsInObjectStore):
(WebCore::IDBBackingStoreLevelDB::createIndex):
(WebCore::IDBBackingStoreLevelDB::deleteIndex):
(WebCore::IDBBackingStoreLevelDB::putIndexDataForRecord):
(WebCore::IDBBackingStoreLevelDB::findKeyInIndex):
(WebCore::IDBBackingStoreLevelDB::getPrimaryKeyViaIndex):
(WebCore::IDBBackingStoreLevelDB::keyExistsInIndex):
(WebCore::IDBBackingStoreLevelDB::openObjectStoreCursor):
(WebCore::IDBBackingStoreLevelDB::openObjectStoreKeyCursor):
(WebCore::IDBBackingStoreLevelDB::openIndexKeyCursor):
(WebCore::IDBBackingStoreLevelDB::openIndexCursor):
* Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:

* Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.cpp:
(WebCore::IDBTransactionBackendLevelDB::IDBTransactionBackendLevelDB):
(WebCore::IDBTransactionBackendLevelDB::abort):
(WebCore::IDBTransactionBackendLevelDB::commit):
(WebCore::IDBTransactionBackendLevelDB::taskTimerFired):
* Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove InlineTextBox's text painting to it's own class
dino@apple.com [Tue, 29 Oct 2013 22:38:16 +0000 (22:38 +0000)]
Move InlineTextBox's text painting to it's own class
https://bugs.webkit.org/show_bug.cgi?id=123355

Reinstate the LGPL license. I incorrectly told Myles to
use another license on these new files.

* rendering/TextPainter.cpp:
* rendering/TextPainter.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove InlineTextBox's text painting to it's own class
commit-queue@webkit.org [Tue, 29 Oct 2013 22:29:30 +0000 (22:29 +0000)]
Move InlineTextBox's text painting to it's own class
https://bugs.webkit.org/show_bug.cgi?id=123355

Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-10-29
Reviewed by Dean Jackson.

Implementing text-decoration-skip: ink requires drawing text
twice (once regularly, and once with a thick outline into a mask).
This patch pulls out the relevant text drawing code from
InlineTextBox into a new class, called TextPainter, which can be re-used
to draw text multiple times.

Because there should be no observable difference, no tests need to be updated.

* CMakeLists.txt: Adding new TextPainter class
* GNUmakefile.list.am: Adding new TextPainter class
* WebCore.vcxproj/WebCore.vcxproj: Adding new TextPainter class
* WebCore.vcxproj/WebCore.vcxproj.filters: Adding new TextPainter
class
* WebCore.xcodeproj/project.pbxproj: Adding new TextPainter class
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint): Moving text drawing code from
this function
* rendering/RenderingAllInOne.cpp: Adding new TextPainter class
* rendering/TextPainter.cpp: Added.
(WebCore::TextPainter::TextPainter):
(WebCore::drawTextOrEmphasisMarks):
(WebCore::paintTextWithShadows):
(WebCore::rotation):
(WebCore::TextPainter::paintText): New location for text drawing
code
(WebCore::TextPainter::paintTextInContext):
* rendering/TextPainter.h: Added.
(WebCore::SavedDrawingStateForMask::SavedDrawingStateForMask):
(WebCore::TextPainter::boxRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[MSE] [Mac] Enable MediaSource on the Mac
jer.noble@apple.com [Tue, 29 Oct 2013 22:03:07 +0000 (22:03 +0000)]
[MSE] [Mac] Enable MediaSource on the Mac
https://bugs.webkit.org/show_bug.cgi?id=122484

Reviewed by Darin Adler.

Source/WebCore:

Enable ENABLE_MEDIA_SOURCE.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

Enable ENABLE_MEDIA_SOURCE.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Enable ENABLE_MEDIA_SOURCE.

* Configurations/FeatureDefines.xcconfig:

Source/WTF:

Enable ENABLE_MEDIA_SOURCE.

* wtf/FeatureDefines.h:
* wtf/Platform.h: Force a clean build.

LayoutTests:

* platform/mac/js/dom/global-constructors-attributes-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBuild fix after 158223; make TileController use float for scales.
timothy_horton@apple.com [Tue, 29 Oct 2013 21:50:47 +0000 (21:50 +0000)]
Build fix after 158223; make TileController use float for scales.

This matches what we do in other places, and fixes the constant
issue with exporting symbols that include CGFloat.

* WebCore.exp.in:
* platform/graphics/ca/mac/TileController.h:
(WebCore::TileController::scale):
* platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::setScale):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoTry to keep MSVC happy.
antti@apple.com [Tue, 29 Oct 2013 21:45:16 +0000 (21:45 +0000)]
Try to keep MSVC happy.

* rendering/SimpleLineLayout.h:
(WebCore::SimpleLineLayout::Run::Run):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoJust updating the sample code for this potential blog post.
bdakin@apple.com [Tue, 29 Oct 2013 21:44:37 +0000 (21:44 +0000)]
Just updating the sample code for this potential blog post.

* blog-files/regions/pizza-is-amazing.png: Replaced.
* blog-files/regions/unstyled-article.png: Replaced.
* demos/regions/pizza-regions-manifesto-regionstyling.html:
* demos/regions/pizza-regions-manifesto.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMore correct build fix after 158223.
timothy_horton@apple.com [Tue, 29 Oct 2013 21:30:39 +0000 (21:30 +0000)]
More correct build fix after 158223.

Only fails in release because it's inline.

* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
* WebCore.exp.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUse left/right instead of left/width for simple text runs
antti@apple.com [Tue, 29 Oct 2013 21:25:51 +0000 (21:25 +0000)]
Use left/right instead of left/width for simple text runs
https://bugs.webkit.org/show_bug.cgi?id=123465

Reviewed by Andreas Kling.

This simplifies the code a bit.

* rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::adjustRunOffsets):
(WebCore::SimpleLineLayout::create):
* rendering/SimpleLineLayout.h:
(WebCore::SimpleLineLayout::Run::Run):
* rendering/SimpleLineLayoutResolver.h:
(WebCore::SimpleLineLayout::RunResolver::Run::rect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoTry fixing the Mac build (though I have no idea why
timothy_horton@apple.com [Tue, 29 Oct 2013 21:25:18 +0000 (21:25 +0000)]
Try fixing the Mac build (though I have no idea why
this wouldn't fail locally)...

* WebCore.exp.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemote Layer Tree: Support tiled drawing and use it for the main frame
timothy_horton@apple.com [Tue, 29 Oct 2013 21:04:37 +0000 (21:04 +0000)]
Remote Layer Tree: Support tiled drawing and use it for the main frame
https://bugs.webkit.org/show_bug.cgi?id=123422

Reviewed by Simon Fraser.

Add a PlatformCALayerRemote subclass that behaves similarly to
WebTiledBackingLayer, forwarding relevant things (setNeedsDisplay, etc.)
to the TileController which it owns.

Teach the remote layer tree code enough to proxy these layers across,
and paint them in a manner similar to WebSimpleLayer (just calling
straight back to the TileController to paint).

* Shared/mac/RemoteLayerTreeTransaction.h:
* Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::LayerProperties::encode):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):
(WebKit::dumpChangedLayers):
* UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::commit):
* WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(PlatformCALayerRemote::setEdgeAntialiasingMask):
Add support for adjusting/encoding/decoding/dumping/applying edgeAntialiasingMask.

(WebKit::RemoteLayerTreeTransaction::dump):
Drive-by fix dumping of created layers to have one layer per line.

* UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::createLayer):
Create CALayers for Simple, TiledBacking, PageTiledBacking, and TiledBackingTile layers.

* WebKit2.xcodeproj/project.pbxproj:
Add PlatformCALayerRemoteTiledBacking.{h, cpp}.

* WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(PlatformCALayerRemote::create):
Create a PlatformCALayerRemoteTiledBacking for TiledBacking and PageTiledBacking layers.

(PlatformCALayerRemote::removeAllSublayers):
Fix removeAllSublayers to make a copy of the PlatformCALayerList before
mutating it, to avoid crashes when iterating a mutated list.

* WebProcess/WebPage/mac/PlatformCALayerRemote.h:
Definalize PlatformCALayerRemote so we can have PlatformCALayerRemoteTiledBacking.
Note that we will use a tiled backing layer in some cases.
Make the constructor protected, not private, so our subclass can use it.

* WebProcess/WebPage/mac/PlatformCALayerRemoteTiledBacking.cpp: Added.
(PlatformCALayerRemoteTiledBacking::PlatformCALayerRemoteTiledBacking):
(PlatformCALayerRemoteTiledBacking::~PlatformCALayerRemoteTiledBacking):
(PlatformCALayerRemoteTiledBacking::setNeedsDisplay):
(PlatformCALayerRemoteTiledBacking::customSublayers):
(PlatformCALayerRemoteTiledBacking::setBounds):
(PlatformCALayerRemoteTiledBacking::isOpaque):
(PlatformCALayerRemoteTiledBacking::setOpaque):
(PlatformCALayerRemoteTiledBacking::acceleratesDrawing):
(PlatformCALayerRemoteTiledBacking::setAcceleratesDrawing):
(PlatformCALayerRemoteTiledBacking::setContentsScale):
(PlatformCALayerRemoteTiledBacking::setBorderWidth):
(PlatformCALayerRemoteTiledBacking::setBorderColor):
* WebProcess/WebPage/mac/PlatformCALayerRemoteTiledBacking.h: Added.
Add a subclass of PlatformCALayerRemote which forwards operations
to TileController, very similar to what WebTiledBackingLayer does.
It also owns the TileController, and overrides customSublayers() and
tiledBacking() to return the right thing.

* WebProcess/WebPage/mac/RemoteLayerBackingStore.mm:
(RemoteLayerBackingStore::display):
Teach RemoteLayerBackingStore about how to paint different kinds of layers.
Simple layers and Tile layers will call paintContents directly,
WebLayers will do what WebLayer does and use drawLayerContents.
Other kinds of layers won't paint at all right now.
I would like to centralize this behavior (and get rid of our CALayer
subclasses entirely, moving all that behavior to be shared between Mac,
Windows, and the remote layer tree), but that is a patch for another day.

* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
(WebKit::RemoteLayerTreeDrawingArea::shouldUseTiledBackingForFrameView):
Force accelerated compositing on always when using the remote layer tree.
Use a TiledBacking for the main frame.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
Drive-by OVERRIDE.

* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd myself as a comitter
nrotem@apple.com [Tue, 29 Oct 2013 21:04:13 +0000 (21:04 +0000)]
Add myself as a comitter

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Mac MediaStream] implement AVFoundation backed MediaStreamSource
eric.carlson@apple.com [Tue, 29 Oct 2013 20:48:21 +0000 (20:48 +0000)]
[Mac MediaStream] implement AVFoundation backed MediaStreamSource
https://bugs.webkit.org/show_bug.cgi?id=123316

Source/WebCore:

Reviewed by Jer Noble

No new tests, existing tests updated.

* CMakeLists.txt: Add MediaStreamSourceStates.cpp.

* Modules/mediastream/MediaSourceStates.cpp:
(WebCore::MediaSourceStates::MediaSourceStates): m_SourceStates -> m_sourceStates.
(WebCore::MediaSourceStates::sourceType): Ditto.
(WebCore::MediaSourceStates::facingMode): Ditto.
* Modules/mediastream/MediaSourceStates.h: Ditto.
* Modules/mediastream/MediaSourceStates.idl: Mark some attributes as optional.

* Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::addTrack):
(WebCore::MediaStream::removeTrack):
(WebCore::MediaStream::addRemoteSource):
(WebCore::MediaStream::removeRemoteSource):

* Modules/mediastream/MediaStreamCapabilities.cpp:
(WebCore::MediaStreamCapabilities::sourceType): MediaSourceStates -> MediaStreamSourceStates
(WebCore::MediaStreamCapabilities::facingMode): Ditto.

* Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::MediaStreamTrack): Don't observe source changes directly, let the
    private track do that. Change private track parameter to ref because it can't be NULL.
(WebCore::MediaStreamTrack::~MediaStreamTrack): Ditto.
(WebCore::MediaStreamTrack::setSource): Pass through to private track.
(WebCore::MediaStreamTrack::stopped): Ditto.
(WebCore::MediaStreamTrack::states): Ditto.
(WebCore::MediaStreamTrack::capabilities): Ditto.
(WebCore::MediaStreamTrack::applyConstraints): Ditto.
(WebCore::MediaStreamTrack::stopProducingData): Ditto.
(WebCore::MediaStreamTrack::trackReadyStateChanged): Renamed from sourceStateChanged. Don't
    schedule an 'ended' event if called as a side effect of the stop() method having been
    called as per spec.
(WebCore::MediaStreamTrack::trackMutedChanged): Renamed from sourceMutedChanged.
(WebCore::MediaStreamTrack::trackEnabledChanged): Renamed from sourceEnabledChanged.
(WebCore::MediaStreamTrack::stop): Pass through to private track.
* Modules/mediastream/MediaStreamTrack.h:
(WebCore::MediaStreamTrack::Observer::~Observer): Add virtual destructor.

* Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::callSuccessHandler): Set track, not source, constraints.

* WebCore.xcodeproj/project.pbxproj: Add new files.

* bindings/js/JSMediaSourceStatesCustom.cpp:
(WebCore::JSMediaSourceStates::facingMode): Return jsUndefined when the facing mode
    is Unknown.

* platform/mediastream/MediaStreamCenter.h: Remove unused class forward defines and
    undefined method prototype.

* platform/mediastream/MediaStreamDescriptor.cpp:
(WebCore::MediaStreamDescriptor::addSource): ASSERT if source is kind None.
(WebCore::MediaStreamDescriptor::removeSource): Ditto.
(WebCore::MediaStreamDescriptor::MediaStreamDescriptor):

* platform/mediastream/MediaStreamSource.cpp:
(WebCore::MediaStreamSource::setReadyState): Call startProducingData when readyState changes
    to Live, stopProducingData when it changes to Ended.
(WebCore::MediaStreamSource::removeObserver): Call stop() when there are no more observers.
(WebCore::MediaStreamSource::setEnabled): If passed false, do nothing unless all observers
    are disabled. Call startProducingData/stopProducingData when becoming enabled/disabled.
(WebCore::MediaStreamSource::stop): Don't bother checking to see if other observers have
    stopped, the spec says that track.stop() should permanently stop the track's source.
* platform/mediastream/MediaStreamSource.h:
(WebCore::MediaStreamSource::name): Make virtual so derived classes can override.
(WebCore::MediaStreamSource::setName): Ditto.
(WebCore::MediaStreamSource::readyState): Ditto.
(WebCore::MediaStreamSource::enabled): Ditto.
(WebCore::MediaStreamSource::muted): Ditto.
(WebCore::MediaStreamSource::setReadonly): Ditto.
(WebCore::MediaStreamSource::remote): Ditto.
(WebCore::MediaStreamSource::setRemote): Ditto.
(WebCore::MediaStreamSource::startProducingData): Added.
(WebCore::MediaStreamSource::stopProducingData): Added.

* platform/mediastream/MediaStreamSourceCapabilities.h: Move MediaStreamSourceStates to
    its own file.

* platform/mediastream/MediaStreamSourceStates.cpp: Added.
(WebCore::MediaStreamSourceStates::facingMode): Moved here from MediaSourceStates so the
    strings are available to platform code.
(WebCore::MediaStreamSourceStates::sourceType): Ditto.
* platform/mediastream/MediaStreamSourceStates.h: Added, moved from MediaStreamSourceCapabilities.h.

* platform/mediastream/MediaStreamTrackPrivate.cpp:
(WebCore::MediaStreamTrackPrivate::create): Pass private track to constructor as PassRefPtr.
(WebCore::MediaStreamTrackPrivate::MediaStreamTrackPrivate): Initialize member variables.
(WebCore::MediaStreamTrackPrivate::~MediaStreamTrackPrivate): Unregister as source observer.
(WebCore::MediaStreamTrackPrivate::setSource): Unregister/register as source observer.
(WebCore::MediaStreamTrackPrivate::setEnabled): Enable/disable source, call client.
(WebCore::MediaStreamTrackPrivate::stop): New. Set readyState to Ended, optionally stop source.
(WebCore::MediaStreamTrackPrivate::setReadyState): Inline the logic from shouldFireTrackReadyStateChanged.
(WebCore::MediaStreamTrackPrivate::constraints): New, passthrough to the source.
(WebCore::MediaStreamTrackPrivate::states): Ditto.
(WebCore::MediaStreamTrackPrivate::type): Ditto.
(WebCore::MediaStreamTrackPrivate::capabilities): Ditto.
(WebCore::MediaStreamTrackPrivate::applyConstraints): Ditto.
(WebCore::MediaStreamTrackPrivate::sourceReadyStateChanged): React to source changes.
(WebCore::MediaStreamTrackPrivate::sourceMutedChanged): Ditto.
(WebCore::MediaStreamTrackPrivate::sourceEnabledChanged): Ditto.
(WebCore::MediaStreamTrackPrivate::observerIsEnabled): Respond to source query.
(WebCore::MediaStreamTrackPrivate::observerIsStopped): Ditto.
* platform/mediastream/MediaStreamTrackPrivate.h:

* platform/mediastream/mac/AVAudioCaptureSource.h: Added.
* platform/mediastream/mac/AVAudioCaptureSource.mm: Added.

* platform/mediastream/mac/AVCaptureDeviceManager.h: Added.
* platform/mediastream/mac/AVCaptureDeviceManager.mm: Added.

* platform/mediastream/mac/AVMediaCaptureSource.h: Added.
* platform/mediastream/mac/AVMediaCaptureSource.mm: Added.

* platform/mediastream/mac/AVVideoCaptureSource.h: Added.
* platform/mediastream/mac/AVVideoCaptureSource.mm: Added.

* platform/mediastream/mac/MediaStreamCenterMac.cpp:
(WebCore::MediaStreamCenterMac::validateRequestConstraints): Implement.
(WebCore::MediaStreamCenterMac::createMediaStream): Ditto.
(WebCore::MediaStreamCenterMac::getMediaStreamTrackSources): Ditto.

* platform/mock/MockMediaStreamCenter.cpp:
(WebCore::initializeMockSources): Update for MediaStreamSourceStates changes.
(WebCore::MockMediaStreamCenter::createMediaStream):

LayoutTests:

Reviewed by Jer Noble.

* fast/mediastream/MediaStream-add-remove-tracks-expected.txt: Updated.
* fast/mediastream/MediaStream-add-remove-tracks.html: Ditto.
* fast/mediastream/MediaStreamConstructor-expected.txt: Ditto.
* fast/mediastream/MediaStreamConstructor.html: Ditto.
* fast/mediastream/MediaStreamTrack-getSources.html: Remove typo.
* fast/mediastream/MediaStreamTrack-expected.txt: Updated results.
* fast/mediastream/MediaStreamTrack.html: Update to test track.stop() behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSource/WebCore: [CSS Regions][CSS Shapes] Layout error when the shape has negative...
zoltan@webkit.org [Tue, 29 Oct 2013 20:44:45 +0000 (20:44 +0000)]
Source/WebCore: [CSS Regions][CSS Shapes] Layout error when the shape has negative top coordinate and it's applied on the second region
<https://webkit.org/b/123346>

Reviewed by David Hyatt.

We have a layout error when there is a shape applied on the second region, and it has a negative 'top' coordinate.
Since shapeInsideInfo::shapeLogicalTop() can return negative numbers, we need to check for it, when we're positioning
the first line in the region.

Test: fast/regions/shape-inside/shape-inside-on-multiple-regions-with-negative-shape-top.html

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::updateShapeAndSegmentsForCurrentLineInFlowThread):

LayoutTests: [CSS Regions][CSS Shapes] Layout error when the shape has negative top coordinate and it's applied on the second region
<http://webkit.org/b/123346>

Reviewed by David Hyatt.

We have a layout error when there is a shape applied on the second region, and it has a negative 'top' coordinate.
Since shapeInsideInfo::shapeLogicalTop() can return negative numbers, we need to check for it, when we're positioning
the first line in the region.

* fast/regions/shape-inside/shape-inside-on-multiple-regions-with-negative-shape-top-expected.html: Added.
* fast/regions/shape-inside/shape-inside-on-multiple-regions-with-negative-shape-top.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoGet IDBTransactionBackendLevelDBOperations *almost* ready to go cross platform.
beidson@apple.com [Tue, 29 Oct 2013 20:41:40 +0000 (20:41 +0000)]
Get IDBTransactionBackendLevelDBOperations *almost* ready to go cross platform.
https://bugs.webkit.org/show_bug.cgi?id=123451

Reviewed by NOBODY (My bad, non-reviewed, non-building code got in there)

* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::processPendingCalls): Remove the auto line I was trying from review feedback.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoGet IDBTransactionBackendLevelDBOperations *almost* ready to go cross platform.
beidson@apple.com [Tue, 29 Oct 2013 20:38:40 +0000 (20:38 +0000)]
Get IDBTransactionBackendLevelDBOperations *almost* ready to go cross platform.
https://bugs.webkit.org/show_bug.cgi?id=123451

Reviewed by Andreas Kling.

Source/WebCore:

This involves:
- Splitting out IDBTransactionBackendLevelDB::Operation into its own header
- Splitting out IDBDatabaseBackendImpl::PendingOpenCall into its own header
- Reworking the LevelDB Operations to handle the base class IDBTransactionBackendInterface
- Adding virtual methods in a few of the *Interface classes to support the above

* GNUmakefile.list.am:
* WebCore.xcodeproj/project.pbxproj:

* Modules/indexeddb/IDBCallbacks.h:

* Modules/indexeddb/IDBCursorBackendInterface.h:

* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::setIndexKeys):
(WebCore::IDBDatabaseBackendImpl::processPendingCalls):
(WebCore::IDBDatabaseBackendImpl::openConnection):
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):
* Modules/indexeddb/IDBDatabaseBackendImpl.h:
* Modules/indexeddb/IDBDatabaseBackendInterface.h:

* Modules/indexeddb/IDBOperation.h: Added.
(WebCore::IDBOperation::~IDBOperation):

* Modules/indexeddb/IDBPendingOpenCall.h: Added.
(WebCore::IDBPendingOpenCall::create):
(WebCore::IDBPendingOpenCall::callbacks):
(WebCore::IDBPendingOpenCall::databaseCallbacks):
(WebCore::IDBPendingOpenCall::version):
(WebCore::IDBPendingOpenCall::transactionId):
(WebCore::IDBPendingOpenCall::IDBPendingOpenCall):

* Modules/indexeddb/IDBRequest.h:

* Modules/indexeddb/IDBTransactionBackendInterface.h:

* Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.cpp:
(WebCore::IDBCursorBackendLevelDB::CursorIterationOperation::create):
(WebCore::IDBCursorBackendLevelDB::CursorAdvanceOperation::create):
(WebCore::IDBCursorBackendLevelDB::CursorPrefetchIterationOperation::create):
(WebCore::IDBCursorBackendLevelDB::IDBCursorBackendLevelDB):
* Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.h:

* Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.cpp:
(WebCore::IDBTransactionBackendLevelDB::scheduleTask):
(WebCore::IDBTransactionBackendLevelDB::abort):
(WebCore::IDBTransactionBackendLevelDB::taskTimerFired):
(WebCore::IDBTransactionBackendLevelDB::schedulePutOperation):
(WebCore::IDBTransactionBackendLevelDB::scheduleOpenCursorOperation):
(WebCore::IDBTransactionBackendLevelDB::scheduleCountOperation):
(WebCore::IDBTransactionBackendLevelDB::scheduleDeleteRangeOperation):
(WebCore::IDBTransactionBackendLevelDB::scheduleClearOperation):
(WebCore::IDBTransactionBackendLevelDB::createCursorBackend):
* Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.h:

* Modules/indexeddb/leveldb/IDBTransactionBackendLevelDBOperations.cpp:
(WebCore::CreateObjectStoreOperation::perform):
(WebCore::CreateIndexOperation::perform):
(WebCore::CreateIndexAbortOperation::perform):
(WebCore::DeleteIndexOperation::perform):
(WebCore::DeleteIndexAbortOperation::perform):
(WebCore::OpenCursorOperation::perform):
(WebCore::DeleteObjectStoreOperation::perform):
(WebCore::IDBDatabaseBackendImpl::VersionChangeOperation::perform):
(WebCore::CreateObjectStoreAbortOperation::perform):
(WebCore::DeleteObjectStoreAbortOperation::perform):
(WebCore::IDBDatabaseBackendImpl::VersionChangeAbortOperation::perform):
* Modules/indexeddb/leveldb/IDBTransactionBackendLevelDBOperations.h:
(WebCore::CreateObjectStoreOperation::create):
(WebCore::CreateObjectStoreOperation::CreateObjectStoreOperation):
(WebCore::DeleteObjectStoreOperation::create):
(WebCore::DeleteObjectStoreOperation::DeleteObjectStoreOperation):
(WebCore::IDBDatabaseBackendImpl::VersionChangeOperation::create):
(WebCore::IDBDatabaseBackendImpl::VersionChangeOperation::VersionChangeOperation):
(WebCore::CreateObjectStoreAbortOperation::create):
(WebCore::CreateObjectStoreAbortOperation::CreateObjectStoreAbortOperation):
(WebCore::DeleteObjectStoreAbortOperation::create):
(WebCore::DeleteObjectStoreAbortOperation::DeleteObjectStoreAbortOperation):
(WebCore::IDBDatabaseBackendImpl::VersionChangeAbortOperation::create):
(WebCore::IDBDatabaseBackendImpl::VersionChangeAbortOperation::VersionChangeAbortOperation):
(WebCore::CreateIndexOperation::create):
(WebCore::CreateIndexOperation::CreateIndexOperation):
(WebCore::CreateIndexAbortOperation::create):
(WebCore::CreateIndexAbortOperation::CreateIndexAbortOperation):
(WebCore::DeleteIndexOperation::create):
(WebCore::DeleteIndexOperation::DeleteIndexOperation):
(WebCore::DeleteIndexAbortOperation::create):
(WebCore::DeleteIndexAbortOperation::DeleteIndexAbortOperation):
(WebCore::GetOperation::create):
(WebCore::GetOperation::GetOperation):
(WebCore::PutOperation::create):
(WebCore::PutOperation::PutOperation):
(WebCore::SetIndexesReadyOperation::create):
(WebCore::SetIndexesReadyOperation::SetIndexesReadyOperation):
(WebCore::OpenCursorOperation::create):
(WebCore::OpenCursorOperation::OpenCursorOperation):
(WebCore::CountOperation::create):
(WebCore::CountOperation::CountOperation):
(WebCore::DeleteRangeOperation::create):
(WebCore::DeleteRangeOperation::DeleteRangeOperation):
(WebCore::ClearOperation::create):
(WebCore::ClearOperation::ClearOperation):

Source/WebKit2:

Stub out more pure virtual methods.

* WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.cpp:
(WebKit::WebProcessIDBDatabaseBackend::backingStore):
(WebKit::WebProcessIDBDatabaseBackend::id):
(WebKit::WebProcessIDBDatabaseBackend::addObjectStore):
(WebKit::WebProcessIDBDatabaseBackend::removeObjectStore):
(WebKit::WebProcessIDBDatabaseBackend::addIndex):
(WebKit::WebProcessIDBDatabaseBackend::removeIndex):
(WebKit::WebProcessIDBDatabaseBackend::metadata):
(WebKit::WebProcessIDBDatabaseBackend::setCurrentVersion):
(WebKit::WebProcessIDBDatabaseBackend::hasPendingSecondHalfOpen):
(WebKit::WebProcessIDBDatabaseBackend::setPendingSecondHalfOpen):
* WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd a failing test expectation on editing/execCommand/insert-list-xml.xhtml
rniwa@webkit.org [Tue, 29 Oct 2013 20:27:33 +0000 (20:27 +0000)]
Add a failing test expectation on editing/execCommand/insert-list-xml.xhtml
after r158198. The failure is tracked by the bug 123460.

* TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMake SimpleLineLayout::Layout a variable size object
antti@apple.com [Tue, 29 Oct 2013 20:25:44 +0000 (20:25 +0000)]
Make SimpleLineLayout::Layout a variable size object
https://bugs.webkit.org/show_bug.cgi?id=123459

Reviewed by Andreas Kling.

Less memory, less indirection.

* rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor):
(WebCore::SimpleLineLayout::create):
(WebCore::SimpleLineLayout::Layout::create):
(WebCore::SimpleLineLayout::Layout::Layout):
* rendering/SimpleLineLayout.h:
* rendering/SimpleLineLayoutFunctions.cpp:
(WebCore::SimpleLineLayout::hitTestFlow):
* rendering/SimpleLineLayoutFunctions.h:
(WebCore::SimpleLineLayout::computeFlowFirstLineBaseline):
(WebCore::SimpleLineLayout::computeFlowLastLineBaseline):
(WebCore::SimpleLineLayout::findTextCaretMinimumOffset):
(WebCore::SimpleLineLayout::findTextCaretMaximumOffset):
(WebCore::SimpleLineLayout::containsTextCaretOffset):
(WebCore::SimpleLineLayout::isTextRendered):
* rendering/SimpleLineLayoutResolver.h:
(WebCore::SimpleLineLayout::RunResolver::end):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoStringImpl::adopt() should return PassRef.
akling@apple.com [Tue, 29 Oct 2013 20:02:06 +0000 (20:02 +0000)]
StringImpl::adopt() should return PassRef.
<https://webkit.org/b/123456>

Make the StringImpl::adopt() functions return a PassRef<StringImpl>.

Reviewed by Anders Carlsson.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRenderObject::outlineStyleForRepaint() should return a reference.
akling@apple.com [Tue, 29 Oct 2013 19:52:06 +0000 (19:52 +0000)]
RenderObject::outlineStyleForRepaint() should return a reference.
<https://webkit.org/b/123453>

Kill a FIXME and make outlineStyleForRepaint() return a RenderStyle&.

Reviewed by Antti Koivisto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSessionState.h should not include WebBackForwardList.h
barraclough@apple.com [Tue, 29 Oct 2013 19:43:29 +0000 (19:43 +0000)]
SessionState.h should not include WebBackForwardList.h
https://bugs.webkit.org/show_bug.cgi?id=123454

Reviewed by Geoff Garen.

WebBackForwardList is a UIProcess type, SessionState is in shared code.
Also, WebBackForwardListItemVector should be in WebBackForwardListItem.h, not WebBackForwardList.h
(the vector type is used in the WebProcess, the item header is shared but the list type is in the UIProcess).

* Shared/SessionState.cpp:
    - fixed includes
* Shared/SessionState.h:
    - WebBackForwardList.h -> WebBackForwardListItem.h
* Shared/WebBackForwardListItem.h:
    - Moved WebBackForwardListVector from WebBackForwardList.h
* Shared/WebPageCreationParameters.h:
    - fixed includes
* UIProcess/WebBackForwardList.h:
    - Moved WebBackForwardListVector to WebBackForwardListItem.h
* WebProcess/WebPage/DrawingArea.cpp:
    - fixed includes
* WebProcess/WebPage/WebPage.cpp:
    - fixed includes

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove more of SVG resources cache to using RenderElement.
akling@apple.com [Tue, 29 Oct 2013 19:41:03 +0000 (19:41 +0000)]
Move more of SVG resources cache to using RenderElement.
<https://webkit.org/b/123452>

Make some more RenderSVGResourcesCache methods take RenderElement&
instead of RenderObject*.

Also removed a double hash lookup in removeResourcesFromRenderer().

Reviewed by Antti Koivisto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[arm] Fix lots of crashes because of 4th argument register trampling.
commit-queue@webkit.org [Tue, 29 Oct 2013 19:34:19 +0000 (19:34 +0000)]
[arm] Fix lots of crashes because of 4th argument register trampling.
https://bugs.webkit.org/show_bug.cgi?id=123421

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-29
Reviewed by Michael Saboff.

r3 register is the 4th argument register for ARM and also a scratch
register in the baseline JIT for this architecture. We can use r6
instead, as this used to be the timeoutCheckRegister and it is no
longer used since r148119.

* assembler/ARMAssembler.h: Temp register is now r6 instead of r3 for ARM.
* assembler/MacroAssemblerARMv7.h: Temp register is now r6 instead of r3 for ARMv7.
* jit/GPRInfo.h: Add r3 properly in GPRInfo for ARM.
(JSC::GPRInfo::toRegister):
(JSC::GPRInfo::toIndex):
* jit/JITStubsARM.h:
(JSC::ctiTrampoline): Remove obsolete timeoutCheckRegister init.
* jit/JITStubsARMv7.h:
(JSC::ctiTrampoline): Remove obsolete timeoutCheckRegister init.
* jit/JSInterfaceJIT.h: Remove useless stuff.
* yarr/YarrJIT.cpp: Use r3 and not the new scratch register r6.
(JSC::Yarr::YarrGenerator::generateEnter): r8 register doesn't need to be saved.
(JSC::Yarr::YarrGenerator::generateReturn):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoTeach the WebKit2 testers to abort early by setting the shouldAbortEarly property...
lforschler@apple.com [Tue, 29 Oct 2013 19:20:21 +0000 (19:20 +0000)]
Teach the WebKit2 testers to abort early by setting the shouldAbortEarly property to True.
https://bugs.webkit.org/show_bug.cgi?id=123450

Reviewed by Alexey Proskuryakov.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunWebKit2Tests.start):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMark some colorspace-sensitive tests as possibly passing.
simon.fraser@apple.com [Tue, 29 Oct 2013 19:03:35 +0000 (19:03 +0000)]
Mark some colorspace-sensitive tests as possibly passing.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix CPU(ARM_TRADITIONAL) build after r157690.
commit-queue@webkit.org [Tue, 29 Oct 2013 19:02:46 +0000 (19:02 +0000)]
Fix CPU(ARM_TRADITIONAL) build after r157690.
https://bugs.webkit.org/show_bug.cgi?id=123247

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-29
Reviewed by Michael Saboff.

Since r157690, the executableCopy function has been removed from AssemblerBuffer.h
and the copy of executable code occurs in the linkCode function (in LinkBuffer.cpp).
As the constant pool for jumps is updated in the executableCopy function of ARM_TRADITIONAL,
this part of code still needs to be called and absolute jumps must be corrected to anticipate
the copy of the executable code through memcpy.

* assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::prepareExecutableCopy): Rename executableCopy to prepareExecutableCopy
and correct absolute jump values using the delta between the source and destination buffers.
* assembler/ARMAssembler.h:
* assembler/LinkBuffer.cpp:
(JSC::LinkBuffer::linkCode): Call prepareExecutableCopy just before the memcpy.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoxss-DENIED-xsl-document-redirect.xml is an XML file, not html.
simon.fraser@apple.com [Tue, 29 Oct 2013 18:56:46 +0000 (18:56 +0000)]
xss-DENIED-xsl-document-redirect.xml is an XML file, not html.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Remove old Inspector.json version files and generators
commit-queue@webkit.org [Tue, 29 Oct 2013 18:38:17 +0000 (18:38 +0000)]
Web Inspector: Remove old Inspector.json version files and generators
https://bugs.webkit.org/show_bug.cgi?id=123426

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-10-29
Reviewed by Timothy Hatcher.

* CMakeLists.txt:
* DerivedSources.make:
* GNUmakefile.am:
* GNUmakefile.list.am:
* WebCore.xcodeproj/project.pbxproj:
* inspector/Inspector-0.1.json: Removed.
* inspector/Inspector-1.0.json: Removed.
* inspector/generate-inspector-protocol-version: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agofast/forms/form-associated-element-removal.html can crash because of an underlying
simon.fraser@apple.com [Tue, 29 Oct 2013 18:26:57 +0000 (18:26 +0000)]
fast/forms/form-associated-element-removal.html can crash because of an underlying
media bug.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] DOM bindings documentation errors
philn@webkit.org [Tue, 29 Oct 2013 17:53:09 +0000 (17:53 +0000)]
[GTK] DOM bindings documentation errors
https://bugs.webkit.org/show_bug.cgi?id=123448

Reviewed by Carlos Garcia Campos.

* bindings/gobject/WebKitDOMCustom.h: Basic documentation for
return types.
* bindings/scripts/CodeGeneratorGObject.pm:
(GenerateFunction): Generate Returns documentation tag for
non-void return types and provide basic documentation.
* bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.h:
Reset tests results.
* bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
* bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.h:
* bindings/scripts/test/GObject/WebKitDOMTestEventTarget.h:
* bindings/scripts/test/GObject/WebKitDOMTestException.h:
* bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
* bindings/scripts/test/GObject/WebKitDOMTestTypedefs.h:
* bindings/scripts/test/GObject/WebKitDOMattribute.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Mac] Rationalize user defaults override code
ap@apple.com [Tue, 29 Oct 2013 17:47:46 +0000 (17:47 +0000)]
[Mac] Rationalize user defaults override code
https://bugs.webkit.org/show_bug.cgi?id=123436

Reviewed by Dan Bernstein.

* DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebPreferencesToConsistentValues): Renamed from resetDefaultsToConsistentValues,
because this function only resets WebPreferences now.
(setDefaultsToConsistentValuesForTesting): Moved code for setting the defaults
here, because tests never change them, and they only need to be set once, not
before each test. Removed long obsolete workaround for HIToolbox preferences.
Don't call resetWebPreferencesToConsistentValues, because it will be called before
the first test anyway.
(main): Don't set AppleMagnifiedMode here, moved that to setDefaultsToConsistentValuesForTesting.
(resetWebViewToConsistentStateBeforeTesting): Moved TestRunner::setSerializeHTTPLoads
and setlocale calls out of resetWebPreferencesToConsistentValues().
Added AppleAquaAntiAliasingChanged notification that we had in WK2, because it's
also needed in WK1.

* WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
(WTR::InjectedBundle::platformInitialize): Use literal syntax for defaults
dictionary.

* WebKitTestRunner/mac/main.mm:
(setDefaultsToConsistentValuesForTesting): Factored out of main(), and changed to
use NSArgumentDomain for everything.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSource/WebCore: Invalid cast in WebCore::toRenderMathMLBlock
bfulgham@apple.com [Tue, 29 Oct 2013 17:40:52 +0000 (17:40 +0000)]
Source/WebCore: Invalid cast in WebCore::toRenderMathMLBlock
https://bugs.webkit.org/show_bug.cgi?id=121728
rdar://problem/15046151

Reviewed by Dean Jackson.

Tested by: mathml/arbitrary-markup.html

* dom/Element.h: Expose childShouldCreateRenderer for
MathML as well as SVG builds.
* dom/Node.h:
(WebCore::Node::isMathMLElement): Added.
* mathml/MathMLElement.cpp:
(WebCore::MathMLElement::create): Create as MathML Element.
(WebCore::MathMLElement::childShouldCreateRenderer):
Only allow the child to emit a renderer if it is a
MathML element.
* mathml/MathMLElement.h:

LayoutTests: [MathML] invalid cast in WebCore::toRenderMathMLBlock
https://bugs.webkit.org/show_bug.cgi?id=121728

Reviewed by Dean Jackson.

* mathml/arbitrary-markup-expected.txt: Added.
* mathml/arbitrary-markup.html: Added.
* mathml/mfenced-root-layer.html: Modified to avoid invalid
use of arbitrary markup inside mfenced element.
* mathml/mfenced-root-layer-expected.txt: Rebaselined.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSVG: applyStrokeStyleToContext should take a RenderElement&.
akling@apple.com [Tue, 29 Oct 2013 17:17:22 +0000 (17:17 +0000)]
SVG: applyStrokeStyleToContext should take a RenderElement&.
<https://webkit.org/b/123447>

..and a RenderStyle& too, for that matter.

Reviewed by Anders Carlsson.

* rendering/svg/SVGRenderSupport.h:
* rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::applyStrokeStyleToContext):

    Have this take a RenderElement& and RenderStyle& instead of
    raw pointers. Tweaked a silly-looking loop.

* rendering/svg/RenderSVGShape.h:
* rendering/svg/RenderSVGShape.cpp:

    Moved BoundingRectStrokeStyleApplier helper class into the
    cpp file since it wasn't being used anywhere else.

* rendering/svg/RenderSVGResourceGradient.cpp:
(WebCore::RenderSVGResourceGradient::applyResource):
* rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::applyResource):
* rendering/svg/RenderSVGResourceSolidColor.cpp:
(WebCore::RenderSVGResourceSolidColor::applyResource):

    Remove ampersands.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMultiple runs per line on simple line path
antti@apple.com [Tue, 29 Oct 2013 17:00:42 +0000 (17:00 +0000)]
Multiple runs per line on simple line path
https://bugs.webkit.org/show_bug.cgi?id=123446

Reviewed by Andreas Kling.

By allowing multiple runs per line we can support text flows with consecutive whitespaces in the middle.

* rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor):

    Remove space test.
    The improved test coverage found a few more cases that we need to disallow.

(WebCore::SimpleLineLayout::adjustRunOffsets):

    Round the run positions and widths so they match line boxes.
    Adjust for text-align.

(WebCore::SimpleLineLayout::create):

    Split lines with consecutive spaces into runs.

* rendering/SimpleLineLayout.h:
(WebCore::SimpleLineLayout::Run::Run):
* rendering/SimpleLineLayoutFunctions.cpp:
(WebCore::SimpleLineLayout::hitTestFlow):
(WebCore::SimpleLineLayout::collectFlowOverflow):
(WebCore::SimpleLineLayout::computeTextBoundingBox):
* rendering/SimpleLineLayoutResolver.h:
(WebCore::SimpleLineLayout::RunResolver::Iterator::resolver):
(WebCore::SimpleLineLayout::RunResolver::Iterator::lineIndex):
(WebCore::SimpleLineLayout::RunResolver::Run::Run):
(WebCore::SimpleLineLayout::RunResolver::Run::rect):
(WebCore::SimpleLineLayout::RunResolver::Run::baseline):
(WebCore::SimpleLineLayout::RunResolver::Run::text):
(WebCore::SimpleLineLayout::RunResolver::Run::lineIndex):
(WebCore::SimpleLineLayout::RunResolver::Iterator::Iterator):
(WebCore::SimpleLineLayout::RunResolver::Iterator::operator++):

    Removed unnecessary operators.

(WebCore::SimpleLineLayout::RunResolver::Iterator::operator==):
(WebCore::SimpleLineLayout::RunResolver::Iterator::operator!=):
(WebCore::SimpleLineLayout::RunResolver::Iterator::operator*):
(WebCore::SimpleLineLayout::RunResolver::Iterator::simpleRun):
(WebCore::SimpleLineLayout::RunResolver::RunResolver):
(WebCore::SimpleLineLayout::RunResolver::begin):
(WebCore::SimpleLineLayout::RunResolver::end):

    Resolver -> RunResolver

(WebCore::SimpleLineLayout::LineResolver::Iterator::Iterator):
(WebCore::SimpleLineLayout::LineResolver::Iterator::operator++):
(WebCore::SimpleLineLayout::LineResolver::Iterator::operator==):
(WebCore::SimpleLineLayout::LineResolver::Iterator::operator!=):
(WebCore::SimpleLineLayout::LineResolver::Iterator::operator*):
(WebCore::SimpleLineLayout::LineResolver::LineResolver):
(WebCore::SimpleLineLayout::LineResolver::begin):
(WebCore::SimpleLineLayout::LineResolver::end):

    Add LineResolver around RunResolver. It resolves the line rectangles.

(WebCore::SimpleLineLayout::runResolver):
(WebCore::SimpleLineLayout::lineResolver):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAX: elements with explicit tabindex should expose AXFocused as writable, since mouse...
cfleizach@apple.com [Tue, 29 Oct 2013 16:40:08 +0000 (16:40 +0000)]
AX: elements with explicit tabindex should expose AXFocused as writable, since mouse clicks can focus it
https://bugs.webkit.org/show_bug.cgi?id=121335

Reviewed by Mario Sanchez Prada.

Source/WebCore:

Re-order logic that determines if a <span> should appear as an accessible element.
The change is that if an element canSetFocus() it should always be in the AX tree.

Test: accessibility/tabindex-elements-are-accessible.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):

LayoutTests:

* accessibility/tabindex-elements-are-accessible-expected.txt: Added.
* accessibility/tabindex-elements-are-accessible.html: Added.
      New test to ensure that if tabindex is on an element, it is in the AX tree.
* platform/mac/accessibility/table-with-row-col-of-headers-expected.txt:
* platform/mac/accessibility/table-with-row-col-of-headers.html:
      Update to reflect that if an ignored <table> has a tabindex, then it should at least be an AXGroup
* platform/mac/accessibility/update-children-when-aria-role-changes.html:
      Update so that the <span> elements being used don't have tabindex, which forces them to be in the AX tree,
      which changes the output of the test (basically we'd need to query the child of those elements instead).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] enable media-stream in build-webkit
philn@webkit.org [Tue, 29 Oct 2013 16:32:44 +0000 (16:32 +0000)]
[GTK] enable media-stream in build-webkit
https://bugs.webkit.org/show_bug.cgi?id=123144

Reviewed by Martin Robinson.

Source/WebCore:

* GNUmakefile.list.am: Add new MediaStream files to the GTK port build.

Tools:

* Scripts/webkitperl/FeatureList.pm: Enable media-stream build
for the GTK+ port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAX: Webkit does not expose AXRequired on input type=file
cfleizach@apple.com [Tue, 29 Oct 2013 16:01:17 +0000 (16:01 +0000)]
AX: Webkit does not expose AXRequired on input type=file
https://bugs.webkit.org/show_bug.cgi?id=123376

Reviewed by Mario Sanchez Prada.

Source/WebCore:

File upload buttons should expose AXRequired, since they take an input state.

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::supportsRequiredAttribute):
(WebCore::AccessibilityNodeObject::alternativeText):

LayoutTests:

Modify existing test case to test for file upload buttons.

* accessibility/html5-required-attribute-expected.txt:
* accessibility/html5-required-attribute.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoEFL 32 bit buildbot doesn't work on dashboard
gyuyoung.kim@samsung.com [Tue, 29 Oct 2013 12:42:21 +0000 (12:42 +0000)]
EFL 32 bit buildbot doesn't work on dashboard
https://bugs.webkit.org/show_bug.cgi?id=123435

Reviewed by Csaba Osztrogon√°c.

32 bit buildbot doesn't work on dashboard because name is different from buildbot list.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix the ChangeLog landed in r158185. The RemoteLayerTreeTextStream class is affected...
zandobersek@gmail.com [Tue, 29 Oct 2013 10:18:40 +0000 (10:18 +0000)]
Fix the ChangeLog landed in r158185. The RemoteLayerTreeTextStream class is affected, not RemoteLayerTreeTransaction.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Update NEWS and Versions.m4 for 2.3.1 release.
carlosgc@webkit.org [Tue, 29 Oct 2013 10:12:32 +0000 (10:12 +0000)]
Unreviewed. Update NEWS and Versions.m4 for 2.3.1 release.

.:

* Source/autotools/Versions.m4: Bump version numbers.

Source/WebKit/gtk:

* NEWS: Added release notes for 2.3.1.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRe-enable simple line layout for EFL
jinwoo7.song@samsung.com [Tue, 29 Oct 2013 09:56:36 +0000 (09:56 +0000)]
Re-enable simple line layout for EFL
https://bugs.webkit.org/show_bug.cgi?id=123402

Reviewed by Antti Koivisto.

Source/WebCore:

* rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor): 8-bit TextRun support is now enabled for EFL port, so the port
can use the simple line layout.

Source/WTF:

* wtf/FeatureDefines.h: Enable 8-bit TextRun support for EFL port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, follow-up to r158185. Export the required symbol.
zandobersek@gmail.com [Tue, 29 Oct 2013 09:32:18 +0000 (09:32 +0000)]
Unreviewed, follow-up to r158185. Export the required symbol.
This should fix the Mac debug build.

* WebCore.exp.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoText selected with double-click gets unselected after DOM modification
commit-queue@webkit.org [Tue, 29 Oct 2013 08:38:22 +0000 (08:38 +0000)]
Text selected with double-click gets unselected after DOM modification
https://bugs.webkit.org/show_bug.cgi?id=114227

Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-10-29
Reviewed by Ryosuke Niwa.

Source/WebCore:

Before this patch when selection is done by double-click (start and base remain
same) and DOM is modified then selection gets vanished. This does not
happen when selection is done by dragging mouse. This happens because
on double-click base and extent remain the same and on DOM
modification we update the selection with base and extent, so we loose
the selection. Since in double-click case start/end contain the
correct selection, same should be used after dom modification to
update selection.

Test: editing/selection/double-click-selection-with-dom-mutation.html

* editing/FrameSelection.cpp:
(WebCore::FrameSelection::textWasReplaced): use start/end to update
selection in case double click selection. Added a check for base !=
extent, if base != extent use base/extent to update the selection
otherwise use start/end with directionality check.

LayoutTests:

New Testcase to test that selection remain intact when selection is
created by double-click and then dom is modified.

* editing/selection/double-click-selection-with-dom-mutation-expected.txt: Added.
* editing/selection/double-click-selection-with-dom-mutation.html: Added.

Rebaselined the below test cases.
* platform/mac/editing/deleting/smart-delete-003-expected.txt:
* platform/mac/editing/deleting/smart-delete-004-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed Mac debug build fix after r158183.
zandobersek@gmail.com [Tue, 29 Oct 2013 08:34:18 +0000 (08:34 +0000)]
Unreviewed Mac debug build fix after r158183.
Remove the duplicated << overloaded operator from RemoteLayerTreeTransaction for printing out
a given FloatSize object. The RemoteLayerTreeTransaction inherits from TextStream, which already
provides that overloaded operator. Format of the output is a bit different so hopefully nothing
breaks further.

* Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTextStream::operator<<):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSSRegions] Display anonymous regions in DRT
mihnea@adobe.com [Tue, 29 Oct 2013 08:23:57 +0000 (08:23 +0000)]
[CSSRegions] Display anonymous regions in DRT
https://bugs.webkit.org/show_bug.cgi?id=122963

Reviewed by Alexandru Chiculita.

After https://bugs.webkit.org/show_bug.cgi?id=119135, css regions are modelled using an anonymous
RenderNamedFlowFragment object inside the block having a valid -webkit-flow-from.
This patch changes the way elements | pseudo-elements with -webkit-flow-from are displayed
in test dumps.

Source/WebCore:

Before:
    RenderRegion {DIV} at (200,200) size 52x52 [border: (1px solid #000000)]
After:
    RenderBlock (positioned) {DIV} at (200,200) size 52x52 [border: (1px solid #000000)]
        RenderNamedFlowFragment at (1,1) size 50x50

Before:
    Flow Threads
        Thread with flow-name 'article'
        Regions for flow 'article'
            RenderRegion {DIV} #region_1
            RenderRegion {DIV} #region_2
After:
    Named flows
        Named flow 'article'
        Regions for named flow 'article'
            RenderNamedFlowFragment (anonymous child of {DIV::before} #region_1)
            RenderNamedFlowFragment (anonymous child of {DIV} #region_2)

Changed existing tests based on the new dumps.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::renderName):
* rendering/RenderNamedFlowFragment.h: Add a comment explaining the purpose of the class.
* rendering/RenderRegion.h:
* rendering/RenderTreeAsText.cpp:
(WebCore::write):
(WebCore::writeRenderRegionList): Adjust function to display info for anonymous regions too.
(WebCore::writeRenderNamedFlowThreads): Separate dump of valid and invalid regions for a named flow.

LayoutTests:

Changed expected files for mac port, removed expectations for gtk | efl and added [Missing]
in TestExpectations for these platforms. Results need to be generated again for the [Missing] lines.

* fast/regions/auto-size/autoheight-regions-mark-expected.txt: Removed.
* fast/regions/flows-dependency-dynamic-remove-expected.txt: Removed.
* fast/regions/flows-dependency-same-flow-expected.txt: Removed.
* platform/efl/TestExpectations:
* platform/efl/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Removed.
* platform/efl/fast/regions/region-dynamic-after-before-expected.txt: Removed.
* platform/efl/fast/regions/region-generated-content-before-after-expected.txt: Removed.
* platform/efl/fast/regions/text-region-split-small-pagination-expected.txt: Removed.
* platform/efl/fast/regions/top-overflow-out-of-second-region-expected.txt: Removed.
* platform/efl/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Removed.
* platform/efl/fast/repaint/line-flow-with-floats-in-regions-expected.png: Removed.
* platform/efl/fast/repaint/line-flow-with-floats-in-regions-expected.txt: Removed.
* platform/efl/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png: Removed.
* platform/efl/fast/repaint/region-painting-invalidation-expected.txt: Removed.
* platform/gtk/TestExpectations:
* platform/gtk/fast/regions/flows-dependency-same-flow-expected.png: Removed.
* platform/gtk/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Removed.
* platform/gtk/fast/regions/region-dynamic-after-before-expected.txt: Removed.
* platform/gtk/fast/regions/region-generated-content-before-after-expected.txt: Removed.
* platform/gtk/fast/regions/text-region-split-small-pagination-expected.txt: Removed.
* platform/gtk/fast/regions/top-overflow-out-of-second-region-expected.txt: Removed.
* platform/gtk/fast/repaint/line-flow-with-floats-in-regions-expected.png: Removed.
* platform/gtk/fast/repaint/line-flow-with-floats-in-regions-expected.txt: Removed.
* platform/gtk/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png: Removed.
* platform/mac/fast/regions/auto-size/autoheight-regions-mark-expected.png: Copied from LayoutTests/fast/regions/flows-dependency-same-flow-expected.png.
* platform/mac/fast/regions/auto-size/autoheight-regions-mark-expected.txt: Added.
* platform/mac/fast/regions/autoheight-regions-mark-expected.png: Removed.
* platform/mac/fast/regions/flows-dependency-dynamic-remove-expected.txt: Added.
* platform/mac/fast/regions/flows-dependency-same-flow-expected.png: Copied from LayoutTests/fast/regions/flows-dependency-same-flow-expected.png.
* platform/mac/fast/regions/flows-dependency-same-flow-expected.txt: Added.
* platform/mac/fast/regions/iframe-html-collected-expected.png: Renamed from LayoutTests/fast/regions/flows-dependency-same-flow-expected.png.
* platform/mac/fast/regions/iframe-html-collected-expected.txt: Renamed from LayoutTests/fast/regions/iframe-html-collected-expected.txt.
* platform/mac/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt:
* platform/mac/fast/regions/region-dynamic-after-before-expected.txt:
* platform/mac/fast/regions/region-generated-content-before-after-expected.txt:
* platform/mac/fast/regions/text-region-split-small-pagination-expected.txt:
* platform/mac/fast/regions/top-overflow-out-of-second-region-expected.txt:
* platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
* platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
* platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
* platform/mac/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt: Renamed from LayoutTests/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt.
* platform/mac/fast/repaint/region-painting-invalidation-expected.txt:
* platform/mac/fast/repaint/region-painting-via-layout-expected.txt: Renamed from LayoutTests/fast/repaint/region-painting-via-layout-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove writeIndent, overloaded << operators from RenderTreeAsText to TextStream
zandobersek@gmail.com [Tue, 29 Oct 2013 07:50:14 +0000 (07:50 +0000)]
Move writeIndent, overloaded << operators from RenderTreeAsText to TextStream
https://bugs.webkit.org/show_bug.cgi?id=116012

Reviewed by Simon Fraser.

The writeIndent method and overloaded << operators for writing out vectors and points and rectangles
of various types are not specific to the render tree nor do they depend on any rendering-specific interface.

* page/scrolling/ScrollingStateNode.cpp:
* page/scrolling/ScrollingStateNode.h:
(ScrollingStateNode): Remove the writeIndent declaration, it's functionally the same as the TextStream method.
* platform/graphics/GraphicsLayer.cpp:
* platform/graphics/GraphicsLayer.h:
(GraphicsLayer): Ditto.
* platform/graphics/filters/DistantLightSource.cpp: Remove the RenderTreeAsText.h inclusion or replace it with
the inclusion of the TextStream.h header where required. The writeIndent method is now declared there.
* platform/graphics/filters/FEBlend.cpp: Ditto.
* platform/graphics/filters/FEColorMatrix.cpp: Ditto.
* platform/graphics/filters/FEComponentTransfer.cpp: Ditto.
* platform/graphics/filters/FEComposite.cpp: Ditto.
* platform/graphics/filters/FEConvolveMatrix.cpp: Ditto.
* platform/graphics/filters/FECustomFilter.cpp: Ditto.
* platform/graphics/filters/FEDiffuseLighting.cpp: Ditto.
* platform/graphics/filters/FEDisplacementMap.cpp: Ditto.
* platform/graphics/filters/FEDropShadow.cpp: Ditto.
* platform/graphics/filters/FEFlood.cpp: Ditto.
* platform/graphics/filters/FEGaussianBlur.cpp: Ditto.
* platform/graphics/filters/FEMerge.cpp: Ditto.
* platform/graphics/filters/FEMorphology.cpp: Ditto.
* platform/graphics/filters/FEOffset.cpp: Ditto.
* platform/graphics/filters/FESpecularLighting.cpp: Ditto.
* platform/graphics/filters/FETurbulence.cpp: Ditto.
* platform/graphics/filters/SourceAlpha.cpp: Ditto.
* platform/graphics/filters/SourceGraphic.cpp: Ditto.
* platform/text/TextStream.cpp: Move the writeIndent and operators' definitions here.
(WebCore::operator<<):
(WebCore):
(WebCore::writeIndent):
* platform/text/TextStream.h: Move the writeIndent and operators' declarations here.
(WebCore):
(TextStream):
(WebCore::TextStream::operator<<):
* rendering/RenderTreeAsText.cpp: Move the writeIndent and operators' definitions into TextStream.
(WebCore):
* rendering/RenderTreeAsText.h: Move the writeIndent and operators' declarations into TextStream.
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoClean up ScopedEventQueue
zandobersek@gmail.com [Tue, 29 Oct 2013 07:42:40 +0000 (07:42 +0000)]
Clean up ScopedEventQueue
https://bugs.webkit.org/show_bug.cgi?id=123408

Reviewed by Darin Adler.

Clean up the ScopedEventQueue implementation. ScopedEventQueue::instance() should return a reference to a
NeverDestroyed<ScopedEventQueue> object. The static ScopedEventQueue::s_instance pointer is removed.

The ScopedEventQueue destructor, the dispatchAllEvents method and the scope level incrementation/decrementation
methods are made private. NeverDestroyed<ScopedEventQueue> and EventQueueScope are made friends of the
ScopedEventQueue class so they can access the constructor and the incrementation/decrementation methods, respectively.

ScopedEventQueue method definitions are reordered to follow the order of their declarations in the header file.
ScopedEventQueue::dispatchAllEvents() now uses std::move to efficiently dispatch and clear all currently queued events.

* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchScopedEvent):
* dom/ScopedEventQueue.cpp:
(WebCore::ScopedEventQueue::instance):
(WebCore::ScopedEventQueue::dispatchAllEvents):
* dom/ScopedEventQueue.h:
(WebCore::EventQueueScope::EventQueueScope):
(WebCore::EventQueueScope::~EventQueueScope):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoapplyTextTransform() should take a const RenderStyle&.
akling@apple.com [Tue, 29 Oct 2013 05:18:24 +0000 (05:18 +0000)]
applyTextTransform() should take a const RenderStyle&.
<https://webkit.org/b/123434>

This function is always called with an existing RenderStyle object.

Reviewed by Anders Carlsson.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRenderSVGResource::applyResource() should take a const RenderStyle&.
akling@apple.com [Tue, 29 Oct 2013 05:14:42 +0000 (05:14 +0000)]
RenderSVGResource::applyResource() should take a const RenderStyle&.
<https://webkit.org/b/123433>

These functions are always called with an existing RenderStyle object
so let them take a const reference instead of a raw pointer.
Also sprinkled some missing OVERRIDEs.

Reviewed by Anders Carlsson.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix bug URL in ChangeLog.
akling@apple.com [Tue, 29 Oct 2013 05:13:13 +0000 (05:13 +0000)]
Fix bug URL in ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove unused RenderTextControl::textBaseStyle().
akling@apple.com [Tue, 29 Oct 2013 05:09:22 +0000 (05:09 +0000)]
Remove unused RenderTextControl::textBaseStyle().
<https://webkit.org/b/123423>

Reviewed by Anders Carlsson.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix path for xss-DENIED-xsl-document-redirect test, and mark
simon.fraser@apple.com [Tue, 29 Oct 2013 04:42:47 +0000 (04:42 +0000)]
Fix path for xss-DENIED-xsl-document-redirect test, and mark
editing/selection/5057506-2.html as image-only failure.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFloating left the header broke other pages, and this CSS has no way to customize
simon.fraser@apple.com [Tue, 29 Oct 2013 04:38:32 +0000 (04:38 +0000)]
Floating left the header broke other pages, and this CSS has no way to customize
per-page.

* BuildSlaveSupport/build.webkit.org-config/public_html/default.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove underlines on the bot names in the header.
simon.fraser@apple.com [Tue, 29 Oct 2013 04:34:31 +0000 (04:34 +0000)]
Remove underlines on the bot names in the header.

* BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
(td.LastBuild a):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd EFL release bots to the buildbot dashboard
gyuyoung.kim@samsung.com [Tue, 29 Oct 2013 04:33:15 +0000 (04:33 +0000)]
Add EFL release bots to the buildbot dashboard
https://bugs.webkit.org/show_bug.cgi?id=123430

Reviewed by Darin Adler.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot): add 64 bits release wk2 and wk1 testers and 32 bits release builder.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
(table.queue-grid tr.platform.linux-efl img.logo): use the EFL logo in its dashboard line.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMore waterfall tweaking.
simon.fraser@apple.com [Tue, 29 Oct 2013 04:32:06 +0000 (04:32 +0000)]
More waterfall tweaking.

* BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
(body > .header):
(td.LastBuild):
(td.LastBuild a):
(td.LastBuild,td.Activity a,td.Change a,td.Builder a):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMore waterfall tweaking.
simon.fraser@apple.com [Tue, 29 Oct 2013 04:27:33 +0000 (04:27 +0000)]
More waterfall tweaking.

* BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
(body.interface):
(body > hr):
(div.content h1):
(body > .header):
(td.Activity a,td.Change a,td.Builder a):
(td.Builder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158172 268f45cc-cd09-0410-ab3c-d52691b4dbfc