WebKit-https.git
14 years ago Reviewed by Darin.
rwlbuis [Thu, 24 Aug 2006 10:04:16 +0000 (10:04 +0000)]
    Reviewed by Darin.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10524
        svg transform: comma delimiting breaks display

        Properly parse transforms which use ',' as seperators.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adele.
mjs [Thu, 24 Aug 2006 07:12:02 +0000 (07:12 +0000)]
    Reviewed by Adele.

        - fix assertion which I accidentally changed to one that sometimes fails
        http://bugzilla.opendarwin.org/show_bug.cgi?id=10531

        * Loader/WebDocumentLoadState.m:
        (-[WebDocumentLoadState dealloc]):
        * WebView/WebDataSource.m:
        (-[WebDataSourcePrivate dealloc]):
        (-[WebDataSource dealloc]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Brady.
mjs [Thu, 24 Aug 2006 06:22:13 +0000 (06:22 +0000)]
    Reviewed by Brady.

        - move WebFrame code that creates WebDataSources down to WebFrameLoader, in preparation
        for WebFrameLoader just holding on to WebDocumentLoadState

        * Loader/WebFrameLoader.h:
        * Loader/WebFrameLoader.m:
        (-[WebFrameLoader _loadRequest:archive:]):
        (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]):
        (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]):
        (-[WebFrameLoader reload]):
        * WebView/WebFrame.m:
        (-[WebFrame _loadItem:withLoadType:]):
        (-[WebFrame _continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
        (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
        (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
        (-[WebFrame _shouldReloadToHandleUnreachableURLFromRequest:]):
        (-[WebFrame loadRequest:]):
        (-[WebFrame loadArchive:]):
        (-[WebFrame reload]):
        * WebView/WebFrameInternal.h:
        * WebView/WebFramePrivate.h:
        * WebView/WebView.m:
        (-[WebView setCustomTextEncodingName:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej
beidson [Thu, 24 Aug 2006 05:59:33 +0000 (05:59 +0000)]
    Reviewed by Maciej

        First pass at pruning unused WebIconDatabase code.  Focus on removing methods that simply
        have no place in the new DB at all.  A few renames and a few important FIXMEs result, but no
        functionality changes.

        * Loader/WebIconLoader.m:
        (-[WebIconLoader didFinishLoading]): Call to WebIconDatabase instead of directly to the bridge
        * Misc/WebIconDatabase.h:
        * Misc/WebIconDatabase.m:
        (-[WebIconDatabase init]):
        (-[WebIconDatabase iconForURL:withSize:cache:]):
        (-[WebIconDatabase iconURLForURL:]):
        (-[WebIconDatabase defaultIconWithSize:]):
        (-[WebIconDatabase retainIconForURL:]):
        (-[WebIconDatabase releaseIconForURL:]):
        (-[WebIconDatabase removeAllIcons]):
        (-[WebIconDatabase _setIconData:forIconURL:]):
        (-[WebIconDatabase _setHaveNoIconForIconURL:]):
        (-[WebIconDatabase _setIconURL:forURL:]):
        (-[WebIconDatabase _hasEntryForIconURL:]):
        (-[WebIconDatabase _applicationWillTerminate:]):
        (-[WebIconDatabase _resetCachedWebPreferences:]):
        * Misc/WebIconDatabasePrivate.h: Changed setIcon: to setIconData:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adele.
mjs [Thu, 24 Aug 2006 04:15:07 +0000 (04:15 +0000)]
    Reviewed by Adele.

        - started factoring most of the guts of WebDataSource into a new class

        WebDocumentLoadState is decoupled from the rest of WebKit and will
        be moved down to WebCore. I only moved one of the data fields of
        WebDataSource for now.

        * Loader/WebDocumentLoadState.h: Added.
        * Loader/WebDocumentLoadState.m: Added.
        (-[WebDocumentLoadState initWithRequest:]): New class.
        (-[WebDocumentLoadState dealloc]):
        (-[WebDocumentLoadState setFrameLoader:]):
        (-[WebDocumentLoadState setMainResourceData:]):
        (-[WebDocumentLoadState mainResourceData]):
        * Loader/WebFrameLoader.m:
        (-[WebFrameLoader _setDataSource:]): Remove redundant _setWebFrame: call,
        it would have been called already by this point.
        (-[WebFrameLoader _setProvisionalDataSource:]): ditto.
        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebDataSource.m:
        (-[WebDataSourcePrivate dealloc]):
        (-[WebDataSource _setWebFrame:]):
        (-[WebDataSource _setPrimaryLoadComplete:]):
        (-[WebDataSource initWithRequest:]):
        (-[WebDataSource data]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adele.
mjs [Thu, 24 Aug 2006 01:28:20 +0000 (01:28 +0000)]
    Reviewed by Adele.

        - refactoring of WebDataSource in preparation for moving a bunch of it to a new class

        - minimize WebDataSourceInternal.h to be only methods called from outside WebDataSource
        - reduce Private category implementation to be only the SPI methods
        - make new Internal and FileInternal categories which contain the
        remainder (depending on whether they are called from outside of
        WebDataSource)

        * WebView/WebDataSource.m:
        (-[WebDataSource _setMainDocumentError:]):
        (addTypesFromClass):
        (+[WebDataSource _representationClassForMIMEType:]):
        (-[WebDataSource _commitIfReady]):
        (-[WebDataSource _commitLoadWithData:]):
        (-[WebDataSource _doesProgressiveLoadWithMIMEType:]):
        (-[WebDataSource _addResponse:]):
        (-[WebDataSource _revertToProvisionalState]):
        (-[WebDataSource _mainDocumentError]):
        (-[WebDataSource _addSubframeArchives:]):
        (-[WebDataSource _fileWrapperForURL:]):
        (+[WebDataSource _repTypesAllowImageTypeOmission:]):
        (-[WebDataSource _decidePolicyForMIMEType:decisionListener:]):
        (-[WebDataSource _finishedLoading]):
        (-[WebDataSource _setResponse:]):
        (-[WebDataSource _setRequest:]):
        (-[WebDataSource _setupForReplaceByMIMEType:]):
        (-[WebDataSource _receivedMainResourceError:complete:]):
        (-[WebDataSource _mainReceivedError:complete:]):
        (-[WebDataSource _defersCallbacks]):
        (-[WebDataSource _downloadWithLoadingConnection:request:response:proxy:]):
        (-[WebDataSource _didFailLoadingWithError:forResource:]):
        (-[WebDataSource _didFinishLoadingForResource:]):
        (-[WebDataSource _didReceiveData:contentLength:forResource:]):
        (-[WebDataSource _didReceiveResponse:forResource:]):
        (-[WebDataSource _didCancelAuthenticationChallenge:forResource:]):
        (-[WebDataSource _didReceiveAuthenticationChallenge:forResource:]):
        (-[WebDataSource _willSendRequest:forResource:redirectResponse:]):
        (-[WebDataSource _identifierForInitialRequest:]):
        (-[WebDataSource _archivedSubresourceForURL:]):
        (-[WebDataSource _startLoading]):
        (-[WebDataSource _stopRecordingResponses]):
        (-[WebDataSource _loadingStartedTime]):
        (-[WebDataSource _replaceSelectionWithArchive:selectReplacement:]):
        (-[WebDataSource _documentFragmentWithArchive:]):
        (-[WebDataSource _documentFragmentWithImageResource:]):
        (-[WebDataSource _imageElementWithImageResource:]):
        (-[WebDataSource _title]):
        (-[WebDataSource _isStopping]):
        (-[WebDataSource _setWebFrame:]):
        (-[WebDataSource _URL]):
        (-[WebDataSource _loadFromPageCache:]):
        (-[WebDataSource _popSubframeArchiveWithName:]):
        (-[WebDataSource _setIsClientRedirect:]):
        (-[WebDataSource _setURL:]):
        (-[WebDataSource _setLastCheckedRequest:]):
        (-[WebDataSource _defersCallbacksChanged]):
        (-[WebDataSource _lastCheckedRequest]):
        (-[WebDataSource _stopLoading]):
        (-[WebDataSource _bridge]):
        (-[WebDataSource _webView]):
        (-[WebDataSource _triggeringAction]):
        (-[WebDataSource _setTriggeringAction:]):
        (-[WebDataSource __adoptRequest:]):
        (-[WebDataSource _isDocumentHTML]):
        (-[WebDataSource _stopLoadingWithError:]):
        (-[WebDataSource _setPrimaryLoadComplete:]):
        (-[WebDataSource _responses]):
        (-[WebDataSource _makeRepresentation]):
        (-[WebDataSource _isClientRedirect]):
        (-[WebDataSource _originalRequest]):
        (-[WebDataSource _URLForHistory]):
        (-[WebDataSource _addToUnarchiveState:]):
        (-[WebDataSource _setOverrideEncoding:]):
        (-[WebDataSource _setIconURL:]):
        (-[WebDataSource _setIconURL:withType:]):
        (-[WebDataSource _overrideEncoding]):
        (-[WebDataSource _setTitle:]):
        * WebView/WebDataSourceInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix Mac bustage.
hyatt [Thu, 24 Aug 2006 01:01:04 +0000 (01:01 +0000)]
Fix Mac bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
darin [Thu, 24 Aug 2006 00:38:57 +0000 (00:38 +0000)]
    Reviewed by Maciej.

        - added an assert to make it slightly easier to debug the common case of
          calling document() on a node of 0

        * dom/Node.h: (WebCore::Node::document): ASSERT(this).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix Platform.h to include #defines for graphics features.
hyatt [Thu, 24 Aug 2006 00:04:12 +0000 (00:04 +0000)]
    Fix Platform.h to include #defines for graphics features.

        Reviewed by darin

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Refactor Cairo and CoreGraphics to use platform ifdefs. This patch
hyatt [Thu, 24 Aug 2006 00:02:51 +0000 (00:02 +0000)]
    Refactor Cairo and CoreGraphics to use platform ifdefs.  This patch
        separates the graphics engines from their respective platforms and replaces
        #ifdef PLATFORM(MAC) and PLATFORM(WIN) with PLATFORM(CG) and PLATFORM(CAIRO).

        Reviewed by darin

        * WebCore.xcodeproj/project.pbxproj:
        * platform/AffineTransform.h:
        * platform/Color.h:
        * platform/Cursor.h:
        * platform/FloatPoint.h:
        * platform/FloatRect.h:
        * platform/FloatSize.h:
        * platform/Font.h:
        * platform/FontData.h:
        * platform/GlyphBuffer.h:
        (WebCore::GlyphBuffer::glyphAt):
        (WebCore::GlyphBuffer::advanceAt):
        (WebCore::GlyphBuffer::add):
        * platform/GraphicsContext.h:
        * platform/Image.h:
        * platform/ImageSource.h:
        * platform/IntPoint.h:
        * platform/IntRect.h:
        * platform/IntSize.h:
        * platform/ResourceLoader.h:
        * platform/ResourceLoaderClient.h:
        * platform/Widget.h:
        * platform/cairo/GraphicsContextCairo.cpp:
        * platform/cairo/ImageCairo.cpp:
        * platform/cairo/ImageSourceCairo.cpp:
        * platform/cg/AffineTransformCG.cpp:
        * platform/cg/FloatPointCG.cpp: Added.
        * platform/cg/FloatRectCG.cpp: Added.
        * platform/cg/FloatSizeCG.cpp: Added.
        * platform/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::GraphicsContext):
        (WebCore::GraphicsContext::~GraphicsContext):
        (WebCore::GraphicsContext::setFocusRingClip):
        (WebCore::GraphicsContext::clearFocusRingClip):
        (WebCore::GraphicsContext::platformContext):
        (WebCore::GraphicsContext::drawRect):
        (WebCore::GraphicsContext::drawLine):
        * platform/cg/GraphicsContextPlatformPrivate.h: Added.
        (WebCore::GraphicsContextPlatformPrivate:::m_cgContext):
        (WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate):
        * platform/cg/ImageCG.cpp: Added.
        (WebCore::Image::drawTiled):
        * platform/cg/ImageSourceCG.cpp: Added.
        * platform/cg/IntPointCG.cpp: Added.
        * platform/cg/IntRectCG.cpp: Added.
        * platform/cg/IntSizeCG.cpp: Added.
        * platform/cg/PDFDocumentImage.cpp: Added.
        (WebCore::PDFDocumentImage::adjustCTM):
        * platform/cg/PDFDocumentImage.h: Added.
        * platform/cg/PathCG.cpp:
        * platform/image-decoders/bmp/BMPImageDecoder.cpp:
        * platform/image-decoders/gif/GIFImageDecoder.cpp:
        * platform/image-decoders/gif/GIFImageReader.cpp:
        * platform/image-decoders/ico/ICOImageDecoder.cpp:
        * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
        * platform/image-decoders/png/PNGImageDecoder.cpp:
        * platform/image-decoders/xbm/XBMImageDecoder.cpp:
        * platform/mac/FloatPointMac.mm:
        * platform/mac/FloatRectMac.mm:
        * platform/mac/FloatSizeMac.mm:
        * platform/mac/GraphicsContextMac.mm:
        * platform/mac/ImageMac.mm:
        * platform/mac/ImageSourceMac.cpp: Removed.
        * platform/mac/IntPointMac.mm:
        * platform/mac/IntRectMac.mm:
        * platform/mac/IntSizeMac.mm:
        * platform/mac/PDFDocumentImage.h: Removed.
        * platform/mac/PDFDocumentImage.mm: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoI forgot to check in these expected results yesterday.
justing [Wed, 23 Aug 2006 23:46:33 +0000 (23:46 +0000)]
I forgot to check in these expected results yesterday.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Remove the ifdef for platform scrollbars vs. engine scrollbars until
hyatt [Wed, 23 Aug 2006 21:36:58 +0000 (21:36 +0000)]
    Remove the ifdef for platform scrollbars vs. engine scrollbars until
        engine scrollbars actually exist.

        * platform/ScrollBar.h:
        (WebCore::ScrollBar::hasPlatformScrollBars):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by harrison
justing [Wed, 23 Aug 2006 21:33:18 +0000 (21:33 +0000)]
    Reviewed by harrison

        Removed the poorly named next/previousVisiblePosition
        and use next/previousCandidate and next/previousVisuallyDistinctCandidate.
        Removed the unused VisiblePosition::maxOffset()

        * editing/VisiblePosition.cpp:
        (WebCore::VisiblePosition::next):
        (WebCore::VisiblePosition::previous):
        (WebCore::VisiblePosition::canonicalPosition):
        * editing/VisiblePosition.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by John Sullivan
beidson [Wed, 23 Aug 2006 21:06:59 +0000 (21:06 +0000)]
    Reviewed by John Sullivan

        /me crosses fingers
        Flip the switch to the new Icon Database
        Massive code pruning is coming up

        * WebKitPrefix.h: Flipped the switch

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Alexey. Landed by rwlbuis.
rwlbuis [Wed, 23 Aug 2006 21:04:08 +0000 (21:04 +0000)]
    Reviewed by Alexey. Landed by rwlbuis.

        Fixes parts of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
        WebKit should have Qt platform support (Part II)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Beth
beidson [Wed, 23 Aug 2006 20:48:13 +0000 (20:48 +0000)]
    Reviewed by Beth
        Since I just pushed the default URL icon from WebKit to WebCore, but
        WebKit was still using its version of the default icon, this patch makes it
        use the WebCore version

        * Misc/WebIconDatabase.m:
        (-[WebIconDatabase defaultIconWithSize:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adele
beidson [Wed, 23 Aug 2006 19:31:44 +0000 (19:31 +0000)]
    Reviewed by Adele

        Moved default URL icon from WebKit to WebCore

        * Resources/urlIcon.tiff: Added.
        * WebCore.xcodeproj/project.pbxproj:
        * loader/icon/IconDataCache.cpp:
        (WebCore::IconDataCache::loadImageFromResource):
        * loader/icon/IconDataCache.h:
        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::IconDatabase):
        (WebCore::IconDatabase::defaultIcon):
        * loader/icon/IconDatabase.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin, Adele.
aroben [Wed, 23 Aug 2006 18:08:45 +0000 (18:08 +0000)]
    Reviewed by Darin, Adele.

        Some popup refactoring/cleanup.

        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::defaultEventHandler):
        * rendering/RenderMenuList.cpp:
        (WebCore::RenderMenuList::RenderMenuList):
        (WebCore::RenderMenuList::~RenderMenuList):
        (WebCore::RenderMenuList::showPopup):
        (WebCore::RenderMenuList::hidePopup):
        * rendering/RenderMenuList.h:
        (WebCore::RenderMenuList::popup):
        (WebCore::RenderMenuList::popupIsVisible):
        * rendering/RenderPopupMenu.h:
        * rendering/RenderPopupMenuMac.h:
        (WebCore::RenderPopupMenuMac::hidePopup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-08-23 Anders Carlsson <acarlsson@apple.com>
andersca [Wed, 23 Aug 2006 17:44:10 +0000 (17:44 +0000)]
2006-08-23  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Darin.

        Make the bindings compile without CoreFoundation.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * bindings/c/c_instance.cpp:
        * bindings/c/c_utility.cpp:
        (KJS::Bindings::convertUTF8ToUTF16):
        * bindings/npapi.h:
        * bindings/runtime.cpp:
        (KJS::Bindings::Instance::createBindingForLanguageInstance):
        (KJS::Bindings::Instance::createLanguageInstanceForValue):
        * bindings/runtime_root.cpp:
        * bindings/runtime_root.h:
        * kjs/interpreter.cpp:
        (KJS::Interpreter::createLanguageInstanceForValue):
        * kjs/interpreter.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Anders. Landed by rwlbuis.
rwlbuis [Wed, 23 Aug 2006 16:18:18 +0000 (16:18 +0000)]
    Reviewed by Anders. Landed by rwlbuis.

        Fixes parts of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
        WebKit should have Qt platform support

        Note: StringQt.cpp is not part of the original patch, but was
        mistakenly omitted from earlier 10467 patch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej
beidson [Wed, 23 Aug 2006 07:29:45 +0000 (07:29 +0000)]
    Reviewed by Maciej

        Added escapeSQLString() - a helper to escape strings to be used in textual SQL queries

        * WebCore.xcodeproj/project.pbxproj: Reordered some files
        * loader/icon/IconDataCache.cpp: Use the new escapeSQLString()
        (WebCore::IconDataCache::writeToDatabase):
        * loader/icon/IconDatabase.cpp: Use the new escapeSQLString() throughout
        (WebCore::IconDatabase::retainIconURL):
        (WebCore::IconDatabase::releaseIconURL):
        (WebCore::IconDatabase::forgetIconForIconURLFromDatabase):
        (WebCore::IconDatabase::establishIconIDForIconURL):
        (WebCore::imageDataForIconURLQuery):
        (WebCore::timeStampForIconURLQuery):
        (WebCore::iconURLForPageURLQuery):
        (WebCore::forgetPageURLQuery):
        (WebCore::setIconIDForPageURLQuery):
        (WebCore::getIconIDForIconURLQuery):
        (WebCore::addIconForIconURLQuery):
        (WebCore::hasIconForIconURLQuery):
        * loader/icon/SQLDatabase.h:
        (WebCore::escapeSQLString): Added

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Brady.
mjs [Wed, 23 Aug 2006 06:59:52 +0000 (06:59 +0000)]
    Reviewed by Brady.

        - remove "loading" flag from WebDataSource and code that manages it; it is redundat.

        * Loader/WebFrameLoader.m:
        (-[WebFrameLoader addPlugInStreamLoader:]):
        (-[WebFrameLoader removePlugInStreamLoader:]):
        (-[WebFrameLoader addSubresourceLoader:]):
        (-[WebFrameLoader removeSubresourceLoader:]):
        * WebView/WebDataSource.m:
        (-[WebDataSourcePrivate dealloc]):
        (-[WebDataSource _setPrimaryLoadComplete:]):
        (-[WebDataSource _stopLoading]):
        (-[WebDataSource _prepareForLoadStart]):
        (-[WebDataSource _startLoading]):
        (-[WebDataSource isLoading]):
        * WebView/WebDataSourceInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Brady.
mjs [Wed, 23 Aug 2006 06:50:38 +0000 (06:50 +0000)]
    Reviewed by Brady.

        - assorted style cleanup of icon loader code:

        - wrapped all implementation files in namespace WebCore {} instead of "using namespace WebCore;" at top
        - split headers to be one per class, to match impl files
        - made files that are purely local in IconDatabase.cpp static
        - make each impl file include config.h as first header (and no config.h includes in other headers)
        - avoid multiple copies of Vector<unsigned char> for image data

        * WebCore.xcodeproj/project.pbxproj:
        * loader/icon/IconDataCache.cpp:
        * loader/icon/IconDataCache.h: Added.
        (WebCore::):
        (WebCore::IconDataCache::getTimestamp):
        (WebCore::IconDataCache::setTimestamp):
        (WebCore::IconDataCache::getIconURL):
        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::imageDataForIconURL):
        (WebCore::IconDatabase::iconForPageURL):
        (WebCore::pageURLTableIsEmptyQuery):
        (WebCore::imageDataForIconURLQuery):
        (WebCore::timeStampForIconURLQuery):
        (WebCore::iconURLForPageURLQuery):
        (WebCore::forgetPageURLQuery):
        (WebCore::setIconIDForPageURLQuery):
        (WebCore::getIconIDForIconURLQuery):
        (WebCore::addIconForIconURLQuery):
        (WebCore::hasIconForIconURLQuery):
        * loader/icon/IconDatabase.h:
        * loader/icon/SQLDatabase.cpp:
        * loader/icon/SQLDatabase.h:
        * loader/icon/SQLStatement.cpp:
        (WebCore::SQLStatement::getColumnBlobAsVector):
        * loader/icon/SQLStatement.h: Added.
        (WebCore::SQLStatement::isPrepared):
        (WebCore::SQLStatement::prepareAndStep):
        (WebCore::SQLStatement::lastError):
        (WebCore::SQLStatement::lastErrorMsg):
        * loader/icon/SQLTransaction.cpp:
        * loader/icon/SQLTransaction.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by NOBODY
trey [Wed, 23 Aug 2006 06:05:06 +0000 (06:05 +0000)]
    Reviewed by NOBODY

        This test update was missing from the patch I posted, and ggarren just checked in.

        * fast/overflow/scrollRevealButton-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej
beidson [Wed, 23 Aug 2006 06:01:09 +0000 (06:01 +0000)]
    Reviewed by Maciej

        The role of the SiteIcon is now the original intention - to be a cache of data relating to an Icon
        As such, I'm renaming it to IconDataCache.
        Also, the IconDatabase has to manually set the image data on the IconDataCache and also sets the
        TimeStamp when an icon is created or the data is changed.
        IconDataCache now has a method to write itself *to* a given database, instead of read itself from one.
        IconDatabase schema changes to have the timestamp set manually instead of via a trigger.
        The overall purpose of this change is to cache the timestamp, killing off a very common SQL query.

        * WebCore.xcodeproj/project.pbxproj: Renamed a file
        * loader/icon/IconDataCache.cpp: Added.
        (IconDataCache::IconDataCache):
        (IconDataCache::getImage): Now either returns the stored image, or 0 - no attempt to grab data
        (IconDataCache::manuallySetImageData): Delete the old image and create the new one
        (IconDataCache::writeToDatabase): Write the current iconURL, data, and timestamp to the given DB
        (IconDataCache::imageDataStatus): Determine if an IconDataCache is new without data versus actually having null data
        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::createDatabaseTables): Changed DB schema to version 5 (hopefully the final version)
        (WebCore::IconDatabase::iconForPageURL):
        (WebCore::IconDatabase::isIconExpiredForIconURL): Uses the timestamp in the IconDataCache object instead of always querying
        (WebCore::IconDatabase::getOrCreateIconDataCache): Added, to handle creation of new IconDataCache when appropriate
        (WebCore::IconDatabase::setIconDataForIconURL): Puts data in SiteIcon then marks it for a future write
        (WebCore::IconDatabase::syncDatabase): Now syncs SiteIconsPendingUpdate
        * loader/icon/IconDatabase.h:
        (WebCore::IconDataCache::getTimestamp):
        (WebCore::IconDataCache::setTimestamp):
        * loader/icon/SiteIcon.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
mjs [Wed, 23 Aug 2006 05:49:04 +0000 (05:49 +0000)]
LayoutTests:

        Reviewed by Eric.

        - test for <rdar://problem/4683948> REGRESSION: Assertion failure in [FrameProgressEntry addChild:forDataSource:] (fandango.com)

        (I both added a WebKit assertion that would fail under this test, and then did a fix to make it not fire)

        * fast/loader/start-load-in-unload-expected.txt: Added.
        * fast/loader/start-load-in-unload.html: Added.

WebKit:

        Reviewed by Eric.

        <rdar://problem/4683948> REGRESSION: Assertion failure in [FrameProgressEntry addChild:forDataSource:] (fandango.com)

        * Loader/WebFrameLoader.m:
        (-[WebFrameLoader addSubresourceLoader:]): Add a WebKit-level assertion that should fire when this bad
        situation occurs.
        * Loader/WebSubresourceLoader.m:
        (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]): Prevent
        the situation from occuring.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix for broken tests.
mjs [Wed, 23 Aug 2006 05:37:03 +0000 (05:37 +0000)]
    Fix for broken tests.

        - made newly added CGI scripts executable

        * http/tests/navigation/resources/error404.pl:
        * http/tests/navigation/resources/frameset.pl:
        * http/tests/navigation/resources/postresult.pl:
        * http/tests/navigation/resources/redirect302.pl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoForgot to check this in in the previous commit.
justing [Wed, 23 Aug 2006 02:32:35 +0000 (02:32 +0000)]
Forgot to check this in in the previous commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
justing [Wed, 23 Aug 2006 00:47:01 +0000 (00:47 +0000)]
LayoutTests:

        Reviewed by harrison

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=10449>
        REGRESSION(r15918): drag-into-marker.html failing

        * editing/pasteboard/paste-list-001-expected.txt:
        * fast/lists/drag-into-marker.html: Added.
        * fast/lists/drag-into-marker.html-disabled: Removed.

WebCore:

        Reviewed by harrison

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=10449>
        REGRESSION(r15918): drag-into-marker.html failing

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply): Don't avoid nesting
        in a list item.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Kevin
beidson [Wed, 23 Aug 2006 00:42:04 +0000 (00:42 +0000)]
    Reviewed by Kevin

        Added a check in getTIFFRepresentation to not proceed if the frame count is zero
        This is an error condition that was handled gracefully before - in certain circumstances
        the call to CGImageDestinationCreateWithData will spam the Console if it is passed null/empty data
        or invalid data.  This small change bails out before that call if that call will definitely fail

        * platform/mac/ImageMac.mm:
        (WebCore::Image::getTIFFRepresentation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Backed out my last change (r15966) because it broke lots of layout tests.
harrison [Wed, 23 Aug 2006 00:23:50 +0000 (00:23 +0000)]
    Backed out my last change (r15966) because it broke lots of layout tests.

        * editing/TextIterator.cpp:
        (WebCore::TextIterator::advance):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mjs [Wed, 23 Aug 2006 00:09:28 +0000 (00:09 +0000)]
WebCore:

        Reviewed by Anders.

        - added some SPI indirections to support the following in WebKit/Loader:
            - pull more WebDataSource code into WebFrameLoader
            - make WebMainResourceLoader not depend on WebKit or on SPI

        * WebCore.exp:
        * WebCore.xcodeproj/project.pbxproj:
        * platform/mac/WebCoreSystemInterface.h:
        * platform/mac/WebCoreSystemInterface.mm:

WebKit:

        Reviewed by Anders.

        - pull more WebDataSource code into WebFrameLoader
        - make WebMainResourceLoader not depend on WebKit or on SPI

        * Loader/WebFrameLoader.h:
        * Loader/WebFrameLoader.m:
        (-[WebFrameLoader _downloadWithLoadingConnection:request:response:proxy:]):
        (-[WebFrameLoader _updateIconDatabaseWithURL:]):
        (-[WebFrameLoader _notifyIconChanged:]):
        (-[WebFrameLoader _iconLoaderReceivedPageIcon:]):
        (-[WebFrameLoader _checkNavigationPolicyForRequest:andCall:withSelector:]):
        (-[WebFrameLoader _checkContentPolicyForMIMEType:andCall:withSelector:]):
        (-[WebFrameLoader cancelContentPolicy]):
        * Loader/WebIconLoader.m:
        (-[WebIconLoader didFinishLoading]):
        * Loader/WebLoader.m:
        (-[NSURLProtocol loadWithRequest:]):
        (-[NSURLProtocol setDefersCallbacks:]):
        * Loader/WebMainResourceLoader.h:
        * Loader/WebMainResourceLoader.m:
        (-[WebMainResourceLoader initWithFrameLoader:]):
        (-[WebMainResourceLoader dealloc]):
        (-[WebMainResourceLoader cancelWithError:]):
        (-[WebMainResourceLoader continueAfterNavigationPolicy:formState:]):
        (-[WebMainResourceLoader willSendRequest:redirectResponse:]):
        (-[WebMainResourceLoader continueAfterContentPolicy:]):
        (-[WebMainResourceLoader checkContentPolicy]):
        (-[WebMainResourceLoader didReceiveResponse:]):
        * Plugins/WebPluginContainerCheck.m:
        * WebCoreSupport/WebSystemInterface.m:
        (InitWebCoreSystemInterface):
        * WebView/WebDataSource.m:
        (-[WebDataSource _loadIcon]):
        (-[WebDataSource _cancelledError]):
        (+[WebDataSource _repTypesAllowImageTypeOmission:]):
        (+[WebDataSource _representationClassForMIMEType:]):
        (-[WebDataSource _commitLoadWithData:]):
        (-[WebDataSource _isDocumentHTML]):
        * WebView/WebDataSourceInternal.h:
        * WebView/WebFramePrivate.h:
        * WebView/WebPolicyDelegate.m:
        * WebView/WebPolicyDelegatePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
justing [Tue, 22 Aug 2006 22:59:18 +0000 (22:59 +0000)]
LayoutTests:

        Reviewed by harrison

        <rdar://problem/4052343&4052343&4426622> Mail hung on paste text

        Bugs exposed:
        * editing/pasteboard/paste-4039777-fix-expected.checksum:
        * editing/pasteboard/paste-4039777-fix-expected.png:
        * editing/pasteboard/paste-4039777-fix-expected.txt:
        * editing/deleting/delete-3857753-fix-expected.txt:
        * editing/pasteboard/styled-element-markup-expected.checksum:
        * editing/pasteboard/styled-element-markup-expected.png:
        * editing/pasteboard/styled-element-markup-expected.txt:
        * editing/execCommand/insertHTML-expected.checksum:
        * editing/execCommand/insertHTML-expected.png:
        * editing/execCommand/insertHTML-expected.txt:
        * editing/execCommand/insertHTML.html:

        Removed some empty style spans, font tags are replaced by style spans
        in a couple of cases:
        * editing/deleting/merge-different-styles-expected.txt:
        * editing/deleting/pruning-after-merge-1-expected.txt:
        * editing/deleting/pruning-after-merge-2-expected.txt:
        * editing/inserting/insert-3786362-fix-expected.txt:
        * editing/pasteboard/block-wrappers-necessary-expected.txt:
        * editing/pasteboard/display-block-on-spans-expected.txt:
        * editing/pasteboard/merge-end-table-expected.txt:
        * editing/pasteboard/paste-4035648-fix-expected.txt:
        * editing/pasteboard/paste-line-endings-001-expected.txt:
        * editing/pasteboard/paste-line-endings-006-expected.txt:
        * editing/pasteboard/paste-list-001-expected.txt:
        * editing/pasteboard/paste-pre-001-expected.txt:
        * editing/pasteboard/paste-pre-002-expected.txt:
        * editing/pasteboard/paste-table-001-expected.txt:
        * editing/pasteboard/paste-table-002-expected.txt:
        * editing/pasteboard/paste-text-001-expected.txt:
        * editing/pasteboard/paste-text-002-expected.txt:
        * editing/pasteboard/paste-text-003-expected.txt:
        * editing/pasteboard/paste-text-004-expected.txt:
        * editing/pasteboard/paste-text-005-expected.txt:
        * editing/pasteboard/paste-text-006-expected.txt:
        * editing/pasteboard/paste-text-011-expected.txt:
        * editing/pasteboard/paste-text-012-expected.txt:
        * editing/pasteboard/paste-text-013-expected.txt:
        * editing/pasteboard/paste-text-014-expected.txt:
        * editing/pasteboard/paste-text-015-expected.txt:
        * editing/pasteboard/paste-text-016-expected.txt:
        * editing/pasteboard/paste-text-017-expected.txt:
        * editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
        * editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
        * editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
        * editing/pasteboard/styled-element-markup.html:
        * editing/pasteboard/testcase-9507-expected.txt:
        * editing/style/smoosh-styles-001-expected.txt:
        * editing/style/smoosh-styles-002-expected.txt:

WebCore:

        Reviewed by harrison

        <rdar://problem/4052343&4052343&4426622> Mail hung on paste text

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::isInterchangeNewlineNode):
        (WebCore::isInterchangeConvertedSpaceSpan):
        (WebCore::ReplacementFragment::ReplacementFragment):
        (WebCore::ReplaceSelectionCommand::removeRedundantStyles): Compute the redundant inheritable styles and
        remove them and remove style nodes and style spans which were only contributing redundant styles.
        (WebCore::ReplaceSelectionCommand::doApply):
        * editing/ReplaceSelectionCommand.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-08-22 Anders Carlsson <acarlsson@apple.com>
andersca [Tue, 22 Aug 2006 21:05:47 +0000 (21:05 +0000)]
2006-08-22  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Darin.

        Move the npruntime code over to using HashMap and the runtime_root code over to using
        HashMap and HashCountedSet.

        * bindings/NP_jsobject.cpp:
        * bindings/c/c_utility.cpp:
        (KJS::Bindings::identifierFromNPIdentifier):
        * bindings/c/c_utility.h:
        * bindings/jni/jni_jsobject.cpp:
        (JavaJSObject::invoke):
        * bindings/npruntime.cpp:
        (getStringIdentifierMap):
        (getIntIdentifierMap):
        (_NPN_GetStringIdentifier):
        (_NPN_GetIntIdentifier):
        * bindings/runtime_root.cpp:
        (getReferencesByRootMap):
        (getReferencesSet):
        (KJS::Bindings::findReferenceSet):
        (KJS::Bindings::rootForImp):
        (KJS::Bindings::rootForInterpreter):
        (KJS::Bindings::addNativeReference):
        (KJS::Bindings::removeNativeReference):
        (RootObject::removeAllNativeReferences):
        * bindings/runtime_root.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
harrison [Tue, 22 Aug 2006 20:59:19 +0000 (20:59 +0000)]
    Reviewed by Darin.

        <rdar://problem/4077676> Inline hole line adheres to the Japanese characters in inline hole

        This happens because the underline is always 2 pixels thick, and placed 3 pixels above the bottom of the text box.

        Test case added:
        * manual-tests/inline-input-marking.html: Added.
        Check that underlining of the inline input hole does not obscure the glyphs.

        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paintMarkedTextUnderline):
        Position underline at bottom of text box.
        Height of underline is reduced to 1 px when font's descent is less than or equal to 2 px.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
ggaren [Tue, 22 Aug 2006 20:23:08 +0000 (20:23 +0000)]
LayoutTests:

        Reviewed by ggaren.

        Introducing a small test suite for bugs related to various navigation techniques,
        e.g., back/forward, reload, various redirect flavors, POST, POST-then-redirect,
        within-page anchors.  Most of the tests are done with and without an enclosing frameset.
        The tests verify the content of the final page (which may include restored form
        state), scroll location (also sometimes restored), and the full content of the
        back-forward list.

        * fast/overflow/scrollRevealButton-expected.txt:
           Updated to include scroll location that is now emitted.
        * http/tests/navigation/anchor-basic-expected.txt: Added.
        * http/tests/navigation/anchor-basic.html: Added.
        * http/tests/navigation/anchor-frames-expected.txt: Added.
        * http/tests/navigation/anchor-frames.html: Added.
        * http/tests/navigation/anchor-goback-expected.txt: Added.
        * http/tests/navigation/anchor-goback.html: Added.
        * http/tests/navigation/anchor-subframeload-expected.txt: Added.
        * http/tests/navigation/anchor-subframeload.html: Added.
        * http/tests/navigation/error404-basic-expected.txt: Added.
        * http/tests/navigation/error404-basic.html: Added.
        * http/tests/navigation/error404-frames-expected.txt: Added.
        * http/tests/navigation/error404-frames.html: Added.
        * http/tests/navigation/error404-goback-expected.txt: Added.
        * http/tests/navigation/error404-goback.html: Added.
        * http/tests/navigation/error404-subframeload-expected.txt: Added.
        * http/tests/navigation/error404-subframeload.html: Added.
        * http/tests/navigation/javascriptlink-basic-expected.txt: Added.
        * http/tests/navigation/javascriptlink-basic.html: Added.
        * http/tests/navigation/javascriptlink-frames-expected.txt: Added.
        * http/tests/navigation/javascriptlink-frames.html: Added.
        * http/tests/navigation/javascriptlink-goback-expected.txt: Added.
        * http/tests/navigation/javascriptlink-goback.html: Added.
        * http/tests/navigation/javascriptlink-subframeload-expected.txt: Added.
        * http/tests/navigation/javascriptlink-subframeload.html: Added.
        * http/tests/navigation/metaredirect-basic-expected.txt: Added.
        * http/tests/navigation/metaredirect-basic.html: Added.
        * http/tests/navigation/metaredirect-frames-expected.txt: Added.
        * http/tests/navigation/metaredirect-frames.html: Added.
        * http/tests/navigation/metaredirect-goback-expected.txt: Added.
        * http/tests/navigation/metaredirect-goback.html: Added.
        * http/tests/navigation/metaredirect-subframeload-expected.txt: Added.
        * http/tests/navigation/metaredirect-subframeload.html: Added.
        * http/tests/navigation/post-basic-expected.txt: Added.
        * http/tests/navigation/post-basic.html: Added.
        * http/tests/navigation/post-frames-expected.txt: Added.
        * http/tests/navigation/post-frames-goback1.html-disabled: Added.
        * http/tests/navigation/post-frames.html: Added.
        * http/tests/navigation/post-goback1-expected.txt: Added.
        * http/tests/navigation/post-goback1.html: Added.
        * http/tests/navigation/post-goback2-expected.txt: Added.
        * http/tests/navigation/post-goback2.html: Added.
        * http/tests/navigation/postredirect-basic-expected.txt: Added.
        * http/tests/navigation/postredirect-basic.html: Added.
        * http/tests/navigation/postredirect-frames-expected.txt: Added.
        * http/tests/navigation/postredirect-frames-goback1.html-disabled: Added.
        * http/tests/navigation/postredirect-frames.html: Added.
        * http/tests/navigation/postredirect-goback1-expected.txt: Added.
        * http/tests/navigation/postredirect-goback1.html: Added.
        * http/tests/navigation/postredirect-goback2-expected.txt: Added.
        * http/tests/navigation/postredirect-goback2.html: Added.
        * http/tests/navigation/redirect302-basic-expected.txt: Added.
        * http/tests/navigation/redirect302-basic.html: Added.
        * http/tests/navigation/redirect302-frames-expected.txt: Added.
        * http/tests/navigation/redirect302-frames.html: Added.
        * http/tests/navigation/redirect302-goback-expected.txt: Added.
        * http/tests/navigation/redirect302-goback.html: Added.
        * http/tests/navigation/redirect302-subframeload-expected.txt: Added.
        * http/tests/navigation/redirect302-subframeload.html: Added.
        * http/tests/navigation/relativeanchor-basic-expected.txt: Added.
        * http/tests/navigation/relativeanchor-basic.html: Added.
        * http/tests/navigation/relativeanchor-frames-expected.txt: Added.
        * http/tests/navigation/relativeanchor-frames.html: Added.
        * http/tests/navigation/relativeanchor-goback-expected.txt: Added.
        * http/tests/navigation/relativeanchor-goback.html: Added.
        * http/tests/navigation/resources/error404.pl: Added.
        * http/tests/navigation/resources/frameset.pl: Added.
        * http/tests/navigation/resources/javascriptlink.html: Added.
        * http/tests/navigation/resources/metaredirect.html: Added.
        * http/tests/navigation/resources/otherpage.html: Added.
        * http/tests/navigation/resources/postresult.pl: Added.
        * http/tests/navigation/resources/redirect302.pl: Added.
        * http/tests/navigation/resources/slowmetaredirect.html: Added.
        * http/tests/navigation/resources/slowtimerredirect.html: Added.
        * http/tests/navigation/resources/success200.html: Added.
        * http/tests/navigation/resources/testcode.js: Added.
        * http/tests/navigation/resources/timerredirect.html: Added.
        * http/tests/navigation/slowmetaredirect-basic-expected.txt: Added.
        * http/tests/navigation/slowmetaredirect-basic.html: Added.
        * http/tests/navigation/slowtimerredirect-basic-expected.txt: Added.
        * http/tests/navigation/slowtimerredirect-basic.html: Added.
        * http/tests/navigation/success200-basic-expected.txt: Added.
        * http/tests/navigation/success200-basic.html: Added.
        * http/tests/navigation/success200-frames-expected.txt: Added.
        * http/tests/navigation/success200-frames-goback.html-disabled: Added.
        * http/tests/navigation/success200-frames-loadsame-expected.txt: Added.
        * http/tests/navigation/success200-frames-loadsame.html: Added.
        * http/tests/navigation/success200-frames-reload.html-disabled: Added.
        * http/tests/navigation/success200-frames.html: Added.
        * http/tests/navigation/success200-goback-expected.txt: Added.
        * http/tests/navigation/success200-goback.html: Added.
        * http/tests/navigation/success200-loadsame-expected.txt: Added.
        * http/tests/navigation/success200-loadsame.html: Added.
        * http/tests/navigation/success200-reload-expected.txt: Added.
        * http/tests/navigation/success200-reload.html: Added.
        * http/tests/navigation/success200-subframeload-expected.txt: Added.
        * http/tests/navigation/success200-subframeload-goback.html-disabled: Added.
        * http/tests/navigation/success200-subframeload.html: Added.
        * http/tests/navigation/timerredirect-basic-expected.txt: Added.
        * http/tests/navigation/timerredirect-basic.html: Added.
        * http/tests/navigation/timerredirect-frames-expected.txt: Added.
        * http/tests/navigation/timerredirect-frames.html: Added.
        * http/tests/navigation/timerredirect-goback-expected.txt: Added.
        * http/tests/navigation/timerredirect-goback.html: Added.
        * http/tests/navigation/timerredirect-subframeload-expected.txt: Added.
        * http/tests/navigation/timerredirect-subframeload.html: Added.

WebKitTools:

        Reviewed by ggaren.

        Added support for a new set of browser navigation tests.  The main feature
        is the ability for a test to queue up a set of future actions that will
        happen after that first page is loaded.  This is used to simulate a sequence
        of user actions such as filling out forms, loading additional pages or
        going back.  In addition we can now dump out the state of the back/forward
        list, and the scroll position is dumped if not at 0,0.

        * DumpRenderTree/DumpRenderTree.m:
        (main):  Init new state
        (compareHistoryItems):  New utility to support sorting.
        (dumpHistoryItem):  Write out a WebHistoryItem and kids.
        (dumpFrameScrollPosition):  Write out the scroll position.
        (dump):  Optionally write b/f list or scroll position.
        (-[WaitUntilDoneDelegate processWork:]):  Perform queued work.
        (-[WaitUntilDoneDelegate webView:locationChangeDone:forDataSource:]):
        Kick off any queued actions.  Fixed for the case of loads started in
        a subframe instead of the root frame.
        (-[WaitUntilDoneDelegate webView:didStartProvisionalLoadForFrame:]):
        Grab the topmost frame that is being loaded.  Do this as early as possible,
        instead of in didCommitLoadForFrame.
        (-[WaitUntilDoneDelegate webView:didCommitLoadForFrame:]):
        Noting a load has started now happens in previous method.
        (+[LayoutTestController isSelectorExcludedFromWebScript:]):  Boilerplate
        (+[LayoutTestController webScriptNameForSelector:]):  Boilerplate
        (-[LayoutTestController notifyDone]):  readyToDump var is subsumed by
        topFrameLoading
        (-[LayoutTestController dumpBackForwardList]):  New impl, just set a bit.
        (-[LayoutTestController _addWorkForTarget:selector:arg1:arg2:]):
        Add new work to the queue.
        (-[LayoutTestController _doLoad:target:]):  Do a queued load.
        (-[LayoutTestController _doBackOrForwardNav:]):  Do a queued back/forward.
        (-[LayoutTestController scheduleBackNav:]):  Ways for scripts to queue actions
        (-[LayoutTestController scheduleForwardNav:]):
        (-[LayoutTestController scheduleReload]):
        (-[LayoutTestController scheduleScript:]):
        (-[LayoutTestController scheduleLoad:target:]):
        (runTest):  Clear new state for each test.  Renamed from "dumpRenderTree"
        since it's not one of the functions that does any dumping.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-08-22 Anders Carlsson <acarlsson@apple.com>
andersca [Tue, 22 Aug 2006 19:45:25 +0000 (19:45 +0000)]
2006-08-22  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Geoff.

        Switch over the NPAPI and Java bindings to using HashMaps instead of dictionaries.

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * bindings/c/c_class.cpp:
        (KJS::Bindings::CClass::CClass):
        (KJS::Bindings::CClass::~CClass):
        (KJS::Bindings::CClass::classForIsA):
        (KJS::Bindings::CClass::methodsNamed):
        (KJS::Bindings::CClass::fieldNamed):
        * bindings/c/c_class.h:
        * bindings/jni/jni_class.cpp:
        (JavaClass::JavaClass):
        (JavaClass::~JavaClass):
        (JavaClass::methodsNamed):
        (JavaClass::fieldNamed):
        * bindings/jni/jni_class.h:
        * bindings/objc/objc_class.h:
        * bindings/objc/objc_class.mm:
        (KJS::Bindings::deleteMethod):
        (KJS::Bindings::deleteField):
        (KJS::Bindings::):
        (KJS::Bindings::ObjcClass::methodsNamed):
        (KJS::Bindings::ObjcClass::fieldNamed):
        * bindings/runtime.cpp:
        * bindings/runtime.h:
        * bindings/runtime_object.cpp:
        (RuntimeObjectImp::fieldGetter):
        (RuntimeObjectImp::getOwnPropertySlot):
        (RuntimeObjectImp::put):
        (RuntimeObjectImp::canPut):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric.
rwlbuis [Tue, 22 Aug 2006 18:56:33 +0000 (18:56 +0000)]
    Reviewed by Eric.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10402
        REPRO: SVG crashes inside gradient code

        Make sure we do not try to update the canvas resource/gradient paintserver when it is not yet built.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by John.
harrison [Tue, 22 Aug 2006 17:28:07 +0000 (17:28 +0000)]
    Reviewed by John.

        <rdar://problem/4523606> Represent heading elements in AXAttributedStringForTextMarkerRange

        * bridge/mac/WebCoreAXObject.mm:
        (headingLevel):
        (-[WebCoreAXObject headingLevel]):
        (-[WebCoreAXObject isHeading]):
        New. Heading level is per the tag (h1 == 1, h2 == 2, etc.)

        (-[WebCoreAXObject role]):
        (-[WebCoreAXObject roleDescription]):
        Add role and roleDescription for headings.

        (-[WebCoreAXObject value]):
        Value is the headingLevel.

        (AXAttributeStringSetHeadingLevel):
        (AXAttributedStringAppendText):
        Put text's heading level (if applicable) in the attributes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by John.
harrison [Tue, 22 Aug 2006 17:24:54 +0000 (17:24 +0000)]
    Reviewed by John.

        <rdar://problem/4522205> Represent controls in AXAttributedStringForTextMarkerRange

        Treat controls as replaced elements, so that AXAttributedStringForTextMarkerRange will, too.

        * editing/TextIterator.cpp:
        (WebCore::TextIterator::advance):
        Include controls.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
harrison [Tue, 22 Aug 2006 12:47:26 +0000 (12:47 +0000)]
    Reviewed by Maciej.

        <rdar://problem/4407336> Some non-text elements return AXTextMarkerRangeForUIElement with equal start and end marker

        * bridge/mac/WebCoreAXObject.mm:
        (-[WebCoreAXObject textMarkerRange]):
        Use 0 and maxDeepOffset(), instead of caretMinOffset() and caretMaxRenderedOffset().
        Check for VisiblePositions being equal.  If so, adjust end one to its next().
        That happens with, e.g., buttons.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric.
rwlbuis [Tue, 22 Aug 2006 11:13:21 +0000 (11:13 +0000)]
    Reviewed by Eric.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10491
        KCanvasMatrix removal

        Remove KCanvasMatrix from project, using AffineTransform instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric.
rwlbuis [Tue, 22 Aug 2006 08:20:13 +0000 (08:20 +0000)]
    Reviewed by Eric.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10405
        REPRO: SVG Maze crashes in RenderPath code

        Do not render a path when it is empty so maze15.svg does not crash anymore.
        Also get rid of a runtime warning issued by CGContextGetPathBoundingBox.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Brady.
mjs [Tue, 22 Aug 2006 07:22:00 +0000 (07:22 +0000)]
    Reviewed by Brady.

        - move more code from WebDataSource to WebFrameLoader

        Also marked a few more methods in WebDataSource as likely MOVABLE in a future round, since they do not
        use any of WebDataSource's private data.

        * Loader/WebFrameLoader.h:
        * Loader/WebFrameLoader.m:
        (-[WebFrameLoader addPlugInStreamLoader:]):
        (-[WebFrameLoader removePlugInStreamLoader:]):
        (-[WebFrameLoader addSubresourceLoader:]):
        (-[WebFrameLoader removeSubresourceLoader:]):
        (-[WebFrameLoader _didReceiveAuthenticationChallenge:forResource:]):
        (-[WebFrameLoader _didCancelAuthenticationChallenge:forResource:]):
        (-[WebFrameLoader _didReceiveResponse:forResource:]):
        (-[WebFrameLoader _didReceiveData:contentLength:forResource:]):
        (-[WebFrameLoader _didFinishLoadingForResource:]):
        (-[WebFrameLoader _didFailLoadingWithError:forResource:]):
        (-[WebFrameLoader _privateBrowsingEnabled]):
        (-[WebFrameLoader _finishedLoadingResource]):
        (-[WebFrameLoader _receivedError:]):
        (-[WebFrameLoader _finishedLoading]):
        * Loader/WebMainResourceLoader.m:
        (-[WebMainResourceLoader didReceiveData:lengthReceived:allAtOnce:]):
        (-[WebMainResourceLoader didFinishLoading]):
        * Loader/WebNetscapePlugInStreamLoader.m:
        (-[WebNetscapePlugInStreamLoader didFinishLoading]):
        (-[WebNetscapePlugInStreamLoader didFailWithError:]):
        (-[WebNetscapePlugInStreamLoader cancelWithError:]):
        * Loader/WebSubresourceLoader.m:
        (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]):
        (-[WebSubresourceLoader signalFinish]):
        (-[WebSubresourceLoader didFailWithError:]):
        (-[WebSubresourceLoader cancel]):
        * Plugins/WebNetscapePluginStream.m:
        (-[WebNetscapePluginStream start]):
        * WebView/WebDataSource.m:
        (-[WebDataSource _replaceSelectionWithArchive:selectReplacement:]):
        (-[WebDataSource _updateIconDatabaseWithURL:]):
        (-[WebDataSource _loadIcon]):
        (-[WebDataSource _setPrimaryLoadComplete:]):
        (-[WebDataSource _cancelledError]):
        (+[WebDataSource _repTypesAllowImageTypeOmission:]):
        (+[WebDataSource _representationClassForMIMEType:]):
        (-[WebDataSource _commitLoadWithData:]):
        (-[WebDataSource _receivedMainResourceError:complete:]):
        (-[WebDataSource _iconLoaderReceivedPageIcon:]):
        (-[WebDataSource _isDocumentHTML]):
        * WebView/WebDataSourceInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej
beidson [Tue, 22 Aug 2006 07:08:01 +0000 (07:08 +0000)]
    Reviewed by Maciej

        <rdar://4690949> - New IconDB: Need to prune unretained icons on startup

        Added a flag to track whether or not the initial pruning has taken place on startup
        If that flag is not set, IconURL retain counts will be tracked in a temporary db table
        in addition to the in-memory hash.  Then when the timer fires after initial retains
        are complete, we prune those icons not in the retain table, prune dangling PageURL
        references, delete the temporary table, and set the flag - and carry on as normal

        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::IconDatabase): initialize the flag
        (WebCore::IconDatabase::open): changed the schema of the temporary table
        (WebCore::IconDatabase::retainIconURL): store the icon retain to the temp table if starting up
        (WebCore::IconDatabase::releaseIconURL): ditto
        (WebCore::IconDatabase::pruneUnretainedIconsOnStartup): remove all icons *not* in the retain table, then
          wipe all the PageURLs who no longer point to a valid IconURL
        * loader/icon/IconDatabase.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric.
ap [Tue, 22 Aug 2006 04:32:02 +0000 (04:32 +0000)]
    Reviewed by Eric.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10419
        XSLTProcessor transformToFragment fails because of an XML declaration

        Test: fast/xsl/transformToFragment-XML-declaration.html

        * xml/XSLTProcessor.cpp:
        (WebCore::XSLTProcessor::transformToString): Always inhibit XML declaration printout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Justin.
harrison [Tue, 22 Aug 2006 00:51:35 +0000 (00:51 +0000)]
    Reviewed by Justin.

        <rdar://problem/4471481> Represent misspellings in AXAttributedStringForTextMarkerRange

        Added support for the NSAccessibilityMisspelledTextAttribute.

        Test cases added: None.  Manual AX testing is way too awkward, and automated testing
        is not possible.  See following bug...
            <rdar://problem/4256882> Need automated testing support for accessibility APIs

        * bridge/mac/WebCoreAXObject.mm:
        Lots of trivial formatting in many methods.

        (-[WebCoreAXObject accessibilityAttributeValue:]):
        Fixed AXStartTextMarker and AXEndTextMarker to use startOfDocument and endOfDocument, instead of
        of positionForCoordinates. I had seen erroneous endOfDocument results while testing the spelling
        attribute.

        (WebCore::AXAttributeStringSetSpelling):
        New. Adds the NSAccessibilityMisspelledTextAttribute for misspelled words.

        (-[WebCoreAXObject AXAttributedStringAppendText:]):
        Added call to AXAttributeStringSetSpelling.

        * editing/visible_units.cpp:
        (WebCore::startOfDocument):
        (WebCore::endOfDocument):
        Added for AXStartTextMarker/AXEndTextMarker fix, these forms of the familiar functions take a Node*,
        so a previously existing VisiblePosition is not required.

        * editing/visible_units.h:
        Declare new forms of startOfDocument and endOfDocument.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
thatcher [Tue, 22 Aug 2006 00:16:49 +0000 (00:16 +0000)]
    Reviewed by Darin.

        Bug 9302: WebKit nightly download image says ~2.5 MB when
        universal binaries make it ~5.0 MB
        http://bugzilla.opendarwin.org/show_bug.cgi?id=9302

        * images/download.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Stamped by Maciej.
thatcher [Mon, 21 Aug 2006 23:35:19 +0000 (23:35 +0000)]
    Stamped by Maciej.

        Changes many opendarwin.org links to the proper webkit.org version.

        * blog/wp-content/themes/webkit/sidebar.php:
        * blog/wp-content/themes/webkit/style.css:
        * building/build.html:
        * coding/contributing.html:
        * contact.html:
        * index.html:
        * nav.inc:
        * projects/compat/hitlist.html:
        * projects/css/index.html:
        * projects/editing/index.html:
        * projects/forms/index.html:
        * projects/html/index.html:
        * projects/javascript/index.html:
        * projects/svg/index.html:
        * projects/svg/svg-status.xsl:
        * projects/xslt/index.html:
        * quality/bugpriorities.html:
        * quality/bugzilla.html:
        * quality/leakhunting.html:
        * quality/lifecycle.html:
        * quality/reporting.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric.
weinig [Mon, 21 Aug 2006 23:26:15 +0000 (23:26 +0000)]
    Reviewed by Eric.

        Fixes parts of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
        WebKit should have Qt platform support

        * platform/qt/TemporaryLinkStubs.cpp: Added.
        (JavaAppletWidget::JavaAppletWidget):
        (Font::selectionRectForComplexText):
        (Font::offsetForPositionForComplexText):
        (WebCore::refreshPlugins):
        (WebCore::focusRingColor):
        (Image::drawTiled):
        (WebCore::TextField::selectAll):
        (WebCore::TextField::addSearchResult):
        (WebCore::TextField::selectionStart):
        (WebCore::TextField::hasSelectedText):
        (WebCore::TextField::selectedText):
        (WebCore::TextField::setAutoSaveName):
        (WebCore::TextField::checksDescendantsForFocus):
        (WebCore::TextField::setSelection):
        (WebCore::TextField::setMaxResults):
        (WebCore::TextField::edited):
        (WebCore::TextField::focusPolicy):
        (WebCore::TextField::TextField):
        (WebCore::TextField::~TextField):
        (WebCore::TextField::setFont):
        (WebCore::TextField::setAlignment):
        (WebCore::TextField::setWritingDirection):
        (WebCore::TextField::maxLength):
        (WebCore::TextField::setMaxLength):
        (WebCore::TextField::text):
        (WebCore::TextField::setText):
        (WebCore::TextField::cursorPosition):
        (WebCore::TextField::setCursorPosition):
        (WebCore::TextField::setEdited):
        (WebCore::TextField::setReadOnly):
        (WebCore::TextField::setPlaceholderString):
        (WebCore::TextField::setColors):
        (WebCore::TextField::sizeForCharacterWidth):
        (WebCore::TextField::baselinePosition):
        (WebCore::TextField::setLiveSearch):
        (WebCore::Slider::Slider):
        (WebCore::Slider::sizeHint):
        (WebCore::Slider::~Slider):
        (WebCore::Slider::setValue):
        (WebCore::Slider::setMaxValue):
        (WebCore::Slider::setMinValue):
        (WebCore::Slider::setFont):
        (WebCore::Slider::value):
        (WebCore::Slider::focusPolicy):
        (WebCore::ScrollBar::ScrollBar):
        (WebCore::ScrollBar::setSteps):
        (WebCore::ScrollBar::scroll):
        (WebCore::ScrollBar::setValue):
        (WebCore::ScrollBar::setKnobProportion):
        (WebCore::PlatformScrollBar::PlatformScrollBar):
        (WebCore::PlatformScrollBar::~PlatformScrollBar):
        (WebCore::PlatformScrollBar::width):
        (WebCore::PlatformScrollBar::height):
        (WebCore::PlatformScrollBar::setEnabled):
        (WebCore::PlatformScrollBar::paint):
        (WebCore::PlatformScrollBar::setScrollBarValue):
        (WebCore::PlatformScrollBar::setKnobProportion):
        (WebCore::PlatformScrollBar::setRect):
        (WebCore::PlatformMouseEvent::PlatformMouseEvent):
        (WebCore::CheckCacheObjectStatus):
        (WebCore::CheckIfReloading):
        (WebCore::ServeSynchronousRequest):
        (WebCore::historyContains):
        (WebCore::submitButtonDefaultLabel):
        (WebCore::inputElementAltText):
        (WebCore::resetButtonDefaultLabel):
        (WebCore::defaultLanguage):
        (WebCore::findNextSentenceFromIndex):
        (WebCore::findSentenceBoundary):
        (WebCore::findNextWordFromIndex):
        (WebCore::findWordBoundary):
        (Frame::setNeedsReapplyStyles):
        (WebCore::screenDepthPerComponent):
        (WebCore::screenIsMonochrome):
        (WebCore::searchableIndexIntroduction):
        (WebCore::setFocusRingColorChangeFunction):
        (FrameView::updateBorder):
        (loadResourceIntoArray):
        (PlugInInfoStore::createPluginInfoForPluginAtIndex):
        (PlugInInfoStore::pluginCount):
        (WebCore::PlugInInfoStore::supportsMIMEType):
        (FileButton::FileButton):
        (FileButton::click):
        (FileButton::sizeForCharacterWidth):
        (FileButton::focusPolicy):
        (FileButton::frameGeometry):
        (FileButton::setFilename):
        (FileButton::baselinePosition):
        (FileButton::setFrameGeometry):
        (FileButton::setDisabled):
        (WebCore::supportedKeySizes):
        (WebCore::signedPublicKeyAndChallengeString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
weinig [Mon, 21 Aug 2006 23:15:15 +0000 (23:15 +0000)]
    Reviewed by Maciej.

        Fixes parts of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
        WebKit should have Qt platform support

        * platform/qt/CursorQt.cpp: Added.
        (WebCore::Cursor::Cursor):
        (WebCore::Cursor::~Cursor):
        (WebCore::Cursor::operator=):
        (WebCore::Cursors::Cursors::self):
        (WebCore::moveCursor):
        (WebCore::crossCursor):
        (WebCore::handCursor):
        (WebCore::iBeamCursor):
        (WebCore::waitCursor):
        (WebCore::helpCursor):
        (WebCore::eastResizeCursor):
        (WebCore::northResizeCursor):
        (WebCore::northEastResizeCursor):
        (WebCore::northWestResizeCursor):
        (WebCore::southResizeCursor):
        (WebCore::southEastResizeCursor):
        (WebCore::southWestResizeCursor):
        (WebCore::westResizeCursor):
        (WebCore::northSouthResizeCursor):
        (WebCore::eastWestResizeCursor):
        (WebCore::northEastSouthWestResizeCursor):
        (WebCore::northWestSouthEastResizeCursor):
        (WebCore::columnResizeCursor):
        (WebCore::rowResizeCursor):
        * platform/qt/RenderThemeQt.cpp: Added.
        (WebCore::RenderThemeQt::RenderThemeQt):
        (WebCore::RenderThemeQt::supportsHover):
        (WebCore::RenderThemeQt::paintCheckbox):
        (WebCore::RenderThemeQt::paintRadio):
        (WebCore::theme):
        (WebCore::RenderThemeQt::isControlStyled):
        (WebCore::RenderThemeQt::controlSupportsTints):
        (WebCore::RenderThemeQt::systemFont):
        (WebCore::RenderThemeQt::createPopupMenu):
        (WebCore::RenderThemeQt::addIntrinsicMargins):
        (WebCore::RenderThemeQt::stylePainterAndWidgetForPaintInfo):
        (WebCore::RenderThemeQt::setCheckboxSize):
        (WebCore::RenderThemeQt::setRadioSize):
        (WebCore::RenderThemeQt::supportsFocus):
        (WebCore::RenderThemeQt::applyTheme):
        (WebCore::RenderThemeQt::adjustButtonStyle):
        (WebCore::RenderThemeQt::paintButton):
        (WebCore::RenderThemeQt::adjustTextFieldStyle):
        (WebCore::RenderThemeQt::paintTextField):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
weinig [Mon, 21 Aug 2006 23:04:03 +0000 (23:04 +0000)]
    Reviewed by Maciej.

        Fixes parts of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10463
        WebKit should have Qt platform support

        * platform/qt/SharedTimerQt.cpp: Added.
        (WebCore:setSharedTimerFiredFunction):
        (WebCore::setSharedTimerFireTime):
        (WebCore::stopSharedTimer):
        * platform/qt/SharedTimerQt.h: Added.
        (WebCore::SharedTimerQt::SharedTimerQt):
        (WebCore::SharedTimerQt::~SharedTimerQt):
        (WebCore::SharedTimerQt::inst):
        (WebCore::SharedTimerQt::fire):
        * platform/qt/SystemTimeQt.cpp: Added.
        (WebCore::currentTime):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
beidson [Mon, 21 Aug 2006 21:05:23 +0000 (21:05 +0000)]
WebCore:

        Reviewed by John

        -Defers writing to the database via a timer and handles starting the timer
         intelligently

        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::IconDatabase):
        (WebCore::IconDatabase::open): Don't start the update timer by default
        (WebCore::IconDatabase::close): Call syncDatabase()
        (WebCore::IconDatabase::setPrivateBrowsingEnabled): Call syncDatabase()
        (WebCore::IconDatabase::setIconURLForPageURL): Setup the cached url, but defer the DB call
        (WebCore::IconDatabase::setIconURLForPageURLInDatabase): Actually commit the url to the DB
        (WebCore::IconDatabase::pruneUnretainedIconsOnStartup):
        (WebCore::IconDatabase::updateDatabase): The updateTimer calls this, which just calls syncDatabase()
        (WebCore::IconDatabase::syncDatabase): Add and remove pending pageURLs and iconURLs, and stop the updateTimer
        * loader/icon/IconDatabase.h:

WebKit:

        Reviewed by John

        Quick ICONDEBUG flag fix

        * Misc/WebIconDatabase.m:
        (-[WebIconDatabase _applicationWillTerminate:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-08-21 Vladimir Olexa <vladimir.olexa@gmail.com>
ap [Mon, 21 Aug 2006 17:43:55 +0000 (17:43 +0000)]
2006-08-21  Vladimir Olexa  <vladimir.olexa@gmail.com>

        Reviewed by Darin.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=6252
        JavaScript 1.6 Array.lastIndexOf

        Test: fast/js/array-lastIndexOf.html

        * kjs/array_object.cpp:
        (ArrayProtoFunc::callAsFunction): Added a LastIndexOf case.
        * kjs/array_object.h:
        (KJS::ArrayProtoFunc::): Added LastIndexOf to enum.
        * tests/mozilla/expected.html: Two more tests now pass.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric.
ap [Mon, 21 Aug 2006 16:55:02 +0000 (16:55 +0000)]
    Reviewed by Eric.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=10429
          XSLTProcessor.transformToFragment crashes if the owner document is empty

        Test: fast/js/xslt-fragment-in-empty-doc.html

        * dom/XMLTokenizer.cpp:
        (WebCore::XMLTokenizer::XMLTokenizer): Don't iterate over the element stack if it's empty.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Anders
beidson [Mon, 21 Aug 2006 08:55:42 +0000 (08:55 +0000)]
    Reviewed by Anders

        -Renamed an internal only method for clarity
        -Tweaked WebDataSource for notification purposes with the new expiring icons
        -Fixed a bug with the ICONDEBUG flag

        * Misc/WebIconDatabase.m:
        (-[WebIconDatabase init]):
        (-[WebIconDatabase iconForURL:withSize:cache:]): #ifdef bug fixed
        (-[WebIconDatabase _hasEntryForIconURL:]): Renamed for clarity
        * Misc/WebIconDatabasePrivate.h:
        * WebView/WebDataSource.m:
        (-[WebDataSource _updateIconDatabaseWithURL:]):
        (-[WebDataSource _notifyIconChanged:]):
        (-[WebDataSource _loadIcon]):
        (-[WebDataSource _iconLoaderReceivedPageIcon:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Anders
beidson [Mon, 21 Aug 2006 08:55:20 +0000 (08:55 +0000)]
    Reviewed by Anders

        -Added timer-based, deferred deletion of database records - PageURLs and Icons handled seperately
         In the near future, we'll also have timer-based deferred *addition* of database records
        -Keep retain/release counts in a hash instead of a DB table
        -Keep only one hash record for the SiteIcons
        -Renamed some methods for clarity

        * bridge/mac/WebCoreIconDatabaseBridge.h: Renamed method for clarity
        * bridge/mac/WebCoreIconDatabaseBridge.mm: Ditto
        (-[WebCoreIconDatabaseBridge _hasEntryForIconURL:]): Ditto
        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::IconDatabase):
        (WebCore::IconDatabase::open): Added new timer setup
        (WebCore::IconDatabase::iconForPageURL): Only work with one hash of the SiteIcons
        (WebCore::IconDatabase::retainIconForPageURL): Keep count in a hash
        (WebCore::IconDatabase::releaseIconForPageURL): Keep count in a hash, use deferred deletion
        (WebCore::IconDatabase::retainIconURL): Added
        (WebCore::IconDatabase::releaseIconURL): Added
        (WebCore::IconDatabase::forgetPageURL):  Added
        (WebCore::IconDatabase::isIconURLRetained): New and improved simplicity
        (WebCore::IconDatabase::setIconDataForIconURL): Cleanup
        (WebCore::IconDatabase::setIconURLForPageURL):
        (WebCore::IconDatabase::pruneUnretainedIconsOnStartup): Renamed
        (WebCore::IconDatabase::pruneIconsPendingDeletion): Added
        (WebCore::IconDatabase::hasEntryForIconURL): Renamed for clarity
        * loader/icon/IconDatabase.h: Added multiple stuffs

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej's rubberstamp
beidson [Mon, 21 Aug 2006 07:51:41 +0000 (07:51 +0000)]
    Reviewed by Maciej's rubberstamp

        Removed stale file references from the Xcode.proj

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Brady.
mjs [Mon, 21 Aug 2006 00:01:52 +0000 (00:01 +0000)]
    Reviewed by Brady.

        - pull a bit of WebDataSource code into WebFrameLoader

        * Loader/WebFrameLoader.m:
        (-[WebFrameLoader _receivedError:]):
        (-[WebFrameLoader webFrame]):
        (-[WebFrameLoader _handleFallbackContent]):
        (+[WebFrameLoader _canShowMIMEType:]):
        (+[WebFrameLoader _representationExistsForURLScheme:]):
        (+[WebFrameLoader _generatedMIMETypeForURLScheme:]):
        * WebView/WebDataSource.m:
        * WebView/WebDataSourceInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
rwlbuis [Sun, 20 Aug 2006 22:27:28 +0000 (22:27 +0000)]
JavaScriptCore:

        Reviewed by Maciej. Landed by rwlbuis.

        Fixes parts of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10463
        WebKit should have Qt platform support

        Removing obsolete QConstString/QString constructors in kjs code.

WebCore:

        Reviewed by Maciej. Landed by rwlbuis.

        Fixes parts of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10463
        WebKit should have Qt platform support

        Removing HelperQt.h usage by creating appropriate operators
        constructor in some of the platform classes, as suggested by Darin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-08-18 Steve Falkenburg <sfalken@apple.com>
sfalken [Sat, 19 Aug 2006 05:35:27 +0000 (05:35 +0000)]
2006-08-18  Steve Falkenburg  <sfalken@apple.com>

        Rubber stamped by adele.

        Fix call to WebFormDelegate's textFieldDidBeginEditing.

        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::subtreeHasChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric. Landed by rwlbuis.
rwlbuis [Fri, 18 Aug 2006 23:26:51 +0000 (23:26 +0000)]
    Reviewed by Eric. Landed by rwlbuis.

        Next chunk of the implementation for:
        http://bugzilla.opendarwin.org/show_bug.cgi?id=10467

        WebKit should have Qt platform support

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric. Landed by rwlbuis.
rwlbuis [Fri, 18 Aug 2006 23:20:27 +0000 (23:20 +0000)]
    Reviewed by Eric. Landed by rwlbuis.

        Next chunk of the implementation for:
        http://bugzilla.opendarwin.org/show_bug.cgi?id=10467

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric. Landed by rwlbuis.
rwlbuis [Fri, 18 Aug 2006 22:47:37 +0000 (22:47 +0000)]
    Reviewed by Eric. Landed by rwlbuis.

        First chunk of the implementation for:
        http://bugzilla.opendarwin.org/show_bug.cgi?id=10467

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric. Landed by rwlbuis.
rwlbuis [Fri, 18 Aug 2006 22:16:42 +0000 (22:16 +0000)]
    Reviewed by Eric. Landed by rwlbuis.

        First chunk of the implementation for:
        http://bugzilla.opendarwin.org/show_bug.cgi?id=10467

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoI hope I got this finally right, learning all the time :|
rwlbuis [Fri, 18 Aug 2006 19:33:48 +0000 (19:33 +0000)]
I hope I got this finally right, learning all the time :|

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAccidently doubly applied patch for:
rwlbuis [Fri, 18 Aug 2006 19:26:47 +0000 (19:26 +0000)]
Accidently doubly applied patch for:
Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10463
Sorry for any inconvenience!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric. Landed by rwlbuis.
rwlbuis [Fri, 18 Aug 2006 19:11:41 +0000 (19:11 +0000)]
     Reviewed by Eric. Landed by rwlbuis.

         Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10470
         The Qt platform needs a KCanvas device.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej. Landed by rwlbuis.
rwlbuis [Fri, 18 Aug 2006 18:53:25 +0000 (18:53 +0000)]
    Reviewed by Maciej. Landed by rwlbuis.

        Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10463
        WTF Changes needed for Qt platform code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFixing my mistakes with landing of:
rwlbuis [Fri, 18 Aug 2006 13:03:33 +0000 (13:03 +0000)]
Fixing my mistakes with landing of:
Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10466

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoI forgot to commit this as part of:
rwlbuis [Fri, 18 Aug 2006 11:58:13 +0000 (11:58 +0000)]
I forgot to commit this as part of:
Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10464

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric. Landed by rwlbuis.
rwlbuis [Fri, 18 Aug 2006 11:45:29 +0000 (11:45 +0000)]
    Reviewed by Eric. Landed by rwlbuis.

        Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10466
        WebKit should have Qt platform support.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric. Landed by rwlbuis.
rwlbuis [Fri, 18 Aug 2006 11:21:58 +0000 (11:21 +0000)]
    Reviewed by Eric. Landed by rwlbuis.

        Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10465
        General WebKit Linux build fixes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric. Landed by rwlbuis.
rwlbuis [Fri, 18 Aug 2006 11:04:01 +0000 (11:04 +0000)]
    Reviewed by Eric. Landed by rwlbuis.

        Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10464
        Offer a cmake build system for Qt platform.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by John Sullivan.
harrison [Thu, 17 Aug 2006 23:05:43 +0000 (23:05 +0000)]
    Reviewed by John Sullivan.

        <rdar://problem/4671069> REGRESSION: Popup buttons in web pages aren't exposed as AXPopupButtons

        Accessorized RenderMenuList objects.

        * bridge/mac/WebCoreAXObject.mm:
        (-[WebCoreAXObject mouseButtonListener]):
        Trivial formatting.

        (-[WebCoreAXObject actionElement]):
        Return the HTMLSelectElement.

        (-[WebCoreAXObject firstChild]):
        (-[WebCoreAXObject lastChild]):
        (-[WebCoreAXObject previousSibling]):
        (-[WebCoreAXObject nextSibling]):
        (-[WebCoreAXObject parentObject]):
        (-[WebCoreAXObject parentObjectUnignored]):
        (-[WebCoreAXObject isAttachment]):
        (-[WebCoreAXObject attachmentView]):
        Trivial formatting.

        (-[WebCoreAXObject role]):
        Return NSAccessibilityPopUpButtonRole.

        (-[WebCoreAXObject subrole]):
        Trivial formatting.

        (-[WebCoreAXObject roleDescription]):
        Return NSAccessibilityPopUpButtonRole.

        (-[WebCoreAXObject textUnderElement]):
        Trivial formatting.

        (-[WebCoreAXObject value]):
        Return the RenderMenuList::text().

        (-[WebCoreAXObject position]):
         Trivial formatting.

        (-[WebCoreAXObject accessibilityIsIgnored]):
        - Ignore popup menu items because AppKit does.
        - Remove redundant check for buttonTag (earlier isControl() check suffices).

        (-[WebCoreAXObject accessibilityAttributeNames]):
        (-[WebCoreAXObject accessibilityActionNames]):
        (-[WebCoreAXObject accessibilityAttributeValue:]):
        Trivial formatting.

        (-[WebCoreAXObject doAXTextMarkerRangeForUnorderedTextMarkers:]):
        Removed old debugging code that is no longer needed.
        Trivial formatting.

        (-[WebCoreAXObject doAXSentenceTextMarkerRangeForTextMarker:]):
        (-[WebCoreAXObject doAXParagraphTextMarkerRangeForTextMarker:]):
        (-[WebCoreAXObject removeAXObjectID]):
        Trivial formatting.

        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::accessKeyAction):
        Call click() instead of focus().

        * rendering/RenderMenuList.cpp:
        (WebCore::RenderMenuList::text):
        Added for easy access to popup's current text.

        * rendering/RenderMenuList.h:
        (WebCore::RenderMenuList::isMenuList):
        * rendering/RenderObject.h:
        (WebCore::RenderObject::isMenuList):
        Added so popups can be identified.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Kevin Decker.
thatcher [Thu, 17 Aug 2006 22:23:18 +0000 (22:23 +0000)]
    Reviewed by Kevin Decker.

        <rdar://problem/4606857> WebKit: WebPreferencesChangedNotification not exported in 64-bit

        * WebKit.LP64.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-08-17 Anders Carlsson <acarlsson@apple.com>
andersca [Thu, 17 Aug 2006 20:37:49 +0000 (20:37 +0000)]
2006-08-17  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Maciej.

        * bindings/npapi.h:
        Fix ifdef.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
harrison [Thu, 17 Aug 2006 20:06:43 +0000 (20:06 +0000)]
    Reviewed by Maciej.

        <rdar://problem/4527201> REGRESSION: AXTextMarkerRangeForUnorderedTextMarkers returns out of order range

        Test cases added: None.  Manual AX testing is way too awkward, and automated testing
        is not possible.  See following bug...
            <rdar://problem/4256882> Need automated testing support for accessibility APIs

        * bridge/mac/AXObjectCacheMac.mm:
        (WebCore::AXObjectCache::visiblePositionForTextMarker):
        Validate the marker by comparing the node and offset to those of the resulting VisiblePosition.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Kevin Decker.
thatcher [Thu, 17 Aug 2006 19:58:53 +0000 (19:58 +0000)]
    Reviewed by Kevin Decker.

        <rdar://problem/4633896> -[WebView close] should clear all delegates and call setHostWindow:nil
        <rdar://problem/4649759> Crash when selecting View Source menu using Chinese (-[WebView _close])

        Check to make sure _private is not null. A WebView can be dealloced before _private is setup.
        Set the _private->closed flag at the beginning of _close to prevent reentry.
        Set the host window and all the delegates to nil in _close.

        * WebView/WebView.m:
        (-[WebView _close]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by thatcher
justing [Wed, 16 Aug 2006 22:59:38 +0000 (22:59 +0000)]
    Reviewed by thatcher

        Equivalent render tree:
        * fast/events/ondragenter-expected.checksum:
        * fast/events/ondragenter-expected.txt:

        Patch exposed a bug (10449):
        * fast/lists/drag-into-marker.html: Removed.
        * fast/lists/drag-into-marker.html-disabled: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Anders. Landed by rwlbuis.
rwlbuis [Wed, 16 Aug 2006 22:34:33 +0000 (22:34 +0000)]
    Reviewed by Anders. Landed by rwlbuis.

        Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10447
        AffineTransform should be multi-platform compatible

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix an issue with CSS2 system fonts where they did not respect text
hyatt [Wed, 16 Aug 2006 22:07:16 +0000 (22:07 +0000)]
    Fix an issue with CSS2 system fonts where they did not respect text
        zoom.  This was most visible with the new control fonts used for form
        controls (they stopped swapping between small/mini/regular as you zoomed).

        Reviewed by beth

        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
justing [Wed, 16 Aug 2006 21:17:47 +0000 (21:17 +0000)]
LayoutTests:

        Reviewed by thatcher

        Added:
        * editing/pasteboard/interchange-newline-4-expected.checksum: Added.
        * editing/pasteboard/interchange-newline-4-expected.png: Added.
        * editing/pasteboard/interchange-newline-4-expected.txt: Added.
        * editing/pasteboard/interchange-newline-4.html: Added.
        * editing/deleting/paragraph-in-preserveNewline-expected.checksum: Added.
        * editing/deleting/paragraph-in-preserveNewline-expected.png: Added.
        * editing/deleting/paragraph-in-preserveNewline-expected.txt: Added.
        * editing/deleting/paragraph-in-preserveNewline.html: Added.

        Equivalent render trees, fixes, or bugs exposed (10427, 10428):
        * editing/execCommand/insertHTML-expected.checksum:
        * editing/execCommand/insertHTML-expected.png:
        * editing/execCommand/insertHTML-expected.txt:
        * editing/execCommand/insertHTML.html:
        * editing/execCommand/insertHorizontalRule-expected.checksum:
        * editing/execCommand/insertHorizontalRule-expected.png:
        * editing/execCommand/insertHorizontalRule-expected.txt:
        * editing/inserting/insert-3786362-fix-expected.checksum:
        * editing/inserting/insert-3786362-fix-expected.png:
        * editing/inserting/insert-3786362-fix-expected.txt:
        * editing/inserting/insert-3786362-fix.html:
        * editing/inserting/insert-3907422-fix-expected.txt:
        * editing/pasteboard/3976872-expected.checksum:
        * editing/pasteboard/3976872-expected.png:
        * editing/pasteboard/3976872-expected.txt:
        * editing/pasteboard/4076267-3-expected.checksum:
        * editing/pasteboard/4076267-3-expected.png:
        * editing/pasteboard/4076267-3-expected.txt:
        * editing/pasteboard/4076267-3.html:
        * editing/pasteboard/4076267-expected.checksum:
        * editing/pasteboard/4076267-expected.png:
        * editing/pasteboard/4076267-expected.txt:
        * editing/pasteboard/4076267.html:
        * editing/pasteboard/4242293-1-expected.txt:
        * editing/pasteboard/4242293-expected.checksum:
        * editing/pasteboard/4242293-expected.png:
        * editing/pasteboard/4242293-expected.txt:
        * editing/pasteboard/4631972-expected.txt:
        * editing/pasteboard/8145-1-expected.txt:
        * editing/pasteboard/8145-3-expected.txt:
        * editing/pasteboard/block-wrappers-necessary-expected.txt:
        * editing/pasteboard/copy-paste-bidi-expected.txt:
        * editing/pasteboard/display-block-on-spans-expected.checksum:
        * editing/pasteboard/display-block-on-spans-expected.png:
        * editing/pasteboard/display-block-on-spans-expected.txt:
        * editing/pasteboard/interchange-newline-1-expected.txt:
        * editing/pasteboard/merge-end-1-expected.checksum:
        * editing/pasteboard/merge-end-1-expected.png:
        * editing/pasteboard/merge-end-1-expected.txt:
        * editing/pasteboard/merge-end-1.html:
        * editing/pasteboard/merge-end-2-expected.checksum:
        * editing/pasteboard/merge-end-2-expected.png:
        * editing/pasteboard/merge-end-2-expected.txt:
        * editing/pasteboard/merge-end-2.html:
        * editing/pasteboard/merge-end-4-expected.txt:
        * editing/pasteboard/merge-end-list-expected.txt:
        * editing/pasteboard/merge-end-table-expected.checksum:
        * editing/pasteboard/merge-end-table-expected.png:
        * editing/pasteboard/merge-end-table-expected.txt:
        * editing/pasteboard/nested-blocks-with-text-area-expected.txt:
        * editing/pasteboard/nested-blocks-with-text-field-expected.txt:
        * editing/pasteboard/paste-4039777-fix-expected.checksum:
        * editing/pasteboard/paste-4039777-fix-expected.png:
        * editing/pasteboard/paste-4039777-fix-expected.txt:
        * editing/pasteboard/paste-line-endings-002-expected.txt:
        * editing/pasteboard/paste-line-endings-004-expected.txt:
        * editing/pasteboard/paste-line-endings-007-expected.txt:
        * editing/pasteboard/paste-line-endings-008-expected.txt:
        * editing/pasteboard/paste-line-endings-009-expected.txt:
        * editing/pasteboard/paste-match-style-002-expected.txt:
        * editing/pasteboard/paste-pre-001-expected.txt:
        * editing/pasteboard/paste-pre-002-expected.txt:
        * editing/pasteboard/paste-table-001-expected.checksum:
        * editing/pasteboard/paste-table-001-expected.png:
        * editing/pasteboard/paste-table-001-expected.txt:
        * editing/pasteboard/paste-table-003-expected.txt:
        * editing/pasteboard/paste-text-001-expected.txt:
        * editing/pasteboard/paste-text-003-expected.txt:
        * editing/pasteboard/paste-text-007-expected.checksum:
        * editing/pasteboard/paste-text-007-expected.png:
        * editing/pasteboard/paste-text-007-expected.txt:
        * editing/pasteboard/paste-text-008-expected.txt:
        * editing/pasteboard/paste-text-009-expected.txt:
        * editing/pasteboard/paste-text-010-expected.txt:
        * editing/pasteboard/paste-text-011-expected.txt:
        * editing/pasteboard/paste-text-012-expected.checksum:
        * editing/pasteboard/paste-text-012-expected.png:
        * editing/pasteboard/paste-text-012-expected.txt:
        * editing/pasteboard/paste-text-012.html:
        * editing/pasteboard/paste-text-013-expected.checksum:
        * editing/pasteboard/paste-text-013-expected.png:
        * editing/pasteboard/paste-text-013-expected.txt:
        * editing/pasteboard/paste-text-015-expected.txt:
        * editing/pasteboard/paste-text-017-expected.txt:
        * editing/pasteboard/paste-text-019-expected.checksum:
        * editing/pasteboard/paste-text-019-expected.png:
        * editing/pasteboard/paste-text-019-expected.txt:
        * editing/pasteboard/paste-text-019.html:
        * editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
        * editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
        * editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
        * editing/pasteboard/pasting-object-expected.txt:
        * editing/pasteboard/prevent-block-nesting-01-expected.txt:
        * editing/pasteboard/quirks-mode-br-1-expected.txt:
        * editing/pasteboard/smart-paste-001-expected.txt:
        * editing/pasteboard/smart-paste-002-expected.txt:
        * editing/pasteboard/smart-paste-003-expected.txt:
        * editing/pasteboard/smart-paste-004-expected.txt:
        * editing/pasteboard/smart-paste-005-expected.txt:
        * editing/pasteboard/smart-paste-006-expected.txt:
        * editing/pasteboard/smart-paste-007-expected.txt:
        * editing/pasteboard/smart-paste-008-expected.txt:
        * editing/pasteboard/undoable-fragment-removes-expected.checksum:
        * editing/pasteboard/undoable-fragment-removes-expected.png:
        * editing/pasteboard/undoable-fragment-removes-expected.txt:
        * editing/pasteboard/undoable-fragment-removes.html:
        * editing/style/smoosh-styles-001-expected.txt:
        * editing/style/smoosh-styles-002-expected.txt:

WebCore:

        Reviewed by thatcher

        First part of fix for:
        <rdar://problem/4384589>
        Mail hung on paste text

        Fixes:
        <http://bugzilla.opendarwin.org/show_bug.cgi?id=8592>
        Extra line left after deleting whitespace:pre text
        <rdar://problem/4128080> Paste as HTML does not yield equivalent style
        <rdar://problem/4046469> Box styles on first element aren't copied/pasted
        Copy/paste of arstechnica.com

        Here's how we avoid adding redundant style information on paste: insert
        the fragment and do a test rendering, save away style information for
        every node in the fragment, remove all style information from the fragment,
        remove the fragment, insert it into the appropriate place in the document,
        then restore only those styles gathered during the test insertion that aren't
        redundant.  Restoring the styles in this way results in an ApplyStyleCommand
        and a layout for nearly every inserted node.
        Instead we want to insert the fragment into the document without removing the
        style information, then mark style nodes and inline style declarations for
        removal if they are redundant, and sweep to remove them.  This means that we
        can't rely on ReplacementFragment::wasBlock anymore, because blocks will now
        have style spans around them.  This patch removes the use of wasBlock in
        ReplaceSelectionCommand.

        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::moveParagraphs): Added code
        to remove the line placeholder left after a move from preserveNewline text.
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::doApply): Don't add a placeholder if
        we're deleting a paragraph in preserveNewline text.
        * editing/JSEditor.cpp: Pass true to prevent nesting.
        * editing/ReplaceSelectionCommand.cpp: Removed wasBlock and friends.
        (WebCore::ReplacementFragment::ReplacementFragment): Ditto.
        (WebCore::ReplacementFragment::saveRenderingInfo): Ditto.
        (WebCore::RenderingInfo::RenderingInfo): Ditto.
        (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand):
        (WebCore::ReplaceSelectionCommand::shouldMergeStart): Combined the to/from
        merging rules into one method.
        (WebCore::ReplaceSelectionCommand::shouldMergeEnd):
        (WebCore::ReplaceSelectionCommand::shouldMerge):
        (WebCore::ReplaceSelectionCommand::doApply):
        Don't do nesting prevention when pasting into an empty paragraph, this
        fixes 4046469, the common cause of paste fidelity bugs, but needs
        to be tweaked a little because this can lead to margin/border build-up
        on repeated copy/pastes.
        Don't track startPos in addition to insertionPos.  It was never used.
        Fixed a bug where a fragment starting with an interchange newline would
        cause content to be put outside of an editable region when pasting at the
        very end of it.
        Adjust insertionPos before insertion (not during) and do not consult wasBlock
        to decide whether or not to do so.
        Changed the way we do the start merge: insert the fragment, then stich
        paragraphs together, in the same way that we do the end merge.  This
        doesn't require wasBlock and fixes bugs.
        Replaced some uses of insertionPos with endOfInsertedContent.
        Fixed a bug in the expansion of the last incoming br (a "collapsed" br
        is one where !isStartOfParagraph([br,0])).
        Removed the special case code that did the end merge for the preserveNewline
        case, since this patch fixes the moveParagraph bug in the preserveNewline case.
        Removed some unused variables.
        (WebCore::ReplaceSelectionCommand::shouldRemoveEndBR): An endBR that was
        holding a line open should always be displaced by inserted content, unless
        the inserted content ends with a br.
        (WebCore::ReplaceSelectionCommand::updateNodesInserted):
        * editing/ReplaceSelectionCommand.h:
        (WebCore::RenderingInfo::style):
        * editing/markup.cpp:
        (WebCore::createMarkup): Only add mail blockquotes and list/table/pre when
        annotate is true (when we're creating markup for the pasteboard).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix Win32 build bustage.
hyatt [Wed, 16 Aug 2006 18:56:27 +0000 (18:56 +0000)]
Fix Win32 build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Brady Eidson
sullivan [Wed, 16 Aug 2006 18:31:23 +0000 (18:31 +0000)]
    Reviewed by Brady Eidson

        - fixed <rdar://problem/4637156> underlines appearing in white selection text

        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::paintDecorations):
        bail out if phase is PaintPhaseSelection and forceWhiteText is true

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by John
beidson [Wed, 16 Aug 2006 18:03:52 +0000 (18:03 +0000)]
    Reviewed by John

        Updated the DB version number and added a helpful comment explaining its meaning

        * loader/icon/IconDatabase.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej
beidson [Wed, 16 Aug 2006 08:16:51 +0000 (08:16 +0000)]
    Reviewed by Maciej

        * Misc/WebIconDatabase.m: Pruned unused method
        * Misc/WebIconDatabasePrivate.h: Ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej
beidson [Wed, 16 Aug 2006 08:16:04 +0000 (08:16 +0000)]
    Reviewed by Maciej

        Major refactoring of new iconDB:
        -Instead of private browsing being handled by in-memory tables, it's now handled
         by a separate in-memory database with the same table names.  This allows us to
         re-use the same SQL on either the main or private-browsing database
        -So it follows, I broke out much of the SQL queries into seperate methods suffixed with
         "Query" that take a database as the method's argument so the same language can run on
         both private and main tables
        -Now that we have two DBs, moved the retain/release count to the m_mainDB
        -While I was at it, updated the schema to combine the Icon and IconResource table - cuts
         down on some high-usage, low value queries which were too expensive
        -Ditched the _url -> url convention for escaping urls for SQL.  Now its url and escapedURL
        -Pruned tons of unused methods from previous revisions

     * bridge/mac/WebCoreIconDatabaseBridge.h: Removed isIconExpiredForPageURL as it was never used
        * bridge/mac/WebCoreIconDatabaseBridge.mm: Ditto
        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::IconDatabase): Updated initializer list
        (WebCore::IconDatabase::open): Sets up both databases
        (WebCore::IconDatabase::close): Closes both databases
        (WebCore::IconDatabase::isEmpty): Queries both databases for at least 1 record
        (WebCore::IconDatabase::isValidDatabase): Reflect the updated schema
        (WebCore::IconDatabase::clearDatabaseTables): Ditto - and takes DB as a parameter
        (WebCore::IconDatabase::createDatabaseTables): Ditto
        (WebCore::IconDatabase::imageDataForIconURL): style cleanup, and using a query-function
        (WebCore::IconDatabase::setPrivateBrowsingEnabled): Resets private DB instead of private tables
        (WebCore::IconDatabase::isIconExpiredForIconURL): Uses a query-function on each DB
        (WebCore::IconDatabase::iconURLForPageURL): Uses a query-function on each DB
        (WebCore::IconDatabase::retainIconForPageURL): Retain count DB changes
        (WebCore::IconDatabase::releaseIconForPageURL): Ditto
        (WebCore::IconDatabase::isIconURLRetained): Determine if it's time to prune a released icon yet
        (WebCore::IconDatabase::forgetIconForIconURLFromDatabase): Alot simpler
        (WebCore::IconDatabase::setIconDataForIconURL): Style cleanup
        (WebCore::IconDatabase::setHaveNoIconForIconURL): Ditto
        (WebCore::IconDatabase::setIconURLForPageURL): Ditto - and using a query-function
        (WebCore::IconDatabase::establishIconIDForIconURL): Style cleanup
        (WebCore::IconDatabase::pruneUnreferencedIcons): DB name change
        (WebCore::IconDatabase::pruneUnretainedIcons): Ditto
        (WebCore::IconDatabase::hasIconForIconURL): Simpler, using a query-function
        (WebCore::IconDatabase::~IconDatabase):
        (WebCore::pageURLTableIsEmptyQuery): Self-explanatory SQL query
        (WebCore::imageDataForIconURLQuery): Self-explanatory SQL query
        (WebCore::timeStampForIconURLQuery): Self-explanatory SQL query
        (WebCore::iconURLForPageURLQuery): Self-explanatory SQL query
        (WebCore::forgetPageURLQuery): Self-explanatory SQL query
        (WebCore::setIconIDForPageURLQuery): Self-explanatory SQL query
        (WebCore::getIconIDForIconURLQuery): Self-explanatory SQL query
        (WebCore::addIconForIconURLQuery): Self-explanatory SQL query
        (WebCore::hasIconForIconURLQuery): Self-explanatory SQL query
     * loader/icon/IconDatabase.h: Some new/changed methods, pruned methods, and new comments
        (WebCore::IconDatabase::isOpen):  Changed our meaning of "isOpen" to reflect the 2 databases

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-08-15 Steve Falkenburg <sfalken@apple.com>
sfalken [Wed, 16 Aug 2006 05:19:09 +0000 (05:19 +0000)]
2006-08-15  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by mjs.

        Build fix.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * wtf/Assertions.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
darin [Wed, 16 Aug 2006 04:22:22 +0000 (04:22 +0000)]
LayoutTests:

        Reviewed by Darin.

        - added a test to check keyboard events fired from the ObjC API:
          http://bugzilla.opendarwin.org/show_bug.cgi?id=9736

        * fast/events/objc-keyboard-event-creation-expected.txt: Added.
        * fast/events/objc-keyboard-event-creation.html: Added.

WebCore:

        Reviewed by Darin.

        - added ObjC wrappers for the KeyboardEvent and WheelEvent initializers
          http://bugzilla.opendarwin.org/show_bug.cgi?id=9736

        * bindings/objc/DOMEvents.mm:
        (-[DOMKeyboardEvent initKeyboardEvent::::::::::]):
        * bindings/objc/DOMEventsNonstandard.mm:
        (-[DOMWheelEvent initWheelEvent:::::::::::]):
        * bindings/objc/DOMPrivate.h:

        - added an initializer for the WheelEvent

        * dom/WheelEvent.cpp:
        (WebCore::WheelEvent::initWheelEvent):
        * dom/WheelEvent.h:

WebKitTools:

        Reviewed by Darin.

        - added a function to create a few DOMKeyboardEvents and dispatch
          them to a specified HTML element
          http://bugzilla.opendarwin.org/show_bug.cgi?id=9736

        * DumpRenderTree/EventSendingController.m:
        (+[EventSendingController isSelectorExcludedFromWebScript:]):
        (+[EventSendingController webScriptNameForSelector:]):
        (-[EventSendingController fireKeyboardEventsToElement:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed and tweaked by Darin.
darin [Wed, 16 Aug 2006 03:53:29 +0000 (03:53 +0000)]
    Reviewed and tweaked by Darin.

        - added DumpRenderTree support so editing delegate can be made to refuse edits
          to enable tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=10129

        * DumpRenderTree/DumpRenderTree.m:
        (+[LayoutTestController isSelectorExcludedFromWebScript:]): Add setAcceptsEditing:
        to the list of methods.
        (+[LayoutTestController webScriptNameForSelector:]): Use the name setAcceptsEditing,
        without the colon, for the JavaScript name.
        (-[LayoutTestController setAcceptsEditing:]): Added. Calls through to the editing
        delegate.
        (dumpRenderTree): Set the acceptsEditing flag to YES before each test.

        * DumpRenderTree/EditingDelegate.h: Added an "acceptsEditing" flag and getter and
        setter methods to the class.
        * DumpRenderTree/EditingDelegate.m:
        (-[EditingDelegate init]): Initialize acceptsEditing to YES.
        (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]): Instead of always returning YES,
        return the value of acceptsEditing.
        (-[EditingDelegate webView:shouldEndEditingInDOMRange:]): Ditto.
        (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]): Ditto.
        (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]): Ditto.
        (-[EditingDelegate webView:shouldDeleteDOMRange:]): Ditto.
        (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
        Ditto.
        (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]): Ditto.
        (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]): Ditto.
        (-[EditingDelegate setAcceptsEditing:]): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adele (preliminary version) and later by Kevin.
mjs [Wed, 16 Aug 2006 03:53:18 +0000 (03:53 +0000)]
    Reviewed by Adele (preliminary version) and later by Kevin.

        - remove most WebKit dependencies from WebMainResourceLoader.

        * Loader/WebFrameLoader.h:
        * Loader/WebFrameLoader.m:
        (-[WebFrameLoader cannotShowMIMETypeForURL:]):
        (-[WebFrameLoader interruptForPolicyChangeErrorWithRequest:]):
        (-[WebFrameLoader isHostedByObjectElement]):
        (-[WebFrameLoader isLoadingMainFrame]):
        (+[WebFrameLoader _canShowMIMEType:]):
        (+[WebFrameLoader _representationExistsForURLScheme:]):
        (+[WebFrameLoader _generatedMIMETypeForURLScheme:]):
        * Loader/WebMainResourceLoader.h:
        * Loader/WebMainResourceLoader.m:
        (-[WebMainResourceLoader interruptForPolicyChangeError]):
        (-[WebMainResourceLoader willSendRequest:redirectResponse:]):
        (isCaseInsensitiveEqual):
        (shouldLoadAsEmptyDocument):
        (-[WebMainResourceLoader continueAfterContentPolicy:response:]):
        (-[WebMainResourceLoader didReceiveResponse:]):
        (-[WebMainResourceLoader didReceiveData:lengthReceived:allAtOnce:]):
        (-[WebMainResourceLoader didFinishLoading]):
        (-[WebMainResourceLoader loadWithRequestNow:]):
        (-[WebMainResourceLoader loadWithRequest:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Kevin Decker.
tomernic [Wed, 16 Aug 2006 01:24:40 +0000 (01:24 +0000)]
    Reviewed by Kevin Decker.

        * Plugins/WebNetscapePluginPackage.m:
        (-[WebNetscapePluginPackage _unloadWithShutdown:]):
        Fixed a subtle problem with the 64-bit debug build -- as written, this would LOG() on 64-bit and do nothing on
        32-bit!
        * Plugins/WebPluginDatabase.m:
        (-[WebPluginDatabase _scanForNewPlugins]):
        Use +[NSMutableSet set] here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
thatcher [Tue, 15 Aug 2006 23:51:04 +0000 (23:51 +0000)]
JavaScriptCore:

        Reviewed by Tim H.

        Build fix:  DWARF and -gfull are incompatible with symbol separation.

        * JavaScriptCore.xcodeproj/project.pbxproj:

JavaScriptGlue:

        Reviewed by Tim H.

        Build fix:  DWARF and -gfull are incompatible with symbol separation.

        * JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

        Reviewed by Tim H.

        Build fix:  DWARF and -gfull are incompatible with symbol separation.

        * WebCore.xcodeproj/project.pbxproj:

WebKit:

        Reviewed by Darin Adler.

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=8980>
        ASSERTION FAILED: !isLoaded (WebKit/WebKit/Plugins/WebBasePluginPackage.m:228 -[WebBasePluginPackage dealloc])

        <rdar://problem/4526052> intermittent assertion failure in -[WebBasePluginPackage dealloc] running layout tests (8980)

        * Plugins/WebPluginDatabase.h:
        * Plugins/WebPluginDatabase.m:
        (+[WebPluginDatabase installedPlugins]):
        Observe NSApplicationWillTerminateNotification so we can unload plug-ins on quit.
        (-[WebPluginDatabase plugins]):
        'plugins' is now a dictionary.
        (-[WebPluginDatabase close]):
        Call new -_removePlugin: method.
        (-[WebPluginDatabase refresh]):
        Moved parts of this method out into other methods: -_addPlugin:, -_removePlugin:, and -_scanForNewPlugins.
        (-[WebPluginDatabase _plugInPaths]):
        No changes; just moved in file.
        (-[WebPluginDatabase _addPlugin:]):
        New method.  Refactored from -refresh.  Adds a plug-in to the database.
        (-[WebPluginDatabase _removePlugin:]):
        New method.  Refactored from -refresh.  Remove a plug-in from the database.
        (-[WebPluginDatabase _scanForNewPlugins]):
        New method.  Refactored from -refresh.  Returns the list of plug-in packages on disk.
        (-[WebPluginDatabase _applicationWillTerminate]):
        New method.  Called when the application terminates.  Closes the plug-in database so that all plug-ins are
        removed from the DB (and unloaded if necessary).

        * Plugins/WebBasePluginPackage.h:
        * Plugins/WebBasePluginPackage.m:
        (-[WebBasePluginPackage initWithPath:]):
        Try to create the NSBundle first, so if the file is not a valid bundle we bail out early.  This
        avoids some stat()s and allocations during the plug-in refresh process.
        (-[WebBasePluginPackage isLoaded]):
        Removed.
        (-[WebBasePluginPackage load]):
        Base class for plug-in packages now always loads "successfully".
        (-[WebBasePluginPackage dealloc]):
        Removed this assertion.  The base plug-in package class has no concept of
        "unloading".
        (-[WebBasePluginPackage finalize]):
        ditto.
        (-[WebBasePluginPackage wasRemovedFromPluginDatabase:]):
        Moved code to unload plug-in package to WebNetscapePluginPackage.  Not all plug-in
        packages can be "unloaded".

        * Plugins/WebNetscapePluginPackage.h:
        * Plugins/WebNetscapePluginPackage.m:
        (-[WebNetscapePluginPackage _unloadWithShutdown:]):
        Combined old -unload and -unloadWithoutShutdown methods into this new one.
        (-[WebNetscapePluginPackage initWithPath:]):
        Call new unload method.
        (-[WebNetscapePluginPackage load]):
        ditto
        (-[WebNetscapePluginPackage wasRemovedFromPluginDatabase:]):
        ditto
        (-[WebNetscapePluginPackage open]):
        New method.  Called when a plug-in instance starts running.
        (-[WebNetscapePluginPackage close]):
        New method.  Called when a plug-in instance stops running.  When all plug-in instances
        close the plug-in package, and the plug-in package is removed from the database, the plug-in
        is unloaded.

        * Plugins/WebPluginPackage.m:
        (-[WebPluginPackage initWithPath:]):
        (-[WebPluginPackage load]):
        Made this a bit more efficient by checking if the bundle is already loaded.
        (-[WebBasePluginPackage unload]):
        Removed.
        (-[WebBasePluginPackage isLoaded]):
        Removed.

        * Plugins/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView start]):
        Open the plug-in package so it remains loaded while this instance uses it.
        (-[WebBaseNetscapePluginView stop]):
        Close the plug-in package when the plug-in instance is stopped.

        * Plugins/WebBaseNetscapePluginStream.m:
        (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:]):
        This check is not necessary.  Netscape plug-in packages are never unloaded until all their instances have
        been stopped, and a Netscape plug-in instance will stop its streams when it is stopped.
        (-[WebBaseNetscapePluginStream _destroyStream]):
        ditto
        (-[WebBaseNetscapePluginStream finishedLoadingWithData:]):
        ditto
        (-[WebBaseNetscapePluginStream _deliverData]):
        ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin Adler.
tomernic [Tue, 15 Aug 2006 23:38:37 +0000 (23:38 +0000)]
    Reviewed by Darin Adler.

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=8980>
        ASSERTION FAILED: !isLoaded (WebKit/WebKit/Plugins/WebBasePluginPackage.m:228 -[WebBasePluginPackage dealloc])

        <rdar://problem/4526052> intermittent assertion failure in -[WebBasePluginPackage dealloc] running layout tests (8980)

        * Plugins/WebPluginDatabase.h:
        * Plugins/WebPluginDatabase.m:
        (+[WebPluginDatabase installedPlugins]):
        Observe NSApplicationWillTerminateNotification so we can unload plug-ins on quit.
        (-[WebPluginDatabase plugins]):
        'plugins' is now a dictionary.
        (-[WebPluginDatabase close]):
        Call new -_removePlugin: method.
        (-[WebPluginDatabase refresh]):
        Moved parts of this method out into other methods: -_addPlugin:, -_removePlugin:, and -_scanForNewPlugins.
        (-[WebPluginDatabase _plugInPaths]):
        No changes; just moved in file.
        (-[WebPluginDatabase _addPlugin:]):
        New method.  Refactored from -refresh.  Adds a plug-in to the database.
        (-[WebPluginDatabase _removePlugin:]):
        New method.  Refactored from -refresh.  Remove a plug-in from the database.
        (-[WebPluginDatabase _scanForNewPlugins]):
        New method.  Refactored from -refresh.  Returns the list of plug-in packages on disk.
        (-[WebPluginDatabase _applicationWillTerminate]):
        New method.  Called when the application terminates.  Closes the plug-in database so that all plug-ins are
        removed from the DB (and unloaded if necessary).

        * Plugins/WebBasePluginPackage.h:
        * Plugins/WebBasePluginPackage.m:
        (-[WebBasePluginPackage initWithPath:]):
        Try to create the NSBundle first, so if the file is not a valid bundle we bail out early.  This
        avoids some stat()s and allocations during the plug-in refresh process.
        (-[WebBasePluginPackage isLoaded]):
        Removed.
        (-[WebBasePluginPackage load]):
        Base class for plug-in packages now always loads "successfully".
        (-[WebBasePluginPackage dealloc]):
        Removed this assertion.  The base plug-in package class has no concept of
        "unloading".
        (-[WebBasePluginPackage finalize]):
        ditto.
        (-[WebBasePluginPackage wasRemovedFromPluginDatabase:]):
        Moved code to unload plug-in package to WebNetscapePluginPackage.  Not all plug-in
        packages can be "unloaded".

        * Plugins/WebNetscapePluginPackage.h:
        * Plugins/WebNetscapePluginPackage.m:
        (-[WebNetscapePluginPackage _unloadWithShutdown:]):
        Combined old -unload and -unloadWithoutShutdown methods into this new one.
        (-[WebNetscapePluginPackage initWithPath:]):
        Call new unload method.
        (-[WebNetscapePluginPackage load]):
        ditto
        (-[WebNetscapePluginPackage wasRemovedFromPluginDatabase:]):
        ditto
        (-[WebNetscapePluginPackage open]):
        New method.  Called when a plug-in instance starts running.
        (-[WebNetscapePluginPackage close]):
        New method.  Called when a plug-in instance stops running.  When all plug-in instances
        close the plug-in package, and the plug-in package is removed from the database, the plug-in
        is unloaded.

        * Plugins/WebPluginPackage.m:
        (-[WebPluginPackage initWithPath:]):
        (-[WebPluginPackage load]):
        Made this a bit more efficient by checking if the bundle is already loaded.
        (-[WebBasePluginPackage unload]):
        Removed.
        (-[WebBasePluginPackage isLoaded]):
        Removed.

        * Plugins/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView start]):
        Open the plug-in package so it remains loaded while this instance uses it.
        (-[WebBaseNetscapePluginView stop]):
        Close the plug-in package when the plug-in instance is stopped.

        * Plugins/WebBaseNetscapePluginStream.m:
        (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:]):
        This check is not necessary.  Netscape plug-in packages are never unloaded until all their instances have
        been stopped, and a Netscape plug-in instance will stop its streams when it is stopped.
        (-[WebBaseNetscapePluginStream _destroyStream]):
        ditto
        (-[WebBaseNetscapePluginStream finishedLoadingWithData:]):
        ditto
        (-[WebBaseNetscapePluginStream _deliverData]):
        ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
thatcher [Tue, 15 Aug 2006 23:31:46 +0000 (23:31 +0000)]
JavaScriptCore:

        Reviewed by Tim H.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10394
        Bug 10394: WebKit Release and Production configurations should enable dead code stripping

        * JavaScriptCore.xcodeproj/project.pbxproj:

JavaScriptGlue:

        Reviewed by Tim H.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10394
        Bug 10394: WebKit Release and Production configurations should enable dead code stripping

        * JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

        Reviewed by Tim H.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10394
        Bug 10394: WebKit Release and Production configurations should enable dead code stripping

        * WebCore.xcodeproj/project.pbxproj:

WebKit:

        Reviewed by Tim H.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10394
        Bug 10394: WebKit Release and Production configurations should enable dead code stripping

        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
ggaren [Tue, 15 Aug 2006 22:51:04 +0000 (22:51 +0000)]
LayoutTests:

        Layout test for <rdar://problem/4661982> (crash in KHTMLParser::popBlock)

        * fast/parser/remove-node-stack-expected.txt: Added.
        * fast/parser/remove-node-stack.html: Added.

WebCore:

        Reviewed by Darin.

        - This patch reworks a previous fix for <rdar://problem/3524912> repro
        crash in KHTMLParser::parseToken, due to parser's current element being
        destroyed (www.gnnetcom.dk), along with subsequent adjustments to fix
        leaks.

        The previous solutions caused a ~2% performance regression on iBench HTML,
        due to RefPtr churn. The optimizations here gain back that ~2% plus ~1% more,
        for a total win of ~3% vs current TOT.

        We can merge this fix to the branch to fix <rdar://problem/4661982>
        (crash in KHTMLParser::popBlock).

        The solution here is:
        (1) Don't let the parser ref document nodes -- that causes leaks.
        (2) Handle ref/deref manually, to avoid RefPtr churn. Specifically, when
        moving a node between stacks or to/from 'current', rather than deref'ing
        and then ref'ing again, simply move the node, along with its refcount, to
        its new location, and overwrite its old location.

        * WebCore.xcodeproj/project.pbxproj:
        * html/HTMLParser.cpp:
        (WebCore::HTMLStackElem::HTMLStackElem):
        (WebCore::HTMLStackElem::derefNode):
        (WebCore::HTMLParser::HTMLParser):
        (WebCore::HTMLParser::setCurrent):
        (WebCore::HTMLParser::insertNode):
        (WebCore::HTMLParser::popNestedHeaderTag):
        (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
        (WebCore::HTMLParser::reopenResidualStyleTags):
        (WebCore::HTMLParser::pushBlock):
        (WebCore::HTMLParser::popBlock):
        (WebCore::HTMLParser::popOneBlockCommon):
        (WebCore::HTMLParser::popOneBlock):
        (WebCore::HTMLParser::moveOneBlockToStack):
        * html/HTMLParser.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdd system fonts layout test.
hyatt [Tue, 15 Aug 2006 22:38:14 +0000 (22:38 +0000)]
Add system fonts layout test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix for bug 3303, support CSS2 system fonts. This patch adds a new API
hyatt [Tue, 15 Aug 2006 22:37:51 +0000 (22:37 +0000)]
    Fix for bug 3303, support CSS2 system fonts.  This patch adds a new API
        to RenderTheme for obtaining a system font. In addition to supporting
        the CSS2 values, extensions have been added for the 3 control sizes on
        Mac.  The UA stylesheet now uses -webkit-small-control and no longer hardcodes
        Lucida Grande 11px.  This means that controls in Safari should now respect
        haxies that modify the default fonts on controls.

        Reviewed by beth

        Added fast/css/css2-system-fonts.html

        * WebCore.xcodeproj/project.pbxproj:
        * css/CSSValueKeywords.in:
        * css/cssparser.cpp:
        (WebCore::CSSParser::parseValue):
        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        * css/html4.css:
        * platform/FontDescription.h:
        (WebCore::FontDescription::setBold):
        * platform/win/TemporaryLinkStubs.cpp:
        (RenderThemeWin::systemFont):
        * rendering/RenderMenuList.cpp:
        (WebCore::RenderMenuList::calcMinMaxWidth):
        * rendering/RenderTheme.h:
        (WebCore::RenderTheme::minimumMenuListSize):
        * rendering/RenderThemeMac.h:
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::systemFont):
        (WebCore::RenderThemeMac::minimumMenuListSize):
        * rendering/RenderThemeWin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
adele [Tue, 15 Aug 2006 21:40:04 +0000 (21:40 +0000)]
LayoutTests:

        Reviewed by Maciej.

        Test for: <rdar://problem/4680207> REGRESSION: select-all should fire onSelect event for text fields and textareas (9518)
        http://bugzilla.opendarwin.org/show_bug.cgi?id=9518

        * fast/forms/onselect-selectall-expected.txt: Added.
        * fast/forms/onselect-selectall.html: Added.

WebCore:

        Reviewed by Maciej.

        - Fix for <rdar://problem/4680207> REGRESSION: select-all should fire onSelect event for text fields and textareas (9518)
        http://bugzilla.opendarwin.org/show_bug.cgi?id=9518

        Test: fast/forms/onselect-selectall.html

        * page/Frame.cpp: (WebCore::Frame::selectAll): Call notifyRendererOfSelectionChange with userTriggered = true so that onSelect will fire.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15886 268f45cc-cd09-0410-ab3c-d52691b4dbfc