WebKit-https.git
2 years agoHeap out of bounds read in JSC::Yarr::Parser<JSC::Yarr::SyntaxChecker, unsigned char...
msaboff@apple.com [Thu, 28 Sep 2017 04:48:51 +0000 (04:48 +0000)]
Heap out of bounds read in JSC::Yarr::Parser<JSC::Yarr::SyntaxChecker, unsigned char>::peek()
https://bugs.webkit.org/show_bug.cgi?id=177423

Reviewed by Mark Lam.

JSTests:

Updated regression test.

* stress/regress-177423.js:
(catch):

Source/JavaScriptCore:

Updated fix that restructures that changes the do ... while to a while and adds another
atEndOfPattern() check before looking for the first named group identifier character.

* yarr/YarrParser.h:
(JSC::Yarr::Parser::tryConsumeGroupName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUncaught Exception: Attempted to assign to readonly property (at ContentView.js:...
commit-queue@webkit.org [Thu, 28 Sep 2017 04:20:05 +0000 (04:20 +0000)]
Uncaught Exception: Attempted to assign to readonly property (at ContentView.js:​206:​34)​
https://bugs.webkit.org/show_bug.cgi?id=177587

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2017-09-27
Reviewed by Matt Baker.

We allow a representedObject to be a string. In strict mode attempting to set
a property on a string results in a TypeError. So we should be careful not to
do this in the rare cases where our representedObject is the a string.

* UserInterface/Views/ContentView.js:
(WI.ContentView.contentViewForRepresentedObject):
(WI.ContentView.closedContentViewForRepresentedObject):
Avoid setting a property on strings. ContentViews backed by a String aren't typically
shared anyways, so the property case would not be useful. If a client really wants
to share they could use `new String(...)` as the representedObject.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoJSArray::canFastCopy() should fail if the source and destination arrays are the same.
mark.lam@apple.com [Thu, 28 Sep 2017 04:19:13 +0000 (04:19 +0000)]
JSArray::canFastCopy() should fail if the source and destination arrays are the same.
https://bugs.webkit.org/show_bug.cgi?id=177584
<rdar://problem/34463903>

Reviewed by Saam Barati.

JSTests:

* stress/regress-177584.js: Added.
(assertEqual):
(Array.prototype.Symbol.species):

Source/JavaScriptCore:

If the source and destination arrays are the same, we may be copying overlapping
regions.  Hence, we need to take the slow path.

* runtime/JSArrayInlines.h:
(JSC::JSArray::canFastCopy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, fix the internal build after r222596 and r222595.
wenson_hsieh@apple.com [Thu, 28 Sep 2017 03:58:19 +0000 (03:58 +0000)]
Unreviewed, fix the internal build after r222596 and r222595.

Guarding code in PlatformPasteboardIOS.mm TARGET_OS_IPHONE did not have the intended effect.

* platform/ios/PlatformPasteboardIOS.mm:
(WebCore::PlatformPasteboard::typesSafeForDOMToReadAndWrite const):
(WebCore::PlatformPasteboard::write):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, fix the internal build after r222595.
wenson_hsieh@apple.com [Thu, 28 Sep 2017 03:18:50 +0000 (03:18 +0000)]
Unreviewed, fix the internal build after r222595.

Add missing iOS compiler guards.

* platform/ios/PlatformPasteboardIOS.mm:
(WebCore::PlatformPasteboard::typesSafeForDOMToReadAndWrite const):
(WebCore::PlatformPasteboard::write):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoDrag event DataTransfer has unexpected types "dyn.ah62d4..."
wenson_hsieh@apple.com [Thu, 28 Sep 2017 02:29:16 +0000 (02:29 +0000)]
Drag event DataTransfer has unexpected types "dyn.ah62d4..."
https://bugs.webkit.org/show_bug.cgi?id=172526
<rdar://problem/32396081>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Currently, the pasteboard types we expose to web content are simply the types that appear on the platform
pasteboard (i.e. the general NSPasteboard on Mac, and either the general UIPasteboard or a UIDragSession's
NSItemProviders on iOS). This leads to DataTransfer.types exposing many private pasteboard types written by apps
around the system to the page, such as dynamic UTIs, CorePasteboardFlavorTypes, or the "Apple WebKit dummy
pasteboard type". These are not only confusing and not useful for web content (since they mostly hold values of
empty string anyways), but can additionally pose privacy concerns by exposing information meant only for native
applications to unvetted web content.

To address this problem, other browsers (e.g. Chrome and Firefox on Mac) white-list MIME types in DataTransfer's
list of types. By default, when dragging or copying, these are "text/plain", "text/html" and "text/uri-list".
However, this policy alone is insufficient, because the page may also supply its own types, in which case our
naive whitelist would prevent us from delivering them to the page. To address this additional constraint, both
Chrome and Firefox write any custom data supplied by the page to custom pasteboard UTIs
(org.chromium.drag-dummy-type and org.mozilla.custom-clipdata, respectively). The corresponding data is a map
of custom UTI => custom data supplied by the page; upon drop or paste, this mapping is consulted if the page
calls getData() with a custom UTI.

This patch adopts this same approach in WebKit, and introduces the com.apple.WebKit.custom-pasteboard-data UTI
(refer to per-method comments below for more information). These changes are covered by 18 new layout and API
tests, as well as existing drag-and-drop tests.

Tests: editing/pasteboard/data-transfer-get-data-on-drop-custom.html
       editing/pasteboard/data-transfer-get-data-on-drop-plain-text.html
       editing/pasteboard/data-transfer-get-data-on-drop-rich-text.html
       editing/pasteboard/data-transfer-get-data-on-drop-url.html
       editing/pasteboard/data-transfer-get-data-on-paste-custom.html
       editing/pasteboard/data-transfer-get-data-on-paste-plain-text.html
       editing/pasteboard/data-transfer-get-data-on-paste-rich-text.html
       DataInteractionTests.DataTransferGetDataWhenDroppingPlainText
       DataInteractionTests.DataTransferGetDataWhenDroppingCustomData
       DataInteractionTests.DataTransferGetDataWhenDroppingURL
       DataInteractionTests.DataTransferGetDataWhenDroppingImageWithFileURL
       DataInteractionTests.DataTransferGetDataWhenDroppingRespectsPresentationStyle
       DataInteractionTests.DataTransferSetDataCannotWritePlatformTypes
       DataInteractionTests.DataTransferGetDataCannotReadPrivatePlatformTypes
       UIPasteboardTests.DataTransferGetDataWhenPastingURL
       UIPasteboardTests.DataTransferGetDataWhenPastingPlatformRepresentations
       UIPasteboardTests.DataTransferSetDataCannotWritePlatformTypes
       UIPasteboardTests.DataTransferGetDataCannotReadPrivatePlatformTypes

* CMakeLists.txt:

Add Pasteboard.cpp to the WebCore CMakeList.

* WebCore.xcodeproj/project.pbxproj:
* dom/DataTransfer.cpp:
(WebCore::DataTransfer::getData const):
(WebCore::DataTransfer::createForDragStartEvent):

Make a new static helper function to create a StaticPasteboard-backed DataTransfer when dispatching a dragstart
event. Any data supplied by the page will be written to the static pasteboard of this DataTransfer.

(WebCore::DataTransfer::moveDragState):

Add a new helper on DataTransfer to transfer the data required to initiate a drag from one DataTransfer to
another. This is used in EventHandler to transfer the contents of the temporary DataTransfer modified by the
page during the dragstart event over to the DataTransfer used for the rest of the drag initiation codepath,
which is actually connected to the platform. This includes committing the contents of the other
DataTransfer's StaticPasteboard to the new platform-connected Pasteboard.

(WebCore::DataTransfer::hasDragImage const):
* dom/DataTransfer.h:
* editing/cocoa/EditorCocoa.mm:
(WebCore::Editor::selectionInHTMLFormat):
(WebCore::Editor::writeSelectionToPasteboard):
(WebCore::Editor::writeSelection):

Write an additional HTML markup string on iOS. We already do this for Mac, but this data previously had no use
on iOS. This is needed for to vend the "text/html" representation to the page on iOS when pasting.

* editing/mac/EditorMac.mm:
(WebCore::Editor::selectionInHTMLFormat): Deleted.
* editing/wpe/EditorWPE.cpp:
(WebCore::createFragmentFromPasteboardData):
* page/EventHandler.cpp:
(WebCore::EventHandler::dispatchDragStartEventOnSourceElement):

Renamed from dispatchDragStartEvent to dispatchDragStartEventOnSourceElement. Additionally, simplified the logic
significantly, so that we now just check to see if the StaticPasteboard exposed to the page has any data,
instead of using platform-dependent logic to compare changeCounts. We can do this because StaticPasteboard is
guaranteed to only contain content that the page has supplied during the dragstart event, since it is empty
upon initialization and cannot be written to by the rest of the platform.

(WebCore::EventHandler::handleDrag):

Tweak dispatchDragStartEvent to take a DataTransfer to expose to bindings; at the call site in handleDrag,
create a new DataTransfer backed by a StaticPasteboard that the page may mutate over the course of the dragstart
event. After dispatching to the page, move the dragging information present on the drag start DataTransfer over
to the DragState's DataTransfer. If the drag image has not been set, compute and set the default drag image
element on the DragState's DataTransfer.

(WebCore::EventHandler::dispatchDragStartEvent): Deleted.
* page/EventHandler.h:
* page/Settings.cpp:
(WebCore::Settings::customPasteboardDataEnabled):
* page/Settings.h:
(WebCore::Settings::setCustomPasteboardDataEnabled):
* page/ios/EventHandlerIOS.mm:
(WebCore::EventHandler::createDraggingDataTransfer const): Deleted.
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::createDraggingDataTransfer const): Deleted.
* page/win/EventHandlerWin.cpp:
(WebCore::EventHandler::createDraggingDataTransfer const): Deleted.

Remove this helper on both iOS and Mac. This only called createForDrag() before, with the addition of clearing
the platform pasteboard prior to returning. Now that a StaticPasteboard is used when starting a drag, we clear
out the platform pasteboard in platform-invariant code in EventHandler::handleDrag, so these helpers are no
longer useful.

* platform/Pasteboard.cpp: Added.
(WebCore::isSafeTypeForDOMToReadAndWrite):

Add a new helper to determine whether or not a pasteboard type is one of the standard DOM-exposed types. These
are "text/plain", "text/html" and "text/uri-list".

(WebCore::sharedBufferFromCustomData):
(WebCore::customDataFromSharedBuffer):

Add helper methods to serialize and deserialize custom data. The serialized data blob consists of: (1)
versioning information, (2) a dictionary mapping each custom type to a value, and (3) a full list of types
written by the page, in the order they were written.

* platform/Pasteboard.h:

Rename Pasteboard::readString to Pasteboard::readStringForBindings, to reflect that the string being read and
the given type are exposed to and from the DOM.

* platform/PasteboardStrategy.h:
* platform/PasteboardWriterData.h:
* platform/PlatformPasteboard.h:
* platform/StaticPasteboard.cpp:

Split m_stringContents out into m_platformData and m_customData. The former contains type-to-data entries for
the DOM-exposed types, while the second contains entries that don't belong in the former.

(WebCore::StaticPasteboard::hasData):
(WebCore::StaticPasteboard::readStringForBindings):
(WebCore::StaticPasteboard::writeString):
(WebCore::StaticPasteboard::clear):
(WebCore::StaticPasteboard::commitToPasteboard):

Rather than propagate each entry to the client layer one at a time, populate a new PasteboardCustomData struct
and send it to the client layer in one go. This new struct consists of an array of types in the order they were
written by the page, a dictionary of public types (types we want to write directly to the platform pasteboard)
and private types (custom types we want to package under our custom data blob).

(WebCore::StaticPasteboard::readString): Deleted.
* platform/StaticPasteboard.h:
* platform/glib/EventHandlerGLib.cpp:
(WebCore::EventHandler::createDraggingDataTransfer const): Deleted.
* platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::readStringForBindings):
(WebCore::Pasteboard::writeCustomData):
(WebCore::Pasteboard::readString): Deleted.
* platform/gtk/PlatformPasteboardGtk.cpp:
(WebCore::PlatformPasteboard::typesSafeForDOMToReadAndWrite const):
(WebCore::PlatformPasteboard::write):

Add stub implementations for new custom pasteboard data methods.

* platform/ios/AbstractPasteboard.h:
* platform/ios/PasteboardIOS.mm:
(WebCore::Pasteboard::writeCustomData):

Add new plumbing to ship a custom data (PasteboardCustomData) struct from WebCore to the client layer.

(WebCore::cocoaTypeFromHTMLClipboardType):
(WebCore::readPlatformValueAsString):
(WebCore::Pasteboard::readStringForBindings):
(WebCore::Pasteboard::types):

Rewritten to ask the client layer for DOM-exposed types rather than all types, in the case where custom
pasteboard data is enabled in Settings.

(WebCore::Pasteboard::readString): Deleted.
* platform/ios/PlatformPasteboardIOS.mm:
(WebCore::PlatformPasteboard::bufferForType):
(WebCore::PlatformPasteboard::getPathnamesForType const):
(WebCore::PlatformPasteboard::numberOfFiles const):
(WebCore::PlatformPasteboard::platformPasteboardTypeForSafeTypeForDOMToReadAndWrite):

Add a new helper to map DOM-safe pasteboard types to their platform counterparts.

(WebCore::PlatformPasteboard::write):
(WebCore::safeTypeForDOMToReadAndWriteForPlatformType):

Add a new helper to map platform pasteboard types to their DOM-safe counterparts.

(WebCore::PlatformPasteboard::typesSafeForDOMToReadAndWrite const):

Fetch a list of DOM-exposed types. On iOS, for drag and drop, we have the additional constraint of not being
able to read any data before the drop happens. This is problematic, since the page needs to know the list of
types during 'dragover' events. To support this, we instead keep the array of types in the teamData property of
the generated item provider, which is immediately available, even when dragging across different apps. Note that
we still need to check if the pasteboard contains the full custom data blob here to handle the case where we
copy on Mac and perform a continuity paste on iOS, since teamData does not exist on Mac.

(WebCore::PlatformPasteboard::readString):

Tweak to account for how UIPasteboard may return data blobs when reading values.

(WebCore::PlatformPasteboard::getPathnamesForType): Deleted.
(WebCore::PlatformPasteboard::numberOfFiles): Deleted.
* platform/ios/WebItemProviderPasteboard.h:
* platform/ios/WebItemProviderPasteboard.mm:
(-[WebItemProviderRegistrationInfoList itemProvider]):
(+[WebItemProviderLoadResult loadResultWithItemProvider:typesToLoad:]):
(-[WebItemProviderLoadResult initWithItemProvider:typesToLoad:]):
(-[WebItemProviderLoadResult typesToLoad]):
(-[WebItemProviderLoadResult setFileURL:forType:]):
(-[WebItemProviderLoadResult itemProvider]):
(-[WebItemProviderPasteboard setItemProviders:]):
(-[WebItemProviderPasteboard dataForPasteboardType:]):
(-[WebItemProviderPasteboard typeIdentifiersToLoadForRegisteredTypeIdentfiers:]):
(-[WebItemProviderPasteboard doAfterLoadingProvidedContentIntoFileURLs:synchronousTimeout:]):
(+[WebItemProviderLoadResult emptyLoadResult]): Deleted.
(+[WebItemProviderLoadResult loadResultWithFileURLMap:presentationStyle:]): Deleted.
(-[WebItemProviderLoadResult initWithFileURLMap:presentationStyle:]): Deleted.
(-[WebItemProviderPasteboard typeIdentifierToLoadForRegisteredTypeIdentfiers:]): Deleted.

In the case of drag and drop on iOS, we cannot load any data prior to performing the drop; additionally, any
attempts to load data immediately after the drop is performed in the UI process will fail. This means any and
all data that the web process may require in the future when handling the drop must be loaded out of the item
providers and saved when the drop is being handled in the UI process.

Currently, we only load the highest fidelity type we can handle (or, if we don't know what we can handle, we
select the highest fidelity representation conforming to "public.content"). This is a problematic for supporting
DataTransfer.getData() on drop on iOS, because the page can ask for any of the three web-exposed types. To
address this, we refactor WebItemProviderPasteboard to support loading multiple representations per item being
dropped. At minimum, we will load anything conforming to "public.html", "public.plain-text", "public.url", and
the new "com.apple.WebKit.custom-pasteboard-data" so we have means to answer any question that the page could
ask via DataTransfer.getData(). We additonally load the highest fidelity supported (or content-conformant) type,
if it has not already been loaded as a result of the former.

To make this possible, we refactor WebItemProviderLoadResult to take an item provider and a list of types to
load. -doAfterLoadingProvidedContentIntoFileURLs:synchronousTimeout: then creates a list of load results and
uses each one to represent the results of loading data from its item provider (i.e. a map of UTI => file URL).

* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writeCustomData):
(WebCore::cocoaTypeFromHTMLClipboardType):
(WebCore::readPlatformValueAsString):
(WebCore::Pasteboard::readStringForBindings):

Change readStringForBindings (formerly, readString) so that if support for custom pasteboard data is enabled,
we only allow reading directly from the platform pasteboard if the given type is DOM-safe; otherwise, we consult
the custom data blob, if it exists. Otherwise, if support for custom pasteboard data is disabled, we fall back
to our current behavior.

(WebCore::Pasteboard::types):
(WebCore::Pasteboard::readString): Deleted.
* platform/mac/PlatformPasteboardMac.mm:
(WebCore::PlatformPasteboard::numberOfFiles const):
(WebCore::PlatformPasteboard::getPathnamesForType const):
(WebCore::PlatformPasteboard::stringForType):
(WebCore::safeTypeForDOMToReadAndWriteForPlatformType):
(WebCore::PlatformPasteboard::typesSafeForDOMToReadAndWrite const):

Add support for reading DOM-exposed types and fetching DOM-exposed data off of the pasteboard. The overall idea
here is similar to iOS, though implementation details vary (e.g. no item provider support).

(WebCore::PlatformPasteboard::write):
(WebCore::PlatformPasteboard::platformPasteboardTypeForSafeTypeForDOMToReadAndWrite):
(WebCore::PlatformPasteboard::numberOfFiles): Deleted.
(WebCore::PlatformPasteboard::getPathnamesForType): Deleted.
* platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::readStringForBindings):
(WebCore::Pasteboard::writeCustomData):
(WebCore::Pasteboard::readString): Deleted.
* platform/wpe/PasteboardWPE.cpp:
(WebCore::Pasteboard::readStringForBindings):
(WebCore::Pasteboard::writeCustomData):
(WebCore::Pasteboard::readString): Deleted.
* platform/wpe/PlatformPasteboardWPE.cpp:
(WebCore::PlatformPasteboard::typesSafeForDOMToReadAndWrite const):
(WebCore::PlatformPasteboard::write):
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setCustomPasteboardDataEnabled):

Add a new internal settings hook for layout tests to opt in to using custom pasteboard data. By default, custom
pasteboard data is enabled only in Safari, or on applications linked on or after certain releases of iOS and
macOS.

* testing/InternalSettings.h:
* testing/InternalSettings.idl:

Source/WebKit:

Add boilerplate plumbing and encoder/decoder support for new pasteboard codepaths. See WebCore ChangeLog for
more details.

* Scripts/webkit/messages.py:
(headers_for_type):
* Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<PasteboardCustomData>::encode):
(IPC::ArgumentCoder<PasteboardCustomData>::decode):

Add encoder/decoder support for PasteboardCustomData.

(IPC::ArgumentCoder<PasteboardWebContent>::encode):
(IPC::ArgumentCoder<PasteboardWebContent>::decode):

Encode and decode dataInHTMLFormat.

* Shared/WebCoreArgumentCoders.h:
* UIProcess/Cocoa/WebPasteboardProxyCocoa.mm:
(WebKit::WebPasteboardProxy::typesSafeForDOMToReadAndWrite):
(WebKit::WebPasteboardProxy::writeCustomData):
* UIProcess/WebPasteboardProxy.cpp:
(WebKit::WebPasteboardProxy::typesSafeForDOMToReadAndWrite):
(WebKit::WebPasteboardProxy::writeCustomData):
* UIProcess/WebPasteboardProxy.h:
* UIProcess/WebPasteboardProxy.messages.in:
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::typesSafeForDOMToReadAndWrite):
(WebKit::WebPlatformStrategies::writeCustomData):
* WebProcess/WebCoreSupport/WebPlatformStrategies.h:

Source/WebKitLegacy/mac:

Adjust for changes in WebCore. See WebCore ChangeLog for more details.

* WebCoreSupport/WebPlatformStrategies.h:
* WebCoreSupport/WebPlatformStrategies.mm:
(WebPlatformStrategies::webExposedTypes):
(WebPlatformStrategies::writeCustomData):

Tools:

Adds new API tests on iOS to cover various cases of using DataTransfer.setData, DataTransfer.getData, and
DataTransfer.types, as well as their interaction with platform objects (source NSItemProviders in the case of
drag and drop, and the general UIPasteboard for copy and paste).

* TestWebKitAPI/PlatformUtilities.h:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKitCocoa/dump-datatransfer-types.html: Added.

Introduce a new API test harness that both drag-and-drop and copy-and-paste tests use to dump DataTransfer's
web-exposed types and values.

* TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
(checkFirstTypeIsPresentAndSecondTypeIsMissing):
(checkJSONWithLogging):
(TestWebKitAPI::TEST):
(checkTypeIdentifierAndIsNotOtherTypeIdentifier): Deleted.
* TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
(TestWebKitAPI::checkJSONWithLogging):
(TestWebKitAPI::setUpWebViewForPasteboardTests):
(TestWebKitAPI::TEST):
* TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm:
(TestWebKitAPI::Util::jsonMatchesExpectedValues):

LayoutTests:

Add new layout tests on Mac and iOS to test various cases of using DataTransfer.setData, DataTransfer.getData,
and DataTransfer.types for drag-and-drop (tests for Mac WK1 only) and copy-and-paste (all platforms).

* TestExpectations:
* editing/pasteboard/data-transfer-get-data-on-drop-custom-expected.txt: Added.
* editing/pasteboard/data-transfer-get-data-on-drop-custom.html: Added.
* editing/pasteboard/data-transfer-get-data-on-drop-plain-text-expected.txt: Added.
* editing/pasteboard/data-transfer-get-data-on-drop-plain-text.html: Added.
* editing/pasteboard/data-transfer-get-data-on-drop-rich-text-expected.txt: Added.
* editing/pasteboard/data-transfer-get-data-on-drop-rich-text.html: Added.
* editing/pasteboard/data-transfer-get-data-on-drop-url-expected.txt: Added.
* editing/pasteboard/data-transfer-get-data-on-drop-url.html: Added.
* editing/pasteboard/data-transfer-get-data-on-paste-custom-expected.txt: Added.
* editing/pasteboard/data-transfer-get-data-on-paste-custom.html: Added.
* editing/pasteboard/data-transfer-get-data-on-paste-plain-text-expected.txt: Added.
* editing/pasteboard/data-transfer-get-data-on-paste-plain-text.html: Added.
* editing/pasteboard/data-transfer-get-data-on-paste-rich-text-expected.txt: Added.
* editing/pasteboard/data-transfer-get-data-on-paste-rich-text.html: Added.
* platform/ios-simulator-wk1/TestExpectations:

Mark new copy and paste tests as [ Pass ], since editing/pasteboard/ is skipped by default for iOS WK1.

* platform/ios-wk1/editing/pasteboard/data-transfer-get-data-on-paste-rich-text-expected.txt: Added.
* platform/ios-wk2/editing/pasteboard/data-transfer-get-data-on-paste-rich-text-expected.txt: Added.

Add iOS-specific baselines. This is due to the generated HTML markup for "text/html" being slightly different
when pasting.

* platform/mac-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoDeferred image size change makes image-load-on-delay.html flaky.
zalan@apple.com [Thu, 28 Sep 2017 01:38:18 +0000 (01:38 +0000)]
Deferred image size change makes image-load-on-delay.html flaky.
https://bugs.webkit.org/show_bug.cgi?id=177520
<rdar://problem/34674299>

Reviewed by Dean Jackson.

Source/WebCore:

Only defer recomputeIsIgnored when the image change actually triggers layout.

* accessibility/AXObjectCache.cpp:
(WebCore::rendererNeedsDeferredUpdate):
(WebCore::AXObjectCache::deferRecomputeIsIgnoredIfNeeded):
(WebCore::AXObjectCache::deferTextChangedIfNeeded):
* accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::deferRecomputeIsIgnoredIfNeeded):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::imageChanged):

LayoutTests:

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Win64] Compile error, 'BasePtrs' is undefined.
pvollan@apple.com [Thu, 28 Sep 2017 01:29:14 +0000 (01:29 +0000)]
[Win64] Compile error, 'BasePtrs' is undefined.
https://bugs.webkit.org/show_bug.cgi?id=177565

Reviewed by Mark Lam.

Copy definition of 'BasePtrs' from bmalloc/GigaCage.h.

* wtf/Gigacage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoTry to fix the Mac CMake build
timothy_horton@apple.com [Thu, 28 Sep 2017 00:50:49 +0000 (00:50 +0000)]
Try to fix the Mac CMake build

* PlatformMac.cmake:
* pal/PlatformMac.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoPropagate hasBeenFlattenedBefore in Structure's transition constructor and fix our...
sbarati@apple.com [Thu, 28 Sep 2017 00:44:28 +0000 (00:44 +0000)]
Propagate hasBeenFlattenedBefore in Structure's transition constructor and fix our for-in caching to fail when the prototype chain has an object with a dictionary structure
https://bugs.webkit.org/show_bug.cgi?id=177523

Reviewed by Mark Lam.

JSTests:

* stress/prototype-chain-has-dictionary-structure-for-in-caching.js: Added.
(assert):
(Test):
(addMethods.Test.prototype.string_appeared_here.i.methodNumber):
(addMethods):
(i.Test.prototype.propName):

Source/JavaScriptCore:

There was a bug in Structure's transition constructor where it didn't
propagate forward the hasBeenFlattenedBefore bit. In practice, this meant
that every time we asked a dictionary structure if it has been flattened
before, it would return false. This patch fixes this bug. It also fixes
a bug that this uncovers in our for-in implementation. Our implementation
would cache the property name enumerator even when the prototype chain
included a structure that is as dictionary. This is wrong because that
prototype object may add properties without transitioning, and the for-in
loop would vend a stale set of prototype properties.

* jit/JITOperations.cpp:
* runtime/JSPropertyNameEnumerator.h:
(JSC::propertyNameEnumerator):
* runtime/Structure.cpp:
(JSC::Structure::Structure):
(JSC::Structure::canCachePropertyNameEnumerator const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMinimum font size may cause elements to have an infinite line-height
mmaxfield@apple.com [Thu, 28 Sep 2017 00:25:59 +0000 (00:25 +0000)]
Minimum font size may cause elements to have an infinite line-height
https://bugs.webkit.org/show_bug.cgi?id=177573
<rdar://problem/34573792>

Reviewed by Dan Bernstein.

Source/WebCore:

When minimum font size is specified, we were trying to preserve the ratio of specified font-size
and specified line-height in order to boost the computed font size proportionately to the font-size
boost. However, this doesn't work when the specified font-size is 0, because the ratio between
line-height and font-size is infinite.

The most straightforward solution is just to make small font-sizes opt out of the line-height
adjustment because the result would be too big.

Test: fast/text/line-height-minimumFontSize-text-small-font-size.html

* css/StyleBuilderCustom.h:
(WebCore::computeLineHeightMultiplierDueToFontSize):
(WebCore::StyleBuilderCustom::applyValueLineHeight):

LayoutTests:

* fast/text/line-height-minimumFontSize-text-small-font-size-expected.txt: Added.
* fast/text/line-height-minimumFontSize-text-small-font-size.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, rolling out r222337.
jlewis3@apple.com [Thu, 28 Sep 2017 00:07:12 +0000 (00:07 +0000)]
Unreviewed, rolling out r222337.

This test is failing on iOS.

Reverted changeset:

"Add long press and drag test"
https://bugs.webkit.org/show_bug.cgi?id=177289
http://trac.webkit.org/changeset/222337

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoYarr::Parser::tryConsumeGroupName() should check for the end of the pattern.
mark.lam@apple.com [Wed, 27 Sep 2017 23:58:33 +0000 (23:58 +0000)]
Yarr::Parser::tryConsumeGroupName() should check for the end of the pattern.
https://bugs.webkit.org/show_bug.cgi?id=177423
<rdar://problem/34621320>

Reviewed by Keith Miller.

JSTests:

* stress/regress-177423.js: Added.

Source/JavaScriptCore:

* yarr/YarrParser.h:
(JSC::Yarr::Parser::tryConsumeGroupName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWeb Inspector: Missing checks in DebuggerSidebarPanel for DOM debugging support
mattbaker@apple.com [Wed, 27 Sep 2017 23:54:41 +0000 (23:54 +0000)]
Web Inspector: Missing checks in DebuggerSidebarPanel for DOM debugging support
https://bugs.webkit.org/show_bug.cgi?id=177574

Reviewed by Joseph Pecoraro.

Check before using class members that are conditionally constructed based
on DOM debugging support.

* UserInterface/Views/DebuggerSidebarPanel.js:
(WI.DebuggerSidebarPanel.prototype.closed):
(WI.DebuggerSidebarPanel.prototype.restoreStateFromCookie):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAllow modern decoding of std::optional<T>
achristensen@apple.com [Wed, 27 Sep 2017 23:50:21 +0000 (23:50 +0000)]
Allow modern decoding of std::optional<T>
https://bugs.webkit.org/show_bug.cgi?id=177519

Reviewed by Tim Horton.

Source/WebCore:

* platform/DragItem.h:
(WebCore::DragItem::decode):

Source/WebKit:

* Platform/IPC/ArgumentCoders.h:
(IPC::ArgumentCoder<std::optional<T>>::decode):
* Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:
(IPC::ArgumentCoder<WebCore::PaymentAuthorizationResult>::decode):
(IPC::ArgumentCoder<WebCore::PaymentError>::decode):
(IPC::ArgumentCoder<WebCore::PaymentMethodUpdate>::decode):
(IPC::ArgumentCoder<WebCore::ShippingContactUpdate>::decode):
(IPC::ArgumentCoder<WebCore::ShippingMethodUpdate>::decode):
* Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<IntPoint>::decode):
(IPC::ArgumentCoder<IntSize>::decode):
* Shared/WebCoreArgumentCoders.h:
* Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::decode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, rolling out r222541.
commit-queue@webkit.org [Wed, 27 Sep 2017 23:25:07 +0000 (23:25 +0000)]
Unreviewed, rolling out r222541.
https://bugs.webkit.org/show_bug.cgi?id=177580

WebCore isn't ready for the asynchronousness this was going to
enable (Requested by alexchristensen on #webkit).

Reverted changeset:

"Pass a completion handler instead of a
WebFramePolicyListenerProxy during policy decisions"
https://bugs.webkit.org/show_bug.cgi?id=177509
http://trac.webkit.org/changeset/222541

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAdd macOS High Sierra and iOS Simulator 11 support to bisect-builds.
lforschler@apple.com [Wed, 27 Sep 2017 23:18:13 +0000 (23:18 +0000)]
Add macOS High Sierra and iOS Simulator 11 support to bisect-builds.
https://bugs.webkit.org/show_bug.cgi?id=177578

Reviewed by Alexey Proskuryakov.

* Scripts/bisect-builds:
(minified_platforms):
(unminified_platforms):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, fix x86 breaking due to exhausted registers
utatane.tea@gmail.com [Wed, 27 Sep 2017 22:59:49 +0000 (22:59 +0000)]
Unreviewed, fix x86 breaking due to exhausted registers
https://bugs.webkit.org/show_bug.cgi?id=175823

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleIntrinsicCall):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMarked imported/w3c/web-platform-tests/html/browsers/origin/relaxing-the-same-origin...
jlewis3@apple.com [Wed, 27 Sep 2017 22:54:26 +0000 (22:54 +0000)]
Marked imported/w3c/web-platform-tests/html/browsers/origin/relaxing-the-same-origin-restriction/document_domain_setter_null.tentative.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=177440

Unreviewed test gardening.

* platform/wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoVersioning.
jmarcell@apple.com [Wed, 27 Sep 2017 21:57:33 +0000 (21:57 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoExpose setShouldSuppressFirstResponderChanges() as WKView SPI
commit-queue@webkit.org [Wed, 27 Sep 2017 21:44:20 +0000 (21:44 +0000)]
Expose setShouldSuppressFirstResponderChanges() as WKView SPI
https://bugs.webkit.org/show_bug.cgi?id=177513
<rdar://problem/34669220>

Patch by Tina Liu <iting_liu@apple.com> on 2017-09-27
Reviewed by Wenson Hsieh.

We already have setShouldSuppressFirstResponderChanges() SPI on WKWebView; Expose it on
WKView as well for clients using legacy WebKit.

* UIProcess/API/Cocoa/WKViewPrivate.h:
* UIProcess/API/mac/WKView.mm:
(-[WKView _setShouldSuppressFirstResponderChanges:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago"Tag" codepoints require the complex text codepath
mmaxfield@apple.com [Wed, 27 Sep 2017 21:02:46 +0000 (21:02 +0000)]
"Tag" codepoints require the complex text codepath
https://bugs.webkit.org/show_bug.cgi?id=177251
<rdar://problem/34384001>

Reviewed by David Hyatt.

Source/WebCore:

Previously, Tag codepoints (U+E0000 - U+E007F) weren't triggering the
complex text codepath.

Eventually, we should migrate the default from simple to complex. I'll do
that in a separate patch.

Test: fast/text/flag-codepoint.html

* platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::characterRangeCodePath):

LayoutTests:

* fast/text/flag-codepoint-expected.html: Added.
* fast/text/flag-codepoint.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRename "FlowThread" to "FragmentedFlow"
hyatt@apple.com [Wed, 27 Sep 2017 20:54:17 +0000 (20:54 +0000)]
Rename "FlowThread" to "FragmentedFlow"
https://bugs.webkit.org/show_bug.cgi?id=177557

Reviewed by Zalan Bujtas.

* CMakeLists.txt:
* WebCore.xcodeproj/project.pbxproj:
* dom/Document.cpp:
(WebCore::Document::updateLayoutIfDimensionsOutOfDate):
* dom/Element.cpp:
(WebCore::Element::absoluteEventBounds):
* rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState):
* rendering/LayoutState.h:
(WebCore::LayoutState::currentRenderFragmentedFlow const):
(WebCore::LayoutState::setCurrentRenderFragmentedFlow):
(WebCore::LayoutState::currentRenderFlowThread const): Deleted.
(WebCore::LayoutState::setCurrentRenderFlowThread): Deleted.
* rendering/LogicalSelectionOffsetCaches.h:
(WebCore::LogicalSelectionOffsetCaches::ContainingBlockInfo::ContainingBlockInfo):
(WebCore::LogicalSelectionOffsetCaches::ContainingBlockInfo::setBlock):
(WebCore::LogicalSelectionOffsetCaches::ContainingBlockInfo::logicalLeftSelectionOffset const):
(WebCore::LogicalSelectionOffsetCaches::ContainingBlockInfo::logicalRightSelectionOffset const):
(WebCore::LogicalSelectionOffsetCaches::ContainingBlockInfo::hasFloatsOrFragmentedFlows const):
(WebCore::LogicalSelectionOffsetCaches::LogicalSelectionOffsetCaches):
(WebCore::LogicalSelectionOffsetCaches::ContainingBlockInfo::hasFloatsOrFlowThreads const): Deleted.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::clone const):
(WebCore::RenderBlock::removeLeftoverAnonymousBlock):
(WebCore::RenderBlock::preparePaginationBeforeBlockLayout):
(WebCore::RenderBlock::addOverflowFromChildren):
(WebCore::RenderBlock::addVisualOverflowFromTheme):
(WebCore::RenderBlock::computeStartPositionDeltaForChildAvoidingFloats):
(WebCore::RenderBlock::simplifiedLayout):
(WebCore::RenderBlock::isSelectionRoot const):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::insertPositionedObject):
(WebCore::isChildHitTestCandidate):
(WebCore::RenderBlock::cachedEnclosingFragmentedFlow const):
(WebCore::RenderBlock::cachedEnclosingFragmentedFlowNeedsUpdate const):
(WebCore::RenderBlock::setCachedEnclosingFragmentedFlowNeedsUpdate):
(WebCore::RenderBlock::updateCachedEnclosingFragmentedFlow const):
(WebCore::RenderBlock::locateEnclosingFragmentedFlow const):
(WebCore::RenderBlock::resetEnclosingFragmentedFlowAndChildInfoIncludingDescendants):
(WebCore::RenderBlock::absoluteQuads const):
(WebCore::RenderBlock::offsetFromLogicalTopOfFirstPage const):
(WebCore::RenderBlock::fragmentAtBlockOffset const):
(WebCore::canComputeFragmentRangeForBox):
(WebCore::RenderBlock::childBoxIsUnsplittableForFragmentation const):
(WebCore::RenderBlock::computeFragmentRangeForBoxChild const):
(WebCore::RenderBlock::estimateFragmentRangeForBoxChild const):
(WebCore::RenderBlock::updateFragmentRangeForBoxChild const):
(WebCore::RenderBlock::cachedFlowThreadContainingBlock const): Deleted.
(WebCore::RenderBlock::cachedFlowThreadContainingBlockNeedsUpdate const): Deleted.
(WebCore::RenderBlock::setCachedFlowThreadContainingBlockNeedsUpdate): Deleted.
(WebCore::RenderBlock::updateCachedFlowThreadContainingBlock const): Deleted.
(WebCore::RenderBlock::locateFlowThreadContainingBlock const): Deleted.
(WebCore::RenderBlock::resetFlowThreadContainingBlockAndChildInfoIncludingDescendants): Deleted.
* rendering/RenderBlock.h:
* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::willCreateColumns const):
(WebCore::RenderBlockFlow::layoutBlock):
(WebCore::RenderBlockFlow::layoutBlockChild):
(WebCore::RenderBlockFlow::setStaticInlinePositionForChild):
(WebCore::inNormalFlow):
(WebCore::RenderBlockFlow::applyBeforeBreak):
(WebCore::RenderBlockFlow::applyAfterBreak):
(WebCore::RenderBlockFlow::adjustLinePositionForPagination):
(WebCore::RenderBlockFlow::hasNextPage const):
(WebCore::RenderBlockFlow::adjustForUnsplittableChild):
(WebCore::RenderBlockFlow::setPageBreak):
(WebCore::RenderBlockFlow::updateMinimumPageHeight):
(WebCore::RenderBlockFlow::pageLogicalTopForOffset const):
(WebCore::RenderBlockFlow::pageLogicalHeightForOffset const):
(WebCore::RenderBlockFlow::pageRemainingLogicalHeightForOffset const):
(WebCore::RenderBlockFlow::styleDidChange):
(WebCore::RenderBlockFlow::updateStylesForColumnChildren):
(WebCore::RenderBlockFlow::computeOverflow):
(WebCore::RenderBlockFlow::paintColumnRules):
(WebCore::RenderBlockFlow::computeLogicalLocationForFloat):
(WebCore::RenderBlockFlow::setMultiColumnFlow):
(WebCore::RenderBlockFlow::relayoutForPagination):
(WebCore::RenderBlockFlow::layoutExcludedChildren):
(WebCore::RenderBlockFlow::addChild):
(WebCore::RenderBlockFlow::removeChild):
(WebCore::RenderBlockFlow::checkForPaginationLogicalHeightChange):
(WebCore::RenderBlockFlow::setComputedColumnCountAndWidth):
(WebCore::RenderBlockFlow::updateColumnProgressionFromStyle):
(WebCore::RenderBlockFlow::computedColumnWidth const):
(WebCore::RenderBlockFlow::computedColumnCount const):
(WebCore::RenderBlockFlow::isTopLayoutOverflowAllowed const):
(WebCore::RenderBlockFlow::isLeftLayoutOverflowAllowed const):
(WebCore::RenderBlockFlow::setMultiColumnFlowThread): Deleted.
* rendering/RenderBlockFlow.h:
(WebCore::RenderBlockFlow::RenderBlockFlowRareData::RenderBlockFlowRareData):
(WebCore::RenderBlockFlow::multiColumnFlow const):
(WebCore::RenderBlockFlow::multiColumnFlowThread const): Deleted.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::layoutRunsAndFloatsInRange):
(WebCore::RenderBlockFlow::linkToEndLineIfNeeded):
(WebCore::RenderBlockFlow::layoutLineBoxes):
(WebCore::RenderBlockFlow::determineStartPosition):
(WebCore::RenderBlockFlow::checkPaginationAndFloatsAtEndLine):
(WebCore::RenderBlockFlow::lineWidthForPaginatedLineChanged const):
(WebCore::RenderBlockFlow::addOverflowFromInlineChildren):
(WebCore::RenderBlockFlow::updateFragmentForLine const):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::clampToStartAndEndFragments const):
(WebCore::RenderBox::hasFragmentRangeInFragmentedFlow const):
(WebCore::RenderBox::styleDidChange):
(WebCore::RenderBox::absoluteQuads const):
(WebCore::RenderBox::shrinkLogicalWidthToAvoidFloats const):
(WebCore::RenderBox::containingBlockAvailableLineWidthInFragment const):
(WebCore::RenderBox::offsetFromContainer const):
(WebCore::RenderBox::computeRectForRepaint const):
(WebCore::RenderBox::skipContainingBlockForPercentHeightCalculation const):
(WebCore::RenderBox::availableLogicalHeightUsing const):
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned const):
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned const):
(WebCore::RenderBox::computePositionedLogicalWidth const):
(WebCore::RenderBox::computePositionedLogicalHeight const):
(WebCore::RenderBox::positionForPoint):
(WebCore::RenderBox::createsNewFormattingContext const):
(WebCore::RenderBox::addVisualEffectOverflow):
(WebCore::RenderBox::addOverflowFromChild):
(WebCore::RenderBox::clearOverflow):
(WebCore::RenderBox::offsetFromLogicalTopOfFirstPage const):
(WebCore::RenderBox::hasFragmentRangeInFlowThread const): Deleted.
* rendering/RenderBox.h:
(WebCore::RenderBox::canHaveOutsideFragmentRange const):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::adjustedPositionRelativeToOffsetParent const):
(WebCore::RenderBoxModelObject::mapAbsoluteToLocalPoint const):
* rendering/RenderElement.cpp:
(WebCore::RenderElement::setStyle):
(WebCore::RenderElement::insertChildInternal):
(WebCore::RenderElement::removeChildInternal):
(WebCore::RenderElement::propagateStyleToAnonymousChildren):
(WebCore::RenderElement::adjustFragmentedFlowStateOnContainingBlockChangeIfNeeded):
(WebCore::RenderElement::removeFromRenderFragmentedFlow):
(WebCore::RenderElement::removeFromRenderFragmentedFlowIncludingDescendants):
(WebCore::RenderElement::resetEnclosingFragmentedFlowAndChildInfoIncludingDescendants):
(WebCore::RenderElement::adjustFlowThreadStateOnContainingBlockChangeIfNeeded): Deleted.
(WebCore::RenderElement::removeFromRenderFlowThread): Deleted.
(WebCore::RenderElement::removeFromRenderFlowThreadIncludingDescendants): Deleted.
(WebCore::RenderElement::resetFlowThreadContainingBlockAndChildInfoIncludingDescendants): Deleted.
* rendering/RenderElement.h:
(WebCore::RenderElement::canContainFixedPositionObjects const):
* rendering/RenderFlowThread.cpp: Removed.
* rendering/RenderFlowThread.h: Removed.
* rendering/RenderFragmentContainer.cpp:
(WebCore::RenderFragmentContainer::RenderFragmentContainer):
(WebCore::RenderFragmentContainer::mapFragmentPointIntoFragmentedFlowCoordinates):
(WebCore::RenderFragmentContainer::positionForPoint):
(WebCore::RenderFragmentContainer::pageLogicalWidth const):
(WebCore::RenderFragmentContainer::pageLogicalHeight const):
(WebCore::RenderFragmentContainer::logicalHeightOfAllFragmentedFlowContent const):
(WebCore::RenderFragmentContainer::fragmentedFlowPortionOverflowRect):
(WebCore::RenderFragmentContainer::fragmentedFlowPortionLocation const):
(WebCore::RenderFragmentContainer::overflowRectForFragmentedFlowPortion):
(WebCore::RenderFragmentContainer::pageLogicalTopForOffset const):
(WebCore::RenderFragmentContainer::isFirstFragment const):
(WebCore::RenderFragmentContainer::isLastFragment const):
(WebCore::RenderFragmentContainer::shouldClipFragmentedFlowContent const):
(WebCore::RenderFragmentContainer::styleDidChange):
(WebCore::RenderFragmentContainer::computeOverflowFromFragmentedFlow):
(WebCore::RenderFragmentContainer::repaintFragmentedFlowContent):
(WebCore::RenderFragmentContainer::repaintFragmentedFlowContentRectangle):
(WebCore::RenderFragmentContainer::installFragmentedFlow):
(WebCore::RenderFragmentContainer::attachFragment):
(WebCore::RenderFragmentContainer::detachFragment):
(WebCore::RenderFragmentContainer::logicalTopOfFragmentedFlowContentRect const):
(WebCore::RenderFragmentContainer::logicalBottomOfFragmentedFlowContentRect const):
(WebCore::RenderFragmentContainer::computeIntrinsicLogicalWidths const):
(WebCore::RenderFragmentContainer::adjustFragmentBoundsFromFragmentedFlowPortionRect const):
(WebCore::RenderFragmentContainer::ensureOverflowForBox):
(WebCore::RenderFragmentContainer::rectFlowPortionForBox const):
(WebCore::RenderFragmentContainer::addVisualOverflowForBox):
(WebCore::RenderFragmentContainer::visualOverflowRectForBoxForPropagation):
(WebCore::CurrentRenderFragmentContainerMaintainer::CurrentRenderFragmentContainerMaintainer):
(WebCore::CurrentRenderFragmentContainerMaintainer::~CurrentRenderFragmentContainerMaintainer):
(WebCore::RenderFragmentContainer::mapFragmentPointIntoFlowThreadCoordinates): Deleted.
(WebCore::RenderFragmentContainer::logicalHeightOfAllFlowThreadContent const): Deleted.
(WebCore::RenderFragmentContainer::flowThreadPortionOverflowRect): Deleted.
(WebCore::RenderFragmentContainer::flowThreadPortionLocation const): Deleted.
(WebCore::RenderFragmentContainer::overflowRectForFlowThreadPortion): Deleted.
(WebCore::RenderFragmentContainer::shouldClipFlowThreadContent const): Deleted.
(WebCore::RenderFragmentContainer::computeOverflowFromFlowThread): Deleted.
(WebCore::RenderFragmentContainer::repaintFlowThreadContent): Deleted.
(WebCore::RenderFragmentContainer::repaintFlowThreadContentRectangle): Deleted.
(WebCore::RenderFragmentContainer::installFlowThread): Deleted.
(WebCore::RenderFragmentContainer::logicalTopOfFlowThreadContentRect const): Deleted.
(WebCore::RenderFragmentContainer::logicalBottomOfFlowThreadContentRect const): Deleted.
(WebCore::RenderFragmentContainer::adjustFragmentBoundsFromFlowThreadPortionRect const): Deleted.
* rendering/RenderFragmentContainer.h:
(WebCore::RenderFragmentContainer::setFragmentedFlowPortionRect):
(WebCore::RenderFragmentContainer::fragmentedFlowPortionRect const):
(WebCore::RenderFragmentContainer::fragmentedFlow const):
(WebCore::RenderFragmentContainer::logicalTopForFragmentedFlowContent const):
(WebCore::RenderFragmentContainer::logicalBottomForFragmentedFlowContent const):
(WebCore::RenderFragmentContainer::setFlowThreadPortionRect): Deleted.
(WebCore::RenderFragmentContainer::flowThreadPortionRect const): Deleted.
(WebCore::RenderFragmentContainer::flowThread const): Deleted.
(WebCore::RenderFragmentContainer::logicalTopForFlowThreadContent const): Deleted.
(WebCore::RenderFragmentContainer::logicalBottomForFlowThreadContent const): Deleted.
* rendering/RenderFragmentContainerSet.cpp:
(WebCore::RenderFragmentContainerSet::RenderFragmentContainerSet):
(WebCore::RenderFragmentContainerSet::installFragmentedFlow):
(WebCore::RenderFragmentContainerSet::expandToEncompassFragmentedFlowContentsIfNeeded):
(WebCore::RenderFragmentContainerSet::installFlowThread): Deleted.
(WebCore::RenderFragmentContainerSet::expandToEncompassFlowThreadContentsIfNeeded): Deleted.
* rendering/RenderFragmentContainerSet.h:
* rendering/RenderFragmentedFlow.cpp: Copied from rendering/RenderFlowThread.cpp.
(WebCore::RenderFragmentedFlow::RenderFragmentedFlow):
(WebCore::RenderFragmentedFlow::createFragmentedFlowStyle):
(WebCore::RenderFragmentedFlow::styleDidChange):
(WebCore::RenderFragmentedFlow::removeFlowChildInfo):
(WebCore::RenderFragmentedFlow::removeFragmentFromThread):
(WebCore::RenderFragmentedFlow::invalidateFragments):
(WebCore::RenderFragmentedFlow::validateFragments):
(WebCore::RenderFragmentedFlow::layout):
(WebCore::RenderFragmentedFlow::updateLogicalWidth):
(WebCore::RenderFragmentedFlow::computeLogicalHeight const):
(WebCore::RenderFragmentedFlow::nodeAtPoint):
(WebCore::RenderFragmentedFlow::shouldRepaint const):
(WebCore::RenderFragmentedFlow::repaintRectangleInFragments const):
(WebCore::RenderFragmentedFlow::fragmentAtBlockOffset const):
(WebCore::RenderFragmentedFlow::adjustedPositionRelativeToOffsetParent const):
(WebCore::RenderFragmentedFlow::pageLogicalTopForOffset const):
(WebCore::RenderFragmentedFlow::pageLogicalWidthForOffset const):
(WebCore::RenderFragmentedFlow::pageLogicalHeightForOffset const):
(WebCore::RenderFragmentedFlow::pageRemainingLogicalHeightForOffset const):
(WebCore::RenderFragmentedFlow::mapFromFlowToFragment const):
(WebCore::RenderFragmentedFlow::removeRenderBoxFragmentInfo):
(WebCore::RenderFragmentedFlow::removeLineFragmentInfo):
(WebCore::RenderFragmentedFlow::logicalWidthChangedInFragmentsForBlock):
(WebCore::RenderFragmentedFlow::contentLogicalWidthOfFirstFragment const):
(WebCore::RenderFragmentedFlow::contentLogicalHeightOfFirstFragment const):
(WebCore::RenderFragmentedFlow::contentLogicalLeftOfFirstFragment const):
(WebCore::RenderFragmentedFlow::firstFragment const):
(WebCore::RenderFragmentedFlow::lastFragment const):
(WebCore::RenderFragmentedFlow::clearRenderBoxFragmentInfoAndCustomStyle):
(WebCore::RenderFragmentedFlow::setFragmentRangeForBox):
(WebCore::RenderFragmentedFlow::hasCachedFragmentRangeForBox const):
(WebCore::RenderFragmentedFlow::getFragmentRangeForBoxFromCachedInfo const):
(WebCore::RenderFragmentedFlow::getFragmentRangeForBox const):
(WebCore::RenderFragmentedFlow::computedFragmentRangeForBox const):
(WebCore::RenderFragmentedFlow::fragmentInRange const):
(WebCore::RenderFragmentedFlow::objectShouldFragmentInFlowFragment const):
(WebCore::RenderFragmentedFlow::objectInFlowFragment const):
(WebCore::RenderFragmentedFlow::checkLinesConsistency const):
(WebCore::RenderFragmentedFlow::clearLinesToFragmentMap):
(WebCore::RenderFragmentedFlow::deleteLines):
(WebCore::RenderFragmentedFlow::willBeDestroyed):
(WebCore::RenderFragmentedFlow::markFragmentsForOverflowLayoutIfNeeded):
(WebCore::RenderFragmentedFlow::updateFragmentsFragmentedFlowPortionRect):
(WebCore::RenderFragmentedFlow::addForcedFragmentBreak):
(WebCore::RenderFragmentedFlow::collectLayerFragments):
(WebCore::RenderFragmentedFlow::fragmentsBoundingBox):
(WebCore::RenderFragmentedFlow::offsetFromLogicalTopOfFirstFragment const):
(WebCore::RenderFragmentedFlow::FragmentSearchAdapter::collectIfNeeded):
(WebCore::RenderFragmentedFlow::mapLocalToContainer const):
(WebCore::RenderFragmentedFlow::mapFromLocalToFragmentedFlow const):
(WebCore::RenderFragmentedFlow::mapFromFragmentedFlowToLocal const):
(WebCore::RenderFragmentedFlow::flipForWritingModeLocalCoordinates const):
(WebCore::RenderFragmentedFlow::addFragmentsVisualEffectOverflow):
(WebCore::RenderFragmentedFlow::addFragmentsVisualOverflowFromTheme):
(WebCore::RenderFragmentedFlow::addFragmentsOverflowFromChild):
(WebCore::RenderFragmentedFlow::addFragmentsLayoutOverflow):
(WebCore::RenderFragmentedFlow::addFragmentsVisualOverflow):
(WebCore::RenderFragmentedFlow::clearFragmentsOverflow):
(WebCore::RenderFragmentedFlow::currentFragment const):
(WebCore::RenderFragmentedFlow::containingFragmentMap):
(WebCore::RenderFlowThread::RenderFlowThread): Deleted.
(WebCore::RenderFlowThread::createFlowThreadStyle): Deleted.
(WebCore::RenderFlowThread::styleDidChange): Deleted.
(WebCore::RenderFlowThread::removeFlowChildInfo): Deleted.
(WebCore::RenderFlowThread::removeFragmentFromThread): Deleted.
(WebCore::RenderFlowThread::invalidateFragments): Deleted.
(WebCore::RenderFlowThread::validateFragments): Deleted.
(WebCore::RenderFlowThread::layout): Deleted.
(WebCore::RenderFlowThread::updateLogicalWidth): Deleted.
(WebCore::RenderFlowThread::computeLogicalHeight const): Deleted.
(WebCore::RenderFlowThread::nodeAtPoint): Deleted.
(WebCore::RenderFlowThread::shouldRepaint const): Deleted.
(WebCore::RenderFlowThread::repaintRectangleInFragments const): Deleted.
(WebCore::RenderFlowThread::fragmentAtBlockOffset const): Deleted.
(WebCore::RenderFlowThread::adjustedPositionRelativeToOffsetParent const): Deleted.
(WebCore::RenderFlowThread::pageLogicalTopForOffset const): Deleted.
(WebCore::RenderFlowThread::pageLogicalWidthForOffset const): Deleted.
(WebCore::RenderFlowThread::pageLogicalHeightForOffset const): Deleted.
(WebCore::RenderFlowThread::pageRemainingLogicalHeightForOffset const): Deleted.
(WebCore::RenderFlowThread::mapFromFlowToFragment const): Deleted.
(WebCore::RenderFlowThread::removeRenderBoxFragmentInfo): Deleted.
(WebCore::RenderFlowThread::removeLineFragmentInfo): Deleted.
(WebCore::RenderFlowThread::logicalWidthChangedInFragmentsForBlock): Deleted.
(WebCore::RenderFlowThread::contentLogicalWidthOfFirstFragment const): Deleted.
(WebCore::RenderFlowThread::contentLogicalHeightOfFirstFragment const): Deleted.
(WebCore::RenderFlowThread::contentLogicalLeftOfFirstFragment const): Deleted.
(WebCore::RenderFlowThread::firstFragment const): Deleted.
(WebCore::RenderFlowThread::lastFragment const): Deleted.
(WebCore::RenderFlowThread::clearRenderBoxFragmentInfoAndCustomStyle): Deleted.
(WebCore::RenderFlowThread::setFragmentRangeForBox): Deleted.
(WebCore::RenderFlowThread::hasCachedFragmentRangeForBox const): Deleted.
(WebCore::RenderFlowThread::getFragmentRangeForBoxFromCachedInfo const): Deleted.
(WebCore::RenderFlowThread::getFragmentRangeForBox const): Deleted.
(WebCore::RenderFlowThread::computedFragmentRangeForBox const): Deleted.
(WebCore::RenderFlowThread::fragmentInRange const): Deleted.
(WebCore::RenderFlowThread::objectShouldFragmentInFlowFragment const): Deleted.
(WebCore::RenderFlowThread::objectInFlowFragment const): Deleted.
(WebCore::RenderFlowThread::checkLinesConsistency const): Deleted.
(WebCore::RenderFlowThread::clearLinesToFragmentMap): Deleted.
(WebCore::RenderFlowThread::deleteLines): Deleted.
(WebCore::RenderFlowThread::willBeDestroyed): Deleted.
(WebCore::RenderFlowThread::markFragmentsForOverflowLayoutIfNeeded): Deleted.
(WebCore::RenderFlowThread::updateFragmentsFlowThreadPortionRect): Deleted.
(WebCore::RenderFlowThread::addForcedFragmentBreak): Deleted.
(WebCore::RenderFlowThread::collectLayerFragments): Deleted.
(WebCore::RenderFlowThread::fragmentsBoundingBox): Deleted.
(WebCore::RenderFlowThread::offsetFromLogicalTopOfFirstFragment const): Deleted.
(WebCore::RenderFlowThread::FragmentSearchAdapter::collectIfNeeded): Deleted.
(WebCore::RenderFlowThread::mapLocalToContainer const): Deleted.
(WebCore::RenderFlowThread::mapFromLocalToFlowThread const): Deleted.
(WebCore::RenderFlowThread::mapFromFlowThreadToLocal const): Deleted.
(WebCore::RenderFlowThread::flipForWritingModeLocalCoordinates const): Deleted.
(WebCore::RenderFlowThread::addFragmentsVisualEffectOverflow): Deleted.
(WebCore::RenderFlowThread::addFragmentsVisualOverflowFromTheme): Deleted.
(WebCore::RenderFlowThread::addFragmentsOverflowFromChild): Deleted.
(WebCore::RenderFlowThread::addFragmentsLayoutOverflow): Deleted.
(WebCore::RenderFlowThread::addFragmentsVisualOverflow): Deleted.
(WebCore::RenderFlowThread::clearFragmentsOverflow): Deleted.
(WebCore::RenderFlowThread::currentFragment const): Deleted.
(WebCore::RenderFlowThread::containingFragmentMap): Deleted.
* rendering/RenderFragmentedFlow.h: Copied from rendering/RenderFlowThread.h.
* rendering/RenderGeometryMap.cpp:
(WebCore::canMapBetweenRenderersViaLayers):
(WebCore::RenderGeometryMap::pushRenderFragmentedFlow):
(WebCore::RenderGeometryMap::pushRenderFlowThread): Deleted.
* rendering/RenderGeometryMap.h:
* rendering/RenderImage.cpp:
(WebCore::RenderImage::layoutShadowControls):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::addChild):
(WebCore::RenderInline::clone const):
(WebCore::RenderInline::splitInlines):
(WebCore::RenderInline::offsetFromContainer const):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::updatePagination):
(WebCore::transparencyClipBox):
(WebCore::accumulateOffsetTowardsAncestor):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::collectFragments):
(WebCore::RenderLayer::hitTest):
(WebCore::RenderLayer::enclosingFragmentedFlowAncestor const):
(WebCore::RenderLayer::hitTestContents const):
(WebCore::RenderLayer::calculateClipRects const):
(WebCore::RenderLayer::enclosingFlowThreadAncestor const): Deleted.
* rendering/RenderLayer.h:
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::computeParentGraphicsLayerRect const):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::canBeComposited const):
* rendering/RenderMedia.cpp:
* rendering/RenderMultiColumnFlow.cpp: Copied from rendering/RenderMultiColumnFlowThread.cpp.
(WebCore::RenderMultiColumnFlow::RenderMultiColumnFlow):
(WebCore::RenderMultiColumnFlow::~RenderMultiColumnFlow):
(WebCore::RenderMultiColumnFlow::renderName const):
(WebCore::RenderMultiColumnFlow::firstMultiColumnSet const):
(WebCore::RenderMultiColumnFlow::lastMultiColumnSet const):
(WebCore::RenderMultiColumnFlow::firstColumnSetOrSpanner const):
(WebCore::RenderMultiColumnFlow::nextColumnSetOrSpannerSiblingOf):
(WebCore::RenderMultiColumnFlow::previousColumnSetOrSpannerSiblingOf):
(WebCore::RenderMultiColumnFlow::layout):
(WebCore::findSetRendering):
(WebCore::RenderMultiColumnFlow::populate):
(WebCore::RenderMultiColumnFlow::evacuateAndDestroy):
(WebCore::RenderMultiColumnFlow::addFragmentToThread):
(WebCore::RenderMultiColumnFlow::willBeRemovedFromTree):
(WebCore::RenderMultiColumnFlow::resolveMovedChild const):
(WebCore::isValidColumnSpanner):
(WebCore::spannerPlacehoderCandidate):
(WebCore::RenderMultiColumnFlow::processPossibleSpannerDescendant):
(WebCore::RenderMultiColumnFlow::fragmentedFlowDescendantInserted):
(WebCore::RenderMultiColumnFlow::handleSpannerRemoval):
(WebCore::RenderMultiColumnFlow::fragmentedFlowRelativeWillBeRemoved):
(WebCore::RenderMultiColumnFlow::fragmentedFlowDescendantBoxLaidOut):
(WebCore::RenderMultiColumnFlow::computeLogicalHeight const):
(WebCore::RenderMultiColumnFlow::initialLogicalWidth const):
(WebCore::RenderMultiColumnFlow::setPageBreak):
(WebCore::RenderMultiColumnFlow::updateMinimumPageHeight):
(WebCore::RenderMultiColumnFlow::fragmentAtBlockOffset const):
(WebCore::RenderMultiColumnFlow::setFragmentRangeForBox):
(WebCore::RenderMultiColumnFlow::addForcedFragmentBreak):
(WebCore::RenderMultiColumnFlow::computeLineGridPaginationOrigin const):
(WebCore::RenderMultiColumnFlow::offsetFromContainer const):
(WebCore::RenderMultiColumnFlow::mapAbsoluteToLocalPoint const):
(WebCore::RenderMultiColumnFlow::physicalTranslationFromFragmentToFlow const):
(WebCore::RenderMultiColumnFlow::mapFromFlowToFragment const):
(WebCore::RenderMultiColumnFlow::physicalTranslationOffsetFromFlowToFragment const):
(WebCore::RenderMultiColumnFlow::physicalTranslationFromFlowToFragment const):
(WebCore::RenderMultiColumnFlow::isPageLogicalHeightKnown const):
(WebCore::RenderMultiColumnFlow::nodeAtPoint):
(WebCore::RenderMultiColumnFlow::shouldCheckColumnBreaks const):
(WebCore::RenderMultiColumnFlowThread::RenderMultiColumnFlowThread): Deleted.
(WebCore::RenderMultiColumnFlowThread::~RenderMultiColumnFlowThread): Deleted.
(WebCore::RenderMultiColumnFlowThread::renderName const): Deleted.
(WebCore::RenderMultiColumnFlowThread::firstMultiColumnSet const): Deleted.
(WebCore::RenderMultiColumnFlowThread::lastMultiColumnSet const): Deleted.
(WebCore::RenderMultiColumnFlowThread::firstColumnSetOrSpanner const): Deleted.
(WebCore::RenderMultiColumnFlowThread::nextColumnSetOrSpannerSiblingOf): Deleted.
(WebCore::RenderMultiColumnFlowThread::previousColumnSetOrSpannerSiblingOf): Deleted.
(WebCore::RenderMultiColumnFlowThread::layout): Deleted.
(WebCore::RenderMultiColumnFlowThread::populate): Deleted.
(WebCore::RenderMultiColumnFlowThread::evacuateAndDestroy): Deleted.
(WebCore::RenderMultiColumnFlowThread::addFragmentToThread): Deleted.
(WebCore::RenderMultiColumnFlowThread::willBeRemovedFromTree): Deleted.
(WebCore::RenderMultiColumnFlowThread::resolveMovedChild const): Deleted.
(WebCore::RenderMultiColumnFlowThread::processPossibleSpannerDescendant): Deleted.
(WebCore::RenderMultiColumnFlowThread::flowThreadDescendantInserted): Deleted.
(WebCore::RenderMultiColumnFlowThread::handleSpannerRemoval): Deleted.
(WebCore::RenderMultiColumnFlowThread::flowThreadRelativeWillBeRemoved): Deleted.
(WebCore::RenderMultiColumnFlowThread::flowThreadDescendantBoxLaidOut): Deleted.
(WebCore::RenderMultiColumnFlowThread::computeLogicalHeight const): Deleted.
(WebCore::RenderMultiColumnFlowThread::initialLogicalWidth const): Deleted.
(WebCore::RenderMultiColumnFlowThread::setPageBreak): Deleted.
(WebCore::RenderMultiColumnFlowThread::updateMinimumPageHeight): Deleted.
(WebCore::RenderMultiColumnFlowThread::fragmentAtBlockOffset const): Deleted.
(WebCore::RenderMultiColumnFlowThread::setFragmentRangeForBox): Deleted.
(WebCore::RenderMultiColumnFlowThread::addForcedFragmentBreak): Deleted.
(WebCore::RenderMultiColumnFlowThread::computeLineGridPaginationOrigin const): Deleted.
(WebCore::RenderMultiColumnFlowThread::offsetFromContainer const): Deleted.
(WebCore::RenderMultiColumnFlowThread::mapAbsoluteToLocalPoint const): Deleted.
(WebCore::RenderMultiColumnFlowThread::physicalTranslationFromFragmentToFlow const): Deleted.
(WebCore::RenderMultiColumnFlowThread::mapFromFlowToFragment const): Deleted.
(WebCore::RenderMultiColumnFlowThread::physicalTranslationOffsetFromFlowToFragment const): Deleted.
(WebCore::RenderMultiColumnFlowThread::physicalTranslationFromFlowToFragment const): Deleted.
(WebCore::RenderMultiColumnFlowThread::isPageLogicalHeightKnown const): Deleted.
(WebCore::RenderMultiColumnFlowThread::nodeAtPoint): Deleted.
(WebCore::RenderMultiColumnFlowThread::shouldCheckColumnBreaks const): Deleted.
* rendering/RenderMultiColumnFlow.h: Copied from rendering/RenderMultiColumnFlowThread.h.
* rendering/RenderMultiColumnFlowThread.cpp: Removed.
* rendering/RenderMultiColumnFlowThread.h: Removed.
* rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::RenderMultiColumnSet):
(WebCore::RenderMultiColumnSet::firstRendererInFragmentedFlow const):
(WebCore::RenderMultiColumnSet::lastRendererInFragmentedFlow const):
(WebCore::RenderMultiColumnSet::containsRendererInFragmentedFlow const):
(WebCore::RenderMultiColumnSet::setLogicalTopInFragmentedFlow):
(WebCore::RenderMultiColumnSet::setLogicalBottomInFragmentedFlow):
(WebCore::RenderMultiColumnSet::pageLogicalTopForOffset const):
(WebCore::RenderMultiColumnSet::setAndConstrainColumnHeight):
(WebCore::RenderMultiColumnSet::distributeImplicitBreaks):
(WebCore::RenderMultiColumnSet::calculateBalancedHeight const):
(WebCore::RenderMultiColumnSet::recalculateColumnHeight):
(WebCore::RenderMultiColumnSet::updateLogicalWidth):
(WebCore::RenderMultiColumnSet::requiresBalancing const):
(WebCore::RenderMultiColumnSet::prepareForLayout):
(WebCore::RenderMultiColumnSet::beginFlow):
(WebCore::RenderMultiColumnSet::endFlow):
(WebCore::RenderMultiColumnSet::layout):
(WebCore::RenderMultiColumnSet::calculateMaxColumnHeight const):
(WebCore::RenderMultiColumnSet::columnCount const):
(WebCore::RenderMultiColumnSet::columnLogicalLeft const):
(WebCore::RenderMultiColumnSet::columnLogicalTop const):
(WebCore::RenderMultiColumnSet::columnIndexAtOffset const):
(WebCore::RenderMultiColumnSet::fragmentedFlowPortionRectAt const):
(WebCore::RenderMultiColumnSet::fragmentedFlowPortionOverflowRect):
(WebCore::RenderMultiColumnSet::paintColumnRules):
(WebCore::RenderMultiColumnSet::repaintFragmentedFlowContent):
(WebCore::RenderMultiColumnSet::initialBlockOffsetForPainting const):
(WebCore::RenderMultiColumnSet::collectLayerFragments):
(WebCore::RenderMultiColumnSet::columnTranslationForOffset const):
(WebCore::RenderMultiColumnSet::adjustFragmentBoundsFromFragmentedFlowPortionRect const):
(WebCore::RenderMultiColumnSet::positionForPoint):
(WebCore::RenderMultiColumnSet::translateFragmentPointToFragmentedFlow const):
(WebCore::RenderMultiColumnSet::updateHitTestResult):
(WebCore::RenderMultiColumnSet::firstRendererInFlowThread const): Deleted.
(WebCore::RenderMultiColumnSet::lastRendererInFlowThread const): Deleted.
(WebCore::RenderMultiColumnSet::containsRendererInFlowThread const): Deleted.
(WebCore::RenderMultiColumnSet::setLogicalTopInFlowThread): Deleted.
(WebCore::RenderMultiColumnSet::setLogicalBottomInFlowThread): Deleted.
(WebCore::RenderMultiColumnSet::flowThreadPortionRectAt const): Deleted.
(WebCore::RenderMultiColumnSet::flowThreadPortionOverflowRect): Deleted.
(WebCore::RenderMultiColumnSet::repaintFlowThreadContent): Deleted.
(WebCore::RenderMultiColumnSet::adjustFragmentBoundsFromFlowThreadPortionRect const): Deleted.
(WebCore::RenderMultiColumnSet::translateFragmentPointToFlowThread const): Deleted.
* rendering/RenderMultiColumnSet.h:
* rendering/RenderMultiColumnSpannerPlaceholder.cpp:
(WebCore::RenderMultiColumnSpannerPlaceholder::createAnonymous):
(WebCore::RenderMultiColumnSpannerPlaceholder::RenderMultiColumnSpannerPlaceholder):
* rendering/RenderMultiColumnSpannerPlaceholder.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::setFragmentedFlowStateIncludingDescendants):
(WebCore::RenderObject::computedFragmentedFlowState):
(WebCore::RenderObject::initializeFragmentedFlowStateOnInsertion):
(WebCore::RenderObject::resetFragmentedFlowStateOnRemoval):
(WebCore::RenderObject::containerForRepaint const):
(WebCore::RenderObject::repaintUsingContainer const):
(WebCore::enclosingFragmentedFlowFromRenderer):
(WebCore::RenderObject::outputRegionsInformation const):
(WebCore::RenderObject::selectionRoot const):
(WebCore::RenderObject::offsetFromContainer const):
(WebCore::RenderObject::insertedIntoTree):
(WebCore::RenderObject::locateEnclosingFragmentedFlow const):
(WebCore::RenderObject::setIsRenderFragmentedFlow):
(WebCore::RenderObject::setFlowThreadStateIncludingDescendants): Deleted.
(WebCore::RenderObject::computedFlowThreadState): Deleted.
(WebCore::RenderObject::initializeFlowThreadStateOnInsertion): Deleted.
(WebCore::RenderObject::resetFlowThreadStateOnRemoval): Deleted.
(WebCore::flowThreadContainingBlockFromRenderer): Deleted.
(WebCore::RenderObject::locateFlowThreadContainingBlock const): Deleted.
(WebCore::RenderObject::setIsRenderFlowThread): Deleted.
* rendering/RenderObject.h:
(WebCore::RenderObject::enclosingFragmentedFlow const):
(WebCore::RenderObject::isInFlowRenderFragmentedFlow const):
(WebCore::RenderObject::isOutOfFlowRenderFragmentedFlow const):
(WebCore::RenderObject::isRenderMultiColumnFlow const):
(WebCore::RenderObject::fragmentedFlowState const):
(WebCore::RenderObject::setFragmentedFlowState):
(WebCore::RenderObject::isAnonymousBlock const):
(WebCore::RenderObject::isRenderFragmentedFlow const):
(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
(WebCore::RenderObject::RenderObjectBitfields::fragmentedFlowState const):
(WebCore::RenderObject::RenderObjectBitfields::setFragmentedFlowState):
(WebCore::RenderObject::RenderObjectRareData::RenderObjectRareData):
(WebCore::RenderObject::flowThreadContainingBlock const): Deleted.
(WebCore::RenderObject::isInFlowRenderFlowThread const): Deleted.
(WebCore::RenderObject::isOutOfFlowRenderFlowThread const): Deleted.
(WebCore::RenderObject::isRenderMultiColumnFlowThread const): Deleted.
(WebCore::RenderObject::flowThreadState const): Deleted.
(WebCore::RenderObject::setFlowThreadState): Deleted.
(WebCore::RenderObject::isRenderFlowThread const): Deleted.
(WebCore::RenderObject::RenderObjectBitfields::flowThreadState const): Deleted.
(WebCore::RenderObject::RenderObjectBitfields::setFlowThreadState): Deleted.
* rendering/RenderReplaced.cpp:
* rendering/RenderRuby.cpp:
(WebCore::isRubyChildForNormalRemoval):
* rendering/RenderTextFragment.cpp:
(WebCore::RenderTextFragment::blockForAccompanyingFirstLetter):
* rendering/RenderView.cpp:
(WebCore::RenderView::availableLogicalHeight const):
(WebCore::RenderView::pageOrViewLogicalHeight const):
(WebCore::RenderView::updateHitTestResult):
(WebCore::RenderView::pageNumberForBlockProgressionOffset const):
(WebCore::RenderView::pageCount const):
* rendering/RenderView.h:
* rendering/RenderingAllInOne.cpp:
* rendering/RootInlineBox.cpp:
(WebCore::containingFragmentMap):
(WebCore::RootInlineBox::~RootInlineBox):
(WebCore::RootInlineBox::containingFragment const):
* rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseForWithReason):
* rendering/line/LineLayoutState.h:
(WebCore::LineLayoutState::LineLayoutState):
(WebCore::LineLayoutState::fragmentedFlow const):
(WebCore::LineLayoutState::setFragmentedFlow):
(WebCore::LineLayoutState::flowThread const): Deleted.
(WebCore::LineLayoutState::setFlowThread): Deleted.
* rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::layout):
* style/RenderTreePosition.h:
* style/RenderTreeUpdaterListItem.cpp:
(WebCore::RenderTreeUpdater::ListItem::updateMarker):
* style/RenderTreeUpdaterMultiColumn.cpp:
(WebCore::RenderTreeUpdater::MultiColumn::update):
(WebCore::RenderTreeUpdater::MultiColumn::createFragmentedFlow):
(WebCore::RenderTreeUpdater::MultiColumn::createFlowThread): Deleted.
* style/RenderTreeUpdaterMultiColumn.h:
* style/StyleResolveForDocument.cpp:
(WebCore::Style::resolveForDocument):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUpdate TestResultsServer for High Sierra queues.
ryanhaddad@apple.com [Wed, 27 Sep 2017 20:42:51 +0000 (20:42 +0000)]
Update TestResultsServer for High Sierra queues.
https://bugs.webkit.org/show_bug.cgi?id=177500

Reviewed by Alexey Proskuryakov.

* TestResultServer/static-dashboards/builders.jsonp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWeb Inspector: Create ResourceCollectionContentView and make CollectionContentView...
mattbaker@apple.com [Wed, 27 Sep 2017 20:41:03 +0000 (20:41 +0000)]
Web Inspector: Create ResourceCollectionContentView and make CollectionContentView easier to extend
https://bugs.webkit.org/show_bug.cgi?id=177419

Reviewed by Devin Rousso.

CollectionContentView should be generic, work with any represented object
Collection, and not perform any type checking. It should just map items
to ContentViews using the provided ContentView constructor.

The behavior when clicking a ContentView in the collection has been extended.
If selection is enabled, clicking a ContentView will cause a "selected" class
to be applied to its element, and a SupplementalRepresentedObjectsDidChange
event is dispatched.

* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Main.html:
New file, move CollectionContentView above subclasses.

* UserInterface/Models/ResourceCollection.js:
(WI.ResourceCollection.prototype.get resourceType):
Make resource type publicly available.

* UserInterface/Views/CollectionContentView.js:
Move type checking of the collection out of the base class and assert
that ContentViews are created when invoking `contentViewConstructor`.
(WI.CollectionContentView):
(WI.CollectionContentView.titleForCollection):
(WI.CollectionContentView.prototype.get supplementalRepresentedObjects):
(WI.CollectionContentView.prototype.get selectionEnabled):
(WI.CollectionContentView.prototype.set selectionEnabled):
(WI.CollectionContentView.prototype.addContentViewForItem):
(WI.CollectionContentView.prototype.removeContentViewForItem):
(WI.CollectionContentView.prototype.contentViewAdded):
(WI.CollectionContentView.prototype.contentViewRemoved):
(WI.CollectionContentView.prototype.initialLayout):
(WI.CollectionContentView.prototype.attached):
(WI.CollectionContentView.prototype.detached):
(WI.CollectionContentView.prototype._handleItemAdded):
(WI.CollectionContentView.prototype._handleItemRemoved):
(WI.CollectionContentView.prototype._selectItem):
(WI.CollectionContentView.prototype._addContentViewForItem): Deleted.
(WI.CollectionContentView.prototype._removeContentViewForItem): Deleted.

* UserInterface/Views/ContentView.js:
(WI.ContentView.createFromRepresentedObject):
Create a ResourceCollectionContentView. In the future, additional
Collection types can be mapped to their associated CollectionContentView.

* UserInterface/Views/ResourceCollectionContentView.js: Added.
New class for resource-specific logic previously in CollectionContentView.
(WI.ResourceCollectionContentView):
(WI.ResourceCollectionContentView.prototype.contentViewAdded):
(WI.ResourceCollectionContentView.prototype._handleContentError):
Remove ContentView without removing the resource from its collection.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoGTK test gardening.
commit-queue@webkit.org [Wed, 27 Sep 2017 20:38:14 +0000 (20:38 +0000)]
GTK test gardening.
https://bugs.webkit.org/show_bug.cgi?id=177545

Patch by Alicia Boya García <aboya@igalia.com> on 2017-09-27
Reviewed by Michael Catanzaro.

* platform/gtk/TestExpectations:
* platform/gtk-wayland/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, rolling out r222567.
jlewis3@apple.com [Wed, 27 Sep 2017 20:11:59 +0000 (20:11 +0000)]
Unreviewed, rolling out r222567.

This broke and internal build.

Reverted changeset:

"Build fix for High Sierra 32 bit Mac"
https://bugs.webkit.org/show_bug.cgi?id=177551
http://trac.webkit.org/changeset/222567

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoHave PingLoad take a CompletionHandler
cdumez@apple.com [Wed, 27 Sep 2017 20:01:25 +0000 (20:01 +0000)]
Have PingLoad take a CompletionHandler
https://bugs.webkit.org/show_bug.cgi?id=177549

Reviewed by Youenn Fablet.

Have PingLoad take a CompletionHandler instead of relying on it calling on method on the
NetworkConnectionToWebProcess when it is done.

* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::loadPing):
* NetworkProcess/PingLoad.cpp:
(WebKit::PingLoad::PingLoad):
(WebKit::PingLoad::didFinish):
* NetworkProcess/PingLoad.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMarked inspector/canvas/shaderProgram-add-remove-webgl.html as flaky.
jlewis3@apple.com [Wed, 27 Sep 2017 19:47:34 +0000 (19:47 +0000)]
Marked inspector/canvas/shaderProgram-add-remove-webgl.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=177388

Unreviewed test gardening.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoBuild fix for High Sierra 32 bit Mac
jbedard@apple.com [Wed, 27 Sep 2017 19:14:27 +0000 (19:14 +0000)]
Build fix for High Sierra 32 bit Mac
https://bugs.webkit.org/show_bug.cgi?id=177551
<rdar://problem/34690283>

Reviewed by Alexey Proskuryakov.

Some assertions have been removed from the SDK. Replace these assertions with equivalent
WTF assert code.  Since the files in this patch are using tabs, some style changes were
also made.

* Carbon/CarbonWindowAdapter.mm:
(+[CarbonWindowAdapter frameViewClassForStyleMask:]):
(-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
(-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
(-[CarbonWindowAdapter setViewsNeedDisplay:]):
(-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
(-[CarbonWindowAdapter dealloc]):
(-[CarbonWindowAdapter windowRef]):
(-[CarbonWindowAdapter _hasWindowRef]):
(-[CarbonWindowAdapter _managesWindowRef]):
(-[CarbonWindowAdapter _removeWindowRef]):
(-[CarbonWindowAdapter _carbonWindowClass]):
(-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
(-[CarbonWindowAdapter sendSuperEvent:]):
(-[CarbonWindowAdapter relinquishFocus]):
(-[CarbonWindowAdapter _cancelKey:]):
(-[CarbonWindowAdapter _commonAwake]):
(-[CarbonWindowAdapter _destroyRealWindow:]):
(-[CarbonWindowAdapter _oldPlaceWindow:]):
(-[CarbonWindowAdapter _termWindowIfOwner]):
(-[CarbonWindowAdapter _windowMovedToRect:]):
(-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
(-[CarbonWindowAdapter selectKeyViewFollowingView:]):
(-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
(-[CarbonWindowAdapter canBecomeKeyWindow]):
(-[CarbonWindowAdapter canBecomeMainWindow]):
(-[CarbonWindowAdapter encodeWithCoder:]):
(-[CarbonWindowAdapter initWithCoder:]):
(-[CarbonWindowAdapter setContentView:]):
(-[CarbonWindowAdapter worksWhenModal]):
(-[CarbonWindowAdapter _setModalWindowLevel]):
(-[CarbonWindowAdapter _clearModalWindowLevel]):
(-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
(-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
(-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
(-[CarbonWindowAdapter _handleRootBoundsChanged]):
(-[CarbonWindowAdapter _handleContentBoundsChanged]):
(-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
(NSCarbonWindowHandleEvent):
(-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
(-[CarbonWindowAdapter _growBoxRect]):
* Carbon/HIWebView.mm:
(HIWebViewGetWebView):
(HIWebViewConstructor):
(HIWebViewDestructor):
(HIWebViewRegisterClass):
(GetBehaviors):
(Draw):
(HitTest):
(GetRegion):
(GetWindowRef):
(CreateNSEventAdoptingCGEvent):
(CopyEventCGEvent):
(CreateNSEventWithCarbonClickEvent):
(Click):
(CreateNSEventWithCarbonEvent):
(MouseUp):
(CreateNSEventWithCarbonMouseMoveEvent):
(MouseMoved):
(MouseDragged):
(MouseWheelMoved):
(ContextMenuClick):
(GetKind):
(BoundsChanged):
(OwningWindowChanged):
(WindowHandler):
(SyncFrame):
(SetFocusPart):
(AdvanceFocus):
(RelinquishFocus):
(ActiveStateChanged):
(ProcessCommand):
(UpdateCommandStatus):
(_NSSelectorForHICommand):
(HIWebViewEventHandler):
(StartUpdateObserver):
(StopUpdateObserver):
(UpdateObserver):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWeb Inspector: Fix Layers tab sidebar popover.
commit-queue@webkit.org [Wed, 27 Sep 2017 18:58:02 +0000 (18:58 +0000)]
Web Inspector: Fix Layers tab sidebar popover.
https://bugs.webkit.org/show_bug.cgi?id=177477

Patch by Ross Kirsling <ross.kirsling@sony.com> on 2017-09-27
Reviewed by Matt Baker.

* UserInterface/Views/LayerDetailsSidebarPanel.js:
(WI.LayerDetailsSidebarPanel.prototype.willDismissPopover): Added.
(WI.LayerDetailsSidebarPanel.prototype._buildDataGrid):
(WI.LayerDetailsSidebarPanel.prototype._sortDataGrid):
(WI.LayerDetailsSidebarPanel.prototype._dataGridSelectedNodeChanged):
(WI.LayerDetailsSidebarPanel.prototype._dataGridFocused):
(WI.LayerDetailsSidebarPanel.prototype._dataGridBlurred):
(WI.LayerDetailsSidebarPanel.prototype._showPopoverForSelectedNode): Refactored.
(WI.LayerDetailsSidebarPanel.prototype._presentPopover):
(WI.LayerDetailsSidebarPanel.prototype._dataGridClicked): Deleted -- not actually desired behavior.
(WI.LayerDetailsSidebarPanel.prototype._updatePopoverForSelectedNode): Deleted -- code simplification.
(WI.LayerDetailsSidebarPanel.prototype._hidePopover): Deleted -- no longer needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, build fix after r222563
utatane.tea@gmail.com [Wed, 27 Sep 2017 18:54:39 +0000 (18:54 +0000)]
Unreviewed, build fix after r222563
https://bugs.webkit.org/show_bug.cgi?id=175823

* runtime/JSArrayInlines.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAdd Above/Below comparisons for UInt32 patterns
utatane.tea@gmail.com [Wed, 27 Sep 2017 18:51:12 +0000 (18:51 +0000)]
Add Above/Below comparisons for UInt32 patterns
https://bugs.webkit.org/show_bug.cgi?id=177281

Reviewed by Saam Barati.

JSTests:

* stress/uint32-comparison-jump.js: Added.
(shouldBe):
(above):
(aboveOrEqual):
(below):
(belowOrEqual):
(notAbove):
(notAboveOrEqual):
(notBelow):
(notBelowOrEqual):
* stress/uint32-comparison.js: Added.
(shouldBe):
(above):
(aboveOrEqual):
(below):
(belowOrEqual):
(aboveTest):
(aboveOrEqualTest):
(belowTest):
(belowOrEqualTest):

Source/JavaScriptCore:

Sometimes, we would like to have UInt32 operations in JS. While VM does
not support UInt32 nicely, VM supports efficient Int32 operations. As long
as signedness does not matter, we can just perform Int32 operations instead
and recognize its bit pattern as UInt32.

But of course, some operations respect signedness. The most frequently
used one is comparison. Octane/zlib performs UInt32 comparison by performing
`val >>> 0`. It emits op_urshift and op_unsigned. op_urshift produces
UInt32 in Int32 form. And op_unsigned will generate Double value if
the generated Int32 is < 0 (which should be UInt32).

There is a chance for optimization. The given code pattern is the following.

    op_unsigned(op_urshift(@1)) lessThan:< op_unsigned(op_urshift(@2))

This can be converted to the following.

    op_urshift(@1) below:< op_urshift(@2)

The above conversion is nice since

1. We can avoid op_unsigned. This could be unsignedness check in DFG. Since
this check depends on the value of Int32, dropping this check is not as easy as
removing Int32 edge filters.

2. We can perform unsigned comparison in Int32 form. We do not need to convert
them to DoubleRep.

Since the above comparison exists in Octane/zlib's *super* hot path, dropping
op_unsigned offers huge win.

At first, my patch attempts to convert the above thing in DFG pipeline.
However it poses several problems.

1. MovHint is not well removed. It makes UInt32ToNumber (which is for op_unsigned) live.
2. UInt32ToNumber could cause an OSR exit. So if we have the following nodes,

    2: UInt32ToNumber(@0)
    3: MovHint(@2, xxx)
    4: UInt32ToNumber(@1)
    5: MovHint(@1, xxx)

we could drop @5's MovHint. But @3 is difficult since @4 can exit.

So, instead, we start introducing a simple optimization in the bytecode compiler.
It performs pattern matching for op_urshift and comparison to drop op_unsigned.
We adds op_below and op_above families to bytecodes. They only accept Int32 and
perform unsigned comparison.

This offers 4% performance improvement in Octane/zlib.

                            baseline                  patched

zlib           x2     431.07483+-16.28434       414.33407+-9.38375         might be 1.0404x faster

* bytecode/BytecodeDumper.cpp:
(JSC::BytecodeDumper<Block>::printCompareJump):
(JSC::BytecodeDumper<Block>::dumpBytecode):
* bytecode/BytecodeDumper.h:
* bytecode/BytecodeList.json:
* bytecode/BytecodeUseDef.h:
(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):
* bytecode/Opcode.h:
(JSC::isBranch):
* bytecode/PreciseJumpTargetsInlines.h:
(JSC::extractStoredJumpTargetsForBytecodeOffset):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitJumpIfTrue):
(JSC::BytecodeGenerator::emitJumpIfFalse):
* bytecompiler/NodesCodegen.cpp:
(JSC::BinaryOpNode::emitBytecode):
* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCapabilities.cpp:
(JSC::DFG::capabilityLevel):
* dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
* dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGIntegerRangeOptimizationPhase.cpp:
* dfg/DFGNodeType.h:
* dfg/DFGPredictionPropagationPhase.cpp:
* dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileCompareUnsigned):
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGStrengthReductionPhase.cpp:
(JSC::DFG::StrengthReductionPhase::handleNode):
* dfg/DFGValidate.cpp:
* ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileCompareBelow):
(JSC::FTL::DFG::LowerDFGToB3::compileCompareBelowEq):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
* jit/JIT.h:
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_below):
(JSC::JIT::emit_op_beloweq):
(JSC::JIT::emit_op_jbelow):
(JSC::JIT::emit_op_jbeloweq):
(JSC::JIT::emit_compareUnsignedAndJump):
(JSC::JIT::emit_compareUnsigned):
* jit/JITArithmetic32_64.cpp:
(JSC::JIT::emit_compareUnsignedAndJump):
(JSC::JIT::emit_compareUnsigned):
* llint/LowLevelInterpreter.asm:
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:
* parser/Nodes.h:
(JSC::ExpressionNode::isBinaryOpNode const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[DFG] Support ArrayPush with multiple args
utatane.tea@gmail.com [Wed, 27 Sep 2017 18:37:41 +0000 (18:37 +0000)]
[DFG] Support ArrayPush with multiple args
https://bugs.webkit.org/show_bug.cgi?id=175823

Reviewed by Saam Barati.

JSTests:

* microbenchmarks/array-push-0.js: Added.
(arrayPush0):
* microbenchmarks/array-push-1.js: Added.
(arrayPush1):
* microbenchmarks/array-push-2.js: Added.
(arrayPush2):
* microbenchmarks/array-push-3.js: Added.
(arrayPush3):
* stress/array-push-multiple-contiguous.js: Added.
(shouldBe):
(test):
* stress/array-push-multiple-double-nan.js: Added.
(shouldBe):
(test):
* stress/array-push-multiple-double.js: Added.
(shouldBe):
(test):
* stress/array-push-multiple-int32.js: Added.
(shouldBe):
(test):
* stress/array-push-multiple-many-contiguous.js: Added.
(shouldBe):
(test):
* stress/array-push-multiple-many-double.js: Added.
(shouldBe):
(test):
* stress/array-push-multiple-many-int32.js: Added.
(shouldBe):
(test):
* stress/array-push-multiple-many-storage.js: Added.
(shouldBe):
(test):
* stress/array-push-multiple-storage.js: Added.
(shouldBe):
(test):

Source/JavaScriptCore:

This patch implements ArrayPush(with multiple arguments) in DFG and FTL. Previously, they are not handled
by ArrayPush. Then they go to generic direct call to Array#push and it does in slow path. This patch
extends ArrayPush to push multiple arguments in a bulk push manner.

The problem of ArrayPush is that we need to perform ArrayPush atomically: If OSR exit occurs in the middle
of ArrayPush, we incorrectly push pushed elements twice. Once we start pushing values, we should not exit.
But we do not want to iterate elements twice, once for type checks and once for actually pushing it. It
could move elements between registers and memory back and forth.

This patch achieves the above goal by separating type checks from ArrayPush. When starting ArrayPush, type
checks for elements are already done by separately emitted Check nodes.

We also add JSArray::pushInline for DFG operations just calling JSArray::push. And we also use it in
arrayProtoFuncPush's fast path.

This patch significantly improves performance of `push(multiple args)`.

                                    baseline                  patched
    Microbenchmarks:
        array-push-0            461.8455+-28.9995    ^    151.3438+-6.5653        ^ definitely 3.0516x faster
        array-push-1            133.8845+-7.0349     ?    136.1775+-5.8327        ? might be 1.0171x slower
        array-push-2            675.6555+-13.4645    ^    145.8747+-6.4621        ^ definitely 4.6318x faster
        array-push-3            849.5284+-15.2540    ^    253.4421+-9.1249        ^ definitely 3.3520x faster

                                    baseline                  patched
    SixSpeed:
        spread-literal.es5       90.3482+-6.6514     ^     24.8123+-2.3304        ^ definitely 3.6413x faster

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleIntrinsicCall):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGNodeType.h:
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileArrayPush):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGStoreBarrierInsertionPhase.cpp:
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileArrayPush):
* jit/JITOperations.h:
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncPush):
* runtime/JSArray.cpp:
(JSC::JSArray::push):
* runtime/JSArray.h:
* runtime/JSArrayInlines.h:
(JSC::JSArray::pushInline):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoDefault to void* for platform widgets
don.olmstead@sony.com [Wed, 27 Sep 2017 18:17:04 +0000 (18:17 +0000)]
Default to void* for platform widgets
https://bugs.webkit.org/show_bug.cgi?id=177518

Reviewed by Michael Catanzaro.

No new tests. No change in behavior.

* platform/Cursor.h:
* platform/DragData.h:
* platform/Widget.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Fetch API] Cloning an opaque response should not assert
commit-queue@webkit.org [Wed, 27 Sep 2017 18:01:29 +0000 (18:01 +0000)]
[Fetch API] Cloning an opaque response should not assert
https://bugs.webkit.org/show_bug.cgi?id=177548

Patch by Youenn Fablet <youenn@apple.com> on 2017-09-27
Reviewed by Sam Weinig.

Source/WebCore:

Test: http/wpt/fetch/response-opaque-clone.html

* Modules/fetch/FetchBodyOwner.cpp:
(WebCore::FetchBodyOwner::readableStream): Returning null if response is opaque.
* Modules/fetch/FetchResponse.cpp:
(WebCore::FetchResponse::clone): Making sure cloned responses keep their opaque state.
(WebCore::FetchResponse::consumeBodyAsStream): Removing assertion as we need to create a stream for cloning.

LayoutTests:

* http/wpt/fetch/response-opaque-clone-expected.txt: Added.
* http/wpt/fetch/response-opaque-clone.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWeb Inspector: Remove unused parameter of Page.reload
joepeck@webkit.org [Wed, 27 Sep 2017 17:57:08 +0000 (17:57 +0000)]
Web Inspector: Remove unused parameter of Page.reload
https://bugs.webkit.org/show_bug.cgi?id=177522

Reviewed by Matt Baker.

Source/JavaScriptCore:

* inspector/protocol/Page.json:

Source/WebCore:

* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl):
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::reload):
(WebCore::InspectorPageAgent::frameNavigated):
(WebCore::InspectorPageAgent::didClearWindowObjectInWorld): Deleted.
* inspector/InspectorPageAgent.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agocssFloat missing in CSSPropertyDeclaration.prototype
cdumez@apple.com [Wed, 27 Sep 2017 17:55:56 +0000 (17:55 +0000)]
cssFloat missing in CSSPropertyDeclaration.prototype
https://bugs.webkit.org/show_bug.cgi?id=177487

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Rebaseline WPT now that more checks are passing.

* web-platform-tests/cssom/interfaces-expected.txt:

Source/WebCore:

Add support for cssFloat attribute on CSSPropertyDeclaration, as per:
- https://drafts.csswg.org/cssom/#dom-cssstyledeclaration-cssfloat

Test: fast/css/CSSStyleDeclaration-cssFloat.html

* css/CSSStyleDeclaration.cpp:
(WebCore::CSSStyleDeclaration::cssFloat):
(WebCore::CSSStyleDeclaration::setCssFloat):
* css/CSSStyleDeclaration.h:
* css/CSSStyleDeclaration.idl:

LayoutTests:

Add layout test coverage.

* fast/css/CSSStyleDeclaration-cssFloat-expected.txt: Added.
* fast/css/CSSStyleDeclaration-cssFloat.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agobisect-builds:add a README to the archive.
lforschler@apple.com [Wed, 27 Sep 2017 17:12:03 +0000 (17:12 +0000)]
bisect-builds:add a README to the archive.
https://bugs.webkit.org/show_bug.cgi?id=177376

Reviewed by Alexey Proskuryakov & Jon Davis.

* BuildSlaveSupport/built-product-archive:
(addFilesToArchive): refactor function (was previously addLauncherToArchive)
(createZip): Teach function to add the README
(addLauncherToArchive): Deleted. (refactored to addFilesToArchive)
* BuildSlaveSupport/run-webkit-archive: Deleted. (Moved to WebKitArchiveSupport)
* WebKitArchiveSupport: Added.
* WebKitArchiveSupport/README: Added. README which will be packaged up with the archive.
* WebKitArchiveSupport/run-webkit-archive: Added. (Moved from BuildSlaveSupport)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRef element keys in CSSAnimationControllerPrivate
antti@apple.com [Wed, 27 Sep 2017 17:08:58 +0000 (17:08 +0000)]
Ref element keys in CSSAnimationControllerPrivate
https://bugs.webkit.org/show_bug.cgi?id=177543

Reviewed by Zalan Bujtas.

For safety.

* page/animation/CSSAnimationControllerPrivate.h:

This won't create ref cycle as elements are removed from the m_compositeAnimations maps when they
are removed from the tree. We have assertions that verify the map is always cleared.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRename "Region" to "Fragment" for RenderRegion and associated classes/methods.
hyatt@apple.com [Wed, 27 Sep 2017 16:19:08 +0000 (16:19 +0000)]
Rename "Region" to "Fragment" for RenderRegion and associated classes/methods.
https://bugs.webkit.org/show_bug.cgi?id=177506

Reviewed by Zalan Bujtas.

* WebCore.xcodeproj/project.pbxproj:
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator BreakInside const):
* css/CSSValueKeywords.in:
* dom/Element.cpp:
* platform/graphics/cg/GraphicsContextCG.cpp:
* rendering/FixedTableLayout.cpp:
(WebCore::FixedTableLayout::calcWidthArray):
* rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::computeMarginLogicalSizeForChild):
(WebCore::IndefiniteSizeStrategy::minLogicalWidthForChild const):
(WebCore::DefiniteSizeStrategy::minLogicalWidthForChild const):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::preparePaginationBeforeBlockLayout):
(WebCore::RenderBlock::addOverflowFromChildren):
(WebCore::RenderBlock::clearLayoutOverflow):
(WebCore::RenderBlock::addVisualOverflowFromTheme):
(WebCore::RenderBlock::computeStartPositionDeltaForChildAvoidingFloats):
(WebCore::RenderBlock::simplifiedLayout):
(WebCore::RenderBlock::markFixedPositionObjectForLayoutIfNeeded):
(WebCore::RenderBlock::layoutPositionedObject):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::logicalLeftOffsetForContent const):
(WebCore::RenderBlock::logicalRightOffsetForContent const):
(WebCore::RenderBlock::adjustLogicalLeftOffsetForLine const):
(WebCore::RenderBlock::adjustLogicalRightOffsetForLine const):
(WebCore::RenderBlock::positionForPointWithInlineChildren):
(WebCore::isChildHitTestCandidate):
(WebCore::RenderBlock::positionForPoint):
(WebCore::RenderBlock::offsetFromLogicalTopOfFirstPage const):
(WebCore::RenderBlock::fragmentAtBlockOffset const):
(WebCore::canComputeFragmentRangeForBox):
(WebCore::RenderBlock::computeFragmentRangeForBoxChild const):
(WebCore::RenderBlock::estimateFragmentRangeForBoxChild const):
(WebCore::RenderBlock::updateFragmentRangeForBoxChild const):
(WebCore::RenderBlock::regionAtBlockOffset const): Deleted.
(WebCore::canComputeRegionRangeForBox): Deleted.
(WebCore::RenderBlock::computeRegionRangeForBoxChild const): Deleted.
(WebCore::RenderBlock::estimateRegionRangeForBoxChild const): Deleted.
(WebCore::RenderBlock::updateRegionRangeForBoxChild const): Deleted.
* rendering/RenderBlock.h:
(WebCore::RenderBlock::availableLogicalWidthForLineInFragment const):
(WebCore::RenderBlock::logicalRightOffsetForLineInFragment const):
(WebCore::RenderBlock::logicalLeftOffsetForLineInFragment const):
(WebCore::RenderBlock::startOffsetForLineInFragment const):
(WebCore::RenderBlock::endOffsetForLineInFragment const):
(WebCore::RenderBlock::availableLogicalWidthForLine const):
(WebCore::RenderBlock::availableLogicalWidthForContent const):
(WebCore::RenderBlock::startOffsetForContent const):
(WebCore::RenderBlock::endOffsetForContent const):
(WebCore::RenderBlock::logicalLeftOffsetForContent const):
(WebCore::RenderBlock::logicalRightOffsetForContent const):
(WebCore::RenderBlock::availableLogicalWidthForLineInRegion const): Deleted.
(WebCore::RenderBlock::logicalRightOffsetForLineInRegion const): Deleted.
(WebCore::RenderBlock::logicalLeftOffsetForLineInRegion const): Deleted.
(WebCore::RenderBlock::startOffsetForLineInRegion const): Deleted.
(WebCore::RenderBlock::endOffsetForLineInRegion const): Deleted.
* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutBlock):
(WebCore::RenderBlockFlow::layoutBlockChild):
(WebCore::RenderBlockFlow::setStaticInlinePositionForChild):
(WebCore::RenderBlockFlow::applyBeforeBreak):
(WebCore::RenderBlockFlow::applyAfterBreak):
(WebCore::RenderBlockFlow::adjustLinePositionForPagination):
(WebCore::RenderBlockFlow::hasNextPage const):
(WebCore::RenderBlockFlow::adjustForUnsplittableChild):
(WebCore::RenderBlockFlow::pushToNextPageWithMinimumLogicalHeight const):
(WebCore::RenderBlockFlow::positionNewFloats):
(WebCore::RenderBlockFlow::getClearDelta):
(WebCore::RenderBlockFlow::needsLayoutAfterFragmentRangeChange const):
(WebCore::RenderBlockFlow::findClosestTextAtAbsolutePoint):
(WebCore::RenderBlockFlow::positionForPointWithInlineChildren):
(WebCore::RenderBlockFlow::positionForPoint):
(WebCore::RenderBlockFlow::layoutExcludedChildren):
(WebCore::RenderBlockFlow::needsLayoutAfterRegionRangeChange const): Deleted.
* rendering/RenderBlockFlow.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::layoutRunsAndFloatsInRange):
(WebCore::RenderBlockFlow::linkToEndLineIfNeeded):
(WebCore::RenderBlockFlow::layoutLineBoxes):
(WebCore::RenderBlockFlow::determineStartPosition):
(WebCore::RenderBlockFlow::checkPaginationAndFloatsAtEndLine):
(WebCore::RenderBlockFlow::lineWidthForPaginatedLineChanged const):
(WebCore::RenderBlockFlow::addOverflowFromInlineChildren):
(WebCore::RenderBlockFlow::positionNewFloatOnLine):
(WebCore::RenderBlockFlow::updateFragmentForLine const):
(WebCore::RenderBlockFlow::updateRegionForLine const): Deleted.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::clampToStartAndEndFragments const):
(WebCore::RenderBox::hasFragmentRangeInFlowThread const):
(WebCore::RenderBox::clientBoxRectInFragment const):
(WebCore::RenderBox::borderBoxRectInFragment const):
(WebCore::RenderBox::constrainLogicalWidthInFragmentByMinMax const):
(WebCore::RenderBox::nodeAtPoint):
(WebCore::RenderBox::paintBoxDecorations):
(WebCore::RenderBox::overflowClipRect):
(WebCore::RenderBox::clipRect):
(WebCore::RenderBox::shrinkLogicalWidthToAvoidFloats const):
(WebCore::RenderBox::containingBlockLogicalWidthForContentInFragment const):
(WebCore::RenderBox::containingBlockAvailableLineWidthInFragment const):
(WebCore::RenderBox::offsetFromContainer const):
(WebCore::RenderBox::computeRectForRepaint const):
(WebCore::RenderBox::updateLogicalWidth):
(WebCore::RenderBox::computeLogicalWidthInFragment const):
(WebCore::RenderBox::computeLogicalWidthInFragmentUsing const):
(WebCore::RenderBox::renderBoxFragmentInfo const):
(WebCore::tableCellShouldHaveZeroInitialSize):
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned const):
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned const):
(WebCore::computeInlineStaticDistance):
(WebCore::RenderBox::computePositionedLogicalWidth const):
(WebCore::RenderBox::computePositionedLogicalHeight const):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced const):
(WebCore::RenderBox::positionForPoint):
(WebCore::RenderBox::createsNewFormattingContext const):
(WebCore::RenderBox::addVisualEffectOverflow):
(WebCore::RenderBox::addOverflowFromChild):
(WebCore::RenderBox::clearOverflow):
(WebCore::RenderBox::clampToStartAndEndRegions const): Deleted.
(WebCore::RenderBox::hasRegionRangeInFlowThread const): Deleted.
(WebCore::RenderBox::clientBoxRectInRegion const): Deleted.
(WebCore::RenderBox::borderBoxRectInRegion const): Deleted.
(WebCore::RenderBox::constrainLogicalWidthInRegionByMinMax const): Deleted.
(WebCore::RenderBox::containingBlockLogicalWidthForContentInRegion const): Deleted.
(WebCore::RenderBox::containingBlockAvailableLineWidthInRegion const): Deleted.
(WebCore::RenderBox::computeLogicalWidthInRegion const): Deleted.
(WebCore::RenderBox::computeLogicalWidthInRegionUsing const): Deleted.
(WebCore::RenderBox::renderBoxRegionInfo const): Deleted.
* rendering/RenderBox.h:
(WebCore::RenderBox::overflowClipRectForChildLayers):
(WebCore::RenderBox::canHaveOutsideFragmentRange const):
(WebCore::RenderBox::needsLayoutAfterFragmentRangeChange const):
(WebCore::RenderBox::canHaveOutsideRegionRange const): Deleted.
(WebCore::RenderBox::needsLayoutAfterRegionRangeChange const): Deleted.
* rendering/RenderBoxFragmentInfo.h: Copied from rendering/RenderBoxRegionInfo.h.
(WebCore::RenderBoxFragmentInfo::RenderBoxFragmentInfo):
(WebCore::RenderBoxRegionInfo::RenderBoxRegionInfo): Deleted.
(WebCore::RenderBoxRegionInfo::logicalLeft const): Deleted.
(WebCore::RenderBoxRegionInfo::logicalWidth const): Deleted.
(WebCore::RenderBoxRegionInfo::shiftLogicalLeft): Deleted.
(WebCore::RenderBoxRegionInfo::isShifted const): Deleted.
(WebCore::RenderBoxRegionInfo::createOverflow): Deleted.
(WebCore::RenderBoxRegionInfo::overflow const): Deleted.
(WebCore::RenderBoxRegionInfo::clearOverflow): Deleted.
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::adjustedPositionRelativeToOffsetParent const):
(WebCore::RenderBoxModelObject::mapAbsoluteToLocalPoint const):
* rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::canHaveBoxInfoInFragment const):
(WebCore::RenderBoxModelObject::canHaveBoxInfoInRegion const): Deleted.
* rendering/RenderBoxRegionInfo.h: Removed.
* rendering/RenderElement.cpp:
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::positionForPoint):
* rendering/RenderFileUploadControl.h:
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computeMainAxisExtentForChild):
(WebCore::RenderFlexibleBox::applyStretchAlignmentToChild):
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::styleDidChange):
(WebCore::RenderFlowThread::removeFlowChildInfo):
(WebCore::RenderFlowThread::removeFragmentFromThread):
(WebCore::RenderFlowThread::invalidateFragments):
(WebCore::RenderFlowThread::validateFragments):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::updateLogicalWidth):
(WebCore::RenderFlowThread::computeLogicalHeight const):
(WebCore::RenderFlowThread::repaintRectangleInFragments const):
(WebCore::RenderFlowThread::fragmentAtBlockOffset const):
(WebCore::RenderFlowThread::adjustedPositionRelativeToOffsetParent const):
(WebCore::RenderFlowThread::pageLogicalTopForOffset const):
(WebCore::RenderFlowThread::pageLogicalWidthForOffset const):
(WebCore::RenderFlowThread::pageLogicalHeightForOffset const):
(WebCore::RenderFlowThread::pageRemainingLogicalHeightForOffset const):
(WebCore::RenderFlowThread::mapFromFlowToFragment const):
(WebCore::RenderFlowThread::removeRenderBoxFragmentInfo):
(WebCore::RenderFlowThread::removeLineFragmentInfo):
(WebCore::RenderFlowThread::logicalWidthChangedInFragmentsForBlock):
(WebCore::RenderFlowThread::contentLogicalWidthOfFirstFragment const):
(WebCore::RenderFlowThread::contentLogicalHeightOfFirstFragment const):
(WebCore::RenderFlowThread::contentLogicalLeftOfFirstFragment const):
(WebCore::RenderFlowThread::firstFragment const):
(WebCore::RenderFlowThread::lastFragment const):
(WebCore::RenderFlowThread::clearRenderBoxFragmentInfoAndCustomStyle):
(WebCore::RenderFlowThread::setFragmentRangeForBox):
(WebCore::RenderFlowThread::hasCachedFragmentRangeForBox const):
(WebCore::RenderFlowThread::getFragmentRangeForBoxFromCachedInfo const):
(WebCore::RenderFlowThread::getFragmentRangeForBox const):
(WebCore::RenderFlowThread::computedFragmentRangeForBox const):
(WebCore::RenderFlowThread::fragmentInRange const):
(WebCore::RenderFlowThread::objectShouldFragmentInFlowFragment const):
(WebCore::RenderFlowThread::objectInFlowFragment const):
(WebCore::RenderFlowThread::checkLinesConsistency const):
(WebCore::RenderFlowThread::clearLinesToFragmentMap):
(WebCore::RenderFlowThread::deleteLines):
(WebCore::RenderFlowThread::willBeDestroyed):
(WebCore::RenderFlowThread::markFragmentsForOverflowLayoutIfNeeded):
(WebCore::RenderFlowThread::updateFragmentsFlowThreadPortionRect):
(WebCore::RenderFlowThread::addForcedFragmentBreak):
(WebCore::RenderFlowThread::collectLayerFragments):
(WebCore::RenderFlowThread::fragmentsBoundingBox):
(WebCore::RenderFlowThread::offsetFromLogicalTopOfFirstFragment const):
(WebCore::RenderFlowThread::FragmentSearchAdapter::collectIfNeeded):
(WebCore::RenderFlowThread::mapLocalToContainer const):
(WebCore::RenderFlowThread::addFragmentsVisualEffectOverflow):
(WebCore::RenderFlowThread::addFragmentsVisualOverflowFromTheme):
(WebCore::RenderFlowThread::addFragmentsOverflowFromChild):
(WebCore::RenderFlowThread::addFragmentsLayoutOverflow):
(WebCore::RenderFlowThread::addFragmentsVisualOverflow):
(WebCore::RenderFlowThread::clearFragmentsOverflow):
(WebCore::RenderFlowThread::currentFragment const):
(WebCore::RenderFlowThread::containingFragmentMap):
(WebCore::RenderFlowThread::removeRegionFromThread): Deleted.
(WebCore::RenderFlowThread::invalidateRegions): Deleted.
(WebCore::RenderFlowThread::validateRegions): Deleted.
(WebCore::RenderFlowThread::repaintRectangleInRegions const): Deleted.
(WebCore::RenderFlowThread::regionAtBlockOffset const): Deleted.
(WebCore::RenderFlowThread::mapFromFlowToRegion const): Deleted.
(WebCore::RenderFlowThread::removeRenderBoxRegionInfo): Deleted.
(WebCore::RenderFlowThread::removeLineRegionInfo): Deleted.
(WebCore::RenderFlowThread::logicalWidthChangedInRegionsForBlock): Deleted.
(WebCore::RenderFlowThread::contentLogicalWidthOfFirstRegion const): Deleted.
(WebCore::RenderFlowThread::contentLogicalHeightOfFirstRegion const): Deleted.
(WebCore::RenderFlowThread::contentLogicalLeftOfFirstRegion const): Deleted.
(WebCore::RenderFlowThread::firstRegion const): Deleted.
(WebCore::RenderFlowThread::lastRegion const): Deleted.
(WebCore::RenderFlowThread::clearRenderBoxRegionInfoAndCustomStyle): Deleted.
(WebCore::RenderFlowThread::setRegionRangeForBox): Deleted.
(WebCore::RenderFlowThread::hasCachedRegionRangeForBox const): Deleted.
(WebCore::RenderFlowThread::getRegionRangeForBoxFromCachedInfo const): Deleted.
(WebCore::RenderFlowThread::getRegionRangeForBox const): Deleted.
(WebCore::RenderFlowThread::computedRegionRangeForBox const): Deleted.
(WebCore::RenderFlowThread::regionInRange const): Deleted.
(WebCore::RenderFlowThread::objectShouldFragmentInFlowRegion const): Deleted.
(WebCore::RenderFlowThread::objectInFlowRegion const): Deleted.
(WebCore::RenderFlowThread::clearLinesToRegionMap): Deleted.
(WebCore::RenderFlowThread::markRegionsForOverflowLayoutIfNeeded): Deleted.
(WebCore::RenderFlowThread::updateRegionsFlowThreadPortionRect): Deleted.
(WebCore::RenderFlowThread::addForcedRegionBreak): Deleted.
(WebCore::RenderFlowThread::offsetFromLogicalTopOfFirstRegion const): Deleted.
(WebCore::RenderFlowThread::RegionSearchAdapter::collectIfNeeded): Deleted.
(WebCore::RenderFlowThread::addRegionsVisualEffectOverflow): Deleted.
(WebCore::RenderFlowThread::addRegionsVisualOverflowFromTheme): Deleted.
(WebCore::RenderFlowThread::addRegionsOverflowFromChild): Deleted.
(WebCore::RenderFlowThread::addRegionsLayoutOverflow): Deleted.
(WebCore::RenderFlowThread::addRegionsVisualOverflow): Deleted.
(WebCore::RenderFlowThread::clearRegionsOverflow): Deleted.
(WebCore::RenderFlowThread::currentRegion const): Deleted.
(WebCore::RenderFlowThread::containingRegionMap): Deleted.
* rendering/RenderFlowThread.h:
(WTF::ValueToString<WebCore::RenderFragmentContainer::string):
(WTF::ValueToString<WebCore::RenderRegion::string): Deleted.
* rendering/RenderFragmentContainer.cpp: Copied from rendering/RenderRegion.cpp.
(WebCore::RenderFragmentContainer::RenderFragmentContainer):
(WebCore::RenderFragmentContainer::mapFragmentPointIntoFlowThreadCoordinates):
(WebCore::RenderFragmentContainer::positionForPoint):
(WebCore::RenderFragmentContainer::pageLogicalWidth const):
(WebCore::RenderFragmentContainer::pageLogicalHeight const):
(WebCore::RenderFragmentContainer::logicalHeightOfAllFlowThreadContent const):
(WebCore::RenderFragmentContainer::flowThreadPortionOverflowRect):
(WebCore::RenderFragmentContainer::flowThreadPortionLocation const):
(WebCore::RenderFragmentContainer::overflowRectForFlowThreadPortion):
(WebCore::RenderFragmentContainer::pageLogicalTopForOffset const):
(WebCore::RenderFragmentContainer::isFirstFragment const):
(WebCore::RenderFragmentContainer::isLastFragment const):
(WebCore::RenderFragmentContainer::shouldClipFlowThreadContent const):
(WebCore::RenderFragmentContainer::styleDidChange):
(WebCore::RenderFragmentContainer::computeOverflowFromFlowThread):
(WebCore::RenderFragmentContainer::repaintFlowThreadContent):
(WebCore::RenderFragmentContainer::repaintFlowThreadContentRectangle):
(WebCore::RenderFragmentContainer::installFlowThread):
(WebCore::RenderFragmentContainer::attachFragment):
(WebCore::RenderFragmentContainer::detachFragment):
(WebCore::RenderFragmentContainer::renderBoxFragmentInfo const):
(WebCore::RenderFragmentContainer::setRenderBoxFragmentInfo):
(WebCore::RenderFragmentContainer::takeRenderBoxFragmentInfo):
(WebCore::RenderFragmentContainer::removeRenderBoxFragmentInfo):
(WebCore::RenderFragmentContainer::deleteAllRenderBoxFragmentInfo):
(WebCore::RenderFragmentContainer::logicalTopOfFlowThreadContentRect const):
(WebCore::RenderFragmentContainer::logicalBottomOfFlowThreadContentRect const):
(WebCore::RenderFragmentContainer::insertedIntoTree):
(WebCore::RenderFragmentContainer::willBeRemovedFromTree):
(WebCore::RenderFragmentContainer::computeIntrinsicLogicalWidths const):
(WebCore::RenderFragmentContainer::computePreferredLogicalWidths):
(WebCore::RenderFragmentContainer::adjustFragmentBoundsFromFlowThreadPortionRect const):
(WebCore::RenderFragmentContainer::ensureOverflowForBox):
(WebCore::RenderFragmentContainer::rectFlowPortionForBox const):
(WebCore::RenderFragmentContainer::addLayoutOverflowForBox):
(WebCore::RenderFragmentContainer::addVisualOverflowForBox):
(WebCore::RenderFragmentContainer::layoutOverflowRectForBox):
(WebCore::RenderFragmentContainer::visualOverflowRectForBox):
(WebCore::RenderFragmentContainer::layoutOverflowRectForBoxForPropagation):
(WebCore::RenderFragmentContainer::visualOverflowRectForBoxForPropagation):
(WebCore::CurrentRenderFragmentContainerMaintainer::CurrentRenderFragmentContainerMaintainer):
(WebCore::CurrentRenderFragmentContainerMaintainer::~CurrentRenderFragmentContainerMaintainer):
(WebCore::RenderRegion::RenderRegion): Deleted.
(WebCore::RenderRegion::mapRegionPointIntoFlowThreadCoordinates): Deleted.
(WebCore::RenderRegion::positionForPoint): Deleted.
(WebCore::RenderRegion::pageLogicalWidth const): Deleted.
(WebCore::RenderRegion::pageLogicalHeight const): Deleted.
(WebCore::RenderRegion::logicalHeightOfAllFlowThreadContent const): Deleted.
(WebCore::RenderRegion::flowThreadPortionOverflowRect): Deleted.
(WebCore::RenderRegion::flowThreadPortionLocation const): Deleted.
(WebCore::RenderRegion::overflowRectForFlowThreadPortion): Deleted.
(WebCore::RenderRegion::pageLogicalTopForOffset const): Deleted.
(WebCore::RenderRegion::isFirstRegion const): Deleted.
(WebCore::RenderRegion::isLastRegion const): Deleted.
(WebCore::RenderRegion::shouldClipFlowThreadContent const): Deleted.
(WebCore::RenderRegion::styleDidChange): Deleted.
(WebCore::RenderRegion::computeOverflowFromFlowThread): Deleted.
(WebCore::RenderRegion::repaintFlowThreadContent): Deleted.
(WebCore::RenderRegion::repaintFlowThreadContentRectangle): Deleted.
(WebCore::RenderRegion::installFlowThread): Deleted.
(WebCore::RenderRegion::attachRegion): Deleted.
(WebCore::RenderRegion::detachRegion): Deleted.
(WebCore::RenderRegion::renderBoxRegionInfo const): Deleted.
(WebCore::RenderRegion::setRenderBoxRegionInfo): Deleted.
(WebCore::RenderRegion::takeRenderBoxRegionInfo): Deleted.
(WebCore::RenderRegion::removeRenderBoxRegionInfo): Deleted.
(WebCore::RenderRegion::deleteAllRenderBoxRegionInfo): Deleted.
(WebCore::RenderRegion::logicalTopOfFlowThreadContentRect const): Deleted.
(WebCore::RenderRegion::logicalBottomOfFlowThreadContentRect const): Deleted.
(WebCore::RenderRegion::insertedIntoTree): Deleted.
(WebCore::RenderRegion::willBeRemovedFromTree): Deleted.
(WebCore::RenderRegion::computeIntrinsicLogicalWidths const): Deleted.
(WebCore::RenderRegion::computePreferredLogicalWidths): Deleted.
(WebCore::RenderRegion::adjustRegionBoundsFromFlowThreadPortionRect const): Deleted.
(WebCore::RenderRegion::ensureOverflowForBox): Deleted.
(WebCore::RenderRegion::rectFlowPortionForBox const): Deleted.
(WebCore::RenderRegion::addLayoutOverflowForBox): Deleted.
(WebCore::RenderRegion::addVisualOverflowForBox): Deleted.
(WebCore::RenderRegion::layoutOverflowRectForBox): Deleted.
(WebCore::RenderRegion::visualOverflowRectForBox): Deleted.
(WebCore::RenderRegion::layoutOverflowRectForBoxForPropagation): Deleted.
(WebCore::RenderRegion::visualOverflowRectForBoxForPropagation): Deleted.
(WebCore::CurrentRenderRegionMaintainer::CurrentRenderRegionMaintainer): Deleted.
(WebCore::CurrentRenderRegionMaintainer::~CurrentRenderRegionMaintainer): Deleted.
* rendering/RenderFragmentContainer.h: Copied from rendering/RenderRegion.h.
(WebCore::RenderFragmentContainer::isRenderFragmentContainerSet const):
(WebCore::RenderFragmentContainer::absoluteQuadsForBoxInFragment):
(WebCore::CurrentRenderFragmentContainerMaintainer::fragment const):
(WebCore::RenderRegion::setFlowThreadPortionRect): Deleted.
(WebCore::RenderRegion::flowThreadPortionRect const): Deleted.
(WebCore::RenderRegion::flowThread const): Deleted.
(WebCore::RenderRegion::isValid const): Deleted.
(WebCore::RenderRegion::setIsValid): Deleted.
(WebCore::RenderRegion::logicalTopForFlowThreadContent const): Deleted.
(WebCore::RenderRegion::logicalBottomForFlowThreadContent const): Deleted.
(WebCore::RenderRegion::isRenderRegionSet const): Deleted.
(WebCore::RenderRegion::collectLayerFragments): Deleted.
(WebCore::RenderRegion::absoluteQuadsForBoxInRegion): Deleted.
(WebCore::CurrentRenderRegionMaintainer::region const): Deleted.
* rendering/RenderFragmentContainerSet.cpp: Copied from rendering/RenderRegionSet.cpp.
(WebCore::RenderFragmentContainerSet::RenderFragmentContainerSet):
(WebCore::RenderFragmentContainerSet::installFlowThread):
(WebCore::RenderFragmentContainerSet::expandToEncompassFlowThreadContentsIfNeeded):
(WebCore::RenderRegionSet::RenderRegionSet): Deleted.
(WebCore::RenderRegionSet::installFlowThread): Deleted.
(WebCore::RenderRegionSet::expandToEncompassFlowThreadContentsIfNeeded): Deleted.
* rendering/RenderFragmentContainerSet.h: Copied from rendering/RenderRegionSet.h.
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computeMarginLogicalSizeForChild const):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::positionForPoint):
(WebCore::RenderInline::linesVisualOverflowBoundingBoxInFragment const):
(WebCore::RenderInline::linesVisualOverflowBoundingBoxInRegion const): Deleted.
* rendering/RenderInline.h:
* rendering/RenderLayer.cpp:
(WebCore::accumulateOffsetTowardsAncestor):
(WebCore::RenderLayer::calculateClipRects const):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintIntoLayer):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::canBeComposited const):
* rendering/RenderLineBreak.cpp:
(WebCore::RenderLineBreak::positionForPoint):
* rendering/RenderLineBreak.h:
* rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::RenderMultiColumnFlowThread::addFragmentToThread):
(WebCore::RenderMultiColumnFlowThread::willBeRemovedFromTree):
(WebCore::RenderMultiColumnFlowThread::processPossibleSpannerDescendant):
(WebCore::RenderMultiColumnFlowThread::flowThreadRelativeWillBeRemoved):
(WebCore::RenderMultiColumnFlowThread::setPageBreak):
(WebCore::RenderMultiColumnFlowThread::updateMinimumPageHeight):
(WebCore::RenderMultiColumnFlowThread::fragmentAtBlockOffset const):
(WebCore::RenderMultiColumnFlowThread::setFragmentRangeForBox):
(WebCore::RenderMultiColumnFlowThread::addForcedFragmentBreak):
(WebCore::RenderMultiColumnFlowThread::offsetFromContainer const):
(WebCore::RenderMultiColumnFlowThread::mapAbsoluteToLocalPoint const):
(WebCore::RenderMultiColumnFlowThread::physicalTranslationFromFragmentToFlow const):
(WebCore::RenderMultiColumnFlowThread::mapFromFlowToFragment const):
(WebCore::RenderMultiColumnFlowThread::physicalTranslationOffsetFromFlowToFragment const):
(WebCore::RenderMultiColumnFlowThread::physicalTranslationFromFlowToFragment const):
(WebCore::RenderMultiColumnFlowThread::addRegionToThread): Deleted.
(WebCore::RenderMultiColumnFlowThread::regionAtBlockOffset const): Deleted.
(WebCore::RenderMultiColumnFlowThread::setRegionRangeForBox): Deleted.
(WebCore::RenderMultiColumnFlowThread::addForcedRegionBreak): Deleted.
(WebCore::RenderMultiColumnFlowThread::physicalTranslationFromRegionToFlow const): Deleted.
(WebCore::RenderMultiColumnFlowThread::mapFromFlowToRegion const): Deleted.
(WebCore::RenderMultiColumnFlowThread::physicalTranslationOffsetFromFlowToRegion const): Deleted.
(WebCore::RenderMultiColumnFlowThread::physicalTranslationFromFlowToRegion const): Deleted.
* rendering/RenderMultiColumnFlowThread.h:
* rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::RenderMultiColumnSet):
(WebCore::RenderMultiColumnSet::updateLogicalWidth):
(WebCore::RenderMultiColumnSet::beginFlow):
(WebCore::RenderMultiColumnSet::endFlow):
(WebCore::RenderMultiColumnSet::layout):
(WebCore::RenderMultiColumnSet::flowThreadPortionOverflowRect):
(WebCore::RenderMultiColumnSet::repaintFlowThreadContent):
(WebCore::RenderMultiColumnSet::collectLayerFragments):
(WebCore::RenderMultiColumnSet::adjustFragmentBoundsFromFlowThreadPortionRect const):
(WebCore::RenderMultiColumnSet::positionForPoint):
(WebCore::RenderMultiColumnSet::translateFragmentPointToFlowThread const):
(WebCore::RenderMultiColumnSet::updateHitTestResult):
(WebCore::RenderMultiColumnSet::adjustRegionBoundsFromFlowThreadPortionRect const): Deleted.
(WebCore::RenderMultiColumnSet::translateRegionPointToFlowThread const): Deleted.
* rendering/RenderMultiColumnSet.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::containerForRepaint const):
(WebCore::RenderObject::repaintUsingContainer const):
(WebCore::RenderObject::outputRegionsInformation const):
(WebCore::RenderObject::positionForPoint):
* rendering/RenderObject.h:
(WebCore::RenderObject::isRenderFragmentContainer const):
(WebCore::RenderObject::isRenderRegion const): Deleted.
* rendering/RenderRegion.cpp: Removed.
* rendering/RenderRegion.h: Removed.
* rendering/RenderRegionSet.cpp: Removed.
* rendering/RenderRegionSet.h: Removed.
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::positionForPoint):
* rendering/RenderReplaced.h:
* rendering/RenderTable.cpp:
(WebCore::RenderTable::updateLogicalWidth):
(WebCore::RenderTable::overflowClipRect):
* rendering/RenderTable.h:
* rendering/RenderText.cpp:
(WebCore::RenderText::positionForPoint):
* rendering/RenderText.h:
* rendering/RenderTreeAsText.cpp:
* rendering/RenderingAllInOne.cpp:
* rendering/RootInlineBox.cpp:
(WebCore::containingFragmentMap):
(WebCore::RootInlineBox::~RootInlineBox):
(WebCore::RootInlineBox::containingFragment const):
(WebCore::RootInlineBox::clearContainingFragment):
(WebCore::RootInlineBox::setContainingFragment):
(WebCore::containingRegionMap): Deleted.
(WebCore::RootInlineBox::containingRegion const): Deleted.
(WebCore::RootInlineBox::clearContainingRegion): Deleted.
(WebCore::RootInlineBox::setContainingRegion): Deleted.
* rendering/RootInlineBox.h:
* rendering/shapes/ShapeOutsideInfo.cpp:
(WebCore::ShapeOutsideInfo::logicalLeftOffset const):
* rendering/style/RenderStyleConstants.h:
* rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::positionForPoint):
* rendering/svg/RenderSVGInlineText.h:
* rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::positionForPoint):
* rendering/svg/RenderSVGText.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, rolling out r222537.
ryanhaddad@apple.com [Wed, 27 Sep 2017 16:10:25 +0000 (16:10 +0000)]
Unreviewed, rolling out r222537.

This change broke internal builds.

Reverted changeset:

"Build libwebrtc unit tests executables"
https://bugs.webkit.org/show_bug.cgi?id=177211
http://trac.webkit.org/changeset/222537

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoREGRESSION (r222040): Crash navigating out of gfycat.com url
antti@apple.com [Wed, 27 Sep 2017 15:32:55 +0000 (15:32 +0000)]
REGRESSION (r222040): Crash navigating out of gfycat.com url
https://bugs.webkit.org/show_bug.cgi?id=177531
Source/WebCore:

<rdar://problem/34602601>

Reviewed by Geoff Garen.

Animation structures are normally removed when the render tree is torn down.
However there are cases where we can instantiate animation without creating a renderer
and we need to make sure animations are canceled in these cases too.

CompositeAnimations should also ref the element but that can be done separately.

Test: fast/animation/animation-element-removal.html

* dom/Element.cpp:
(WebCore::Element::removedFrom):

    Ensure animations are canceled when element is removed from the tree.

(WebCore::Element::clearHasPendingResources):
(WebCore::Element::hasCSSAnimation const):
(WebCore::Element::setHasCSSAnimation):
(WebCore::Element::clearHasCSSAnimation):

    Add a bit so we don't need to do hash lookups for every removal.

* dom/Element.h:
* dom/ElementRareData.h:
(WebCore::ElementRareData::hasCSSAnimation const):
(WebCore::ElementRareData::setHasCSSAnimation):
(WebCore::ElementRareData::ElementRareData):
* page/animation/CSSAnimationController.cpp:
(WebCore::CSSAnimationControllerPrivate::ensureCompositeAnimation):

    Test for the bit.

(WebCore::CSSAnimationControllerPrivate::clear):
(WebCore::CSSAnimationController::cancelAnimations):

LayoutTests:

Reviewed by Geoff Garen.

* fast/animation/animation-element-removal-expected.txt: Added.
* fast/animation/animation-element-removal.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMark accessibility/image-load-on-delay.html as a failure on Windows.
pvollan@apple.com [Wed, 27 Sep 2017 14:45:13 +0000 (14:45 +0000)]
Mark accessibility/image-load-on-delay.html as a failure on Windows.
https://bugs.webkit.org/show_bug.cgi?id=177541

Unreviewed test gardening.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[GTK] Web Inspector: Add Canvas2D.svg and Canvas3D.svg
commit-queue@webkit.org [Wed, 27 Sep 2017 10:50:31 +0000 (10:50 +0000)]
[GTK] Web Inspector: Add Canvas2D.svg and Canvas3D.svg
https://bugs.webkit.org/show_bug.cgi?id=175364

Patch by Fujii Hironori <Hironori.Fujii@sony.com> on 2017-09-27
Reviewed by Carlos Garcia Campos.

Add more free icons.

* UserInterface/Images/gtk/Canvas2D.svg: Copied from Source/WebInspectorUI/UserInterface/Images/gtk/Canvas.svg.
* UserInterface/Images/gtk/Canvas3D.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[ATK] atk_table_cell_get_position() should return values of aria-rowindex and aria...
jdiggs@igalia.com [Wed, 27 Sep 2017 09:45:35 +0000 (09:45 +0000)]
[ATK] atk_table_cell_get_position() should return values of aria-rowindex and aria-colindex, if present
https://bugs.webkit.org/show_bug.cgi?id=171176

Reviewed by Chris Fleizach.

Source/WebCore:

Modify webKitAccessibleTableCellGetPosition() to prefer the ARIA value
over the DOM-based value.

No new tests needed: We have coverage through aria-table-attributes.html.
Platform expectations for this test were updated.

* accessibility/atk/WebKitAccessibleInterfaceTableCell.cpp:
(webkitAccessibleTableCellGetPosition):

LayoutTests:

* accessibility/aria-table-attributes.html: Updated to reflect new behavior.
* platform/gtk/accessibility/aria-table-attributes-expected.txt: Updated to reflect new behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAdd initial experimental support for webm in WebKitGTK+ with VP8, VP9,
commit-queue@webkit.org [Wed, 27 Sep 2017 09:21:44 +0000 (09:21 +0000)]
Add initial experimental support for webm in WebKitGTK+ with VP8, VP9,
Vorbis and Opus formats, as long as suitable plugins are installed in
GStreamer.
https://bugs.webkit.org/show_bug.cgi?id=177355

Patch by Alicia Boya García <aboya@igalia.com> on 2017-09-27
Reviewed by Xabier Rodriguez-Calvar.

* platform/graphics/gstreamer/mse/AppendPipeline.cpp:
(WebCore::AppendPipeline::AppendPipeline):
* platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoPut g_gigacageBasePtr into its own page and make it read-only
fpizlo@apple.com [Wed, 27 Sep 2017 05:05:27 +0000 (05:05 +0000)]
Put g_gigacageBasePtr into its own page and make it read-only
https://bugs.webkit.org/show_bug.cgi?id=174972

Reviewed by Michael Saboff.

Source/bmalloc:

This puts the gigacage base pointers into their own page and makes that page read-only.

* bmalloc/Gigacage.cpp:
(Gigacage::ensureGigacage):
(Gigacage::disablePrimitiveGigacage):
(Gigacage::addPrimitiveDisableCallback):
* bmalloc/Gigacage.h:
(Gigacage::basePtr):
(Gigacage::basePtrs):

Source/JavaScriptCore:

C++ code doesn't have to know about this change. That includes C++ code that generates JIT code.

But the offline assembler now needs to know about how to load from offsets of global variables.
This turned out to be easy to support by extending the existing expression support.

* llint/LowLevelInterpreter64.asm:
* offlineasm/ast.rb:
* offlineasm/parser.rb:
* offlineasm/transform.rb:
* offlineasm/x86.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWeb Inspector: Styles Redesign: Style unused, overridden, and invalid properties...
nvasilyev@apple.com [Wed, 27 Sep 2017 02:54:36 +0000 (02:54 +0000)]
Web Inspector: Styles Redesign: Style unused, overridden, and invalid properties differently
https://bugs.webkit.org/show_bug.cgi?id=177461

Reviewed by Matt Baker.

Style properties the same way as in the current styles sidebar with two minor changes:
- Commented out properties are never strikethrough.
- Non-inherited properties of inherited rules are no longer strikethrough (but still semi-transparent).

* UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:
(.spreadsheet-style-declaration-editor .property:matches(.invalid, .other-vendor, .overridden):not(.disabled)):
Use the same styles as in the old sidebar, with exception of `-webkit-text-stroke-width: 0.000000000000001px`
hack, which was replaced by -webkit-text-decoration-color.

(.spreadsheet-style-declaration-editor .property.invalid:not(.disabled)):
(.spreadsheet-style-declaration-editor .property.not-inherited):
* UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:
(WI.SpreadsheetStyleProperty):
(WI.SpreadsheetStyleProperty.prototype._update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAX: Defer RenderImage's imageChanged event until after layout is done.
zalan@apple.com [Wed, 27 Sep 2017 02:54:16 +0000 (02:54 +0000)]
AX: Defer RenderImage's imageChanged event until after layout is done.
https://bugs.webkit.org/show_bug.cgi?id=177446

Reviewed by Dean Jackson.

Source/WebCore:

This is to avoid unintentional tree mutation during layout.

Covered by existing tests.

* rendering/RenderImage.cpp:
(WebCore::RenderImage::imageChanged):

LayoutTests:

* accessibility/image-load-on-delay.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUpdate web-platform-tests IDL files
cdumez@apple.com [Wed, 27 Sep 2017 02:38:57 +0000 (02:38 +0000)]
Update web-platform-tests IDL files
https://bugs.webkit.org/show_bug.cgi?id=177515

Reviewed by Youenn Fablet.

Update web-platform-tests IDL files and rebaseline tests.

* web-platform-tests/WebIDL/interfaces-expected.txt:
* web-platform-tests/cssom-view/interfaces-expected.txt:
* web-platform-tests/cssom/interfaces-expected.txt:
* web-platform-tests/html/dom/interfaces-expected.txt:
* web-platform-tests/interfaces/cssom-view.idl: Added.
* web-platform-tests/interfaces/cssom.idl:
* web-platform-tests/interfaces/dom.idl:
* web-platform-tests/interfaces/geometry.idl:
* web-platform-tests/interfaces/html.idl:
* web-platform-tests/interfaces/payment-handler.idl: Added.
* web-platform-tests/interfaces/payment-request.idl: Added.
* web-platform-tests/interfaces/webidl.idl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAX: Several ARIA roles with presentational children are exposing children
jdiggs@igalia.com [Wed, 27 Sep 2017 02:21:11 +0000 (02:21 +0000)]
AX: Several ARIA roles with presentational children are exposing children
https://bugs.webkit.org/show_bug.cgi?id=177502

Reviewed by Chris Fleizach.

Source/WebCore:

Add MenuItemCheckboxRole, MenuItemRadioRole, and SplitterRole to the list
of AccessibilityRole types which cannot have children. In the case of
DocumentMathRole, only treat children as presentational (excluded from the
accessibility tree) if the element is not MathML.

Test: accessibility/presentational-children.html

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::canHaveChildren const):

LayoutTests:

New test. Also update the results for the inspector because ARIA separators
and their subclass roles should not expose (claim to have) children.

* accessibility/presentational-children-expected.txt: Added.
* accessibility/presentational-children.html: Added.
* inspector/dom/getAccessibilityPropertiesForNode-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoPass a completion handler instead of a WebFramePolicyListenerProxy during policy...
achristensen@apple.com [Wed, 27 Sep 2017 01:39:00 +0000 (01:39 +0000)]
Pass a completion handler instead of a WebFramePolicyListenerProxy during policy decisions
https://bugs.webkit.org/show_bug.cgi?id=177509

Reviewed by Tim Horton.

This makes WebFramePolicyListenerProxy just a wrapper around a WTF::Function which is only needed for the C and glib APIs.
This is a step towards making WebPageProxy::DecidePolicyForResponseSync and WebPageProxy::DecidePolicyForNavigationAction asynchronous.

This patch has no change in behavior.

* CMakeLists.txt:
* UIProcess/API/APINavigationClient.h:
(API::NavigationClient::decidePolicyForNavigationAction):
(API::NavigationClient::decidePolicyForNavigationResponse):
* UIProcess/API/APIPolicyClient.h:
(API::PolicyClient::decidePolicyForNavigationAction):
(API::PolicyClient::decidePolicyForNewWindowAction):
(API::PolicyClient::decidePolicyForResponse):
* UIProcess/API/C/WKFramePolicyListener.cpp:
(WKFramePolicyListenerUseWithPolicies):
* UIProcess/API/C/WKPage.cpp:
(WKPageSetPagePolicyClient):
(WKPageSetPageNavigationClient):
* UIProcess/API/Cocoa/WKBrowsingContextController.mm:
* UIProcess/API/glib/WebKitPolicyClient.cpp:
* UIProcess/Automation/WebAutomationSession.cpp:
* UIProcess/Cocoa/NavigationState.h:
* UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction):
(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationResponse):
* UIProcess/Cocoa/WebViewImpl.mm:
* UIProcess/RemoteWebInspectorProxy.cpp:
* UIProcess/WebFormSubmissionListenerProxy.h:
* UIProcess/WebFrameListenerProxy.cpp: Removed.
* UIProcess/WebFrameListenerProxy.h: Removed.
* UIProcess/WebFramePolicyListenerProxy.cpp:
(WebKit::WebFramePolicyListenerProxy::WebFramePolicyListenerProxy):
(WebKit::WebFramePolicyListenerProxy::~WebFramePolicyListenerProxy):
(WebKit::WebFramePolicyListenerProxy::create):
(WebKit::WebFramePolicyListenerProxy::use):
(WebKit::WebFramePolicyListenerProxy::download):
(WebKit::WebFramePolicyListenerProxy::ignore):
* UIProcess/WebFramePolicyListenerProxy.h:
(WebKit::WebFramePolicyListenerProxy::create): Deleted.
(): Deleted.
(WebKit::WebFramePolicyListenerProxy::operator new): Deleted.
* UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::webProcessWillShutDown):
(WebKit::WebFrameProxy::receivedPolicyDecision): Deleted.
(WebKit::WebFrameProxy::setUpPolicyListenerProxy): Deleted.
* UIProcess/WebFrameProxy.h:
* UIProcess/WebInspectorProxy.cpp:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
(WebKit::WebPageProxy::decidePolicyForResponseSync):
(WebKit::WebPageProxy::receivedPolicyDecision): Deleted.
(WebKit::WebPageProxy::decidePolicyForResponse): Deleted.
* UIProcess/WebPageProxy.h:
* UIProcess/mac/ViewGestureControllerMac.mm:
* WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMac CMake bot should provide verbose build output
timothy_horton@apple.com [Wed, 27 Sep 2017 01:33:03 +0000 (01:33 +0000)]
Mac CMake bot should provide verbose build output
https://bugs.webkit.org/show_bug.cgi?id=177512

Reviewed by Alexey Proskuryakov.

* BuildSlaveSupport/build.webkit.org-config/config.json:
It's hard to diagnose weird bot-only build problems without the
full verbose build output, so turn that on. The Xcode builders
do it too, so why not CMake!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoFall back to normal line layout position, when simple line layout fails to find one.
zalan@apple.com [Wed, 27 Sep 2017 01:15:07 +0000 (01:15 +0000)]
Fall back to normal line layout position, when simple line layout fails to find one.
https://bugs.webkit.org/show_bug.cgi?id=176220
<rdar://problem/34205774>

Reviewed by Brent Fulgham.

Source/WebCore:

In case of empty content, let's just fall back to normal line layout and try to
find the visually correct one.

Test: fast/text/invalid-positionForPoint-offset.html

* rendering/RenderText.cpp:
(WebCore::RenderText::positionForPoint):
* rendering/SimpleLineLayoutResolver.cpp:
(WebCore::SimpleLineLayout::RunResolver::runForPoint const):

LayoutTests:

* fast/text/invalid-positionForPoint-offset-expected.txt: Added.
* fast/text/invalid-positionForPoint-offset.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMake it possible to easily get verbose ninja output from build-webkit
timothy_horton@apple.com [Wed, 27 Sep 2017 01:00:31 +0000 (01:00 +0000)]
Make it possible to easily get verbose ninja output from build-webkit
https://bugs.webkit.org/show_bug.cgi?id=177511

Reviewed by Sam Weinig.

* Scripts/build-webkit:
Add a -v/--verbose argument to build-webkit, which sets the environment
variable VERBOSE=1, which buildCMakeGeneratedProject already checks.

* Scripts/webkitdirs.pm:
(buildCMakeGeneratedProject):
Add ninja verbosity arguments to @makeArgs, which are appended
after the -- and thus handed to ninja; the previous implementation
(appending to @args) would only work if @makeArgs was non-empty and thus
the -- was included.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoBuild libwebrtc unit tests executables
commit-queue@webkit.org [Wed, 27 Sep 2017 00:37:59 +0000 (00:37 +0000)]
Build libwebrtc unit tests executables
https://bugs.webkit.org/show_bug.cgi?id=177211

Patch by Youenn Fablet <youenn@apple.com> on 2017-09-26
Reviewed by Alex Christensen.

.:

* WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:

Source/ThirdParty/libwebrtc:

Adding support for a new target called unittests that will be several executables.
Each executable run unit tests dedicated to a part of libwebrtc.

Adding one target/executable per unit test suite.
Adding one composite target to build all unit test targets.
Adding a target to build a static libwebrtctest library.
The static libwebrtctest library is then linked to each unit test executable which is also linked to libwebrtc dylib.

Some unit tests require a default codec (VP8) that is disabled in libwebrtc.
This ends up making some tests crashing.
An additional work should follow to execute only the meaningful subset of tests.

* Configurations/libwebrtc-base.xcconfig: Added.
* Configurations/libwebrtc-test-static.xcconfig: Added.
* Configurations/rtc_pc_unittests.xcconfig: Added.
* Source/third_party/gflags/gen/posix/include/private/config.h:
* Source/webrtc/modules/audio_coding/neteq/tools/neteq_test.cc: Replacing FATAL by RTC_FATAL.
* Source/webrtc/sdk/objc/Framework/Classes/Common/helpers.mm: Removing UIKit dependency.
* Source/webrtc/test/gmock.h: Using googletest version instead of checking in testing folder.
* Source/webrtc/test/gtest.h: Ditto.
* Source/webrtc/test/rtp_file_reader.cc: Replacing FATAL by RTC_FATAL.
* libwebrtc.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWeb Automation: overflow:hidden elements with no children are mistakenly reported...
bburg@apple.com [Wed, 27 Sep 2017 00:02:02 +0000 (00:02 +0000)]
Web Automation: overflow:hidden elements with no children are mistakenly reported as not visible
https://bugs.webkit.org/show_bug.cgi?id=177514
<rdar://problem/31936291>

Reviewed by Joseph Pecoraro.

* UIProcess/Automation/atoms/ElementDisplayed.js:
(isShown.isElementSubtreeHiddenByOverflow):
Array.prototype.every returns true when passed an empty list, so we need
to check for the case where the element has no children and return 'false'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, rolling out r222525.
jlewis3@apple.com [Tue, 26 Sep 2017 23:59:12 +0000 (23:59 +0000)]
Unreviewed, rolling out r222525.

This caused a consistent failure in the test
inspector/dom/getAccessibilityPropertiesForNode.html .

Reverted changeset:

"AX: Several ARIA roles with presentational children are
exposing children"
https://bugs.webkit.org/show_bug.cgi?id=177502
http://trac.webkit.org/changeset/222525

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoSpeedometer: ensure all TodoMVC tests use the complete latest CSS
commit-queue@webkit.org [Tue, 26 Sep 2017 23:48:14 +0000 (23:48 +0000)]
Speedometer: ensure all TodoMVC tests use the complete latest CSS
https://bugs.webkit.org/show_bug.cgi?id=177358

Patch by Mathias Bynens <mathias@qiwi.be> on 2017-09-26
Reviewed by Ryosuke Niwa.

* Speedometer/resources/todomvc/architecture-examples/angular/dist/*: Updated per build instructions.
* Speedometer/resources/todomvc/architecture-examples/angular/src/assets/css/todomvc-app.css: Updated to latest version.
* Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/*: Updated to latest TodoMVC CSS.
* Speedometer/resources/todomvc/architecture-examples/angularjs/package-lock.json: Added.
* Speedometer/resources/todomvc/architecture-examples/angularjs/package.json: Updated to latest TodoMVC CSS.
* Speedometer/resources/todomvc/architecture-examples/angularjs/todomvc-index.html: Updated to match new CSS classnames.
* Speedometer/resources/todomvc/architecture-examples/emberjs-debug/assets/vendor.css: Manually updated to latest TodoMVC CSS, except with IDs instead of classes. (Build steps unknown.)
* Speedometer/resources/todomvc/architecture-examples/emberjs/app/components/todo-list.js: Updated to match new CSS classnames.
* Speedometer/resources/todomvc/architecture-examples/emberjs/app/templates/application.hbs: Updated to match new CSS classnames.
* Speedometer/resources/todomvc/architecture-examples/emberjs/app/templates/components/todo-list.hbs: Updated to match new CSS classnames.
* Speedometer/resources/todomvc/architecture-examples/emberjs/dist/*: Updated per build instructions.
* Speedometer/resources/todomvc/architecture-examples/emberjs/vendor/index.css: Updated to latest TodoMVC CSS.
* Speedometer/resources/todomvc/architecture-examples/inferno/node_modules/*: Updated TodoMVC CSS.
* Speedometer/resources/todomvc/architecture-examples/inferno/package.json: Updated TodoMVC CSS.
* Speedometer/resources/todomvc/architecture-examples/jquery/index.html: Updated to match new CSS classnames.
* Speedometer/resources/todomvc/architecture-examples/jquery/node_modules/*: Updated TodoMVC CSS.
* Speedometer/resources/todomvc/architecture-examples/jquery/package.json: Updated to latest TodoMVC CSS.
* Speedometer/resources/todomvc/dependency-examples/flight/flight/app/templates/stats.html: Updated to match new CSS classnames.
* Speedometer/resources/todomvc/dependency-examples/flight/flight/index.html: Updated to match new CSS classnames.
* Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/todomvc-app-css/index.css: Updated to latest TodoMVC CSS.
* Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/todomvc-app-css/package.json: Updated to latest TodoMVC CSS.
* Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/todomvc-common/*: Updated to latest version.
* Speedometer/resources/todomvc/dependency-examples/flight/flight/package.json: Updated to latest TodoMVC CSS.
* Speedometer/resources/todomvc/functional-prog-examples/elm/node_modules/todomvc-app-css/index.css: Updated to latest TodoMVC CSS.
* Speedometer/resources/todomvc/functional-prog-examples/elm/node_modules/todomvc-common/base.js: Updated to latest version.
* Speedometer/resources/todomvc/functional-prog-examples/elm/package.json: Updated to latest TodoMVC CSS.
* Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/*: Updated per build instructions.
* Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/package-lock.json: Updated to latest TodoMVC CSS.
* Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/package.json: Updated to latest TodoMVC CSS.
* Speedometer/resources/todomvc/vanilla-examples/es2015/node_modules/todomvc-app-css/index.css: Updated to latest TodoMVC CSS.
* Speedometer/resources/todomvc/vanilla-examples/es2015/node_modules/todomvc-app-css/package.json: Updated to latest TodoMVC CSS.
* Speedometer/resources/todomvc/vanilla-examples/es2015/node_modules/todomvc-app-css/readme.md: Updated to latest TodoMVC CSS.
* Speedometer/resources/todomvc/vanilla-examples/es2015/node_modules/todomvc-common/*: Updated to latest version.
* Speedometer/resources/todomvc/vanilla-examples/es2015/package.json: Updated to latest TodoMVC CSS.
* Speedometer/resources/todomvc/vanilla-examples/vanillajs/node_modules/todomvc-app-css/index.css: Updated to latest TodoMVC CSS.
* Speedometer/resources/todomvc/vanilla-examples/vanillajs/node_modules/todomvc-common/*: Updated to latest version.
* Speedometer/resources/todomvc/vanilla-examples/vanillajs/package.json: Updated to latest TodoMVC CSS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Cocoa] Add a modern WKPreferences switch to disable WebRTC
commit-queue@webkit.org [Tue, 26 Sep 2017 23:35:41 +0000 (23:35 +0000)]
[Cocoa] Add a modern WKPreferences switch to disable WebRTC
https://bugs.webkit.org/show_bug.cgi?id=176638
<rdar://problem/34335158>

Patch by Youenn Fablet <youenn@apple.com> on 2017-09-26
Reviewed by Alex Christensen.

* UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _peerConnectionEnabled]):
(-[WKPreferences _setPeerConnectionEnabled:]):
* UIProcess/API/Cocoa/WKPreferencesPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMake fontToUse() a member function of InlineTextBox
dbates@webkit.org [Tue, 26 Sep 2017 23:05:29 +0000 (23:05 +0000)]
Make fontToUse() a member function of InlineTextBox
https://bugs.webkit.org/show_bug.cgi?id=177495

Reviewed by Myles C. Maxfield.

Following bug #177493 we can write fontToUse() in terms of InlineTextBox::combinedText().

No functionality changed. So, no new tests.

* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::lineFont const): Added; extracted from fontToUse().
(WebCore::InlineTextBox::combinedText const): Mark inline to give a hint to the compiler
that this function is small and seems reasonable to inline.
(WebCore::InlineTextBox::localSelectionRect const): Modified to call lineFont().
(WebCore::InlineTextBox::paint): Ditto.
(WebCore::InlineTextBox::offsetForPosition const): Ditto.
(WebCore::InlineTextBox::positionForOffset const): Ditto. Remove an extraneous
if-statement while I am here.
(WebCore::fontToUse): Deleted; moved logic to InlineTextBox::lineFont().
* rendering/InlineTextBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRemove unnecessary libwebrtc dependencies
commit-queue@webkit.org [Tue, 26 Sep 2017 22:56:06 +0000 (22:56 +0000)]
Remove unnecessary libwebrtc dependencies
https://bugs.webkit.org/show_bug.cgi?id=177494

Patch by Youenn Fablet <youenn@apple.com> on 2017-09-26
Reviewed by Alex Christensen.

* libwebrtc.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoFollowup (r222427): SynchronizedFixedQueue should not have a public constructor
commit-queue@webkit.org [Tue, 26 Sep 2017 22:40:51 +0000 (22:40 +0000)]
Followup (r222427): SynchronizedFixedQueue should not have a public constructor
https://bugs.webkit.org/show_bug.cgi?id=177458

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2017-09-26
Reviewed by Tim Horton.

Source/WebCore:

ImageFrameCache::decodingQueue() and frameRequestQueue() should return
raw references instead of Ref objects.

* platform/graphics/ImageFrameCache.cpp:
(WebCore::ImageFrameCache::decodingQueue):
(WebCore::ImageFrameCache::frameRequestQueue):
(WebCore::ImageFrameCache::startAsyncDecodingQueue):
* platform/graphics/ImageFrameCache.h:

Source/WTF:

Since SynchronizedFixedQueue is now derived from ThreadSafeRefCounted<SynchronizedFixedQueue>,
the standard way to have an instance of it is to call SynchronizedFixedQueue::create()
which returns a Ref<SynchronizedFixedQueue>. Now it does not make sense to still
have the constructor public.

* wtf/SynchronizedFixedQueue.h:
(WTF::SynchronizedFixedQueue::SynchronizedFixedQueue):

Tools:

Fix the definition and the creation of SynchronizedFixedQueue.

* TestWebKitAPI/Tests/WTF/SynchronizedFixedQueue.cpp:
(TestWebKitAPI::ToUpperConverter::ToUpperConverter):
(TestWebKitAPI::ToUpperConverter::startProducing):
(TestWebKitAPI::ToUpperConverter::startConsuming):
(TestWebKitAPI::ToUpperConverter::stopProducing):
(TestWebKitAPI::ToUpperConverter::stopConsuming):
(TestWebKitAPI::ToUpperConverter::enqueueLower):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoCMake should reconfigure if the Sources.txt files are touched
keith_miller@apple.com [Tue, 26 Sep 2017 22:34:31 +0000 (22:34 +0000)]
CMake should reconfigure if the Sources.txt files are touched
https://bugs.webkit.org/show_bug.cgi?id=177508

Reviewed by JF Bastien.

* Source/cmake/WebKitMacros.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoExtract out combined text query into a member function
dbates@webkit.org [Tue, 26 Sep 2017 22:28:43 +0000 (22:28 +0000)]
Extract out combined text query into a member function
https://bugs.webkit.org/show_bug.cgi?id=177493

Reviewed by Zalan Bujtas.

Towards removing duplication throughout the paint code extract the
querying for the combined text of an inline text box into a member
function.

For a similar reason, update functions to query lineStyle() instead
of passing this information an argument.

No functionality changed. So, no new tests.

* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint): Extract logic to query for combined text
from here to InlineTextBox::combinedText() and modify code to call this
member function.
(WebCore::InlineTextBox::paintTextSubrangeBackground): Query for line style
instead of taking it as an argument.
(WebCore::InlineTextBox::paintCompositionBackground): Ditto.
(WebCore::InlineTextBox::paintTextMatchMarker): Ditto.
(WebCore::InlineTextBox::paintDecoration): Update code to query combinedText()
instead of taking RenderCombineText as an argument. While I am here make use of
GraphicsContextStateSaver to save and restore the graphics context state when
we have a non-empty clip rect.
(WebCore::InlineTextBox::paintDocumentMarker): Query for line style instead of
taking it as an argument.
(WebCore::InlineTextBox::paintDocumentMarkers): Ditto.
(WebCore::InlineTextBox::combinedText const): Added; extracted from InlineTextBox::paint().
* rendering/InlineTextBox.h:
* rendering/TextPainter.h:
(WebCore::TextPainter::setEmphasisMark): Modified to take a const RenderCombineText*
as opposed to a pointer to a non-const RenderCombineText.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAX: ARIA grids claim to be multiselectable even with aria-multiselectable is set...
jdiggs@igalia.com [Tue, 26 Sep 2017 22:19:12 +0000 (22:19 +0000)]
AX: ARIA grids claim to be multiselectable even with aria-multiselectable is set to false
https://bugs.webkit.org/show_bug.cgi?id=177498

Reviewed by Chris Fleizach.

Source/WebCore:

AccessibilityARIAGrid::isMultiSelectable() was unconditionally returning
true. Modify it to return false if aria-multiselectable has been set to
false by the author.

Test: accessibility/aria-multiselectable-grid.html

* accessibility/AccessibilityARIAGrid.cpp:
(WebCore::AccessibilityARIAGrid::isMultiSelectable const):
* accessibility/AccessibilityARIAGrid.h:

LayoutTests:

* accessibility/aria-multiselectable-grid-expected.txt: Added.
* accessibility/aria-multiselectable-grid.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Win] WebKitCOMAPI.h is not copied after build has finished.
pvollan@apple.com [Tue, 26 Sep 2017 22:00:52 +0000 (22:00 +0000)]
[Win] WebKitCOMAPI.h is not copied after build has finished.
https://bugs.webkit.org/show_bug.cgi?id=177505

Reviewed by Brent Fulgham.

The file is located in the WebKitLegacy forwarding headers folder, not the WebKit folder.

* WebKitLegacy.vcxproj/WebKitLegacy.proj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAX: Several ARIA roles with presentational children are exposing children
jdiggs@igalia.com [Tue, 26 Sep 2017 21:51:04 +0000 (21:51 +0000)]
AX: Several ARIA roles with presentational children are exposing children
https://bugs.webkit.org/show_bug.cgi?id=177502

Reviewed by Chris Fleizach.

Source/WebCore:

Add MenuItemCheckboxRole, MenuItemRadioRole, and SplitterRole to the list
of AccessibilityRole types which cannot have children. In the case of
DocumentMathRole, only treat children as presentational (excluded from the
accessibility tree) if the element is not MathML.

Test: accessibility/presentational-children.html

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::canHaveChildren const):

LayoutTests:

* accessibility/presentational-children-expected.txt: Added.
* accessibility/presentational-children.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[PAL][CMake] Include ICU directories
don.olmstead@sony.com [Tue, 26 Sep 2017 21:43:12 +0000 (21:43 +0000)]
[PAL][CMake] Include ICU directories
https://bugs.webkit.org/show_bug.cgi?id=177504

Reviewed by Myles C. Maxfield.

* pal/CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, rolling out r222518.
commit-queue@webkit.org [Tue, 26 Sep 2017 21:25:44 +0000 (21:25 +0000)]
Unreviewed, rolling out r222518.
https://bugs.webkit.org/show_bug.cgi?id=177507

Break the High Sierra build (Requested by yusukesuzuki on
#webkit).

Reverted changeset:

"Add Above/Below comparisons for UInt32 patterns"
https://bugs.webkit.org/show_bug.cgi?id=177281
http://trac.webkit.org/changeset/222518

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[ios-simulator] API test DataInteractionTests.ExternalSourceDataTransferItemGetFolder...
wenson_hsieh@apple.com [Tue, 26 Sep 2017 20:49:52 +0000 (20:49 +0000)]
[ios-simulator] API test DataInteractionTests.ExternalSourceDataTransferItemGetFolderAsEntry is failing
https://bugs.webkit.org/show_bug.cgi?id=177271

Reviewed by Tim Horton and Megan Gardner.

Rebaseline a failing API test.

* TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Curl] Introduce CurlResponse to hold response information among threads.
commit-queue@webkit.org [Tue, 26 Sep 2017 20:48:02 +0000 (20:48 +0000)]
[Curl] Introduce CurlResponse to hold response information among threads.
https://bugs.webkit.org/show_bug.cgi?id=177496

Patch by Basuke Suzuki <Basuke.Suzuki@sony.com> on 2017-09-26
Reviewed by Alex Christensen.

* platform/network/curl/AuthenticationChallenge.h:
* platform/network/curl/AuthenticationChallengeCurl.cpp:
(WebCore::AuthenticationChallenge::AuthenticationChallenge):
(WebCore::AuthenticationChallenge::protectionSpaceFromHandle):
* platform/network/curl/CurlContext.cpp:
(WebCore::CurlHandle::getHttpConnectCode):
* platform/network/curl/CurlContext.h:
* platform/network/curl/CurlResponse.h: Added.
(WebCore::CurlResponse::isolatedCopy const):
* platform/network/curl/ResourceHandleCurlDelegate.cpp:
(WebCore::ResourceHandleCurlDelegate::didReceiveAllHeaders):
(WebCore::ResourceHandleCurlDelegate::didReceiveContentData):
(WebCore::ResourceHandleCurlDelegate::handleLocalReceiveResponse):
(WebCore::ResourceHandleCurlDelegate::didFinish):
(WebCore::ResourceHandleCurlDelegate::handleDataURL):
(WebCore::ResourceHandleCurlDelegate::didReceiveHeader):
(WebCore::isHttpInfo): Deleted.
* platform/network/curl/ResourceHandleCurlDelegate.h:
* platform/network/curl/ResourceResponse.h:
(WebCore::ResourceResponse::ResourceResponse):
(WebCore::ResourceResponse::setResponseFired): Deleted.
(WebCore::ResourceResponse::responseFired): Deleted.
* platform/network/curl/ResourceResponseCurl.cpp:
(WebCore::ResourceResponse::ResourceResponse):
(WebCore::ResourceResponse::appendHTTPHeaderField):
(WebCore::ResourceResponse::setStatusLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoHarden our access to the vector of URL schemes.
bfulgham@apple.com [Tue, 26 Sep 2017 20:42:14 +0000 (20:42 +0000)]
Harden our access to the vector of URL schemes.
https://bugs.webkit.org/show_bug.cgi?id=177470
<rdar://problem/33881522>

Reviewed by Chris Dumez.

Instead of asserting, use MESSAGE_CHECK so that we actually refuse to access an invalid iterator.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::startURLSchemeTask):
(WebKit::WebPageProxy::stopURLSchemeTask):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMake StoredCredentials an enum class and rename its header
cdumez@apple.com [Tue, 26 Sep 2017 20:36:29 +0000 (20:36 +0000)]
Make StoredCredentials an enum class and rename its header
https://bugs.webkit.org/show_bug.cgi?id=177455

Reviewed by Youenn Fablet.

Follow-up to r222467, actually make it an enum *class*.

* platform/network/StoredCredentialsPolicy.h:
(): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAdd Above/Below comparisons for UInt32 patterns
utatane.tea@gmail.com [Tue, 26 Sep 2017 20:32:18 +0000 (20:32 +0000)]
Add Above/Below comparisons for UInt32 patterns
https://bugs.webkit.org/show_bug.cgi?id=177281

Reviewed by Saam Barati.

JSTests:

* stress/uint32-comparison-jump.js: Added.
(shouldBe):
(above):
(aboveOrEqual):
(below):
(belowOrEqual):
(notAbove):
(notAboveOrEqual):
(notBelow):
(notBelowOrEqual):
* stress/uint32-comparison.js: Added.
(shouldBe):
(above):
(aboveOrEqual):
(below):
(belowOrEqual):
(aboveTest):
(aboveOrEqualTest):
(belowTest):
(belowOrEqualTest):

Source/JavaScriptCore:

Sometimes, we would like to have UInt32 operations in JS. While VM does
not support UInt32 nicely, VM supports efficient Int32 operations. As long
as signedness does not matter, we can just perform Int32 operations instead
and recognize its bit pattern as UInt32.

But of course, some operations respect signedness. The most frequently
used one is comparison. Octane/zlib performs UInt32 comparison by performing
`val >>> 0`. It emits op_urshift and op_unsigned. op_urshift produces
UInt32 in Int32 form. And op_unsigned will generate Double value if
the generated Int32 is < 0 (which should be UInt32).

There is a chance for optimization. The given code pattern is the following.

    op_unsigned(op_urshift(@1)) lessThan:< op_unsigned(op_urshift(@2))

This can be converted to the following.

    op_urshift(@1) below:< op_urshift(@2)

The above conversion is nice since

1. We can avoid op_unsigned. This could be unsignedness check in DFG. Since
this check depends on the value of Int32, dropping this check is not as easy as
removing Int32 edge filters.

2. We can perform unsigned comparison in Int32 form. We do not need to convert
them to DoubleRep.

Since the above comparison exists in Octane/zlib's *super* hot path, dropping
op_unsigned offers huge win.

At first, my patch attempts to convert the above thing in DFG pipeline.
However it poses several problems.

1. MovHint is not well removed. It makes UInt32ToNumber (which is for op_unsigned) live.
2. UInt32ToNumber could cause an OSR exit. So if we have the following nodes,

    2: UInt32ToNumber(@0)
    3: MovHint(@2, xxx)
    4: UInt32ToNumber(@1)
    5: MovHint(@1, xxx)

we could drop @5's MovHint. But @3 is difficult since @4 can exit.

So, instead, we start introducing a simple optimization in the bytecode compiler.
It performs pattern matching for op_urshift and comparison to drop op_unsigned.
We adds op_below and op_above families to bytecodes. They only accept Int32 and
perform unsigned comparison.

This offers 4% performance improvement in Octane/zlib.

                            baseline                  patched

zlib           x2     431.07483+-16.28434       414.33407+-9.38375         might be 1.0404x faster

* bytecode/BytecodeDumper.cpp:
(JSC::BytecodeDumper<Block>::printCompareJump):
(JSC::BytecodeDumper<Block>::dumpBytecode):
* bytecode/BytecodeDumper.h:
* bytecode/BytecodeList.json:
* bytecode/BytecodeUseDef.h:
(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):
* bytecode/Opcode.h:
(JSC::isBranch):
* bytecode/PreciseJumpTargetsInlines.h:
(JSC::extractStoredJumpTargetsForBytecodeOffset):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitJumpIfTrue):
(JSC::BytecodeGenerator::emitJumpIfFalse):
* bytecompiler/NodesCodegen.cpp:
(JSC::BinaryOpNode::emitBytecode):
* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCapabilities.cpp:
(JSC::DFG::capabilityLevel):
* dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
* dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGIntegerRangeOptimizationPhase.cpp:
* dfg/DFGNodeType.h:
* dfg/DFGPredictionPropagationPhase.cpp:
* dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileCompareUnsigned):
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGStrengthReductionPhase.cpp:
(JSC::DFG::StrengthReductionPhase::handleNode):
* dfg/DFGValidate.cpp:
* ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileCompareBelow):
(JSC::FTL::DFG::LowerDFGToB3::compileCompareBelowEq):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
* jit/JIT.h:
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_below):
(JSC::JIT::emit_op_beloweq):
(JSC::JIT::emit_op_jbelow):
(JSC::JIT::emit_op_jbeloweq):
(JSC::JIT::emit_compareUnsignedAndJump):
(JSC::JIT::emit_compareUnsigned):
* jit/JITArithmetic32_64.cpp:
(JSC::JIT::emit_compareUnsignedAndJump):
(JSC::JIT::emit_compareUnsigned):
* llint/LowLevelInterpreter.asm:
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:
* parser/Nodes.h:
(JSC::ExpressionNode::isBinaryOpNode const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAdd helper functions to write better selection tests
megan_gardner@apple.com [Tue, 26 Sep 2017 20:24:19 +0000 (20:24 +0000)]
Add helper functions to write better selection tests
https://bugs.webkit.org/show_bug.cgi?id=177403

Reviewed by Tim Horton.

Selection tests are finicky to write, so having some more helper functions
that can assist in double checking where we think we are selecting, or where we
think words are located in helpful.

* fast/events/touch/ios/resources/ui-debugging.js: Added.
(debugDot):
(removeDebugDot):
(debugRect):
(removeDebugRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRemove extraneous includes of TextRun.h
commit-queue@webkit.org [Tue, 26 Sep 2017 20:22:19 +0000 (20:22 +0000)]
Remove extraneous includes of TextRun.h
https://bugs.webkit.org/show_bug.cgi?id=177499

Patch by Daniel Bates <dabates@apple.com> on 2017-09-26
Reviewed by Myles C. Maxfield.

No functionality changed. So, no new tests.

* platform/graphics/mac/ComplexTextControllerCoreText.mm:
* platform/mac/DragImageMac.mm:
* platform/text/ios/LocalizedDateCache.mm:
* testing/InternalSettings.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[PAL] Move Clock into PAL
commit-queue@webkit.org [Tue, 26 Sep 2017 19:57:30 +0000 (19:57 +0000)]
[PAL] Move Clock into PAL
https://bugs.webkit.org/show_bug.cgi?id=174342

Patch by Yoshiaki Jitsukawa <Yoshiaki.Jitsukawa@sony.com> on 2017-09-26
Reviewed by Myles C. Maxfield.

Source/WebCore:

No new tests. No change in behavior.

* CMakeLists.txt:
* WebCore.xcodeproj/project.pbxproj:
* html/MediaController.cpp:
(MediaController::MediaController):
* html/MediaController.h:
* platform/Clock.cpp: Removed.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::MediaPlayerPrivateMediaStreamAVFObjC):
* platform/mac/PlatformClockCA.cpp: Removed. PlatformClockCA is no longer used.
* platform/mac/PlatformClockCA.h: Removed.

Source/WebCore/PAL:

* PAL.xcodeproj/project.pbxproj:
* pal/PlatformGTK.cmake:
* pal/PlatformWin.cmake:
* pal/system/Clock.h: Renamed from Source/WebCore/platform/Clock.h.
* pal/system/ClockGeneric.cpp: Renamed from Source/WebCore/platform/ClockGeneric.cpp.
(PAL::Clock::create):
* pal/system/ClockGeneric.h: Renamed from Source/WebCore/platform/ClockGeneric.h.
* pal/system/mac/ClockCM.h: Renamed from Source/WebCore/platform/mac/PlatformClockCM.h.
* pal/system/mac/ClockCM.mm: Renamed from Source/WebCore/platform/mac/PlatformClockCM.mm.
(Clock::create):
(ClockCM::ClockCM):
(ClockCM::initializeWithTimingSource):
(ClockCM::setCurrentTime):
(ClockCM::currentTime const):
(ClockCM::setCurrentMediaTime):
(ClockCM::currentMediaTime const):
(ClockCM::setPlayRate):
(ClockCM::start):
(ClockCM::stop):

* pal/cf/CoreMediaSoftLink.cpp:
* pal/cf/CoreMediaSoftLink.h:
Add requrired functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoSet LF eol-style on Windows shell script, because the script failed on one of the EWS
pvollan@apple.com [Tue, 26 Sep 2017 19:06:57 +0000 (19:06 +0000)]
Set LF eol-style on Windows shell script, because the script failed on one of the EWS
bots, when it had the 'native' style.

Unreviewed Windows EWS fix.

* EWSTools/start-queue-win.sh: Modified property svn:eol-style.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Curl] Change member variable of CurlHandle to use std::unique_ptr
commit-queue@webkit.org [Tue, 26 Sep 2017 19:03:35 +0000 (19:03 +0000)]
[Curl] Change member variable of CurlHandle to use std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=177492

Patch by Basuke Suzuki <Basuke.Suzuki@sony.com> on 2017-09-26
Reviewed by Alex Christensen.

* platform/network/curl/CurlDownload.cpp:
(WebCore::CurlDownload::init):
(WebCore::CurlDownload::getResponse const):
(WebCore::CurlDownload::setupTransfer):
(WebCore::CurlDownload::didCompleteTransfer):
(WebCore::CurlDownload::didCancelTransfer):
(WebCore::CurlDownload::didReceiveHeader):
(WebCore::CurlDownload::addHeaders): Deleted.
* platform/network/curl/CurlDownload.h:
* platform/network/curl/ResourceHandleCurlDelegate.cpp:
(WebCore::ResourceHandleCurlDelegate::ResourceHandleCurlDelegate):
(WebCore::ResourceHandleCurlDelegate::start):
(WebCore::ResourceHandleCurlDelegate::setDefersLoading):
(WebCore::ResourceHandleCurlDelegate::setAuthentication):
(WebCore::ResourceHandleCurlDelegate::setupTransfer):
(WebCore::ResourceHandleCurlDelegate::didCompleteTransfer):
(WebCore::ResourceHandleCurlDelegate::didCancelTransfer):
(WebCore::ResourceHandleCurlDelegate::didReceiveAllHeaders):
(WebCore::ResourceHandleCurlDelegate::handleLocalReceiveResponse):
(WebCore::ResourceHandleCurlDelegate::setupPOST):
(WebCore::ResourceHandleCurlDelegate::setupPUT):
(WebCore::ResourceHandleCurlDelegate::setupFormData):
(WebCore::ResourceHandleCurlDelegate::applyAuthentication):
(WebCore::ResourceHandleCurlDelegate::getNetworkLoadMetrics):
(WebCore::ResourceHandleCurlDelegate::willSetupSslCtx):
(WebCore::ResourceHandleCurlDelegate::didReceiveHeader):
(WebCore::ResourceHandleCurlDelegate::didReceiveData):
* platform/network/curl/ResourceHandleCurlDelegate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agowebkitpy: Notify parent process when a worker is spawned
jbedard@apple.com [Tue, 26 Sep 2017 18:58:57 +0000 (18:58 +0000)]
webkitpy: Notify parent process when a worker is spawned
https://bugs.webkit.org/show_bug.cgi?id=177467
<rdar://problem/34660194>

Reviewed by Daniel Bates.

When we fork the parent process, there may be resources in that process
which workers will take ownership of. Notify ports when a new worker is created
so that these resources can be correctly managed.

* Scripts/webkitpy/common/message_pool.py:
(_MessagePool._start_workers): After all workers are started, notify the caller
that a worker has been created, unless we are running inline, in which case the
parent process is still the worker.
* Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
(LayoutTestRunner._handle_did_spawn_worker): Notify the port that a worker process
has been created.
* Scripts/webkitpy/port/base.py:
(Port.did_spawn_worker): Add function so that ports may manage any
resources created on the parent process but managed by the provided worker.
* Scripts/webkitpy/port/device.py:
(Device.release_worker_resources): Call release_worker_resources on the
platform_device if such a function is defined.
* Scripts/webkitpy/port/ios.py:
(IOSPort.did_spawn_worker): Release any worker resources on the iOS
device object associated with the spawned worker.
* Scripts/webkitpy/test/runner.py:
(Runner.handle): Ignore the did_spawn_worker message during testing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWeb Inspector: Improve Table scrolling performance
joepeck@webkit.org [Tue, 26 Sep 2017 18:22:40 +0000 (18:22 +0000)]
Web Inspector: Improve Table scrolling performance
https://bugs.webkit.org/show_bug.cgi?id=177468

Reviewed by Brian Burg.

This reduces work during scrolling updates in two ways.

1. Avoid recalculating the width/height of the Table on scroll.
  - We only need to recalculate sizes if the view changes size.
2. Avoid resetting sizes on all cells if the sizes did not change.
  - Enumerating and setting style.width values was showing up in profiles.

* UserInterface/Views/Table.js:
(WI.Table):
New member variables for a cached width/height of the scrollable region.
_cachedWidth is the same as _cachedScrollableHeight but they could be
different so I just kept them separate for now. Also switch to
getBoundingClientRect which gets us a better value then
offsetWidth/offsetHeight.

(WI.Table.prototype.resize):
Clear cached size and relayout.

(WI.Table.prototype.layout):
If we did not resize, layout without recalculating sizes.

(WI.Table.prototype.resizerDragging):
(WI.Table.prototype._getOrCreateRow):
When column widths change increment the width generation. This will let
us quickly check if a row's cells are appropriately sized or not.

(WI.Table.prototype._resizeColumnsAndFiller):
Cache width values after recalculating. Provide a fast path if values
have not changed.

(WI.Table.prototype._updateVisibleRows):
(WI.Table.prototype._updateFillerRowWithNewHeight):
Factor out updating the filler row into a function.

(WI.Table.prototype._applyColumnWidths):
Always update the width generation of a row after setting its cell widths.

(WI.Table.prototype._applyColumnWidthsToColumnsIfNeeded):
Fast path only updates row cell widths if they need to change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Curl] Simplify JobManager's duty and move the tasks to client
commit-queue@webkit.org [Tue, 26 Sep 2017 18:20:59 +0000 (18:20 +0000)]
[Curl] Simplify JobManager's duty and move the tasks to client
for easy handling. Also simlify CurlHandle by not storing internal
error value as a member variable.
https://bugs.webkit.org/show_bug.cgi?id=177466

Patch by Basuke Suzuki <Basuke.Suzuki@sony.com> on 2017-09-26
Reviewed by Alex Christensen.

* platform/network/curl/CurlContext.cpp:
(WebCore::CurlHandle::perform):
(WebCore::CurlHandle::pause):
(WebCore::CurlHandle::getEffectiveURL):
(WebCore::CurlHandle::getPrimaryPort):
(WebCore::CurlHandle::getResponseCode):
(WebCore::CurlHandle::getContentLength):
(WebCore::CurlHandle::getHttpAuthAvail):
(WebCore::CurlHandle::getNetworkLoadMetrics):
* platform/network/curl/CurlContext.h:
(WebCore::CurlHandle::errorCode const): Deleted.
(WebCore::CurlHandle::setErrorCode): Deleted.
* platform/network/curl/CurlDownload.cpp:
(WebCore::CurlDownload::start):
(WebCore::CurlDownload::cancel):
(WebCore::CurlDownload::setupTransfer):
(WebCore::CurlDownload::didCompleteTransfer):
(WebCore::CurlDownload::didCancelTransfer):
(WebCore::CurlDownload::setupRequest): Deleted.
(WebCore::CurlDownload::notifyFinish): Deleted.
(WebCore::CurlDownload::notifyFail): Deleted.
* platform/network/curl/CurlDownload.h:
* platform/network/curl/CurlJobManager.cpp:
(WebCore::CurlJobList::startJobs):
(WebCore::CurlJobList::finishJobs):
(WebCore::CurlJobManager::add):
(WebCore::CurlJobManager::cancel):
(WebCore::CurlJobManager::callOnJobThread):
(WebCore::CurlJobManager::updateJobList):
(WebCore::CurlJobManager::workerThread):
(WebCore::CurlJobList::notifyResult): Deleted.
* platform/network/curl/CurlJobManager.h:
* platform/network/curl/ResourceHandleCurlDelegate.cpp:
(WebCore::ResourceHandleCurlDelegate::start):
(WebCore::ResourceHandleCurlDelegate::cancel):
(WebCore::ResourceHandleCurlDelegate::dispatchSynchronousJob):
(WebCore::ResourceHandleCurlDelegate::setupTransfer):
(WebCore::ResourceHandleCurlDelegate::didCompleteTransfer):
(WebCore::ResourceHandleCurlDelegate::didCancelTransfer):
(WebCore::ResourceHandleCurlDelegate::didFinish):
(WebCore::ResourceHandleCurlDelegate::didFail):
(WebCore::ResourceHandleCurlDelegate::setupRequest): Deleted.
(WebCore::ResourceHandleCurlDelegate::notifyFinish): Deleted.
(WebCore::ResourceHandleCurlDelegate::notifyFail): Deleted.
* platform/network/curl/ResourceHandleCurlDelegate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoCleanup: Consolidate non-selection background painting code for text
dbates@webkit.org [Tue, 26 Sep 2017 18:12:50 +0000 (18:12 +0000)]
Cleanup: Consolidate non-selection background painting code for text
https://bugs.webkit.org/show_bug.cgi?id=177490

Reviewed by Zalan Bujtas.

Share code to paint the background of a text subrange instead of duplicating
it for text match markers and composition underlines.

Additionally standardize the argument order for various paint functions and
make more paint functions private.

No functionality changed. So, no new tests.

* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint): Updated code as needed for changes below.
(WebCore::InlineTextBox::paintSelection): Add FIXME comment to fix up this code for
combined text while I am in this file.
(WebCore::InlineTextBox::paintTextSubrangeBackground): Added. Extracted from the common code of
paintCompositionBackground() and paintTextMatchMarker().
(WebCore::InlineTextBox::paintCompositionBackground): Modified to use paintTextSubrangeBackground().
(WebCore::InlineTextBox::paintTextMatchMarker): Ditto.
(WebCore::InlineTextBox::paintDocumentMarker): Add FIXME comment to fix up this code for
combined and hyphenated text while I am here.
(WebCore::InlineTextBox::paintDocumentMarkers): Update code as needed for changes
above.
* rendering/InlineTextBox.h: Change visibility of paintCompositionBackground(),
paintDocumentMarkers() and paintCompositionUnderline() from protected to private
as no derived class makes use of these functions. Group related functions to
improve readability.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed. Remove hardware concurrency from features list.
dino@apple.com [Tue, 26 Sep 2017 18:08:23 +0000 (18:08 +0000)]
Unreviewed. Remove hardware concurrency from features list.

* features.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoThrown ObjC exception when right clicking on <img> containing mp4 link
jer.noble@apple.com [Tue, 26 Sep 2017 17:53:47 +0000 (17:53 +0000)]
Thrown ObjC exception when right clicking on <img> containing mp4 link
https://bugs.webkit.org/show_bug.cgi?id=177370

Reviewed by Darin Adler.

Source/WebKit:

Creating a NSImage from mp4 data will fail and return nil; do a nil-check before attempting
to put the results into a NSMutableArray.

* UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::createShareMenuItem):

Tools:

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit/mac/ContextMenuImgWithVideo.html: Added.
* TestWebKitAPI/Tests/WebKit/mac/ContextMenuImgWithVideo.mm: Added.
(-[ContextMenuImgWithVideoDelegate _webView:contextMenu:forElement:]):
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUpdate TestExpectations for http/tests/local/blob/send-hybrid-blob-using-open-panel...
ryanhaddad@apple.com [Tue, 26 Sep 2017 17:40:40 +0000 (17:40 +0000)]
Update TestExpectations for http/tests/local/blob/send-hybrid-blob-using-open-panel.html.
https://bugs.webkit.org/show_bug.cgi?id=171353

Unreviewed test gardening.

* platform/ios-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWeb Automation: add commands to get and set user permissions for pages in an automati...
bburg@apple.com [Tue, 26 Sep 2017 17:12:21 +0000 (17:12 +0000)]
Web Automation: add commands to get and set user permissions for pages in an automation session
https://bugs.webkit.org/show_bug.cgi?id=177405
<rdar://problem/34493846>

Reviewed by Joseph Pecoraro.

To test some Web APIs via WebDriver, it needs to be possible to simulate a user accepting or
denying requests for elevated permissions, such as getUserMedia() or geolocation.

This patch adds a generic way for a test to configure the automation session's
simulated user action that will happen every time a specific permission is requested.
A test can set a "session permission", trigger the permission request via Web API,
and then verify that the page behaves correctly when the user accepted or denied the request.

A proposal will follow shortly to expose this functionality via a new REST API endpoint.

* UIProcess/Automation/Automation.json: Add get/set commands.

* UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::getSessionPermissions):
(WebKit::WebAutomationSession::setSessionPermissions):
For now, store the permission value in a member of the session. The getUserMedia
permission only needs a bool, but there is no reason we couldn't use more complicated
values for permissions (i.e., strings, numbers, arrays, objects) someday.

(WebKit::WebAutomationSession::shouldAllowGetUserMediaForPage const):
Expose the specific decision to be taken based on whether the request is allowed or denied.

* UIProcess/Automation/WebAutomationSession.h:
* UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
(WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame):
If the page is under automation, then simulate the user action according to the
current values of permissions set for the session.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Win] 'webkit-patch clean' is failing on bot.
pvollan@apple.com [Tue, 26 Sep 2017 16:29:08 +0000 (16:29 +0000)]
[Win] 'webkit-patch clean' is failing on bot.
https://bugs.webkit.org/show_bug.cgi?id=177488

Reviewed by Brent Fulgham.

If 'os.remove' throws an exception, catch it.

* Scripts/webkitpy/common/checkout/scm/svn.py:
(SVN.discard_working_directory_changes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoREGRESSION (222040): Google Maps Street View CrashTracer: [USER] com.apple.WebKit...
antti@apple.com [Tue, 26 Sep 2017 15:51:55 +0000 (15:51 +0000)]
REGRESSION (222040): Google Maps Street View CrashTracer: [USER] com.apple.WebKit.WebContent.Development at com.apple.WebCore: WebCore::PropertyWrapperAcceleratedTransform::blend const + 92
https://bugs.webkit.org/show_bug.cgi?id=177485

Reviewed by Zalan Bujtas.

Source/WebCore:

We crash when animating between two different types of transforms because renderer is null for the first frame.

Test: fast/animation/animation-mixed-transform-crash.html

* page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::currentStyle const):

    Add a way to get the current style from animations.
    This is either the render style or the inital style.

* page/animation/AnimationBase.h:
* page/animation/CSSPropertyAnimation.cpp:
(WebCore::blendFunc):

    Renderer may be null when computing the first frame of the animation. Null check.

(WebCore::blendFilter):

    Here too.

* page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::updateTransitions):
* page/animation/ImplicitAnimation.h:
* page/animation/KeyframeAnimation.h:

LayoutTests:

* fast/animation/animation-mixed-transform-crash-expected.html: Added.
* fast/animation/animation-mixed-transform-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMark compositing/masks/compositing-clip-path-change-no-repaint.html as flaky.
ryanhaddad@apple.com [Tue, 26 Sep 2017 15:40:08 +0000 (15:40 +0000)]
Mark compositing/masks/compositing-clip-path-change-no-repaint.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=177397

Unreviewed test gardening.

* platform/ios/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoJSC build should use unified sources for derived sources
keith_miller@apple.com [Tue, 26 Sep 2017 15:34:19 +0000 (15:34 +0000)]
JSC build should use unified sources for derived sources
https://bugs.webkit.org/show_bug.cgi?id=177421

Reviewed by JF Bastien.

.:

* Source/cmake/WebKitMacros.cmake:

Source/JavaScriptCore:

This patch make a couple of changes:

1) Make derived sources added to relevant bundles. I was going to add JSCBuiltins.cpp
to runtime but that kept breaking the windows build. I'll get back to it later
2) Move the derived location of some sources both for clarity and for ease of use.
3) Make auto generator scripts able to create directories if needed.
4) Move some scripts from the top level of the JavaScriptCore directory to a
more appropriate directory.
5) Move some CMake generation commands around for clarity.

* CMakeLists.txt:
* DerivedSources.make:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Scripts/lazywriter.py:
(LazyFileWriter.close):
* Sources.txt:
* inspector/scripts/generate-inspector-protocol-bindings.py:
(IncrementalFileWriter.close):
* yarr/create_regex_tables: Renamed from Source/JavaScriptCore/create_regex_tables.
* yarr/generateYarrCanonicalizeUnicode: Renamed from Source/JavaScriptCore/generateYarrCanonicalizeUnicode.

Source/WTF:

The script now needs to determine if a file is from a derived
source. This is only relevant for the CMake build since the
script needs to provide a list of the bundled source files. If the
script does not provide the full path for derived sources then
CMake will be unable to find them and the build will fail.

Additionally, I move the error message for the Xcode build outside
the main loop. This means that the error message will contain all
the files you need to add to Xcode and all those files will now be
written in DerivedSources so they should be easier to add.

* Scripts/generate-unified-source-bundles.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[EME] Add ClearKey support for persistent session data load and removal
zandobersek@gmail.com [Tue, 26 Sep 2017 09:48:23 +0000 (09:48 +0000)]
[EME] Add ClearKey support for persistent session data load and removal
https://bugs.webkit.org/show_bug.cgi?id=177442

Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

Implement the session data load and removal for persistent sessions
in the ClearKey implementation of the CDMInstance interface.

CDMInstanceClearKey::loadSession() finds data for the specified session
name, if any, and constructs a corresponding KeyStatusVector object that
holds information about all known keys associated with this session before
dispatching the LoadSessionCallback asynchronously.

CDMInstanceClearKey::removeSessionData() similarly finds the session data,
if any, and then removes it from the state tracker. The key data is still
reused to construct the KeyStatusVector object that holds information
about all the keys that were stored for this session. The key information
is also embedded in the 'license release' JSON message. Both key status
vector and message are then used in the RemoveSessionDataCallback dispatch
that is again done asynchronously.

No new tests -- affected tests have their baselines updated.

* platform/encryptedmedia/clearkey/CDMClearKey.cpp:
(WebCore::CDMInstanceClearKey::loadSession):
(WebCore::CDMInstanceClearKey::removeSessionData):

LayoutTests:

Update WPE baselines for EME tests affected by the addition of persistent
session data load and removal in the ClearKey implementation.

All the affected tests progress, but most of them still don't pass
entirely due to missing functionality in the GStreamer pipeline.

* platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-destroy-persistent-license-expected.txt:
* platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-persistent-license-events-expected.txt:
* platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-retrieve-destroy-persistent-license-expected.txt:
* platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-retrieve-persistent-license-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[GCrypt] Only report libgcrypt errors when logging is enabled
zandobersek@gmail.com [Tue, 26 Sep 2017 08:38:16 +0000 (08:38 +0000)]
[GCrypt] Only report libgcrypt errors when logging is enabled
https://bugs.webkit.org/show_bug.cgi?id=177360

Reviewed by Xabier Rodriguez-Calvar.

* pal/crypto/gcrypt/Utilities.h:
(PAL::GCrypt::logError): Only print out the libgcrypt error on stderr
when logging is enabled at build-time, avoiding unnecessary output in
non-debugging use cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUpdate compressedTexImage3D to match the signature in the specification.
Ms2ger@igalia.com [Tue, 26 Sep 2017 08:13:38 +0000 (08:13 +0000)]
Update compressedTexImage3D to match the signature in the specification.
https://bugs.webkit.org/show_bug.cgi?id=177431

Reviewed by Sam Weinig.

No new tests: not much point in adding tests now; this method doesn't
do anything anyway.

* html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::compressedTexImage3D):
* html/canvas/WebGL2RenderingContext.h:
* html/canvas/WebGL2RenderingContext.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoSupport building JavaScriptCore with the Bionic C library
zandobersek@gmail.com [Tue, 26 Sep 2017 07:07:45 +0000 (07:07 +0000)]
Support building JavaScriptCore with the Bionic C library
https://bugs.webkit.org/show_bug.cgi?id=177427

Reviewed by Michael Catanzaro.

Source/JavaScriptCore:

When compiling with the Bionic C library, the MachineContext.h header
should enable the same code paths that are enabled for the GNU C library.

The Bionic C library defines the __BIONIC__ macro, but unlike other C
libraries that mimic the GNU one, it doesn't define __GLIBC__. So the
__BIONIC__ macro checks have to match the __GLIBC__ ones.

* runtime/MachineContext.h:
(JSC::MachineContext::stackPointer):
(JSC::MachineContext::framePointer):
(JSC::MachineContext::instructionPointer):
(JSC::MachineContext::argumentPointer<1>):
(JSC::MachineContext::llintInstructionPointer):

Source/WTF:

* wtf/Platform.h: Define HAVE_MACHINE_CONTEXT when __BIONIC__
is defined, i.e. when building with the Bionic C library.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[CMake] Use implicit include directories for Clang as well
zandobersek@gmail.com [Tue, 26 Sep 2017 07:05:46 +0000 (07:05 +0000)]
[CMake] Use implicit include directories for Clang as well
https://bugs.webkit.org/show_bug.cgi?id=177426

Reviewed by Michael Catanzaro.

In WebKitCompilerFlags.cmake, also gather and use the system
include directories for C and C++ build targets when compiling
with Clang. This fixes compilation errors when cross-building
WebKit with a Clang-based toolchain.

COMPILER_IS_GCC_OR_CLANG is used to check for GCC or Clang
compilers. That only checks for the C++ compiler, but it's not
reasonable to expect two widely different compilers being used
for C and C++ compilation.

* Source/cmake/WebKitCompilerFlags.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoFix the macOS WebCore CMake build
timothy_horton@apple.com [Tue, 26 Sep 2017 06:43:42 +0000 (06:43 +0000)]
Fix the macOS WebCore CMake build

* PlatformMac.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMake PolicyAction an encodable enum class
achristensen@apple.com [Tue, 26 Sep 2017 05:52:40 +0000 (05:52 +0000)]
Make PolicyAction an encodable enum class
https://bugs.webkit.org/show_bug.cgi?id=177480

Reviewed by Antti Koivisto.

Source/WebCore:

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::responseReceived):
(WebCore::DocumentLoader::continueAfterContentPolicy):
* loader/FrameLoaderTypes.h:
* loader/PolicyChecker.cpp:
(WebCore::PolicyChecker::checkNavigationPolicy):
(WebCore::PolicyChecker::checkNewWindowPolicy):

Source/WebKit:

* NetworkProcess/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::continueDecidePendingDownloadDestination):
(WebKit::DownloadManager::cancelDownload):
* NetworkProcess/NetworkCORSPreflightChecker.cpp:
(WebKit::NetworkCORSPreflightChecker::didReceiveResponseNetworkSession):
* NetworkProcess/NetworkDataTask.cpp:
(WebKit::NetworkDataTask::didReceiveResponse):
* NetworkProcess/NetworkDataTaskBlob.cpp:
(WebKit::NetworkDataTaskBlob::dispatchDidReceiveResponse):
* NetworkProcess/NetworkLoad.cpp:
(WebKit::NetworkLoad::~NetworkLoad):
(WebKit::NetworkLoad::continueDidReceiveResponse):
(WebKit::NetworkLoad::notifyDidReceiveResponse):
* NetworkProcess/PingLoad.cpp:
(WebKit::PingLoad::didReceiveResponseNetworkSession):
* NetworkProcess/capture/NetworkDataTaskReplay.cpp:
(WebKit::NetworkCapture::NetworkDataTaskReplay::didReceiveResponse):
* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(toNSURLSessionResponseDisposition):
* NetworkProcess/soup/NetworkDataTaskSoup.cpp:
(WebKit::NetworkDataTaskSoup::dispatchDidReceiveResponse):
* Scripts/webkit/messages.py:
(headers_for_type):
* UIProcess/WebFormSubmissionListenerProxy.h:
* UIProcess/WebFrameListenerProxy.h:
(WebKit::WebFrameListenerProxy::navigation): Deleted.
* UIProcess/WebFramePolicyListenerProxy.cpp:
(WebKit::WebFramePolicyListenerProxy::use):
(WebKit::WebFramePolicyListenerProxy::download):
(WebKit::WebFramePolicyListenerProxy::ignore):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::invalidatePolicyListener):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didReceivePolicyDecision):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:

Source/WebKitLegacy/mac:

* Plugins/WebPluginContainerCheck.mm:
(-[WebPluginContainerCheck _continueWithPolicy:]):
(-[WebPluginContainerCheck _isForbiddenFileLoad]):
* WebCoreSupport/WebFrameLoaderClient.mm:
(-[WebFramePolicyListener invalidate]):
(-[WebFramePolicyListener ignore]):
(-[WebFramePolicyListener download]):
(-[WebFramePolicyListener use]):
(-[WebFramePolicyListener continue]):
* WebView/WebPolicyDelegate.mm:
(-[WebPolicyDecisionListener use]):
(-[WebPolicyDecisionListener ignore]):
(-[WebPolicyDecisionListener download]):

Source/WebKitLegacy/win:

* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchDecidePolicyForResponse):
(WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
* WebFramePolicyListener.cpp:
(WebFramePolicyListener::use):
(WebFramePolicyListener::download):
(WebFramePolicyListener::ignore):
(WebFramePolicyListener::continueSubmit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222492 268f45cc-cd09-0410-ab3c-d52691b4dbfc