WebKit-https.git
5 years agoCrashes under RenderLayer::hitTestLayer under determinePrimarySnapshottedPlugIn()
simon.fraser@apple.com [Fri, 13 Feb 2015 19:04:12 +0000 (19:04 +0000)]
Crashes under RenderLayer::hitTestLayer under determinePrimarySnapshottedPlugIn()
https://bugs.webkit.org/show_bug.cgi?id=141551

Reviewed by Zalan Bujtas.

It's possible for a layout to dirty the parent frame's state, via the calls to
ownerElement()->scheduleSetNeedsStyleRecalc() that RenderLayerCompositor does when
iframes toggle their compositing mode.

That could cause FrameView::updateLayoutAndStyleIfNeededRecursive() to fail to
leave all the frames in a clean state. Later on, we could enter hit testing,
which calls document().updateLayout() on each frame's document. Document::updateLayout()
does layout on all ancestor documents, so in the middle of hit testing, we could
layout a subframe (dirtying an ancestor frame), then layout another frame, which
would forcing that ancestor to be laid out while we're hit testing it, thus
corrupting the RenderLayer tree while it's being iterated over.

Fix by having FrameView::updateLayoutAndStyleIfNeededRecursive() do a second
layout after laying out subframes, which most of the time will be a no-op.

Also add a stronger assertion, that this frame and all subframes are clean
at the end of FrameView::updateLayoutAndStyleIfNeededRecursive() for the
main frame.

Various existing frames tests hit the new assertion if the code change is removed,
so this is covered by existing tests.

* page/FrameView.cpp:
(WebCore::FrameView::needsStyleRecalcOrLayout):
(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive):
* page/FrameView.h:
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::willBeDestroyed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@180063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agodeterminePrimarySnapshottedPlugIn() should only traverse visible Frames
simon.fraser@apple.com [Fri, 13 Feb 2015 19:04:09 +0000 (19:04 +0000)]
determinePrimarySnapshottedPlugIn() should only traverse visible Frames
https://bugs.webkit.org/show_bug.cgi?id=141547
Part of rdar://problem/18445733.

Reviewed by Anders Carlsson.
Source/WebCore:

There's an expectation from clients that FrameView::updateLayoutAndStyleIfNeededRecursive()
updates layout in all frames, but it uses the widget tree, so only hits frames
that are parented via renderers (i.e. not display:none frames or their descendants).

Moving towards a future where we remove Widgets, fix by adding a FrameTree
traversal function that only finds rendered frames (those with an ownerRenderer).

Not testable.

* page/FrameTree.cpp:
(WebCore::FrameTree::firstRenderedChild):
(WebCore::FrameTree::nextRenderedSibling):
(WebCore::FrameTree::traverseNextRendered):
(printFrames):
* page/FrameTree.h:
* page/FrameView.cpp:
(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive):

Source/WebKit2:

Use FrameTree::traverseNextRendered() to avoid doing things in unrendered frames
which are not guaranteed to have been laid out.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::determinePrimarySnapshottedPlugIn):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@180062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agorun-jsc-stress-tests --remote should skip profiler tests
ossy@webkit.org [Fri, 13 Feb 2015 19:01:54 +0000 (19:01 +0000)]
run-jsc-stress-tests --remote should skip profiler tests
https://bugs.webkit.org/show_bug.cgi?id=141470

Reviewed by Filip Pizlo.

* Scripts/run-jsc-stress-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@180061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoGoogle doc spreadsheet reproducibly crashes when sorting
msaboff@apple.com [Fri, 13 Feb 2015 18:57:57 +0000 (18:57 +0000)]
Google doc spreadsheet reproducibly crashes when sorting
https://bugs.webkit.org/show_bug.cgi?id=141098

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Moved the stack check to before the callee registers are allocated in the
prologue() by movving it from the functionInitialization() macro.  This
way we can check the stack before moving the stack pointer, avoiding a
crash during a "call" instruction.  Before this change, we weren't even
checking the stack for program and eval execution.

Made a couple of supporting changes.

* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::llint_stack_check): We can't just go up one frame as we
may be processing an exception to an entry frame.

* llint/LowLevelInterpreter.asm:

* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:
(llint_throw_from_slow_path_trampoline): Changed method to get the vm
from the code block to not use the codeBlock, since we may need to
continue from an exception in a native function.

LayoutTests:

New test.

* js/regress-141098-expected.txt: Added.
* js/regress-141098.html: Added.
* js/script-tests/regress-141098.js: Added.
(probeAndRecurse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@180060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd an initializer list constructor to Deque
andersca@apple.com [Fri, 13 Feb 2015 18:46:04 +0000 (18:46 +0000)]
Add an initializer list constructor to Deque
https://bugs.webkit.org/show_bug.cgi?id=141565

Reviewed by Andreas Kling.

Source/WTF:

* wtf/Deque.h:
(WTF::inlineCapacity>::Deque):

Tools:

* TestWebKitAPI/Tests/WTF/Deque.cpp:
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@180059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoTimerBase::m_heapInsertionOrder calculation is racy
ap@apple.com [Fri, 13 Feb 2015 18:28:15 +0000 (18:28 +0000)]
TimerBase::m_heapInsertionOrder calculation is racy
https://bugs.webkit.org/show_bug.cgi?id=141554

Reviewed by Anders Carlsson.

Use an atomic increment.

* platform/Timer.cpp: (WebCore::TimerBase::setNextFireTime):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@180058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRe-indent Deque.h
andersca@apple.com [Fri, 13 Feb 2015 18:05:46 +0000 (18:05 +0000)]
Re-indent Deque.h

Rubber-stamped by Antti Koivisto.

* wtf/Deque.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@180055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWorkQueue should support concurrent queues
antti@apple.com [Fri, 13 Feb 2015 17:50:15 +0000 (17:50 +0000)]
WorkQueue should support concurrent queues
https://bugs.webkit.org/show_bug.cgi?id=141559

Reviewed by Anders Carlsson.

* DatabaseProcess/DatabaseProcess.cpp:
(WebKit::DatabaseProcess::DatabaseProcess):
* Platform/IPC/Connection.h:
* Platform/IPC/mac/ConnectionMac.mm:
(IPC::Connection::open):
* Platform/WorkQueue.cpp:
(WorkQueue::create):

    Also make create return a Ref.

(WorkQueue::WorkQueue):
* Platform/WorkQueue.h:

    Add queue type enum.

* Platform/efl/WorkQueueEfl.cpp:
(WorkQueue::platformInitialize):
* Platform/gtk/WorkQueueGtk.cpp:
(WorkQueue::platformInitialize):
* Platform/mac/WorkQueueMac.cpp:
(WorkQueue::platformInitialize):
* Shared/mac/SecItemShim.cpp:
(WebKit::SecItemShim::initializeConnection):
* Shared/mac/SecItemShim.h:
* UIProcess/Launcher/ProcessLauncher.cpp:
(WebKit::processLauncherWorkQueue):
* UIProcess/mac/SecItemShimProxy.cpp:
(WebKit::SecItemShimProxy::initializeConnection):
* UIProcess/mac/SecItemShimProxy.h:
* WebProcess/Plugins/PluginProcessConnectionManager.cpp:
(WebKit::PluginProcessConnectionManager::initializeConnection):
* WebProcess/Plugins/PluginProcessConnectionManager.h:
* WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::EventDispatcher):
(WebKit::EventDispatcher::initializeConnection):
* WebProcess/WebPage/EventDispatcher.h:
* WebProcess/WebPage/ViewUpdateDispatcher.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@180054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS] Refine GC behavior in response to process suspension and memory pressure.
akling@apple.com [Fri, 13 Feb 2015 17:38:50 +0000 (17:38 +0000)]
[iOS] Refine GC behavior in response to process suspension and memory pressure.
<https://webkit.org/b/141543>
<rdar://problem/19738024>

Reviewed by Geoffrey Garen.

Do an immediate full garbage collection when the web process is about to
be suspended (when another tab is moving to the foreground on iOS.)
This ensures that we make a best effort to reduce the process footprint
before we lose the ability to execute code.

When receiving a memory pressure warning, tell the garbage collector to
accelerate its next collection (by calling garbageCollectSoon().)
This gives us some confidence that a collection will happen within a
reasonable timeframe, but doesn't risk dooming us to a loop of endless
garbage collections.

* platform/cocoa/MemoryPressureHandlerCocoa.mm:
(WebCore::MemoryPressureHandler::platformReleaseMemory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@180053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoClean up the framework postprocessing phase
andersca@apple.com [Fri, 13 Feb 2015 17:35:53 +0000 (17:35 +0000)]
Clean up the framework postprocessing phase
https://bugs.webkit.org/show_bug.cgi?id=141544

Reviewed by Dan Bernstein.

Rename WK_API_AVAILABILITY_ENABLED to WK_FRAMEWORK_HEADER_POSTPROCESSING_ENABLED to better match what
it is we're doing. Also, rename the associated script. Remove a couple of now unnecessary #defines, and
change everything we can to be feature-based instead of OS based.

* Configurations/WebKit.xcconfig:
* Shared/API/Cocoa/WKFoundation.h:
* WebKit2.xcodeproj/project.pbxproj:
* mac/postprocess-framework-headers.sh: Renamed from Source/WebKit2/mac/rewrite-availability-macros.sh.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@180052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd some RELEASE_ASSERTs to try to catch crashes in StyleResolver::loadPendingImages
antti@apple.com [Fri, 13 Feb 2015 17:32:14 +0000 (17:32 +0000)]
Add some RELEASE_ASSERTs to try to catch crashes in StyleResolver::loadPendingImages
https://bugs.webkit.org/show_bug.cgi?id=141561

Reviewed by Simon Fraser.

One possibility is that loads triggered by loadPendingImages end up synchronously destroying or re-entering
style resolver. Try to catch these in release builds.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::~StyleResolver):
(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::loadPendingImages):
* css/StyleResolver.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@180051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoDiv having contentEditable and display:grid cannot be edited if it is empty.
changseok.oh@collabora.com [Fri, 13 Feb 2015 17:15:50 +0000 (17:15 +0000)]
Div having contentEditable and display:grid cannot be edited if it is empty.
https://bugs.webkit.org/show_bug.cgi?id=141465

Reviewed by Ryosuke Niwa.

Source/WebCore:

This bug is quite similar to webkit.org/b/141218. RenderGrid should be also treated as a candidate
for visible position as like RenderFlexibleBox. The only different situation between them is
that RenderGrid has a bug setting "0px" for logicalHeight when it is empty. RenderGrid should also have
a minimum height of a single line if it is editable as well as RenderFlexibleBox does.

Test: fast/events/key-events-in-editable-gridbox.html

* dom/Position.cpp:
(WebCore::Position::isCandidate):
(WebCore::Position::isRenderedCharacter):
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutGridItems):

LayoutTests:

This tests if an editable grid box can be reedited after erasing all texts in it.

* fast/events/key-events-in-editable-gridbox-expected.txt: Added.
* fast/events/key-events-in-editable-gridbox.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@180050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Win] Skip accessibility tests failing due to debug assertions.
bfulgham@apple.com [Fri, 13 Feb 2015 17:10:35 +0000 (17:10 +0000)]
[Win] Skip accessibility tests failing due to debug assertions.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@180049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[buildbot] Remove buildJSCTool cruft from master.cfg
ossy@webkit.org [Fri, 13 Feb 2015 14:37:08 +0000 (14:37 +0000)]
[buildbot] Remove buildJSCTool cruft from cfg
https://bugs.webkit.org/show_bug.cgi?id=141513

Reviewed by Alexey Proskuryakov.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunJavaScriptCoreTests):
(RunJavaScriptCoreTests.start):
(RunWebKitTests):
(RunWebKitTests.start):
(TestFactory.__init__):
(TestLeaksFactory.__init__):
(RunJavaScriptCoreTests.__init__): Deleted.
(RunWebKitTests.__init__): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@180039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION (r176262): Invalid cast in WebCore`WebCore::RootInlineBox::selectionTop
zalan@apple.com [Fri, 13 Feb 2015 12:48:09 +0000 (12:48 +0000)]
REGRESSION (r176262): Invalid cast in WebCore`WebCore::RootInlineBox::selectionTop
https://bugs.webkit.org/show_bug.cgi?id=138992

Reviewed by Dave Hyatt.

RenderRubyText requires the ancestor chain to be (RenderRubyAsInline | RenderRubyAsBlock) -> RenderRubyRun -> RenderRubyText.
This patch ensures that we create RenderRubyText for an <rt> element only when
the expected ancestor chain is guaranteed.

Source/WebCore:

Test: fast/ruby/crash-when-ruby-is-set-to-inline-block.html

* rendering/RenderElement.cpp:
(WebCore::RenderElement::createFor): treat inline-block <ruby> as block.
* rendering/RenderObject.h:
(WebCore::RenderObject::isRubyInline):
(WebCore::RenderObject::isRubyBlock):
(WebCore::RenderObject::isRuby): Deleted.
* rendering/RenderRuby.cpp:
(WebCore::isAnonymousRubyInlineBlock):
* rendering/RenderRuby.h: add support for is<RenderRubyAsBlock>(renderer) and for is<RenderRubyAsInline>(renderer)
The isRuby() method does not follow the is*() -> maps to one class pattern.
(WebCore::isRuby):
* rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::addChild):
(WebCore::RenderRubyRun::staticCreateRubyRun):

LayoutTests:

* fast/ruby/crash-when-ruby-is-set-to-inline-block-expected.txt: Added.
* fast/ruby/crash-when-ruby-is-set-to-inline-block.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@180038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[BMalloc] Add a FIXME comment for memory alignas
gyuyoung.kim@samsung.com [Fri, 13 Feb 2015 09:43:26 +0000 (09:43 +0000)]
[BMalloc] Add a FIXME comment for memory alignas
https://bugs.webkit.org/show_bug.cgi?id=141556

Reviewed by Csaba Osztrogonác.

* bmalloc/Chunk.h: Add a FIXME comment.
* bmalloc/LargeChunk.h: ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@180037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix the gperf related build issue on the WinCairo bot
ossy@webkit.org [Fri, 13 Feb 2015 09:19:04 +0000 (09:19 +0000)]
Fix the gperf related build issue on the WinCairo bot
https://bugs.webkit.org/show_bug.cgi?id=141507

Reviewed by Alex Christensen.

* platform/ColorData.gperf: Modified property svn:eol-style.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@180036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, remove empty directories.
ossy@webkit.org [Fri, 13 Feb 2015 09:15:14 +0000 (09:15 +0000)]
Unreviewed, remove empty directories.

.:

* ManualTests/qt: Removed.

Source/WebCore:

* loader/icon/wince: Removed.
* platform/graphics/wince: Removed.
* storage/wince: Removed.

Tools:

* DumpRenderTree/gtk: Removed.
* DumpRenderTree/gtk/fonts: Removed.
* DumpRenderTree/unix: Removed.
* DumpRenderTree/unix/TestNetscapePlugin: Removed.
* GtkLauncher: Removed.
* TestWebKitAPI/Tests/WebKitGtk: Removed.
* TestWebKitAPI/Tests/WebKitGtk/resources: Removed.
* WebKitTestRunner/WebKitTestRunnerAppTests: Removed.
* WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj: Removed.

Websites/perf.webkit.org:

* public/data: Removed.

Websites/webkit.org:

* blog/wp-includes/js/codepress: Removed.

LayoutTests:

* fast/forms/date-multiple-fields: Removed.
* fast/forms/datetimelocal-multiple-fields: Removed.
* fast/forms/month-multiple-fields: Removed.
* fast/forms/time-multiple-fields: Removed.
* fast/forms/week-multiple-fields: Removed.
* fast/js: Removed.
* http/tests/inspector-enabled: Removed.
* http/tests/inspector-enabled/resources: Removed.
* http/tests/inspector/appcache: Removed.
* http/tests/inspector/appcache/resources: Removed.
* http/tests/inspector/audits: Removed.
* http/tests/inspector/audits/resources: Removed.
* http/tests/inspector/indexeddb: Removed.
* http/tests/inspector/indexeddb/resources: Removed.
* http/tests/inspector/network: Removed.
* http/tests/inspector/network/resources: Removed.
* http/tests/inspector/resource-tree: Removed.
* http/tests/inspector/resource-tree/resources: Removed.
* http/tests/inspector/resources: Removed.
* http/tests/inspector/search: Removed.
* http/tests/inspector/search/resources: Removed.
* http/tests/inspector/stacktraces: Removed.
* http/tests/inspector/stacktraces/resources: Removed.
* http/tests/inspector/styles: Removed.
* http/tests/inspector/styles/resources: Removed.
* http/tests/inspector/websocket: Removed.
* http/tests/webgl/1.0.1: Removed.
* inspector-protocol/heap-profiler: Removed.
* inspector-protocol/heap-profiler/resources: Removed.
* inspector/console: Removed.
* inspector/console/resources: Removed.
* inspector/elements: Removed.
* inspector/elements/resources: Removed.
* inspector/profiler: Removed.
* inspector/runtime: Removed.
* inspector/styles: Removed.
* inspector/styles/resources: Removed.
* js/regress/resources: Removed.
* media/track/opera/track/webvtt/rendering/reftest/media: Removed.
* networkinformation: Removed.
* networkinformation/resources: Removed.
* networkinformation/script-tests: Removed.
* platform/efl-wk2/dom: Removed.
* platform/efl-wk2/dom/xhtml: Removed.
* platform/efl-wk2/inspector: Removed.
* platform/efl-wk2/tables: Removed.
* platform/efl-wk2/tables/mozilla: Removed.
* platform/gtk-wk1: Removed.
* platform/gtk-wk1/fast: Removed.
* platform/gtk-wk1/fast/css: Removed.
* platform/gtk-wk1/fast/loader: Removed.
* platform/gtk-wk1/fast/media: Removed.
* platform/gtk-wk1/fast/writing-mode: Removed.
* platform/gtk-wk1/http: Removed.
* platform/gtk-wk1/http/tests: Removed.
* platform/gtk-wk1/http/tests/cache: Removed.
* platform/gtk-wk1/http/tests/security: Removed.
* platform/gtk-wk1/http/tests/security/contentSecurityPolicy: Removed.
* platform/gtk-wk1/js: Removed.
* platform/gtk-wk1/js/dom: Removed.
* platform/gtk-wk1/loader: Removed.
* platform/gtk-wk1/scrollingcoordinator: Removed.
* platform/gtk-wk2/accessibility: Removed.
* platform/gtk-wk2/fast: Removed.
* platform/gtk-wk2/fast/events: Removed.
* platform/gtk-wk2/http: Removed.
* platform/gtk-wk2/http/tests: Removed.
* platform/gtk-wk2/http/tests/loading: Removed.
* platform/gtk-wk2/http/tests/misc: Removed.
* platform/gtk-wk2/http/tests/misc/authentication-redirect-1: Removed.
* platform/gtk-wk2/http/tests/misc/authentication-redirect-2: Removed.
* platform/gtk-wk2/http/tests/misc/authentication-redirect-4: Removed.
* platform/gtk-wk2/http/tests/security: Removed.
* platform/gtk-wk2/http/tests/security/401-logout: Removed.
* platform/gtk-wk2/http/tests/xmlhttprequest: Removed.
* platform/gtk-wk2/js: Removed.
* platform/gtk-wk2/js/dom: Removed.
* platform/gtk-wk2/plugins: Removed.
* platform/gtk-wk2/plugins/npruntime: Removed.
* platform/gtk/platform: Removed.
* platform/ios-simulator/editing/editability: Removed.
* platform/ios-simulator/editing/input: Removed.
* platform/ios-simulator/editing/secure-input: Removed.
* platform/ios-simulator/editing/shadow: Removed.
* platform/ios-simulator/editing/spelling: Removed.
* platform/ios-simulator/editing/text-iterator: Removed.
* platform/ios-simulator/editing/undo: Removed.
* platform/ios-simulator/editing/unsupported-content: Removed.
* platform/ios-simulator/fast/canvas/webgl: Removed.
* platform/ios-simulator/fast/css-grid-layout: Removed.
* platform/ios-simulator/fast/css/content: Removed.
* platform/ios-simulator/fast/css/image-orientation: Removed.
* platform/ios-simulator/fast/css/image-resolution: Removed.
* platform/ios-simulator/fast/css/style-scoped: Removed.
* platform/ios-simulator/fast/css3-text/css3-text-indent: Removed.
* platform/ios-simulator/fast/css3-text/css3-text-indent/getComputedStyle: Removed.
* platform/ios-simulator/fast/dom/Document: Removed.
* platform/ios-simulator/fast/dom/Document/CaretRangeFromPoint: Removed.
* platform/ios-simulator/fast/dom/Geolocation: Removed.
* platform/ios-simulator/fast/dom/HTMLAnchorElement: Removed.
* platform/ios-simulator/fast/dom/HTMLImageElement/sizes: Removed.
* platform/ios-simulator/fast/dom/MutationObserver: Removed.
* platform/ios-simulator/fast/dom/NavigatorContentUtils: Removed.
* platform/ios-simulator/fast/dom/Orientation: Removed.
* platform/ios-simulator/fast/dom/custom: Removed.
* platform/ios-simulator/fast/events/constructors: Removed.
* platform/ios-simulator/fast/events/scoped: Removed.
* platform/iphone-simulator: Removed.
* platform/iphone-simulator/fast: Removed.
* platform/iphone-simulator/fast/events: Removed.
* platform/mac-mavericks/fast/borders: Removed.
* platform/mac-wk2/fast/writing-mode: Removed.
* platform/mac-wk2/http/tests/plugins: Removed.
* platform/mac-wk2/js: Removed.
* platform/mac-wk2/js/dom: Removed.
* platform/mac-wk2/tiled-drawing/fixed: Removed.
* platform/mac-wk2/tiled-drawing/fixed-background: Removed.
* platform/mac-wk2/tiled-drawing/sticky: Removed.
* platform/mac/dom: Removed.
* platform/mac/dom/xhtml: Removed.
* platform/mac/fast/backgrounds/resources: Removed.
* platform/mac/media/W3C/audio: Removed.
* platform/mac/media/W3C/audio/canPlayType: Removed.
* platform/mac/platform/mac-wk2: Removed.
* platform/mac/platform/mac/editing/spelling: Removed.
* platform/mac/platform/mac/fast/forms: Removed.
* platform/win-wk2: Removed.
* platform/win-wk2/fast: Removed.
* platform/win-wk2/http: Removed.
* platform/win-wk2/platform: Removed.
* platform/win-wk2/svg: Removed.
* platform/win/canvas: Removed.
* platform/win/fast/xmlhttprequest: Removed.
* platform/win/loader: Removed.
* platform/wk2/tables: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@180035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove Windows cruft from Tools/Scripts/build-webkittestrunner
ossy@webkit.org [Fri, 13 Feb 2015 08:48:54 +0000 (08:48 +0000)]
Remove Windows cruft from Tools/Scripts/build-webkittestrunner
https://bugs.webkit.org/show_bug.cgi?id=141519

Reviewed by Alexey Proskuryakov.

* Scripts/build-webkittestrunner:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@180034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoCrash removing RemoteLayerTreeDisplayRefreshMonitor from the drawing area's map
timothy_horton@apple.com [Fri, 13 Feb 2015 06:48:03 +0000 (06:48 +0000)]
Crash removing RemoteLayerTreeDisplayRefreshMonitor from the drawing area's map
https://bugs.webkit.org/show_bug.cgi?id=141545
<rdar://problem/17712200>

Reviewed by Simon Fraser.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::windowScreenDidChange):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
windowScreenDidChange should take uint32_t, since that's what PlatformDisplayID is.

* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
RemoteLayerTreeDisplayRefreshMonitor is driven by the page's
RemoteLayerTreeDrawingArea. Because of this, we cannot have the same
sharing of DisplayRefreshMonitors that other platforms use.
In order to ensure that we get a unique DisplayRefreshMonitor
per-DrawingArea, give each page a unique DisplayID derived
from WebPage's unique ID.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@180031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Win] Mark some debug assertions.
bfulgham@apple.com [Fri, 13 Feb 2015 06:03:00 +0000 (06:03 +0000)]
[Win] Mark some debug assertions.

* platform/win/TestExpectations: Mark several debug assertions so
we don't end testing early.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@180030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Win] More media rebaselining.
bfulgham@apple.com [Fri, 13 Feb 2015 05:53:27 +0000 (05:53 +0000)]
[Win] More media rebaselining.

* platform/win/TestExpectations:
* platform/win/fast/css/focus-ring-exists-for-search-field-expected.png: Added.
* platform/win/fast/css/focus-ring-exists-for-search-field-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@180029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoCrashes under detectItemAroundHitTestResult when DataDetectors is not available
timothy_horton@apple.com [Fri, 13 Feb 2015 03:59:28 +0000 (03:59 +0000)]
Crashes under detectItemAroundHitTestResult when DataDetectors is not available
https://bugs.webkit.org/show_bug.cgi?id=141549
<rdar://problem/19180955>

Reviewed by Dan Bernstein.

* editing/mac/DataDetection.mm:
(WebCore::DataDetection::detectItemAroundHitTestResult):
Bail out from data detection if either of the relevant frameworks aren't loaded.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@180028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL] Need to have new baseline for some tests of fast/ruby since r172874
commit-queue@webkit.org [Fri, 13 Feb 2015 02:30:59 +0000 (02:30 +0000)]
[EFL] Need to have new baseline for some tests of fast/ruby since r172874
https://bugs.webkit.org/show_bug.cgi?id=141462

Unreviewed, EFL gardening. Rebaseline after r172874

Patch by Hunseop Jeong <hs85.jeong@samsung.com> on 2015-02-12

* platform/efl/TestExpectations:
* platform/efl/fast/ruby/bopomofo-expected.png: Added.
* platform/efl/fast/ruby/bopomofo-expected.txt:
* platform/efl/fast/ruby/bopomofo-letter-spacing-expected.png: Added.
* platform/efl/fast/ruby/bopomofo-letter-spacing-expected.txt:
* platform/efl/fast/ruby/bopomofo-rl-expected.png: Added.
* platform/efl/fast/ruby/bopomofo-rl-expected.txt:
* platform/efl/fast/ruby/ruby-beforeafter-expected.png:
* platform/efl/fast/ruby/ruby-beforeafter-expected.txt:
* platform/efl/fast/ruby/ruby-length-expected.png:
* platform/efl/fast/ruby/ruby-length-expected.txt:
* platform/efl/fast/ruby/ruby-run-break-expected.png:
* platform/efl/fast/ruby/ruby-run-break-expected.txt:
* platform/efl/fast/ruby/ruby-runs-expected.png:
* platform/efl/fast/ruby/ruby-runs-expected.txt:
* platform/efl/fast/ruby/ruby-runs-spans-expected.png:
* platform/efl/fast/ruby/ruby-runs-spans-expected.txt:
* platform/efl/fast/ruby/ruby-trailing-expected.png:
* platform/efl/fast/ruby/ruby-trailing-expected.txt:
* platform/efl/fast/ruby/rubyDOM-insert-rt-expected.png:
* platform/efl/fast/ruby/rubyDOM-insert-rt-expected.txt:
* platform/efl/fast/ruby/rubyDOM-insert-text1-expected.png:
* platform/efl/fast/ruby/rubyDOM-insert-text1-expected.txt:
* platform/efl/fast/ruby/rubyDOM-insert-text2-expected.png:
* platform/efl/fast/ruby/rubyDOM-insert-text2-expected.txt:
* platform/efl/fast/ruby/rubyDOM-insert-text3-expected.png:
* platform/efl/fast/ruby/rubyDOM-insert-text3-expected.txt:
* platform/efl/fast/ruby/rubyDOM-remove-rt1-expected.png:
* platform/efl/fast/ruby/rubyDOM-remove-rt1-expected.txt:
* platform/efl/fast/ruby/rubyDOM-remove-rt2-expected.png:
* platform/efl/fast/ruby/rubyDOM-remove-rt2-expected.txt:
* platform/efl/fast/ruby/rubyDOM-remove-text1-expected.png:
* platform/efl/fast/ruby/rubyDOM-remove-text1-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@180027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS Media] Audio should hide timeline scrubber until playback starts
dino@apple.com [Fri, 13 Feb 2015 01:04:12 +0000 (01:04 +0000)]
[iOS Media] Audio should hide timeline scrubber until playback starts
https://bugs.webkit.org/show_bug.cgi?id=141542
<rdar://problem/19820685>

Reviewed by Eric Carlson.

We regressed from the system behaviour in iOS 7, where the timeline
scrubber for an audio element is not shown until the user starts
playback.

* Modules/mediacontrols/mediaControlsiOS.css:
(video::-webkit-media-controls-panel): Fix the alignment of the flexbox.
(audio::-webkit-media-controls-status-display): Add the style for the status display.
* Modules/mediacontrols/mediaControlsiOS.js:
(ControllerIOS.prototype.configureInlineControls): Start hidden if we are an <audio>.
(ControllerIOS.prototype.configureFullScreenControls): Drive by comment change.
(ControllerIOS.prototype.setPlaying): Unhide the timeline.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@180024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Win] Unreviewed updates to test expectations to reduce failures on Windows bots.
bfulgham@apple.com [Fri, 13 Feb 2015 01:00:17 +0000 (01:00 +0000)]
[Win] Unreviewed updates to test expectations to reduce failures on Windows bots.

* platform/win/TestExpectations: Mark a number of time-outs for Media tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@180023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoCrash under RemoteLayerTreeDrawingArea::flushLayers() when closing a tab
timothy_horton@apple.com [Fri, 13 Feb 2015 00:49:59 +0000 (00:49 +0000)]
Crash under RemoteLayerTreeDrawingArea::flushLayers() when closing a tab
https://bugs.webkit.org/show_bug.cgi?id=141541

Reviewed by Benjamin Poulain.

* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::flushLayers):
The WebPage pointer can become stale between when it is retrieved
and dereferenced. Retrieve it by ID inside the dispatch_async block
instead of outside of it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@180022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRe-baselines after http://trac.webkit.org/changeset/180018
bdakin@apple.com [Fri, 13 Feb 2015 00:13:23 +0000 (00:13 +0000)]
Re-baselines after trac.webkit.org/changeset/180018

* platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-div-latched-div-with-handler-expected.txt:
* platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-div-latched-mainframe-with-handler-expected.txt:
* platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe-with-handler-expected.txt:
* platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-select-latched-mainframe-with-handler-expected.txt:
* platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-select-latched-select-with-handler-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@180021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoDrop the quirks-mode exception for CSS MIME types
cdumez@apple.com [Thu, 12 Feb 2015 23:23:55 +0000 (23:23 +0000)]
Drop the quirks-mode exception for CSS MIME types
https://bugs.webkit.org/show_bug.cgi?id=141501

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Drop the quirks-mode exception for CSS MIME types.
This matches Firefox's behavior.

This patch is based on the following Blink revision:
http://src.chromium.org/viewvc/blink?view=revision&revision=189669

Tests:
- http/tests/misc/css-accept-any-type.html
- http/tests/security/cross-origin-css.html

* css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::parseAuthorStyleSheet):
* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::setCSSStyleSheet):
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::cachedResourceContent):
* loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::sheetText):
(WebCore::CachedCSSStyleSheet::canUseSheet):
* loader/cache/CachedCSSStyleSheet.h:

LayoutTests:

Update a couple of layout tests now that we dropped the quirks-mode
exception for CSS MIME types.

* http/tests/misc/css-accept-any-type-expected.txt:
* http/tests/misc/css-accept-any-type.html:
* http/tests/security/cross-origin-css-expected.txt:
* http/tests/security/cross-origin-css.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@180020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION: Should not send wheel events with a delta of 0
bdakin@apple.com [Thu, 12 Feb 2015 23:09:05 +0000 (23:09 +0000)]
REGRESSION: Should not send wheel events with a delta of 0
https://bugs.webkit.org/show_bug.cgi?id=141537
-and corresponding-
rdar://problem/18903118

Reviewed by Simon Fraser.

Source/WebCore:

This code should not have been removed entirely to accommodate rubber-banding, it
just needs to return false instead of true in order to allow the MayBegin and
Ended phases to be handled by the ElasticityController.
* dom/Element.cpp:
(WebCore::Element::dispatchWheelEvent):

LayoutTests:

* platform/mac-wk2/tiled-drawing/scrolling/wheel-events-with-no-delta-expected.txt: Added.
* platform/mac-wk2/tiled-drawing/scrolling/wheel-events-with-no-delta.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@180018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS Media] Implement 3-style media timeline (buffered, played, unavailable)
dino@apple.com [Thu, 12 Feb 2015 22:20:39 +0000 (22:20 +0000)]
[iOS Media] Implement 3-style media timeline (buffered, played, unavailable)
https://bugs.webkit.org/show_bug.cgi?id=141526
<rdar://problem/19603337>

Reviewed by Eric Carlson and Antoine Quint.

Implement a 3-style media scrubber for iOS. This draws white for
the region that has been played (before the playhead), black
for the region that is buffered, and is hollow for the rest.

* Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.updateProgress): Update progress is now completely
shared between OS X and iOS. This calls the implementation specific
drawTimelineBackground.
(Controller.prototype.drawTimelineBackground): Move the OS X code to here.
* Modules/mediacontrols/mediaControlsiOS.css:
(audio::-webkit-media-controls-timeline): New styles for the timeline. Updated thumb image, etc.
(video::-webkit-media-controls-timeline::-webkit-slider-runnable-track):
(audio::-webkit-media-controls-timeline::-webkit-slider-thumb):
(audio::-webkit-media-controls-timeline::-webkit-slider-thumb:active):
(video::-webkit-media-controls-time-remaining-display):
* Modules/mediacontrols/mediaControlsiOS.js:
(ControllerIOS): Create a globally unique canvas context name in the constructor.
(ControllerIOS.prototype.createControls): Set the background of the timeline to a canvas.
(ControllerIOS.prototype.addRoundedRect): Helper function.
(ControllerIOS.prototype.drawTimelineBackground): Draw the 3-style content.
(ControllerIOS.prototype.updateProgress): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@180013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSimplify the initialization of BytecodeGenerator a bit
benjamin@webkit.org [Thu, 12 Feb 2015 22:20:18 +0000 (22:20 +0000)]
Simplify the initialization of BytecodeGenerator a bit
https://bugs.webkit.org/show_bug.cgi?id=141505

Reviewed by Anders Carlsson.

* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
* bytecompiler/BytecodeGenerator.h:
Setup the default initialization at the declaration level
instead of the constructor.

Also made m_scopeNode and m_codeType const to make it explicit
that they are invariant after construction.

* parser/Nodes.cpp:
* runtime/Executable.cpp:
Remove 2 useless #includes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@180012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMove the generators for GetScope and SkipScope to the common core in DFGSpeculativeJIT
benjamin@webkit.org [Thu, 12 Feb 2015 22:18:26 +0000 (22:18 +0000)]
Move the generators for GetScope and SkipScope to the common core in DFGSpeculativeJIT
https://bugs.webkit.org/show_bug.cgi?id=141506

Reviewed by Michael Saboff.

The generators for the nodes GetScope and SkipScope were
completely identical between 32 and 64bits.

This patch moves the duplicated code to DFGSpeculativeJIT.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetScope):
(JSC::DFG::SpeculativeJIT::compileSkipScope):
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@180010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWebKit persistent cache uses a lot of threads
antti@apple.com [Thu, 12 Feb 2015 21:31:21 +0000 (21:31 +0000)]
WebKit persistent cache uses a lot of threads
https://bugs.webkit.org/show_bug.cgi?id=141520

Reviewed by Andreas Kling.

Parallel retrieves are limited but stores are not. We may end up with lots of backround io
dispatch queue threads if they don't complete fast enough.

This patch adds pending state for write operations similar to what retrieves already have
and limits to number of active operations.

* NetworkProcess/cache/NetworkCacheStorage.h:

    Combine StoreOperation and UpdateOperation and rename to WriteOperation.
    Rename RetrieveOperation to ReadOperation.
    The idea is to emphasize that these are disk operations.

* NetworkProcess/cache/NetworkCacheStorageCocoa.mm:
(WebKit::NetworkCacheStorage::dispatchReadOperation):
(WebKit::NetworkCacheStorage::dispatchPendingReadOperations):
(WebKit::retrieveFromMemory):
(WebKit::NetworkCacheStorage::retrieve):
(WebKit::NetworkCacheStorage::store):
(WebKit::NetworkCacheStorage::update):
(WebKit::NetworkCacheStorage::dispatchPendingWriteOperations):

    Only allow 3 parallel writes.

(WebKit::NetworkCacheStorage::dispatchFullWriteOperation):
(WebKit::NetworkCacheStorage::dispatchHeaderWriteOperation):

    More informative names.

(WebKit::NetworkCacheStorage::dispatchRetrieveOperation): Deleted.
(WebKit::NetworkCacheStorage::dispatchPendingRetrieveOperations): Deleted.
(WebKit::retrieveActive): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@180008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix some Mac linker warnings
commit-queue@webkit.org [Thu, 12 Feb 2015 21:18:41 +0000 (21:18 +0000)]
Fix some Mac linker warnings
https://bugs.webkit.org/show_bug.cgi?id=141522

Patch by Daniel Bates <dabates@apple.com> on 2015-02-12
Reviewed by Alex Christensen.

Following <https://trac.webkit.org/changeset/179945>, the linker warns about the following hidden WebCore symbols:

ld: warning: cannot export hidden symbol __ZN7WebCore20LogNotYetImplementedE from /.../OpenSource/WebKitBuild/WebCore.build/Debug/WebCore.build/Objects-normal/x86_64/Logging.o
ld: warning: cannot export hidden symbol _wkCreateURLPasteboardFlavorTypeName from /.../OpenSource/WebKitBuild/WebCore.build/Debug/WebCore.build/Objects-normal/x86_64/WebCoreSystemInterface.o
ld: warning: cannot export hidden symbol _wkCreateURLNPasteboardFlavorTypeName from /.../OpenSource/WebKitBuild/WebCore.build/Debug/WebCore.build/Objects-normal/x86_64/WebCoreSystemInterface.o

* WebCore.exp.in: Remove symbols for functions wkCreateURLPasteboardFlavorTypeName and wkCreateURLNPasteboardFlavorTypeName.
* platform/Logging.h: Export WTFLogChannel for LogNotYetImplemented, which is referenced from
notImplementedLoggingChannel() in file NotImplemented.cpp. We make use of the associated
header, NotImplemented.h, in both WebKit and WebKit2.
* platform/mac/WebCoreSystemInterface.mm: Remove declarations for functions
wkCreateURLPasteboardFlavorTypeName and wkCreateURLNPasteboardFlavorTypeName that
were inadvertently not removed in r25494.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@180007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWeb Inspector: Crash inspecting styles of element with mutated stylesheet
commit-queue@webkit.org [Thu, 12 Feb 2015 20:47:10 +0000 (20:47 +0000)]
Web Inspector: Crash inspecting styles of element with mutated stylesheet
https://bugs.webkit.org/show_bug.cgi?id=141451

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-02-12
Reviewed by Timothy Hatcher.

Source/WebCore:

Test: inspector/css/stylesheet-with-mutations.html

* css/CSSStyleSheet.h:
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::CSSStyleSheet):
(WebCore::CSSStyleSheet::didMutateRules):
Keep a flag on the CSSStyleSheet to know when it has had a rule
mutation from the contents.

* inspector/InspectorStyleSheet.h:
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::reparseStyleSheet):
When completely replacing the stylesheet's contents, we will have
destroyed any previous rules, so clear the has mutations flag.

(WebCore::selectorsFromSource):
Previously there was a mismatch between the rules the parsed
SourceData had, and the actual CSSSelectors we were iterating.
We use the SourceData so we can get the exact user authored
text instead of generated longhands from actualy selector objects.
Add an ASSERT and bail to catch and more gracefully handle
any possible mismatches in the future.

(WebCore::InspectorStyleSheet::styleSheetMutated):
(WebCore::InspectorStyleSheet::ensureParsedDataReady):
When a CSSStyleSheet has been mutated beyond the inspector's
knowledge right now, fall back to readonly generated selectors.
We should better handle this in the future:
<https://webkit.org/b/141450> Web Inspector: Better support for CSSOM StyleSheet mutations (insertRule/deleteRule)

LayoutTests:

* inspector/css/stylesheet-with-mutations-expected.txt: Added.
* inspector/css/stylesheet-with-mutations.html: Added.
Previously this test would crash, or in debug builds show one
of the two selectors in the rule.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@180005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWeb Inspector: add keyboard shortcut to enable/disable all breakpoints
burg@cs.washington.edu [Thu, 12 Feb 2015 20:30:48 +0000 (20:30 +0000)]
Web Inspector: add keyboard shortcut to enable/disable all breakpoints
https://bugs.webkit.org/show_bug.cgi?id=141527

Reviewed by Joseph Pecoraro.

* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Views/DebuggerSidebarPanel.js:
(WebInspector.DebuggerSidebarPanel): Bind Command/Control + Y to toggle breakpoints button.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@180004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, rolling out r179987.
commit-queue@webkit.org [Thu, 12 Feb 2015 20:00:50 +0000 (20:00 +0000)]
Unreviewed, rolling out r179987.
https://bugs.webkit.org/show_bug.cgi?id=141525

caused debug tests to fail (Requested by alexchristensen on
#webkit).

Reverted changeset:

"[CSS Grid Layout] Invalid initialization of track sizes with
non spanning grid items"
https://bugs.webkit.org/show_bug.cgi?id=140763
http://trac.webkit.org/changeset/179987

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@180003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemoved empty directory.
achristensen@apple.com [Thu, 12 Feb 2015 19:57:03 +0000 (19:57 +0000)]
Removed empty directory.

* WinCELauncher: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@180002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWeb Inspector: support adding and removing timelines to the timeline sidebar panel...
burg@cs.washington.edu [Thu, 12 Feb 2015 19:00:03 +0000 (19:00 +0000)]
Web Inspector: support adding and removing timelines to the timeline sidebar panel and overview
https://bugs.webkit.org/show_bug.cgi?id=138434

Reviewed by Timothy Hatcher.

A timeline recording's timelines should not be static. This patch adds relevant machinery to
dynamically add and remove timelines from the Timeline model object and its various views.

From the model side, this is a simple change that adds TimelineAdded and TimelineRemoved events.
The timeline views and timeline sidebar require more extensive changes to support this functionality.
Instead of keeping a fixed set of timeline tree elements, the sidebar view now adds and removes
tree elements to reflect the available timelines for the displayed timeline recording.

This change also includes several minor cleanups, such as appending 'Element' to view properties that
are DOM elements, and renaming TimelineContentView to TimelineRecordingContentView.

* UserInterface/Controllers/TimelineManager.js:
(WebInspector.TimelineManager.prototype._loadNewRecording):
Populate predefined network, layout, and script timelines here after constructing the recording.

* UserInterface/Main.html:
* UserInterface/Models/Timeline.js:
Move hardcoded class names and localized strings to these base class methods. This is not implemented
using overridden methods because not all timeline types have their own subclasses. Add a dummy
implementation of saveIdentityToCookie() to avoid warnings when saving sidebar panel selection state.

(WebInspector.Timeline.prototype.get type):
(WebInspector.Timeline.prototype.get displayName): Added.
(WebInspector.Timeline.prototype.get iconClassName): Added.
(WebInspector.Timeline.prototype.addRecord):
* UserInterface/Models/TimelineRecording.js:
(WebInspector.TimelineRecording):
(WebInspector.TimelineRecording.prototype.addTimeline.set timeline): Added.
(WebInspector.TimelineRecording.prototype.addTimeline): Added.
(WebInspector.TimelineRecording.prototype.removeTimeline.get this): Added.
(WebInspector.TimelineRecording.prototype.removeTimeline): Added.
* UserInterface/Views/ContentView.js:
(WebInspector.ContentView):
* UserInterface/Views/LayoutTimelineView.css:
(.sidebar > .panel.navigation.timeline.timeline-recording-content-view-showing .navigation-sidebar-panel-content-tree-outline.layout .item .subtitle):
(.sidebar > .panel.navigation.timeline.timeline-content-view-showing .navigation-sidebar-panel-content-tree-outline.layout .item .subtitle): Deleted.
* UserInterface/Views/LayoutTimelineView.js:
(WebInspector.LayoutTimelineView.prototype._treeElementSelected):
(WebInspector.LayoutTimelineView.prototype._closeStatusButtonClicked):
* UserInterface/Views/NavigationSidebarPanel.js:
(WebInspector.NavigationSidebarPanel.prototype.saveStateToCookie): Fix error message formatting.
(WebInspector.NavigationSidebarPanel.prototype._updateFilter):
* UserInterface/Views/NetworkTimelineView.css:
(.sidebar > .panel.navigation.timeline.timeline-recording-content-view-showing .navigation-sidebar-panel-content-tree-outline.network .item .subtitle):
(.sidebar > .panel.navigation.timeline.timeline-content-view-showing .navigation-sidebar-panel-content-tree-outline.network .item .subtitle): Deleted.
* UserInterface/Views/NetworkTimelineView.js:
(WebInspector.NetworkTimelineView.prototype._closeStatusButtonClicked):
* UserInterface/Views/ScriptTimelineView.css:
(.sidebar > .panel.navigation.timeline.timeline-recording-content-view-showing .navigation-sidebar-panel-content-tree-outline.script .item .subtitle):
(.sidebar > .panel.navigation.timeline.timeline-content-view-showing .navigation-sidebar-panel-content-tree-outline.script .item .subtitle): Deleted.
* UserInterface/Views/ScriptTimelineView.js:
(WebInspector.ScriptTimelineView.prototype._treeElementSelected):
(WebInspector.ScriptTimelineView.prototype._closeStatusButtonClicked):
* UserInterface/Views/TimelineOverview.js:
Convert this class to use the representedObject class pattern. It manages its own mapping from timelines
to overview graph views. Append 'Element' to some properties holding DOM elements.
(WebInspector.TimelineOverview):
(WebInspector.TimelineOverview.prototype.get visibleDuration):
(WebInspector.TimelineOverview.prototype.reset):
(WebInspector.TimelineOverview.prototype.updateLayout):
(WebInspector.TimelineOverview.prototype._handleScrollEvent):
(WebInspector.TimelineOverview.prototype._handleWheelEvent):
(WebInspector.TimelineOverview.prototype._timelineRemoved):
(WebInspector.TimelineOverview.prototype.updateLayoutIfNeeded):
(WebInspector.TimelineOverview.prototype._timeRangeSelectionChanged):
* UserInterface/Views/TimelineRecordingContentView.css: Renamed from Source/WebInspectorUI/UserInterface/Views/TimelineContentView.css.
Remove hard-coded top offsets and heights that need to be dynamically calculated.
(.content-view.timeline-recording > .timeline-overview):
(.content-view.timeline-recording > .view-container):
(.content-view.timeline-recording > .view-container > .timeline-view > .data-grid td):
(.content-view.timeline-recording > .view-container > .timeline-view > .data-grid table.data):
* UserInterface/Views/TimelineRecordingContentView.js: Renamed from Source/WebInspectorUI/UserInterface/Views/TimelineContentView.js.
Manage timeline views and path components dynamically. Adjust view heights as necessary. Append 'Element'
to some properties holding DOM elements.
(WebInspector.TimelineRecordingContentView):
(WebInspector.TimelineRecordingContentView.prototype.showOverviewTimelineView):
(WebInspector.TimelineRecordingContentView.prototype.showTimelineViewForTimeline):
(WebInspector.TimelineRecordingContentView.prototype.get allowedNavigationSidebarPanels):
(WebInspector.TimelineRecordingContentView.prototype.get supportsSplitContentBrowser):
(WebInspector.TimelineRecordingContentView.prototype.get navigationItems):
(WebInspector.TimelineRecordingContentView.prototype.get currentTimelineView):
(WebInspector.TimelineRecordingContentView.prototype.shown):
(WebInspector.TimelineRecordingContentView.prototype.hidden):
(WebInspector.TimelineRecordingContentView.prototype.filterDidChange):
(WebInspector.TimelineRecordingContentView.prototype.updateLayout):
(WebInspector.TimelineRecordingContentView.prototype.saveToCookie):
(WebInspector.TimelineRecordingContentView.prototype.restoreFromCookie):
(WebInspector.TimelineRecordingContentView.prototype.get matchTreeElementAgainstCustomFilters.checkTimeBounds):
(WebInspector.TimelineRecordingContentView.prototype.get matchTreeElementAgainstCustomFilters):
(WebInspector.TimelineRecordingContentView.prototype._pathComponentSelected):
(WebInspector.TimelineRecordingContentView.prototype._timelineViewSelectionPathComponentsDidChange):
(WebInspector.TimelineRecordingContentView.prototype._showTimelineView):
(WebInspector.TimelineRecordingContentView.prototype._update):
(WebInspector.TimelineRecordingContentView.prototype._updateTimes):
(WebInspector.TimelineRecordingContentView.prototype._startUpdatingCurrentTime):
(WebInspector.TimelineRecordingContentView.prototype._stopUpdatingCurrentTime):
(WebInspector.TimelineRecordingContentView.prototype._capturingStarted):
(WebInspector.TimelineRecordingContentView.prototype._capturingStopped):
(WebInspector.TimelineRecordingContentView.prototype._debuggerPaused):
(WebInspector.TimelineRecordingContentView.prototype._debuggerResumed):
Fix a minor regression where we make a useless call to stop updating the time.

(WebInspector.TimelineRecordingContentView.prototype._recordingTimesUpdated):
(WebInspector.TimelineRecordingContentView.prototype._clearTimeline):
(WebInspector.TimelineRecordingContentView.prototype._timelineRemoved):
(WebInspector.TimelineRecordingContentView.prototype._timelineCountChanged):
(WebInspector.TimelineRecordingContentView.prototype._recordingReset):
(WebInspector.TimelineRecordingContentView.prototype._recordingUnloaded):
(WebInspector.TimelineRecordingContentView.prototype._timeRangeSelectionChanged):
* UserInterface/Views/TimelineSidebarPanel.css:
(.sidebar > .panel.navigation.timeline.timeline-recording-content-view-showing > .content):
(.sidebar > .panel.navigation.timeline.timeline-content-view-showing > .content): Deleted.
* UserInterface/Views/TimelineSidebarPanel.js:
Manage timeline tree elements dynamically. Adjust view heights as necessary. Append 'Element'
to some properties holding DOM elements. Keep track of the displayed recording and view explicitly.
(WebInspector.TimelineSidebarPanel):
(WebInspector.TimelineSidebarPanel.prototype.shown):
(WebInspector.TimelineSidebarPanel.prototype.showDefaultContentView):
(WebInspector.TimelineSidebarPanel.prototype.treeElementForRepresentedObject.looselyCompareRepresentedObjects):
(WebInspector.TimelineSidebarPanel.prototype.showTimelineOverview):
(WebInspector.TimelineSidebarPanel.prototype.updateFilter):
(WebInspector.TimelineSidebarPanel.prototype.matchTreeElementAgainstCustomFilters):
(WebInspector.TimelineSidebarPanel.prototype.canShowDifferentContentView):
(WebInspector.TimelineSidebarPanel.prototype.saveStateToCookie):
(WebInspector.TimelineSidebarPanel.prototype.get if):
(WebInspector.TimelineSidebarPanel.prototype._contentBrowserCurrentContentViewDidChange):
(WebInspector.TimelineSidebarPanel.prototype._recordingCountChanged):
(WebInspector.TimelineSidebarPanel.prototype._recordingSelected):
(WebInspector.TimelineSidebarPanel.prototype._recordingLoaded):
(WebInspector.TimelineSidebarPanel.prototype._timelineRemoved):
(WebInspector.TimelineSidebarPanel.prototype._timelineCountChanged):
(WebInspector.TimelineSidebarPanel.createTimelineTreeElement): Deleted.
(WebInspector.TimelineSidebarPanel.prototype.restoreStateFromCookie):
* UserInterface/Views/TimelineView.css:
(.panel.navigation.timeline.timeline-recording-content-view-showing > .content > .navigation-sidebar-panel-content-tree-outline):
(.panel.navigation.timeline.timeline-content-view-showing > .content > .navigation-sidebar-panel-content-tree-outline): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@180001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoPerf dashboard should show the results of A/B testing
rniwa@webkit.org [Thu, 12 Feb 2015 18:50:53 +0000 (18:50 +0000)]
Perf dashboard should show the results of A/B testing
https://bugs.webkit.org/show_bug.cgi?id=141500

Reviewed by Chris Dumez.

Added the support for fetching test_runs for a specific test group in /api/runs/, and used it in the
analysis task page to fetch results for each test group.

Merged App.createChartData into App.Manifest.fetchRunsWithPlatformAndMetric so that App.BuildRequest
can use the formatter.

* public/api/runs.php:
(fetch_runs_for_config_and_test_group): Added.
(fetch_runs_for_config): Just return the fetched rows since main will format them with RunsGenerator.
(main): Use fetch_runs_for_config_and_test_group to fetch rows when a test group id is specified. Also
use RunsGenerator to format results.
(RunsGenerator): Added.
(RunsGenerator::__construct): Added.
(RunsGenerator::add_runs): Added.
(RunsGenerator::format_run): Moved.
(RunsGenerator::parse_revisions_array): Moved.

* public/v2/analysis.js:
(App.TestGroup): Fixed a typo. The property on a test group that refers to an analysis task is "task".
(App.TestGroup._fetchChartData): Added. Fetches all A/B testing results for this group.
(App.BuildRequest.configLetter): Renamed from config since this returns a letter that identifies the
configuration associated with this build request such as "A" and "B".
(App.BuildRequest.statusLabel): Added the missing label for failed build requests.
(App.BuildRequest.url): Added. Returns the URL associated with this build request.
(App.BuildRequest._meanFetched): Added. Retrieve the mean and the build number for this request via
_fetchChartData.

* public/v2/app.js:
(App.Pane._fetch): Set chartData directly here.
(App.Pane._updateMovingAverageAndEnvelope): Renamed from _computeChartData. No longer sets chartData
now that it's done in App.Pane._fetch.
(App.AnalysisTaskController._fetchedRuns): Updated per createChartData merge.

* public/v2/data.js:
(Measurement.prototype.buildId): Added.
(TimeSeries.prototype.findPointByBuild): Added.

* public/v2/index.html: Fixed a bug that build status URL was broken. We can't use link-to helper since
url is not an Ember routed path.

* public/v2/manifest.js:
(App.Manifest.fetchRunsWithPlatformAndMetric): Takes testGroupId as the third argument. Merged
App.createChartData here so that App.BuildRequest can use the formatter

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@180000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWeb Inspector: Large background image fails to load in inspector
burg@cs.washington.edu [Thu, 12 Feb 2015 18:42:21 +0000 (18:42 +0000)]
Web Inspector: Large background image fails to load in inspector
https://bugs.webkit.org/show_bug.cgi?id=141405

Reviewed by Timothy Hatcher.

Convert base64-encoded resource data to binary data using Uint8Array and Blobs.
Use object URLs for blobs instead of data URLs when setting image 'src' attribute
and in @font-face urls. This conversion happens when the backend indicates that
resource content is base64-encoded.

Update image and font clients of resource-fetching functionality so that they use
object URLs correctly. Add some plumbing so that Blobs can be constructed with
the correct mime-type.

* UserInterface/Base/Utilities.js:
(decodeBase64ToBlob): Added.
* UserInterface/Models/CSSStyleSheet.js:
(WebInspector.CSSStyleSheet.prototype.get mimeType): Added.
* UserInterface/Models/Resource.js:
(WebInspector.Resource.prototype.createObjectURL): Added.
(WebInspector.Resource.prototype.getImageSize.imageDidLoad):
(WebInspector.Resource.prototype.getImageSize):
(WebInspector.Resource.prototype.get contentURL): Deleted.
* UserInterface/Models/Script.js:
(WebInspector.Script.prototype.get mimeType): Added.
* UserInterface/Models/SourceCode.js:
(WebInspector.SourceCode.prototype.get mimeType): Added.
(WebInspector.SourceCode.prototype._processContent):
(WebInspector.SourceCode.prototype.get contentIsBase64Encoded): Deleted.
* UserInterface/Models/SourceCodeRevision.js:
(WebInspector.SourceCodeRevision):
(WebInspector.SourceCodeRevision.prototype.copy):
(WebInspector.SourceCodeRevision.prototype.get contentIsBase64Encoded): Deleted.
(WebInspector.SourceCodeRevision.prototype.set contentIsBase64Encoded): Deleted.
* UserInterface/Views/FontResourceContentView.js:
(WebInspector.FontResourceContentView.prototype.hidden):
(WebInspector.FontResourceContentView.prototype.closed):
* UserInterface/Views/ImageResourceContentView.js:
(WebInspector.ImageResourceContentView.prototype.contentAvailable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agorun-jsc-stress-tests --remote should be able add the necessary libraries to the bundl...
ossy@webkit.org [Thu, 12 Feb 2015 18:35:12 +0000 (18:35 +0000)]
run-jsc-stress-tests --remote should be able add the necessary libraries to the bundle on Linux
https://bugs.webkit.org/show_bug.cgi?id=141202

Reviewed by Darin Adler.

* Scripts/run-jsc-stress-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION(r178060): empty arguments are passed when logging to system console
burg@cs.washington.edu [Thu, 12 Feb 2015 18:21:00 +0000 (18:21 +0000)]
REGRESSION(r178060): empty arguments are passed when logging to system console
https://bugs.webkit.org/show_bug.cgi?id=141511

Reviewed by Timothy Hatcher.

* page/PageConsoleClient.cpp:
(WebCore::PageConsoleClient::messageWithTypeAndLevel): Change premature move to copyRef.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Win] Test bot infrastructure should not try to find/use old Safari DLLs
bfulgham@apple.com [Thu, 12 Feb 2015 17:48:00 +0000 (17:48 +0000)]
[Win] Test bot infrastructure should not try to find/use old Safari DLLs
https://bugs.webkit.org/show_bug.cgi?id=141517

Reviewed by Anders Carlsson.

We do not need to locate or use the DLL's that came with Safari, so stop
failing when we cannot find them. Also remove some old Qt cruft from this
script.

* BuildSlaveSupport/built-product-archive:
(archiveBuiltProduct):
(extractBuiltProduct):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Win] [64-bit] Work around MSVC2013 Runtime Bug
bfulgham@apple.com [Thu, 12 Feb 2015 17:20:07 +0000 (17:20 +0000)]
[Win] [64-bit] Work around MSVC2013 Runtime Bug
https://bugs.webkit.org/show_bug.cgi?id=141498
<rdar://problem/19803642>

Reviewed by Anders Carlsson.

Disable FMA3 instruction use in the MSVC math library to
work around a VS2013 runtime crash. We can remove this
workaround when we switch to VS2015.

Source/JavaScriptCore:

* API/tests/testapi.c: Call _set_FMA3_enable(0) to disable
FMA3 support.
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: Add new files.
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters: Ditto.
* JavaScriptCore.vcxproj/JavaScriptCoreDLL.cpp: Added.
* JavaScriptCore.vcxproj/jsc/DLLLauncherMain.cpp: Call _set_FMA3_enable(0)
to disable FMA3 support.
* jsc.cpp: Ditto.
* testRegExp.cpp: Ditto.

Source/WebKit/win:

* WebKitDLL.cpp: Call _set_FMA3_enable(0) to disable FMA3 support.

Source/WTF:

* WTF.vcxproj/WTF.vcxproj: Add new files.
* WTF.vcxproj/WTF.vcxproj.filters: Ditto.
* wtf/win/WTFDLL.cpp: Added.

Tools:

* DumpRenderTree/cg/ImageDiffCG.cpp: Call _set_FMA3_enable(0) to
disable FMA3 support.
* DumpRenderTree/win/DumpRenderTree.cpp: Ditto.
* DumpRenderTree/win/ImageDiffCairo.cpp: Ditto.
* DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
* Scripts/webkitperl/httpd.pm: Ditto.
* TestWebKitAPI/win/main.cpp: Ditto.
* WinLauncher/Common.cpp: Ditto.
* win/DLLLauncher/DLLLauncherMain.cpp: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Win] Unreviewed debug build fix after r179980.
achristensen@apple.com [Thu, 12 Feb 2015 16:48:08 +0000 (16:48 +0000)]
[Win] Unreviewed debug build fix after r179980.

* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::currentViewportSize):
Explicitly call constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, EFL gardening. Two tests have been failing since r148090.
gyuyoung.kim@samsung.com [Thu, 12 Feb 2015 16:35:54 +0000 (16:35 +0000)]
Unreviewed, EFL gardening. Two tests have been failing since r148090.

* platform/efl/TestExpectations: Skip 2 failure tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agov2 UI should adjust the number of ticks on dashboards based on screen size
rniwa@webkit.org [Thu, 12 Feb 2015 16:32:58 +0000 (16:32 +0000)]
v2 UI should adjust the number of ticks on dashboards based on screen size
https://bugs.webkit.org/show_bug.cgi?id=141502

Reviewed by Chris Dumez.

* public/v2/interactive-chart.js:
(App.InteractiveChartComponent._updateDimensionsIfNeeded): Compute the number of ticks based on the
content size.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, EFL gardening.
gyuyoung.kim@samsung.com [Thu, 12 Feb 2015 16:25:34 +0000 (16:25 +0000)]
Unreviewed, EFL gardening.

* platform/efl/TestExpectations: Mark two tests failing since r177664.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[CSS Grid Layout] Invalid initialization of track sizes with non spanning grid items
svillar@igalia.com [Thu, 12 Feb 2015 16:14:16 +0000 (16:14 +0000)]
[CSS Grid Layout] Invalid initialization of track sizes with non spanning grid items
https://bugs.webkit.org/show_bug.cgi?id=140763

Reviewed by Antti Koivisto.

Source/WebCore:

Content sized tracks with non-spanning grid items were not
properly sized because the growth limit was sometimes infinity
(-1) after calling resolveContentBasedTrackSizingFunctions() when
it should not. This patch adds an special initialization phase for
non-spanning grid items as the new track sizing algorithm
describes.

Granted, that was handled in the old algorithm in
distributeSpaceToTracks() as a special case. The problem is that
it regressed after the optimization added in r173868 because that
method is no longer called when the space to distribute is 0.

That's why we could fix this by allowing calls to
distributeSpaceToTracks() with spaceToDistribute>=0 but by fixing
it with an explicit initialization our implementation becomes
closer to the new algorithm and the initialization is now explicit
in the code instead of a side effect of calling
distributeSpaceToTracks() with no space to be distributed. It also
brings a slight performance improvement as we save sorts and hash
lookups.

I also took the change to add caching to several GridTrackSize
methods that were hot on the profiler (each one accounted for ~1%
of the total time, now they account for ~0.3% each).

Test: fast/css-grid-layout/grid-initialize-span-one-items.html

* rendering/RenderGrid.cpp:
(WebCore::GridItemWithSpan::span): New helper method for ASSERTs.
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
Exclude non spanning grid items from the calls to
resolveContentBasedTrackSizingFunctionsForItems().
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForNonSpanningItems):
New method to resolve track sizes only using non-spanning grid
items.
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems):
Ensure that it isn't called for non-spanning grid items.
* rendering/RenderGrid.h:
* rendering/style/GridTrackSize.h:
(WebCore::GridTrackSize::GridTrackSize): Cache return values.
(WebCore::GridTrackSize::setLength): Ditto.
(WebCore::GridTrackSize::setMinMax): Ditto.
(WebCore::GridTrackSize::cacheMinMaxTrackBreadthTypes): New method
that caches the return values for hasXXXTrackBreadth() methods.
(WebCore::GridTrackSize::hasMinOrMaxContentMinTrackBreadth): Use
the cached return value.
(WebCore::GridTrackSize::hasMaxContentMaxTrackBreadth): Ditto.
(WebCore::GridTrackSize::hasMinContentMaxTrackBreadth): Ditto.
(WebCore::GridTrackSize::hasMinOrMaxContentMaxTrackBreadth): Ditto.
(WebCore::GridTrackSize::hasMaxContentMinTrackBreadth): Ditto.
(WebCore::GridTrackSize::hasMinContentMinTrackBreadth): Ditto.
(WebCore::GridTrackSize::hasMinContentMinTrackBreadthAndMinOrMaxContentMaxTrackBreadth):
Ditto.
(WebCore::GridTrackSize::hasMaxContentMinTrackBreadthAndMaxContentMaxTrackBreadth):
Ditto.

LayoutTests:

* fast/css-grid-layout/grid-content-sized-columns-resolution-expected.txt:
* fast/css-grid-layout/grid-content-sized-columns-resolution.html:
* fast/css-grid-layout/grid-initialize-span-one-items-expected.txt: Added.
* fast/css-grid-layout/grid-initialize-span-one-items.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agorun-jsc-stress-tests should accept remote host config from JSON file
ossy@webkit.org [Thu, 12 Feb 2015 16:08:04 +0000 (16:08 +0000)]
run-jsc-stress-tests should accept remote host config from JSON file
https://bugs.webkit.org/show_bug.cgi?id=141509

Reviewed by Michael Saboff.

* Scripts/run-javascriptcore-tests:
(runJSCStressTests):
* Scripts/run-jsc-stress-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove the USE(ACCELERATED_COMPOSITING) guard from the
zandobersek@gmail.com [Thu, 12 Feb 2015 14:25:30 +0000 (14:25 +0000)]
Remove the USE(ACCELERATED_COMPOSITING) guard from the
MediaPlayerPrivateGStreamerBase destructor.

The guard was removed in r163079. It was still defined through CMake
for the EFL and GTK ports when the guarded code was introduced in
r172828. In r171741 the macro was finally removed for the GTK and EFL
ports as well, but the guards for the affected code weren't updated
so TextureMapperPlatformLayer::Client::platformLayerWillBeDestroyed()
wasn't being called anymore.

Rubber-stamped by Philippe Normand.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::~MediaPlayerPrivateGStreamerBase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] Add API to allow overriding the default color chooser implementation
carlosgc@webkit.org [Thu, 12 Feb 2015 08:50:00 +0000 (08:50 +0000)]
[GTK] Add API to allow overriding the default color chooser implementation
https://bugs.webkit.org/show_bug.cgi?id=98935

Reviewed by Gustavo Noronha Silva.

Source/WebKit2:

Add API to allow the user to override the default UI of color
chooser. Similar to the file chooser API, a new run-color-chooser
signal is added to WebKitWebView that passes a WebKitColorChooserRequest
parameter to the signal.

Initial patch by Arnaud Renevier <a.renevier@sisa.samsung.com>.

* PlatformGTK.cmake: Add new files to compilation.
* UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::createColorPicker): Create a
WebKitColorChooser is the view widget is a WebKitWebView or a
WebColorPicker otherwise,
* UIProcess/API/gtk/WebKitColorChooser.cpp: Added.
(WebKit::WebKitColorChooser::create):
(WebKit::WebKitColorChooser::WebKitColorChooser):
(WebKit::WebKitColorChooser::~WebKitColorChooser):
(WebKit::WebKitColorChooser::endPicker): Chain up to parent class
when not having a request, or finish the request if we have one.
(WebKit::WebKitColorChooser::colorChooserRequestFinished):
(WebKit::WebKitColorChooser::colorChooserRequestRGBAChanged):
(WebKit::WebKitColorChooser::showColorPicker): Create a new
WebKitColorChooserRequest and emit WebKitWebView::run-color-chooser.
If the signal is not handled, fallback to the default color
chooser dialog implemented by the parent class.
* UIProcess/API/gtk/WebKitColorChooser.h: Added.
* UIProcess/API/gtk/WebKitColorChooserRequest.cpp: Added.
(webkitColorChooserRequestGetProperty):
(webkitColorChooserRequestSetProperty):
(webkit_color_chooser_request_class_init):
(webkit_color_chooser_request_set_rgba):
(webkit_color_chooser_request_get_rgba):
(webkit_color_chooser_request_get_element_rectangle):
(webkit_color_chooser_request_finish):
(webkit_color_chooser_request_cancel):
(webkitColorChooserRequestCreate):
* UIProcess/API/gtk/WebKitColorChooserRequest.h: Added.
* UIProcess/API/gtk/WebKitColorChooserRequestPrivate.h: Added.
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_class_init): Add run-color-chooser signal.
(webkitWebViewEmitRunColorChooser): Emit run-color-chooser signal.
* UIProcess/API/gtk/WebKitWebView.h:
* UIProcess/API/gtk/WebKitWebViewPrivate.h:
* UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt: Add new symbols.
* UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add new section for WebKitColorChooserRequest.
* UIProcess/API/gtk/webkit2.h: Include WebKitColorChooserRequest.h

Tools:

Add a color chooser implementation for MiniBrowser using
GtkPopover when the GTK+ version is recent enough.
And a test case to check the new color chooser API.

* MiniBrowser/gtk/BrowserWindow.c:
(colorChooserRGBAChanged):
(popoverColorClosed):
(colorChooserRequestFinished):
(runColorChooserCallback):
(browserWindowConstructed):
* TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
(testWebViewColorChooserRequest):
(beforeAll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAX: Undeprecate ios-simulator accessibility tests
cfleizach@apple.com [Thu, 12 Feb 2015 07:08:48 +0000 (07:08 +0000)]
AX: Undeprecate ios-simulator accessibility tests
https://bugs.webkit.org/show_bug.cgi?id=141407

Reviewed by Daniel Bates.

Undeprecate ios accessibility tests.
Modified one failing test (svg-group-element-with-title.html) slightly to get it to pass.

* platform/ios-sim-deprecated/accessibility: Removed.
* platform/ios-sim-deprecated/accessibility/accessibility-aria-table-children-expected.txt: Removed.
* platform/ios-sim-deprecated/accessibility/accessibility-aria-table-children.html: Removed.
* platform/ios-sim-deprecated/accessibility/accessibility-crash-in-axcontainer-expected.txt: Removed.
* platform/ios-sim-deprecated/accessibility/accessibility-crash-in-axcontainer.html: Removed.
* platform/ios-sim-deprecated/accessibility/accessibility-hint-expected.txt: Removed.
* platform/ios-sim-deprecated/accessibility/accessibility-hint.html: Removed.
* platform/ios-sim-deprecated/accessibility/aria-label-with-internal-text-expected.txt: Removed.
* platform/ios-sim-deprecated/accessibility/aria-label-with-internal-text.html: Removed.
* platform/ios-sim-deprecated/accessibility/aria-pressed-state-expected.txt: Removed.
* platform/ios-sim-deprecated/accessibility/aria-pressed-state.html: Removed.
* platform/ios-sim-deprecated/accessibility/centerpoint-expected.txt: Removed.
* platform/ios-sim-deprecated/accessibility/centerpoint.html: Removed.
* platform/ios-sim-deprecated/accessibility/disabled-states-expected.txt: Removed.
* platform/ios-sim-deprecated/accessibility/disabled-states.html: Removed.
* platform/ios-sim-deprecated/accessibility/dom-focus-fires-on-correct-element-expected.txt: Removed.
* platform/ios-sim-deprecated/accessibility/dom-focus-fires-on-correct-element.html: Removed.
* platform/ios-sim-deprecated/accessibility/element-paths-expected.txt: Removed.
* platform/ios-sim-deprecated/accessibility/element-paths.html: Removed.
* platform/ios-sim-deprecated/accessibility/file-upload-button-expected.txt: Removed.
* platform/ios-sim-deprecated/accessibility/file-upload-button.html: Removed.
* platform/ios-sim-deprecated/accessibility/focus-change-notifications-expected.txt: Removed.
* platform/ios-sim-deprecated/accessibility/focus-change-notifications.html: Removed.
* platform/ios-sim-deprecated/accessibility/header-elements-expected.txt: Removed.
* platform/ios-sim-deprecated/accessibility/header-elements.html: Removed.
* platform/ios-sim-deprecated/accessibility/identifier-expected.txt: Removed.
* platform/ios-sim-deprecated/accessibility/identifier.html: Removed.
* platform/ios-sim-deprecated/accessibility/internal-link-expected.txt: Removed.
* platform/ios-sim-deprecated/accessibility/internal-link.html: Removed.
* platform/ios-sim-deprecated/accessibility/landmark-type-expected.txt: Removed.
* platform/ios-sim-deprecated/accessibility/landmark-type.html: Removed.
* platform/ios-sim-deprecated/accessibility/link-with-images-text-expected.txt: Removed.
* platform/ios-sim-deprecated/accessibility/link-with-images-text.html: Removed.
* platform/ios-sim-deprecated/accessibility/link-with-only-image-expected.txt: Removed.
* platform/ios-sim-deprecated/accessibility/link-with-only-image.html: Removed.
* platform/ios-sim-deprecated/accessibility/math-expected.txt: Removed.
* platform/ios-sim-deprecated/accessibility/math.html: Removed.
* platform/ios-sim-deprecated/accessibility/mixed-checkboxes-expected.txt: Removed.
* platform/ios-sim-deprecated/accessibility/mixed-checkboxes.html: Removed.
* platform/ios-sim-deprecated/accessibility/no-child-link-header-expected.txt: Removed.
* platform/ios-sim-deprecated/accessibility/no-child-link-header.html: Removed.
* platform/ios-sim-deprecated/accessibility/non-contiguous-link-expected.txt: Removed.
* platform/ios-sim-deprecated/accessibility/non-contiguous-link.html: Removed.
* platform/ios-sim-deprecated/accessibility/out-of-bounds-child-access-expected.txt: Removed.
* platform/ios-sim-deprecated/accessibility/out-of-bounds-child-access.html: Removed.
* platform/ios-sim-deprecated/accessibility/password-value-expected.txt: Removed.
* platform/ios-sim-deprecated/accessibility/password-value.html: Removed.
* platform/ios-sim-deprecated/accessibility/placeholder-value-expected.txt: Removed.
* platform/ios-sim-deprecated/accessibility/placeholder-value.html: Removed.
* platform/ios-sim-deprecated/accessibility/popup-button-value-label-expected.txt: Removed.
* platform/ios-sim-deprecated/accessibility/popup-button-value-label.html: Removed.
* platform/ios-sim-deprecated/accessibility/progressbar-expected.txt: Removed.
* platform/ios-sim-deprecated/accessibility/progressbar.html: Removed.
* platform/ios-sim-deprecated/accessibility/radio-button-expected.txt: Removed.
* platform/ios-sim-deprecated/accessibility/radio-button.html: Removed.
* platform/ios-sim-deprecated/accessibility/secure-text-field-expected.txt: Removed.
* platform/ios-sim-deprecated/accessibility/secure-text-field.html: Removed.
* platform/ios-sim-deprecated/accessibility/selected-buttons-expected.txt: Removed.
* platform/ios-sim-deprecated/accessibility/selected-buttons.html: Removed.
* platform/ios-sim-deprecated/accessibility/selected-text-expected.txt: Removed.
* platform/ios-sim-deprecated/accessibility/selected-text.html: Removed.
* platform/ios-sim-deprecated/accessibility/svg-group-element-with-title-expected.txt: Removed.
* platform/ios-sim-deprecated/accessibility/svg-group-element-with-title.html: Removed.
* platform/ios-sim-deprecated/accessibility/svg-path-crash-expected.txt: Removed.
* platform/ios-sim-deprecated/accessibility/svg-path-crash.html: Removed.
* platform/ios-sim-deprecated/accessibility/tab-role-expected.txt: Removed.
* platform/ios-sim-deprecated/accessibility/tab-role.html: Removed.
* platform/ios-sim-deprecated/accessibility/table-cell-for-row-col-expected.txt: Removed.
* platform/ios-sim-deprecated/accessibility/table-cell-for-row-col.html: Removed.
* platform/ios-sim-deprecated/accessibility/table-cell-ranges-expected.txt: Removed.
* platform/ios-sim-deprecated/accessibility/table-cell-ranges.html: Removed.
* platform/ios-sim-deprecated/accessibility/table-with-mismatch-column-count-in-initial-section-expected.txt: Removed.
* platform/ios-sim-deprecated/accessibility/tables-lists-expected.txt: Removed.
* platform/ios-sim-deprecated/accessibility/tables-lists.html: Removed.
* platform/ios-sim-deprecated/accessibility/text-line-no-ignored-elements-expected.txt: Removed.
* platform/ios-sim-deprecated/accessibility/text-line-no-ignored-elements.html: Removed.
* platform/ios-sim-deprecated/accessibility/text-marker-list-item-expected.txt: Removed.
* platform/ios-sim-deprecated/accessibility/text-marker-list-item.html: Removed.
* platform/ios-sim-deprecated/accessibility/text-marker-validation-expected.txt: Removed.
* platform/ios-sim-deprecated/accessibility/text-marker-validation.html: Removed.
* platform/ios-sim-deprecated/accessibility/text-role-expected.txt: Removed.
* platform/ios-sim-deprecated/accessibility/text-role.html: Removed.
* platform/ios-sim-deprecated/accessibility/textfield-in-axvalue-expected.txt: Removed.
* platform/ios-sim-deprecated/accessibility/textfield-in-axvalue.html: Removed.
* platform/ios-sim-deprecated/accessibility/toggle-button-expected.txt: Removed.
* platform/ios-sim-deprecated/accessibility/toggle-button.html: Removed.
* platform/ios-sim-deprecated/accessibility/url-test-expected.txt: Removed.
* platform/ios-sim-deprecated/accessibility/url-test.html: Removed.
* platform/ios-simulator/accessibility: Copied from LayoutTests/platform/ios-sim-deprecated/accessibility.
* platform/ios-simulator/accessibility/svg-group-element-with-title.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoStreamline and simplify SVGSVGElement and related classes
darin@apple.com [Thu, 12 Feb 2015 05:09:25 +0000 (05:09 +0000)]
Streamline and simplify SVGSVGElement and related classes
https://bugs.webkit.org/show_bug.cgi?id=141463

Reviewed by Antti Koivisto.

* dom/Document.cpp: Removed unneeded include of SVGSVGElement.h.
* loader/FrameLoader.cpp: Ditto.
* rendering/RenderBoxModelObject.cpp: Ditto.
* rendering/svg/RenderSVGForeignObject.cpp: Ditto.
* svg/SVGImageElement.cpp: Ditto.
* svg/SVGMarkerElement.cpp: Ditto.
* svg/SVGPathElement.cpp: Ditto.
* svg/SVGPatternElement.cpp: Ditto.
* svg/SVGTransform.cpp: Ditto.

* page/FrameView.cpp:
(WebCore::FrameView::scrollToAnchor): Updated to call the SVGSVGElement function
named scrollToAnchor (was setupInitialView). Also refactored to avoid repeating
the expression frame().document() so often.

* platform/graphics/FloatSize.h: Added operator/.

* svg/SVGDocument.cpp:
(WebCore::SVGDocument::rootElement): Rearranged to use early return.
(WebCore::SVGDocument::zoomAndPanEnabled): Ditto.
(WebCore::SVGDocument::startPan): Ditto. Also used FloatPoint math instead
of breaking things apart into x and y.
(WebCore::SVGDocument::updatePan): Ditto.

* svg/SVGDocument.h: Removed some unneeded includes and forward declarations.
Moved function bodies out of the class to make it more readable. Renamed
m_translate to m_panningOffset and made it a FloatSize instead of FloatPoint.

* svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::startAnimations): Use a modern for loop
and update since timeContainer() now returns a reference.

* svg/SVGSVGElement.cpp: Removed many unneeded includes.
(WebCore::SVGSVGElement::SVGSVGElement): Moved initialization of scalars to
the class definition. Updated since m_timerContainer is a Ref (later should
change it to be a std::unique_ptr or just directly contained in SVGSVGElement).
(WebCore::SVGSVGElement::~SVGSVGElement): Removed comment that doesn't say much,
but is worded in a confusing way.
(WebCore::SVGSVGElement::contentScriptType): Use NeverDestroyed instead of
DEPRECATED_DEFINE_STATIC_LOCAL.
(WebCore::SVGSVGElement::contentStyleType): Ditto.
(WebCore::SVGSVGElement::viewport): Streamlined a bit.
(WebCore::SVGSVGElement::pixelUnitToMillimeterX): Ditto.
(WebCore::SVGSVGElement::pixelUnitToMillimeterY): Ditto.
(WebCore::SVGSVGElement::currentView): Changed to return a reference.
(WebCore::SVGSVGElement::frameForCurrentScale): Added. Helper for the two
functions below.
(WebCore::SVGSVGElement::currentScale): Updated to use frameForCurrentScale.
(WebCore::SVGSVGElement::setCurrentScale): Ditto.
(WebCore::SVGSVGElement::setCurrentTranslate): Optimized the case where there
is no change to the translation. Also changed the data member's name to
m_currentTranslate to more directly match the DOM API naming.
(WebCore::SVGSVGElement::parseAttribute): Simplified the parsing a bit, and
changed to pass a reference to SVGZoomAndPan::parseAttribute.
(WebCore::SVGSVGElement::svgAttributeChanged): Tweaked formatting and removed
code that converts the renderer pointer to a RenderObject* unnecessarily.
(WebCore::SVGSVGElement::suspendRedraw): Removed FIXME about implementing this,
since we don't really plan to do that.
(WebCore::SVGSVGElement::unsuspendRedraw): Ditto.
(WebCore::SVGSVGElement::unsuspendRedrawAll): Ditto.
(WebCore::SVGSVGElement::forceRedraw): Ditto.
(WebCore::SVGSVGElement::collectIntersectionOrEnclosureList): Changed return
type to Ref, and pass in a function instead of an enumeration value.
(WebCore::SVGSVGElement::getIntersectionList): Updated for above.
(WebCore::SVGSVGElement::getEnclosureList): Ditto.
(WebCore::SVGSVGElement::checkIntersection): Use && instead of early return
for the null check.
(WebCore::SVGSVGElement::checkEnclosure): Ditto.
(WebCore::SVGSVGElement::createSVGLength): Use initialization list syntax
for greater brevity.
(WebCore::SVGSVGElement::createSVGAngle): Ditto.
(WebCore::SVGSVGElement::createSVGPoint): Ditto.
(WebCore::SVGSVGElement::createSVGMatrix): Ditto.
(WebCore::SVGSVGElement::createSVGRect): Ditto.
(WebCore::SVGSVGElement::createSVGTransform): Removed unneeded explicit
constructor invocation.
(WebCore::SVGSVGElement::createSVGTransformFromMatrix): Removed unneeded cast.
(WebCore::SVGSVGElement::insertedInto): Updated since timeContainer() now
returns a reference.
(WebCore::SVGSVGElement::setCurrentTime): Use isfinite instead of isnan, so
we won't store infinity as the current time.
(WebCore::SVGSVGElement::currentViewBoxRect): Renamed locals and changed
to use initializer lists for brevity.
(WebCore::SVGSVGElement::currentViewportSize): Streamlined code by using
initializer lists, using local variables only for things used more than once,
and using the / operator defined above.
(WebCore::SVGSVGElement::viewBoxToViewTransform): Use the concatenate function
in a way that is more straightforward, rather than doing it with a temporary.
(WebCore::SVGSVGElement::scrollToAnchor): Renamed this from
setupInitialView.
(WebCore::SVGSVGElement::inheritViewAttributes): Changed this to work with
references rather than pointers.
(WebCore::SVGSVGElement::getElementById): Use getAllElementsById as the
FIXME comment suggested for better efficiency when there are a lot of descendants
of the <svg> element at the cost of making it less efficient if there are
a lot of elements all with the desired ID, but not inside the <svg> element.
(WebCore::SVGSVGElement::isValid): Moved here from the header.

* svg/SVGSVGElement.h: Removed unneeded forward declarations. Moved the
animated properties to the top of the file, then other DOM, the other
public members. Changed return types to references and Ref. Moved
function bodies out of the class definition. Made createSVGNumber inline.

* svg/SVGViewElement.cpp: Removed unneeded includes.
(WebCore::SVGViewElement::isSupportedAttribute): Deleted.
(WebCore::SVGViewElement::parseAttribute): Changed to not rely on
isSupportedAttribute. Eventually I will do this in all the SVG classes.

* svg/SVGViewSpec.cpp: Removed unneeded include of SVGSVGElement.h.
(WebCore::SVGViewSpec::parseViewSpec): Updated for change in the name
of the parse function in the SVGZoomAndPan class.

* svg/SVGZoomAndPan.cpp:
(WebCore::SVGZoomAndPan::isKnownAttribute): Deleted.
(WebCore::SVGZoomAndPan::addSupportedAttributes): Deleted.
(WebCore::SVGZoomAndPan::parse): Renamed from parseZoomAndPan since
this is a member of the SVGZoomAndPan class and also has an argument
of SVGZoomAndPanType.
(WebCore::SVGZoomAndPan::parseAttributeValue): Added. Helper so the
template function is not so big. Also write it in a simpler way.
(WebCore::SVGZoomAndPan::ref): Deleted.
(WebCore::SVGZoomAndPan::deref): Deleted.
(WebCore::SVGZoomAndPan::setZoomAndPan): Deleted.

* svg/SVGZoomAndPan.h: Removed unneeded includes. Reformatted the enum.
Moved function bodies out of the class definition. Removed many unneeded
functions.

* svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::insertedInto): Updated since timeContainer
now returns a reference rather than a pointer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, EFL gardenging. Need to mark pointer/hover media query tests as failure.
gyuyoung.kim@samsung.com [Thu, 12 Feb 2015 04:37:17 +0000 (04:37 +0000)]
Unreviewed, EFL gardenging. Need to mark pointer/hover media query tests as failure.
These tests have been failed since r179055.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSVGUseElement follow-up improvements
darin@apple.com [Thu, 12 Feb 2015 03:53:48 +0000 (03:53 +0000)]
SVGUseElement follow-up improvements
https://bugs.webkit.org/show_bug.cgi?id=141382

Reviewed by Antti Koivisto.

Source/WebCore:

* loader/cache/CachedSVGDocumentClient.h: Removed unneeded forward declaration.

* page/EventHandler.cpp: Removed unneeded include of SVGUseElement.h.
* rendering/svg/RenderSVGViewportContainer.cpp: Ditto.

* svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::clearTargetDependencies): Removed too-specific
check that assumed that SVG elements in shadow trees are always for <use> elements.
This amounted to an unneeded optimization that could be removed with no bad effect.

* svg/SVGElement.cpp:
(WebCore::SVGElement::correspondingElement): Removed the assertions so this could
be used more freely outside of cases where the shadow tree state is fully consistent.
It's fine to have this just be a mechanical getter; there's nothing super-tricky
here that needs to be caught by the assertion.
(WebCore::SVGElement::title): Removed unneeded special handling for titles inside
the shadow tree.

* svg/SVGGElement.cpp:
(WebCore::SVGGElement::create): Added an overload that doesn't require explicitly
passing in the tag name.
* svg/SVGGElement.h: Ditto.
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::create): Ditto.
* svg/SVGSVGElement.h: Ditto.

* svg/SVGUseElement.cpp: Removed a lot of unneeded includes.
(WebCore::SVGUseElement::SVGUseElement): Removed code to initialize some booleans.
We do that in the class definition now.
(WebCore::SVGUseElement::create): Removed the code that calls the
ensureUserAgentShadowRoot function unconditionally. That's properly done when
needed; no need to do it here.
(WebCore::SVGUseElement::~SVGUseElement): Removed unneeded code to destroy the
shadow tree (that happens automatically) and simplified the code to stop loading
the external document.
(WebCore::SVGUseElement::isSupportedAttribute): Deleted.
(WebCore::SVGUseElement::parseAttribute): Simplified this. Removed assumptions
about the intersection of various sets of attributes, and also removed the
isSupportedAttribute function. This seems to serve no purpose here, or in any
other SVG element class. I plan to remove it everywhere over time.
(WebCore::isWellFormedDocument): Deleted.
(WebCore::SVGUseElement::insertedInto): Simplified code by removing all the
special cases during initial parsing, and did the invalidation here rather than
deferring it to didNotifySubtreeInsertions. Added a call to the new function,
updateExternalDocument, since that won't do anything when the element is not
in a document.
(WebCore::SVGUseElement::didNotifySubtreeInsertions): Deleted.
(WebCore::SVGUseElement::removedFrom): Added code to call clearShadowTree and
updateExternalDocument. Both are efficient when doing nothing, and both are
appropriate since the element is no longer in a document.
(WebCore::SVGUseElement::referencedDocument): Deleted. No longer needed.
(WebCore::SVGUseElement::externalDocument): Streamlined the logic here, removing
multiple unneeded checks.
(WebCore::SVGUseElement::transferSizeAttributesToTargetClone): Renamed since
"target clone" is clear enough within this class, without explicitly stating
"shadow tree". All the clones are in the shadow tree.
(WebCore::SVGUseElement::svgAttributeChanged): Removed unneeded code calling
isSupportedAttribute. Changed the code that detects changes in href to just
call updateExternalDocument (for the document URL) and invalidateShadowTree
(for the fragment). Also updated the transferSizeAttributesToTargetClone logic
to only trigger on width and height and updated names.
(WebCore::SVGUseElement::willAttachRenderers): Updated for the new name of
m_shouldRebuildShadowTree and added a call through to the base class.
(WebCore::createAllowedElementSet): Added. A more efficient way to implement
the initialization of the set for isDisallowedElement.
(WebCore::isDisallowedElement): Simplified this by using the function above,
and also overloaded for both SVGElement and Element for a tiny efficiency boost.
(WebCore::SVGUseElement::clearShadowTree): Renamed form clearResourceReferences.
This is a much more straightforward name. Also deleted the code that sets the
m_needsShadowTreeRecreation flag to false. That should be done by the build
function, not here.
(WebCore::SVGUseElement::buildPendingResource): Made this just invalidate the
shadow tree now instead of explicitly building it.
(WebCore::SVGUseElement::updateShadowTree): Moved the code to create a shadow
tree here from buildPendingResource. ALso changed the logic so that we
always blow away the old shadow tree. Moved the comment about rebuilding things
every time here. Updated the code to use the findTarget and cloneTarget functions,
eliminating the buildShadowTree function entirely. Moved the call to
transferSizeAttributesToShadowTreeTargetClone inside cloneTarget. Also updated
for the name change for m_shouldRebuildShadowTree.
(WebCore::SVGUseElement::targetClone): Renamed from shadowTreeTargetClone.
No need to emphasize "shadow tree" since that's where all clones are.
(WebCore::isDirectReference): Streamlined a bit using "using namespace".
(WebCore::SVGUseElement::toClipPath): Rewrote to use early return and updated
for name changes. Also used ASCIILiteral.
(WebCore::SVGUseElement::rendererClipChild): Changed local variable names.
(WebCore::removeDisallowedElementsFromSubtree): Wrote the iteration in a
slightly more idiomatic style.
(WebCore::SVGUseElement::findTarget): Added. This new function implements
the rule for finding a valid target for a use element. This replaces logic
that was duplicated in two different places and it also includes all the
rules that were formerly in the isValidTarget function. Also, this implements
a correct check for a cycle that handles cases the code in isValidTarget did not.
(WebCore::SVGUseElement::isValidTarget): Deleted.
(WebCore::SVGUseElement::cloneTarget): Added. Helper function used both when
cloning the target of the top level <use> elements and for other <use> elements
inside the shadow tree.
(WebCore::cloneDataAndChildren): Added. Helper function that allows both the
<use> and <symbol> element expanding functions to be shorter and share more code.
(WebCore::SVGUseElement::expandUseElementsInShadowTree): Removed unneeded checks
of cachedDocumentIsStillLoading. Used the new findTarget function, which handles
finding the target cross-document correctly. Removed the incorrect use of
referencedDocument when creating new elements and finding targets. Refactored
to use the new cloneDataAndChildren function and also moved the code that removes
the special attributes here, replacing the transferAttributesToShadowTreeReplacement
function. Made a few other simplifications.
(WebCore::SVGUseElement::expandSymbolElementsInShadowTree): Ditto, just like the
<use> changes only simpler.
(WebCore::SVGUseElement::transferEventListenersToShadowTree): Made this const.
Removed unneeded assertions.
(WebCore::SVGUseElement::invalidateShadowTree): Updated for name change.
(WebCore::SVGUseElement::invalidateDependentShadowTrees): Removed assertion.
(WebCore::SVGUseElement::transferAttributesToShadowTreeReplacement): Deleted.
(WebCore::SVGUseElement::selfHasRelativeLengths): Tweaked names.
(WebCore::SVGUseElement::notifyFinished): Removed the inDocument check, since
this function will only be called for elements that are in a document.
(WebCore::SVGUseElement::cachedDocumentIsStillLoading): Deleted.
(WebCore::SVGUseElement::finishParsingChildren): Removed the code that calls
buildPendingResource here. Shadow tree updating is driven solely by renderer
generation now.
(WebCore::SVGUseElement::updateExternalDocument): Replaced setCachedDocument
with this. This function knows how to load a different document if the URL
has changed, or leave it alone if not, and also stop the load if it should.
(WebCore::SVGUseElement::isValid): Moved this here from the header, since it's
always being called virtually.
(WebCore::SVGUseElement::haveLoadedRequiredResources): Ditto.
(WebCore::SVGUseElement::setHaveFiredLoadEvent): Ditto.
(WebCore::SVGUseElement::haveFiredLoadEvent): Ditto.
(WebCore::SVGUseElement::svgLoadEventTimer): Ditto.

* svg/SVGUseElement.h: Removed unneeded include. Moved the animated properties
to the top of the class because they are public DOM API and so are logical to
list first. I'd like to do that for other classes too over time. Changed to
derive privately from CachedSVGDocumentClient. Made the function
invalidateDependentShadowTrees private. Removed didNotifySubtreeInsertions,
isSupportedAttribute, clearResourceReferences, buildShadowTree,
transferAttributesToShadowTreeReplacement, isParserInserted, and
m_wasInsertedByParser. Added updateExternalDocument, cloneTarget, targetClone,
updateShadowTree, and clearShadowTree. Also did a couple other renames,
including renaming m_cachedDocument to m_externalDocument.

* svg/svgtags.in: Removed constructorNeedsCreatedByParser from the <use>
element since we don't have to handle constructing by the parser specially.

LayoutTests:

Modified some tests to be reference tests since the change in implementation slightly changed
the behavior, but not in a way that matters. Other similar updates.

* TestExpectations: Expect a progression in imported/mozilla/svg/dynamic-use-02.svg.

* platform/gtk/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.png: Removed.
* platform/gtk/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt: Removed.
* platform/gtk/svg/custom/use-property-synchronization-crash-expected.png: Removed.
* platform/ios-sim-deprecated/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt: Removed.
* platform/ios-simulator/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt: Removed.
* platform/mac-mountainlion/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt: Removed.
* platform/mac/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.png: Removed.
* platform/mac/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt: Removed.
* platform/mac/svg/custom/use-property-synchronization-crash-expected.png: Removed.

* svg/animations/use-animate-width-and-height-expected.txt: Updated to expect the new expression
name from the modified test.
* svg/animations/use-animate-width-and-height.html: THe state of the shadow root now depends on
layout, so force layout before inspecting it.

* svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.xhtml: Added.
* svg/custom/relative-sized-shadow-tree-content-with-symbol.xhtml: Made this no longer be a
repaint test. Not sure why we are using those in so many cases. Also made it be a reference test.

* svg/custom/use-property-synchronization-crash-expected.svg: Added.
* svg/custom/use-property-synchronization-crash-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, EFL gardening. Mark multi-column failing tests to Failure.
gyuyoung.kim@samsung.com [Thu, 12 Feb 2015 03:46:18 +0000 (03:46 +0000)]
Unreviewed, EFL gardening. Mark multi-column failing tests to Failure.
Those tests have been failing since r167808.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoCSS selector JIT compilation support for :lang()
diorahman@rockybars.com [Thu, 12 Feb 2015 02:33:54 +0000 (02:33 +0000)]
CSS selector JIT compilation support for :lang()
https://bugs.webkit.org/show_bug.cgi?id=140818

Reviewed by Benjamin Poulain.

Source/WebCore:

Add the JIT support for :lang(), to ensure :lang() no longer force the engine to
the slow path.

Test: fast/selectors/lang-chained-multiple.html

* cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::addPseudoClassType):
Get rid of the FunctionType::CannotCompile
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatching):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsInLanguage):

LayoutTests:

* fast/selectors/lang-chained-multiple-expected.txt: Added.
* fast/selectors/lang-chained-multiple.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix more weak external symbol errors.
achristensen@apple.com [Thu, 12 Feb 2015 02:25:42 +0000 (02:25 +0000)]
Fix more weak external symbol errors.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
* page/make_settings.pl:
(printGetterAndSetter):
Remove some WEBCORE_EXPORT macros.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoiOS build fix.
enrica@apple.com [Thu, 12 Feb 2015 01:25:20 +0000 (01:25 +0000)]
iOS build fix.

Unreviewed.

* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView inputAssistantItem]):
(-[WKContentView _inputAssistantItem]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoDo not export functions defined in headers.
achristensen@apple.com [Thu, 12 Feb 2015 01:09:50 +0000 (01:09 +0000)]
Do not export functions defined in headers.
This prevents weak external symbol errors in some configurations.

* dom/Range.h:
(WebCore::Range::startContainer):
(WebCore::Range::startOffset):
(WebCore::Range::endContainer):
(WebCore::Range::endOffset):
* inspector/InspectorController.h:
* page/Settings.h:
(WebCore::Settings::setMediaKeysStorageDirectory):
* page/make_settings.pl:
(printGetterAndSetter):
* platform/network/cocoa/ProtectionSpaceCocoa.h:
(WebCore::ProtectionSpace::encodingRequiresPlatformData):
* platform/text/TextEncoding.h:
(WebCore::TextEncoding::decode):
Removed WEBCORE_EXPORT macros.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWeb Inspector: REGRESSION: Clicking selected item in the sidebar second time should...
commit-queue@webkit.org [Thu, 12 Feb 2015 00:46:21 +0000 (00:46 +0000)]
Web Inspector: REGRESSION: Clicking selected item in the sidebar second time should scroll to the corresponding line
https://bugs.webkit.org/show_bug.cgi?id=140280

Patch by Nikita Vasilyev <nvasilyev@apple.com> on 2015-02-11
Reviewed by Brian Burg.

* UserInterface/Views/ContentViewContainer.js:
(WebInspector.ContentViewContainer.prototype.showContentView):
Perform scolling regardless of the navigation history. Since scrolling source code doesn't introduce a BackForwardEntry,
it's possible that the actual content view has a different scroll position.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[WK2] Add logging to validate the network cache efficacy (Part 2)
cdumez@apple.com [Wed, 11 Feb 2015 23:57:31 +0000 (23:57 +0000)]
[WK2] Add logging to validate the network cache efficacy (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=141345
<rdar://problem/19632080>

Reviewed by Sam Weinig.

Source/WebCore:

Add a few more diagnostic logging keys for the network cache efficacy
logging.

Source/WebKit2:

Add diagnostic logging messages to validate the network cache efficacy.
The following 4 messages are added:
- networkCache / retrieval / success
- networkCache / retrieval / unhandledRequestFailure
- networkCache / retrieval / noLongerInCacheFailure
- networkCache / retrieval / unusableCachedEntryFailure

The messages are sent via IPC from the NetworkProcess to the UIProcess,
where the WebPageProxy code already handles diagnostic messages sent by
the WebProcess.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION(r179166): Crash when accessing document.dir on a document with no elements
weinig@apple.com [Wed, 11 Feb 2015 23:40:13 +0000 (23:40 +0000)]
REGRESSION(r179166): Crash when accessing document.dir on a document with no elements
<rdar://problem/19804351>
https://bugs.webkit.org/show_bug.cgi?id=141480

Reviewed by Chris Dumez.

Source/WebCore:

Test: fast/dom/document-dir-empty-document-crash.html

* html/HTMLDocument.cpp:
(WebCore::HTMLDocument::dir):
Don't unnecessarily dereference the documentElement. is<HTMLHtmlElement>() will handle null just fine.

LayoutTests:

* fast/dom/document-dir-empty-document-crash-expected.txt: Added.
* fast/dom/document-dir-empty-document-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago<https://webkit.org/b/141492> extract-localizable-strings.pl shouldn't update the...
mrowe@apple.com [Wed, 11 Feb 2015 23:14:30 +0000 (23:14 +0000)]
<https://webkit.org/b/141492> extract-localizable-strings.pl shouldn't update the target file if the contents haven't changed

Avoid updating the target file if the contents haven't changed. This prevents Xcode from copying the identical
file into the framework and resigning it, which avoids the resulting relinking of all targets that depend on
the framework.

Reviewed by Dan Bernstein.

* extract-localizable-strings.pl: Write our output to a temporary file. If the output differs from the
existing contents of the target file, move the temporary file over the target file. Otherwise, delete
the temporary file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoThe callee frame helpers in DFG::SpeculativeJIT should be available to other JITs
fpizlo@apple.com [Wed, 11 Feb 2015 23:02:32 +0000 (23:02 +0000)]
The callee frame helpers in DFG::SpeculativeJIT should be available to other JITs
https://bugs.webkit.org/show_bug.cgi?id=141493

Reviewed by Michael Saboff.

* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::calleeFrameSlot): Deleted.
(JSC::DFG::SpeculativeJIT::calleeArgumentSlot): Deleted.
(JSC::DFG::SpeculativeJIT::calleeFrameTagSlot): Deleted.
(JSC::DFG::SpeculativeJIT::calleeFramePayloadSlot): Deleted.
(JSC::DFG::SpeculativeJIT::calleeArgumentTagSlot): Deleted.
(JSC::DFG::SpeculativeJIT::calleeArgumentPayloadSlot): Deleted.
(JSC::DFG::SpeculativeJIT::calleeFrameCallerFrame): Deleted.
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
* jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::calleeFrameSlot):
(JSC::AssemblyHelpers::calleeArgumentSlot):
(JSC::AssemblyHelpers::calleeFrameTagSlot):
(JSC::AssemblyHelpers::calleeFramePayloadSlot):
(JSC::AssemblyHelpers::calleeArgumentTagSlot):
(JSC::AssemblyHelpers::calleeArgumentPayloadSlot):
(JSC::AssemblyHelpers::calleeFrameCallerFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoNew perf dashboard shows too much space around interesting data points
rniwa@webkit.org [Wed, 11 Feb 2015 22:56:31 +0000 (22:56 +0000)]
New perf dashboard shows too much space around interesting data points
https://bugs.webkit.org/show_bug.cgi?id=141487

Reviewed by Chris Dumez.

Revise the y-axis range adjustment algorithm in r179913. Instead of showing the entire moving average,
show the current time series excluding points in the series outside the moving average envelope.

* public/v2/app.js:
(App.Pane._computeChartData): Don't deal with missing moving average or enveloping strategy here.
(App.Pane._computeMovingAverageAndOutliers): Set isOutliner to true on all data points in the current
time series if the point lies outside the moving average envelope. Don't expose the moving average or
the envelope computed for this purpose if they're not set by the user.

* public/v2/data.js:
(TimeSeries.prototype.minMaxForTimeRange): Takes a boolean argument, ignoreOutlier. When the flag is set
to true, min/max computation will ignore any point in the series with non-falsy "isOutliner" property.

* public/v2/interactive-chart.js:
(App.InteractiveChartComponent._constructGraphIfPossible): Unsupport hideMovingAverage and hideEnvelope.
(App.InteractiveChartComponent._computeYAxisDomain): Removed the commented out code. Also moved the code
to deal with showFullYAxis here.
(App.InteractiveChartComponent._minMaxForAllTimeSeries): Rewrote the code. Takes ignoreOutliners as an
argument instead of directly inspecting showFullYAxis.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[WinCairo] Accelerated compositing should be disabled when graphics card does not...
commit-queue@webkit.org [Wed, 11 Feb 2015 22:48:27 +0000 (22:48 +0000)]
[WinCairo] Accelerated compositing should be disabled when graphics card does not support it.
https://bugs.webkit.org/show_bug.cgi?id=140667

Patch by peavo@outlook.com <peavo@outlook.com> on 2015-02-11
Reviewed by Alex Christensen.

* WebCoreSupport/AcceleratedCompositingContext.cpp:
(AcceleratedCompositingContext::scrollNonCompositedContents):
(AcceleratedCompositingContext::acceleratedCompositingAvailable):
* WebCoreSupport/AcceleratedCompositingContext.h:
* WebView.cpp:
(WebView::notifyPreferencesChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoTurn recent assertions into release assertions to help track down crash in DocumentLo...
cdumez@apple.com [Wed, 11 Feb 2015 22:15:31 +0000 (22:15 +0000)]
Turn recent assertions into release assertions to help track down crash in DocumentLoader::stopLoadingForPolicyChange()
https://bugs.webkit.org/show_bug.cgi?id=141484
<rdar://problem/13811738>

Reviewed by Andy Estes.

Turn recent assertions into release assertions to help track down crash in
DocumentLoader::stopLoadingForPolicyChange(). This should increase the
likelyhood of tripping them so that we better understand why this happens.

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::~DocumentLoader):
(WebCore::DocumentLoader::detachFromFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSetupVarargsFrame should not assume that an inline stack frame would have identical...
fpizlo@apple.com [Wed, 11 Feb 2015 21:48:38 +0000 (21:48 +0000)]
SetupVarargsFrame should not assume that an inline stack frame would have identical layout to a normal stack frame
https://bugs.webkit.org/show_bug.cgi?id=141485

Reviewed by Oliver Hunt.

The inlineStackOffset argument was meant to make it easy for the DFG to use this helper for
vararg calls from inlined code, but that doesn't work since the DFG inline call frame
doesn't actually put the argument count at the JSStack::ArgumentCount offset. In fact there
is really no such thing as an inlineStackOffset except when we OSR exit; while the code is
running the stack layout is compacted so that the stackOffset is not meaningful.

* jit/JITCall.cpp:
(JSC::JIT::compileSetupVarargsFrame):
* jit/JITCall32_64.cpp:
(JSC::JIT::compileSetupVarargsFrame):
* jit/SetupVarargsFrame.cpp:
(JSC::emitSetupVarargsFrameFastCase):
* jit/SetupVarargsFrame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[MSE] SampleMap::addRange() returns an inverted iterator_range, possibly causing...
jer.noble@apple.com [Wed, 11 Feb 2015 21:45:02 +0000 (21:45 +0000)]
[MSE] SampleMap::addRange() returns an inverted iterator_range, possibly causing a crash when that iterator_range is traversed.
https://bugs.webkit.org/show_bug.cgi?id=141479
rdar://problem/19067597

Reviewed by Chris Dumez.

When looking backwards through a presentationOrder map to find samples, we then reverse our iterators
and put them in an iterator_range to return to the caller. But in addition to reversing the iterators
themselves, we also need to put them in the iterator_range in reverse order, so that when the caller
iterates from iterator_range.first -> iterator_range.second, they don't end up off the end of the
the underlying storage.

* Modules/mediasource/SampleMap.cpp:
(WebCore::PresentationOrderSampleMap::findSamplesWithinPresentationRangeFromEnd):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION (iOS 8): PDFs embedded in <object>/<embed> tag don't load at all
timothy_horton@apple.com [Wed, 11 Feb 2015 21:36:22 +0000 (21:36 +0000)]
REGRESSION (iOS 8): PDFs embedded in <object>/<embed> tag don't load at all
https://bugs.webkit.org/show_bug.cgi?id=141457
<rdar://problem/18221851>

Reviewed by Alexey Proskuryakov.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::objectContentType):
On iOS, if we don't know what to do with a PDF-in-object, treat it as an image.

* TestExpectations:
* fast/replaced/pdf-as-object-and-embed-expected.html: Added.
* fast/replaced/pdf-as-object-and-embed.html: Added.
* platform/ios-simulator-wk2/TestExpectations:
Add a test that ensures that WebKit2 on iOS treats <object>, <embed>,
and <img> the same when rendering a PDF.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoImprove the showFrameTree() output slightly
simon.fraser@apple.com [Wed, 11 Feb 2015 20:34:15 +0000 (20:34 +0000)]
Improve the showFrameTree() output slightly
https://bugs.webkit.org/show_bug.cgi?id=141482

Reviewed by Zalan Bujtas.

Have showFrameTree() show the Frame's RenderView so it can be correlated with
layer dumps, and show styleRecalc and needsLayout state.

* page/FrameTree.cpp:
(printFrames):
* page/FrameView.cpp:
(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive): Add an explanatory
comment about why we don't walk the Frame tree.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMake run-jsc-stress-tests --remote work with make-based runner
ossy@webkit.org [Wed, 11 Feb 2015 20:31:24 +0000 (20:31 +0000)]
Make run-jsc-stress-tests --remote work with make-based runner
https://bugs.webkit.org/show_bug.cgi?id=141079

Reviewed by Darin Adler.

* Scripts/run-javascriptcore-tests:
(runJSCStressTests): Pass through the --shell-runner and --make-runner arguments.
* Scripts/run-jsc-stress-tests: Made the make-based runner the default runner,
except for remote testing on Darwin. Unified runShellTestRunner and runMakeTestRunner
to avoid code duplication.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoStop using WebCore.exp.in on Mac and iOS.
achristensen@apple.com [Wed, 11 Feb 2015 20:29:32 +0000 (20:29 +0000)]
Stop using WebCore.exp.in on Mac and iOS.
https://bugs.webkit.org/show_bug.cgi?id=141413

Reviewed by Dan Bates.

* Configurations/Base.xcconfig:
Make symbols hidden by default unless exported by WEBCORE_EXPORT macros.
* platform/PlatformExportMacros.h:
Start using WEBCORE_EXPORT on Mac and iOS (but not Windows yet).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoDiv having contentEditable and display:flex cannot be edited if it is empty.
changseok.oh@collabora.com [Wed, 11 Feb 2015 20:13:03 +0000 (20:13 +0000)]
Div having contentEditable and display:flex cannot be edited if it is empty.
https://bugs.webkit.org/show_bug.cgi?id=141218

Reviewed by Ryosuke Niwa.

Source/WebCore:

RenderFlexibleBox should be treated as a candidate for visible position. Visible selection
in an editable area is recalculated whenever an inner value of div is changed. If the inner value
is empty, the visible selection recalculated with DeleteSelectionCommand::m_endingPostion
is not correct. Because RenderBlockFlow is only considered but not RenderFlexibleBox
in Position::isCandidate so that a calculated ending VisiblePosition for an editable div
having "display : flex" goes weird and VisibleSelection is empty accordingly.

Test: fast/events/key-events-in-editable-flexbox.html

* dom/Position.cpp:
(WebCore::Position::isCandidate):

LayoutTests:

This tests if an editable flexbox can be reedited after erasing all texts in it.

* fast/events/key-events-in-editable-flexbox-expected.txt: Added.
* fast/events/key-events-in-editable-flexbox.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[CMake] Don't set flag fuse-ld on the C/C++ compiler flags, but on the linker flags.
clopez@igalia.com [Wed, 11 Feb 2015 20:12:36 +0000 (20:12 +0000)]
[CMake] Don't set flag fuse-ld on the C/C++ compiler flags, but on the linker flags.
https://bugs.webkit.org/show_bug.cgi?id=141481

Reviewed by Csaba Osztrogonác.

* Source/cmake/OptionsCommon.cmake: Move -fuse-ld=gold to the linker flags.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoActivate ReliefLogger of a memory pressure handler for linux system.
changseok.oh@collabora.com [Wed, 11 Feb 2015 20:09:13 +0000 (20:09 +0000)]
Activate ReliefLogger of a memory pressure handler for linux system.
https://bugs.webkit.org/show_bug.cgi?id=123611

Reviewed by Anders Carlsson.

Source/WebCore:

Put more logs for the time when a system goes under memory pressure or viceversa.

No new tests since no engine behavior changed.

* platform/linux/MemoryPressureHandlerLinux.cpp:
(WebCore::MemoryPressureHandler::waitForMemoryPressureEvent): Wait a memory pressure event
from cgroup in a seperated thread. Once a pressure event happens, respondToMemoryPressure()
would be called to get back some resources.
(WebCore::MemoryPressureHandler::install): Install memoryPressureHandler module
to make it work.

Source/WebKit2:

* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::WebProcessCreationParameters):
Make the parameter, shouldEnableMemoryPressureReliefLogging shareable with COCOA else systems.
(WebKit::WebProcessCreationParameters::encode): ditto.
(WebKit::WebProcessCreationParameters::decode): ditto.
* Shared/WebProcessCreationParameters.h:
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::createNewWebProcess): Set shouldEnableMemoryPressureReliefLogging
to true for linux system.
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess): Pass the shouldEnableMemoryPressureReliefLogging value
to MemoryPressureHandler::ReliefLogger::setLoggingEnabled().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFinal preparations to switch to WEBCORE_EXPORT.
achristensen@apple.com [Wed, 11 Feb 2015 19:44:07 +0000 (19:44 +0000)]
Final preparations to switch to WEBCORE_EXPORT.

* platform/ios/WebVideoFullscreenInterfaceAVKit.h:
Export the vtable and a function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoperformance.now can crash if accessed from a window that has navigated
weinig@apple.com [Wed, 11 Feb 2015 18:36:38 +0000 (18:36 +0000)]
performance.now can crash if accessed from a window that has navigated
<rdar://problem/16892506>
https://bugs.webkit.org/show_bug.cgi?id=141478

Reviewed by Alexey Proskuryakov.

Test: fast/performance/performance-now-crash-on-navigated-window.html

* page/Performance.cpp:
(WebCore::Performance::now):
Check for a null frame, which can happen when the window has been navigated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoperformance.now can crash if accessed from a window that has navigated
weinig@apple.com [Wed, 11 Feb 2015 18:33:14 +0000 (18:33 +0000)]
performance.now can crash if accessed from a window that has navigated
<rdar://problem/16892506>
https://bugs.webkit.org/show_bug.cgi?id=141478

Reviewed by Alexey Proskuryakov.

* fast/performance/performance-now-crash-on-navigated-window-expected.txt: Added.
* fast/performance/performance-now-crash-on-navigated-window.html: Added.
* fast/performance/resources: Added.
* fast/performance/resources/initialFrame.html: Added.
* fast/performance/resources/secondFrame.html: Added.
Add test for calling performance.now() on from a navigated window.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoVersioning.
bshafiei@apple.com [Wed, 11 Feb 2015 18:09:53 +0000 (18:09 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoURL::setUser and URL::setPass don't percent encode
ap@apple.com [Wed, 11 Feb 2015 18:03:42 +0000 (18:03 +0000)]
URL::setUser and URL::setPass don't percent encode
https://bugs.webkit.org/show_bug.cgi?id=141453
rdar://problem/14844503&16551802&19623145

Reviewed by Darin Adler.

Source/WebCore:

Tests: fast/url/url-credentials-escaping.html
       http/tests/xmlhttprequest/basic-auth-credentials-escaping.html

Start adding some code that performs escaping in a way that matches the URL Standard.
Right now, it's only used where we failed to do any escaping at all, and over time,
we'll be moving towards a new implementation.

* html/URLUtils.h:
(WebCore::URLUtils<T>::username):
(WebCore::URLUtils<T>::password):
* platform/URL.cpp:
(WebCore::isSchemeFirstChar):
(WebCore::URL::user):
(WebCore::URL::pass):
(WebCore::URL::encodedUser):
(WebCore::URL::encodedPass):
(WebCore::URL::setUser):
(WebCore::URL::setPass):
(WebCore::encodeWithURLEscapeSequences):
* platform/URL.h:

LayoutTests:

* fast/url/url-credentials-escaping-expected.txt: Added.
* fast/url/url-credentials-escaping.html: Added.
This change is most directly testable via URL API.

* http/tests/xmlhttprequest/basic-auth-credentials-escaping-expected.txt: Added.
* http/tests/xmlhttprequest/basic-auth-credentials-escaping.html: Added.
Verify that this doesn't break XMLHttpRequest authentication.

* fast/dom/DOMURL/invalid-url-getters-expected.txt: Removed.
* fast/dom/DOMURL/invalid-url-getters.html: Removed.
* fast/dom/DOMURL/url-origin-expected.txt:
* fast/dom/DOMURL/url-origin.html:
Removed tests for invalid URLs, there is no such thing with URL API.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK][EFL] Suppress a warning of unused params
utatane.tea@gmail.com [Wed, 11 Feb 2015 17:58:33 +0000 (17:58 +0000)]
[GTK][EFL] Suppress a warning of unused params
https://bugs.webkit.org/show_bug.cgi?id=141474

Reviewed by Darin Adler.

Drop unused argument name, `directoryName`.

* UIProcess/API/APIWebsiteDataStore.cpp:
(API::WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agorun-jsc-stress tests should detect the number of processors on the remote machine too
ossy@webkit.org [Wed, 11 Feb 2015 17:11:22 +0000 (17:11 +0000)]
run-jsc-stress tests should detect the number of processors on the remote machine too
https://bugs.webkit.org/show_bug.cgi?id=141196

Reviewed by Darin Adler.

* Scripts/run-javascriptcore-tests:
(runJSCStressTests): Pass through the --child-processes argument.
* Scripts/run-jsc-stress-tests: Added determineNumberOfProcessors function
to detect the number of local and remote processors with the same algorithm.
Additionally introduced $numChildProcesses to emphasize it isn't necessarily
same as $numProcessors.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agorun-jsc-stress-tests should pass JSC_timeout to remote hosts
ossy@webkit.org [Wed, 11 Feb 2015 17:10:01 +0000 (17:10 +0000)]
run-jsc-stress-tests should pass JSC_timeout to remote hosts
https://bugs.webkit.org/show_bug.cgi?id=141164

Reviewed by Darin Adler.

Additonally removed IMPORTANT_ENVS, since JSC_timeout was the only one.

* Scripts/run-jsc-stress-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd a few more WEBCORE_EXPORT macros for debug and iOS builds.
achristensen@apple.com [Wed, 11 Feb 2015 17:09:33 +0000 (17:09 +0000)]
Add a few more WEBCORE_EXPORT macros for debug and iOS builds.

* page/EventHandler.h:
* page/ios/WebEventRegion.h:
* platform/sql/SQLiteDatabaseTracker.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION(r179476): It broke the !ENABLE(PICTURE_SIZES) build
darin@apple.com [Wed, 11 Feb 2015 16:41:13 +0000 (16:41 +0000)]
REGRESSION(r179476): It broke the !ENABLE(PICTURE_SIZES) build
https://bugs.webkit.org/show_bug.cgi?id=141327

Reviewed by Csaba Osztrogonác.

* html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes):
Put #if around use of m_sizesAttribute.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agobmalloc buildfix on 32 bit Linux (x86/ARM)
ossy@webkit.org [Wed, 11 Feb 2015 16:12:13 +0000 (16:12 +0000)]
bmalloc buildfix on 32 bit Linux (x86/ARM)
https://bugs.webkit.org/show_bug.cgi?id=141472

Reviewed by Gyuyoung Kim.

* bmalloc/Algorithm.h:
(bmalloc::roundUpToMultipleOf):
* bmalloc/FixedVector.h:
(bmalloc::FixedVector::clear):
* bmalloc/Sizes.h:
(bmalloc::Sizes::sizeClass):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, rolling out r179921.
commit-queue@webkit.org [Wed, 11 Feb 2015 15:34:13 +0000 (15:34 +0000)]
Unreviewed, rolling out r179921.
https://bugs.webkit.org/show_bug.cgi?id=141473

caused about 30 test failures on yosemite and mavericks
(Requested by alexchristensen on #webkit).

Reverted changeset:

"Div having contentEditable and display:flex cannot be edited
if it is empty."
https://bugs.webkit.org/show_bug.cgi?id=141218
http://trac.webkit.org/changeset/179921

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Win] Unreviewed build fix.
achristensen@apple.com [Wed, 11 Feb 2015 15:05:06 +0000 (15:05 +0000)]
[Win] Unreviewed build fix.

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed GTK+ Gardening 11 February.
commit-queue@webkit.org [Wed, 11 Feb 2015 13:54:24 +0000 (13:54 +0000)]
Unreviewed GTK+ Gardening 11 February.

Patch by Marcos Chavarría Teijeiro <chavarria1991@gmail.com> on 2015-02-11

* platform/gtk/TestExpectations:
* platform/gtk/editing/pasteboard/onpaste-text-html-expected.txt: Rebaselined after r179168.
* platform/gtk/fast/css/outline-auto-empty-rects-expected.txt: Added. Rebaselined after r177774.
* platform/gtk/fast/css/pseudo-invalid-form-invalidation-optimization-expected.txt: Added. Rebaselined after r177664.
* platform/gtk/fast/css/pseudo-valid-form-invalidation-optimization-expected.txt: Added. Rebaselined after r177664.
* platform/gtk/fast/forms/basic-buttons-expected.txt: Rebaselined after r178078.
* platform/gtk/fast/line-grid/line-align-right-edges-expected.txt: Rebaselined after r177128.
* platform/gtk/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.txt: Added. Rebaselined after r177774.
* platform/gtk/fast/table/022-expected.txt: Added. Rebaselined after r177774.
* platform/gtk/fast/text/wbr-pre-expected.txt: Added. Rebaselined after r177774.
* platform/gtk/fast/text/whitespace/019-expected.txt: Added. Rebaselined after r177774.
* platform/gtk/fast/text/whitespace/023-expected.txt: Added. Rebaselined after r177774.
* platform/gtk/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt: Added. Rebaselined after r177490.
* platform/gtk/svg/custom/glyph-selection-arabic-forms-expected.txt: Added. Rebaselined after r177774.
* platform/gtk/svg/custom/glyph-selection-lang-attribute-expected.txt: Rebaselined after r177490.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL][GTK] Use bmalloc instead of tcmalloc
gyuyoung.kim@samsung.com [Wed, 11 Feb 2015 12:15:23 +0000 (12:15 +0000)]
[EFL][GTK] Use bmalloc instead of tcmalloc
https://bugs.webkit.org/show_bug.cgi?id=140162

Reviewed by Carlos Garcia Campos.

.:

Add bmalloc directory to build list.

* CMakeLists.txt: Define BMALLOC_DIR directory.
* Source/CMakeLists.txt: Add bmalloc path to sub-directories list.

Source/bmalloc:

Support to use bmalloc on EFL and GTK ports.

* CMakeLists.txt: Added.
* bmalloc/Allocator.cpp:
(bmalloc::Allocator::allocate):
    Fix unused return value caused by posix_memalign().
* bmalloc/AsyncTask.h:
* bmalloc/BoundaryTag.h:
(bmalloc::BoundaryTag::clear):
* bmalloc/Chunk.h:
    Change Traits::Page with Traits::PageType in order to fix
    -fpermitive build error on EFL and GTK port.
* bmalloc/EndTag.h:
(bmalloc::EndTag::operator=):
* bmalloc/Line.h: ditto.
* bmalloc/MediumTraits.h:
* bmalloc/Page.h: ditto.
* bmalloc/PerThread.h:
    EFL port doesn't support __has_include definition yet.
    Define HAVE_PTHREAD_MACHDEP_H according to check if __has_include is supported.
* bmalloc/SmallTraits.h: ditto.
* bmalloc/VMAllocate.h:
(bmalloc::vmDeallocatePhysicalPages):
(bmalloc::vmAllocatePhysicalPages):
* bmalloc/Vector.h:
(bmalloc::Vector<T>::push):
(bmalloc::Vector<T>::reallocateBuffer):

Source/WTF:

* wtf/CMakeLists.txt:
* wtf/FastMalloc.cpp:
    Enable bmalloc on GTK ports, but EFL port will enable it when bmalloc supports
    memory statistics.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] Add default color chooser implementation using GtkColorChooserDialog
carlosgc@webkit.org [Wed, 11 Feb 2015 09:03:06 +0000 (09:03 +0000)]
[GTK] Add default color chooser implementation using GtkColorChooserDialog
https://bugs.webkit.org/show_bug.cgi?id=141392

Reviewed by Gustavo Noronha Silva.

.:

Enable INPUT_TYPE_COLOR by default for GTK+ port.

* Source/cmake/OptionsGTK.cmake:

Source/WebKit2:

* PlatformGTK.cmake: Add new files to compilation.
* UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::createColorPicker): Call WebColorPickerGtk::create().
* UIProcess/gtk/WebColorPickerGtk.cpp: Added.
(WebKit::WebColorPickerGtk::create):
(WebKit::WebColorPickerGtk::WebColorPickerGtk):
(WebKit::WebColorPickerGtk::~WebColorPickerGtk):
(WebKit::WebColorPickerGtk::cancel): Set initial color.
(WebKit::WebColorPickerGtk::endPicker): Destroy the color chooser dialog.
(WebKit::WebColorPickerGtk::didChooseColor): Notify the client.
(WebKit::WebColorPickerGtk::colorChooserDialogRGBAChangedCallback):
Update the selected color.
(WebKit::WebColorPickerGtk::colorChooserDialogResponseCallback):
Cancel or finish the operation depending on the dialog response.
(WebKit::WebColorPickerGtk::showColorPicker): Create a
GtkColorChooserDialog to handle the color picker operation.
* UIProcess/gtk/WebColorPickerGtk.h: Added.
(WebKit::WebColorPickerGtk::initialColor):

Tools:

Enable INPUT_TYPE_COLOR by default for GTK+ port.

* Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Unskip input color tests.

* platform/gtk/TestExpectations:
* platform/gtk/fast/forms/color/input-appearance-color-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoDiv having contentEditable and display:flex cannot be edited if it is empty.
changseok.oh@collabora.com [Wed, 11 Feb 2015 08:51:55 +0000 (08:51 +0000)]
Div having contentEditable and display:flex cannot be edited if it is empty.
https://bugs.webkit.org/show_bug.cgi?id=141218

Reviewed by Ryosuke Niwa.

Source/WebCore:

RenderFlexibleBox should be treated as a candidate for visible position. Visible selection
in an editable area is recalculated whenever an inner value of div is changed. If the inner value
is empty, the visible selection recalculated with DeleteSelectionCommand::m_endingPostion
is not correct. Because RenderBlockFlow is only considered but not RenderFlexibleBox
in Position::isCandidate so that a calculated ending VisiblePosition for an editable div
having "display : flex" goes weird and VisibleSelection is empty accordingly.

Test: fast/events/key-events-in-editable-flexbox.html

* dom/Position.cpp:
(WebCore::Position::isCandidate):

LayoutTests:

This tests if an editable flexbox can be reedited after erasing all texts in it.

* fast/events/key-events-in-editable-flexbox-expected.txt: Added.
* fast/events/key-events-in-editable-flexbox.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agohttp/tests/cache/disk-cache-validation.html generates a lot of Perl errors
dburkart@apple.com [Wed, 11 Feb 2015 08:36:22 +0000 (08:36 +0000)]
http/tests/cache/disk-cache-validation.html generates a lot of Perl errors
https://bugs.webkit.org/show_bug.cgi?id=141393

Reviewed by Darin Adler.

* http/tests/cache/resources/generate-response.cgi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, rolling out r179910.
commit-queue@webkit.org [Wed, 11 Feb 2015 08:01:19 +0000 (08:01 +0000)]
Unreviewed, rolling out r179910.
https://bugs.webkit.org/show_bug.cgi?id=141464

Caused assertions on debug bots (Requested by ap on #webkit).

Reverted changeset:

"[WK2] Add logging to validate the network cache efficacy
(Part 2)"
https://bugs.webkit.org/show_bug.cgi?id=141345
http://trac.webkit.org/changeset/179910

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, EFL gardening. Tests of fast/ruby needs to have new baseline since r172874.
gyuyoung.kim@samsung.com [Wed, 11 Feb 2015 06:16:04 +0000 (06:16 +0000)]
Unreviewed, EFL gardening. Tests of fast/ruby needs to have new baseline since r172874.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179918 268f45cc-cd09-0410-ab3c-d52691b4dbfc