WebKit-https.git
7 years agoMake computeBlockDirectionMargins const
tony@chromium.org [Sat, 1 Sep 2012 01:00:10 +0000 (01:00 +0000)]
Make computeBlockDirectionMargins const
https://bugs.webkit.org/show_bug.cgi?id=95595

Reviewed by Ojan Vafai.

This is a step in making computeLogicalHeight const.
Refactor RenderBox::computeBlockDirectionMargins and make it const.
Add a helper method computeAndSetBlockDirectionMargins for the callers outside of
computeLogicalHeight that are calling this.

No new tests, this is already covered by tests in fast/writing-mode and fast/multicol.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::marginBeforeEstimateForChild): Switch to computeAndSetBlockDirectionMargins
(WebCore::RenderBlock::layoutBlockChild): Switch to computeAndSetBlockDirectionMargins
(WebCore::RenderBlock::insertFloatingObject): Switch to computeAndSetBlockDirectionMargins
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalHeight): Use const version and fill in a MarginValues struct (to be merged in the next patch).
(WebCore::RenderBox::computeBlockDirectionMargins): Pass in out params.
(WebCore):
(WebCore::RenderBox::computeAndSetBlockDirectionMargins): Does the same as the old computeBlockDirectionMargins.
* rendering/RenderBox.h:
(RenderBox):
* rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox): Switch to computeAndSetBlockDirectionMargins
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox): Switch to computeAndSetBlockDirectionMargins
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::layout): Switch to computeAndSetBlockDirectionMargins

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRolled back in a piece of <http://trac.webkit.org/changeset/127293>.
ggaren@apple.com [Sat, 1 Sep 2012 00:46:58 +0000 (00:46 +0000)]
Rolled back in a piece of <trac.webkit.org/changeset/127293>.

    Shrink activation objects by half
    https://bugs.webkit.org/show_bug.cgi?id=95591

    Reviewed by Sam Weinig.

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_resolve_global_dynamic):
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:
* runtime/JSActivation.cpp:
(JSC::JSActivation::JSActivation):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:
(JSGlobalData):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::visitChildren):
* runtime/JSGlobalObject.h:
(JSGlobalObject):
(JSC::JSGlobalObject::withScopeStructure):
(JSC::JSGlobalObject::strictEvalActivationStructure):
(JSC::JSGlobalObject::activationStructure):
(JSC::JSGlobalObject::nameScopeStructure):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. CSS_VARIABLES are not enabled on Windows. Adding Windows specific results.
roger_fong@apple.com [Sat, 1 Sep 2012 00:40:57 +0000 (00:40 +0000)]
Unreviewed. CSS_VARIABLES are not enabled on Windows. Adding Windows specific results.

* platform/win/fast/css/variables: Added.
* platform/win/fast/css/variables/build-supports-variables-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove use of ClassInfo in SpeculativeJIT::emitBranch
mhahnenberg@apple.com [Sat, 1 Sep 2012 00:38:37 +0000 (00:38 +0000)]
Remove use of ClassInfo in SpeculativeJIT::emitBranch
https://bugs.webkit.org/show_bug.cgi?id=95623

Reviewed by Filip Pizlo.

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitNonStringCellOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitNonStringCellOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Make link highlighter use same node selection criteria as Chromium for...
wjmaclean@chromium.org [Sat, 1 Sep 2012 00:33:12 +0000 (00:33 +0000)]
[chromium] Make link highlighter use same node selection criteria as Chromium for Android.
https://bugs.webkit.org/show_bug.cgi?id=95371

Reviewed by James Robinson.

This CL brings the selection criteria for link highlight targets into alignment with Chromium for Android.

Source/WebKit/chromium:

* src/WebViewImpl.cpp:
(WebKit::highlightConditions):
(WebKit::WebViewImpl::bestTouchLinkNode):
* tests/data/test_touch_link_highlight.html:

LayoutTests:

* platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-ZIndex.html: Copied from LayoutTests/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-background.html.
* platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-background.html:
* platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-body.html: Copied from LayoutTests/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-background.html.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-ZIndex-expected.png: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-ZIndex-expected.txt: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-body-expected.png: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-body-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Adding expected failing results for some fast/css(3) tests.
roger_fong@apple.com [Sat, 1 Sep 2012 00:30:10 +0000 (00:30 +0000)]
Unreviewed. Adding expected failing results for some fast/css(3) tests.
https://bugs.webkit.org/show_bug.cgi?id=95627.

* platform/win/fast/css/image-resolution: Added.
* platform/win/fast/css/image-resolution/image-resolution-expected.txt: Added.
* platform/win/fast/css/image-set-setting-expected.txt: Added.
* platform/win/fast/css/parse-border-image-repeat-null-crash-expected.txt: Added.
* platform/win/fast/css3-text-decoration: Added.
* platform/win/fast/css3-text-decoration/getComputedStyle: Added.
* platform/win/fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt: Added.
* platform/win/fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Consolidate geometry unit testing functions for cc
jamesr@google.com [Sat, 1 Sep 2012 00:20:52 +0000 (00:20 +0000)]
[chromium] Consolidate geometry unit testing functions for cc
https://bugs.webkit.org/show_bug.cgi?id=95526

Reviewed by Julien Chaffraix.

This consolidates geometry equality (rects, matrices) in CCGeometryUtils and removes a few duplicate macros for
testing rect equality.

* WebKit.gypi:
* tests/CCDamageTrackerTest.cpp:
(WebKitTests::TEST_F):
* tests/CCGeometryTestUtils.cpp: Added.
(WebKitTests):
(WebKitTests::ExpectTransformationMatrixEq):
* tests/CCGeometryTestUtils.h: Renamed from Source/WebKit/chromium/tests/CCLayerTreeTestCommon.h.
(WebKit):
(WebKitTests):
* tests/CCLayerTreeHostTest.cpp:
* tests/CCMathUtilTest.cpp:
(WebKit::TEST):
* tests/TiledLayerChromiumTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMark some indexeddb tests as SLOW. They consistently time out for me
ojan@chromium.org [Sat, 1 Sep 2012 00:12:40 +0000 (00:12 +0000)]
Mark some indexeddb tests as SLOW. They consistently time out for me
when I run with --fully-parallel.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRolled back in a piece of <http://trac.webkit.org/changeset/127293>.
ggaren@apple.com [Sat, 1 Sep 2012 00:08:18 +0000 (00:08 +0000)]
Rolled back in a piece of <trac.webkit.org/changeset/127293>.

    Shrink activation objects by half
    https://bugs.webkit.org/show_bug.cgi?id=95591

    Reviewed by Sam Weinig.

* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::MarkedBlock):
* heap/MarkedBlock.h:
(MarkedBlock):
(JSC::MarkedBlock::globalData):
(JSC):
* heap/WeakSet.cpp:
(JSC::WeakSet::addAllocator):
* heap/WeakSet.h:
(WeakSet):
(JSC::WeakSet::WeakSet):
(JSC::WeakSet::globalData):
* runtime/JSGlobalData.h:
(JSC::WeakSet::heap):
(JSC):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago [WK2] Use initial process in multi-process mode, too
ap@apple.com [Fri, 31 Aug 2012 23:49:17 +0000 (23:49 +0000)]
    [WK2] Use initial process in multi-process mode, too
        https://bugs.webkit.org/show_bug.cgi?id=95612

        Reviewed by Sam Weinig.

        * UIProcess/WebContext.cpp:
        (WebKit::WebContext::WebContext):
        (WebKit::WebContext::warmInitialProcess):
        (WebKit::WebContext::disconnectProcess):
        (WebKit::WebContext::createWebPage):
        * UIProcess/WebContext.h:
        Added a boolean telling whether the last (normally, the only) process in m_processes
        is available for use in a new page.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Clean up Web*Layer initialization paths
jamesr@google.com [Fri, 31 Aug 2012 23:46:52 +0000 (23:46 +0000)]
[chromium] Clean up Web*Layer initialization paths
https://bugs.webkit.org/show_bug.cgi?id=95523

Reviewed by Darin Fisher.

Constructing a Web*LayerImpl (or other compositor type) wrapper shouldn't require knowledge of the underyling
implementation. Also normalizes naming conventions in these files.

* src/WebAnimationImpl.cpp:
(WebKit::WebAnimation::create):
(WebKit::WebAnimationImpl::WebAnimationImpl):
* src/WebAnimationImpl.h:
(WebAnimationImpl):
* src/WebContentLayerImpl.cpp:
(WebKit::WebContentLayerImpl::WebContentLayerImpl):
(WebKit::WebContentLayerImpl::~WebContentLayerImpl):
(WebKit::WebContentLayerImpl::layer):
(WebKit::WebContentLayerImpl::setDoubleSided):
(WebKit::WebContentLayerImpl::setContentsScale):
(WebKit::WebContentLayerImpl::setUseLCDText):
(WebKit::WebContentLayerImpl::setDrawCheckerboardForMissingTiles):
* src/WebContentLayerImpl.h:
(WebContentLayerImpl):
* src/WebFloatAnimationCurveImpl.cpp:
(WebKit::WebFloatAnimationCurve::create):
(WebKit::WebFloatAnimationCurveImpl::WebFloatAnimationCurveImpl):
* src/WebFloatAnimationCurveImpl.h:
(WebFloatAnimationCurveImpl):
* src/WebIOSurfaceLayerImpl.cpp:
(WebKit::WebIOSurfaceLayer::create):
(WebKit::WebIOSurfaceLayerImpl::WebIOSurfaceLayerImpl):
* src/WebIOSurfaceLayerImpl.h:
(WebIOSurfaceLayerImpl):
* src/WebImageLayerImpl.cpp:
(WebKit::WebImageLayer::create):
(WebKit::WebImageLayerImpl::WebImageLayerImpl):
* src/WebImageLayerImpl.h:
(WebImageLayerImpl):
* src/WebLayerImpl.cpp:
(WebKit::WebLayer::create):
(WebKit):
(WebKit::WebLayerImpl::WebLayerImpl):
* src/WebLayerImpl.h:
(WebLayerImpl):
* src/WebScrollbarLayerImpl.cpp:
(WebKit::WebScrollbarLayer::create):
(WebKit::WebScrollbarLayerImpl::WebScrollbarLayerImpl):
* src/WebScrollbarLayerImpl.h:
(WebScrollbarLayerImpl):
* src/WebSolidColorLayerImpl.cpp:
(WebKit::WebSolidColorLayer::create):
(WebKit::WebSolidColorLayerImpl::WebSolidColorLayerImpl):
* src/WebSolidColorLayerImpl.h:
(WebSolidColorLayerImpl):
* src/WebTransformAnimationCurveImpl.cpp:
(WebKit::WebTransformAnimationCurve::create):
(WebKit::WebTransformAnimationCurveImpl::WebTransformAnimationCurveImpl):
* src/WebTransformAnimationCurveImpl.h:
(WebTransformAnimationCurveImpl):
* src/WebVideoLayerImpl.cpp:
(WebKit::WebVideoLayer::create):
(WebKit::WebVideoLayerImpl::WebVideoLayerImpl):
* src/WebVideoLayerImpl.h:
(WebVideoLayerImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r127309.
commit-queue@webkit.org [Fri, 31 Aug 2012 23:42:35 +0000 (23:42 +0000)]
Unreviewed, rolling out r127309.
http://trac.webkit.org/changeset/127309
https://bugs.webkit.org/show_bug.cgi?id=95624

The Windows tests weren't actually fixed. (Requested by
mhahnenberg on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-31

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago [WK2] WebProcesses should not wait 60 seconds to close in multi-process mode
ap@apple.com [Fri, 31 Aug 2012 23:27:27 +0000 (23:27 +0000)]
    [WK2] WebProcesses should not wait 60 seconds to close in multi-process mode
        https://bugs.webkit.org/show_bug.cgi?id=95616

        Reviewed by Darin Adler.

        * Shared/ChildProcess.cpp: (WebKit::ChildProcess::ChildProcess):
        * Shared/ChildProcess.h: (WebKit::ChildProcess::setTerminationTimeout):
        Expose a setter for timeout instead of taking it at construction time. If a derived
        class doesn't call the setter, default to 0.

        * PluginProcess/PluginProcess.cpp:
        (WebKit::PluginProcess::PluginProcess):
        (WebKit::PluginProcess::initializePluginProcess):
        Use timeout from initialization message.

        * WebProcess/WebProcess.cpp:
        (WebKit::WebProcess::WebProcess):
        (WebKit::WebProcess::initializeWebProcess):
        Ditto.

        * Shared/Plugins/PluginProcessCreationParameters.cpp:
        (WebKit::PluginProcessCreationParameters::encode):
        (WebKit::PluginProcessCreationParameters::decode):
        * Shared/Plugins/PluginProcessCreationParameters.h:
        * Shared/WebProcessCreationParameters.cpp:
        (WebKit::WebProcessCreationParameters::encode):
        (WebKit::WebProcessCreationParameters::decode):
        * Shared/WebProcessCreationParameters.h:
        Funnel timeout across process boundary.

        * UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::didFinishLaunching):
        Pass timeout as initialization message after launch.

        * UIProcess/WebContext.cpp:
        (WebKit::WebContext::createNewWebProcess): Pass timeout as initialization message
        (unlike plugin process proxy, web process proxy doesn't wait, and relies on the message
        being queued).
        (WebKit::WebContext::disconnectProcess): Skip invalidating global managers when
        one process quits. We still need to do something, but running this code would just
        result in assertion failures any time a page was closed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRefactor LLInt and supporting code in preparation for the C Loop backend.
commit-queue@webkit.org [Fri, 31 Aug 2012 23:25:28 +0000 (23:25 +0000)]
Refactor LLInt and supporting code in preparation for the C Loop backend.
https://bugs.webkit.org/show_bug.cgi?id=95531.

Patch by Mark Lam <mark.lam@apple.com> on 2012-08-31
Reviewed by Filip Pizlo.

* bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFromLLInt):
* bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFromLLInt):
* jit/JITExceptions.cpp:
(JSC::genericThrow): Use ExecutableBase::catchRoutineFor() to fetch
    fetch the catch routine for a thrown exception.  This will allow
    us to redefine that for the C loop later, and still keep this
    code readable.
* llint/LLIntOfflineAsmConfig.h: Moved ASM macros to
    LowLevelInterpreter.cpp which is the only place they are used. This
    will make it more convenient to redefine them for the C loop later.
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::setUpCall): Use ExecutableBase's hostCodeEntry()
    jsCodeEntryFor(), and jsCodeWithArityCheckEntryFor() for computing
    the entry points to functions being called.
* llint/LLIntSlowPaths.h:
(SlowPathReturnType):
(JSC::LLInt::encodeResult):
(LLInt):
(JSC::LLInt::decodeResult): Added.  Needed by LLInt C Loop later.
* llint/LowLevelInterpreter.asm:
* llint/LowLevelInterpreter.cpp:
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:
* offlineasm/asm.rb: Disambiguate between opcodes and other labels.
* offlineasm/config.rb:
* runtime/Executable.h:
(JSC::ExecutableBase::hostCodeEntryFor): Added.
(ExecutableBase):
(JSC::ExecutableBase::jsCodeEntryFor): Added.
(JSC::ExecutableBase::jsCodeWithArityCheckEntryFor): Added.
(JSC::ExecutableBase::catchRoutineFor): Added.
* runtime/JSValueInlineMethods.h:
(JSC):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Lion] css3/filters/composited-during-animation-layertree.html produces empty results
jberlin@webkit.org [Fri, 31 Aug 2012 23:16:39 +0000 (23:16 +0000)]
[Lion] css3/filters/composited-during-animation-layertree.html produces empty results
https://bugs.webkit.org/show_bug.cgi?id=95622

Move the empty results to mac-lion and add the ML results to mac to get the bots greener.

* platform/mac-lion/css3/filters/composited-during-animation-layertree-expected.txt: Copied from LayoutTests/platform/mac/css3/filters/composited-during-animation-layertree-expected.txt.
* platform/mac/css3/filters/composited-during-animation-layertree-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Getting rid of Windows specific results because CSS3 flexbox has been...
roger_fong@apple.com [Fri, 31 Aug 2012 23:08:00 +0000 (23:08 +0000)]
Unreviewed. Getting rid of Windows specific results because CSS3 flexbox has been re-enabled here: https://bugs.webkit.org/show_bug.cgi?id=95382

* platform/win/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
* platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Mountain Lion] platform/mac/editing/spelling/removing-underline-after-accepting...
jberlin@webkit.org [Fri, 31 Aug 2012 23:00:17 +0000 (23:00 +0000)]
[Mountain Lion] platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation.html failing.
https://bugs.webkit.org/show_bug.cgi?id=95477

Add Mountain Lion expected (failing?) results and move the ones previously in mac to mac-lion to get the bots greener.

* platform/mac-lion/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation-expected.png: Renamed from LayoutTests/platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation-expected.png.
* platform/mac-lion/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation-expected.txt: Copied from LayoutTests/platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation-expected.txt.
* platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed update of fast/js/function-constructor-this-value.html expectations on...
pdr@google.com [Fri, 31 Aug 2012 22:56:22 +0000 (22:56 +0000)]
Unreviewed update of fast/js/function-constructor-this-value.html expectations on Chromium
https://bugs.webkit.org/show_bug.cgi?id=95617

This test was added in r127323 but fails on Chromium ports.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Assert on ChromeClientGtk::scroll with delta (0, -1).
commit-queue@webkit.org [Fri, 31 Aug 2012 22:51:58 +0000 (22:51 +0000)]
[GTK] Assert on ChromeClientGtk::scroll with delta (0, -1).
https://bugs.webkit.org/show_bug.cgi?id=95590

Change the assert to avoid hitting when the delta does not have any
value > 0.

Patch by José Dapena Paz <jdapena@igalia.com> on 2012-08-31
Reviewed by Martin Robinson.

* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::scroll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIntroduce new CSS property for clip-path
krit@webkit.org [Fri, 31 Aug 2012 22:29:48 +0000 (22:29 +0000)]
Introduce new CSS property for clip-path
https://bugs.webkit.org/show_bug.cgi?id=95474

Reviewed by Tim Horton.

Source/WebCore:

This path introduces the new, prefixed CSS property 'clip-path' from the
CSS Masking specification. In a first step the property just accepts
'none' and the the basic shapes from CSS Exclusion. Later it will also be
possible to reference SVG 'clipPath' elements - like Firefox already does.
To enable the parsing of the shapes, the exclusion compiler flags
around the shape parser were removed.

http://dvcs.w3.org/hg/FXTF/raw-file/tip/masking/index.html

Test: fast/masking/parsing-clip-path-shape.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Return CSSValue for CSSPropertyWebkitClipPath.
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue): Add CSSPropertyWebkitClipPath.
(WebCore::CSSParser::parseBasicShape): Modify parser function to accept CSSPropertyWebkitClipPath as well.
* css/CSSParser.h:
* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
* css/CSSPropertyNames.in: Added property name -webkit-clip-path.
* css/StyleBuilder.cpp:
(ApplyPropertyClipPath): New property applier just for -webkit-clip-path.
(WebCore::ApplyPropertyClipPath::setValue):
(WebCore::ApplyPropertyClipPath::applyValue):
(WebCore::ApplyPropertyClipPath::createHandler):
(WebCore::StyleBuilder::StyleBuilder):
* rendering/style/RenderStyle.cpp: Repaint if there is a difference between two BasicShapes.
(WebCore::RenderStyle::diff):
* rendering/style/RenderStyle.h:
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
(WebCore::StyleRareNonInheritedData::reportMemoryUsage):
* rendering/style/StyleRareNonInheritedData.h: Add new member variable for clip shape.
(StyleRareNonInheritedData):

LayoutTests:

Test parsing behavior of basic shapes on new introduced '-webkit-clip-path' CSS property.

* fast/masking/parsing-clip-path-shape-expected.txt: Added.
* fast/masking/parsing-clip-path-shape.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] ASSERT failure in RenderBlock::checkPositionedObjectsNeedLayout
zhajiang@rim.com [Fri, 31 Aug 2012 22:17:03 +0000 (22:17 +0000)]
[BlackBerry] ASSERT failure in RenderBlock::checkPositionedObjectsNeedLayout
https://bugs.webkit.org/show_bug.cgi?id=95611

Reviewed by Antonio Gomes.
Patch by Jacky Jiang <zhajiang@rim.com>

PR:200127
Remove r118405 now as we already have a new fix webkit/43f8394b for
that issue and it is not reproducible anymore after the removal.
In this way, we can get rid of this ASSERT failure as well.
Thanks Antonio for the suggestion.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Eliminate WebGL IT policy
rwlbuis@webkit.org [Fri, 31 Aug 2012 22:09:54 +0000 (22:09 +0000)]
[BlackBerry] Eliminate WebGL IT policy
https://bugs.webkit.org/show_bug.cgi?id=95604
Internal RIM PR #198764

Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-08-31
Reviewed by Rob Buis.

This is no longer a requirement for the BlackBerry port.

Source/WebCore:

No new tests, because this introduces no new functionality.

* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::create):

Source/WebKit/blackberry:

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPage::setWebGLEnabled):
* WebKitSupport/AboutData.cpp:
(BlackBerry::WebKit::configPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNot reviewed.
ggaren@apple.com [Fri, 31 Aug 2012 21:49:28 +0000 (21:49 +0000)]
Not reviewed.

Removed some tabs that snuck into my last patch.

* fast/js/function-constructor-this-value.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse one object instead of two for closures, eliminating ScopeChainNode
ggaren@apple.com [Fri, 31 Aug 2012 21:47:01 +0000 (21:47 +0000)]
Use one object instead of two for closures, eliminating ScopeChainNode
https://bugs.webkit.org/show_bug.cgi?id=95501

Reviewed by Sam Weinig.

Adding a test to demonstrate the behavior change in this patch.

* fast/js/function-constructor-this-value-expected.txt: Added.
* fast/js/function-constructor-this-value.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoondisplay event handlers are not called
jonlee@apple.com [Fri, 31 Aug 2012 21:26:44 +0000 (21:26 +0000)]
ondisplay event handlers are not called
https://bugs.webkit.org/show_bug.cgi?id=95263
<rdar://problem/12193359>

Reviewed by Alexey Proskuryakov.

Source/WebCore:

To support the legacy API, we conflate ondisplay and onshow.

* Modules/notifications/Notification.h:
(WebCore::Notification::ondisplay): Use display event as an alias for the show event.
(WebCore::Notification::setOndisplay):

LayoutTests:

Adjust the test to use the ondisplay handler, to fully test legacy API.

* http/tests/notifications/legacy/show-expected.txt: Verify that event listener for ondisplay is
the same as that for onshow.
* http/tests/notifications/legacy/show.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Adding passing test results for fast/canvas/canvas-strokeRect-alpha-shadow.
roger_fong@apple.com [Fri, 31 Aug 2012 21:24:55 +0000 (21:24 +0000)]
Unreviewed. Adding passing test results for fast/canvas/canvas-strokeRect-alpha-shadow.
Test passes on Windows port now but Mac port currently uses expected failing results.

* platform/win/fast/canvas/canvas-strokeRect-alpha-shadow-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago REGRESSION (r127252): incomplete repaint on Flash element after pinch to zoom
beidson@apple.com [Fri, 31 Aug 2012 21:18:51 +0000 (21:18 +0000)]
   REGRESSION (r127252): incomplete repaint on Flash element after pinch to zoom
       <rdar://problem/12217897> and https://bugs.webkit.org/show_bug.cgi?id=95607

       Reviewed by Simon Fraser.

       * WebProcess/Plugins/PluginView.cpp:
       (WebKit::PluginView::viewGeometryDidChange): Only give the window coordinate clip rect a chance
 to override the boundsRect() if the page scale factor is 1.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove ENABLE_CSS3_FLEXBOX compile time flag
tony@chromium.org [Fri, 31 Aug 2012 21:17:19 +0000 (21:17 +0000)]
Remove ENABLE_CSS3_FLEXBOX compile time flag
https://bugs.webkit.org/show_bug.cgi?id=95382

Reviewed by Ojan Vafai.

Everyone is already enabling this by default and the spec has stablized.

.:

* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:
* configure.ac:

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

No new tests, shouldn't change anything.

* Configurations/FeatureDefines.xcconfig:
* GNUmakefile.am:
* GNUmakefile.features.am:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue): Expand check range to include flex and inline-flex.
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
* css/CSSPropertyNames.in:
* css/CSSValueKeywords.in:
* css/StyleBuilder.cpp:
(WebCore::StyleBuilder::StyleBuilder):
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getPropertyValue):
(WebCore::StylePropertySet::asText):
* css/StylePropertyShorthand.cpp:
(WebCore::webkitFlexShorthand):
(WebCore::shorthandForProperty):
* css/StylePropertyShorthand.h:
(WebCore):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
* page/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimation::ensurePropertyMap):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::createObject):
* rendering/style/RenderStyle.h:
* rendering/style/RenderStyleConstants.h:

Source/WebKit/chromium:

* features.gypi:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Tools:

* Scripts/webkitperl/FeatureList.pm:
* qmake/mkspecs/features/features.pri:

WebKitLibraries:

* win/tools/vsprops/FeatureDefines.vsprops:
* win/tools/vsprops/FeatureDefinesCairo.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Add main versus impl thread asserts
commit-queue@webkit.org [Fri, 31 Aug 2012 21:11:23 +0000 (21:11 +0000)]
[chromium] Add main versus impl thread asserts
https://bugs.webkit.org/show_bug.cgi?id=95596

Patch by Christopher Cameron <ccameron@chromium.org> on 2012-08-31
Reviewed by James Robinson.

Add asserts to prioritized texture manager that specify that a
function be called on the main or impl thread.

Add debug signs that the main thread is blocked to the threaded
proxy.

Add a mechanism to simultaneously set the thread to the impl thread
and indicate that the main thread is blocked.

Update tests that hit asserts in the prioritized texture manager to
set their impl thread and main thread blocked state correctly.

Source/WebCore:

* platform/graphics/chromium/cc/CCPrioritizedTextureManager.cpp:
(WebCore::CCPrioritizedTextureManager::prioritizeTextures):
(WebCore::CCPrioritizedTextureManager::clearPriorities):
(WebCore::CCPrioritizedTextureManager::requestLate):
(WebCore::CCPrioritizedTextureManager::acquireBackingTextureIfNeeded):
(WebCore::CCPrioritizedTextureManager::reduceMemory):
(WebCore::CCPrioritizedTextureManager::registerTexture):
(WebCore::CCPrioritizedTextureManager::unregisterTexture):
(WebCore::CCPrioritizedTextureManager::returnBackingTexture):
(WebCore::CCPrioritizedTextureManager::createBacking):
(WebCore::CCPrioritizedTextureManager::assertInvariants):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(WebCore):
(DebugScopedSetImplThreadAndMainThreadBlocked):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::finishAllRendering):
(WebCore::CCThreadProxy::setVisible):
(WebCore::CCThreadProxy::initializeRenderer):
(WebCore::CCThreadProxy::recreateContext):
(WebCore::CCThreadProxy::implSideRenderingStats):
(WebCore::CCThreadProxy::start):
(WebCore::CCThreadProxy::forceSerializeOnSwapBuffers):
(WebCore::CCThreadProxy::acquireLayerTextures):

Source/WebKit/chromium:

* tests/CCPrioritizedTextureTest.cpp:
(WTF::CCPrioritizedTextureTest::CCPrioritizedTextureTest):
(WTF::CCPrioritizedTextureTest::~CCPrioritizedTextureTest):
(WTF::CCPrioritizedTextureTest::validateTexture):
(WTF::TEST_F):
* tests/TiledLayerChromiumTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed update of fast/js/function-apply-aliased.html expectations.
pdr@google.com [Fri, 31 Aug 2012 21:03:36 +0000 (21:03 +0000)]
Unreviewed update of fast/js/function-apply-aliased.html expectations.

fast/js/function-apply-aliased.html has been failing for TEXT for some time but
the chromium-mac TestExpectations did not have an entry for mac. This patch
updates the expectations to include all platforms.

The bug (crbug.com/48239) has been updated to reflect this.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLayoutTests/http/tests/websocket/tests/hixie76/frame-lengths.html was removed. Remove...
jberlin@webkit.org [Fri, 31 Aug 2012 20:55:12 +0000 (20:55 +0000)]
LayoutTests/http/tests/websocket/tests/hixie76/frame-lengths.html was removed. Remove it from the Skipped list.

* platform/mac-wk2/Skipped:
* platform/qt-arm/Skipped:
* platform/wincairo/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agocompositing/tiling/huge-layer* flakey
jberlin@webkit.org [Fri, 31 Aug 2012 20:55:07 +0000 (20:55 +0000)]
compositing/tiling/huge-layer* flakey
https://bugs.webkit.org/show_bug.cgi?id=48454

These tests were disabled in r89631. Remove them from the Skipped list so that
run-webkit-tests doesn't try to find them.

* platform/win/Skipped:
* platform/wincairo/Skipped:
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoobjc_msgSend and IMP should be cast appropriately before using
psolanki@apple.com [Fri, 31 Aug 2012 20:47:56 +0000 (20:47 +0000)]
objc_msgSend and IMP should be cast appropriately before using
https://bugs.webkit.org/show_bug.cgi?id=95242

Reviewed by Benjamin Poulain.

Follow on fix for Mac EWS - use objc-runtime.h instead of runtime.h so
that it finds the declaration for objc_msgSend.

* UIProcess/API/mac/PDFViewController.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoThe fast/forms/ file tests were moved in the file sub-directory in r96918. Remove the
jberlin@webkit.org [Fri, 31 Aug 2012 20:41:21 +0000 (20:41 +0000)]
The fast/forms/ file tests were moved in the file sub-directory in r96918. Remove the
old entries from the Skipped list.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Put compositor client interfaces in separate headers, normalize naming
jamesr@google.com [Fri, 31 Aug 2012 20:40:39 +0000 (20:40 +0000)]
[chromium] Put compositor client interfaces in separate headers, normalize naming
https://bugs.webkit.org/show_bug.cgi?id=95522

Reviewed by Adam Barth.

Source/WebCore:

Client interfaces should be in their own headers so code implementing these interfaces do not have to
transitively #include all of the compositor internals.

We call things 'clients' not 'delegates' in the compositor.

* WebCore.gypi:
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerPainter::ContentLayerPainter):
(WebCore::ContentLayerPainter::create):
(WebCore::ContentLayerPainter::paint):
(WebCore::ContentLayerChromium::create):
(WebCore::ContentLayerChromium::ContentLayerChromium):
(WebCore::ContentLayerChromium::drawsContent):
(WebCore::ContentLayerChromium::createTextureUpdaterIfNeeded):
* platform/graphics/chromium/ContentLayerChromium.h:
(WebCore):
(ContentLayerPainter):
(ContentLayerChromium):
(WebCore::ContentLayerChromium::clearClient):
* platform/graphics/chromium/TextureLayerChromium.cpp:
* platform/graphics/chromium/TextureLayerChromium.h:
(WebCore):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore):

Source/WebKit/chromium:

* src/WebContentLayerImpl.cpp:
(WebKit::WebContentLayerImpl::~WebContentLayerImpl):
* src/WebContentLayerImpl.h:
(WebContentLayerImpl):
* src/WebExternalTextureLayerImpl.h:
* src/WebLayerTreeViewImpl.h:
(WebCore):
* tests/CCLayerTreeHostCommonTest.cpp:
* tests/CCLayerTreeHostTest.cpp:
(WebKitTests::ContentLayerChromiumWithUpdateTracking::create):
(WebKitTests::ContentLayerChromiumWithUpdateTracking::ContentLayerChromiumWithUpdateTracking):
(WebKitTests::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers):
(WebKitTests::CCLayerTreeHostTestAtomicCommit::CCLayerTreeHostTestAtomicCommit):
(WebKitTests::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::CCLayerTreeHostTestAtomicCommitWithPartialUpdate):
(WebKitTests::CCLayerTreeHostTestLostContextWhileUpdatingResources::CCLayerTreeHostTestLostContextWhileUpdatingResources):
(CCLayerTreeHostTestLostContextWhileUpdatingResources):
* tests/ContentLayerChromiumTest.cpp:
(WebKit::MockContentLayerChromiumClient::MockContentLayerChromiumClient):
(WebKit::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening. Adding fast/css/nested-layers-with-over.html to Windows skip...
roger_fong@apple.com [Fri, 31 Aug 2012 20:36:49 +0000 (20:36 +0000)]
Unreviewed gardening. Adding fast/css/nested-layers-with-over.html to Windows skip list.
https://bugs.webkit.org/show_bug.cgi?id=95388

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnskip plugins/npruntime/delete-plugin-within-* tests on Windows
mhahnenberg@apple.com [Fri, 31 Aug 2012 20:32:15 +0000 (20:32 +0000)]
Unskip plugins/npruntime/delete-plugin-within-* tests on Windows
https://bugs.webkit.org/show_bug.cgi?id=95597

Reviewed by Darin Adler.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Skip http/tests/notifications on Lion, since there is no support.
jonlee@apple.com [Fri, 31 Aug 2012 20:28:49 +0000 (20:28 +0000)]
Unreviewed. Skip http/tests/notifications on Lion, since there is no support.

* platform/mac-lion/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Adding expected failing results for accessibility/canvas tests.
roger_fong@apple.com [Fri, 31 Aug 2012 20:15:56 +0000 (20:15 +0000)]
Unreviewed. Adding expected failing results for accessibility/canvas tests.
https://bugs.webkit.org/show_bug.cgi?id=95598

Windows description and role strings don't match up with what is expected on Mac.
Particularly, they do not include the "AX" at the beginning of the descriptions/roles of canvas fallback content.

* platform/win/accessibility/canvas-description-and-role-expected.txt: Added.
* platform/win/accessibility/canvas-fallback-content-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoobjc_msgSend and IMP should be cast appropriately before using
psolanki@apple.com [Fri, 31 Aug 2012 20:11:26 +0000 (20:11 +0000)]
objc_msgSend and IMP should be cast appropriately before using
https://bugs.webkit.org/show_bug.cgi?id=95242

Reviewed by Benjamin Poulain.

Fix for older compilers. Pass id as the return type to the template
instead of relying on default type.

Source/WebKit/mac:

* WebView/WebDelegateImplementationCaching.mm:
(CallDelegate):
(CallFormDelegate):
* WebView/WebHTMLView.mm:
(setCursor):
(setNeedsDisplayInRect):

Source/WTF:

* wtf/Functional.h:
(WTF::R):
* wtf/ObjcRuntimeExtras.h:

Tools:

* DumpRenderTree/mac/DumpRenderTree.mm:
(drt_NSFontManager_availableFontFamilies):
* WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
(WTR::wtr_NSFontManager_availableFontFamilies):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] DEPS roll with a test skip.
gavinp@chromium.org [Fri, 31 Aug 2012 20:10:29 +0000 (20:10 +0000)]
[chromium] DEPS roll with a test skip.
https://bugs.webkit.org/show_bug.cgi?id=95601

Unreviewed gardening & DEPS roll.

Source/WebKit/chromium:

fast/frames/cached-frame-counter.html was never the most stable test, and now it's failing on more platforms. Marking it flaky, along with a DEPS roll (earlier attempts at the DEPS roll failed on this)

* DEPS:

LayoutTests:

fast/frames/cached-frame-counter.html was never the most stable test, and now it's failing on more platforms. Marking it flaky, along with a DEPS roll (earlier attempts at the DEPS roll failed on this)

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNot reviewed.
ggaren@apple.com [Fri, 31 Aug 2012 20:10:09 +0000 (20:10 +0000)]
Not reviewed.

Rolled out http://trac.webkit.org/changeset/127293 because it broke
inspector tests on Windows.

    Shrink activation objects by half
    https://bugs.webkit.org/show_bug.cgi?id=95591

    Reviewed by Sam Weinig.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix the Debug builds after r127277
benjamin@webkit.org [Fri, 31 Aug 2012 19:51:17 +0000 (19:51 +0000)]
Fix the Debug builds after r127277

Unreviewed.

One assertion was not updated in r127277. The encapsulation of CSSParserString's length
has changed and now use an accessor.

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-08-31

* css/CSSParser.cpp:
(WebCore::CSSParser::storeVariableDeclaration):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonrwt: use scm instead of calling svn directly to get the revision in json results...
zandobersek@gmail.com [Fri, 31 Aug 2012 19:49:00 +0000 (19:49 +0000)]
nrwt: use scm instead of calling svn directly to get the revision in json results generator
https://bugs.webkit.org/show_bug.cgi?id=89616

Reviewed by Eric Seidel.

Add the new 'executive' optional function argument to the SCM.in_working_directory
class method. This way we get to reuse an Executive instance which is necessary in testing
when we're operating with a mock version of the object.

In JSONResultsGeneratorBase, it's now possible to get the current SVN revision by using
the SCMDetector with the generator's FileSystem and Executive instances.

* Scripts/webkitpy/common/checkout/scm/detection.py:
(SCMDetector.detect_scm_system):
* Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
(SCMDetectorTest.test_detect_scm_system): Update the unit test to capture the mock
Executive output and test it against expected output.
* Scripts/webkitpy/common/checkout/scm/git.py:
(Git.in_working_directory):
* Scripts/webkitpy/common/checkout/scm/scm.py:
(SCM.in_working_directory):
* Scripts/webkitpy/common/checkout/scm/svn.py:
(SVN.in_working_directory):
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
(JSONResultsGeneratorBase.__init__):
(JSONResultsGeneratorBase._get_svn_revision):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago(Regression: r126774): Fix crash when scrolling after removing inline sticky element
simon.fraser@apple.com [Fri, 31 Aug 2012 19:38:40 +0000 (19:38 +0000)]
(Regression: r126774): Fix crash when scrolling after removing inline sticky element
https://bugs.webkit.org/show_bug.cgi?id=95584

Reviewed by Dave Hyatt.

Source/WebCore:

Move fixed/sticky registration and unregistration with the FrameView from
RenderBox and RenderInline into RenderBoxModelObject, which also
fixes the issue that inlines didn't unregister themselves on destruction.

Test: fast/css/sticky/remove-inline-sticky-crash.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::willBeDestroyed): Code moved to RenderBoxModelObject. No need
to null-check style.
(WebCore::RenderBox::styleWillChange): Code moved to RenderBoxModelObject.
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::willBeDestroyed): Remove fixed objects. Check
isPositioned() to avoid this work for most non-positioned renderers.
(WebCore::RenderBoxModelObject::styleWillChange): Register and unregister fixed
and sticky objects with the FrameView.
* rendering/RenderInline.cpp: styleWillChange() is no longer needed.
* rendering/RenderInline.h: Ditto.

LayoutTests:

Testcase removes an inline sticky, then scrolls.

* fast/css/sticky/remove-inline-sticky-crash-expected.txt: Added.
* fast/css/sticky/remove-inline-sticky-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove extraneous includes (Node.h, Document.h, Element.h, RenderObject.h)
commit-queue@webkit.org [Fri, 31 Aug 2012 19:11:32 +0000 (19:11 +0000)]
Remove extraneous includes (Node.h, Document.h, Element.h, RenderObject.h)
https://bugs.webkit.org/show_bug.cgi?id=95259

Patch by Nikhil Bhargava <nbhargava@google.com> on 2012-08-31
Reviewed by Sam Weinig.

Node.h, Document.h, Element.h, and RenderObject.h are four of the most
expensive headers to include. This patch removes them from many of the
places they are not needed. There is a minor compile-time performance
boost.

* dom/ElementShadow.h:
* dom/Range.h:
(WebCore):
* dom/TreeScopeAdopter.h:
(WebCore):
* editing/VisiblePosition.h:
(WebCore):
* html/HTMLCollection.h:
(WebCore):
* html/parser/HTMLElementStack.h:
* html/parser/HTMLTreeBuilder.h:
(WebCore):
* html/track/WebVTTParser.h:
(WebCore):
* inspector/InspectorCSSAgent.h:
(WebCore):
* inspector/InspectorInstrumentation.h:
(WebCore):
* inspector/InspectorOverlay.h:
* loader/ImageLoader.h:
* loader/TextTrackLoader.h:
(WebCore):
* platform/chromium/PopupListBox.cpp:
* platform/chromium/PopupListBox.h:
(WebCore):
* platform/graphics/MediaPlayer.h:
(WebCore):
* rendering/FilterEffectRenderer.h:
* rendering/InlineFlowBox.cpp:
* rendering/RenderCounter.cpp:
* rendering/RenderGeometryMap.h:
(WebCore):
* rendering/RenderInputSpeech.h:
(WebCore):
* rendering/RenderMediaControls.h:
(WebCore):
* rendering/RenderMediaControlsChromium.h:
(WebCore):
* rendering/RenderQuote.cpp:
* rendering/RenderQuote.h:
(WebCore):
* rendering/RenderScrollbar.h:
(WebCore):
* rendering/RenderText.h:
(WebCore):
* rendering/RenderTheme.h:
(WebCore):
* rendering/RenderThemeChromiumSkia.h:
(WebCore):
* rendering/svg/RenderSVGResourceMarker.h:
(WebCore):
* svg/graphics/filters/SVGFilterBuilder.h:
(WebCore):
* xml/NativeXPathNSResolver.h:
(WebCore):
(NativeXPathNSResolver):
(WebCore::NativeXPathNSResolver::create):
* xml/XPathStep.h:
(WebCore):
(XPath):
(Step):
(NodeTest):
(WebCore::XPath::Step::NodeTest::NodeTest):
(WebCore::XPath::Step::NodeTest::kind):
(WebCore::XPath::Step::NodeTest::data):
(WebCore::XPath::Step::NodeTest::namespaceURI):
(WebCore::XPath::Step::NodeTest::mergedPredicates):
(WebCore::XPath::Step::axis):
(WebCore::XPath::Step::nodeTest):
* xml/parser/NewXMLDocumentParser.cpp:
* xml/parser/NewXMLDocumentParser.h:
(WebCore):
* xml/parser/XMLToken.h:
* xml/parser/XMLTreeBuilder.cpp:
* xml/parser/XMLTreeBuilder.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Tests] Add basic tests to http/tests/notifications
jonlee@apple.com [Fri, 31 Aug 2012 19:08:50 +0000 (19:08 +0000)]
[Tests] Add basic tests to http/tests/notifications
https://bugs.webkit.org/show_bug.cgi?id=95493
<rdar://problem/12209303>

Reviewed by Alexey Proskuryakov.

Source/WebKit2:

Simplify the passing of the permission policy to just a boolean instead of converting it
back and forth from the NotificationClient::Permission enum.

* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h: Move the declaration to the section
of functions that are TestRunner SPI.
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setWebNotificationPermission): Use a boolean.
* WebProcess/Notifications/NotificationPermissionRequestManager.cpp:
(WebKit::NotificationPermissionRequestManager::setPermissionLevelForTesting):
* WebProcess/Notifications/NotificationPermissionRequestManager.h:
(NotificationPermissionRequestManager):

* win/WebKit2.vcproj: Add WKNotificationPermissionRequest.{h,cpp}.
* win/WebKit2Generated.make: Export WKNotificationPermissionRequest.h.

Tools:

Add permission request support for WTR.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
(WTR::TestController::decidePolicyForNotificationPermissionRequest): Always allow.
* WebKitTestRunner/TestController.h:
(TestController):

LayoutTests:

* http/tests/notifications/request-expected.txt: Added.
* http/tests/notifications/request.html: Added. This test requests permission. DRT/WTR
is expected to accept it, and we verify that both the parameter in the callback function,
and Notification.permission, are both set to "granted".
* http/tests/notifications/show-expected.txt: Added.
* http/tests/notifications/show.html: Added. This test checks that the various permission
APIs on TestRunner work.

Legacy analog to above tests.
* http/tests/notifications/legacy/request-expected.txt: Added.
* http/tests/notifications/legacy/request.html: Added.
* http/tests/notifications/legacy/show-expected.txt: Added.
* http/tests/notifications/legacy/show.html: Added.

* http/tests/resources/js-test-post-async.js: Added. This will be used for most tests since
the events are called asynchronously.
* http/tests/resources/js-test-pre.js: Updated from fast/js/resources.
* http/tests/resources/notifications-test-pre.js: Added. Adds a helper function to complete
the test, and defines the domain of http/tests.
(testCompleted):

Skip.
* platform/chromium/TestExpectations: Skip on Android. Filed 95506 to bring Chromium support.
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/Skipped:
* platform/qt/Skipped: Filed 95507 to bring Qt support.
* platform/win/Skipped:
* platform/wincairo/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[DRT] Make simulating a web click on a notification a queued task
jonlee@apple.com [Fri, 31 Aug 2012 18:55:50 +0000 (18:55 +0000)]
[DRT] Make simulating a web click on a notification a queued task
https://bugs.webkit.org/show_bug.cgi?id=95546
<rdar://problem/12214170>

Reviewed by Alexey Proskuryakov.

Making the web click happen asynchronously better mimics user interaction with the platform.

* DumpRenderTree/TestRunner.h: Add a flag that determines whether we have a pending notification click.
(TestRunner::hasPendingWebNotificationClick): Exposed so that dump() can check that the flag is
not set.
* DumpRenderTree/mac/DumpRenderTree.mm:
(dump): Assert that the flag is not set.
* DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::simulateWebNotificationClick): Set the flag, then add a task to click the
notification. In the case where the block gets executed after the flag has been unset, we avoid
performing the click.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[New Multicolumn] Implement column repainting.
hyatt@apple.com [Fri, 31 Aug 2012 18:51:39 +0000 (18:51 +0000)]
[New Multicolumn] Implement column repainting.
https://bugs.webkit.org/show_bug.cgi?id=95593

Reviewed by Dan Bernstein.

Make the new columns repaint properly. Note this code is a significant improvement over the
old multicolumn code in that repaints are properly issued per-column, i.e., no more fuzzy
uniting of rects.

* rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::columnIndexAtOffset):
(WebCore):
(WebCore::RenderMultiColumnSet::repaintFlowThreadContent):
* rendering/RenderMultiColumnSet.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed update of test expectations.
pdr@google.com [Fri, 31 Aug 2012 18:45:30 +0000 (18:45 +0000)]
Unreviewed update of test expectations.

Marking media/track/track-cue-rendering-snap-to-lines-not-set.html as
flaky again until WK89167 is fixed.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed Gardening. inspector/profiler/webgl/webgl-profiler-api-changes.html fails...
roger_fong@apple.com [Fri, 31 Aug 2012 18:25:30 +0000 (18:25 +0000)]
Unreviewed Gardening. inspector/profiler/webgl/webgl-profiler-api-changes.html fails on Windows.
WebGL not enabled on Windows.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Layout tests svg-filters.html and alpha.html are crashing intermittently
alokp@chromium.org [Fri, 31 Aug 2012 18:24:26 +0000 (18:24 +0000)]
[chromium] Layout tests svg-filters.html and alpha.html are crashing intermittently
https://bugs.webkit.org/show_bug.cgi?id=92660

Reviewed by James Robinson.

We use two GL contexts to create and upload tile textures.
One context creates the texture, while another uploads it.
Even though the texture is shared by the two contexts, it is not
available to the uploading context immediately after creation,
unless the creating context is flushed.

* platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:
(WebCore::createAcceleratedCanvas):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::updateTextureRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoShrink activation objects by half
ggaren@apple.com [Fri, 31 Aug 2012 18:22:01 +0000 (18:22 +0000)]
Shrink activation objects by half
https://bugs.webkit.org/show_bug.cgi?id=95591

Reviewed by Sam Weinig.

Removed the global object, global data, and global this pointers from
JSScope, and changed an int to a bitfield. This gets the JSActivation
class down to 64 bytes, which in practice cuts it in half by getting it
out of the 128 byte size class.

Now, it's one extra indirection to get these pointers. These pointers
aren't accessed by JIT code, so I thought there would be no cost to the
extra indirection. However, some C++-heavy SunSpider tests regressed a
bit in an early version of the patch, which added even more indirection.
This suggests that calls to exec->globalData() and/or exec->lexicalGlobalObject()
are common and probably duplicated in lots of places, and could stand
further optimization in C++.

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute): Test against the specific activation
for our global object, since there's no VM-shared activation structure
anymore. This is guaranteed to have the same success rate as the old test
because activation scope is fixed at compile time.

* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::MarkedBlock):
* heap/MarkedBlock.h:
(JSC::MarkedBlock::globalData):
* heap/WeakSet.cpp:
(JSC::WeakSet::addAllocator):
* heap/WeakSet.h:
(WeakSet):
(JSC::WeakSet::WeakSet):
(JSC::WeakSet::globalData): Store a JSGlobalData* instead of a Heap*
because JSGlobalData->Heap is just a constant fold in the addressing
mode, while Heap->JSGlobalData is an extra pointer dereference. (These
objects should eventually just merge.)

* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_resolve_global_dynamic): See DFGAbstractState.cpp.

* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm: Load the activation structure from
the code block instead of the global data because the structure is not
VM-shared anymore. (See DFGAbstractState.cpp.)

* runtime/JSActivation.cpp:
(JSC::JSActivation::JSActivation):
* runtime/JSActivation.h:
(JSActivation): This is the point of the patch: Remove the data.

* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:
(JSGlobalData): No longer VM-shared. (See DFGAbstractState.cpp.)

(JSC::WeakSet::heap): (See WeakSet.h.)

* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::JSGlobalObject):
(JSC::JSGlobalObject::setGlobalThis):
(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::visitChildren):
* runtime/JSGlobalObject.h:
(JSGlobalObject):
(JSC::JSGlobalObject::withScopeStructure):
(JSC::JSGlobalObject::strictEvalActivationStructure):
(JSC::JSGlobalObject::activationStructure):
(JSC::JSGlobalObject::nameScopeStructure):
(JSC::JSScope::globalThis):
(JSC::JSGlobalObject::globalThis): Data that used to be in the JSScope
class goes here now, so it's not duplicated across all activations.

* runtime/JSNameScope.h:
(JSC::JSNameScope::JSNameScope):
* runtime/JSScope.cpp:
(JSC::JSScope::visitChildren): This is the point of the patch: Remove the data.

* runtime/JSScope.h:
(JSScope):
(JSC::JSScope::JSScope):
(JSC::JSScope::globalObject):
(JSC::JSScope::globalData):
* runtime/JSSegmentedVariableObject.h:
(JSC::JSSegmentedVariableObject::JSSegmentedVariableObject):
* runtime/JSSymbolTableObject.h:
(JSC::JSSymbolTableObject::JSSymbolTableObject):
* runtime/JSVariableObject.h:
(JSC::JSVariableObject::JSVariableObject):
* runtime/JSWithScope.h:
(JSC::JSWithScope::JSWithScope):
* runtime/StrictEvalActivation.cpp:
(JSC::StrictEvalActivation::StrictEvalActivation): Simplified now that
we don't need to pass so much data to JSScope.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMark http/tests/security/inactive-document-with-empty-security-origin.html while...
jberlin@webkit.org [Fri, 31 Aug 2012 18:12:59 +0000 (18:12 +0000)]
Mark http/tests/security/inactive-document-with-empty-security-origin.html while Geoff Garen
investigates in https://bugs.webkit.org/show_bug.cgi?id=95501 in order to get the bots green.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Fix platform/chromium/TestExpectations typo
gavinp@chromium.org [Fri, 31 Aug 2012 18:07:10 +0000 (18:07 +0000)]
[chromium] Fix platform/chromium/TestExpectations typo
https://bugs.webkit.org/show_bug.cgi?id=95592

Unreviewed gardening.

Unfortunately r127174 contained a typo that broke webkit-lint on our build. See https://bugs.webkit.org/show_bug.cgi?id=95581 .

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofast/css/align-positioned-object-on-resize.html skipped on Mac platforms
jberlin@webkit.org [Fri, 31 Aug 2012 18:00:24 +0000 (18:00 +0000)]
fast/css/align-positioned-object-on-resize.html skipped on Mac platforms
https://bugs.webkit.org/show_bug.cgi?id=83489

This test was removed in r126911. Remove it from the Skipped list.

* platform/mac/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttp/tests/cache/cancel-in-progress-load.html fails on several platforms
jberlin@webkit.org [Fri, 31 Aug 2012 18:00:20 +0000 (18:00 +0000)]
http/tests/cache/cancel-in-progress-load.html fails on several platforms
https://bugs.webkit.org/show_bug.cgi?id=87728

The test was rolled out in r119918. Remove it from the Skipped list so that run-webkit-tests
doesn't complain about not being able to find the test.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoplugins/npruntime/leak-window-scriptable-object.html is failing
jberlin@webkit.org [Fri, 31 Aug 2012 18:00:17 +0000 (18:00 +0000)]
plugins/npruntime/leak-window-scriptable-object.html is failing
https://bugs.webkit.org/show_bug.cgi?id=90710

This test was removed in r91637. Remove it from the Skipped list so that run-webkit-tests
doesn't complain about not being able to find the test.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] http/tests/cookies/js-get-and-set-http-only-cookie.html failing since introducti...
jberlin@webkit.org [Fri, 31 Aug 2012 18:00:13 +0000 (18:00 +0000)]
[Qt] http/tests/cookies/js-get-and-set-http-only-cookie.html failing since introduction in r119947
https://bugs.webkit.org/show_bug.cgi?id=87208

The .php version was removed in r118166, but the .html version it was replaced with in r119947
was separately marked as failing on Qt. Update the Skipped lists so that run-webkit-tests
doesn't complain about not being able to find the test on Mac (and so that the comment in the
Qt Skipped list is correct).

* platform/mac/Skipped:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofast/workers/storage/interrupt-database-sync.html fails intermittently
jberlin@webkit.org [Fri, 31 Aug 2012 18:00:08 +0000 (18:00 +0000)]
fast/workers/storage/interrupt-database-sync.html fails intermittently
https://bugs.webkit.org/show_bug.cgi?id=49906

The test was disabled in r81333, so remove it from the Skipped lists so that run-webkit-tests
doesn't complain about not being able to find the test.

* platform/win-xp/Skipped:
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMark fast/dom/shadow/shadowdom-for-textarea-complex-shadow.html as failing on mac
pdr@google.com [Fri, 31 Aug 2012 17:45:35 +0000 (17:45 +0000)]
Mark fast/dom/shadow/shadowdom-for-textarea-complex-shadow.html as failing on mac
https://bugs.webkit.org/show_bug.cgi?id=95588

Unreviewed gardening.

This test is failing on mac due to the sizing of the textbox: in the
expected results there is no scrollbar but in the actual results there
is one. This patch marks this test as failing temporarily.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[New Multicolumn] Refactor flow thread repainting.
hyatt@apple.com [Fri, 31 Aug 2012 17:37:47 +0000 (17:37 +0000)]
[New Multicolumn] Refactor flow thread repainting.
https://bugs.webkit.org/show_bug.cgi?id=95586

Reviewed by Simon Fraser.

Refactor flow thread repainting in regions to delegate the work to the region. This allows subclasses
to customize how the repainting happens so that individual repaints can be issued for columns and pages
inside sets.

repaintFlowThreadContent is the new virtual function that can be subclassed by sets to customize
the repaint process.

repaintFlowThreadContentRectangle is a parameterized helper that will be called for each individual
column and page in a set.

* WebCore.exp.in:
Change repaintRectangle's signature to be const.

* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::repaintRectangleInRegions):
Now delegates the work for each region to RenderRegion::repaintFlowThreadContent.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintUsingContainer):
(WebCore::RenderObject::repaint):
(WebCore::RenderObject::repaintRectangle):
(WebCore::RenderObject::isRooted):
* rendering/RenderObject.h:
Change a bunch of functions to be const.

* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::repaintFlowThreadContent):
(WebCore):
(WebCore::RenderRegion::repaintFlowThreadContentRectangle):
* rendering/RenderRegion.h:
(RenderRegion):
Add the two new functions (the virtual repaintFlowThreadContent and the helper it
uses, repaintFlowThreadContentRectangle).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r127182.
commit-queue@webkit.org [Fri, 31 Aug 2012 17:34:49 +0000 (17:34 +0000)]
Unreviewed, rolling out r127182.
http://trac.webkit.org/changeset/127182
https://bugs.webkit.org/show_bug.cgi?id=95587

Reftests shouldn't be rebaselined (Requested by pdr on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-31

* platform/chromium-mac-snowleopard/fast/dom/shadow/shadowdom-for-textarea-complex-shadow-expected.png: Removed.
* platform/chromium-mac/fast/dom/shadow/shadowdom-for-textarea-complex-shadow-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Disable GCController timer for PLATFORM(BLACKBERRY)
yoli@rim.com [Fri, 31 Aug 2012 17:28:30 +0000 (17:28 +0000)]
[BlackBerry] Disable GCController timer for PLATFORM(BLACKBERRY)
https://bugs.webkit.org/show_bug.cgi?id=93007

Reviewed by Rob Buis.

Disable GCController timer.

* bindings/js/GCController.cpp:
(WebCore::GCController::GCController):
(WebCore::GCController::garbageCollectSoon):
(WebCore):
* bindings/js/GCController.h:
(GCController):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCSS Parser should directly parse 8 bit source strings
msaboff@apple.com [Fri, 31 Aug 2012 17:26:31 +0000 (17:26 +0000)]
CSS Parser should directly parse 8 bit source strings
https://bugs.webkit.org/show_bug.cgi?id=95207

Reviewed by Geoffrey Garen.

Source/WebCore:

Changed CSSParser to handle 8 bit strings directly. Templatized most private parsing methods
and helper methods by character type. Introduced several templatized helper methods for
parsing methods. Some of these helper methods have independent source and destination template
types to handle that an 8 bit source string when parsed produces a 16 bit result. This is due
to unicode escapes. Renamed the lex method "realLex" and made it a templated method. The lex
method that is called by cssyylex(), which is now inlined, invokes the correct instance of realLex
via a member function pointer.

Split out the encoding part of parseEscape() into a new templated UnicodeToChars() method.

Added 8/16 bit switching to CSSParserString as well as added initialization, setters and getters.
Note that CSSParserString must have a default constructor as it is part of the YYLVAL union.
Therefore created init() methods instead of constructors. Many of the parser function now directly
modify the instance in yylval. Made supporting changes in other webcore classes that are used
directly by CSSParser.

Test: fast/css/unicode-escape-in-8bit-string.html

* css/CSSGrammar.y: Removed cssyylex() and changed manipulation of CSSParserString objects to
use newly written methods instead of direct manipulation of attributes.

* css/CSSParser.cpp:
Templatized new or existing helper methods
(WebCore::makeLower):
(WebCore::isCSSLetter):
(WebCore::isCSSEscape):
(WebCore::isURILetter):
(WebCore::isIdentifierStartAfterDash):
(WebCore::isEqualToCSSIdentifier):
(WebCore::checkAndSkipEscape):
(WebCore::checkForValidDouble):
(WebCore::parseDouble):
(WebCore::parseColorIntOrPercentage):
(WebCore::isTenthAlpha):
(WebCore::parseAlphaValue):
(WebCore::mightBeRGBA):
(WebCore::mightBeRGB):
(WebCore::fastParseColorInternal):
(WebCore::CSSParser::fastParseColor):
(WebCore::CSSParser::parseImageSet):
(WebCore::skipWhiteSpace):
(WebCore::CSSParser::currentCharacter16):
(WebCore::CSSParser::isIdentifierStart):
(WebCore::CSSParser::checkAndSkipString):
(WebCore::CSSParser::parseUnicodeRange):
(WebCore::CSSParser::parseNthChild):
(WebCore::CSSParser::parseNthChildExtra):
(WebCore::CSSParser::detectFunctionTypeToken):
(WebCore::CSSParser::detectMediaQueryToken):
(WebCore::CSSParser::detectNumberToken):
(WebCore::CSSParser::detectDashToken):
(WebCore::CSSParser::detectAtToken):
(WebCore::CSSParser::setRuleHeaderEnd):
(WebCore::cssPropertyID):
(WebCore::isCSSTokenizerIdentifier):
(WebCore::isCSSTokenizerURL):

(WebCore::CSSParser::CSSParser): Updated constructor for initializing new attributes.

(WebCore::CSSParserString::lower): Calls new makeLower() template helper.

(WebCore::CSSParser::setupParser): Added 8 bit path and set up parser appropriate to
string type.

(WebCore::equal): Updated to use CSSParserString getters and StringImpl::equal
(WebCore::equalIgnoringCase): Updated to use CSSParserString getters and
StringImpl::equalIgnoringCase
(WebCore::parseColorValue): Updated to use new CSSParserString::init()
(WebCore::parseSimpleLength):
(WebCore::parseKeywordValue): Updated to use new CSSParserString::init()
(WebCore::parseTransformArguments):
(WebCore::CSSParser::parseSystemColor): Updated to use new CSSParserString::init()
(WebCore::CSSParser::storeVariableDeclaration): Create right character sized AtomicString.
(WebCore::FontFamilyValueBuilder::add):
(WebCore::TransformOperationInfo::TransformOperationInfo):
(WebCore::CSSParser::parseFontFeatureTag):

(WebCore::CSSParser::parseEscape): Now only parses an escape and returns the resulting
Unicode value as an unsigned.
(WebCore::CSSParser::UnicodeToChars): New method to write out unicode character(s)
based on character type.
(WebCore::CSSParser::parseIdentifierInternal): Templated helper.
(WebCore::CSSParser::parseIdentifier): Parses identifiers, possibly upconverting
the result when a unicode escape is found in an 8 bit source.
(WebCore::CSSParser::parseStringInternal): Templated helper.
(WebCore::CSSParser::parseString): Parses strings, possibly upconverting
the result when a unicode escape is found in an 8 bit source.
(WebCore::CSSParser::parseURIInternal): Templated helper.
(WebCore::CSSParser::parseURI): Templated and split logic out to parseURIInternal.
Reparses a parsed identifier to see if it is a URI.  This method doesn't need to up
convert from 8 to 16 bits since that would have been done in parseIdentfier().
(WebCore::CSSParser::realLex): Lot of template related changes.  Removed yylval->string
ASSERT checks at the end, since they are too naive to handle upconverted identifier,
string and URIs.  They compared source pointers (m_tokenStart) with resulting strings.
(WebCore::fixUnparsedProperties):
(WebCore::CSSParser::fixUnparsedPropertyRanges): Added new template helper with same name.
(WebCore::CSSParser::markRuleHeaderStart):
(WebCore::CSSParser::markRuleHeaderEnd):
(WebCore::CSSParser::markRuleBodyStart):
(WebCore::CSSParser::markRuleBodyEnd):
(WebCore::CSSParser::markPropertyStart):
(WebCore::CSSParser::markPropertyEnd):
(WebCore::cssValueKeywordID):

* css/CSSParser.h:
(CSSParser):
(WebCore::CSSParser::lex): Made this inline helper that calls correct realLex().
(WebCore::CSSParser::is8BitSource):
(WebCore::CSSParser::tokenStartOffset): Templated method returning offset in source
of the current token start.
(WebCore::CSSParser::tokenStartChar): Templated access to m_tokenStart.
(WebCore::cssyylex): Made this inline to avoid call.
* css/CSSParserValues.h:
(WebCore::CSSParserString::init): Added three new initialization methods.

New setters, getters and helper methods.
(WebCore::CSSParserString::clear):
(WebCore::CSSParserString::is8Bit):
(WebCore::CSSParserString::characters8):
(WebCore::CSSParserString::characters16):
(WebCore::CSSParserString::length):
(WebCore::CSSParserString::setLength):
(WebCore::CSSParserString::operator[]):
(WebCore::CSSParserString::equalIgnoringCase):
(WebCore::CSSParserString::operator String):
(WebCore::CSSParserString::operator AtomicString):

Other methods templatized to support changes in CSSParser.
* platform/graphics/Color.cpp:
(WebCore::parseHexColorInternal):
(WebCore::Color::parseHexColor): New LChar flavor
(WebCore::Color::Color):
* platform/graphics/Color.h:
(Color):
* platform/text/TextEncoding.cpp:
(WebCore::TextEncoding::TextEncoding):
* platform/text/TextEncodingRegistry.cpp:
(WebCore::atomicCanonicalTextEncodingName):
* platform/text/TextEncodingRegistry.h:
* svg/SVGParserUtilities.cpp:
(WebCore::genericParseNumber):
(WebCore::parseSVGNumber):
* svg/SVGParserUtilities.h:
(WebCore::isSVGSpace):
(WebCore::skipOptionalSVGSpaces):
(WebCore::skipOptionalSVGSpacesOrDelimiter):

Source/WTF:

* wtf/text/StringImpl.h:
(WTF::equalIgnoringCase): Added (const char*, const LChar*, unsigned) flavor to support
8 bit CSS parser work.

LayoutTests:

New test that checks the case that a 16 bit unicode escape in an 8 bit CSS
source is properly handled.

* fast/css/unicode-escape-in-8bit-string-expected.html: Added.
* fast/css/unicode-escape-in-8bit-string.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] ASSERT(m_useFixedLayout) in WebPage when using QRawWebView without setting fixed...
kbalazs@webkit.org [Fri, 31 Aug 2012 17:08:41 +0000 (17:08 +0000)]
[Qt] ASSERT(m_useFixedLayout) in WebPage when using QRawWebView without setting fixed layout
https://bugs.webkit.org/show_bug.cgi?id=95557

Reviewed by Noam Rosenthal.

Let QRawWebView work with non-fixed layout size.

* UIProcess/API/qt/raw/qrawwebview.cpp:
(QRawWebView::setSize): Also put the member assigment into
the point where the new size is ensured to be committed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] javascript-url-stop-loaders.html and zero-length-response.html are flaky...
dominik.rottsches@intel.com [Fri, 31 Aug 2012 17:07:09 +0000 (17:07 +0000)]
[Chromium] javascript-url-stop-loaders.html and zero-length-response.html are flaky on Chromium EWS
https://bugs.webkit.org/show_bug.cgi?id=95581

Unreviewed, Chromium gardening.

Tests mentioned in the title seem to cause flakiness on the Chromium EWS.

* platform/chromium/TestExpectations: Mark as TIMEOUT PASS for now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] LayerTreeRenderer::callOnMainTread method name is misleading
kbalazs@webkit.org [Fri, 31 Aug 2012 16:54:07 +0000 (16:54 +0000)]
[Qt] LayerTreeRenderer::callOnMainTread method name is misleading
https://bugs.webkit.org/show_bug.cgi?id=95558

Reviewed by Kenneth Rohde Christiansen.

Fix the typo in the function name so callers will really call this
and not WTF::callOnMainThread. Renamed to dispatchOnMainThread to
make it clear that these things are not the same.

* UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
(WebKit::LayerTreeRenderer::dispatchOnMainThread):
(WebKit::LayerTreeRenderer::flushLayerChanges):
(WebKit::LayerTreeRenderer::purgeGLResources):
* UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:
(LayerTreeRenderer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (127047): Crash in PluginProxy::windowVisibilityChanged when changing...
beidson@apple.com [Fri, 31 Aug 2012 16:20:16 +0000 (16:20 +0000)]
REGRESSION (127047): Crash in PluginProxy::windowVisibilityChanged when changing tabs
<rdar://problem/12211180> and https://bugs.webkit.org/show_bug.cgi?id=95515

Reviewed by Dan Bernstein.

Plug-ins created in background tabs don't get initialized until they first become visible,
so telling them they are now invisible leads to messaging on behalf of an uninitialized plug-in.

Many other methods related to visibility and focus only call through if the plug-in is initialized,
so setWindowIsVisible should do the same.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::setWindowIsVisible): Only tell initialized plug-ins of window visibility changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: sort object properties when dumping them in tests
jberlin@webkit.org [Fri, 31 Aug 2012 16:03:26 +0000 (16:03 +0000)]
Web Inspector: sort object properties when dumping them in tests
https://bugs.webkit.org/show_bug.cgi?id=95459

Fix the expected results for timeline-paint to actually be in order.

* inspector/timeline/timeline-paint-expected.txt:
'height' comes before 'width' alphabetically.
* platform/chromium/inspector/timeline/timeline-paint-expected.txt: Removed.
Once the cross-platform results were fixed, this file was identical to the cross-platform
file. Remove it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[New Multicolumn] Make RenderFlowThreads into selection roots.
hyatt@apple.com [Fri, 31 Aug 2012 16:03:01 +0000 (16:03 +0000)]
[New Multicolumn] Make RenderFlowThreads into selection roots.
https://bugs.webkit.org/show_bug.cgi?id=95580

Reviewed by Dan Bernstein.

Make RenderFlowThreads selection roots so that they paint their own selection gaps.
This fixes multicolumn selection rendering so that the gaps paint correctly and stop
at the edge of the flow thread instead of going out to the edges of enclosing blocks.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::isSelectionRoot):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Regions] It should be possible to specify ::BEFORE/AFTER as regions
commit-queue@webkit.org [Fri, 31 Aug 2012 15:50:05 +0000 (15:50 +0000)]
[CSS Regions] It should be possible to specify ::BEFORE/AFTER as regions
https://bugs.webkit.org/show_bug.cgi?id=90079

Patch by Andrei Bucur <abucur@adobe.com> on 2012-08-31
Reviewed by David Hyatt.

Source/WebCore:

The calls for RenderRegion::node() have been replaced with RenderRegion::generatingNode() to allow pseudo-elements to have RenderRegion renderers.
The compare function that establishes the region order was adapted to take into account pseudo-regions.
A renderer for the pseudo-element is now generated if it's a region even though there's no content property specified.

Test: fast/regions/content-flowed-into-pseudo-regions.html

* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::computeOverflowStateForRegions):
* rendering/RenderNamedFlowThread.cpp:
(WebCore::compareRenderRegions):
* rendering/RenderObjectChildList.cpp:
(WebCore::ensureBeforeAfterContainer):
(WebCore):
(WebCore::RenderObjectChildList::updateBeforeAfterContent):
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::nodeAtPoint):
(WebCore::RenderRegion::checkRegionStyle):
(WebCore::RenderRegion::computeStyleInRegion):
* rendering/RenderTreeAsText.cpp:
(WebCore::writeRenderNamedFlowThreads):

LayoutTests:

The new ref-test has a block with both a :before and :after pseudo-elements marked as regions.
In the block there's another region.

The test verifies the content is correctly flowed (the region order is respected) in the region chain:
:before region -> child region -> :after region

As a region a pseudo-element should also be displayed if there's no content property specified in the style sheet.

* fast/regions/content-flowed-into-pseudo-regions-expected.html: Added.
* fast/regions/content-flowed-into-pseudo-regions.html: Added.
* fast/regions/resources/region-style.css:
(.regionArticleAfter::after, .regionArticleBefore::before):
(.borderBoxNoFloat):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] ImageDiff output is not in the expected form if image dimensions differ
kbalazs@webkit.org [Fri, 31 Aug 2012 15:49:00 +0000 (15:49 +0000)]
[Qt] ImageDiff output is not in the expected form if image dimensions differ
https://bugs.webkit.org/show_bug.cgi?id=95575

Reviewed by Csaba Osztrogonác.

Output 100% difference in the case of differing image dimensions so
the test harness knows that we won't produce any output further.
This matches the behavior of other ports.

* DumpRenderTree/qt/ImageDiff.cpp:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[New Multicolumn] Implement unforced breaking in the new column layout.
hyatt@apple.com [Fri, 31 Aug 2012 15:47:04 +0000 (15:47 +0000)]
[New Multicolumn] Implement unforced breaking in the new column layout.
https://bugs.webkit.org/show_bug.cgi?id=95498

Reviewed by Dan Bernstein.

This patch implements unforced breaking for lines and objects inside columns. Forced breaks are
not yet handled properly and will be covered in a separate patch.

* rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState):
Eliminate the flow thread constructor for LayoutState. Flow threads were doing a double push of
layout states, once in RenderFlowThread::layout() and then again in RenderBlock::layout(). This
double push was unnecessary, so I refactored the code to ensure the RenderBlock push does the
right thing for RenderFlowThreads.

(WebCore):
* rendering/LayoutState.h:
(LayoutState):
Eliminate the flow thread constructor for LayoutState.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::checkForPaginationLogicalHeightChange):
This function now handles RenderFlowThreads and properly sets a non-zero page height as well
as querying the flow thread to ask if the pagination logical height has changed. The flow thread
has a new member that it sets in layout() so that it can answer this question.

(WebCore::RenderBlock::hasNextPage):
Make sure RenderRegionSets always claim to have a next page when they are the last region, since
we know columns/pages can always generate additional boxes as needed.

* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::RenderFlowThread):
Add the m_pageLogicalHeightChanged member variable for tracking whether regions changed dimensions,
thus forcing us to repaginate everything.

(WebCore::RenderFlowThread::layout):
Remove the redundant push of layout state now that RenderBlock's covers it.

(WebCore::RenderFlowThread::regionAtBlockOffset):
Always return the last region if it's a set, regardless of the extendLastRegion boolean.
This reflects the fact that the last region set can always generate new page/column boxes.

(WebCore::RenderFlowThread::pageLogicalTopForOffset):
Refactored to call into the region it finds for a given offset, so that the region itself
can answer the question of where the top of the page is. This enables sets to return the top of
specific columns/pages within the set.

(WebCore::RenderFlowThread::pageRemainingLogicalHeightForOffset):
Changed to be written in terms of pageLogicalTop and pageLogicalHeight so that it correctly uses
only the current column/page when determining remaining height.

* rendering/RenderFlowThread.h:
Added pageLogicalHeightChanged() so that RenderBlock can ask the flow thread if its regions changed
dimensions.

* rendering/RenderMultiColumnBlock.cpp:
(WebCore::RenderMultiColumnBlock::checkForPaginationLogicalHeightChange):
Tweaked to no longer turn on pagination, since the RenderMultiColumnFlowThread does that and we
want to avoid a double push of paginated states. Instead it now just sets the column height ahead
of time so that the RenderMultiColumnSets know how big their columns are.

* rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::pageLogicalTopForOffset):
Subclassed to return the top of a specific column.

(WebCore):
* rendering/RenderMultiColumnSet.h:
Add the subclassed method for pageLogicalTopForOffset.

* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::pageLogicalTopForOffset):
The code from RenderFlow::pageLogicalTopForOffset moved here. Just returns the top of the flow
thread portion rect in the region (same as before).

(WebCore::RenderRegion::layout):
Changed to check only the page logical width and height, since we only consider a region as
invalidating how you break if there is an actual page height change.

* rendering/RenderRegion.h:
(WebCore::RenderRegion::isRenderRegionSet):
Added an isRenderRegionSet() virtual function so that we can test for sets.

* rendering/RenderRegionSet.h:
(WebCore::RenderRegionSet::isRenderRegionSet):
Subclassed isRenderRegionSet() to return true.

* rendering/RenderView.cpp:
* rendering/RenderView.h:
(LayoutStateMaintainer):
(WebCore::LayoutStateMaintainer::push):
Remove the pushes of LayoutState that were specific to RenderFlowThreads.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Update $ to alias to querySelector rather than getElementById
pfeldman@chromium.org [Fri, 31 Aug 2012 15:40:14 +0000 (15:40 +0000)]
Web Inspector: Update $ to alias to querySelector rather than getElementById
https://bugs.webkit.org/show_bug.cgi?id=92648

Reviewed by Yury Semikhatsky.

Source/WebCore:

Completed implementation started by Addy Osmani. Updates $ to alias to querySelector
with more flexible handling of selectors. Also adds a warning about the change (as per Firebug).

* inspector/InjectedScriptSource.js:
(.):

LayoutTests:

* inspector/console/command-line-api-expected.txt:
* inspector/console/command-line-api-inspect.html:
* inspector/console/command-line-api.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Unreviewed gardening, add Qt-WK2 specific expected
ossy@webkit.org [Fri, 31 Aug 2012 15:36:04 +0000 (15:36 +0000)]
[Qt][WK2] Unreviewed gardening, add Qt-WK2 specific expected
file, because this doesn't fail as expected, but passes.

* platform/qt-5.0-wk2/css3/compositing/should-have-compositing-layer-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r127261.
commit-queue@webkit.org [Fri, 31 Aug 2012 15:04:25 +0000 (15:04 +0000)]
Unreviewed, rolling out r127261.
http://trac.webkit.org/changeset/127261
https://bugs.webkit.org/show_bug.cgi?id=95572

This patch depends on other build fixes (see blockers of bug
95466) which should land first (Requested by milian on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-31

* qmake/mkspecs/features/features.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Disable WebViewTest.AutoResizeMinimumSize
gavinp@chromium.org [Fri, 31 Aug 2012 14:59:42 +0000 (14:59 +0000)]
[chromium] Disable WebViewTest.AutoResizeMinimumSize
https://bugs.webkit.org/show_bug.cgi?id=95571

Unreviewed gardening.

Disabling this test since it started failing in build 17225, see http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Win/builds/17247 for instance. Will shortly file bug to re-enable this.

* tests/WebViewTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: disable popover on click outside of popover anchor
caseq@chromium.org [Fri, 31 Aug 2012 14:54:43 +0000 (14:54 +0000)]
Web Inspector: disable popover on click outside of popover anchor
https://bugs.webkit.org/show_bug.cgi?id=95564

Reviewed by Yury Semikhatsky.

Immediately hide popover when receiving a click outside of popover anchor.

* inspector/front-end/Popover.js:
(WebInspector.PopoverHelper.prototype._mouseDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Support WebKit2/QML on QNX
commit-queue@webkit.org [Fri, 31 Aug 2012 14:47:17 +0000 (14:47 +0000)]
[Qt] Support WebKit2/QML on QNX
https://bugs.webkit.org/show_bug.cgi?id=95466

Patch by Milian Wolff <milian.wolff@kdab.com> on 2012-08-31
Reviewed by Noam Rosenthal.

Enable USE(3D_GRAPHICS) on QNX again, paired with the other bug fixes
this should finally work now.

* qmake/mkspecs/features/features.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed rebaseline after r127226
gavinp@chromium.org [Fri, 31 Aug 2012 14:35:22 +0000 (14:35 +0000)]
Unreviewed rebaseline after r127226

The windows results needed this rebaseline, apparently the original commit omitted these windows diffs per yosin@chromium.org.

* platform/chromium-win-xp/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png: Added.
* platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Add proper support for navigator.onLine and associated events
commit-queue@webkit.org [Fri, 31 Aug 2012 14:35:14 +0000 (14:35 +0000)]
[EFL] Add proper support for navigator.onLine and associated events
https://bugs.webkit.org/show_bug.cgi?id=95532

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-08-31
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Add support for detecting online state in EFL port and
monitor state changes. The EFL port now has proper
support for navigator.onLine and associated events.

The implementation is based on Eeze library for
detecting network interfaces and their configuration.
Detection of online state changes relies on rtnetlink.

No new tests, no behavior change for layout tests.

* PlatformEfl.cmake: Link unconditionally against Eeze
library now.
* platform/network/NetworkStateNotifier.cpp:
(WebCore):
* platform/network/NetworkStateNotifier.h:
(NetworkStateNotifier):
(WebCore):
* platform/network/efl/NetworkStateNotifierEfl.cpp: Added.
(WebCore):
(WebCore::NetworkStateNotifier::updateState):
(WebCore::NetworkStateNotifier::networkInterfaceChanged):
(WebCore::readSocketCallback):
(WebCore::NetworkStateNotifier::~NetworkStateNotifier):
(WebCore::NetworkStateNotifier::NetworkStateNotifier):

Source/WebKit/efl:

Remove ewk_network_state_notifier_online_set() API since
the EFL port no longer relies on the client application to
provide it with the online state.

* ewk/ewk_network.cpp:
* ewk/ewk_network.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] REGRESSION(r127091): It made layout tests extremely slow
ossy@webkit.org [Fri, 31 Aug 2012 14:29:35 +0000 (14:29 +0000)]
[Qt][WK2] REGRESSION(r127091): It made layout tests extremely slow
https://bugs.webkit.org/show_bug.cgi?id=95450

Unreviewed gardening, skip http/tests/appcache tests until proper fix.

* platform/qt-5.0-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove http/tests/loading/gmail-assert-on-load.html test case from Skipped.
commit-queue@webkit.org [Fri, 31 Aug 2012 14:13:04 +0000 (14:13 +0000)]
Remove http/tests/loading/gmail-assert-on-load.html test case from Skipped.
https://bugs.webkit.org/show_bug.cgi?id=95562

Unreviewed gardening.

Removed http/tests/loading/gmail-assert-on-load.html test case from Skipped files since it has been moved out from http/loading to http/misc, for details see bug 88923.

Patch by Kangil Han <kangil.han@samsung.com> on 2012-08-31

* platform/win/Skipped:
* platform/wincairo/Skipped:
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Fri, 31 Aug 2012 14:04:00 +0000 (14:04 +0000)]
Unreviewed GTK gardening.

Adding failure expectations for two HTTP security tests.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] QNX does not support SOCK_SEQPACKET socket type for socketpair in ProcessLauncherQt
commit-queue@webkit.org [Fri, 31 Aug 2012 13:33:59 +0000 (13:33 +0000)]
[Qt] QNX does not support SOCK_SEQPACKET socket type for socketpair in ProcessLauncherQt
https://bugs.webkit.org/show_bug.cgi?id=95553

Patch by Milian Wolff <milian.wolff@kdab.com> on 2012-08-31
Reviewed by Simon Hausmann.

Calling socketpair with SOCK_SEQPACKET socket type fails on QNX with an error 241 (EPROTOTYPE),
as can be seen by the following debug output: "Creation of socket failed with errno: 241".
A test app shows that SOCK_DGRAM works properly on QNX, thus use it instead of SOCK_SEQPACKET.

* UIProcess/Launcher/qt/ProcessLauncherQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] QNX build fails due to missing OpenGL ES defines
commit-queue@webkit.org [Fri, 31 Aug 2012 12:58:52 +0000 (12:58 +0000)]
[Qt] QNX build fails due to missing OpenGL ES defines
https://bugs.webkit.org/show_bug.cgi?id=95554

Patch by Milian Wolff <milian.wolff@kdab.com> on 2012-08-31
Reviewed by Simon Hausmann.

Apply the fix of bug 91030 to all platforms running on QNX.

* platform/graphics/opengl/Extensions3DOpenGLES.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening, skip a new failing test.
ossy@webkit.org [Fri, 31 Aug 2012 12:52:03 +0000 (12:52 +0000)]
[Qt] Unreviewed gardening, skip a new failing test.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CMake] Changes on the bindings generator does not trigger generation of the bindings
commit-queue@webkit.org [Fri, 31 Aug 2012 12:46:50 +0000 (12:46 +0000)]
[CMake] Changes on the bindings generator does not trigger generation of the bindings
https://bugs.webkit.org/show_bug.cgi?id=95552

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-31
Reviewed by Kenneth Rohde Christiansen.

Added the engine especific part of the generator to the dependency
list.

* UseJSC.cmake:
* UseV8.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix for WinCE after r127191.
paroga@webkit.org [Fri, 31 Aug 2012 12:28:14 +0000 (12:28 +0000)]
Build fix for WinCE after r127191.

* bytecode/JumpTable.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Gardening of failing tests and new passes
dominik.rottsches@intel.com [Fri, 31 Aug 2012 12:07:56 +0000 (12:07 +0000)]
[EFL] Gardening of failing tests and new passes
https://bugs.webkit.org/show_bug.cgi?id=95555

Unreviewed EFL gardening of failing tests and new passes.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-08-31

* platform/efl/TestExpectations:
* platform/efl/http/tests/misc/willCacheResponse-delegate-callback-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Gardening after r127140. Skip a failing reftest.
ossy@webkit.org [Fri, 31 Aug 2012 12:05:51 +0000 (12:05 +0000)]
[Qt] Gardening after r127140. Skip a failing reftest.

Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-08-31
Reviewed by Csaba Osztrogonác.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening, unskip now passing tests, update expected files.
ossy@webkit.org [Fri, 31 Aug 2012 11:59:55 +0000 (11:59 +0000)]
[Qt] Unreviewed gardening, unskip now passing tests, update expected files.

* platform/qt-5.0/css2.1/t0805-c5519-brdr-r-01-e-expected.png: Removed.
* platform/qt-5.0/css2.1/t0805-c5519-brdr-r-01-e-expected.txt: Removed.
* platform/qt-5.0/fast/inline/absolute-positioned-inline-in-centred-block-expected.png: Removed.
* platform/qt-5.0/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Removed.
* platform/qt/Skipped:
* platform/qt/TestExpectations:
* platform/qt/css2.1/t0805-c5519-brdr-r-00-a-expected.txt:
* platform/qt/css2.1/t0805-c5519-brdr-r-01-e-expected.png:
* platform/qt/css2.1/t0805-c5519-brdr-r-01-e-expected.txt:
* platform/qt/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
* platform/qt/css2.1/t0805-c5521-brdr-l-00-a-expected.txt:
* platform/qt/css2.1/t0805-c5521-brdr-l-01-e-expected.txt:
* platform/qt/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt:
* platform/qt/css3/filters/blur-filter-page-scroll-expected.png: Added.
* platform/qt/css3/filters/blur-filter-page-scroll-expected.txt: Added.
* platform/qt/css3/filters/blur-filter-page-scroll-parents-expected.png: Added.
* platform/qt/css3/filters/blur-filter-page-scroll-parents-expected.txt: Added.
* platform/qt/css3/filters/effect-reference-expected.png: Added.
* platform/qt/css3/filters/effect-reference-expected.txt: Added.
* platform/qt/css3/filters/effect-reference-external-expected.png: Added.
* platform/qt/css3/filters/effect-reference-external-expected.txt: Added.
* platform/qt/css3/filters/effect-reference-hw-expected.txt: Added.
* platform/qt/css3/filters/effect-reference-ordering-expected.png: Added.
* platform/qt/css3/filters/effect-reference-ordering-expected.txt: Added.
* platform/qt/fast/block/float/024-expected.png:
* platform/qt/fast/block/float/024-expected.txt:
* platform/qt/fast/block/margin-collapse/025-expected.png:
* platform/qt/fast/block/margin-collapse/025-expected.txt:
* platform/qt/fast/block/margin-collapse/block-inside-inline/025-expected.png:
* platform/qt/fast/block/margin-collapse/block-inside-inline/025-expected.txt:
* platform/qt/fast/block/margin-collapse/empty-clear-blocks-expected.png:
* platform/qt/fast/block/margin-collapse/empty-clear-blocks-expected.txt:
* platform/qt/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
* platform/qt/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt:
* platform/qt/fast/css/nested-layers-with-hover-expected.txt:
* platform/qt/fast/inline/absolute-positioned-inline-in-centred-block-expected.png:
* platform/qt/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt:
* platform/qt/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.png:
* platform/qt/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt:
* platform/qt/svg/filters/color-interpolation-filters-expected.png: Added.
* platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.png: Added.
* platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.txt:
* platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.png: Added.
* platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Simplify FrameLoaderClinetEfl by adding a private method.
commit-queue@webkit.org [Fri, 31 Aug 2012 11:35:27 +0000 (11:35 +0000)]
[EFL] Simplify FrameLoaderClinetEfl by adding a private method.
https://bugs.webkit.org/show_bug.cgi?id=95444

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-08-31
Reviewed by Gyuyoung Kim.

In the FrameLoaderClientEfl, the codes which checks that
if current frame is main frame are frequently used.
This patch adds a private method and replaces those codes
with the method to simplify.

* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchDidChangeLocationWithinPage):
(WebCore::FrameLoaderClientEfl::dispatchDidReceiveIcon):
(WebCore::FrameLoaderClientEfl::dispatchDidStartProvisionalLoad):
(WebCore::FrameLoaderClientEfl::dispatchDidReceiveTitle):
(WebCore::FrameLoaderClientEfl::dispatchDidCommitLoad):
(WebCore::FrameLoaderClientEfl::dispatchDidFailProvisionalLoad):
(WebCore::FrameLoaderClientEfl::transitionToCommittedForNewPage):
* WebCoreSupport/FrameLoaderClientEfl.h:
(WebCore::FrameLoaderClientEfl::isLoadingMainFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [WebGL] Link WebGL calls to the source code where it was made
commit-queue@webkit.org [Fri, 31 Aug 2012 09:56:10 +0000 (09:56 +0000)]
Web Inspector: [WebGL] Link WebGL calls to the source code where it was made
https://bugs.webkit.org/show_bug.cgi?id=95426

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-08-31
Reviewed by Vsevolod Vlasov.

Save a stack trace for every call we capture and report to the frontend sourceURL,lineNumber,columnNumber were the call was made from.
Right now, this will work only with V8.

* inspector/InjectedScriptExterns.js:
(CallSite.prototype.getFileName):
(CallSite.prototype.getLineNumber):
(CallSite.prototype.getColumnNumber):
* inspector/InjectedScriptWebGLModuleSource.js:
(.):
* inspector/Inspector.json:
* inspector/front-end/WebGLProfileView.js:
(WebInspector.WebGLProfileView):
(WebInspector.WebGLProfileView.prototype._showTraceLog):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Add high-DPI images for status bar glyphs
pfeldman@chromium.org [Fri, 31 Aug 2012 09:43:27 +0000 (09:43 +0000)]
Web Inspector: Add high-DPI images for status bar glyphs
https://bugs.webkit.org/show_bug.cgi?id=95471

Patch by Patrick Dubroy <dubroy@chromium.org> on 2012-08-31
Reviewed by Pavel Feldman.

Add the new 2x resolution image for the status bar glyphs, and add
media queries to use the images on high-DPI devices.

* inspector/front-end/Images/statusbarButtonGlyphs2x.png: Added.
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.css:
(.long-click-glyph):
(@media (-webkit-min-device-pixel-ratio: 1.5)):
(.status-bar-item > .glyph):
* inspector/front-end/scriptsPanel.css:
(.toggle-breakpoints .glyph):
(@media (-webkit-min-device-pixel-ratio: 1.5)):
(.status-bar-item.scripts-navigator-show-hide-button > .glyph):
(.status-bar-item.scripts-debugger-show-hide-button > .glyph):
* WebCore.gypi
* inspector/front-end/timelinePanel.css:
(#timeline-overview-sidebar .icon):
(@media (-webkit-min-device-pixel-ratio: 1.5)):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Exclusions] Exclusions tests should run without errors in standalone browser
commit-queue@webkit.org [Fri, 31 Aug 2012 09:40:57 +0000 (09:40 +0000)]
[CSS Exclusions] Exclusions tests should run without errors in standalone browser
https://bugs.webkit.org/show_bug.cgi?id=95369

Patch by Bear Travis <betravis@adobe.com> on 2012-08-31
Reviewed by Andreas Kling.

Adding a check to make sure window.internals exists before accessing it.
Without the check, a reference error would occur when trying to run these
tests from the browser (as opposed to the test script).

* fast/exclusions/css-exclusions-disabled.html:
* fast/exclusions/script-tests/parsing-wrap-shape-inside.js:
* fast/exclusions/script-tests/parsing-wrap-shape-outside.js:
* fast/exclusions/script-tests/wrap-flow-parsing.js:
* fast/exclusions/script-tests/wrap-margin-parsing.js:
* fast/exclusions/script-tests/wrap-padding-parsing.js:
* fast/exclusions/script-tests/wrap-parsing.js:
* fast/exclusions/script-tests/wrap-through-parsing.js:
* fast/exclusions/shape-inside/shape-inside-floats-simple.html:
* fast/exclusions/shape-inside/shape-inside-inline-elements.html:
* fast/exclusions/shape-inside/shape-inside-overflow.html:
* fast/exclusions/shape-inside/shape-inside-percentage-auto.html:
* fast/exclusions/shape-inside/shape-inside-text.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: render box model elements and grid on inspector overlay
pfeldman@chromium.org [Fri, 31 Aug 2012 09:35:57 +0000 (09:35 +0000)]
Web Inspector: render box model elements and grid on inspector overlay
https://bugs.webkit.org/show_bug.cgi?id=95456

Reviewed by Vsevolod Vlasov.

This change migrates native rendering for box model to the InspectorOverlay.

* inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::didScrollImpl):
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didScroll):
(WebCore):
* inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::drawNodeHighlight):
(WebCore::InspectorOverlay::drawRectHighlight):
(WebCore::InspectorOverlay::overlayPage):
(WebCore::InspectorOverlay::evaluateInOverlay):
* inspector/InspectorOverlay.h:
(WebCore::Highlight::setColors):
(Highlight):
(InspectorOverlay):
* inspector/InspectorOverlayPage.html:
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::didLayout):
(WebCore):
(WebCore::InspectorPageAgent::didScroll):
* inspector/InspectorPageAgent.h:
* page/Chrome.cpp:
(WebCore::Chrome::scroll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [WebGL] Make wrap functions initialization lazy
commit-queue@webkit.org [Fri, 31 Aug 2012 09:14:44 +0000 (09:14 +0000)]
Web Inspector: [WebGL] Make wrap functions initialization lazy
https://bugs.webkit.org/show_bug.cgi?id=95533

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-08-31
Reviewed by Vsevolod Vlasov.

WebGL wrap functions initialization is not always needed to be executed: for example, when we will instrument a 2D canvas.
Drive-by: fixed variable namings, moved duplicated code into a small auxiliary function.
* inspector/InjectedScriptWebGLModuleSource.js:
(.):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Port convertValueToQVariant to use the JSC C API
hausmann@webkit.org [Fri, 31 Aug 2012 08:07:42 +0000 (08:07 +0000)]
[Qt] Port convertValueToQVariant to use the JSC C API
https://bugs.webkit.org/show_bug.cgi?id=94695

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Most of the code is portable to the C API, with a few exceptions for internal
types such as byte arrays, dates or when unboxing primitive types.

* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtField::setValueToInstance):
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::operator<<):
(JSC::Bindings::isJSUint8ClampedArray):
(JSC::Bindings::isJSArray):
(Bindings):
(JSC::Bindings::isJSDate):
(JSC::Bindings::isQtObject):
(JSC::Bindings::valueRealType):
(JSC::Bindings::toString):
(JSC::Bindings::unwrapBoxedPrimitive):
(JSC::Bindings::convertValueToQVariantMap):
(JSC::Bindings::convertToList):
(JSC::Bindings::toQString):
(JSC::Bindings::getGregorianDateTimeUTC):
(JSC::Bindings::toQDateTimeUTC):
(JSC::Bindings::convertValueToQVariant):
(JSC::Bindings::findMethodIndex):
(JSC::Bindings::QtConnectionObject::execute):
* bridge/qt/qt_runtime.h:
(Bindings):

Source/WebKit/qt:

Minor adaptations are needed here to accomodate the changed signature of
convertValueToQVariant.

* Api/qwebelement.cpp:
(QWebElement::evaluateJavaScript):
(convertJSValueToWebElementVariant):
* Api/qwebframe.cpp:
(QWebFrame::evaluateJavaScript):
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(convertJSValueToNodeVariant):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127238 268f45cc-cd09-0410-ab3c-d52691b4dbfc