WebKit-https.git
7 years agoBuild Error on Qt Linux build
commit-queue@webkit.org [Fri, 6 Jul 2012 20:41:09 +0000 (20:41 +0000)]
Build Error on Qt Linux build
https://bugs.webkit.org/show_bug.cgi?id=90699

Patch by Pravin D <pravind.2k4@gmail.com> on 2012-07-06
Reviewed by Laszlo Gombos.

* parser/Parser.cpp:
(JSC::::parseForStatement):
Removed unused boolean variable as this was causing build error on Qt Linux.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][CMake] Move gtest sources to an upper level
commit-queue@webkit.org [Fri, 6 Jul 2012 19:19:44 +0000 (19:19 +0000)]
[EFL][CMake] Move gtest sources to an upper level
https://bugs.webkit.org/show_bug.cgi?id=90602

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-06
Reviewed by Chang Shu.

.:

CTest was enabled for all the ports, but used only by EFL. Now
ENABLE_API_TESTS has to be defined, which will also build gtest.

* CMakeLists.txt:
* Source/CMakeLists.txt:
* Source/cmake/OptionsEfl.cmake:
* Source/cmake/gtest/CMakeLists.txt: Added.

Source/WebKit:

Removed gtest since it is now built as a separated component.
This will allow us to share it with WebKit 2 API tests.

* PlatformEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] Add support for Network Information API
commit-queue@webkit.org [Fri, 6 Jul 2012 19:12:12 +0000 (19:12 +0000)]
[WK2] Add support for Network Information API
https://bugs.webkit.org/show_bug.cgi?id=89870

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-06
Reviewed by Anders Carlsson.

Add Network Information API support for WebKit2.

* CMakeLists.txt:
* DerivedSources.pri:
* GNUmakefile.am:
* GNUmakefile.list.am:
* Platform/CoreIPC/MessageID.h:
* Shared/API/c/WKBase.h:
* Shared/APIObject.h:
* Shared/WebNetworkInfo.cpp: Added.
(WebKit):
(WebKit::WebNetworkInfo::WebNetworkInfo):
(WebKit::WebNetworkInfo::~WebNetworkInfo):
(WebKit::WebNetworkInfo::Data::encode):
(WebKit::WebNetworkInfo::Data::decode):
* Shared/WebNetworkInfo.h: Added.
(WebKit):
(WebNetworkInfo):
(Data):
(WebKit::WebNetworkInfo::create):
(WebKit::WebNetworkInfo::bandwidth):
(WebKit::WebNetworkInfo::metered):
(WebKit::WebNetworkInfo::data):
(WebKit::WebNetworkInfo::type):
* Target.pri:
* UIProcess/API/C/WKAPICast.h:
(WebKit):
* UIProcess/API/C/WKNetworkInfoManager.cpp: Added.
(WKNetworkInfoManagerGetTypeID):
* UIProcess/API/C/WKNetworkInfoManager.h: Added.
* UIProcess/WebNetworkInfoManagerProxy.cpp: Added.
(WebKit):
(WebKit::WebNetworkInfoManagerProxy::create):
(WebKit::WebNetworkInfoManagerProxy::WebNetworkInfoManagerProxy):
(WebKit::WebNetworkInfoManagerProxy::~WebNetworkInfoManagerProxy):
(WebKit::WebNetworkInfoManagerProxy::invalidate):
(WebKit::WebNetworkInfoManagerProxy::initializeProvider):
(WebKit::WebNetworkInfoManagerProxy::providerDidChangeNetworkInformation):
(WebKit::WebNetworkInfoManagerProxy::didReceiveMessage):
(WebKit::WebNetworkInfoManagerProxy::startUpdating):
(WebKit::WebNetworkInfoManagerProxy::stopUpdating):
(WebKit::WebNetworkInfoManagerProxy::getBandwidth):
(WebKit::WebNetworkInfoManagerProxy::isMetered):
* UIProcess/WebNetworkInfoManagerProxy.h: Added.
(CoreIPC):
(WebKit):
(WebNetworkInfoManagerProxy):
(WebKit::WebNetworkInfoManagerProxy::clearContext):
(WebKit::WebNetworkInfoManagerProxy::type):
* UIProcess/WebNetworkInfoManagerProxy.messages.in: Added.
* UIProcess/WebNetworkInfoProvider.cpp: Added.
(WebKit):
(WebKit::WebNetworkInfoProvider::startUpdating):
(WebKit::WebNetworkInfoProvider::stopUpdating):
(WebKit::WebNetworkInfoProvider::bandwidth):
(WebKit::WebNetworkInfoProvider::metered):
* UIProcess/WebNetworkInfoProvider.h: Added.
(WebKit):
(WebNetworkInfoProvider):
* WebKit2.pri:
* WebProcess/NetworkInfo/WebNetworkInfoManager.cpp: Added.
(WebKit):
(WebKit::WebNetworkInfoManager::WebNetworkInfoManager):
(WebKit::WebNetworkInfoManager::~WebNetworkInfoManager):
(WebKit::WebNetworkInfoManager::didReceiveMessage):
(WebKit::WebNetworkInfoManager::registerWebPage):
(WebKit::WebNetworkInfoManager::unregisterWebPage):
(WebKit::WebNetworkInfoManager::bandwidth):
(WebKit::WebNetworkInfoManager::metered):
(WebKit::WebNetworkInfoManager::didChangeNetworkInformation):
* WebProcess/NetworkInfo/WebNetworkInfoManager.h: Added.
(CoreIPC):
(WebKit):
(WebNetworkInfoManager):
* WebProcess/NetworkInfo/WebNetworkInfoManager.messages.in: Added.
* WebProcess/WebCoreSupport/WebNetworkInfoClient.cpp: Added.
(WebKit):
(WebKit::WebNetworkInfoClient::~WebNetworkInfoClient):
(WebKit::WebNetworkInfoClient::bandwidth):
(WebKit::WebNetworkInfoClient::metered):
(WebKit::WebNetworkInfoClient::startUpdating):
(WebKit::WebNetworkInfoClient::stopUpdating):
* WebProcess/WebCoreSupport/WebNetworkInfoClient.h: Added.
(WebKit):
(WebNetworkInfoClient):
(WebKit::WebNetworkInfoClient::WebNetworkInfoClient):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::didReceiveMessage):
* WebProcess/WebProcess.h:
(WebProcess):
(WebKit::WebProcess::networkInfoManager):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Gtk] Add a configuration option for disabling unstable features in releases
zandobersek@gmail.com [Fri, 6 Jul 2012 18:36:31 +0000 (18:36 +0000)]
[Gtk] Add a configuration option for disabling unstable features in releases
https://bugs.webkit.org/show_bug.cgi?id=87995

Reviewed by Martin Robinson.

.:

Add a configuration flag for enabling the unstable features - features of which
support in the Gtk port is being worked on but is not yet complete. The primary
use of this flag is when compiling through the build-webkit script.

All the features that are currently enabled when building through build-webkit but
are disabled by default when executing the configure script directly have their default
value (when the correspondent flag is not passed) set to 'yes' when unstable features
are enabled and 'no' otherwise. This way unstable features are kept disabled when performing
a release build (unless they are specifically enabled).

* configure.ac:

Tools:

Pass the --enable-unstable-features flag when building the Gtk port through build-webkit.

* Scripts/webkitdirs.pm:
(buildAutotoolsProject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDrawing to accelerated 2D canvas causes compositor to recompute layer tree
commit-queue@webkit.org [Fri, 6 Jul 2012 17:47:34 +0000 (17:47 +0000)]
Drawing to accelerated 2D canvas causes compositor to recompute layer tree
https://bugs.webkit.org/show_bug.cgi?id=90630

Patch by Justin Novosad <junov@chromium.org> on 2012-07-06
Reviewed by Simon Fraser.

No new tests: covered by existing canvas/compositing layout tests

Before this change, there was no distinction between canvas changes
that require recomputing the compositor tree and canvas changes that
only require re-display. The new CanvasPixelsChanged member of enum
ContentChangeType requests re-display without re-layout.

* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::didDraw):
* rendering/RenderBoxModelObject.h:
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::contentChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix build with recent clang.
commit-queue@webkit.org [Fri, 6 Jul 2012 17:39:20 +0000 (17:39 +0000)]
Fix build with recent clang.
https://bugs.webkit.org/show_bug.cgi?id=90634

Patch by Nuno Lopes <nlopes@apple.com> on 2012-07-06
Reviewed by Oliver Hunt.

* jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::SpecializedThunkJIT):
(SpecializedThunkJIT):
* jit/ThunkGenerators.cpp:
(JSC::charCodeAtThunkGenerator):
(JSC::charAtThunkGenerator):
(JSC::fromCharCodeThunkGenerator):
(JSC::sqrtThunkGenerator):
(JSC::floorThunkGenerator):
(JSC::ceilThunkGenerator):
(JSC::roundThunkGenerator):
(JSC::expThunkGenerator):
(JSC::logThunkGenerator):
(JSC::absThunkGenerator):
(JSC::powThunkGenerator):
* parser/ASTBuilder.h:
(JSC::ASTBuilder::createAssignResolve):
(JSC::ASTBuilder::createForLoop):
(JSC::ASTBuilder::createForInLoop):
(JSC::ASTBuilder::makeAssignNode):
(JSC::ASTBuilder::makePrefixNode):
(JSC::ASTBuilder::makePostfixNode):
* parser/NodeConstructors.h:
(JSC::PostfixErrorNode::PostfixErrorNode):
(JSC::PrefixErrorNode::PrefixErrorNode):
(JSC::AssignResolveNode::AssignResolveNode):
(JSC::AssignErrorNode::AssignErrorNode):
(JSC::ForNode::ForNode):
(JSC::ForInNode::ForInNode):
* parser/Nodes.h:
(FunctionCallResolveNode):
(PostfixErrorNode):
(PrefixErrorNode):
(ReadModifyResolveNode):
(AssignResolveNode):
(AssignErrorNode):
(ForNode):
(ForInNode):
* parser/Parser.cpp:
(JSC::::parseVarDeclarationList):
(JSC::::parseForStatement):
* parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createAssignResolve):
(JSC::SyntaxChecker::createForLoop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: get rid of this._lastMarkedRange in TextEditor.
pfeldman@chromium.org [Fri, 6 Jul 2012 17:19:25 +0000 (17:19 +0000)]
Web Inspector: get rid of this._lastMarkedRange in TextEditor.
https://bugs.webkit.org/show_bug.cgi?id=90691

Reviewed by Vsevolod Vlasov.

We don't need it, should use setSelection instead.

* inspector/front-end/TextEditor.js:
(WebInspector.TextEditor.prototype.markAndRevealRange):
(WebInspector.TextEditor.prototype._handleSelectionChange):
(WebInspector.TextEditor.prototype.setSelection):
(WebInspector.TextEditor.prototype._handleFocused):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Snippet renaming behavior is not correct.
vsevik@chromium.org [Fri, 6 Jul 2012 17:08:12 +0000 (17:08 +0000)]
Web Inspector: Snippet renaming behavior is not correct.
https://bugs.webkit.org/show_bug.cgi?id=90689

Reviewed by Pavel Feldman.

Navigator overlay is now not closed when editing is canceled.
Esc handler in NavigatorOverlayController is not installed as a shortcut anymore since
it should not be called until all underlying DOM elements handled the key down event.

* inspector/front-end/NavigatorOverlayController.js:
(WebInspector.NavigatorOverlayController.prototype.set showNavigatorOverlay):
(WebInspector.NavigatorOverlayController.prototype._keyDown):
(WebInspector.NavigatorOverlayController.prototype._innerHideNavigatorOverlay):
* inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorView.prototype.rename.commitHandler):
(WebInspector.NavigatorView.prototype.rename.cancelHandler):
(WebInspector.NavigatorView.prototype.rename.afterEditing):
* inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator):
(WebInspector.ScriptsNavigator.prototype._itemRenamingRequested):
(WebInspector.SnippetsNavigatorView.prototype._handleRenameSnippet):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._itemRenamingRequested.callback):
(WebInspector.ScriptsPanel.prototype._itemRenamingRequested):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSeparate mutating CSSStyleDeclaration operations.
kling@webkit.org [Fri, 6 Jul 2012 17:05:39 +0000 (17:05 +0000)]
Separate mutating CSSStyleDeclaration operations.
<http://webkit.org/b/89945>

Reviewed by Antti Koivisto.

Use separate paths for mutating the StylePropertySet wrapped by a CSSStyleDeclaration.
PropertySetCSSStyleDeclaration now has:

    - propertySet() const
    - ensureMutablePropertySet()

This is prep work for supporting immutable ElementAttributeData objects, the idea being
that calling ensureMutablePropertySet() may cause the element to convert its internal
attribute storage (which also holds the inline StylePropertySet.)

* css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::length):
(WebCore::PropertySetCSSStyleDeclaration::item):
(WebCore::PropertySetCSSStyleDeclaration::cssText):
(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyValue):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyPriority):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyShorthand):
(WebCore::PropertySetCSSStyleDeclaration::isPropertyImplicit):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::removeProperty):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValueInternal):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyValueInternal):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):
(WebCore::PropertySetCSSStyleDeclaration::copy):
(WebCore::PropertySetCSSStyleDeclaration::makeMutable):
(WebCore::PropertySetCSSStyleDeclaration::cssPropertyMatches):
(WebCore::InlineCSSStyleDeclaration::didMutate):
(WebCore::InlineCSSStyleDeclaration::ensureMutablePropertySet):
* css/PropertySetCSSStyleDeclaration.h:
(PropertySetCSSStyleDeclaration):
(WebCore::PropertySetCSSStyleDeclaration::propertySet):
(WebCore::PropertySetCSSStyleDeclaration::ensureMutablePropertySet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: text editor scrolls 2px horizontally as one navigates the source code.
pfeldman@chromium.org [Fri, 6 Jul 2012 16:54:04 +0000 (16:54 +0000)]
Web Inspector: text editor scrolls 2px horizontally as one navigates the source code.
https://bugs.webkit.org/show_bug.cgi?id=90682

Reviewed by Vsevolod Vlasov.

Removing the hack that is glueing the scroller to the left.

* inspector/front-end/TextEditor.js:
(WebInspector.TextEditor.prototype._updatePanelOffsets):
(WebInspector.TextEditorChunkedPanel.prototype._scroll):
* inspector/front-end/textEditor.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: get rid of cancellable records in Timeline, manage frame records expli...
caseq@chromium.org [Fri, 6 Jul 2012 16:41:00 +0000 (16:41 +0000)]
Web Inspector: get rid of cancellable records in Timeline, manage frame records explicitly
https://bugs.webkit.org/show_bug.cgi?id=90684

Reviewed by Pavel Feldman.

- drop handling of "cancelable" records;
- keep frame record until other records come (or frame is canceled)

* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::didBeginFrame):
(WebCore::InspectorTimelineAgent::didCancelFrame):
(WebCore::InspectorTimelineAgent::addRecordToTimeline):
(WebCore::InspectorTimelineAgent::pushCurrentRecord):
(WebCore::InspectorTimelineAgent::commitFrameRecord):
(WebCore::InspectorTimelineAgent::clearRecordStack):
* inspector/InspectorTimelineAgent.h:
(WebCore::InspectorTimelineAgent::TimelineRecordEntry::TimelineRecordEntry):
(TimelineRecordEntry):
(InspectorTimelineAgent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebKit2: WKContext should ask for its injected bundle initialization user...
jberlin@webkit.org [Fri, 6 Jul 2012 16:35:32 +0000 (16:35 +0000)]
Source/WebKit2: WKContext should ask for its injected bundle initialization user data when it needs it so the
client doesn't have to keep it up to date.
https://bugs.webkit.org/show_bug.cgi?id=90627

Reviewed by NOBODY (OOPS!).

Add a getInjectedBundleInitializationUserData callback to WKContextInjectedBundleClient.

* Shared/APIClientTraits.cpp:
Allow the WKContextInjectedBundleClient API to be versioned.
* Shared/APIClientTraits.h:

* UIProcess/API/C/WKContext.h:
Add the callback and bump the version of WKContextInjectedBundleClient.

* UIProcess/WebContext.cpp:
(WebKit::WebContext::ensureWebProcess):
Prefer any user data returned when the callback is invoked over that set with
WKContextSetInitializationUserDataForInjectedBundle.

* UIProcess/WebContextInjectedBundleClient.cpp:
(WebKit::WebContextInjectedBundleClient::getInjectedBundleInitializationUserData):
Invoke the callback if the client has registered for it.
* UIProcess/WebContextInjectedBundleClient.h:

Tools: WKContext should ask for its initialization data when it needs it so the client doesn't have
to keep it up to date.
https://bugs.webkit.org/show_bug.cgi?id=90627

Reviewed by NOBODY (OOPS!).

Add tests and update other WKContextInjectedBundleClients.

* MiniBrowser/mac/AppDelegate.m:
(-[BrowserAppDelegate init]):
Updated for the change to WKContextInjectedBundleClient.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
Ditto.

* TestWebKitAPI/PlatformUtilities.cpp:
(TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
Moved the logic to create the initialization dictionary here ...
(TestWebKitAPI::Util::createContextForInjectedBundleTest):
... from here so that it can be used without automatically using
WKContextSetInitializationUserDataForInjectedBundle.
* TestWebKitAPI/PlatformUtilities.h:

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
Add the new test files.
* TestWebKitAPI/GNUmakefile.am:
Ditto.

* TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp: Added.
(TestWebKitAPI::didReceiveMessageFromInjectedBundle):
Check that the message received from the injected bundle matches the user data it was
initialized with.
(TestWebKitAPI::getInjectedBundleInitializationUserData):
Return the user data that the injected bundle should be initialized with.
(TestWebKitAPI::TEST):
Set up WKContextInjectedBundleClient and load a page.
* TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp: Added.
(TestWebKitAPI::GetInjectedBundleInitializationUserDataCallbackTest::initialize):
Send the initialization user data back up to the UI Process.

* TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp: Added.
(TestWebKitAPI::didReceiveMessageFromInjectedBundle):
Check that the message received from the injected bundle matches the user data it was
initialized with in the callback.
(TestWebKitAPI::getInjectedBundleInitializationUserData):
Return the user data that the injected bundle should be initialized with.
(TestWebKitAPI::TEST):
Set up the context and use WKContextSetInitializationUserDataForInjectedBundle to set the
initialization user data (which should be overridden by the user data returned in
getInjectedBundleInitializationUserData).
* TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp: Added.
(TestWebKitAPI::InjectedBundleInitializationUserDataCallbackWinsTest::initialize):
Send the initialization user data back up to the UI Process.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebContext::injectedBundleInitializationUserData() is unused, should be removed
jberlin@webkit.org [Fri, 6 Jul 2012 16:35:21 +0000 (16:35 +0000)]
WebContext::injectedBundleInitializationUserData() is unused, should be removed
https://bugs.webkit.org/show_bug.cgi?id=90486

Reviewed by Anders Carlsson.

* UIProcess/WebContext.h:
Remove it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening, skip new failing tests.
ossy@webkit.org [Fri, 6 Jul 2012 16:29:09 +0000 (16:29 +0000)]
[Qt] Unreviewed gardening, skip new failing tests.

* platform/qt-5.0-wk1/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Add site specific quirks setting to WebKit2 GTK+ API
carlosgc@webkit.org [Fri, 6 Jul 2012 16:04:25 +0000 (16:04 +0000)]
[GTK] Add site specific quirks setting to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=90663

Reviewed by Martin Robinson.

* UIProcess/API/gtk/WebKitSettings.cpp:
(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init):
(webkit_settings_get_enable_site_specific_quirks):
(webkit_settings_set_enable_site_specific_quirks):
* UIProcess/API/gtk/WebKitSettings.h:
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
* UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
(testWebKitSettings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][GTK] jhbuild : Disable pixman demos build depending on GTK+
commit-queue@webkit.org [Fri, 6 Jul 2012 16:01:33 +0000 (16:01 +0000)]
[EFL][GTK] jhbuild : Disable pixman demos build depending on GTK+
https://bugs.webkit.org/show_bug.cgi?id=90593

Patch by Dongwoo Im <dw.im@samsung.com> on 2012-07-06
Reviewed by Philippe Normand.

* efl/jhbuild.modules: Give '--enable-gtk=no' option to pixman.
* gtk/jhbuild.modules: Give '--enable-gtk=no' option to pixman.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening, clean up the TestExpectations file, removing
zandobersek@gmail.com [Fri, 6 Jul 2012 15:55:57 +0000 (15:55 +0000)]
Unreviewed GTK gardening, clean up the TestExpectations file, removing
non-existent or doubled test entries and re-specifying detailed test
expectations so the TestExpectations lint passes.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] [GTK] http/tests/multipart/multipart-replace-non-html-content.php is failing...
commit-queue@webkit.org [Fri, 6 Jul 2012 15:02:09 +0000 (15:02 +0000)]
[EFL] [GTK] http/tests/multipart/multipart-replace-non-html-content.php is failing after r121912
https://bugs.webkit.org/show_bug.cgi?id=90685

Unreviewed gardening, add test expectation for a failing
test after r121912.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-07-06

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoProcessLauncher's WorkQueue's name is too long on Windows
commit-queue@webkit.org [Fri, 6 Jul 2012 14:49:53 +0000 (14:49 +0000)]
ProcessLauncher's WorkQueue's name is too long on Windows
https://bugs.webkit.org/show_bug.cgi?id=44041

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-07-06
Reviewed by Andreas Kling.

Shorten thread name for process launcher so that we can silence the warning
for thread names getting truncated under VisualStudio -
see createThread() in  Threading.cpp.

* UIProcess/Launcher/ProcessLauncher.cpp:
(WebKit::processLauncherWorkQueue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] DumpRenderTree does not use 'monospace' font when directed
ossy@webkit.org [Fri, 6 Jul 2012 14:37:57 +0000 (14:37 +0000)]
[Qt] DumpRenderTree does not use 'monospace' font when directed
https://bugs.webkit.org/show_bug.cgi?id=85203

The test fonts used for Qt tests were moved to the Liberation font family.

Due to this change we are skipping tons of tests. They will be gradually
unskipped in batches, ASAP.

Also, the now unneeded special font configuration for Qt5 WK1 was removed.

Patch by Luciano Wolf <luciano.wolf@openbossa.org> on 2012-07-06
Reviewed by Tor Arne Vestbø.

Tools:

* DumpRenderTree/qt/QtInitializeTestFonts.cpp:
(WebKit::initializeTestFonts):

LayoutTests:

* platform/qt-4.8/Skipped:
* platform/qt-5.0-wk1/Skipped:
* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] REGRESSION: 5 tests started to fail with newer Qt5
ossy@webkit.org [Fri, 6 Jul 2012 14:21:50 +0000 (14:21 +0000)]
[Qt] REGRESSION: 5 tests started to fail with newer Qt5
https://bugs.webkit.org/show_bug.cgi?id=90687

Unreviewed gardening, skip new failing tests.

* platform/qt-5.0/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] WebKit-EFL headers do not build with gcc < 4.6
commit-queue@webkit.org [Fri, 6 Jul 2012 14:16:05 +0000 (14:16 +0000)]
[EFL] WebKit-EFL headers do not build with gcc < 4.6
https://bugs.webkit.org/show_bug.cgi?id=90681

Unreviewed EFL build fix.

Remove several forward declarations from ewk_view
header to avoid typedef redefinitions which are
illegal in C.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-06

* UIProcess/API/efl/ewk_view.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Add native memory used by GlyphCache to the snapshot
commit-queue@webkit.org [Fri, 6 Jul 2012 14:09:12 +0000 (14:09 +0000)]
Web Inspector: Add native memory used by GlyphCache to the snapshot
https://bugs.webkit.org/show_bug.cgi?id=90615

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-07-06
Reviewed by Yury Semikhatsky.

* inspector/InspectorMemoryAgent.cpp:
(MemoryBlockName):
(WebCore):
(WebCore::addPlatformComponentsInfo):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):
* inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.MemoryBlockViewProperties._initialize):
* platform/MemoryUsageSupport.cpp:
(WebCore::MemoryUsageSupport::memoryUsageByComponents):
(WebCore):
* platform/MemoryUsageSupport.h:
(MemoryUsageSupport):
(ComponentInfo):
(WebCore::MemoryUsageSupport::ComponentInfo::ComponentInfo):
* platform/chromium/MemoryUsageSupportChromium.cpp:
(WebCore::glyphCacheVisitor):
(WebCore):
(WebCore::MemoryUsageSupport::memoryUsageByComponents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Buildfix for newer Qt5
ossy@webkit.org [Fri, 6 Jul 2012 13:23:56 +0000 (13:23 +0000)]
[Qt] Buildfix for newer Qt5
https://bugs.webkit.org/show_bug.cgi?id=90519

Reviewed by Tor Arne Vestbø.

Source/WebKit/qt:

* WebCoreSupport/QtFallbackWebPopup.cpp: Include QtGui/QStandardItemModel instead of deprecated QStandardItemModel.

Source/WebKit2:

* UIProcess/API/qt/qwebkittest.cpp: Include qpa/qwindowsysteminterface.h instead of deprecated qwindowsysteminterface_qpa.h.

Tools:

* MiniBrowser/qt/MiniBrowser.pro: We also need to depend on gui-private in the MiniBrowser to get access to these headers.
* MiniBrowser/qt/MiniBrowserApplication.h: Include qpa/qwindowsysteminterface.h instead of deprecated qwindowsysteminterface_qpa.h
* WebKitTestRunner/qt/PlatformWebViewQt.cpp: Include qpa/qwindowsysteminterface.h instead of deprecated qwindowsysteminterface_qpa.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Make use of Qt5 qmake's changed makefile recursion behavior
ossy@webkit.org [Fri, 6 Jul 2012 13:20:11 +0000 (13:20 +0000)]
[Qt] Make use of Qt5 qmake's changed makefile recursion behavior

When not using the -r option, qmake now interleaves qmake and make calls,
so we don't need custom logic for this. There's also an option to supress
the effect of the -r option, which we use to make WebKit.pro the only
project file parsed in a recursive qmake-run.

https://bugs.webkit.org/show_bug.cgi?id=90461

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-07-06
Reviewed by Tor Arne Vestbø.

* qmake/mkspecs/features/default_post.prf:
* qmake/mkspecs/features/functions.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Remove custom qmake logic for module creation
ossy@webkit.org [Fri, 6 Jul 2012 13:18:47 +0000 (13:18 +0000)]
[Qt] Remove custom qmake logic for module creation

Qmake now has the necessary hooks to cleanly override the build locations.

https://bugs.webkit.org/show_bug.cgi?id=90461

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-07-06
Reviewed by Tor Arne Vestbø.

.:

* Source/api.pri:

Tools:

* qmake/mkspecs/features/default_pre.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Add top-level .qmake.conf
ossy@webkit.org [Fri, 6 Jul 2012 13:17:36 +0000 (13:17 +0000)]
[Qt] Add top-level .qmake.conf

With Qt5, this makes setting $QMAKEPATH externally unnecessary.

The magic in the perl scripts to set QMAKEPATH is still there, as it doesn't
hurt, and is still required for Qt4.

https://bugs.webkit.org/show_bug.cgi?id=90461

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-07-06
Reviewed by Tor Arne Vestbø.

.:

* .qmake.conf: Added.
* WebKit.pro:

Tools:

* qmake/mkspecs/features/default_pre.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unify qtFeatureDefaults code paths
ossy@webkit.org [Fri, 6 Jul 2012 13:16:33 +0000 (13:16 +0000)]
[Qt] Unify qtFeatureDefaults code paths

There's no reason to run qmake on features.prf directly anymore, as we
can selectivly run configure tests in the project file now.

https://bugs.webkit.org/show_bug.cgi?id=90461

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-07-06
Reviewed by Tor Arne Vestbø.

* Scripts/webkitdirs.pm:
(qtFeatureDefaults):
* qmake/configure.pri:
* qmake/mkspecs/features/features.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Let qt_module_config create the forwarding module pri file
ossy@webkit.org [Fri, 6 Jul 2012 13:15:24 +0000 (13:15 +0000)]
[Qt] Let qt_module_config create the forwarding module pri file

https://bugs.webkit.org/show_bug.cgi?id=90461

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-07-06
Reviewed by Tor Arne Vestbø.

* Source/sync.profile:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Don't let qt_webkit.pri proclaim its own location
ossy@webkit.org [Fri, 6 Jul 2012 13:14:20 +0000 (13:14 +0000)]
[Qt] Don't let qt_webkit.pri proclaim its own location

This won't work any more with recent Qt5 versions, as the forwarding
pri is created by qt_module_config, which needs MODULE_PRI to be set
up already.

We also need to load build_config, not qt_module.

https://bugs.webkit.org/show_bug.cgi?id=90461

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-07-06
Reviewed by Tor Arne Vestbø.

.:

* Source/api.pri:

Tools:

* qmake/qt_webkit.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Remove redundant CONFIG+=module
ossy@webkit.org [Fri, 6 Jul 2012 13:13:07 +0000 (13:13 +0000)]
[Qt] Remove redundant CONFIG+=module

qt_module_config takes care of that.

In api.pri we are actually testing the flag ourselves, so now we need to
test a related flag qt_module_config sets instead.

.:

https://bugs.webkit.org/show_bug.cgi?id=90461

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-07-06
Reviewed by Tor Arne Vestbø.

* Source/api.pri:

Tools:

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-07-06
Reviewed by Tor Arne Vestbø.

* qmake/mkspecs/features/default_post.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Adjust to changed generation of master include file
ossy@webkit.org [Fri, 6 Jul 2012 13:12:01 +0000 (13:12 +0000)]
[Qt] Adjust to changed generation of master include file

The responsiblity for creating the master include was moved out of syncqt.
@ignore_for_master_contents still stays, as syncqt (ab-)uses this for
determining whether a header is private.

https://bugs.webkit.org/show_bug.cgi?id=90461

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-07-06
Reviewed by Tor Arne Vestbø.

.:

* Source/sync.profile:

Source/WebKit/qt:

* Api/qwebscriptworld.h:
* tests/util.h:

Source/WebKit2:

* UIProcess/API/qt/tests/bytearraytestdata.h:
* UIProcess/API/qt/tests/testwindow.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Switch to new-style Qt 5 configure tests
ossy@webkit.org [Fri, 6 Jul 2012 13:10:45 +0000 (13:10 +0000)]
[Qt] Switch to new-style Qt 5 configure tests

Use explicit project file action instead of syncqt magic.

https://bugs.webkit.org/show_bug.cgi?id=90461

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-07-06
Reviewed by Tor Arne Vestbø.

Source/WebCore:

* WebCore.pri:

Tools:

* Scripts/webkitdirs.pm:
(buildQMakeProjects):
* qmake/configure.pri: Copied from Tools/qmake/configure.pro.
* qmake/configure.pro:
* qmake/mkspecs/features/default_pre.prf:
* qmake/mkspecs/features/features.prf:
* qmake/sync.profile: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: start searching from the cursor position in the Sources panel.
pfeldman@chromium.org [Fri, 6 Jul 2012 13:08:41 +0000 (13:08 +0000)]
Web Inspector: start searching from the cursor position in the Sources panel.
https://bugs.webkit.org/show_bug.cgi?id=90677

Reviewed by Vsevolod Vlasov.

Web Inspector: start searching from the cursor position in the Sources panel.
Drive-by: select whole match upon search cancel.
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.performSearch.finishedCallback):
(WebInspector.ScriptsPanel.prototype.performSearch):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.performSearch.doFindSearchMatches):
(WebInspector.SourceFrame.prototype.performSearch):
* inspector/front-end/TextEditor.js:
(WebInspector.TextEditor.prototype.lastSelection):
(WebInspector.TextEditor.prototype._handleFocused):
* inspector/front-end/TextEditorModel.js:
(WebInspector.TextRange.prototype.serializeToObject):
(WebInspector.TextRange.prototype.compareTo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Snippets should be correctly (re)loaded when inspector is open and...
vsevik@chromium.org [Fri, 6 Jul 2012 12:19:33 +0000 (12:19 +0000)]
Web Inspector: Snippets should be correctly (re)loaded when inspector is open and on navigation.
https://bugs.webkit.org/show_bug.cgi?id=90672

Reviewed by Pavel Feldman.

Snippets are now reloaded from the storage on ScriptSnippetMapping reset.
Fixed snippets storage.

* inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel):
(WebInspector.ScriptSnippetModel.prototype._loadSnippets):
(WebInspector.ScriptSnippetModel.prototype._reset):
* inspector/front-end/SnippetStorage.js:
(WebInspector.Snippet.fromObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Implement snippets removing.
vsevik@chromium.org [Fri, 6 Jul 2012 12:14:24 +0000 (12:14 +0000)]
Web Inspector: Implement snippets removing.
https://bugs.webkit.org/show_bug.cgi?id=90674

Reviewed by Pavel Feldman.

* inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorView.prototype.rename.afterEditing):
* inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator.prototype.removeUISourceCode):
(WebInspector.SnippetsNavigatorView.prototype._handleRemoveSnippet):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._addUISourceCode):
(WebInspector.ScriptsPanel.prototype._uiSourceCodeRemoved):
(WebInspector.ScriptsPanel.prototype._revealExecutionLine):
* inspector/front-end/TabbedEditorContainer.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening, adding a test expectation for a failing
zandobersek@gmail.com [Fri, 6 Jul 2012 12:02:37 +0000 (12:02 +0000)]
Unreviewed GTK gardening, adding a test expectation for a failing
http multipart test after r121912.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNot reviewed: fix inspector front-end compilation.
pfeldman@chromium.org [Fri, 6 Jul 2012 11:45:36 +0000 (11:45 +0000)]
Not reviewed: fix inspector front-end compilation.

* inspector/front-end/ElementsTreeOutline.js:
* inspector/front-end/SearchController.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: add memory reporting routine to Document
yurys@chromium.org [Fri, 6 Jul 2012 11:25:28 +0000 (11:25 +0000)]
Web Inspector: add memory reporting routine to Document
https://bugs.webkit.org/show_bug.cgi?id=90668

Reviewed by Pavel Feldman.

Added methods for reporting HashSet, ListHashSet and Vector memory
footprint. Made Document report its size along with its internal
collections sizes.

* dom/Document.cpp:
(WebCore::Document::reportMemoryUsage):
(WebCore):
* dom/Document.h:
(Document):
* dom/MemoryInstrumentation.h:
(MemoryInstrumentation):
(MemoryObjectInfo):
(WebCore::MemoryObjectInfo::reportHashMap):
(WebCore::MemoryObjectInfo::reportHashSet):
(WebCore::MemoryObjectInfo::reportListHashSet):
(WebCore::MemoryObjectInfo::reportVector):
(WebCore::MemoryObjectInfo::memoryInstrumentation):
(WebCore::MemoryInstrumentation::reportHashMap):
(WebCore):
(WebCore::MemoryInstrumentation::reportHashSet):
(WebCore::MemoryInstrumentation::reportListHashSet):
(WebCore::MemoryInstrumentation::reportVector):
* inspector/InspectorMemoryAgent.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFixing defines for NEON intrinsics.
rgabor@webkit.org [Fri, 6 Jul 2012 10:05:07 +0000 (10:05 +0000)]
Fixing defines for NEON intrinsics.
https://bugs.webkit.org/show_bug.cgi?id=90666

Reviewed by Zoltan Herczeg.

Existing tests cover this issue.

* platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::platformApplyGeneric):
* platform/graphics/filters/arm/FEGaussianBlurNEON.h:
* platform/graphics/filters/arm/NEONHelpers.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Inspector][WebSocket][NRWT] layout tests which requires websocket server must be...
toyoshim@chromium.org [Fri, 6 Jul 2012 10:04:56 +0000 (10:04 +0000)]
[Inspector][WebSocket][NRWT] layout tests which requires websocket server must be in a websocket subdirectory.
https://bugs.webkit.org/show_bug.cgi?id=90524

Reviewed by Pavel Feldman.

* http/tests/inspector/websocket/web-socket-frame-expected.txt: Renamed from LayoutTests/http/tests/inspector/web-socket-frame-expected.txt.
* http/tests/inspector/websocket/web-socket-frame.html: Renamed from LayoutTests/http/tests/inspector/web-socket-frame.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Workspace should dispatch WorkspaceReset event on navigation.
vsevik@chromium.org [Fri, 6 Jul 2012 09:46:35 +0000 (09:46 +0000)]
Web Inspector: Workspace should dispatch WorkspaceReset event on navigation.
https://bugs.webkit.org/show_bug.cgi?id=90616

Reviewed by Pavel Feldman.

Source/WebCore:

Workspace UISourceCodeProviders are now reset on navigation.
UISourceCodeRemoved event is not dispatched from UISourceCodeProviders on reset (page navigation) anymore.

* inspector/front-end/CompilerScriptMapping.js:
(WebInspector.CompilerScriptMapping.prototype.reset):
* inspector/front-end/DebuggerScriptMapping.js:
(WebInspector.DebuggerScriptMapping):
* inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeRemoved):
* inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel.prototype._reset):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._loadUISourceCodes):
(WebInspector.ScriptsPanel.prototype._reset):
(WebInspector.ScriptsPanel.prototype.canShowAnchorLocation):
(WebInspector.ScriptsPanel.prototype._toggleFormatSource):
(WebInspector.ScriptsPanel.prototype.showGoToSourceDialog):
* inspector/front-end/StylesPanel.js:
(WebInspector.StylesUISourceCodeProvider):
(WebInspector.StylesUISourceCodeProvider.prototype.reset):
* inspector/front-end/Workspace.js:
(WebInspector.CompositeUISourceCodeProvider.prototype.uiSourceCodeProviders):
(WebInspector.Workspace):
(WebInspector.Workspace.prototype.registerUISourceCodeProvider):
(WebInspector.Workspace.prototype._reset):

LayoutTests:

* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
* inspector/debugger/linkifier.html:
* inspector/debugger/scripts-panel.html:
* inspector/styles/edit-inspector-stylesheet.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][ARM] REGRESSION(r121885): It broke 30 jsc tests, 500+ layout tests
zherczeg@webkit.org [Fri, 6 Jul 2012 08:42:29 +0000 (08:42 +0000)]
[Qt][ARM] REGRESSION(r121885): It broke 30 jsc tests, 500+ layout tests
https://bugs.webkit.org/show_bug.cgi?id=90656

Reviewed by Csaba Osztrogonác.

Typo fixes.

* assembler/MacroAssemblerARM.cpp:
(JSC::MacroAssemblerARM::load32WithUnalignedHalfWords):
Rename getOp2Byte() -> getOp2Half()
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::convertibleLoadPtr):
Add a necessary space.
* jit/JITStubs.cpp:
(JSC):
Revert INLINE_ARM_FUNCTION macro.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Add Web Inspector to WebKit-EFL
commit-queue@webkit.org [Fri, 6 Jul 2012 07:17:22 +0000 (07:17 +0000)]
[EFL] Add Web Inspector to WebKit-EFL
https://bugs.webkit.org/show_bug.cgi?id=83865

Patch by Seokju Kwon <seokju.kwon@samsung.com> on 2012-07-06
Reviewed by Pavel Feldman.

Source/WebKit:

EFL port implementation for Web Inspector.
Prepare Web Inspector resources.

* PlatformEfl.cmake:

Source/WebKit/efl:

EFL port implementation for Web Inspector.
Implementation of InspectorClientEfl and InspectorFrontendClientEfl
for using the Web Inspector in WebKit-EFL with new EWK APIs.

* WebCoreSupport/InspectorClientEfl.cpp:
(WebCore::notifyWebInspectorDestroy):
(WebCore):
(InspectorFrontendSettingsEfl):
(WebCore::InspectorFrontendSettingsEfl::getProperty):
(WebCore::InspectorFrontendSettingsEfl::setProperty):
(WebCore::InspectorClientEfl::InspectorClientEfl):
(WebCore::InspectorClientEfl::~InspectorClientEfl):
(WebCore::InspectorClientEfl::inspectorDestroyed):
(WebCore::InspectorClientEfl::openInspectorFrontend):
(WebCore::InspectorClientEfl::closeInspectorFrontend):
(WebCore::InspectorClientEfl::bringFrontendToFront):
(WebCore::InspectorClientEfl::sendMessageToFrontend):
(WebCore::InspectorClientEfl::releaseFrontendPage):
(WebCore::InspectorClientEfl::inspectorFilesPath):
(WebCore::InspectorFrontendClientEfl::InspectorFrontendClientEfl):
(WebCore::InspectorFrontendClientEfl::~InspectorFrontendClientEfl):
(WebCore::InspectorFrontendClientEfl::localizedStringsURL):
(WebCore::InspectorFrontendClientEfl::hiddenPanels):
(WebCore::InspectorFrontendClientEfl::bringToFront):
(WebCore::InspectorFrontendClientEfl::closeWindow):
(WebCore::InspectorFrontendClientEfl::inspectedURLChanged):
(WebCore::InspectorFrontendClientEfl::attachWindow):
(WebCore::InspectorFrontendClientEfl::detachWindow):
(WebCore::InspectorFrontendClientEfl::setAttachedWindowHeight):
(WebCore::InspectorFrontendClientEfl::destroyInspectorWindow):
* WebCoreSupport/InspectorClientEfl.h:
(WebCore):
(InspectorClientEfl):
(InspectorFrontendClientEfl):
(WebCore::InspectorFrontendClientEfl::disconnectInspectorClient):
* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(ewk_view_web_inspector_show):
(ewk_view_web_inspector_close):
(ewk_view_web_inspector_view_get):
(ewk_view_web_inspector_view_set):
* ewk/ewk_view.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r121925): It broke 5 sputnik tests on x86 platforms
fpizlo@apple.com [Fri, 6 Jul 2012 07:01:35 +0000 (07:01 +0000)]
REGRESSION(r121925): It broke 5 sputnik tests on x86 platforms
https://bugs.webkit.org/show_bug.cgi?id=90658

Reviewed by Zoltan Herczeg.

Under the new object model, out-of-line property accesses such as those
in ResolveGlobal must account for the fact that the offset to the Kth
property is represented by K + inlineStorageCapacity. Hence, the property
loads in ResolveGlobal must have an additional -inlineStorageCapacity *
sizeof(JSValue) offset.

* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Showing the context menu in the Web Inspector can crash the browser
commit-queue@webkit.org [Fri, 6 Jul 2012 06:27:30 +0000 (06:27 +0000)]
[GTK] Showing the context menu in the Web Inspector can crash the browser
https://bugs.webkit.org/show_bug.cgi?id=88800

Patch by Arnaud Renevier <arno@renevier.net> on 2012-07-05
Reviewed by Carlos Garcia Campos.

Remove ContextMenuItem from its parent before appending it again to a
new parent

No new tests, behavior is unchanged.

* platform/gtk/ContextMenuGtk.cpp:
(WebCore::ContextMenu::appendItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2][EFL] Ewk_View needs to report load status changes
commit-queue@webkit.org [Fri, 6 Jul 2012 06:07:52 +0000 (06:07 +0000)]
[WK2][EFL] Ewk_View needs to report load status changes
https://bugs.webkit.org/show_bug.cgi?id=90566

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-05
Reviewed by Kenneth Rohde Christiansen.

Add new "load,finished", "load,provisional,failed",
"load,provisional,redirect" and "load,provisional,started"
signals on the Ewk_View to notify the client of different
load state changes.

* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_load_finished):
(ewk_view_load_provisional_failed):
(ewk_view_load_provisional_redirect):
(ewk_view_load_provisional_started):
* UIProcess/API/efl/ewk_view.h:
* UIProcess/API/efl/ewk_view_loader_client.cpp:
(didFinishLoadForFrame):
(didFailLoadWithErrorForFrame):
(didStartProvisionalLoadForFrame):
(didReceiveServerRedirectForProvisionalLoadForFrame):
(didFailProvisionalLoadWithErrorForFrame):
(ewk_view_loader_client_attach):
* UIProcess/API/efl/ewk_view_private.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed 64 bit buildfix after r121925.
ossy@webkit.org [Fri, 6 Jul 2012 04:52:26 +0000 (04:52 +0000)]
[Qt] Unreviewed 64 bit buildfix after r121925.

* bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFromLLInt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Transform should be applied to the clip rect in QRawWebView::paint
commit-queue@webkit.org [Fri, 6 Jul 2012 04:31:26 +0000 (04:31 +0000)]
[Qt] Transform should be applied to the clip rect in QRawWebView::paint
https://bugs.webkit.org/show_bug.cgi?id=90652

Patch by Luiz Agostini <luiz.agostini@nokia.com> on 2012-07-05
Reviewed by Kenneth Rohde Christiansen.

Applying the transformation matrix to the clip rect in QRawWebView::paint.

* UIProcess/API/qt/raw/qrawwebview.cpp:
(QRawWebView::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd Jason Liu to committers.py.
jason.liu@torchmobile.com.cn [Fri, 6 Jul 2012 04:25:11 +0000 (04:25 +0000)]
Add Jason Liu to committers.py.
https://bugs.webkit.org/show_bug.cgi?id=90654

Unreviewed.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed Chromium gardening. Roll Chromium DEPS
yosin@chromium.org [Fri, 6 Jul 2012 04:09:40 +0000 (04:09 +0000)]
Unreviewed Chromium gardening. Roll Chromium DEPS

* DEPS: 145501 => 145569

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed Chromium gardening - Rebaseline for r121917.
yosin@chromium.org [Fri, 6 Jul 2012 03:57:04 +0000 (03:57 +0000)]
Unreviewed Chromium gardening - Rebaseline for r121917.

* platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Removed.
* platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Removed.
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
* platform/chromium-mac/fast/html/details-marker-style-expected.png:
* platform/chromium-mac/fast/html/details-marker-style-expected.txt:
* platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
* platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
* platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
* platform/chromium-win/fast/html/details-marker-style-expected.png:
* platform/chromium-win/fast/html/details-marker-style-expected.txt:
* platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
* platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Unreviewed, Fix build break when WEB_AUDIO is enabled.
commit-queue@webkit.org [Fri, 6 Jul 2012 03:47:27 +0000 (03:47 +0000)]
[EFL] Unreviewed, Fix build break when WEB_AUDIO is enabled.
https://bugs.webkit.org/show_bug.cgi?id=90653

Unreviewed build fix.

A new file, AudioFIFO.cpp, is added for the Web Audio fearure.
This file should be included into the CMakeLists.txt file.

Patch by Dongwoo Im <dw.im@samsung.com> on 2012-07-05

* CMakeLists.txt: Add the newly created file into the CMakeLists.txt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed Chromium gardening - Disable WebAnimationTest for Linux and Windows.
yosin@chromium.org [Fri, 6 Jul 2012 03:33:47 +0000 (03:33 +0000)]
Unreviewed Chromium gardening - Disable WebAnimationTest for Linux and Windows.
https://bugs.webkit.org/show_bug.cgi?id=90651

* tests/WebAnimationTest.cpp:
(WebKit):
(WebKit::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMultiple Content Security Policy headers are correctly processed as separate headers.
commit-queue@webkit.org [Fri, 6 Jul 2012 02:50:57 +0000 (02:50 +0000)]
Multiple Content Security Policy headers are correctly processed as separate headers.
https://bugs.webkit.org/show_bug.cgi?id=90629

Source/WebCore:

Headers of the same name are normalized into a single, comma-separated
string as per RFC2616, section 4.2. We didn't correctly account for this
in ContentSecurityPolicy::didReceiveHeader. Now we do by walking through
the header string, looking for commas and processing each block in turn.

This oversight bit Firefox as well, and was patched in February:
https://bugzilla.mozilla.org/show_bug.cgi?id=717511

Patch by Mike West <mkwst@chromium.org> on 2012-07-05
Reviewed by Adam Barth.

Test: http/tests/security/contentSecurityPolicy/directive-parsing-multiple-headers.html

* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::didReceiveHeader):

LayoutTests:

Patch by Mike West <mkwst@chromium.org> on 2012-07-05
Reviewed by Adam Barth.

* http/tests/security/contentSecurityPolicy/directive-parsing-multiple-headers-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/directive-parsing-multiple-headers.html: Added.
* http/tests/security/contentSecurityPolicy/resources/echo-multiple-headers.pl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, skipping failing tests.
fpizlo@apple.com [Fri, 6 Jul 2012 01:55:14 +0000 (01:55 +0000)]
Unreviewed, skipping failing tests.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2][EFL] Ewk_View should provide API to set/get device pixel ratio
commit-queue@webkit.org [Fri, 6 Jul 2012 01:47:55 +0000 (01:47 +0000)]
[WK2][EFL] Ewk_View should provide API to set/get device pixel ratio
https://bugs.webkit.org/show_bug.cgi?id=90590

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-05
Reviewed by Kenneth Rohde Christiansen.

Add API to Ewk_View so retrieve and set the device
pixel ratio.

* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_device_pixel_ratio_set):
(ewk_view_device_pixel_ratio_get):
* UIProcess/API/efl/ewk_view.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r121921.
commit-queue@webkit.org [Fri, 6 Jul 2012 01:27:35 +0000 (01:27 +0000)]
Unreviewed, rolling out r121921.
http://trac.webkit.org/changeset/121921
https://bugs.webkit.org/show_bug.cgi?id=90648

caused hundreds of crashes on Mac (Requested by pizlo on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-05

Source/WebCore:

* editing/SurroundingText.cpp:
(WebCore::SurroundingText::SurroundingText):
* editing/TextIterator.cpp:
(WebCore::CharacterIterator::advance):
(WebCore::BackwardsCharacterIterator::advance):

LayoutTests:

* platform/chromium/editing/surrounding-text/surrounding-text-expected.txt:
* platform/chromium/editing/surrounding-text/surrounding-text.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoType-ahead doesn't work in options inside optgroups
andersca@apple.com [Fri, 6 Jul 2012 01:24:38 +0000 (01:24 +0000)]
Type-ahead doesn't work in options inside optgroups
https://bugs.webkit.org/show_bug.cgi?id=90647
<rdar://problem/5604894>

Reviewed by Dan Bernstein.

Set the title of the menu item to a string that doesn't contain any leading or trailing whitespace.

Source/WebCore:

* platform/mac/PopupMenuMac.mm:
(WebCore::PopupMenuMac::populate):

Source/WebKit2:

* UIProcess/mac/WebPopupMenuProxyMac.mm:
(WebKit::WebPopupMenuProxyMac::populate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Fix the build error introduced by enabling CUSTOM_THEME_HANDLER
charles.wei@torchmobile.com.cn [Fri, 6 Jul 2012 01:05:46 +0000 (01:05 +0000)]
[BlackBerry] Fix the build error introduced by enabling CUSTOM_THEME_HANDLER
https://bugs.webkit.org/show_bug.cgi?id=90588

Reviewed by Rob Buis.

Fix the build error introduced by enabling CUSTOM_THEME_HANDLER.
* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::isProtocolHandlerRegistered):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agot/fuzzer-mouse-crash
hayato@chromium.org [Fri, 6 Jul 2012 00:26:39 +0000 (00:26 +0000)]
t/fuzzer-mouse-crash

<patch description>

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDouble release of resources if the load is canceled in a callback of ResourceLoader...
benjamin@webkit.org [Fri, 6 Jul 2012 00:20:44 +0000 (00:20 +0000)]
Double release of resources if the load is canceled in a callback of ResourceLoader::didFinishLoading
https://bugs.webkit.org/show_bug.cgi?id=90431

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-07-05
Reviewed by Anders Carlsson.

Source/WebCore:

In ResourceLoader::didFinishLoadingOnePart(), we invoke didFinishLoad() on the WebKit client. If WebKit
causes the current frame to cancel the load synchronously, the resources are already freed when
ResourceLoader::didFinishLoadingOnePart() ends.
When ResourceLoader::didFinishLoading() subsequently invokes releaseResources(), we are releasing the
resources a second time.

This patch add a second check for cancellation after invoking ResourceLoader::didFinishLoadingOnePart() to
avoid such issues.

The previous check at the beginning of ResourceLoader::didFinishLoading() has been removed because it is
redundant with ResourceLoader::didFinishLoadingOnePart().

* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::didFinishLoading):
(WebCore::ResourceLoader::didFinishLoadingOnePart):

Tools:

Add a Mac API test.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.html: Added.
* TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.mm: Added.
(-[CancelLoadFromResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
(-[CancelLoadFromResourceLoadDelegateFrameLoadDelegate webView:didFinishLoadForFrame:]):
(TestWebKitAPI):
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoJSString::tryHashConstLock() fails to get exclusive lock
msaboff@apple.com [Fri, 6 Jul 2012 00:04:05 +0000 (00:04 +0000)]
JSString::tryHashConstLock() fails to get exclusive lock
https://bugs.webkit.org/show_bug.cgi?id=90639

Reviewed by Oliver Hunt.

Added check that the string is already locked even before compare and swap.

* heap/MarkStack.cpp:
(JSC::JSString::tryHashConstLock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoINLINE_ARM_FUNCTION(thingy) should make thingy be thumb2 if we're using thumb2
fpizlo@apple.com [Thu, 5 Jul 2012 23:31:00 +0000 (23:31 +0000)]
INLINE_ARM_FUNCTION(thingy) should make thingy be thumb2 if we're using thumb2
https://bugs.webkit.org/show_bug.cgi?id=90644

Reviewed by Mark Hahnenberg.

Fix breakage introduced in http://trac.webkit.org/changeset/121885

* wtf/InlineASM.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd a utility method for hasOverflowClip() or hasClip()
simon.fraser@apple.com [Thu, 5 Jul 2012 23:14:29 +0000 (23:14 +0000)]
Add a utility method for hasOverflowClip() or hasClip()
https://bugs.webkit.org/show_bug.cgi?id=90635

Reviewed by Dean Jackson.

Add RenderObject::hasClipOrOverflowClip() as a convenience method
since we end up calling hasOverfFlowClip() || hasClip() a lot in the layer code.

No new tests; refactoring only.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects):
(WebCore::RenderLayer::calculateRects):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::enclosingNonStackingClippingLayer):
(WebCore::RenderLayerCompositor::clipsCompositingDescendants):
* rendering/RenderObject.h:
(WebCore::RenderObject::hasClipOrOverflowClip):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoInline property storage should not be wasted when it is exhausted
fpizlo@apple.com [Thu, 5 Jul 2012 22:55:51 +0000 (22:55 +0000)]
Inline property storage should not be wasted when it is exhausted
https://bugs.webkit.org/show_bug.cgi?id=90347

Reviewed by Gavin Barraclough.

Previously, if we switched an object from using inline storage to out-of-line
storage, we would abandon the inline storage. This would have two main implications:
(i) all accesses to the object, even for properties that were previously in inline
storage, must now take an extra indirection; and (ii) we waste a non-trivial amount
of space since we must allocate additional out-of-line storage to hold properties
that would have fit in the inline storage. There's also the copying cost when
switching to out-of-line storage - we must copy all inline properties into ouf-of-line
storage.

This patch changes the way that object property storage works so that we can use both
inline and out-of-line storage concurrently. This is accomplished by introducing a
new notion of property offset. This PropertyOffset is a 32-bit signed integer and it
behaves as follows:

offset == -1: invalid offset, indicating a property that does not exist.

0 <= offset <= inlineStorageCapacity: offset into inline storage.

inlineStorageCapacity < offset: offset into out-of-line storage.

Because non-final objects don't have inline storage, the only valid PropertyOffsets
for those objects' properties are -1 or > inlineStorageCapacity.

This now means that the decision to use inline or out-of-line storage for an access is
made based on the offset, rather than the structure. It also means that any access
where the offset is a variable must have an extra branch, unless the type of the
object is also known (if it's known to be a non-final object then we can just assert
that the offset is >= inlineStorageCapacity).

This looks like a big Kraken speed-up and a slight V8 speed-up.

* GNUmakefile.list.am:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* assembler/ARMv7Assembler.h:
(ARMv7Assembler):
(JSC::ARMv7Assembler::ldrWide8BitImmediate):
(JSC::ARMv7Assembler::replaceWithLoad):
(JSC::ARMv7Assembler::replaceWithAddressComputation):
* assembler/AbstractMacroAssembler.h:
(AbstractMacroAssembler):
(ConvertibleLoadLabel):
(JSC::AbstractMacroAssembler::ConvertibleLoadLabel::ConvertibleLoadLabel):
(JSC::AbstractMacroAssembler::ConvertibleLoadLabel::isSet):
(JSC::AbstractMacroAssembler::labelIgnoringWatchpoints):
(JSC::AbstractMacroAssembler::replaceWithLoad):
(JSC::AbstractMacroAssembler::replaceWithAddressComputation):
* assembler/CodeLocation.h:
(JSC):
(CodeLocationCommon):
(CodeLocationConvertibleLoad):
(JSC::CodeLocationConvertibleLoad::CodeLocationConvertibleLoad):
(JSC::CodeLocationCommon::convertibleLoadAtOffset):
* assembler/LinkBuffer.cpp:
(JSC::LinkBuffer::finalizeCodeWithDisassembly):
* assembler/LinkBuffer.h:
(LinkBuffer):
(JSC::LinkBuffer::locationOf):
* assembler/MacroAssemblerARMv7.h:
(MacroAssemblerARMv7):
(JSC::MacroAssemblerARMv7::convertibleLoadPtr):
* assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::convertibleLoadPtr):
(MacroAssemblerX86):
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::convertibleLoadPtr):
(MacroAssemblerX86_64):
* assembler/RepatchBuffer.h:
(RepatchBuffer):
(JSC::RepatchBuffer::replaceWithLoad):
(JSC::RepatchBuffer::replaceWithAddressComputation):
(JSC::RepatchBuffer::setLoadInstructionIsActive):
* assembler/X86Assembler.h:
(JSC::X86Assembler::replaceWithLoad):
(X86Assembler):
(JSC::X86Assembler::replaceWithAddressComputation):
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::printGetByIdOp):
(JSC::CodeBlock::dump):
(JSC::CodeBlock::finalizeUnconditionally):
* bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFromLLInt):
(JSC::GetByIdStatus::computeForChain):
(JSC::GetByIdStatus::computeFor):
* bytecode/GetByIdStatus.h:
(JSC::GetByIdStatus::GetByIdStatus):
(JSC::GetByIdStatus::offset):
(GetByIdStatus):
* bytecode/Opcode.h:
(JSC):
(JSC::padOpcodeName):
* bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFromLLInt):
(JSC::PutByIdStatus::computeFor):
* bytecode/PutByIdStatus.h:
(JSC::PutByIdStatus::PutByIdStatus):
(JSC::PutByIdStatus::offset):
(PutByIdStatus):
* bytecode/ResolveGlobalStatus.cpp:
(JSC):
(JSC::computeForStructure):
* bytecode/ResolveGlobalStatus.h:
(JSC::ResolveGlobalStatus::ResolveGlobalStatus):
(JSC::ResolveGlobalStatus::offset):
(ResolveGlobalStatus):
* bytecode/StructureSet.h:
(StructureSet):
* bytecode/StructureStubInfo.h:
* dfg/DFGByteCodeParser.cpp:
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::handleGetByOffset):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
* dfg/DFGJITCompiler.h:
(JSC::DFG::PropertyAccessRecord::PropertyAccessRecord):
(PropertyAccessRecord):
* dfg/DFGRepatch.cpp:
(JSC::DFG::dfgRepatchByIdSelfAccess):
(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::tryBuildGetByIDProtoList):
(JSC::DFG::emitPutReplaceStub):
(JSC::DFG::emitPutTransitionStub):
(JSC::DFG::tryCachePutByID):
(JSC::DFG::tryBuildPutByIdList):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::emitAllocateBasicJSObject):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::compile):
* heap/MarkStack.cpp:
(JSC::visitChildren):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::tryCacheGetByID):
(JSC::Interpreter::privateExecute):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
(JSC::PropertyStubCompilationInfo::copyToStubInfo):
* jit/JIT.h:
(JSC::PropertyStubCompilationInfo::PropertyStubCompilationInfo):
(JSC::JIT::compileGetByIdProto):
(JSC::JIT::compileGetByIdSelfList):
(JSC::JIT::compileGetByIdProtoList):
(JSC::JIT::compileGetByIdChainList):
(JSC::JIT::compileGetByIdChain):
(JSC::JIT::compilePutByIdTransition):
(JIT):
* jit/JITInlineMethods.h:
(JSC::JIT::emitAllocateBasicJSObject):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_resolve_global):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_resolve_global):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::compileGetDirectOffset):
(JSC::JIT::emit_op_method_check):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::compilePutDirectOffset):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::patchGetByIdSelf):
(JSC::JIT::patchPutByIdReplace):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_method_check):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::compilePutDirectOffset):
(JSC::JIT::compileGetDirectOffset):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::patchGetByIdSelf):
(JSC::JIT::patchPutByIdReplace):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
(JSC::JIT::emit_op_get_by_pname):
* jit/JITStubs.cpp:
(JSC::JITThunks::tryCacheGetByID):
(JSC::DEFINE_STUB_FUNCTION):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
* llint/LowLevelInterpreter.asm:
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:
* offlineasm/x86.rb:
* runtime/JSGlobalObject.h:
(JSGlobalObject):
(JSC::JSGlobalObject::functionNameOffset):
* runtime/JSObject.cpp:
(JSC::JSObject::visitChildren):
(JSC):
(JSC::JSFinalObject::visitChildren):
(JSC::JSObject::put):
(JSC::JSObject::deleteProperty):
(JSC::JSObject::getPropertySpecificValue):
(JSC::JSObject::removeDirect):
(JSC::JSObject::growOutOfLineStorage):
(JSC::JSObject::getOwnPropertyDescriptor):
* runtime/JSObject.h:
(JSObject):
(JSC::JSObject::getDirect):
(JSC::JSObject::getDirectLocation):
(JSC::JSObject::hasInlineStorage):
(JSC::JSObject::inlineStorageUnsafe):
(JSC::JSObject::inlineStorage):
(JSC::JSObject::outOfLineStorage):
(JSC::JSObject::locationForOffset):
(JSC::JSObject::offsetForLocation):
(JSC::JSObject::getDirectOffset):
(JSC::JSObject::putDirectOffset):
(JSC::JSObject::putUndefinedAtDirectOffset):
(JSC::JSObject::addressOfOutOfLineStorage):
(JSC::JSObject::finishCreation):
(JSC::JSNonFinalObject::JSNonFinalObject):
(JSC::JSNonFinalObject::finishCreation):
(JSFinalObject):
(JSC::JSFinalObject::finishCreation):
(JSC::JSFinalObject::JSFinalObject):
(JSC::JSObject::offsetOfOutOfLineStorage):
(JSC::JSObject::setOutOfLineStorage):
(JSC::JSObject::JSObject):
(JSC):
(JSC::JSCell::fastGetOwnProperty):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::setStructureAndReallocateStorageIfNecessary):
(JSC::JSObject::putDirectWithoutTransition):
(JSC::offsetRelativeToPatchedStorage):
(JSC::indexRelativeToBase):
(JSC::offsetRelativeToBase):
* runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::create):
* runtime/JSPropertyNameIterator.h:
(JSPropertyNameIterator):
(JSC::JSPropertyNameIterator::getOffset):
(JSC::JSPropertyNameIterator::finishCreation):
* runtime/JSValue.cpp:
(JSC::JSValue::putToPrimitive):
* runtime/Operations.h:
(JSC::normalizePrototypeChain):
* runtime/Options.cpp:
(JSC):
(JSC::Options::initialize):
* runtime/PropertyMapHashTable.h:
(PropertyMapEntry):
(JSC::PropertyMapEntry::PropertyMapEntry):
(PropertyTable):
(JSC::PropertyTable::PropertyTable):
(JSC::PropertyTable::getDeletedOffset):
(JSC::PropertyTable::addDeletedOffset):
(JSC::PropertyTable::nextOffset):
(JSC):
(JSC::PropertyTable::sizeInMemory):
* runtime/PropertyOffset.h: Added.
(JSC):
(JSC::checkOffset):
(JSC::validateOffset):
(JSC::isValidOffset):
(JSC::isInlineOffset):
(JSC::isOutOfLineOffset):
(JSC::offsetInInlineStorage):
(JSC::offsetInOutOfLineStorage):
(JSC::offsetInRespectiveStorage):
(JSC::numberOfOutOfLineSlotsForLastOffset):
(JSC::numberOfSlotsForLastOffset):
(JSC::nextPropertyOffsetFor):
(JSC::firstPropertyOffsetFor):
* runtime/PropertySlot.h:
(JSC::PropertySlot::cachedOffset):
(JSC::PropertySlot::setValue):
(JSC::PropertySlot::setCacheableGetterSlot):
(JSC::PropertySlot::clearOffset):
* runtime/PutPropertySlot.h:
(JSC::PutPropertySlot::setExistingProperty):
(JSC::PutPropertySlot::setNewProperty):
(JSC::PutPropertySlot::cachedOffset):
(PutPropertySlot):
* runtime/Structure.cpp:
(JSC::Structure::Structure):
(JSC::Structure::materializePropertyMap):
(JSC::nextOutOfLineStorageCapacity):
(JSC::Structure::growOutOfLineCapacity):
(JSC::Structure::suggestedNewOutOfLineStorageCapacity):
(JSC::Structure::addPropertyTransitionToExistingStructure):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::removePropertyTransition):
(JSC::Structure::flattenDictionaryStructure):
(JSC::Structure::addPropertyWithoutTransition):
(JSC::Structure::removePropertyWithoutTransition):
(JSC::Structure::copyPropertyTableForPinning):
(JSC::Structure::get):
(JSC::Structure::putSpecificValue):
(JSC::Structure::remove):
* runtime/Structure.h:
(Structure):
(JSC::Structure::putWillGrowOutOfLineStorage):
(JSC::Structure::previousID):
(JSC::Structure::outOfLineCapacity):
(JSC::Structure::outOfLineSizeForKnownFinalObject):
(JSC::Structure::outOfLineSizeForKnownNonFinalObject):
(JSC::Structure::outOfLineSize):
(JSC::Structure::hasInlineStorage):
(JSC::Structure::inlineCapacity):
(JSC::Structure::inlineSizeForKnownFinalObject):
(JSC::Structure::inlineSize):
(JSC::Structure::totalStorageSize):
(JSC::Structure::totalStorageCapacity):
(JSC::Structure::firstValidOffset):
(JSC::Structure::lastValidOffset):
(JSC::Structure::isValidOffset):
(JSC::Structure::isEmpty):
(JSC::Structure::transitionCount):
(JSC::Structure::get):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoJSObjectCallAsFunction should thisConvert the provided thisObject
oliver@apple.com [Thu, 5 Jul 2012 20:36:37 +0000 (20:36 +0000)]
JSObjectCallAsFunction should thisConvert the provided thisObject
https://bugs.webkit.org/show_bug.cgi?id=90628

Reviewed by Gavin Barraclough.

Perform this conversion on the provided this object.

* API/JSObjectRef.cpp:
(JSObjectCallAsFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCode refactoring: move mimeTypeFromUTITree to a separate file.
commit-queue@webkit.org [Thu, 5 Jul 2012 20:19:08 +0000 (20:19 +0000)]
Code refactoring: move mimeTypeFromUTITree to a separate file.
https://bugs.webkit.org/show_bug.cgi?id=90619

We should move UTI handling related code to a separate file.

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2012-07-05
Reviewed by David Kilzer.

* WebCore.xcodeproj/project.pbxproj: Add UTIUtilities.h/UTIUtilities.mm to xcode project, and drive-by fix
    that happened when editing the Xcode project file.
* platform/network/mac/UTIUtilities.h: Added.
(WebCore):
* platform/network/mac/UTIUtilities.mm: Added.  move mimeTypeFromUTITree to UTIUtilities.mm.
(WebCore):
(WebCore::mimeTypeFromUTITree):
* platform/network/mac/WebCoreURLResponse.mm: include UTIUtilities.h to use mimeTypeFromUTITree.
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Create a WebKit::Web* wrapper for the cc animation classes
vollick@chromium.org [Thu, 5 Jul 2012 20:07:55 +0000 (20:07 +0000)]
[chromium] Create a WebKit::Web* wrapper for the cc animation classes
https://bugs.webkit.org/show_bug.cgi?id=90303

Reviewed by James Robinson.

Source/Platform:

* Platform.gypi:
* chromium/public/WebAnimation.h: Added.
(WebCore):
(WebKit):
(WebAnimation):
(WebKit::WebAnimation::WebAnimation):
(WebKit::WebAnimation::~WebAnimation):
* chromium/public/WebAnimationCurve.h: Added.
(WebCore):
(WebKit):
(WebAnimationCurve):
(WebKit::WebAnimationCurve::~WebAnimationCurve):
(WebKit::WebAnimationCurve::WebAnimationCurve):
* chromium/public/WebFloatAnimationCurve.h: Added.
(WebCore):
(WebKit):
(WebFloatAnimationCurve):
(WebKit::WebFloatAnimationCurve::WebFloatAnimationCurve):
(WebKit::WebFloatAnimationCurve::~WebFloatAnimationCurve):
* chromium/public/WebFloatKeyframe.h: Added.
(WebKit):
(WebKit::WebFloatKeyframe::WebFloatKeyframe):
(WebFloatKeyframe):
* chromium/public/WebTransformAnimationCurve.h: Added.
(WebCore):
(WebKit):
(WebTransformAnimationCurve):
(WebKit::WebTransformAnimationCurve::WebTransformAnimationCurve):
(WebKit::WebTransformAnimationCurve::~WebTransformAnimationCurve):
* chromium/public/WebTransformKeyframe.h: Added.
(WebKit):
(WebKit::WebTransformKeyframe::WebTransformKeyframe):
(WebTransformKeyframe):

Source/WebKit/chromium:

* WebKit.gyp:
* WebKit.gypi:
* src/WebAnimation.cpp: Added.
(WebKit):
(WebKit::WebAnimation::iterations):
(WebKit::WebAnimation::setIterations):
(WebKit::WebAnimation::startTime):
(WebKit::WebAnimation::setStartTime):
(WebKit::WebAnimation::timeOffset):
(WebKit::WebAnimation::setTimeOffset):
(WebKit::WebAnimation::alternatesDirection):
(WebKit::WebAnimation::setAlternatesDirection):
(WebKit::WebAnimation::toCCActiveAnimation):
(WebKit::WebAnimation::initialize):
(WebKit::WebAnimation::destroy):
* src/WebAnimationCurveCommon.cpp: Added.
(WebKit):
(WebKit::createTimingFunction):
* src/WebAnimationCurveCommon.h: Added.
(WebCore):
(WebKit):
* src/WebFloatAnimationCurve.cpp: Added.
(WebKit):
(WebKit::WebFloatAnimationCurve::add):
(WebKit::WebFloatAnimationCurve::toCCAnimationCurve):
(WebKit::WebFloatAnimationCurve::initialize):
(WebKit::WebFloatAnimationCurve::destroy):
* src/WebTransformAnimationCurve.cpp: Added.
(WebKit):
(WebKit::WebTransformAnimationCurve::add):
(WebKit::WebTransformAnimationCurve::toCCAnimationCurve):
(WebKit::WebTransformAnimationCurve::initialize):
(WebKit::WebTransformAnimationCurve::destroy):
* tests/WebAnimationTest.cpp: Added.
* tests/WebFloatAnimationCurveTest.cpp: Added.
* tests/WebTransformAnimationCurveTest.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCharacter iterators should not advance if they are at end
leandrogracia@chromium.org [Thu, 5 Jul 2012 20:03:40 +0000 (20:03 +0000)]
Character iterators should not advance if they are at end
https://bugs.webkit.org/show_bug.cgi?id=90560

Reviewed by Ryosuke Niwa.

Source/WebCore:

CharacterIterator and BackwardsCharacterIterator try to advance their
internal TextIterator without checking if they already are at end.
This can cause crashes in TextIterator::advance.

Test: platform/chromium/editing/surrounding-text/surrounding-text.html

* editing/SurroundingText.cpp:
(WebCore::SurroundingText::SurroundingText):
* editing/TextIterator.cpp:
(WebCore::CharacterIterator::advance):
(WebCore::BackwardsCharacterIterator::advance):

LayoutTests:

Add a new test case where character iterators are already at end when
trying to advance. This was caught by Chromium's address sanitizer
here: http://code.google.com/p/chromium/issues/detail?id=135705

* platform/chromium/editing/surrounding-text/surrounding-text-expected.txt:
* platform/chromium/editing/surrounding-text/surrounding-text.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoText Autosizing: Add basic framework
commit-queue@webkit.org [Thu, 5 Jul 2012 19:57:22 +0000 (19:57 +0000)]
Text Autosizing: Add basic framework
https://bugs.webkit.org/show_bug.cgi?id=88655

Follow-up patch tweaking method signatures.

Patch by John Mellor <johnme@chromium.org> on 2012-07-05
Reviewed by Simon Fraser.

No functional change, so no new tests.

* page/FrameView.cpp:
(WebCore::FrameView::layout):
* rendering/TextAutosizer.cpp:
(WebCore::TextAutosizer::processSubtree):
(WebCore::TextAutosizer::processBlock):
(WebCore::TextAutosizer::processText):
(WebCore):
* rendering/TextAutosizer.h:
(TextAutosizer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] Add C API for Battery Status API
commit-queue@webkit.org [Thu, 5 Jul 2012 19:49:56 +0000 (19:49 +0000)]
[WK2] Add C API for Battery Status API
https://bugs.webkit.org/show_bug.cgi?id=90545

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-05
Reviewed by Anders Carlsson.

Add C API for WKBatteryManager and WKBatteryStatus
so that clients can support the Battery Status API
in WebKit2.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* UIProcess/API/C/WKBatteryManager.cpp:
(WKBatteryManagerProviderDidChangeBatteryStatus):
(WKBatteryManagerProviderUpdateBatteryStatus):
* UIProcess/API/C/WKBatteryStatus.cpp: Copied from Source/WebKit2/UIProcess/API/C/WKBatteryManager.cpp.
(WKBatteryStatusGetTypeID):
(WKBatteryStatusCreate):
* UIProcess/API/C/WKBatteryStatus.h: Copied from Source/WebKit2/UIProcess/API/C/WKBatteryManager.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: move cursor to the current search match.
pfeldman@chromium.org [Thu, 5 Jul 2012 19:44:04 +0000 (19:44 +0000)]
Web Inspector: move cursor to the current search match.
https://bugs.webkit.org/show_bug.cgi?id=90621

Reviewed by Vsevolod Vlasov.

After closing the search dialog, the cursor should be at the latest search match location.

* inspector/front-end/TextEditor.js:
(WebInspector.TextEditor.prototype.markAndRevealRange):
(WebInspector.TextEditor.prototype._handleFocused):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSubpixel layout broken with spans with CSS position other than static
commit-queue@webkit.org [Thu, 5 Jul 2012 18:20:42 +0000 (18:20 +0000)]
Subpixel layout broken with spans with CSS position other than static
https://bugs.webkit.org/show_bug.cgi?id=90097

Patch by Behdad Esfahbod <behdad@behdad.org> on 2012-07-05
Reviewed by Eric Seidel.

In InlineBox, don't truncate size to integers when returning.

In RenderBlock, don't round-up width to next integer.  Round-up to
next LayoutUnit instead.

Test: Added fast/sub-pixel/size-of-span-with-different-positions.html
Adjust expected outputs affected by the rounding changes.

* platform/FractionalLayoutUnit.h:
(WebCore::FractionalLayoutUnit::fromFloatCeil):
(FractionalLayoutUnit):
* rendering/InlineBox.h:
(WebCore::InlineBox::size):
* rendering/RenderBlock.cpp:
(WebCore::updatePreferredWidth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r121899.
commit-queue@webkit.org [Thu, 5 Jul 2012 18:01:10 +0000 (18:01 +0000)]
Unreviewed, rolling out r121899.
http://trac.webkit.org/changeset/121899
https://bugs.webkit.org/show_bug.cgi?id=90623

Unauthorized WK2 API breakage (Requested by andersca on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-05

* Shared/API/c/WKSharedAPICast.h:
(WebKit::toCopiedURLAPI):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdding myself as committer to committers.py
dtharp@codeaurora.org [Thu, 5 Jul 2012 17:54:46 +0000 (17:54 +0000)]
Adding myself as committer to committers.py

Unreviewed.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CMake] Fix some CMake warnings
rwlbuis@webkit.org [Thu, 5 Jul 2012 17:46:09 +0000 (17:46 +0000)]
[CMake] Fix some CMake warnings
https://bugs.webkit.org/show_bug.cgi?id=90558

Fix WebKit options so they match with FeatureList.pm.

Reviewed by Dan Bates.

* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Mac][WK2] Enable HTTPS tests
ap@apple.com [Thu, 5 Jul 2012 17:37:35 +0000 (17:37 +0000)]
[Mac][WK2] Enable HTTPS tests
https://bugs.webkit.org/show_bug.cgi?id=90600

Reviewed by Brady Eidson.

Tools:

* DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Removed a misleading comment.
It explained why we were doing this here instead of a frame load delegate, but that's
just history, not an explanation of why we need this code.

* WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize):
Ignore certificate errors for localhost and 127.0.0.1. Since this is only needed
for tests, it seems appropriate to have platform specific solutions in every WTR,
and not add a WebKit2 API.

LayoutTests:

Unskip in common wk2 skipped file, re-skip everywhere besides Mac.

* platform/gtk-wk2/Skipped:
* platform/qt-5.0-wk2/Skipped:
* platform/win-wk2/Skipped:
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: REGRESSION (r115654): Sometimes does not replace content for multipar...
japhet@chromium.org [Thu, 5 Jul 2012 17:19:13 +0000 (17:19 +0000)]
Source/WebCore: REGRESSION (r115654): Sometimes does not replace content for multipart/x-mixed-replace
https://bugs.webkit.org/show_bug.cgi?id=88436

Reviewed by Brady Eidson.

Test: http/tests/multipart/multipart-replace-non-html-content.php

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::commitData): We should only send receivedFirstData() once per main resource load,
    rather than multiple times in a multipart load.
(WebCore::DocumentLoader::setupForReplaceByMIMEType): m_gotFirstByte isn't set to true until data is
    actually committed, and multipart data is often not committed until the part is finished. Check
    whether the SharedBuffer is non-null instead.
* testing/js/WebCoreTestSupport.cpp:
(WebCoreTestSupport::resetInternalsObject): The JSInternals object my have already been cleared if the window shell
    was cleared as part of creation of a new Document. Check it before using it.

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=88436.

Reviewed by Brady Eidson.

* http/tests/multipart/multipart-replace-non-html-content-expected.txt: Added.
* http/tests/multipart/multipart-replace-non-html-content.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: move search field to the bottom of the page.
pfeldman@chromium.org [Thu, 5 Jul 2012 16:44:46 +0000 (16:44 +0000)]
Web Inspector: move search field to the bottom of the page.
https://bugs.webkit.org/show_bug.cgi?id=90610

Reviewed by Vsevolod Vlasov.

This is the first step in the Search/replace implementation. This change moves search
field from the inspector toolbar to the inspector view footer that is visible upon Cmd/Ctrl+F.

* English.lproj/localizedStrings.js:
* inspector/front-end/InspectorView.js:
(WebInspector.InspectorView):
(WebInspector.InspectorView.prototype._pushToHistory):
(WebInspector.InspectorView.prototype.panelsElement):
(WebInspector.InspectorView.prototype.setFooterElement):
* inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.show):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype._reset):
* inspector/front-end/SearchController.js:
(WebInspector.SearchController):
(WebInspector.SearchController.prototype.updateSearchLabel):
(WebInspector.SearchController.prototype.cancelSearch):
(WebInspector.SearchController.prototype._updateSearchNavigationButtonState):
(WebInspector.SearchController.prototype.focusSearchField):
(WebInspector.SearchController.prototype._onKeyDown):
(WebInspector.SearchController.prototype._onNextButtonSearch):
(WebInspector.SearchController.prototype._onPrevButtonSearch):
(WebInspector.SearchController.prototype._performSearch):
* inspector/front-end/inspector.css:
(#search):
(.toolbar-search-container):
(.toolbar-search-navigation):
(.toolbar-search-navigation:hover):
(.toolbar-search-navigation.toolbar-search-navigation-prev):
(.toolbar-search-navigation.toolbar-search-navigation-next):
(.toolbar-search-navigation-hidden):
(.status-bar):
(.search-drawer-header input[type="search"].search-config-search):
(.inspector-footer):
(.inspector-footer > div):
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
(WebInspector.get _setCompactMode):
(WebInspector.postDocumentKeyDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Move Webkit1 before WebKit2 in the build order
vestbo@webkit.org [Thu, 5 Jul 2012 16:39:54 +0000 (16:39 +0000)]
[Qt] Move Webkit1 before WebKit2 in the build order

Reviewed by Csaba Osztrogonác.

* WebKit.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Clear m_currentInputEvent after handled by pointerLockMouseEvent().
scheib@chromium.org [Thu, 5 Jul 2012 16:21:43 +0000 (16:21 +0000)]
[Chromium] Clear m_currentInputEvent after handled by pointerLockMouseEvent().
https://bugs.webkit.org/show_bug.cgi?id=90391

Source/WebKit/chromium:

WebViewImpl::handleInputEvent was keeping a pointer to an input event that would
later be accessed. When in pointer lock, that pointer was not being cleared.
Code modified to use TemporaryChange to automatically clear the pointer at all
method exit points.

Reviewed by Abhishek Arya.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleInputEvent):

LayoutTests:

Test that reproduces bug 90391:
Enable pointer lock, receive mouse move, call window.open, don't crash.

Reviewed by Abhishek Arya.

* pointer-lock/bug90391-move-then-window-open-crash-expected.txt: Added.
* pointer-lock/bug90391-move-then-window-open-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: added low-level instrumentation support for TimelineAgent
caseq@chromium.org [Thu, 5 Jul 2012 16:13:48 +0000 (16:13 +0000)]
Web Inspector: added low-level instrumentation support for TimelineAgent
https://bugs.webkit.org/show_bug.cgi?id=90264

Patch by Sergey Rogulenko <rogulenko@google.com> on 2012-07-05
Reviewed by Pavel Feldman.

* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::timelineAgentForOrphanEvents):
(WebCore::InspectorInstrumentation::setTimelineAgentForOrphanEvents):
(WebCore::InspectorInstrumentation::threadSpecificTimelineAgentForOrphanEvents):
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::pushCurrentRecord):
* inspector/InspectorTimelineAgent.h:
(InspectorTimelineAgent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoText Autosizing: Add test framework and simple test.
commit-queue@webkit.org [Thu, 5 Jul 2012 15:38:10 +0000 (15:38 +0000)]
Text Autosizing: Add test framework and simple test.
https://bugs.webkit.org/show_bug.cgi?id=90561

Source/WebCore:

Exposes methods allowing Layout Tests to enable Text Autosizing and
get the same results as if they were running on a mobile device.

Patch by John Mellor <johnme@chromium.org> on 2012-07-05
Reviewed by Adam Barth.

Test: fast/text-autosizing/simple-paragraph.html

* page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore):
(WebCore::Settings::setTextAutosizingWindowSizeOverride):
* page/Settings.h:
(Settings):
(WebCore::Settings::textAutosizingWindowSizeOverride):
* rendering/TextAutosizer.cpp:
(WebCore::TextAutosizer::boostSubtree):
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::InternalSettings):
(WebCore::InternalSettings::restoreTo):
(WebCore::InternalSettings::setTextAutosizingEnabled):
(WebCore):
(WebCore::InternalSettings::setTextAutosizingWindowSizeOverride):
* testing/InternalSettings.h:
(InternalSettings):
* testing/InternalSettings.idl:

Source/WebKit/chromium:

ENABLE(TEXT_AUTOSIZING) is now on in Chromium (but disabled at runtime).
This allows it to be used in Layout Tests (and in future by Web
Inspector's mobile device emulation).

Patch by John Mellor <johnme@chromium.org> on 2012-07-05
Reviewed by Adam Barth.

* features.gypi:

LayoutTests:

Added a RefTest checking that Text Autosizing is active.
Skipped the text-autosizing test directory on platforms that
currently disable ENABLE(TEXT_AUTOSIZING).

Patch by John Mellor <johnme@chromium.org> on 2012-07-05
Reviewed by Adam Barth.

* fast/text-autosizing/simple-paragraph-expected.html: Added.
* fast/text-autosizing/simple-paragraph.html: Added.
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:
* platform/win/Skipped:
* platform/wincairo/Skipped:
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: timeline events in the vicinity of event dividers some times are trick...
caseq@chromium.org [Thu, 5 Jul 2012 15:27:26 +0000 (15:27 +0000)]
Web Inspector: timeline events in the vicinity of event dividers some times are tricky to expand
https://bugs.webkit.org/show_bug.cgi?id=90572

Reviewed by Pavel Feldman.

- do not use resources-event-divider-padding;
- make dividers larger and use border-color to visualize them;
- move resources-<color>-divider to timelinePanel.css, as they're not used outside of timeline;

* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.createEventDivider):
* inspector/front-end/inspectorCommon.css:
* inspector/front-end/timelinePanel.css:
(.timeline .resources-event-divider):
(.resources-red-divider):
(.resources-blue-divider):
(.resources-orange-divider):
(.resources-divider.last):
(.timeline .resources-event-divider.timeline-frame-divider):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: incorrect height of main timeline pane after switching to memory mode
caseq@chromium.org [Thu, 5 Jul 2012 15:17:43 +0000 (15:17 +0000)]
Web Inspector: incorrect height of main timeline pane after switching to memory mode
https://bugs.webkit.org/show_bug.cgi?id=90387

Reviewed by Pavel Feldman.

* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._splitterDragging):
(WebInspector.TimelinePanel.prototype.set _setSplitterPosition):
(WebInspector.TimelinePanel.prototype._overviewModeChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Add a method didChangeFormState to WebViewClient.
commit-queue@webkit.org [Thu, 5 Jul 2012 14:23:45 +0000 (14:23 +0000)]
[chromium] Add a method didChangeFormState to WebViewClient.
https://bugs.webkit.org/show_bug.cgi?id=90563

Patch by Oli Lan <olilan@chromium.org> on 2012-07-05
Reviewed by Adam Barth.

This patch adds a new method didChangeFormState to WebViewClient,
and calls it from ChromeClientImpl::formStateDidChange with the changed node.

This new method can be used for example by the Android port to update the browser's
IME when the state of the currently focused text node has changed. To facilitate this
usage, a focused() method has been added to WebNode.

A new test has been added to WebViewTest. This test checks that didChangeFormState
is called when an input's value is changed, and also checks that WebNode::focused() returns
the correct value for the provided node, in both the focused and non-focused cases.

* public/WebNode.h:
* public/WebViewClient.h:
(WebKit::WebViewClient::didChangeFormState):
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::formStateDidChange):
* src/WebNode.cpp:
(WebKit::WebNode::focused):
(WebKit):
* tests/WebViewTest.cpp:
(FormChangeWebViewClient):
(WebKit::FormChangeWebViewClient::didChangeFormState):
(WebKit::FormChangeWebViewClient::reset):
(WebKit::FormChangeWebViewClient::called):
(WebKit::FormChangeWebViewClient::focused):
(WebKit):
(WebKit::TEST_F):
* tests/data/input_field_set_value_while_focused.html: Added.
* tests/data/input_field_set_value_while_not_focused.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CMAKE] Unreviewd typo fix after r121857
ryuan.choi@samsung.com [Thu, 5 Jul 2012 14:20:53 +0000 (14:20 +0000)]
[CMAKE] Unreviewd typo fix after r121857

* Source/cmake/WebKitMacros.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Add support for keyboard increment / decrement on numbers in attribute...
commit-queue@webkit.org [Thu, 5 Jul 2012 14:19:54 +0000 (14:19 +0000)]
Web Inspector: Add support for keyboard increment / decrement on numbers in attributes in Elements Panel
https://bugs.webkit.org/show_bug.cgi?id=89586

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-07-05
Reviewed by Pavel Feldman

Refactoring the key events while editing style property values. Migrated the code to UIUtils.js and referred
from StylesSidebarPane.js, ElementsTreeOutline.js and MetricsSidebarPane.js.

No new tests as code refactoring and UI feature added to ElementsTreeOutline.js

* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._startEditingAttribute.handleKeyDownEvents):
(WebInspector.ElementsTreeElement.prototype._startEditingAttribute):
* inspector/front-end/MetricsSidebarPane.js:
(WebInspector.MetricsSidebarPane.prototype._handleKeyDown.finishHandler):
(WebInspector.MetricsSidebarPane.prototype._handleKeyDown.customNumberHandler):
(WebInspector.MetricsSidebarPane.prototype._handleKeyDown):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._handleNameOrValueUpDown.finishHandler):
(WebInspector.StylesSidebarPane.prototype._handleNameOrValueUpDown):
* inspector/front-end/UIUtils.js:
(WebInspector._modifiedHexValue):
(WebInspector._modifiedFloatNumber):
(WebInspector.handleElementValueModifications):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Remove rpath-hacks in qt_webkit.pri
vestbo@webkit.org [Thu, 5 Jul 2012 13:10:04 +0000 (13:10 +0000)]
[Qt] Remove rpath-hacks in qt_webkit.pri

Having it in qt_webkit.pri meant that all client apps would inherit the rpath,
even if they were not using QtWebKit.

This is a regression for people who build client apps against a non-installed
QtWebKit, as the client app will be missing a rpath to the standalone WebKit
build dir. This can be solved by LD_LIBRARY_PATH or custom QMAKE_RPATHDIR
logic, until the real issue is fixed in Qt.

Reviewed by Csaba Osztrogonác.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNEON intrinsics should be used with gaussian blur filter
rgabor@webkit.org [Thu, 5 Jul 2012 12:31:56 +0000 (12:31 +0000)]
NEON intrinsics should be used with gaussian blur filter
https://bugs.webkit.org/show_bug.cgi?id=90166

Reviewed by Zoltan Herczeg.

Rewrite inline assembly to NEON intrinsics for better portabilty
and readibility. Remove unnecessary FEGaussianBlurNEON.cpp and add
NEONHelpers.h to the project which will contains the shared
NEON code of the filters.

Existing tests cover this issue.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::platformApplyGeneric):
(WebCore::FEGaussianBlur::platformApplyWorker):
* platform/graphics/filters/FEGaussianBlur.h:
(FEGaussianBlur):
* platform/graphics/filters/arm/FEGaussianBlurNEON.cpp: Removed.
* platform/graphics/filters/arm/FEGaussianBlurNEON.h:
(WebCore::boxBlurNEON):
* platform/graphics/filters/arm/NEONHelpers.h: Added.
(WebCore):
(WebCore::loadRGBA8AsFloat):
(WebCore::storeFloatAsRGBA8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] WTR crashes if a URL is passed as a parameter
kbalazs@webkit.org [Thu, 5 Jul 2012 11:21:47 +0000 (11:21 +0000)]
[Qt] WTR crashes if a URL is passed as a parameter
https://bugs.webkit.org/show_bug.cgi?id=88093

Reviewed by Zoltan Herczeg.

* Shared/API/c/WKSharedAPICast.h:
(WebKit::toCopiedURLAPI):
Don't special case null string. It's handled
fine by WebURL and passing 0 is not suitable
to the API.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Change class name from NotificationClientEfl to NotificationPresenterClientEfl.
commit-queue@webkit.org [Thu, 5 Jul 2012 10:54:01 +0000 (10:54 +0000)]
[EFL] Change class name from NotificationClientEfl to NotificationPresenterClientEfl.
https://bugs.webkit.org/show_bug.cgi?id=90542

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-07-05
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit:

NotificationClientEfl.cpp is changed to NotificationPresenterClientEfl.cpp
to be in line with other ports(qt, chromium, gtk).

* PlatformEfl.cmake:

Source/WebKit/efl:

Change class name from NotificationClientEfl to NotificationPresenterClientEfl
to be in line with other ports.(qt, chromium, blackberry)

* WebCoreSupport/ChromeClientEfl.cpp:
* WebCoreSupport/NotificationPresenterClientEfl.cpp: Renamed from Source/WebKit/efl/WebCoreSupport/NotificationClientEfl.cpp.
(WebCore):
(WebCore::NotificationPresenterClientEfl::NotificationPresenterClientEfl):
(WebCore::NotificationPresenterClientEfl::~NotificationPresenterClientEfl):
(WebCore::NotificationPresenterClientEfl::show):
(WebCore::NotificationPresenterClientEfl::cancel):
(WebCore::NotificationPresenterClientEfl::notificationObjectDestroyed):
(WebCore::NotificationPresenterClientEfl::notificationControllerDestroyed):
(WebCore::NotificationPresenterClientEfl::requestPermission):
(WebCore::NotificationPresenterClientEfl::checkPermission):
(WebCore::NotificationPresenterClientEfl::cancelRequestsForPermission):
* WebCoreSupport/NotificationPresenterClientEfl.h: Renamed from Source/WebKit/efl/WebCoreSupport/NotificationClientEfl.h.
(WebCore):
(NotificationPresenterClientEfl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Enable the CUSTOM_SCHEME_HANDLER feature as default.
commit-queue@webkit.org [Thu, 5 Jul 2012 10:52:48 +0000 (10:52 +0000)]
[EFL] Enable the CUSTOM_SCHEME_HANDLER feature as default.
https://bugs.webkit.org/show_bug.cgi?id=88608

Patch by Dongwoo Im <dw.im@samsung.com> on 2012-07-05
Reviewed by Hajime Morita.

.:

* Source/cmake/OptionsEfl.cmake: Enable the CUSTOM_SCHEME_HANDLER feature as default.

Source/WebKit2:

* WebProcess/WebCoreSupport/WebChromeClient.h:
(WebKit::WebChromeClient::isProtocolHandlerRegistered): Add a stub function.
(WebKit::WebChromeClient::unregisterProtocolHandler): Add a stub function.
(WebChromeClient):

Tools:

* Scripts/webkitperl/FeatureList.pm: Enable the CUSTOM_SCHEME_HANDLER feature as default.

LayoutTests:

* platform/efl/fast/dom/unregister-protocol-handler-expected.txt: Expected result of the EFL port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Having a "Scroll into view" for nodes through web inspector.
commit-queue@webkit.org [Thu, 5 Jul 2012 10:33:54 +0000 (10:33 +0000)]
Web Inspector: Having a "Scroll into view" for nodes through web inspector.
https://bugs.webkit.org/show_bug.cgi?id=89554

Added options for scrolling-into-view the  element node through web
inspector.

Patch by Sam D <dsam2912@gmail.com> on 2012-07-05
Reviewed by Pavel Feldman.

No new tests. UI change.

* English.lproj/localizedStrings.js:
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
(.):
* inspector/front-end/RemoteObject.js:
(WebInspector.RemoteObject.prototype.callFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd Gamepad logging channel
zandobersek@gmail.com [Thu, 5 Jul 2012 09:34:46 +0000 (09:34 +0000)]
Add Gamepad logging channel
https://bugs.webkit.org/show_bug.cgi?id=90570

Reviewed by Carlos Garcia Campos.

Add a new logging channel for logging significant
events that are related to Gamepad API implementation.

No new tests - no new testable functionality.

* platform/Logging.cpp:
(WebCore):
(WebCore::getChannelFromName):
* platform/Logging.h:
(WebCore):
* platform/gtk/GamepadsGtk.cpp: Log when a device is
registered or unregistered.
(WebCore::GamepadsGtk::registerDevice):
(WebCore::GamepadsGtk::unregisterDevice):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening after r121891.
kkristof@inf.u-szeged.hu [Thu, 5 Jul 2012 09:22:58 +0000 (09:22 +0000)]
[Qt] Unreviewed gardening after r121891.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Wk2][EFL] EFL needs a WebKitTestRunner
ryuan.choi@samsung.com [Thu, 5 Jul 2012 08:47:49 +0000 (08:47 +0000)]
[Wk2][EFL] EFL needs a WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=87659

Reviewed by Kenneth Rohde Christiansen.

.:

* Source/CMakeLists.txt:
Set compiler flags for WebCoreTestSupport to be linked into TestRunnerInjectedBundle
shared library.
* Source/cmake/WebKitMacros.cmake: Remove unnecessary dependency.

Source/WebKit2:

* PlatformEfl.cmake: Added WKImageCairo.cpp in source list.

Tools:

Add an implementation of WebKitTestRunner for Efl port.

* CMakeLists.txt: Includes WebKitTestRunner build script.
* Scripts/build-webkittestrunner: Added knowledge of WebKitTestRunner/Efl.
* Scripts/webkitpy/layout_tests/port/efl.py: Ditto.
(EflPort.setup_environ_for_server):
* WebKitTestRunner/CMakeLists.txt: Added.
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
* WebKitTestRunner/InjectedBundle/efl/ActivateFontsEfl.cpp: Added.
* WebKitTestRunner/InjectedBundle/efl/InjectedBundleEfl.cpp: Added.
* WebKitTestRunner/InjectedBundle/efl/LayoutTestControllerEfl.cpp: Added.
* WebKitTestRunner/PlatformEfl.cmake: Added.
* WebKitTestRunner/PlatformWebView.h:
* WebKitTestRunner/TestController.cpp:
* WebKitTestRunner/config.h: Added knowledge of WebKitTestRunner/Efl.
* WebKitTestRunner/efl/PlatformWebViewEfl.cpp: Added.
* WebKitTestRunner/efl/TestControllerEfl.cpp: Added.
* WebKitTestRunner/efl/main.cpp: Added.
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Add ewk_view_reload_bypass_cache API.
commit-queue@webkit.org [Thu, 5 Jul 2012 08:36:39 +0000 (08:36 +0000)]
[EFL][WK2] Add ewk_view_reload_bypass_cache API.
https://bugs.webkit.org/show_bug.cgi?id=89413

Patch by Hyerim Bae <hyerim.bae@samsung.com> on 2012-07-05
Reviewed by Kenneth Rohde Christiansen.

Add API, which is for reloading documents without cache.

* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_reload_bypass_cache):
* UIProcess/API/efl/ewk_view.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [JSC] support JS execution in the context of an isolated world
commit-queue@webkit.org [Thu, 5 Jul 2012 08:19:51 +0000 (08:19 +0000)]
Web Inspector: [JSC] support JS execution in the context of an isolated world
https://bugs.webkit.org/show_bug.cgi?id=85709

Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-07-05
Reviewed by Gavin Barraclough.

No new test case for this bug.

* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::collectIsolatedContexts):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121891 268f45cc-cd09-0410-ab3c-d52691b4dbfc