WebKit-https.git
10 years agoWebCore: For continuous scrolling devices on the Mac (trackpads and Mighty/Magic
enrica@apple.com [Mon, 15 Mar 2010 20:31:04 +0000 (20:31 +0000)]
WebCore: For continuous scrolling devices on the Mac (trackpads and Mighty/Magic
Mice), set the number of wheel ticks equal to the atomic increment of
the device: a pixel.  This ensures that any scrolling action will
generate at least one wheel tick, regardless of the speed/length of
the gesture.

Reviewed by John Sullivan.

https://bugs.webkit.org/show_bug.cgi?id=29601
<rdar://problem/7453254>

Tests: fast/events/continuous-platform-wheelevent-in-scrolling-div.html
       fast/events/platform-wheelevent-in-scrolling-div.html

* platform/mac/WebCoreSystemInterface.h: Modify method signature.
* platform/mac/WebCoreSystemInterface.mm: Ditto.
* platform/mac/WheelEventMac.mm:
(WebCore::PlatformWheelEvent::PlatformWheelEvent): Call into
WebKitSystemInterface to determine both wheelTicksX/Y and deltaX/Y.
WKSI will query the event system for number of wheel ticks and
pixels/lines scrolled based on the device type.

WebKit/mac: Updated call to WKGetWheelEventDeltas() to match new method signature.

Reviewed by John Sullivan.

https://bugs.webkit.org/show_bug.cgi?id=29601
<rdar://problem/7453254>

* WebView/WebDynamicScrollBarsView.mm:
(-[WebDynamicScrollBarsView scrollWheel:]):

WebKitLibraries: Added two new output arguments to WKGetWheelEventDeltas() to return
the number of scroll wheel ticks in the x and y directions.

Reviewed by John Sullivan.

https://bugs.webkit.org/show_bug.cgi?id=29601.
<rdar://problem/7453254>

* WebKitSystemInterface.h:
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceSnowLeopard.a:
* libWebKitSystemInterfaceTiger.a:

LayoutTests: These tests verify that scrollwheel events (both continuous and
non-continuous) generate the expected pixel deltas in scrollable
regions, and also generate DOM mousewheel events with expected
wheelDelta values.

Reviewed by John Sullivan.

https://bugs.webkit.org/show_bug.cgi?id=29601
<rdar://problem/7453254>

* fast/events/continuous-platform-wheelevent-in-scrolling-div-expected.txt: Added.
* fast/events/continuous-platform-wheelevent-in-scrolling-div.html: Added.
* fast/events/platform-wheelevent-in-scrolling-div-expected.txt: Added.
* fast/events/platform-wheelevent-in-scrolling-div.html: Added.
* fast/events/wheelevent-in-scrolling-div-expected.txt: Rebased
expected results due to change in test output formatting.
* fast/events/wheelevent-in-scrolling-div.html: Modified to use common
js logging and assertion functions.
* platform/gtk/Skipped: DRT support needed by tests not yet implemented
in GTK port.  See https://bugs.webkit.org/show_bug.cgi?id=36003.
* platform/mac-tiger/Skipped: DRT support needed by tests not possible
to implement in Tiger.
* platform/qt/Skipped: DRT support for tests not yet implemented in Qt
port.  See https://bugs.webkit.org/show_bug.cgi?id=36004.
* platform/win/Skipped: DRT support for tests not yet implemented in
Windows port.  See https://bugs.webkit.org/show_bug.cgi?id=36002.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-15 Marcus Bulach <bulach@chromium.org>
eric@webkit.org [Mon, 15 Mar 2010 20:30:17 +0000 (20:30 +0000)]
2010-03-15  Marcus Bulach  <bulach@chromium.org>

        Reviewed by Jeremy Orlow.

        Send the frame URL on GeolocationServiceBridgeImpl::startUpdating.
        https://bugs.webkit.org/show_bug.cgi?id=36012

        * public/GeolocationServiceBridgeChromium.h:
        * src/GeolocationServiceBridgeChromium.cpp:
        (WebKit::GeolocationServiceBridgeImpl::startUpdating):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-15 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Mon, 15 Mar 2010 20:18:47 +0000 (20:18 +0000)]
2010-03-15  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GStreamer] duration query optimizations
        https://bugs.webkit.org/show_bug.cgi?id=36116

        Don't reattempt duration queries that previously failed and cache
        media duration only if it's known.

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
        (WebCore::MediaPlayerPrivate::duration):
        (WebCore::MediaPlayerPrivate::updateStates):
        (WebCore::MediaPlayerPrivate::durationChanged):
        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-15 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Mon, 15 Mar 2010 20:11:55 +0000 (20:11 +0000)]
2010-03-15  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GStreamer] updateStates called for all elements posting a state-change
        https://bugs.webkit.org/show_bug.cgi?id=36115

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::mediaPlayerPrivateMessageCallback): Update player state
        only for state-change messages coming from playbin2 directly.
        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
        (WebCore::MediaPlayerPrivate::pipeline): public accessor for the
        playbin element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago-[WebFrame setAlwaysHideHorizontal/VerticalScroller:] prevents keyboard scrolling
sullivan@apple.com [Mon, 15 Mar 2010 20:10:22 +0000 (20:10 +0000)]
-[WebFrame setAlwaysHideHorizontal/VerticalScroller:] prevents keyboard scrolling
<https://bugs.webkit.org/show_bug.cgi?id=36125>

Reviewed by Adam Roben.

* WebView/WebDynamicScrollBarsView.h:
Added instance variables horizontalScrollingAllowedButScrollerHidden and
verticalScrollingAllowedButScrollerHidden. Renamed instance variables
hideHorizontal/VerticalScroller to alwaysHideHorizontal/VerticalScroller for clarity.
Declared methods -horizontalScrollingAllowed and -verticalScrollingAllowed.
Added comments.

* WebView/WebDynamicScrollBarsView.mm:
(-[WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]):
Updated for instance variable renaming.
(-[WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]):
Ditto.
(-[WebDynamicScrollBarsView horizontalScrollingAllowed]):
New method, returns YES if the scroller is showing or the only reason that the scroller
is not showing is that setAlwaysHideHorizontalScrolling has been called.
(-[WebDynamicScrollBarsView verticalScrollingAllowed]):
New method, returns YES if the scroller is showing or the only reason that the scroller
is not showing is that setAlwaysHideVerticalScrolling has been called.
(-[WebDynamicScrollBarsView updateScrollers]):
Updated for instance variable renamings. Now updates horizontalScrollingAllowedButScrollerHidden
and verticalScrollingAllowedButScrollerHidden. Now takes the always-hidden state into account
in the early-return code path, to avoid taking it into account twice in the regular code path.

* WebView/WebFrameView.mm:
(-[WebFrameView _scrollToBeginningOfDocument]):
Use _isScrollable instead of _hasScrollBars.
(-[WebFrameView _scrollToEndOfDocument]):
Ditto.
(-[WebFrameView scrollToBeginningOfDocument:]):
Use _largestScrollableChild instead of _largestChildWithScrollBars.
(-[WebFrameView scrollToEndOfDocument:]):
Ditto.
(-[WebFrameView _pageVertically:]):
Use _isScrollable and _largestScrollableChild instead of _hasScrollBars
and _largestChildWithScrollBars.
(-[WebFrameView _pageHorizontally:]):
Ditto.
(-[WebFrameView _scrollLineVertically:]):
Ditto.
(-[WebFrameView _scrollLineHorizontally:]):
Ditto.
(-[WebFrameView keyDown:]):
Use _largestScrollableChild instead of _largestChildWithScrollBars.
(-[WebFrameView _isScrollable]):
New method, calls -[WebDynamicScrollBarsView horizontalScrollingAllowed] and
-[WebDynamicScrollBarsView verticalScrollingAllowed]
(-[WebFrameView _largestScrollableChild]):
New method, like _largestChildWithScrollBars but uses _isScrollable.
(-[WebFrameView _hasScrollBars]):
Added a comment that this is no longer used by Safari, and can thus probably be
deleted once we no longer want to support it for nightly build compatibility with
old versions of Safari.
(-[WebFrameView _largestChildWithScrollBars]):
Ditto.

* WebView/WebFrameViewPrivate.h:
Declared -_isScrollable and -_largestScrollableChild. Added comments to
_hasScrollBars and _largestChildWithScrollBars saying that they are no longer
used by Safari, and can thus probably be deleted once we no longer want to
support them for nightly build compatibility with old versions of Safari.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoClean up more bits of the open-source image decoders. In addition to
pkasting@chromium.org [Mon, 15 Mar 2010 20:08:33 +0000 (20:08 +0000)]
Clean up more bits of the open-source image decoders.  In addition to
simplifying things somewhat, this makes all the decoders the same in
terms of how they construct "image reader" subclasses and init scale
data.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=36040

No functional change, so no tests.

* platform/image-decoders/ImageDecoder.h: Reorder a few declarations to try and group/order members slightly better.
(WebCore::ImageDecoder::ImageDecoder):
* platform/image-decoders/gif/GIFImageDecoder.cpp: Move reader construction into decode().  Prep scale data in setSize().  Remove useless comment.
(WebCore::GIFImageDecoder::setData):
(WebCore::GIFImageDecoder::setSize):
(WebCore::GIFImageDecoder::frameBufferAtIndex):
(WebCore::GIFImageDecoder::decode):
* platform/image-decoders/gif/GIFImageDecoder.h: Prep scale data in setSize().
* platform/image-decoders/gif/GIFImageReader.cpp: Prep scale data in setSize().
(GIFImageReader::read):
* platform/image-decoders/ico/ICOImageDecoder.cpp: Shorten code.
(WebCore::ICOImageDecoder::setSize):
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp: Fix style.  Move reader construction into decode().
(WebCore::JPEGImageReader::close):
(WebCore::JPEGImageReader::skipBytes):
(WebCore::JPEGImageDecoder::decode):
* platform/image-decoders/jpeg/JPEGImageDecoder.h: Move reader construction into decode().
(WebCore::JPEGImageDecoder::filenameExtension):
* platform/image-decoders/png/PNGImageDecoder.cpp: Move reader construction into decode().  Track completion on decoder, not reader.  Prep scale data in setSize().  Remove useless comment.
(WebCore::PNGImageReader::PNGImageReader):
(WebCore::PNGImageReader::close):
(WebCore::PNGImageReader::decode):
(WebCore::PNGImageDecoder::setSize):
(WebCore::PNGImageDecoder::frameBufferAtIndex):
(WebCore::PNGImageDecoder::headerAvailable):
(WebCore::PNGImageDecoder::pngComplete):
(WebCore::PNGImageDecoder::decode):
* platform/image-decoders/png/PNGImageDecoder.h: Move reader construction into decode().  Track completion on decoder, not reader.  Prep scale data in setSize().
(WebCore::PNGImageDecoder::filenameExtension):
(WebCore::PNGImageDecoder::isComplete):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-15 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Mon, 15 Mar 2010 20:00:53 +0000 (20:00 +0000)]
2010-03-15  Philippe Normand  <pnormand@igalia.com>

        Reviewed by  Gustavo Noronha Silva.

        [GTK] video playback position query flood when mouse over the video element
        https://bugs.webkit.org/show_bug.cgi?id=35333

        Don't trigger a position query only to know which play/pause
        button to display.

        * platform/gtk/RenderThemeGtk.cpp:
        (WebCore::RenderThemeGtk::paintMediaPlayButton):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-15 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Mon, 15 Mar 2010 19:57:11 +0000 (19:57 +0000)]
2010-03-15  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Fix a minor case where we'd deference a null pointer if we tried
        to run new-run-webkit-tests on an unsupported platform (e.g.
        Cygwin's python version).

        https://bugs.webkit.org/show_bug.cgi?id=36076

        * Scripts/webkitpy/layout_tests/port/factory.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[v8] Add V8 bindings for DOMFormData.
jianli@chromium.org [Mon, 15 Mar 2010 17:27:25 +0000 (17:27 +0000)]
[v8] Add V8 bindings for DOMFormData.
https://bugs.webkit.org/show_bug.cgi?id=36026

Reviewed by Nate Chapin.

Test: http/tests/local/send-form-data.html

* Android.v8bindings.mk:
* WebCore.gypi:
* bindings/v8/V8Index.h:
* bindings/v8/custom/V8DOMFormDataCustom.cpp: Added.
* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::sendCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Add DOMFormData.idl to expose FormData interface.
jianli@chromium.org [Mon, 15 Mar 2010 17:27:16 +0000 (17:27 +0000)]
WebCore: Add DOMFormData.idl to expose FormData interface.
https://bugs.webkit.org/show_bug.cgi?id=36024

Reviewed by Sam Weinig.

The implementation is based on XMLHttpRequest 2 spec:
http://dev.w3.org/2006/webapi/XMLHttpRequest-2/#formdata

Test: http/tests/local/send-form-data.html

* Android.derived.jscbindings.mk:
* Android.derived.v8bindings.mk:
* Android.jscbindings.mk:
* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.pri:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMFormDataCustom.cpp: Added.
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::send):
* bindings/scripts/CodeGeneratorJS.pm:
* html/DOMFormData.idl: Added.
* page/DOMWindow.idl:

LayoutTests: Add DOMFormData.idl to expose FormData interface
https://bugs.webkit.org/show_bug.cgi?id=36024

Reviewed by Sam Weinig.

Add a layout test to test sending FormData via XMLHttpRequest. Also
changed all test results that are affected by exposing FormData.

* fast/dom/Window/window-properties-expected.txt:
* fast/dom/Window/window-property-descriptors-expected.txt:
* fast/dom/constructed-objects-prototypes-expected.txt:
* fast/dom/prototype-inheritance-2-expected.txt:
* fast/dom/prototype-inheritance-expected.txt:
* fast/js/global-constructors-expected.txt:
* http/tests/local/resources/send-form-data.js: Added.
* http/tests/local/send-form-data-expected.txt: Added.
* http/tests/local/send-form-data.html: Added.
* http/tests/xmlhttprequest/resources/multipart-post-echo.php: Added.
* platform/gtk/Skipped:
* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/qt/Skipped:
* platform/qt/fast/dom/Window/window-properties-expected.txt:
* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/qt/fast/dom/prototype-inheritance-expected.txt:
* platform/qt/fast/js/global-constructors-expected.txt:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-15 Patrik Persson <patrik.j.persson@ericsson.com>
eric@webkit.org [Mon, 15 Mar 2010 17:14:10 +0000 (17:14 +0000)]
2010-03-15  Patrik Persson  <patrik.j.persson@ericsson.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=32369

        Revised test of storage/databases in sandboxed iframes.

        Verify that SECURITY_ERR is raised on access to
        window.localStorage or window.openDatabase(). Also verify that
        window.sessionStorage is now allowed in sandboxed iframes.

        WebKit would previously return null references in these cases.  The
        new behavior is in accordance with HTML5:

        - http://dev.w3.org/html5/webstorage/   (sections 4.2 and 4.3)
        - http://dev.w3.org/html5/webdatabase/  (section 4.1)
        - http://www.mail-archive.com/whatwg@lists.whatwg.org/msg19786.html

        * fast/frames/resources/sandboxed-iframe-storage-disallowed.html: expect exceptions, not null
        * fast/frames/sandboxed-iframe-storage-expected.txt: expect exceptions, not null
2010-03-15  Patrik Persson  <patrik.j.persson@ericsson.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=32369

        Revise iframe sandbox behavior to match the updated HTML5 spec.

        - Enables window.sessionStorage in sandboxed iframes.

        - Raises SECURITY_ERR exceptions when window.localStorage or
          window.openDatabase() is blocked by iframe sandboxing.

          Note: window.sessionStorage does not raise exceptions.

        WebKit would previously return null references in these cases.  The
        new behavior is in accordance with HTML5:

          http://dev.w3.org/html5/webstorage/   (sections 4.2 and 4.3)
          http://dev.w3.org/html5/webdatabase/  (section 4.1)
          http://www.mail-archive.com/whatwg@lists.whatwg.org/msg19786.html

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::selectDOMStorage): exception handling
        * inspector/InspectorDOMStorageResource.cpp:
        (WebCore::InspectorDOMStorageResource::handleEvent): exception handling
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::sessionStorage): re-enabled in iframe sandbox
        (WebCore::DOMWindow::localStorage): raise exception rather than return null
        (WebCore::DOMWindow::openDatabase): raise exception rather than return null
        * page/DOMWindow.h: added exceptions to interface
        * page/DOMWindow.idl: added exceptions to interface
        * page/SecurityOrigin.h:
        (WebCore::SecurityOrigin::canAccessLocalStorage): renamed function to reflect its purpose
        * storage/StorageEventDispatcher.cpp:
        (WebCore::StorageEventDispatcher::dispatch): exception handling
2010-03-15  Patrik Persson  <patrik.j.persson@ericsson.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=32369

        Revise iframe sandbox behavior to match the updated HTML5 spec.

        - Enables window.sessionStorage in sandboxed iframes.

        - Raises SECURITY_ERR exceptions when window.localStorage or
          window.openDatabase() is blocked by iframe sandboxing.

          Note: window.sessionStorage does not raise exceptions.

        WebKit would previously return null references in these cases.  The
        new behavior is in accordance with HTML5:

          http://dev.w3.org/html5/webstorage/   (sections 4.2 and 4.3)
          http://dev.w3.org/html5/webdatabase/  (section 4.1)
          http://www.mail-archive.com/whatwg@lists.whatwg.org/msg19786.html

        * src/StorageAreaProxy.cpp:
        (WebCore::StorageAreaProxy::storageEvent): exception handling
        * src/StorageEventDispatcherImpl.cpp:
        (WebCore::StorageEventDispatcherImpl::dispatchStorageEvent): exception handling

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTell Subversion about more directories that expect to have .pyc files.
darin@apple.com [Mon, 15 Mar 2010 16:41:41 +0000 (16:41 +0000)]
Tell Subversion about more directories that expect to have .pyc files.

* Scripts/webkitpy/layout_tests: Added property svn:ignore.
* Scripts/webkitpy/layout_tests/port: Added property svn:ignore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-15 Gabor Loki <loki@webkit.org>
eric@webkit.org [Mon, 15 Mar 2010 16:33:24 +0000 (16:33 +0000)]
2010-03-15  Gabor Loki  <loki@webkit.org>

        Reviewed by Gavin Barraclough.

        Combine ctiTrampolines on ARM and Thumb-2
        https://bugs.webkit.org/show_bug.cgi?id=36014

        * jit/JITStubs.cpp:
        (JSC::JITThunks::JITThunks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-15 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Mon, 15 Mar 2010 16:22:24 +0000 (16:22 +0000)]
2010-03-15  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Implement a progress indicator in the Audits panel
        when resources are reloading
        https://bugs.webkit.org/show_bug.cgi?id=35971

        * English.lproj/localizedStrings.js:
        * GNUmakefile.am:
        * WebCore.gypi:
        * inspector/front-end/AuditLauncherView.js:
        (WebInspector.AuditLauncherView.prototype.updateResourceTrackingState):
        (WebInspector.AuditLauncherView.prototype.get totalResources):
        (WebInspector.AuditLauncherView.prototype.set totalResources):
        (WebInspector.AuditLauncherView.prototype.get loadedResources):
        (WebInspector.AuditLauncherView.prototype.set loadedResources):
        (WebInspector.AuditLauncherView.prototype._resetResourceCount):
        (WebInspector.AuditLauncherView.prototype.resourceStarted):
        (WebInspector.AuditLauncherView.prototype.resourceFinished):
        (WebInspector.AuditLauncherView.prototype.reset):
        (WebInspector.AuditLauncherView.prototype._setAuditRunning):
        (WebInspector.AuditLauncherView.prototype._launchButtonClicked):
        (WebInspector.AuditLauncherView.prototype._createCategoryElement):
        (WebInspector.AuditLauncherView.prototype._createLauncherUI):
        (WebInspector.AuditLauncherView.prototype._updateResourceProgress):
        (WebInspector.AuditLauncherView.prototype._updateButton):
        * inspector/front-end/AuditsPanel.js:
        (WebInspector.AuditsPanel.prototype.resourceStarted):
        (WebInspector.AuditsPanel.prototype.resourceFinished):
        (WebInspector.AuditsPanel.prototype.reset):
        * inspector/front-end/Images/spinner.gif: Added.
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/audits.css:
        (.audit-launcher-view .resource-progress > img):
        * inspector/front-end/inspector.js:
        (WebInspector.updateResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-15 Tony Chang <tony@chromium.org>
eric@webkit.org [Mon, 15 Mar 2010 15:54:38 +0000 (15:54 +0000)]
2010-03-15  Tony Chang  <tony@chromium.org>

        Reviewed by Darin Adler.

        option-pageup/down should move cursor on chromium mac
        https://bugs.webkit.org/show_bug.cgi?id=36108

        Remove waitUntilDone/notifyDone from the layout test, it's not needed
        and causes timeouts on failure.

        * editing/input/option-page-up-down.html:
2010-03-15  Tony Chang  <tony@chromium.org>

        Reviewed by Darin Adler.

        option-pageup/down should move cursor on chromium mac
        https://bugs.webkit.org/show_bug.cgi?id=36108

        * src/EditorClientImpl.cpp:
        (WebKit::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMethod name and parameter name mistakes from recent SPI addition
sullivan@apple.com [Mon, 15 Mar 2010 15:40:57 +0000 (15:40 +0000)]
Method name and parameter name mistakes from recent SPI addition
<https://bugs.webkit.org/show_bug.cgi?id=36119>

Reviewed by Dan Bernstein.

* WebView/WebDynamicScrollBarsView.h:
Renamed instance variable and method name from "setAllowXXX" to "setAllowsXXX".

* WebView/WebDynamicScrollBarsView.mm:
(-[WebDynamicScrollBarsView setAllowsScrollersToOverlapContent:]):
Updated for renamed instance variable and method.
(-[WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]):
Changed parameter name from shouldBeVisible to shouldBeHidden.
(-[WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]):
Ditto.
(-[WebDynamicScrollBarsView contentViewFrame]):
Updated for renamed instance variable.
(-[WebDynamicScrollBarsView tile]):
Ditto.
(-[WebDynamicScrollBarsView reflectScrolledClipView:]):
Ditto.

* WebView/WebFrame.mm:
(-[WebFrame setAllowsScrollersToOverlapContent:]):
Renamed method from setAllowXXX, and updated for same change in WebDynamicScrollBarsView.

* WebView/WebFramePrivate.h:
Renamed method name from "setAllowXXX" to "setAllowsXXX".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-15 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Mon, 15 Mar 2010 15:34:47 +0000 (15:34 +0000)]
2010-03-15  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GStreamer] replace g_idle_add / g_timeout_add calls with Timers in the gstreamer player
        https://bugs.webkit.org/show_bug.cgi?id=35735

        Replaced g_idle_add calls with Timers immediately started once
        only. The g_timeout_add was replaced by a periodic Timer.

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
        (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):
        (WebCore::MediaPlayerPrivate::volumeChangedTimerFired):
        (WebCore::MediaPlayerPrivate::volumeChanged):
        (WebCore::MediaPlayerPrivate::processBufferingStats):
        (WebCore::MediaPlayerPrivate::fillTimerFired):
        (WebCore::MediaPlayerPrivate::maxTimeLoaded):
        (WebCore::MediaPlayerPrivate::updateStates):
        (WebCore::MediaPlayerPrivate::muteChangedTimerFired):
        (WebCore::MediaPlayerPrivate::muteChanged):
        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Mon, 15 Mar 2010 15:20:22 +0000 (15:20 +0000)]
2010-03-12  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Eric Carlson.

        media/video-preload.html fails
        https://bugs.webkit.org/show_bug.cgi?id=35793

        Only effectively load, and start buffering when playing, or when
        the preload attribute is set.

        Test: media/video-preload.html

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
        (WebCore::MediaPlayerPrivate::load):
        (WebCore::MediaPlayerPrivate::commitLoad):
        (WebCore::MediaPlayerPrivate::prepareToPlay):
        (WebCore::MediaPlayerPrivate::setPreload):
        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-15 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Mon, 15 Mar 2010 14:46:56 +0000 (14:46 +0000)]
2010-03-15  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Unreviewed.

        [Qt] Build fix if TILED_BACKING_STORE is disabled.

        * Api/qwebframe.cpp:
        (QWebFramePrivate::renderContentsLayerAbsoluteCoords):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-15 Shu Chang <Chang.Shu@nokia.com>
eric@webkit.org [Mon, 15 Mar 2010 14:34:25 +0000 (14:34 +0000)]
2010-03-15  Shu Chang  <Chang.Shu@nokia.com>

        Reviewed by Holger Freyther.

        [Qt] Change and add expected results after the fix and also remove the test from Skipped.
        https://bugs.webkit.org/show_bug.cgi?id=36060

        * platform/qt/Skipped:
        * platform/qt/fast/canvas/fillrect-gradient-zero-stops-expected.checksum: Added.
        * platform/qt/fast/canvas/fillrect-gradient-zero-stops-expected.png: Added.
        * platform/qt/fast/canvas/fillrect-gradient-zero-stops-expected.txt:
2010-03-15  Shu Chang  <Chang.Shu@nokia.com>

        Reviewed by Holger Freyther.

        [Qt] The behavior of QGradient with no stops is defined differently from HTML5 spec,
        where the latter requires the gradient to be transparent black. Explicitly added a
        transparent black color stop to match the HTML5 behavior.
        https://bugs.webkit.org/show_bug.cgi?id=36060

        * platform/graphics/qt/GradientQt.cpp:
        (WebCore::Gradient::platformGradient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSome minor code clean ups in SpatialNavigation.cpp
tonikitoo@webkit.org [Mon, 15 Mar 2010 14:13:43 +0000 (14:13 +0000)]
Some minor code clean ups in SpatialNavigation.cpp

Rubber-stamped by Holger Freyther.
Patch by Antonio Gomes <tonikitoo@webkit.org>

* page/SpatialNavigation.cpp:
(WebCore::distanceInDirection):
(WebCore::deflateIfOverlapped):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-13 Ilya Tikhonovsky <loislo@chromium.org>
pfeldman@chromium.org [Mon, 15 Mar 2010 13:02:28 +0000 (13:02 +0000)]
2010-03-13  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Timothy Hatcher.

        WebInspector: Position of GraphBar elements is calculating more carefully
        and they fully visible at the bottom of Timeline panel.

        http://bugs.webkit.org/show_bug.cgi?id=35966

        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelineRecordGraphRow.prototype.update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-15 MORITA Hajime <morrita@google.com>
eric@webkit.org [Mon, 15 Mar 2010 09:10:00 +0000 (09:10 +0000)]
2010-03-15  MORITA Hajime  <morrita@google.com>

        Reviewed by Alexey Proskuryakov.

        Selection.modify extends too far with 'lineboundary'.
        https://bugs.webkit.org/show_bug.cgi?id=33413

        * editing/selection/extend-selection-expected.txt:
        * platform/win/editing/selection/extend-selection-expected.txt:
        Updated result to correct expectation that described the wrong
        behaviour for the selection expansion with 'lineboundary'
        granularity.
2010-03-15  MORITA Hajime  <morrita@google.com>

        Reviewed by Alexey Proskuryakov.

        Selection.modify extends too far with 'lineboundary'.
        https://bugs.webkit.org/show_bug.cgi?id=33413

        Selection.modify() with 'lineboundary' granularity implies just
        "Go to the end of the line", unlike selection expansion with
        other type of granularities. This change handled LineGranularity
        as special case, to look-up end of line with UPSTREAM affinity.
        Doing this prevents look-up algorithm to go next line.

        Test: editing/selection/extend-selection-expected.txt

        * dom/Position.cpp:
        (WebCore::Position::getInlineBoxAndOffset):
        Handled an edge case for node look-up with UPSTREAM.
        * editing/SelectionController.cpp:
        (WebCore::SelectionController::modifyExtendingForward):
        Added UPSTREAM tweak for the case for LineGranularity.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-09 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Mon, 15 Mar 2010 08:34:45 +0000 (08:34 +0000)]
2010-03-09  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Holger Freyther.

        [GTK] GTK_WIDGET_IS_SENSITIVE is deprecated in GTK+ 2.20
        https://bugs.webkit.org/show_bug.cgi?id=35909

        * webkit/webkitwebview.cpp: GTK_WIDGET_IS_SENSITIVE has been
        deprecated in gtk 2.20. Use gtk_widget_is_sensitive when available.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-14 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Mon, 15 Mar 2010 08:33:18 +0000 (08:33 +0000)]
2010-03-14  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Shinichiro Hamaji.

        Always call PrintContext.end() from PrintContext::pageNumberForElement().

        Without this change, WebKit remains in printing mode after determining the page number if the specified element is found.

        https://bugs.webkit.org/show_bug.cgi?id=36049

        * platform/gtk/Skipped:
        * platform/mac/printing/return-from-printing-mode-expected.checksum: Added.
        * platform/mac/printing/return-from-printing-mode-expected.png: Added.
        * platform/mac/printing/return-from-printing-mode-expected.txt: Added.
        * platform/qt/Skipped:
        * platform/win/Skipped:
        * printing/return-from-printing-mode.html: Added.
2010-03-14  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Shinichiro Hamaji.

        Always call PrintContext.end() from PrintContext::pageNumberForElement().

        Without this change, WebKit remains in printing mode after determining the page number if the specified element is found.

        https://bugs.webkit.org/show_bug.cgi?id=36049

        Test: printing/return-from-printing-mode.html

        * page/PrintContext.cpp:
        (WebCore::PrintContext::pageNumberForElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-11 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Mon, 15 Mar 2010 08:19:40 +0000 (08:19 +0000)]
2010-03-11  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GStreamer] progressTimer never stopped after EOS
        https://bugs.webkit.org/show_bug.cgi?id=36007

        Mark the pipeline as paused only if playback hasn't ended
        yet. When didEnd() is triggered, the pipeline is paused (but
        paused() still returns false) and a timeupdate event is fired,
        those 2 conditions allow the HTMLMediaElement to stop the
        progressTimer (in updatePlayerState, via mediaPlayerTimeChanged).

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivate::updateStates):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-15 Adam Barth <abarth@webkit.org>
eric@webkit.org [Mon, 15 Mar 2010 07:28:25 +0000 (07:28 +0000)]
2010-03-15  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Operational scripts from running the EWS
        https://bugs.webkit.org/show_bug.cgi?id=36097

        These are the scripts I use to manage the EWS on EC2.  If someone other
        than me wants to run the EWS, these scripts might be helpful.

        * EWSTools/boot.sh: Added.
        * EWSTools/create-webkit-git: Added.
        * EWSTools/screen-config: Added.
        * EWSTools/start-queue.sh: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-14 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 15 Mar 2010 07:04:30 +0000 (07:04 +0000)]
2010-03-14  Darin Adler  <darin@apple.com>

        Reviewed by Mark Rowe.

        Remove unneeded dependency on non-string identifier for an NSTableColumn
        https://bugs.webkit.org/show_bug.cgi?id=36106

        * WebView/WebTextCompletionController.mm:
        (-[WebTextCompletionController _buildUI]): Use init instead of initWithIdentifier:
        because the table has only one column and that column does not need an identifier.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdded canvas perf demo for whatwg.
mjs@apple.com [Mon, 15 Mar 2010 06:19:32 +0000 (06:19 +0000)]
Added canvas perf demo for whatwg.

* demos/canvas-perf: Added.
* demos/canvas-perf/canvas.html: Added.
* demos/canvas-perf/kraken.jpg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-14 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 15 Mar 2010 06:16:14 +0000 (06:16 +0000)]
2010-03-14  Adam Barth  <abarth@webkit.org>

        Unreviewed.

        Fix the webkit-patch bots.  Turns out they need the path of the main
        script to run properly.

        * Scripts/webkit-patch:
        * Scripts/webkitpy/patch/patcher.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTell Subversion about more directories that expect to have .pyc files.
darin@apple.com [Mon, 15 Mar 2010 05:58:45 +0000 (05:58 +0000)]
Tell Subversion about more directories that expect to have .pyc files.

* Scripts/webkitpy/init: Added property svn:ignore.
* Scripts/webkitpy/patch: Added property svn:ignore.
* Scripts/webkitpy/thirdparty: Added property svn:ignore.
* Scripts/webkitpy/thirdparty/autoinstalled: Added property svn:ignore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-14 Chang Shu <chang.shu@nokia.com>
eric@webkit.org [Mon, 15 Mar 2010 01:28:02 +0000 (01:28 +0000)]
2010-03-14  Chang Shu  <chang.shu@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] [Symbian] Added block for ENABLE_SYMBIAN_DIALOG_PROVIDERS
        on Symbian platform.
        https://bugs.webkit.org/show_bug.cgi?id=35919

        * WebCore.pro:
2010-03-14  Chang Shu  <chang.shu@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] [Symbian] Use Symbian native dialog providers for combo pupups.
        https://bugs.webkit.org/show_bug.cgi?id=35919

        * WebCoreSupport/QtFallbackWebPopup.cpp:
        (WebCore::QtFallbackWebPopup::show):
        (WebCore::ResetAndDestroy):
        (WebCore::QtFallbackWebPopup::showS60BrowserDialog):
        * WebCoreSupport/QtFallbackWebPopup.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSupport for HTMLProgressElement
yael.aharon@nokia.com [Mon, 15 Mar 2010 01:00:36 +0000 (01:00 +0000)]
Support for HTMLProgressElement
https://bugs.webkit.org/show_bug.cgi?id=35937

Reviewed by Darin Adler.

WebCore:

Added support for HTMLProgressElement.
This implementation is enabled only for Qt, because only RenderThemeQt
was modified to actually draw the progress element.
The labels attribute of the progress element will be implemented in a
separate patch.

Tests: fast/dom/HTMLProgressElement/progress-element.html
       fast/dom/HTMLProgressElement/set-progress-properties.html

* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pri:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* css/CSSSelector.cpp:
(WebCore::CSSSelector::extractPseudoType):
* css/CSSValueKeywords.in:
* css/html.css:
* html/HTMLElement.cpp:
(WebCore::inlineTagList):
* html/HTMLElementsAllInOne.cpp:
* html/HTMLFormControlElement.cpp:
* html/HTMLFormControlElement.h:
* html/HTMLProgressElement.cpp: Added.
* html/HTMLProgressElement.h: Added.
* html/HTMLProgressElement.idl: Added.
* html/HTMLTagNames.in:
* page/DOMWindow.idl:
* platform/ThemeTypes.h:
* platform/qt/RenderThemeQt.cpp:
* platform/qt/RenderThemeQt.h:
* rendering/RenderObject.h:
* rendering/RenderProgress.cpp: Added.
* rendering/RenderProgress.h: Added.
* rendering/RenderTheme.cpp:
* rendering/RenderTheme.h:

LayoutTests:

* fast/dom/HTMLProgressElement: Added.
* fast/dom/HTMLProgressElement/progress-element.html: Added.
* fast/dom/HTMLProgressElement/script-tests: Added.
* fast/dom/HTMLProgressElement/script-tests/TEMPLATE.html: Added.
* fast/dom/HTMLProgressElement/script-tests/set-progress-properties.js: Added.
* fast/dom/HTMLProgressElement/set-progress-properties.html: Added.
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/fast/dom/HTMLProgressElement: Added.
* platform/qt/fast/dom/HTMLProgressElement/progress-element-expected.checksum: Added.
* platform/qt/fast/dom/HTMLProgressElement/progress-element-expected.png: Added.
* platform/qt/fast/dom/HTMLProgressElement/progress-element-expected.txt: Added.
* platform/qt/fast/dom/HTMLProgressElement/set-progress-properties-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=35146
antti@apple.com [Mon, 15 Mar 2010 00:53:19 +0000 (00:53 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=35146
Support tiled backing store

Reviewed by Simon Hausmann.

QtLauncher support and build flag in build-webkit.

* QtLauncher/main.cpp:
(LauncherWindow::applyPrefs):
(LauncherWindow::toggleTiledBackingStore):
(LauncherWindow::toggleResizesToContents):
(LauncherWindow::createChrome):
(LauncherApplication::handleUserOptions):
* QtLauncher/webview.cpp:
(WebViewGraphicsBased::WebViewGraphicsBased):
(WebViewGraphicsBased::setResizesToContents):
(WebViewGraphicsBased::resizeEvent):
* QtLauncher/webview.h:
* Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=35146
antti@apple.com [Mon, 15 Mar 2010 00:51:57 +0000 (00:51 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=35146
Support tiled backing store

Reviewed by Simon Hausmann.

Implements a basic tiled backing store mechanism. Tiles are created and
deleted on demand. The page content is cached to the tiles. Tile content
is kept in sync with the document. Since the backing store covers area
larger than the currently visible viewport, the document can be scrolled
quickly without having to enter rendering tree painting.

The tile management code is platform independent. This patch has simple QPixmap
based tile implementation for Qt.

The feature is behind ENABLE_TILED_BACKING_STORE flag.

* Api/qgraphicswebview.cpp:
(QGraphicsWebViewPrivate::visibleRect):
(QGraphicsWebView::paint):
* Api/qwebframe.cpp:
(QWebFramePrivate::renderContentsLayerAbsoluteCoords):
* Api/qwebframe.h:
* Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply):
* Api/qwebsettings.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-14 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Mon, 15 Mar 2010 00:01:57 +0000 (00:01 +0000)]
2010-03-14  Oliver Hunt  <oliver@apple.com>

        Reviewed by Darin Adler.

        REGRESSION(r53287): drop event is not fired if dataTransfer.dropEffect is not explicitly set
        https://bugs.webkit.org/show_bug.cgi?id=36095

        Correct this test to cover the somewhat bizarre "correct" handling
        of undefined dropEffect

        * fast/events/drag-and-drop-expected.txt:
        * fast/events/drag-and-drop.html:
2010-03-14  Oliver Hunt  <oliver@apple.com>

        Reviewed by Darin Adler.

        REGRESSION(r53287): drop event is not fired if dataTransfer.dropEffect is not explicitly set
        https://bugs.webkit.org/show_bug.cgi?id=36095

        The issue here is that while dropEffect is meant to be initialized
        to "none", the behaviour of the drag is differs between dragEffect
        not being set and dragEffect being explicitly set to "none"

        This patch corrects this behaviour by making Clipboard distinguish
        between the initial "none" value of dropEffect and an explicit "none".
        This alone is insufficient for correct behaviour, we also need to
        resurrect the removed defaultOperationForDrag function, but we now
        use the function only when dragEffect is uninitialized.  There are a
        few tweaks to the behaviour of the defaultOperationForDrag as well
        to ensure exactly the same set of outcomes for all cases that we
        may hit it.

        * dom/Clipboard.cpp:
        (WebCore::Clipboard::Clipboard):
        (WebCore::dragOpFromIEOp):
        (WebCore::Clipboard::destinationOperation):
        * dom/Clipboard.h:
        (WebCore::Clipboard::dropEffect):
        (WebCore::Clipboard::dropEffectIsUninitialized):
        * page/DragController.cpp:
        (WebCore::defaultOperationForDrag):
        (WebCore::DragController::tryDHTMLDrag):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=35146
antti@apple.com [Sun, 14 Mar 2010 23:40:29 +0000 (23:40 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=35146
Support tiled backing store

Reviewed by Simon Hausmann.

Implements a basic tiled backing store mechanism. Tiles are created and
deleted on demand. The page content is cached to the tiles. Tile content
is kept in sync with the document. Since the backing store covers area
larger than the currently visible viewport, the document can be scrolled
quickly without having to enter rendering tree painting.

The tile management code is platform independent. This patch has simple QPixmap
based tile implementation for Qt.

The feature is behind ENABLE_TILED_BACKING_STORE flag.

* WebCore.pri:
* WebCore.pro:
* page/Frame.cpp:
(WebCore::Frame::Frame):
(WebCore::Frame::setTiledBackingStoreEnabled):
(WebCore::Frame::tiledBackingStorePaintBegin):
(WebCore::Frame::tiledBackingStorePaint):
(WebCore::Frame::tiledBackingStorePaintEnd):
(WebCore::Frame::tiledBackingStoreContentsRect):
* page/Frame.h:
(WebCore::Frame::tiledBackingStore):
* page/FrameView.cpp:
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::doDeferredRepaints):
* page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setTiledBackingStoreEnabled):
* page/Settings.h:
(WebCore::Settings::tiledBackingStoreEnabled):
* platform/graphics/Tile.h: Added.
(WebCore::Tile::create):
(WebCore::Tile::coordinate):
(WebCore::Tile::rect):
* platform/graphics/TiledBackingStore.cpp: Added.
(WebCore::TiledBackingStore::TiledBackingStore):
(WebCore::TiledBackingStore::~TiledBackingStore):
(WebCore::TiledBackingStore::invalidate):
(WebCore::TiledBackingStore::updateTileBuffers):
(WebCore::TiledBackingStore::paint):
(WebCore::TiledBackingStore::viewportChanged):
(WebCore::TiledBackingStore::setContentsScale):
(WebCore::TiledBackingStore::tileDistance):
(WebCore::TiledBackingStore::createTiles):
(WebCore::TiledBackingStore::dropOverhangingTiles):
(WebCore::TiledBackingStore::dropTilesOutsideRect):
(WebCore::TiledBackingStore::tileAt):
(WebCore::TiledBackingStore::setTile):
(WebCore::TiledBackingStore::removeTile):
(WebCore::TiledBackingStore::mapToContents):
(WebCore::TiledBackingStore::mapFromContents):
(WebCore::TiledBackingStore::contentsRect):
(WebCore::TiledBackingStore::tileRectForCoordinate):
(WebCore::TiledBackingStore::tileCoordinateForPoint):
(WebCore::TiledBackingStore::startTileBufferUpdateTimer):
(WebCore::TiledBackingStore::tileBufferUpdateTimerFired):
(WebCore::TiledBackingStore::startTileCreationTimer):
(WebCore::TiledBackingStore::tileCreationTimerFired):
(WebCore::TiledBackingStore::setContentsFrozen):
* platform/graphics/TiledBackingStore.h: Added.
(WebCore::TiledBackingStore::contentsScale):
(WebCore::TiledBackingStore::contentsFrozen):
* platform/graphics/TiledBackingStoreClient.h: Added.
* platform/graphics/qt/TileQt.cpp: Added.
(WebCore::checkeredPixmap):
(WebCore::Tile::Tile):
(WebCore::Tile::~Tile):
(WebCore::Tile::isDirty):
(WebCore::Tile::isReadyToPaint):
(WebCore::Tile::invalidate):
(WebCore::Tile::updateBackBuffer):
(WebCore::Tile::swapBackBufferToFront):
(WebCore::Tile::paint):
(WebCore::Tile::paintCheckerPattern):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: WebCore part of removing support for legacy versions of Core Graphics
mitz@apple.com [Sun, 14 Mar 2010 21:44:07 +0000 (21:44 +0000)]
WebCore: WebCore part of removing support for legacy versions of Core Graphics

Reviewed by Darin Adler.

* WebCore.vcproj/WebCore.vcproj: Removed FontDatabase.{cpp,h}
* platform/graphics/win/FontCGWin.cpp:
(WebCore::Font::drawGlyphs): Removed call to wkCanCreateCGFontWithLOGFONT(),
as it is now always true.
* platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::createFontPlatformData): Ditto.
* platform/graphics/win/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::~FontCustomPlatformData): Updated for
the removal of m_cgFont.
(WebCore::FontCustomPlatformData::fontPlatformData): Removed call to
wkCanCreateCGFontWithLOGFONT(), as it is now always true.
(WebCore::createFontCustomPlatformData): Ditto. Also updated for change to
the FontCustomPlatformData constructor.
* platform/graphics/win/FontCustomPlatformData.h: Removed m_cgFont member.
(WebCore::FontCustomPlatformData::FontCustomPlatformData): Removed cgFont
parameter.
* platform/graphics/win/FontDatabase.cpp: Removed.
* platform/graphics/win/FontDatabase.h: Removed.
* platform/graphics/win/FontPlatformDataCGWin.cpp:
(WebCore::FontPlatformData::platformDataInit): Removed call to
wkCanCreateCGFontWithLOGFONT(), as it is now always true.
* platform/win/TemporaryLinkStubs.cpp:
(WebCore::populateFontDatabase): Removed stub.

WebKit/win: WebKit part of removing support for legacy versions of Core Graphics

Reviewed by Darin Adler.

* WebKitClassFactory.cpp:
(WebKitClassFactory::WebKitClassFactory): Removed call to populateFontDatabase().
* WebKitGraphics.cpp:
(makeFont): Ditto.
* WebTextRenderer.cpp:
(WebTextRenderer::registerPrivateFont): Removed call to wkAddFontsAtPath().

WebKitLibraries: WebKitSystemInterface part of removing support for legacy versions of Core Graphics

Reviewed by Darin Adler.

* win/include/WebKitSystemInterface/WebKitSystemInterface.h: Removed
wkCanCreateCGFontWithLOGFONT(), wkSetFontPlatformInfo(), wkAddFontsInDirectory(),
wkAddFontsAtPath(), wkAddFontsFromRegistry(), wkAddFontsFromPlist(), and
wkCreateFontsPlist().
* win/lib/WebKitSystemInterface.lib: Updated.
* win/lib/WebKitSystemInterface_debug.lib: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago"event.ctrlKey" is always false when dragging an element with "ctrl" key down
jberlin@webkit.org [Sun, 14 Mar 2010 15:43:52 +0000 (15:43 +0000)]
"event.ctrlKey" is always false when dragging an element with "ctrl" key down
https://bugs.webkit.org/show_bug.cgi?id=17113

Reviewed by Sam Weinig.

No new tests.

* page/DragController.cpp:
(WebCore::createMouseEvent):
Use the current state of the shift, ctrl, alt, and meta keys when creating the drag mouse event.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-13 Antonio Gomes <tonikitoo@webkit.org>
tonikitoo@webkit.org [Sun, 14 Mar 2010 12:58:53 +0000 (12:58 +0000)]
2010-03-13  Antonio Gomes  <tonikitoo@webkit.org>

        Not reviewed identation fix.

        * manual-tests/spatial-navigation/spatial-navigation-test-cases.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoThe webkit-patch script now displays a warning if run using
cjerdonek@webkit.org [Sun, 14 Mar 2010 00:23:55 +0000 (00:23 +0000)]
The webkit-patch script now displays a warning if run using
a version of Python less than 2.5.  This will help users
understand why webkit-patch is erroring out if they are
using Python 2.4, for example.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=31533

* Scripts/webkit-patch:
  - Moved most of the file contents to webkitpy/patch/patcher.py
    so the Python version can be checked before interpreting
    any code that can cause the script to error out.
  - Added a configure_logging() method to enable any version
    warnings to show up.
  - Added a main() method with calls to configure_logging(),
    check_version(), and the main webkit patch method.

* Scripts/webkitpy/patch/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py.
  - This file is required to make a folder a package.

* Scripts/webkitpy/patch/patcher.py: Added.
  - Moved code from Scripts/webkit-patch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChanged test-webkitpy so that messages logged as a side-effect
cjerdonek@webkit.org [Sat, 13 Mar 2010 23:48:20 +0000 (23:48 +0000)]
Changed test-webkitpy so that messages logged as a side-effect
of unit-testing code do not get displayed to the screen.  These
messages clutter up the unit test results if not filtered out.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=35835

* Scripts/test-webkitpy:
  - Adjusted the configure_logging() method to filter out any
    log messages from webkitpy.
  - Also added an INFO message stating that most console logging
    is getting suppressed.

* Scripts/webkitpy/init/versioning.py:
  - Added a log parameter to the check_version() method.

* Scripts/webkitpy/init/versioning_unittest.py:
  - Qualified a call to check_version() with the parameter names.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoThe test-webkitpy script now warns the user if the script is
cjerdonek@webkit.org [Sat, 13 Mar 2010 22:36:30 +0000 (22:36 +0000)]
The test-webkitpy script now warns the user if the script is
being run using a Python version different from the minimum
version the webkitpy package was meant to support.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=35788

Warning developers if their Python version is too low will help
them understand why test-webkitpy is failing.  Secondly, warning
developers if their Python version is higher than the minimum will
help them understand that their changes may not be okay for the
minimum supported version, even if test-webkitpy is passing.

* Scripts/test-webkitpy:
  - Moved the "from ..._unittest import *" lines to the new
    file Scripts/webkitpy/unittests.py.  This will allow the
    version-check warning to be displayed even if an error occurs
    while interpreting (i.e. importing) the unit test code.
  - Added configure_logging() to configur logging for test-webkitpy.
  - Added an init() method to configure logging and check the
    current Python version.

* Scripts/webkitpy/init/unittests.py: Added.
  - Added a file to import all unit test modules in the
    webkitpy.init package.

* Scripts/webkitpy/init/versioning.py: Added.
  - Added a _MINIMUM_SUPPORTED_PYTHON_VERSION variable and set
    it equal to 2.5.
  - Added a compare_version() method to compare the current Python
    version against a target version.
  - Added a check_version() method to check the current Python
    version against the current minimum supported version, and to
    log a warning message if the check fails.

* Scripts/webkitpy/init/versioning_unittest.py: Added.
  - Added unit tests for the functions in versioning.py.

* Scripts/webkitpy/style/unittests.py:
  - Fixed/updated a code comment.

* Scripts/webkitpy/unittests.py: Added.
  - Moved the "from ..._unittest import *" lines from test-webkitpy.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMoved all code in webkitpy/__init__.py to another location.
cjerdonek@webkit.org [Sat, 13 Mar 2010 22:10:04 +0000 (22:10 +0000)]
Moved all code in webkitpy/__init__.py to another location.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=35828

Keeping webkitpy/__init__.py free of non-trivial code allows
calling code to import initialization code from webkitpy
before any errors or log messages occur due to code in
__init__.py.  Such initialization code can include things like
version checking code and logging configuration code.  This
also lets us move the autoinstall initialization code to a
location where it only executes if it is needed -- something
we have done in this patch.

* Scripts/webkitpy/__init__.py:
  - Moved all executable code to the following location:
    webkitpy/thirdparty/autoinstalled/__init__.py
  - Added a code comment to keep this file free of non-trivial
    code.

* Scripts/webkitpy/bugzilla.py:
  - Updated mechanize import statement.

* Scripts/webkitpy/networktransaction.py:
  - Updated mechanize import statement.

* Scripts/webkitpy/networktransaction_unittest.py:
  - Updated mechanize import statement.

* Scripts/webkitpy/statusserver.py:
  - Updated mechanize import statement.

* Scripts/webkitpy/thirdparty/autoinstalled/__init__.py: Added.
  - Copied the code from webkitpy/__init__.py and updated it
    as necessary.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMoved webkitpy/mock.py into webkitpy/thirdparty since it is
cjerdonek@webkit.org [Sat, 13 Mar 2010 21:28:36 +0000 (21:28 +0000)]
Moved webkitpy/mock.py into webkitpy/thirdparty since it is
third-party code.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=35499

Updated the import statement in all of the below except where noted.

* Scripts/webkitpy/bugzilla_unittest.py:
* Scripts/webkitpy/commands/commandtest.py:
* Scripts/webkitpy/commands/download_unittest.py:
* Scripts/webkitpy/commands/early_warning_system_unittest.py:
* Scripts/webkitpy/commands/queries_unittest.py:
* Scripts/webkitpy/commands/queues_unittest.py:
* Scripts/webkitpy/commands/queuestest.py:
* Scripts/webkitpy/commands/upload.py:
* Scripts/webkitpy/commands/upload_unittest.py:
* Scripts/webkitpy/commands_references.py: Added.
  - Added a file containing an absolute import of Mock so that
    the imports in the commands folder can import from this file
    (similar to style_references.py).  This helps limit the
    number of affected files in future refactorings.

* Scripts/webkitpy/credentials_unittest.py:
* Scripts/webkitpy/mock.py: Removed.
  - Moved to Scripts/webkitpy/thirdparty.

* Scripts/webkitpy/mock_bugzillatool.py:
* Scripts/webkitpy/patchcollection_unittest.py:
* Scripts/webkitpy/steps/closebugforlanddiff_unittest.py:
* Scripts/webkitpy/steps/steps_unittest.py:
* Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py:
* Scripts/webkitpy/steps_references.py: Added.
  - Added a file containing an absolute import of Mock so that
    the imports in the steps folder can import from this file
    (similar to style_references.py).  This helps limit the
    number of affected files in future refactorings.

* Scripts/webkitpy/thirdparty/mock.py: Copied from WebKitTools/Scripts/webkitpy/mock.py.
  - Also eliminated trailing white space and carriage returns.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-13 Kim Grönholm <kim.gronholm@nomovok.com>
eric@webkit.org [Sat, 13 Mar 2010 19:28:45 +0000 (19:28 +0000)]
2010-03-13  Kim Grönholm  <kim.gronholm@nomovok.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] GraphicsLayer: Opacity change from zero to non-zero doesn't always have effect with AC
        https://bugs.webkit.org/show_bug.cgi?id=36034

        * platform/graphics/qt/GraphicsLayerQt.cpp:
        (WebCore::OpacityAnimationQt::applyFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-13 Kim Grönholm <kim.gronholm@nomovok.com>
eric@webkit.org [Sat, 13 Mar 2010 18:54:12 +0000 (18:54 +0000)]
2010-03-13  Kim Grönholm  <kim.gronholm@nomovok.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] GraphicsLayer: Opacity transitions end with begin value
        https://bugs.webkit.org/show_bug.cgi?id=36019

        * platform/graphics/qt/GraphicsLayerQt.cpp:
        (WebCore::AnimationQt::updateCurrentTime):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-13 Leandro Pereira <leandro@profusion.mobi>
eric@webkit.org [Sat, 13 Mar 2010 18:35:41 +0000 (18:35 +0000)]
2010-03-13  Leandro Pereira  <leandro@profusion.mobi>

        Reviewed by Kenneth Rohde Christiansen.

        Add EFL port files to efl/ewk.
        http://webkit.org/b/35925

        * efl/ewk/ewk_history.cpp: Added.
        * efl/ewk/ewk_history.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-13 Leandro Pereira <leandro@profusion.mobi>
eric@webkit.org [Sat, 13 Mar 2010 18:17:04 +0000 (18:17 +0000)]
2010-03-13  Leandro Pereira  <leandro@profusion.mobi>

        Reviewed by Kenneth Rohde Christiansen.

        Add EFL port files to efl/ewk.
        http://webkit.org/b/35928

        * efl/ewk/ewk_main.cpp: Added.
        * efl/ewk/ewk_main.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Enable accelerated compositing by default
ossy@webkit.org [Sat, 13 Mar 2010 18:12:45 +0000 (18:12 +0000)]
[Qt] Enable accelerated compositing by default
https://bugs.webkit.org/show_bug.cgi?id=35866

Unreviewed. Roll-out r55955, because it broke 3 tests:
- animations/fill-mode-transform.html
- animations/play-state.html
- animations/simultaneous-start-left.html

* Api/qwebsettings.cpp:
(QWebSettings::QWebSettings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-13 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Sat, 13 Mar 2010 13:43:33 +0000 (13:43 +0000)]
2010-03-13  Dirk Schulze  <krit@webkit.org>

        No review, rolling out r55927.
        http://trac.webkit.org/changeset/55927
        https://bugs.webkit.org/show_bug.cgi?id=35793

        Breaks Gtk build bots.

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
        (WebCore::MediaPlayerPrivate::load):
        (WebCore::MediaPlayerPrivate::setPreload):
        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-12 Robert Hogan <robert@webkit.org>
robert@webkit.org [Sat, 13 Mar 2010 10:59:20 +0000 (10:59 +0000)]
2010-03-12  Robert Hogan  <robert@webkit.org>

        Reviewed by Adam Barth.

        Amend incorrect typo patch for QtLauncher.

        https://bugs.webkit.org/show_bug.cgi?id=35877

        * QtLauncher/webview.cpp:
        (WebViewGraphicsBased::setFrameRateMeasurementEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-13 Victor Wang <victorw@chromium.org>
eric@webkit.org [Sat, 13 Mar 2010 10:44:59 +0000 (10:44 +0000)]
2010-03-13  Victor Wang  <victorw@chromium.org>

        Add appengine app to host and serve webkit layout test results.

        The app allows you post test result files (json) and serve them up.
        Chromium flakiness dashboard will first use this app to host results.json
        and expectations.json, but the files hosted by this app are not limited
        to chromium results or json files. It can be used to host other files if needed.

        https://bugs.webkit.org/show_bug.cgi?id=35944

        * TestResultServer: Added.
        * TestResultServer/app.yaml: Added.
        * TestResultServer/handlers: Added.
        * TestResultServer/handlers/__init__.py: Added.
        * TestResultServer/handlers/menu.py: Added.
        * TestResultServer/handlers/testfilehandler.py: Added.
        * TestResultServer/index.yaml: Added.
        * TestResultServer/main.py: Added.
        * TestResultServer/model: Added.
        * TestResultServer/model/__init__.py: Added.
        * TestResultServer/model/testfile.py: Added.
        * TestResultServer/stylesheets: Added.
        * TestResultServer/stylesheets/form.css: Added.
        * TestResultServer/stylesheets/menu.css: Added.
        * TestResultServer/stylesheets/testfile.css: Added.
        * TestResultServer/templates: Added.
        * TestResultServer/templates/menu.html: Added.
        * TestResultServer/templates/showfilelist.html: Added.
        * TestResultServer/templates/uploadform.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-13 Dimitri Glazkov <dglazkov@chromium.org>
eric@webkit.org [Sat, 13 Mar 2010 10:28:10 +0000 (10:28 +0000)]
2010-03-13  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by David Levin.

        new-run-webkit-tests fails with --debug option.
        https://bugs.webkit.org/show_bug.cgi?id=36067

        * Scripts/webkitpy/layout_tests/port/mac.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-13 Leandro Pereira <leandro@profusion.mobi>
eric@webkit.org [Sat, 13 Mar 2010 10:11:29 +0000 (10:11 +0000)]
2010-03-13  Leandro Pereira  <leandro@profusion.mobi>

        Reviewed by Kenneth Rohde Christiansen.

        Add EFL port files to efl/ewk.
        http://webkit.org/b/35924

        * efl/ewk/ewk_frame.cpp: Added.
        * efl/ewk/ewk_frame.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-13 Leandro Pereira <leandro@profusion.mobi>
eric@webkit.org [Sat, 13 Mar 2010 09:54:45 +0000 (09:54 +0000)]
2010-03-13  Leandro Pereira  <leandro@profusion.mobi>

        Reviewed by Kenneth Rohde Christiansen.

        Add EFL port files to efl/ewk.
        http://webkit.org/b/35936

        * efl/ewk/ewk_view_single.c: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-13 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
eric@webkit.org [Sat, 13 Mar 2010 09:38:05 +0000 (09:38 +0000)]
2010-03-13  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        Add "Show FPS" menu option to QtLauncher.

        [Qt] QtLauncher need a menu option to show/hide FPS
        https://bugs.webkit.org/show_bug.cgi?id=35794

        * QtLauncher/main.cpp:
        (LauncherWindow::showFPS):
        (LauncherWindow::createChrome):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-13 Simon Hausmann <simon.hausmann@nokia.com>
eric@webkit.org [Sat, 13 Mar 2010 09:21:24 +0000 (09:21 +0000)]
2010-03-13  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Enable accelerated compositing by default
        https://bugs.webkit.org/show_bug.cgi?id=35866

        * Api/qwebsettings.cpp:
        (QWebSettings::QWebSettings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-13 Leandro Pereira <leandro@profusion.mobi>
eric@webkit.org [Sat, 13 Mar 2010 09:04:43 +0000 (09:04 +0000)]
2010-03-13  Leandro Pereira  <leandro@profusion.mobi>

        Reviewed by Kenneth Rohde Christiansen.

        Add EFL port files to efl/ewk.
        http://webkit.org/b/35929

        * efl/ewk/ewk_util.cpp: Added.
        * efl/ewk/ewk_util.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-13 Leandro Pereira <leandro@profusion.mobi>
eric@webkit.org [Sat, 13 Mar 2010 08:47:59 +0000 (08:47 +0000)]
2010-03-13  Leandro Pereira  <leandro@profusion.mobi>

        Reviewed by Kenneth Rohde Christiansen.

        Add EFL port files to efl/ewk.
        http://webkit.org/b/35934

        * efl/ewk/EWebKit.h: Added.
        * efl/ewk/ewk_eapi.h: Added.
        * efl/ewk/ewk_logging.h: Added.
        * efl/ewk/ewk_private.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-13 Eric Roman <eroman@chromium.org>
eric@webkit.org [Sat, 13 Mar 2010 08:31:14 +0000 (08:31 +0000)]
2010-03-13  Eric Roman  <eroman@chromium.org>

        Reviewed by Adam Barth.

        Add a firstPartyForCookies() property to WebDocument.
        https://bugs.webkit.org/show_bug.cgi?id=35592

        * public/WebDocument.h:
        * src/WebDocument.cpp:
        (WebKit::WebDocument::firstPartyForCookies):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-13 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
eric@webkit.org [Sat, 13 Mar 2010 08:14:24 +0000 (08:14 +0000)]
2010-03-13  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        Add a "Toggle FullScreen" option to QtLauncher Menu.

        [Qt] QtLauncher needs an option to toggle FullScreen Mode
        https://bugs.webkit.org/show_bug.cgi?id=35755

        * QtLauncher/main.cpp:
        (LauncherWindow::init):
        (LauncherWindow::eventFilter):
        (LauncherWindow::initializeView):
        (LauncherWindow::toggleFullScreenMode):
        (LauncherWindow::createChrome):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-12 Shu Chang <chang.shu@nokia.com>
eric@webkit.org [Sat, 13 Mar 2010 07:57:33 +0000 (07:57 +0000)]
2010-03-12  Shu Chang  <chang.shu@nokia.com>

        Reviewed by David Levin.

        [Qt] Rebaseline the test and remove it from Skipped.
        https://bugs.webkit.org/show_bug.cgi?id=36057

        * platform/qt/Skipped:
        * platform/qt/fast/canvas/canvas-size-change-after-layout-expected.checksum: Added.
        * platform/qt/fast/canvas/canvas-size-change-after-layout-expected.png: Added.
        * platform/qt/fast/canvas/canvas-size-change-after-layout-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-12 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Sat, 13 Mar 2010 07:07:43 +0000 (07:07 +0000)]
2010-03-12  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG Glyphs - transform path not context
        https://bugs.webkit.org/show_bug.cgi?id=36070

        SVGFont should transform the path of a glyph, not the context. Modifying
        the context causes wrong gradient transformations. This bug doesn't
        influence CG because we generally fill or stroke texts with a mask image.
        All other platforms provide a direct way to make the drawings.

        * svg/SVGFont.cpp:
        (WebCore::Font::drawTextUsingSVGFont):
2010-03-12  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG Glyphs - transform path not context
        https://bugs.webkit.org/show_bug.cgi?id=36070

        Some tests don't look pixel perfect after the SVGFont changes (difference of 0.1%).
        They just need an update.
        Tests for the changes on other platforms than CG are
            * svg/batik/text/textEffect.svg
            * svg/batik/text/textEffect3.svg
            * svg/W3C-SVG-1.1/pservers-grad-08-b.svg

        * platform/mac-leopard/svg/custom/svg-fonts-in-html-expected.checksum:
        * platform/mac-leopard/svg/custom/svg-fonts-in-html-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
        * platform/mac/svg/batik/text/textEffect-expected.checksum:
        * platform/mac/svg/batik/text/textEffect-expected.png:
        * platform/mac/svg/batik/text/textEffect3-expected.checksum:
        * platform/mac/svg/batik/text/textEffect3-expected.png:
        * platform/mac/svg/text/selection-doubleclick-expected.png:
        * platform/mac/svg/text/selection-tripleclick-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
barraclough@apple.com [Sat, 13 Mar 2010 02:10:07 +0000 (02:10 +0000)]
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

Reviewed by NOBODY (build fix).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFixed broken build on Windows.
enrica@apple.com [Sat, 13 Mar 2010 01:56:01 +0000 (01:56 +0000)]
Fixed broken build on Windows.
Added contditional compilation for accelerated compositing.

* WebView.cpp:
(WebView::deleteBackingStore):
(WebView::addToDirtyRegion):
(WebView::updateBackingStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=34942 Fullscreen
bdakin@apple.com [Sat, 13 Mar 2010 01:39:03 +0000 (01:39 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=34942 Fullscreen
API naming is inconsistent
-and corresponding-
<rdar://problem/7729165>

Reviewed by Simon Fraser.

WebCore:

This patch changes all occurrences of "fullScreen" to the more
popular "fullscreen." webkitEnterFullScreen and
webkitExitFullScreen have been maintained for now for backwards
compatibility.

* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::webkitEnterFullscreen):
(WebCore::HTMLVideoElement::webkitExitFullscreen):
* html/HTMLVideoElement.h:
(WebCore::HTMLVideoElement::webkitEnterFullScreen):
(WebCore::HTMLVideoElement::webkitExitFullScreen):
* html/HTMLVideoElement.idl:
* platform/graphics/mac/MediaPlayerProxy.h:

WebKit/mac:

This patch changes all occurrences of "fullScreen" to the more
popular "fullscreen."

* Plugins/Hosted/NetscapePluginHostProxy.h:
(WebKit::NetscapePluginHostProxy::isFullscreenWindowShowing):
* Plugins/Hosted/NetscapePluginHostProxy.mm:
(WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
(WebKit::NetscapePluginHostProxy::didEnterFullscreen):
(WebKit::NetscapePluginHostProxy::didExitFullscreen):
(WebKit::NetscapePluginHostProxy::setFullscreenWindowIsShowing):
(WKPCSetFullscreenWindowIsShowing):
* Plugins/Hosted/WebKitPluginClient.defs:
* Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView _workaroundSilverlightFullscreenBug:]):
(-[WebNetscapePluginView _createPlugin]):
(-[WebNetscapePluginView _destroyPlugin]):
* WebView/WebVideoFullscreenHUDWindowController.mm:
(-[WebVideoFullscreenHUDWindowController windowDidLoad]):

WebKit/win:

This patch changes all occurrences of "fullScreen" to the more
popular "fullscreen."

* FullscreenVideoController.cpp:
(FullscreenVideoController::onMouseDown):
(FullscreenVideoController::onMouseMove):
(FullscreenVideoController::onMouseUp):
* FullscreenVideoController.h:
(FullscreenVideoController::fullscreenToHUDCoordinates):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-12 James Robinson <jamesr@chromium.org>
jamesr@google.com [Sat, 13 Mar 2010 01:02:47 +0000 (01:02 +0000)]
2010-03-12  James Robinson  <jamesr@chromium.org>

        Reviewed by Adam Barth.

        Add virtual destructor to DOMWrapperWorld
        https://bugs.webkit.org/show_bug.cgi?id=36077

        DOMWrapperWorld is RefCounted<DOMWrapperWorld>.  IsolatedWorld
        inherits from DOMWrapperWorld and has member variables
        with destructors, so DOMWrapperWorld needs to have a declared virtual
        d'tor to ensure that its derived class's destructors are called.

        No new tests, no change in behavior

        * bindings/v8/DOMWrapperWorld.h:
        (WebCore::DOMWrapperWorld::~DOMWrapperWorld):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
barraclough@apple.com [Sat, 13 Mar 2010 00:46:17 +0000 (00:46 +0000)]
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

Reviewed by NOBODY (build fix).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBug 36075 - Clean up screwyness re static string impls & Identifiers.
barraclough@apple.com [Fri, 12 Mar 2010 23:49:05 +0000 (23:49 +0000)]
Bug 36075 - Clean up screwyness re static string impls & Identifiers.

Reviewed by Oliver Hunt.

JavaScriptCore:

* API/JSClassRef.cpp:
(OpaqueJSClass::~OpaqueJSClass): Classname may be null/empty, and these are an identifer.  This is okay, since the null/empty strings are shared across all threads.
* JavaScriptCore.exp:
* runtime/Identifier.cpp:
(JSC::Identifier::add): No need to explicitly hash null reps, this is done in the ststic UStringImpl constructor.
(JSC::Identifier::addSlowCase): UStringImpl::empty() handled & checkCurrentIdentifierTable now called in the header.
(JSC::Identifier::checkCurrentIdentifierTable): Replaces checkSameIdentifierTable (this no longer checked the rep since the identifierTable pointer was removed from UString::Rep long ago).
* runtime/Identifier.h:
(JSC::Identifier::add): Replace call to checkSameIdentifierTable with call to checkCurrentIdentifierTable at head of function.
* runtime/UStringImpl.cpp:
(JSC::UStringImpl::~UStringImpl): Remove call to checkConsistency - this function no longer checks anything interesting.
* runtime/UStringImpl.h:
(JSC::UStringOrRopeImpl::UStringOrRopeImpl): Set s_refCountFlagIsIdentifier in static constructor.
(JSC::UStringImpl::UStringImpl): remove calls to checkConsistency (see above), add new ASSERT to substring constructor.
(JSC::UStringImpl::setHash): ASSERT not static (static strings set the hash in their constructor, should not reach this code path).
(JSC::UStringImpl::create): Add missing ASSERT.
(JSC::UStringImpl::setIsIdentifier): ASSERT !isStatic() (static strings hash set in constructor).

WebCore:

* platform/text/StringImpl.cpp:
(WebCore::StringImpl::~StringImpl): Add ASSERT
(WebCore::StringImpl::sharedBuffer): Add ASSERT
* platform/text/StringImpl.h:
(WebCore::StringImpl::setHash): Add ASSERT
(WebCore::StringImpl::isStatic): added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=33739 Fullscreen
bdakin@apple.com [Fri, 12 Mar 2010 23:17:12 +0000 (23:17 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=33739 Fullscreen
video HUD stays on top when switching to another window (e.g. via
Alt-Tab)
-and corresponding-
<rdar://problem/7547574>

Reviewed by Adam Roben.

The HUD was always on top because it had the WS_EX_TOPMOST style.
So I removed the style and made m_videoWindow the owner of
m_hudWindow. This keeps m_hudWindow on top only when m_videoWindow
is the focused window.

* FullscreenVideoController.cpp:
(FullscreenVideoController::exitFullscreen): ASSERT that movie()->exitFullscreen() also destroyed the hud.
(FullscreenVideoController::createHUDWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoContent of 3D tests appears at the bottom right corner sometimes.
enrica@apple.com [Fri, 12 Mar 2010 23:11:42 +0000 (23:11 +0000)]
Content of 3D tests appears at the bottom right corner sometimes.
<rdar://problem/7556244>
<https://bugs.webkit.org/show_bug.cgi?id=36027>

Reviewed by Simon Fraser.

WebCore:

There were two problems to solve here:
- the incorrect anchoring of the rootChildLayer that was causing the composited
  content to be positioned incorrectly
- the failure to paint the non composited content into the backing store when
  animating composited content.

The first problem has been solved by leaving the original anchor point for the
rootChildLayer and splitting the tasks of clipping and scrolling using two separate layers.
The second problem has been solved leveraging the knowledge that WebView has of the dirty region
of the backing store to pass this information to the layer renderer. This allows the renderer to force
a paint into the backing store before moving to the compositing.

Tests: compositing/geometry/horizontal-scroll-composited.html
       compositing/geometry/vertical-scroll-composited.html

* manual-tests/win/horizontal-scroll-composited.html: Removed. This is now a layout test.
* manual-tests/win/milliondollar.html: Added.
* platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): Added initialization of dirty flag.
(WebCore::WKCACFLayerRenderer::setScrollFrame):
(WebCore::WKCACFLayerRenderer::updateScrollFrame): Updated to resize and position the clip and scroll layers.
(WebCore::WKCACFLayerRenderer::setRootChildLayer):
(WebCore::WKCACFLayerRenderer::createRenderer): Added new layer hierarchy.
(WebCore::WKCACFLayerRenderer::destroyRenderer): Remove clip layer on destroy.
(WebCore::WKCACFLayerRenderer::resize):
(WebCore::WKCACFLayerRenderer::paint): Forcing paint massage to trigger paint into the backing store.
* platform/graphics/win/WKCACFLayerRenderer.h:
(WebCore::WKCACFLayerRenderer::setBackingStoreDirty): Added.

WebKit/win:

See detailed comments in WebCore/ChangeLog.

* WebView.cpp:
(WebView::deleteBackingStore): Reset the dirty flag when deleting the backing store.
(WebView::addToDirtyRegion): Set the dirty flag when adding dirty rectangles to the
backing store dirty region.
(WebView::updateBackingStore): Reset the dirty flag after painting into the backing store.
(WebView::setAcceleratedCompositing): Removed unnecessary call to updateRootLayerContents.
(WebView::updateRootLayerContents): Changed the way we pass parameters to setScrollFrame.
We are passing width and height of the view content together with the offset for the scrolling.
It was confusing to pass it all as a rectangle, when it is not a rectangle.

LayoutTests:

* compositing/geometry/horizontal-scroll-composited.html: Added.
* compositing/geometry/vertical-scroll-composited.html: Added.
* compositing/resources/apple.jpg: Added.
* platform/mac/compositing/geometry/horizontal-scroll-composited-expected.checksum: Added.
* platform/mac/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
* platform/mac/compositing/geometry/horizontal-scroll-composited-expected.txt: Added.
* platform/mac/compositing/geometry/vertical-scroll-composited-expected.checksum: Added.
* platform/mac/compositing/geometry/vertical-scroll-composited-expected.png: Added.
* platform/mac/compositing/geometry/vertical-scroll-composited-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-12 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 12 Mar 2010 22:58:51 +0000 (22:58 +0000)]
2010-03-12  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Dimitri Glazkov.

        Fix typo in websocket_server (path_from_base instead of
        path_from_chromium_base).

        https://bugs.webkit.org/show_bug.cgi?id=36074

        * Scripts/webkitpy/layout_tests/port/websocket_server.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-12 Robert Hogan <robert@webkit.org>
robert@webkit.org [Fri, 12 Mar 2010 22:49:49 +0000 (22:49 +0000)]
2010-03-12  Robert Hogan  <robert@webkit.org>

        Not reviewed, build fix.

        Revert http://trac.webkit.org/projects/webkit/changeset/55374 which broke
        the !ENABLE(DATABASE) build on all platforms when attempting to fix the
        --minimal build on Qt.

        Support for SQLite now seems to be non-negotiable for the Qt build but making
        it mandatory requires review, so re-break --minimal Qt build for now.

        Qt build issue now tracked at https://bugs.webkit.org/show_bug.cgi?id=36073

        * page/GeolocationPositionCache.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-12 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 12 Mar 2010 22:43:00 +0000 (22:43 +0000)]
2010-03-12  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Adam Barth.

        new-run-webkit-tests --new-baseline doesn't work at all.

        It attempts to call a method that isn't defined. To fix it, I
        removed the unnecessary and unnecessarily confusing 'platform'
        argument to the test_type constructor and use the Port object that
        is passed in instead, since we are only ever generating a baseline
        from the port that is currently executing.

        https://bugs.webkit.org/show_bug.cgi?id=36046

        * Scripts/webkitpy/layout_tests/port/mac.py:
        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-12 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 12 Mar 2010 22:42:19 +0000 (22:42 +0000)]
2010-03-12  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Adam Barth.

        Fix new-run-webkit-tests --run-singly

        This script option is currently broken - the script attempts to
        dereference methods and variables that don't exist, which causes
        the Chromium Linux valgrind bot to be quite unhappy. This has been
        broken since r54449 when I renamed Port.start_test_driver to
        Port.start_driver.

        https://bugs.webkit.org/show_bug.cgi?id=36042

        * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-12 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Fri, 12 Mar 2010 22:31:05 +0000 (22:31 +0000)]
2010-03-12  Dirk Schulze  <krit@webkit.org>

        Unreviewed LayoutTest update.

        Result was not updated with r55930.

        * platform/mac/svg/custom/dominant-baseline-hanging-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/7709115> REGRESSION: toolbar is missing at http://www.glom.org/
mitz@apple.com [Fri, 12 Mar 2010 21:23:57 +0000 (21:23 +0000)]
<rdar://problem/7709115> REGRESSION: toolbar is missing at glom.org/
https://bugs.webkit.org/show_bug.cgi?id=35507

Reviewed by Alexey Proskuryakov.

* css/CSSImportRule.cpp:
(WebCore::CSSImportRule::setCSSStyleSheet): Extend the change made in
<http://trac.webkit.org/changeset/48818> to detect the two variants of
KHTMLFixes.css in @import rules as well as in <link> elements.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBug 36052 - [Qt] REGRESSION(55878) 63 test cases crash
barraclough@apple.com [Fri, 12 Mar 2010 21:16:06 +0000 (21:16 +0000)]
Bug 36052 - [Qt] REGRESSION(55878) 63 test cases crash

Reviewed by Geoff Garen.

r55878 changed UStringImpl::empty()->characters() to be non-null,
so TextBreakIteratorQt.cpp now should check the length of strings
(previously was assuming all strings with a non-null data pointer
had a length of at least 1).

* platform/text/qt/TextBreakIteratorQt.cpp:
(WebCore::wordBreakIterator):
(WebCore::characterBreakIterator):
(WebCore::lineBreakIterator):
(WebCore::sentenceBreakIterator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-12 Garret Kelly <gdk@chromium.org>
abarth@webkit.org [Fri, 12 Mar 2010 21:15:02 +0000 (21:15 +0000)]
2010-03-12  Garret Kelly  <gdk@chromium.org>

        Unreiviewed.

        Fix Chromium Mac build. Last patch did not apply properly.
        (Garret assures me this patch will actually work.)

        * src/WebInputEventConversion.cpp:
        (WebKit::toPlatformTouchEventType):
        (WebKit::toPlatformTouchPointState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-12 Garret Kelly <gdk@chromium.org>
abarth@webkit.org [Fri, 12 Mar 2010 20:48:17 +0000 (20:48 +0000)]
2010-03-12  Garret Kelly  <gdk@chromium.org>

        Unreviewed.

        Fix Chromium Mac build. This time, with actual fixing goodness.

        * src/WebInputEventConversion.cpp:
        (WebKit::toPlatformTouchEventType):
        (WebKit::toPlatformTouchPointState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoExpose WebPDFView's underlying PDFDocument.
beidson@apple.com [Fri, 12 Mar 2010 20:47:27 +0000 (20:47 +0000)]
Expose WebPDFView's underlying PDFDocument.

Patch by Andy Estes <aestes@apple.com> on 2010-03-12
Reviewed by Brady Eidson.

https://bugs.webkit.org/show_bug.cgi?id=36045

* WebView/WebDocumentPrivate.h: Create a new protocol called
WebDocumentPDF.
* WebView/WebPDFView.h: Have WebPDFView implement said protocol.
* WebView/WebPDFView.mm:
(-[WebPDFView PDFDocument]): Expose WebPDFView's underlying
PDFDocument by implementing -(PDFDocument*)PDFDocument from
WebDocumentPDF.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-12 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Fri, 12 Mar 2010 20:43:59 +0000 (20:43 +0000)]
2010-03-12  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG fallback color doesn't work for bogus gradients.
        https://bugs.webkit.org/show_bug.cgi?id=35479

        Use a given fallback color on ignored gradients if present. Gradients
        must be ignored, if one dimension of the objects boundingBox is zero.

        Test: svg/custom/gradient-with-1d-boundingbox.svg

        * svg/graphics/SVGPaintServer.cpp:
        (WebCore::SVGPaintServer::strokePaintServer):
        * svg/graphics/SVGPaintServerGradient.cpp:
        (WebCore::SVGPaintServerGradient::setup):
2010-03-12  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG fallback color doesn't work for bogus gradients.
        https://bugs.webkit.org/show_bug.cgi?id=35479

        We now use a fallback color on ignored gradients for one dimensional objects,
        either a given fallback color or black as default.
        This causes a change of one LayoutTest, because it was done manually in the
        gradient PaintServer, without respecting a given fallback color.

        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.txt:
        * platform/mac/svg/custom/gradient-with-1d-boundingbox-expected.checksum: Added.
        * platform/mac/svg/custom/gradient-with-1d-boundingbox-expected.png: Added.
        * platform/mac/svg/custom/gradient-with-1d-boundingbox-expected.txt: Added.
        * svg/custom/gradient-with-1d-boundingbox.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-12 Garret Kelly <gdk@chromium.org>
abarth@webkit.org [Fri, 12 Mar 2010 20:36:17 +0000 (20:36 +0000)]
2010-03-12  Garret Kelly  <gdk@chromium.org>

        Unreviewed.

        Fix Chromium Mac build.

        * src/WebInputEventConversion.cpp:
        (WebKit::toPlatformTouchEventType):
        (WebKit::toPlatformTouchPointState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=36069
hyatt@apple.com [Fri, 12 Mar 2010 20:29:50 +0000 (20:29 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=36069

Reviewed by Dan Bernstein.

Eliminate InlineRunBox.

* WebCore.xcodeproj/project.pbxproj:
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::adjustPosition):
(WebCore::InlineFlowBox::paintFillLayer):
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):
* rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::InlineFlowBox):
(WebCore::InlineFlowBox::prevLineBox):
(WebCore::InlineFlowBox::nextLineBox):
(WebCore::InlineFlowBox::setNextLineBox):
(WebCore::InlineFlowBox::setPreviousLineBox):
* rendering/InlineRunBox.h: Removed.
* rendering/InlineTextBox.h:
(WebCore::InlineTextBox::InlineTextBox):
(WebCore::InlineTextBox::prevTextBox):
(WebCore::InlineTextBox::nextTextBox):
(WebCore::InlineTextBox::setNextTextBox):
(WebCore::InlineTextBox::setPreviousTextBox):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::destroy):
(WebCore::RenderBlock::rightmostPosition):
(WebCore::RenderBlock::leftmostPosition):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::destroy):
(WebCore::RenderInline::absoluteRects):
(WebCore::RenderInline::absoluteQuads):
(WebCore::RenderInline::linesBoundingBox):
(WebCore::RenderInline::linesVisibleOverflowBoundingBox):
(WebCore::RenderInline::addFocusRingRects):
(WebCore::RenderInline::paintOutline):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::localBoundingBox):
* rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::deleteLineBoxTree):
(WebCore::RenderLineBoxList::extractLineBox):
(WebCore::RenderLineBoxList::attachLineBox):
(WebCore::RenderLineBoxList::removeLineBox):
(WebCore::RenderLineBoxList::deleteLineBoxes):
(WebCore::RenderLineBoxList::dirtyLineBoxes):
(WebCore::RenderLineBoxList::paint):
(WebCore::RenderLineBoxList::hitTest):
(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
(WebCore::RenderLineBoxList::checkConsistency):
* rendering/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::absoluteRects):
(WebCore::RenderSVGInline::absoluteQuads):
* rendering/RenderSVGText.cpp:
(WebCore::RenderSVGText::absoluteRects):
(WebCore::RenderSVGText::absoluteQuads):
(WebCore::RenderSVGText::objectBoundingBox):
* rendering/RenderText.cpp:
(WebCore::RenderText::extractTextBox):
(WebCore::RenderText::attachTextBox):
(WebCore::RenderText::removeTextBox):
(WebCore::RenderText::createInlineTextBox):
(WebCore::RenderText::positionLineBox):
* rendering/RootInlineBox.h:
(WebCore::RootInlineBox::nextRootBox):
(WebCore::RootInlineBox::prevRootBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Fri, 12 Mar 2010 20:11:06 +0000 (20:11 +0000)]
2010-03-12  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Eric Carlson.

        media/video-preload.html fails
        https://bugs.webkit.org/show_bug.cgi?id=35793

        Only effectively load, and start buffering when playing, or when
        the preload attribute is set.

        Test: media/video-preload.html

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
        (WebCore::MediaPlayerPrivate::load):
        (WebCore::MediaPlayerPrivate::commitLoad):
        (WebCore::MediaPlayerPrivate::prepareToPlay):
        (WebCore::MediaPlayerPrivate::setPreload):
        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNot reviewed, build fix.
dimich@chromium.org [Fri, 12 Mar 2010 20:06:17 +0000 (20:06 +0000)]
Not reviewed, build fix.

Reverts 55920 and 55921. Landing for Jian Li.

WebCore:

* Android.derived.jscbindings.mk:
* Android.derived.v8bindings.mk:
* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pri:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMFormDataCustom.cpp: Removed.
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::send):
* bindings/scripts/CodeGeneratorJS.pm:
* bindings/v8/V8Index.h:
* bindings/v8/custom/V8DOMFormDataCustom.cpp: Removed.
* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::sendCallback):
* html/DOMFormData.idl: Removed.
* page/DOMWindow.idl:

LayoutTests:

* fast/dom/Window/window-properties-expected.txt:
* fast/dom/Window/window-property-descriptors-expected.txt:
* fast/dom/constructed-objects-prototypes-expected.txt:
* fast/dom/prototype-inheritance-2-expected.txt:
* fast/dom/prototype-inheritance-expected.txt:
* fast/js/global-constructors-expected.txt:
* http/tests/local/resources/send-form-data.js: Removed.
* http/tests/local/send-form-data-expected.txt: Removed.
* http/tests/local/send-form-data.html: Removed.
* http/tests/xmlhttprequest/resources/multipart-post-echo.php: Removed.
* platform/gtk/Skipped:
* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/qt/Skipped:
* platform/qt/fast/dom/Window/window-properties-expected.txt:
* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/qt/fast/dom/prototype-inheritance-expected.txt:
* platform/qt/fast/js/global-constructors-expected.txt:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Fri, 12 Mar 2010 20:03:52 +0000 (20:03 +0000)]
2010-03-12  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Fix critical being printed to stderr on every test. This is
        because the jar is only being created when soup hits the HTTP
        path. We should reconsider the time of its creation.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (resetDefaultsToConsistentValues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake the timeout in 'snav-unit-overflow-and-scroll-in-direction.html' 10x shorter...
tonikitoo@webkit.org [Fri, 12 Mar 2010 19:57:39 +0000 (19:57 +0000)]
Make the timeout in 'snav-unit-overflow-and-scroll-in-direction.html' 10x shorter (from 500ms to 50ms)

Rubber-stamped by Kenneth Christiansen.
Patch by Antonio Gomes <tonikitoo@webkit.org>

* fast/events/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-12 Jakob Petsovits <jpetsovits@rim.com>
jpetsovits@rim.com [Fri, 12 Mar 2010 19:45:13 +0000 (19:45 +0000)]
2010-03-12  Jakob Petsovits  <jpetsovits@rim.com>

        Reviewed by Dirk Schulze.

        [OpenVG] Add support for drawing text to PainterOpenVG
        https://bugs.webkit.org/show_bug.cgi?id=35581

        Doesn't come with any actual font classes, as OpenVG
        by itself doesn't provide any access to platform fonts
        but just the means to draw glyphs that have been loaded
        manually before.

        * platform/graphics/openvg/PainterOpenVG.cpp:
        (WebCore::PlatformPainterState::PlatformPainterState):
        (WebCore::PlatformPainterState::copyPaintState):
        (WebCore::PainterOpenVG::textDrawingMode):
        (WebCore::PainterOpenVG::setTextDrawingMode):
        (WebCore::PainterOpenVG::drawText):
        * platform/graphics/openvg/PainterOpenVG.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-12 Jakob Petsovits <jpetsovits@rim.com>
jpetsovits@rim.com [Fri, 12 Mar 2010 19:25:32 +0000 (19:25 +0000)]
2010-03-12  Jakob Petsovits  <jpetsovits@rim.com>

        Reviewed by Dirk Schulze.

        [OpenVG] Use masks to implement non-rectilinear clipping
        https://bugs.webkit.org/show_bug.cgi?id=35544

        Requires some additional context switching logic to
        make sure the right context is current when dealing
        with the mask, because we don't store it by ourselves.

        Initial version of this code was written by
        Eli Fidler <efidler@rim.com>, I did a couple of
        bug fixes and efficiency improvements since then.

        * platform/graphics/openvg/GraphicsContextOpenVG.cpp:
        (WebCore::GraphicsContext::clipPath):
        (WebCore::GraphicsContext::clip):
        (WebCore::GraphicsContext::clipOut):
        (WebCore::GraphicsContext::clipOutEllipseInRect):
        (WebCore::GraphicsContext::addInnerRoundedRectClip):
        * platform/graphics/openvg/PainterOpenVG.cpp:
        (WebCore::PlatformPainterState::PlatformPainterState):
        (WebCore::PlatformPainterState::~PlatformPainterState):
        (WebCore::PlatformPainterState::maskingEnabled):
        (WebCore::PlatformPainterState::applyState):
        (WebCore::PlatformPainterState::saveMaskIfNecessary):
        (WebCore::PainterOpenVG::intersectClipRect):
        (WebCore::PainterOpenVG::clipPath):
        (WebCore::PainterOpenVG::save):
        * platform/graphics/openvg/PainterOpenVG.h:
        (WebCore::PainterOpenVG::):
        * platform/graphics/openvg/SurfaceOpenVG.cpp:
        (WebCore::SurfaceOpenVG::makeCurrent):
        (WebCore::SurfaceOpenVG::makeCompatibleCurrent):
        * platform/graphics/openvg/SurfaceOpenVG.h:
        (WebCore::SurfaceOpenVG::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[v8] Add V8 bindings for DOMFormData.
jianli@chromium.org [Fri, 12 Mar 2010 19:17:21 +0000 (19:17 +0000)]
[v8] Add V8 bindings for DOMFormData.
https://bugs.webkit.org/show_bug.cgi?id=36026

Reviewed by Nate Chapin.

Test: http/tests/local/send-form-data.html

* WebCore.gypi:
* bindings/v8/V8Index.h:
* bindings/v8/custom/V8DOMFormDataCustom.cpp: Added.
(WebCore::V8DOMFormData::appendCallback):
* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::sendCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Add DOMFormData.idl to expose FormData interface.
jianli@chromium.org [Fri, 12 Mar 2010 19:17:14 +0000 (19:17 +0000)]
WebCore: Add DOMFormData.idl to expose FormData interface.
https://bugs.webkit.org/show_bug.cgi?id=36024

Reviewed by Sam Weinig.

The implementation is based on XMLHttpRequest 2 spec:
http://dev.w3.org/2006/webapi/XMLHttpRequest-2/#formdata

Test: http/tests/local/send-form-data.html

* Android.derived.jscbindings.mk:
* Android.derived.v8bindings.mk:
* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.pri:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMFormDataCustom.cpp: Added.
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::send):
* bindings/scripts/CodeGeneratorJS.pm:
* html/DOMFormData.idl: Added.
* page/DOMWindow.idl:

LayoutTests: Add DOMFormData.idl to expose FormData interface
https://bugs.webkit.org/show_bug.cgi?id=36024

Reviewed by Sam Weinig.

Add a layout test to test sending FormData via XMLHttpRequest. Also
changed all test results that are affected by exposing FormData.

* fast/dom/Window/window-properties-expected.txt:
* fast/dom/Window/window-property-descriptors-expected.txt:
* fast/dom/constructed-objects-prototypes-expected.txt:
* fast/dom/prototype-inheritance-2-expected.txt:
* fast/dom/prototype-inheritance-expected.txt:
* fast/js/global-constructors-expected.txt:
* http/tests/local/resources/send-form-data.js: Added.
* http/tests/local/send-form-data-expected.txt: Added.
* http/tests/local/send-form-data.html: Added.
* http/tests/xmlhttprequest/resources/multipart-post-echo.php: Added.
* platform/gtk/Skipped:
* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/qt/Skipped:
* platform/qt/fast/dom/Window/window-properties-expected.txt:
* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/qt/fast/dom/prototype-inheritance-expected.txt:
* platform/qt/fast/js/global-constructors-expected.txt:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-12 Jakob Petsovits <jpetsovits@rim.com>
jpetsovits@rim.com [Fri, 12 Mar 2010 19:11:28 +0000 (19:11 +0000)]
2010-03-12  Jakob Petsovits  <jpetsovits@rim.com>

        Reviewed by Dirk Schulze.

        [OpenVG] Add a SurfaceOpenVG constructor for EGL client buffer surfaces
        https://bugs.webkit.org/show_bug.cgi?id=35538

        SurfaceOpenVG can now not only encapsulate pbuffer
        and window surfaces but also VGImage-based ones.

        * platform/graphics/openvg/EGLDisplayOpenVG.cpp:
        (WebCore::EGLDisplayOpenVG::createPbufferFromClientBuffer):
        * platform/graphics/openvg/EGLDisplayOpenVG.h:
        * platform/graphics/openvg/SurfaceOpenVG.cpp:
        (WebCore::SurfaceOpenVG::SurfaceOpenVG):
        * platform/graphics/openvg/SurfaceOpenVG.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTeach prepare-ChangeLog to find modified selectors in CSS files
aroben@apple.com [Fri, 12 Mar 2010 19:06:01 +0000 (19:06 +0000)]
Teach prepare-ChangeLog to find modified selectors in CSS files

Reviewed by Tim Hatcher.

Fixes <http://webkit.org/b/36064> prepare-ChangeLog should extract
modified selectors from CSS files

* Scripts/prepare-ChangeLog:
(get_function_line_ranges): Call get_selector_line_ranges_for_css for
.css files.
(get_selector_line_ranges_for_css): Added. Finds selectors and their
line ranges and returns them.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-12 Alpha Lam <hclam@chromium.org>
eric@webkit.org [Fri, 12 Mar 2010 19:03:06 +0000 (19:03 +0000)]
2010-03-12  Alpha Lam  <hclam@chromium.org>

        Reviewed by Eric Carlson.

        HTMLMediaElement crash when it is used after resource loading is canceled.
        https://bugs.webkit.org/show_bug.cgi?id=35992

        Adding a test to access the duration property of a video element after
        resource loading was canceled.

        * http/tests/media/video-cancel-load-expected.txt: Added.
        * http/tests/media/video-cancel-load.html: Added.
2010-03-12  Alpha Lam  <hclam@chromium.org>

        Reviewed by Eric Carlson.

        Fix a crash when resource loading of media element is canceled.
        https://bugs.webkit.org/show_bug.cgi?id=35992

        Use of HTMLMediaElement::duration() after resource loading was canceled
        will cause a crash. This is because HTMLMediaElement::m_player is used
        when NULL.
        Test: http/tests/media/video-cancel-load.html

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::duration):
        Avoid calling to m_player when it is null.
        (WebCore::HTMLMediaElement::userCancelledLoad):
        Set m_readyState to HAVE_NOTHING.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-12 Garret Kelly <gdk@chromium.org>
eric@webkit.org [Fri, 12 Mar 2010 18:45:38 +0000 (18:45 +0000)]
2010-03-12  Garret Kelly  <gdk@chromium.org>

        Reviewed by Eric Seidel.

        Enable touch events in Chromium features gypi file.
        https://bugs.webkit.org/show_bug.cgi?id=35994

        * features.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Fri, 12 Mar 2010 18:36:58 +0000 (18:36 +0000)]
2010-03-12  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Rubber-stamped by Kenneth Rohde Christiansen.

        Misc documentation fixes. Fixes (almost) all warnings emitted by
        the documentation build process. Only the broken references to JSC
        objects remain.

        * webkit/webkitsecurityorigin.cpp:
        * webkit/webkitwebbackforwardlist.cpp:
        * webkit/webkitwebdatasource.cpp:
        * webkit/webkitwebframe.cpp:
        * webkit/webkitwebhistoryitem.cpp:
        * webkit/webkitwebinspector.cpp:
        (webkit_web_inspector_class_init):
        * webkit/webkitwebsettings.cpp:
        (webkit_web_settings_class_init):
        * webkit/webkitwebview.cpp:
        (DNDContentsRequest::webkit_web_view_class_init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/7725534> CSSPrimitiveValue::parserValue() returns deleted memory
mitz@apple.com [Fri, 12 Mar 2010 18:28:56 +0000 (18:28 +0000)]
<rdar://problem/7725534> CSSPrimitiveValue::parserValue() returns deleted memory
https://bugs.webkit.org/show_bug.cgi?id=20069

Reviewed by Darin Adler.

No test added, since with the CSS variables feature disabled, the pointer
to the freed memory is never dereferenced.

* css/CSSPrimitiveValue.cpp:
(WebCore::valueOrPropertyName): Changed to return a const AtomicString& from
a static table.
(WebCore::CSSPrimitiveValue::parserValue): Updated for the above change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-05 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Fri, 12 Mar 2010 18:18:40 +0000 (18:18 +0000)]
2010-03-05  Ojan Vafai  <ojan@chromium.org>

        Reviewed by David Levin.

        Tests for smartdelete should only occur after double-click
        https://bugs.webkit.org/show_bug.cgi?id=35314

        Fixes the tests to make selections using the mouse in order
        to force smart-delete. It also adds/modifies tests to have them correctly
        identify cases where we are smart-deleting, but shouldn't be.

        Fixing to smart-delete only on mouse-based selections will be a followup patch.

        * editing/deleting/5390681-2.html:
        * editing/deleting/non-smart-delete.html: Added.
        * editing/deleting/smart-delete-001.html:
        * editing/deleting/smart-delete-002.html:
        * editing/deleting/smart-delete-003.html:
        * editing/deleting/smart-delete-004.html:
        * editing/editing.js:
        (doubleClick):
        (doubleClickAtSelectionStart):
        * editing/pasteboard/4944770-2.html:
        * editing/pasteboard/drag-drop-modifies-page.html:
        * editing/pasteboard/smart-drag-drop.html: Added.
        * editing/pasteboard/smart-paste-001.html:
        * editing/pasteboard/smart-paste-002.html:
        * editing/pasteboard/smart-paste-003.html:
        * editing/pasteboard/smart-paste-004.html:
        * editing/pasteboard/smart-paste-005.html:
        * editing/pasteboard/smart-paste-007.html:
        * editing/pasteboard/smart-paste-008.html:
        * editing/selection/delete-word-granularity-text-control-expected.txt: Added.
        * editing/selection/delete-word-granularity-text-control.html: Added.
        * editing/selection/script-tests/delete-word-granularity-text-control.js: Added.
        * editing/style/style-boundary-005.html:
        * platform/mac/editing/deleting/non-smart-delete-expected.checksum: Added.
        * platform/mac/editing/deleting/non-smart-delete-expected.png: Added.
        * platform/mac/editing/deleting/non-smart-delete-expected.txt: Added.
        * platform/mac/editing/deleting/smart-delete-001-expected.txt:
        * platform/mac/editing/deleting/smart-delete-002-expected.txt:
        * platform/mac/editing/deleting/smart-delete-003-expected.txt:
        * platform/mac/editing/deleting/smart-delete-004-expected.txt:
        * platform/mac/editing/pasteboard/drag-drop-modifies-page-expected.checksum:
        * platform/mac/editing/pasteboard/drag-drop-modifies-page-expected.png:
        * platform/mac/editing/pasteboard/drag-drop-modifies-page-expected.txt:
        * platform/mac/editing/pasteboard/smart-drag-drop-expected.checksum: Added.
        * platform/mac/editing/pasteboard/smart-drag-drop-expected.png: Added.
        * platform/mac/editing/pasteboard/smart-drag-drop-expected.txt: Added.
        * platform/mac/editing/pasteboard/smart-paste-001-expected.txt:
        * platform/mac/editing/pasteboard/smart-paste-002-expected.txt:
        * platform/mac/editing/pasteboard/smart-paste-003-expected.txt:
        * platform/mac/editing/pasteboard/smart-paste-004-expected.txt:
        * platform/mac/editing/pasteboard/smart-paste-005-expected.txt:
        * platform/mac/editing/pasteboard/smart-paste-007-expected.txt:
        * platform/mac/editing/pasteboard/smart-paste-008-expected.txt:
        * platform/mac/editing/style/style-boundary-005-expected.checksum:
        * platform/mac/editing/style/style-boundary-005-expected.png:
        * platform/mac/editing/style/style-boundary-005-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55913 268f45cc-cd09-0410-ab3c-d52691b4dbfc