WebKit-https.git
9 years ago2011-01-27 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Fri, 28 Jan 2011 00:58:02 +0000 (00:58 +0000)]
2011-01-27  Stephen White  <senorblanco@chromium.org>

        Reviewed by Darin Adler.

        Fix performance regression in ImageQualityController::objectDestroyed().
        https://bugs.webkit.org/show_bug.cgi?id=52645

        In r72282, I inadvertently introduced this regression by using a
        linear search through the hash map on object destruction.  This was
        because the hash key consisted of both object pointer and layer id,
        but on object destruction we only know the object pointer, requiring
        a search to find all the layers.
        By replacing the hash map with two nested hash maps, where the outer key
        is the object and the inner key is the layer, we can find all the
        relevant data for an object in one hash lookup.

        * rendering/RenderBoxModelObject.cpp:
        Replace the (object,layer)->size HashMap with object->layer and
        layer->size HashMaps.
        (WebCore::ImageQualityController::isEmpty):
        Implement isEmpty() for the outer HashMap.
        (WebCore::ImageQualityController::removeLayer):
        When a layer is removed, remove it from the inner hash map.
        (WebCore::ImageQualityController::set):
        Implement set():  if the inner map exists, set the layer->size tuple
        directly.  If not, create a new inner map, set the tuple, and insert
        it in the outer map.
        (WebCore::ImageQualityController::objectDestroyed):
        Look up the object in the outer map only.
        (WebCore::ImageQualityController::highQualityRepaintTimerFired):
        Cosmetic changes for the renamed now-outer hash map.
        (WebCore::ImageQualityController::shouldPaintAtLowQuality):
        Do both outer and inner hash map lookups.  Call set() to add/update
        entries to the hash maps.  keyDestroyed() is now removeLayer().
        (WebCore::imageQualityController):
        Make the ImageQualityController a file-static global, so it can be
        created and destroyed on the fly.
        (WebCore::RenderBoxModelObject::~RenderBoxModelObject):
        If there is no ImageQualityController, don't call objectDestroyed().
        If it's empty, delete it.
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::paintIntoRect):
        Also pass the Image* as the (void*) layer, since 0 is not a valid
        HashMap key.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Adrienne Walker <enne@google.com>
enne@google.com [Fri, 28 Jan 2011 00:50:34 +0000 (00:50 +0000)]
2011-01-27  Adrienne Walker  <enne@google.com>

        Reviewed by James Robinson.

        [chromium] Tiled compositor crashes if compositing turned off mid-paint
        https://bugs.webkit.org/show_bug.cgi?id=53198

        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::drawLayers):
        * platform/graphics/chromium/LayerTilerChromium.cpp:
        (WebCore::LayerTilerChromium::update):
        (WebCore::LayerTilerChromium::draw):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Zhenyao Mo <zmo@google.com>
zmo@google.com [Fri, 28 Jan 2011 00:49:36 +0000 (00:49 +0000)]
2011-01-27  Zhenyao Mo  <zmo@google.com>

        Unreviewed, roll webkit chromium rev from 72673 to 72894.
        Also, added gmock section in DEPS to pull down gmock.

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Alexey Marinichev <amarinichev@chromium.org>
commit-queue@webkit.org [Fri, 28 Jan 2011 00:36:18 +0000 (00:36 +0000)]
2011-01-27  Alexey Marinichev  <amarinichev@chromium.org>

        Reviewed by Kenneth Russell.

        Add a callback to WebGraphicsContext3D that is called when a context is lost
        https://bugs.webkit.org/show_bug.cgi?id=53153

        * public/WebGraphicsContext3D.h:
        (WebKit::WebGraphicsContext3D::setContextLostCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Jacob Dinu <dinu.jacob@nokia.com>
commit-queue@webkit.org [Fri, 28 Jan 2011 00:21:55 +0000 (00:21 +0000)]
2011-01-27  Jacob Dinu  <dinu.jacob@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView
        https://bugs.webkit.org/show_bug.cgi?id=48440

        Preserve user input when toggling use of QGraphicsView

        * QtTestBrowser/launcherwindow.cpp:
        (LauncherWindow::initializeView):
        (LauncherWindow::loadFinished):
        * QtTestBrowser/launcherwindow.h:
        * QtTestBrowser/mainwindow.cpp:
        (MainWindow::addressUrl):
        * QtTestBrowser/mainwindow.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Carol Szabo <carol.szabo@nokia.com>
carol.szabo@nokia.com [Fri, 28 Jan 2011 00:14:16 +0000 (00:14 +0000)]
2011-01-27  Carol Szabo <carol.szabo@nokia.com>

        Reviewed by David Hyatt.

        A corrupted counter tree is created when renderers are added to the
        tree bypassing RenderObject::addChild
        https://bugs.webkit.org/show_bug.cgi?id=51270

        No new tests. This patch reimplements the fix for bugs 43812 and
        51637 and hence all tests are already there as part of the original
        fixes for those bugs.

        * rendering/RenderCounter.cpp:
        (WebCore::findPlaceForCounter):
        Removed old workaround as this patch hopefully fixes the real
        problem.
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::addChild):
        Removed call to counter updater as it was moved to a lower level.
        (WebCore::RenderObject::destroy):
        Moved attached counter nodes destruction to after the node is
        removed from the tree.
        * rendering/RenderObjectChildList.cpp:
        (WebCore::RenderObjectChildList::removeChildNode):
        (WebCore::RenderObjectChildList::appendChildNode):
        (WebCore::RenderObjectChildList::insertChildNode):
        Added notifications to the Counter system such that the
        CounterForest reflects the changes to the RendererTree.
        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::destroy):
        Applied the same changes as for RenderObject::destroy()
        since RenderObject::destroy() is not called from here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd WKCACFViewLayerTreeHost
aroben@apple.com [Thu, 27 Jan 2011 23:40:41 +0000 (23:40 +0000)]
Add WKCACFViewLayerTreeHost

This is a class that derives from CACFLayerTreeHost and uses a WKCACFView to render.

Fixes <http://webkit.org/b/53251> <rdar://problem/8925496> CACFLayerTreeHost should use
WKCACFView for rendering

* WebCore.vcproj/WebCore.vcproj: Added WKCACFViewLayerTreeHost.{cpp,h}.

* platform/graphics/ca/win/CACFLayerTreeHost.cpp:
(WebCore::CACFLayerTreeHost::acceleratedCompositingAvailable): Make the test window have a
non-zero size. WKCACFView will always say it can't render if you pass it a 0-sized window,
so we need a non-empty window to perform a valid test.
(WebCore::CACFLayerTreeHost::create): First try to create a WKCACFViewLayerTreeHost, then
fall back to a LegacyCACFLayerTreeHost.
(WebCore::CACFLayerTreeHost::flushPendingLayerChangesNow): Moved code to react to the
context flush from here...
(WebCore::CACFLayerTreeHost::contextDidChange): ...to here. Derived classes are required to
call this function whenever changes are flushed to the context.

* platform/graphics/ca/win/CACFLayerTreeHost.h: Added contextDidChange.

* platform/graphics/ca/win/LegacyCACFLayerTreeHost.cpp:
(WebCore::LegacyCACFLayerTreeHost::createRenderer):
(WebCore::LegacyCACFLayerTreeHost::resize):
Changed to use flushContext instead of flushing the context manually so that we will always
notify the base class when the context gets flushed.

(WebCore::LegacyCACFLayerTreeHost::flushContext): Added a call to contextDidChange so the
base class will know what happened. Moved code to schedule a render from here...
(WebCore::LegacyCACFLayerTreeHost::contextDidChange): ...to here.

* platform/graphics/ca/win/LegacyCACFLayerTreeHost.h: Added contextDidChange.

* platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp: Added.
(WebCore::WKCACFViewLayerTreeHost::create): If WebKitQuartzCoreAdditions, which provides
WKCACFView, isn't present, bail. Otherwise allocate and return a new host.
(WebCore::WKCACFViewLayerTreeHost::WKCACFViewLayerTreeHost): Initialize members.
(WebCore::WKCACFViewLayerTreeHost::updateViewIfNeeded): Update the view if we previously
marked that we needed to do so, and flush the context if our layer's bounds have changed.
(WebCore::WKCACFViewLayerTreeHost::contextDidChangeCallback): Call through to
contextDidChange.
(WebCore::WKCACFViewLayerTreeHost::contextDidChange): Tell the WKCACFView to start rendering
(if we didn't already), then call up to the base class.
(WebCore::WKCACFViewLayerTreeHost::initializeContext): Set the context's user data, the
view's layer, and hook up our "context did change" callback.
(WebCore::WKCACFViewLayerTreeHost::resize): Mark that the view needs to be updated the next
time we paint.
(WebCore::WKCACFViewLayerTreeHost::createRenderer): Update our view and return whether it is
able to render or not.
(WebCore::WKCACFViewLayerTreeHost::destroyRenderer): Clear out all the info we passed down
to the view.
(WebCore::WKCACFViewLayerTreeHost::lastCommitTime): Call through to the view.
(WebCore::WKCACFViewLayerTreeHost::flushContext): Ditto.
(WebCore::WKCACFViewLayerTreeHost::paint): Update the view so it will draw at the right
size, then call up to the base class.
(WebCore::WKCACFViewLayerTreeHost::render): Invalidate the view using the passed-in dirty
rects, then ask it to draw.

* platform/graphics/ca/win/WKCACFViewLayerTreeHost.h: Copied from Source/WebCore/platform/graphics/ca/win/LegacyCACFLayerTreeHost.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove LegacyCACFLayerTreeHost into its own files
aroben@apple.com [Thu, 27 Jan 2011 23:39:50 +0000 (23:39 +0000)]
Move LegacyCACFLayerTreeHost into its own files

More preparation for <http://webkit.org/b/53251> <rdar://problem/8925496> CACFLayerTreeHost

Reviewed by Simon Fraser.

* WebCore.vcproj/WebCore.vcproj: Added LegacyCACFLayerTreeHost.{cpp,h}.

* platform/graphics/ca/win/CACFLayerTreeHost.cpp: Moved code from here to new files.

* platform/graphics/ca/win/LegacyCACFLayerTreeHost.cpp: Added.
* platform/graphics/ca/win/LegacyCACFLayerTreeHost.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Thu, 27 Jan 2011 23:33:35 +0000 (23:33 +0000)]
2011-01-27  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed, fixed upstream Chromium build

        r76844 should have rolled back Chromium DEPS to 72673, not 72637.

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Thu, 27 Jan 2011 23:29:51 +0000 (23:29 +0000)]
2011-01-27  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed WinCE build fix for r76824.

        * platform/wince/DragDataWinCE.cpp:
        (WebCore::DragData::dragDataMap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSplit CACFLayerTreeHost into base and derived classes
aroben@apple.com [Thu, 27 Jan 2011 23:26:27 +0000 (23:26 +0000)]
Split CACFLayerTreeHost into base and derived classes

The derived class, LegacyCACFLayerTreeHost, contains all the D3D-related code. A later patch
will add a new derived class that replaces the D3D code with a different rendering API.

For now, LegacyCACFLayerTreeHost lives in CACFLayerTreeHost.cpp. This keeps the diff a
little smaller. A later patch will move it to its own source files.

Preparation for <http://webkit.org/b/53251> <rdar://problem/8925496> CACFLayerTreeHost
should use WKCACFView for rendering

Reviewed by Simon Fraser.

* platform/graphics/ca/win/CACFLayerTreeHost.cpp:
(WebCore::CACFLayerTreeHost::acceleratedCompositingAvailable): Clear the window before
destroying the host, as that is now the API contract that clients must fulfill.
(WebCore::LegacyCACFLayerTreeHost::create): Added. Simple creator.
(WebCore::CACFLayerTreeHost::create): Now instantiates a LegacyCACFLayerTreeHost. Calls the
new initialize function to perform initialization that has to happen after the vtable has
been set up.

(WebCore::LegacyCACFLayerTreeHost::LegacyCACFLayerTreeHost):
(WebCore::CACFLayerTreeHost::CACFLayerTreeHost):
(WebCore::LegacyCACFLayerTreeHost::initializeContext):
(WebCore::CACFLayerTreeHost::initialize):
Moved some initialization code from the CACFLayerTreeHost constructor into these new
functions.

(WebCore::LegacyCACFLayerTreeHost::~LegacyCACFLayerTreeHost): Added. Moved code here from
~CACFLayerTreeHost.
(WebCore::CACFLayerTreeHost::~CACFLayerTreeHost): Rather than clearing the window at this
point (which would be too late, since we won't be able to call into the derived class's
virtual functions), just assert that it has already been cleared (or was never set in the
first place).
(WebCore::LegacyCACFLayerTreeHost::createRenderer): Renamed from
CACFLayerTreeHost::createRenderer, and changed to use getters instead of accessing
CACFLayerTreeHost's data members directly.

(WebCore::LegacyCACFLayerTreeHost::destroyRenderer):
(WebCore::CACFLayerTreeHost::destroyRenderer):
Moved some code to the new LegacyCACFLayerTreeHost function.

(WebCore::LegacyCACFLayerTreeHost::resize):
(WebCore::LegacyCACFLayerTreeHost::renderTimerFired):
Moved these functions to LegacyCACFLayerTreeHost.

(WebCore::LegacyCACFLayerTreeHost::paint):
(WebCore::CACFLayerTreeHost::paint):
Moved some code to the new LegacyCACFLayerTreeHost function.

(WebCore::LegacyCACFLayerTreeHost::render):
(WebCore::LegacyCACFLayerTreeHost::renderSoon):
Moved these functions to LegacyCACFLayerTreeHost.

(WebCore::CACFLayerTreeHost::flushPendingLayerChangesNow): Moved code to flush the context
from here...
(WebCore::LegacyCACFLayerTreeHost::flushContext): ...to this new function.

(WebCore::LegacyCACFLayerTreeHost::lastCommitTime): Moved code to get the last commit time
to this new function...
(WebCore::CACFLayerTreeHost::notifyAnimationsStarted): ...from here.

(WebCore::LegacyCACFLayerTreeHost::initD3DGeometry):
(WebCore::LegacyCACFLayerTreeHost::resetDevice):
Moved these functions to LegacyCACFLayerTreeHost.

* platform/graphics/ca/win/CACFLayerTreeHost.h: Made some functions virtual, removed some
members that have moved to LegacyCACFLayerTreeHost, added some getters used by
LegacyCACFLayerTreeHost.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove CACFLayerTreeHostClient to its own header file
aroben@apple.com [Thu, 27 Jan 2011 23:25:22 +0000 (23:25 +0000)]
Move CACFLayerTreeHostClient to its own header file

Rubber-stamped by Steve Falkenburg.

Source/WebCore:

* WebCore.vcproj/WebCore.vcproj: Added CACFLayerTreeHostClient.h. Also let VS have its way
with the file.

* platform/graphics/ca/win/CACFLayerTreeHost.cpp: Added new #include.

* platform/graphics/ca/win/CACFLayerTreeHost.h: Removed CACFLayerTreeHostClient.

* platform/graphics/ca/win/CACFLayerTreeHostClient.h: Added.

* platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp: Moved some #includes here
from the header file.

* platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h: Replaced broader #includes
with more specific ones, plus a forward-declaration.

Source/WebKit/win:

Trim down #includes in WebView.h

* WebView.cpp: Moved some #includes here from the header file.

* WebView.h: Replaced some broader #includes with more specific ones, plus a
forward-declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Thu, 27 Jan 2011 23:20:56 +0000 (23:20 +0000)]
2011-01-27  Dirk Schulze  <krit@webkit.org>

        Unreviewed rebaseline.

        SVG animation of Paths with segments of different coordinate modes on begin and end
        https://bugs.webkit.org/show_bug.cgi?id=52984

        Rebaseline for SL. HTML were created by make-script-test-wrappers now.
        Skip added tests on WebKit2 because of missing eventSender.

        * platform/mac-wk2/Skipped:
        * svg/animations/animate-path-nested-transforms-expected.txt:
        * svg/animations/animate-text-nested-transforms-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 James Simonsen <simonjam@chromium.org>
simonjam@chromium.org [Thu, 27 Jan 2011 23:03:04 +0000 (23:03 +0000)]
2011-01-27  James Simonsen  <simonjam@chromium.org>

        Reviewed by Tony Chang.

        [Chromium] Simplify small caps logic in complex text on linux
        https://bugs.webkit.org/show_bug.cgi?id=53207

        Test: fast/text/atsui-multiple-renderers.html
              fast/text/atsui-small-caps-punctuation-size.html

        * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
        (WebCore::ComplexTextController::nextScriptRun): Remove redundant logic. Case changes in a text run imply FontData changes.
        (WebCore::ComplexTextController::setupFontForScriptRun): Update comment to reflect above.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Zhenyao Mo <zmo@google.com>
zmo@google.com [Thu, 27 Jan 2011 22:59:34 +0000 (22:59 +0000)]
2011-01-27  Zhenyao Mo  <zmo@google.com>

        Unreviewed, roll back webkit chromium rev to 72637.

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 27 Jan 2011 22:50:53 +0000 (22:50 +0000)]
2011-01-27  Adam Barth  <abarth@webkit.org>

        In which I attempt to fix the EFL build.

        * CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Thu, 27 Jan 2011 22:43:05 +0000 (22:43 +0000)]
2011-01-27  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium rebaseline for fast/text/text-letter-spacing.html
        with changes matching the mac ones done by r76739.

        * platform/chromium-win/fast/text/text-letter-spacing-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Zhenyao Mo <zmo@google.com>
zmo@google.com [Thu, 27 Jan 2011 22:38:38 +0000 (22:38 +0000)]
2011-01-27  Zhenyao Mo  <zmo@google.com>

        Unreviewed.

        Roll Webkit Chromium rev from 72637 to 72868.

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-25 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Thu, 27 Jan 2011 22:38:10 +0000 (22:38 +0000)]
2011-01-25  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Darin Adler.

        Updating the expected result for 5408255 and adding tests for caret positioning at the
        beginning and end of RenderBoxes.

        Undo moves caret to invalid position
        https://bugs.webkit.org/show_bug.cgi?id=49744

        * editing/selection/caret-painting-after-paste-undo-rtl.html: Added.
        * editing/selection/caret-painting-after-paste-undo.html: Added.
        * platform/mac/editing/deleting/5408255-expected.png:
        * platform/mac/editing/selection/caret-painting-after-paste-undo-expected.checksum: Added.
        * platform/mac/editing/selection/caret-painting-after-paste-undo-expected.png: Added.
        * platform/mac/editing/selection/caret-painting-after-paste-undo-expected.txt: Added.
        * platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.checksum: Added.
        * platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.png: Added.
        * platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.txt: Added.
2011-01-25  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Darin Adler.

        Adding border and padding to the calculation of the local caret rect for RenderBoxes.
        Corrected for mistake in r76625

        Undo moves caret to invalid position
        https://bugs.webkit.org/show_bug.cgi?id=49744

        Tests: editing/selection/caret-painting-after-paste-undo-rtl.html
               editing/selection/caret-painting-after-paste-undo.html

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::localCaretRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 27 Jan 2011 22:30:52 +0000 (22:30 +0000)]
2011-01-27  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Chromium rebaseline and text expectation update.

        * platform/chromium-linux/fast/repaint/select-option-background-color-expected.checksum: Added.
        * platform/chromium-linux/fast/repaint/select-option-background-color-expected.png: Added.
        * platform/chromium-linux/fast/repaint/select-option-background-color-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Thu, 27 Jan 2011 22:13:08 +0000 (22:13 +0000)]
2011-01-27  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed rebaseline of fast/inline/continuation-outlines-with-layers.html
        afte r76726.

        * platform/mac/fast/inline/continuation-outlines-with-layers-expected.txt:
        * platform/chromium-win/fast/inline/continuation-outlines-with-layers-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Sheriff Bot <webkit.review.bot@gmail.com>
rniwa@webkit.org [Thu, 27 Jan 2011 22:02:02 +0000 (22:02 +0000)]
2011-01-27  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r76825.
        http://trac.webkit.org/changeset/76825
        https://bugs.webkit.org/show_bug.cgi?id=53256

        "caused crashes on GTK and chromium" (Requested by rniwa on
        #webkit).

        * rendering/RenderBoxModelObject.cpp:
        (WebCore::ImageQualityController::keyDestroyed):
        (WebCore::ImageQualityController::objectDestroyed):
        (WebCore::ImageQualityController::highQualityRepaintTimerFired):
        (WebCore::ImageQualityController::shouldPaintAtLowQuality):
        (WebCore::imageQualityController):
        (WebCore::RenderBoxModelObject::~RenderBoxModelObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 27 Jan 2011 21:52:56 +0000 (21:52 +0000)]
2011-01-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Generalize the mechanism view-source uses to remember the source for an HTMLToken
        https://bugs.webkit.org/show_bug.cgi?id=53200

        Currently view-source tracks the source associated with each HTMLToken.
        We want to re-use this mechanism for the new XSS auditor.  This patch
        moves this code into its own class so it can be shared between the
        view-source parser and the general HTML parser.  This patch also add
        support for tracking the source of tokens that span document.write
        boundaries.

        No functional change.  This code change is somewhat tested by our
        view-source layout tests.

        * Android.mk:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
            - Fun with updating build files.
        * html/parser/HTMLDocumentParser.cpp:
        (WebCore::HTMLDocumentParser::pumpTokenizer):
            - Teach HTMLDocumentParser to track the source for HTMLTokens.
              Currently, this information isn't used, but it will be shortly.
              I ran the HTML parser benchmark and this change didn't have a
              measurable effect.
        * html/parser/HTMLDocumentParser.h:
            - Composite in the HTMLSourceTracker.
        * html/parser/HTMLSourceTracker.cpp: Added.
        (WebCore::HTMLSourceTracker::HTMLSourceTracker):
        (WebCore::HTMLSourceTracker::start):
        (WebCore::HTMLSourceTracker::end):
            - This function should eventualy be folded into HTMLTokenizer.
        (WebCore::HTMLSourceTracker::sourceForToken):
        * html/parser/HTMLSourceTracker.h: Added.
        * html/parser/HTMLToken.h:
            - Now HTMLTokens always have a start index of zero.  To do the job
              of the old start index, this patch introduces the notion of a
              baseOffset.  Unlike the start index (which was used as the base
              offset for all the other indicies), the baseOffset can change
              over the lifetime of the token.  We need the flexibility to
              change the offset for tokens that span document.write boundaries.
              Values are now normalized to zero-offset when stored.
        (WebCore::HTMLToken::clear):
        (WebCore::HTMLToken::setBaseOffset):
        (WebCore::HTMLToken::end):
        (WebCore::HTMLToken::beginAttributeName):
        (WebCore::HTMLToken::endAttributeName):
        (WebCore::HTMLToken::beginAttributeValue):
        (WebCore::HTMLToken::endAttributeValue):
        * html/parser/HTMLViewSourceParser.cpp:
            - Updates the HTMLViewSourceParser to use the new
              HTMLSourceTracker.
        (WebCore::HTMLViewSourceParser::pumpTokenizer):
        (WebCore::HTMLViewSourceParser::append):
        (WebCore::HTMLViewSourceParser::sourceForToken):
            - This function now just calls through to HTMLSourceTracker.
        * html/parser/HTMLViewSourceParser.h:
        * platform/text/SegmentedString.cpp:
        (WebCore::SegmentedString::currentColumn):
        (WebCore::SegmentedString::setCurrentPosition):
        * platform/text/SegmentedString.h:
        (WebCore::SegmentedString::numberOfCharactersConsumed):
            - We need to handle the general case now.  The "slow" version
              doesn't turn out to be any slower in practice anyway.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Robert Hogan <robert@webkit.org>
robert@webkit.org [Thu, 27 Jan 2011 21:45:10 +0000 (21:45 +0000)]
2011-01-27  Robert Hogan  <robert@webkit.org>

        Rubber-stamped by Andreas Kling.

        [Qt] Style Fix: correct indentation in FrameLoadeClientQt:createPlugin

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::createPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 27 Jan 2011 21:35:37 +0000 (21:35 +0000)]
2011-01-27  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Encode/Decode hasPreciseScrollingDeltas bit in WebWheelEvent
        https://bugs.webkit.org/show_bug.cgi?id=53254

        * Shared/WebWheelEvent.cpp:
        (WebKit::WebWheelEvent::WebWheelEvent):
        Initialize m_phase and m_hasPreciseScrollingDeltas.

        (WebKit::WebWheelEvent::encode):
        (WebKit::WebWheelEvent::decode):
        Add missing coding for m_hasPreciseScrollingDeltas.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix all the builds.
weinig@apple.com [Thu, 27 Jan 2011 21:32:55 +0000 (21:32 +0000)]
Fix all the builds.

* platform/ScrollView.cpp:
(WebCore::ScrollView::paintOverhangAreas): Add parameters.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd ability to do an unconstrained scroll on a ScrollView
weinig@apple.com [Thu, 27 Jan 2011 21:23:06 +0000 (21:23 +0000)]
Add ability to do an unconstrained scroll on a ScrollView
https://bugs.webkit.org/show_bug.cgi?id=53249

Reviewed by Dave Hyatt.

* platform/ScrollView.cpp:
(WebCore::ScrollView::ScrollView):
Initialize m_constrainsScrollingToContentEdge to true.

(WebCore::ScrollView::setScrollOffset):
Only constrain the offset if the m_constrainsScrollingToContentEdge is set.

(WebCore::ScrollView::updateScrollbars):
Simplify expression converting an IntSize to an IntPoint.

(WebCore::ScrollView::paint):
Paint the overhang if there is any.

(WebCore::ScrollView::calculateOverhangAreasForPainting):
Calculate the overhang in viewport coordinates for painting.

* platform/ScrollView.h:
(WebCore::ScrollView::constrainsScrollingToContentEdge):
(WebCore::ScrollView::setConstrainsScrollingToContentEdge):
Add bit to control whether the scroll position should be constrained
to the content edge when set.

* platform/ScrollbarThemeComposite.cpp:
(WebCore::usedTotalSize):
(WebCore::ScrollbarThemeComposite::thumbPosition):
(WebCore::ScrollbarThemeComposite::thumbLength):
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::paint):
Improve calculations of thumb size and position to take overhang into account.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Thu, 27 Jan 2011 21:03:14 +0000 (21:03 +0000)]
2011-01-27  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG animation of Paths with segments of different coordinate modes on begin and end
        https://bugs.webkit.org/show_bug.cgi?id=52984

        Added tests to check the correct behavior on path animations, where the coordinate modes
        of the start path differs from the one on the end path.

        * svg/animations/animate-path-animation-Cc-Ss-expected.txt: Added.
        * svg/animations/animate-path-animation-Cc-Ss.html: Added.
        * svg/animations/animate-path-animation-Ll-Vv-Hh-expected.txt: Added.
        * svg/animations/animate-path-animation-Ll-Vv-Hh.html: Added.
        * svg/animations/animate-path-animation-Qq-Tt-expected.txt: Added.
        * svg/animations/animate-path-animation-Qq-Tt.html: Added.
        * svg/animations/animate-path-animation-cC-sS-inverse-expected.txt: Added.
        * svg/animations/animate-path-animation-cC-sS-inverse.html: Added.
        * svg/animations/animate-path-animation-lL-vV-hH-inverse-expected.txt: Added.
        * svg/animations/animate-path-animation-lL-vV-hH-inverse.html: Added.
        * svg/animations/animate-path-animation-qQ-tT-inverse-expected.txt: Added.
        * svg/animations/animate-path-animation-qQ-tT-inverse.html: Added.
        * svg/animations/animate-path-nested-transforms.html: Cleanup.
        * svg/animations/animate-text-nested-transforms.html: Cleanup.
        * svg/animations/resources/SVGAnimationTestCase.js:
        (shouldBeCloseEnough): For debug output of values with tolerance level.
        (startTest):
        (sampleAnimation):
        * svg/animations/script-tests/animate-path-animation-Cc-Ss.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (sample4):
        (executeTest):
        * svg/animations/script-tests/animate-path-animation-Ll-Vv-Hh.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (sample4):
        (executeTest):
        * svg/animations/script-tests/animate-path-animation-Qq-Tt.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (sample4):
        (executeTest):
        * svg/animations/script-tests/animate-path-animation-cC-sS-inverse.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (sample4):
        (executeTest):
        * svg/animations/script-tests/animate-path-animation-lL-vV-hH-inverse.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (sample4):
        (executeTest):
        * svg/animations/script-tests/animate-path-animation-qQ-tT-inverse.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (sample4):
        (executeTest):
2011-01-27  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG animation of Paths with segments of different coordinate modes on begin and end
        https://bugs.webkit.org/show_bug.cgi?id=52984

        At the moment we just support SVG path animations, if the number of segments on the given start path
        is the same as the number of segments on the given end path. But a segment on a given position must be identical
        on both paths as well. Not only the segment type, also the coordinate mode of the segments must be identical.
        If MoveToRel is on the second position on the start path a MoveToRel must be on the second position
        of the end path too. According to the SVG spec, at least the coordinate mode can differ. Means, if we have MoveToRel
        in the start path, we can use MoveToAbs on the same position in the end path.

        This patch fixes the blending code to follow the spec here. It was necessary to track the current position of
        both paths, transform coordinates to the same coordinate mode and transform the resulting animation coordinate back
        to the coordinate mode of either the start or the end path. Which mode is taken depends on the progress of the
        animation.

        Tests: svg/animations/animate-path-animation-Cc-Ss.html
               svg/animations/animate-path-animation-Ll-Vv-Hh.html
               svg/animations/animate-path-animation-Qq-Tt.html
               svg/animations/animate-path-animation-cC-sS-inverse.html
               svg/animations/animate-path-animation-lL-vV-hH-inverse.html
               svg/animations/animate-path-animation-qQ-tT-inverse.html

        * svg/SVGPathBlender.cpp:
        (WebCore::blendFloatPoint):
        (WebCore::blendAnimatedFloat):
        (WebCore::SVGPathBlender::blendAnimatedDimensionalFloat):
        (WebCore::SVGPathBlender::blendAnimatedFloatPoint):
        (WebCore::SVGPathBlender::blendMoveToSegment):
        (WebCore::SVGPathBlender::blendLineToSegment):
        (WebCore::SVGPathBlender::blendLineToHorizontalSegment):
        (WebCore::SVGPathBlender::blendLineToVerticalSegment):
        (WebCore::SVGPathBlender::blendCurveToCubicSegment):
        (WebCore::SVGPathBlender::blendCurveToCubicSmoothSegment):
        (WebCore::SVGPathBlender::blendCurveToQuadraticSegment):
        (WebCore::SVGPathBlender::blendCurveToQuadraticSmoothSegment):
        (WebCore::SVGPathBlender::blendArcToSegment):
        (WebCore::coordinateModeOfCommand):
        (WebCore::isSegmentEqual):
        (WebCore::SVGPathBlender::blendAnimatedPath):
        (WebCore::SVGPathBlender::cleanup):
        * svg/SVGPathBlender.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 27 Jan 2011 20:53:59 +0000 (20:53 +0000)]
2011-01-27  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Mihai Parparita.

        new-run-webkit-tests: turn off pixel tests correctly by default
        for webkit-based ports. r70013 (bug 47510) used
        port.set_option_default() to attempt to set default values, but
        that didn't work correctly. I have removed set_option_default
        for now since it was only being used in two places and in three
        useless unit tests. There is a separate bug open to fix the
        option parsing (48095), so this workaround is fine for now.

        https://bugs.webkit.org/show_bug.cgi?id=53217

        * Scripts/webkitpy/layout_tests/port/webkit.py:
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/base_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Cris Neckar <cdn@chromium.org>
jschuh@chromium.org [Thu, 27 Jan 2011 20:47:46 +0000 (20:47 +0000)]
2011-01-27  Cris Neckar  <cdn@chromium.org>

        Reviewed by Dimitri Glazkov.

        Clear the parent on a css keyframe's m_style when removing it from the stylesheet.
        https://bugs.webkit.org/show_bug.cgi?id=52320

        Test: fast/css/css-keyframe-style-crash.html

        * css/CSSRuleList.cpp:
        (WebCore::CSSRuleList::deleteRule):
        * css/WebKitCSSKeyframesRule.cpp:
        (WebCore::WebKitCSSKeyframesRule::~WebKitCSSKeyframesRule):
2011-01-27  Cris Neckar  <cdn@chromium.org>

        Reviewed by Dimitri Glazkov.

        Test for crash when accessing a keyframe's style rule.
        https://bugs.webkit.org/show_bug.cgi?id=52320

        * fast/css/css-keyframe-style-crash-expected.txt: Added.
        * fast/css/css-keyframe-style-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 27 Jan 2011 20:28:12 +0000 (20:28 +0000)]
2011-01-27  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Chromium text expectation update.

        * platform/chromium/test_expectations.txt: Apparently, video-size.html crashes on Linux due to crbug.com/71087.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Rob Buis <rwlbuis@gmail.com>
rwlbuis@webkit.org [Thu, 27 Jan 2011 20:02:36 +0000 (20:02 +0000)]
2011-01-27  Rob Buis  <rwlbuis@gmail.com>

        Reviewed by Kent Tamura.

        Color changes to option elements in a select multiple aren't drawn immediately
        https://bugs.webkit.org/show_bug.cgi?id=49790

        Redirect style changes on <option> element to the owner <select> element.

        Test: fast/repaint/select-option-background-color.html

        * html/HTMLOptionElement.cpp:
        (WebCore::HTMLOptionElement::setRenderStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-19 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Thu, 27 Jan 2011 19:58:33 +0000 (19:58 +0000)]
2011-01-19  Stephen White  <senorblanco@chromium.org>

        Reviewed by Darin Adler.

        Fix performance regression in ImageQualityController::objectDestroyed().
        https://bugs.webkit.org/show_bug.cgi?id=52645

        In r72282, I inadvertently introduced this regression by using a
        linear search through the hash map on object destruction.  This was
        because the hash key consisted of both object pointer and layer id,
        but on object destruction we only know the object pointer, requiring
        a search to find all the layers.
        By replacing the hash map with two nested hash maps, where the outer key
        is the object and the inner key is the layer, we can find all the
        relevant data for an object in one hash lookup.

        * rendering/RenderBoxModelObject.cpp:
        Replace the (object,layer)->size HashMap with object->layer and
        layer->size HashMaps.
        (WebCore::ImageQualityController::isEmpty):
        Implement isEmpty() for the outer HashMap.
        (WebCore::ImageQualityController::removeLayer):
        When a layer is removed, remove it from the inner hash map.
        (WebCore::ImageQualityController::set):
        Implement set():  if the inner map exists, set the layer->size tuple
        directly.  If not, create a new inner map, set the tuple, and insert
        it in the outer map.
        (WebCore::ImageQualityController::objectDestroyed):
        Look up the object in the outer map only.
        (WebCore::ImageQualityController::highQualityRepaintTimerFired):
        Cosmetic changes for the renamed now-outer hash map.
        (WebCore::ImageQualityController::shouldPaintAtLowQuality):
        Do both outer and inner hash map lookups.  Call set() to add/update
        entries to the hash maps.  keyDestroyed() is now removeLayer().
        (WebCore::imageQualityController):
        Make the ImageQualityController a file-static global, so it can be
        created and destroyed on the fly.
        (WebCore::RenderBoxModelObject::~RenderBoxModelObject):
        If there is no ImageQualityController, don't call objectDestroyed().
        If it's empty, delete it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: WebKit2: add support for drag and drop on Windows
enrica@apple.com [Thu, 27 Jan 2011 19:51:14 +0000 (19:51 +0000)]
Source/WebCore: WebKit2: add support for drag and drop on Windows
https://bugs.webkit.org/show_bug.cgi?id=52775
<rdar://problem/8514409>

Reviewed by Darin Adler and Adam Roben.

On Windows the access to the content being dragged is
provided via the IDataObject interface that is made available
to the window that registers itself as drop target.
Since this interface cannot be accessed from the WebProcess,
in every call to one of the methods of the IDropTarget interface
we serialize the content of the drag clipboard and send it over to
the WebProcess.
The bulk of this patch consists in the refactoring needed in DragData
and ClipboardWin classes to extract the data from the serialized object.

* platform/DragData.cpp:
* platform/DragData.h:
* platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::getWebLocData):
(WebCore::getURL):
(WebCore::getPlainText):
(WebCore::getTextHTML):
(WebCore::getCFHTML):
(WebCore::fragmentFromFilenames):
(WebCore::containsFilenames):
(WebCore::fragmentFromHTML):
(WebCore::containsHTML):
(WebCore::getClipboardData):
* platform/win/ClipboardUtilitiesWin.h:
* platform/win/ClipboardWin.cpp:
(WebCore::Clipboard::create):
(WebCore::ClipboardWin::ClipboardWin):
(WebCore::ClipboardWin::getData):
(WebCore::ClipboardWin::types):
(WebCore::ClipboardWin::files):
(WebCore::ClipboardWin::hasData):
* platform/win/ClipboardWin.h:
(WebCore::ClipboardWin::create):
* platform/win/DragDataWin.cpp:
(WebCore::DragData::DragData):
(WebCore::DragData::containsURL):
(WebCore::DragData::dragDataMap):
(WebCore::DragData::asURL):
(WebCore::DragData::containsFiles):
(WebCore::DragData::asFilenames):
(WebCore::DragData::containsPlainText):
(WebCore::DragData::asPlainText):
(WebCore::DragData::canSmartReplace):
(WebCore::DragData::containsCompatibleContent):
(WebCore::DragData::asFragment):

Source/WebKit2: WebKit2: add support for drag and drop on Windows
https://bugs.webkit.org/show_bug.cgi?id=52775
<rdar://problem/8514409>

Reviewed by Darin Adler and Adam Roben.

On Windows the access to the content being dragged is
provided via the IDataObject interface that is made available
to the window that registers itself as drop target.
Since this interface cannot be accessed from the WebProcess,
in every call to one of the methods of the IDropTarget interface
we serialize the content of the drag clipboard and send it over to
the WebProcess. The implementation uses the same messages as the
Mac one, with slightly different parameters to pass the serialized
clipboard.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::performDragControllerAction): Added Windows
specific implementation.
* UIProcess/WebPageProxy.h:
* UIProcess/win/WebView.cpp:
(WebKit::WebView::WebView): Added dropTargetHelper object creation.
(WebKit::WebView::initialize): Added to register for drag/drop with out
refcount issues.
(WebKit::WebView::close):
(WebKit::WebView::windowReceivedMessage):
(WebKit::WebView::QueryInterface):
(WebKit::WebView::AddRef):
(WebKit::WebView::Release):
(WebKit::dragOperationToDragCursor):
(WebKit::WebView::keyStateToDragOperation):
(WebKit::WebView::DragEnter):
(WebKit::WebView::DragOver):
(WebKit::WebView::DragLeave):
(WebKit::WebView::Drop):
* UIProcess/win/WebView.h:
(WebKit::WebView::create):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::performDragControllerAction):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Thu, 27 Jan 2011 19:38:03 +0000 (19:38 +0000)]
2011-01-27  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Space characters in source document interfere with reported caret offset
        https://bugs.webkit.org/show_bug.cgi?id=53033

        Calculate caret offset from rendered text instead of from node contents.

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (objectAndOffsetUnignored): Calculate the caret offset based only
        on positions and ranges, instead of using the computed offset in
        the container node.
2011-01-27  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Space characters in source document interfere with reported caret offset
        https://bugs.webkit.org/show_bug.cgi?id=53033

        New unit test to check the fix for this bug.

        * tests/testatk.c:
        (testWebkitAtkCaretOffsetsAndExtranousWhiteSpaces): New.
        (main): Add new unit test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Reviewed by Darin Adler.
ap@apple.com [Thu, 27 Jan 2011 19:36:10 +0000 (19:36 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=53197
        <rdar://problem/8895682> Make WebKit2 printing asynchronous

        <rdar://problem/8899988> REGRESSION(WebKit2): Attempting to print WHATWG HTML spec shows
        1-page blank preview

        <rdar://problem/8900078> WebKit2 printing has a separate message exchange per page when
        printing instead of printing all at once

        * UIProcess/API/mac/WKPrintingView.h: Store a lot more cached information.

        * UIProcess/API/mac/WKPrintingView.mm:
        (-[WKPrintingView _adjustPrintingMarginsForHeaderAndFooter]): Use PrintOperation stored in
        class. We generally want that now, because current operation will not be set up on other threads.
        (-[WKPrintingView _isPrintingPreview]): Added. Preview is different, because it can draw
        a placeholder - but actual printing need to wait until UI process has data.
        (-[WKPrintingView _updatePreview]): Force AppKit to update print preview when we have real
        data to replace placeholder with.
        (-[WKPrintingView _hasPageRects]): Return if page rects have already been computed.
        (-[WKPrintingView _expectedPreviewCallbackForRect:]): Find an existing request for this rect,
        if any.
        (pageDidDrawToPDF): Update preview - or if actually printing, release control to printing thread.
        (-[WKPrintingView _preparePDFDataForPrintingOnSecondaryThread]): Ask for a PDF document with
        pages the user asked to print.
        (pageDidComputePageRects): When web process returns page geometry data, we update preview to display
        a page count (which indirectly triggers a request for a preview). When actually printing,
        request a PDF right away, we'll need it later.
        (-[WKPrintingView _askPageToComputePageRects]): Ask web process for page geometry.
        (prepareDataForPrintingOnSecondaryThread): This function starts preparing all data necessary
        for actual printing on main thread.
        (-[WKPrintingView knowsPageRange:]): Changed to be async for preview, and to call main
        thread for actual printing.
        (-[WKPrintingView _pageForRect:]): Find page number for a given range, assuming that AppKit
        always asks for full pages.
        (-[WKPrintingView _drawPDFDocument:page:atPoint:]): A helper function to draw a PDF document.
        (-[WKPrintingView _drawPreview:]): Draw the whole page for preview.
        (-[WKPrintingView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
        Draw the whole page for actual printing.
        (-[WKPrintingView _drawPageBorderWithSizeOnMainThread:]): Call drawPageBorderWithSize: with
        correct graphics context and print operation.
        (-[WKPrintingView drawPageBorderWithSize:]): Delegate work to main thread when called from a
        secondary one.
        (-[WKPrintingView _provideTotalScaleFactorForPrintOperation:]): Added an assertion that
        our stored NSPrintOperation isn't out of sync with reality.
        (-[WKPrintingView rectForPage:]): Handle the case where we don't have the data yet, drawing
        a placeholder.
        (-[WKPrintingView endDocument]): When page setup changes, we must reset all state.

        * UIProcess/API/mac/WKView.mm: (-[WKView printOperationWithPrintInfo:forFrame:]): Tell
        NSPrintingView which operation it's serving, so that it knows it even when current operation
        isn't set.

        * UIProcess/GenericCallback.h:
        (WebKit::ComputedPagesCallback::create):
        (WebKit::ComputedPagesCallback::~ComputedPagesCallback):
        (WebKit::ComputedPagesCallback::performCallbackWithReturnValue):
        (WebKit::ComputedPagesCallback::invalidate):
        (WebKit::ComputedPagesCallback::callbackID):
        (WebKit::ComputedPagesCallback::generateCallbackID):
        (WebKit::ComputedPagesCallback::ComputedPagesCallback):
        Added ComputedPagesCallback, which returns a vector of IntRects and a double. Hopefully,
        it will become a specialization of GenericCallback one day.

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::close): Added m_voidCallbacks - it looks like they were omitted
        by accident.
        (WebKit::WebPageProxy::computedPagesCallback): Added.
        (WebKit::WebPageProxy::processDidCrash): Added m_computedPagesCallbacks.
        (WebKit::WebPageProxy::computePagesForPrinting): Async now!
        (WebKit::WebPageProxy::drawRectToPDF): Ditto.
        (WebKit::WebPageProxy::drawPagesToPDF): Added.
        * UIProcess/WebPageProxy.h:

        * UIProcess/WebPageProxy.messages.in: Added ComputedPagesCallback.

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::beginPriting): Compute page rects right away - we'll need them in
        drawPagesToPDF(), which doesn't have a PrintInfo.
        (WebKit::WebPage::computePagesForPrinting): Send async response.
        (WebKit::WebPage::drawRectToPDF): This function used to draw into original
        location at frame coordinates, and now it draws at (0, 0).
        (WebKit::WebPage::drawPagesToPDF): Added - make a multi-page PDF.
        * WebProcess/WebPage/WebPage.h:

        * WebProcess/WebPage/WebPage.messages.in: Added DrawPagesToPDF.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 David Grogan <dgrogan@google.com>
jorlow@chromium.org [Thu, 27 Jan 2011 19:24:23 +0000 (19:24 +0000)]
2011-01-27  David Grogan  <dgrogan@google.com>

        Reviewed by Jeremy Orlow.

        initial support for close() in indexeddb backend
        https://bugs.webkit.org/show_bug.cgi?id=53150

        * storage/indexeddb/transaction-after-close-expected.txt: Added.
        * storage/indexeddb/transaction-after-close.html: Added.
2011-01-27  David Grogan  <dgrogan@google.com>

        Reviewed by Jeremy Orlow.

        initial support for close() in indexeddb backend
        https://bugs.webkit.org/show_bug.cgi?id=53150

        Test: storage/indexeddb/transaction-after-close.html

        * storage/IDBDatabase.cpp:
        (WebCore::IDBDatabase::IDBDatabase):
        (WebCore::IDBDatabase::transaction):
        (WebCore::IDBDatabase::close):
        * storage/IDBDatabase.h:
        * storage/IDBDatabase.idl:
        * storage/IDBDatabaseBackendImpl.cpp:
        (WebCore::IDBDatabaseBackendImpl::transaction):
        (WebCore::IDBDatabaseBackendImpl::close):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Thu, 27 Jan 2011 19:23:44 +0000 (19:23 +0000)]
2011-01-27  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG animation doesn't support calcMode discrete for number and color values.
        https://bugs.webkit.org/show_bug.cgi?id=53189

        Add support for calcMode discrete on number and color animation.

        Tests: svg/animations/animate-color-calcMode-discrete.html
               svg/animations/animate-number-calcMode-discrete.html

        * svg/SVGAnimateElement.cpp:
        (WebCore::SVGAnimateElement::calculateAnimatedValue):
2011-01-27  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG animation doesn't support calcMode discrete for number and color values.
        https://bugs.webkit.org/show_bug.cgi?id=53189

        Test for correct behavior on animating numbers and colors with calcMode discrete.

        * svg/animations/animate-color-calcMode-discrete-expected.txt: Added.
        * svg/animations/animate-color-calcMode-discrete.html: Added.
        * svg/animations/animate-number-calcMode-discrete-expected.txt: Added.
        * svg/animations/animate-number-calcMode-discrete.html: Added.
        * svg/animations/script-tests/animate-color-calcMode-discrete.js: Added.
        (sample1):
        (sample2):
        (executeTest):
        * svg/animations/script-tests/animate-number-calcMode-discrete.js: Added.
        (sample1):
        (sample2):
        (executeTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 27 Jan 2011 19:18:25 +0000 (19:18 +0000)]
2011-01-27  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Chromium test expectation update for video tests.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Thu, 27 Jan 2011 19:16:44 +0000 (19:16 +0000)]
2011-01-27  Alejandro G. Castro  <alex@igalia.com>

        Unreviewed GTK build fix after r76797.

        * Shared/WebPreferencesStore.h: Use Qt fonts preference for the moment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Charlie Reis <creis@chromium.org>
rniwa@webkit.org [Thu, 27 Jan 2011 19:11:53 +0000 (19:11 +0000)]
2011-01-27  Charlie Reis  <creis@chromium.org>

        Reviewed by Mihai Parparita.

        back-during-onload-hung-page.php causes Chromium WebKit bot to fail
        https://bugs.webkit.org/show_bug.cgi?id=53220

        Reduces the timeout on a script that shouldn't finish during a test.
        This avoids problems in one of the Chromium WebKit builders.

        * http/tests/history/resources/back-during-onload-hung-page.php: Reduce timeout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAllow pop-up menus to contain multiple items that have the same title.
mitz@apple.com [Thu, 27 Jan 2011 19:05:22 +0000 (19:05 +0000)]
Allow pop-up menus to contain multiple items that have the same title.

Reviewed by Anders Carlsson.

* UIProcess/mac/WebPopupMenuProxyMac.mm:
(WebKit::WebPopupMenuProxyMac::populate): Set the item’s title after adding it rather than
when adding it, so that it will not replace any existing item with the same title.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-26 Zhenyao Mo <zmo@google.com>
zmo@google.com [Thu, 27 Jan 2011 18:58:53 +0000 (18:58 +0000)]
2011-01-26  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        shaderSource needs to preserve original source
        https://bugs.webkit.org/show_bug.cgi?id=52833

        * fast/canvas/webgl/gl-getshadersource-expected.txt: Added.
        * fast/canvas/webgl/gl-getshadersource.html: Added.
2011-01-26  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        shaderSource needs to preserve original source
        https://bugs.webkit.org/show_bug.cgi?id=52833

        Test: fast/canvas/webgl/gl-getshadersource.html

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::getShaderParameter): Intercept SHADER_SOURCE_LENGTH.
        (WebCore::WebGLRenderingContext::getShaderSource): Intercept the call.
        (WebCore::WebGLRenderingContext::shaderSource): Cache the source.
        * html/canvas/WebGLShader.cpp: Cache shader source.
        (WebCore::WebGLShader::WebGLShader):
        * html/canvas/WebGLShader.h: Ditto.
        (WebCore::WebGLShader::getSource):
        (WebCore::WebGLShader::setSource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReverted an accidental change in r76561.
mitz@apple.com [Thu, 27 Jan 2011 18:52:34 +0000 (18:52 +0000)]
Reverted an accidental change in r76561.

Rubber-stamped by Anders Carlsson.

* WebView/WebHTMLView.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 27 Jan 2011 18:24:59 +0000 (18:24 +0000)]
2011-01-27  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip flaky test, needs further investigation on the failure.

        [GTK] media/audio-delete-while-slider-thumb-clicked.html is flaky
        https://bugs.webkit.org/show_bug.cgi?id=53247

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTrivial crash fix in WTR.
kbalazs@webkit.org [Thu, 27 Jan 2011 18:09:31 +0000 (18:09 +0000)]
Trivial crash fix in WTR.

Rubber-stamped by Ariya Hidayat.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize): Increase the size
of the vector by one to be able to store the null character.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agofast/text/international/bidi-mirror-he-ar.html now passed on Windows in WebKit2.
jberlin@webkit.org [Thu, 27 Jan 2011 17:32:33 +0000 (17:32 +0000)]
fast/text/international/bidi-mirror-he-ar.html now passed on Windows in WebKit2.
Unreviewed.

* platform/win-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
mjs@apple.com [Thu, 27 Jan 2011 17:26:16 +0000 (17:26 +0000)]
Unreviewed.

Fix mistake in my previous commit; I accidentally copied the old mac results instead
of the new mac results for this test.

* platform/mac-wk2/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed; Fixed change log entries because Chromium rebaselines are unreviewed...
rniwa@webkit.org [Thu, 27 Jan 2011 17:05:31 +0000 (17:05 +0000)]
Unreviewed; Fixed change log entries because Chromium rebaselines are unreviewed but claimed to be reviewed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 27 Jan 2011 16:58:26 +0000 (16:58 +0000)]
2011-01-27  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, rebaseline of the favicon-as-image test from the build
        bot.

        * platform/gtk/http/tests/misc/favicon-as-image-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 27 Jan 2011 16:55:48 +0000 (16:55 +0000)]
2011-01-27  Ryosuke Niwa  <rniwa@webkit.org>

        Another Unreviewed Chromium test expectation update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 27 Jan 2011 16:50:58 +0000 (16:50 +0000)]
2011-01-27  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Chromium test expectation update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 27 Jan 2011 16:31:29 +0000 (16:31 +0000)]
2011-01-27  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Chromium rebaselines.

        * platform/chromium-mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum: Added.
        * platform/chromium-mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.png: Added.
        * platform/chromium-mac/fast/repaint/line-flow-with-floats-9-expected.checksum:
        * platform/chromium-mac/fast/repaint/line-flow-with-floats-9-expected.png:
        * platform/chromium-mac/fast/text/justify-ideograph-complex-expected.checksum: Added.
        * platform/chromium-mac/fast/text/justify-ideograph-complex-expected.png: Added.
        * platform/chromium-mac/fast/text/justify-ideograph-simple-expected.checksum: Added.
        * platform/chromium-mac/fast/text/justify-ideograph-simple-expected.png: Added.
        * platform/chromium-mac/fast/text/justify-ideograph-vertical-expected.checksum: Added.
        * platform/chromium-mac/fast/text/justify-ideograph-vertical-expected.png: Added.
        * platform/chromium-mac/tables/mozilla/marvin/x_thead_align_justify-expected.checksum: Added.
        * platform/chromium-mac/tables/mozilla/marvin/x_thead_align_justify-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Balazs Kelemen <kbalazs@webkit.org>
kbalazs@webkit.org [Thu, 27 Jan 2011 16:29:11 +0000 (16:29 +0000)]
2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>

        Reviewed by Csaba Osztrogonác.

        [Qt][WK2] WTR should be initialized in the same way as DRT
        https://bugs.webkit.org/show_bug.cgi?id=53240

        * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
        (WTR::activateFonts): Added missing initialization steps.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Thu, 27 Jan 2011 15:55:58 +0000 (15:55 +0000)]
2011-01-27  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed WinCE build fix for r76743.

        * platform/graphics/wince/FontWinCE.cpp:
        (WebCore::TextRunComponent::TextRunComponent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 27 Jan 2011 15:38:34 +0000 (15:38 +0000)]
2011-01-27  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, GTK baselines for
        svg/custom/pattern-referencing-preserve-aspect-ratio.svg added in r76274.

        * platform/gtk/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 27 Jan 2011 15:25:42 +0000 (15:25 +0000)]
2011-01-27  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, GTK baselines for
        http/tests/misc/favicon-as-image.html which was unskipped in r76555.

        * platform/gtk/http/tests/misc/favicon-as-image-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 27 Jan 2011 15:11:53 +0000 (15:11 +0000)]
2011-01-27  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, GTK baselines for fast/dom/52776.html, follow-up of r76319.

        * platform/gtk/fast/dom/52776-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Thu, 27 Jan 2011 15:07:35 +0000 (15:07 +0000)]
2011-01-27  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt][WK2] Add QWKPage APIs regarding engine process availability
        https://bugs.webkit.org/show_bug.cgi?id=53237

        QWKPage will now emit engineConnected() and engineDisconnected()
        when the web process crashes and is relaunched respectively.

        Also added QWKPage::isConnectedToEngine() for convenience.

        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPagePrivate::QWKPagePrivate):
        (QWKPagePrivate::didRelaunchProcess):
        (QWKPagePrivate::processDidCrash):
        (QWKPage::isConnectedToEngine):
        * UIProcess/API/qt/qwkpage.h:
        * UIProcess/API/qt/qwkpage_p.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Balazs Kelemen <kbalazs@webkit.org>
kbalazs@webkit.org [Thu, 27 Jan 2011 14:56:14 +0000 (14:56 +0000)]
2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>

        Reviewed by Andreas Kling.

        [Qt][WK2] Lots of layout test failures due to wrong font type
        https://bugs.webkit.org/show_bug.cgi?id=53233

        * Shared/WebPreferencesStore.h:
        Specialize default font families for Qt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 27 Jan 2011 14:25:01 +0000 (14:25 +0000)]
2011-01-27  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, new GTK baselines for fast/text/justify* tests
        introduced in r76743.

        * platform/gtk/fast/text/justify-ideograph-complex-expected.txt: Added.
        * platform/gtk/fast/text/justify-ideograph-simple-expected.txt: Added.
        * platform/gtk/fast/text/justify-ideograph-vertical-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Thu, 27 Jan 2011 14:22:11 +0000 (14:22 +0000)]
2011-01-27  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Closure and Global variable details automatically collapsing on each step through JavaScript code.
        https://bugs.webkit.org/show_bug.cgi?id=53234

        * inspector/debugger-expand-scope.html:
        * inspector/debugger-proto-property.html:
2011-01-27  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Closure and Global variable details automatically collapsing on each step through JavaScript code.
        https://bugs.webkit.org/show_bug.cgi?id=53234

        * inspector/front-end/ScopeChainSidebarPane.js:
        (WebInspector.ScopeChainSidebarPane):
        (WebInspector.ScopeChainSidebarPane.prototype.update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Sheriff Bot <webkit.review.bot@gmail.com>
podivilov@chromium.org [Thu, 27 Jan 2011 14:14:49 +0000 (14:14 +0000)]
2011-01-27  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r76789.
        http://trac.webkit.org/changeset/76789
        https://bugs.webkit.org/show_bug.cgi?id=53238

        Broke GTK layout tests (Requested by podivilov on #webkit).

        * inspector/front-end/ScopeChainSidebarPane.js:
        (WebInspector.ScopeChainSidebarPane):
        (WebInspector.ScopeChainSidebarPane.prototype.update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 27 Jan 2011 14:07:41 +0000 (14:07 +0000)]
2011-01-27  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, fix typo introduced in r76783.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Thu, 27 Jan 2011 14:03:18 +0000 (14:03 +0000)]
2011-01-27  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: store all settings related to the agents on the frontend side
        https://bugs.webkit.org/show_bug.cgi?id=53174

        * http/tests/inspector/console-xhr-logging.html: since the setting doesn't change on the front-end
        side there is no need to check it after modifying backend's value.
        * inspector/report-protocol-errors.html: use the new signature of disableDebugger method.
2011-01-27  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: store all settings related to the agents on the frontend side
        https://bugs.webkit.org/show_bug.cgi?id=53174

        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.exp.in:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/ScriptDebugServer.cpp:
        * bindings/js/ScriptDebugServer.h:
        * bindings/js/ScriptProfiler.cpp:
        * bindings/js/ScriptProfiler.h:
        * bindings/v8/ScriptDebugServer.cpp:
        * bindings/v8/ScriptDebugServer.h:
        * bindings/v8/ScriptProfiler.cpp:
        * bindings/v8/ScriptProfiler.h:
        * inspector/Inspector.idl:
        * inspector/InspectorAgent.cpp: profiler and debugger enablement state is now stored
        on the front-end side and will be pushed to the backend when the frontend is loaded.
        (WebCore::InspectorAgent::InspectorAgent):
        (WebCore::InspectorAgent::disconnectFrontend):
        (WebCore::InspectorAgent::restoreDebugger):
        (WebCore::InspectorAgent::restoreProfiler):
        (WebCore::InspectorAgent::enableProfiler):
        (WebCore::InspectorAgent::disableProfiler):
        (WebCore::InspectorAgent::showAndEnableDebugger):
        (WebCore::InspectorAgent::enableDebugger):
        (WebCore::InspectorAgent::disableDebugger):
        * inspector/InspectorAgent.h:
        * inspector/InspectorConsoleAgent.cpp: XHR failures will be logged to the console only
        if the front-end was opened during current browser session and XHR logging is turned on
        there.
        (WebCore::InspectorConsoleAgent::setMonitoringXHREnabled):
        (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
        * inspector/InspectorDebuggerAgent.cpp:
        * inspector/InspectorDebuggerAgent.h:
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::identifierForInitialRequestImpl):
        (WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCacheImpl):
        * inspector/InspectorProfilerAgent.cpp:
        (WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
        (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
        * inspector/InspectorSettings.cpp: Removed.
        * inspector/InspectorSettings.h: Removed.
        * inspector/InspectorState.cpp:
        (WebCore::InspectorState::InspectorState):
        * inspector/InspectorState.h:
        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.consoleMessagesCleared):
        (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher):
        (WebInspector.ConsoleView.prototype._handleContextMenuEvent.itemAction):
        (WebInspector.ConsoleView.prototype._handleContextMenuEvent):
        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype._toggleProfiling):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._toggleDebugging):
        * inspector/front-end/Settings.js:
        (WebInspector.Settings):
        * inspector/front-end/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 27 Jan 2011 13:56:50 +0000 (13:56 +0000)]
2011-01-27  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, new GTK baselines for fast/multicol tests as follow-up
        of r76726.

        * platform/gtk/fast/multicol/vertical-lr/border-padding-pagination-expected.txt: Added.
        * platform/gtk/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt: Added.
        * platform/gtk/fast/multicol/vertical-lr/column-count-with-rules-expected.txt: Added.
        * platform/gtk/fast/multicol/vertical-lr/column-rules-expected.txt: Added.
        * platform/gtk/fast/multicol/vertical-lr/float-avoidance-expected.txt: Added.
        * platform/gtk/fast/multicol/vertical-lr/float-multicol-expected.txt: Added.
        * platform/gtk/fast/multicol/vertical-lr/float-paginate-complex-expected.txt: Added.
        * platform/gtk/fast/multicol/vertical-lr/float-paginate-expected.txt: Added.
        * platform/gtk/fast/multicol/vertical-lr/nested-columns-expected.txt: Added.
        * platform/gtk/fast/multicol/vertical-lr/unsplittable-inline-block-expected.txt: Added.
        * platform/gtk/fast/multicol/vertical-rl/border-padding-pagination-expected.txt: Added.
        * platform/gtk/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt: Added.
        * platform/gtk/fast/multicol/vertical-rl/column-count-with-rules-expected.txt: Added.
        * platform/gtk/fast/multicol/vertical-rl/column-rules-expected.txt: Added.
        * platform/gtk/fast/multicol/vertical-rl/float-avoidance-expected.txt: Added.
        * platform/gtk/fast/multicol/vertical-rl/float-multicol-expected.txt: Added.
        * platform/gtk/fast/multicol/vertical-rl/float-paginate-complex-expected.txt: Added.
        * platform/gtk/fast/multicol/vertical-rl/float-paginate-expected.txt: Added.
        * platform/gtk/fast/multicol/vertical-rl/nested-columns-expected.txt: Added.
        * platform/gtk/fast/multicol/vertical-rl/unsplittable-inline-block-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Joone Hur <joone.hur@collabora.co.uk>
joone.hur@collabora.co.uk [Thu, 27 Jan 2011 13:43:16 +0000 (13:43 +0000)]
2011-01-27  Joone Hur <joone.hur@collabora.co.uk>

        Unreviewed.

        Adding myself to committers.py.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Thu, 27 Jan 2011 13:01:24 +0000 (13:01 +0000)]
2011-01-27  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Closure and Global variable details automatically collapsing on each step through JavaScript code.
        https://bugs.webkit.org/show_bug.cgi?id=53234

        * inspector/front-end/ScopeChainSidebarPane.js:
        (WebInspector.ScopeChainSidebarPane):
        (WebInspector.ScopeChainSidebarPane.prototype.update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Thu, 27 Jan 2011 12:54:33 +0000 (12:54 +0000)]
2011-01-27  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Elements panel] Tooltip for relative links incorrectly identifies current URL
        https://bugs.webkit.org/show_bug.cgi?id=53171

        WebCore:
        * inspector/front-end/inspector.js:
        (WebInspector.completeURL): Taught to understand partial href's that start with "?" (contain GET parameters only)

        LayoutTests:
        * inspector/styles-url-linkify-expected.txt:
        * inspector/styles-url-linkify.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Thu, 27 Jan 2011 12:44:29 +0000 (12:44 +0000)]
2011-01-27  Sergio Villar Senin  <svillar@igalia.com>

        Unreviewed.

        New test expectations for http/tests/navigation/error404* in GTK.

        * platform/gtk/Skipped:
        * platform/gtk/http/tests/navigation/error404-basic-expected.txt: Added.
        * platform/gtk/http/tests/navigation/error404-goback-expected.txt: Added.
        * platform/gtk/http/tests/navigation/error404-subframeload-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Thu, 27 Jan 2011 12:38:09 +0000 (12:38 +0000)]
2011-01-27  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        [V8] Crash in WebCore::addMessageToConsole
        https://bugs.webkit.org/show_bug.cgi?id=53227

        * bindings/v8/V8Proxy.cpp: check that the Frame where the error
        occured still has a page before getting a console object from it.
        (WebCore::V8Proxy::reportUnsafeAccessTo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] [Symbian] Move project files into Source
ossy@webkit.org [Thu, 27 Jan 2011 12:30:01 +0000 (12:30 +0000)]
[Qt] [Symbian] Move project files into Source
https://bugs.webkit.org/show_bug.cgi?id=52891

Patch by Laszlo Gombos <laszlo.1.gombos@nokia.com> on 2011-01-27
Reviewed by Csaba Osztrogonác.

Fix the Symbian build after the project files
are moved to Source directory. On Symbian qmake
needs to run in the same directory where the main
pro files (WebKit.pro, Tools.pro) are located.

* Scripts/webkitdirs.pm: Change to the directory where the pro file
is located before running qmake for Symbian. Qmake on Symbian
does not properly honor the "-o" option, work it around by setting
the name of the Makefile to bld.inf.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Hans Wennborg <hans@chromium.org>
hans@chromium.org [Thu, 27 Jan 2011 11:57:35 +0000 (11:57 +0000)]
2011-01-27  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        IndexedDB: Remove IDBCallbacks::onSuccess() used for null values.
        https://bugs.webkit.org/show_bug.cgi?id=53178

        Remove the IDBCallbacks::onSuccess() function that was used for
        null values, and replace such calls with calls to
        IDBCallBacks::onSuccess(SerializedScriptValue::nullValue())
        instead.

        No new functionality, so no new tests.

        * storage/IDBCallbacks.h:
        * storage/IDBCursorBackendImpl.cpp:
        (WebCore::IDBCursorBackendImpl::updateInternal):
        (WebCore::IDBCursorBackendImpl::continueFunctionInternal):
        * storage/IDBIndexBackendImpl.cpp:
        (WebCore::IDBIndexBackendImpl::openCursorInternal):
        * storage/IDBObjectStoreBackendImpl.cpp:
        (WebCore::IDBObjectStoreBackendImpl::deleteInternal):
        (WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
        * storage/IDBRequest.cpp:
        * storage/IDBRequest.h:
2011-01-27  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        IndexedDB: Remove IDBCallbacks::onSuccess() used for null values.
        https://bugs.webkit.org/show_bug.cgi?id=53178

        Remove the IDBCallbacks::onSuccess() function that was used for
        null values, and replace such calls with calls to
        IDBCallBacks::onSuccess(SerializedScriptValue::nullValue())
        instead.

        * public/WebIDBCallbacks.h:
        (WebKit::WebIDBCallbacks::onSuccess):
        * src/IDBCallbacksProxy.cpp:
        * src/IDBCallbacksProxy.h:
        * src/WebIDBCallbacksImpl.cpp:
        * src/WebIDBCallbacksImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 27 Jan 2011 11:54:23 +0000 (11:54 +0000)]
2011-01-27  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skipping 2 more media tests.

        [GStreamer] wrong media duration report in media/controls-after-reload.html
        https://bugs.webkit.org/show_bug.cgi?id=51602

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Thu, 27 Jan 2011 11:38:09 +0000 (11:38 +0000)]
2011-01-27  Yuzo Fujishima  <yuzo@google.com>

        Unreviewed Chromium test expectation change.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Thu, 27 Jan 2011 11:27:40 +0000 (11:27 +0000)]
2011-01-27  Yuzo Fujishima  <yuzo@google.com>

        Unreviewed Chromium test expectation change.

        * platform/chromium-mac-leopard/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum: Removed.
        * platform/chromium-mac-leopard/css2.1/t0905-c5525-fltcont-00-d-g-expected.png: Removed.
        * platform/chromium-mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.checksum: Removed.
        * platform/chromium-mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.png: Removed.
        * platform/chromium-mac-leopard/fast/multicol/shadow-breaking-expected.checksum: Removed.
        * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-1-expected.checksum: Removed.
        * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-1-expected.png: Removed.
        * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-10-expected.checksum: Removed.
        * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-10-expected.png: Removed.
        * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-2-expected.checksum: Removed.
        * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-2-expected.png: Removed.
        * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-3-expected.checksum: Removed.
        * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-3-expected.png: Removed.
        * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-4-expected.checksum: Removed.
        * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-4-expected.png: Removed.
        * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-5-expected.checksum: Removed.
        * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-5-expected.png: Removed.
        * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-6-expected.checksum: Removed.
        * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-6-expected.png: Removed.
        * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-7-expected.checksum: Removed.
        * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-7-expected.png: Removed.
        * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-8-expected.checksum: Removed.
        * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-8-expected.png: Removed.
        * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-9-expected.checksum: Removed.
        * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-9-expected.png: Removed.
        * platform/chromium-mac-leopard/fast/text/complex-text-opacity-expected.checksum: Removed.
        * platform/chromium-mac-leopard/fast/text/complex-text-opacity-expected.png: Removed.
        * platform/chromium-mac-leopard/fast/text/complex-text-opacity-expected.txt: Removed.
        * platform/chromium-mac-leopard/tables/mozilla/marvin/x_thead_align_justify-expected.checksum: Removed.
        * platform/chromium-mac-leopard/tables/mozilla/marvin/x_thead_align_justify-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
mjs@apple.com [Thu, 27 Jan 2011 11:13:38 +0000 (11:13 +0000)]
Unreviewed.

Fix mistake in my previous commit; I accidentally copied the old mac results instead
of the new mac results for this test.

* platform/mac-wk2/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
ossy@webkit.org [Thu, 27 Jan 2011 10:51:51 +0000 (10:51 +0000)]
Unreviewed.

Add Qt specific expected results for new passing tests introduced in r76726.
Compared to Mac png files and Mac expected files.

* platform/qt/fast/multicol/vertical-lr/border-padding-pagination-expected.checksum: Added.
* platform/qt/fast/multicol/vertical-lr/border-padding-pagination-expected.png: Added.
* platform/qt/fast/multicol/vertical-lr/border-padding-pagination-expected.txt: Added.
* platform/qt/fast/multicol/vertical-lr/column-break-with-balancing-expected.checksum: Added.
* platform/qt/fast/multicol/vertical-lr/column-break-with-balancing-expected.png: Added.
* platform/qt/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt: Added.
* platform/qt/fast/multicol/vertical-lr/column-rules-expected.checksum: Added.
* platform/qt/fast/multicol/vertical-lr/column-rules-expected.png: Added.
* platform/qt/fast/multicol/vertical-lr/column-rules-expected.txt: Added.
* platform/qt/fast/multicol/vertical-lr/float-avoidance-expected.checksum: Added.
* platform/qt/fast/multicol/vertical-lr/float-avoidance-expected.png: Added.
* platform/qt/fast/multicol/vertical-lr/float-avoidance-expected.txt: Added.
* platform/qt/fast/multicol/vertical-lr/float-multicol-expected.checksum: Added.
* platform/qt/fast/multicol/vertical-lr/float-multicol-expected.png: Added.
* platform/qt/fast/multicol/vertical-lr/float-multicol-expected.txt: Added.
* platform/qt/fast/multicol/vertical-lr/float-paginate-complex-expected.checksum: Added.
* platform/qt/fast/multicol/vertical-lr/float-paginate-complex-expected.png: Added.
* platform/qt/fast/multicol/vertical-lr/float-paginate-complex-expected.txt: Added.
* platform/qt/fast/multicol/vertical-lr/float-paginate-expected.checksum: Added.
* platform/qt/fast/multicol/vertical-lr/float-paginate-expected.png: Added.
* platform/qt/fast/multicol/vertical-lr/float-paginate-expected.txt: Added.
* platform/qt/fast/multicol/vertical-lr/nested-columns-expected.checksum: Added.
* platform/qt/fast/multicol/vertical-lr/nested-columns-expected.png: Added.
* platform/qt/fast/multicol/vertical-lr/nested-columns-expected.txt: Added.
* platform/qt/fast/multicol/vertical-lr/unsplittable-inline-block-expected.checksum: Added.
* platform/qt/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png: Added.
* platform/qt/fast/multicol/vertical-lr/unsplittable-inline-block-expected.txt: Added.
* platform/qt/fast/multicol/vertical-rl/border-padding-pagination-expected.checksum: Added.
* platform/qt/fast/multicol/vertical-rl/border-padding-pagination-expected.png: Added.
* platform/qt/fast/multicol/vertical-rl/border-padding-pagination-expected.txt: Added.
* platform/qt/fast/multicol/vertical-rl/column-break-with-balancing-expected.checksum: Added.
* platform/qt/fast/multicol/vertical-rl/column-break-with-balancing-expected.png: Added.
* platform/qt/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt: Added.
* platform/qt/fast/multicol/vertical-rl/column-rules-expected.checksum: Added.
* platform/qt/fast/multicol/vertical-rl/column-rules-expected.png: Added.
* platform/qt/fast/multicol/vertical-rl/column-rules-expected.txt: Added.
* platform/qt/fast/multicol/vertical-rl/float-avoidance-expected.checksum: Added.
* platform/qt/fast/multicol/vertical-rl/float-avoidance-expected.png: Added.
* platform/qt/fast/multicol/vertical-rl/float-avoidance-expected.txt: Added.
* platform/qt/fast/multicol/vertical-rl/float-multicol-expected.checksum: Added.
* platform/qt/fast/multicol/vertical-rl/float-multicol-expected.png: Added.
* platform/qt/fast/multicol/vertical-rl/float-multicol-expected.txt: Added.
* platform/qt/fast/multicol/vertical-rl/float-paginate-complex-expected.checksum: Added.
* platform/qt/fast/multicol/vertical-rl/float-paginate-complex-expected.png: Added.
* platform/qt/fast/multicol/vertical-rl/float-paginate-complex-expected.txt: Added.
* platform/qt/fast/multicol/vertical-rl/float-paginate-expected.checksum: Added.
* platform/qt/fast/multicol/vertical-rl/float-paginate-expected.png: Added.
* platform/qt/fast/multicol/vertical-rl/float-paginate-expected.txt: Added.
* platform/qt/fast/multicol/vertical-rl/nested-columns-expected.checksum: Added.
* platform/qt/fast/multicol/vertical-rl/nested-columns-expected.png: Added.
* platform/qt/fast/multicol/vertical-rl/nested-columns-expected.txt: Added.
* platform/qt/fast/multicol/vertical-rl/unsplittable-inline-block-expected.checksum: Added.
* platform/qt/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png: Added.
* platform/qt/fast/multicol/vertical-rl/unsplittable-inline-block-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Add simple zooming features to MiniBrowser
zoltan@webkit.org [Thu, 27 Jan 2011 10:25:17 +0000 (10:25 +0000)]
[Qt] Add simple zooming features to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=53231

Reviewed by Andreas Kling.

Add View menu and Zoom In, Zoom Out, Zoom Reset actions to MiniBrowser.

* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
(BrowserWindow::zoomIn):
(BrowserWindow::zoomOut):
(BrowserWindow::resetZoom):
(BrowserWindow::updateUserAgentList):
(BrowserWindow::applyZoom):
* MiniBrowser/qt/BrowserWindow.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Sheriff Bot <webkit.review.bot@gmail.com>
philn@webkit.org [Thu, 27 Jan 2011 10:00:24 +0000 (10:00 +0000)]
2011-01-27  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r76773.
        http://trac.webkit.org/changeset/76773
        https://bugs.webkit.org/show_bug.cgi?id=53230

        breaks multiple GTK media tests (Requested by philn-tp on
        #webkit).

        * platform/gtk/Skipped:
2011-01-27  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r76773.
        http://trac.webkit.org/changeset/76773
        https://bugs.webkit.org/show_bug.cgi?id=53230

        breaks multiple GTK media tests (Requested by philn-tp on
        #webkit).

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::mimeTypeCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Thu, 27 Jan 2011 09:41:11 +0000 (09:41 +0000)]
2011-01-27  Yuzo Fujishima  <yuzo@google.com>

        Unreviewed Chromium test expectaion change.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Sheriff Bot <webkit.review.bot@gmail.com>
yurys@chromium.org [Thu, 27 Jan 2011 09:34:33 +0000 (09:34 +0000)]
2011-01-27  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r76770.
        http://trac.webkit.org/changeset/76770
        https://bugs.webkit.org/show_bug.cgi?id=53229

        Some inspector tests fail (Requested by yurys on #webkit).

        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.exp.in:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::isDebuggerAlwaysEnabled):
        * bindings/js/ScriptDebugServer.h:
        * bindings/js/ScriptProfiler.cpp:
        (WebCore::ScriptProfiler::isProfilerAlwaysEnabled):
        * bindings/js/ScriptProfiler.h:
        * bindings/v8/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::isDebuggerAlwaysEnabled):
        * bindings/v8/ScriptDebugServer.h:
        * bindings/v8/ScriptProfiler.cpp:
        (WebCore::ScriptProfiler::isProfilerAlwaysEnabled):
        * bindings/v8/ScriptProfiler.h:
        * inspector/Inspector.idl:
        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::InspectorAgent):
        (WebCore::InspectorAgent::disconnectFrontend):
        (WebCore::InspectorAgent::restoreDebugger):
        (WebCore::InspectorAgent::restoreProfiler):
        (WebCore::InspectorAgent::ensureSettingsLoaded):
        (WebCore::InspectorAgent::enableProfiler):
        (WebCore::InspectorAgent::disableProfiler):
        (WebCore::InspectorAgent::showAndEnableDebugger):
        (WebCore::InspectorAgent::enableDebugger):
        (WebCore::InspectorAgent::disableDebugger):
        * inspector/InspectorAgent.h:
        (WebCore::InspectorAgent::settings):
        * inspector/InspectorConsoleAgent.cpp:
        (WebCore::InspectorConsoleAgent::setMonitoringXHREnabled):
        (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::InspectorDebuggerAgent::isDebuggerAlwaysEnabled):
        * inspector/InspectorDebuggerAgent.h:
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::identifierForInitialRequestImpl):
        (WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCacheImpl):
        * inspector/InspectorProfilerAgent.cpp:
        (WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
        (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
        * inspector/InspectorSettings.cpp: Added.
        (WebCore::InspectorSettings::InspectorSettings):
        (WebCore::InspectorSettings::getBoolean):
        (WebCore::InspectorSettings::setBoolean):
        (WebCore::InspectorSettings::getLong):
        (WebCore::InspectorSettings::setLong):
        (WebCore::InspectorSettings::registerBoolean):
        (WebCore::InspectorSettings::registerLong):
        * inspector/InspectorSettings.h: Copied from Source/WebCore/bindings/v8/ScriptProfiler.h.
        * inspector/InspectorState.cpp:
        (WebCore::InspectorState::InspectorState):
        * inspector/InspectorState.h:
        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.monitoringXHRStateChanged):
        (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher):
        (WebInspector.ConsoleView.prototype._handleContextMenuEvent):
        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype._toggleProfiling):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._toggleDebugging):
        * inspector/front-end/Settings.js:
        (WebInspector.Settings):
        * inspector/front-end/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Thu, 27 Jan 2011 09:08:36 +0000 (09:08 +0000)]
2011-01-27  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Dan Bernstein.

        Add or update WebKit2-specific results to account for different reporting of scroll position
        https://bugs.webkit.org/show_bug.cgi?id=53226

        * platform/mac-wk2/fast/multicol: Added.
        * platform/mac-wk2/fast/multicol/vertical-rl: Added.
        * platform/mac-wk2/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt: Added.
        * platform/mac-wk2/fast/multicol/vertical-rl/float-paginate-complex-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-26 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 27 Jan 2011 08:55:04 +0000 (08:55 +0000)]
2011-01-26  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] LayoutTests/media/audio-mpeg4-supported.html fails
        https://bugs.webkit.org/show_bug.cgi?id=53125

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::mimeTypeCache): Add audio/x-m4a mimetype in the cache.

2011-01-26  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] LayoutTests/media/audio-mpeg4-supported.html fails
        https://bugs.webkit.org/show_bug.cgi?id=53125

        * platform/gtk/Skipped: Unskip fixed test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 27 Jan 2011 08:43:25 +0000 (08:43 +0000)]
2011-01-27  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, updated GTK baselines after r76726.

        * platform/gtk/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:
        * platform/gtk/fast/blockflow/vertical-baseline-alignment-expected.txt:
        * platform/gtk/fast/lists/002-vertical-expected.txt:
        * platform/gtk/fast/lists/003-vertical-expected.txt:
        * platform/gtk/fast/overflow/overflow-rtl-vertical-expected.txt:
        * platform/gtk/fast/table/028-vertical-expected.txt:
        * platform/gtk/fast/table/border-collapsing/003-vertical-expected.txt:
        * platform/gtk/fast/table/height-percent-test-vertical-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Thu, 27 Jan 2011 08:38:41 +0000 (08:38 +0000)]
2011-01-27  Yuzo Fujishima  <yuzo@google.com>

        Unreviewed Chromium test expectation change.

        Update expectation for r76760.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-26 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Thu, 27 Jan 2011 08:36:21 +0000 (08:36 +0000)]
2011-01-26  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: store all settings related to the agents on the frontend side
        https://bugs.webkit.org/show_bug.cgi?id=53174

        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.exp.in:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * inspector/Inspector.idl:
        * inspector/InspectorAgent.cpp: profiler and debugger enablement state is now stored
        on the front-end side and will be pushed to the backend when the frontend is loaded.
        (WebCore::InspectorAgent::InspectorAgent):
        (WebCore::InspectorAgent::disconnectFrontend):
        (WebCore::InspectorAgent::restoreDebugger):
        (WebCore::InspectorAgent::restoreProfiler):
        (WebCore::InspectorAgent::enableProfiler):
        (WebCore::InspectorAgent::disableProfiler):
        (WebCore::InspectorAgent::showAndEnableDebugger):
        (WebCore::InspectorAgent::enableDebugger):
        (WebCore::InspectorAgent::disableDebugger):
        * inspector/InspectorAgent.h:
        * inspector/InspectorConsoleAgent.cpp: XHR failures will be logged to the console only
        if the front-end was opened during current browser session and XHR logging is turned on
        there.
        (WebCore::InspectorConsoleAgent::setMonitoringXHREnabled):
        (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::identifierForInitialRequestImpl):
        (WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCacheImpl):
        * inspector/InspectorProfilerAgent.cpp:
        (WebCore::InspectorProfilerAgent::enable):
        (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
        * inspector/InspectorProfilerAgent.h:
        * inspector/InspectorSettings.cpp: Removed.
        * inspector/InspectorSettings.h: Removed.
        * inspector/InspectorState.cpp:
        (WebCore::InspectorState::InspectorState):
        * inspector/InspectorState.h:
        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.consoleMessagesCleared):
        (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher):
        (WebInspector.ConsoleView.prototype._handleContextMenuEvent.itemAction):
        (WebInspector.ConsoleView.prototype._handleContextMenuEvent):
        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype._toggleProfiling):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._toggleDebugging):
        * inspector/front-end/Settings.js:
        (WebInspector.Settings):
        * inspector/front-end/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-26 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Thu, 27 Jan 2011 08:32:51 +0000 (08:32 +0000)]
2011-01-26  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Dan Bernstein.

        WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
        https://bugs.webkit.org/show_bug.cgi?id=42319

        Unskip inspector tests (except the few that mysteriously fail).

        * platform/mac-wk2/Skipped:
2011-01-26  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Dan Bernstein.

        WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
        https://bugs.webkit.org/show_bug.cgi?id=42319

        Add evaluateInWebInspector and other APIs needed for inspector tests to run.

        * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
        * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
        (WTR::LayoutTestController::showWebInspector):
        (WTR::LayoutTestController::closeWebInspector):
        (WTR::LayoutTestController::evaluateInWebInspector):
        (WTR::LayoutTestController::setTimelineProfilingEnabled):
        * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
        * WebKitTestRunner/TestInvocation.cpp:
        (WTR::shouldOpenWebInspector):
        (WTR::TestInvocation::invoke):
        * WebKitTestRunner/WebKitTestRunnerPrefix.h:
2011-01-26  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Dan Bernstein.

        WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
        https://bugs.webkit.org/show_bug.cgi?id=42319

        Add WKBundleInspector and APIs needed to implement WebKitTestRunner APIs.

        * GNUmakefile.am:
        * Shared/API/c/WKBase.h:
        * Shared/APIObject.h:
        * WebKit2.pro:
        * WebKit2.xcodeproj/project.pbxproj:
        * WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
        * WebProcess/InjectedBundle/API/c/WKBundleInspector.cpp: Added.
        (WKBundleInspectorGetTypeID):
        (WKBundleInspectorShow):
        (WKBundleInspectorClose):
        (WKBundleInspectorEvaluateScriptForTest):
        (WKBundleInspectorSetPageProfilingEnabled):
        * WebProcess/InjectedBundle/API/c/WKBundleInspector.h: Added.
        * WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
        (WKBundlePageGetInspector):
        * WebProcess/InjectedBundle/API/c/WKBundlePage.h:
        * WebProcess/WebPage/WebInspector.cpp:
        (WebKit::WebInspector::create):
        (WebKit::WebInspector::evaluateScriptForTest):
        * WebProcess/WebPage/WebInspector.h:
        (WebKit::WebInspector::type):
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::inspector):
        * WebProcess/WebPage/WebPage.h:
        * win/WebKit2.vcproj:
        * win/WebKit2Generated.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r76743): Uneven spacing in right-to-left justified text
mitz@apple.com [Thu, 27 Jan 2011 08:23:31 +0000 (08:23 +0000)]
REGRESSION (r76743): Uneven spacing in right-to-left justified text
https://bugs.webkit.org/show_bug.cgi?id=53225

Reviewed by Sam Weinig.

Fixes failure in fast/text/atsui-spacing-features.html

There was an inconsistency between rendering code and font code in the interpretation of
'after expansion' and 'trailing expansion'. Changed all code to interpret these in terms of
visual order rather than logical.

* platform/graphics/Font.cpp:
(WebCore::Font::expansionOpportunityCount): Added a text direction parameter and changed to
iterate in visual order accordingly.
* platform/graphics/Font.h:
* platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::WidthIterator): Pass the run direction to expansionOpportunityCount().
(WebCore::WidthIterator::advance): For right-to-left runs, evaluate the trailing expansion
condition with respect to the first character, which is the trailing character in visual order.
* platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::ComplexTextController): Pass the run direction to
expansionOpportunityCount().
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Thu, 27 Jan 2011 08:15:59 +0000 (08:15 +0000)]
2011-01-27  Yuzo Fujishima  <yuzo@google.com>

        Unreviewed Chromium test expectation change.

        Another test expectation update for r76743.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
ossy@webkit.org [Thu, 27 Jan 2011 07:42:42 +0000 (07:42 +0000)]
Unreviewed.

[Qt] Update test expectations after r76726.

* platform/qt/fast/lists/002-vertical-expected.checksum:
* platform/qt/fast/lists/002-vertical-expected.png:
* platform/qt/fast/lists/002-vertical-expected.txt:
* platform/qt/fast/lists/003-vertical-expected.checksum:
* platform/qt/fast/lists/003-vertical-expected.png:
* platform/qt/fast/lists/003-vertical-expected.txt:
* platform/qt/fast/overflow/overflow-rtl-vertical-expected.checksum:
* platform/qt/fast/overflow/overflow-rtl-vertical-expected.png:
* platform/qt/fast/overflow/overflow-rtl-vertical-expected.txt:
* platform/qt/fast/table/028-vertical-expected.checksum:
* platform/qt/fast/table/028-vertical-expected.png:
* platform/qt/fast/table/028-vertical-expected.txt:
* platform/qt/fast/table/border-collapsing/003-vertical-expected.checksum:
* platform/qt/fast/table/border-collapsing/003-vertical-expected.png:
* platform/qt/fast/table/border-collapsing/003-vertical-expected.txt:
* platform/qt/fast/table/height-percent-test-vertical-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-26 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Thu, 27 Jan 2011 07:14:01 +0000 (07:14 +0000)]
2011-01-26  Yuzo Fujishima  <yuzo@google.com>

        Unreviewed Chromium test expectation change.

        Update test expectations for r76743

        * platform/chromium-linux/css1/box_properties/clear_float-expected.checksum:
        * platform/chromium-linux/css1/box_properties/clear_float-expected.png:
        * platform/chromium-linux/css1/box_properties/float_elements_in_series-expected.checksum:
        * platform/chromium-linux/css1/box_properties/float_elements_in_series-expected.png:
        * platform/chromium-linux/css1/box_properties/float_on_text_elements-expected.checksum:
        * platform/chromium-linux/css1/box_properties/float_on_text_elements-expected.png:
        * platform/chromium-linux/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
        * platform/chromium-linux/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
        * platform/chromium-linux/fast/multicol/shadow-breaking-expected.checksum:
        * platform/chromium-linux/fast/multicol/shadow-breaking-expected.png: Added.
        * platform/chromium-linux/fast/repaint/line-flow-with-floats-1-expected.checksum:
        * platform/chromium-linux/fast/repaint/line-flow-with-floats-1-expected.png:
        * platform/chromium-linux/fast/repaint/line-flow-with-floats-10-expected.checksum:
        * platform/chromium-linux/fast/repaint/line-flow-with-floats-10-expected.png:
        * platform/chromium-linux/fast/repaint/line-flow-with-floats-2-expected.checksum:
        * platform/chromium-linux/fast/repaint/line-flow-with-floats-2-expected.png:
        * platform/chromium-linux/fast/repaint/line-flow-with-floats-3-expected.checksum:
        * platform/chromium-linux/fast/repaint/line-flow-with-floats-3-expected.png:
        * platform/chromium-linux/fast/repaint/line-flow-with-floats-4-expected.checksum:
        * platform/chromium-linux/fast/repaint/line-flow-with-floats-4-expected.png:
        * platform/chromium-linux/fast/repaint/line-flow-with-floats-5-expected.checksum:
        * platform/chromium-linux/fast/repaint/line-flow-with-floats-5-expected.png:
        * platform/chromium-linux/fast/repaint/line-flow-with-floats-6-expected.checksum:
        * platform/chromium-linux/fast/repaint/line-flow-with-floats-6-expected.png:
        * platform/chromium-linux/fast/repaint/line-flow-with-floats-7-expected.checksum:
        * platform/chromium-linux/fast/repaint/line-flow-with-floats-7-expected.png:
        * platform/chromium-linux/fast/repaint/line-flow-with-floats-8-expected.checksum:
        * platform/chromium-linux/fast/repaint/line-flow-with-floats-8-expected.png:
        * platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.checksum:
        * platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png:
        * platform/chromium-linux/tables/mozilla/marvin/x_tr_align_justify-expected.checksum:
        * platform/chromium-linux/tables/mozilla/marvin/x_tr_align_justify-expected.png:
        * platform/chromium-mac/css1/box_properties/clear_float-expected.checksum: Added.
        * platform/chromium-mac/css1/box_properties/clear_float-expected.png: Added.
        * platform/chromium-mac/css1/box_properties/float_on_text_elements-expected.checksum: Added.
        * platform/chromium-mac/css1/box_properties/float_on_text_elements-expected.png: Added.
        * platform/chromium-mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum: Added.
        * platform/chromium-mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png: Added.
        * platform/chromium-mac/fast/multicol/shadow-breaking-expected.checksum: Added.
        * platform/chromium-mac/fast/multicol/shadow-breaking-expected.png: Added.
        * platform/chromium-mac/fast/repaint/line-flow-with-floats-1-expected.checksum:
        * platform/chromium-mac/fast/repaint/line-flow-with-floats-1-expected.png:
        * platform/chromium-mac/fast/repaint/line-flow-with-floats-10-expected.checksum:
        * platform/chromium-mac/fast/repaint/line-flow-with-floats-10-expected.png:
        * platform/chromium-mac/fast/repaint/line-flow-with-floats-2-expected.checksum:
        * platform/chromium-mac/fast/repaint/line-flow-with-floats-2-expected.png:
        * platform/chromium-mac/fast/repaint/line-flow-with-floats-3-expected.checksum:
        * platform/chromium-mac/fast/repaint/line-flow-with-floats-3-expected.png:
        * platform/chromium-mac/fast/repaint/line-flow-with-floats-4-expected.checksum:
        * platform/chromium-mac/fast/repaint/line-flow-with-floats-4-expected.png:
        * platform/chromium-mac/fast/repaint/line-flow-with-floats-5-expected.checksum:
        * platform/chromium-mac/fast/repaint/line-flow-with-floats-5-expected.png:
        * platform/chromium-mac/fast/repaint/line-flow-with-floats-6-expected.checksum:
        * platform/chromium-mac/fast/repaint/line-flow-with-floats-6-expected.png:
        * platform/chromium-mac/fast/repaint/line-flow-with-floats-7-expected.checksum:
        * platform/chromium-mac/fast/repaint/line-flow-with-floats-7-expected.png:
        * platform/chromium-mac/fast/repaint/line-flow-with-floats-8-expected.checksum:
        * platform/chromium-mac/fast/repaint/line-flow-with-floats-8-expected.png:
        * platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.checksum:
        * platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.png:
        * platform/chromium-win/css1/box_properties/clear_float-expected.checksum:
        * platform/chromium-win/css1/box_properties/clear_float-expected.png:
        * platform/chromium-win/css1/box_properties/float_elements_in_series-expected.checksum:
        * platform/chromium-win/css1/box_properties/float_elements_in_series-expected.png:
        * platform/chromium-win/css1/box_properties/float_on_text_elements-expected.checksum:
        * platform/chromium-win/css1/box_properties/float_on_text_elements-expected.png:
        * platform/chromium-win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
        * platform/chromium-win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
        * platform/chromium-win/fast/multicol/shadow-breaking-expected.checksum:
        * platform/chromium-win/fast/multicol/shadow-breaking-expected.png:
        * platform/chromium-win/fast/repaint/line-flow-with-floats-1-expected.checksum:
        * platform/chromium-win/fast/repaint/line-flow-with-floats-1-expected.png:
        * platform/chromium-win/fast/repaint/line-flow-with-floats-10-expected.checksum:
        * platform/chromium-win/fast/repaint/line-flow-with-floats-10-expected.png:
        * platform/chromium-win/fast/repaint/line-flow-with-floats-2-expected.checksum:
        * platform/chromium-win/fast/repaint/line-flow-with-floats-2-expected.png:
        * platform/chromium-win/fast/repaint/line-flow-with-floats-3-expected.checksum:
        * platform/chromium-win/fast/repaint/line-flow-with-floats-3-expected.png:
        * platform/chromium-win/fast/repaint/line-flow-with-floats-4-expected.checksum:
        * platform/chromium-win/fast/repaint/line-flow-with-floats-4-expected.png:
        * platform/chromium-win/fast/repaint/line-flow-with-floats-5-expected.checksum:
        * platform/chromium-win/fast/repaint/line-flow-with-floats-5-expected.png:
        * platform/chromium-win/fast/repaint/line-flow-with-floats-6-expected.checksum:
        * platform/chromium-win/fast/repaint/line-flow-with-floats-6-expected.png:
        * platform/chromium-win/fast/repaint/line-flow-with-floats-7-expected.checksum:
        * platform/chromium-win/fast/repaint/line-flow-with-floats-7-expected.png:
        * platform/chromium-win/fast/repaint/line-flow-with-floats-8-expected.checksum:
        * platform/chromium-win/fast/repaint/line-flow-with-floats-8-expected.png:
        * platform/chromium-win/svg/custom/svg-fonts-in-html-expected.checksum:
        * platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
        * platform/chromium-win/tables/mozilla/marvin/x_tr_align_justify-expected.checksum:
        * platform/chromium-win/tables/mozilla/marvin/x_tr_align_justify-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDon't create the Direct3D device before it's first needed
aroben@apple.com [Thu, 27 Jan 2011 06:41:35 +0000 (06:41 +0000)]
Don't create the Direct3D device before it's first needed

We only need the device once we decide to render. There's no point in creating it before
then.

Reviewed by Sam Weinig.

* platform/graphics/ca/win/CACFLayerTreeHost.cpp:
(WebCore::CACFLayerTreeHost::setWindow): Removed the call to createRenderer() from here.
We already have code to create it when we first try to draw.
(WebCore::CACFLayerTreeHost::createRenderer): Flush the context after we set our layer's
bounds so that the bounds will take effect the next time we render (which could be just
after this function returns).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd assertions that CACFLayerTreeHost gains and loses an HWND only once
aroben@apple.com [Thu, 27 Jan 2011 06:40:54 +0000 (06:40 +0000)]
Add assertions that CACFLayerTreeHost gains and loses an HWND only once

CACFLayerTreeHost doesn't support any other use pattern.

Reviewed by Sam Weinig.

* platform/graphics/ca/win/CACFLayerTreeHost.cpp:
(WebCore::CACFLayerTreeHost::CACFLayerTreeHost): Initialize new member.
(WebCore::CACFLayerTreeHost::setWindow): Assert that we transition from not having a window,
to having a window, to not having a window just once over the lifetime of this object.

* platform/graphics/ca/win/CACFLayerTreeHost.h: Added m_state.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNotify layers that their animations have started when we flush the context, not when...
aroben@apple.com [Thu, 27 Jan 2011 06:40:14 +0000 (06:40 +0000)]
Notify layers that their animations have started when we flush the context, not when we render

r76372 separated context flushing from rendering, but this bit of code got left behind.

Reviewed by Sam Weinig.

* platform/graphics/ca/win/CACFLayerTreeHost.cpp:
(WebCore::CACFLayerTreeHost::render): Moved code to notify the layers from here to
notifyAnimationsStarted.
(WebCore::CACFLayerTreeHost::flushPendingLayerChangesNow): Added a call to
notifyAnimationsStarted after we flush the context.
(WebCore::CACFLayerTreeHost::notifyAnimationsStarted): Added. Code came from render. Changed
to call PlatformCALayer::animationStarted rather than calling through to the client
directly.

* platform/graphics/ca/win/CACFLayerTreeHost.h: Added notifyAniamtionsStarted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSmall cleanup in MediaPlayerPrivateFullscreenWindow
aroben@apple.com [Thu, 27 Jan 2011 06:39:12 +0000 (06:39 +0000)]
Small cleanup in MediaPlayerPrivateFullscreenWindow

Reviewed by Sam Weinig.

* platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
(WebCore::MediaPlayerPrivateFullscreenWindow::~MediaPlayerPrivateFullscreenWindow): Moved
code here from close(), since this was the only place that called it after the following
change to createWindow.
(WebCore::MediaPlayerPrivateFullscreenWindow::createWindow): Replaced code that handled the
case where we had already created the window with an assertion that we have not already done
so. Our single caller (FullscreenVideoController) did not require this behavior.

* platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h: Removed layerView.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdated results for the html.css changes in r76726. The old results were prepared...
mitz@apple.com [Thu, 27 Jan 2011 06:31:58 +0000 (06:31 +0000)]
Updated results for the html.css changes in r76726. The old results were prepared before
r76726.

* platform/mac/fast/text/justify-ideograph-vertical-expected.checksum:
* platform/mac/fast/text/justify-ideograph-vertical-expected.png:
* platform/mac/fast/text/justify-ideograph-vertical-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-26 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Thu, 27 Jan 2011 06:30:53 +0000 (06:30 +0000)]
2011-01-26  Yuzo Fujishima  <yuzo@google.com>

        Unreviewed Chromium test expectation change.

        fast/text/justify-ideograph-vertical.html crashes on LINUX.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-26 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Thu, 27 Jan 2011 05:59:31 +0000 (05:59 +0000)]
2011-01-26  Yuzo Fujishima  <yuzo@google.com>

        Unreviewed Chromium test expectation change.

        Mark the tests started failing at http://trac.webkit.org/changeset/76726 as such.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove ScrollView scroll wheel code to ScrollAnimator.
weinig@apple.com [Thu, 27 Jan 2011 05:12:24 +0000 (05:12 +0000)]
Move ScrollView scroll wheel code to ScrollAnimator.

Reviewed by Adam Roben.

* platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::handleWheelEvent):
* platform/ScrollAnimator.h:
Moved implementation of handleWheelEvent from ScrollView::wheelEvent.

* platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
Call down to the ScrollableArea.

* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::handleWheelEvent):
Call down to the ScrollAnimator.

* platform/ScrollableArea.h:
(WebCore::ScrollableArea::scrollPosition):
(WebCore::ScrollableArea::minimumScrollPosition):
(WebCore::ScrollableArea::maximumScrollPosition):
(WebCore::ScrollableArea::visibleContentRect):
(WebCore::ScrollableArea::visibleHeight):
(WebCore::ScrollableArea::visibleWidth):
Add functions needed to implement wheel event in the animator.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76757 268f45cc-cd09-0410-ab3c-d52691b4dbfc