WebKit-https.git
13 years agoWebCore:
beidson [Tue, 19 Sep 2006 02:21:52 +0000 (02:21 +0000)]
WebCore:

        Reviewed by Anders

        <rdar://problem/3028061> - WebKit never updates favicon
        The WebKit enforced expiration date for icons has worked for some time, but the
        move to the new Icon Loader broke the "always get the icon if the user refreshes the page"
        functionality.  This patch fixes that up, along with some other architectural improvements,
        the main one being that WebCore::Document now contains an iconURL for the Frame to query if needed.

        * bridge/mac/FrameMac.h: Added isLoadTypeReload()
        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::isLoadTypeReload): Implementation, calls into the bridge
        * bridge/mac/WebCoreFrameBridge.h: Added isLoadTypeReload:
        * bridge/win/FrameWin.h: Added isLoadTypeReload() for temporary link stub
        * dom/Document.h: Added m_iconURL
        (WebCore::Document::iconURL): Added
        (WebCore::Document::setIconURL): Ditto
        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::process): Sets the iconURL in the Document instead of the Frame
        * page/Frame.cpp:
        (WebCore::Frame::iconURL): Calculates the iconURL based on the document, then the default favicon.ico url
        (WebCore::Frame::endIfNotLoading): Checks for the load type - always loads icon on Reload
        * page/Frame.h: Nuked setIconURL(), added isLoadTypeReload()
        * page/FramePrivate.h: Nuked IconURL
        * platform/win/TemporaryLinkStubs.cpp:
        (FrameWin::isLoadTypeReload):

WebKit:

        Reviewed by Anders

        Implement a bridge method so WebCore can find the reload type of a frame load

        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge isLoadTypeReload]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim H.
weinig [Mon, 18 Sep 2006 23:15:22 +0000 (23:15 +0000)]
    Reviewed by Tim H.

        - Re-add private method [DOMRGBColor _color] to DOMPrivate.h as
          it is it turns out that AppKit uses it.

        * bindings/objc/DOMPrivate.h:
        * bindings/objc/DOMRGBColor.mm:
        (-[DOMRGBColor _color]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
weinig [Mon, 18 Sep 2006 21:40:34 +0000 (21:40 +0000)]
WebCore:

        Reviewed by Tim H.

        Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10903
        Yet Another Objective-C Bindings Patch

        - Whitespace cleanup for IDLParser.pm

        - Split DOMException, DOMRangeException, DOMXPathException, DOMEventsException
          and DOMAbstractView into their own files.

        - Remove private method [DOMRGBColor _color] from DOMPrivate.h as
          it is not used and a public method is available now.

        - Remove internal method [DOMDocument _ownerElement] from DOMInternal.h
          as it not used.

        - Auto-generate method isContentEditable for DOMNode.

        - General cleanup of bindings code including removing unneeded #imports
          and whitespace cleanup

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/objc/DOM.mm:
        (addElementClass):
        (elementClass):
        (-[DOMNode _initWithNode:WebCore::]):
        (+[DOMNode _nodeWith:WebCore::]):
        (-[DOMNode WebCore::]):
        (-[DOMNode KJS::Bindings::]):
        (-[DOMNode addEventListener:::]):
        (-[DOMNode removeEventListener:::]):
        (-[DOMNode dispatchEvent:]):
        (-[DOMElement image]):
        (-[DOMElement _font]):
        (-[DOMElement _imageTIFFRepresentation]):
        (-[DOMElement _getURLAttribute:]):
        (-[DOMElement _NPObject]):
        (-[DOMElement isFocused]):
        (-[DOMRange dealloc]):
        (-[DOMRange finalize]):
        (-[DOMRange description]):
        (-[DOMRange startContainer]):
        (-[DOMRange startOffset]):
        (-[DOMRange endContainer]):
        (-[DOMRange endOffset]):
        (-[DOMRange collapsed]):
        (-[DOMRange commonAncestorContainer]):
        (-[DOMRange setStart::]):
        (-[DOMRange setEnd::]):
        (-[DOMRange setStartBefore:]):
        (-[DOMRange setStartAfter:]):
        (-[DOMRange setEndBefore:]):
        (-[DOMRange setEndAfter:]):
        (-[DOMRange collapse:]):
        (-[DOMRange selectNode:]):
        (-[DOMRange selectNodeContents:]):
        (-[DOMRange compareBoundaryPoints::]):
        (-[DOMRange deleteContents]):
        (-[DOMRange extractContents]):
        (-[DOMRange cloneContents]):
        (-[DOMRange insertNode:]):
        (-[DOMRange surroundContents:]):
        (-[DOMRange cloneRange]):
        (-[DOMRange toString]):
        (-[DOMRange detach]):
        (-[DOMRange _initWithRange:WebCore::]):
        (+[DOMRange _rangeWith:WebCore::]):
        (-[DOMRange WebCore::]):
        (-[DOMNodeFilter _initWithNodeFilter:WebCore::]):
        (+[DOMNodeFilter _nodeFilterWith:WebCore::]):
        (-[DOMNodeFilter WebCore::]):
        (-[DOMNodeFilter dealloc]):
        (-[DOMNodeFilter finalize]):
        (-[DOMNodeIterator _initWithNodeIterator:WebCore::filter:]):
        (-[DOMNodeIterator WebCore::]):
        (+[DOMNodeIterator _nodeIteratorWith:WebCore::filter:]):
        (-[DOMTreeWalker _initWithTreeWalker:WebCore::filter:]):
        (-[DOMTreeWalker WebCore::]):
        (+[DOMTreeWalker _treeWalkerWith:WebCore::filter:]):
        (ObjCNodeFilterCondition::acceptNode):
        (-[DOMDocument createNodeIterator::::]):
        (-[DOMDocument createTreeWalker::::]):
        (ObjCEventListener::find):
        (ObjCEventListener::create):
        (ObjCEventListener::handleEvent):
        * bindings/objc/DOMAbstractView.h: Added.
        * bindings/objc/DOMAbstractView.mm: Added.
        (-[DOMAbstractView document]):
        (-[DOMAbstractView WebCore::]):
        (-[DOMAbstractView _initWithAbstractView:WebCore::]):
        (+[DOMAbstractView _abstractViewWith:WebCore::]):
        * bindings/objc/DOMCSS.mm:
        (-[DOMStyleSheet _initWithStyleSheet:WebCore::]):
        (+[DOMStyleSheet _styleSheetWith:WebCore::]):
        (+[DOMCSSStyleSheet _CSSStyleSheetWith:WebCore::]):
        (-[DOMCSSRule _initWithRule:WebCore::]):
        (+[DOMCSSRule _CSSRuleWith:WebCore::]):
        (-[DOMCSSValue _initWithValue:WebCore::]):
        (+[DOMCSSValue _CSSValueWith:WebCore::]):
        (+[DOMCSSPrimitiveValue _CSSPrimitiveValueWith:WebCore::]):
        (-[DOMDocument getComputedStyle::]):
        (-[DOMDocument getMatchedCSSRules::]):
        * bindings/objc/DOMCore.h:
        * bindings/objc/DOMEventException.h: Added.
        * bindings/objc/DOMEvents.h:
        * bindings/objc/DOMEvents.mm:
        * bindings/objc/DOMException.h: Added.
        * bindings/objc/DOMHTML.mm:
        (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]):
        (viewForElement):
        (-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]):
        (-[DOMHTMLInputElement _selectedRange]):
        (-[DOMHTMLInputElement _setAutofilled:]):
        * bindings/objc/DOMInternal.h:
        * bindings/objc/DOMObject.h:
        * bindings/objc/DOMPrivate.h:
        * bindings/objc/DOMRange.h:
        * bindings/objc/DOMRangeException.h: Added.
        * bindings/objc/DOMViews.h:
        * bindings/objc/DOMViews.mm: Removed.
        * bindings/objc/DOMXPath.h:
        * bindings/objc/DOMXPathException.h: Added.
        * bindings/scripts/IDLParser.pm:
        * dom/Node.idl:

WebKit:

        Reviewed by Tim H.

        Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10903
        Yet Another Objective-C Bindings Patch

        * MigrateHeaders.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by John Sullivan.
harrison [Mon, 18 Sep 2006 21:37:08 +0000 (21:37 +0000)]
    Reviewed by John Sullivan.

        <rdar://problem/4494340> REGRESSION: Making the font size bigger/smaller in an HTML message doesn't affect the body until you reopen it

        Problem was the public API -[WebView setTextSizeMultiplier] did not notify anyone that the value changed.

        * WebView/WebDocumentInternal.h:
        Add _textSizeMultiplierChanged to the _WebDocumentTextSizing protocol.

        * WebView/WebHTMLView.m:
        (-[WebHTMLView _textSizeMultiplierChanged]):
        Send [self _updateTextSizeMultiplier].

        * WebView/WebPDFView.m:
        (-[WebPDFView _textSizeMultiplierChanged]):
        ASSERT_NOT_REACHED() because WebPDFView does not track the common multiplier.

        * WebView/WebView.m:
        (-[WebView setTextSizeMultiplier:]):
        Send [self _notifyTextSizeMultiplierChanged];

        (-[WebView _performTextSizingSelector:withObject:onTrackingDocs:selForNonTrackingDocs:newScaleFactor:]):
        Alter the _textSizeMultiplier directly so that notification is not sent.
        Minor formatting.

        (-[WebView _notifyTextSizeMultiplierChanged]):
        New. Send _textSizeMultiplierChanged to all document views that track the common multiplier.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoACTUAL Windows build fix
beidson [Mon, 18 Sep 2006 20:42:51 +0000 (20:42 +0000)]
ACTUAL Windows build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Windows build fix
beidson [Mon, 18 Sep 2006 20:32:07 +0000 (20:32 +0000)]
    Windows build fix

        * platform/win/TemporaryLinkStubs.cpp:
        (IconDatabase::setIconURLForPageURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd layout test for float bug.
hyatt [Mon, 18 Sep 2006 19:20:41 +0000 (19:20 +0000)]
Add layout test for float bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix for bug 3969, hr width doesn't update when it clears a float. This
hyatt [Mon, 18 Sep 2006 19:12:44 +0000 (19:12 +0000)]
    Fix for bug 3969, hr width doesn't update when it clears a float.  This
        was also a problem with tables and overflow sections.

        Reviewed by Eric

        Added fast/block/float/width-update-after-clear.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::collapseMargins):
        (WebCore::RenderBlock::clearFloatsIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUpdate table layout test results.
hyatt [Mon, 18 Sep 2006 19:07:06 +0000 (19:07 +0000)]
Update table layout test results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUpdate table layout test results.
hyatt [Mon, 18 Sep 2006 19:06:14 +0000 (19:06 +0000)]
Update table layout test results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUpdate table layout test results.
hyatt [Mon, 18 Sep 2006 19:05:07 +0000 (19:05 +0000)]
Update table layout test results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUpdate table layout test results.
hyatt [Mon, 18 Sep 2006 19:00:54 +0000 (19:00 +0000)]
Update table layout test results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUpdate table layout test results.
hyatt [Mon, 18 Sep 2006 18:55:29 +0000 (18:55 +0000)]
Update table layout test results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by John
beidson [Mon, 18 Sep 2006 18:13:26 +0000 (18:13 +0000)]
    Reviewed by John

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10907
        REGRESSION: New Icon Loaders don't handle certain non-server-root URLs correctly

        * bridge/mac/FrameMac.h: Changed originalRequestURL() to virtual
        * bridge/win/FrameWin.h: Added originalRequestURL()
        * loader/icon/IconLoader.cpp:
        (IconLoader::receivedAllData): Moved the "pageURL to iconURL mapping logic" to Frame::commitIconURLToIconDatabase()
        * page/Frame.cpp:
        (WebCore::Frame::iconURL): Construct the icon URL from *only* the protocol and host of the frame's url.
        (WebCore::Frame::endIfNotLoading): Call commitIconURLToIconDatabase() if we're not kicking off an icon load
        (WebCore::Frame::commitIconURLToIconDatabase): Map the completed doc's pageURL to the iconURL
        * page/Frame.h: Added pure virtual originalRequestURL()
        * platform/win/TemporaryLinkStubs.cpp:
        (FrameWin::originalRequestURL): Added

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBuild fix, NSIntMapValueCallBacks is deprecated infavor of the new name NSIntegerMapV...
thatcher [Mon, 18 Sep 2006 18:11:29 +0000 (18:11 +0000)]
Build fix, NSIntMapValueCallBacks is deprecated infavor of the new name NSIntegerMapValueCallBacks. Just make a new NSMapTableValueCallBacks of {NULL, NULL, NULL} to make it build on new or older systems.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej.
rwlbuis [Mon, 18 Sep 2006 09:25:48 +0000 (09:25 +0000)]
    Reviewed by Maciej.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10807
        REGRESSION (r16259): Repro crash on manual-tests/svg-repaint-image.svg

        Make sure the paint method is not exited without popping
        context and transparency layer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-18 Graham Dennis <graham.dennis@gmail.com>
bdash [Mon, 18 Sep 2006 09:16:54 +0000 (09:16 +0000)]
2006-09-18  Graham Dennis  <graham.dennis@gmail.com>

        Reviewed by Eric.

        - fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10896
        REGRESSION: WebKit can't be built with SVG disabled

        * bindings/scripts/CodeGeneratorObjC.pm:
        For each file generated add a #ifdef <something>_SUPPORT / #endif
        pair if the idl file has a Conditional extended attribute

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-17 Eric Seidel <eric@eseidel.com>
eseidel [Mon, 18 Sep 2006 06:45:54 +0000 (06:45 +0000)]
2006-09-17  Eric Seidel  <eric@eseidel.com>

        Reviewed by ap.

        REGRESSION (r16245): double-clicking on javascript exceptions fails to show source
        http://bugzilla.opendarwin.org/show_bug.cgi?id=10813

        * bridge/mac/WebCoreFrameBridge.mm:
        (+[WebCoreFrameBridge stringWithData:textEncodingName:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-17 Eric Seidel <eric@eseidel.com>
eseidel [Mon, 18 Sep 2006 06:14:46 +0000 (06:14 +0000)]
2006-09-17  Eric Seidel  <eric@eseidel.com>

        Reviewed by hyatt.

        * fast/js/window-properties.html: make work in Firefox (hangs IE)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Hyatt.
ap [Mon, 18 Sep 2006 05:03:42 +0000 (05:03 +0000)]
    Reviewed by Hyatt.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10779
        REGRESSION: Animated GIF ignores frame intervals and loops infinitely

        No test possible.

        * platform/Image.cpp:
        (WebCore::Image::shouldAnimate): Don't check that there is more than one frame,
        maybe the rest just hasn't been loaded yet.
        (WebCore::Image::startAnimation): Move the frame count check here - there is no need
        to start animating before we get at least two frames.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-17 Eric Seidel <eric@eseidel.com>
eseidel [Mon, 18 Sep 2006 04:46:30 +0000 (04:46 +0000)]
2006-09-17  Eric Seidel  <eric@eseidel.com>

        Add a textual dump of the window object property tree.

        Reviewed by Sarge.

        * fast/js/window-properties-expected.txt: Added.
        * fast/js/window-properties.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLand updated tests for font changes.
hyatt [Mon, 18 Sep 2006 00:48:19 +0000 (00:48 +0000)]
Land updated tests for font changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLand updated tests for font changes.
hyatt [Mon, 18 Sep 2006 00:46:03 +0000 (00:46 +0000)]
Land updated tests for font changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLand updated tests for font changes.
hyatt [Mon, 18 Sep 2006 00:45:07 +0000 (00:45 +0000)]
Land updated tests for font changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sarge
beidson [Sun, 17 Sep 2006 23:17:33 +0000 (23:17 +0000)]
    Reviewed by Sarge

        IconLoader now gracefully handles the condition where there's no document in the frame
        (ie. PDFs)

        * loader/icon/IconLoader.cpp:
        (IconLoader::startLoading):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix for bug 10899, rework how CSS keywords work to be smarter about
hyatt [Sun, 17 Sep 2006 23:06:47 +0000 (23:06 +0000)]
    Fix for bug 10899, rework how CSS keywords work to be smarter about
        using the correct size when generic families change (e.g., monospace to
        serif and vice versa).

        Reviewed by aroben

        Added fast/text/basic/generic-family-changes.html

        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        (WebCore::CSSStyleSelector::checkForGenericFamilyChange):
        (WebCore::CSSStyleSelector::fontSizeForKeyword):
        * css/cssstyleselector.h:
        * dom/Document.cpp:
        (WebCore::Document::recalcStyle):
        * platform/FontDescription.h:
        (WebCore::FontDescription::FontDescription):
        (WebCore::FontDescription::keywordSize):
        (WebCore::FontDescription::setKeywordSize):
        (WebCore::FontDescription::operator==):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Adding layout test for bug 10899.
hyatt [Sun, 17 Sep 2006 23:04:09 +0000 (23:04 +0000)]
    Adding layout test for bug 10899.

        * fast/text/basic/generic-family-changes-expected.checksum: Added.
        * fast/text/basic/generic-family-changes-expected.png: Added.
        * fast/text/basic/generic-family-changes-expected.txt: Added.
        * fast/text/basic/generic-family-changes.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by hyatt, sfalken.
aroben [Sun, 17 Sep 2006 21:39:49 +0000 (21:39 +0000)]
    Reviewed by hyatt, sfalken.

        Get DumpRenderTree compiling and limping along on Windows.

        * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
        (loadResourceIntoArray): Added this function that WebCore::ImageWin needs from WebKit
        (main): Add NULL argument to Page constructor.
        * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Remove incorrect "wininet.dll" argument to CC, fix JavaScriptCore.lib path, add *_SECURE_NO_DEPRECATE #defines
        * Scripts/webkitdirs.pm: Fix JavaScriptCore.lib path

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Brady.
ap [Sun, 17 Sep 2006 20:18:46 +0000 (20:18 +0000)]
    Reviewed by Brady.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10852
        REGRESSION: Reproducible crash in XMLHttpRequest::abort()

        Test: http/tests/xmlhttprequest/xhr-onunload.html

        * xml/xmlhttprequest.cpp:
        (WebCore::XMLHttpRequest::send): Check the return value of ResourceLoader::start().

        * loader/icon/IconLoader.cpp:
        (IconLoader::startLoading): Fix a similar latent bug here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Build fix.
aroben [Sun, 17 Sep 2006 19:37:26 +0000 (19:37 +0000)]
    Build fix.

        * loader/icon/IconDatabase.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLand updated results from font fix yesterday.
hyatt [Sun, 17 Sep 2006 19:24:08 +0000 (19:24 +0000)]
Land updated results from font fix yesterday.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-17 Anders Carlsson <acarlsson@apple.com>
andersca [Sun, 17 Sep 2006 18:36:23 +0000 (18:36 +0000)]
2006-09-17  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Brady.

        Add simplifyWhiteSpace and stripWhiteSpace to the String class.
        Change the XSLT Parameter Map to use Strings instead of StringImpls.
        General cleanup.

        * bindings/js/JSXSLTProcessor.cpp:
        (KJS::XSLTProcessorProtoFunc::callAsFunction):
        * bindings/js/kjs_events.cpp:
        (KJS::JSAbstractEventListener::handleEvent):
        * bindings/js/kjs_window.cpp:
        (KJS::ScheduledAction::execute):
        * css/MediaList.cpp:
        (WebCore::MediaList::setMediaText):
        * dom/Document.cpp:
        (WebCore::Document::processHttpEquiv):
        * editing/ApplyStyleCommand.cpp:
        (WebCore::StyleChange::init):
        * html/HTMLDocument.cpp:
        (WebCore::parseDocTypeDeclaration):
        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::parseMappedAttribute):
        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::HTMLObjectElement):
        (WebCore::HTMLObjectElement::parseMappedAttribute):
        (WebCore::HTMLObjectElement::attach):
        (WebCore::HTMLObjectElement::setComplete):
        (WebCore::HTMLObjectElement::detach):
        (WebCore::HTMLObjectElement::recalcStyle):
        (WebCore::HTMLObjectElement::childrenChanged):
        (WebCore::HTMLObjectElement::isImageType):
        * html/HTMLObjectElement.h:
        * html/HTMLOptionElement.cpp:
        (WebCore::HTMLOptionElement::value):
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::appendFormData):
        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::parseTag):
        * ksvg2/svg/SVGColor.cpp:
        (WebCore::SVGColor::setRGBColor):
        * ksvg2/svg/SVGDescElement.cpp:
        (WebCore::SVGDescElement::description):
        * platform/PlatformString.h:
        * platform/String.cpp:
        (WebCore::String::stripWhiteSpace):
        (WebCore::String::simplifyWhiteSpace):
        * platform/StringImpl.cpp:
        (WebCore::isSpace):
        (WebCore::parseLength):
        (WebCore::StringImpl::stripWhiteSpace):
        (WebCore::StringImpl::simplifyWhiteSpace):
        (WebCore::StringImpl::toInt):
        * platform/StringImpl.h:
        * platform/mac/ClipboardMac.mm:
        (WebCore::cocoaTypeFromMIMEType):
        * rendering/RenderPartObject.cpp:
        (WebCore::RenderPartObject::updateWidget):
        * xml/XPathFunctions.cpp:
        (WebCore::XPath::FunNormalizeSpace::doEvaluate):
        * xml/XPathGrammar.y:
        * xml/XPathStep.cpp:
        (WebCore::XPath::Step::nodeTestMatches):
        * xml/XSLStyleSheet.cpp:
        (WebCore::XSLStyleSheet::loadChildSheets):
        (WebCore::XSLStyleSheet::locateStylesheetSubResource):
        * xml/XSLTProcessor.cpp:
        (WebCore::xsltParamArrayFromParameterMap):
        (WebCore::XSLTProcessor::setParameter):
        (WebCore::XSLTProcessor::getParameter):
        (WebCore::XSLTProcessor::removeParameter):
        * xml/XSLTProcessor.h:
        * xml/xmlhttprequest.cpp:
        (WebCore::XMLHttpRequest::getStatusText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd fieldset layout test.
hyatt [Sun, 17 Sep 2006 15:28:22 +0000 (15:28 +0000)]
Add fieldset layout test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix for bugzilla bugs 10895 and 6336, fieldsets misbehaving when floats
hyatt [Sun, 17 Sep 2006 15:27:04 +0000 (15:27 +0000)]
    Fix for bugzilla bugs 10895 and 6336, fieldsets misbehaving when floats
        are declared right before the fieldsets.  It turns out fieldsets in other
        browsers avoid floats (like overflow:auto/hidden/scroll sections do), so
        adding that behavior to fieldset fixes the bug.

        Made avoidsFloats virtual and did some refactoring to make tables, flexboxes
        and fieldsets all subclass.

        Reviewed by anders

        Added fast/forms/float-before-fieldset.html

        * rendering/RenderFieldset.h:
        (WebCore::RenderFieldset::avoidsFloats):
        * rendering/RenderFlexibleBox.h:
        (WebCore::RenderFlexibleBox::avoidsFloats):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::avoidsFloats):
        * rendering/RenderObject.h:
        * rendering/RenderTable.h:
        (WebCore::RenderTable::avoidsFloats):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUpdate buggy table test to not have a degenrate column structure.
hyatt [Sun, 17 Sep 2006 14:35:52 +0000 (14:35 +0000)]
Update buggy table test to not have a degenrate column structure.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUpdate buggy table test to say rules=groups and not rules=group
hyatt [Sun, 17 Sep 2006 14:35:18 +0000 (14:35 +0000)]
Update buggy table test to say rules=groups and not rules=group

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd frame/rules layout test.
hyatt [Sun, 17 Sep 2006 08:00:57 +0000 (08:00 +0000)]
Add frame/rules layout test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix for bugzilla bug 3240, implement support for the HTML4 "frame" and
hyatt [Sun, 17 Sep 2006 07:57:56 +0000 (07:57 +0000)]
    Fix for bugzilla bug 3240, implement support for the HTML4 "frame" and
        "rules" attributes on tables.

        Reviewed by bradee-oh

        Well-covered by existing layout tests.

        * html/HTMLTableCellElement.cpp:
        (WebCore::HTMLTableCellElement::additionalAttributeStyleDecl):
        * html/HTMLTableColElement.cpp:
        (WebCore::HTMLTableColElement::additionalAttributeStyleDecl):
        * html/HTMLTableColElement.h:
        * html/HTMLTableElement.cpp:
        (WebCore::HTMLTableElement::HTMLTableElement):
        (WebCore::HTMLTableElement::~HTMLTableElement):
        (WebCore::HTMLTableElement::setCaption):
        (WebCore::HTMLTableElement::setTHead):
        (WebCore::HTMLTableElement::setTFoot):
        (WebCore::HTMLTableElement::setTBody):
        (WebCore::HTMLTableElement::createTHead):
        (WebCore::HTMLTableElement::deleteTHead):
        (WebCore::HTMLTableElement::createTFoot):
        (WebCore::HTMLTableElement::deleteTFoot):
        (WebCore::HTMLTableElement::createCaption):
        (WebCore::HTMLTableElement::deleteCaption):
        (WebCore::HTMLTableElement::insertRow):
        (WebCore::HTMLTableElement::deleteRow):
        (WebCore::HTMLTableElement::addChild):
        (WebCore::HTMLTableElement::childrenChanged):
        (WebCore::HTMLTableElement::mapToEntry):
        (WebCore::HTMLTableElement::parseMappedAttribute):
        (WebCore::HTMLTableElement::additionalAttributeStyleDecl):
        (WebCore::HTMLTableElement::getSharedCellDecl):
        (WebCore::HTMLTableElement::getSharedGroupDecl):
        (WebCore::HTMLTableElement::attach):
        * html/HTMLTableElement.h:
        (WebCore::HTMLTableElement::caption):
        (WebCore::HTMLTableElement::tHead):
        (WebCore::HTMLTableElement::tFoot):
        (WebCore::HTMLTableElement::):
        * html/HTMLTableRowElement.h:
        * html/HTMLTableSectionElement.cpp:
        (WebCore::HTMLTableSectionElement::additionalAttributeStyleDecl):
        * html/HTMLTableSectionElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd layout test for bug 4192.
hyatt [Sun, 17 Sep 2006 07:43:30 +0000 (07:43 +0000)]
Add layout test for bug 4192.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix for bugzilla bug 4192, font size wrong for <tt> elements that
hyatt [Sun, 17 Sep 2006 07:39:45 +0000 (07:39 +0000)]
    Fix for bugzilla bug 4192, font size wrong for <tt> elements that
        specify their own new font-family list.  Make sure to always
        reset the generic family along with the family list when mapping in
        new font-family values.

        Reviewed by bradee-oh

        fast/text/basic/generic-family-reset.html

        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix for bugzilla bug 4129, font size wrong for <tt> elements that
hyatt [Sun, 17 Sep 2006 07:39:12 +0000 (07:39 +0000)]
    Fix for bugzilla bug 4129, font size wrong for <tt> elements that
        specify their own new font-family list.  Make sure to always
        reset the generic family along with the family list when mapping in
        new font-family values.

        Reviewed by bradee-oh

        fast/text/basic/generic-family-reset.html

        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
beidson [Sun, 17 Sep 2006 07:29:59 +0000 (07:29 +0000)]
WebCore:

        Reviewed by Hyatt

        Pruning code relating to WebKit's icon loader

        * bridge/mac/WebCoreIconDatabaseBridge.h:
        * bridge/mac/WebCoreIconDatabaseBridge.mm:
        * loader/icon/IconDatabase.h:
        * page/Frame.cpp:
        (WebCore::Frame::endIfNotLoading): Moved a FIXME in from WebKit's IconLoader to
        its new home

WebKit:

        Reviewed by Hyatt

        WebIconLoader is dead, long live WebCore::IconLoader
        (code prune)

        * Loader/WebFrameLoader.h:
        * Loader/WebFrameLoader.m:
        (-[WebFrameLoader dealloc]):
        (-[WebFrameLoader commitProvisionalLoad]):
        * Loader/WebIconLoader.h: Removed.
        * Loader/WebIconLoader.m: Removed.
        * Misc/WebIconDatabase.h:
        * Misc/WebIconDatabase.m:
        * Misc/WebIconDatabasePrivate.h:
        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge notifyIconChanged:]):
        * WebCoreSupport/WebIconDatabaseBridge.h:
        * WebCoreSupport/WebIconDatabaseBridge.m:
        (-[WebIconDatabaseBridge _init]):
        (-[WebIconDatabaseBridge _setIconData:forIconURL:]):
        (-[WebIconDatabaseBridge _setHaveNoIconForIconURL:]):
        * WebKit.exp:
        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebDataSource.m:
        (-[WebDataSourcePrivate dealloc]):
        (-[WebDataSource _stopLoading]):
        (-[WebDataSource _setPrimaryLoadComplete:]):
        * WebView/WebDataSourceInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim H.
weinig [Sat, 16 Sep 2006 21:13:17 +0000 (21:13 +0000)]
    Reviewed by Tim H.

        Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10885
        Auto-generate DOMHTMLDocument for the Objective-C bindings

        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/objc/DOMExtensions.h:
        * bindings/objc/DOMHTML.mm:
        (-[DOMHTMLDocument createDocumentFragmentWithText:]):
        * bindings/objc/DOMHTMLDocument.h: Removed.
        * bindings/objc/DOMHTMLDocument.mm: Removed.
        * bindings/objc/PublicDOMInterfaces.h:
        * bindings/scripts/CodeGeneratorObjC.pm:
        * html/HTMLDocument.idl:
        * platform/DeprecatedString.h:
        (WebCore::DeprecatedString::operator NSString*):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Eric.
rwlbuis [Sat, 16 Sep 2006 16:15:59 +0000 (16:15 +0000)]
    Reviewed by Eric.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10866
        Code in kcanvas/ should not use Private

        Remove Private classes and tweak coding style.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-16 Mark Rowe <opendarwin.org@bdash.net.nz>
bdash [Sat, 16 Sep 2006 15:13:59 +0000 (15:13 +0000)]
2006-09-16  Mark Rowe  <opendarwin.org@bdash.net.nz>

        Reviewed by Anders.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10887
        Fix build error

        * bindings/objc/DOMPrivate.h: Remove reference to DOMEventPrivate.h.

2006-09-16  Mark Rowe  <opendarwin.org@bdash.net.nz>

        Reviewed by Anders.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10887
        Fix build error

        * MigrateHeaders.make: Remove reference to DOMEventPrivate.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Anders.
weinig [Sat, 16 Sep 2006 15:11:39 +0000 (15:11 +0000)]
    Reviewed by Anders.

        Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10886
        REGRESSION (r16387): Reproducible crash when mousing over HTML document

        - Special case method [DOMNode ownerDocument] to call document() instead
          or ownerDocument() to return to the old behavior.

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/scripts/CodeGeneratorObjC.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoMy ChangeLog msg got out of order. *sigh*
beidson [Sat, 16 Sep 2006 04:19:28 +0000 (04:19 +0000)]
My ChangeLog msg got out of order.  *sigh*

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Brady.
beidson [Sat, 16 Sep 2006 04:17:12 +0000 (04:17 +0000)]
    Reviewed by Brady.

        Make new style ObjC methods public API.

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/objc/DOMPrivate.h:
        * bindings/objc/PublicDOMInterfaces.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
thatcher [Sat, 16 Sep 2006 04:04:10 +0000 (04:04 +0000)]
WebCore:

        Reviewed by Brady.

        Make new style ObjC methods public API.

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/objc/DOMPrivate.h:
        * bindings/objc/PublicDOMInterfaces.h:

WebKit:

        Reviewed by Brady.

        Make new style ObjC methods public API.

        * MigrateHeaders.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
weinig [Sat, 16 Sep 2006 03:30:49 +0000 (03:30 +0000)]
WebCore:

        Reviewed by Tim H.

        Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10870
        Auto-generate DOMNode for the Objective-C bindings

        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/objc/DOM.mm:
        (-[DOMNode boundingBox]):
        (-[DOMNode lineBoxRects]):
        * bindings/objc/DOMEvents.h:
        * bindings/objc/DOMExtensions.h:
        * bindings/objc/DOMNode.h: Removed.
        * bindings/objc/DOMNode.mm: Removed.
        * bindings/objc/PublicDOMInterfaces.h:
        * bindings/scripts/CodeGeneratorObjC.pm:
        * dom/Node.idl:

WebKit:

        Reviewed by Tim H.

        Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10870
        Auto-generate DOMNode for the Objective-C bindings

        * MigrateHeaders.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
thatcher [Sat, 16 Sep 2006 02:24:00 +0000 (02:24 +0000)]
WebCore:

        Reviewed by Justin.

        Removed alter selection logic from WebCoreFrameBridge and moved to SelectionController.

        * bridge/mac/WebCoreFrameBridge.h:
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge centerSelectionInVisibleArea]):
        (-[WebCoreFrameBridge rangeByExpandingSelectionWithGranularity:]):
        (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:direction:granularity:]):
        (-[WebCoreFrameBridge alterCurrentSelection:direction:granularity:]):
        (-[WebCoreFrameBridge alterCurrentSelection:verticalDistance:]):
        (-[WebCoreFrameBridge replaceMarkedTextWithText:]):
        (-[WebCoreFrameBridge replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
        (-[WebCoreFrameBridge increaseSelectionListLevel]):
        (-[WebCoreFrameBridge increaseSelectionListLevelOrdered]):
        (-[WebCoreFrameBridge increaseSelectionListLevelUnordered]):
        (-[WebCoreFrameBridge decreaseSelectionListLevel]):
        (-[WebCoreFrameBridge insertLineBreak]):
        (-[WebCoreFrameBridge insertParagraphSeparator]):
        (-[WebCoreFrameBridge insertParagraphSeparatorInQuotedContent]):
        (-[WebCoreFrameBridge insertText:selectInsertedText:]):
        (-[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:granularity:]):
        (-[WebCoreFrameBridge forwardDeleteKeyPressedWithSmartDelete:granularity:]):
        (createMouseEventFromDraggingInfo):
        * editing/SelectionController.cpp:
        (WebCore::SelectionController::moveTo):
        (WebCore::SelectionController::setSelection):
        (WebCore::SelectionController::modify):
        (WebCore::SelectionController::setBase):
        (WebCore::SelectionController::setExtent):
        * editing/SelectionController.h:
        * page/Frame.cpp:
        (WebCore::Frame::revealSelection):
        (WebCore::Frame::revealCaret):
        * page/Frame.h:

WebKit:

        Reviewed by Justin.

        Call the bridge directly for alter selection calls. All of this logic is now
        in WebCore's SelectionController.

        * WebView/WebHTMLView.m:
        (-[NSArray moveBackward:]):
        (-[NSArray moveBackwardAndModifySelection:]):
        (-[NSArray moveDown:]):
        (-[NSArray moveDownAndModifySelection:]):
        (-[NSArray moveForward:]):
        (-[NSArray moveForwardAndModifySelection:]):
        (-[NSArray moveLeft:]):
        (-[NSArray moveLeftAndModifySelection:]):
        (-[NSArray moveRight:]):
        (-[NSArray moveRightAndModifySelection:]):
        (-[NSArray moveToBeginningOfDocument:]):
        (-[NSArray moveToBeginningOfDocumentAndModifySelection:]):
        (-[NSArray moveToBeginningOfSentence:]):
        (-[NSArray moveToBeginningOfSentenceAndModifySelection:]):
        (-[NSArray moveToBeginningOfLine:]):
        (-[NSArray moveToBeginningOfLineAndModifySelection:]):
        (-[NSArray moveToBeginningOfParagraph:]):
        (-[NSArray moveToBeginningOfParagraphAndModifySelection:]):
        (-[NSArray moveToEndOfDocument:]):
        (-[NSArray moveToEndOfDocumentAndModifySelection:]):
        (-[NSArray moveToEndOfSentence:]):
        (-[NSArray moveToEndOfSentenceAndModifySelection:]):
        (-[NSArray moveToEndOfLine:]):
        (-[NSArray moveToEndOfLineAndModifySelection:]):
        (-[NSArray moveToEndOfParagraph:]):
        (-[NSArray moveToEndOfParagraphAndModifySelection:]):
        (-[NSArray moveParagraphBackwardAndModifySelection:]):
        (-[NSArray moveParagraphForwardAndModifySelection:]):
        (-[NSArray moveUp:]):
        (-[NSArray moveUpAndModifySelection:]):
        (-[NSArray moveWordBackward:]):
        (-[NSArray moveWordBackwardAndModifySelection:]):
        (-[NSArray moveWordForward:]):
        (-[NSArray moveWordForwardAndModifySelection:]):
        (-[NSArray moveWordLeft:]):
        (-[NSArray moveWordLeftAndModifySelection:]):
        (-[NSArray moveWordRight:]):
        (-[NSArray moveWordRightAndModifySelection:]):
        (-[NSArray pageUp:]):
        (-[NSArray pageDown:]):
        (-[NSArray pageUpAndModifySelection:]):
        (-[NSArray pageDownAndModifySelection:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Anders
beidson [Sat, 16 Sep 2006 01:40:34 +0000 (01:40 +0000)]
    Reviewed by Anders

        Added the ability to get a mutable char* from a CString, which will copy the internal
        buffer if the ref count is greater than 1 so your mutable char* won't affect any other
        referrer of that buffer.

        * platform/CString.cpp:
        (WebCore::CString::mutableData):
        (WebCore::CString::copyBufferIfNeeded):
        * platform/CString.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
justing [Sat, 16 Sep 2006 01:17:24 +0000 (01:17 +0000)]
LayoutTests:

        Reviewed by harrison

        <rdar://problem/4674869>
        REGRESSION: selecting text to write over results in cursor jumping to middle of next line

        * editing/deleting/whitespace-pre-1-expected.checksum: Added.
        * editing/deleting/whitespace-pre-1-expected.png: Added.
        * editing/deleting/whitespace-pre-1-expected.txt: Added.
        * editing/deleting/whitespace-pre-1.html: Added.

WebCore:

        Reviewed by harrison

        <rdar://problem/4674869>
        REGRESSION: selecting text to write over results in cursor jumping to middle of next line

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::modify): Added lineBoundary to test fix.
        * editing/visible_units.cpp:
        (WebCore::endOfLine): If the last box on the line is a lineBreak, return the
        position before it, not after it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-15 Mark Rowe <opendarwin.org@bdash.net.nz>
bdash [Sat, 16 Sep 2006 00:55:22 +0000 (00:55 +0000)]
2006-09-15  Mark Rowe  <opendarwin.org@bdash.net.nz>

        Reviewed by Brady.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10635
        Bug 10635: Buildbot configuration in SVN is out of sync with build.webkit.org

        * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py: Reorder build slaves within build factories in an attempt to spread the load evenly.
        * BuildSlaveSupport/build.webkit.org-config/webkit/status.py: Return to sending status emails to <svnuser>@opensource.apple.com addresses.
        * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py: Update configuration to match changes in Buildbot.  Always do clean SVG builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-15 Krzysztof Kowalczyk <kkowalczyk@gmail.com>
bdash [Sat, 16 Sep 2006 00:39:12 +0000 (00:39 +0000)]
2006-09-15  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>

        Reviewed by Adam.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10864
        Bug 10864: Linux\GDK build fixes

        * JavaScriptCoreSources.bkl:
        * jscore.bkl:

2006-09-15  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>

        Reviewed by Adam.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10864
        Bug 10864: Linux\GDK build fixes

        * Projects/gdk/webcore-gdk.bkl:
        * WebCoreSources.bkl:
        * platform/gdk/FontCacheGdk.cpp:
        * platform/gdk/FontDataGdk.cpp:
        (WebCore::FontData::platformInit):
        * platform/gdk/FontGdk.cpp:
        (WebCore::Font::drawGlyphs):
        * platform/gdk/FrameGdk.cpp:
        (WebCore::FrameGdk::handleGdkEvent):
        * platform/gdk/FrameGdk.h:
        * platform/gdk/ImageGdk.cpp: Added.
        (WebCore::Image::initPlatformData):
        (WebCore::Image::invalidatePlatformData):
        (WebCore::Image::loadPlatformResource):
        (WebCore::Image::supportsType):
        * platform/gdk/RenderPopupMenuGdk.cpp:
        (WebCore::RenderPopupMenuGdk::hidePopup):
        * platform/gdk/RenderPopupMenuGdk.h:
        * platform/gdk/ScreenGdk.cpp:
        (WebCore::drawableForPage):
        (WebCore::screenRect):
        (WebCore::screenDepth):
        (WebCore::usableScreenRect):
        (WebCore::scaleFactor):
        * platform/gdk/SystemTimeLinux.cpp:
        (WebCore::currentTime):
        * platform/gdk/TemporaryLinkStubs.cpp:
        (FrameGdk::bindingRootObject):
        (FrameGdk::markMisspellings):
        (WebCore::screenDepthPerComponent):
        (WebCore::screenIsMonochrome):
        (WebCore::fileButtonChooseFileLabel):
        (WebCore::fileButtonNoFileSelectedLabel):
        (FrameGdk::shouldChangeSelection):
        (FrameGdk::respondToChangedSelection):
        (FrameGdk::respondToChangedContents):
        (Path::contains):
        (PlatformScrollBar::PlatformScrollBar):
        (PlatformScrollBar::~PlatformScrollBar):
        (PlatformScrollBar::width):
        (PlatformScrollBar::height):
        (PlatformScrollBar::setEnabled):
        (PlatformScrollBar::paint):
        (PlatformScrollBar::setScrollBarValue):
        (PlatformScrollBar::setKnobProportion):
        (PlatformScrollBar::setRect):
        (ScrollBar::ScrollBar):
        (FileChooser::FileChooser):
        (FileChooser::~FileChooser):
        (FileChooser::openFileChooser):
        (FileChooser::basenameForWidth):
        (FileChooser::uploadControlDetaching):
        (FileChooser::chooseFile):
        (Icon::Icon):
        (Icon::~Icon):
        (Icon::newIconForFile):
        (Icon::paint):
        (IconLoader::stopLoading):
        (IconLoader::startLoading):
        (IconLoader::createForFrame):
        (IconDatabase::isIconExpiredForIconURL):
        (IconDatabase::hasEntryForIconURL):
        (IconDatabase::sharedIconDatabase):
        * platform/gdk/WidgetGdk.cpp:
        * webcore-base.bkl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Justin.
thatcher [Sat, 16 Sep 2006 00:36:16 +0000 (00:36 +0000)]
    Reviewed by Justin.

        Updating results to new expected values.

        * fast/lists/drag-into-marker-expected.txt:
        * fast/repaint/selection-after-delete-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Windows build fix.
aroben [Sat, 16 Sep 2006 00:26:05 +0000 (00:26 +0000)]
    Windows build fix.

        * JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Justin.
thatcher [Fri, 15 Sep 2006 23:57:58 +0000 (23:57 +0000)]
    Reviewed by Justin.

        Updating results to new expected values.

        * editing/inserting/4278698-expected.txt:
        * fast/dom/window-xy-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-15 Nikolas Zimmermann <zimmermann@kde.org>
bdash [Fri, 15 Sep 2006 23:55:41 +0000 (23:55 +0000)]
2006-09-15  Nikolas Zimmermann  <zimmermann@kde.org>

        Reviewed by Eric.

        Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10835
        Fix svg memory leaks.

        Reworked SVGList to deal with RefPtr's for ptr types
        which makes manual refcounting unnecessary, and is much safer.

        Removing all virtual functions (nullItem) from SVGList, and
        also remove SVGListBase. Switch to a similar concept like
        Vector/VectorTraits (see new file SVGListTraits.h).

        Credits go to Eric/Maciej for the inspiration.

        * CMakeLists.txt: Add SVGListTraits.cpp to build
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * bindings/scripts/CodeGeneratorJS.pm: Generator changes for SVGTransform/PathSeg/LengthList (now RefPtr based)
        * kcanvas/RenderSVGText.cpp: Add some get() methods, as SVGLengthList is RefPtr based now.
        (WebCore::RenderSVGText::translationForAttributes):
        * ksvg2/svg/SVGAnimateTransformElement.cpp: Add some get() methods, as SVGTransformList is RefPtr based now.
        (WebCore::SVGAnimateTransformElement::handleTimerEvent):
        * ksvg2/svg/SVGElementInstanceList.cpp: Be RefPtr based.
        (WebCore::SVGElementInstanceList::SVGElementInstanceList):
        * ksvg2/svg/SVGElementInstanceList.h:
        * ksvg2/svg/SVGLengthList.cpp: Ditto.
        (WebCore::SVGLengthList::SVGLengthList):
        * ksvg2/svg/SVGLengthList.h: Ditto.
        * ksvg2/svg/SVGList.h: Rewrote, as described above.
        (WebCore::SVGListTypeOperations::nullItem):
        (WebCore::SVGList::SVGList):
        (WebCore::SVGList::~SVGList):
        (WebCore::SVGList::clear):
        (WebCore::SVGList::getFirst):
        (WebCore::SVGList::getLast):
        (WebCore::SVGList::getItem):
        (WebCore::SVGList::replaceItem):
        (WebCore::SVGList::removeItem):
        * ksvg2/svg/SVGListTraits.cpp: Added.
        * ksvg2/svg/SVGListTraits.h: Added.
        (WebCore::):
        * ksvg2/svg/SVGPathElement.cpp: Add some get() methods, as SVGPathSegList is RefPtr based now.
        (WebCore::SVGPathElement::toPathData):
        * ksvg2/svg/SVGPathSegList.cpp: Be RefPtr based.
        (WebCore::SVGPathSegList::SVGPathSegList):
        * ksvg2/svg/SVGPathSegList.h: Ditto.
        * ksvg2/svg/SVGTransform.cpp: Style cleanup.
        (SVGTransform::SVGTransform):
        * ksvg2/svg/SVGTransformList.cpp: Be RefPtr based.
        (SVGTransformList::SVGTransformList):
        (SVGTransformList::createSVGTransformFromMatrix):
        (SVGTransformList::consolidate):
        * ksvg2/svg/SVGTransformList.h: Ditto.
        * ksvg2/svg/SVGTransformable.cpp: Fix RefPtr usage of SVGTransform.
        (SVGTransformable::parseTransformAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-15 Nikolas Zimmermann <zimmermann@kde.org>
eseidel [Fri, 15 Sep 2006 23:30:47 +0000 (23:30 +0000)]
2006-09-15  Nikolas Zimmermann  <zimmermann@kde.org>

        Reviewed by eseidel.  Landed by eseidel.

        Fix build on Qt/Linux and implement Frame::addMessageToConsole to
        be able to see javascript errors for instance.

        * CMakeLists.txt:
        * platform/qt/FrameQt.h:
        * platform/qt/FrameQt.cpp: Implement addMessageToConsole.
        (WebCore::FrameQt::bindingRootObject):
        * platform/qt/TemporaryLinkStubs.cp
        (WebCore::IconDatabase::hasEntryForIconURL):
        (WebCore::IconDatabase::sharedIconDatabase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-15 Anders Carlsson <acarlsson@apple.com>
andersca [Fri, 15 Sep 2006 22:47:04 +0000 (22:47 +0000)]
2006-09-15  Anders Carlsson  <acarlsson@apple.com>

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        Fix the release build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by eseidel.
aroben [Fri, 15 Sep 2006 22:31:20 +0000 (22:31 +0000)]
    Reviewed by eseidel.

        Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10876
        containsItemForURLUnicode uses matchLetter instead of
        matchUnicodeLetter

        Small fixes for _WebCoreHistoryProvider.

        * History/WebHistory.m: Consistently use BUFFER_SIZE #define
        (-[_WebCoreHistoryProvider containsItemForURLLatin1:length:]):
        (-[_WebCoreHistoryProvider containsItemForURLUnicode:length:]):
        Replace incorrect call to matchLetter to matchUnicodeLetter

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim H.
weinig [Fri, 15 Sep 2006 22:23:50 +0000 (22:23 +0000)]
    Reviewed by Tim H.

        Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10869
        Auto-generate the internal methods for the Objective-C bindings

        - Auto-generates the internal method (ie. the _fooBar and _fooBarWith methods)
          implementations where standard.  For cases where a custom implementation was
          needed, added a [ObjCNoInternal] extended attribute to the corresponding IDL.

        - Some general cleanup of some of the non-generated bindings, to bring them in-
          line with what the generated bindings look like.

        * bindings/objc/DOM.mm:
        (-[DOMNode description]):
        * bindings/objc/DOMCSS.mm:
        (-[DOMCSSPrimitiveValue WebCore::]):
        (-[DOMDocument getComputedStyle::]):
        (-[DOMDocument getMatchedCSSRules::]):
        * bindings/objc/DOMEvents.mm:
        (-[DOMEvent WebCore::]):
        * bindings/objc/DOMHTML.mm:
        * bindings/objc/DOMHTMLDocument.mm:
        (-[DOMHTMLDocument title]):
        (-[DOMHTMLDocument setTitle:]):
        (-[DOMHTMLDocument referrer]):
        (-[DOMHTMLDocument domain]):
        (-[DOMHTMLDocument URL]):
        (-[DOMHTMLDocument body]):
        (-[DOMHTMLDocument setBody:]):
        (-[DOMHTMLDocument images]):
        (-[DOMHTMLDocument applets]):
        (-[DOMHTMLDocument links]):
        (-[DOMHTMLDocument forms]):
        (-[DOMHTMLDocument anchors]):
        (-[DOMHTMLDocument cookie]):
        (-[DOMHTMLDocument setCookie:]):
        (-[DOMHTMLDocument open]):
        (-[DOMHTMLDocument close]):
        (-[DOMHTMLDocument write:]):
        (-[DOMHTMLDocument writeln:]):
        (-[DOMHTMLDocument getElementById:]):
        (-[DOMHTMLDocument getElementsByName:]):
        (-[DOMHTMLDocument WebCore::]):
        (+[DOMHTMLDocument _HTMLDocumentWith:WebCore::]):
        * bindings/objc/DOMHTMLOptionElement.mm:
        (-[DOMHTMLOptionElement form]):
        (-[DOMHTMLOptionElement defaultSelected]):
        (-[DOMHTMLOptionElement setDefaultSelected:]):
        (-[DOMHTMLOptionElement text]):
        (-[DOMHTMLOptionElement index]):
        (-[DOMHTMLOptionElement disabled]):
        (-[DOMHTMLOptionElement setDisabled:]):
        (-[DOMHTMLOptionElement label]):
        (-[DOMHTMLOptionElement setLabel:]):
        (-[DOMHTMLOptionElement selected]):
        (-[DOMHTMLOptionElement setSelected:]):
        (-[DOMHTMLOptionElement value]):
        (-[DOMHTMLOptionElement setValue:]):
        (-[DOMHTMLOptionElement WebCore::]):
        (+[DOMHTMLOptionElement _HTMLOptionElementWith:WebCore::]):
        * bindings/objc/DOMInternal.h:
        * bindings/objc/DOMNode.mm:
        (-[DOMNode dealloc]):
        (-[DOMNode finalize]):
        (-[DOMNode nodeName]):
        (-[DOMNode nodeValue]):
        (-[DOMNode setNodeValue:]):
        (-[DOMNode nodeType]):
        (-[DOMNode parentNode]):
        (-[DOMNode childNodes]):
        (-[DOMNode firstChild]):
        (-[DOMNode lastChild]):
        (-[DOMNode previousSibling]):
        (-[DOMNode nextSibling]):
        (-[DOMNode attributes]):
        (-[DOMNode ownerDocument]):
        (-[DOMNode insertBefore::]):
        (-[DOMNode replaceChild::]):
        (-[DOMNode removeChild:]):
        (-[DOMNode appendChild:]):
        (-[DOMNode hasChildNodes]):
        (-[DOMNode cloneNode:]):
        (-[DOMNode normalize]):
        (-[DOMNode isSupported::]):
        (-[DOMNode namespaceURI]):
        (-[DOMNode prefix]):
        (-[DOMNode setPrefix:]):
        (-[DOMNode localName]):
        (-[DOMNode hasAttributes]):
        (-[DOMNode isSameNode:]):
        (-[DOMNode isEqualNode:]):
        (-[DOMNode isDefaultNamespace:]):
        (-[DOMNode lookupPrefix:]):
        (-[DOMNode lookupNamespaceURI:]):
        (-[DOMNode textContent]):
        (-[DOMNode setTextContent:]):
        (-[DOMNode boundingBox]):
        (-[DOMNode lineBoxRects]):
        * bindings/objc/DOMObject.mm:
        (-[DOMObject _init]):
        * bindings/objc/DOMXPath.mm:
        (-[DOMNativeXPathNSResolver dealloc]):
        (-[DOMNativeXPathNSResolver finalize]):
        (-[DOMNativeXPathNSResolver WebCore::]):
        (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:WebCore::]):
        (+[DOMNativeXPathNSResolver _xpathNSResolverWith:WebCore::]):
        (-[DOMNativeXPathNSResolver lookupNamespaceURI:]):
        * bindings/scripts/CodeGeneratorObjC.pm:
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
        (-[WebCoreFrameBridge moveSelectionToDragCaret:smartMove:]):
        * css/CSSCharsetRule.idl:
        * css/CSSFontFaceRule.idl:
        * css/CSSImportRule.idl:
        * css/CSSMediaRule.idl:
        * css/CSSPageRule.idl:
        * css/CSSPrimitiveValue.idl:
        * css/CSSRule.idl:
        * css/CSSStyleRule.idl:
        * css/CSSStyleSheet.idl:
        * css/CSSUnknownRule.idl:
        * css/CSSValue.idl:
        * css/CSSValueList.idl:
        * css/StyleSheet.idl:
        * dom/Event.idl:
        * dom/KeyboardEvent.idl:
        * dom/MouseEvent.idl:
        * dom/MutationEvent.idl:
        * dom/NodeIterator.idl:
        * dom/OverflowEvent.idl:
        * dom/TreeWalker.idl:
        * dom/UIEvent.idl:
        * dom/WheelEvent.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
aroben [Fri, 15 Sep 2006 22:10:25 +0000 (22:10 +0000)]
WebCore:
        Reviewed by timothy.

        Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10865
        New file upload control should match the width of the old one

        Make width of new file upload control match the old one as closely as
        possible.

        * rendering/RenderFileUploadControl.cpp:

LayoutTests:
        Reviewed by timothy.

        Part of http://bugzilla.opendarwin.org/show_bug.cgi?id=10865
        New file upload control should match the width of the old one

        Update tests to match new file upload control.

        * fast/forms/file-input-disabled-expected.txt:
        * fast/forms/form-element-geometry-expected.txt:
        * fast/forms/input-appearance-height-expected.txt:
        * fast/forms/input-value-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Eric.
thatcher [Fri, 15 Sep 2006 22:01:14 +0000 (22:01 +0000)]
    Reviewed by Eric.

        Remove the SVG IDL files from the Copy Resources phase.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-15 Anders Carlsson <acarlsson@apple.com>
andersca [Fri, 15 Sep 2006 21:52:16 +0000 (21:52 +0000)]
2006-09-15  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Steve.

        Add JavaScriptCore API to the build.
        * API/JSBase.cpp:
        * API/JSCallbackConstructor.cpp:
        * API/JSCallbackFunction.cpp:
        * API/JSCallbackObject.cpp:
        * API/JSClassRef.cpp:
        * API/JSContextRef.cpp:
        * API/JSObjectRef.cpp:
        * API/JSStringRef.cpp:
        * API/JSValueRef.cpp:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * os-win32/stdbool.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago - just layout test result changes
kmccullo [Fri, 15 Sep 2006 18:09:18 +0000 (18:09 +0000)]
    - just layout test result changes

        * fast/dom/Range/range-compareNode-expected.txt:
        * fast/dom/Range/range-intersectsNode-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Eric Siedel
beidson [Fri, 15 Sep 2006 09:38:34 +0000 (09:38 +0000)]
    Reviewed by Eric Siedel

        Dumped the use of CGColorRef and directly use the floating point data from
        WebCore::Color

        This fixes the performance regression found between 16285 and 16286

        * platform/mac/FontMac.mm:
        (WebCore::Font::drawComplexText):
        (WebCore::Font::drawGlyphs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-14 Mark Rowe <opendarwin.org@bdash.net.nz>
bdash [Fri, 15 Sep 2006 06:09:02 +0000 (06:09 +0000)]
2006-09-14  Mark Rowe  <opendarwin.org@bdash.net.nz>

        Reviewed by Adam.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10838
        Bug 10838: REGRESSION: Leaking of WebScriptObjectPrivate

        FrameMac relies on its cleanupPluginObjects being called to perform cleanup.  The virtual
        Frame::cleanupPluginObjects method is called from Frame's destructor, which results
        in Frame::cleanupPluginObjects being called rather than FrameMac::cleanupPluginObjects.

        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::~FrameMac): Call cancelAndClear to ensure that FrameMac::cleanupPluginObjects
        will be called from Frame::clear
        * page/Frame.cpp:
        (WebCore::Frame::~Frame): Use cancelAndClear.
        (WebCore::Frame::cancelAndClear): Move cancellation and clearing into a separate method that
        FrameMac can use.
        * page/Frame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej's rubber stamp
beidson [Thu, 14 Sep 2006 23:44:33 +0000 (23:44 +0000)]
    Reviewed by Maciej's rubber stamp

        Exact same fix I just made, but in the other method I horked up
        Also added a reference to the bugzilla in comments

        * page/Frame.cpp:
        (WebCore::Frame::endIfNotLoading):
        (WebCore::Frame::stop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej
beidson [Thu, 14 Sep 2006 22:58:15 +0000 (22:58 +0000)]
    Reviewed by Maciej

        Fixed a bad iFrame crash, resolving some of the layout test badness

        * page/Frame.cpp:
        (WebCore::Frame::endIfNotLoading):
        - Added a RefPtr to protect the frame itself to prevent its destruction during this method

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
justing [Thu, 14 Sep 2006 19:52:27 +0000 (19:52 +0000)]
LayoutTests:

        Reviewed by harrison

        <rdar://problem/4655880> Up/Down arrows skip over To Do

        * editing/selection/mixed-editability-3-expected.checksum: Added.
        * editing/selection/mixed-editability-3-expected.png: Added.
        * editing/selection/mixed-editability-3-expected.txt: Added.
        * editing/selection/mixed-editability-3.html: Added.
        * editing/selection/mixed-editability-4-expected.checksum: Added.
        * editing/selection/mixed-editability-4-expected.png: Added.
        * editing/selection/mixed-editability-4-expected.txt: Added.
        * editing/selection/mixed-editability-4.html: Added.
        * editing/selection/mixed-editability-5-expected.checksum: Added.
        * editing/selection/mixed-editability-5-expected.png: Added.
        * editing/selection/mixed-editability-5-expected.txt: Added.
        * editing/selection/mixed-editability-5.html: Added.

WebCore:

        Reviewed by harrison

        <rdar://problem/4655880> Up/Down arrows skip over To Do

        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge canDeleteRange:]): Added a FIXME.
        * dom/Node.cpp: Removed the unused inSameRootEditableElement.
        * dom/Node.h:
        * editing/SelectionController.cpp:
        (WebCore::SelectionController::modify): Added documentboundary to granularities in order test a fix.
        * editing/visible_units.cpp:
        (WebCore::previousLinePosition): Use highestEditableRoot so that this function can move from
        editable content into editable content that's embedded in non-editable content.
        (WebCore::nextLinePosition): Ditto.
        (WebCore::startOfEditableContent): Renamed from startOfEditableRoot and use highestEditableRoot.
        This is the behavior that callers desire.  This fixes Command + Up/Down.
        (WebCore::endOfEditableContent): Ditto.
        * editing/visible_units.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-14 Karthik Kumar <karthikkumar@gmail.com>
aroben [Thu, 14 Sep 2006 17:07:02 +0000 (17:07 +0000)]
2006-09-14  Karthik Kumar  <karthikkumar@gmail.com>

        Reviewed by timothy. Landed by aroben.

        Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10856
        Windows build fixes after r16360

        * WebCore.vcproj/WebCore/WebCore.vcproj: Add loader\icon to
        AdditionalIncludeDirectories
        * platform/win/TemporaryLinkStubs.cpp: Add link stubs for IconLoader,
        IconDatabase
        (IconLoader::stopLoading):
        (IconLoader::startLoading):
        (IconLoader::createForFrame):
        (IconDatabase::isIconExpiredForIconURL):
        (IconDatabase::hasEntryForIconURL):
        (IconDatabase::sharedIconDatabase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoPart of a build fix - rest will be filling in some temporary link stubs
beidson [Thu, 14 Sep 2006 09:00:39 +0000 (09:00 +0000)]
Part of a build fix - rest will be filling in some temporary link stubs

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-14 Graham Dennis <graham.dennis@gmail.com>
bdash [Thu, 14 Sep 2006 08:08:33 +0000 (08:08 +0000)]
2006-09-14  Graham Dennis  <graham.dennis@gmail.com>

        Reviewed by Justin Garcia.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=10726
          Crash in ApplyStyleCommand::applyRelativeFontStyleChange

        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Prevent a crash by
        makeing sure that the 'beyondEnd' node is after the start node.

2006-09-14  Graham Dennis  <graham.dennis@gmail.com>

        Reviewed by Justin Garcia.

        Modified testcase for:
        http://bugzilla.opendarwin.org/show_bug.cgi?id=10726
        Crash in ApplyStyleCommand::applyRelativeFontStyleChange

        * editing/style/table-selection-expected.checksum:
        * editing/style/table-selection-expected.png:
        * editing/style/table-selection-expected.txt:
        * editing/style/table-selection.html:
        This testcase was for 10579, which is very similar to this bug (10726)
        Now the testcase tests both bugs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-14 MorganL <morlmor@yahoo.com>
bdash [Thu, 14 Sep 2006 07:29:13 +0000 (07:29 +0000)]
2006-09-14  MorganL  <morlmor@yahoo.com>

        Reviewed by Brady.

        Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10845
        Various bugs/crashes in ResourceLoaderWin with local files.

        * platform/ResourceLoaderInternal.h:
        (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
        * platform/win/ResourceLoaderWin.cpp:
        (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal):
        (WebCore::ResourceLoader::fileLoadTimer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
beidson [Thu, 14 Sep 2006 07:20:47 +0000 (07:20 +0000)]
WebCore:

        Reviewed by Maciej

        Icon loads now take place in WebCore

        * WebCore.xcodeproj/project.pbxproj:
        * bridge/BrowserExtension.h:
        * bridge/mac/BrowserExtensionMac.h:
        * bridge/mac/BrowserExtensionMac.mm:
        - Moved enforcement of a Mozilla Favicon extension elsewhere

        * bridge/mac/FrameMac.h:
        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::originalRequestURL):
        - Added accessor to "original request URL"

        * bridge/mac/WebCoreFrameBridge.h:
        - Removed methods to set the iconURL as all loading is now done in WebCore
        - Added call throughs to notify WebKit an Icon is done loading, and a to get the original request URL

        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::process):
        - Moved enforcement of a Mozilla Favicon extension elsewhere

        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::setIconURLForPageURL):
        - Changed an ASSERT to correctly handle a sketchy (invalid) situation

        * loader/icon/IconLoader.h: Added.
        * loader/icon/IconLoader.cpp: Added.
        (IconLoader::IconLoader):
        (IconLoader::createForFrame):
        - Static factory method with a private constructor to enforce
          "you MUST have a Frame to create an IconLoader" semantics
        (IconLoader::~IconLoader):
        (IconLoader::startLoading):
        (IconLoader::stopLoading):
        (IconLoader::receivedData):
        - ResourceLoaderClient delegate
        (IconLoader::receivedAllData):
        - Ditto

        * loader/mac/IconLoaderMac.mm: Added.
        (IconLoader::receivedResponse):
        (IconLoader::notifyIconChanged):
        - For now, these are platform specific methods
        - One to get the HTTP response code of an icon load
        - The other to call through to the app when the icon has changed (loaded)

        * page/Frame.h:
        * page/Frame.cpp:
        (WebCore::Frame::iconURL):
        (WebCore::Frame::setIconURL):
        - Frame objects now have an inherent icon URL and a way to calculate/access it
        (WebCore::Frame::endIfNotLoading):
        - This is where we actually kick off the IconLoader
        (WebCore::Frame::stop):
        - Added call to stop loading the icon

        * page/FramePrivate.h:
        (WebCore::FramePrivate::FramePrivate):
        (WebCore::FramePrivate::~FramePrivate):
        - Added the icon URL as a private member
        - Added the IconLoader as a private member, and clean it up on deletion

        * platform/mac/ResourceLoaderMac.mm:
        (WebCore::ResourceLoader::start):  Added a valuable ASSERT

WebKit:

        Reviewed by Maciej

        Add infrastructure to support icon loads taking place in WebCore
        Will remove WebKit icon loaders in a later patch

        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge notifyIconChanged:]):
        (-[WebFrameBridge originalRequestURL]):
        - Nuked two old, obsolete methods
        - Added bridge for notifying of an icon change
        - Added bridge for getting the "original request URL" which is still needed
          until that info is available in the WebCore loaders

        * WebView/WebDataSource.m:
        (-[WebDataSource _loadIcon]):
        - Empty body just for now, as it still gets called - next patch will prune all the old impl out

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix for 10841, unable to check checkboxes inside labels.
hyatt [Thu, 14 Sep 2006 07:01:48 +0000 (07:01 +0000)]
    Fix for 10841, unable to check checkboxes inside labels.

        Reviewed by xenon, bradee-oh

        * css/html4.css:
        * dom/Element.cpp:
        (WebCore::Element::contains):
        * dom/Element.h:
        * html/HTMLLabelElement.cpp:
        (WebCore::HTMLLabelElement::defaultEventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-13 Mark Rowe <opendarwin.org@bdash.net.nz>
bdash [Thu, 14 Sep 2006 05:03:29 +0000 (05:03 +0000)]
2006-09-13  Mark Rowe  <opendarwin.org@bdash.net.nz>

        Reviewed by Adam.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10834
        Bug 10834: FileChooser constructor in FileChooserMac appears to overretain m_controller

        * platform/mac/FileChooserMac.mm:
        (WebCore::FileChooser::FileChooser): Don't over-retain the OpenPanelController.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Rubberstamped by hyatt.
aroben [Thu, 14 Sep 2006 04:47:34 +0000 (04:47 +0000)]
    Rubberstamped by hyatt.

        Updating tables results after hyatt landed a fix for
        http://bugzilla.opendarwin.org/show_bug.cgi?id=8126
        Padding must not apply to columns

        * tables/mozilla/bugs/bug139524-2-expected.txt:
        * tables/mozilla/bugs/bug139524-4-expected.txt:
        * tables/mozilla/bugs/bug32841-expected.txt:
        * tables/mozilla/dom/appendCol2-expected.txt:
        * tables/mozilla/dom/deleteCol1-expected.txt:
        * tables/mozilla/dom/deleteCol2-expected.txt:
        * tables/mozilla/dom/deleteCol3-expected.txt:
        * tables/mozilla/dom/deleteColGroup1-expected.txt:
        * tables/mozilla/dom/deleteColGroup2-expected.txt:
        * tables/mozilla/dom/insertColGroups1-expected.txt:
        * tables/mozilla/dom/insertColGroups2-expected.txt:
        * tables/mozilla/dom/insertCols1-expected.txt:
        * tables/mozilla/dom/insertCols2-expected.txt:
        * tables/mozilla/dom/insertCols3-expected.txt:
        * tables/mozilla/dom/insertCols4-expected.txt:
        * tables/mozilla/dom/insertCols5-expected.txt:
        * tables/mozilla/marvin/body_col-expected.txt:
        * tables/mozilla/marvin/x_col_span-expected.txt:
        * tables/mozilla/marvin/x_col_width_px-expected.txt:
        * tables/mozilla/marvin/x_colgroup_span-expected.txt:
        * tables/mozilla/other/body_col-expected.txt:
        * tables/mozilla_expected_failures/bugs/bug1128-expected.txt:
        * tables/mozilla_expected_failures/bugs/bug29058-2-expected.txt:
        * tables/mozilla_expected_failures/bugs/bug45621-expected.txt:
        * tables/mozilla_expected_failures/bugs/bug7243-expected.txt:
        * tables/mozilla_expected_failures/core/cols1-expected.txt:
        * tables/mozilla_expected_failures/dom/appendCol1-expected.txt:
        * tables/mozilla_expected_failures/dom/appendColGroup1-expected.txt:
        * tables/mozilla_expected_failures/other/test4-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-13 Mark Rowe <opendarwin.org@bdash.net.nz>
bdash [Thu, 14 Sep 2006 04:41:51 +0000 (04:41 +0000)]
2006-09-13  Mark Rowe  <opendarwin.org@bdash.net.nz>

        Reviewed by Eric.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10836
        Bug 10836: REGRESSION: Mac implementation of Font::drawGlyphs leaks a CGColorRef

        * platform/mac/FontMac.mm:
        (WebCore::Font::drawComplexText): Release CGColorRef after use.
        (WebCore::Font::drawGlyphs): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-14 Anders Carlsson <acarlsson@apple.com>
andersca [Thu, 14 Sep 2006 02:27:13 +0000 (02:27 +0000)]
2006-09-14  Anders Carlsson  <acarlsson@apple.com>

        Try fixing the Win32 build.

        * bridge/win/FrameWin.h:
        * platform/win/TemporaryLinkStubs.cpp:
        (FrameWin::bindingRootObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-12 Steve Falkenburg <sfalken@apple.com>
sfalken [Thu, 14 Sep 2006 01:59:26 +0000 (01:59 +0000)]
2006-09-12  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Ada.

        Build tweaks (doing JavaScriptCore now since it doesn't have
        dependencies).

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh:
        * JavaScriptCore.vcproj/JavaScriptCore/dstroot-to-sdk.cmd: Added.
        * JavaScriptCore.vcproj/dftables/dftables.vcproj:
        * JavaScriptCore.vcproj/testkjs/testkjs.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-14 Anders Carlsson <acarlsson@apple.com>
andersca [Thu, 14 Sep 2006 01:56:44 +0000 (01:56 +0000)]
2006-09-14  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Tim O.

        Add USE defines for the generic JavaScriptCore bindings as well as NPAPI bindings.

        * bindings/js/kjs_binding.cpp:
        (KJS::ScriptInterpreter::createLanguageInstanceForValue):
        * bindings/js/kjs_dom.cpp:
        (KJS::getRuntimeObject):
        * bridge/mac/FrameMac.h:
        * config.h:
        * html/HTMLAppletElement.cpp:
        (WebCore::HTMLAppletElement::~HTMLAppletElement):
        (WebCore::HTMLAppletElement::detach):
        * html/HTMLAppletElement.h:
        * html/HTMLEmbedElement.cpp:
        (WebCore::HTMLEmbedElement::~HTMLEmbedElement):
        (WebCore::HTMLEmbedElement::detach):
        * html/HTMLEmbedElement.h:
        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::~HTMLObjectElement):
        (WebCore::HTMLObjectElement::detach):
        * html/HTMLObjectElement.h:
        * html/HTMLPlugInElement.cpp:
        (WebCore::HTMLPlugInElement::HTMLPlugInElement):
        (WebCore::HTMLPlugInElement::~HTMLPlugInElement):
        (WebCore::HTMLPlugInElement::createNPObject):
        * html/HTMLPlugInElement.h:
        * page/Frame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim O.
thatcher [Wed, 13 Sep 2006 22:18:03 +0000 (22:18 +0000)]
    Reviewed by Tim O.

        <rdar://problem/4726416> obsolete confusing "ADVISORY NOTE" comment in WebHistory.h

        Removed the "ADVISORY NOTE: This method may change for the 1.0 SDK" comments.

        * History/WebHistory.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Clean up the XBL and XSLT ifdefs to be consistent with the SVG
hyatt [Wed, 13 Sep 2006 22:10:25 +0000 (22:10 +0000)]
    Clean up the XBL and XSLT ifdefs to be consistent with the SVG
        and XPath ifdefs.  KHTML_NO_XBL is flipped and is now XBL_SUPPORT.
        KHTML_XSLT is now XSLT_SUPPORT.

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSXSLTProcessor.cpp:
        * bindings/js/JSXSLTProcessor.h:
        * bindings/js/kjs_window.cpp:
        (KJS::Window::getValueProperty):
        * config.h:
        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/cssparser.cpp:
        (WebCore::CSSParser::parseValue):
        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::~Document):
        (WebCore::Document::recalcStyleSelector):
        * dom/Document.h:
        (WebCore::Document::bindingManager):
        * dom/Node.cpp:
        (WebCore::Node::createRendererIfNeeded):
        * dom/ProcessingInstruction.cpp:
        (WebCore::ProcessingInstruction::ProcessingInstruction):
        (WebCore::ProcessingInstruction::checkStyleSheet):
        (WebCore::ProcessingInstruction::setStyleSheet):
        * dom/ProcessingInstruction.h:
        * dom/XMLTokenizer.cpp:
        (WebCore::XMLTokenizer::processingInstruction):
        (WebCore::XMLTokenizer::insertErrorMessageBlock):
        * dom/XMLTokenizer.h:
        * loader/Cache.cpp:
        (WebCore::Cache::getStatistics):
        * loader/Cache.h:
        * loader/CachedResource.h:
        (WebCore::CachedResource::):
        * loader/CachedResourceClient.h:
        * loader/CachedXBLDocument.cpp:
        * loader/CachedXBLDocument.h:
        * loader/CachedXSLStyleSheet.cpp:
        * loader/CachedXSLStyleSheet.h:
        * loader/DocLoader.cpp:
        * loader/DocLoader.h:
        * rendering/RenderStyle.cpp:
        (WebCore::StyleCSS3NonInheritedData::StyleCSS3NonInheritedData):
        (WebCore::StyleCSS3NonInheritedData::~StyleCSS3NonInheritedData):
        (WebCore::StyleCSS3NonInheritedData::operator==):
        * rendering/RenderStyle.h:
        * xml/XSLImportRule.cpp:
        * xml/XSLImportRule.h:
        * xml/XSLStyleSheet.cpp:
        * xml/XSLStyleSheet.h:
        * xml/XSLTProcessor.cpp:
        * xml/XSLTProcessor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-13 Nikolas Zimmermann <zimmermann@kde.org>
eseidel [Wed, 13 Sep 2006 22:07:23 +0000 (22:07 +0000)]
2006-09-13  Nikolas Zimmermann  <zimmermann@kde.org>

        Reviewed by eseidel.  Landed by eseidel.

        Fix newly introduced memory leaks in SVG.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=10835

        * ksvg2/svg/SVGList.h:
        (WebCore::SVGListBase::~SVGListBase):
        (WebCore::SVGListBase::clearVector):
        (WebCore::SVGListBase::clear):
        (WebCore::SVGList::clearVector):
        (WebCore::):
        * ksvg2/svg/SVGNumberList.cpp: s/float/double/ - forgot that!
        (SVGNumberList::SVGNumberList):
        * ksvg2/svg/SVGNumberList.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-13 MorganL <morlmor@yahoo.com>
aroben [Wed, 13 Sep 2006 18:37:25 +0000 (18:37 +0000)]
2006-09-13  MorganL  <morlmor@yahoo.com>

        Reviewed/landed by aroben.

        Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10833
        Windows build needs fixed after move to engine-rendered file upload widget

        * WebCore.vcproj/WebCore/WebCore.vcproj: Add RenderFileUpload files,
        remove RenderFileButton files
        * platform/win/TemporaryLinkStubs.cpp: Add stubs for FileChooser, Icon
        (FileChooser::FileChooser):
        (FileChooser::~FileChooser):
        (FileChooser::openFileChooser):
        (FileChooser::basenameForWidth):
        (FileChooser::uploadControlDetaching):
        (FileChooser::chooseFile):
        (WebCore::fileButtonChooseFileLabel):
        (WebCore::fileButtonNoFileSelectedLabel):
        (Icon::Icon):
        (Icon::~Icon):
        (Icon::newIconForFile):
        (Icon::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-13 MorganL <morlmor@yahoo.com>
aroben [Wed, 13 Sep 2006 18:15:19 +0000 (18:15 +0000)]
2006-09-13  MorganL  <morlmor@yahoo.com>

        Reviewed/landed by aroben.

        Fixes http://bugzilla.opendarwin.org/attachment.cgi?id=10537
        Webkit WebCore build fails on Windows

        * WebCore.vcproj/WebCore/build-generated-files.sh: export SOURCE_ROOT
        variable

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoForgot these added files.
thatcher [Wed, 13 Sep 2006 16:16:51 +0000 (16:16 +0000)]
Forgot these added files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim H.
thatcher [Wed, 13 Sep 2006 16:12:42 +0000 (16:12 +0000)]
    Reviewed by Tim H.

        Fix Qt/Linux build.

        * CMakeLists.txt: Change SVGZoomEvent.idl location & add RenderFileUploadControl
        * platform/Icon.h: Add wtf/Platform.h include
        * platform/qt/FileChooserQt.cpp: Added as stub. Easy to implement though.
        (WebCore::FileChooser::FileChooser):
        (WebCore::FileChooser::~FileChooser):
        (WebCore::FileChooser::openFileChooser):
        (WebCore::FileChooser::basenameForWidth):
        (WebCore::FileChooser::uploadControlDetaching):
        (WebCore::FileChooser::chooseFile):
        * platform/qt/IconQt.cpp: Added as stub.
        (WebCore::Icon::Icon):
        (WebCore::Icon::~Icon):
        (WebCore::Icon::newIconForFile):
        (WebCore::Icon::paint):
        * platform/qt/TemporaryLinkStubs.cpp: Remove old RenderFileButton code & some new *Labels needed
        (searchableIndexIntroduction):
        (fileButtonChooseFileLabel):
        (fileButtonNoFileSelectedLabel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by eseidel.
aroben [Wed, 13 Sep 2006 07:08:39 +0000 (07:08 +0000)]
    Reviewed by eseidel.

        Switch back to passing relative paths to generate-bindings.pl when
        generating JS bindings.

        * DerivedSources.make: Pass in relative paths to generate-bindings.pl
        * bindings/scripts/CodeGenerator.pm: Make ScanDirectory never call
        chdir and always construct absolute paths instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix for bug 3244, implement html4 label support.
hyatt [Wed, 13 Sep 2006 06:23:56 +0000 (06:23 +0000)]
    Fix for bug 3244, implement html4 label support.

        Reviewed by mjs, aroben

        Added fast/events/label-focus.html

        * css/html4.css:
        * html/HTMLLabelElement.cpp:
        (WebCore::HTMLLabelElement::formElement):
        (WebCore::HTMLLabelElement::setActive):
        (WebCore::HTMLLabelElement::setHovered):
        (WebCore::HTMLLabelElement::defaultEventHandler):
        * html/HTMLLabelElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoNew label layout test.
hyatt [Wed, 13 Sep 2006 06:20:19 +0000 (06:20 +0000)]
New label layout test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-12 Julien Palmas <julien.palmas@gmail.com>
eseidel [Wed, 13 Sep 2006 05:37:00 +0000 (05:37 +0000)]
2006-09-12  Julien Palmas  <julien.palmas@gmail.com>

        Reviewed by darin.  Landed by eseidel.

        * ksvg2/svg/svgpathparser.cpp:
        (WebCore::SVGPolyParser::parsePoints):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
kmccullo [Wed, 13 Sep 2006 01:28:11 +0000 (01:28 +0000)]
LayoutTests:

        Reviewed by Andersca, Maciej, Brady.

        * fast/dom/Range/range-intersectsNode-expected.txt: Added.
        * fast/dom/Range/range-intersectsNode.html: Added.
        * fast/dom/Range/resources/intersectsNode.js: Added.

WebCore:

        Reviewed by Andersca, Maciej, Brady.

        - Implemented intersectsNode in the Range Class
          to be compliant with Mozilla standard

        * dom/Range.cpp:
        (WebCore::Range::intersectsNode):
        * dom/Range.h:
        * dom/Range.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-12 Nikolas Zimmermann <zimmermann@kde.org>
eseidel [Wed, 13 Sep 2006 01:18:41 +0000 (01:18 +0000)]
2006-09-12  Nikolas Zimmermann  <zimmermann@kde.org>

        Reviewed by eseidel.  Landed by eseidel.

        Test: svg/W3C-SVG-1.1/struct-dom-01-b.svg (fixed)
        Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10826

        Also finally fixes some long outstanding bugs:
        Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=9190
        Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=9229
        Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10413

        Enable all JavaScript SVG bindings. Builds on Qt/Linux & OSX.

        * CMakeLists.txt:
        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/scripts/CodeGenerator.pm:
        * bindings/scripts/CodeGeneratorJS.pm:
        * ksvg2/bindings/js/JSSVGElementWrapperFactory.cpp:
        * ksvg2/svg/SVGAElement.idl: Added.
        * ksvg2/svg/SVGAngle.idl:
        * ksvg2/svg/SVGAnimateColorElement.idl: Added.
        * ksvg2/svg/SVGAnimateElement.idl: Added.
        * ksvg2/svg/SVGAnimateTransformElement.idl: Added.
        * ksvg2/svg/SVGAnimatedLengthList.idl: Added.
        * ksvg2/svg/SVGAnimatedNumberList.idl: Added.
        * ksvg2/svg/SVGAnimatedTransformList.idl: Added.
        * ksvg2/svg/SVGAnimationElement.idl: Added.
        * ksvg2/svg/SVGCircleElement.idl: Added.
        * ksvg2/svg/SVGClipPathElement.idl: Added.
        * ksvg2/svg/SVGColor.idl:
        * ksvg2/svg/SVGComponentTransferFunctionElement.idl: Added.
        * ksvg2/svg/SVGCursorElement.idl: Added.
        * ksvg2/svg/SVGDefsElement.idl: Added.
        * ksvg2/svg/SVGDescElement.idl: Added.
        * ksvg2/svg/SVGEllipseElement.idl: Added.
        * ksvg2/svg/SVGEvent.idl:
        * ksvg2/svg/SVGExternalResourcesRequired.idl: Added.
        * ksvg2/svg/SVGFEBlendElement.idl: Added.
        * ksvg2/svg/SVGFEColorMatrixElement.idl: Added.
        * ksvg2/svg/SVGFEComponentTransferElement.idl: Added.
        * ksvg2/svg/SVGFECompositeElement.idl: Added.
        * ksvg2/svg/SVGFEDiffuseLightingElement.idl: Added.
        * ksvg2/svg/SVGFEDisplacementMapElement.idl: Added.
        * ksvg2/svg/SVGFEDistantLightElement.idl: Added.
        * ksvg2/svg/SVGFEFloodElement.idl: Added.
        * ksvg2/svg/SVGFEFuncAElement.idl: Added.
        * ksvg2/svg/SVGFEFuncBElement.idl: Added.
        * ksvg2/svg/SVGFEFuncGElement.idl: Added.
        * ksvg2/svg/SVGFEFuncRElement.idl: Added.
        * ksvg2/svg/SVGFEGaussianBlurElement.idl: Added.
        * ksvg2/svg/SVGFEImageElement.idl: Added.
        * ksvg2/svg/SVGFEMergeElement.idl: Added.
        * ksvg2/svg/SVGFEMergeNodeElement.idl: Added.
        * ksvg2/svg/SVGFEOffsetElement.idl: Added.
        * ksvg2/svg/SVGFEPointLightElement.idl: Added.
        * ksvg2/svg/SVGFESpecularLightingElement.idl: Added.
        * ksvg2/svg/SVGFESpotLightElement.idl: Added.
        * ksvg2/svg/SVGFETileElement.idl: Added.
        * ksvg2/svg/SVGFETurbulenceElement.idl: Added.
        * ksvg2/svg/SVGFilterElement.idl: Added.
        * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.idl: Added.
        * ksvg2/svg/SVGFitToViewBox.idl: Added.
        * ksvg2/svg/SVGForeignObjectElement.idl: Added.
        * ksvg2/svg/SVGGElement.idl: Added.
        * ksvg2/svg/SVGGradientElement.idl: Added.
        * ksvg2/svg/SVGImageElement.idl: Added.
        * ksvg2/svg/SVGLangSpace.idl: Added.
        * ksvg2/svg/SVGLength.idl:
        * ksvg2/svg/SVGLengthList.idl: Added.
        * ksvg2/svg/SVGLineElement.idl: Added.
        * ksvg2/svg/SVGLinearGradientElement.idl: Added.
        * ksvg2/svg/SVGLocatable.idl: Added.
        * ksvg2/svg/SVGMarkerElement.idl: Added.
        * ksvg2/svg/SVGMaskElement.idl: Added.
        * ksvg2/svg/SVGNumberList.idl: Added.
        * ksvg2/svg/SVGPaint.idl: Added.
        * ksvg2/svg/SVGPathElement.idl:
        * ksvg2/svg/SVGPathSeg.idl:
        * ksvg2/svg/SVGPatternElement.idl: Added.
        * ksvg2/svg/SVGPointList.idl: Added.
        * ksvg2/svg/SVGPolygonElement.idl: Added.
        * ksvg2/svg/SVGPolylineElement.idl: Added.
        * ksvg2/svg/SVGPreserveAspectRatio.idl:
        * ksvg2/svg/SVGRadialGradientElement.idl: Added.
        * ksvg2/svg/SVGRectElement.idl: Added.
        * ksvg2/svg/SVGRenderingIntent.idl: Added.
        * ksvg2/svg/SVGSVGElement.idl:
        * ksvg2/svg/SVGScriptElement.idl: Added.
        * ksvg2/svg/SVGSetElement.idl: Added.
        * ksvg2/svg/SVGStopElement.idl: Added.
        * ksvg2/svg/SVGStringList.idl: Added.
        * ksvg2/svg/SVGStylable.idl: Added.
        * ksvg2/svg/SVGStyleElement.idl: Added.
        * ksvg2/svg/SVGSwitchElement.idl: Added.
        * ksvg2/svg/SVGSymbolElement.idl: Added.
        * ksvg2/svg/SVGTRefElement.idl: Added.
        * ksvg2/svg/SVGTSpanElement.idl: Added.
        * ksvg2/svg/SVGTests.idl: Added.
        * ksvg2/svg/SVGTextContentElement.idl: Added.
        * ksvg2/svg/SVGTextElement.idl: Added.
        * ksvg2/svg/SVGTextPositioningElement.idl: Added.
        * ksvg2/svg/SVGTitleElement.idl: Added.
        * ksvg2/svg/SVGTransform.idl:
        * ksvg2/svg/SVGTransformList.idl: Added.
        * ksvg2/svg/SVGTransformable.idl: Added.
        * ksvg2/svg/SVGURIReference.idl: Added.
        * ksvg2/svg/SVGUnitTypes.idl: Added.
        * ksvg2/svg/SVGUseElement.idl: Added.
        * ksvg2/svg/SVGViewElement.idl: Added.
        * ksvg2/svg/SVGZoomAndPan.idl: Added.
        * ksvg2/svg/SVGZoomEvent.idl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by timo, ggaren.
aroben [Wed, 13 Sep 2006 00:25:14 +0000 (00:25 +0000)]
    Reviewed by timo, ggaren.

        Make Icon ref-counted.

        * platform/FileChooser.h: Store m_icon as a RefPtr instead of
        auto_ptr.
        * platform/Icon.h: Inherit from Shared<Icon>
        * platform/mac/FileChooserMac.mm:
        (WebCore::FileChooser::chooseFile): Update m_icon usage
        * platform/mac/IconMac.mm:
        (WebCore::Icon::newIconForFile): Return a RefPtr instead of an
        auto_ptr

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFixing the versioning.
thatcher [Tue, 12 Sep 2006 23:57:26 +0000 (23:57 +0000)]
Fixing the versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoVersioning
thatcher [Tue, 12 Sep 2006 22:26:08 +0000 (22:26 +0000)]
Versioning

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16331 268f45cc-cd09-0410-ab3c-d52691b4dbfc