11 years agoWebCore:
darin@apple.com [Tue, 12 May 2009 01:25:11 +0000 (01:25 +0000)]

2009-05-11  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        <rdar://problem/6276843> REGRESSION: TextIterator generates
        an extra newline for ranges that start outside of body

        * editing/TextIterator.cpp:
        Check startPos for null, not just currPos.


2009-05-11  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        <rdar://problem/6276843> REGRESSION: TextIterator generates
        an extra newline for ranges that start outside of body

        * editing/text-iterator/basic-iteration-expected.txt:
        Expect success, not failure.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 25700: Regression:WebKit:cmd-left and cmd-right use to go to the beginning and...
cfleizach@apple.com [Tue, 12 May 2009 01:09:50 +0000 (01:09 +0000)]
Bug 25700: Regression:WebKit:cmd-left and cmd-right use to go to the beginning and end of a line in Mail

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-11 Sam Weinig <sam@webkit.org>
weinig@apple.com [Tue, 12 May 2009 01:06:58 +0000 (01:06 +0000)]
2009-05-11  Sam Weinig  <sam@webkit.org>

        Reviewed by Geoffrey Garen.

        Start re-factoring JIT code generation to move op_code generation
        to helper functions outside the main switch-statement and gave those
        helper functions standardized names.  This patch only covers the main
        pass and all the arithmetic opcodes in the slow path.

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * jit/JIT.cpp:
        * jit/JIT.h:
        * jit/JITArithmetic.cpp:
        * jit/JITOpcodes.cpp: Copied from jit/JIT.cpp.
        * jit/JITPropertyAccess.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-11 Christian Dywan <christian@twotoasts.de>
christian@webkit.org [Tue, 12 May 2009 00:48:38 +0000 (00:48 +0000)]
2009-05-11  Christian Dywan  <christian@twotoasts.de>

        Reviewed by Gustavo Noronha.

        [GTK] Warnings building WebKit/gtk/tests/testwebframe.c

        * tests/testwebframe.c:
        (test_webkit_web_frame_create_destroy): Declare webView as a GtkWidget*
        to fix pointer type incompatibility warnings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-11 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Tue, 12 May 2009 00:28:17 +0000 (00:28 +0000)]
2009-05-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Enable the new passing test, and skip two new failing tests.

        * platform/gtk/Skipped:
        * platform/gtk/fast/css/compare-content-style-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Bug 25087: Test for ENABLE_FOO macros consistently in IDL files
ddkilzer@apple.com [Tue, 12 May 2009 00:14:03 +0000 (00:14 +0000)]
    Bug 25087: Test for ENABLE_FOO macros consistently in IDL files


        Reviewed by Timothy Hatcher.

        Change tests for ENABLE macros to check for both existence and

        - Negative:  #if !defined(ENABLE_FOO) || !ENABLE_FOO
        - Positive:  #if defined(ENABLE_FOO) && ENABLE_FOO

        * css/CSSCharsetRule.idl:
        * css/CSSPrimitiveValue.idl:
        * css/RGBColor.idl:
        * dom/Attr.idl:
        * dom/DOMCoreException.idl:
        * dom/DOMImplementation.idl:
        * dom/Document.idl:
        * dom/Element.idl:
        * dom/Event.idl:
        * dom/EventException.idl:
        * dom/KeyboardEvent.idl:
        * dom/MessagePort.idl:
        * dom/MouseEvent.idl:
        * dom/Node.idl:
        * dom/ProcessingInstruction.idl:
        * dom/Range.idl:
        * dom/RangeException.idl:
        * dom/WheelEvent.idl:
        * html/CanvasPixelArray.idl:
        * html/HTMLAnchorElement.idl:
        * html/HTMLAppletElement.idl:
        * html/HTMLAreaElement.idl:
        * html/HTMLBaseFontElement.idl:
        * html/HTMLCanvasElement.idl:
        * html/HTMLDocument.idl:
        * html/HTMLElement.idl:
        * html/HTMLEmbedElement.idl:
        * html/HTMLFrameElement.idl:
        * html/HTMLIFrameElement.idl:
        * html/HTMLImageElement.idl:
        * html/HTMLInputElement.idl:
        * html/HTMLLinkElement.idl:
        * html/HTMLObjectElement.idl:
        * html/HTMLOptionElement.idl:
        * html/HTMLOptionsCollection.idl:
        * html/HTMLSelectElement.idl:
        * html/HTMLStyleElement.idl:
        * html/ImageData.idl:
        * inspector/InspectorController.idl:
        * loader/appcache/DOMApplicationCache.idl:
        * page/Console.idl:
        * page/Coordinates.idl:
        * page/DOMSelection.idl:
        * page/DOMWindow.idl:
        * page/Geoposition.idl:
        * page/History.idl:
        * page/Location.idl:
        * page/Navigator.idl:
        * svg/SVGElementInstance.idl:
        * svg/SVGException.idl:
        * workers/WorkerContext.idl:
        * xml/XMLHttpRequestException.idl:
        * xml/XPathException.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdded missing bug titles and URLs.
darin@apple.com [Tue, 12 May 2009 00:03:35 +0000 (00:03 +0000)]
Added missing bug titles and URLs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
darin@apple.com [Tue, 12 May 2009 00:01:18 +0000 (00:01 +0000)]

2009-05-11  Norbert Leser  <norbert.leser@nokia.com>

        Reviewed by Darin Adler.

        class/struct mix-up in forward declarations

        * inspector/InspectorResource.h:
        * loader/CachedFont.h:
        * loader/appcache/ApplicationCache.h:
        * rendering/RenderBlock.h:
        * rendering/RootInlineBox.h:
        * rendering/SVGInlineTextBox.h:
        * svg/SVGGlyphElement.h:
        * svg/SVGHKernElement.h:


2009-05-11  Norbert Leser  <norbert.leser@nokia.com>

        Reviewed by Darin Adler.

        class/struct mix-up in forward declarations

        * Api/qwebpage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-11 Norbert Leser <norbert.leser@nokia.com>
darin@apple.com [Mon, 11 May 2009 23:54:27 +0000 (23:54 +0000)]
2009-05-11  Norbert Leser  <norbert.leser@nokia.com>

        Reviewed by Darin Adler.

        The Symbian tools can't compile and link this without this include.
        It's not clear why this is different from other toolsets or why it affects
        only this header file, but adding the include for now.

        * editing/RemoveCSSPropertyCommand.h: Added include of CSSMutableStyleDeclaration.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
alice.liu@apple.com [Mon, 11 May 2009 23:35:07 +0000 (23:35 +0000)]

2009-05-11  Alice Liu  <alice.liu@apple.com>

        Reviewed by Dan Bernstein.

        REGRESSION(r38788 & r42020): styled searchfields look wrong on Windows, affects Facebook

        Test: fast/forms/search-styled.html

        * css/themeWin.css:
        Remove the overriding of -webkit-appearance for searchfields. This will cause background
        images to not be honored when styling searchfields

        * rendering/RenderThemeWin.cpp:
        * rendering/RenderThemeWin.h:
        Re-instate final adjustments to searchfield styling that were removed in r42020


2009-05-11  Alice Liu  <alice.liu@apple.com>

        Reviewed by Dan Bernstein.

        REGRESSION(r38788 & r42020): styled searchfields look wrong on Windows, affects Facebook

        * fast/forms/search-styled.html: Added.
        * platform/mac/fast/forms/search-styled-expected.txt: Added.
        * platform/win/fast/forms/search-styled-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Re-add experimental PGO configs.
sfalken@apple.com [Mon, 11 May 2009 23:02:32 +0000 (23:02 +0000)]
    Re-add experimental PGO configs.

        Reviewed by Adam Roben.

        * JavaScriptCore.vcproj/JavaScriptCore.make:
        * JavaScriptCore.vcproj/JavaScriptCore.sln:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln:
        * JavaScriptCore.vcproj/jsc/jsc.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Include SunSpider tests in production builds.
sfalken@apple.com [Mon, 11 May 2009 22:54:46 +0000 (22:54 +0000)]
    Include SunSpider tests in production builds.

        Reviewed by Adam Roben.

        * SunSpider.make: Added.
        * xcopy.excludes: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-11 Brady Eidson <beidson@apple.com>
beidson@apple.com [Mon, 11 May 2009 22:00:46 +0000 (22:00 +0000)]
2009-05-11  Brady Eidson  <beidson@apple.com>

        Fix Windows build

        * platform/network/cf/ResourceHandleCFNet.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-11 Nate Chapin <japhet@google.com>
dglazkov@chromium.org [Mon, 11 May 2009 22:00:06 +0000 (22:00 +0000)]
2009-05-11  Nate Chapin  <japhet@google.com>

        Reviewed by Dimitri Glazkov.

        Update V8ElementCustom.cpp to match the current API of Node.

        * bindings/v8/custom/V8ElementCustom.cpp:
        (WebCore::ACCESSOR_SETTER): Changed a couple of method names to match current names.
        (WebCore::ACCESSOR_GETTER): Changed a method name to match current name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-11 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 11 May 2009 21:49:43 +0000 (21:49 +0000)]
2009-05-11  Sam Weinig  <sam@webkit.org>

        Reviewed by Geoffrey "1" Garen.

        Rip out the !USE(CTI_REPATCH_PIC) code.  It was untested and unused.

        * jit/JIT.h:
        * jit/JITPropertyAccess.cpp:
        * jit/JITStubs.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-11 Brady Eidson <beidson@apple.com>
beidson@apple.com [Mon, 11 May 2009 21:49:14 +0000 (21:49 +0000)]
2009-05-11  Brady Eidson  <beidson@apple.com>

        Fix Windows build

        * platform/network/cf/ResourceHandleCFNet.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-11 Brady Eidson <beidson@apple.com>
beidson@apple.com [Mon, 11 May 2009 21:36:03 +0000 (21:36 +0000)]
2009-05-11  Brady Eidson  <beidson@apple.com>

        Fix Windows build

        * platform/network/cf/ResourceHandleCFNet.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-11 Nate Chapin <japhet@google.com>
dglazkov@chromium.org [Mon, 11 May 2009 21:35:35 +0000 (21:35 +0000)]
2009-05-11  Nate Chapin  <japhet@google.com>

        Reviewed by Dimitri Glazkov.

        V8CustomBinding.cpp is missing a header file


        * bindings/v8/custom/V8CustomBinding.cpp: Added #include "V8Proxy.h".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-11 Aaron Boodman <aa@chromium.org>
dglazkov@chromium.org [Mon, 11 May 2009 21:30:26 +0000 (21:30 +0000)]
2009-05-11  Aaron Boodman  <aa@chromium.org>

        Reviewed by Darin Fisher.

        Change V8Proxy::retrieveActiveFrame() call sites to V8Proxy::retrieveFrameForEnteredContext().

        Also, change instances of ScriptController::retrieveActiveFrame() to
        V8::retrieveFrameForEnteredContext() for consistency.

        See http://codereview.chromium.org/113085 for the corresponding Chromium change.

        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
        * bindings/v8/custom/V8LocationCustom.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
beidson@apple.com [Mon, 11 May 2009 21:06:30 +0000 (21:06 +0000)]

2009-05-11  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/5972751> Local image files (BMP, ico) can be misidentified as HTML.

        First part of the fix - Disable content sniffing for file resources which never should've been happening anyways.
        Second part of the fix - If the networking layer doesn't give us back a MIME type default to "application/octet-stream".

        * platform/MIMETypeRegistry.cpp:
        (WebCore::defaultMIMEType): "application/octet-stream"
        * platform/MIMETypeRegistry.h:

        * platform/network/ResourceHandle.cpp:
        (WebCore::ResourceHandle::create): If content sniffing is true, double check with "shouldContentSniffRequest()" which
          might override it to false.
        (WebCore::ResourceHandle::shouldContentSniffURL): Return false for file:// urls, true for everything else.
        * platform/network/ResourceHandle.h:

        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::createCFURLResponseWithDefaultMIMEType): Create a copy of the CFURLRequest with the default MIME type instead
          of null.
        (WebCore::didReceiveResponse): If the MIME type for the response is null, create a copy with the default MIME type.
        (WebCore::WebCoreSynchronousLoader::load): Use shouldContentSniffRequest() to make synchronous loads have the same
          sniffing policy as asynchronous loads.  Also, correct a null MIME type by creating a copy with the default type.

        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::loadResourceSynchronously): Use shouldContentSniffRequest() to make synchronous loads have the
          same sniffing policy as asynchronous loads.
        (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]): Set up the [NSURLResponse MIMEType] swizzling if
          it hasn't been set up yet.
        (_web_NSURLResponse_MIMEType): Either return the actual MIME type of the response, or the default MIME type if it's nil.

        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::loadRequestAsynchronously): Remove the workaround added in r29370 as it will now be covered by
          the new mechanism.


2009-05-11  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler.

        * platform/mac-leopard/Skipped: Skip fast/images/favicon-as-image.html until we can come up
          with a better solution to its new failure.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-11 Dmitry Titov <dimich@chromium.org>
dimich@chromium.org [Mon, 11 May 2009 20:37:49 +0000 (20:37 +0000)]
2009-05-11  Dmitry Titov  <dimich@chromium.org>

        GTK build fix - the deprecated waitForThreadCompletion is not needed on GTK.

        * wtf/ThreadingPthreads.cpp: added #ifdef PLATFORM(DARWIN) around waitForThreadCompletion().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

ddkilzer@apple.com [Mon, 11 May 2009 20:34:52 +0000 (20:34 +0000)]

        This was added in r39816 to disable dynamic entries.  They are
        still disabled after fixing the typo since this feature define
        is never set anywhere.

        * bindings/js/JSDOMApplicationCacheCustom.cpp:
        * loader/appcache/DOMApplicationCache.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Build fix for newer versions of GCC
aroben@apple.com [Mon, 11 May 2009 20:28:40 +0000 (20:28 +0000)]
    Build fix for newer versions of GCC

        * wtf/ThreadingPthreads.cpp: Added a declaration of
        waitForThreadCompletion before its definition to silence a warning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
dimich@chromium.org [Mon, 11 May 2009 19:49:04 +0000 (19:49 +0000)]

2009-05-11  Dmitry Titov  <dimich@chromium.org>

        Reviewed by Alexey Proskuryakov and Adam Roben.

        Change WTF::ThreadIdentifier to be an actual (but wrapped) thread id, remove ThreadMap.

        * wtf/Threading.h:
        ThreadIdentifier is now a class, containing a PlatformThreadIdentifier and
        methods that are used across the code on thread ids: construction, comparisons,
        check for 'valid' state etc. '0' is used as invalid id, which happens to just work
        with all platform-specific thread id implementations.

        All the following files repeatedly reflect the new ThreadIdentifier for each platform.
        We remove ThreadMap and threadMapMutex from all of them, remove the functions that
        populated/searched/cleared the map and add platform-specific comparison operators
        for ThreadIdentifier.

        There are specific temporary workarounds for Safari 4 beta on OSX and Win32 since the
        public build uses WTF threading functions with old type of ThreadingIdentifier.
        The next time Safari 4 is rebuilt, it will 'automatically' pick up the new type and new
        functions so the deprecated ones can be removed.

        * wtf/gtk/ThreadingGtk.cpp:

        * wtf/ThreadingNone.cpp:

        * wtf/ThreadingPthreads.cpp:
        (WTF::waitForThreadCompletion): This is a workaround for Safari 4 beta on Mac.
        Safari 4 is linked against old definition of ThreadIdentifier so it treats it as uint32_t.
        This 'old' variant of waitForThreadCompletion takes uint32_t and has the old decorated name, so Safari can
        load it from JavaScriptCore library. The other functions (CurrentThread() etc) happen to match their previous
        decorated names and, while they return pthread_t now, it is a pointer which round-trips through a uint32_t.
        This function will be removed as soon as Safari 4 will release next public build.

        * wtf/qt/ThreadingQt.cpp:

        * wtf/ThreadingWin.cpp:
        (WTF::createThreadInternal): All the platforms (except Windows) used a sequential
        counter as a thread ID and mapped it into platform ID. Windows was using native thread
        id and mapped it into thread handle. Since we can always obtain a thread handle
        by thread id, createThread now closes the handle.
        (WTF::waitForThreadCompletion): obtains another one using OpenThread(id) API. If can not obtain a handle,
        it means the thread already exited.
        (WTF::detachThreadDeprecated): old function, renamed (for Win Safari 4 beta which uses it for now).
        (WTF::waitForThreadCompletionDeprecated): same.
        (WTF::currentThreadDeprecated): same.
        (WTF::createThreadDeprecated): same.

        * bytecode/SamplingTool.h:
        * bytecode/SamplingTool.cpp: Use DEFINE_STATIC_LOCAL for a static ThreadIdentifier variable, to avoid static constructor.

        * JavaScriptCore.exp: export lists - updated decorated names of the WTF threading functions
        since they now take a different type as a parameter.
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: ditto for Windows, plus added "deprecated" functions
        that take old parameter type - turns out public beta of Safari 4 uses those, so they need to be kept along for a while.
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: ditto.


2009-05-11  Dmitry Titov  <dimich@chromium.org>

        Reviewed by Alexey Proskuryakov and Adam Roben.

        Change WTF::ThreadIdentifier to be an actual (but wrapped) thread id, remove ThreadMap.

        Most of the change is in WTF.
        Unless noted, all the following files changed to use the new ThreadIdentifier::isValid()
        method instead of just doing 'if(m_threadID)' kind of checks, since ThreadIdentifier
        is now a class rather then an integer.
        Also, there is no need to initialize threadID in constructors to 0 now.

        * dom/XMLTokenizerLibxml2.cpp:
        (WebCore::libxmlLoaderThread): use DEFINE_STATIC_LOCAL and accessor function for static thread id,
        since now ThreadIdentifier needs construction and we avoid having global initializers.
        (WebCore::matchFunc): use the new accessor function.
        (WebCore::openFunc): ditto.
        (WebCore::createStringParser): ditto.
        (WebCore::createMemoryParser): ditto.
        * loader/icon/IconDatabase.cpp:
        * platform/sql/SQLiteDatabase.cpp:
        * storage/DatabaseThread.cpp:
        (WebCore::DatabaseThread::databaseThread): remove m_threadID from debug output.
        * storage/LocalStorageThread.cpp:
        * workers/WorkerThread.cpp:


2009-05-11  Dmitry Titov  <dimich@chromium.org>

        Reviewed by Alexey Proskuryakov and Adam Roben.

        Change WTF::ThreadIdentifier to be an actual (but wrapped) thread id, remove ThreadMap.

        Most of the change is in WTF and WebCore.

        * WebKit.vcproj/WebKit.def: replaced decorated names of WTF threading functions with new ones.
        Also, aliased the old implementations so the public Safari 4 beta can load the old WTF functions
        which it uses. Next time Safari 4 builds, it will pick up new functions and the deprecated ones
        can be removed.
        * WebKit.vcproj/WebKit_debug.def: same.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
darin@apple.com [Mon, 11 May 2009 18:54:49 +0000 (18:54 +0000)]

2009-05-11  Darin Adler  <darin@apple.com>

        Reviewed by Oliver Hunt.

        Bug 25560: REGRESSION (r34821): "string value".__proto__ gets the wrong object.

        I missed this case back a year ago when I sped up handling
        of JavaScript wrappers. Easy to fix.

        * runtime/JSObject.h:
        (JSC::JSValue::get): Return the prototype itself if the property name
        is __proto__.
        * runtime/JSString.cpp:
        (JSC::JSString::getOwnPropertySlot): Ditto.


2009-05-11  Darin Adler  <darin@apple.com>

        Reviewed by Oliver Hunt.

        Bug 25560: REGRESSION (r34821): "string value".__proto__ gets the wrong object.

        * fast/js/prototypes-expected.txt: Added.
        * fast/js/prototypes.html: Added.
        * fast/js/resources/prototypes.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRename emitGetFromCallFrameHeader to emitGetFromCallFrameHeaderPtr
oliver@apple.com [Mon, 11 May 2009 18:05:45 +0000 (18:05 +0000)]
Rename emitGetFromCallFrameHeader to emitGetFromCallFrameHeaderPtr

Reviewed by Maciej Stachowiak

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-11 Brady Eidson <beidson@apple.com>
beidson@apple.com [Mon, 11 May 2009 17:28:42 +0000 (17:28 +0000)]
2009-05-11  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler.

        Remove unused header that declared one function which was never defined anywhere.

        * WebCore.vcproj/WebCore.vcproj:
        * platform/network/cf/ResourceResponseCFNet.cpp: Change to include ResourceResponse.h (which really means
        * platform/network/cf/ResourceResponseCFNet.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Added webarchive/test-link-rel-icon.html to gtk Skipped list
ddkilzer@apple.com [Mon, 11 May 2009 17:06:08 +0000 (17:06 +0000)]
    Added webarchive/test-link-rel-icon.html to gtk Skipped list

        * platform/gtk/Skipped: Added webarchive/test-link-rel-icon.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-11 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Mon, 11 May 2009 17:00:30 +0000 (17:00 +0000)]
2009-05-11  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Timothy Hatcher.

        Fix assert during Inspector destruction.

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::inspectedPageDestroyed): Moved closing
            inspector above removing InspectorController object to fix JS errors,
            added clearing inspector page ptr.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Bug 23331: LayoutTests/webarchive/test-link-rel-icon.html fails in different...
ddkilzer@apple.com [Mon, 11 May 2009 16:44:56 +0000 (16:44 +0000)]
    Bug 23331: LayoutTests/webarchive/test-link-rel-icon.html fails in different ways on buildbots


        Reviewed by Brady Eidson.

        * webarchive/test-link-rel-icon-expected.webarchive: Updated
        results after removing workaround in the test.
        * webarchive/test-link-rel-icon.html: Copied from webarchive/test-link-rel-icon.html-disabled.
        Removed workaround for Bug 21026 / <rdar://problem/6240826>.
        * webarchive/test-link-rel-icon.html-disabled: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Build fix, build ParserArena.cpp
zecke@webkit.org [Mon, 11 May 2009 16:22:58 +0000 (16:22 +0000)]
[Qt] Build fix, build ParserArena.cpp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore
zecke@webkit.org [Mon, 11 May 2009 16:22:42 +0000 (16:22 +0000)]
2009-05-11  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Holger Freyther.

        [Qt] Make sure that public APIs are properly exported on all Qt platforms

        * WebCore.pro: Define QT_MAKEDLL for all non-static builds, not just for win

2009-05-11  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Holger Freyther.

        [Qt] Make sure that public APIs are properly exported on all Qt platforms

        * Scripts/webkitdirs.pm: Remove QT_SHARED define from Qt builds, define QT_MAKEDLL in WebCore.pro instead

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-11 Laszlo Gombos <laszlo.1.gombos@nokia.com>
zecke@webkit.org [Mon, 11 May 2009 16:22:16 +0000 (16:22 +0000)]
2009-05-11  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Holger Freyther.

        Fix Qt build when ENABLE_DATABASE is turned off


        * Api/qwebdatabase.cpp:
        * Api/qwebdatabase_p.h:
        * Api/qwebsecurityorigin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-11 Norbert Leser <norbert.leser@nokia.com>
zecke@webkit.org [Mon, 11 May 2009 16:22:00 +0000 (16:22 +0000)]
2009-05-11  Norbert Leser  <norbert.leser@nokia.com>

        Reviewed by Darin Adler.


        Symbian compilers cannot resolve WTF::PassRefPtr<JSC::Profile>
        unless Profile.h is included.

        * profiler/ProfileGenerator.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore
zecke@webkit.org [Mon, 11 May 2009 16:21:45 +0000 (16:21 +0000)]
2009-05-11  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>

        Reviewed by Holger Freyther.


        * JavaScriptCore.pri: coding style modified
        * jsc.pro: duplicated values removed from INCLUDEPATH, DEFINES

2009-05-11  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>

        Reviewed by Holger Freyther.


        * WebCore.pro: duplicated values removed from INCLUDEPATH

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-11 Laszlo Gombos <laszlo.1.gombos@nokia.com>
zecke@webkit.org [Mon, 11 May 2009 16:21:18 +0000 (16:21 +0000)]
2009-05-11  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Eric Seidel.

        Build fix Symbian; clean Up WebKit/Qt if ENABLE_NETSCAPE_PLUGIN_API=0

        * WebCore.pro: Use platform independent plugin stubs if ENABLE_NETSCAPE_PLUGIN_API=0
        * platform/qt/TemporaryLinkStubs.cpp: Remove stub functions for plugins

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-11 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 11 May 2009 16:10:05 +0000 (16:10 +0000)]
2009-05-11  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Fix failure seen on most of the buildbots.

        * fast/forms/text-control-intrinsic-widths-expected.txt: Rolled back to the
        version before Hyatt's recent intrinsic margin check-in. According to Dan,
        that should not have had any effect on this test, so these results reflect
        some other sort of difference on Hyatt's computer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-11 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Mon, 11 May 2009 15:17:11 +0000 (15:17 +0000)]
2009-05-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by NOBODY (build fix).

        Also add ParserArena, in addition to AllInOne, for release builds,
        since adding it to AllInOne breaks Mac.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-11 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Mon, 11 May 2009 14:55:58 +0000 (14:55 +0000)]
2009-05-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Unreviewed build fix. Adding ParserArena to the autotools build.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago More Windows build fixes after r43479
aroben@apple.com [Mon, 11 May 2009 14:50:21 +0000 (14:50 +0000)]
    More Windows build fixes after r43479

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
        Export ParserArena::reset.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Windows build fixes after r43479
aroben@apple.com [Mon, 11 May 2009 14:36:20 +0000 (14:36 +0000)]
    Windows build fixes after r43479

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Added
        ParserArena to the project.

        * parser/NodeConstructors.h: Added a missing include.
        (JSC::ParserArenaDeletable::operator new): Marked these as inline.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-11 Anton Shestakov <engored@ya.ru>
kov@webkit.org [Mon, 11 May 2009 13:57:35 +0000 (13:57 +0000)]
2009-05-11  Anton Shestakov  <engored@ya.ru>

        Rubber-stamped by Gustavo Noronha.

        New Russian translation.

        * ru.po: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRevert "2009-05-11 Jan Michael Alonzo <jmalonzo@webkit.org>"
jmalonzo@webkit.org [Mon, 11 May 2009 10:55:25 +0000 (10:55 +0000)]
Revert "2009-05-11  Jan Michael Alonzo  <jmalonzo@webkit.org>"

This reverts commit r43485 as it fails the mac bots.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-11 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Mon, 11 May 2009 10:34:16 +0000 (10:34 +0000)]
2009-05-11  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by NOBODY (BuildFix).

        Add ParserArena to AllInOneFile as well as gtk, qt and wx build

        * AllInOneFile.cpp:
        * GNUmakefile.am:
        * JavaScriptCore.pri:
        * JavaScriptCoreSources.bkl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-10 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Mon, 11 May 2009 06:06:30 +0000 (06:06 +0000)]
2009-05-10  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Geoff Garen.

        - fixed REGRESSION(r43432): Many JavaScriptCore tests crash in 64-bit

        Accound for the 64-bit instruction prefix when rewriting mov to lea on 64-bit.

        * jit/JIT.h:
        * jit/JITPropertyAccess.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-10 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 11 May 2009 04:30:14 +0000 (04:30 +0000)]
2009-05-10  Darin Adler  <darin@apple.com>

        Reviewed by Cameron Zwarich.

        Bug 25674: syntax tree nodes should use arena allocation

        Part two: Remove reference counting from most nodes.

        * JavaScriptCore.exp: Updated.

        * JavaScriptCore.xcodeproj/project.pbxproj: Added ParserArena.h and .cpp.

        * parser/Grammar.y: Replaced uses of ParserRefCountedData with uses of
        ParserArenaData. Took out now-nonfunctional code that tries to manually
        release declaration list. Changed the new calls that create FuncDeclNode
        and FuncExprNode so that they use the proper version of operator new for
        the reference-counted idiom, not the deletion idiom.

        * parser/NodeConstructors.h:
        (JSC::ParserArenaDeletable::operator new): Added.
        (JSC::ParserArenaRefCounted::ParserArenaRefCounted): Added.
        (JSC::Node::Node): Removed ParserRefCounted initializer.
        (JSC::ElementNode::ElementNode): Ditto.
        (JSC::PropertyNode::PropertyNode): Ditto.
        (JSC::ArgumentsNode::ArgumentsNode): Ditto.
        (JSC::SourceElements::SourceElements): Ditto.
        (JSC::ParameterNode::ParameterNode): Ditto.
        (JSC::FuncExprNode::FuncExprNode): Added ParserArenaRefCounted initializer.
        (JSC::FuncDeclNode::FuncDeclNode): Ditto.
        (JSC::CaseClauseNode::CaseClauseNode): Removed ParserRefCounted initializer.
        (JSC::ClauseListNode::ClauseListNode): Ditto.
        (JSC::CaseBlockNode::CaseBlockNode): Ditto.

        * parser/NodeInfo.h: Replaced uses of ParserRefCountedData with uses of

        * parser/Nodes.cpp:
        (JSC::ScopeNode::ScopeNode): Added ParserArenaRefCounted initializer.
        (JSC::ProgramNode::create): Use the proper version of operator new for
        the reference-counted idiom, not the deletion idiom. Use the arena
        contains function instead of the vecctor find function.
        (JSC::EvalNode::create): Use the proper version of operator new for
        the reference-counted idiom, not the deletion idiom. Use the arena
        reset function instead of the vector shrink function.
        (JSC::FunctionBodyNode::createNativeThunk): Use the proper version
        of operator new for the reference-counted idiom, not the deletion idiom.
        (JSC::FunctionBodyNode::create): More of the same.

        * parser/Nodes.h: Added ParserArenaDeletable and ParserArenaRefCounted
        to replace ParserRefCounted. Fixed inheritance so only the classes that
        need reference counting inherit from ParserArenaRefCounted.

        * parser/Parser.cpp:
        (JSC::Parser::parse): Set m_sourceElements to 0 since it now starts
        uninitialized. Just set it to 0 again in the failure case, since it's
        now just a raw pointer, not an owning one.
        (JSC::Parser::reparseInPlace): Removed now-unneeded get() function.
        (JSC::Parser::didFinishParsing): Replaced uses of ParserRefCountedData
        with uses of ParserArenaData.

        * parser/Parser.h: Less RefPtr, more arena.

        * parser/ParserArena.cpp: Added.
        * parser/ParserArena.h: Added.

        * runtime/JSGlobalData.cpp:
        (JSC::JSGlobalData::~JSGlobalData): Removed arena-related code, since it's
        now in the Parser.
        (JSC::JSGlobalData::createLeaked): Removed unneeded #ifndef.
        (JSC::JSGlobalData::createNativeThunk): Tweaked #if a bit.

        * runtime/JSGlobalData.h: Removed parserArena, which is now in Parser.

        * wtf/RefCounted.h: Added deletionHasBegun function, for use in
        assertions to catch deletion not done by the deref function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Part 2: Try to fix the Windows build by adding a symbol which is really just...
ddkilzer@apple.com [Mon, 11 May 2009 00:48:31 +0000 (00:48 +0000)]
    Part 2: Try to fix the Windows build by adding a symbol which is really just a re-mangling of a changed method signature

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mitz@apple.com [Mon, 11 May 2009 00:43:05 +0000 (00:43 +0000)]

        Reviewed by Darin Adler.

        - fix a crash when deactivating a document that had adopted a <form>

        Test: fast/dom/HTMLFormElement/document-deactivation-callback-crash.html

        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::didMoveToNewOwnerDocument): Corrected the
        logic here: <form> elements should be registered for document activation
        callbacks if and only if autocomplete is off.


        Reviewed by Darin Adler.

        - test for a crash when deactivating a document that had adopted a
          <form> element

        * fast/dom/HTMLFormElement/document-deactivation-callback-crash-expected.txt: Added.
        * fast/dom/HTMLFormElement/document-deactivation-callback-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Try to fix the Windows build by removing an unknown symbol
ddkilzer@apple.com [Mon, 11 May 2009 00:36:15 +0000 (00:36 +0000)]
    Try to fix the Windows build by removing an unknown symbol

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Touch Nodes.cpp to try to fix Windows build
ddkilzer@apple.com [Mon, 11 May 2009 00:27:40 +0000 (00:27 +0000)]
    Touch Nodes.cpp to try to fix Windows build

        * parser/Nodes.cpp: Removed whitespace.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Test for Bug 23741: StyleRareNonInheritedData::operator==() should not compar...
ddkilzer@apple.com [Mon, 11 May 2009 00:03:04 +0000 (00:03 +0000)]
    Test for Bug 23741: StyleRareNonInheritedData::operator==() should not compare ContentData objects by pointer

        Rubber-stamped by Geoff Garen.

        Original test by Simon Fraser.

        * fast/css/compare-content-style.html: Added.
        * platform/mac/fast/css/compare-content-style-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-10 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 10 May 2009 22:46:23 +0000 (22:46 +0000)]
2009-05-10  Darin Adler  <darin@apple.com>

        Reviewed by Maciej Stachowiak.

        Quick fix for failures seen on buildbot. Maciej plans a better fix later.

        * wtf/dtoa.cpp: Change the hardcoded number of 32-bit words in a BigInt
        from 32 to 64. Parsing "1e500", for example, requires more than 32 words.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-10 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 10 May 2009 22:32:34 +0000 (22:32 +0000)]
2009-05-10  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Bug 25674: syntax tree nodes should use arena allocation
        Part one: Change lifetimes so we won't have to use reference
        counting so much, but don't eliminate the reference counts
        entirely yet.

        * JavaScriptCore.exp: Updated.

        * bytecompiler/BytecodeGenerator.cpp:
        (JSC::BytecodeGenerator::BytecodeGenerator): Update for use of raw pointers
        instead of RefPtr.
        (JSC::BytecodeGenerator::emitCall): Ditto.
        (JSC::BytecodeGenerator::emitConstruct): Ditto.

        * parser/Grammar.y: Update node creating code to use new (JSGlobalData*)
        instead of the plain new. At the moment this is just a hook for future
        arena allocation; it's inline and JSGlobalData* is not used.

        * parser/NodeConstructors.h: Updated for name change of parserObjects to
        parserArena. Also added explicit initialization for raw pointers that used
        to be RefPtr. Also removed some uses of get() that aren't needed now that
        the pointers are raw pointers. Also eliminated m_parameter from FuncExprNode
        and FuncDeclNode. Also changed node-creating code to use new (JSGlobalData*)
        as above.

        * parser/Nodes.cpp: Eliminated NodeReleaser and all use of it.
        (JSC::ParserRefCounted::ParserRefCounted): Updated for name change of
        parserObjects to parserArena.
        (JSC::SourceElements::append): Use raw pointers.
        (JSC::ArrayNode::emitBytecode): Ditto.
        (JSC::ArrayNode::isSimpleArray): Ditto.
        (JSC::ArrayNode::toArgumentList): Ditto.
        (JSC::ObjectLiteralNode::emitBytecode): Ditto.
        (JSC::PropertyListNode::emitBytecode): Ditto.
        (JSC::BracketAccessorNode::emitBytecode): Ditto.
        (JSC::DotAccessorNode::emitBytecode): Ditto.
        (JSC::ArgumentListNode::emitBytecode): Ditto.
        (JSC::NewExprNode::emitBytecode): Ditto.
        (JSC::EvalFunctionCallNode::emitBytecode): Ditto.
        (JSC::FunctionCallValueNode::emitBytecode): Ditto.
        (JSC::FunctionCallResolveNode::emitBytecode): Ditto.
        (JSC::FunctionCallBracketNode::emitBytecode): Ditto.
        (JSC::FunctionCallDotNode::emitBytecode): Ditto.
        (JSC::CallFunctionCallDotNode::emitBytecode): Ditto.
        (JSC::ApplyFunctionCallDotNode::emitBytecode): Ditto.
        (JSC::PostfixBracketNode::emitBytecode): Ditto.
        (JSC::PostfixDotNode::emitBytecode): Ditto.
        (JSC::DeleteBracketNode::emitBytecode): Ditto.
        (JSC::DeleteDotNode::emitBytecode): Ditto.
        (JSC::DeleteValueNode::emitBytecode): Ditto.
        (JSC::VoidNode::emitBytecode): Ditto.
        (JSC::TypeOfValueNode::emitBytecode): Ditto.
        (JSC::PrefixBracketNode::emitBytecode): Ditto.
        (JSC::PrefixDotNode::emitBytecode): Ditto.
        (JSC::UnaryOpNode::emitBytecode): Ditto.
        (JSC::BinaryOpNode::emitStrcat): Ditto.
        (JSC::BinaryOpNode::emitBytecode): Ditto.
        (JSC::EqualNode::emitBytecode): Ditto.
        (JSC::StrictEqualNode::emitBytecode): Ditto.
        (JSC::ReverseBinaryOpNode::emitBytecode): Ditto.
        (JSC::ThrowableBinaryOpNode::emitBytecode): Ditto.
        (JSC::InstanceOfNode::emitBytecode): Ditto.
        (JSC::LogicalOpNode::emitBytecode): Ditto.
        (JSC::ConditionalNode::emitBytecode): Ditto.
        (JSC::ReadModifyResolveNode::emitBytecode): Ditto.
        (JSC::AssignResolveNode::emitBytecode): Ditto.
        (JSC::AssignDotNode::emitBytecode): Ditto.
        (JSC::ReadModifyDotNode::emitBytecode): Ditto.
        (JSC::AssignBracketNode::emitBytecode): Ditto.
        (JSC::ReadModifyBracketNode::emitBytecode): Ditto.
        (JSC::CommaNode::emitBytecode): Ditto.
        (JSC::ConstDeclNode::emitCodeSingle): Ditto.
        (JSC::ConstDeclNode::emitBytecode): Ditto.
        (JSC::ConstStatementNode::emitBytecode): Ditto.
        (JSC::statementListEmitCode): Ditto.
        (JSC::BlockNode::emitBytecode): Ditto.
        (JSC::ExprStatementNode::emitBytecode): Ditto.
        (JSC::VarStatementNode::emitBytecode): Ditto.
        (JSC::IfNode::emitBytecode): Ditto.
        (JSC::IfElseNode::emitBytecode): Ditto.
        (JSC::DoWhileNode::emitBytecode): Ditto.
        (JSC::WhileNode::emitBytecode): Ditto.
        (JSC::ForNode::emitBytecode): Ditto.
        (JSC::ForInNode::emitBytecode): Ditto.
        (JSC::ReturnNode::emitBytecode): Ditto.
        (JSC::WithNode::emitBytecode): Ditto.
        (JSC::CaseBlockNode::tryOptimizedSwitch): Ditto.
        (JSC::CaseBlockNode::emitBytecodeForBlock): Ditto.
        (JSC::SwitchNode::emitBytecode): Ditto.
        (JSC::LabelNode::emitBytecode): Ditto.
        (JSC::ThrowNode::emitBytecode): Ditto.
        (JSC::TryNode::emitBytecode): Ditto.
        (JSC::ScopeNodeData::ScopeNodeData): Use swap to transfer ownership
        of the arena, varStack and functionStack.
        (JSC::ScopeNode::ScopeNode): Pass in the arena when creating the
        (JSC::ProgramNode::ProgramNode): Made this inline since it's used
        in only one place.
        (JSC::ProgramNode::create): Changed this to return a PassRefPtr since
        we plan to have the scope nodes be outside the arena, so they will need
        some kind of ownership transfer (maybe auto_ptr instead of PassRefPtr
        in the future, though). Remove the node from the newly-created arena to
        avoid a circular reference. Later we'll keep the node out of the arena
        by using a different operator new, but for now it's the ParserRefCounted
        constructor that puts the node into the arena, and there's no way to
        bypass that.
        (JSC::EvalNode::EvalNode): Ditto.
        (JSC::EvalNode::create): Ditto.
        (JSC::FunctionBodyNode::FunctionBodyNode): Ditto.
        (JSC::FunctionBodyNode::createNativeThunk): Moved the code that
        reseets the arena here instead of the caller.
        (JSC::FunctionBodyNode::create): Same change as the other create
        functions above.
        (JSC::FunctionBodyNode::emitBytecode): Use raw pointers.

        * parser/Nodes.h: Removed NodeReleaser. Changed FunctionStack to
        use raw pointers. Removed the releaseNodes function. Added an override
        of operator new that takes a JSGlobalData* to prepare for future arena use.
        Use raw pointers instead of RefPtr everywhere possible.

        * parser/Parser.cpp:
        (JSC::Parser::reparseInPlace): Pass the arena in.

        * parser/Parser.h:
        (JSC::Parser::parse): Updated for name change of parserObjects to parserArena.
        (JSC::Parser::reparse): Ditto.
        * runtime/FunctionConstructor.cpp:
        (JSC::extractFunctionBody): Ditto.
        * runtime/JSGlobalData.cpp:
        (JSC::JSGlobalData::~JSGlobalData): Ditto.
        (JSC::JSGlobalData::createNativeThunk): Moved arena manipulation into the
        FunctionBodyNode::createNativeThunk function.

        * runtime/JSGlobalData.h: Tweaked formatting and renamed parserObjects to

        * wtf/NotFound.h: Added the usual "using WTF" to this header to match the
        rest of WTF.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-10 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Sun, 10 May 2009 18:49:10 +0000 (18:49 +0000)]
2009-05-10  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Geoffrey Garen.

        Remove no longer valid chunk of code from dtoa.

        * wtf/dtoa.cpp:
        (WTF::dtoa): Removed invalid code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Dan Bernstein.
ap@webkit.org [Sun, 10 May 2009 17:53:22 +0000 (17:53 +0000)]
    Reviewed by Dan Bernstein.

        <rdar://problem/6867598> REGRESSION (r42483): Have to enter credentials twice when trying
        to view protected MobileMe video

        Add a temporary workaround.

        * platform/network/ResourceHandleInternal.h:
        Added an m_useSiteSpecificQuirks boolean (Mac-only). A Frame pointer is only available when
        starting a request, so we need to store this data for later use.

        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::start): Initialize m_useSiteSpecificQuirks.
        (WebCore::ResourceHandle::receivedCredential): Use per-session credentials with gallery.me.com.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Geoff Garen.
ap@webkit.org [Sun, 10 May 2009 17:32:44 +0000 (17:32 +0000)]
    Reviewed by Geoff Garen.

        "Class const *" is the same as "const Class*", use the latter syntax consistently.

        See <http://www.parashift.com/c++-faq-lite/const-correctness.html#faq-18.9>.

        * pcre/pcre_compile.cpp:
        * runtime/JSObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Dan Bernstein.
ap@webkit.org [Sun, 10 May 2009 17:01:40 +0000 (17:01 +0000)]
    Reviewed by Dan Bernstein.

        <rdar://problem/6870383> Have to enter credentials twice when downloading from a protected page

        Use credentials from WebCore storage when downloading.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Dan Bernstein.
ap@webkit.org [Sun, 10 May 2009 16:57:06 +0000 (16:57 +0000)]
    Reviewed by Dan Bernstein.

        Match newer XMLHttpRequest draft and make withCredential setter raise an exception when
        called at a wrong time.

        No test, because we are waiting for a newer version of system frameworks to test the attribute.

        * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::setWithCredentials):
        * xml/XMLHttpRequest.h:
        * xml/XMLHttpRequest.idl:
        Raise INVALID_STATE_ERR if the state is not OPENED, or if the send() flag is true.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mitz@apple.com [Sun, 10 May 2009 16:26:10 +0000 (16:26 +0000)]

        Reviewed by Dave Kilzer.

        - fix https://bugs.webkit.org/show_bug.cgi?id=25602
          REGRESSION: fast/overflow/overflow-focus-ring.html seems double-drawn
          on ToT

        Test: fast/layers/self-painting-outline.html

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::paintLayer): Paint the layer's own outline only
        if it is a self-painting layer.


        Reviewed by Dave Kilzer.

        - new test and correct results for https://bugs.webkit.org/show_bug.cgi?id=25602
          REGRESSION: fast/overflow/overflow-focus-ring.html seems double-drawn
          on ToT

        * fast/layers/self-painting-outline.html: Added.
        * platform/mac/fast/overflow/overflow-focus-ring-expected.checksum: Updated.
        * platform/mac/fast/overflow/overflow-focus-ring-expected.png: Updated.
        * platform/mac/fast/layers/self-painting-outline-expected.checksum: Added.
        * platform/mac/fast/layers/self-painting-outline-expected.png: Added.
        * platform/mac/fast/layers/self-painting-outline-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-10 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Sun, 10 May 2009 11:32:31 +0000 (11:32 +0000)]
2009-05-10  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Alexey Proskuryakov.

        - speedup dtoa/strtod

        Added a bunch of inlining, and replaced malloc with stack allocation.

        0.5% SunSpider speedup (7% on string-tagcloud).

        * runtime/NumberPrototype.cpp:
        * runtime/UString.cpp:
        * wtf/dtoa.cpp:
        * wtf/dtoa.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mitz@apple.com [Sun, 10 May 2009 05:04:30 +0000 (05:04 +0000)]

        Reviewed by Geoffrey Garen and Mark Rowe.

        - fix https://bugs.webkit.org/show_bug.cgi?id=25666
          Assertion failure in Node::setDocument()
          (willMoveToNewOwnerDocumentWasCalled) when adopting a <form> element

        Test: fast/dom/HTMLFormElement/adopt-assertion.html

        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::willMoveToNewOwnerDocument): Overrides of
        this method are required to call the base class implementation. Do it.
        (WebCore::HTMLFormElement::didMoveToNewOwnerDocument): Ditto.


        Reviewed by Geoffrey Garen and Mark Rowe.

        - test for https://bugs.webkit.org/show_bug.cgi?id=25666
          Assertion failure in Node::setDocument()
          (willMoveToNewOwnerDocumentWasCalled) when adopting a <form> element

        * fast/dom/HTMLFormElement/adopt-assertion-expected.txt: Added.
        * fast/dom/HTMLFormElement/adopt-assertion.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-09 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Sun, 10 May 2009 02:44:51 +0000 (02:44 +0000)]
2009-05-09  Geoffrey Garen  <ggaren@apple.com>

        Rubber stamped by Beth Dakin.

        Added a test for a math edge case I just came across.

        * fast/js/postfix-syntax-expected.txt:
        * fast/js/resources/postfix-syntax.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-09 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sun, 10 May 2009 02:28:15 +0000 (02:28 +0000)]
2009-05-09  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Gustavo Noronha.

        WebKit-r43163 won't build for gtk-directfb

        Move the ENCHANT check out of the with_target conditional since it
        applies to all targets

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-09 Mike Hommey <glandium@debian.org>
jmalonzo@webkit.org [Sun, 10 May 2009 02:10:17 +0000 (02:10 +0000)]
2009-05-09  Mike Hommey  <glandium@debian.org>

        Reviewed by Geoffrey Garen. Landed by Jan Alonzo.

        Enable JIT on x86-64 gtk+

        * configure.ac:

2009-05-09  Mike Hommey  <glandium@debian.org>

        Reviewed by Geoffrey Garen. Landed by Jan Alonzo.

        Enable JIT on x86-64 gtk+

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Maciej Stachowiak.
kevino@webkit.org [Sat, 9 May 2009 22:41:36 +0000 (22:41 +0000)]
Reviewed by Maciej Stachowiak.

WebCore::DocumentLoader::mainReceivedError now asserts if error.isNull(), so
make sure wx does not create empty ResourceError() objects.


git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-09 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Sat, 9 May 2009 22:05:34 +0000 (22:05 +0000)]
2009-05-09  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Cameron Zwarich.

        Removed the last non-call-related manually managed JIT stub call.

        * jit/JITArithmetic.cpp:
        (JSC::JIT::compileFastArithSlow_op_rshift): Fully use the JITStubCall
        abstraction, instead of emitPutJITStubArg.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-09 Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
kov@webkit.org [Sat, 9 May 2009 16:01:17 +0000 (16:01 +0000)]
2009-05-09  Sebastian Andrzej Siewior  <sebastian@breakpoint.cc>

        Reviewed by Gustavo Noronha.

        PLATFORM(X86_64) inherits ia64

        __ia64__ is defined by gcc in an IA64 arch and has completely
        nothing in common with X86-64 exept both are from Intel and have
        an 64bit address space. That's it. Since code seems to expect x86
        here, ia64 has to go.

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-09 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Sat, 9 May 2009 15:44:28 +0000 (15:44 +0000)]
2009-05-09  Gustavo Noronha Silva  <gns@gnome.org>

        Suggested by Geoffrey Garen.

        Assume SSE2 is present on X86-64 and on MAC X86-32. This fixes a
        build breakage on non-Mac X86-64 when JIT is enabled.

        * jit/JITArithmetic.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix, adding missing files to make dist.
kov@webkit.org [Sat, 9 May 2009 14:38:59 +0000 (14:38 +0000)]
Build fix, adding missing files to make dist.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoCorrect the results from the previous patch
mitz@apple.com [Sat, 9 May 2009 09:26:09 +0000 (09:26 +0000)]
Correct the results from the previous patch

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUpdate Windows-specific layout test results for textarea intrinsic
mitz@apple.com [Sat, 9 May 2009 09:19:42 +0000 (09:19 +0000)]
Update Windows-specific layout test results for textarea intrinsic
margins following r43355

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-09 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Sat, 9 May 2009 08:54:50 +0000 (08:54 +0000)]
2009-05-09  Geoffrey Garen  <ggaren@apple.com>

        Windows build fix.

        * assembler/X86Assembler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-09 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Sat, 9 May 2009 08:49:22 +0000 (08:49 +0000)]
2009-05-09  Geoffrey Garen  <ggaren@apple.com>

        Windows build fix.

        * assembler/X86Assembler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-09 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Sat, 9 May 2009 08:35:57 +0000 (08:35 +0000)]
2009-05-09  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Gavin Barraclough.

        Original patch by John McCall. Updated by Cameron Zwarich. Further refined by me.

        - Assorted speedups to property access

        ~.3%-1% speedup on SunSpider

        1) When we know from the structure ID that an object is using inline storage, plant direct
        loads and stores against it; no need to indirect through storage pointer.

        2) Also because of the above, union the property storage pointer with the first inline property
        slot and add an extra inline property slot.

        * assembler/AbstractMacroAssembler.h:
        * assembler/MacroAssembler.h:
        * assembler/MacroAssemblerX86.h:
        * assembler/MacroAssemblerX86_64.h:
        * assembler/X86Assembler.h:
        * jit/JIT.cpp:
        * jit/JIT.h:
        * jit/JITPropertyAccess.cpp:
        * runtime/JSObject.cpp:
        * runtime/JSObject.h:
        * runtime/Structure.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-09 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Sat, 9 May 2009 08:24:49 +0000 (08:24 +0000)]
2009-05-09  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Gavin Barraclough.

        Changed all our JIT stubs so that they return a maximum of 1 JS value or
        two non-JS pointers, and do all other value returning through out
        parameters, in preparation for 64bit JS values on a 32bit system.

        Stubs that used to return two JSValues now return one JSValue and take
        and out parameter specifying where in the register array the second
        value should go.

        SunSpider reports no change.

        * jit/JIT.cpp:
        * jit/JITArithmetic.cpp:
        * jit/JITStubs.cpp:
        * jit/JITStubs.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-08 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sat, 9 May 2009 06:12:36 +0000 (06:12 +0000)]
2009-05-08  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Skip failing render tree test that was added in r43420.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-08 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Sat, 9 May 2009 05:25:53 +0000 (05:25 +0000)]
2009-05-08  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Cameron Zwarich.

        Fixed <rdar://problem/6634956> CrashTracer: [REGRESSION] >400 crashes
        in Safari at com.apple.JavaScriptCore • JSC::BytecodeGenerator::emitComplexJumpScopes + 468

        * bytecompiler/BytecodeGenerator.cpp:
        (JSC::BytecodeGenerator::emitComplexJumpScopes): Guard the whole loop
        with a bounds check. The old loop logic would decrement and read topScope
        without a bounds check, which could cause crashes on page boundaries.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-08 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sat, 9 May 2009 02:17:20 +0000 (02:17 +0000)]
2009-05-08  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by NOBODY (BuildFix).

        Gtk fix: add LiteralParser to the build script per r43424.

        Add LiteralParser to the Qt and Wx build scripts too.

        * GNUmakefile.am:
        * JavaScriptCore.pri:
        * JavaScriptCoreSources.bkl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubber-stamped by George Staikos.
zimmermann@webkit.org [Sat, 9 May 2009 02:05:33 +0000 (02:05 +0000)]
Rubber-stamped by George Staikos.
Update WML <input> layout test result, as input field metrics have changed recently.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNot reviewed. Fix clean builds, forgot to land name() -> formControlName() rename...
zimmermann@webkit.org [Sat, 9 May 2009 01:34:48 +0000 (01:34 +0000)]
Not reviewed. Fix clean builds, forgot to land name() -> formControlName() rename patch in WebKit. Only landed the WebCore side.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd a limited literal parser for eval to handle object and array literals fired at...
oliver@apple.com [Sat, 9 May 2009 01:01:16 +0000 (01:01 +0000)]
Add a limited literal parser for eval to handle object and array literals fired at eval

Reviewed by Gavin Barraclough and Darin Adler.

This is a simplified parser and lexer that we can throw at strings passed to eval
in case a site is using eval to parse JSON (eg. json2.js).  The lexer is intentionally
limited (in effect it's whitelisting a limited "common" subset of the JSON grammar)
as this decreases the likelihood of us wating time attempting to parse any significant
amount of non-JSON content.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-08 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sat, 9 May 2009 00:51:47 +0000 (00:51 +0000)]
2009-05-08  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein


        Reduce the inline capacity of CSSParserValueList's m_values
        vector to reduce the size of CSSParserValueList from 544 to 160 bytes in 64-bit.

        * css/CSSParserValues.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNot reviewed. Used sort-Xcode-project-file to sort the XCode project file - it hasn...
zimmermann@webkit.org [Sat, 9 May 2009 00:29:15 +0000 (00:29 +0000)]
Not reviewed. Used sort-Xcode-project-file to sort the XCode project file - it hasn't been done for a while.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mitz@apple.com [Fri, 8 May 2009 23:49:19 +0000 (23:49 +0000)]

        Reviewed by Darin Adler.

        - fix <rdar://problem/6864786> REGRESSION: Crash below
          ApplyStyleCommand::applyInlineStyleToRange when reviewing a patch in

        Test: editing/style/apply-through-end-of-document.html

        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::applyInlineStyleToRange): Added a null
        check for the case of a range extending through the end of the document,
        in which pastEndNode is 0.


        Reviewed by Darin Adler.

        - test for <rdar://problem/6864786> REGRESSION: Crash below
          ApplyStyleCommand::applyInlineStyleToRange when reviewing a patch in

        * editing/style/apply-through-end-of-document-expected.txt: Added.
        * editing/style/apply-through-end-of-document.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-08 Douglas R. Davidson <ddavidso@apple.com>
bdakin@apple.com [Fri, 8 May 2009 23:40:39 +0000 (23:40 +0000)]
2009-05-08  Douglas R. Davidson  <ddavidso@apple.com>

        Reviewed by Beth Dakin.

        <rdar://problem/6857446> REGRESSION (Safari 3-4): Contraction base
        marked as misspelled even though contraction is a word
        Make sure spelling underline does not persist on words like

        * editing/TypingCommand.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Kevin Ollivier.
kevino@webkit.org [Fri, 8 May 2009 22:53:29 +0000 (22:53 +0000)]
Reviewed by Kevin Ollivier.

Make sure the path's refdata isn't deleted before we're done with the object.


git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix memory leak for wxMac.
kevino@webkit.org [Fri, 8 May 2009 22:49:10 +0000 (22:49 +0000)]
Fix memory leak for wxMac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-08 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 8 May 2009 21:47:23 +0000 (21:47 +0000)]
2009-05-08  Anders Carlsson  <andersca@apple.com>

        Reviewed by Kevin Decker.

        - Fix <rdar://problem/6866712>.

        Instead of just caching whether a plug-in object _has_ a field or method, also add an entry to the cache
        if it _doesn't_ have a certain field or method. This way we have to make fewer calls to the plug-in host.

        * Plugins/Hosted/ProxyInstance.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Fri, 8 May 2009 21:37:43 +0000 (21:37 +0000)]
2009-05-08  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        Make the scan program call g_thread_init(NULL) in addition to
        g_type_init(), so that it actually works.

        * docs/GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Fri, 8 May 2009 21:37:09 +0000 (21:37 +0000)]
2009-05-08  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        Ship the gtk-doc.make file, so as to not depend on gtkdoc-tools.

        * GNUmakefile.am:
        * autogen.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-08 Beth Dakin <bdakin@apple.com>
bdakin@apple.com [Fri, 8 May 2009 21:35:48 +0000 (21:35 +0000)]
2009-05-08  Beth Dakin  <bdakin@apple.com>

        Reviewed by Dan Bernstein.

        <rdar://problem/6857446> REGRESSION (r37591): Cannot print or
        preview from maps.yandex.ru

        We need to fall into the stretchesToViewHeight() quirk when we are
        printing and we are the root and the root has percentage height OR
        when we are the body and the root has percentage height. Otherwise
        we have a height of 0 and can run into painting troubles.

        * rendering/RenderBox.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
harrison@apple.com [Fri, 8 May 2009 21:12:43 +0000 (21:12 +0000)]

2009-05-08  Douglas Davidson  <ddavidso@apple.com>

        Reviewed by Darin Adler.

        Fixes for <rdar://problem/6852771>.
        Prevent text checking replacement immediately after an apostrophe
        and automatic link addition except immediately after typing.

        * editing/Editor.cpp:


2009-05-08  Douglas R. Davidson  <ddavidso@apple.com>

        Reviewed by Darin Adler.

        Fixes for <rdar://problem/6852771>.
        Disable text checking menu items if view is not editable.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
        (-[WebHTMLView smartInsertDeleteEnabled]):
        (-[WebHTMLView setSmartInsertDeleteEnabled:]):
        (-[WebHTMLView toggleSmartInsertDelete:]):
        * WebView/WebHTMLViewInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoVersioning.
timothy@apple.com [Fri, 8 May 2009 21:12:27 +0000 (21:12 +0000)]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-08 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 8 May 2009 20:53:15 +0000 (20:53 +0000)]
2009-05-08  Geoffrey Garen  <ggaren@apple.com>

        Not reviewed.

        Restored a Mozilla JS test I accidentally gutted.

        * tests/mozilla/ecma/Array/

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-08 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 8 May 2009 20:51:53 +0000 (20:51 +0000)]
2009-05-08  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Gavin Barraclough.

        More abstraction for JITStub calls from JITed code.

        Added a JITStubCall class that automatically handles things like assigning
        arguments to different stack slots and storing return values. Deployed
        the class in about a billion places. A bunch more places remain to be
        fixed up, but this is a good stopping point for now.

        * jit/JIT.cpp:
        * jit/JIT.h:
        * jit/JITArithmetic.cpp:
        * jit/JITCall.cpp:
        * jit/JITPropertyAccess.cpp:
        * jit/JITStubs.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Fri, 8 May 2009 20:44:50 +0000 (20:44 +0000)]
2009-05-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Disable more new tests that are failing.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-08 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Fri, 8 May 2009 19:13:42 +0000 (19:13 +0000)]
2009-05-08  Eric Carlson  <eric.carlson@apple.com>

        No review, update tests results missed in r43403.

        * fast/dom/Window/window-properties-expected.txt:
        * platform/mac-leopard/fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Fri, 8 May 2009 19:08:26 +0000 (19:08 +0000)]
2009-05-08  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        GTK+ test results for two new tests.

        * platform/gtk/fast/layers/remove-only-this-layer-update-expected.txt: Added.
        * platform/gtk/fast/repaint/selection-clear-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-08 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Fri, 8 May 2009 18:37:59 +0000 (18:37 +0000)]
2009-05-08  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Darin Adler.

        Bug 25627: HTMLMediaElement: some errors should fire on <source> elements

        Update for HTML5 spec change to fire 'error' events on <source> element
        when there is a failure while processing/loading a <source>.

        Test: media/video-source-error.html

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::enqueueEvent): Remove white-space.
        (WebCore::HTMLMediaElement::loadInternal): Call cancelPendingEventsAndCallbacks instead
        of just calling m_pendingEvents.clear() as we now also need to cancel pending errors on
        all <source> element.
        (WebCore::HTMLMediaElement::selectMediaResource): Call isSafeToLoadURL() here instead of in
        loadResource() as we need to report errors differently depending on the type of failure. Use
        KURL instead of String.
        (WebCore::HTMLMediaElement::loadNextSourceChild): nextSourceChild -> selectNextSourceChild.
        Fail silently when there are no more <source> canditates because that is what spec mandates.
        Keep url as KURL instead of converting to String.
        (WebCore::HTMLMediaElement::loadResource): ASSERT that the URL is safe to load as we now
        assume the safety check now done before this function. Takes KURL instead of String.
        (WebCore::HTMLMediaElement::isSafeToLoadURL): New, checks to see if a url is safe to load, logs
        failure if not.
        (WebCore::HTMLMediaElement::noneSupported): MEDIA_ERR_NONE_SUPPORTED -> MEDIA_ERR_SRC_NOT_SUPPORTED
        (WebCore::HTMLMediaElement::cancelPendingEventsAndCallbacks): New, clear all events pending on
        the media and all source elements.
        (WebCore::HTMLMediaElement::setNetworkState): Fire an error on the source element when the
        the failure happened while processing one. Only call nonSupported() when the failure happened
        while processing media element 'src' attribute.
        (WebCore::HTMLMediaElement::havePotentialSourceChild): nextSourceChild -> selectNextSourceChild.
        Deal with selectNextSourceChild returning a KURL instead of a String.
        (WebCore::HTMLMediaElement::selectNextSourceChild): Renamed from nextSourceChild, add optional
        param to control whether or not errors are fired on a source element when it will not be used.
        Check safety of url here instead of waiting until loadResource(). Return a KURL instead of a
        (WebCore::HTMLMediaElement::initialURL): nextSourceChild -> selectNextSourceChild. Keep url as
        a KURL instead of a String.
        * html/HTMLMediaElement.h:

        * html/HTMLSourceElement.cpp:
        (WebCore::HTMLSourceElement::HTMLSourceElement): Initialize timer related variables.
        (WebCore::HTMLSourceElement::scheduleErrorEvent): New, start one-shot timer to fire an error
        event ASAP.
        (WebCore::HTMLSourceElement::cancelPendingErrorEvent): New, cancel pending error event.
        (WebCore::HTMLSourceElement::errorEventTimerFired): New, fire error event if it has not been
        * html/HTMLSourceElement.h:

        * html/MediaError.h:
        * html/MediaError.idl: Ditto

2009-05-08  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Darin Adler.

        Bug 25627: HTMLMediaElement: some errors should fire on <source> elements

        Add video-source-error.html to test errors fired on <source> elements .

        * media/media-constants-expected.txt:
        * media/media-constants.html:
        * media/unsupported-rtsp.html:
        * media/video-error-does-not-exist.html:
        * media/video-source-error.html: Added.
        * media/video-src-change.html:
        * media/video-src-invalid-remove.html:
        * media/video-src-plus-source.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Fri, 8 May 2009 15:56:43 +0000 (15:56 +0000)]
2009-05-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Disable new test that is failing.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43402 268f45cc-cd09-0410-ab3c-d52691b4dbfc