WebKit-https.git
7 years agoAX: file upload input text value is not exposed through accessibility
cfleizach@apple.com [Tue, 13 Nov 2012 20:30:10 +0000 (20:30 +0000)]
AX: file upload input text value is not exposed through accessibility
https://bugs.webkit.org/show_bug.cgi?id=100583

Reviewed by Beth Dakin.

Source/WebCore:

This is a hard problem to solve on the Mac because there are three pieces of information
     1) The type of button 2) The text on the button 3) The text for the value.
I think the best compromise is to label this as a file upload button type in the role description,
and then expose the file path text as the AXTitle.
This will give the more relevant information and should be clear what is happening.

Test: platform/mac/accessibility/file-upload-button-subrole.html

* English.lproj/Localizable.strings:
* accessibility/mac/WebAccessibilityObjectWrapper.mm:
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper roleDescription]):
(-[WebAccessibilityObjectWrapper accessibilityTitle]):
* platform/LocalizedStrings.cpp:
(WebCore::AXFileUploadButtonText):
* platform/LocalizedStrings.h:

LayoutTests:

* platform/mac/accessibility/file-upload-button-subrole-expected.txt: Added.
* platform/mac/accessibility/file-upload-button-subrole.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r133944.
commit-queue@webkit.org [Tue, 13 Nov 2012 20:17:55 +0000 (20:17 +0000)]
Unreviewed, rolling out r133944.
http://trac.webkit.org/changeset/133944
https://bugs.webkit.org/show_bug.cgi?id=102118

Only JS bindings support NATIVE_TYPE_ERR (Requested by arv on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-13

Source/WebCore:

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateFunctionCallback):
(GenerateParametersCheck):
(GenerateSingleConstructorCallback):
(GenerateNamedConstructorCallback):
(TypeCanFailConversion):
* dom/Element.cpp:
(WebCore::Element::setAttributeNode):
(WebCore::Element::removeAttributeNode):
* dom/Element.idl:

LayoutTests:

* fast/dom/Element/attr-param-typechecking-expected.txt:
* fast/dom/Element/script-tests/attr-param-typechecking.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed.
abarth@webkit.org [Tue, 13 Nov 2012 20:11:53 +0000 (20:11 +0000)]
Unreviewed.

Update run-bindings-tests results.

* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::V8Float64Array::dispatchWrapCustom):
(WebCore::V8Float64Array::wrapSlow):
* bindings/scripts/test/V8/V8Float64Array.h:
(WebCore::V8Float64Array::toNative):
(V8Float64Array):
(WebCore):
(WebCore::dispatchWrap):
(WebCore::toV8Object):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::V8TestActiveDOMObject::wrapSlow):
* bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(WebCore::V8TestActiveDOMObject::toNative):
(V8TestActiveDOMObject):
(WebCore):
(WebCore::dispatchWrap):
(WebCore::toV8Object):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::wrapSlow):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(WebCore::V8TestCustomNamedGetter::toNative):
(V8TestCustomNamedGetter):
(WebCore):
(WebCore::dispatchWrap):
(WebCore::toV8Object):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::wrapSlow):
* bindings/scripts/test/V8/V8TestEventConstructor.h:
(WebCore::V8TestEventConstructor::toNative):
(V8TestEventConstructor):
(WebCore):
(WebCore::dispatchWrap):
(WebCore::toV8Object):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::V8TestEventTarget::wrapSlow):
* bindings/scripts/test/V8/V8TestEventTarget.h:
(WebCore::V8TestEventTarget::toNative):
(V8TestEventTarget):
(WebCore):
(WebCore::dispatchWrap):
(WebCore::toV8Object):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::V8TestException::wrapSlow):
* bindings/scripts/test/V8/V8TestException.h:
(WebCore::V8TestException::toNative):
(V8TestException):
(WebCore):
(WebCore::dispatchWrap):
(WebCore::toV8Object):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::wrapSlow):
* bindings/scripts/test/V8/V8TestInterface.h:
(WebCore::V8TestInterface::toNative):
(V8TestInterface):
(WebCore):
(WebCore::dispatchWrap):
(WebCore::toV8Object):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::wrapSlow):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(WebCore::V8TestMediaQueryListListener::toNative):
(V8TestMediaQueryListListener):
(WebCore):
(WebCore::dispatchWrap):
(WebCore::toV8Object):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructor::wrapSlow):
* bindings/scripts/test/V8/V8TestNamedConstructor.h:
(WebCore::V8TestNamedConstructor::toNative):
(V8TestNamedConstructor):
(WebCore):
(WebCore::dispatchWrap):
(WebCore::toV8Object):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::wrapSlow):
* bindings/scripts/test/V8/V8TestNode.h:
(WebCore::V8TestNode::toNative):
(V8TestNode):
(WebCore):
(WebCore::dispatchWrap):
(WebCore::toV8Object):
(WebCore::toV8):
(WebCore::toV8Fast):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::wrapSlow):
* bindings/scripts/test/V8/V8TestObj.h:
(WebCore::V8TestObj::toNative):
(V8TestObj):
(WebCore):
(WebCore::dispatchWrap):
(WebCore::toV8Object):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore::V8TestOverloadedConstructors::wrapSlow):
* bindings/scripts/test/V8/V8TestOverloadedConstructors.h:
(WebCore::V8TestOverloadedConstructors::toNative):
(V8TestOverloadedConstructors):
(WebCore):
(WebCore::dispatchWrap):
(WebCore::toV8Object):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(WebCore::V8TestSerializedScriptValueInterface::toNative):
(V8TestSerializedScriptValueInterface):
(WebCore):
(WebCore::dispatchWrap):
(WebCore::toV8Object):
(WebCore::toV8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoStore layer positions and sizes in the transaction
andersca@apple.com [Tue, 13 Nov 2012 20:11:32 +0000 (20:11 +0000)]
Store layer positions and sizes in the transaction
https://bugs.webkit.org/show_bug.cgi?id=102115

Reviewed by Andreas Kling.

* Shared/mac/RemoteLayerTreeTransaction.h:
(LayerProperties):
* Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::LayerProperties::encode):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):
(WebKit::RemoteLayerTreeTransaction::layerPropertiesChanged):
(WebKit::dumpChangedLayers):
* WebProcess/WebPage/mac/RemoteGraphicsLayer.h:
(RemoteGraphicsLayer):
* WebProcess/WebPage/mac/RemoteGraphicsLayer.mm:
(WebKit::RemoteGraphicsLayer::setPosition):
(WebKit::RemoteGraphicsLayer::setSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed test expectations for animation tests.
danakj@chromium.org [Tue, 13 Nov 2012 20:08:04 +0000 (20:08 +0000)]
Unreviewed test expectations for animation tests.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoJSFunction and its descendants should be destructible
fpizlo@apple.com [Tue, 13 Nov 2012 19:58:18 +0000 (19:58 +0000)]
JSFunction and its descendants should be destructible
https://bugs.webkit.org/show_bug.cgi?id=102062

Reviewed by Mark Hahnenberg.

This will make it easy to place an InlineWatchpointSet inside JSFunction. In the
future, we could make JSFunction non-destructible again by making a version of
WatchpointSet that is entirely GC'd, but this seems like overkill for now.

This is performance-neutral.

* runtime/JSBoundFunction.cpp:
(JSC::JSBoundFunction::destroy):
(JSC):
* runtime/JSBoundFunction.h:
(JSBoundFunction):
* runtime/JSFunction.cpp:
(JSC):
(JSC::JSFunction::destroy):
* runtime/JSFunction.h:
(JSFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Pacify linter and tweak expectations to avoid conflicts.
dglazkov@chromium.org [Tue, 13 Nov 2012 19:53:22 +0000 (19:53 +0000)]
[Chromium] Pacify linter and tweak expectations to avoid conflicts.

* platform/chromium/TestExpectations: Tweaked.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed.
abarth@webkit.org [Tue, 13 Nov 2012 19:42:22 +0000 (19:42 +0000)]
Unreviewed.

Speculative build fix for Qt.

* dom/make_names.pl:
(printWrapperFactoryCppFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAllow painting outside overflow clip in accelerated scrolling layers
commit-queue@webkit.org [Tue, 13 Nov 2012 19:40:31 +0000 (19:40 +0000)]
Allow painting outside overflow clip in accelerated scrolling layers
https://bugs.webkit.org/show_bug.cgi?id=100524

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-11-13
Reviewed by Simon Fraser.

Source/WebCore:

In preparation for avoiding repaints when scrolling child layers, make it
possible to paint outside the overflow clip.

Test: compositing/overflow/updating-scrolling-content.html

* rendering/LayoutState.h:
(LayoutState):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paint):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::applyCachedClipAndScrollOffsetForRepaint):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::repaintBlockSelectionGaps):

LayoutTests:

Added a test to check painting outside the overflow clip. Note that this will
not pass unless ENABLE_ACCELERATED_OVERFLOW_SCROLLING is enabled.

* compositing/overflow/updating-scrolling-content-expected.txt: Added.
* compositing/overflow/updating-scrolling-content.html: Added.
* platform/chromium/TestExpectations: Mark test as expected to fail
  by default.
* platform/mac/TestExpectations: Skip the test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoThe layer tree transaction should include the root layer
andersca@apple.com [Tue, 13 Nov 2012 19:33:01 +0000 (19:33 +0000)]
The layer tree transaction should include the root layer
https://bugs.webkit.org/show_bug.cgi?id=102109

Reviewed by Andreas Kling.

Keep the root layer ID in the layer tree transaction and encode/decode and dump it.

* Shared/mac/RemoteLayerTreeTransaction.h:
(RemoteLayerTreeTransaction):
* Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::encode):
(WebKit::RemoteLayerTreeTransaction::decode):
(WebKit::RemoteLayerTreeTransaction::setRootLayerID):
(WebKit):
(WebKit::RemoteLayerTreeTransaction::dump):
* WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
(RemoteLayerTreeContext):
* WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
(WebKit::RemoteLayerTreeContext::RemoteLayerTreeContext):
(WebKit::RemoteLayerTreeContext::setRootLayer):
(WebKit::RemoteLayerTreeContext::flushLayers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Remove the test that is now passing.
dglazkov@chromium.org [Tue, 13 Nov 2012 19:31:19 +0000 (19:31 +0000)]
[Chromium] Remove the test that is now passing.

* platform/chromium/TestExpectations: Removed expectation of failure.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPort SimpleFontDataWin.cpp to WinCE
paroga@webkit.org [Tue, 13 Nov 2012 19:31:14 +0000 (19:31 +0000)]
Port SimpleFontDataWin.cpp to WinCE
https://bugs.webkit.org/show_bug.cgi?id=97889

Reviewed by Brent Fulgham.

Add #if !OS(WINCE) around some parts of the code, so it can be used by the WinCE port too in a next step.
Also cleaned up the include headers.

* platform/graphics/win/SimpleFontDataWin.cpp:
(WebCore::SimpleFontData::initGDIFont):
(WebCore::SimpleFontData::platformDestroy):
(WebCore::SimpleFontData::boundsForGDIGlyph):
(WebCore):
(WebCore::SimpleFontData::widthForGDIGlyph):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Chromium] move spectrum.css into the standalone css files group.
pfeldman@chromium.org [Tue, 13 Nov 2012 19:29:40 +0000 (19:29 +0000)]
Web Inspector: [Chromium] move spectrum.css into the standalone css files group.

Not reviewed: moved css file in gypi.

* WebCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r134434.
dglazkov@chromium.org [Tue, 13 Nov 2012 19:24:35 +0000 (19:24 +0000)]
Unreviewed, rolling out r134434.
http://trac.webkit.org/changeset/134434
https://bugs.webkit.org/show_bug.cgi?id=102072

The test that was added asserts in loader.

Source/WebCore:

* loader/FrameLoader.cpp:
(WebCore::createWindow):
* page/DOMWindow.cpp:
(WebCore):
(WebCore::DOMWindow::adjustWindowRect):
(WebCore::DOMWindow::moveBy):
(WebCore::DOMWindow::moveTo):
(WebCore::DOMWindow::resizeBy):
(WebCore::DOMWindow::resizeTo):
(WebCore::DOMWindow::open):
(WebCore::DOMWindow::showModalDialog):
* page/DOMWindow.h:
(DOMWindow):

LayoutTests:

* fast/dom/Window/open-window-min-size-expected.txt: Removed.
* fast/dom/Window/open-window-min-size.html: Removed.
* fast/dom/Window/resources/print-close.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r134449.
dglazkov@chromium.org [Tue, 13 Nov 2012 19:21:03 +0000 (19:21 +0000)]
Unreviewed, rolling out r134449.
http://trac.webkit.org/changeset/134449
https://bugs.webkit.org/show_bug.cgi?id=102076

Re-rolling in the patch, it was innocent.

* TestWebKitAPI/PlatformEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r134424.
dglazkov@chromium.org [Tue, 13 Nov 2012 19:10:46 +0000 (19:10 +0000)]
Unreviewed, rolling out r134424.
http://trac.webkit.org/changeset/134424
https://bugs.webkit.org/show_bug.cgi?id=102076

Made fast/dom/Window/open-window-min-size.html crash.

* TestWebKitAPI/PlatformEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Rebaselined platform/chromium/virtual/softwarecompositing/layer-creation...
commit-queue@webkit.org [Tue, 13 Nov 2012 19:10:44 +0000 (19:10 +0000)]
[Chromium] Rebaselined platform/chromium/virtual/softwarecompositing/layer-creation/spanOverlapsCanvas.html
https://bugs.webkit.org/show_bug.cgi?id=101997

Patch by Slavomir Kaslev <skaslev@google.com> on 2012-11-13
Reviewed by James Robinson.

Since we disabled hardware accelerated canvas when in software compositing mode,
this layout test doesn't create any layers which is the correct behaviour.

* platform/chromium/TestExpectations:
* platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/spanOverlapsCanvas-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] More efficient wrapper dispatch
abarth@webkit.org [Tue, 13 Nov 2012 19:06:30 +0000 (19:06 +0000)]
[V8] More efficient wrapper dispatch
https://bugs.webkit.org/show_bug.cgi?id=102082

Patch by Dan Carney <dcarney@google.com> on 2012-11-13
Reviewed by Adam Barth.

Source/WebCore:

Dispatching a call to V8Whatever::wrap involved a chain
of calls, each of which checked its wrapper cache.
This refactor gives calls only 2 choices of functions to call:
toV8 and toV8Object instead of wrap. wrap has been renamed to
dispatchWrap and no longer contains cache checks.
Additionally, classes which require a custom toV8 function
have had all wrapping and caching calls removed, as they could
not have been accessed.

No new tests. Sufficiently covered.

* Modules/indexeddb/IDBAny.idl:
* Modules/indexeddb/IDBKey.idl:
* WebCore.gypi:
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateNormalAttrGetter):
(GenerateImplementation):
(GenerateToV8Converters):
* bindings/scripts/IDLAttributes.txt:
* bindings/v8/SerializedScriptValue.cpp:
* bindings/v8/custom/V8BlobCustom.cpp:
(WebCore::V8Blob::dispatchWrapCustom):
* bindings/v8/custom/V8CSSRuleCustom.cpp:
(WebCore::V8CSSRule::dispatchWrapCustom):
* bindings/v8/custom/V8CSSValueCustom.cpp:
(WebCore::V8CSSValue::dispatchWrapCustom):
* bindings/v8/custom/V8CanvasRenderingContextCustom.cpp:
(WebCore::V8CanvasRenderingContext::dispatchWrapCustom):
* bindings/v8/custom/V8DataViewCustom.cpp:
(WebCore):
(WebCore::V8DataView::dispatchWrapCustom):
* bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::V8Document::dispatchWrapCustom):
* bindings/v8/custom/V8ElementCustom.cpp: Copied from Source/WebCore/bindings/v8/custom/V8PerformanceEntryCustom.cpp.
(WebCore):
(WebCore::V8Element::dispatchWrapCustom):
* bindings/v8/custom/V8EntryCustom.cpp:
(WebCore::V8Entry::dispatchWrapCustom):
* bindings/v8/custom/V8EntrySyncCustom.cpp:
(WebCore::V8EntrySync::dispatchWrapCustom):
* bindings/v8/custom/V8EventCustom.cpp:
(WebCore):
(WebCore::V8Event::dispatchWrapCustom):
* bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::V8HTMLCollection::dispatchWrapCustom):
* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::V8HTMLDocument::dispatchWrapCustom):
* bindings/v8/custom/V8HTMLElementCustom.cpp:
(WebCore::V8HTMLElement::dispatchWrapCustom):
* bindings/v8/custom/V8ImageDataCustom.cpp:
(WebCore::V8ImageData::dispatchWrapCustom):
* bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::V8Node::dispatchWrapCustom):
* bindings/v8/custom/V8PerformanceEntryCustom.cpp:
(WebCore::V8PerformanceEntry::dispatchWrapCustom):
* bindings/v8/custom/V8SVGDocumentCustom.cpp:
(WebCore::V8SVGDocument::dispatchWrapCustom):
* bindings/v8/custom/V8SVGElementCustom.cpp:
(WebCore::V8SVGElement::dispatchWrapCustom):
* bindings/v8/custom/V8SVGPathSegCustom.cpp:
(WebCore::V8SVGPathSeg::dispatchWrapCustom):
* bindings/v8/custom/V8StyleSheetCustom.cpp:
(WebCore::V8StyleSheet::dispatchWrapCustom):
* dom/Element.idl:
* dom/make_names.pl:
(printWrapperFunctions):
(printWrapperFactoryCppFile):
(printWrapperFactoryHeaderFile):
* html/MicroDataItemValue.idl:
* inspector/ScriptProfile.idl:
* inspector/ScriptProfileNode.idl:
* page/DOMWindow.idl:
* workers/WorkerContext.idl:

Source/WebKit/chromium:

* src/WebArrayBuffer.cpp:
(WebKit::WebArrayBuffer::toV8Value):
* src/WebBlob.cpp:
(WebKit::WebBlob::toV8Value):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Remove the WebCompositorSupport methods for changing settings, plumb every...
danakj@chromium.org [Tue, 13 Nov 2012 19:05:59 +0000 (19:05 +0000)]
[chromium] Remove the WebCompositorSupport methods for changing settings, plumb everything through WebLayerTreeSettings
https://bugs.webkit.org/show_bug.cgi?id=101968

Reviewed by James Robinson.

Source/Platform:

Move the outlier settings from WebCompositorSupport to WebLayerTreeView.

PerTilePainting and AcceleratedAnimations are simply moved over. The
PartialSwap and PageScalePinchZoomInCompositor settings, however, are
not used by DRT, so we remove them.

This change will temporarily break the --per-tile-painting and
--accelerated-animations command line flags for chromium DRT until
a chromium side patch hooks up the WebLayerTreeSettings again, but
we have no bots running with these flags.

PinchZoom will be unaffected by this, as DRT never turned it on, and by
passing the WebLayerTreeSetting, chromium will not use it from here yet,
either.

PartialSwap will be also unaffected, as there was no place in WebKit
that would enable it currently.

* chromium/public/WebCompositorSupport.h:
(WebCompositorSupport):
* chromium/public/WebLayerTreeView.h:
(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):

Source/WebKit/chromium:

This adds perTilePainting and acceleratedAniamtions to the WebSettings
classes, so that DRT can turn these on via WebLayerTreeSettings.

* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setAcceleratedAnimationEnabled):
(WebKit):
(WebKit::WebSettingsImpl::setPerTilePaintingEnabled):
* src/WebSettingsImpl.h:
(WebSettingsImpl):
(WebKit::WebSettingsImpl::gestureTapHighlightEnabled):
(WebKit::WebSettingsImpl::doubleTapToZoomEnabled):
(WebKit::WebSettingsImpl::perTilePaintingEnabled):
(WebKit::WebSettingsImpl::acceleratedAnimationEnabled):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):

Tools:

* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::resetWebSettings):
* DumpRenderTree/chromium/TestShell.h:
(TestShell::setPerTilePaintingEnabled):
(TestShell::setAcceleratedAnimationEnabled):
(TestShell):
* DumpRenderTree/chromium/WebPreferences.cpp:
(WebPreferences::applyTo):
* DumpRenderTree/chromium/WebPreferences.h:
(WebPreferences):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix webkitpy issues arising from a partially-installed pylint.
dpranke@chromium.org [Tue, 13 Nov 2012 18:59:54 +0000 (18:59 +0000)]
Fix webkitpy issues arising from a partially-installed pylint.
Unreviewed, build fix.

This patch ensures that we will re-install the pylint and logilab
packages if any of them are missing, not just the pylint package.

* Scripts/webkitpy/thirdparty/__init__.py:
(AutoinstallImportHook._install_pylint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRevert the changes from r134388 and r134426 as r134345 was rolled out.
rakuco@webkit.org [Tue, 13 Nov 2012 18:58:29 +0000 (18:58 +0000)]
Revert the changes from r134388 and r134426 as r134345 was rolled out.

* platform/efl/fast/dynamic/insertAdjacentElement-expected.txt:
* platform/gtk/fast/dynamic/insertAdjacentElement-expected.txt:
* platform/mac/fast/dynamic/insertAdjacentElement-expected.txt:
* platform/qt/fast/dynamic/insertAdjacentElement-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r134367.
dglazkov@chromium.org [Tue, 13 Nov 2012 18:53:36 +0000 (18:53 +0000)]
Unreviewed, rolling out r134367.
http://trac.webkit.org/changeset/134367
https://bugs.webkit.org/show_bug.cgi?id=100738

Speculative rollout, could have cause Dromaeo setAttribute
perf regression.

PerformanceTests:

* DOM/ModifyAttribute.html: Removed.
* DOM/resources/dom-perf/modify-attribute.js: Removed.

Source/WebCore:

* dom/Element.cpp:
(WebCore::Element::attributeChanged):
(WebCore::checkNeedsStyleInvalidationForClassChange):
(WebCore::Element::classAttributeChanged):

LayoutTests:

* fast/dom/shadow/distribution-attribute-modified-expected.html: Removed.
* fast/dom/shadow/distribution-attribute-modified.html: Removed.
* fast/dom/shadow/distribution-className-modified-expected.html: Removed.
* fast/dom/shadow/distribution-className-modified.html: Removed.
* fast/dom/shadow/distribution-id-modified-expected.html: Removed.
* fast/dom/shadow/distribution-id-modified.html: Removed.
* fast/dom/shadow/reprojection-attribute-modified-expected.html: Removed.
* fast/dom/shadow/reprojection-attribute-modified.html: Removed.
* fast/dom/shadow/reprojection-className-modified-expected.html: Removed.
* fast/dom/shadow/reprojection-className-modified.html: Removed.
* fast/dom/shadow/reprojection-id-modified-expected.html: Removed.
* fast/dom/shadow/reprojection-id-modified.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd initiator to CachedResourceRequest.
commit-queue@webkit.org [Tue, 13 Nov 2012 18:52:28 +0000 (18:52 +0000)]
Add initiator to CachedResourceRequest.
https://bugs.webkit.org/show_bug.cgi?id=101935

Patch by Marja Hölttä <marja@chromium.org> on 2012-11-13
Reviewed by Adam Barth.

Motivation: Chromium needs to know which elements request a
resource (such as an image or a script) (bug 92761). In addition,
for exposing resource timing information (bug 84883) we need to
store the initiator, and this is the first step towards it.

No new tests: No visible change in behavior.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSCrossfadeValue.cpp:
(WebCore::cachedImageForCSSValue):
* css/CSSCursorImageValue.cpp:
(WebCore::CSSCursorImageValue::cachedImage):
* css/CSSFontFaceSrcValue.cpp:
(WebCore::CSSFontFaceSrcValue::cachedFont):
* css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::cachedImageSet):
* css/CSSImageValue.cpp:
(WebCore::CSSImageValue::cachedImage):
* css/CSSImageValue.h:
(WebCore):
(CSSImageValue):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::loadPendingImage):
* css/StyleRuleImport.cpp:
(WebCore::StyleRuleImport::requestStyleSheet):
* css/WebKitCSSSVGDocumentValue.cpp:
(WebCore::WebKitCSSSVGDocumentValue::load):
* css/WebKitCSSShaderValue.cpp:
(WebCore::WebKitCSSShaderValue::cachedShader):
* dom/ScriptElement.cpp:
(WebCore::ScriptElement::requestScript):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::process):
* html/parser/CSSPreloadScanner.cpp:
(WebCore::CSSPreloadScanner::emitRule):
* html/parser/CSSPreloadScanner.h:
(CSSPreloadScanner):
* html/parser/HTMLPreloadScanner.cpp:
(WebCore::PreloadTask::preload):
* loader/ImageLoader.cpp:
(WebCore::ImageLoader::updateFromElement):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::determineRevalidationPolicy):
(WebCore):
(WebCore::CachedResourceLoader::preload):
* loader/cache/CachedResourceLoader.h:
(WebCore):
(CachedResourceLoader):
* loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::CachedResourceRequest):
(WebCore):
(WebCore::CachedResourceRequest::~CachedResourceRequest):
(WebCore::CachedResourceRequest::setInitiator):
(WebCore::CachedResourceRequest::initiatorName):
(WebCore::CachedResourceRequest::initiatorDocument):
(WebCore::CachedResourceRequest::initiatorElement):
* loader/cache/CachedResourceRequest.h:
(WebCore):
(WebCore::CachedResourceRequest::setOptions):
(WebCore::CachedResourceRequest::defer):
(WebCore::CachedResourceRequest::setDefer):
(CachedResourceRequest):
* loader/cache/CachedResourceRequestInitiators.cpp: Copied from Source/WebCore/loader/cache/CachedResourceRequest.cpp.
(WebCore):
(WebCore::CachedResourceRequestInitiators::CachedResourceRequestInitiators):
* loader/cache/CachedResourceRequestInitiators.h: Copied from Source/WebCore/loader/cache/CachedResourceRequest.cpp.
(WebCore):
(CachedResourceRequestInitiators):
(WebCore::cachedResourceRequestInitiators):
* loader/icon/IconLoader.cpp:
(WebCore::IconLoader::startLoading):
* platform/ThreadGlobalData.cpp:
(WebCore::ThreadGlobalData::ThreadGlobalData):
* platform/ThreadGlobalData.h:
(WebCore):
(WebCore::ThreadGlobalData::cachedResourceRequestInitiators):
(ThreadGlobalData):
* svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::requestImageResource):
* svg/SVGFontFaceUriElement.cpp:
(WebCore::SVGFontFaceUriElement::loadFont):
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::svgAttributeChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] More unreviewed gardening.
rakuco@webkit.org [Tue, 13 Nov 2012 18:51:36 +0000 (18:51 +0000)]
[EFL] More unreviewed gardening.

Update some pixel expectations and skip one test.

* platform/efl/TestExpectations:
* platform/efl/fast/media/view-mode-media-feature-expected.png: Added property svn:mime-type.
* platform/efl/fast/overflow/overflow_hidden-expected.png: Modified property svn:mime-type.
* platform/efl/svg/text/text-rescale-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r134345.
commit-queue@webkit.org [Tue, 13 Nov 2012 18:47:57 +0000 (18:47 +0000)]
Unreviewed, rolling out r134345.
http://trac.webkit.org/changeset/134345
https://bugs.webkit.org/show_bug.cgi?id=102106

Incomplete support for NATIVE_TYPE_ERR in objc and other
bindings (Requested by jsbell on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-13

Source/WebCore:

* Modules/mediastream/MediaConstraintsImpl.cpp:
(WebCore::MediaConstraintsImpl::create):
* Modules/mediastream/MediaStreamTrackList.cpp:
(WebCore::MediaStreamTrackList::add):
(WebCore::MediaStreamTrackList::remove):
* Modules/mediastream/RTCDataChannel.cpp:
(WebCore::RTCDataChannel::setBinaryType):
* Modules/mediastream/RTCIceCandidate.cpp:
(WebCore::RTCIceCandidate::create):
* Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::parseConfiguration):
(WebCore::RTCPeerConnection::createOffer):
(WebCore::RTCPeerConnection::createAnswer):
(WebCore::RTCPeerConnection::setLocalDescription):
(WebCore::RTCPeerConnection::setRemoteDescription):
(WebCore::RTCPeerConnection::addIceCandidate):
(WebCore::RTCPeerConnection::addStream):
(WebCore::RTCPeerConnection::removeStream):
* Modules/mediastream/RTCSessionDescription.cpp:
(WebCore::RTCSessionDescription::create):
(WebCore::RTCSessionDescription::setType):
* bindings/js/CallbackFunction.cpp:
(WebCore::checkFunctionOnlyCallback):
* bindings/js/JSCustomXPathNSResolver.cpp:
(WebCore::JSCustomXPathNSResolver::create):
* bindings/js/JSHTMLOptionsCollectionCustom.cpp:
(WebCore::JSHTMLOptionsCollection::add):
* bindings/js/JSHTMLSelectElementCustom.cpp:
(WebCore::selectIndexSetter):
* bindings/js/JSMutationObserverCustom.cpp:
(WebCore::JSMutationObserverConstructor::constructJSMutationObserver):
* bindings/js/JSSQLResultSetRowListCustom.cpp:
(WebCore::JSSQLResultSetRowList::item):
* bindings/js/JSSQLTransactionCustom.cpp:
(WebCore::JSSQLTransaction::executeSql):
* bindings/js/JSSQLTransactionSyncCustom.cpp:
(WebCore::JSSQLTransactionSync::executeSql):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheck):
* bindings/scripts/CodeGeneratorObjC.pm:
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateFunctionCallString):
* bindings/v8/V8Callback.h:
(WebCore::createFunctionOnlyCallback):
* bindings/v8/V8Collection.cpp:
(WebCore::toOptionsCollectionSetter):
* bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::V8Document::evaluateCallback):
* bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
(WebCore::V8HTMLOptionsCollection::addCallback):
* bindings/v8/custom/V8MutationObserverCustom.cpp:
(WebCore::V8MutationObserver::constructorCallback):
* bindings/v8/custom/V8SQLTransactionCustom.cpp:
(WebCore::V8SQLTransaction::executeSqlCallback):
* bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:
(WebCore::V8SQLTransactionSync::executeSqlCallback):
* dom/DOMCoreException.idl:
* html/HTMLElement.cpp:
(WebCore::HTMLElement::insertAdjacentElement):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::webkitAddKey):
* html/HTMLOptionsCollection.cpp:
(WebCore::HTMLOptionsCollection::add):
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::createPattern):
(WebCore::CanvasRenderingContext2D::putImageData):
(WebCore::CanvasRenderingContext2D::webkitPutImageDataHD):
* page/Crypto.cpp:
(WebCore::Crypto::getRandomValues):
* page/DOMSelection.cpp:
(WebCore::DOMSelection::extend):
* svg/properties/SVGTransformListPropertyTearOff.h:
(WebCore::SVGTransformListPropertyTearOff::createSVGTransformFromMatrix):

LayoutTests:

* canvas/philip/tests/2d.drawImage.null.html:
* canvas/philip/tests/2d.imageData.put.null.html:
* canvas/philip/tests/2d.pattern.image.null.html:
* editing/selection/extend-expected.txt:
* fast/dom/Geolocation/argument-types-expected.txt:
* fast/dom/Geolocation/not-enough-arguments-expected.txt:
* fast/dom/Geolocation/script-tests/argument-types.js:
(test):
* fast/dom/HTMLSelectElement/select-selectedIndex-expected.txt:
* fast/dom/HTMLSelectElement/select-selectedIndex-multiple-expected.txt:
* fast/js/select-options-add-expected.txt:
* fast/mediastream/RTCIceCandidate-expected.txt:
* fast/mediastream/RTCPeerConnection-expected.txt:
* fast/mediastream/RTCSessionDescription-expected.txt:
* media/encrypted-media/encrypted-media-syntax-expected.txt:
* media/encrypted-media/encrypted-media-syntax.html:
* media/video-test.js:
* platform/chromium/fast/dynamic/insertAdjacentElement-expected.txt:
* security/crypto-random-values-types-expected.txt:
* svg/dom/SVGTransformList-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: storage/indexeddb/mozilla/add-twice-failure.html is flaky following r134252
jsbell@chromium.org [Tue, 13 Nov 2012 18:45:34 +0000 (18:45 +0000)]
IndexedDB: storage/indexeddb/mozilla/add-twice-failure.html is flaky following r134252
https://bugs.webkit.org/show_bug.cgi?id=101996

Reviewed by Dimitri Glazkov.

Error being tested may cause transaction to abort, which could happen before or after
test output is captured. Prevent default behavior of the error so this doesn't happen.

* storage/indexeddb/mozilla/resources/add-twice-failure.js:
(addSecondExpectedError):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, adding my new email address to committers.py and watchlist.
noam.rosenthal@nokia.com [Tue, 13 Nov 2012 18:26:38 +0000 (18:26 +0000)]
Unreviewed, adding my new email address to committers.py and watchlist.

* Scripts/webkitpy/common/config/committers.py:
* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Fully restore both zoom and scroll when leaving an input field.
mifenton@rim.com [Tue, 13 Nov 2012 18:23:59 +0000 (18:23 +0000)]
[BlackBerry] Fully restore both zoom and scroll when leaving an input field.
https://bugs.webkit.org/show_bug.cgi?id=102094

Reviewed by Rob Buis.

PR 234187.

Cache both the zoom and scroll position prior to adjusting
for input focus so that state can be reset fully.

Reviewed Internally by Gen Mak.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
* WebKitSupport/InputHandler.h:
(InputHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: remove legacy string-based backend methods
alecflett@chromium.org [Tue, 13 Nov 2012 18:19:00 +0000 (18:19 +0000)]
IndexedDB: remove legacy string-based backend methods
https://bugs.webkit.org/show_bug.cgi?id=102004

Reviewed by Adam Barth.

This is the final stage in a refactor, preceded by
https://bugs.webkit.org/show_bug.cgi?id=100426

* public/WebIDBDatabase.h:
(WebKit::WebIDBDatabase::createObjectStore):
* public/WebIDBObjectStore.h:
(WebKit::WebIDBObjectStore::createIndex):
(WebKit::WebIDBObjectStore::index):
* public/WebIDBTransaction.h:
* src/IDBDatabaseBackendProxy.cpp:
* src/IDBDatabaseBackendProxy.h:
(IDBDatabaseBackendProxy):
* src/IDBTransactionBackendProxy.cpp:
* src/IDBTransactionBackendProxy.h:
(IDBTransactionBackendProxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate DOMException name: HierarchyRequestError
arv@chromium.org [Tue, 13 Nov 2012 18:02:13 +0000 (18:02 +0000)]
Update DOMException name: HierarchyRequestError
https://bugs.webkit.org/show_bug.cgi?id=102092

Reviewed by Ojan Vafai.

Source/WebCore:

Patch 3 of 25 to update DOMException name to match the spec and Firefox.

Updated existing tests.

* dom/DOMCoreException.cpp:

LayoutTests:

Updated tests and expectations.

* fast/dom/DOMException/prototype-object-expected.txt:
* fast/dom/DOMException/prototype-object.html:
* fast/dom/DOMException/stack-trace-expected.txt:
* fast/dom/DOMException/stack-trace.html:
* fast/dom/Document/replace-child-expected.txt:
* fast/dom/Range/31684-expected.txt:
* fast/dom/Range/range-exceptions-expected.txt:
* fast/dom/Range/script-tests/31684.js:
* fast/dom/Range/script-tests/range-exceptions.js:
* fast/dom/Range/surroundContents-1.html:
* fast/dom/css-mediarule-functions-expected.txt:
* fast/dom/css-mediarule-functions.html:
* fast/dom/document-set-body-expected.txt:
* fast/dom/document-set-body.html:
* fast/dom/move-nodes-across-documents.html:
* fast/dom/processing-instruction-appendChild-exceptions-expected.txt:
* fast/dom/processing-instruction-appendChild-exceptions.xhtml:
* fast/dom/setter-type-enforcement-expected.txt:
* fast/dom/shadow/adopt-node-with-shadow-root-expected.txt:
* fast/dom/shadow/shadow-disable-expected.txt:
* fast/dom/shadow/shadow-root-js-api-expected.txt:
* fast/events/mutation-during-replace-child-2-expected.txt:
* fast/events/mutation-during-replace-child-2.html:
* fast/events/mutation-during-replace-child-expected.txt:
* fast/events/mutation-during-replace-child.html:
* fast/frames/adopt-iframe-into-itself-expected.txt:
* fast/frames/adopt-object-into-itself-expected.txt:
* fast/html/adopt-parent-frame.html:
* fast/inspector-support/uncaught-dom3-exception-expected.txt:
* platform/chromium/dom/xhtml/level3/core/documentnormalizedocument10-expected.txt:
* platform/chromium/fast/dom/DOMException/prototype-object-expected.txt:
* platform/chromium/fast/dom/DOMException/stack-trace-expected.txt:
* platform/chromium/fast/inspector-support/uncaught-dom3-exception-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoClean up use of adjustWindowRect
kenneth@webkit.org [Tue, 13 Nov 2012 17:59:14 +0000 (17:59 +0000)]
Clean up use of adjustWindowRect
https://bugs.webkit.org/show_bug.cgi?id=102072

Reviewed by Alexis Menard.

Source/WebCore:

Tested by fast/dom/Window/open-window-min-size.html

* loader/FrameLoader.cpp:
(WebCore::createWindow):

    Validate the window size here so that it is not just done for
    .open, but also for .showModalDialog. This is compatible with
    other browsers such as IE and Firefox (though IE > 6, enforces
    a minimum width of 250 instead of 100 as Firefox and us.)

* page/DOMWindow.cpp:
(WebCore):
(WebCore::DOMWindow::adjustWindowRect):

    Make it a static method which only takes page. It was never
    called from anywhere without a valid page, so the page check
    has been turned into an assert, and two of the arguments have
    been removed as they can be accessed via the page.

(WebCore::DOMWindow::moveBy):
(WebCore::DOMWindow::moveTo):
(WebCore::DOMWindow::resizeBy):
(WebCore::DOMWindow::resizeTo):

    Update use of adjustWindowRect.

(WebCore::DOMWindow::open):

    Avoid modifying the WindowFeatures as the WebCore::createWindow
    validates and adjusts the arguments.

* page/DOMWindow.h:
(DOMWindow):

LayoutTests:

Test that minimum sizes are honored.

* fast/dom/Window/open-window-min-size.html: Added.
* fast/dom/Window/open-window-min-size-expected.txt: Added.
* fast/dom/Window/resources/print-close.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Exclusions] Update wrap-margin/padding to shape-margin/padding
commit-queue@webkit.org [Tue, 13 Nov 2012 17:53:31 +0000 (17:53 +0000)]
[CSS Exclusions] Update wrap-margin/padding to shape-margin/padding
https://bugs.webkit.org/show_bug.cgi?id=97736

Patch by Bem Jones-Bey <bjonesbe@adobe.com> on 2012-11-13
Reviewed by Andreas Kling.

Rename properties to match updated spec.

Source/WebCore:

Tests: fast/exclusions/shape-margin-parsing.html
       fast/exclusions/shape-padding-parsing.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::isSimpleLengthPropertyID):
(WebCore::CSSParser::parseValue):
* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
* css/CSSPropertyNames.in:
* css/StyleBuilder.cpp:
(WebCore::StyleBuilder::StyleBuilder):
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::asText):
* css/StylePropertyShorthand.cpp:
(WebCore::webkitWrapShorthand):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
* rendering/style/RenderStyle.h:
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
* rendering/style/StyleRareNonInheritedData.h:
(StyleRareNonInheritedData):

LayoutTests:

* fast/exclusions/css-exclusions-disabled-expected.txt:
* fast/exclusions/css-exclusions-disabled.html:
* fast/exclusions/script-tests/shape-margin-parsing.js: Added.
(test):
(testComputedStyle):
(testNotInherited):
* fast/exclusions/script-tests/shape-padding-parsing.js: Added.
(test):
(testComputedStyle):
(testNotInherited):
* fast/exclusions/script-tests/wrap-margin-parsing.js: Removed.
* fast/exclusions/script-tests/wrap-padding-parsing.js: Removed.
* fast/exclusions/script-tests/wrap-parsing.js:
(testComputedStyle):
* fast/exclusions/shape-margin-parsing-expected.txt: Added.
* fast/exclusions/shape-margin-parsing.html: Renamed from LayoutTests/fast/exclusions/wrap-padding-parsing.html.
* fast/exclusions/shape-padding-parsing-expected.txt: Added.
* fast/exclusions/shape-padding-parsing.html: Renamed from LayoutTests/fast/exclusions/wrap-margin-parsing.html.
* fast/exclusions/wrap-margin-parsing-expected.txt: Removed.
* fast/exclusions/wrap-padding-parsing-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r134418.
dglazkov@chromium.org [Tue, 13 Nov 2012 17:47:00 +0000 (17:47 +0000)]
Unreviewed, rolling out r134418.
http://trac.webkit.org/changeset/134418
https://bugs.webkit.org/show_bug.cgi?id=101903

The newly added test is crashing on cr-win.

Source/WebCore:

* dom/ElementShadow.cpp:
* dom/ElementShadow.h:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateType):
(WebCore::HTMLInputElement::setIndeterminate):
* html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::didElementStateChange):
* html/shadow/SelectRuleFeatureSet.cpp:
(WebCore::SelectRuleFeatureSet::add):
(WebCore::SelectRuleFeatureSet::clear):
(WebCore::SelectRuleFeatureSet::collectFeaturesFromSelector):
* html/shadow/SelectRuleFeatureSet.h:
(SelectRuleFeatureSet):

LayoutTests:

* fast/dom/shadow/pseudoclass-update-indeterminate-input-expected.html: Removed.
* fast/dom/shadow/pseudoclass-update-indeterminate-input.html: Removed.
* fast/dom/shadow/pseudoclass-update-indeterminate-progress-expected.html: Removed.
* fast/dom/shadow/pseudoclass-update-indeterminate-progress.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Properly skip all HiDPI tests which are currently failing.
rakuco@webkit.org [Tue, 13 Nov 2012 17:27:14 +0000 (17:27 +0000)]
[EFL] Properly skip all HiDPI tests which are currently failing.

Skip an additional test and add a bug to each entry.

* platform/efl/TestExpectations:
* platform/efl/svg/as-image/animated-svg-repaints-completely-in-hidpi-expected.png: Removed.
* platform/efl/svg/as-image/animated-svg-repaints-completely-in-hidpi-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUninitialized fields in class JSLock
commit-queue@webkit.org [Tue, 13 Nov 2012 17:17:07 +0000 (17:17 +0000)]
Uninitialized fields in class JSLock
https://bugs.webkit.org/show_bug.cgi?id=101695

Patch by Cosmin Truta <ctruta@rim.com> on 2012-11-13
Reviewed by Mark Hahnenberg.

Initialize JSLock::m_ownerThread and JSLock::m_lockDropDepth.

* runtime/JSLock.cpp:
(JSC::JSLock::JSLock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Update pixel expectation for fast/repaint/table-hover-on-link.html
rakuco@webkit.org [Tue, 13 Nov 2012 17:12:29 +0000 (17:12 +0000)]
[EFL] Update pixel expectation for fast/repaint/table-hover-on-link.html

* platform/efl/fast/repaint/table-hover-on-link-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] More video-colorspace-yuv* gardening.
rakuco@webkit.org [Tue, 13 Nov 2012 17:09:33 +0000 (17:09 +0000)]
[EFL] More video-colorspace-yuv* gardening.

These tests are also failing on WK2, so skip them in both ports.

* platform/efl-wk1/TestExpectations:
* platform/efl-wk1/media/video-colorspace-yuv420-expected.png: Removed.
* platform/efl-wk1/media/video-colorspace-yuv422-expected.png: Removed.
* platform/efl/TestExpectations:
* platform/efl/media/video-colorspace-yuv420-expected.txt: Removed.
* platform/efl/media/video-colorspace-yuv422-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r134391.
dglazkov@chromium.org [Tue, 13 Nov 2012 17:08:32 +0000 (17:08 +0000)]
Unreviewed, rolling out r134391.
http://trac.webkit.org/changeset/134391
https://bugs.webkit.org/show_bug.cgi?id=99660

Speculative rollout, trying to fix browser_tests failure.

Source/Platform:

* chromium/public/WebLayerTreeView.h:
(WebLayerTreeView):

Source/WebCore:

* English.lproj/localizedStrings.js:
* inspector/Inspector.json:
* inspector/InspectorClient.h:
* inspector/InspectorPageAgent.cpp:
(PageAgentState):
(WebCore::InspectorPageAgent::enable):
(WebCore::InspectorPageAgent::disable):
* inspector/InspectorPageAgent.h:
* inspector/front-end/Settings.js:
* inspector/front-end/SettingsScreen.js:
(WebInspector.GenericSettingsTab):
* inspector/front-end/inspector.js:
(WebInspector.doLoadedDone):

Source/WebKit/chromium:

* public/WebView.h:
(WebView):
* src/InspectorClientImpl.cpp:
* src/InspectorClientImpl.h:
(InspectorClientImpl):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):
* src/WebViewImpl.h:
(WebViewImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, update expectations after r134345.
rakuco@webkit.org [Tue, 13 Nov 2012 16:53:02 +0000 (16:53 +0000)]
Unreviewed, update expectations after r134345.

* platform/efl/fast/dynamic/insertAdjacentElement-expected.txt:
* platform/gtk/fast/dynamic/insertAdjacentElement-expected.txt:
* platform/mac/fast/dynamic/insertAdjacentElement-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r134205.
commit-queue@webkit.org [Tue, 13 Nov 2012 16:44:45 +0000 (16:44 +0000)]
Unreviewed, rolling out r134205.
http://trac.webkit.org/changeset/134205
https://bugs.webkit.org/show_bug.cgi?id=102093

Broke webkit-flow-inlines-dynamic.html on several ports
(Requested by mihnea on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-13

Source/WebCore:

* css/StyleResolver.cpp:
(WebCore::StyleResolver::isValidRegionStyleProperty):
* rendering/InlineBox.cpp:
* rendering/InlineBox.h:
(WebCore):
(InlineBox):
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::addToLine):
(WebCore::InlineFlowBox::addTextBoxVisualOverflow):
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::setRegionObjectsRegionStyle):
(WebCore::RenderRegion::restoreRegionObjectsOriginalStyle):
(WebCore::RenderRegion::computeStyleInRegion):
(WebCore::RenderRegion::computeChildrenStyleInRegion):
(WebCore::RenderRegion::setObjectStyleInRegion):
(WebCore::RenderRegion::clearObjectStyleInRegion):
* rendering/RenderRegion.h:
(RenderRegion):
(ObjectRegionStyleInfo):

LayoutTests:

* fast/regions/region-style-text-shadow-expected.html: Removed.
* fast/regions/region-style-text-shadow.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CMake] Incorrect dependency calculation when generating forwarding headers
rakuco@webkit.org [Tue, 13 Nov 2012 16:42:53 +0000 (16:42 +0000)]
[CMake] Incorrect dependency calculation when generating forwarding headers
https://bugs.webkit.org/show_bug.cgi?id=102076

Reviewed by Kenneth Rohde Christiansen.

Explicitly call generate-forwarding-headers.pl on ${WEBKIT2_DIR} as
well, since some dependencies pulled in via the WebKit2/WebKit2_C.h
include in config.h are only generated from there.

This is a bit redundant since this is also done in WebKit2's
PlatformEfl.cmake, however the WTF and WebCore API tests do not depend
on WebKit2 so the script may not have been called when these tests are
being built.

* TestWebKitAPI/PlatformEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] WK1 gardening.
rakuco@webkit.org [Tue, 13 Nov 2012 16:15:43 +0000 (16:15 +0000)]
[EFL] WK1 gardening.

Mark media/video-colorspace-yuv420.html and
media/video-colorspace-yuv422.html as producing bad image results.

* platform/efl-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove the non-const overload of ElementAttributeData::inlineStyle().
kling@webkit.org [Tue, 13 Nov 2012 16:08:41 +0000 (16:08 +0000)]
Remove the non-const overload of ElementAttributeData::inlineStyle().

Rubber-stamped by Anders Koivisto.

No call sites actually needed a mutable StylePropertySet* from inlineStyle() anyway.

* dom/ElementAttributeData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Enable input type month/week
keishi@webkit.org [Tue, 13 Nov 2012 16:06:41 +0000 (16:06 +0000)]
[Chromium] Enable input type month/week
https://bugs.webkit.org/show_bug.cgi?id=102042

Reviewed by Kent Tamura.

Enable input type month/week for Chromium.

No new tests. Tests will be added later in Bug 102045 and Bug 102046.

* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Refactoring] Remove shadowPseudoId() and use setPseudo() in <meter> ElementShadow.
shinyak@chromium.org [Tue, 13 Nov 2012 15:59:02 +0000 (15:59 +0000)]
[Refactoring] Remove shadowPseudoId() and use setPseudo() in <meter> ElementShadow.
https://bugs.webkit.org/show_bug.cgi?id=101906

Reviewed by Dimitri Glazkov.

Source/WebCore:

We're migrating shadowPseudoId() to pseudo(). We remove shadowPseudoId() from HTMLKeygenElement and use
setPseudo()/pseudo() instead.

No new tests, covered by existing tests.

* html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::didElementStateChange): Since shadowPseudoId() was returning pseudo id without setting
it anywhere, we have to set it into pseudo attribute here.
(WebCore::HTMLMeterElement::createShadowSubtree): ditto.
* html/shadow/MeterShadowElement.cpp:
(WebCore::MeterInnerElement::MeterInnerElement):
(WebCore::MeterValueElement::valuePseudoId):
* html/shadow/MeterShadowElement.h:
(MeterInnerElement):
(WebCore::MeterBarElement::MeterBarElement):
(MeterBarElement):
(WebCore::MeterValueElement::MeterValueElement):
(WebCore::MeterValueElement::updatePseudo):
(MeterValueElement):

LayoutTests:

* fast/dom/HTMLMeterElement/meter-element-markup-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoExpectations update for fast/regions/webkit-flow-inlines-dynamic.html
schenney@chromium.org [Tue, 13 Nov 2012 15:56:44 +0000 (15:56 +0000)]
Expectations update for fast/regions/webkit-flow-inlines-dynamic.html
https://bugs.webkit.org/show_bug.cgi?id=102086

Unreviewed expectations update.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChanging pseudoClass (:indeterminate) should cause distribution
shinyak@chromium.org [Tue, 13 Nov 2012 15:55:13 +0000 (15:55 +0000)]
Changing pseudoClass (:indeterminate) should cause distribution
https://bugs.webkit.org/show_bug.cgi?id=101903

Reviewed by Dimitri Glazkov.

Source/WebCore:

<progress> and <input type="checkbox"> have 'indeterminate' state. When their state is changed, we have to
invalidate distribution if necessary. To check it, we collect a feature that :invalidate is used in select attributes.

For <input>, we also have to see 'type' is changed. According to the spec, :indeterminate should match only
progress element or <input type="checkbox">. So changing 'type' might also change :indeterminate state.

Tests: fast/dom/shadow/pseudoclass-update-indeterminate-input.html
       fast/dom/shadow/pseudoclass-update-indeterminate-progress.html

* dom/ElementShadow.cpp:
(WebCore::invalidateParentDistributionIfNecessary): Since we will add a lot of pseudoClass check later, we would like to
have this kind of helper method. We will add various pseudoClass check (see Bug 101697), we reuse CSSSelector::PseudoType
here.
(WebCore):
* dom/ElementShadow.h:
(WebCore):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateType): Invalidate parent distribution anyway, since it changes various internal states.
(WebCore::HTMLInputElement::setIndeterminate): Invalidate parent distribution if necessary.
* html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::didElementStateChange):
* html/shadow/SelectRuleFeatureSet.cpp:
(WebCore::SelectRuleFeatureSet::SelectRuleFeatureSet): Adds m_usesIndeterminate feature.
(WebCore::SelectRuleFeatureSet::add):
(WebCore::SelectRuleFeatureSet::clear):
(WebCore::SelectRuleFeatureSet::collectFeaturesFromSelector):
* html/shadow/SelectRuleFeatureSet.h:
(WebCore::SelectRuleFeatureSet::hasSelectorForIndeterminate):
(SelectRuleFeatureSet):

LayoutTests:

* fast/dom/shadow/pseudoclass-update-indeterminate-input-expected.html: Added.
* fast/dom/shadow/pseudoclass-update-indeterminate-input.html: Added.
* fast/dom/shadow/pseudoclass-update-indeterminate-progress-expected.html: Added.
* fast/dom/shadow/pseudoclass-update-indeterminate-progress.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoReverting expectations update because it breaks lint
schenney@chromium.org [Tue, 13 Nov 2012 15:39:01 +0000 (15:39 +0000)]
Reverting expectations update because it breaks lint
https://bugs.webkit.org/show_bug.cgi?id=101982

Unreviewed expectations fix.

With the new-ish wekbit_skia.gyp file we do not need to change expections like this.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Rebaseline after bug 98666 (input[type=range] thumb rendering)
rakuco@webkit.org [Tue, 13 Nov 2012 15:30:38 +0000 (15:30 +0000)]
[EFL] Rebaseline after bug 98666 (input[type=range] thumb rendering)
https://bugs.webkit.org/show_bug.cgi?id=102059

Unreviewed rebaseline. There were a few actual bugs (see bug 102068 and
bug 102067).These changes seem correct and the image changes are tiny.
The non-platform results were still wrong because they are not used
by most platforms, even if the results actually match the platform results.

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-11-13

* fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt:
* fast/forms/range/slider-thumb-stylability-expected.txt:
* fast/forms/range/range-thumb-height-percentage-expected.txt:
* fast/repaint/slider-thumb-float-expected.txt:
* platform/efl/TestExpectations:
* platform/efl/fast/dom/HTMLInputElement/input-slider-update-expected.png:
* platform/efl/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
* platform/efl/fast/forms/box-shadow-override-expected.txt:
* platform/efl/fast/forms/input-appearance-height-expected.txt:
* platform/efl/fast/forms/range/input-appearance-range-expected.png:
* platform/efl/fast/forms/range/input-appearance-range-expected.txt:
* platform/efl/fast/forms/range/slider-padding-expected.txt:
* platform/efl/fast/forms/range/slider-thumb-shared-style-expected.txt:
* platform/efl/fast/layers/video-layer-expected.txt:
* platform/efl/fast/multicol/client-rects-expected.txt:
* platform/efl/fast/repaint/slider-thumb-drag-release-expected.png:
* platform/efl/fast/repaint/slider-thumb-drag-release-expected.txt:
* platform/efl/media/audio-controls-rendering-expected.txt:
* platform/efl/media/audio-repaint-expected.txt:
* platform/efl/media/controls-after-reload-expected.txt:
* platform/efl/media/controls-strict-expected.txt:
* platform/efl/media/controls-styling-expected.txt:
* platform/efl/media/controls-styling-strict-expected.txt:
* platform/efl/media/controls-without-preload-expected.txt:
* platform/efl/media/media-controls-clone-expected.txt:
* platform/efl/media/media-document-audio-repaint-expected.txt:
* platform/efl/media/track/track-cue-rendering-horizontal-expected.txt:
* platform/efl/media/track/track-cue-rendering-vertical-expected.txt:
* platform/efl/media/video-display-toggle-expected.txt:
* platform/efl/media/video-empty-source-expected.txt:
* platform/efl/media/video-no-audio-expected.txt:
* platform/efl/media/video-zoom-controls-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] TiledBackingStore: WebChromeClient::pageRect() should consider viewport size
commit-queue@webkit.org [Tue, 13 Nov 2012 15:15:04 +0000 (15:15 +0000)]
[WK2] TiledBackingStore: WebChromeClient::pageRect() should consider viewport size
https://bugs.webkit.org/show_bug.cgi?id=101946

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-13
Reviewed by Noam Rosenthal.

WebChromeClient::pageRect() should consider viewport size when TILED_BACKING_STORE enabled.

Based on patch by Kenneth Rohde Christiansen.

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::pageRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed: Adding watchlist definition for CoordinatedGraphics.
zeno.albisser@digia.com [Tue, 13 Nov 2012 15:11:40 +0000 (15:11 +0000)]
Unreviewed: Adding watchlist definition for CoordinatedGraphics.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFindGLIB.cmake fails do find glib gmodule module.
hugo.lima@openbossa.org [Tue, 13 Nov 2012 15:04:41 +0000 (15:04 +0000)]
FindGLIB.cmake fails do find glib gmodule module.
https://bugs.webkit.org/show_bug.cgi?id=101784

Reviewed by Caio Marcelo de Oliveira Filho.

* Source/cmake/FindGLIB.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[cmake] Do not use GLOB to add WTR IDL files to buildsystem.
hugo.lima@openbossa.org [Tue, 13 Nov 2012 14:54:06 +0000 (14:54 +0000)]
[cmake] Do not use GLOB to add WTR IDL files to buildsystem.
https://bugs.webkit.org/show_bug.cgi?id=101785

Reviewed by Caio Marcelo de Oliveira Filho.

Using *.idl makes impossible to add IDL files depending on compiler flags,
like a possible GamepadController.idl file found on Chromium.

* WebKitTestRunner/CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] TestRunner should depend on webkit_wtf_support instead of compiling the...
jochen@chromium.org [Tue, 13 Nov 2012 14:49:58 +0000 (14:49 +0000)]
[chromium] TestRunner should depend on webkit_wtf_support instead of compiling the files itself
https://bugs.webkit.org/show_bug.cgi?id=102075

Reviewed by Pavel Feldman.

* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoExploit ElementAttributeData sharing in Node.cloneNode.
kling@webkit.org [Tue, 13 Nov 2012 14:21:28 +0000 (14:21 +0000)]
Exploit ElementAttributeData sharing in Node.cloneNode.
<http://webkit.org/b/101374>

Reviewed by Anders Carlsson.

Instead of blindly creating a new ElementAttributeData for Node.cloneNode, let's be clever!
If the source data is immutable, simply ref it from the new node at virtually no cost.

If the source data is mutable, convert it to immutable data so it can be shared between both nodes.
Since the typical use-case for Node.cloneNode is to create-once/clone-many, this saves both time
and memory in the long run.

~8% speed-up on PerformanceTests/DOM/CloneNodes on my MBP.

* dom/Element.cpp:
(WebCore::Element::cloneAttributesFromElement):

    Move attribute data cloning logic from ElementAttributeData to Element.

* dom/ElementAttributeData.cpp:
(WebCore::ImmutableElementAttributeData::~ImmutableElementAttributeData):
(WebCore::ImmutableElementAttributeData::ImmutableElementAttributeData):
(WebCore::ElementAttributeData::ElementAttributeData):
(WebCore::MutableElementAttributeData::MutableElementAttributeData):
(WebCore::ElementAttributeData::makeMutableCopy):
(WebCore::ElementAttributeData::makeImmutableCopy):
* dom/ElementAttributeData.h:
(ElementAttributeData):
(ImmutableElementAttributeData):
(MutableElementAttributeData):

    Add facilities for converting a mutable ElementAttributeData to an immutable one.
    Share some code in the common base class constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Build fix of V8 bindings.
kinuko@chromium.org [Tue, 13 Nov 2012 14:09:23 +0000 (14:09 +0000)]
Unreviewed. Build fix of V8 bindings.

Patch by Kentaro Hara <haraken@chromium.org> on 2012-11-13

* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::maybeDOMWrapper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][DRT] Remove extra layoutFrame() call when preparing to send an event via EventS...
rakuco@webkit.org [Tue, 13 Nov 2012 14:06:03 +0000 (14:06 +0000)]
[EFL][DRT] Remove extra layoutFrame() call when preparing to send an event via EventSender.
https://bugs.webkit.org/show_bug.cgi?id=102074

Reviewed by Kenneth Rohde Christiansen.

* DumpRenderTree/efl/EventSender.cpp:
(feedMouseEvent): Do not call DumpRenderTreeSupportEfl::layoutFrame()
when sending an event, as it causes additional repaints that create
wrong pixel results for tests such as
fast/repaint/overflow-auto-in-overflow-auto-scrolled.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Canvas] UI: make the Grid save scrolling position, show wait spinner...
commit-queue@webkit.org [Tue, 13 Nov 2012 14:05:30 +0000 (14:05 +0000)]
Web Inspector: [Canvas] UI: make the Grid save scrolling position, show wait spinner icon
https://bugs.webkit.org/show_bug.cgi?id=102071

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-11-13
Reviewed by Pavel Feldman.

* inspector/front-end/CanvasProfileView.js:
(WebInspector.CanvasProfileView):
(WebInspector.CanvasProfileView.prototype.dispose):
(WebInspector.CanvasProfileView.prototype.elementsToRestoreScrollPositionsFor):
(WebInspector.CanvasProfileView.prototype._enableWaitIcon):
(WebInspector.CanvasProfileView.prototype._replayTraceLog.didReplayTraceLog):
(WebInspector.CanvasProfileView.prototype._replayTraceLog):
(WebInspector.CanvasProfileView.prototype._didReceiveTraceLog):
(WebInspector.CanvasProfileView.prototype._createCallNode):
* inspector/front-end/canvasProfiler.css:
(#canvas-replay-image.wait):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Settings screen: some panel shortcuts are missing
commit-queue@webkit.org [Tue, 13 Nov 2012 13:50:58 +0000 (13:50 +0000)]
Web Inspector: Settings screen: some panel shortcuts are missing
https://bugs.webkit.org/show_bug.cgi?id=101026

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-11-13
Reviewed by Pavel Feldman.

Panels, that have not been loaded by the time shortcuts view was
initialized, had no chance to register shortcuts.

Solution: move shortcut registration (for shortcuts screen) to panel
descriptors.

More changes: add JsDoc annotations to ShortcutScreen and change "key"
parameter type for raw string to key descriptor object.

* WebCore.gypi: Added TimelinePanelDescriptor.js file.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* inspector/compile-front-end.py: Ditto.
* inspector/front-end/WebKit.qrc: Ditto.
* inspector/front-end/inspector.html: Ditto.
* inspector/front-end/AdvancedSearchController.js: Add JsDoc annotation.
* inspector/front-end/GoToLineDialog.js: Ditto.
* inspector/front-end/CallStackSidebarPane.js: Removed shortcut-screen
shortcuts registration.
* inspector/front-end/ElementsPanel.js: Ditto.
* inspector/front-end/ScriptsPanel.js: Ditto.
* inspector/front-end/StylesSidebarPane.js: Ditto.
* inspector/front-end/TimelinePanel.js: Ditto.
* inspector/front-end/ConsoleView.js: Changes order of lines to increase
readability.
* inspector/front-end/ElementsPanelDescriptor.js: Add shortcut-screen
shortcuts registration and key descriptor constants.
* inspector/front-end/ScriptsPanelDescriptor.js: Ditto.
* inspector/front-end/TimelinePanelDescriptor.js: Ditto.
* inspector/front-end/Panel.js: Removed unused "uregisterShortcut"; made
"registerShortcuts" method accept array of key descriptors.
(WebInspector.PanelDescriptor.prototype.registerShortcuts): Added.
* inspector/front-end/ShortcutsScreen.js: Added JsDoc; changed parameter
type from string to key descriptor.
* inspector/front-end/inspector.js: Register shortcuts using
panel descriptors.
(WebInspector._panelDescriptors): Removed duplicate line.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoOptimize RGB565 and RGBA5551 packing/unpacking functions with NEON intrinsics
rgabor@webkit.org [Tue, 13 Nov 2012 13:44:31 +0000 (13:44 +0000)]
Optimize RGB565 and RGBA5551 packing/unpacking functions with NEON intrinsics
https://bugs.webkit.org/show_bug.cgi?id=102060

Reviewed by Zoltan Herczeg.

Adding more NEONized packing functions to GraphicsContext3DNEON.h.
These functions are three times faster with this intrinsics optimizations.

* platform/graphics/GraphicsContext3D.cpp:
(WebCore):
* platform/graphics/cpu/arm/GraphicsContext3DNEON.h:
(WebCore::ARM::unpackOneRowOfRGBA5551ToRGBA8NEON):
(ARM):
(WebCore::ARM::packOneRowOfRGBA8ToUnsignedShort5551NEON):
(WebCore::ARM::unpackOneRowOfRGB565ToRGBA8NEON):
(WebCore::ARM::packOneRowOfRGBA8ToUnsignedShort565NEON):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed: temporary disable failing test.
loislo@chromium.org [Tue, 13 Nov 2012 13:26:44 +0000 (13:26 +0000)]
Unreviewed: temporary disable failing test.

* tests/MemoryInstrumentationTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Enable Mutation observer
ossy@webkit.org [Tue, 13 Nov 2012 13:20:25 +0000 (13:20 +0000)]
[Qt] Enable Mutation observer
https://bugs.webkit.org/show_bug.cgi?id=102066

Reviewed by Pavel Feldman.

Source/WebCore:

* DerivedSources.pri: Add missing IDL files.

Tools:

* qmake/mkspecs/features/features.pri:

LayoutTests:

* platform/qt/TestExpectations: Unskip now passing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoupdate expectations in advance of skia change for blurred rects
reed@google.com [Tue, 13 Nov 2012 13:15:51 +0000 (13:15 +0000)]
update expectations in advance of skia change for blurred rects
https://bugs.webkit.org/show_bug.cgi?id=101982

Reviewed by NOBODY.

Unreviewed. Expectations change only

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening, skip failing tests.
ossy@webkit.org [Tue, 13 Nov 2012 13:03:11 +0000 (13:03 +0000)]
[Qt] Unreviewed gardening, skip failing tests.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] DRT - platform/blackberry/editing/text-iterator/findString-markers.html...
commit-queue@webkit.org [Tue, 13 Nov 2012 12:49:42 +0000 (12:49 +0000)]
[BlackBerry] DRT - platform/blackberry/editing/text-iterator/findString-markers.html failed
https://bugs.webkit.org/show_bug.cgi?id=102056

Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2012-11-13
Reviewed by Rob Buis.

RIM PR 235836

TestRunner::findString() was changed to call Page::findString() instead
of WebPage::findNextString(). Page::findString() doesn't update
TextMatch markers.
Work-around by calling both Page::findString() and WebPage::findNextString().

* DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
(TestRunner::findString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed Qt gardening.
kbalazs@webkit.org [Tue, 13 Nov 2012 12:48:11 +0000 (12:48 +0000)]
Unreviewed Qt gardening.

Skip and rebase some tests, remove png's for reftests.

* platform/qt-5.0-wk2/TestExpectations:
* platform/qt-5.0-wk2/css2.1/20110323/margin-collapse-clear-016-expected.png: Added.
* platform/qt-5.0-wk2/css3/filters/custom/custom-filter-composite-source-atop-expected.png: Added.
* platform/qt-5.0-wk2/css3/filters/custom/missing-custom-filter-shader-expected.png: Added.
* platform/qt-5.0-wk2/svg/animations/animateMotion-additive-2c-expected.png: Removed.
* platform/qt-5.0-wk2/svg/repaint/inner-svg-change-viewBox-expected.png: Added.
* platform/qt/svg/animations/animateMotion-additive-2d-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Make isValidDOMObject() static
haraken@chromium.org [Tue, 13 Nov 2012 11:44:57 +0000 (11:44 +0000)]
[V8] Make isValidDOMObject() static
https://bugs.webkit.org/show_bug.cgi?id=101914

Reviewed by Adam Barth.

isValidDOMObject() is used by DOMWrapper.cpp only.

No tests. No change in behavior.

* bindings/v8/V8DOMWrapper.cpp:
(WebCore::isValidDOMObject):
(WebCore):
(WebCore::V8DOMWrapper::maybeDOMWrapper):
* bindings/v8/V8DOMWrapper.h:
(V8DOMWrapper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSSRegions] Incorrect computed height for content with region-break-before
mihnea@adobe.com [Tue, 13 Nov 2012 11:39:12 +0000 (11:39 +0000)]
[CSSRegions] Incorrect computed height for content with region-break-before
https://bugs.webkit.org/show_bug.cgi?id=101862

Reviewed by Julien Chaffraix.

Source/WebCore:

When processing the region breaks for auto-height regions, we skipped the case
when the region-break-before occurred in the first region in the chain which was
an auto-height region. Because of that, the region computed height was not 0
as it was supposed to be, but rather LayoutUnit::max() / 2.

Test: fast/regions/autoheight-breakbefore-wrongheight.html

* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::addForcedRegionBreak):
Make sure we process also the case when the region-break occurs at offset 0 in the flow thread
and the first region in chain is an auto-height region.
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::updateLogicalHeight):
Add an assert to make sure that the computed height for auto-height regions is always less than LayoutUnit::max() / 2.

LayoutTests:

Add a test showing that when content having -webkit-region-break-before:always is flowed
into a region chain with the first region being an auto-height region, the auto-height region
has a computed height of 0 and the content is flowed into the second region in the chain.

* fast/regions/autoheight-breakbefore-wrongheight-expected.txt: Added.
* fast/regions/autoheight-breakbefore-wrongheight.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd the TestRunner public API to the ChromiumPublicApi watchlist, and introduce an...
jochen@chromium.org [Tue, 13 Nov 2012 11:31:25 +0000 (11:31 +0000)]
Add the TestRunner public API to the ChromiumPublicApi watchlist, and introduce an entry for ChromiumTestRunner
https://bugs.webkit.org/show_bug.cgi?id=101957

Reviewed by Adam Barth.

Chromium now also depends on the TestRunner public API, and as such, similar rules as for the Chromium WebKit API should apply.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMemory instrumentation: remove reportMemoryUsage method from ImageObserver
yurys@chromium.org [Tue, 13 Nov 2012 11:21:33 +0000 (11:21 +0000)]
Memory instrumentation: remove reportMemoryUsage method from ImageObserver
https://bugs.webkit.org/show_bug.cgi?id=102058

Reviewed by Pavel Feldman.

* bindings/v8/V8PerIsolateData.cpp:
(WebCore::V8PerIsolateData::reportMemoryUsage): drive-by fix, no need to report
each element of the vector as generic vector instrumentation will take care of it.
* platform/graphics/Image.cpp: the client is reported as weak pointer to make sure
we don't count its by the pointer to the base class which may differ from the actual
object address.
(WebCore::Image::reportMemoryUsage):
* platform/graphics/ImageObserver.h: removed reportMemoryUsage method from the interface.
(ImageObserver):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] move tracking of damaged regions from WebViewHost to WebTestProxy
jochen@chromium.org [Tue, 13 Nov 2012 10:53:50 +0000 (10:53 +0000)]
[chromium] move tracking of damaged regions from WebViewHost to WebTestProxy
https://bugs.webkit.org/show_bug.cgi?id=101927

Reviewed by Adam Barth.

This will allow for sharing the code with content_shell

* DumpRenderTree/chromium/DRTTestRunner.cpp:
(DRTTestRunner::display):
* DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
(WebKit):
(WebTestProxyBase):
(WebTestRunner::WebTestProxy::didInvalidateRect):
(WebTestRunner::WebTestProxy::didScrollRect):
(WebTestRunner::WebTestProxy::scheduleComposite):
(WebTestRunner::WebTestProxy::scheduleAnimation):
(WebTestRunner::WebTestProxy::setWindowRect):
(WebTestRunner::WebTestProxy::show):
(WebTestRunner::WebTestProxy::didAutoResize):
(WebTestRunner::WebTestProxy::postAccessibilityNotification):
* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::setPaintRect):
(WebTestRunner):
(WebTestRunner::WebTestProxyBase::paintRect):
(WebTestRunner::WebTestProxyBase::didInvalidateRect):
(WebTestRunner::WebTestProxyBase::didScrollRect):
(WebTestRunner::WebTestProxyBase::scheduleComposite):
(WebTestRunner::WebTestProxyBase::scheduleAnimation):
(WebTestRunner::WebTestProxyBase::show):
(WebTestRunner::WebTestProxyBase::setWindowRect):
(WebTestRunner::WebTestProxyBase::didAutoResize):
(WebTestRunner::WebTestProxyBase::postAccessibilityNotification):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::createNewWindow):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::scheduleAnimation):
(WebViewHost::show):
(WebViewHost::setWindowRect):
(WebViewHost::WebViewHost):
(WebViewHost::proxy):
(WebViewHost::setProxy):
(WebViewHost::reset):
(WebViewHost::paintInvalidatedRegion):
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agocheckbox to toggle FPS counter in the inspector's settings
commit-queue@webkit.org [Tue, 13 Nov 2012 10:25:21 +0000 (10:25 +0000)]
checkbox to toggle FPS counter in the inspector's settings
https://bugs.webkit.org/show_bug.cgi?id=99660

Patch by Eberhard Graether <egraether@google.com> on 2012-11-13
Reviewed by Pavel Feldman.

Added a checkbox to the inspector's settings to toggle a FPS counter. The checkbox appears when InspectorClient::canShowFPSCounter() returns true.

Source/Platform:

* chromium/public/WebLayerTreeView.h:
(WebLayerTreeView):
(WebKit::WebLayerTreeView::setShowFPSCounter):

Source/WebCore:

No new tests.

* English.lproj/localizedStrings.js:
* inspector/Inspector.json:
* inspector/InspectorClient.h:
(WebCore::InspectorClient::canShowFPSCounter):
(WebCore::InspectorClient::setShowFPSCounter):
(InspectorClient):
* inspector/InspectorPageAgent.cpp:
(PageAgentState):
(WebCore::InspectorPageAgent::enable):
(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::canShowFPSCounter):
(WebCore):
(WebCore::InspectorPageAgent::setShowFPSCounter):
* inspector/InspectorPageAgent.h:
* inspector/front-end/Settings.js:
* inspector/front-end/SettingsScreen.js:
(WebInspector.GenericSettingsTab):
(WebInspector.GenericSettingsTab.prototype.get _showFPSCounterChanged):
* inspector/front-end/inspector.js:
(WebInspector.doLoadedDone):

Source/WebKit/chromium:

* public/WebView.h:
(WebView):
* src/InspectorClientImpl.cpp:
(WebKit::InspectorClientImpl::canShowFPSCounter):
(WebKit):
(WebKit::InspectorClientImpl::setShowFPSCounter):
* src/InspectorClientImpl.h:
(InspectorClientImpl):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setShowFPSCounter):
(WebKit):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::loadFontAtlasIfNecessary):
* src/WebViewImpl.h:
(WebViewImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnable to set valid time value to input[type=time] with user interaction in some...
tkent@chromium.org [Tue, 13 Nov 2012 10:18:33 +0000 (10:18 +0000)]
Unable to set valid time value to input[type=time] with user interaction in some cases
https://bugs.webkit.org/show_bug.cgi?id=102048

Reviewed by Kentaro Hara.

Source/WebCore:

The implementations of shouldMillisecondFieldReadOnly,
shouldMinuteFieldReadOnly, and shouldSecondFieldReadOnly were
incorrect. We need to check if a part of the minimum value matches to
the corresponding part of the current value.

Also, we had better check hour field editability.

Test: fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield.html

* html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::shouldHaveSecondField):
Fix a problem that hh:mm:00.sss didn't create a seconds field.
* html/shadow/DateTimeEditElement.cpp:
(DateTimeEditBuilder): Add shouldHourFieldReadOnly declaration.
(WebCore::DateTimeEditBuilder::visitField):
Add shouldHourFieldReadOnly check to Hour11/Hour12/Hour23/Hour24/Period fields.
(WebCore::DateTimeEditBuilder::shouldHourFieldReadOnly):
Added. An hour field should be read-only if the step value is a multiple
of a day and the hour part of the minimum value matches to the hour part
of the value.
(WebCore::DateTimeEditBuilder::shouldMillisecondFieldReadOnly):
A millisecond field should be read-only if the step value is a multiple
of one second and the millisecond part of the minimum value matches to
the millisecond part of the value.
(WebCore::DateTimeEditBuilder::shouldMinuteFieldReadOnly):
A minute field should be read-only if the step value is a multiple of
one hour and the minute part of the minimum value matches to the minute
part of the value.
(WebCore::DateTimeEditBuilder::shouldSecondFieldReadOnly):
A second field should be read-only if the step value is a multiple of
one minute and the second part of the minimum value matches to the second
part of the value.
* platform/Decimal.cpp:
(WebCore::Decimal::remainder):
Fix a bug in case that the fractional part of quotient is >= 0.5. Also
make this matches to C99, C++11, ECMAScript behavior.

Source/WebKit/chromium:

* tests/DecimalTest.cpp:
(TEST_F): Update and add tests.
2.1 % 3 should be 2.1
10 % -3 should be 1
-10 % -3 should be -1
3.6 % 1.3 should be 1
500 % 1000 should be 500
-500 % 1000 should be -500

LayoutTests:

* fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield-expected.txt: Added.
* fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMemory instrumentation: MemoryBlock name should not include full path to the block
yurys@chromium.org [Tue, 13 Nov 2012 10:13:54 +0000 (10:13 +0000)]
Memory instrumentation: MemoryBlock name should not include full path to the block
https://bugs.webkit.org/show_bug.cgi?id=102055

Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/InspectorMemoryAgent.cpp: pass only last path component as MemoryBlock name
intead of fully qualified name.

LayoutTests:

Use Image instead of Page.Image as block identifier.

* inspector/profiler/memory-instrumentation-cached-images-expected.txt:
* inspector/profiler/memory-instrumentation-cached-images.html:
* inspector/profiler/memory-instrumentation-canvas-expected.txt:
* inspector/profiler/memory-instrumentation-canvas.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed Qt gardening.
kadam@inf.u-szeged.hu [Tue, 13 Nov 2012 10:11:57 +0000 (10:11 +0000)]
[Qt] Unreviewed Qt gardening.

Update TestExpectations after r134345.

Patch by Szilard Ledan <szledan@inf.u-szeged.hu> on 2012-11-13

* platform/qt/fast/dynamic/insertAdjacentElement-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: get rid of enter/exitTextChangeMode in the editor
pfeldman@chromium.org [Tue, 13 Nov 2012 09:29:17 +0000 (09:29 +0000)]
Web Inspector: get rid of enter/exitTextChangeMode in the editor
https://bugs.webkit.org/show_bug.cgi?id=101845

Reviewed by Vsevolod Vlasov.

They seem to do nothing.

* inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor.prototype._textChanged):
(WebInspector.DefaultTextEditor.prototype.editRange):
(WebInspector.TextEditorMainPanel):
(WebInspector.TextEditorMainPanel.prototype.handleUndoRedo):
(WebInspector.TextEditorMainPanel.prototype.handleEnterKey.get var):
(WebInspector.TextEditorMainPanel.prototype.handleEnterKey):
(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
* inspector/front-end/TextEditorModel.js:
(WebInspector.TextEditorModel.endsWithBracketRegex.):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove the custom WebSocket::send for both V8 and JSC
tommyw@google.com [Tue, 13 Nov 2012 09:15:35 +0000 (09:15 +0000)]
Remove the custom WebSocket::send for both V8 and JSC
https://bugs.webkit.org/show_bug.cgi?id=101936

Reviewed by Kentaro Hara.

This patch removes the custom WebSocket::send since it isn't needed anymore.

Patch covered by existing tests.

* Modules/websockets/WebSocket.idl:
* UseV8.cmake:
* WebCore.gypi:
* bindings/js/JSWebSocketCustom.cpp:
* bindings/v8/custom/V8WebSocketCustom.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed Qt gardening.
kbalazs@webkit.org [Tue, 13 Nov 2012 09:08:54 +0000 (09:08 +0000)]
Unreviewed Qt gardening.

Amend my last commit, Ossy suggested we should not forget about
past failures because of needed rebaseline.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed Qt gardening.
kbalazs@webkit.org [Tue, 13 Nov 2012 08:55:33 +0000 (08:55 +0000)]
Unreviewed Qt gardening.

Cleanup TestExpectations to pass --lint-test-files.
Removed some duplicated entries.

* platform/qt-5.0-wk2/TestExpectations:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix the ARM traditional build after r134332
ossy@webkit.org [Tue, 13 Nov 2012 08:53:09 +0000 (08:53 +0000)]
Fix the ARM traditional build after r134332
https://bugs.webkit.org/show_bug.cgi?id=102044

Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2012-11-13
Reviewed by Zoltan Herczeg.

Added missing methods for the MacroAssemblerARM, based on the MacroAssemblerARMv7.

* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::canJumpReplacePatchableBranchPtrWithPatch):
(MacroAssemblerARM):
(JSC::MacroAssemblerARM::startOfPatchableBranchPtrWithPatch):
(JSC::MacroAssemblerARM::revertJumpReplacementToPatchableBranchPtrWithPatch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: move indentation logic into TextEditorModel
pfeldman@chromium.org [Tue, 13 Nov 2012 08:48:42 +0000 (08:48 +0000)]
Web Inspector: move indentation logic into TextEditorModel
https://bugs.webkit.org/show_bug.cgi?id=101842

Reviewed by Vsevolod Vlasov.

Source/WebCore:

I'd like to move as much headless logic into the TextEditorModel as possible.
Drive by: removed some dead code, converted getter into function and moved undo
mark state into the model as well.

* inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor.prototype.editRange):
(WebInspector.DefaultTextEditor.prototype._syncDecorationsForLine):
(WebInspector.TextEditorChunkedPanel.prototype._splitChunkOnALine):
(WebInspector.TextEditorMainPanel.prototype.handleEnterKey.get var):
(WebInspector.TextEditorMainPanel.prototype.handleEnterKey):
(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
(WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
(WebInspector.TextEditorMainChunk):
(WebInspector.TextEditorMainChunk.prototype.isDecorated):
(WebInspector.TextEditorMainChunk.prototype.set expanded):
* inspector/front-end/TextEditorModel.js:
(WebInspector.TextEditorModel.endsWithBracketRegex.):

LayoutTests:

* inspector/editor/indentation.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoop_get_callee should have value profiling
fpizlo@apple.com [Tue, 13 Nov 2012 08:42:47 +0000 (08:42 +0000)]
op_get_callee should have value profiling
https://bugs.webkit.org/show_bug.cgi?id=102047

Reviewed by Sam Weinig.

This will allow us to detect if the callee is always the same, which is probably
the common case for a lot of constructors.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
* bytecode/Opcode.h:
(JSC):
(JSC::padOpcodeName):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_get_callee):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_get_callee):
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed attempt to fix the chromium mac-build after r134348.
hayato@chromium.org [Tue, 13 Nov 2012 08:39:00 +0000 (08:39 +0000)]
Unreviewed attempt to fix the chromium mac-build after r134348.

* platform/graphics/mac/FontMac.mm:
(WebCore::Font::drawGlyphs):
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: migrate text editor to mutation observers
pfeldman@chromium.org [Tue, 13 Nov 2012 08:34:35 +0000 (08:34 +0000)]
Web Inspector: migrate text editor to mutation observers
https://bugs.webkit.org/show_bug.cgi?id=101841

Reviewed by Vsevolod Vlasov.

Otherwise, we miss notifications on the removed lines.

* inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor.prototype.wasShown):
(WebInspector.DefaultTextEditor.prototype.willHide):
(WebInspector.TextEditorChunkedPanel.prototype._repaintAll):
(WebInspector.TextEditorMainPanel):
(WebInspector.TextEditorMainPanel.prototype._wasShown):
(WebInspector.TextEditorMainPanel.prototype._willHide):
(WebInspector.TextEditorMainPanel.prototype.markAndRevealRange):
(WebInspector.TextEditorMainPanel.prototype.beginDomUpdates):
(WebInspector.TextEditorMainPanel.prototype.endDomUpdates):
(WebInspector.TextEditorMainPanel.prototype._paintScheduledLines):
(WebInspector.TextEditorMainPanel.prototype._paintLineChunks):
(WebInspector.TextEditorMainPanel.prototype._paintLine):
(WebInspector.TextEditorMainPanel.prototype._insertSpanBefore):
(WebInspector.TextEditorMainPanel.prototype._handleMutations.else.get if):
(WebInspector.TextEditorMainPanel.prototype._handleMutations):
(WebInspector.TextEditorMainPanel.prototype._collectDirtyLines):
(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
* inspector/front-end/externs.js:
(WebKitMutation):
(WebKitMutationObserver.prototype.observe):
(WebKitMutationObserver.prototype.disconnect):
* inspector/front-end/textEditor.css:
(.debug-fadeout):
(@-webkit-keyframes debug-fadeout):
(to):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoOptimize RGBA4444ToRGBA8 packing/unpacking functions with NEON intrinsics in Graphics...
rgabor@webkit.org [Tue, 13 Nov 2012 08:33:08 +0000 (08:33 +0000)]
Optimize RGBA4444ToRGBA8 packing/unpacking functions with NEON intrinsics in GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=101473

Reviewed by Zoltan Herczeg.

With NEON intrinsics the packing/unpacking functions can be optimized well.
This particular function is about 3 times faster with ARM NEON. On top level tests
the speed up was 1.18x.

* CMakeLists.txt:
* GNUmakefile.am:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.pri:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/GraphicsContext3D.cpp:
(WebCore):
* platform/graphics/cpu/arm/GraphicsContext3DNEON.h: Added.
(WebCore):
(ARM):
(WebCore::ARM::unpackOneRowOfRGBA4444ToRGBA8NEON):
(WebCore::ARM::packOneRowOfRGBA8ToUnsignedShort4444NEON):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash when replacing parts of text inputs with content: url(...)
tasak@google.com [Tue, 13 Nov 2012 08:23:48 +0000 (08:23 +0000)]
Crash when replacing parts of text inputs with content: url(...)
https://bugs.webkit.org/show_bug.cgi?id=101133

Reviewed by Kent Tamura.

Source/WebCore:

Disable directly setting content of elements in an input element's
shadow dom tree, because the setting breaks input element's behavior.

Tests: fast/forms/number/number-content-url-crash.html
       fast/forms/search/search-content-url-crash.html

* css/html.css:
(input::-webkit-textfield-decoration-container):
Use important to disable overriding an input element's content
property.
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::attach):
Added ASSERTION. No content should be applied to
input::-webkit-textfield-decoration-container.

LayoutTests:

* fast/forms/number/number-content-url-crash-expected.txt: Added.
* fast/forms/number/number-content-url-crash.html: Added.
* fast/forms/search/search-content-url-crash-expected.txt: Added.
* fast/forms/search/search-content-url-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCoordinated Graphics: Directly composited animated GIFs only render the first image.
commit-queue@webkit.org [Tue, 13 Nov 2012 08:11:18 +0000 (08:11 +0000)]
Coordinated Graphics: Directly composited animated GIFs only render the first image.
https://bugs.webkit.org/show_bug.cgi?id=102043

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-13
Reviewed by Noam Rosenthal.

.:

Add a test to check that a gif animation can run on a compositing layer.

* ManualTests/animated-gif-on-compositing-layer.html: Added.

Source/WebKit2:

CoordinatedGraphicsLayer::setContentsToImage() checks the pointer to the image,
not nativeImagePtr, so Coordinated Graphics currently draws only the first frame
of gif animations. This patch makes Coordinated Graphics draw gif animations.

In addition, this patch modifies the style of direct image compositing
code to match other parts of CoordinatedGraphicsLayer.

Test: ManualTests/animated-gif-on-compositing-layer.html

* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::didChangeImageBacking):
(WebCore):
(WebCore::CoordinatedGraphicsLayer::CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::setContentsNeedsDisplay):
(WebCore::CoordinatedGraphicsLayer::setContentsToImage):
(WebCore::CoordinatedGraphicsLayer::syncImageBacking):
(WebCore::CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly):
(WebCore::CoordinatedGraphicsLayer::releaseImageBackingIfNeeded):
(WebCore::CoordinatedGraphicsLayer::purgeBackingStores):
(WebCore::CoordinatedGraphicsLayer::hasPendingVisibleChanges):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] REGRESSION(134142): overscaled tiles in pixel test results and MiniBrowser
commit-queue@webkit.org [Tue, 13 Nov 2012 07:49:22 +0000 (07:49 +0000)]
[Qt] REGRESSION(134142): overscaled tiles in pixel test results and MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=101918

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-12
Reviewed by Noam Rosenthal.

Source/WebCore:

Remove TiledBackingStore::rect(), because it is not used anymore.

* platform/graphics/TiledBackingStore.h:
(TiledBackingStore):

Source/WebKit2:

Currently, CoordinatedBackingStore can keep out-dated contents size, because the
size of CoordinatedBackingStore is set by only LayerTreeRenderer::createTile().
Although the size of GraphicsLayer is changed, LayerTreeRenderer::createTile()
is not called. However, LayerTreeRenderer::createTile() is always called, when
the contents scale of GraphicsLayer is changed.

This patch makes sure that we reset the backing store's size to the
layer size when UpdateTile or RemoveTile are called.

* UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp:
(WebKit::CoordinatedBackingStore::setSize):
(WebKit::CoordinatedBackingStore::paintToTextureMapper):
* UIProcess/CoordinatedGraphics/CoordinatedBackingStore.h:
(CoordinatedBackingStore):
* UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:
(WebKit::LayerTreeCoordinatorProxy::createTileForLayer):
* UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.h:
(LayerTreeCoordinatorProxy):
* UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.messages.in:
* UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
(WebKit::LayerTreeRenderer::getBackingStore):
(WebKit::LayerTreeRenderer::removeBackingStoreIfNeeded):
(WebKit::LayerTreeRenderer::resetBackingStoreSizeToLayerSize):
(WebKit):
(WebKit::LayerTreeRenderer::createTile):
(WebKit::LayerTreeRenderer::removeTile):
(WebKit::LayerTreeRenderer::updateTile):
* UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:
(LayerTreeRenderer):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::createTile):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayerClient):
(CoordinatedGraphicsLayer):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedTile.cpp:
(WebKit::CoordinatedTile::updateBackBuffer):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedTile.h:
(CoordinatedTileClient):
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::createTile):
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:
(LayerTreeCoordinator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowebkitpy: clean up lint errors, part 1
dpranke@chromium.org [Tue, 13 Nov 2012 07:37:30 +0000 (07:37 +0000)]
webkitpy: clean up lint errors, part 1
https://bugs.webkit.org/show_bug.cgi?id=102024

Reviewed by Adam Barth.

This patch cleans up a lot of miscellaneous minor lint errors that
apparently aren't caught by unit tests, and suppresses a few
false positives.

Also, this patch removes the garden-o-matic "rollout" entry point
since it's no longer being used by the frontend (rather than
fix it to not generate lint errors).

* Scripts/webkitpy/common/system/executive_mock.py:
(MockExecutive2.run_command):
* Scripts/webkitpy/common/system/filesystem_mock.py:
(MockFileSystem.copyfile):
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._http_tests):
* Scripts/webkitpy/layout_tests/port/apple.py:
(ApplePort):
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.reference_files):
* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort):
* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidDriver._teardown_performance):
* Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
(ChromiumPortTestCase.TestAndroidPort.__init__):
(ChromiumPortTestCase.test_default_configuration):
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
(PortTestCase):
(PortTestCase.test_driver_cmd_line):
(PortTestCase.test_expectations_ordering):
* Scripts/webkitpy/layout_tests/servers/http_server_base.py:
(HttpServerBase._check_that_all_ports_are_available):
* Scripts/webkitpy/style/checkers/python.py:
(Pylinter):
* Scripts/webkitpy/tool/commands/gardenomatic.py:
(GardenOMatic.__init__):
* Scripts/webkitpy/tool/commands/queues.py:
(CommitQueue):
* Scripts/webkitpy/tool/servers/gardeningserver.py:
(GardeningHTTPRequestHandler):
(GardeningHTTPRequestHandler.localresult):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago<rdar://problem/12445176>
weinig@apple.com [Tue, 13 Nov 2012 07:35:18 +0000 (07:35 +0000)]
<rdar://problem/12445176>
WebProcess needs permission to open AppleUpstreamUserClient

Rubber-stamped by Dan Bernstein.

* WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] We should be able to recover the V8DOMWindowShell more quickly
abarth@webkit.org [Tue, 13 Nov 2012 07:32:07 +0000 (07:32 +0000)]
[V8] We should be able to recover the V8DOMWindowShell more quickly
https://bugs.webkit.org/show_bug.cgi?id=102020

Reviewed by Kentaro Hara.

For isolated worlds, we used to store the V8DOMWindowShell as an
internal field of the inner DOM window. This patch moves the pointer to
an internal field of the v8::Context, which saves us the work of
looking up the inner DOM window.

Unfortunately, we cannot store the V8DOMWindowShell in V8PerContextData
because the V8DOMWindowShell outlives the V8PerContextData. (We destroy
the V8PerContextData when we detach the V8DOMWindowShell from the
frame.)

* bindings/scripts/CodeGeneratorV8.pm:
(GetInternalFields):
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::initializeIfNeeded):
* bindings/v8/V8DOMWindowShell.h:
(WebCore::V8DOMWindowShell::getEntered):
* bindings/v8/V8PerContextData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowebkitpy: clean up lint errors, part 2
dpranke@chromium.org [Tue, 13 Nov 2012 07:29:59 +0000 (07:29 +0000)]
webkitpy: clean up lint errors, part 2
https://bugs.webkit.org/show_bug.cgi?id=102029

Reviewed by Adam Barth.

This cleans up the remaining lint errors in webkitpy with four exceptions:
1) we don't lint thirdparty/ autoinstalled code, obviously
2) there's an intentional error in the unit tests for pylint itself
3) the implementation of webkit-patch optimize-expectations has
an error but I think we can and should just remove that command as well.
4) I have not yet linted the test code

* Scripts/webkitpy/common/newstringio.py:
* Scripts/webkitpy/common/checkout/scm/scm.py:
(SCM.find_checkout_root):
(SCM.will.remote_merge_base):
* Scripts/webkitpy/common/checkout/scm/scm_mock.py:
* Scripts/webkitpy/common/checkout/scm/svn.py:
(SVNRepository.has_authorization_for_realm):
(SVN.__init__):
* Scripts/webkitpy/common/config/contributionareas.py:
(ContributionAreas.names):
* Scripts/webkitpy/common/config/ports.py:
(DeprecatedPort):
* Scripts/webkitpy/common/net/buildbot/buildbot.py:
(Builder.force_build):
* Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
* Scripts/webkitpy/style/checkers/cpp.py:
(check_posix_threading):
(check_spacing):
* Scripts/webkitpy/style/optparser.py:
(ArgumentParser._create_option_parser):
* Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
(AbstractLocalServerCommand.execute):
* Scripts/webkitpy/tool/commands/download.py:
(AbstractPatchProcessingCommand):
(AbstractPatchProcessingCommand._process_patch):
* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(AbstractEarlyWarningSystem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Add ASSERT() to guarantee that we don't store NULL pointers to V8 internal fields
haraken@chromium.org [Tue, 13 Nov 2012 06:59:25 +0000 (06:59 +0000)]
[V8] Add ASSERT() to guarantee that we don't store NULL pointers to V8 internal fields
https://bugs.webkit.org/show_bug.cgi?id=101054

Reviewed by Adam Barth.

I'm investigating a Chromium crash bug:
http://code.google.com/p/chromium/issues/detail?id=155942

I've not yet identified the root cause (because I can't reproduce
the crash), but it looks like we are storing NULL pointers to
V8 internal fields. Just in case, we can add an ASSERT() to
guarantee that NULL pointers are never stored. (Also I'm hoping
that this ASSERT() will give me more debug information.)

No tests. No change in behavior.

* bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::setDOMWrapper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Turn on errors on warnings for WebKit1 and WebKit2 libraries
commit-queue@webkit.org [Tue, 13 Nov 2012 06:55:08 +0000 (06:55 +0000)]
[EFL] Turn on errors on warnings for WebKit1 and WebKit2 libraries
https://bugs.webkit.org/show_bug.cgi?id=101762

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-12
Reviewed by Gyuyoung Kim.

In case of EFL, add ENABLE_WERROR to EXTRA_COMPILER_FLAGS for WEBKIT and WEBKIT2

* Source/CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChanging id, className, or attribute should invalidate distribution
shinyak@chromium.org [Tue, 13 Nov 2012 06:50:15 +0000 (06:50 +0000)]
Changing id, className, or attribute should invalidate distribution
https://bugs.webkit.org/show_bug.cgi?id=100738

Reviewed by Dimitri Glazkov.

PerformanceTests:

Added test code to modify id/class/attribute.

* DOM/ModifyAttribute.html: Added.
* DOM/resources/dom-perf/modify-attribute.js: Added.
(ModifyAttribute.CreateElementToSetUp):
(ModifyAttribute.ModifyId):
(ModifyAttribute.ModifyClass):
(ModifyAttribute.ModifyTitle):

Source/WebCore:

When id, className, or attribute is changed, we might have to invalidate distribution.
However, we don't want to do useless invalidation. So we consult with the RuleFeatureSet of ElementShadow,
and invalidate distribution only if necessary.

When className is changed, we can share a lot of code between invalidating distribution and invalidating style.
So we made checkNeedsStyleInvalidationForClassChange a template method, and share it.

Also we've measured how this patch makes changing attribute slow. By converting checkNeedsStyleInvalidationForClassChange
to template, actually this improves the performance of changing attribute code. I've measured each code 3 times.

DOM/ModifyAttribute.html
Before this patch:
        median  stdev  min      max    [ms]
  1st   115.62   0.67  114.75   117.00
  2nd   115.08   1.13  113.25   117.58
  3rd   114.75   1.16  113.42   117.83

After this patch:
        median  stdev  min      max    [ms]
  1st   102.55   0.95  101.25   104.50
  2nd   103.10   0.86  102.20   100.95
  3rd   103.30   1.05  102.10   106.65

Tests: fast/dom/shadow/distribution-attribute-modified.html
       fast/dom/shadow/distribution-className-modified.html
       fast/dom/shadow/distribution-id-modified.html
       fast/dom/shadow/reprojection-attribute-modified.html
       fast/dom/shadow/reprojection-className-modified.html
       fast/dom/shadow/reprojection-id-modified.html

* dom/Element.cpp:
(WebCore::Element::attributeChanged):
(WebCore::HasSelectorForClassStyleFunctor::HasSelectorForClassStyleFunctor):
(HasSelectorForClassStyleFunctor):
(WebCore::HasSelectorForClassStyleFunctor::operator()): Returns true if StyleResolver::hasSelectorForClass returns true.
(WebCore):
(WebCore::HasSelectorForClassDistributionFunctor::HasSelectorForClassDistributionFunctor):
(HasSelectorForClassDistributionFunctor):
(WebCore::HasSelectorForClassDistributionFunctor::operator()): Returns true if ElementShadow::hasSelectorForClass returns true.
(WebCore::checkFunctorForClassChange):
(WebCore::checkNeedsStyleInvalidationForClassChange): Extacted the implementation to checkFunctorForClassChange.
(WebCore::checkNeedsDistributionInvalidationForClassChange):
(WebCore::Element::classAttributeChanged):

LayoutTests:

We have test cases that id/class/attribute is changed, and thier reprojection cases.

* fast/dom/shadow/distribution-attribute-modified-expected.html: Added.
* fast/dom/shadow/distribution-attribute-modified.html: Added.
* fast/dom/shadow/distribution-className-modified-expected.html: Added.
* fast/dom/shadow/distribution-className-modified.html: Added.
* fast/dom/shadow/distribution-id-modified-expected.html: Added.
* fast/dom/shadow/distribution-id-modified.html: Added.
* fast/dom/shadow/reprojection-attribute-modified-expected.html: Added.
* fast/dom/shadow/reprojection-attribute-modified.html: Added.
* fast/dom/shadow/reprojection-className-modified-expected.html: Added.
* fast/dom/shadow/reprojection-className-modified.html: Added.
* fast/dom/shadow/reprojection-id-modified-expected.html: Added.
* fast/dom/shadow/reprojection-id-modified.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] In ewk_tiled_backing_store_pre_render_region, the 'slicer' may be uninitialized
commit-queue@webkit.org [Tue, 13 Nov 2012 06:36:05 +0000 (06:36 +0000)]
[EFL] In ewk_tiled_backing_store_pre_render_region, the 'slicer' may be uninitialized
https://bugs.webkit.org/show_bug.cgi?id=102038

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-12
Reviewed by Gyuyoung Kim.

To fix build warning -Wuninitialized,
initialize the 'slicer' in ewk_tiled_backing_store_pre_render_region.

* ewk/ewk_tiled_backing_store.cpp:
(ewk_tiled_backing_store_pre_render_region):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] NetworkJob should not check if data is received with HEAD
commit-queue@webkit.org [Tue, 13 Nov 2012 06:28:49 +0000 (06:28 +0000)]
[BlackBerry] NetworkJob should not check if data is received with HEAD
https://bugs.webkit.org/show_bug.cgi?id=102034

Patch by Joe Mason <jmason@rim.com> on 2012-11-12
Reviewed by George Staikos.

Internal PR: 241391

.:

Add test that HEAD XMLHttpRequests return status 404 instead of calling onerror.

* ManualTests/blackberry/head-xhr-nonexistant-file.html: Added.

Source/WebCore:

Make HEAD requests call didFinish instead of didFail on a 404 response, even though they
have no data.

Tests: ManualTests/blackberry/head-xhr-nonexistant-file.html

* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::NetworkJob):
(WebCore::NetworkJob::initialize):
(WebCore::NetworkJob::shouldNotifyClientFailed):
* platform/network/blackberry/NetworkJob.h:
(NetworkJob):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoremove 'webkit-patch optimize-expectations'
dpranke@chromium.org [Tue, 13 Nov 2012 06:12:55 +0000 (06:12 +0000)]
remove 'webkit-patch optimize-expectations'
https://bugs.webkit.org/show_bug.cgi?id=102032

Reviewed by Adam Barth.

Removing this command because it is totally broken (probably
broke when I added support for multiple files in a cascade)
and doesn't seem to do anything much useful. It certainly
didn't actually optimize things.

* Scripts/webkitpy/tool/commands/expectations.py: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoThe act of getting the callee during 'this' construction should be explicit in bytecode
fpizlo@apple.com [Tue, 13 Nov 2012 06:04:51 +0000 (06:04 +0000)]
The act of getting the callee during 'this' construction should be explicit in bytecode
https://bugs.webkit.org/show_bug.cgi?id=102016

Reviewed by Michael Saboff.

This is mostly a rollout of http://trac.webkit.org/changeset/116673, but also includes
changes to have create_this use the result of get_callee.

No performance or behavioral impact. This is just meant to allow us to profile
get_callee in the future.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
* bytecode/Opcode.h:
(JSC):
(JSC::padOpcodeName):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
* jit/JIT.h:
(JIT):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_get_callee):
(JSC):
(JSC::JIT::emit_op_create_this):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_get_callee):
(JSC):
(JSC::JIT::emit_op_create_this):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] V8DOMWrapper::instantiateV8Object shouldn't use deprecatedDocument
abarth@webkit.org [Tue, 13 Nov 2012 06:04:36 +0000 (06:04 +0000)]
[V8] V8DOMWrapper::instantiateV8Object shouldn't use deprecatedDocument
https://bugs.webkit.org/show_bug.cgi?id=102015

Reviewed by Kentaro Hara.

Previously, Nodes had a special path through
V8DOMWrapper::instantiateV8Object using deprecatedDocument so that we
could find the V8PerContextData quickly. Now that we can get the
V8PerContextData from the v8::Context quickly, we can move Nodes to the
general case. The net consequence is that creation of all DOM objects
should be as fast as Nodes are.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateToV8Converters):
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::V8Float64Array::wrapSlow):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::V8TestActiveDOMObject::wrapSlow):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::wrapSlow):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::wrapSlow):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::V8TestEventTarget::wrapSlow):
* bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::V8TestException::wrapSlow):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::wrapSlow):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::wrapSlow):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructor::wrapSlow):
* bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::wrapSlow):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::wrapSlow):
* bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore::V8TestOverloadedConstructors::wrapSlow):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):
* bindings/v8/V8Binding.cpp:
* bindings/v8/V8Binding.h:
(WebCore):
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::instantiateV8Object):
* bindings/v8/V8DOMWrapper.h:
(V8DOMWrapper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134360 268f45cc-cd09-0410-ab3c-d52691b4dbfc