WebKit-https.git
7 years agofast/forms/range/input-appearance-range-rtl.html off by one pixel
tony@chromium.org [Wed, 17 Oct 2012 22:33:29 +0000 (22:33 +0000)]
fast/forms/range/input-appearance-range-rtl.html off by one pixel
https://bugs.webkit.org/show_bug.cgi?id=99625

Reviewed by Ojan Vafai.

Source/WebCore:

Previously, we would assume that a vertical slider in RTL would render identically to
a vertical slider in LTR. Due to differing thumb sizes, there is an off by one.

This worked in deprecated flexbox because it doesn't adjust for RTL when applying
box-align: center.

Tests: fast/forms/range/input-appearance-range-rtl.html

* html/shadow/SliderThumbElement.cpp:
(WebCore::RenderSliderContainer::layout): Force LTR for flexbox layout when vertical. We have to restore the old value
just in case the user switches from vertical to horizontal.

LayoutTests:

Run test on GTK+ and Qt now that it is fixed.

* platform/gtk/TestExpectations:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCreating a String from an NSString should check for all 8 bit strings
msaboff@apple.com [Wed, 17 Oct 2012 22:17:49 +0000 (22:17 +0000)]
Creating a String from an NSString should check for all 8 bit strings
https://bugs.webkit.org/show_bug.cgi?id=99392

Reviewed by Geoffrey Garen.

Source/WebCore:

Use CFStringGetBytes() to try to get Latin1 data to create an 8 bit string.

No functional change, change covered by existing tests.

* platform/text/mac/StringMac.mm:
(WTF::String::String):

Source/WTF:

Exported the LChar* version of create().

* wtf/text/StringImpl.cpp:
(WTF::StringImpl::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoStringImpl::findIgnoringCase() and reverseFindIgnoringCase() don't optimally handle...
msaboff@apple.com [Wed, 17 Oct 2012 22:16:12 +0000 (22:16 +0000)]
StringImpl::findIgnoringCase() and reverseFindIgnoringCase() don't optimally handle a mix of 8 and 16 bit strings
https://bugs.webkit.org/show_bug.cgi?id=99224

Reviewed by Geoffrey Garen.

Added helper templated functions and all four combinations similar to find() and reverseFind().

(WTF::findIgnoringCaseInner):
(WTF::StringImpl::findIgnoringCase):
(WTF::reverseFindIgnoringCaseInner):
(WTF::StringImpl::reverseFindIgnoringCase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Memory leak in ewk_download_job_response_set()
commit-queue@webkit.org [Wed, 17 Oct 2012 22:14:41 +0000 (22:14 +0000)]
[EFL][WK2] Memory leak in ewk_download_job_response_set()
https://bugs.webkit.org/show_bug.cgi?id=99621

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-17
Reviewed by Kenneth Rohde Christiansen.

No longer call ewk_url_response_ref() on the response
object in ewk_download_job_response_set() since it will
be ref'd when assigning to the RefPtr member already.

* UIProcess/API/efl/ewk_context_download_client.cpp:
(didReceiveResponse):
* UIProcess/API/efl/ewk_download_job.cpp:
(ewk_download_job_response_set):
* UIProcess/API/efl/ewk_download_job_private.h: Remove several unimplemented functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Compilation warning in Ewk_View when accelerated compositing is disabled
commit-queue@webkit.org [Wed, 17 Oct 2012 22:08:21 +0000 (22:08 +0000)]
[EFL][WK2] Compilation warning in Ewk_View when accelerated compositing is disabled
https://bugs.webkit.org/show_bug.cgi?id=99613

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-17
Reviewed by Kenneth Rohde Christiansen.

Fix compilation warning in _ewk_view_smart_calculate() when
the ACCELERATED_COMPOSITING flag is not set.

* UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_smart_calculate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAtomicString::HashAndUTF8CharactersTranslator::equal() doesn't optimally handle 8...
msaboff@apple.com [Wed, 17 Oct 2012 22:08:20 +0000 (22:08 +0000)]
AtomicString::HashAndUTF8CharactersTranslator::equal() doesn't optimally handle 8 bit strings
https://bugs.webkit.org/show_bug.cgi?id=99223

Reviewed by Geoffrey Garen.

Added an 8 bit path.

* wtf/text/AtomicString.cpp:
(WTF::HashAndUTF8CharactersTranslator::equal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRename PerfTestRunner.runPerSecond to PerfTestRunner.measureRunsPerSecond for consistency
rniwa@webkit.org [Wed, 17 Oct 2012 22:06:52 +0000 (22:06 +0000)]
Rename PerfTestRunner.runPerSecond to PerfTestRunner.measureRunsPerSecond for consistency
https://bugs.webkit.org/show_bug.cgi?id=99642

Reviewed by Dirk Pranke.

Renamed the method.

* Bindings/append-child.html:
* Bindings/create-element.html:
* Bindings/event-target-wrapper.html:
* Bindings/first-child.html:
* Bindings/get-attribute.html:
* Bindings/get-element-by-id.html:
* Bindings/get-elements-by-tag-name.html:
* Bindings/id-getter.html:
* Bindings/id-setter.html:
* Bindings/insert-before.html:
* Bindings/node-list-access.html:
* Bindings/scroll-top.html:
* Bindings/set-attribute.html:
* Bindings/typed-array-construct-from-array.html:
* Bindings/typed-array-construct-from-same-type.html:
* Bindings/typed-array-construct-from-typed.html:
* Bindings/typed-array-set-from-typed.html:
* Bindings/undefined-first-child.html:
* Bindings/undefined-get-element-by-id.html:
* Bindings/undefined-id-getter.html:
* CSS/CSSPropertySetterGetter.html:
* CSS/CSSPropertyUpdateValue.html:
* CSS/PseudoClassSelectors.html:
* DOM/textarea-dom.html:
* DOM/textarea-edit.html:
* Interactive/resources/window-resize.js:
* Layout/flexbox-column-nowrap.html:
* Layout/flexbox-column-wrap.html:
* Layout/flexbox-row-nowrap.html:
* Layout/flexbox-row-wrap.html:
* Layout/line-layout.html:
* Parser/css-parser-yui.html:
* Parser/innerHTML-setter.html:
* Parser/query-selector-deep.html:
* Parser/query-selector-first.html:
* Parser/query-selector-last.html:
* Parser/simple-url.html:
* Parser/textarea-parsing.html:
* Parser/tiny-innerHTML.html:
* Parser/url-parser.html:
* Parser/xml-parser.html:
* SVG/SvgNestedUse.html:
* resources/runner.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Use smart pointers inside Ewk_View
commit-queue@webkit.org [Wed, 17 Oct 2012 22:04:47 +0000 (22:04 +0000)]
[EFL][WK2] Use smart pointers inside Ewk_View
https://bugs.webkit.org/show_bug.cgi?id=99611

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-17
Reviewed by Kenneth Rohde Christiansen.

Use smart pointers instead of raw ones for several
Ewk_View members to avoid handling memory manually.

* PlatformEfl.cmake:
* UIProcess/API/efl/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_Ewk_View_Private_Data::_Ewk_View_Private_Data):
(_Ewk_View_Private_Data::~_Ewk_View_Private_Data):
(ewk_view_cursor_set):
(ewk_view_color_picker_dismiss):
(ewk_view_color_picker_color_set):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCommitting new files is so overrated.
oliver@apple.com [Wed, 17 Oct 2012 21:57:40 +0000 (21:57 +0000)]
Committing new files is so overrated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoStringPrototype::jsSpliceSubstringsWithSeparators() doesn't optimally handle 8 bit...
msaboff@apple.com [Wed, 17 Oct 2012 21:54:43 +0000 (21:54 +0000)]
StringPrototype::jsSpliceSubstringsWithSeparators() doesn't optimally handle 8 bit strings
https://bugs.webkit.org/show_bug.cgi?id=99230

Reviewed by Geoffrey Garen.

Added code to select characters8() or characters16() on the not all 8 bit path for both the
processing of the source and the separators.

* runtime/StringPrototype.cpp:
(JSC::jsSpliceSubstringsWithSeparators):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, Qt baselines for shadow DOM changes to RenderSlider.
tony@chromium.org [Wed, 17 Oct 2012 21:49:01 +0000 (21:49 +0000)]
Unreviewed, Qt baselines for shadow DOM changes to RenderSlider.
There are a couple unexplained failures that I'm still investigating.

* platform/chromium-mac/fast/dom/HTMLInputElement/input-slider-update-expected.txt: Removed.
* platform/chromium-mac/fast/forms/range/range-thumb-height-percentage-expected.txt: Removed.
* platform/chromium-mac/fast/forms/range/slider-padding-expected.txt: Removed.
* platform/chromium-mac/fast/repaint/slider-thumb-drag-release-expected.txt: Removed.
* platform/qt/TestExpectations:
* platform/qt/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
* platform/qt/fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt: Added.
* platform/qt/fast/forms/box-shadow-override-expected.txt:
* platform/qt/fast/forms/range/input-appearance-range-expected.txt:
* platform/qt/fast/forms/range/range-thumb-height-percentage-expected.txt:
* platform/qt/fast/forms/range/slider-padding-expected.txt:
* platform/qt/fast/multicol/client-rects-expected.txt:
* platform/qt/fast/repaint/slider-thumb-drag-release-expected.txt:
* platform/qt/fast/repaint/slider-thumb-float-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoArray and object allocations via 'new Object' or 'new Array' should be inlined in...
fpizlo@apple.com [Wed, 17 Oct 2012 21:48:03 +0000 (21:48 +0000)]
Array and object allocations via 'new Object' or 'new Array' should be inlined in bytecode to allow allocation site profiling
https://bugs.webkit.org/show_bug.cgi?id=99557

Reviewed by Geoffrey Garen.

Removed an inaccurate and misleading comment as per Geoff's review. (I forgot
to make this change as part of http://trac.webkit.org/changeset/131644).

* bytecompiler/NodesCodegen.cpp:
(JSC::FunctionCallResolveNode::emitBytecode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBytecode should not have responsibility for determining how to perform non-local...
oliver@apple.com [Wed, 17 Oct 2012 21:42:43 +0000 (21:42 +0000)]
Bytecode should not have responsibility for determining how to perform non-local resolves
https://bugs.webkit.org/show_bug.cgi?id=99349

Reviewed by Gavin Barraclough.

This patch removes lexical analysis from the bytecode generation.  This allows
us to delay lookup of a non-local variables until the lookup is actually necessary,
and simplifies a lot of the resolve logic in BytecodeGenerator.

Once a lookup is performed we cache the lookup information in a set of out-of-line
buffers in CodeBlock.  This allows subsequent lookups to avoid unnecessary hashing,
etc, and allows the respective JITs to recreated optimal lookup code.

This is currently still a performance regression in LLInt, but most of the remaining
regression is caused by a lot of indirection that I'll remove in future work, as well
as some work necessary to allow LLInt to perform in line instruction repatching.
We will also want to improve the behaviour of the baseline JIT for some of the lookup
operations, however this patch was getting quite large already so I'm landing it now
that we've reached the bar of "performance-neutral".

* GNUmakefile.list.am:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::printStructures):
(JSC::CodeBlock::dump):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::visitStructures):
(JSC):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::shrinkToFit):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::addResolve):
(JSC::CodeBlock::addPutToBase):
(CodeBlock):
(JSC::CodeBlock::resolveOperations):
(JSC::CodeBlock::putToBaseOperation):
(JSC::CodeBlock::numberOfResolveOperations):
(JSC::CodeBlock::numberOfPutToBaseOperations):
(JSC::CodeBlock::addPropertyAccessInstruction):
(JSC::CodeBlock::globalObjectConstant):
(JSC::CodeBlock::setGlobalObjectConstant):
* bytecode/GlobalResolveInfo.h: Removed.
* bytecode/Opcode.h:
(JSC):
(JSC::padOpcodeName):
* bytecode/ResolveGlobalStatus.cpp:
(JSC::computeForStructure):
(JSC::ResolveGlobalStatus::computeFor):
* bytecode/ResolveGlobalStatus.h:
(JSC):
(ResolveGlobalStatus):
* bytecode/ResolveOperation.h: Added.
  The new types and logic we use to perform the cached lookups.
(JSC):
(ResolveOperation):
(JSC::ResolveOperation::getAndReturnScopedVar):
(JSC::ResolveOperation::checkForDynamicEntriesBeforeGlobalScope):
(JSC::ResolveOperation::getAndReturnGlobalVar):
(JSC::ResolveOperation::getAndReturnGlobalProperty):
(JSC::ResolveOperation::resolveFail):
(JSC::ResolveOperation::skipTopScopeNode):
(JSC::ResolveOperation::skipScopes):
(JSC::ResolveOperation::returnGlobalObjectAsBase):
(JSC::ResolveOperation::setBaseToGlobal):
(JSC::ResolveOperation::setBaseToUndefined):
(JSC::ResolveOperation::setBaseToScope):
(JSC::ResolveOperation::returnScopeAsBase):
(JSC::PutToBaseOperation::PutToBaseOperation):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::ResolveResult::checkValidity):
(JSC):
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::resolve):
(JSC::BytecodeGenerator::resolveConstDecl):
(JSC::BytecodeGenerator::shouldAvoidResolveGlobal):
(JSC::BytecodeGenerator::emitResolve):
(JSC::BytecodeGenerator::emitResolveBase):
(JSC::BytecodeGenerator::emitResolveBaseForPut):
(JSC::BytecodeGenerator::emitResolveWithBaseForPut):
(JSC::BytecodeGenerator::emitResolveWithThis):
(JSC::BytecodeGenerator::emitGetLocalVar):
(JSC::BytecodeGenerator::emitInitGlobalConst):
(JSC::BytecodeGenerator::emitPutToBase):
* bytecompiler/BytecodeGenerator.h:
(JSC::ResolveResult::registerResolve):
(JSC::ResolveResult::dynamicResolve):
(ResolveResult):
(JSC::ResolveResult::ResolveResult):
(JSC):
(NonlocalResolveInfo):
(JSC::NonlocalResolveInfo::NonlocalResolveInfo):
(JSC::NonlocalResolveInfo::~NonlocalResolveInfo):
(JSC::NonlocalResolveInfo::resolved):
(JSC::NonlocalResolveInfo::put):
(BytecodeGenerator):
(JSC::BytecodeGenerator::getResolveOperations):
(JSC::BytecodeGenerator::getResolveWithThisOperations):
(JSC::BytecodeGenerator::getResolveBaseOperations):
(JSC::BytecodeGenerator::getResolveBaseForPutOperations):
(JSC::BytecodeGenerator::getResolveWithBaseForPutOperations):
(JSC::BytecodeGenerator::getPutToBaseOperation):
* bytecompiler/NodesCodegen.cpp:
(JSC::ResolveNode::isPure):
(JSC::FunctionCallResolveNode::emitBytecode):
(JSC::PostfixNode::emitResolve):
(JSC::PrefixNode::emitResolve):
(JSC::ReadModifyResolveNode::emitBytecode):
(JSC::AssignResolveNode::emitBytecode):
(JSC::ConstDeclNode::emitCodeSingle):
(JSC::ForInNode::emitBytecode):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGByteCodeParser.cpp:
(ByteCodeParser):
(InlineStackEntry):
(JSC::DFG::ByteCodeParser::handleGetByOffset):
(DFG):
(JSC::DFG::ByteCodeParser::parseResolveOperations):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
* dfg/DFGCapabilities.h:
(JSC::DFG::canCompileResolveOperations):
(DFG):
(JSC::DFG::canCompilePutToBaseOperation):
(JSC::DFG::canCompileOpcode):
(JSC::DFG::canInlineOpcode):
* dfg/DFGGraph.h:
(ResolveGlobalData):
(ResolveOperationData):
(DFG):
(PutToBaseOperationData):
(Graph):
* dfg/DFGNode.h:
(JSC::DFG::Node::hasIdentifier):
(JSC::DFG::Node::resolveOperationsDataIndex):
(Node):
* dfg/DFGNodeType.h:
(DFG):
* dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::OSRExit):
* dfg/DFGOSRExit.h:
(OSRExit):
* dfg/DFGOSRExitCompiler.cpp:
* dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
* dfg/DFGRepatch.cpp:
(JSC::DFG::tryCacheGetByID):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::convertLastOSRExitToForward):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::resolveOperations):
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::putToBaseOperation):
(JSC::DFG::SpeculativeJIT::callOperation):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGStructureCheckHoistingPhase.cpp:
(JSC::DFG::StructureCheckHoistingPhase::run):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
* jit/JIT.h:
(JIT):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_put_to_base):
(JSC):
(JSC::JIT::emit_resolve_operations):
(JSC::JIT::emitSlow_link_resolve_operations):
(JSC::JIT::emit_op_resolve):
(JSC::JIT::emitSlow_op_resolve):
(JSC::JIT::emit_op_resolve_base):
(JSC::JIT::emitSlow_op_resolve_base):
(JSC::JIT::emit_op_resolve_with_base):
(JSC::JIT::emitSlow_op_resolve_with_base):
(JSC::JIT::emit_op_resolve_with_this):
(JSC::JIT::emitSlow_op_resolve_with_this):
(JSC::JIT::emitSlow_op_put_to_base):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_put_to_base):
(JSC):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_init_global_const):
(JSC::JIT::emit_op_init_global_const_check):
(JSC::JIT::emitSlow_op_init_global_const_check):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_init_global_const):
(JSC::JIT::emit_op_init_global_const_check):
(JSC::JIT::emitSlow_op_init_global_const_check):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
(JSC):
* jit/JITStubs.h:
* llint/LLIntSlowPaths.cpp:
(LLInt):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
* llint/LLIntSlowPaths.h:
(LLInt):
* llint/LowLevelInterpreter.asm:
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:
* runtime/JSScope.cpp:
(JSC::LookupResult::base):
(JSC::LookupResult::value):
(JSC::LookupResult::setBase):
(JSC::LookupResult::setValue):
(LookupResult):
(JSC):
(JSC::setPutPropertyAccessOffset):
(JSC::executeResolveOperations):
(JSC::JSScope::resolveContainingScopeInternal):
(JSC::JSScope::resolveContainingScope):
(JSC::JSScope::resolve):
(JSC::JSScope::resolveBase):
(JSC::JSScope::resolveWithBase):
(JSC::JSScope::resolveWithThis):
(JSC::JSScope::resolvePut):
(JSC::JSScope::resolveGlobal):
* runtime/JSScope.h:
(JSScope):
* runtime/JSVariableObject.cpp:
(JSC):
* runtime/JSVariableObject.h:
(JSVariableObject):
* runtime/Structure.h:
(JSC::Structure::propertyAccessesAreCacheable):
(Structure):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoArray and object allocations via 'new Object' or 'new Array' should be inlined in...
fpizlo@apple.com [Wed, 17 Oct 2012 21:39:11 +0000 (21:39 +0000)]
Array and object allocations via 'new Object' or 'new Array' should be inlined in bytecode to allow allocation site profiling
https://bugs.webkit.org/show_bug.cgi?id=99557

Reviewed by Geoffrey Garen.

This uses the old jneq_ptr trick to allow for the bytecode to "see" that the
operation in question is what we almost certainly know it to be.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
* bytecode/Opcode.h:
(JSC):
(JSC::padOpcodeName):
* bytecode/SpecialPointer.h:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitCallEval):
(JSC::BytecodeGenerator::expectedFunctionForIdentifier):
(JSC):
(JSC::BytecodeGenerator::emitExpectedFunctionSnippet):
(JSC::BytecodeGenerator::emitConstruct):
* bytecompiler/BytecodeGenerator.h:
(BytecodeGenerator):
* bytecompiler/NodesCodegen.cpp:
(JSC::NewExprNode::emitBytecode):
(JSC::FunctionCallValueNode::emitBytecode):
(JSC::FunctionCallResolveNode::emitBytecode):
(JSC::FunctionCallBracketNode::emitBytecode):
(JSC::FunctionCallDotNode::emitBytecode):
(JSC::CallFunctionCallDotNode::emitBytecode):
(JSC::ApplyFunctionCallDotNode::emitBytecode):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
* jit/JIT.h:
(JIT):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_new_array_with_size):
(JSC):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
(JSC):
* jit/JITStubs.h:
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(LLInt):
* llint/LLIntSlowPaths.h:
(LLInt):
* llint/LowLevelInterpreter.asm:
* runtime/ArrayConstructor.cpp:
(JSC::constructArrayWithSizeQuirk):
(JSC):
* runtime/ArrayConstructor.h:
(JSC):
* runtime/CommonIdentifiers.h:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
(JSC):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, Apple Mac baselines for shadow DOM changes to RenderSlider.
tony@chromium.org [Wed, 17 Oct 2012 21:24:50 +0000 (21:24 +0000)]
Unreviewed, Apple Mac baselines for shadow DOM changes to RenderSlider.

* platform/mac/TestExpectations:
* platform/mac/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
* platform/mac/fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt: Added.
* platform/mac/fast/forms/box-shadow-override-expected.txt:
* platform/mac/fast/forms/range/input-appearance-range-expected.txt:
* platform/mac/fast/forms/range/range-thumb-height-percentage-expected.txt:
* platform/mac/fast/forms/range/slider-padding-expected.txt:
* platform/mac/fast/forms/range/slider-thumb-shared-style-expected.txt:
* platform/mac/fast/forms/range/slider-thumb-stylability-expected.txt: Added.
* platform/mac/fast/multicol/client-rects-expected.txt:
* platform/mac/fast/repaint/slider-thumb-drag-release-expected.txt:
* platform/mac/fast/repaint/slider-thumb-float-expected.txt: Added.
* platform/mac/media/audio-controls-rendering-expected.txt:
* platform/mac/media/controls-after-reload-expected.txt:
* platform/mac/media/controls-strict-expected.txt:
* platform/mac/media/controls-styling-strict-expected.txt:
* platform/mac/media/video-controls-rendering-expected.txt:
* platform/mac/media/video-display-toggle-expected.txt:
* platform/mac/media/video-no-audio-expected.txt:
* platform/mac/media/video-playing-and-pause-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoJIT op_get_by_pname should call cti_get_by_val_generic and not cti_get_by_val
fpizlo@apple.com [Wed, 17 Oct 2012 21:12:52 +0000 (21:12 +0000)]
JIT op_get_by_pname should call cti_get_by_val_generic and not cti_get_by_val
https://bugs.webkit.org/show_bug.cgi?id=99631
<rdar://problem/12483221>

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

cti_get_by_val assumes that the return address has patching metadata associated with it, which won't
be true for op_get_by_pname. cti_get_by_val_generic makes no such assumptions.

* jit/JITPropertyAccess.cpp:
(JSC::JIT::emitSlow_op_get_by_pname):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emitSlow_op_get_by_pname):

LayoutTests:

* fast/js/get-by-pname-that-looks-like-a-patchable-get-by-val-expected.txt: Added.
* fast/js/get-by-pname-that-looks-like-a-patchable-get-by-val.html: Added.
* fast/js/jsc-test-list:
* fast/js/script-tests/get-by-pname-that-looks-like-a-patchable-get-by-val.js: Added.
(foo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, second set of GTK+ baselines for shadow DOM changes to RenderSlider.
tony@chromium.org [Wed, 17 Oct 2012 21:10:33 +0000 (21:10 +0000)]
Unreviewed, second set of GTK+ baselines for shadow DOM changes to RenderSlider.

* platform/gtk/TestExpectations:
* platform/gtk/media/audio-controls-rendering-expected.txt:
* platform/gtk/media/audio-repaint-expected.txt:
* platform/gtk/media/controls-after-reload-expected.txt:
* platform/gtk/media/controls-strict-expected.txt:
* platform/gtk/media/controls-styling-expected.txt:
* platform/gtk/media/controls-styling-strict-expected.txt:
* platform/gtk/media/controls-without-preload-expected.txt:
* platform/gtk/media/media-controls-clone-expected.txt:
* platform/gtk/media/media-document-audio-repaint-expected.txt:
* platform/gtk/media/track/track-cue-rendering-horizontal-expected.txt:
* platform/gtk/media/track/track-cue-rendering-vertical-expected.txt:
* platform/gtk/media/video-controls-rendering-expected.txt:
* platform/gtk/media/video-display-toggle-expected.txt:
* platform/gtk/media/video-empty-source-expected.txt:
* platform/gtk/media/video-no-audio-expected.txt:
* platform/gtk/media/video-playing-and-pause-expected.txt:
* platform/gtk/media/video-zoom-controls-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoInteger overflows/underflows in all Gamepad controller api calls.
commit-queue@webkit.org [Wed, 17 Oct 2012 21:09:45 +0000 (21:09 +0000)]
Integer overflows/underflows in all Gamepad controller api calls.
https://bugs.webkit.org/show_bug.cgi?id=97262

Patch by Scott Graham <scottmg@chromium.org> on 2012-10-17
Reviewed by Abhishek Arya.

Tools:

Range check controller inputs. This code is not exposed to the web,
but makes fuzzers try less hard to break uninteresting code.

* DumpRenderTree/chromium/TestRunner/GamepadController.cpp:
(GamepadController::setButtonCount):
(GamepadController::setButtonData):
(GamepadController::setAxisCount):
(GamepadController::setAxisData):

LayoutTests:

* gamepad/gamepad-out-of-range-crasher.html: Added.
* gamepad/gamepad-out-of-range-crasher-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, Chromium baselines for shadow DOM changes to RenderSlider.
tony@chromium.org [Wed, 17 Oct 2012 21:01:18 +0000 (21:01 +0000)]
Unreviewed, Chromium baselines for shadow DOM changes to RenderSlider.

* platform/chromium-linux-x86/fast/multicol/client-rects-expected.txt: Removed.
* platform/chromium-linux/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png:
* platform/chromium-mac-snowleopard/fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt.
* platform/chromium-mac-snowleopard/fast/forms/box-shadow-override-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/datalist/input-appearance-range-with-datalist-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-appearance-height-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/range/slider-thumb-stylability-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/range/slider-thumb-stylability-expected.txt.
* platform/chromium-mac-snowleopard/fast/repaint/slider-thumb-float-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/repaint/slider-thumb-float-expected.txt.
* platform/chromium-mac/fast/dom/HTMLInputElement/input-slider-update-expected.txt: Added.
* platform/chromium-mac/fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt.
* platform/chromium-mac/fast/forms/box-shadow-override-expected.png:
* platform/chromium-mac/fast/forms/box-shadow-override-expected.txt:
* platform/chromium-mac/fast/forms/datalist/input-appearance-range-with-datalist-expected.png:
* platform/chromium-mac/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png:
* platform/chromium-mac/fast/forms/input-appearance-height-expected.png:
* platform/chromium-mac/fast/forms/input-appearance-height-expected.txt:
* platform/chromium-mac/fast/forms/range/input-appearance-range-expected.txt:
* platform/chromium-mac/fast/forms/range/range-thumb-height-percentage-expected.txt: Added.
* platform/chromium-mac/fast/forms/range/slider-padding-expected.txt: Added.
* platform/chromium-mac/fast/forms/range/slider-thumb-shared-style-expected.txt: Added.
* platform/chromium-mac/fast/forms/range/slider-thumb-stylability-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/range/slider-thumb-stylability-expected.txt.
* platform/chromium-mac/fast/hidpi/video-controls-in-hidpi-expected.txt:
* platform/chromium-mac/fast/layers/video-layer-expected.txt:
* platform/chromium-mac/fast/multicol/client-rects-expected.txt:
* platform/chromium-mac/fast/repaint/slider-thumb-drag-release-expected.txt: Added.
* platform/chromium-mac/fast/repaint/slider-thumb-float-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/repaint/slider-thumb-float-expected.txt.
* platform/chromium-mac/media/audio-controls-rendering-expected.txt:
* platform/chromium-mac/media/audio-repaint-expected.txt:
* platform/chromium-mac/media/controls-after-reload-expected.txt:
* platform/chromium-mac/media/controls-strict-expected.txt:
* platform/chromium-mac/media/controls-styling-expected.txt:
* platform/chromium-mac/media/controls-styling-strict-expected.txt:
* platform/chromium-mac/media/controls-without-preload-expected.txt:
* platform/chromium-mac/media/media-controls-clone-expected.txt:
* platform/chromium-mac/media/media-document-audio-repaint-expected.txt:
* platform/chromium-mac/media/track/track-cue-rendering-horizontal-expected.txt:
* platform/chromium-mac/media/track/track-cue-rendering-vertical-expected.txt:
* platform/chromium-mac/media/video-controls-rendering-expected.txt:
* platform/chromium-mac/media/video-display-toggle-expected.txt:
* platform/chromium-mac/media/video-empty-source-expected.txt:
* platform/chromium-mac/media/video-no-audio-expected.txt:
* platform/chromium-mac/media/video-playing-and-pause-expected.txt:
* platform/chromium-mac/media/video-zoom-controls-expected.txt:
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/hidpi/video-controls-in-hidpi-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/hidpi/video-controls-in-hidpi-expected.txt.
* platform/chromium-win-xp/fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt.
* platform/chromium-win-xp/fast/forms/datalist/input-appearance-range-with-datalist-expected.png: Removed.
* platform/chromium-win-xp/fast/forms/range/slider-thumb-stylability-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/range/slider-thumb-stylability-expected.txt.
* platform/chromium-win-xp/fast/repaint/slider-thumb-float-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/repaint/slider-thumb-float-expected.txt.
* platform/chromium-win/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
* platform/chromium-win/fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt:
* platform/chromium-win/fast/forms/box-shadow-override-expected.txt:
* platform/chromium-win/fast/forms/datalist/input-appearance-range-with-datalist-expected.png:
* platform/chromium-win/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png:
* platform/chromium-win/fast/forms/input-appearance-height-expected.txt:
* platform/chromium-win/fast/forms/range/input-appearance-range-expected.png:
* platform/chromium-win/fast/forms/range/input-appearance-range-expected.txt:
* platform/chromium-win/fast/forms/range/range-thumb-height-percentage-expected.txt:
* platform/chromium-win/fast/forms/range/slider-padding-expected.txt:
* platform/chromium-win/fast/forms/range/slider-thumb-shared-style-expected.txt:
* platform/chromium-win/fast/forms/range/slider-thumb-stylability-expected.txt:
* platform/chromium-win/fast/hidpi/video-controls-in-hidpi-expected.txt:
* platform/chromium-win/fast/multicol/client-rects-expected.txt:
* platform/chromium-win/fast/repaint/slider-thumb-drag-release-expected.txt:
* platform/chromium-win/fast/repaint/slider-thumb-float-expected.txt:
* platform/chromium-win/media/track/track-cue-rendering-vertical-expected.txt:
* platform/chromium-win/platform/chromium/virtual/gpu/fast/hidpi/video-controls-in-hidpi-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/hidpi/video-controls-in-hidpi-expected.txt.
* platform/chromium/TestExpectations:
* platform/mac-lion/media/audio-repaint-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPerformance test should support asynchronous tests
rniwa@webkit.org [Wed, 17 Oct 2012 20:57:46 +0000 (20:57 +0000)]
Performance test should support asynchronous tests
https://bugs.webkit.org/show_bug.cgi?id=95668

Reviewed by Dirk Pranke.

Added PerfTestRunner.prepareToMeasureValuesAsync and PerfTestRunner.measureValueAsync,
and deployed it in Animation/balls.

* Animation/balls.html:
* resources/runner.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening, mark inspector/styles/styles-history.html as flaky on Linux.
danakj@chromium.org [Wed, 17 Oct 2012 20:36:31 +0000 (20:36 +0000)]
Unreviewed gardening, mark inspector/styles/styles-history.html as flaky on Linux.
https://bugs.webkit.org/show_bug.cgi?id=99519

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, first set of GTK+ baselines for shadow DOM changes to RenderSlider.
tony@chromium.org [Wed, 17 Oct 2012 20:25:17 +0000 (20:25 +0000)]
Unreviewed, first set of GTK+ baselines for shadow DOM changes to RenderSlider.

* fast/forms/range/slider-thumb-stylability-expected.txt: Renamed from LayoutTests/platform/efl/fast/forms/range/slider-thumb-stylability-expected.txt.
* platform/chromium-mac-snowleopard/fast/hidpi/video-controls-in-hidpi-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/multicol/client-rects-expected.txt: Removed.
* platform/chromium-win-xp/fast/multicol/client-rects-expected.txt: Removed.
* platform/gtk/TestExpectations:
* platform/gtk/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
* platform/gtk/fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt: Added.
* platform/gtk/fast/forms/box-shadow-override-expected.txt:
* platform/gtk/fast/forms/input-appearance-height-expected.txt:
* platform/gtk/fast/forms/range/input-appearance-range-expected.txt:
* platform/gtk/fast/forms/range/range-thumb-height-percentage-expected.txt: Added.
* platform/gtk/fast/forms/range/slider-padding-expected.txt:
* platform/gtk/fast/forms/range/slider-thumb-shared-style-expected.txt:
* platform/gtk/fast/forms/range/slider-thumb-stylability-expected.png: Removed.
* platform/gtk/fast/forms/range/slider-thumb-stylability-expected.txt:
* platform/gtk/fast/hidpi/video-controls-in-hidpi-expected.txt:
* platform/gtk/fast/layers/video-layer-expected.txt:
* platform/gtk/fast/multicol/client-rects-expected.txt:
* platform/gtk/fast/repaint/slider-thumb-drag-release-expected.txt:
* platform/gtk/fast/repaint/slider-thumb-float-expected.txt: Added.
* platform/mac/fast/forms/range/slider-thumb-stylability-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline some windows tests now that the bot is providing results in the right...
danakj@chromium.org [Wed, 17 Oct 2012 20:24:10 +0000 (20:24 +0000)]
Rebaseline some windows tests now that the bot is providing results in the right place.

Unreviewed gardening.

* platform/chromium-win-xp/css1/basic/inheritance-expected.png: Removed.
* platform/chromium-win-xp/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.png: Removed.
* platform/chromium-win-xp/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.png: Removed.
* platform/chromium-win-xp/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Removed.
* platform/chromium-win-xp/tables/mozilla/bugs/bug73321-expected.png: Removed.
* platform/chromium-win/css1/basic/inheritance-expected.png:
* platform/chromium-win/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.png:
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug73321-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Remove redundant OpenGL library addition from the build system.
rakuco@webkit.org [Wed, 17 Oct 2012 20:22:59 +0000 (20:22 +0000)]
[EFL] Remove redundant OpenGL library addition from the build system.
https://bugs.webkit.org/show_bug.cgi?id=99629

Reviewed by Rob Buis.

* PlatformEfl.cmake: Do not add OPENGL_gl_LIBRARY to
WebCore_LIBRARIES, this is already done in CMakeLists.txt these
days.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CMake] Set WebCore_LIBRARIES earlier.
rakuco@webkit.org [Wed, 17 Oct 2012 20:21:27 +0000 (20:21 +0000)]
[CMake] Set WebCore_LIBRARIES earlier.
https://bugs.webkit.org/show_bug.cgi?id=99630

Reviewed by Rob Buis.

* CMakeLists.txt: Follow the style we use in other CMakeList.txt
files and set the Foo_LIBRARIES variables before we start checking
for optional features, as they might append other libraries to the
list (it already happens with WTF_USE_3D_GRAPHICS, for example).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAllow lazy initialization of SVG XML animated properties.
pdr@google.com [Wed, 17 Oct 2012 20:07:57 +0000 (20:07 +0000)]
Allow lazy initialization of SVG XML animated properties.
https://bugs.webkit.org/show_bug.cgi?id=84657

Reviewed by Tim Horton.

Source/WebCore:

When animating a property in the shadow tree, instance properties and tearoffs are created
but they simply reference the animated element's animating properties.

When starting an animation for the first time (see SVGAnimateElement::resetAnimatedType),
we initialize the root property and instance properties using startAnimValAnimation(...).
If an instance property is added while the root property is animating, this initialization
will not occur and we crash.

This patch updates the resetAnimValToBaseVal codepath to start (and initialize) an animated
property if it is not already animating. After this patch, instance properties can be added
in the middle of animation and they will be properly started/initialized.

Test: svg/animations/use-while-animating-crash.html

* svg/SVGAnimatedTypeAnimator.h:
(WebCore::SVGAnimatedTypeAnimator::resetFromBaseValue):
(WebCore::SVGAnimatedTypeAnimator::resetFromBaseValues):
(WebCore::SVGAnimatedTypeAnimator::executeAction):

LayoutTests:

* platform/mac/svg/animations/use-while-animating-crash-expected.txt: Added.
* svg/animations/use-while-animating-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed watchlist email change.
joepeck@webkit.org [Wed, 17 Oct 2012 19:47:19 +0000 (19:47 +0000)]
Unreviewed watchlist email change.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBind isolatedWorldSecurityOrigin to world
commit-queue@webkit.org [Wed, 17 Oct 2012 19:34:18 +0000 (19:34 +0000)]
Bind isolatedWorldSecurityOrigin to world
https://bugs.webkit.org/show_bug.cgi?id=99582

Patch by Dan Carney <dcarney@google.com> on 2012-10-17
Reviewed by Adam Barth.

Source/WebCore:

Security origin of isolated worlds was not previously set at the world
level, although it could have been.

No new tests. No change in functionality.

* bindings/v8/DOMWrapperWorld.cpp:
(WebCore::DOMWrapperWorld::deallocate):
(WebCore):
(WebCore::isolatedWorldSecurityOrigins):
(WebCore::DOMWrapperWorld::isolatedWorldSecurityOrigin):
(WebCore::DOMWrapperWorld::setIsolatedWorldSecurityOrigin):
(WebCore::DOMWrapperWorld::clearIsolatedWorldSecurityOrigin):
* bindings/v8/DOMWrapperWorld.h:
(DOMWrapperWorld):
(WebCore::DOMWrapperWorld::isIsolatedWorldId):
(WebCore::DOMWrapperWorld::isIsolatedWorld):
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::resetIsolatedWorlds):
(WebCore::ScriptController::evaluateInIsolatedWorld):
(WebCore::ScriptController::collectIsolatedContexts):
* bindings/v8/ScriptController.h:
(ScriptController):
(WebCore::ScriptController::setIsolatedWorldSecurityOrigin):
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::initializeIfNeeded):
* bindings/v8/V8DOMWindowShell.h:
(V8DOMWindowShell):
* bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
(WebCore::V8XMLHttpRequest::constructorCallback):

Tools:

Added ability to unset isolatedWorldSecurityOrigin.

* DumpRenderTree/chromium/DRTTestRunner.cpp:
(DRTTestRunner::setIsolatedWorldSecurityOrigin):

LayoutTests:

Clean up of isolated worlds added after test completion.

* http/tests/security/isolatedWorld/cross-origin-xhr.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Mac] Uninitialized Members in WebDataSourcePrivate
commit-queue@webkit.org [Wed, 17 Oct 2012 19:02:30 +0000 (19:02 +0000)]
[Mac] Uninitialized Members in WebDataSourcePrivate
https://bugs.webkit.org/show_bug.cgi?id=99617

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2012-10-17
Reviewed by David Kilzer.

Initialize BOOL member variables.

* WebView/WebDataSource.mm:
(WebDataSourcePrivate::WebDataSourcePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed watchlist addition.
joepeck@webkit.org [Wed, 17 Oct 2012 18:56:44 +0000 (18:56 +0000)]
Unreviewed watchlist addition.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGraphicsLayer visible rect computation needs to use the current animating transform
simon.fraser@apple.com [Wed, 17 Oct 2012 18:20:31 +0000 (18:20 +0000)]
GraphicsLayer visible rect computation needs to use the current animating transform
https://bugs.webkit.org/show_bug.cgi?id=99529

Reviewed by Dean Jackson.

Source/WebCore:

If we're running an accelerated animation of transform
on a GraphicsLayerCA, the current value of the transform won't
be reflected in the GraphicsLayer's m_transform. However,
we need the current value of the transform in order to correctly
compute the visible rect of this layer and descendants.

Add a function to GraphicsLayerClient to retrieve the current
value of the transform from the client.

RenderLayer's currentTransform() used to return a transform
with transform-origin baked in; GraphicsLayerClient needs one
that excludes transform-origin, so enhance RenderLayer::currentTransform()
to be able to produce either.

Tests: compositing/visible-rect/animated-from-none.html
       compositing/visible-rect/animated.html

* platform/graphics/GraphicsLayerClient.h:
(WebCore):
(GraphicsLayerClient):
(WebCore::GraphicsLayerClient::getCurrentTransform):
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::computeVisibleRect):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::currentTransform):
* rendering/RenderLayer.h:
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::currentTransform):
* rendering/RenderLayerBacking.h:
(RenderLayerBacking):

LayoutTests:

Tests that exercise visible-rect computation on an animating layer.

* compositing/visible-rect/animated-expected.txt: Added.
* compositing/visible-rect/animated-from-none-expected.txt: Added.
* compositing/visible-rect/animated-from-none.html: Added.
* compositing/visible-rect/animated.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoplugins: Allow a plugin to dictate whether it can receive drag events or not.
commit-queue@webkit.org [Wed, 17 Oct 2012 18:18:12 +0000 (18:18 +0000)]
plugins: Allow a plugin to dictate whether it can receive drag events or not.
https://bugs.webkit.org/show_bug.cgi?id=99355

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-10-17
Reviewed by Tony Chang.

Source/WebCore:

When doing a drag over a plugin, ask the plugin whether it can accept
drag/drop to decide whether drag/drop is possible or not. At present,
plugins do not receive drag events through WebCore (i.e. various
implementations of PluginView::handleMouseEvent ignores the
drop-events). This change makes it possible for the ports to ask the
plugin first to decide whether it can (or wants to) accept drag events.
The default implementation remains the same, i.e. plugins do not receive
drag events. For chromium, the overridden implementation uses the
WebPlugin interface to check whether the plugin can accept drag events.

* html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::canProcessDrag):
(WebCore):
* html/HTMLPlugInElement.h:
(WebCore):
(HTMLPlugInElement):
* page/DragController.cpp:
(WebCore::DragController::canProcessDrag):
* plugins/PluginViewBase.h:
(WebCore):
(WebCore::PluginViewBase::canProcessDrag):

Source/WebKit/chromium:

Introduce WebPlugin::canProcessDrag() and use that to implement PluginViewBase::canProcessDrag.

* public/WebPlugin.h:
(WebKit::WebPlugin::canProcessDrag):
(WebPlugin):
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::canProcessDrag):
(WebKit):
(WebKit::WebPluginContainerImpl::handleMouseEvent):
* src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):

Tools:

Update the TestWebPlugin to implement the new |canProcessDrag| interface.

* DumpRenderTree/chromium/TestWebPlugin.h:
(TestWebPlugin::canProcessDrag):

LayoutTests:

Update test to not set contentEditable on the plugin anymore.

* platform/chromium/plugins/drag-events-expected.txt:
* platform/chromium/plugins/drag-events.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Create an accessibility watchlist.
dmazzoni@google.com [Wed, 17 Oct 2012 18:09:55 +0000 (18:09 +0000)]
Unreviewed. Create an accessibility watchlist.

* Scripts/webkitpy/common/config/committers.py:
* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAlways use fastRealloc when growing or shrinking the Vector buffer
andersca@apple.com [Wed, 17 Oct 2012 18:00:11 +0000 (18:00 +0000)]
Always use fastRealloc when growing or shrinking the Vector buffer
https://bugs.webkit.org/show_bug.cgi?id=99616

Reviewed by Andreas Kling.

Remove the pointless #if PLATFORM(BLACKBERRY) and always try to use fastRealloc to grow or shrink the
vector buffer when possible; realloc should always be at least as fast as free+malloc.

* wtf/Vector.h:
(WTF::VectorBufferBase::shouldReallocateBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Prevent focus zoom on non-userscalable pages.
mifenton@rim.com [Wed, 17 Oct 2012 17:55:30 +0000 (17:55 +0000)]
[BlackBerry] Prevent focus zoom on non-userscalable pages.
https://bugs.webkit.org/show_bug.cgi?id=99608

Reviewed by Rob Buis.

PR 222378.

Disable focus zoom when the page is non-user scalable.

Reviewed Internally by Nima Ghanavatian.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Remove legacy members from WebDraggableRegion
jianli@chromium.org [Wed, 17 Oct 2012 17:50:40 +0000 (17:50 +0000)]
[chromium] Remove legacy members from WebDraggableRegion
https://bugs.webkit.org/show_bug.cgi?id=99612

Reviewed by Adam Barth.

Those legacy members to support old syntax are not longer needed after
chromium side changes landed.

* public/WebDraggableRegion.h:
(WebDraggableRegion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoShrink EventTargetData by making firingEventListeners vector optional.
kling@webkit.org [Wed, 17 Oct 2012 17:46:36 +0000 (17:46 +0000)]
Shrink EventTargetData by making firingEventListeners vector optional.
<http://webkit.org/b/99532>
<rdar://problem/12515099>

Reviewed by Anders Carlsson.

The majority of event listeners never actually fire, and EventTargetData::firingEventListeners
is just sitting there taking up space. Make it an OwnPtr instead, shrinking EventTargetData
by 48 bytes and progressing Membuster3 by 395kB.

* dom/EventTarget.cpp:
(WebCore::EventTarget::removeEventListener):
(WebCore::EventTarget::fireEventListeners):
(WebCore::EventTarget::removeAllEventListeners):
* dom/EventTarget.h:
(WebCore::EventTarget::isFiringEventListeners):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBlock freeing thread should sleep indefinitely when there's no work to do
mhahnenberg@apple.com [Wed, 17 Oct 2012 17:30:37 +0000 (17:30 +0000)]
Block freeing thread should sleep indefinitely when there's no work to do
https://bugs.webkit.org/show_bug.cgi?id=98084

Reviewed by Geoffrey Garen.

r130212 didn't fully fix the problem.

* heap/BlockAllocator.cpp:
(JSC::BlockAllocator::blockFreeingThreadMain): We would just continue to the next iteration if
we found that we had zero blocks to copy. We should move the indefinite wait up to where that
check is done so that we properly detect the "no more blocks to copy, wait for more" condition.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoxss-DENIED-xsl-document-securityOrigin.xml crashes with icon assertion
commit-queue@webkit.org [Wed, 17 Oct 2012 17:17:06 +0000 (17:17 +0000)]
xss-DENIED-xsl-document-securityOrigin.xml crashes with icon assertion
https://bugs.webkit.org/show_bug.cgi?id=99571

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-17
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Check that the iconURL is not empty in IconController::continueLoadWithDecision()
to avoid hitting assertions later when trying to commit this empty URL to the
database. IconController::url() may indeed return an empty URL but there was
no check for it.

No new tests, already covered by http/tests/security/xss-DENIED-xsl-document-securityOrigin.xml.

* loader/icon/IconController.cpp:
(WebCore::IconController::continueLoadWithDecision):

LayoutTests:

Unskip http/tests/security/xss-DENIED-xsl-document-securityOrigin.xml
for EFL WebKit2 now that it no longer hits an assertion in
IconDatabase.

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix build warnings : -Wunused-parameter, -Wunused-variable
commit-queue@webkit.org [Wed, 17 Oct 2012 17:15:14 +0000 (17:15 +0000)]
Fix build warnings : -Wunused-parameter, -Wunused-variable
https://bugs.webkit.org/show_bug.cgi?id=99539

Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-10-17
Reviewed by Kentaro Hara.

Fix build warnings about unused parameter or unused variable when
WTF_USE_TILED_BACKING_STORE option is enabled.

Source/WebCore:

* html/shadow/HTMLContentElement.cpp:
(WebCore::contentTagName):
* platform/graphics/efl/GraphicsContext3DEfl.cpp:
(WebCore::GraphicsContext3D::getImageData):
* platform/graphics/efl/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::createSurface):
(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):
* platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::bindVertexArrayOES):
* platform/graphics/texmap/TextureMapper.h:
(WebCore::BitmapTexture::canReuseWith):
(WebCore::TextureMapper::beginPainting):
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::drawRepaintCounter):
* platform/graphics/texmap/TextureMapperImageBuffer.cpp:
(WebCore::BitmapTextureImageBuffer::updateContents):
* platform/graphics/texmap/TextureMapperImageBuffer.h:
* platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::sortByZOrder):
(WebCore::TextureMapperLayer::flushCompositingStateSelf):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::allowsIndependentlyCompositedFrames):

Source/WebKit/efl:

* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::attachRootGraphicsLayer):
(WebCore::ChromeClientEfl::delegatedScrollRequested):

Source/WebKit2:

* UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp:
(WebKit::CoordinatedBackingStore::paintToTextureMapper):
* UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
(WebKit::LayerTreeRenderer::createLayer):
* UIProcess/DrawingAreaProxy.cpp:
(WebKit::DrawingAreaProxy::didReceiveLayerTreeCoordinatorProxyMessage):
* UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::setVisibleContentsRect):
(WebKit::DrawingAreaProxy::createTileForLayer):
(WebKit::DrawingAreaProxy::updateTileForLayer):
(WebKit::DrawingAreaProxy::removeTileForLayer):
(WebKit::DrawingAreaProxy::update):
(WebKit::DrawingAreaProxy::didUpdateBackingStoreState):
(WebKit::DrawingAreaProxy::enterAcceleratedCompositingMode):
(WebKit::DrawingAreaProxy::exitAcceleratedCompositingMode):
(WebKit::DrawingAreaProxy::updateAcceleratedCompositingMode):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::tiledBackingStorePaintEnd):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedTile.cpp:
(WebKit::CoordinatedTile::paint):
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::scrollNonCompositedContents):
(WebKit::LayerTreeCoordinator::notifyAnimationStarted):
* WebProcess/WebPage/LayerTreeHost.h:
(WebKit::LayerTreeHost::setVisibleContentsRect):
(WebKit::LayerTreeHost::setVisibleContentsRectForLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] IndexedDB: Delete obsolete public API method
jsbell@chromium.org [Wed, 17 Oct 2012 17:10:48 +0000 (17:10 +0000)]
[Chromium] IndexedDB: Delete obsolete public API method
https://bugs.webkit.org/show_bug.cgi?id=99603

Reviewed by Dimitri Glazkov.

Remove a stub that was necessary while the Chromium side of webkit.org/b/99097 was landing.

* public/WebIDBTransactionCallbacks.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDynamically added elements do not get re-projected.
shinyak@chromium.org [Wed, 17 Oct 2012 17:07:39 +0000 (17:07 +0000)]
Dynamically added elements do not get re-projected.
https://bugs.webkit.org/show_bug.cgi?id=99227

Reviewed by Dimitri Glazkov.

Source/WebCore:

When distribution happens, we have to invalidate its host shadow's distribution, since the children of the host
is changed.

Test: fast/dom/shadow/content-reprojection-dynamic.html

* html/shadow/ContentDistributor.cpp:
(WebCore::ContentDistributor::distribute):

LayoutTests:

* fast/dom/shadow/content-reprojection-dynamic-expected.html: Added.
* fast/dom/shadow/content-reprojection-dynamic.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLayout Test http/tests/workers/text-encoding.html is flaky crashing on debug bots
danakj@chromium.org [Wed, 17 Oct 2012 16:55:08 +0000 (16:55 +0000)]
Layout Test http/tests/workers/text-encoding.html is flaky crashing on debug bots
https://bugs.webkit.org/show_bug.cgi?id=99604

Unreviewed gardening.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[gyp] fix bundle resources for DumpRenderTree on mac
jochen@chromium.org [Wed, 17 Oct 2012 16:55:02 +0000 (16:55 +0000)]
[gyp] fix bundle resources for DumpRenderTree on mac
https://bugs.webkit.org/show_bug.cgi?id=99558

Reviewed by Adam Barth.

mac_bundle_resources doesn't propagate to targets that depend on it,
so I'm wrapping it in an all_dependent_settings block.

* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: no "delete watch expression" context menu item when clicking on the...
yurys@chromium.org [Wed, 17 Oct 2012 16:38:59 +0000 (16:38 +0000)]
Web Inspector: no "delete watch expression" context menu item when clicking on the expression value
https://bugs.webkit.org/show_bug.cgi?id=99602

Reviewed by Pavel Feldman.

Add delete items to the watch expression's value's context menu.

* inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement.prototype._contextMenuFired):
(WebInspector.ObjectPropertyTreeElement.prototype.populateContextMenu):
* inspector/front-end/WatchExpressionsSidebarPane.js:
(WebInspector.WatchExpressionTreeElement.prototype.populateContextMenu):
(WebInspector.WatchExpressionTreeElement.prototype._contextMenu):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed inspector test fixed and skipped on JSC.
vsevik@chromium.org [Wed, 17 Oct 2012 16:32:29 +0000 (16:32 +0000)]
Unreviewed inspector test fixed and skipped on JSC.

* inspector/debugger/live-edit-breakpoints-expected.txt:
* inspector/debugger/live-edit-breakpoints.html:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:
* platform/win/TestExpectations:
* platform/wincairo/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Exclusions] Additional simple polygon tests
commit-queue@webkit.org [Wed, 17 Oct 2012 16:27:06 +0000 (16:27 +0000)]
[CSS Exclusions] Additional simple polygon tests
https://bugs.webkit.org/show_bug.cgi?id=98548

Patch by Hans Muller <hmuller@adobe.com> on 2012-10-17
Reviewed by Dirk Schulze.

Added a pair of CSS Exclusions shape-inside ref-tests for regular polygons
with 8 and 16 sides. Also made some small revisions to the supporting code,
simple-polyon.js, and the existing simple polygon tests, and to localize and
correct the conversion from float to layout coordinates. All of the tests
now round/truncate the left edge of line segment intervals depending on whether
subpixel layout is enabled.

* fast/exclusions/resources/simple-polygon.js:
(createRegularPolygonVertices):
(polygonXIntercepts):
(simulatePolygonShape):
(generateSimulatedPolygonShapeInsideElement):
(createPolygonShapeInsideTestCase):
(createPolygonShapeInsideTestCaseExpected):
* fast/exclusions/shape-inside/shape-inside-regular-polygon16-expected.html: Added.
* fast/exclusions/shape-inside/shape-inside-regular-polygon16.html: Added.
* fast/exclusions/shape-inside/shape-inside-regular-polygon8-expected.html: Added.
* fast/exclusions/shape-inside/shape-inside-regular-polygon8.html: Added.
* fast/exclusions/shape-inside/shape-inside-simple-polygon-001-expected.html:
* fast/exclusions/shape-inside/shape-inside-simple-polygon-001.html:
* fast/exclusions/shape-inside/shape-inside-simple-polygon-002-expected.html:
* fast/exclusions/shape-inside/shape-inside-simple-polygon-002.html:
* fast/exclusions/shape-inside/shape-inside-simple-polygon-003-expected.html:
* fast/exclusions/shape-inside/shape-inside-simple-polygon-003.html:
* fast/exclusions/shape-inside/shape-inside-simple-polygon-004-expected.html:
* fast/exclusions/shape-inside/shape-inside-simple-polygon-004.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd myself to the MediaStream watchlist
commit-queue@webkit.org [Wed, 17 Oct 2012 16:09:10 +0000 (16:09 +0000)]
Add myself to the MediaStream watchlist
https://bugs.webkit.org/show_bug.cgi?id=99589

Patch by Harald Alvestrand <hta@google.com> on 2012-10-17
Reviewed by Adam Barth.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Don't use the C API internally in WebKitDownload
carlosgc@webkit.org [Wed, 17 Oct 2012 16:00:27 +0000 (16:00 +0000)]
[GTK] Don't use the C API internally in WebKitDownload
https://bugs.webkit.org/show_bug.cgi?id=96773

Reviewed by Gustavo Noronha Silva.

Using the C++ classes directly instead of the C API wrappers we
avoid a lot of toImpl/toAPI casts, string conversions and
allocations. The code is also a lot simpler and easier to read.

* UIProcess/API/gtk/WebKitDownload.cpp:
(_WebKitDownloadPrivate):
(webkitDownloadCreate):
(webkit_download_get_request):
(webkit_download_cancel):
* UIProcess/API/gtk/WebKitDownloadPrivate.h:
* UIProcess/API/gtk/WebKitWebContext.cpp:
(webkit_web_context_download_uri):
(webkitWebContextGetOrCreateDownload):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Don't use the C API internally in WebKitCookieManager
carlosgc@webkit.org [Wed, 17 Oct 2012 15:56:29 +0000 (15:56 +0000)]
[GTK] Don't use the C API internally in WebKitCookieManager
https://bugs.webkit.org/show_bug.cgi?id=96772

Reviewed by Gustavo Noronha Silva.

Using the C++ classes directly instead of the C API wrappers we
avoid a lot of toImpl/toAPI casts, string conversions and
allocations. The code is also a lot simpler and easier to read.

* UIProcess/API/gtk/WebKitCookieManager.cpp:
(_WebKitCookieManagerPrivate):
(webkitCookieManagerFinalize):
(webkitCookieManagerCreate):
(webkit_cookie_manager_set_persistent_storage):
(webkit_cookie_manager_set_accept_policy):
(webkit_cookie_manager_get_accept_policy):
(webkitCookieManagerGetDomainsWithCookiesCallback):
(webkit_cookie_manager_get_domains_with_cookies):
(webkit_cookie_manager_delete_cookies_for_domain):
(webkit_cookie_manager_delete_all_cookies):
* UIProcess/API/gtk/WebKitCookieManagerPrivate.h:
* UIProcess/API/gtk/WebKitWebContext.cpp:
(webkit_web_context_get_cookie_manager):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Don't use the C API internally in WebKitContextMenu
carlosgc@webkit.org [Wed, 17 Oct 2012 15:52:17 +0000 (15:52 +0000)]
[GTK] Don't use the C API internally in WebKitContextMenu
https://bugs.webkit.org/show_bug.cgi?id=96770

Reviewed by Gustavo Noronha Silva.

Using the C++ classes directly instead of the C API wrappers we
avoid a lot of toImpl/toAPI casts, string conversions and
allocations. The code is also a lot simpler and easier to read.

* UIProcess/API/gtk/WebKitContextMenu.cpp:
(webkitContextMenuCreate):
* UIProcess/API/gtk/WebKitContextMenuItem.cpp:
(webkitContextMenuItemCreate):
* UIProcess/API/gtk/WebKitContextMenuItemPrivate.h:
* UIProcess/API/gtk/WebKitContextMenuPrivate.h:
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewPopulateContextMenu):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Don't use the C API internally in WebKitBackForwardList
carlosgc@webkit.org [Wed, 17 Oct 2012 15:47:48 +0000 (15:47 +0000)]
[GTK] Don't use the C API internally in WebKitBackForwardList
https://bugs.webkit.org/show_bug.cgi?id=96769

Reviewed by Gustavo Noronha Silva.

Using the C++ classes directly instead of the C API wrappers we
avoid a lot of toImpl/toAPI casts, string conversions and
allocations. The code is also a lot simpler and easier to read.

* UIProcess/API/gtk/WebKitBackForwardList.cpp:
(_WebKitBackForwardListPrivate):
(webkitBackForwardListGetOrCreateItem):
(webkitBackForwardListCreateList):
(webkitBackForwardListCreate):
(webkitBackForwardListChanged):
(webkit_back_forward_list_get_current_item):
(webkit_back_forward_list_get_back_item):
(webkit_back_forward_list_get_forward_item):
(webkit_back_forward_list_get_nth_item):
(webkit_back_forward_list_get_length):
(webkit_back_forward_list_get_back_list):
(webkit_back_forward_list_get_back_list_with_limit):
(webkit_back_forward_list_get_forward_list):
(webkit_back_forward_list_get_forward_list_with_limit):
* UIProcess/API/gtk/WebKitBackForwardListItem.cpp:
(_WebKitBackForwardListItemPrivate):
(webkitBackForwardListItemFinalized):
(webkitBackForwardListItemGetOrCreate):
(webkitBackForwardListItemGetItem):
(webkit_back_forward_list_item_get_uri):
(webkit_back_forward_list_item_get_title):
(webkit_back_forward_list_item_get_original_uri):
* UIProcess/API/gtk/WebKitBackForwardListPrivate.h:
* UIProcess/API/gtk/WebKitLoaderClient.cpp:
(didChangeBackForwardList):
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewConstructed):
(webkit_web_view_go_to_back_forward_list_item):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Regression] Undoing script changes does not restore breakpoints.
vsevik@chromium.org [Wed, 17 Oct 2012 15:38:51 +0000 (15:38 +0000)]
Web Inspector: [Regression] Undoing script changes does not restore breakpoints.
https://bugs.webkit.org/show_bug.cgi?id=99598

Reviewed by Pavel Feldman.

Source/WebCore:

workingCopyChanged now dispatches did/willMergeToVM instead of did/willDivergeFromVM
when change returns uiSourceCode to non dirty state.
Added wasDirty parameter to workingCopyChanged event.

Test: inspector/debugger/live-edit-breakpoints.html

* inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptFile.prototype._workingCopyCommitted):
(WebInspector.ResourceScriptFile.prototype._workingCopyChanged):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.setWorkingCopy):

LayoutTests:

* http/tests/inspector/live-edit-test.js:
(initialize_LiveEditTest.InspectorTest.replaceInSource):
(initialize_LiveEditTest.InspectorTest.commitSource):
(initialize_LiveEditTest.InspectorTest.undoSourceEditing):
(initialize_LiveEditTest):
* inspector/debugger/live-edit-breakpoints-expected.txt: Added.
* inspector/debugger/live-edit-breakpoints.html: Added.
* inspector/debugger/live-edit.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Don't use the C API internally in WebKitURISchemeRequest
carlosgc@webkit.org [Wed, 17 Oct 2012 15:37:33 +0000 (15:37 +0000)]
[GTK] Don't use the C API internally in WebKitURISchemeRequest
https://bugs.webkit.org/show_bug.cgi?id=96787

Reviewed by Gustavo Noronha Silva.

Using the C++ classes directly instead of the C API wrappers we
avoid a lot of toImpl/toAPI casts, string conversions and
allocations. The code is also a lot simpler and easier to read.

* UIProcess/API/gtk/WebKitRequestManagerClient.cpp:
(didReceiveURIRequest):
* UIProcess/API/gtk/WebKitURISchemeRequest.cpp:
(_WebKitURISchemeRequestPrivate):
(webkitURISchemeRequestCreate):
(webkit_uri_scheme_request_get_web_view):
(webkitURISchemeRequestReadCallback):
* UIProcess/API/gtk/WebKitURISchemeRequestPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Make sure the favicon database path is set only once
commit-queue@webkit.org [Wed, 17 Oct 2012 15:36:06 +0000 (15:36 +0000)]
[EFL][WK2] Make sure the favicon database path is set only once
https://bugs.webkit.org/show_bug.cgi?id=99597

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-17
Reviewed by Kenneth Rohde Christiansen.

Make sure the icon database path is set only once by checking
that the database is not already open before settign the path.
This avoids printing error message on stderr.

* UIProcess/API/efl/ewk_context.cpp:
(ewk_context_favicon_database_get):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed rebaseline for ietestcenter/css3/bordersbackgrounds/border-radius-content...
danakj@chromium.org [Wed, 17 Oct 2012 15:35:59 +0000 (15:35 +0000)]
Unreviewed rebaseline for ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001.htm

* platform/chromium-win-xp/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Don't use the C API internally in WebKitWebInspector
carlosgc@webkit.org [Wed, 17 Oct 2012 15:31:45 +0000 (15:31 +0000)]
[GTK] Don't use the C API internally in WebKitWebInspector
https://bugs.webkit.org/show_bug.cgi?id=96786

Reviewed by Gustavo Noronha Silva.

Using the C++ classes directly instead of the C API wrappers we
avoid a lot of toImpl/toAPI casts, string conversions and
allocations. The code is also a lot simpler and easier to read.

* UIProcess/API/gtk/WebKitWebInspector.cpp:
(_WebKitWebInspectorPrivate):
(webkitWebInspectorFinalize):
(webkitWebInspectorCreate):
(webkit_web_inspector_get_web_view):
(webkit_web_inspector_is_attached):
(webkit_web_inspector_attach):
(webkit_web_inspector_detach):
(webkit_web_inspector_show):
(webkit_web_inspector_close):
(webkit_web_inspector_get_attached_height):
* UIProcess/API/gtk/WebKitWebInspectorPrivate.h:
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_get_inspector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] accessibility/ignore-spacer-elements.html is failing
commit-queue@webkit.org [Wed, 17 Oct 2012 15:30:16 +0000 (15:30 +0000)]
[GTK] accessibility/ignore-spacer-elements.html is failing
https://bugs.webkit.org/show_bug.cgi?id=98366

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-10-17
Reviewed by Chris Fleizach.

The failure was due to platform-specific expectations of childrenCount.
The solution was conditionalizing the test.

* accessibility/ignore-spacer-elements.html: Base expected childrenCount on platform.
* platform/gtk/TestExpectations: Unskip previously-failing test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Don't use the C API internally in WebKitGeolocation classes
carlosgc@webkit.org [Wed, 17 Oct 2012 15:24:20 +0000 (15:24 +0000)]
[GTK] Don't use the C API internally in WebKitGeolocation classes
https://bugs.webkit.org/show_bug.cgi?id=96778

Reviewed by Gustavo Noronha Silva.

Using the C++ classes directly instead of the C API wrappers we
avoid a lot of toImpl/toAPI casts, string conversions and
allocations. The code is also a lot simpler and easier to read.

* UIProcess/API/gtk/WebKitGeolocationPermissionRequest.cpp:
(_WebKitGeolocationPermissionRequestPrivate):
(webkitGeolocationPermissionRequestAllow):
(webkitGeolocationPermissionRequestDeny):
(webkitGeolocationPermissionRequestFinalize):
(webkitGeolocationPermissionRequestCreate):
* UIProcess/API/gtk/WebKitGeolocationPermissionRequestPrivate.h:
* UIProcess/API/gtk/WebKitGeolocationProvider.cpp:
(WebKitGeolocationProvider::create):
(WebKitGeolocationProvider::WebKitGeolocationProvider):
(WebKitGeolocationProvider::notifyPositionChanged):
(WebKitGeolocationProvider::notifyErrorOccurred):
* UIProcess/API/gtk/WebKitGeolocationProvider.h:
(WebKitGeolocationProvider):
* UIProcess/API/gtk/WebKitUIClient.cpp:
(decidePolicyForGeolocationPermissionRequest):
* UIProcess/API/gtk/WebKitWebContext.cpp:
(createDefaultWebContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening.
commit-queue@webkit.org [Wed, 17 Oct 2012 15:07:46 +0000 (15:07 +0000)]
Unreviewed EFL gardening.
https://bugs.webkit.org/show_bug.cgi?id=99596

Unskip editing/inserting, editing/selection, editing/spelling and editing/style categories.
Mark missing text expectations for these.

Patch by Mariusz Grzegorczyk <mariusz.g@samsung.com> on 2012-10-17

* platform/efl-wk1/TestExpectations:
* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Avoid re-creating CSSGrammar.cpp with each (incremental) build
hausmann@webkit.org [Wed, 17 Oct 2012 15:01:03 +0000 (15:01 +0000)]
[Qt] Avoid re-creating CSSGrammar.cpp with each (incremental) build

Reviewed by Tor Arne Vestbø.

The expected output is CSSGrammar.cpp and the input file used to be CSSGrammar.y,
so ${QMAKE_FILE_BASE}.cpp did the correct transformation. Recently the input has
changed to CSSGrammar.y.in, in which case the ${QMAKE_FILE_BASE} is CSSGrammar.y
unfortunately. The resulting target CSSGrammar.y.cpp will never be created and
therefore the target will always run.

* DerivedSources.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed fix for ImageSourceCG.
loislo@chromium.org [Wed, 17 Oct 2012 14:43:26 +0000 (14:43 +0000)]
Unreviewed fix for ImageSourceCG.

* platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::reportMemoryUsage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed fix for compilation on CG bots.
loislo@chromium.org [Wed, 17 Oct 2012 14:36:35 +0000 (14:36 +0000)]
Unreviewed fix for compilation on CG bots.

* platform/graphics/cg/ImageSourceCG.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: NMI instrument ImageDecoder. It owns a buffer that could be quite...
loislo@chromium.org [Wed, 17 Oct 2012 14:26:12 +0000 (14:26 +0000)]
Web Inspector: NMI instrument ImageDecoder. It owns a buffer that could be quite big.
https://bugs.webkit.org/show_bug.cgi?id=99540

Reviewed by Yury Semikhatsky.

* platform/graphics/ImageSource.cpp:
(WebCore::ImageSource::reportMemoryUsage):
(WebCore):
* platform/graphics/ImageSource.h:
(ImageSource):
* platform/image-decoders/ImageDecoder.cpp:
(WebCore::ImageFrame::reportMemoryUsage):
(WebCore):
(WebCore::ImageDecoder::reportMemoryUsage):
* platform/image-decoders/ImageDecoder.h:
(ImageFrame):
(ImageDecoder):
* platform/image-decoders/skia/ImageDecoderSkia.cpp:
(WebCore::ImageFrame::reportMemoryUsage):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix build on Mac OSX 10.6 and earlier.
commit-queue@webkit.org [Wed, 17 Oct 2012 14:16:40 +0000 (14:16 +0000)]
[Qt] Fix build on Mac OSX 10.6 and earlier.
https://bugs.webkit.org/show_bug.cgi?id=99595

Patch by Zeno Albisser <zeno@webkit.org> on 2012-10-17
Reviewed by Simon Hausmann.

* Target.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: display "disconnected" message when remote debugging terminates
pfeldman@chromium.org [Wed, 17 Oct 2012 12:48:53 +0000 (12:48 +0000)]
Web Inspector: display "disconnected" message when remote debugging terminates
https://bugs.webkit.org/show_bug.cgi?id=99316

Reviewed by Yury Semikhatsky.

Otherwise, it is not clear that the front-end is no longer functional.

* inspector/front-end/InspectorFrontendHostStub.js:
(WebInspector.RemoteDebuggingTerminatedScreen):
* inspector/front-end/inspector.js:
(WebInspector.loaded.WebInspector.socket.onclose):
(WebInspector.loaded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2][WTR] InjectedBundlePage::decidePolicyForNavigationAction() should print only...
commit-queue@webkit.org [Wed, 17 Oct 2012 12:23:07 +0000 (12:23 +0000)]
[WK2][WTR] InjectedBundlePage::decidePolicyForNavigationAction() should print only filename part of local URLs
https://bugs.webkit.org/show_bug.cgi?id=99581

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-17
Reviewed by Kenneth Rohde Christiansen.

Tools:

Now InjectedBundlePage::decidePolicyForNavigationAction() prints only filename part of local URLs (URLs where scheme
equals to 'file').

* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::decidePolicyForNavigationAction):

LayoutTests:

Unskipped fast/loader/reload-policy-delegate.html for WK2.

* platform/wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2][EFL] Add unit tests for Spelling
g.czajkowski@samsung.com [Wed, 17 Oct 2012 12:06:44 +0000 (12:06 +0000)]
[WK2][EFL] Add unit tests for Spelling
https://bugs.webkit.org/show_bug.cgi?id=95956

Reviewed by Gyuyoung Kim.

Add the unit tests which covers API from ewk_text_checker.h
and text checker settings from ewk_settings.h

* PlatformEfl.cmake:
* UIProcess/API/efl/tests/resources/spelling_test.html: Added.
* UIProcess/API/efl/tests/test_ewk2_text_checker.cpp: Added.
(resetCallbacksExecutionStats):
(onTimeout):
(onSettingChange):
(onSpellDocumentTag):
(onSpellDocumentTagClose):
(onSpellingCheck):
(onWordGuesses):
(onWordLearn):
(onWordIgnore):
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2][GTK] Favicons are incorrectly released before receiving the actual data
mario@webkit.org [Wed, 17 Oct 2012 11:54:15 +0000 (11:54 +0000)]
[WK2][GTK] Favicons are incorrectly released before receiving the actual data
https://bugs.webkit.org/show_bug.cgi?id=99492

Reviewed by Carlos Garcia Campos.

Don't release the icon for a page URL in the first stage of the
asynchronous call webkit_favicon_database_get_favicon() but do it
later instead, to avoid a race condition with the initial
synchronization process the first time we request an icon which is
actually in the icon database, but has not made available yet.

* UIProcess/API/gtk/WebKitFaviconDatabase.cpp:
(GetFaviconSurfaceAsyncData::~GetFaviconSurfaceAsyncData): Release
here the icon for the page URL if not a valid icon has been found.
(GetFaviconSurfaceAsyncData): Add a new boolean parameter to flag
when a given icon for a page URL should be released.
(getIconSurfaceSynchronously): Don't release the icon, just return 0.
(processPendingIconsForPageURL): If a valid icon is got at this
point, disable the flag shouldReleaseIconForPageURL not to release
the icon later on.
(webkit_favicon_database_get_favicon): Make sure we retain the
icon for a given page URL before trying to retrieve it from the
IconDatabase, and that we flag it to be released in case not a
valid icon has been found yet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: delete watch expression button overlaps with the expression value
yurys@chromium.org [Wed, 17 Oct 2012 11:50:25 +0000 (11:50 +0000)]
Web Inspector: delete watch expression button overlaps with the expression value
https://bugs.webkit.org/show_bug.cgi?id=99569

Reviewed by Vsevolod Vlasov.

Delete watch expression button now doesn't overlap with the watch expression.

* inspector/front-end/inspector.css:
(.properties-tree.watch-expressions > li > .value):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove handling of CSSPropertyPointerEvents from StyleResolver into StyleBuilder.
macpherson@chromium.org [Wed, 17 Oct 2012 11:30:23 +0000 (11:30 +0000)]
Move handling of CSSPropertyPointerEvents from StyleResolver into StyleBuilder.
https://bugs.webkit.org/show_bug.cgi?id=99536

Reviewed by Alexis Menard.

One small step towards removing the giant switch statement in StyleResolver,
this patch moves pointer event property into StyleBuilder.

Covered by fast/events/pointer-events.html and fast/events/pointer-events-2.html.

* css/StyleBuilder.cpp:
(WebCore::StyleBuilder::StyleBuilder):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLocalized date should be based on LDML
keishi@webkit.org [Wed, 17 Oct 2012 11:28:39 +0000 (11:28 +0000)]
Localized date should be based on LDML
https://bugs.webkit.org/show_bug.cgi?id=99570

Reviewed by Kent Tamura.

Source/WebCore:

Localized date should be based on LDML to match the format inside DateTimeEditElement.

No new tests. Covered by LocaleMacTest.formatDate and LocaleWinTest.formatDate.

* platform/text/LocaleICU.cpp: Removed formatDateTime.
* platform/text/LocaleICU.h:
(LocaleICU):
* platform/text/LocaleNone.cpp: Removed formatDateTime.
(LocaleNone):
* platform/text/LocaleWin.cpp: Removed formatDateTime and formatDate.
(WebCore):
* platform/text/LocaleWin.h:
(LocaleWin):
* platform/text/Localizer.cpp:
(WebCore::DateTimeStringBuilder::visitField): Added support for year/month/day.
(WebCore::Localizer::formatDateTime): Creates the formatted string based on the format from dateFormat().
* platform/text/Localizer.h:
* platform/text/mac/LocaleMac.h:
(LocaleMac):
* platform/text/mac/LocaleMac.mm: Removed formatDateTime.

Source/WebKit/chromium:

* tests/LocaleMacTest.cpp:
(TEST_F): Updated expectations.
* tests/LocaleWinTest.cpp:
(TEST_F): Updated expectations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImplement the Selector argument to RTCPeerConnection.getStats
commit-queue@webkit.org [Wed, 17 Oct 2012 11:15:07 +0000 (11:15 +0000)]
Implement the Selector argument to RTCPeerConnection.getStats
https://bugs.webkit.org/show_bug.cgi?id=99460

Patch by Harald Alvestrand <hta@google.com> on 2012-10-17
Reviewed by Adam Barth.

Source/Platform:

* chromium/public/WebRTCStatsRequest.h:
(WebKit):
(WebRTCStatsRequest):

Source/WebCore:

The change adds two new parameters to the RTCStatsRequest object:
stream and component. Together these are enough to identify a
MediaStreamTrack.

Test: fast/mediastream/RTCPeerConnection-statsSelector.html

* Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::streamDescriptor):
(WebCore):
* Modules/mediastream/MediaStreamTrack.h:
* Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::getStats):
* Modules/mediastream/RTCStatsRequestImpl.cpp:
(WebCore::RTCStatsRequestImpl::create):
(WebCore::RTCStatsRequestImpl::RTCStatsRequestImpl):
(WebCore::RTCStatsRequestImpl::hasSelector):
(WebCore):
(WebCore::RTCStatsRequestImpl::stream):
(WebCore::RTCStatsRequestImpl::component):
* Modules/mediastream/RTCStatsRequestImpl.h:
(RTCStatsRequestImpl):
* platform/chromium/support/WebRTCStatsRequest.cpp:
(WebKit):
(WebKit::WebRTCStatsRequest::hasSelector):
(WebKit::WebRTCStatsRequest::stream):
(WebKit::WebRTCStatsRequest::component):
* platform/mediastream/RTCStatsRequest.h:
(WebCore):
(RTCStatsRequest):

Tools:

The MockWebRTCPeerConnectionHandler will return one object only
when it gets a selector, and an even number when there is no selector.
This allows to verify that the argument is passed, but not its value.

* DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
(MockWebRTCPeerConnectionHandler::getStats):

LayoutTests:

* fast/mediastream/RTCPeerConnection-statsSelector-expected.txt: Added.
* fast/mediastream/RTCPeerConnection-statsSelector.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebKitTestRunner needs layoutTestController.queueReload
commit-queue@webkit.org [Wed, 17 Oct 2012 11:07:13 +0000 (11:07 +0000)]
WebKitTestRunner needs layoutTestController.queueReload
https://bugs.webkit.org/show_bug.cgi?id=42672

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-17
Reviewed by Kenneth Rohde Christiansen.

Tools:

Added implementation of testRunner.queueReload().

* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::queueReload):
(WTR):
* WebKitTestRunner/InjectedBundle/InjectedBundle.h:
(InjectedBundle):
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::queueReload):
(WTR):
* WebKitTestRunner/InjectedBundle/TestRunner.h:
(TestRunner):
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
* WebKitTestRunner/WorkQueueManager.cpp:
(WTR::WorkQueueManager::queueReload):
(WTR):
* WebKitTestRunner/WorkQueueManager.h:
(WorkQueueManager):

LayoutTests:

Unskipped the related test cases for WK2.

* platform/efl-wk2/TestExpectations:
* platform/wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Enable use of more AllInOne files
commit-queue@webkit.org [Wed, 17 Oct 2012 10:46:48 +0000 (10:46 +0000)]
[Qt] Enable use of more AllInOne files
https://bugs.webkit.org/show_bug.cgi?id=99579

Patch by Simon Hausmann <simon.hausmann@digia.com> on 2012-10-17
Reviewed by Tor Arne Vestbø.

The AllInOne files reduce pressure during final link time because the object files contain less duplicated
symbols.

* Target.pri: Add HTMLElementsAllInOne, EditingAllInOne and RenderingAllInOne to the build
* editing/EditingAllInOne.cpp: Place a #if USE(CF) around the inclusion of SmartReplaceCF.cpp
* html/HTMLElementsAllInOne.cpp: Move HTMLPlugInElement.cpp to the top to fix builds on X11 based platforms
where the X headers get confused by the "Region" type that's also declared in WebCore.
* rendering/RenderingAllInOne.cpp: Fix build on case-sensitive file systems (Plugin -> PlugIn) and added a
#if PLATFORM(WIN) around the inclusion of RenderThemeWin.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r131421): Text baseline becomes incorrect after re-layout of input[type...
tkent@chromium.org [Wed, 17 Oct 2012 10:40:10 +0000 (10:40 +0000)]
REGRESSION(r131421): Text baseline becomes incorrect after re-layout of input[type=time]
https://bugs.webkit.org/show_bug.cgi?id=99572

Reviewed by Kentaro Hara.

Source/WebCore:

We use flexible box since r131421, and it seems text baseline becomes
incorrect if there are text nodes in a flex container.

Test: fast/forms/time-multiple-fields/time-multiple-fields-static-relayout.html

* css/html.css:
(input::-webkit-datetime-edit-text): Added.
* html/shadow/DateTimeEditElement.cpp:
(WebCore::DateTimeEditBuilder::visitLiteral):
Wrap text with an element with ::-webkit-datetime-edit-text.

LayoutTests:

* fast/forms/time-multiple-fields/time-multiple-fields-static-relayout-expected.txt: Added.
* fast/forms/time-multiple-fields/time-multiple-fields-static-relayout.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Wed, 17 Oct 2012 10:34:09 +0000 (10:34 +0000)]
Unreviewed GTK gardening.

Fixing expectation for fast/forms/range/input-appearance-range-rtl.html,
it's a reftest so the failure is actually of pixel nature.

Also removing some expectations for tests that now consistently pass.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago.: [WK2][EFL] Implementation of spellchecking feature.
commit-queue@webkit.org [Wed, 17 Oct 2012 10:30:52 +0000 (10:30 +0000)]
.: [WK2][EFL] Implementation of spellchecking feature.
https://bugs.webkit.org/show_bug.cgi?id=91854

Patch by Grzegorz Czajkowski  <g.czajkowski@samsung.com>, Michal Roj <m.roj@sasmung.com> on 2012-10-17
Reviewed by Gyuyoung Kim.

Define SPELLCHECK macro and enable it for WK2-Efl.
The spellchecking implementation is based on the Enchant library.
It can be used by other WebKit ports.

* Source/cmake/FindEnchant.cmake: Added.
* Source/cmake/OptionsEfl.cmake: Enable spellchecking feature for WebKit2-EFL.
* Source/cmake/WebKitFeatures.cmake: Define the SPELLCHECK macro.
* Source/cmakeconfig.h.cmake: Add the feature.

Source/WebCore: [WK2][EFL] Implementation of spellchecking feature.
https://bugs.webkit.org/show_bug.cgi?id=91854

Patch by Grzegorz Czajkowski  <g.czajkowski@samsung.com>, Michal Roj <m.roj@samsung.com> on 2012-10-17
Reviewed by Gyuyoung Kim.

* PlatformEfl.cmake:
Add enchant-related compiler flags: header paths and the library flag.

Source/WebKit2: Implementation of spellchecking feature.
https://bugs.webkit.org/show_bug.cgi?id=91854

Patch by Grzegorz Czajkowski  <g.czajkowski@samsung.com>, Michal Roj <m.roj@samsung.com> on 2012-10-17
Reviewed by Gyuyoung Kim.

Add spelling implementation for WebKit2-EFL that is based on Enchant library.

Additionally the patch provides API to overwrite the default WebKit
spellchecker implementation as Enchant library doesn't ensure grammar checking.
Application is able to overwrite it by defining its own implementation and
setting appropriate callback functions.

* PlatformEfl.cmake:
Add enchant-related compiler flags: header paths and the library flag.

* UIProcess/API/efl/EWebKit2.h:
Add ewk_text_checker.h to the main WebKit2-EFL's header to be available for applications.

* UIProcess/API/efl/WebKitTextChecker.cpp: Added.
Implement the callbacks functions of WKTextChecker.

(WebKit):
(WebKit::isContinuousSpellCheckingEnabled):
(WebKit::setContinuousSpellCheckingEnabled):
(WebKit::uniqueSpellDocumentTag):
(WebKit::closeSpellDocumentWithTag):
(WebKit::checkSpellingOfString):
(WebKit::guessesForWord):
(WebKit::learnWord):
(WebKit::ignoreWord):
Those functions are directly given as callback functions for WKTextChecker's client.
They choose between WebKit's spelling implementation and client's ones.

(WebKit::availableSpellCheckingLanguages):
(WebKit::updateSpellCheckingLanguages):
(WebKit::loadedSpellCheckingLanguages):
They are used by ewk_settings.cpp file and allow to do not
expose 'textCheckerEnchant'.

* UIProcess/API/efl/WebKitTextChecker.h: Added.
Define the functions which choose between WebKit's spelling implementation and
the client's ones.

(WebKit):
* UIProcess/API/efl/ewk_context.cpp:
(_Ewk_Context::_Ewk_Context):
Attach the spellchecker feature for the context.

* UIProcess/API/efl/ewk_text_checker.cpp: Added.
(ewk_text_checker_callbacks_get):
An internal function to get the client's callback functions.

* UIProcess/API/efl/ewk_text_checker.h: Added.
Define API to set the client's own spelling implementation.

* UIProcess/API/efl/ewk_text_checker_private.h: Added.
(_Ewk_Text_Checker):
Define the struct with the client's callbacks responisble for spelling.

* UIProcess/API/efl/ewk_settings.cpp:
(onContinuousSpellCheckingIdler):
The application is notified about the spelling setting change on idler
to do not block WebKit.
The the continuous spell checking may be changed through the context menu option.

(spellCheckingLanguagesSetUpdate):
The dictionaries are requested on 'idler' to do not block WebKit.

(spellCheckingLanguagesSet):
Set the languages.

(ewk_settings_continuous_spell_checking_change_cb_set):
Set the callback function used to notify the client when the spelling
setting was changed by WebKit.

(ewk_settings_continuous_spell_checking_enabled_get):
(ewk_settings_continuous_spell_checking_enabled_set):
API to set/get the continuous spell checking.

(ewk_settings_spell_checking_available_languages_get):
(ewk_settings_spell_checking_languages_set):
(ewk_settings_spell_checking_languages_get):
API to get/set languages to use by WebKit implementation based on Enchant library.

* UIProcess/efl/TextCheckerEfl.cpp:
(WebKit::TextChecker::state):
(WebKit::TextChecker::isContinuousSpellCheckingAllowed):
(WebKit::TextChecker::setContinuousSpellCheckingEnabled):
(WebKit::TextChecker::setGrammarCheckingEnabled):
(WebKit::TextChecker::continuousSpellCheckingEnabledStateChanged):
(WebKit::TextChecker::grammarCheckingEnabledStateChanged):
(WebKit::TextChecker::uniqueSpellDocumentTag):
(WebKit::TextChecker::closeSpellDocumentWithTag):
(WebKit::TextChecker::checkSpellingOfString):
(WebKit::TextChecker::checkGrammarOfString): Remove WebCore namaspace as it's already defined for the whole file.
(WebKit::TextChecker::spellingUIIsShowing):
(WebKit::TextChecker::toggleSpellingUIIsShowing):
(WebKit::TextChecker::updateSpellingUIWithMisspelledWord):
(WebKit::TextChecker::updateSpellingUIWithGrammarString):
(WebKit::TextChecker::getGuessesForWord):
(WebKit::TextChecker::learnWord):
(WebKit::TextChecker::ignoreWord):
Those call WKTextChecker client's methods.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Avoid style updates when retrieving the inline stylesheet text
apavlov@chromium.org [Wed, 17 Oct 2012 10:24:41 +0000 (10:24 +0000)]
Web Inspector: Avoid style updates when retrieving the inline stylesheet text
https://bugs.webkit.org/show_bug.cgi?id=99576

Reviewed by Vsevolod Vlasov.

Avoid using innerText() to retrieve inline stylesheet text, which may result in style and layout updates.

* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::inlineStyleSheetText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix for WinCE after r131365.
paroga@webkit.org [Wed, 17 Oct 2012 10:20:11 +0000 (10:20 +0000)]
Build fix for WinCE after r131365.

* platform/graphics/GlyphBuffer.h:
(WebCore::GlyphBufferAdvance::width):
* platform/graphics/wince/FontWinCE.cpp:
(WebCore::cursorToX):
* platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::GraphicsContext::drawText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Add background color to the checkbox theme.
commit-queue@webkit.org [Wed, 17 Oct 2012 10:08:53 +0000 (10:08 +0000)]
[EFL] Add background color to the checkbox theme.
https://bugs.webkit.org/show_bug.cgi?id=98788

Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-10-17
Reviewed by Gyuyoung Kim.

Background color is added to the checkbox theme for identifying
checkbox status easily.

Checkbox theme uses images which has transparent background, and the
theme itself doesn't have the background color.

When the background of checkbox is black, checked/unchecked status
cannot be distinguished because check mark color is black.

And it is hard to identify whether the checkbox is disabled or not,
because there is no background color in the checkbox theme.

Instead of adding background color to the edc script, background
images are added because the shape of the check box can be various.

* DefaultTheme/widget/check/check.edc:
* DefaultTheme/widget/check/img_check_bg_enabled.png: Added.
* DefaultTheme/widget/check/img_check_bg_disabled.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Ewk_Url_Scheme_Request has to be refactored
commit-queue@webkit.org [Wed, 17 Oct 2012 10:08:37 +0000 (10:08 +0000)]
[EFL][WK2] Ewk_Url_Scheme_Request has to be refactored
https://bugs.webkit.org/show_bug.cgi?id=99549

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-17
Reviewed by Kenneth Rohde Christiansen.

Ewk_Url_Scheme_Requestis inherited from RefCounted, WKEinaSharedString is used,
removed weird _Ewk_Url_Scheme_Request.

* UIProcess/API/efl/ewk_context_private.h:
* UIProcess/API/efl/ewk_context_request_manager_client.cpp:
(didReceiveURIRequest):
* UIProcess/API/efl/ewk_url_scheme_request.cpp:
(ewk_url_scheme_request_ref):
(ewk_url_scheme_request_unref):
* UIProcess/API/efl/ewk_url_scheme_request.h:
* UIProcess/API/efl/ewk_url_scheme_request_private.h:
(Ewk_Url_Scheme_Request):
(Ewk_Url_Scheme_Request::create):
(Ewk_Url_Scheme_Request::Ewk_Url_Scheme_Request):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Unreviewed gardening.
dominik.rottsches@intel.com [Wed, 17 Oct 2012 10:02:56 +0000 (10:02 +0000)]
[EFL] Unreviewed gardening.

Unskipping 4 cases after regression was fixed in r131229,
moving out a crash and incorrect console loggin on the wk2 bot.

* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoV8 should throw a more descriptive exception when blocking 'eval' via CSP.
mkwst@chromium.org [Wed, 17 Oct 2012 10:00:17 +0000 (10:00 +0000)]
V8 should throw a more descriptive exception when blocking 'eval' via CSP.
https://bugs.webkit.org/show_bug.cgi?id=94332

Reviewed by Adam Barth.

Source/WebCore:

Following up on https://bugs.webkit.org/show_bug.cgi?id=94331, this
patch wires up the new error message mechanism to V8, and updates the
Chromium test expectations accordingly.

* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::disableEval):
    Pass 'errorMessage' through to V8.
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::initializeIfNeeded):
    Grab the error message from ContentSecurityPolicy, and pass it
    through to V8.
* bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy):
(WebCore::WorkerContextExecutionProxy::evaluate):
(WebCore::WorkerContextExecutionProxy::setEvalAllowed):
* bindings/v8/WorkerContextExecutionProxy.h:
(WorkerContextExecutionProxy):
    Convert 'm_disableEvalPending' to a string to store the current
    error message, and use it to set the eval state.
* bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::disableEval):
    Pass 'errorMessage' through to V8.

LayoutTests:

* platform/chromium/TestExpectations:
    Unskipping these tests, as this patch unbreaks them.
* platform/chromium/http/tests/security/contentSecurityPolicy/eval-blocked-expected.txt:
* platform/chromium/http/tests/security/contentSecurityPolicy/eval-blocked-in-about-blank-iframe-expected.txt:
* platform/chromium/http/tests/security/contentSecurityPolicy/function-constructor-blocked-expected.txt:
    Updating expectations with the new error message.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAssertion failed on HTMLFormControlElement.cpp: updateFromElementCallback()
morrita@google.com [Wed, 17 Oct 2012 09:57:57 +0000 (09:57 +0000)]
Assertion failed on HTMLFormControlElement.cpp: updateFromElementCallback()
https://bugs.webkit.org/show_bug.cgi?id=99566

Reviewed by Kent Tamura.

Source/WebCore:

It had a too optimistic assertion. This change removes it.

Test: fast/forms/textarea/textarea-autofocus-removal-while-focusing.html

* html/HTMLFormControlElement.cpp:
(WebCore::updateFromElementCallback):

LayoutTests:

* fast/forms/textarea/textarea-autofocus-removal-while-focusing.txt: Added.
* fast/forms/textarea/textarea-autofocus-removal-while-focusing.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed Chromium rebaselines.
antonm@chromium.org [Wed, 17 Oct 2012 09:43:48 +0000 (09:43 +0000)]
Unreviewed Chromium rebaselines.

* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.png:
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.png:
* platform/chromium-win-xp/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: When dirty uiSourceCode is saved to disk from scripts navigator contex...
vsevik@chromium.org [Wed, 17 Oct 2012 09:42:26 +0000 (09:42 +0000)]
Web Inspector: When dirty uiSourceCode is saved to disk from scripts navigator context menu working copy is not committed.
https://bugs.webkit.org/show_bug.cgi?id=99555

Reviewed by Yury Semikhatsky.

Save As context menu handler now commits working copy for dirty UISourceCodes.

* inspector/front-end/HandlerRegistry.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2][GTK] Unneeded GError field in internal structure in WebKitFaviconDatabase.cpp
mario@webkit.org [Wed, 17 Oct 2012 09:27:41 +0000 (09:27 +0000)]
[WK2][GTK] Unneeded GError field in internal structure in WebKitFaviconDatabase.cpp
https://bugs.webkit.org/show_bug.cgi?id=99564

Reviewed by Carlos Garcia Campos.

Removed field 'error' from GetFaviconSurfaceAsyncData and updated
the code accordingly, by using g_simple_async_result_take_error().

* UIProcess/API/gtk/WebKitFaviconDatabase.cpp:
(GetFaviconSurfaceAsyncData): Removed unneeded field.
(processPendingIconsForPageURL): Avoid using g_propagate_error and
use g_simple_async_result_take_error directly instead.
(webkit_favicon_database_get_favicon_finish): Remove unneeded code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Stylesheets saved with FileManager are not saved to disk when edited...
vsevik@chromium.org [Wed, 17 Oct 2012 08:52:16 +0000 (08:52 +0000)]
Web Inspector: Stylesheets saved with FileManager are not saved to disk when edited from Elements panel.
https://bugs.webkit.org/show_bug.cgi?id=99554

Reviewed by Yury Semikhatsky.

Moved saving to disk from SourceFrame to UISourceCode.

* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._commitEditing):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype._commitContent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Regression] SASS sources are not saved to disk.
vsevik@chromium.org [Wed, 17 Oct 2012 08:49:14 +0000 (08:49 +0000)]
Web Inspector: [Regression] SASS sources are not saved to disk.
https://bugs.webkit.org/show_bug.cgi?id=99551

Reviewed by Yury Semikhatsky.

Added resource null checks.

* inspector/front-end/StylesSourceMapping.js:
(WebInspector.StylesSourceMapping.prototype._uiSourceCodeAddedToWorkspace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoClean up ContentData operator overloads
commit-queue@webkit.org [Wed, 17 Oct 2012 08:18:07 +0000 (08:18 +0000)]
Clean up ContentData operator overloads
https://bugs.webkit.org/show_bug.cgi?id=99556

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-10-17
Reviewed by Eric Seidel.

Use virtual dispatch for checking ContentData equality instead
of a switch over the type. This the first step in getting rid
of the StyleContentType enum and all the switch statements over
the type().

No tests needed, this is just a refactor.

* rendering/style/ContentData.cpp:
* rendering/style/ContentData.h:
(ContentData):
(WebCore::operator==):
(WebCore):
(WebCore::operator!=):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix the build with a newer version of clang.
mrowe@apple.com [Wed, 17 Oct 2012 08:15:47 +0000 (08:15 +0000)]
Fix the build with a newer version of clang.

Reviewed by Dan Bernstein.

Source/WebKit/mac:

Some of the methods in WebCoreStatistics appear to have been added by someone not familiar with Objective-C.
While it's technically valid to have empty components in a selector, it's rarely done and is not consistent
with our style guidelines. In this particular case it's also done in such a manner that it's ambiguous and
therefore generates a warning in newer versions of the compiler.

Fixes <rdar://problem/12503709>.

* Misc/WebCoreStatistics.h: Remove unused methods and rename the two poorly-named methods that remain.
* Misc/WebCoreStatistics.mm: Ditto.
(-[WebFrame numberOfPagesWithPageWidth:pageHeight:]):
(-[WebFrame printToCGContext:pageWidth:pageHeight:]):

Tools:

Update to accommodate the renamed methods in WebCoreStatistics.

* DumpRenderTree/mac/PixelDumpSupportMac.mm:
(createPagedBitmapContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviwed gardening. Skip failing reftest after r131497.
kadam@inf.u-szeged.hu [Wed, 17 Oct 2012 08:13:20 +0000 (08:13 +0000)]
[Qt] Unreviwed gardening. Skip failing reftest after r131497.
https://bugs.webkit.org/show_bug.cgi?id=98666

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-10-17

* platform/qt/TestExpectations: Skip fast/forms/range/input-appearance-range-rtl.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNEON intrinsics Gauss filter does not work properly
rgabor@webkit.org [Wed, 17 Oct 2012 08:06:55 +0000 (08:06 +0000)]
NEON intrinsics Gauss filter does not work properly
https://bugs.webkit.org/show_bug.cgi?id=98875

Reviewed by Zoltan Herczeg.

Fixing the NEON intrinsics Gauss filter. The stride parameter
was missing from the intrinsics algorithm. Tested with pixel
checks, now it's working properly.

* platform/graphics/filters/arm/FEGaussianBlurNEON.h:
(WebCore::boxBlurNEON):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash on Frame::inScope() part 2
morrita@google.com [Wed, 17 Oct 2012 08:00:16 +0000 (08:00 +0000)]
Crash on Frame::inScope() part 2
https://bugs.webkit.org/show_bug.cgi?id=99543

Reviewed by Kent Tamura.

FrameTree::scopedChildCount() can be called even when the one of child frames
is in orphan state. This change added a guard for that case.

No new tests. A hard-to-test timing issue.

* page/Frame.cpp:
(WebCore::Frame::inScope):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebKitTestRunner needs testRunner.queueLoad
commit-queue@webkit.org [Wed, 17 Oct 2012 07:54:23 +0000 (07:54 +0000)]
WebKitTestRunner needs testRunner.queueLoad
https://bugs.webkit.org/show_bug.cgi?id=42674

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-17
Reviewed by Kenneth Rohde Christiansen.

Tools:

Added testRunner.queueLoad() and testRunner.queueBackNavigation() implementation to WTR including
Work Queue implementation. Work Queue is managed by WorkQueueManager which belongs to UI process
(as the needed functionality, like loading initiation, has to be invoked from UI process) and
exchanges messages with Injected bundle.

* WebKitTestRunner/CMakeLists.txt:
* WebKitTestRunner/GNUmakefile.am:
* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::InjectedBundle):
(WTR::InjectedBundle::didReceiveMessage):
(WTR::InjectedBundle::done):
(WTR::InjectedBundle::shouldProcessWorkQueue):
(WTR):
(WTR::InjectedBundle::processWorkQueue):
(WTR::InjectedBundle::queueBackNavigation):
(WTR::InjectedBundle::queueLoad):
* WebKitTestRunner/InjectedBundle/InjectedBundle.h:
(InjectedBundle):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
(WTR::InjectedBundlePage::didFinishLoadForFrame):
(WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
(WTR::InjectedBundlePage::locationChangeForFrame):
(WTR):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
(InjectedBundlePage):
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::queueBackNavigation):
(WTR):
(WTR::TestRunner::queueLoad):
* WebKitTestRunner/InjectedBundle/TestRunner.h:
(TestRunner):
* WebKitTestRunner/Target.pri:
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
* WebKitTestRunner/TestController.h:
(WTR::TestController::workQueueManager):
(TestController):
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
* WebKitTestRunner/WorkQueueManager.cpp: Added.
(WTR):
(WTR::mainPage):
(WTR::goToItemAtIndex):
(WTR::WorkQueueManager::WorkQueueManager):
(WTR::WorkQueueManager::clearWorkQueue):
(WTR::WorkQueueManager::processWorkQueue):
(WTR::WorkQueueManager::queueLoad):
(WTR::WorkQueueManager::queueBackNavigation):
(WTR::WorkQueueManager::enqueue):
* WebKitTestRunner/WorkQueueManager.h: Added.
(WTR):
(WorkQueueManager):
(WTR::WorkQueueManager::isWorkQueueEmpty):
(WorkQueueItem):
(WTR::WorkQueueManager::WorkQueueItem::~WorkQueueItem):
* WebKitTestRunner/win/WebKitTestRunner.vcproj:

LayoutTests:

Unskipped corresponding tests for WK2 and WK2 EFL, put those which still failing to appropriate groups.

* platform/efl-wk2/TestExpectations:
* platform/wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove shadowAncestorNode() from VisibleSelection
shinyak@chromium.org [Wed, 17 Oct 2012 07:42:57 +0000 (07:42 +0000)]
Remove shadowAncestorNode() from VisibleSelection
https://bugs.webkit.org/show_bug.cgi?id=99544

Reviewed by Hajime Morita.

An effort to replace shadowAncestorNode() with shadowHost(), since shadowAncestorNode() is now deprecated.

No new tests, no change in behavior.

* editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries): Since shadowHost() returns 0 if
an element is not in shadowRoot, it's ok to compare shadowAncestor to 0.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Start using OwnPtr for non-ref counted ewk types
commit-queue@webkit.org [Wed, 17 Oct 2012 07:28:44 +0000 (07:28 +0000)]
[EFL][WK2] Start using OwnPtr for non-ref counted ewk types
https://bugs.webkit.org/show_bug.cgi?id=99472

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-17
Reviewed by Kenneth Rohde Christiansen.

Use OwnPtr internally for non-ref counted Ewk types to avoid
manual memory handling.

Private _new() and _free() functions are removed since they
are not needed now that the classes are defined in the
private headers instead of the cpp files. The constructor
for those classes was made private and factory methods were
added to encourage developers to use smart pointers instead
of raw ones.

* UIProcess/API/efl/ewk_back_forward_list.cpp:
(ewk_back_forward_list_changed):
* UIProcess/API/efl/ewk_back_forward_list_item_private.h:
* UIProcess/API/efl/ewk_back_forward_list_private.h:
(_Ewk_Back_Forward_List):
(_Ewk_Back_Forward_List::create):
(_Ewk_Back_Forward_List::_Ewk_Back_Forward_List):
* UIProcess/API/efl/ewk_context.cpp:
(_Ewk_Context):
(_Ewk_Context::_Ewk_Context):
(ewk_context_cookie_manager_get):
(ewk_context_favicon_database_get):
* UIProcess/API/efl/ewk_context_download_client.cpp:
(didFail):
* UIProcess/API/efl/ewk_cookie_manager.cpp:
(_Ewk_Cookie_Manager::_Ewk_Cookie_Manager):
(_Ewk_Cookie_Manager::~_Ewk_Cookie_Manager):
(getAcceptPolicyCallback):
(getHostnamesWithCookiesCallback):
(ewk_cookie_manager_changes_watch):
* UIProcess/API/efl/ewk_cookie_manager_private.h:
(Cookie_Change_Handler):
(Cookie_Change_Handler::Cookie_Change_Handler):
(_Ewk_Cookie_Manager):
(_Ewk_Cookie_Manager::create):
* UIProcess/API/efl/ewk_error.cpp:
(_Ewk_Error::_Ewk_Error):
(ewk_error_cancellation_get):
* UIProcess/API/efl/ewk_error_private.h:
(_Ewk_Error):
(_Ewk_Error::create):
* UIProcess/API/efl/ewk_favicon_database.cpp:
(_Ewk_Favicon_Database::_Ewk_Favicon_Database):
* UIProcess/API/efl/ewk_favicon_database_private.h:
(IconChangeCallbackData):
(IconChangeCallbackData::IconChangeCallbackData):
(IconRequestCallbackData):
(IconRequestCallbackData::IconRequestCallbackData):
(_Ewk_Favicon_Database):
(_Ewk_Favicon_Database::create):
* UIProcess/API/efl/ewk_popup_menu_item.cpp:
(_Ewk_Popup_Menu_Item::_Ewk_Popup_Menu_Item):
* UIProcess/API/efl/ewk_popup_menu_item_private.h:
(_Ewk_Popup_Menu_Item):
(_Ewk_Popup_Menu_Item::create):
* UIProcess/API/efl/ewk_url_scheme_request.cpp:
(_Ewk_Url_Scheme_Request::_Ewk_Url_Scheme_Request):
* UIProcess/API/efl/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_Ewk_View_Private_Data::_Ewk_View_Private_Data):
(_Ewk_View_Private_Data::~_Ewk_View_Private_Data):
(_ewk_view_initialize):
(ewk_view_back_forward_list_get):
(ewk_view_popup_menu_request):
(ewk_view_popup_menu_close):
* UIProcess/API/efl/ewk_view_loader_client.cpp:
(didFailLoadWithErrorForFrame):
(didFailProvisionalLoadWithErrorForFrame):
* UIProcess/API/efl/ewk_view_resource_load_client.cpp:
(didFailLoadForResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoContent of replaced elements should be trimmed to the content edge curve.
commit-queue@webkit.org [Wed, 17 Oct 2012 07:16:26 +0000 (07:16 +0000)]
Content of replaced elements should be trimmed to the content edge curve.
https://bugs.webkit.org/show_bug.cgi?id=63899

Patch by Douglas Stockwell <dstockwell@chromium.org> on 2012-10-17
Reviewed by Simon Fraser.

Source/WebCore:

When a border-radius is specified the content of replaced elements needs to be clipped to avoid
being painted over the padding or border in the corners. Previously the clip that was applied
was set to the border-edge curve, this patch contracts the clip by the size of the border and
padding (the content-edge curve) to match the css3 spec.
Spec: http://www.w3.org/TR/css3-background/#corner-clipping

Test: fast/replaced/border-radius-clip-content-edge.html

* rendering/RenderBoxModelObject.h:
(RenderBoxModelObject):
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::paint):
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::paint):

LayoutTests:

* fast/replaced/border-radius-clip-content-edge-expected.txt: Added.
* fast/replaced/border-radius-clip-content-edge.html: Added.
* platform/fast/replaced/border-radius-clip-content-edge-expected.png: Added.
* platform/chromium/TestExpectations:
* platform/chromium-linux/fast/replaced/border-radius-clip-content-edge-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Use WTF RefCounted and RefPtr for Ewk_Resource and Ewk_Form_Submission_Request
commit-queue@webkit.org [Wed, 17 Oct 2012 07:10:41 +0000 (07:10 +0000)]
[EFL][WK2] Use WTF RefCounted and RefPtr for Ewk_Resource and Ewk_Form_Submission_Request
https://bugs.webkit.org/show_bug.cgi?id=99542

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-17
Reviewed by Kenneth Rohde Christiansen.

Use WTF RefCounted and RefPtr for Ewk_Resource and Ewk_Form_Submission_Request
to avoid handling raw pointers internally.

* UIProcess/API/efl/ewk_form_submission_request.cpp:
(ewk_form_submission_request_ref):
(ewk_form_submission_request_unref):
(ewk_form_submission_request_submit):
* UIProcess/API/efl/ewk_form_submission_request_private.h:
(_Ewk_Form_Submission_Request):
(_Ewk_Form_Submission_Request::~_Ewk_Form_Submission_Request):
(_Ewk_Form_Submission_Request::create):
(_Ewk_Form_Submission_Request::_Ewk_Form_Submission_Request):
* UIProcess/API/efl/ewk_resource.cpp:
(ewk_resource_ref):
(ewk_resource_unref):
* UIProcess/API/efl/ewk_resource_private.h:
(_Ewk_Resource):
(_Ewk_Resource::create):
(_Ewk_Resource::_Ewk_Resource):
* UIProcess/API/efl/ewk_view.cpp:
(_Ewk_View_Private_Data::~_Ewk_View_Private_Data):
(ewk_view_resource_load_initiated):
(ewk_view_resource_load_response):
(ewk_view_resource_load_failed):
(ewk_view_resource_load_finished):
(ewk_view_resource_request_sent):
(ewk_view_load_provisional_started):
* UIProcess/API/efl/ewk_view_form_client.cpp:
(willSubmitForm):
* UIProcess/API/efl/ewk_view_resource_load_client.cpp:
(didInitiateLoadForResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131556 268f45cc-cd09-0410-ab3c-d52691b4dbfc