WebKit-https.git
8 years agoHeap-use-after-free in WTF::HashMap<int, WTF::RefPtr<WebCore::CalculationValue>,...
mikelawther@chromium.org [Mon, 14 May 2012 03:30:46 +0000 (03:30 +0000)]
Heap-use-after-free in WTF::HashMap<int, WTF::RefPtr<WebCore::CalculationValue>, WTF::IntHash<unsigned int>, WTF::HashTrait
https://bugs.webkit.org/show_bug.cgi?id=85195

Source/WebCore:

This bug was caused by Length not understanding that calc expressions shouldn't be
blended - a Length with a calc expression handle was created without incrementing
the ref count of the expression. Length no longer attempts to blend calc expressions,
http://webkit.org/b/86160 has been filed to track expression blending. Fixing this fixed
the crash.

Once this was fixed, the RenderStyle diff checker thought the style was changing,
as Length didn't know how to compare calc expressions, resulting in an infinite
loop of style recalcs. Expressions can now compare themselves.

Reviewed by Darin Adler.

Tests: css3/calc/transition-crash.html
       css3/calc/transition-crash2.html

* platform/CalculationValue.h:
(WebCore::CalcExpressionNode::CalcExpressionNode):
(CalcExpressionNode):
(WebCore::CalcExpressionNode::type):
(CalculationValue):
(WebCore::CalculationValue::operator==):
(WebCore::CalcExpressionNumber::CalcExpressionNumber):
(WebCore::CalcExpressionNumber::operator==):
(CalcExpressionNumber):
(WebCore::CalcExpressionLength::CalcExpressionLength):
(WebCore::CalcExpressionLength::operator==):
(CalcExpressionLength):
(WebCore::CalcExpressionBinaryOperation::CalcExpressionBinaryOperation):
(WebCore::CalcExpressionBinaryOperation::operator==):
(CalcExpressionBinaryOperation):
* platform/Length.cpp:
(WebCore::Length::isCalculatedEqual):
(WebCore):
* platform/Length.h:
(WebCore::Length::operator==):
(Length):
(WebCore::Length::blend):

LayoutTests:

Reviewed by Darin Adler.

* css3/calc/transition-crash-expected.txt: Added.
* css3/calc/transition-crash.html: Added.
* css3/calc/transition-crash2-expected.txt: Added.
* css3/calc/transition-crash2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed GTK test_expectations update.
philn@webkit.org [Mon, 14 May 2012 03:23:54 +0000 (03:23 +0000)]
Unreviewed GTK test_expectations update.

* platform/gtk/test_expectations.txt: Mark
media/video-controls-toggling.html as failing and move 2 other
media failures to the correct section.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed GTK test_expectations update.
philn@webkit.org [Mon, 14 May 2012 01:48:15 +0000 (01:48 +0000)]
Unreviewed GTK test_expectations update.

* platform/gtk/test_expectations.txt: Flag another 2 media failures.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed GTK test_expectations update.
philn@webkit.org [Mon, 14 May 2012 01:40:30 +0000 (01:40 +0000)]
Unreviewed GTK test_expectations update.

* platform/gtk/test_expectations.txt: Flag failing media test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRoll out local changes accidentally landed in r116905.
darin@apple.com [Sun, 13 May 2012 23:48:25 +0000 (23:48 +0000)]
Roll out local changes accidentally landed in r116905.

* platform/graphics/GraphicsContext.h:
* platform/graphics/cg/GraphicsContextCG.cpp:
* platform/graphics/cg/ImageCG.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse emptyString instead of String("")
rwlbuis@webkit.org [Sun, 13 May 2012 23:47:02 +0000 (23:47 +0000)]
Use emptyString instead of String("")
https://bugs.webkit.org/show_bug.cgi?id=86305

Reviewed by Darin Adler.

Use emptyString() instead of String("") because it is better style and faster.

No new tests. No change in behavior.

* Modules/webdatabase/AbstractDatabase.cpp:
(WebCore::AbstractDatabase::performOpenAndVerify):
* Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:
(WebCore::ThreadableWebSocketChannelClientWrapper::subprotocol):
(WebCore::ThreadableWebSocketChannelClientWrapper::extensions):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setValueFromRenderer):
* platform/SharedBufferChunkReader.cpp:
(WebCore::SharedBufferChunkReader::nextChunkAsUTF8StringWithLatin1Fallback):
* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::ResourceHandleManager::setProxyInfo):
* platform/text/LocaleICU.cpp:
(WebCore::LocaleICU::initializeLocalizedDateFormatText):
* rendering/RenderQuote.cpp:
(WebCore::RenderQuote::originalText):
* storage/StorageNamespaceImpl.cpp:
(WebCore::StorageNamespaceImpl::localStorageNamespace):
* svg/SVGStringList.cpp:
(WebCore::SVGStringList::reset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImage::initPlatformData is always an empty function so we can remove it
darin@apple.com [Sun, 13 May 2012 23:42:24 +0000 (23:42 +0000)]
Image::initPlatformData is always an empty function so we can remove it
https://bugs.webkit.org/show_bug.cgi?id=86297

Reviewed by Dan Bernstein.

* platform/graphics/BitmapImage.h: Removed declaration of initPlatformData.

* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::BitmapImage): Removed call to initPlatformData.
* platform/graphics/cairo/BitmapImageCairo.cpp:
(WebCore::BitmapImage::BitmapImage): Ditto.
* platform/graphics/cg/ImageCG.cpp:
(WebCore::BitmapImage::BitmapImage): Ditto.
* platform/graphics/chromium/ImageChromiumMac.mm: Removed empty
initPlatformData function.
* platform/graphics/efl/ImageEfl.cpp: Ditto.
* platform/graphics/gtk/ImageGtk.cpp:
* platform/graphics/mac/ImageMac.mm:
* platform/graphics/openvg/ImageOpenVG.cpp:
(WebCore::BitmapImage::BitmapImage): Removed call to initPlatformData.
Removed empty initPlatformData function.
* platform/graphics/qt/ImageQt.cpp:
(WebCore::BitmapImage::BitmapImage): Removed call to initPlatformData.
Removed empty initPlatformData function.
* platform/graphics/skia/ImageSkia.cpp: Removed empty initPlatformData function.
* platform/graphics/win/ImageWin.cpp: Ditto.
* platform/graphics/wx/ImageWx.cpp: Ditto.
(WebCore::BitmapImage::BitmapImage): Removed call to initPlatformData.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRenderView::selectionBounds and RenderView::setSelection use maps with raw pointers...
darin@apple.com [Sun, 13 May 2012 23:39:53 +0000 (23:39 +0000)]
RenderView::selectionBounds and RenderView::setSelection use maps with raw pointers that should be OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=86300

Reviewed by Eric Seidel.

* rendering/RenderView.cpp:
(WebCore::RenderView::selectionBounds): Changed SelectionMap type to use OwnPtr.
Added code to do adoptPtr as needed and removed explicit delete code.
(WebCore::RenderView::setSelection): Changed SelectedBlockMap type to use OwnPtr.
Added code to do adoptPtr as needed and removed explicit delete code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFractionalLayoutUnit class has unneeded redundant uses of "inline" keyword
darin@apple.com [Sun, 13 May 2012 23:36:03 +0000 (23:36 +0000)]
FractionalLayoutUnit class has unneeded redundant uses of "inline" keyword
https://bugs.webkit.org/show_bug.cgi?id=86301

Reviewed by Andreas Kling.

* platform/FractionalLayoutUnit.h: Removed uses of inline for functions
defined inside a class definition. The C++ language defines that all such
functions are treated as if specified with inline, and explicitly stating
inline in addition does not add anything or change behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDangling node to ID maps vector uses raw pointers, but should use OwnPtr
darin@apple.com [Sun, 13 May 2012 23:25:04 +0000 (23:25 +0000)]
Dangling node to ID maps vector uses raw pointers, but should use OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=86299

Reviewed by Pavel Feldman.

* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::releaseDanglingNodes): Removed now-unneeded call
to deleteAllValues since the clear function now takes care of that.
(WebCore::InspectorDOMAgent::pushNodePathToFrontend): Added code that uses
adoptPtr and release as neeed to deal with a Vector<OwnPtr>.
* inspector/InspectorDOMAgent.h: Changed m_danglingNodeToIdMaps to be
Vector<OwnPtr> instead of a vector of raw pointers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Unreviewed, fix test skipped in the previous commit.
rakuco@webkit.org [Sun, 13 May 2012 21:45:41 +0000 (21:45 +0000)]
[EFL] Unreviewed, fix test skipped in the previous commit.

* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Gardening; skip tests after r116900.
rakuco@webkit.org [Sun, 13 May 2012 21:43:24 +0000 (21:43 +0000)]
[EFL] Gardening; skip tests after r116900.

The patch only updated the chromium and mac expectations...

* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Gardening; skip test added in r116858.
rakuco@webkit.org [Sun, 13 May 2012 21:09:25 +0000 (21:09 +0000)]
[EFL] Gardening; skip test added in r116858.

* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoVolume slider needs to be displayed below the mute button
commit-queue@webkit.org [Sun, 13 May 2012 19:11:51 +0000 (19:11 +0000)]
Volume slider needs to be displayed below the mute button
https://bugs.webkit.org/show_bug.cgi?id=85990

Patch by Victor Carbune <vcarbune@adobe.com> on 2012-05-13
Reviewed by Dimitri Glazkov.

Source/WebCore:

Added back code for rendering offset, but used only when the volume slider
needs to be displayed below the controls.

Test: media/media-volume-slider-rendered-below.html

* css/mediaControlsChromium.css:
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
Changed positioning of the slider to absolute, otherwise it is not possible to position it from the layout() method.
* css/mediaControlsQuickTime.css:
Added back the double mute-button and changed the z-index of the original button. When the slider is displayed
the second mute button is actually there.
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
(audio::-webkit-media-controls-volume-slider-mute-button, video::-webkit-media-controls-volume-slider-mute-button):
Added copy.
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlPanelElement::makeTransparent): Disabled the possible of hiding controls. WebVTT rendering
in the place of controls when these are visible is not possible with the current code.
(RenderMediaVolumeSliderContainer):
(WebCore):
(WebCore::RenderMediaVolumeSliderContainer::RenderMediaVolumeSliderContainer):
(WebCore::RenderMediaVolumeSliderContainer::layout):
Checked if the absolute coordinates of the corner of the slider would be rendered outside the page. This part of the
code is faulty if display:none is toggled on the controls.
(WebCore::MediaControlVolumeSliderContainerElement::createRenderer):
* html/shadow/MediaControlElements.h:
(MediaControlVolumeSliderContainerElement):
* html/shadow/MediaControlRootElement.cpp:
(WebCore::MediaControlRootElement::create):

LayoutTests:

Updated tests expectation and marked failing tests accordingly.

* media/media-volume-slider-rendered-below.html: Added.
* media/media-volume-slider-rendered-expected.txt: Added.
* platform/chromium/test_expectations.txt: Updated.
* platform/mac/media/audio-controls-rendering-expected.txt: Updated (z-index change).
* platform/mac/media/controls-after-reload-expected.txt: Same.
* platform/mac/media/controls-strict-expected.txt: Same.
* platform/mac/media/video-controls-rendering-expected.txt: Same.
* platform/mac/media/video-display-toggle-expected.txt: Same.
* platform/mac/media/video-playing-and-pause-expected.txt: Same.
* platform/mac/test_expectations.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Texmap] TextureMapperAnimations does not support keyframe with multiple animations
igor.o@sisa.samsung.com [Sun, 13 May 2012 17:00:50 +0000 (17:00 +0000)]
[Texmap] TextureMapperAnimations does not support keyframe with multiple animations
https://bugs.webkit.org/show_bug.cgi?id=86303

Qt and GTK, in WebKit1, use TextureMapper to store AC animations using
TextureMapperAnimations::add(keyframeName, TextureMapperAnimation). And when a
CSS animation animates several CSS properties, TextureMapperAnimations::add is
called more than once with the same keyframeName value. However, currently,
TextureMapperAnimations can not store more than one animated property in the keyframe
because it is using HashMap<String, TextureMapperAnimation>, and WebKit HashMap
does not support add the same key twice.

Reviewed by Noam Rosenthal.

* platform/graphics/texmap/TextureMapperAnimation.cpp:
(WebCore::TextureMapperAnimations::hasActiveAnimationsOfType):
(WebCore::TextureMapperAnimations::hasRunningAnimations):
(WebCore::TextureMapperAnimations::add):
(WebCore):
(WebCore::TextureMapperAnimations::pause):
(WebCore::TextureMapperAnimations::apply):
* platform/graphics/texmap/TextureMapperAnimation.h:
(TextureMapperAnimations): Use HashMap<String, Vector<TextureMapperAnimation> >,
so we can support an keyframe with multiple animations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r116812.
commit-queue@webkit.org [Sun, 13 May 2012 06:07:20 +0000 (06:07 +0000)]
Unreviewed, rolling out r116812.
http://trac.webkit.org/changeset/116812
https://bugs.webkit.org/show_bug.cgi?id=86313

Appears to be causing a top crash (Requested by abarth on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-12

Source/Platform:

* Platform.gypi:
* chromium/public/Platform.h:
(WebKit):
* chromium/public/WebStorageArea.h: Removed.
* chromium/public/WebStorageNamespace.h: Removed.

Source/WebKit/chromium:

* WebKit.gyp:
* public/WebStorageArea.h:
(WebKit):
(WebStorageArea):
(WebKit::WebStorageArea::~WebStorageArea):
(WebKit::WebStorageArea::setItem):
(WebKit::WebStorageArea::removeItem):
(WebKit::WebStorageArea::clear):
* public/WebStorageNamespace.h:
(WebKit):
(WebStorageNamespace):
(WebKit::WebStorageNamespace::~WebStorageNamespace):
(WebKit::WebStorageNamespace::isSameNamespace):
* public/platform/WebKitPlatformSupport.h:
(WebKit):
(WebKitPlatformSupport):
(WebKit::WebKitPlatformSupport::createLocalStorageNamespace):
* src/StorageAreaProxy.cpp:
* src/StorageNamespaceProxy.cpp:
(WebCore::StorageNamespace::localStorageNamespace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCrash in HTMLSelectElement::setOption
inferno@chromium.org [Sun, 13 May 2012 04:22:42 +0000 (04:22 +0000)]
Crash in HTMLSelectElement::setOption
https://bugs.webkit.org/show_bug.cgi?id=85420

Source/WebCore:

Reviewed by Eric Seidel

RefPtr before option in HTMLSelectElement::setOption since it
can get destroyed due to mutation events.

Test: fast/dom/HTMLSelectElement/option-add-crash.html

* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::setOption):

LayoutTests:

Reviewed by Eric Seidel.

* fast/dom/HTMLSelectElement/option-add-crash-expected.txt: Added.
* fast/dom/HTMLSelectElement/option-add-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[wx] Restore paste implementation and fix a couple typos.
kevino@webkit.org [Sun, 13 May 2012 03:51:08 +0000 (03:51 +0000)]
[wx] Restore paste implementation and fix a couple typos.
https://bugs.webkit.org/show_bug.cgi?id=86311

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[wx] Fix backing bitmap creation under wxMSW.
kevino@webkit.org [Sun, 13 May 2012 01:40:30 +0000 (01:40 +0000)]
[wx] Fix backing bitmap creation under wxMSW.
https://bugs.webkit.org/show_bug.cgi?id=86304

Reviewed by Kevin Ollivier.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCleanup before changing attributeName in SVG <animate>
pdr@google.com [Sat, 12 May 2012 19:14:19 +0000 (19:14 +0000)]
Cleanup before changing attributeName in SVG <animate>
https://bugs.webkit.org/show_bug.cgi?id=86100

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Changing attributeName caused a crash because references were not removed from the old target.
This change simply cleans up before changing attributeName in SVG animation elements.

Test: svg/animations/dynamic-modify-attributename-crash.svg

* svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::svgAttributeChanged):

LayoutTests:

* svg/animations/dynamic-modify-attributename-crash-expected.txt: Added.
* svg/animations/dynamic-modify-attributename-crash.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agorun-safari and co. should support --guard-malloc command line argument
timothy_horton@apple.com [Sat, 12 May 2012 18:08:59 +0000 (18:08 +0000)]
run-safari and co. should support --guard-malloc command line argument
https://bugs.webkit.org/show_bug.cgi?id=86287

Reviewed by Dan Bernstein.

Add setUpGuardMallocIfNeeded(), which consults the argument --guard-malloc on OS X,
setting DYLD_INSERT_LIBRARIES="/usr/lib/libgmalloc.dylib" if it's enabled.

Use setUpGuardMallocIfNeeded() before running a WebKit app (whether standalone or
in the debugger). This will cause gmalloc to be loaded for gdb as well, but this
tends to be harmless.

Change "malloc guard" to the more common "Guard Malloc" in run-webkit-tests.

* Scripts/old-run-webkit-tests:
* Scripts/webkitdirs.pm:
(appendToEnvironmentVariableList):
(setUpGuardMallocIfNeeded):
(printHelpAndExitForRunAndDebugWebKitAppIfNeeded):
(runMacWebKitApp):
(execMacWebKitAppForDebugging):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Allow the platform media player to determine the media element's paused...
commit-queue@webkit.org [Sat, 12 May 2012 17:09:59 +0000 (17:09 +0000)]
[BlackBerry] Allow the platform media player to determine the media element's paused/playing status
https://bugs.webkit.org/show_bug.cgi?id=86235

Patch by Max Feil <mfeil@rim.com> on 2012-05-12
Reviewed by George Staikos.

Source/WebCore:

The platform media player needs to know when the HTMLMediaElement
is not paused. This is to address problems when switching
source element, which causes the destruction of the old
MediaPlayerPrivate object and construction of a new one. The
new one must resume playing ASAP if the old one was playing.

Test: media/media-continues-playing-after-replace-source.html

* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::isElementPaused):
(WebCore):
* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
(MediaPlayerPrivate):

LayoutTests:

This test replaces the source element of a playing media object
and makes sure the new source element begins playing.

* media/media-continues-playing-after-replace-source-expected.txt: Added.
* media/media-continues-playing-after-replace-source.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: heap profiler should allow revealing an element which is logged to...
yurys@chromium.org [Sat, 12 May 2012 16:35:48 +0000 (16:35 +0000)]
Web Inspector: heap profiler should allow revealing an element which is logged to the console
https://bugs.webkit.org/show_bug.cgi?id=86204

Reviewed by Pavel Feldman.

JS objects in the console have context menu item that allows to reveal them in a heap snapshot view.

* English.lproj/localizedStrings.js:
* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsObject):
* inspector/front-end/ContextMenu.js:
(WebInspector.ContextMenu.prototype.isEmpty):
* inspector/front-end/DataGrid.js:
(WebInspector.DataGridNode.prototype._detach):
(WebInspector.DataGridNode.prototype.wasDetached):
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype.nodeClassName):
(WebInspector.HeapSnapshotNodesProvider.prototype.nodePosition):
* inspector/front-end/HeapSnapshotDataGrids.js:
(WebInspector.HeapSnapshotSortableDataGrid):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.highlightObjectByHeapSnapshotId):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.highlightNode):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.nodeWasDetached):
(WebInspector.HeapSnapshotSortableDataGrid.prototype._clearCurrentHighlight):
(WebInspector.HeapSnapshotViewportDataGrid):
(WebInspector.HeapSnapshotViewportDataGrid.prototype.highlightNode):
(WebInspector.HeapSnapshotViewportDataGrid.prototype._onScroll):
(WebInspector.HeapSnapshotConstructorsDataGrid):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.highlightObjectByHeapSnapshotId.didGetClassName):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.highlightObjectByHeapSnapshotId):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.setDataSource):
* inspector/front-end/HeapSnapshotGridNodes.js:
(WebInspector.HeapSnapshotGridNode.prototype.wasDetached):
(WebInspector.HeapSnapshotConstructorNode.prototype.revealNodeBySnapshotObjectId):
(WebInspector.HeapSnapshotConstructorNode.prototype.revealNodeBySnapshotObjectId.didPopulateChildren):
* inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotProxy.prototype.nodeClassName):
(WebInspector.HeapSnapshotProviderProxy.prototype.nodePosition):
* inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertiesSection.ContextMenuProvider):
(WebInspector.ObjectPropertiesSection.ContextMenuProvider.prototype.populateContextMenu):
(WebInspector.ObjectPropertiesSection.addContextMenuProvider):
(WebInspector.ObjectPropertiesSection.prototype.enableContextMenu):
(WebInspector.ObjectPropertiesSection.prototype._contextMenuEventFired):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype.showObject):
(WebInspector.RevealInHeapSnapshotContextMenuProvider):
(WebInspector.RevealInHeapSnapshotContextMenuProvider.prototype.populateContextMenu.revealInSummaryView):
(WebInspector.RevealInHeapSnapshotContextMenuProvider.prototype.populateContextMenu.didReceiveHeapObjectId):
(WebInspector.RevealInHeapSnapshotContextMenuProvider.prototype.populateContextMenu):
* inspector/front-end/profilesPanel.css:
(.highlighted-row):
(@-webkit-keyframes row_highlight):
(to):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, GTK gardening. Also add baselines for new tests after
zandobersek@gmail.com [Sat, 12 May 2012 14:29:42 +0000 (14:29 +0000)]
Unreviewed, GTK gardening. Also add baselines for new tests after
r116001, r116373 and r116438.

* platform/gtk/css2.1/20110323/first-letter-000-expected.txt: Added.
* platform/gtk/css2.1/20110323/first-letter-001-expected.txt: Added.
* platform/gtk/css2.1/20110323/first-letter-dynamic-001-expected.txt: Added.
* platform/gtk/css2.1/20110323/first-letter-dynamic-002-expected.txt: Added.
* platform/gtk/css2.1/20110323/first-letter-dynamic-003a-expected.txt: Added.
* platform/gtk/css2.1/20110323/first-letter-dynamic-003b-expected.txt: Added.
* platform/gtk/css2.1/20110323/first-letter-inherit-001-expected.txt: Added.
* platform/gtk/css2.1/20110323/first-letter-nested-001-expected.txt: Added.
* platform/gtk/css2.1/20110323/first-letter-nested-002-expected.txt: Added.
* platform/gtk/css2.1/20110323/first-letter-nested-003-expected.txt: Added.
* platform/gtk/css2.1/20110323/first-letter-nested-004-expected.txt: Added.
* platform/gtk/css2.1/20110323/first-letter-nested-005-expected.txt: Added.
* platform/gtk/css2.1/20110323/first-letter-nested-006-expected.txt: Added.
* platform/gtk/css2.1/20110323/first-letter-nested-007-expected.txt: Added.
* platform/gtk/css2.1/20110323/first-letter-quote-001-expected.txt: Added.
* platform/gtk/css2.1/20110323/first-letter-quote-002-expected.txt: Added.
* platform/gtk/css2.1/20110323/first-letter-quote-003-expected.txt: Added.
* platform/gtk/css2.1/20110323/first-letter-quote-004-expected.txt: Added.
* platform/gtk/css2.1/20110323/first-letter-quote-005-expected.txt: Added.
* platform/gtk/css2.1/20110323/first-letter-quote-006-expected.txt: Added.
* platform/gtk/fast/css/first-letter-nested-positioned-expected.txt: Added.
* platform/gtk/fast/css/first-letter-quotes-no-content-before-after-expected.txt: Added.
* platform/gtk/fast/css/first-line-text-decoration-expected.txt: Added.
* platform/gtk/fast/css/first-line-text-decoration-inherited-from-parent-expected.txt: Added.
* platform/gtk/media/media-can-play-webm-expected.txt: Added.
* platform/gtk/svg/as-image/image-respects-deviceScaleFactor-expected.txt: Added.
* platform/gtk/svg/as-image/image-respects-pageScaleFactor-expected.txt: Added.
* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: move recording button state control out of addProfileHeader.
loislo@chromium.org [Sat, 12 May 2012 13:54:27 +0000 (13:54 +0000)]
Web Inspector: move recording button state control out of addProfileHeader.
https://bugs.webkit.org/show_bug.cgi?id=86293

Reviewed by Yury Semikhatsky.

* inspector/front-end/CSSSelectorProfileView.js:
(WebInspector.CSSSelectorProfileType.prototype.buttonClicked):
* inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotProfileType.prototype.buttonClicked):
* inspector/front-end/ProfileView.js:
(WebInspector.CPUProfileType.prototype.buttonClicked):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfileType.prototype.buttonClicked):
(WebInspector.ProfilesPanel.prototype.toggleRecordButton):
(WebInspector.ProfilesPanel.prototype.addProfileHeader):
(WebInspector.ProfilesPanel.prototype.setRecordingProfile):
(WebInspector.ProfilesPanel.prototype.takeHeapSnapshot.done):
(WebInspector.ProfilesPanel.prototype.takeHeapSnapshot):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Turn HelpScreen to be View.
caseq@chromium.org [Sat, 12 May 2012 13:39:09 +0000 (13:39 +0000)]
Web Inspector: Turn HelpScreen to be View.
https://bugs.webkit.org/show_bug.cgi?id=85711

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-05-12
Reviewed by Yury Semikhatsky.

Motivation: for further UI changes, HelpSceen needs to be View.
It is planned to combine Settings Screen and Shortcuts Screen in one
tabbed screen.
Bonus: "helpScreen.css" will be lazy-loaded.
Additional changes: move settingsScreen logic out of inspector.js

UI change, no test required.

* WebCore.gypi: Change "helpScreen.css" file group.
* inspector/front-end/HelpScreen.js:
(WebInspector.HelpScreen): Turned to View subclass.
(WebInspector.HelpScreen.prototype.showModal): Remove "onHide" param
(WebInspector.HelpScreen.prototype.hide): Ditto.
(WebInspector.HelpScreen.prototype._onKeyDown): Adopt View members.
(WebInspector.HelpScreen.prototype._onBlur): Ditto.
* inspector/front-end/SettingsScreen.js: Adopt new workflow.
(WebInspector.SettingsScreen): Put onHide function to member
(WebInspector.SettingsScreen.prototype.willHide): Invoke onHide
(WebInspector.SettingsController): Mediator pattern - this class
takes care of status bar button - settings screen relationship.
(WebInspector.SettingsController.prototype.get statusBarItem):
Getter fot representative element.
(WebInspector.SettingsController.prototype._buttonClicked):
Classifies user action.
(WebInspector.SettingsController.prototype._onHideSettingsScreen):
Cleanup after settings screen is hidden.
(WebInspector.SettingsController.prototype._showSettingsScreen):
Presents settings screen.
(WebInspector.SettingsController.prototype._hideSettingsScreen):
Hides settings screen.
* inspector/front-end/ShortcutsScreen.js: Adopt new workflow.
(WebInspector.ShortcutsScreen.prototype.wasShown): Lazy initialization.
* inspector/front-end/WorkerManager.js: Adopt new workflow.
(WebInspector.WorkerManager.prototype._disconnectedFromWorker): Ditto.
(WebInspector.WorkerTerminatedScreen.prototype.willHide): Ditto.
* inspector/front-end/helpScreen.css: Fix spacing.
(.help-window-outer): Ditto.
(body.compact .help-window-outer): Ditto.
(body.compact .help-window-main): Ditto.
(body.compact .help-window-caption): Ditto.
(.help-content): Ditto.
(body.compact .help-content): Ditto.
(.help-content select): Ditto.
* inspector/front-end/inspector.html: Ditto.
* inspector/front-end/inspector.js: Ditto.
(WebInspector._createGlobalStatusBarItems): Create SettingsController.
(WebInspector.documentKeyDown): Adopt new workflow.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: add tab context menu
pfeldman@chromium.org [Sat, 12 May 2012 13:09:41 +0000 (13:09 +0000)]
Web Inspector: add tab context menu
https://bugs.webkit.org/show_bug.cgi?id=86292

Reviewed by Yury Semikhatsky.

This tab context menu will have "Close", "Close Others" and "Close All".

* English.lproj/localizedStrings.js:
* inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPane.prototype.closeOtherTabs):
(WebInspector.TabbedPaneTab.prototype._createTabElement):
(WebInspector.TabbedPaneTab.prototype._tabClicked):
(WebInspector.TabbedPaneTab.prototype._tabContextMenu):
(WebInspector.TabbedPaneTab.prototype._tabContextMenu.closeOthers):
(WebInspector.TabbedPaneTab.prototype._tabContextMenu.closeAll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: make call frame selector pane focusable, allow Up / Down to select...
pfeldman@chromium.org [Sat, 12 May 2012 12:52:42 +0000 (12:52 +0000)]
Web Inspector: make call frame selector pane focusable, allow Up / Down to select current call frame.
https://bugs.webkit.org/show_bug.cgi?id=86291

Reviewed by Yury Semikhatsky.

This change makes sidebar section focusable, introduces key listeners for Up and Down.

* inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane):
(WebInspector.CallStackSidebarPane.prototype.setStatus):
(WebInspector.CallStackSidebarPane.prototype._treeKeyDown):
* inspector/front-end/UISourceCode.js:
* inspector/front-end/scriptsPanel.css:
(#scripts-debug-toolbar img):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: unreviewed one line fix.
loislo@chromium.org [Sat, 12 May 2012 12:36:13 +0000 (12:36 +0000)]
Web Inspector: unreviewed one line fix.

* inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotWorker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Load context menu item has to be shown for all Profiles panel.
loislo@chromium.org [Sat, 12 May 2012 12:02:08 +0000 (12:02 +0000)]
Web Inspector: Load context menu item has to be shown for all Profiles panel.
https://bugs.webkit.org/show_bug.cgi?id=86290

Reviewed by Pavel Feldman.

* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype._handleContextMenuEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Update test expectations
tkent@chromium.org [Sat, 12 May 2012 11:56:26 +0000 (11:56 +0000)]
[Chromium] Update test expectations

* platform/chromium-linux-x86/fast/speech/input-appearance-searchandspeech-expected.txt: Removed.
* platform/chromium-linux-x86/svg/custom/inline-svg-in-xhtml-expected.txt: Removed.
* platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.txt:
* platform/chromium-linux/svg/custom/inline-svg-in-xhtml-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: shrink SourceFrame editing API to two methods (was 4).
pfeldman@chromium.org [Sat, 12 May 2012 11:09:27 +0000 (11:09 +0000)]
Web Inspector: shrink SourceFrame editing API to two methods (was 4).
https://bugs.webkit.org/show_bug.cgi?id=86288

Reviewed by Yury Semikhatsky.

Used specific workflow in two SourceFrame implementations.

* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.commitEditing):
(WebInspector.JavaScriptSourceFrame.prototype.afterTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype._didEditContent):
* inspector/front-end/ResourceView.js:
(WebInspector.EditableResourceSourceFrame.prototype.commitEditing.callbackWrapper):
(WebInspector.EditableResourceSourceFrame.prototype.commitEditing):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.commitEditing):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.commitEditing):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: allow showing arbitrary range of nodes in heap snapshot view
yurys@chromium.org [Sat, 12 May 2012 10:17:18 +0000 (10:17 +0000)]
Web Inspector: allow showing arbitrary range of nodes in heap snapshot view
https://bugs.webkit.org/show_bug.cgi?id=86230

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/profiler/heap-snapshot-summary-show-ranges.html

It was only possible to expand heap snapshot node children sequentially starting
from the first child and then pressing either "Show next X items" or "Show all X items".
This change makes it possible to show any range of children.

* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotFilteredOrderedIterator):
(WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.serializeItemsRange):
(WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.sortAll):
(WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.sortAndRewind):
(WebInspector.HeapSnapshotEdgesProvider.prototype.serializeItem):
(WebInspector.HeapSnapshotNodesProvider.prototype.serializeItem):
* inspector/front-end/HeapSnapshotGridNodes.js:
(WebInspector.HeapSnapshotGridNode):
(WebInspector.HeapSnapshotGridNode.prototype._populate.sorted):
(WebInspector.HeapSnapshotGridNode.prototype._populate):
(WebInspector.HeapSnapshotGridNode.prototype._populateChildren.serializeNextChunk):
(WebInspector.HeapSnapshotGridNode.prototype._populateChildren.insertRetrievedChild):
(WebInspector.HeapSnapshotGridNode.prototype._populateChildren.insertShowMoreButton):
(WebInspector.HeapSnapshotGridNode.prototype._populateChildren.childrenRetrieved):
(WebInspector.HeapSnapshotGridNode.prototype._populateChildren):
(WebInspector.HeapSnapshotGridNode.prototype._saveChildren):
(WebInspector.HeapSnapshotGridNode.prototype.sort.afterSort):
(WebInspector.HeapSnapshotGridNode.prototype.sort):
(WebInspector.HeapSnapshotDiffNodesProvider):
(WebInspector.HeapSnapshotDiffNodesProvider.prototype.serializeItemsRange):
(WebInspector.HeapSnapshotDiffNodesProvider.prototype.serializeItemsRange.didReceiveDeletedItems):
(WebInspector.HeapSnapshotDiffNodesProvider.prototype.serializeItemsRange.didReceiveAddedItems):
(WebInspector.HeapSnapshotDiffNodesProvider.prototype.sortAndRewind):
* inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotWorker):
(WebInspector.HeapSnapshotProviderProxy.prototype.serializeItemsRange):
* inspector/front-end/ShowMoreDataGridNode.js:
(WebInspector.ShowMoreDataGridNode):
(WebInspector.ShowMoreDataGridNode.prototype._showNextChunk):
(WebInspector.ShowMoreDataGridNode.prototype._showAll):
(WebInspector.ShowMoreDataGridNode.prototype._updateLabels):
(WebInspector.ShowMoreDataGridNode.prototype.setStartPosition):
(WebInspector.ShowMoreDataGridNode.prototype.setEndPosition):
* inspector/front-end/utilities.js:

LayoutTests:

* inspector/profiler/heap-snapshot-comparison-show-all.html:
* inspector/profiler/heap-snapshot-containment-show-all.html:
* inspector/profiler/heap-snapshot-dominators-show-all.html:
* inspector/profiler/heap-snapshot-summary-show-all.html:
* inspector/profiler/heap-snapshot-summary-show-ranges-expected.txt: Added.
* inspector/profiler/heap-snapshot-summary-show-ranges.html: Added. Test that
showing overlapping and disjoint ranges of node children will leave the node
in a valid state.
* platform/mac/Skipped: Skip the test on platforms that don't support heap profiling.
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: remove UISourceCode.id since it is no longer used.
pfeldman@chromium.org [Sat, 12 May 2012 10:02:53 +0000 (10:02 +0000)]
Web Inspector: remove UISourceCode.id since it is no longer used.
https://bugs.webkit.org/show_bug.cgi?id=86286

Reviewed by Vsevolod Vlasov.

Source/WebCore:

We are now using breakpointStorageId property for breakpoint persistence.

* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager):
(WebInspector.BreakpointManager.prototype._debuggerReset):
(WebInspector.BreakpointManager.prototype._uiLocationAdded.get if):
(WebInspector.BreakpointManager.prototype._uiLocationAdded):
(WebInspector.BreakpointManager.prototype._uiLocationRemoved.get if):
(WebInspector.BreakpointManager.prototype._uiLocationRemoved):
* inspector/front-end/CompilerScriptMapping.js:
* inspector/front-end/JavaScriptSource.js:
(WebInspector.JavaScriptSource):
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.prototype._createUISourceCode):
(WebInspector.RawSourceCode.prototype._finishedLoading):
* inspector/front-end/SnippetsModel.js:
(WebInspector.SnippetsScriptMapping.prototype._snippetAdded):
(WebInspector.SnippetsScriptMapping.prototype._createUISourceCodeForScript):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):

LayoutTests:

* inspector/debugger/breakpoint-manager.html:
* inspector/debugger/raw-source-code.html:
* inspector/debugger/scripts-file-selector.html:
* inspector/debugger/scripts-panel.html:
* inspector/debugger/scripts-sorting.html:
* inspector/debugger/ui-source-code-display-name.html:
* inspector/debugger/ui-source-code.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Test expectation update.
tkent@chromium.org [Sat, 12 May 2012 08:51:34 +0000 (08:51 +0000)]
[Chromium] Test expectation update.

* fast/block/float/avoiding-float-centered-expected.txt: Renamed from LayoutTests/platform/efl/fast/block/float/avoiding-float-centered-expected.txt.
* fast/clip/008-expected.txt: Renamed from LayoutTests/platform/efl/fast/clip/008-expected.txt.
* fast/clip/011-expected.txt: Renamed from LayoutTests/platform/efl/fast/clip/011-expected.txt.
* fast/clip/012-expected.txt: Renamed from LayoutTests/platform/efl/fast/clip/012-expected.txt.
* platform/chromium-linux-x86/fast/speech/input-appearance-searchandspeech-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.txt.
* platform/chromium-linux-x86/svg/custom/inline-svg-in-xhtml-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/custom/inline-svg-in-xhtml-expected.txt.
* platform/chromium-linux/editing/selection/3690703-2-expected.txt:
* platform/chromium-linux/editing/selection/3690703-expected.txt:
* platform/chromium-linux/editing/selection/3690719-expected.txt:
* platform/chromium-mac-leopard/fast/block/lineboxcontain/block-glyphs-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/block/lineboxcontain/block-glyphs-expected.txt.
* platform/chromium-mac-snowleopard/fast/block/lineboxcontain/block-glyphs-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/block/lineboxcontain/block-glyphs-expected.txt.
* platform/chromium-mac-snowleopard/fast/speech/input-appearance-searchandspeech-expected.txt: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/speech/input-appearance-searchandspeech-expected.txt.
* platform/chromium-mac/editing/inserting/before-after-input-element-expected.txt: Removed.
* platform/chromium-mac/editing/pasteboard/4806874-expected.txt: Removed.
* platform/chromium-mac/editing/pasteboard/input-field-1-expected.txt: Removed.
* platform/chromium-mac/editing/selection/3690703-2-expected.txt: Removed.
* platform/chromium-mac/editing/selection/3690703-expected.txt: Removed.
* platform/chromium-mac/editing/selection/3690719-expected.txt: Removed.
* platform/chromium-mac/editing/selection/4895428-3-expected.txt: Removed.
* platform/chromium-mac/editing/selection/4975120-expected.txt: Removed.
* platform/chromium-mac/editing/selection/drag-select-1-expected.txt: Removed.
* platform/chromium-mac/editing/selection/expanding-selections-expected.txt: Removed.
* platform/chromium-mac/editing/selection/leave-requested-block-expected.txt: Removed.
* platform/chromium-mac/editing/selection/select-across-readonly-input-1-expected.txt: Removed.
* platform/chromium-mac/editing/selection/select-across-readonly-input-2-expected.txt: Removed.
* platform/chromium-mac/editing/selection/select-across-readonly-input-3-expected.txt: Removed.
* platform/chromium-mac/editing/selection/select-across-readonly-input-4-expected.txt: Removed.
* platform/chromium-mac/editing/selection/select-across-readonly-input-5-expected.txt: Removed.
* platform/chromium-mac/fast/block/lineboxcontain/block-font-expected.txt: Removed.
* platform/chromium-mac/fast/block/lineboxcontain/block-glyphs-expected.txt:
* platform/chromium-mac/fast/block/lineboxcontain/font-expected.txt: Removed.
* platform/chromium-mac/fast/forms/box-shadow-override-expected.png:
* platform/chromium-mac/fast/forms/placeholder-position-expected.txt: Removed.
* platform/chromium-mac/fast/forms/search-cancel-button-style-sharing-expected.png:
* platform/chromium-mac/fast/forms/search-rtl-expected.png:
* platform/chromium-mac/fast/forms/search-vertical-alignment-expected.png:
* platform/chromium-mac/fast/forms/searchfield-heights-expected.png:
* platform/chromium-win/editing/inserting/before-after-input-element-expected.txt:
* platform/chromium-win/editing/pasteboard/4806874-expected.txt:
* platform/chromium-win/editing/pasteboard/drop-text-without-selection-expected.txt:
* platform/chromium-win/editing/pasteboard/input-field-1-expected.txt:
* platform/chromium-win/editing/selection/3690703-2-expected.txt:
* platform/chromium-win/editing/selection/3690703-expected.txt:
* platform/chromium-win/editing/selection/3690719-expected.txt:
* platform/chromium-win/editing/selection/4895428-3-expected.txt:
* platform/chromium-win/editing/selection/4975120-expected.txt:
* platform/chromium-win/editing/selection/drag-select-1-expected.txt:
* platform/chromium-win/editing/selection/expanding-selections-expected.txt:
* platform/chromium-win/editing/selection/leave-requested-block-expected.txt:
* platform/chromium-win/editing/selection/select-across-readonly-input-1-expected.txt:
* platform/chromium-win/editing/selection/select-across-readonly-input-2-expected.txt:
* platform/chromium-win/editing/selection/select-across-readonly-input-3-expected.txt:
* platform/chromium-win/editing/selection/select-across-readonly-input-4-expected.txt:
* platform/chromium-win/editing/selection/select-across-readonly-input-5-expected.txt:
* platform/chromium-win/fast/block/float/avoiding-float-centered-expected.txt:
* platform/chromium-win/fast/clip/008-expected.txt:
* platform/chromium-win/fast/clip/011-expected.txt:
* platform/chromium-win/fast/clip/012-expected.txt:
* platform/chromium-win/fast/forms/placeholder-position-expected.txt:
* platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.txt:
* platform/chromium-win/svg/custom/inline-svg-in-xhtml-expected.txt:
* platform/chromium-win/svg/hixie/mixed/003-expected.txt:
* platform/chromium/test_expectations.txt:
* platform/gtk/fast/block/float/avoiding-float-centered-expected.txt: Removed.
* platform/gtk/fast/clip/008-expected.txt: Removed.
* platform/gtk/fast/clip/011-expected.txt: Removed.
* platform/gtk/fast/clip/012-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, GTK gardening.
zandobersek@gmail.com [Sat, 12 May 2012 08:44:00 +0000 (08:44 +0000)]
Unreviewed, GTK gardening.

* platform/gtk/test_expectations.txt: Also remove expectations for some
tests that were recently removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: merge MainScriptMapping into DebuggerPresentationModel; move other...
pfeldman@chromium.org [Sat, 12 May 2012 08:33:31 +0000 (08:33 +0000)]
Web Inspector: merge MainScriptMapping into DebuggerPresentationModel; move other classes into their own files.
https://bugs.webkit.org/show_bug.cgi?id=86285

Reviewed by Yury Semikhatsky.

Source/WebCore:

The only purpose of the debugger presentation model now is to manage mappings. Merging main script mapping back into it.
Other classes defined in that class are moved out into their own files.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource):
(WebInspector.DebuggerPresentationModel.prototype.uiSourceCodes):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
* inspector/front-end/DebuggerResourceBinding.js: Added.
(WebInspector.DebuggerResourceBinding):
(WebInspector.DebuggerResourceBinding.canEditScriptSource):
(WebInspector.DebuggerResourceBinding.setScriptSource.didEditScriptSource):
(WebInspector.DebuggerResourceBinding.setScriptSource):
(WebInspector.DebuggerResourceBinding.prototype.canSetContent):
(WebInspector.DebuggerResourceBinding.prototype.setContent):
(WebInspector.DebuggerResourceBinding.prototype._uiSourceCodeForResource):
(WebInspector.DebuggerResourceBinding.prototype._setContentWithInitialContent):
* inspector/front-end/PresentationConsoleMessageHelper.js: Added.
(WebInspector.PresentationConsoleMessageHelper):
(WebInspector.PresentationConsoleMessageHelper.prototype._consoleMessageAdded):
(WebInspector.PresentationConsoleMessageHelper.prototype._addConsoleMessageToScript):
(WebInspector.PresentationConsoleMessageHelper.prototype._addPendingConsoleMessage):
(WebInspector.PresentationConsoleMessageHelper.prototype._parsedScriptSource):
(WebInspector.PresentationConsoleMessageHelper.prototype._consoleCleared):
(WebInspector.PresentationConsoleMessageHelper.prototype._debuggerReset):
(WebInspector.PresentationConsoleMessage):
(WebInspector.PresentationConsoleMessage.prototype._updateLocation):
(WebInspector.PresentationConsoleMessage.prototype.get lineNumber):
(WebInspector.PresentationConsoleMessage.prototype.dispose):
* inspector/front-end/ScriptMapping.js:
* inspector/front-end/ScriptsPanel.js:
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:

LayoutTests:

* http/tests/inspector/compiler-script-mapping-expected.txt:
* http/tests/inspector/compiler-script-mapping.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCleanup ContentSecurityPolicy naming conventions.
commit-queue@webkit.org [Sat, 12 May 2012 08:31:30 +0000 (08:31 +0000)]
Cleanup ContentSecurityPolicy naming conventions.
https://bugs.webkit.org/show_bug.cgi?id=86282

Patch by Mike West <mkwst@chromium.org> on 2012-05-12
Reviewed by Adam Barth.

Two tiny changes:

1. `reportURI` and `reportURL` are both used within the CSP
   implementation. We should standardize on `reportURI` to match the
   spec.

2. Renames `ContentSecurityPolicy::allowConnectFromSource` to
   `ContentSecurityPolicy::allowConnectToSource` for clarity.

No new tests, as there's no user-visible change.

* Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::connect):
* page/ContentSecurityPolicy.cpp:
(CSPDirectiveList):
(WebCore::CSPDirectiveList::reportViolation):
(WebCore::CSPDirectiveList::allowConnectToSource):
(WebCore::CSPDirectiveList::parseReportURI):
(WebCore::CSPDirectiveList::addDirective):
(WebCore::ContentSecurityPolicy::allowConnectToSource):
* page/ContentSecurityPolicy.h:
* page/EventSource.cpp:
(WebCore::EventSource::create):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::open):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Rebaseline for some tests.
tkent@chromium.org [Sat, 12 May 2012 07:43:03 +0000 (07:43 +0000)]
[Chromium] Rebaseline for some tests.

* css3/selectors3/html/css3-modsel-23-expected.txt: Renamed from LayoutTests/platform/efl/css3/selectors3/html/css3-modsel-23-expected.txt.
* css3/selectors3/html/css3-modsel-24-expected.txt: Renamed from LayoutTests/platform/efl/css3/selectors3/html/css3-modsel-24-expected.txt.
* css3/selectors3/html/css3-modsel-68-expected.txt: Renamed from LayoutTests/platform/efl/css3/selectors3/html/css3-modsel-68-expected.txt.
* css3/selectors3/html/css3-modsel-69-expected.txt: Renamed from LayoutTests/platform/efl/css3/selectors3/html/css3-modsel-69-expected.txt.
* css3/selectors3/xhtml/css3-modsel-23-expected.txt: Renamed from LayoutTests/platform/efl/css3/selectors3/xhtml/css3-modsel-23-expected.txt.
* css3/selectors3/xhtml/css3-modsel-24-expected.txt: Renamed from LayoutTests/platform/efl/css3/selectors3/xhtml/css3-modsel-24-expected.txt.
* css3/selectors3/xhtml/css3-modsel-68-expected.txt: Renamed from LayoutTests/platform/efl/css3/selectors3/xhtml/css3-modsel-68-expected.txt.
* css3/selectors3/xhtml/css3-modsel-69-expected.txt: Renamed from LayoutTests/platform/efl/css3/selectors3/xhtml/css3-modsel-69-expected.txt.
* css3/selectors3/xml/css3-modsel-23-expected.txt: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-23-expected.txt.
* css3/selectors3/xml/css3-modsel-24-expected.txt: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-24-expected.txt.
* css3/selectors3/xml/css3-modsel-68-expected.txt: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-68-expected.txt.
* css3/selectors3/xml/css3-modsel-69-expected.txt: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-69-expected.txt.
* fast/block/float/033-expected.txt:
* fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Renamed from LayoutTests/platform/efl/fast/block/float/float-not-removed-from-next-sibling3-expected.txt.
* fast/block/float/in-margin-expected.png: Renamed from LayoutTests/platform/efl/fast/block/float/in-margin-expected.png.
* fast/block/float/overlapping-floats-with-overflow-hidden-expected.txt: Renamed from LayoutTests/platform/efl/fast/block/float/overlapping-floats-with-overflow-hidden-expected.txt.
* fast/block/float/shrink-to-avoid-float-complexity-expected.txt: Renamed from LayoutTests/platform/efl/fast/block/float/shrink-to-avoid-float-complexity-expected.txt.
* fast/block/lineboxcontain/parsing-invalid-expected.txt: Renamed from LayoutTests/platform/efl/fast/block/lineboxcontain/parsing-invalid-expected.txt.
* fast/clip/017-expected.png: Renamed from LayoutTests/platform/efl/fast/clip/017-expected.png.
* fast/css/invalidation-errors-2-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/invalidation-errors-2-expected.txt.
* fast/css/invalidation-errors-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/invalidation-errors-expected.txt.
* fast/css/nested-layers-with-hover-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/nested-layers-with-hover-expected.txt.
* fast/dynamic/subtree-boundary-percent-height-expected.png: Renamed from LayoutTests/platform/efl/fast/dynamic/subtree-boundary-percent-height-expected.png.
* fast/dynamic/subtree-no-common-root-static-y-expected.png: Renamed from LayoutTests/platform/efl/fast/dynamic/subtree-no-common-root-static-y-expected.png.
* fast/dynamic/subtree-table-cell-height-expected.png: Renamed from LayoutTests/platform/efl/fast/dynamic/subtree-table-cell-height-expected.png.
* fast/inline/continuation-outlines-expected.txt: Renamed from LayoutTests/platform/efl/fast/inline/continuation-outlines-expected.txt.
* fast/layers/self-painting-outline-expected.png: Renamed from LayoutTests/platform/efl/fast/layers/self-painting-outline-expected.png.
* fast/multicol/layers-split-across-columns-expected.txt: Renamed from LayoutTests/platform/efl/fast/multicol/layers-split-across-columns-expected.txt.
* fast/overflow/004-expected.txt: Renamed from LayoutTests/platform/efl/fast/overflow/004-expected.txt.
* fast/overflow/clip-rects-fixed-ancestor-expected.txt: Renamed from LayoutTests/platform/efl/fast/overflow/clip-rects-fixed-ancestor-expected.txt.
* fast/overflow/line-clamp-expected.txt: Renamed from LayoutTests/platform/efl/fast/overflow/line-clamp-expected.txt.
* fast/overflow/overflow-focus-ring-expected.txt: Renamed from LayoutTests/platform/efl/fast/overflow/overflow-focus-ring-expected.txt.
* fast/repaint/layer-outline-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/layer-outline-expected.txt.
* fast/repaint/layer-outline-horizontal-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/layer-outline-horizontal-expected.txt.
* fast/repaint/opacity-change-on-overflow-float-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/opacity-change-on-overflow-float-expected.txt.
* fast/repaint/subtree-root-clip-3-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/subtree-root-clip-3-expected.png.
* fast/table/029-expected.txt: Renamed from LayoutTests/platform/efl/fast/table/029-expected.txt.
* fast/table/overflowHidden-expected.txt: Renamed from LayoutTests/platform/efl/fast/table/overflowHidden-expected.txt.
* platform/chromium-linux-x86/fast/text/selection-painted-separately-expected.txt:
* platform/chromium-linux-x86/fast/text/selection-rect-rounding-expected.txt: Added.
* platform/chromium-linux/fast/block/margin-collapse/103-expected.txt:
* platform/chromium-linux/fast/css/input-search-padding-expected.txt:
* platform/chromium-linux/fast/forms/box-shadow-override-expected.txt:
* platform/chromium-linux/fast/forms/input-appearance-height-expected.txt:
* platform/chromium-linux/fast/forms/input-baseline-expected.txt:
* platform/chromium-linux/fast/forms/input-text-double-click-expected.txt:
* platform/chromium-linux/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
* platform/chromium-linux/fast/forms/search-styled-expected.txt:
* platform/chromium-linux/fast/forms/searchfield-heights-expected.txt:
* platform/chromium-linux/fast/forms/validation-message-appearance-expected.txt:
* platform/chromium-linux/fast/invalid/residual-style-expected.txt:
* platform/chromium-linux/fast/replaced/replaced-breaking-mixture-expected.txt:
* platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.txt:
* platform/chromium-linux/fast/text/selection-painted-separately-expected.txt:
* platform/chromium-linux/fast/text/selection-rect-rounding-expected.txt: Added.
* platform/chromium-linux/http/tests/navigation/javascriptlink-frames-expected.txt:
* platform/chromium-linux/tables/mozilla/bugs/bug18359-expected.txt:
* platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.txt:
* platform/chromium-linux/tables/mozilla/bugs/bug2479-3-expected.txt:
* platform/chromium-linux/tables/mozilla/bugs/bug2479-4-expected.txt:
* platform/chromium-linux/tables/mozilla/bugs/bug28928-expected.txt:
* platform/chromium-linux/tables/mozilla/bugs/bug4382-expected.txt:
* platform/chromium-linux/tables/mozilla/bugs/bug44505-expected.txt:
* platform/chromium-linux/tables/mozilla/bugs/bug46368-1-expected.txt:
* platform/chromium-linux/tables/mozilla/bugs/bug46368-2-expected.txt:
* platform/chromium-linux/tables/mozilla/bugs/bug51037-expected.txt:
* platform/chromium-linux/tables/mozilla/bugs/bug7342-expected.txt:
* platform/chromium-linux/tables/mozilla/dom/tableDom-expected.txt:
* platform/chromium-linux/tables/mozilla/other/move_row-expected.txt:
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
* platform/chromium-mac-leopard/css3/selectors3/html/css3-modsel-23-expected.png:
* platform/chromium-mac-leopard/css3/selectors3/html/css3-modsel-24-expected.png:
* platform/chromium-mac-leopard/css3/selectors3/html/css3-modsel-68-expected.png:
* platform/chromium-mac-leopard/css3/selectors3/html/css3-modsel-69-expected.png:
* platform/chromium-mac-leopard/css3/selectors3/xhtml/css3-modsel-23-expected.png:
* platform/chromium-mac-leopard/css3/selectors3/xhtml/css3-modsel-24-expected.png:
* platform/chromium-mac-leopard/css3/selectors3/xhtml/css3-modsel-68-expected.png:
* platform/chromium-mac-leopard/css3/selectors3/xhtml/css3-modsel-69-expected.png:
* platform/chromium-mac-leopard/css3/selectors3/xml/css3-modsel-23-expected.png:
* platform/chromium-mac-leopard/css3/selectors3/xml/css3-modsel-24-expected.png:
* platform/chromium-mac-leopard/css3/selectors3/xml/css3-modsel-68-expected.png:
* platform/chromium-mac-leopard/css3/selectors3/xml/css3-modsel-69-expected.png:
* platform/chromium-mac-leopard/fast/events/context-no-deselect-expected.txt: Removed.
* platform/chromium-mac-leopard/fast/forms/input-disabled-color-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-disabled-color-expected.txt: Removed.
* platform/chromium-mac-leopard/fast/forms/number/input-appearance-number-rtl-expected.txt: Removed.
* platform/chromium-mac-leopard/fast/inline/continuation-outlines-expected.png:
* platform/chromium-mac-leopard/fast/text/selection-painted-separately-expected.txt:
* platform/chromium-mac-leopard/fast/text/selection-rect-rounding-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/events/context-no-deselect-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/forms/input-disabled-color-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-disabled-color-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-number-rtl-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/inline/continuation-outlines-expected.png:
* platform/chromium-mac-snowleopard/fast/text/selection-painted-separately-expected.txt:
* platform/chromium-mac-snowleopard/fast/text/selection-rect-rounding-expected.txt:
* platform/chromium-mac/css3/selectors3/html/css3-modsel-23-expected.png:
* platform/chromium-mac/css3/selectors3/html/css3-modsel-24-expected.png:
* platform/chromium-mac/css3/selectors3/html/css3-modsel-68-expected.png:
* platform/chromium-mac/css3/selectors3/html/css3-modsel-69-expected.png:
* platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-23-expected.png:
* platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-24-expected.png:
* platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-68-expected.png:
* platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-69-expected.png:
* platform/chromium-mac/css3/selectors3/xml/css3-modsel-23-expected.png:
* platform/chromium-mac/css3/selectors3/xml/css3-modsel-24-expected.png:
* platform/chromium-mac/css3/selectors3/xml/css3-modsel-68-expected.png:
* platform/chromium-mac/css3/selectors3/xml/css3-modsel-69-expected.png:
* platform/chromium-mac/fast/block/float/overlapping-floats-with-overflow-hidden-expected.txt: Removed.
* platform/chromium-mac/fast/block/float/shrink-to-avoid-float-complexity-expected.txt: Removed.
* platform/chromium-mac/fast/block/lineboxcontain/parsing-invalid-expected.txt: Removed.
* platform/chromium-mac/fast/block/margin-collapse/103-expected.txt: Removed.
* platform/chromium-mac/fast/css/input-search-padding-expected.txt: Removed.
* platform/chromium-mac/fast/css/invalidation-errors-2-expected.txt: Removed.
* platform/chromium-mac/fast/css/invalidation-errors-expected.txt: Removed.
* platform/chromium-mac/fast/css/line-height-expected.txt: Removed.
* platform/chromium-mac/fast/css/nested-layers-with-hover-expected.txt: Removed.
* platform/chromium-mac/fast/css/text-input-with-webkit-border-radius-expected.txt: Removed.
* platform/chromium-mac/fast/css/text-overflow-input-expected.txt: Removed.
* platform/chromium-mac/fast/dom/isindex-001-expected.txt: Removed.
* platform/chromium-mac/fast/dom/isindex-002-expected.txt: Removed.
* platform/chromium-mac/fast/events/context-no-deselect-expected.txt: Removed.
* platform/chromium-mac/fast/forms/basic-inputs-expected.txt:
* platform/chromium-mac/fast/forms/box-shadow-override-expected.png:
* platform/chromium-mac/fast/forms/box-shadow-override-expected.txt:
* platform/chromium-mac/fast/forms/encoding-test-expected.txt: Removed.
* platform/chromium-mac/fast/forms/fieldset-align-expected.txt: Removed.
* platform/chromium-mac/fast/forms/floating-textfield-relayout-expected.txt: Removed.
* platform/chromium-mac/fast/forms/input-align-expected.txt: Removed.
* platform/chromium-mac/fast/forms/input-appearance-default-bkcolor-expected.txt: Removed.
* platform/chromium-mac/fast/forms/input-appearance-disabled-expected.txt:
* platform/chromium-mac/fast/forms/input-appearance-focus-expected.txt: Removed.
* platform/chromium-mac/fast/forms/input-appearance-height-expected.txt:
* platform/chromium-mac/fast/forms/input-appearance-readonly-expected.txt: Removed.
* platform/chromium-mac/fast/forms/input-appearance-visibility-expected.txt: Removed.
* platform/chromium-mac/fast/forms/input-appearance-width-expected.txt: Removed.
* platform/chromium-mac/fast/forms/input-baseline-expected.txt: Removed.
* platform/chromium-mac/fast/forms/input-disabled-color-expected.png:
* platform/chromium-mac/fast/forms/input-double-click-selection-gap-bug-expected.txt: Removed.
* platform/chromium-mac/fast/forms/input-field-text-truncated-expected.txt: Removed.
* platform/chromium-mac/fast/forms/input-placeholder-visibility-1-expected.txt: Removed.
* platform/chromium-mac/fast/forms/input-placeholder-visibility-3-expected.txt: Removed.
* platform/chromium-mac/fast/forms/input-readonly-empty-expected.txt: Removed.
* platform/chromium-mac/fast/forms/input-spaces-expected.txt: Removed.
* platform/chromium-mac/fast/forms/input-table-expected.txt: Removed.
* platform/chromium-mac/fast/forms/input-text-click-inside-expected.txt: Removed.
* platform/chromium-mac/fast/forms/input-text-click-outside-expected.txt: Removed.
* platform/chromium-mac/fast/forms/input-text-double-click-expected.txt: Removed.
* platform/chromium-mac/fast/forms/input-text-option-delete-expected.txt: Removed.
* platform/chromium-mac/fast/forms/input-text-self-emptying-click-expected.txt: Removed.
* platform/chromium-mac/fast/forms/input-width-expected.txt: Removed.
* platform/chromium-mac/fast/forms/number/input-appearance-number-rtl-expected.txt: Removed.
* platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
* platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-layer-expected.txt: Removed.
* platform/chromium-mac/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/chromium-mac/fast/forms/plaintext-mode-2-expected.txt: Removed.
* platform/chromium-mac/fast/forms/search-cancel-button-style-sharing-expected.png:
* platform/chromium-mac/fast/forms/search-cancel-button-style-sharing-expected.txt: Removed.
* platform/chromium-mac/fast/forms/search-display-none-cancel-button-expected.txt: Removed.
* platform/chromium-mac/fast/forms/search-rtl-expected.png:
* platform/chromium-mac/fast/forms/search-styled-expected.txt: Removed.
* platform/chromium-mac/fast/forms/search-vertical-alignment-expected.png:
* platform/chromium-mac/fast/forms/search-vertical-alignment-expected.txt: Removed.
* platform/chromium-mac/fast/forms/searchfield-heights-expected.png:
* platform/chromium-mac/fast/forms/searchfield-heights-expected.txt: Removed.
* platform/chromium-mac/fast/forms/tabbing-input-iframe-expected.txt: Removed.
* platform/chromium-mac/fast/forms/textfield-focus-ring-expected.txt: Removed.
* platform/chromium-mac/fast/forms/validation-message-appearance-expected.txt:
* platform/chromium-mac/fast/forms/visual-hebrew-text-field-expected.txt: Removed.
* platform/chromium-mac/fast/frames/take-focus-from-iframe-expected.txt: Removed.
* platform/chromium-mac/fast/html/details-no-summary4-expected.txt: Removed.
* platform/chromium-mac/fast/html/details-open-javascript-expected.txt: Removed.
* platform/chromium-mac/fast/html/details-open2-expected.txt: Removed.
* platform/chromium-mac/fast/html/details-open4-expected.txt: Removed.
* platform/chromium-mac/fast/inline/continuation-outlines-expected.png:
* platform/chromium-mac/fast/invalid/residual-style-expected.txt: Removed.
* platform/chromium-mac/fast/lists/dynamic-marker-crash-expected.txt: Removed.
* platform/chromium-mac/fast/multicol/layers-split-across-columns-expected.txt: Removed.
* platform/chromium-mac/fast/overflow/004-expected.txt: Removed.
* platform/chromium-mac/fast/overflow/clip-rects-fixed-ancestor-expected.txt: Removed.
* platform/chromium-mac/fast/overflow/line-clamp-expected.txt: Removed.
* platform/chromium-mac/fast/overflow/overflow-focus-ring-expected.txt: Removed.
* platform/chromium-mac/fast/repaint/layer-outline-expected.txt: Removed.
* platform/chromium-mac/fast/repaint/layer-outline-horizontal-expected.txt: Removed.
* platform/chromium-mac/fast/repaint/opacity-change-on-overflow-float-expected.txt: Removed.
* platform/chromium-mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt: Removed.
* platform/chromium-mac/fast/replaced/replaced-breaking-mixture-expected.txt: Removed.
* platform/chromium-mac/fast/replaced/width100percent-textfield-expected.txt: Removed.
* platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.txt:
* platform/chromium-mac/fast/speech/speech-bidi-rendering-expected.txt: Removed.
* platform/chromium-mac/fast/table/003-expected.txt: Removed.
* platform/chromium-mac/fast/table/029-expected.txt: Removed.
* platform/chromium-mac/fast/table/colspanMinWidth-expected.txt: Removed.
* platform/chromium-mac/fast/table/overflowHidden-expected.txt: Removed.
* platform/chromium-mac/fast/table/spanOverlapRepaint-expected.txt: Removed.
* platform/chromium-mac/fast/table/text-field-baseline-expected.txt: Removed.
* platform/chromium-mac/fast/text/selection-painted-separately-expected.txt:
* platform/chromium-mac/fast/transforms/transformed-focused-text-input-expected.txt: Removed.
* platform/chromium-mac/http/tests/navigation/javascriptlink-frames-expected.txt: Removed.
* platform/chromium-mac/plugins/mouse-click-plugin-clears-selection-expected.txt: Removed.
* platform/chromium-mac/tables/mozilla/bugs/45621-expected.txt: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug12384-expected.txt: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug154780-expected.txt: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug18359-expected.txt: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug24200-expected.txt: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.txt: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug2479-3-expected.txt: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug2479-4-expected.txt: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug28928-expected.txt: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug4382-expected.txt: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug44505-expected.txt:
* platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.txt: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug46368-1-expected.txt: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug46368-2-expected.txt: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug51037-expected.txt: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug55545-expected.txt: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug7342-expected.txt: Removed.
* platform/chromium-mac/tables/mozilla/dom/tableDom-expected.txt: Removed.
* platform/chromium-mac/tables/mozilla/other/move_row-expected.txt: Removed.
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt: Removed.
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug45621-expected.txt: Removed.
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt: Removed.
* platform/chromium-win-vista/fast/text/selection-painted-separately-expected.txt:
* platform/chromium-win-vista/fast/text/selection-rect-rounding-expected.txt: Added.
* platform/chromium-win-xp/fast/forms/search-styled-expected.txt:
* platform/chromium-win-xp/fast/text/selection-painted-separately-expected.txt:
* platform/chromium-win-xp/fast/text/selection-rect-rounding-expected.txt: Added.
* platform/chromium-win/fast/block/float/overlapping-floats-with-overflow-hidden-expected.txt:
* platform/chromium-win/fast/block/float/shrink-to-avoid-float-complexity-expected.txt:
* platform/chromium-win/fast/block/lineboxcontain/parsing-invalid-expected.txt:
* platform/chromium-win/fast/block/margin-collapse/103-expected.txt:
* platform/chromium-win/fast/css/input-search-padding-expected.txt:
* platform/chromium-win/fast/css/invalidation-errors-2-expected.txt:
* platform/chromium-win/fast/css/invalidation-errors-expected.txt:
* platform/chromium-win/fast/css/line-height-expected.txt:
* platform/chromium-win/fast/css/nested-layers-with-hover-expected.txt:
* platform/chromium-win/fast/css/text-input-with-webkit-border-radius-expected.txt:
* platform/chromium-win/fast/css/text-overflow-input-expected.txt:
* platform/chromium-win/fast/dom/isindex-001-expected.txt:
* platform/chromium-win/fast/dom/isindex-002-expected.txt:
* platform/chromium-win/fast/events/autoscroll-expected.txt:
* platform/chromium-win/fast/events/context-no-deselect-expected.txt:
* platform/chromium-win/fast/forms/basic-inputs-expected.txt:
* platform/chromium-win/fast/forms/box-shadow-override-expected.txt:
* platform/chromium-win/fast/forms/encoding-test-expected.txt:
* platform/chromium-win/fast/forms/fieldset-align-expected.txt:
* platform/chromium-win/fast/forms/floating-textfield-relayout-expected.txt:
* platform/chromium-win/fast/forms/input-align-expected.txt:
* platform/chromium-win/fast/forms/input-appearance-default-bkcolor-expected.txt:
* platform/chromium-win/fast/forms/input-appearance-disabled-expected.txt:
* platform/chromium-win/fast/forms/input-appearance-focus-expected.txt:
* platform/chromium-win/fast/forms/input-appearance-height-expected.txt:
* platform/chromium-win/fast/forms/input-appearance-preventDefault-expected.txt:
* platform/chromium-win/fast/forms/input-appearance-readonly-expected.txt:
* platform/chromium-win/fast/forms/input-appearance-selection-expected.txt:
* platform/chromium-win/fast/forms/input-appearance-visibility-expected.txt:
* platform/chromium-win/fast/forms/input-appearance-width-expected.txt:
* platform/chromium-win/fast/forms/input-baseline-expected.txt:
* platform/chromium-win/fast/forms/input-double-click-selection-gap-bug-expected.txt:
* platform/chromium-win/fast/forms/input-field-text-truncated-expected.txt:
* platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.txt:
* platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.txt:
* platform/chromium-win/fast/forms/input-readonly-empty-expected.txt:
* platform/chromium-win/fast/forms/input-spaces-expected.txt:
* platform/chromium-win/fast/forms/input-table-expected.txt:
* platform/chromium-win/fast/forms/input-text-click-inside-expected.txt:
* platform/chromium-win/fast/forms/input-text-click-outside-expected.txt:
* platform/chromium-win/fast/forms/input-text-double-click-expected.txt:
* platform/chromium-win/fast/forms/input-text-option-delete-expected.txt:
* platform/chromium-win/fast/forms/input-text-self-emptying-click-expected.txt:
* platform/chromium-win/fast/forms/input-width-expected.txt:
* platform/chromium-win/fast/forms/number/input-appearance-number-rtl-expected.txt:
* platform/chromium-win/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
* platform/chromium-win/fast/forms/number/input-appearance-spinbutton-layer-expected.txt:
* platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/chromium-win/fast/forms/plaintext-mode-2-expected.txt:
* platform/chromium-win/fast/forms/search-cancel-button-style-sharing-expected.txt:
* platform/chromium-win/fast/forms/search-display-none-cancel-button-expected.txt:
* platform/chromium-win/fast/forms/search-rtl-expected.txt:
* platform/chromium-win/fast/forms/search-styled-expected.txt:
* platform/chromium-win/fast/forms/search-vertical-alignment-expected.txt:
* platform/chromium-win/fast/forms/searchfield-heights-expected.txt:
* platform/chromium-win/fast/forms/tabbing-input-iframe-expected.txt:
* platform/chromium-win/fast/forms/textfield-focus-ring-expected.txt:
* platform/chromium-win/fast/forms/validation-message-appearance-expected.txt:
* platform/chromium-win/fast/forms/visual-hebrew-text-field-expected.txt:
* platform/chromium-win/fast/frames/take-focus-from-iframe-expected.txt:
* platform/chromium-win/fast/html/details-no-summary4-expected.txt:
* platform/chromium-win/fast/html/details-open-javascript-expected.txt:
* platform/chromium-win/fast/html/details-open2-expected.txt:
* platform/chromium-win/fast/html/details-open4-expected.txt:
* platform/chromium-win/fast/invalid/residual-style-expected.txt:
* platform/chromium-win/fast/lists/dynamic-marker-crash-expected.txt:
* platform/chromium-win/fast/multicol/layers-split-across-columns-expected.txt:
* platform/chromium-win/fast/overflow/004-expected.txt:
* platform/chromium-win/fast/overflow/clip-rects-fixed-ancestor-expected.txt:
* platform/chromium-win/fast/overflow/line-clamp-expected.txt:
* platform/chromium-win/fast/overflow/overflow-focus-ring-expected.txt:
* platform/chromium-win/fast/repaint/layer-outline-expected.txt:
* platform/chromium-win/fast/repaint/layer-outline-horizontal-expected.txt:
* platform/chromium-win/fast/repaint/opacity-change-on-overflow-float-expected.txt:
* platform/chromium-win/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
* platform/chromium-win/fast/replaced/replaced-breaking-mixture-expected.txt:
* platform/chromium-win/fast/replaced/width100percent-textfield-expected.txt:
* platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.txt:
* platform/chromium-win/fast/speech/speech-bidi-rendering-expected.txt:
* platform/chromium-win/fast/table/003-expected.txt:
* platform/chromium-win/fast/table/029-expected.txt:
* platform/chromium-win/fast/table/colspanMinWidth-expected.txt:
* platform/chromium-win/fast/table/overflowHidden-expected.txt:
* platform/chromium-win/fast/table/spanOverlapRepaint-expected.txt:
* platform/chromium-win/fast/table/text-field-baseline-expected.txt:
* platform/chromium-win/fast/text/selection-painted-separately-expected.txt:
* platform/chromium-win/fast/text/selection-rect-rounding-expected.txt:
* platform/chromium-win/fast/transforms/transformed-focused-text-input-expected.txt:
* platform/chromium-win/http/tests/navigation/javascriptlink-frames-expected.txt:
* platform/chromium-win/plugins/mouse-click-plugin-clears-selection-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/45621-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug12384-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug154780-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug18359-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug24200-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug2479-2-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug2479-3-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug2479-4-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug28928-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug4382-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug44505-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug4527-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug46368-1-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug46368-2-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug51037-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug55545-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug7342-expected.txt:
* platform/chromium-win/tables/mozilla/dom/tableDom-expected.txt:
* platform/chromium-win/tables/mozilla/other/move_row-expected.txt:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug45621-expected.txt:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
* platform/chromium/fast/block/float/033-expected.txt: Removed.
* platform/chromium/fast/block/float/avoidance-rtl-expected.txt: Removed.
* platform/chromium/fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Removed.
* platform/chromium/fast/block/float/float-overflow-hidden-containing-block-width-expected.txt: Removed.
* platform/chromium/fast/block/float/in-margin-expected.txt: Removed.
* platform/chromium/fast/clip/017-expected.txt: Removed.
* platform/chromium/fast/dynamic/subtree-boundary-percent-height-expected.txt: Removed.
* platform/chromium/fast/dynamic/subtree-no-common-root-static-y-expected.txt: Removed.
* platform/chromium/fast/dynamic/subtree-table-cell-height-expected.txt: Removed.
* platform/chromium/fast/layers/self-painting-outline-expected.txt: Removed.
* platform/chromium/fast/repaint/subtree-root-clip-3-expected.txt: Removed.
* platform/chromium/test_expectations.txt:
* platform/efl/fast/block/float/033-expected.txt: Removed.
* platform/gtk/css3/selectors3/html/css3-modsel-23-expected.txt: Removed.
* platform/gtk/css3/selectors3/html/css3-modsel-24-expected.txt: Removed.
* platform/gtk/css3/selectors3/html/css3-modsel-68-expected.txt: Removed.
* platform/gtk/css3/selectors3/html/css3-modsel-69-expected.txt: Removed.
* platform/gtk/css3/selectors3/xhtml/css3-modsel-23-expected.txt: Removed.
* platform/gtk/css3/selectors3/xhtml/css3-modsel-24-expected.txt: Removed.
* platform/gtk/css3/selectors3/xhtml/css3-modsel-68-expected.txt: Removed.
* platform/gtk/css3/selectors3/xhtml/css3-modsel-69-expected.txt: Removed.
* platform/gtk/css3/selectors3/xml/css3-modsel-23-expected.txt: Removed.
* platform/gtk/css3/selectors3/xml/css3-modsel-24-expected.txt: Removed.
* platform/gtk/css3/selectors3/xml/css3-modsel-68-expected.txt: Removed.
* platform/gtk/css3/selectors3/xml/css3-modsel-69-expected.txt: Removed.
* platform/gtk/fast/block/float/033-expected.txt: Removed.
* platform/gtk/fast/block/float/avoidance-rtl-expected.txt: Removed.
* platform/gtk/fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Removed.
* platform/gtk/fast/block/float/float-overflow-hidden-containing-block-width-expected.txt: Removed.
* platform/gtk/fast/block/float/in-margin-expected.png: Removed.
* platform/gtk/fast/block/float/in-margin-expected.txt: Removed.
* platform/gtk/fast/block/float/overlapping-floats-with-overflow-hidden-expected.txt: Removed.
* platform/gtk/fast/block/float/shrink-to-avoid-float-complexity-expected.txt: Removed.
* platform/gtk/fast/block/lineboxcontain/parsing-invalid-expected.txt: Removed.
* platform/gtk/fast/clip/017-expected.png: Removed.
* platform/gtk/fast/clip/017-expected.txt: Removed.
* platform/gtk/fast/css/invalidation-errors-2-expected.txt: Removed.
* platform/gtk/fast/css/invalidation-errors-expected.txt: Removed.
* platform/gtk/fast/css/nested-layers-with-hover-expected.txt: Removed.
* platform/gtk/fast/dynamic/subtree-boundary-percent-height-expected.png: Removed.
* platform/gtk/fast/dynamic/subtree-boundary-percent-height-expected.txt: Removed.
* platform/gtk/fast/dynamic/subtree-no-common-root-static-y-expected.png: Removed.
* platform/gtk/fast/dynamic/subtree-no-common-root-static-y-expected.txt: Removed.
* platform/gtk/fast/dynamic/subtree-table-cell-height-expected.png: Removed.
* platform/gtk/fast/dynamic/subtree-table-cell-height-expected.txt: Removed.
* platform/gtk/fast/inline/continuation-outlines-expected.txt: Removed.
* platform/gtk/fast/layers/self-painting-outline-expected.png: Removed.
* platform/gtk/fast/layers/self-painting-outline-expected.txt: Removed.
* platform/gtk/fast/multicol/layers-split-across-columns-expected.txt: Removed.
* platform/gtk/fast/overflow/004-expected.txt: Removed.
* platform/gtk/fast/overflow/clip-rects-fixed-ancestor-expected.txt: Removed.
* platform/gtk/fast/overflow/line-clamp-expected.txt: Removed.
* platform/gtk/fast/overflow/overflow-focus-ring-expected.txt: Removed.
* platform/gtk/fast/repaint/layer-outline-expected.txt: Removed.
* platform/gtk/fast/repaint/layer-outline-horizontal-expected.txt: Removed.
* platform/gtk/fast/repaint/opacity-change-on-overflow-float-expected.txt: Removed.
* platform/gtk/fast/repaint/subtree-root-clip-3-expected.png: Removed.
* platform/gtk/fast/repaint/subtree-root-clip-3-expected.txt: Removed.
* platform/gtk/fast/table/029-expected.txt: Removed.
* platform/gtk/fast/table/overflowHidden-expected.txt: Removed.
* platform/gtk/tables/mozilla/bugs/bug154780-expected.txt: Removed.
* platform/gtk/tables/mozilla_expected_failures/bugs/bug45621-expected.png: Removed.
* platform/gtk/tables/mozilla_expected_failures/bugs/bug45621-expected.txt: Removed.
* platform/mac/fast/block/float/033-expected.txt: Removed.
* platform/mac/fast/block/float/float-not-removed-from-next-sibling3-expected.png: Removed.
* platform/mac/fast/block/float/float-overflow-hidden-containing-block-width-expected.txt: Removed.
* platform/mac/fast/block/float/in-margin-expected.txt: Removed.
* platform/mac/fast/clip/017-expected.txt: Removed.
* platform/mac/fast/dynamic/subtree-boundary-percent-height-expected.txt: Removed.
* platform/mac/fast/dynamic/subtree-no-common-root-static-y-expected.txt: Removed.
* platform/mac/fast/dynamic/subtree-table-cell-height-expected.txt: Removed.
* platform/qt/fast/block/float/avoidance-rtl-expected.txt: Removed.
* platform/qt/fast/block/float/float-overflow-hidden-containing-block-width-expected.txt: Removed.
* platform/qt/fast/block/float/in-margin-expected.txt: Removed.
* platform/qt/fast/clip/017-expected.txt: Removed.
* platform/qt/fast/css/resize-single-axis-expected.txt: Removed.
* platform/qt/fast/dynamic/subtree-boundary-percent-height-expected.txt: Removed.
* platform/qt/fast/dynamic/subtree-no-common-root-static-y-expected.txt: Removed.
* platform/qt/fast/dynamic/subtree-table-cell-height-expected.txt: Removed.
* platform/qt/fast/layers/self-painting-outline-expected.txt: Removed.
* platform/qt/fast/repaint/subtree-root-clip-3-expected.txt: Removed.
* tables/mozilla/bugs/bug154780-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug154780-expected.txt.
* tables/mozilla_expected_failures/bugs/bug45621-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla_expected_failures/bugs/bug45621-expected.png.
* tables/mozilla_expected_failures/bugs/bug45621-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla_expected_failures/bugs/bug45621-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Call isLinkVisited directly
pilgrim@chromium.org [Sat, 12 May 2012 06:45:37 +0000 (06:45 +0000)]
[Chromium] Call isLinkVisited directly
https://bugs.webkit.org/show_bug.cgi?id=85412

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* page/PageGroup.cpp:
(WebCore::PageGroup::isLinkVisited):
* platform/VisitedLinks.cpp: Added.
(WebCore):
(WebCore::VisitedLinks::isLinkVisited):
* platform/VisitedLinks.h: Added.
(WebCore):
(VisitedLinks):
* platform/chromium/PlatformSupport.h:
* platform/chromium/VisitedLinksChromium.cpp: Added.
(WebCore):
(WebCore::VisitedLinks::isLinkVisited):

Source/WebKit/chromium:

* src/PlatformSupport.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoOptimise and update test expectations after r116636
noel.gordon@gmail.com [Sat, 12 May 2012 05:43:35 +0000 (05:43 +0000)]
Optimise and update test expectations after r116636

Unreviewed test expectations update.

* fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Renamed from LayoutTests/platform/efl/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt.
* fast/block/float/014-expected.txt: Renamed from LayoutTests/platform/efl/fast/block/float/014-expected.txt.
* fast/images/gray-scale-jpeg-with-color-profile-expected.txt:
* fast/repaint/backgroundSizeRepaint-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/backgroundSizeRepaint-expected.txt.
* fast/repaint/clipped-relative-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/clipped-relative-expected.txt.
* fast/repaint/selected-replaced-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/selected-replaced-expected.txt.
* fast/replaced/absolute-image-sizing-expected.txt: Renamed from LayoutTests/platform/efl/fast/replaced/absolute-image-sizing-expected.txt.
* fast/replaced/image-onload-expected.txt: Renamed from LayoutTests/platform/efl/fast/replaced/image-onload-expected.txt.
* fast/replaced/image-sizing-expected.txt: Renamed from LayoutTests/platform/efl/fast/replaced/image-sizing-expected.txt.
* fast/replaced/width100percent-image-expected.txt: Renamed from LayoutTests/platform/efl/fast/replaced/width100percent-image-expected.txt.
* fast/writing-mode/background-horizontal-bt-expected.txt: Renamed from LayoutTests/platform/efl/fast/writing-mode/background-horizontal-bt-expected.txt.
* fast/writing-mode/background-vertical-lr-expected.txt: Renamed from LayoutTests/platform/efl/fast/writing-mode/background-vertical-lr-expected.txt.
* fast/writing-mode/background-vertical-rl-expected.txt: Renamed from LayoutTests/platform/efl/fast/writing-mode/background-vertical-rl-expected.txt.
* platform/chromium-linux-x86/fast/backgrounds/size/backgroundSize20-expected.png: Added.
* platform/chromium-linux-x86/fast/backgrounds/size/backgroundSize21-expected.png: Added.
* platform/chromium-linux-x86/fast/backgrounds/size/backgroundSize22-expected.png: Added.
* platform/chromium-linux-x86/fast/replaced/image-tag-expected.png: Added.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug120107-expected.png: Added.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug1271-expected.png: Added.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug12908-2-expected.png: Added.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug13169-expected.png: Added.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug196870-expected.png: Added.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug50695-2-expected.png: Added.
* platform/chromium-linux/compositing/geometry/vertical-scroll-composited-expected.png:
* platform/chromium-linux/fast/backgrounds/size/backgroundSize20-expected.png: Added.
* platform/chromium-linux/fast/backgrounds/size/backgroundSize21-expected.png: Added.
* platform/chromium-linux/fast/backgrounds/size/backgroundSize22-expected.png: Added.
* platform/chromium-linux/fast/backgrounds/size/contain-and-cover-expected.png:
* platform/chromium-linux/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
* platform/chromium-linux/fast/block/float/014-expected.png:
* platform/chromium-linux/fast/images/gray-scale-jpeg-with-color-profile-expected.png:
* platform/chromium-linux/fast/repaint/backgroundSizeRepaint-expected.png:
* platform/chromium-linux/fast/repaint/block-layout-inline-children-replaced-expected.png:
* platform/chromium-linux/fast/repaint/clipped-relative-expected.png:
* platform/chromium-linux/fast/repaint/selected-replaced-expected.png:
* platform/chromium-linux/fast/replaced/absolute-image-sizing-expected.png:
* platform/chromium-linux/fast/replaced/image-onload-expected.png:
* platform/chromium-linux/fast/replaced/image-sizing-expected.png:
* platform/chromium-linux/fast/replaced/image-tag-expected.png: Added.
* platform/chromium-linux/fast/replaced/width100percent-image-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-01-t-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-04-t-expected.png:
* platform/chromium-linux/svg/carto.net/scrollbar-expected.png:
* platform/chromium-linux/svg/carto.net/selectionlist-expected.png:
* platform/chromium-linux/svg/custom/image-rescale-clip-expected.png:
* platform/chromium-linux/svg/custom/image-rescale-scroll-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug101674-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug10565-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug11026-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.txt:
* platform/chromium-linux/tables/mozilla/bugs/bug120107-expected.png: Added.
* platform/chromium-linux/tables/mozilla/bugs/bug1271-expected.png: Added.
* platform/chromium-linux/tables/mozilla/bugs/bug12908-1-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug12908-2-expected.png: Added.
* platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug13169-expected.png: Added.
* platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug15544-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug17138-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug196870-expected.png: Added.
* platform/chromium-linux/tables/mozilla/bugs/bug29314-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug2981-2-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug4093-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug4284-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug4427-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug50695-2-expected.png: Added.
* platform/chromium-linux/tables/mozilla/bugs/bug56563-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug5797-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug625-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug6404-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug82946-2-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug86708-expected.png:
* platform/chromium-linux/tables/mozilla/core/bloomberg-expected.png:
* platform/chromium-linux/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
* platform/chromium-linux/tables/mozilla/core/misc-expected.png:
* platform/chromium-linux/tables/mozilla/core/row_span-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/tbody_valign_middle-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/tbody_valign_top-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/td_valign_baseline-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/td_valign_bottom-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/td_valign_middle-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/td_valign_top-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_top-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/th_valign_baseline-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/th_valign_bottom-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/th_valign_middle-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/th_valign_top-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/thead_valign_baseline-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/thead_valign_bottom-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/thead_valign_middle-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/thead_valign_top-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/tr_valign_baseline-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/tr_valign_bottom-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/tr_valign_middle-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/tr_valign_top-expected.png:
* platform/chromium-linux/tables/mozilla/other/cell_widths-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/other/test4-expected.png:
* platform/chromium-mac-leopard/fast/backgrounds/size/backgroundSize20-expected.png: Added.
* platform/chromium-mac-leopard/fast/backgrounds/size/backgroundSize21-expected.png: Added.
* platform/chromium-mac-leopard/fast/backgrounds/size/backgroundSize22-expected.png: Added.
* platform/chromium-mac-leopard/fast/block/float/014-expected.png:
* platform/chromium-mac-leopard/fast/repaint/backgroundSizeRepaint-expected.png:
* platform/chromium-mac-leopard/fast/repaint/block-layout-inline-children-replaced-expected.png:
* platform/chromium-mac-leopard/fast/repaint/clipped-relative-expected.png:
* platform/chromium-mac-leopard/fast/repaint/selected-replaced-expected.png:
* platform/chromium-mac-leopard/fast/replaced/absolute-image-sizing-expected.png:
* platform/chromium-mac-leopard/fast/replaced/image-onload-expected.png:
* platform/chromium-mac-leopard/fast/replaced/image-sizing-expected.png:
* platform/chromium-mac-leopard/fast/replaced/image-tag-expected.png: Added.
* platform/chromium-mac-leopard/fast/replaced/width100percent-image-expected.png:
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
* platform/chromium-mac-leopard/svg/carto.net/scrollbar-expected.png:
* platform/chromium-mac-leopard/svg/carto.net/selectionlist-expected.png:
* platform/chromium-mac-leopard/svg/custom/image-rescale-clip-expected.png:
* platform/chromium-mac-leopard/svg/custom/image-rescale-scroll-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug101674-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug10565-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug11026-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug1188-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug120107-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug1271-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug12908-1-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug12908-2-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug1296-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug13169-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug1430-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug15544-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug17138-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug196870-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug2981-2-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug4093-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug4284-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug4427-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug50695-2-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug56563-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug5797-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug625-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug6404-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug82946-2-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug86708-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/core/bloomberg-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/core/misc-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/core/row_span-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_middle-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_top-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_baseline-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_bottom-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_middle-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_top-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_top-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_baseline-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_bottom-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_middle-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_top-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_baseline-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_bottom-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_middle-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_top-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_baseline-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_bottom-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_middle-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_top-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/other/cell_widths-expected.png:
* platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
* platform/chromium-mac-leopard/tables/mozilla_expected_failures/other/test4-expected.png:
* platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize20-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize21-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize22-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/block/float/014-expected.png:
* platform/chromium-mac-snowleopard/fast/images/gray-scale-jpeg-with-color-profile-expected.png:
* platform/chromium-mac-snowleopard/fast/repaint/backgroundSizeRepaint-expected.png:
* platform/chromium-mac-snowleopard/fast/repaint/block-layout-inline-children-replaced-expected.png:
* platform/chromium-mac-snowleopard/fast/repaint/clipped-relative-expected.png:
* platform/chromium-mac-snowleopard/fast/repaint/selected-replaced-expected.png:
* platform/chromium-mac-snowleopard/fast/replaced/absolute-image-sizing-expected.png:
* platform/chromium-mac-snowleopard/fast/replaced/image-onload-expected.png:
* platform/chromium-mac-snowleopard/fast/replaced/image-sizing-expected.png:
* platform/chromium-mac-snowleopard/fast/replaced/image-tag-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/replaced/width100percent-image-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
* platform/chromium-mac-snowleopard/svg/carto.net/scrollbar-expected.png:
* platform/chromium-mac-snowleopard/svg/carto.net/selectionlist-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/image-rescale-clip-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/image-rescale-scroll-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug101674-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug10565-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug11026-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug120107-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1271-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug12908-1-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug12908-2-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1296-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug13169-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1430-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug15544-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug17138-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug196870-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug29314-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2981-2-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4093-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4284-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4427-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug50695-2-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug56563-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug5797-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug625-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug6404-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug82946-2-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug86708-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/core/bloomberg-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/core/misc-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/core/row_span-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_middle-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_top-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_baseline-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_bottom-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_middle-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_top-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_top-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_baseline-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_bottom-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_middle-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_top-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_baseline-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_bottom-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_middle-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_top-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_baseline-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_bottom-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_middle-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_top-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/other/cell_widths-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/other/test4-expected.png:
* platform/chromium-mac/compositing/geometry/vertical-scroll-composited-expected.png:
* platform/chromium-mac/fast/backgrounds/size/backgroundSize17-expected.png:
* platform/chromium-mac/fast/backgrounds/size/backgroundSize18-expected.png:
* platform/chromium-mac/fast/backgrounds/size/backgroundSize19-expected.png:
* platform/chromium-mac/fast/backgrounds/size/backgroundSize20-expected.png:
* platform/chromium-mac/fast/backgrounds/size/backgroundSize21-expected.png:
* platform/chromium-mac/fast/backgrounds/size/backgroundSize22-expected.png:
* platform/chromium-mac/fast/backgrounds/size/contain-and-cover-expected.png:
* platform/chromium-mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
* platform/chromium-mac/fast/block/float/014-expected.png:
* platform/chromium-mac/fast/images/gray-scale-jpeg-with-color-profile-expected.png:
* platform/chromium-mac/fast/images/image-css3-content-data-expected.png:
* platform/chromium-mac/fast/images/rgb-jpeg-with-adobe-marker-only-expected.png:
* platform/chromium-mac/fast/images/ycbcr-with-cmyk-color-profile-expected.png:
* platform/chromium-mac/fast/repaint/backgroundSizeRepaint-expected.png:
* platform/chromium-mac/fast/repaint/block-layout-inline-children-replaced-expected.png:
* platform/chromium-mac/fast/repaint/clipped-relative-expected.png:
* platform/chromium-mac/fast/repaint/selected-replaced-expected.png:
* platform/chromium-mac/fast/replaced/absolute-image-sizing-expected.png:
* platform/chromium-mac/fast/replaced/image-onload-expected.png:
* platform/chromium-mac/fast/replaced/image-sizing-expected.png:
* platform/chromium-mac/fast/replaced/image-tag-expected.png:
* platform/chromium-mac/fast/replaced/width100percent-image-expected.png:
* platform/chromium-mac/fast/writing-mode/background-horizontal-bt-expected.png:
* platform/chromium-mac/fast/writing-mode/background-vertical-lr-expected.png:
* platform/chromium-mac/fast/writing-mode/background-vertical-rl-expected.png:
* platform/chromium-mac/platform/chromium/compositing/img-layer-grow-expected.png:
* platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
* platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
* platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
* platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
* platform/chromium-mac/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
* platform/chromium-mac/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt: Removed.
* platform/chromium-mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
* platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-01-t-expected.png:
* platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
* platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-04-t-expected.png:
* platform/chromium-mac/svg/carto.net/scrollbar-expected.png:
* platform/chromium-mac/svg/carto.net/selectionlist-expected.png:
* platform/chromium-mac/svg/custom/image-rescale-clip-expected.png:
* platform/chromium-mac/svg/custom/image-rescale-expected.png:
* platform/chromium-mac/svg/custom/image-rescale-scroll-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
* platform/chromium-mac/svg/repaint/image-href-change-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug101674-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug10565-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug11026-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.txt: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug120107-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug1271-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug12908-1-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug12908-2-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug13169-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug15544-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug17138-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug196870-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug29314-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug2981-2-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug4093-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug4284-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug4427-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug50695-2-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug56563-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug5797-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug625-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug6404-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug82946-2-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug86708-expected.png:
* platform/chromium-mac/tables/mozilla/core/bloomberg-expected.png:
* platform/chromium-mac/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
* platform/chromium-mac/tables/mozilla/core/misc-expected.png:
* platform/chromium-mac/tables/mozilla/core/row_span-expected.png:
* platform/chromium-mac/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
* platform/chromium-mac/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
* platform/chromium-mac/tables/mozilla/marvin/tbody_valign_middle-expected.png:
* platform/chromium-mac/tables/mozilla/marvin/tbody_valign_top-expected.png:
* platform/chromium-mac/tables/mozilla/marvin/td_valign_baseline-expected.png:
* platform/chromium-mac/tables/mozilla/marvin/td_valign_bottom-expected.png:
* platform/chromium-mac/tables/mozilla/marvin/td_valign_middle-expected.png:
* platform/chromium-mac/tables/mozilla/marvin/td_valign_top-expected.png:
* platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
* platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
* platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
* platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_top-expected.png:
* platform/chromium-mac/tables/mozilla/marvin/th_valign_baseline-expected.png:
* platform/chromium-mac/tables/mozilla/marvin/th_valign_bottom-expected.png:
* platform/chromium-mac/tables/mozilla/marvin/th_valign_middle-expected.png:
* platform/chromium-mac/tables/mozilla/marvin/th_valign_top-expected.png:
* platform/chromium-mac/tables/mozilla/marvin/thead_valign_baseline-expected.png:
* platform/chromium-mac/tables/mozilla/marvin/thead_valign_bottom-expected.png:
* platform/chromium-mac/tables/mozilla/marvin/thead_valign_middle-expected.png:
* platform/chromium-mac/tables/mozilla/marvin/thead_valign_top-expected.png:
* platform/chromium-mac/tables/mozilla/marvin/tr_valign_baseline-expected.png:
* platform/chromium-mac/tables/mozilla/marvin/tr_valign_bottom-expected.png:
* platform/chromium-mac/tables/mozilla/marvin/tr_valign_middle-expected.png:
* platform/chromium-mac/tables/mozilla/marvin/tr_valign_top-expected.png:
* platform/chromium-mac/tables/mozilla/other/cell_widths-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/other/test4-expected.png:
* platform/chromium-win-vista/fast/backgrounds/size/backgroundSize20-expected.png: Added.
* platform/chromium-win-vista/fast/backgrounds/size/backgroundSize21-expected.png: Added.
* platform/chromium-win-vista/fast/backgrounds/size/backgroundSize22-expected.png: Added.
* platform/chromium-win-vista/fast/replaced/image-tag-expected.png: Added.
* platform/chromium-win-vista/tables/mozilla/bugs/bug120107-expected.png: Added.
* platform/chromium-win-vista/tables/mozilla/bugs/bug1271-expected.png: Added.
* platform/chromium-win-vista/tables/mozilla/bugs/bug12908-2-expected.png: Added.
* platform/chromium-win-vista/tables/mozilla/bugs/bug13169-expected.png: Added.
* platform/chromium-win-vista/tables/mozilla/bugs/bug196870-expected.png: Added.
* platform/chromium-win-vista/tables/mozilla/bugs/bug50695-2-expected.png: Added.
* platform/chromium-win-xp/fast/backgrounds/size/backgroundSize20-expected.png: Added.
* platform/chromium-win-xp/fast/backgrounds/size/backgroundSize21-expected.png: Added.
* platform/chromium-win-xp/fast/backgrounds/size/backgroundSize22-expected.png: Added.
* platform/chromium-win-xp/fast/replaced/image-tag-expected.png: Added.
* platform/chromium-win-xp/tables/mozilla/bugs/bug120107-expected.png: Added.
* platform/chromium-win-xp/tables/mozilla/bugs/bug1271-expected.png: Added.
* platform/chromium-win-xp/tables/mozilla/bugs/bug12908-2-expected.png: Added.
* platform/chromium-win-xp/tables/mozilla/bugs/bug13169-expected.png: Added.
* platform/chromium-win-xp/tables/mozilla/bugs/bug196870-expected.png: Added.
* platform/chromium-win-xp/tables/mozilla/bugs/bug50695-2-expected.png: Added.
* platform/chromium-win/compositing/geometry/vertical-scroll-composited-expected.png:
* platform/chromium-win/fast/backgrounds/size/backgroundSize17-expected.png:
* platform/chromium-win/fast/backgrounds/size/backgroundSize18-expected.png:
* platform/chromium-win/fast/backgrounds/size/backgroundSize19-expected.png:
* platform/chromium-win/fast/backgrounds/size/backgroundSize20-expected.png:
* platform/chromium-win/fast/backgrounds/size/backgroundSize21-expected.png:
* platform/chromium-win/fast/backgrounds/size/backgroundSize22-expected.png:
* platform/chromium-win/fast/backgrounds/size/contain-and-cover-expected.png:
* platform/chromium-win/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
* platform/chromium-win/fast/block/float/014-expected.png:
* platform/chromium-win/fast/images/gray-scale-jpeg-with-color-profile-expected.png:
* platform/chromium-win/fast/images/image-css3-content-data-expected.png:
* platform/chromium-win/fast/images/rgb-jpeg-with-adobe-marker-only-expected.png:
* platform/chromium-win/fast/images/ycbcr-with-cmyk-color-profile-expected.png:
* platform/chromium-win/fast/repaint/backgroundSizeRepaint-expected.png:
* platform/chromium-win/fast/repaint/block-layout-inline-children-replaced-expected.png:
* platform/chromium-win/fast/repaint/clipped-relative-expected.png:
* platform/chromium-win/fast/repaint/selected-replaced-expected.png:
* platform/chromium-win/fast/replaced/absolute-image-sizing-expected.png:
* platform/chromium-win/fast/replaced/image-onload-expected.png:
* platform/chromium-win/fast/replaced/image-sizing-expected.png:
* platform/chromium-win/fast/replaced/image-tag-expected.png:
* platform/chromium-win/fast/replaced/width100percent-image-expected.png:
* platform/chromium-win/fast/writing-mode/background-horizontal-bt-expected.png:
* platform/chromium-win/fast/writing-mode/background-vertical-lr-expected.png:
* platform/chromium-win/fast/writing-mode/background-vertical-rl-expected.png:
* platform/chromium-win/platform/chromium/compositing/img-layer-grow-expected.png: Removed.
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/struct-image-01-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/struct-image-04-t-expected.png:
* platform/chromium-win/svg/carto.net/scrollbar-expected.png:
* platform/chromium-win/svg/carto.net/selectionlist-expected.png:
* platform/chromium-win/svg/custom/image-rescale-clip-expected.png:
* platform/chromium-win/svg/custom/image-rescale-expected.png:
* platform/chromium-win/svg/custom/image-rescale-scroll-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
* platform/chromium-win/svg/repaint/image-href-change-expected.png: Added.
* platform/chromium-win/tables/mozilla/bugs/bug101674-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug10565-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug11026-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug1188-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug1188-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug120107-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug1271-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug12908-1-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug12908-2-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug1296-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug13169-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug1430-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug15544-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug17138-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug196870-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug29314-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug2981-2-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug4093-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug4284-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug4427-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug50695-2-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug56563-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug5797-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug625-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug6404-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug82946-2-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug86708-expected.png:
* platform/chromium-win/tables/mozilla/core/bloomberg-expected.png:
* platform/chromium-win/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
* platform/chromium-win/tables/mozilla/core/misc-expected.png:
* platform/chromium-win/tables/mozilla/core/row_span-expected.png:
* platform/chromium-win/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
* platform/chromium-win/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
* platform/chromium-win/tables/mozilla/marvin/tbody_valign_middle-expected.png:
* platform/chromium-win/tables/mozilla/marvin/tbody_valign_top-expected.png:
* platform/chromium-win/tables/mozilla/marvin/td_valign_baseline-expected.png:
* platform/chromium-win/tables/mozilla/marvin/td_valign_bottom-expected.png:
* platform/chromium-win/tables/mozilla/marvin/td_valign_middle-expected.png:
* platform/chromium-win/tables/mozilla/marvin/td_valign_top-expected.png:
* platform/chromium-win/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
* platform/chromium-win/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
* platform/chromium-win/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
* platform/chromium-win/tables/mozilla/marvin/tfoot_valign_top-expected.png:
* platform/chromium-win/tables/mozilla/marvin/th_valign_baseline-expected.png:
* platform/chromium-win/tables/mozilla/marvin/th_valign_bottom-expected.png:
* platform/chromium-win/tables/mozilla/marvin/th_valign_middle-expected.png:
* platform/chromium-win/tables/mozilla/marvin/th_valign_top-expected.png:
* platform/chromium-win/tables/mozilla/marvin/thead_valign_baseline-expected.png:
* platform/chromium-win/tables/mozilla/marvin/thead_valign_bottom-expected.png:
* platform/chromium-win/tables/mozilla/marvin/thead_valign_middle-expected.png:
* platform/chromium-win/tables/mozilla/marvin/thead_valign_top-expected.png:
* platform/chromium-win/tables/mozilla/marvin/tr_valign_baseline-expected.png:
* platform/chromium-win/tables/mozilla/marvin/tr_valign_bottom-expected.png:
* platform/chromium-win/tables/mozilla/marvin/tr_valign_middle-expected.png:
* platform/chromium-win/tables/mozilla/marvin/tr_valign_top-expected.png:
* platform/chromium-win/tables/mozilla/other/cell_widths-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/other/test4-expected.png:
* platform/chromium/test_expectations.txt:
* platform/efl/fast/images/gray-scale-jpeg-with-color-profile-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug29314-expected.txt: Removed.
* platform/gtk/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Removed.
* platform/gtk/fast/block/float/014-expected.txt: Removed.
* platform/gtk/fast/images/gray-scale-jpeg-with-color-profile-expected.txt: Removed.
* platform/gtk/fast/repaint/backgroundSizeRepaint-expected.txt: Removed.
* platform/gtk/fast/repaint/clipped-relative-expected.txt: Removed.
* platform/gtk/fast/repaint/selected-replaced-expected.txt: Removed.
* platform/gtk/fast/replaced/absolute-image-sizing-expected.txt: Removed.
* platform/gtk/fast/replaced/image-onload-expected.txt: Removed.
* platform/gtk/fast/replaced/image-sizing-expected.txt: Removed.
* platform/gtk/fast/replaced/width100percent-image-expected.txt: Removed.
* platform/gtk/fast/writing-mode/background-horizontal-bt-expected.txt: Removed.
* platform/gtk/fast/writing-mode/background-vertical-lr-expected.txt: Removed.
* platform/gtk/fast/writing-mode/background-vertical-rl-expected.txt: Removed.
* platform/gtk/svg/carto.net/scrollbar-expected.txt: Removed.
* platform/gtk/svg/carto.net/selectionlist-expected.txt: Removed.
* platform/gtk/tables/mozilla/bugs/bug10565-expected.txt: Removed.
* platform/gtk/tables/mozilla/bugs/bug11026-expected.txt: Removed.
* platform/gtk/tables/mozilla/bugs/bug12908-1-expected.txt: Removed.
* platform/gtk/tables/mozilla/bugs/bug1296-expected.txt: Removed.
* platform/gtk/tables/mozilla/bugs/bug1430-expected.txt: Removed.
* platform/gtk/tables/mozilla/bugs/bug15544-expected.txt: Removed.
* platform/gtk/tables/mozilla/bugs/bug17138-expected.txt: Removed.
* platform/gtk/tables/mozilla/bugs/bug29314-expected.txt: Removed.
* platform/gtk/tables/mozilla/bugs/bug2981-2-expected.txt: Removed.
* platform/gtk/tables/mozilla/bugs/bug4093-expected.txt: Removed.
* platform/gtk/tables/mozilla/bugs/bug4284-expected.txt: Removed.
* platform/gtk/tables/mozilla/bugs/bug4427-expected.txt: Removed.
* platform/gtk/tables/mozilla/bugs/bug56563-expected.txt: Removed.
* platform/gtk/tables/mozilla/bugs/bug5797-expected.txt: Removed.
* platform/gtk/tables/mozilla/bugs/bug625-expected.txt: Removed.
* platform/gtk/tables/mozilla/bugs/bug6404-expected.txt: Removed.
* platform/gtk/tables/mozilla/bugs/bug82946-2-expected.txt: Removed.
* platform/gtk/tables/mozilla/core/bloomberg-expected.txt: Removed.
* platform/gtk/tables/mozilla/core/col_widths_auto_autoFix-expected.txt: Removed.
* platform/gtk/tables/mozilla/core/misc-expected.txt: Removed.
* platform/gtk/tables/mozilla/core/row_span-expected.txt: Removed.
* platform/gtk/tables/mozilla/marvin/tbody_valign_baseline-expected.txt: Removed.
* platform/gtk/tables/mozilla/marvin/tbody_valign_bottom-expected.txt: Removed.
* platform/gtk/tables/mozilla/marvin/tbody_valign_middle-expected.txt: Removed.
* platform/gtk/tables/mozilla/marvin/tbody_valign_top-expected.txt: Removed.
* platform/gtk/tables/mozilla/marvin/td_valign_baseline-expected.txt: Removed.
* platform/gtk/tables/mozilla/marvin/td_valign_bottom-expected.txt: Removed.
* platform/gtk/tables/mozilla/marvin/td_valign_middle-expected.txt: Removed.
* platform/gtk/tables/mozilla/marvin/td_valign_top-expected.txt: Removed.
* platform/gtk/tables/mozilla/marvin/tfoot_valign_baseline-expected.txt: Removed.
* platform/gtk/tables/mozilla/marvin/tfoot_valign_bottom-expected.txt: Removed.
* platform/gtk/tables/mozilla/marvin/tfoot_valign_middle-expected.txt: Removed.
* platform/gtk/tables/mozilla/marvin/tfoot_valign_top-expected.txt: Removed.
* platform/gtk/tables/mozilla/marvin/th_valign_baseline-expected.txt: Removed.
* platform/gtk/tables/mozilla/marvin/th_valign_bottom-expected.txt: Removed.
* platform/gtk/tables/mozilla/marvin/th_valign_middle-expected.txt: Removed.
* platform/gtk/tables/mozilla/marvin/th_valign_top-expected.txt: Removed.
* platform/gtk/tables/mozilla/marvin/thead_valign_baseline-expected.txt: Removed.
* platform/gtk/tables/mozilla/marvin/thead_valign_bottom-expected.txt: Removed.
* platform/gtk/tables/mozilla/marvin/thead_valign_middle-expected.txt: Removed.
* platform/gtk/tables/mozilla/marvin/thead_valign_top-expected.txt: Removed.
* platform/gtk/tables/mozilla/marvin/tr_valign_baseline-expected.txt: Removed.
* platform/gtk/tables/mozilla/marvin/tr_valign_bottom-expected.txt: Removed.
* platform/gtk/tables/mozilla/marvin/tr_valign_middle-expected.txt: Removed.
* platform/gtk/tables/mozilla/marvin/tr_valign_top-expected.txt: Removed.
* platform/gtk/tables/mozilla/other/cell_widths-expected.txt: Removed.
* platform/gtk/tables/mozilla_expected_failures/bugs/bug6933-expected.txt: Removed.
* platform/mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Removed.
* platform/mac/fast/images/gray-scale-jpeg-with-color-profile-expected.txt: Removed.
* platform/mac/tables/mozilla/bugs/bug29314-expected.txt: Removed.
* platform/qt/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Removed.
* platform/qt/fast/images/gray-scale-jpeg-with-color-profile-expected.txt: Copied from LayoutTests/fast/images/gray-scale-jpeg-with-color-profile-expected.txt.
* platform/qt/tables/mozilla/bugs/bug29314-expected.txt: Copied from LayoutTests/tables/mozilla/bugs/bug29314-expected.txt.
* svg/carto.net/scrollbar-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/scrollbar-expected.txt.
* svg/carto.net/selectionlist-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/selectionlist-expected.txt.
* tables/mozilla/bugs/bug10565-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug10565-expected.txt.
* tables/mozilla/bugs/bug11026-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug11026-expected.txt.
* tables/mozilla/bugs/bug12908-1-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug12908-1-expected.txt.
* tables/mozilla/bugs/bug1296-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug1296-expected.txt.
* tables/mozilla/bugs/bug1430-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug1430-expected.txt.
* tables/mozilla/bugs/bug15544-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug15544-expected.txt.
* tables/mozilla/bugs/bug17138-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug17138-expected.txt.
* tables/mozilla/bugs/bug29314-expected.txt:
* tables/mozilla/bugs/bug2981-2-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug2981-2-expected.txt.
* tables/mozilla/bugs/bug4093-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug4093-expected.txt.
* tables/mozilla/bugs/bug4284-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug4284-expected.txt.
* tables/mozilla/bugs/bug4427-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug4427-expected.txt.
* tables/mozilla/bugs/bug56563-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug56563-expected.txt.
* tables/mozilla/bugs/bug5797-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug5797-expected.txt.
* tables/mozilla/bugs/bug625-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug625-expected.txt.
* tables/mozilla/bugs/bug6404-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug6404-expected.txt.
* tables/mozilla/bugs/bug82946-2-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug82946-2-expected.txt.
* tables/mozilla/core/bloomberg-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/core/bloomberg-expected.txt.
* tables/mozilla/core/col_widths_auto_autoFix-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/core/col_widths_auto_autoFix-expected.txt.
* tables/mozilla/core/misc-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/core/misc-expected.txt.
* tables/mozilla/core/row_span-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/core/row_span-expected.txt.
* tables/mozilla/marvin/tbody_valign_baseline-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/tbody_valign_baseline-expected.txt.
* tables/mozilla/marvin/tbody_valign_bottom-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/tbody_valign_bottom-expected.txt.
* tables/mozilla/marvin/tbody_valign_middle-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/tbody_valign_middle-expected.txt.
* tables/mozilla/marvin/tbody_valign_top-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/tbody_valign_top-expected.txt.
* tables/mozilla/marvin/td_valign_baseline-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/td_valign_baseline-expected.txt.
* tables/mozilla/marvin/td_valign_bottom-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/td_valign_bottom-expected.txt.
* tables/mozilla/marvin/td_valign_middle-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/td_valign_middle-expected.txt.
* tables/mozilla/marvin/td_valign_top-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/td_valign_top-expected.txt.
* tables/mozilla/marvin/tfoot_valign_baseline-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/tfoot_valign_baseline-expected.txt.
* tables/mozilla/marvin/tfoot_valign_bottom-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/tfoot_valign_bottom-expected.txt.
* tables/mozilla/marvin/tfoot_valign_middle-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/tfoot_valign_middle-expected.txt.
* tables/mozilla/marvin/tfoot_valign_top-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/tfoot_valign_top-expected.txt.
* tables/mozilla/marvin/th_valign_baseline-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/th_valign_baseline-expected.txt.
* tables/mozilla/marvin/th_valign_bottom-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/th_valign_bottom-expected.txt.
* tables/mozilla/marvin/th_valign_middle-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/th_valign_middle-expected.txt.
* tables/mozilla/marvin/th_valign_top-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/th_valign_top-expected.txt.
* tables/mozilla/marvin/thead_valign_baseline-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/thead_valign_baseline-expected.txt.
* tables/mozilla/marvin/thead_valign_bottom-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/thead_valign_bottom-expected.txt.
* tables/mozilla/marvin/thead_valign_middle-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/thead_valign_middle-expected.txt.
* tables/mozilla/marvin/thead_valign_top-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/thead_valign_top-expected.txt.
* tables/mozilla/marvin/tr_valign_baseline-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/tr_valign_baseline-expected.txt.
* tables/mozilla/marvin/tr_valign_bottom-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/tr_valign_bottom-expected.txt.
* tables/mozilla/marvin/tr_valign_middle-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/tr_valign_middle-expected.txt.
* tables/mozilla/marvin/tr_valign_top-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/tr_valign_top-expected.txt.
* tables/mozilla/other/cell_widths-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/other/cell_widths-expected.txt.
* tables/mozilla_expected_failures/bugs/bug6933-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla_expected_failures/bugs/bug6933-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd previous/next buttons the garden-o-matics perf panel
ojan@chromium.org [Sat, 12 May 2012 03:15:47 +0000 (03:15 +0000)]
Add previous/next buttons the garden-o-matics perf panel
https://bugs.webkit.org/show_bug.cgi?id=86280

Reviewed by Dimitri Glazkov.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/perf.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Port gtest WebViewTest.ActiveState from test_shell_tests to webkit_unit_tests
tony@chromium.org [Sat, 12 May 2012 03:04:41 +0000 (03:04 +0000)]
[chromium] Port gtest WebViewTest.ActiveState from test_shell_tests to webkit_unit_tests
https://bugs.webkit.org/show_bug.cgi?id=86271

Reviewed by James Robinson.

The original test is in src/webkit/glue/webview_unittest.cc.

* tests/WebViewTest.cpp:
(WebKit::TEST_F):
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Plumb --show-paint-rects to accelerated compositor
shawnsingh@chromium.org [Sat, 12 May 2012 02:20:50 +0000 (02:20 +0000)]
[chromium] Plumb --show-paint-rects to accelerated compositor
https://bugs.webkit.org/show_bug.cgi?id=86255

Reviewed by James Robinson.

Source/Platform:

* chromium/public/WebLayerTreeView.h:
(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):

Source/WebKit/chromium:

* public/WebSettings.h:
* src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::Settings::operator CCSettings):
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setShowPaintRects):
(WebKit):
* src/WebSettingsImpl.h:
(WebSettingsImpl):
(WebKit::WebSettingsImpl::showFPSCounter):
(WebKit::WebSettingsImpl::showPlatformLayerTree):
(WebKit::WebSettingsImpl::showPaintRects):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::settingsImpl):
(WebKit::WebViewImpl::settings):
(WebKit):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
* src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[TextureMapper] Tiles are not created for large textures
commit-queue@webkit.org [Sat, 12 May 2012 02:11:10 +0000 (02:11 +0000)]
[TextureMapper] Tiles are not created for large textures
https://bugs.webkit.org/show_bug.cgi?id=86245

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-05-11
Reviewed by Noam Rosenthal.

No new tests. This will not produce any observable behavior changes,
unless run on a machine with a small texture size limit.

The maxTextureSize() method on TextureMapperGL was missing a "const"
keyword, meaning that it was not properly overriding the version in
the abstract base class (TextureMapper). This patch adds the const
modifier and cleans up the list of override methods in the two
TextureMapper sublcasses, adding the OVERRIDE macro for compilers that
support it and removing a couple unused methods.

* platform/graphics/texmap/TextureMapperGL.cpp:
* platform/graphics/texmap/TextureMapperGL.h:
(WebCore::TextureMapperGL::create):
* platform/graphics/texmap/TextureMapperImageBuffer.h:
(TextureMapperImageBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Prevent deadlock on CCVideoLayerImpl destruction
enne@google.com [Sat, 12 May 2012 02:04:46 +0000 (02:04 +0000)]
[chromium] Prevent deadlock on CCVideoLayerImpl destruction
https://bugs.webkit.org/show_bug.cgi?id=86258

Reviewed by James Robinson.

~CCVideoLayerImpl had a common deadlock issue where if it got
destroyed before WebMediaPlayerClientImpl, it would take a lock,
call WebMediaPlayerClientImpl::setVideoFrameProviderClient(0),
which in turn would call CCVideoLayerImpl::stopUsingProvider(),
which would try to take the same lock and would deadlock.

CCVideoLayerImpl is only created and destroyed during tree
synchronization in a commit or during synchronous compositor thread
destruction. In either case, the main thread is blocked, and so no
lock needs to be taken at all.

* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::CCVideoLayerImpl):
(WebCore::CCVideoLayerImpl::~CCVideoLayerImpl):
(WebCore::CCVideoLayerImpl::stopUsingProvider):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r114170): Scroll areas in nested frames improperly placed when tiled...
jpfau@apple.com [Sat, 12 May 2012 02:01:51 +0000 (02:01 +0000)]
REGRESSION (r114170): Scroll areas in nested frames improperly placed when tiled drawing is enabled
https://bugs.webkit.org/show_bug.cgi?id=86239

Reviewed by Anders Carlsson.

.:

* ManualTests/resources/frame-textarea.html: Added.
* ManualTests/scrollable-positioned-frame.html: Added.
* ManualTests/scrollable-positioned-nested-frame.html: Added.

Source/WebCore:

Fixes a regression introduced in r114170 by recursively adding positions of parent frames to placement of nested frame scroll areas.

Manual tests: ManualTests/scrollable-positioned-frame.html
              ManualTests/scrollable-positioned-nested-frame.html

* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::computeNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=86278
bdakin@apple.com [Sat, 12 May 2012 01:19:38 +0000 (01:19 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=86278
Composited layers should only run the overlay scrollbars painting pass
if necessary

Reviewed by Dan Bernstein.

It's not enough that the rootLayer has dirty scrollbars; we also have
to actually be doing the overlay scrollbars painting pass to skip the
early return.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoComcast website displays bottom of page when loaded
andersca@apple.com [Sat, 12 May 2012 00:56:13 +0000 (00:56 +0000)]
Comcast website displays bottom of page when loaded
https://bugs.webkit.org/show_bug.cgi?id=86277
<rdar://problem/11426887>

Reviewed by Beth Dakin.

There were two bugs here. The first bug was that FrameView::setScrollPosition didn't end up calling into the scrolling coordinator
to update the scroll position. The second bug was that ScrollingTreeNodeMac::setScrollPosition didn't constrain the scroll position
to the edge of the page.

* page/FrameView.cpp:
(WebCore::FrameView::setScrollPosition):
Call requestScrollPositionUpdate.

* page/scrolling/ScrollingTree.cpp:
* page/scrolling/ScrollingTree.h:
Remove setMainFrameScrollPosition, it is not called by anyone.

* page/scrolling/mac/ScrollingTreeNodeMac.h:
* page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::setScrollPosition):
Clamp to the page size and call setScrollPositionWithoutContentEdgeConstraints.

(WebCore::ScrollingTreeNodeMac::setScrollPositionWithoutContentEdgeConstraints):
Update the scroll layer position and call back to the main thread.

(WebCore::ScrollingTreeNodeMac::scrollBy):
Call setScrollPosition.

(WebCore::ScrollingTreeNodeMac::scrollByWithoutContentEdgeConstraints):
Call setScrollPositionWithoutContentEdgeConstraints.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoConvert some MathML layout tests to reftests
commit-queue@webkit.org [Sat, 12 May 2012 00:42:16 +0000 (00:42 +0000)]
Convert some MathML layout tests to reftests
https://bugs.webkit.org/show_bug.cgi?id=86250

Patch by David Barton <dbarton@mathscribe.com> on 2012-05-11
Reviewed by Ryosuke Niwa.

* mathml/presentation/msub-base-changed-expected.html: Added.
* mathml/presentation/msub-sub-changed-expected.html: Added.
* mathml/presentation/msubsup-base-changed-expected.html: Added.
* mathml/presentation/msubsup-sub-changed-expected.html: Added.
* mathml/presentation/msubsup-sup-changed-expected.html: Added.
* mathml/presentation/msup-base-changed-expected.html: Added.
* mathml/presentation/msup-sup-changed-expected.html: Added.
* platform/efl/mathml/presentation/msub-base-changed-expected.png: Removed.
* platform/efl/mathml/presentation/msub-base-changed-expected.txt: Removed.
* platform/efl/mathml/presentation/msub-sub-changed-expected.png: Removed.
* platform/efl/mathml/presentation/msub-sub-changed-expected.txt: Removed.
* platform/efl/mathml/presentation/msubsup-base-changed-expected.png: Removed.
* platform/efl/mathml/presentation/msubsup-base-changed-expected.txt: Removed.
* platform/efl/mathml/presentation/msubsup-sub-changed-expected.png: Removed.
* platform/efl/mathml/presentation/msubsup-sub-changed-expected.txt: Removed.
* platform/efl/mathml/presentation/msubsup-sup-changed-expected.png: Removed.
* platform/efl/mathml/presentation/msubsup-sup-changed-expected.txt: Removed.
* platform/efl/mathml/presentation/msup-base-changed-expected.png: Removed.
* platform/efl/mathml/presentation/msup-base-changed-expected.txt: Removed.
* platform/efl/mathml/presentation/msup-sup-changed-expected.png: Removed.
* platform/efl/mathml/presentation/msup-sup-changed-expected.txt: Removed.
* platform/gtk/mathml/presentation/msub-base-changed-expected.txt: Removed.
* platform/gtk/mathml/presentation/msub-sub-changed-expected.txt: Removed.
* platform/gtk/mathml/presentation/msubsup-base-changed-expected.txt: Removed.
* platform/gtk/mathml/presentation/msubsup-sub-changed-expected.txt: Removed.
* platform/gtk/mathml/presentation/msubsup-sup-changed-expected.txt: Removed.
* platform/gtk/mathml/presentation/msup-base-changed-expected.txt: Removed.
* platform/gtk/mathml/presentation/msup-sup-changed-expected.txt: Removed.
* platform/mac/mathml/presentation/msub-base-changed-expected.png: Removed.
* platform/mac/mathml/presentation/msub-base-changed-expected.txt: Removed.
* platform/mac/mathml/presentation/msub-sub-changed-expected.png: Removed.
* platform/mac/mathml/presentation/msub-sub-changed-expected.txt: Removed.
* platform/mac/mathml/presentation/msubsup-base-changed-expected.png: Removed.
* platform/mac/mathml/presentation/msubsup-base-changed-expected.txt: Removed.
* platform/mac/mathml/presentation/msubsup-sub-changed-expected.png: Removed.
* platform/mac/mathml/presentation/msubsup-sub-changed-expected.txt: Removed.
* platform/mac/mathml/presentation/msubsup-sup-changed-expected.png: Removed.
* platform/mac/mathml/presentation/msubsup-sup-changed-expected.txt: Removed.
* platform/mac/mathml/presentation/msup-base-changed-expected.png: Removed.
* platform/mac/mathml/presentation/msup-base-changed-expected.txt: Removed.
* platform/mac/mathml/presentation/msup-sup-changed-expected.png: Removed.
* platform/mac/mathml/presentation/msup-sup-changed-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIntroduce PropertyName class
barraclough@apple.com [Sat, 12 May 2012 00:39:43 +0000 (00:39 +0000)]
Introduce PropertyName class
https://bugs.webkit.org/show_bug.cgi?id=86241

Reviewed by Geoff Garen.

Replace 'const Identifier&' arguments to functions accessing object properties with a new 'PropertyName' type.
This change paves the way to allow for properties keyed by values that are not Identifiers.

This change is largely a mechanical find & replace.
It also changes JSFunction's constructor to take a UString& instead of an Identifier&
(since in some cases we can no longer guarantee that we'lll have an Identifier), and
unifies Identifier's methods to obtain array indices onto PropertyName.

The new PropertyName class retains the ability to support .impl() and .ustring(), but
in a future patch we may need to rework this, since not all PropertyNames should be
equal based on their string representation.

Source/JavaScriptCore:

* API/JSCallbackFunction.cpp:
(JSC::JSCallbackFunction::finishCreation):
* API/JSCallbackFunction.h:
(JSCallbackFunction):
(JSC::JSCallbackFunction::create):
* API/JSCallbackObject.h:
(JSCallbackObject):
* API/JSCallbackObjectFunctions.h:
(JSC::::getOwnPropertySlot):
(JSC::::getOwnPropertyDescriptor):
(JSC::::put):
(JSC::::deleteProperty):
(JSC::::getStaticValue):
(JSC::::staticFunctionGetter):
(JSC::::callbackGetter):
* API/JSObjectRef.cpp:
(JSObjectMakeFunctionWithCallback):
* JSCTypedArrayStubs.h:
(JSC):
* JavaScriptCore.xcodeproj/project.pbxproj:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::getOwnPropertySlot):
(JSC::DebuggerActivation::put):
(JSC::DebuggerActivation::putDirectVirtual):
(JSC::DebuggerActivation::deleteProperty):
(JSC::DebuggerActivation::getOwnPropertyDescriptor):
(JSC::DebuggerActivation::defineOwnProperty):
* debugger/DebuggerActivation.h:
(DebuggerActivation):
* jsc.cpp:
(GlobalObject::addFunction):
(GlobalObject::addConstructableFunction):
* runtime/Arguments.cpp:
(JSC::Arguments::getOwnPropertySlot):
(JSC::Arguments::getOwnPropertyDescriptor):
(JSC::Arguments::put):
(JSC::Arguments::deleteProperty):
(JSC::Arguments::defineOwnProperty):
* runtime/Arguments.h:
(Arguments):
* runtime/ArrayConstructor.cpp:
(JSC::ArrayConstructor::finishCreation):
(JSC::ArrayConstructor::getOwnPropertySlot):
(JSC::ArrayConstructor::getOwnPropertyDescriptor):
* runtime/ArrayConstructor.h:
(ArrayConstructor):
* runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::getOwnPropertySlot):
(JSC::ArrayPrototype::getOwnPropertyDescriptor):
(JSC::putProperty):
* runtime/ArrayPrototype.h:
(ArrayPrototype):
* runtime/BooleanConstructor.cpp:
(JSC::BooleanConstructor::finishCreation):
* runtime/BooleanPrototype.cpp:
(JSC::BooleanPrototype::getOwnPropertySlot):
(JSC::BooleanPrototype::getOwnPropertyDescriptor):
* runtime/BooleanPrototype.h:
(BooleanPrototype):
* runtime/ClassInfo.h:
(MethodTable):
* runtime/DateConstructor.cpp:
(JSC::DateConstructor::finishCreation):
(JSC::DateConstructor::getOwnPropertySlot):
(JSC::DateConstructor::getOwnPropertyDescriptor):
* runtime/DateConstructor.h:
(DateConstructor):
* runtime/DatePrototype.cpp:
(JSC::DatePrototype::getOwnPropertySlot):
(JSC::DatePrototype::getOwnPropertyDescriptor):
* runtime/DatePrototype.h:
(DatePrototype):
* runtime/Error.h:
(JSC::StrictModeTypeErrorFunction::create):
* runtime/ErrorConstructor.cpp:
(JSC::ErrorConstructor::finishCreation):
* runtime/ErrorPrototype.cpp:
(JSC::ErrorPrototype::getOwnPropertySlot):
(JSC::ErrorPrototype::getOwnPropertyDescriptor):
* runtime/ErrorPrototype.h:
(ErrorPrototype):
* runtime/FunctionConstructor.cpp:
(JSC::FunctionConstructor::finishCreation):
* runtime/FunctionPrototype.cpp:
(JSC::FunctionPrototype::finishCreation):
(JSC::FunctionPrototype::addFunctionProperties):
(JSC::functionProtoFuncBind):
* runtime/FunctionPrototype.h:
(JSC::FunctionPrototype::create):
(FunctionPrototype):
* runtime/Identifier.cpp:
(JSC):
* runtime/Identifier.h:
(Identifier):
* runtime/InternalFunction.cpp:
(JSC::InternalFunction::finishCreation):
* runtime/InternalFunction.h:
(InternalFunction):
* runtime/JSActivation.cpp:
(JSC::JSActivation::symbolTableGet):
(JSC::JSActivation::symbolTablePut):
(JSC::JSActivation::symbolTablePutWithAttributes):
(JSC::JSActivation::getOwnPropertySlot):
(JSC::JSActivation::put):
(JSC::JSActivation::putDirectVirtual):
(JSC::JSActivation::deleteProperty):
(JSC::JSActivation::argumentsGetter):
* runtime/JSActivation.h:
(JSActivation):
* runtime/JSArray.cpp:
(JSC::JSArray::defineOwnProperty):
(JSC::JSArray::getOwnPropertySlot):
(JSC::JSArray::getOwnPropertyDescriptor):
(JSC::JSArray::put):
(JSC::JSArray::deleteProperty):
* runtime/JSArray.h:
(JSArray):
(JSC):
* runtime/JSBoundFunction.cpp:
(JSC::JSBoundFunction::create):
(JSC::JSBoundFunction::finishCreation):
* runtime/JSBoundFunction.h:
(JSBoundFunction):
* runtime/JSCell.cpp:
(JSC::JSCell::getOwnPropertySlot):
(JSC::JSCell::put):
(JSC::JSCell::deleteProperty):
(JSC::JSCell::putDirectVirtual):
(JSC::JSCell::defineOwnProperty):
(JSC::JSCell::getOwnPropertyDescriptor):
* runtime/JSCell.h:
(JSCell):
* runtime/JSFunction.cpp:
(JSC::JSFunction::create):
(JSC::JSFunction::finishCreation):
(JSC::JSFunction::argumentsGetter):
(JSC::JSFunction::callerGetter):
(JSC::JSFunction::lengthGetter):
(JSC::JSFunction::getOwnPropertySlot):
(JSC::JSFunction::getOwnPropertyDescriptor):
(JSC::JSFunction::put):
(JSC::JSFunction::deleteProperty):
(JSC::JSFunction::defineOwnProperty):
(JSC::getCalculatedDisplayName):
* runtime/JSFunction.h:
(JSFunction):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::put):
(JSC::JSGlobalObject::putDirectVirtual):
(JSC::JSGlobalObject::defineOwnProperty):
(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::createThrowTypeError):
(JSC::JSGlobalObject::getOwnPropertySlot):
(JSC::JSGlobalObject::getOwnPropertyDescriptor):
* runtime/JSGlobalObject.h:
(JSGlobalObject):
(JSC::JSGlobalObject::hasOwnPropertyForWrite):
(JSC::JSGlobalObject::symbolTableHasProperty):
* runtime/JSNotAnObject.cpp:
(JSC::JSNotAnObject::getOwnPropertySlot):
(JSC::JSNotAnObject::getOwnPropertyDescriptor):
(JSC::JSNotAnObject::put):
(JSC::JSNotAnObject::deleteProperty):
* runtime/JSNotAnObject.h:
(JSNotAnObject):
* runtime/JSONObject.cpp:
(JSC::JSONObject::getOwnPropertySlot):
(JSC::JSONObject::getOwnPropertyDescriptor):
* runtime/JSONObject.h:
(JSONObject):
* runtime/JSObject.cpp:
(JSC::JSObject::put):
(JSC::JSObject::putDirectVirtual):
(JSC::JSObject::putDirectAccessor):
(JSC::JSObject::hasProperty):
(JSC::JSObject::deleteProperty):
(JSC::JSObject::hasOwnProperty):
(JSC::callDefaultValueFunction):
(JSC::JSObject::findPropertyHashEntry):
(JSC::JSObject::getPropertySpecificValue):
(JSC::JSObject::removeDirect):
(JSC::JSObject::getOwnPropertyDescriptor):
(JSC::JSObject::getPropertyDescriptor):
(JSC::putDescriptor):
(JSC::JSObject::defineOwnProperty):
* runtime/JSObject.h:
(JSObject):
(JSC::JSObject::getDirect):
(JSC::JSObject::getDirectLocation):
(JSC::JSObject::inlineGetOwnPropertySlot):
(JSC::JSObject::getOwnPropertySlot):
(JSC::JSCell::fastGetOwnPropertySlot):
(JSC::JSObject::getPropertySlot):
(JSC::JSObject::get):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::putOwnDataProperty):
(JSC::JSObject::putDirect):
(JSC::JSObject::putDirectWithoutTransition):
(JSC::JSValue::get):
(JSC::JSValue::put):
* runtime/JSStaticScopeObject.cpp:
(JSC::JSStaticScopeObject::put):
(JSC::JSStaticScopeObject::putDirectVirtual):
(JSC::JSStaticScopeObject::getOwnPropertySlot):
* runtime/JSStaticScopeObject.h:
(JSStaticScopeObject):
* runtime/JSString.cpp:
(JSC::JSString::getOwnPropertySlot):
(JSC::JSString::getStringPropertyDescriptor):
* runtime/JSString.h:
(JSString):
(JSC::JSString::getStringPropertySlot):
* runtime/JSValue.cpp:
(JSC::JSValue::putToPrimitive):
* runtime/JSValue.h:
(JSC):
(JSValue):
* runtime/JSVariableObject.cpp:
(JSC::JSVariableObject::deleteProperty):
(JSC::JSVariableObject::symbolTableGet):
(JSC::JSVariableObject::putDirectVirtual):
* runtime/JSVariableObject.h:
(JSVariableObject):
(JSC::JSVariableObject::symbolTableGet):
(JSC::JSVariableObject::symbolTablePut):
(JSC::JSVariableObject::symbolTablePutWithAttributes):
* runtime/Lookup.cpp:
(JSC::setUpStaticFunctionSlot):
* runtime/Lookup.h:
(JSC::HashTable::entry):
(JSC):
(JSC::getStaticPropertySlot):
(JSC::getStaticPropertyDescriptor):
(JSC::getStaticFunctionSlot):
(JSC::getStaticFunctionDescriptor):
(JSC::getStaticValueSlot):
(JSC::getStaticValueDescriptor):
(JSC::lookupPut):
* runtime/MathObject.cpp:
(JSC::MathObject::getOwnPropertySlot):
(JSC::MathObject::getOwnPropertyDescriptor):
* runtime/MathObject.h:
(MathObject):
* runtime/NativeErrorConstructor.h:
(JSC::NativeErrorConstructor::finishCreation):
* runtime/NumberConstructor.cpp:
(JSC):
(JSC::NumberConstructor::finishCreation):
(JSC::NumberConstructor::getOwnPropertySlot):
(JSC::NumberConstructor::getOwnPropertyDescriptor):
(JSC::NumberConstructor::put):
(JSC::numberConstructorNaNValue):
(JSC::numberConstructorNegInfinity):
(JSC::numberConstructorPosInfinity):
(JSC::numberConstructorMaxValue):
(JSC::numberConstructorMinValue):
* runtime/NumberConstructor.h:
(NumberConstructor):
* runtime/NumberPrototype.cpp:
(JSC::NumberPrototype::getOwnPropertySlot):
(JSC::NumberPrototype::getOwnPropertyDescriptor):
* runtime/NumberPrototype.h:
(NumberPrototype):
* runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::finishCreation):
(JSC::ObjectConstructor::getOwnPropertySlot):
(JSC::ObjectConstructor::getOwnPropertyDescriptor):
* runtime/ObjectConstructor.h:
(ObjectConstructor):
* runtime/ObjectPrototype.cpp:
(JSC::ObjectPrototype::put):
(JSC::ObjectPrototype::defineOwnProperty):
(JSC::ObjectPrototype::getOwnPropertySlot):
(JSC::ObjectPrototype::getOwnPropertyDescriptor):
* runtime/ObjectPrototype.h:
(ObjectPrototype):
* runtime/PropertySlot.h:
(PropertySlot):
(JSC::PropertySlot::getValue):
* runtime/RegExpConstructor.cpp:
(JSC):
(JSC::RegExpConstructor::finishCreation):
(JSC::RegExpConstructor::getOwnPropertySlot):
(JSC::RegExpConstructor::getOwnPropertyDescriptor):
(JSC::regExpConstructorDollar1):
(JSC::regExpConstructorDollar2):
(JSC::regExpConstructorDollar3):
(JSC::regExpConstructorDollar4):
(JSC::regExpConstructorDollar5):
(JSC::regExpConstructorDollar6):
(JSC::regExpConstructorDollar7):
(JSC::regExpConstructorDollar8):
(JSC::regExpConstructorDollar9):
(JSC::regExpConstructorInput):
(JSC::regExpConstructorMultiline):
(JSC::regExpConstructorLastMatch):
(JSC::regExpConstructorLastParen):
(JSC::regExpConstructorLeftContext):
(JSC::regExpConstructorRightContext):
(JSC::RegExpConstructor::put):
* runtime/RegExpConstructor.h:
(RegExpConstructor):
* runtime/RegExpMatchesArray.h:
(JSC::RegExpMatchesArray::getOwnPropertySlot):
(JSC::RegExpMatchesArray::getOwnPropertyDescriptor):
(JSC::RegExpMatchesArray::put):
(JSC::RegExpMatchesArray::deleteProperty):
(JSC::RegExpMatchesArray::defineOwnProperty):
* runtime/RegExpObject.cpp:
(JSC):
(JSC::RegExpObject::getOwnPropertySlot):
(JSC::RegExpObject::getOwnPropertyDescriptor):
(JSC::RegExpObject::deleteProperty):
(JSC::RegExpObject::defineOwnProperty):
(JSC::regExpObjectGlobal):
(JSC::regExpObjectIgnoreCase):
(JSC::regExpObjectMultiline):
(JSC::regExpObjectSource):
(JSC::RegExpObject::put):
* runtime/RegExpObject.h:
(RegExpObject):
* runtime/RegExpPrototype.cpp:
(JSC::RegExpPrototype::getOwnPropertySlot):
(JSC::RegExpPrototype::getOwnPropertyDescriptor):
* runtime/RegExpPrototype.h:
(RegExpPrototype):
* runtime/StrictEvalActivation.cpp:
(JSC::StrictEvalActivation::deleteProperty):
* runtime/StrictEvalActivation.h:
(StrictEvalActivation):
* runtime/StringConstructor.cpp:
(JSC::StringConstructor::finishCreation):
(JSC::StringConstructor::getOwnPropertySlot):
(JSC::StringConstructor::getOwnPropertyDescriptor):
* runtime/StringConstructor.h:
(StringConstructor):
* runtime/StringObject.cpp:
(JSC::StringObject::getOwnPropertySlot):
(JSC::StringObject::getOwnPropertyDescriptor):
(JSC::StringObject::put):
(JSC::StringObject::defineOwnProperty):
(JSC::StringObject::deleteProperty):
* runtime/StringObject.h:
(StringObject):
* runtime/StringPrototype.cpp:
(JSC::StringPrototype::getOwnPropertySlot):
(JSC::StringPrototype::getOwnPropertyDescriptor):
* runtime/StringPrototype.h:
(StringPrototype):
* runtime/Structure.cpp:
(JSC::Structure::despecifyDictionaryFunction):
(JSC::Structure::addPropertyTransitionToExistingStructure):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::removePropertyTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::attributeChangeTransition):
(JSC::Structure::addPropertyWithoutTransition):
(JSC::Structure::removePropertyWithoutTransition):
(JSC::Structure::get):
(JSC::Structure::despecifyFunction):
(JSC::Structure::putSpecificValue):
(JSC::Structure::remove):
* runtime/Structure.h:
(Structure):
(JSC::Structure::get):

Source/WebCore:

* WebCore.exp.in:
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::cssPropertyIDForJSCSSPropertyName):
(WebCore::JSCSSStyleDeclaration::getOwnPropertySlotDelegate):
(WebCore::JSCSSStyleDeclaration::getOwnPropertyDescriptorDelegate):
(WebCore::JSCSSStyleDeclaration::putDelegate):
* bindings/js/JSDOMBinding.cpp:
(WebCore::findAtomicString):
(WebCore::objectToStringFunctionGetter):
* bindings/js/JSDOMBinding.h:
(WebCore):
(WebCore::propertyNameToString):
(WebCore::propertyNameToAtomicString):
* bindings/js/JSDOMMimeTypeArrayCustom.cpp:
(WebCore::JSDOMMimeTypeArray::canGetItemsForName):
(WebCore::JSDOMMimeTypeArray::nameGetter):
* bindings/js/JSDOMPluginArrayCustom.cpp:
(WebCore::JSDOMPluginArray::canGetItemsForName):
(WebCore::JSDOMPluginArray::nameGetter):
* bindings/js/JSDOMPluginCustom.cpp:
(WebCore::JSDOMPlugin::canGetItemsForName):
(WebCore::JSDOMPlugin::nameGetter):
* bindings/js/JSDOMStringMapCustom.cpp:
(WebCore::JSDOMStringMap::canGetItemsForName):
(WebCore::JSDOMStringMap::nameGetter):
(WebCore::JSDOMStringMap::deleteProperty):
(WebCore::JSDOMStringMap::putDelegate):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::nonCachingStaticFunctionGetter):
(WebCore::childFrameGetter):
(WebCore::namedItemGetter):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertyDescriptor):
(WebCore::JSDOMWindow::put):
(WebCore::JSDOMWindow::deleteProperty):
(WebCore::JSDOMWindow::defineOwnProperty):
* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::getOwnPropertySlot):
(WebCore::JSDOMWindowShell::getOwnPropertyDescriptor):
(WebCore::JSDOMWindowShell::put):
(WebCore::JSDOMWindowShell::putDirectVirtual):
(WebCore::JSDOMWindowShell::defineOwnProperty):
(WebCore::JSDOMWindowShell::deleteProperty):
* bindings/js/JSDOMWindowShell.h:
(JSDOMWindowShell):
* bindings/js/JSHTMLAllCollectionCustom.cpp:
(WebCore::getNamedItems):
(WebCore::callHTMLAllCollection):
(WebCore::JSHTMLAllCollection::canGetItemsForName):
(WebCore::JSHTMLAllCollection::nameGetter):
(WebCore::JSHTMLAllCollection::item):
* bindings/js/JSHTMLAppletElementCustom.cpp:
(WebCore::JSHTMLAppletElement::getOwnPropertySlotDelegate):
(WebCore::JSHTMLAppletElement::getOwnPropertyDescriptorDelegate):
(WebCore::JSHTMLAppletElement::putDelegate):
* bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::getNamedItems):
(WebCore::JSHTMLCollection::canGetItemsForName):
(WebCore::JSHTMLCollection::nameGetter):
* bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::canGetItemsForName):
(WebCore::JSHTMLDocument::nameGetter):
* bindings/js/JSHTMLEmbedElementCustom.cpp:
(WebCore::JSHTMLEmbedElement::getOwnPropertySlotDelegate):
(WebCore::JSHTMLEmbedElement::getOwnPropertyDescriptorDelegate):
(WebCore::JSHTMLEmbedElement::putDelegate):
* bindings/js/JSHTMLFormElementCustom.cpp:
(WebCore::JSHTMLFormElement::canGetItemsForName):
(WebCore::JSHTMLFormElement::nameGetter):
* bindings/js/JSHTMLFrameSetElementCustom.cpp:
(WebCore::JSHTMLFrameSetElement::canGetItemsForName):
(WebCore::JSHTMLFrameSetElement::nameGetter):
* bindings/js/JSHTMLObjectElementCustom.cpp:
(WebCore::JSHTMLObjectElement::getOwnPropertySlotDelegate):
(WebCore::JSHTMLObjectElement::getOwnPropertyDescriptorDelegate):
(WebCore::JSHTMLObjectElement::putDelegate):
* bindings/js/JSHistoryCustom.cpp:
(WebCore::nonCachingStaticBackFunctionGetter):
(WebCore::nonCachingStaticForwardFunctionGetter):
(WebCore::nonCachingStaticGoFunctionGetter):
(WebCore::JSHistory::getOwnPropertySlotDelegate):
(WebCore::JSHistory::getOwnPropertyDescriptorDelegate):
(WebCore::JSHistory::putDelegate):
(WebCore::JSHistory::deleteProperty):
* bindings/js/JSLocationCustom.cpp:
(WebCore::nonCachingStaticReplaceFunctionGetter):
(WebCore::nonCachingStaticReloadFunctionGetter):
(WebCore::nonCachingStaticAssignFunctionGetter):
(WebCore::JSLocation::getOwnPropertySlotDelegate):
(WebCore::JSLocation::getOwnPropertyDescriptorDelegate):
(WebCore::JSLocation::putDelegate):
(WebCore::JSLocation::deleteProperty):
(WebCore::JSLocation::defineOwnProperty):
(WebCore::JSLocationPrototype::putDelegate):
(WebCore::JSLocationPrototype::defineOwnProperty):
* bindings/js/JSNamedNodeMapCustom.cpp:
(WebCore::JSNamedNodeMap::canGetItemsForName):
(WebCore::JSNamedNodeMap::nameGetter):
* bindings/js/JSNodeListCustom.cpp:
(WebCore::JSNodeList::canGetItemsForName):
(WebCore::JSNodeList::nameGetter):
* bindings/js/JSPluginElementFunctions.cpp:
(WebCore::runtimeObjectPropertyGetter):
(WebCore::runtimeObjectCustomGetOwnPropertySlot):
(WebCore::runtimeObjectCustomGetOwnPropertyDescriptor):
(WebCore::runtimeObjectCustomPut):
* bindings/js/JSPluginElementFunctions.h:
(WebCore):
* bindings/js/JSStorageCustom.cpp:
(WebCore::JSStorage::canGetItemsForName):
(WebCore::JSStorage::nameGetter):
(WebCore::JSStorage::deleteProperty):
(WebCore::JSStorage::putDelegate):
* bindings/js/JSStyleSheetListCustom.cpp:
(WebCore::JSStyleSheetList::canGetItemsForName):
(WebCore::JSStyleSheetList::nameGetter):
* bindings/js/JSWorkerContextCustom.cpp:
(WebCore::JSWorkerContext::getOwnPropertySlotDelegate):
(WebCore::JSWorkerContext::getOwnPropertyDescriptorDelegate):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeader):
(GenerateImplementation):
(GenerateConstructorDeclaration):
(GenerateConstructorDefinition):
* bridge/c/c_class.cpp:
(JSC::Bindings::CClass::methodsNamed):
(JSC::Bindings::CClass::fieldNamed):
* bridge/c/c_class.h:
(CClass):
* bridge/c/c_instance.cpp:
(JSC::Bindings::CRuntimeMethod::create):
(JSC::Bindings::CRuntimeMethod::finishCreation):
(JSC::Bindings::CInstance::getMethod):
* bridge/c/c_instance.h:
(CInstance):
* bridge/jni/jsc/JavaClassJSC.cpp:
(JavaClass::methodsNamed):
(JavaClass::fieldNamed):
* bridge/jni/jsc/JavaClassJSC.h:
(JavaClass):
* bridge/jni/jsc/JavaInstanceJSC.cpp:
(JavaRuntimeMethod::create):
(JavaRuntimeMethod::finishCreation):
* bridge/jni/jsc/JavaInstanceJSC.h:
(JavaInstance):
* bridge/jsc/BridgeJSC.h:
(Class):
(JSC::Bindings::Class::fallbackObject):
(JSC::Bindings::Instance::setValueOfUndefinedField):
(Instance):
(JSC::Bindings::Instance::getOwnPropertySlot):
(JSC::Bindings::Instance::getOwnPropertyDescriptor):
(JSC::Bindings::Instance::put):
* bridge/objc/objc_class.h:
(ObjcClass):
* bridge/objc/objc_class.mm:
(JSC::Bindings::ObjcClass::methodsNamed):
(JSC::Bindings::ObjcClass::fieldNamed):
(JSC::Bindings::ObjcClass::fallbackObject):
* bridge/objc/objc_instance.h:
(ObjcInstance):
* bridge/objc/objc_instance.mm:
(ObjCRuntimeMethod::create):
(ObjCRuntimeMethod::finishCreation):
(ObjcInstance::setValueOfUndefinedField):
(ObjcInstance::getValueOfUndefinedField):
* bridge/objc/objc_runtime.h:
(JSC::Bindings::ObjcFallbackObjectImp::create):
(JSC::Bindings::ObjcFallbackObjectImp::propertyName):
(ObjcFallbackObjectImp):
* bridge/objc/objc_runtime.mm:
(JSC::Bindings::ObjcFallbackObjectImp::ObjcFallbackObjectImp):
(JSC::Bindings::ObjcFallbackObjectImp::getOwnPropertySlot):
(JSC::Bindings::ObjcFallbackObjectImp::getOwnPropertyDescriptor):
(JSC::Bindings::ObjcFallbackObjectImp::put):
(JSC::Bindings::callObjCFallbackObject):
(JSC::Bindings::ObjcFallbackObjectImp::deleteProperty):
(JSC::Bindings::ObjcFallbackObjectImp::defaultValue):
* bridge/runtime_array.cpp:
(JSC::RuntimeArray::lengthGetter):
(JSC::RuntimeArray::getOwnPropertySlot):
(JSC::RuntimeArray::getOwnPropertyDescriptor):
(JSC::RuntimeArray::put):
(JSC::RuntimeArray::deleteProperty):
* bridge/runtime_array.h:
(RuntimeArray):
* bridge/runtime_method.cpp:
(JSC::RuntimeMethod::finishCreation):
(JSC::RuntimeMethod::lengthGetter):
(JSC::RuntimeMethod::getOwnPropertySlot):
(JSC::RuntimeMethod::getOwnPropertyDescriptor):
* bridge/runtime_method.h:
(JSC::RuntimeMethod::create):
(RuntimeMethod):
* bridge/runtime_object.cpp:
(JSC::Bindings::RuntimeObject::fallbackObjectGetter):
(JSC::Bindings::RuntimeObject::fieldGetter):
(JSC::Bindings::RuntimeObject::methodGetter):
(JSC::Bindings::RuntimeObject::getOwnPropertySlot):
(JSC::Bindings::RuntimeObject::getOwnPropertyDescriptor):
(JSC::Bindings::RuntimeObject::put):
(JSC::Bindings::RuntimeObject::deleteProperty):
* bridge/runtime_object.h:
(RuntimeObject):

Source/WebKit/mac:

* Plugins/Hosted/ProxyInstance.h:
(ProxyInstance):
* Plugins/Hosted/ProxyInstance.mm:
(ProxyClass):
(WebKit::ProxyClass::methodsNamed):
(WebKit::ProxyClass::fieldNamed):
(WebKit::ProxyRuntimeMethod::create):
(WebKit::ProxyRuntimeMethod::finishCreation):
(WebKit::ProxyInstance::getMethod):
(WebKit::ProxyInstance::methodsNamed):
(WebKit::ProxyInstance::fieldNamed):

Source/WebKit2:

* WebProcess/Plugins/Netscape/JSNPMethod.cpp:
(WebKit::JSNPMethod::finishCreation):
* WebProcess/Plugins/Netscape/JSNPMethod.h:
(WebKit::JSNPMethod::create):
(JSNPMethod):
* WebProcess/Plugins/Netscape/JSNPObject.cpp:
(WebKit::npIdentifierFromIdentifier):
(WebKit::JSNPObject::getOwnPropertySlot):
(WebKit::JSNPObject::getOwnPropertyDescriptor):
(WebKit::JSNPObject::put):
(WebKit::JSNPObject::deleteProperty):
(WebKit::JSNPObject::propertyGetter):
(WebKit::JSNPObject::methodGetter):
* WebProcess/Plugins/Netscape/JSNPObject.h:
(JSNPObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agouse after free in WebCore::RenderObject::document
commit-queue@webkit.org [Sat, 12 May 2012 00:28:32 +0000 (00:28 +0000)]
use after free in WebCore::RenderObject::document
https://bugs.webkit.org/show_bug.cgi?id=84891

Patch by David Barton <dbarton@mathscribe.com> on 2012-05-11
Reviewed by Julien Chaffraix.

Source/WebCore:

Change RenderMathMLFenced::addChild() to use the beforeChild parameter. When beforeChild
is 0, insert child renderers before the closing fence, which might not be the same as
this->lastChild(), e.g. possibly due to anonymous blocks or generated content.

Tests: mathml/presentation/mfenced-add-child1-expected.html
       mathml/presentation/mfenced-add-child1.html
       mathml/presentation/mfenced-add-child2-expected.html
       mathml/presentation/mfenced-add-child2.html

* rendering/mathml/RenderMathMLFenced.cpp:
(WebCore::RenderMathMLFenced::RenderMathMLFenced):
(WebCore::RenderMathMLFenced::makeFences):
(WebCore::RenderMathMLFenced::addChild):
* rendering/mathml/RenderMathMLFenced.h:
(RenderMathMLFenced):

LayoutTests:

* mathml/presentation/mfenced-add-child1-expected.html: Added.
* mathml/presentation/mfenced-add-child1.html: Added.
* mathml/presentation/mfenced-add-child2-expected.html: Added.
* mathml/presentation/mfenced-add-child2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDo a DEPS roll per build failure caused by r116810.
rniwa@webkit.org [Sat, 12 May 2012 00:14:15 +0000 (00:14 +0000)]
Do a DEPS roll per build failure caused by r116810.

See http://webkitmemes.tumblr.com/post/21734202168/the-solution-to-any-chromium-problem for the rationale.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCan't scroll on webpage after following links from Blogger
andersca@apple.com [Sat, 12 May 2012 00:09:04 +0000 (00:09 +0000)]
Can't scroll on webpage after following links from Blogger
https://bugs.webkit.org/show_bug.cgi?id=86274
<rdar://problem/11431352>

Reviewed by Beth Dakin.

When committing a new scroll layer, make sure to reset the scroll position.

* page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::commitNewTreeState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[TextureMapper] Support drawing debug borders
commit-queue@webkit.org [Fri, 11 May 2012 23:57:55 +0000 (23:57 +0000)]
[TextureMapper] Support drawing debug borders
https://bugs.webkit.org/show_bug.cgi?id=86237

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-05-11
Reviewed by Noam Rosenthal.

No new tests. This is the implementation of an interactive debugging
feature.

* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayer::create): Moved this to the top of the file to
reduce contention for the coveted last spot in the file. This also
follows the pattern used in many WebCore files of having the factories
at the top.
(WebCore::GraphicsLayerTextureMapper::setDebugBorder): Added this
plumbing.
* platform/graphics/texmap/GraphicsLayerTextureMapper.h: Added
plumbing.
* platform/graphics/texmap/TextureMapper.h: Ditto.
* platform/graphics/texmap/TextureMapperBackingStore.cpp:
(WebCore::TextureMapperTiledBackingStore::TextureMapperTiledBackingStore):
Initialize the new member.
(WebCore::TextureMapperTiledBackingStore::paintToTextureMapper): When
debug borders are enabled call the new drawBorder method on the TM.
(WebCore::TextureMapperTiledBackingStore::setDebugBorder): Added this
plumbing.
* platform/graphics/texmap/TextureMapperBackingStore.h: Added plumbing
and members to store debug border states. This is necessary because of
the when painting there is no handle on the GraphicsLayers.
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::drawRect): Factored out the common bits of
drawTexture and drawBorder into this helper.
(WebCore::TextureMapperGL::drawBorder): Added this method, which works
very similarly to drawTexture, but uses a different shader program and
must also set the line width and color.
(WebCore::TextureMapperGL::drawTexture): Factored out the bits that
are shared with drawRect.
* platform/graphics/texmap/TextureMapperGL.h:
(TextureMapperGL): Added the new method declarations.
* platform/graphics/texmap/TextureMapperImageBuffer.h:
(WebCore::TextureMapperImageBuffer::drawBorder): Added an empty
implementation. Later we can add an implementation for the ImageBuffer
TM.
* platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::updateBackingStore): When updating the
backing store send the debug border information through.
(WebCore::TextureMapperLayer::syncCompositingStateSelf): When updating
the layer state, also update the debug indicators. This is required to
initialize the debug border values for the layer.
(WebCore::TextureMapperLayer::setDebugBorder): Added this plumbing.
* platform/graphics/texmap/TextureMapperLayer.h: Ditto.
* platform/graphics/texmap/TextureMapperShaderManager.cpp: Added a
solid color shader that doesn't care about texture coordinates or
opacity values.
(WebCore::TextureMapperShaderManager::solidColorProgram): Added. This
is a shorter getter for the solid color program that doesn't require
casting from the caller.
(WebCore::TextureMapperShaderManager::getShaderProgram): Added support
for the solid color program.
(WebCore::TextureMapperShaderProgramSolidColor::create): Added.
(WebCore::TextureMapperShaderProgramSolidColor::TextureMapperShaderProgramSolidColor):
Ditto.
(WebCore::TextureMapperShaderProgramSolidColor::vertexShaderSource):
Ditto.
(WebCore::TextureMapperShaderProgramSolidColor::fragmentShaderSource):
Ditto.
* platform/graphics/texmap/TextureMapperShaderManager.h:
(TextureMapperShaderProgramSolidColor): Added.
(WebCore::TextureMapperShaderProgramSolidColor::colorVariable): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRolling out r116659.
msaboff@apple.com [Fri, 11 May 2012 23:50:02 +0000 (23:50 +0000)]
Rolling out r116659.

Causes ASSERT failures on bots.

Rubber stamped by Geoff Garen.

* heap/Heap.cpp:
(JSC::Heap::markRoots):
* heap/MarkStack.cpp:
(JSC::MarkStackThreadSharedData::markingThreadMain):
(JSC::MarkStackThreadSharedData::markingThreadStartFunc):
(JSC::MarkStackThreadSharedData::MarkStackThreadSharedData):
(JSC::MarkStackThreadSharedData::reset):
(JSC::MarkStack::reset):
(JSC):
(JSC::SlotVisitor::copyAndAppend):
* heap/MarkStack.h:
(MarkStackThreadSharedData):
(MarkStack):
* runtime/JSString.h:
(JSString):
(JSC::JSString::finishCreation):
(JSC::JSString::is8Bit):
(JSC::JSRopeString::finishCreation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoInstrument timer function calls so they show up in the Web Inspector Timeline.
timothy@apple.com [Fri, 11 May 2012 23:40:47 +0000 (23:40 +0000)]
Instrument timer function calls so they show up in the Web Inspector Timeline.

https://webkit.org/b/86173

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/timeline/timeline-timer.html

* bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::executeFunctionInContext): Wrap the call with JSMainThreadExecState::instrumentFunctionCall
and InspectorInstrumentation::didCallFunction.

LayoutTests:

* inspector/timeline/timeline-injected-script-eval-expected.txt: Updated for the blocked scriptName and scriptLine.
* inspector/timeline/timeline-script-tag-1-expected.txt: Updated for the blocked lineNumber.
* inspector/timeline/timeline-script-tag-2-expected.txt: Ditto.
* inspector/timeline/timeline-test.js: Block scriptName, scriptLine, lineNumber and timerId.
* inspector/timeline/timeline-timer-expected.txt: Added.
* inspector/timeline/timeline-timer.html: Added.
* platform/chromium/inspector/timeline/timeline-timer-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<rdar://problem/11361907> and https://bugs.webkit.org/show_bug.cgi?id=86265
beidson@apple.com [Fri, 11 May 2012 23:20:14 +0000 (23:20 +0000)]
<rdar://problem/11361907> and https://bugs.webkit.org/show_bug.cgi?id=86265
REGRESSION(r104885): Images missing from printed YummySoup! recipes

We thought clients were passing paths as URLs.
It turns out it was more likely they were passing file: URLs with the file: scheme removed.
And that jives perfectly with the behavior change caused by r104885.

Reviewed by Alexey Proskuryakov.

Rename _webkit_URLFromURLOrPath to _webkit_URLFromURLOrSchemelessFileURL, and change it
to create the new URL simply by appending "file:":
* Misc/WebNSURLExtras.h:
* Misc/WebNSURLExtras.mm:
(-[NSURL _webkit_URLFromURLOrSchemelessFileURL]):

* WebView/WebFrame.mm:
(-[WebFrame loadRequest:]): Create the fixed url simply by appending "file:" to the
  existing URL string.
(-[WebFrame loadData:MIMEType:textEncodingName:baseURL:]):
(-[WebFrame loadHTMLString:baseURL:]):
(-[WebFrame loadAlternateHTMLString:baseURL:forUnreachableURL:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] [WK2] Memory leak in PluginProcessProxy::scanPlugin
commit-queue@webkit.org [Fri, 11 May 2012 23:08:16 +0000 (23:08 +0000)]
[GTK] [WK2] Memory leak in PluginProcessProxy::scanPlugin
https://bugs.webkit.org/show_bug.cgi?id=86240

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-11
Reviewed by Martin Robinson.

Free the output received from the g_spawn_sync().

* UIProcess/Plugins/gtk/PluginProcessProxyGtk.cpp:
(WebKit::PluginProcessProxy::scanPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAppease thread verifier when dealing with the JSC API's shared VM
oliver@apple.com [Fri, 11 May 2012 23:07:51 +0000 (23:07 +0000)]
Appease thread verifier when dealing with the JSC API's shared VM
https://bugs.webkit.org/show_bug.cgi?id=86268

Reviewed by Geoffrey Garen.

If we're the shared VM, just disable the verifier.  This makes debug builds
livable against non-webkit clients.

* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium/mac] Let libwebkit.dylib link in Debug/components build
thakis@chromium.org [Fri, 11 May 2012 23:03:45 +0000 (23:03 +0000)]
[chromium/mac] Let libwebkit.dylib link in Debug/components build
https://bugs.webkit.org/show_bug.cgi?id=86244

Reviewed by James Robinson.

In static builds, this was not needed because the targets depending on
'webkit' already link in QuartzCore. In Release components builds, it wasn't
needed because they are built with -dead_strip, which stripped the referencing
code.

* WebCore.gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove a Chromium test expectation now that the regression is fixed in r116814.
rniwa@webkit.org [Fri, 11 May 2012 22:58:11 +0000 (22:58 +0000)]
Remove a Chromium test expectation now that the regression is fixed in r116814.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r116802.
commit-queue@webkit.org [Fri, 11 May 2012 22:55:42 +0000 (22:55 +0000)]
Unreviewed, rolling out r116802.
http://trac.webkit.org/changeset/116802
https://bugs.webkit.org/show_bug.cgi?id=86260

This patch causes compiling error to chromium builds
(Requested by jianli_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-11

Source/WebCore:

* WebCore.gypi:

Source/WebKit/chromium:

* features.gypi:
* src/WebInputEventConversion.cpp:
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

LayoutTests:

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRegression fix after r116798.
rniwa@webkit.org [Fri, 11 May 2012 22:38:32 +0000 (22:38 +0000)]
Regression fix after r116798.

We need to return true for the html element in the design mode
in which case parentNode() is editable and is not a body element.

* dom/Node.cpp:
(WebCore::Node::isRootEditableElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoJIT memory allocator is not returning memory to the OS on Darwin
fpizlo@apple.com [Fri, 11 May 2012 22:37:13 +0000 (22:37 +0000)]
JIT memory allocator is not returning memory to the OS on Darwin
https://bugs.webkit.org/show_bug.cgi?id=86047

Reviewed by Geoff Garen.

* jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::FixedVMPoolExecutableAllocator::notifyPageIsFree):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Move createLocalStorageNamespace to Platform.h
pilgrim@chromium.org [Fri, 11 May 2012 22:30:34 +0000 (22:30 +0000)]
[Chromium] Move createLocalStorageNamespace to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=85766

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/Platform:

* Platform.gypi:
* chromium/public/Platform.h:
(WebKit):
(Platform):
(WebKit::Platform::createLocalStorageNamespace):
* chromium/public/WebStorageArea.h: Added.
(WebKit):
(WebStorageArea):
(WebKit::WebStorageArea::~WebStorageArea):
(WebKit::WebStorageArea::setItem):
(WebKit::WebStorageArea::removeItem):
(WebKit::WebStorageArea::clear):
* chromium/public/WebStorageNamespace.h: Added.
(WebKit):
(WebStorageNamespace):
(WebKit::WebStorageNamespace::~WebStorageNamespace):
(WebKit::WebStorageNamespace::isSameNamespace):

Source/WebKit/chromium:

* WebKit.gyp:
* public/WebStorageArea.h:
* public/WebStorageNamespace.h:
* public/platform/WebKitPlatformSupport.h:
(WebKit):
(WebKit::WebKitPlatformSupport::blobRegistry):
* src/StorageAreaProxy.cpp:
* src/StorageNamespaceProxy.cpp:
(WebCore::StorageNamespace::localStorageNamespace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Move implementation of WebCore::GraphicsContext3D and related from WebKit...
jamesr@google.com [Fri, 11 May 2012 22:19:38 +0000 (22:19 +0000)]
[chromium] Move implementation of WebCore::GraphicsContext3D and related from WebKit/chromium/src to WebCore/platform/chromium/support
https://bugs.webkit.org/show_bug.cgi?id=86257

Reviewed by Adam Barth.

Source/WebCore:

The WebCore platform interfaces GraphicsContext3D and Extensions3DChromium are implemented in chromium on top of
the Platform interface WebGraphicsContext3D. This moves the implementation support code from WebKit/chromium/src
to WebCore/platform/chromium/support, which avoids having code in WebKit/ implementing WebCore interfaces and
allows code in WebCore/platform to use this support code directly where appropriate.

Refactor only, no new functionality or tests.

* WebCore.gypi:
* platform/chromium/support/Extensions3DChromium.cpp: Renamed from Source/WebKit/chromium/src/Extensions3DChromium.cpp.
(WebCore):
(WebCore::Extensions3DChromium::Extensions3DChromium):
(WebCore::Extensions3DChromium::~Extensions3DChromium):
(WebCore::Extensions3DChromium::supports):
(WebCore::Extensions3DChromium::ensureEnabled):
(WebCore::Extensions3DChromium::isEnabled):
(WebCore::Extensions3DChromium::getGraphicsResetStatusARB):
(WebCore::Extensions3DChromium::blitFramebuffer):
(WebCore::Extensions3DChromium::renderbufferStorageMultisample):
(WebCore::Extensions3DChromium::postSubBufferCHROMIUM):
(WebCore::Extensions3DChromium::mapBufferSubDataCHROMIUM):
(WebCore::Extensions3DChromium::unmapBufferSubDataCHROMIUM):
(WebCore::Extensions3DChromium::mapTexSubImage2DCHROMIUM):
(WebCore::Extensions3DChromium::unmapTexSubImage2DCHROMIUM):
(WebCore::Extensions3DChromium::setVisibilityCHROMIUM):
(WebCore::Extensions3DChromium::discardFramebufferEXT):
(WebCore::Extensions3DChromium::ensureFramebufferCHROMIUM):
(WebCore::Extensions3DChromium::setGpuMemoryAllocationChangedCallbackCHROMIUM):
(WebCore::Extensions3DChromium::createVertexArrayOES):
(WebCore::Extensions3DChromium::deleteVertexArrayOES):
(WebCore::Extensions3DChromium::isVertexArrayOES):
(WebCore::Extensions3DChromium::bindVertexArrayOES):
(WebCore::Extensions3DChromium::getTranslatedShaderSourceANGLE):
(WebCore::Extensions3DChromium::setSwapBuffersCompleteCallbackCHROMIUM):
(WebCore::Extensions3DChromium::rateLimitOffscreenContextCHROMIUM):
(WebCore::Extensions3DChromium::paintFramebufferToCanvas):
(WebCore::Extensions3DChromium::texImageIOSurface2DCHROMIUM):
(WebCore::Extensions3DChromium::texStorage2DEXT):
(WebCore::Extensions3DChromium::createQueryEXT):
(WebCore::Extensions3DChromium::deleteQueryEXT):
(WebCore::Extensions3DChromium::isQueryEXT):
(WebCore::Extensions3DChromium::beginQueryEXT):
(WebCore::Extensions3DChromium::endQueryEXT):
(WebCore::Extensions3DChromium::getQueryivEXT):
(WebCore::Extensions3DChromium::getQueryObjectuivEXT):
* platform/chromium/support/GraphicsContext3DChromium.cpp: Renamed from Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp.
(WebCore):
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::createGraphicsContextFromWebContext):
(WebCore::GraphicsContext3DPrivate::extractWebGraphicsContext3D):
(WebCore::GraphicsContext3DPrivate::platformGraphicsContext3D):
(WebCore::GraphicsContext3DPrivate::platformTexture):
(GrMemoryAllocationChangedCallback):
(WebCore::GrMemoryAllocationChangedCallback::GrMemoryAllocationChangedCallback):
(WebCore::GrMemoryAllocationChangedCallback::onGpuMemoryAllocationChanged):
(WebCore::GraphicsContext3DPrivate::grContext):
(WebCore::GraphicsContext3DPrivate::prepareTexture):
(WebCore::GraphicsContext3DPrivate::markContextChanged):
(WebCore::GraphicsContext3DPrivate::markLayerComposited):
(WebCore::GraphicsContext3DPrivate::layerComposited):
(WebCore::GraphicsContext3DPrivate::paintFramebufferToCanvas):
(WebCore::GraphicsContext3DPrivate::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3DPrivate::paintCompositedResultsToCanvas):
(WebCore::GraphicsContext3DPrivate::paintRenderingResultsToImageData):
(WebCore::GraphicsContext3DPrivate::reshape):
(WebCore::GraphicsContext3DPrivate::getInternalFramebufferSize):
(WebCore::GraphicsContext3DPrivate::isContextLost):
(WebCore::GraphicsContext3DPrivate::isGLES2Compliant):
(WebCore::GraphicsContext3DPrivate::bindAttribLocation):
(WebCore::GraphicsContext3DPrivate::bufferData):
(WebCore::GraphicsContext3DPrivate::bufferSubData):
(WebCore::GraphicsContext3DPrivate::getActiveAttrib):
(WebCore::GraphicsContext3DPrivate::getActiveUniform):
(WebCore::GraphicsContext3DPrivate::getAttribLocation):
(WebCore::GraphicsContext3DPrivate::getContextAttributes):
(WebCore::GraphicsContext3DPrivate::getProgramInfoLog):
(WebCore::GraphicsContext3DPrivate::getShaderInfoLog):
(WebCore::GraphicsContext3DPrivate::getShaderSource):
(WebCore::GraphicsContext3DPrivate::getString):
(WebCore::GraphicsContext3DPrivate::getUniformLocation):
(WebCore::GraphicsContext3DPrivate::shaderSource):
(WebCore::GraphicsContext3DPrivate::texImage2D):
(WebCore::GraphicsContext3DPrivate::texSubImage2D):
(WebCore::GraphicsContext3DPrivate::uniform1fv):
(WebCore::GraphicsContext3DPrivate::uniform1iv):
(WebCore::GraphicsContext3DPrivate::uniform2fv):
(WebCore::GraphicsContext3DPrivate::uniform2iv):
(WebCore::GraphicsContext3DPrivate::uniform3fv):
(WebCore::GraphicsContext3DPrivate::uniform3iv):
(WebCore::GraphicsContext3DPrivate::uniform4fv):
(WebCore::GraphicsContext3DPrivate::uniform4iv):
(WebCore::GraphicsContext3DPrivate::uniformMatrix2fv):
(WebCore::GraphicsContext3DPrivate::uniformMatrix3fv):
(WebCore::GraphicsContext3DPrivate::uniformMatrix4fv):
(WebCore::GraphicsContext3DPrivate::getExtensions):
(WebCore::GraphicsContext3DPrivate::isResourceSafe):
(WebCore::GraphicsContext3DPrivate::initializeExtensions):
(WebCore::GraphicsContext3DPrivate::supportsExtension):
(WebCore::GraphicsContext3DPrivate::ensureExtensionEnabled):
(WebCore::GraphicsContext3DPrivate::isExtensionEnabled):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::platformGraphicsContext3D):
(WebCore::GraphicsContext3D::platformTexture):
(WebCore::GraphicsContext3D::grContext):
(WebCore::GraphicsContext3D::prepareTexture):
(WebCore::GraphicsContext3D::getInternalFramebufferSize):
(WebCore::GraphicsContext3D::isResourceSafe):
(WebCore::GraphicsContext3D::platformLayer):
(WebCore::GraphicsContext3D::layerComposited):
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):
(GraphicsContextLostCallbackAdapter):
(WebCore::GraphicsContextLostCallbackAdapter::~GraphicsContextLostCallbackAdapter):
(WebCore::GraphicsContextLostCallbackAdapter::GraphicsContextLostCallbackAdapter):
(WebCore::GraphicsContextLostCallbackAdapter::onContextLost):
(WebCore::GraphicsContextLostCallbackAdapter::create):
(WebCore::GraphicsContext3DPrivate::setContextLostCallback):
(GraphicsErrorMessageCallbackAdapter):
(WebCore::GraphicsErrorMessageCallbackAdapter::~GraphicsErrorMessageCallbackAdapter):
(WebCore::GraphicsErrorMessageCallbackAdapter::GraphicsErrorMessageCallbackAdapter):
(WebCore::GraphicsErrorMessageCallbackAdapter::onErrorMessage):
(WebCore::GraphicsErrorMessageCallbackAdapter::create):
(WebCore::GraphicsContext3DPrivate::setErrorMessageCallback):
(WebCore::GraphicsContext3D::isGLES2Compliant):
(GraphicsContext3DSwapBuffersCompleteCallbackAdapter):
(WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::~GraphicsContext3DSwapBuffersCompleteCallbackAdapter):
(WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::GraphicsContext3DSwapBuffersCompleteCallbackAdapter):
(WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::onSwapBuffersComplete):
(WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::create):
(WebCore::GraphicsContext3DPrivate::setSwapBuffersCompleteCallbackCHROMIUM):
(GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::~GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::onMemoryAllocationChanged):
(WebCore::GraphicsContext3DPrivate::setGpuMemoryAllocationChangedCallbackCHROMIUM):
* platform/chromium/support/GraphicsContext3DPrivate.h: Renamed from Source/WebKit/chromium/src/GraphicsContext3DPrivate.h.
(WebKit):
(WebCore):
(GraphicsContext3DPrivate):

Source/WebKit/chromium:

* WebKit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Expose WebPluginContainer of WebPlugin to embedder
fsamuel@chromium.org [Fri, 11 May 2012 22:18:35 +0000 (22:18 +0000)]
[Chromium] Expose WebPluginContainer of WebPlugin to embedder
https://bugs.webkit.org/show_bug.cgi?id=85916

Reviewed by Darin Fisher.

The browser plugin needs to access its current guest's  WebPluginContainer
so that it can replace the guest with another guest WebPlugin when navigating
across processes.

* public/WebPlugin.h:
(WebPlugin):
(WebKit::WebPlugin::container):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoClarified JSGlobalData (JavaScript VM) lifetime
ggaren@apple.com [Fri, 11 May 2012 22:17:00 +0000 (22:17 +0000)]
Clarified JSGlobalData (JavaScript VM) lifetime
https://bugs.webkit.org/show_bug.cgi?id=85142

Reviewed by Alexey Proskuryakov.

(Follow-up fix.)

* API/JSContextRef.cpp:
(JSGlobalContextCreate): Restored some code I removed because I misread an #ifdef.
(We don't need to test BUILDING_ON_LEOPARD, but we still need the linked-on
test, because apps might have been linked on older OS's.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIntegrate IETC CSS : xml namespace tests
tomz@codeaurora.org [Fri, 11 May 2012 21:53:20 +0000 (21:53 +0000)]
Integrate IETC CSS : xml namespace tests
https://bugs.webkit.org/show_bug.cgi?id=86144

Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-05-11
Reviewed by Adam Barth.

Integrating 17 IETC xml namespace tests, along with associated
reference tests.

* ietestcenter/css3/namespaces/declaring-001-expected.xml: Added.
* ietestcenter/css3/namespaces/declaring-001.xml: Added.
* ietestcenter/css3/namespaces/prefix-007-expected.xml: Added.
* ietestcenter/css3/namespaces/prefix-007.xml: Added.
* ietestcenter/css3/namespaces/prefix-008-expected.xml: Added.
* ietestcenter/css3/namespaces/prefix-008.xml: Added.
* ietestcenter/css3/namespaces/prefix-009-expected.xml: Added.
* ietestcenter/css3/namespaces/prefix-009.xml: Added.
* ietestcenter/css3/namespaces/prefix-010-expected.xml: Added.
* ietestcenter/css3/namespaces/prefix-010.xml: Added.
* ietestcenter/css3/namespaces/prefix-011-expected.xml: Added.
* ietestcenter/css3/namespaces/prefix-011.xml: Added.
* ietestcenter/css3/namespaces/qualifiedNames-001-expected.xml: Added.
* ietestcenter/css3/namespaces/qualifiedNames-001.xml: Added.
* ietestcenter/css3/namespaces/scope-003-expected.xml: Added.
* ietestcenter/css3/namespaces/scope-003.xml: Added.
* ietestcenter/css3/namespaces/syntax-016-expected.xml: Added.
* ietestcenter/css3/namespaces/syntax-016.xml: Added.
* ietestcenter/css3/namespaces/syntax-017-expected.xml: Added.
* ietestcenter/css3/namespaces/syntax-017.xml: Added.
* ietestcenter/css3/namespaces/syntax-018-expected.xml: Added.
* ietestcenter/css3/namespaces/syntax-018.xml: Added.
* ietestcenter/css3/namespaces/syntax-019-expected.xml: Added.
* ietestcenter/css3/namespaces/syntax-019.xml: Added.
* ietestcenter/css3/namespaces/syntax-020-expected.xml: Added.
* ietestcenter/css3/namespaces/syntax-020.xml: Added.
* ietestcenter/css3/namespaces/syntax-021-expected.xml: Added.
* ietestcenter/css3/namespaces/syntax-021.xml: Added.
* ietestcenter/css3/namespaces/syntax-022-expected.xml: Added.
* ietestcenter/css3/namespaces/syntax-022.xml: Added.
* ietestcenter/css3/namespaces/syntax-023-expected.xml: Added.
* ietestcenter/css3/namespaces/syntax-023.xml: Added.
* ietestcenter/css3/namespaces/terminology-001-expected.xml: Added.
* ietestcenter/css3/namespaces/terminology-001.xml: Added.
* platform/chromium/test_expectations.txt:
* platform/efl/test_expectations.txt:
* platform/gtk/test_expectations.txt:
* platform/mac/test_expectations.txt:
* platform/qt/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Mark 1 crashed test for chromium mac.
jianli@chromium.org [Fri, 11 May 2012 21:49:32 +0000 (21:49 +0000)]
Unreviewed. Mark 1 crashed test for chromium mac.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImageSkia.cpp does not conform to style guidelines
commit-queue@webkit.org [Fri, 11 May 2012 21:40:50 +0000 (21:40 +0000)]
ImageSkia.cpp does not conform to style guidelines
https://bugs.webkit.org/show_bug.cgi?id=86219

Patch by Keyar Hood <keyar@chromium.org> on 2012-05-11
Reviewed by Stephen White.

No tests as this is purely style changees.

* platform/graphics/skia/ImageSkia.cpp:
(WebCore::TransformDimensions):
(WebCore::BitmapImage::draw):
(WebCore::BitmapImageSingleFrameSkia::draw):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Rebaseline one test for chromium mac.
jianli@chromium.org [Fri, 11 May 2012 21:36:20 +0000 (21:36 +0000)]
Unreviewed. Rebaseline one test for chromium mac.

* platform/chromium-mac-leopard/css3/filters/custom/effect-color-check-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, GTK rebaseline after fonts update in r116778.
philn@webkit.org [Fri, 11 May 2012 21:28:02 +0000 (21:28 +0000)]
Unreviewed, GTK rebaseline after fonts update in r116778.

* platform/gtk/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
* platform/gtk/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
* platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
* platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
* platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
* platform/gtk/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
* platform/gtk/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
* platform/gtk/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:
* platform/gtk/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/gtk/fast/css/line-height-determined-by-primary-font-expected.txt:
* platform/gtk/fast/dynamic/text-combine-expected.txt:
* platform/gtk/fast/encoding/denormalised-voiced-japanese-chars-expected.txt:
* platform/gtk/fast/repaint/japanese-rl-selection-clear-expected.txt:
* platform/gtk/fast/repaint/japanese-rl-selection-repaint-expected.txt:
* platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
* platform/gtk/fast/repaint/repaint-across-writing-mode-boundary-expected.txt:
* platform/gtk/fast/ruby/base-shorter-than-text-expected.txt:
* platform/gtk/fast/ruby/nested-ruby-expected.txt:
* platform/gtk/fast/text/backslash-to-yen-sign-euc-expected.txt:
* platform/gtk/fast/text/backslash-to-yen-sign-expected.txt:
* platform/gtk/fast/text/emphasis-combined-text-expected.txt:
* platform/gtk/fast/text/emphasis-vertical-expected.txt:
* platform/gtk/fast/text/international/001-expected.txt:
* platform/gtk/fast/text/international/002-expected.txt:
* platform/gtk/fast/text/international/003-expected.txt:
* platform/gtk/fast/text/international/plane2-expected.txt:
* platform/gtk/fast/text/international/text-combine-image-test-expected.txt:
* platform/gtk/fast/text/international/text-spliced-font-expected.txt:
* platform/gtk/fast/text/international/vertical-text-glyph-test-expected.txt:
* platform/gtk/fast/text/international/vertical-text-metrics-test-expected.txt:
* platform/gtk/fast/text/international/wrap-CJK-001-expected.txt:
* platform/gtk/fast/text/justify-ideograph-complex-expected.txt:
* platform/gtk/fast/text/justify-ideograph-simple-expected.txt:
* platform/gtk/fast/text/justify-ideograph-vertical-expected.txt:
* platform/gtk/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
* platform/gtk/fast/writing-mode/border-vertical-lr-expected.txt:
* platform/gtk/fast/writing-mode/fallback-orientation-expected.txt:
* platform/gtk/fast/writing-mode/japanese-lr-selection-expected.txt:
* platform/gtk/fast/writing-mode/japanese-lr-text-expected.txt:
* platform/gtk/fast/writing-mode/japanese-rl-selection-expected.txt:
* platform/gtk/fast/writing-mode/japanese-rl-text-expected.txt:
* platform/gtk/fast/writing-mode/japanese-ruby-horizontal-bt-expected.txt:
* platform/gtk/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
* platform/gtk/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:
* platform/gtk/fast/writing-mode/vertical-align-table-baseline-expected.txt:
* platform/gtk/fast/writing-mode/vertical-baseline-alignment-expected.txt:
* platform/gtk/fast/writing-mode/vertical-font-fallback-expected.txt:
* platform/gtk/svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt:
* platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
* platform/gtk/svg/dom/altGlyph-dom-expected.txt:
* platform/gtk/svg/text/text-fonts-01-t-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed Chromium build fix after http://trac.webkit.org/changeset/116799.
timothy_horton@apple.com [Fri, 11 May 2012 21:24:09 +0000 (21:24 +0000)]
Unreviewed Chromium build fix after trac.webkit.org/changeset/116799.

* rendering/RenderLayerBacking.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Compute the best target node on a GestureTap event
commit-queue@webkit.org [Fri, 11 May 2012 21:16:19 +0000 (21:16 +0000)]
[chromium] Compute the best target node on a GestureTap event
https://bugs.webkit.org/show_bug.cgi?id=85101

Patch by Terry Anderson <tdanderson@chromium.org> on 2012-05-11
Reviewed by Adam Barth.

Source/WebCore:

Will be using the tests in the touchadjustment/ directory.

* WebCore.gypi:
Include TouchAdjustment.* files.

Source/WebKit/chromium:

* features.gypi:
Enable the touch adjustment code by default.
* src/WebInputEventConversion.cpp:
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
In the case of a GestureTap, deltaX represents the horizontal padding of the touch
area and deltaY represents the vertical padding of the touch area.

LayoutTests:

* platform/chromium/test_expectations.txt:
Skipping two layout tests in the touchadjustment/ directory that
fail using DRT but pass when I run through the test cases manually.
Allan Jensen experiences a similar problem with these two tests
on the qt port (see comment 36 in the bug description) and will be
investigating why these tests have unexpected behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r116498.
commit-queue@webkit.org [Fri, 11 May 2012 21:12:02 +0000 (21:12 +0000)]
Unreviewed, rolling out r116498.
http://trac.webkit.org/changeset/116498
https://bugs.webkit.org/show_bug.cgi?id=86251

Causes crashes in major sites and security issues (Requested
by schenney on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-11

Source/WebCore:

* rendering/svg/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::addChild):
* rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::willBeDestroyed):
(WebCore::RenderSVGInlineText::setTextInternal):
(WebCore::RenderSVGInlineText::styleDidChange):
* rendering/svg/RenderSVGText.cpp:
(WebCore::recursiveUpdateLayoutAttributes):
(WebCore::RenderSVGText::layoutAttributesChanged):
(WebCore::RenderSVGText::layoutAttributesWillBeDestroyed):
(WebCore::RenderSVGText::invalidateTextPositioningElements):
(WebCore::recursiveUpdateScaledFont):
(WebCore::RenderSVGText::layout):
(WebCore::RenderSVGText::addChild):
(WebCore::recursiveCollectLayoutAttributes):
(WebCore::RenderSVGText::rebuildLayoutAttributes):
(WebCore):
* rendering/svg/RenderSVGText.h:
(RenderSVGText):
(WebCore::RenderSVGText::layoutAttributes):
* rendering/svg/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation):
* rendering/svg/SVGTextLayoutAttributesBuilder.cpp:
(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributes):

LayoutTests:

* svg/text/add-tspan-position-bug-expected.html: Removed.
* svg/text/add-tspan-position-bug.html: Removed.
* svg/text/modify-tspan-position-bug-expected.html: Removed.
* svg/text/modify-tspan-position-bug.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[wx] Unreviewed build fixes for recent trunk changes and 32-bit ld *nix builds.
kevino@webkit.org [Fri, 11 May 2012 20:24:31 +0000 (20:24 +0000)]
[wx] Unreviewed build fixes for recent trunk changes and 32-bit ld *nix builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFrameView->m_lastPaintTime is not updated in the tiled drawing case
timothy_horton@apple.com [Fri, 11 May 2012 20:16:47 +0000 (20:16 +0000)]
FrameView->m_lastPaintTime is not updated in the tiled drawing case
https://bugs.webkit.org/show_bug.cgi?id=86246
<rdar://problem/11248475>

Reviewed by Simon Fraser.

Update FrameView's m_lastPaintTime from RenderLayerBacking::paintContents
if the RenderLayerBacking is backing a tiled drawing layer.

In the future we might want to consider updating m_lastPaintTime when any
compositing layer is painted into, but this change gets us on par with the
non-tiled-drawing case as it stands now.

No new tests.

* page/FrameView.h:
(WebCore::FrameView::setLastPaintTime):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd helper function for node()->rootEditableElement() == node()
commit-queue@webkit.org [Fri, 11 May 2012 20:09:13 +0000 (20:09 +0000)]
Add helper function for node()->rootEditableElement() == node()
https://bugs.webkit.org/show_bug.cgi?id=86217

Patch by Shezan Baig <shezbaig.wk@gmail.com> on 2012-05-11
Reviewed by Ryosuke Niwa.

Added Node::isRootEditableElement and updated existing code that did
(node->rootEditableElement() == node) to use isRootEditableElement
instead.

No new tests. No change in behavior.

* dom/Node.cpp:
(WebCore::Node::isRootEditableElement):
(WebCore):
* dom/Node.h:
(Node):
Added new helper function.

* dom/Document.cpp:
(WebCore::Document::setFocusedNode):
* dom/Element.cpp:
(WebCore::Element::updateFocusAppearance):
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::removeNode):
* editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::doApply):
* page/FocusController.cpp:
(WebCore::FocusController::setFocusedNode):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::hasLineIfEmpty):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::addOverflowFromInlineChildren):
Updates to existing code to use the new helper function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Create WebTransformationMatrix interface for chromium platform
shawnsingh@chromium.org [Fri, 11 May 2012 20:07:12 +0000 (20:07 +0000)]
[chromium] Create WebTransformationMatrix interface for chromium platform
https://bugs.webkit.org/show_bug.cgi?id=86049

Reviewed by James Robinson.

Source/Platform:

* Platform.gyp/Platform.gyp:
* Platform.gypi:
* chromium/public/WebTransformationMatrix.h: Added.
(WebCore):
(WebKit):
(WebTransformationMatrix):

Source/WebCore:

This patch creates a WebTransformationMatrix interface. It will
remain unused at the moment, until (a) unit tests are created
and (b) when we are ready to make a brief transition of all other
chromium code to use it.

* WebCore.gypi:
* platform/chromium/support/WebTransformationMatrix.cpp: Added.
(WebKit):
(WebKit::WebTransformationMatrix::WebTransformationMatrix):
(WebKit::WebTransformationMatrix::operator=):
(WebKit::WebTransformationMatrix::operator==):
(WebKit::WebTransformationMatrix::operator*):
(WebKit::WebTransformationMatrix::inverse):
(WebKit::WebTransformationMatrix::to2dTransform):
(WebKit::WebTransformationMatrix::multiply):
(WebKit::WebTransformationMatrix::makeIdentity):
(WebKit::WebTransformationMatrix::translate):
(WebKit::WebTransformationMatrix::translate3d):
(WebKit::WebTransformationMatrix::translateRight3d):
(WebKit::WebTransformationMatrix::scale):
(WebKit::WebTransformationMatrix::scaleNonUniform):
(WebKit::WebTransformationMatrix::scale3d):
(WebKit::WebTransformationMatrix::rotate):
(WebKit::WebTransformationMatrix::rotate3d):
(WebKit::WebTransformationMatrix::skewX):
(WebKit::WebTransformationMatrix::skewY):
(WebKit::WebTransformationMatrix::applyPerspective):
(WebKit::WebTransformationMatrix::blend):
(WebKit::WebTransformationMatrix::hasPerspective):
(WebKit::WebTransformationMatrix::isInvertible):
(WebKit::WebTransformationMatrix::isBackFaceVisible):
(WebKit::WebTransformationMatrix::isIdentity):
(WebKit::WebTransformationMatrix::isIdentityOrTranslation):
(WebKit::WebTransformationMatrix::isIntegerTranslation):
(WebKit::WebTransformationMatrix::m11):
(WebKit::WebTransformationMatrix::setM11):
(WebKit::WebTransformationMatrix::m12):
(WebKit::WebTransformationMatrix::setM12):
(WebKit::WebTransformationMatrix::m13):
(WebKit::WebTransformationMatrix::setM13):
(WebKit::WebTransformationMatrix::m14):
(WebKit::WebTransformationMatrix::setM14):
(WebKit::WebTransformationMatrix::m21):
(WebKit::WebTransformationMatrix::setM21):
(WebKit::WebTransformationMatrix::m22):
(WebKit::WebTransformationMatrix::setM22):
(WebKit::WebTransformationMatrix::m23):
(WebKit::WebTransformationMatrix::setM23):
(WebKit::WebTransformationMatrix::m24):
(WebKit::WebTransformationMatrix::setM24):
(WebKit::WebTransformationMatrix::m31):
(WebKit::WebTransformationMatrix::setM31):
(WebKit::WebTransformationMatrix::m32):
(WebKit::WebTransformationMatrix::setM32):
(WebKit::WebTransformationMatrix::m33):
(WebKit::WebTransformationMatrix::setM33):
(WebKit::WebTransformationMatrix::m34):
(WebKit::WebTransformationMatrix::setM34):
(WebKit::WebTransformationMatrix::m41):
(WebKit::WebTransformationMatrix::setM41):
(WebKit::WebTransformationMatrix::m42):
(WebKit::WebTransformationMatrix::setM42):
(WebKit::WebTransformationMatrix::m43):
(WebKit::WebTransformationMatrix::setM43):
(WebKit::WebTransformationMatrix::m44):
(WebKit::WebTransformationMatrix::setM44):
(WebKit::WebTransformationMatrix::a):
(WebKit::WebTransformationMatrix::setA):
(WebKit::WebTransformationMatrix::b):
(WebKit::WebTransformationMatrix::setB):
(WebKit::WebTransformationMatrix::c):
(WebKit::WebTransformationMatrix::setC):
(WebKit::WebTransformationMatrix::d):
(WebKit::WebTransformationMatrix::setD):
(WebKit::WebTransformationMatrix::e):
(WebKit::WebTransformationMatrix::setE):
(WebKit::WebTransformationMatrix::f):
(WebKit::WebTransformationMatrix::setF):
(WebKit::WebTransformationMatrix::toWebCoreTransform):
(WebKit::WebTransformationMatrix::mapRect):
(WebKit::WebTransformationMatrix::mapPoint):
(WebKit::WebTransformationMatrix::mapQuad):
(WebKit::WebTransformationMatrix::projectPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWK2/Plugins: Move enumeration of plugins to a secondary UIProcess thread.
kling@webkit.org [Fri, 11 May 2012 19:49:28 +0000 (19:49 +0000)]
WK2/Plugins: Move enumeration of plugins to a secondary UIProcess thread.
<http://webkit.org/b/86143>
<rdar://problem/10777218>

Reviewed by Anders Carlsson.

To avoid spins beneath PluginInfoStore::getPluginInfo(), do this work on a secondary
thread in the UIProcess.

* Shared/APIObject.h:

    Made APIObject a ThreadSafeRefCounted. In the context of this patch, this is to
    be able to dispatch bound Functions on WebContext.

* WebProcess/mac/KeychainItemShimMethods.mm:
(WebKit::responseMap):
* WebProcess/mac/SecItemShimMethods.mm:
(WebKit::responseMap):
* WebKit2.xcodeproj/project.pbxproj:
* Shared/BlockingResponseMap.h:
(BlockingResponseMap):
(BlockingResponseMap::waitForResponse):
(BlockingResponseMap::didReceiveResponse):

     Renamed from Source/WebKit2/WebProcess/mac/KeychainShimResponseMap.h.
     Generalize this somewhat since it's useful in more than just the keychain scenario.
     This can/should be generalized further, but that's a topic for another patch.

* UIProcess/Plugins/PluginInfoStore.h:
* UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::PluginInfoStore::plugins):
(WebKit::PluginInfoStore::findPluginForMIMEType):
(WebKit::PluginInfoStore::findPluginForExtension):
(WebKit::PluginInfoStore::findPlugin):
(WebKit::PluginInfoStore::infoForPluginWithPath):

    Slap a mutex on the PluginInfoStore since it can now be called from both the
    main thread (via WKFrameCanShowMIMEType) and the GetPlugin work queue.

* UIProcess/WebContext.messages.in:
* UIProcess/WebContext.h:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
(WebKit::WebContext::processDidFinishLaunching):
(WebKit::WebContext::sendDidGetPlugins):
(WebKit::WebContext::handleGetPlugins):
(WebKit::WebContext::getPlugins):
(WebKit::WebContext::didReceiveMessageOnConnectionWorkQueue):

    Make GetPlugins a DispatchOnConnectionQueue message and execute it on a new
    plug-in work queue. This effectively makes the GetPlugin call asynchronous.
    On Mac, the built-in PDF reader is still registered on the main thread as that
    ends up calling into localizedString().

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didGetPlugins):
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in:

    Add a DidGetPlugins message to WebProcess. This is passed directly to the handler
    in WebPlatformStrategies.cpp.

* WebProcess/WebCoreSupport/WebPlatformStrategies.h:
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::responseMap):
(WebKit::handleDidGetPlugins):
(WebKit::generateRequestID):
(WebKit::WebPlatformStrategies::populatePluginCache):

    Use a BlockingResponseMap to block the WebProcess main thread until the UIProcess
    responds with DidGetPlugins.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CSS Shaders] Make CSS Shaders render to texture framebuffers
achicu@adobe.com [Fri, 11 May 2012 19:45:39 +0000 (19:45 +0000)]
[CSS Shaders] Make CSS Shaders render to texture framebuffers
https://bugs.webkit.org/show_bug.cgi?id=85113

Reviewed by Dean Jackson.

Source/WebCore:

Added the required members to store the framebuffer, the texture and the depth buffer. Also removed the m_drawingBuffer
because context->readPixels doesn't require one anymore.

ReadPixels is not flipping the result, so I've also removed the flipping projection matrix that was specific only to Chromium.

Added a test to check that colors are not switched and the resulting image is not mirrored.

Test: css3/filters/custom/effect-color-check.html

* platform/graphics/filters/FECustomFilter.cpp:
(WebCore::FECustomFilter::FECustomFilter):
(WebCore::FECustomFilter::~FECustomFilter):
(WebCore):
(WebCore::FECustomFilter::deleteRenderBuffers):
(WebCore::FECustomFilter::platformApplySoftware):
(WebCore::FECustomFilter::initializeContext):
(WebCore::FECustomFilter::resizeContext):
(WebCore::FECustomFilter::bindProgramAndBuffers):
* platform/graphics/filters/FECustomFilter.h:
(FECustomFilter):

LayoutTests:

Added a test to check that colors are not switched and the resulting image is not mirrored.

* css3/filters/custom/effect-color-check-expected.png: Added.
* css3/filters/custom/effect-color-check-expected.txt: Added.
* css3/filters/custom/effect-color-check.html: Added.
* css3/filters/resources/color-fill.fs: Added.
* platform/chromium-linux/css3/filters/custom/custom-filter-shader-cache-expected.png:
* platform/chromium-linux/css3/filters/custom/effect-custom-combined-missing-expected.png:
* platform/chromium-linux/css3/filters/custom/effect-custom-expected.png:
* platform/chromium-mac/css3/filters/custom/effect-color-check-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r116687): [Chromium] plugins/embed-attributes-style.html shows a garbled...
andersca@apple.com [Fri, 11 May 2012 19:40:30 +0000 (19:40 +0000)]
REGRESSION(r116687): [Chromium] plugins/embed-attributes-style.html shows a garbled string
https://bugs.webkit.org/show_bug.cgi?id=86170

Reviewed by Andreas Kling.

The string we are passing to the TextRun constructor needs to stay alive for longer so revert back to the old
behavior where we store it as a member variable.

* rendering/RenderEmbeddedObject.cpp:
(WebCore::unavailablePluginReplacementText):
(WebCore):
(WebCore::RenderEmbeddedObject::setPluginUnavailabilityReason):
(WebCore::RenderEmbeddedObject::getReplacementTextGeometry):
* rendering/RenderEmbeddedObject.h:
(RenderEmbeddedObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Tests needs rebaselining after r116776
commit-queue@webkit.org [Fri, 11 May 2012 19:21:53 +0000 (19:21 +0000)]
[EFL] Tests needs rebaselining after r116776
https://bugs.webkit.org/show_bug.cgi?id=86227

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-11

* platform/efl/fast/css/line-height-determined-by-primary-font-expected.png:
* platform/efl/fast/css/line-height-determined-by-primary-font-expected.txt:
* platform/efl/fast/dynamic/text-combine-expected.png:
* platform/efl/fast/dynamic/text-combine-expected.txt:
* platform/efl/fast/encoding/denormalised-voiced-japanese-chars-expected.png:
* platform/efl/fast/encoding/denormalised-voiced-japanese-chars-expected.txt:
* platform/efl/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
* platform/efl/fast/repaint/repaint-across-writing-mode-boundary-expected.txt:
* platform/efl/fast/ruby/base-shorter-than-text-expected.png:
* platform/efl/fast/ruby/base-shorter-than-text-expected.txt:
* platform/efl/fast/ruby/nested-ruby-expected.png:
* platform/efl/fast/ruby/nested-ruby-expected.txt:
* platform/efl/fast/text/backslash-to-yen-sign-euc-expected.png:
* platform/efl/fast/text/backslash-to-yen-sign-euc-expected.txt:
* platform/efl/fast/text/backslash-to-yen-sign-expected.png:
* platform/efl/fast/text/backslash-to-yen-sign-expected.txt:
* platform/efl/fast/text/emphasis-combined-text-expected.png:
* platform/efl/fast/text/emphasis-combined-text-expected.txt:
* platform/efl/fast/text/justify-ideograph-leading-expansion-expected.png:
* platform/efl/fast/text/justify-ideograph-leading-expansion-expected.txt:
* platform/efl/fast/text/justify-ideograph-simple-expected.png:
* platform/efl/fast/text/justify-ideograph-simple-expected.txt:
* platform/efl/fast/text/justify-ideograph-vertical-expected.png:
* platform/efl/fast/text/justify-ideograph-vertical-expected.txt:
* platform/efl/fast/writing-mode/vertical-align-table-baseline-expected.png:
* platform/efl/fast/writing-mode/vertical-align-table-baseline-expected.txt:
* platform/efl/fast/writing-mode/vertical-baseline-alignment-expected.png:
* platform/efl/fast/writing-mode/vertical-baseline-alignment-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: CVDisplayLink keeps running after a single requestAnimationFrame
simon.fraser@apple.com [Fri, 11 May 2012 18:56:32 +0000 (18:56 +0000)]
Source/WebCore: CVDisplayLink keeps running after a single requestAnimationFrame
https://bugs.webkit.org/show_bug.cgi?id=86174

Reviewed by Sam Weinig.

A DisplayRefreshMonitor would keep its CVDisplayLink alive for as long
as it had clients, and the client is the ScriptedAnimationController, which
lives on the document. So a single requestAnimationFrame call would kick
off a CVDisplayLink which lived until the document was destroyed.

Fix by having the DisplayRefreshMonitor kill itself if the CVDisplayLink
fires for 10 times with no scheduled callbacks (to avoid creation/deletion
thrash on pages that call requestAnimationFrames with short setTimeouts,
as some do).

Use a HashMap in DisplayRefreshMonitorManager for the set of DisplayRefreshMonitor,
with the displayID as the key (using UnsignedWithZeroKeyHashTraits<uint64_t> since
we want to allow for 0 to be a valid displayID).

Use a HashSet in DisplayRefreshMonitor for the client set, so that we don't have to
worry about adding clients twice.

Also fix a possible crash when the only client of a DisplayRefreshMonitor
was removed from inside the callback by making DisplayRefreshMonitor ref-counted,
with a protector.

Test: fast/animation/request-animation-frame-detach-element2.html

* platform/graphics/DisplayRefreshMonitor.cpp:
(WebCore::DisplayRefreshMonitor::DisplayRefreshMonitor): Initialize m_unscheduledFireCount
(WebCore::DisplayRefreshMonitor::handleDisplayRefreshedNotificationOnMainThread): Renamed
from refreshDisplayOnMainThread, since it doesn't just refresh the display.
(WebCore::DisplayRefreshMonitor::addClient): No longer inline.
(WebCore::DisplayRefreshMonitor::removeClient): No longer inline.
(WebCore::DisplayRefreshMonitor::displayDidRefresh): Keep track of m_unscheduledFireCount,
which we used to kill this monitor if it has been idle for a while.
Use a RefPtr<DisplayRefreshMonitor> to prevent deletion while running the callback.
Copy the clients to a vector to protect against mutating the set while enumerating it.
Notify the DisplayRefreshMonitorManager when we're done, so that it can decide
to delete inactive monitors.

(WebCore::DisplayRefreshMonitorManager::ensureMonitorForClient): find or allocate
a DisplayRefreshMonitor for a given client.
(WebCore::DisplayRefreshMonitorManager::registerClient): Simplified by use of HashMap.
(WebCore::DisplayRefreshMonitorManager::unregisterClient): Ditto.
(WebCore::DisplayRefreshMonitorManager::scheduleAnimation): Ditto. Uses
ensureMonitorForClient() since an earlier inactive monitor may have been removed.
(WebCore::DisplayRefreshMonitorManager::displayDidRefresh): Remove inactive
monitors.
* platform/graphics/DisplayRefreshMonitor.h: Make DisplayRefreshMonitor
ref-counted, to make it easier to avoid deletion while it's on the stack.
(WebCore::DisplayRefreshMonitor::create):
(DisplayRefreshMonitor):
(WebCore::DisplayRefreshMonitor::shouldBeTerminated):
(DisplayRefreshMonitorManager):
* platform/graphics/blackberry/DisplayRefreshMonitorBlackBerry.cpp: Attempt to
keep things building.
(WebCore::DisplayRefreshMonitor::~DisplayRefreshMonitor):
(WebCore::DisplayRefreshMonitor::displayLinkFired):
to give the manager a chance to kill this monitor.
* platform/graphics/mac/DisplayRefreshMonitorMac.cpp:
(WebCore::DisplayRefreshMonitor::~DisplayRefreshMonitor):
(WebCore::DisplayRefreshMonitor::displayLinkFired): Don't bail early
if not scheduled; we want to call handleDisplayRefreshedNotificationOnMainThread(),

LayoutTests: CVDisplayLink keeps running after a single requestAnimationFrame
https://bugs.webkit.org/show_bug.cgi?id=86174

Reviewed by Sam Weinig.

Test removing a frame inside its requestAnimationFrame callback.

* fast/animation/request-animation-frame-detach-element2-expected.txt: Added.
* fast/animation/request-animation-frame-detach-element2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: move canEditScriptSource and setScriptSource from DebuggerPresentation...
pfeldman@chromium.org [Fri, 11 May 2012 18:50:41 +0000 (18:50 +0000)]
Web Inspector: move canEditScriptSource and setScriptSource from DebuggerPresentationModel into ResourceBinding
https://bugs.webkit.org/show_bug.cgi?id=86234

Reviewed by Vsevolod Vlasov.

Simple move refactoring.

* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerResourceBinding):
(WebInspector.DebuggerResourceBinding.canEditScriptSource):
(WebInspector.DebuggerResourceBinding.setScriptSource.didEditScriptSource):
(WebInspector.DebuggerResourceBinding.setScriptSource):
(WebInspector.DebuggerResourceBinding.prototype.canSetContent):
(WebInspector.DebuggerResourceBinding.prototype._uiSourceCodeForResource):
(WebInspector.DebuggerResourceBinding.prototype._setContentWithInitialContent):
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.canEditSource):
(WebInspector.JavaScriptSourceFrame.prototype.editContent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove RenderLayer::m_scrollOverflow
jchaffraix@webkit.org [Fri, 11 May 2012 18:48:19 +0000 (18:48 +0000)]
Remove RenderLayer::m_scrollOverflow
https://bugs.webkit.org/show_bug.cgi?id=86226

Reviewed by Simon Fraser.

No expected change in behavior.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::computeScrollDimensions):
Added 2 local variables to compute the left / top scrollable overflows.

* rendering/RenderLayer.h:
(WebCore::RenderLayer::scrolledContentOffset):
Returned m_scrollOffset directly as this is what the old code was doing by adding
m_scrollOrigin then adding m_scrollOverflow (which was set to -m_scrollOrigin in
computeScrollDimensions).

(RenderLayer::m_scrollOffset): Improved the comment about what m_scrollOffset is.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: extract PresentationConsoleMessageHelper from DebuggerPresentationModel.
pfeldman@chromium.org [Fri, 11 May 2012 18:31:41 +0000 (18:31 +0000)]
Web Inspector: extract PresentationConsoleMessageHelper from DebuggerPresentationModel.
https://bugs.webkit.org/show_bug.cgi?id=86229

Reviewed by Vsevolod Vlasov.

This change also starts tracking messages along with the live location changes.

Tested with script-formatter-console.html.

* inspector/front-end/BreakpointManager.js:
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
(WebInspector.PresentationConsoleMessageHelper):
(WebInspector.PresentationConsoleMessageHelper.prototype._addPendingConsoleMessage):
(WebInspector.PresentationConsoleMessageHelper.prototype._parsedScriptSource):
(WebInspector.PresentationConsoleMessageHelper.prototype._debuggerReset):
(WebInspector.PresentationConsoleMessage):
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu):
(WebInspector.JavaScriptSourceFrame.prototype._consoleMessageAdded):
(WebInspector.JavaScriptSourceFrame.prototype._setBreakpoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSimplify FloatingObject by removing unnecessary convenience methods.
eae@chromium.org [Fri, 11 May 2012 18:21:39 +0000 (18:21 +0000)]
Simplify FloatingObject by removing unnecessary convenience methods.
https://bugs.webkit.org/show_bug.cgi?id=86163

Reviewed by Eric Seidel.

Simplify the pixel snapping in FloatingObject by getting rid of a bunch
of convenience methods.

No new tests, no change in functionality.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::addIntrudingFloats):
(WebCore::RenderBlock::FloatingObjects::intervalForFloatingObject):
(WebCore::::string):
* rendering/RenderBlock.h:
(FloatingObject):
(WebCore::RenderBlock::pixelSnappedLogicalTopForFloat):
(WebCore::RenderBlock::pixelSnappedLogicalBottomForFloat):
(WebCore::RenderBlock::pixelSnappedLogicalLeftForFloat):
(WebCore::RenderBlock::pixelSnappedLogicalRightForFloat):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkit-patch rebaseline should fetch stale expectations :)
dpranke@chromium.org [Fri, 11 May 2012 18:10:34 +0000 (18:10 +0000)]
webkit-patch rebaseline should fetch stale expectations :)
https://bugs.webkit.org/show_bug.cgi?id=86231

Unreviewed, build fix.

This change reverts r115492 and goes back to fetching individual
baselines from the layout tests directory, rather than fetching
entire zip files. The performance hit over networks for people
far away from the bots has turned out to be severe, so we need a
better solution to this.

* Scripts/webkitpy/tool/commands/rebaseline.py:
(RebaselineTest._results_url):
(RebaselineTest._file_name_for_expected_result):
(RebaselineTest._rebaseline_test):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaseline.test_rebaseline_updates_expectations_file_noop):
(test_rebaseline_updates_expectations_file):
(test_rebaseline_test):
(test_rebaseline_and_copy_test):
(test_rebaseline_and_copy_test_no_existing_result):
(test_rebaseline_and_copy_test_with_lion_result):
(test_rebaseline_and_copy_no_overwrite_test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Ensure that animations continue to run when transform-style is changed
commit-queue@webkit.org [Fri, 11 May 2012 18:04:15 +0000 (18:04 +0000)]
[chromium] Ensure that animations continue to run when transform-style is changed
https://bugs.webkit.org/show_bug.cgi?id=83283

Source/WebCore:

Make sure that we transfer animations when changing layers due to a transform-style change.
Unit tested in GraphicsLayerChromiumTest.updateLayerPreserves3DWithAnimations

Patch by Ian Vollick <vollick@chromium.org> on 2012-05-11
Reviewed by James Robinson.

Test: animations/change-transform-style-during-animation.html

* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setLayerAnimationController):
(WebCore::LayerChromium::releaseLayerAnimationController):
(WebCore):
(WebCore::LayerChromium::notifyAnimationStarted):
* platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
* platform/graphics/chromium/cc/CCLayerAnimationController.cpp:
(WebCore::CCLayerAnimationController::CCLayerAnimationController):
(WebCore::CCLayerAnimationController::pushAnimationUpdatesTo):
(WebCore::CCLayerAnimationController::notifyAnimationStarted):
(WebCore::CCLayerAnimationController::setClient):
(WebCore):
(WebCore::CCLayerAnimationController::pushNewAnimationsToImplThread):
(WebCore::CCLayerAnimationController::replaceImplThreadAnimations):
* platform/graphics/chromium/cc/CCLayerAnimationController.h:
(CCLayerAnimationController):
(WebCore::CCLayerAnimationController::setForceSync):

Source/WebKit/chromium:

Patch by Ian Vollick <vollick@chromium.org> on 2012-05-11
Reviewed by James Robinson.

* WebKit.gypi:
* tests/GraphicsLayerChromiumTest.cpp: Added.
(WebKitTests):
(MockGraphicsLayerClient):
(WebKitTests::MockGraphicsLayerClient::notifyAnimationStarted):
(WebKitTests::MockGraphicsLayerClient::notifySyncRequired):
(WebKitTests::MockGraphicsLayerClient::paintContents):
(WebKitTests::MockGraphicsLayerClient::showDebugBorders):
(WebKitTests::MockGraphicsLayerClient::showRepaintCounter):
(WebKitTests::TEST):

LayoutTests:

Patch by Ian Vollick <vollick@chromium.org> on 2012-05-11
Reviewed by James Robinson.

* animations/change-transform-style-during-animation-expected.png: Added.
* animations/change-transform-style-during-animation-expected.txt: Added.
* animations/change-transform-style-during-animation.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix crash seen when running with libgmalloc
weinig@apple.com [Fri, 11 May 2012 17:57:17 +0000 (17:57 +0000)]
Fix crash seen when running with libgmalloc
<rdar://problem/11435411>
https://bugs.webkit.org/show_bug.cgi?id=86232

Reviewed by Gavin Barraclough.

* heap/MarkStack.cpp:
(JSC::MarkStackThreadSharedData::markingThreadMain):
Don't delete the SlotVisitor before the ParallelModeEnabler has had a chance to run its
destructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt]ietestcenter/css3/flexbox tests fail on 32 bit
tomz@codeaurora.org [Fri, 11 May 2012 17:28:21 +0000 (17:28 +0000)]
[Qt]ietestcenter/css3/flexbox tests fail on 32 bit
https://bugs.webkit.org/show_bug.cgi?id=85596

Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-05-11
Reviewed by Csaba Osztrogon√°c.

Reference tests originally assumed "background: green" was identical
to the green used in the pngs used by the feature tests. On local builds
of QT, GTK, and chromium, this assumption seemed to hold up. On the Mac
and QT bots however, it became clear this was an invalid assumption. I've
re-written the reference tests to use the original pngs as appropriate.
I have reproduced the failures on a Mac & Qt32 and verified that the newly
re-written reference tests behave properly now.

* ietestcenter/css3/flexbox/flexbox-align-end-001-expected.htm:
* ietestcenter/css3/flexbox/flexbox-align-start-001-expected.htm:
* ietestcenter/css3/flexbox/flexbox-flex-001-expected.htm:
* ietestcenter/css3/flexbox/flexbox-flex-002-expected.htm:
* ietestcenter/css3/flexbox/flexbox-flex-003-expected.htm:
* ietestcenter/css3/flexbox/flexbox-flex-004-expected.htm:
* ietestcenter/css3/flexbox/flexbox-groups-001-expected.htm:
* ietestcenter/css3/flexbox/flexbox-groups-002-expected.htm:
* ietestcenter/css3/flexbox/flexbox-groups-003-expected.htm:
* ietestcenter/css3/flexbox/flexbox-groups-004-expected.htm:
* ietestcenter/css3/flexbox/flexbox-layout-001-expected.htm:
* ietestcenter/css3/flexbox/flexbox-layout-003-expected.htm:
* ietestcenter/css3/flexbox/flexbox-pack-end-001-expected.htm:
* ietestcenter/css3/flexbox/flexbox-pack-justify-001-expected.htm:
* ietestcenter/css3/flexbox/flexbox-pack-start-001-expected.htm:
* platform/chromium/test_expectations.txt:
* platform/efl/test_expectations.txt:
* platform/gtk/test_expectations.txt:
* platform/mac/Skipped:
* platform/mac/test_expectations.txt:
* platform/qt/Skipped:
* platform/qt/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMediaStream API: Fix a reference counting issue in UserMediaRequest
tommyw@google.com [Fri, 11 May 2012 17:09:28 +0000 (17:09 +0000)]
MediaStream API: Fix a reference counting issue in UserMediaRequest
https://bugs.webkit.org/show_bug.cgi?id=86210

Reviewed by Abhishek Arya.

.:

* ManualTests/user-media-request-crash.html: Added.

Source/WebCore:

When contextDestroyed() is called on UserMediaRequest it does a callback to the
page client. If the receiving code clears their stored copy the UserMediaRequest
object is destroyed in the middle of the call.

Currently only testable manually against chrome, preferably with asan turned on.
I have added a manual test that verifies the fix, but I have started work
to make DumpRenderTree able to test this and many other things. The first patch is here:
https://bugs.webkit.org/show_bug.cgi?id=86215

* Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::contextDestroyed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agosplit MediaPlayer::enterFullscreen into 2 seperate functions
commit-queue@webkit.org [Fri, 11 May 2012 17:05:23 +0000 (17:05 +0000)]
split MediaPlayer::enterFullscreen into 2 seperate functions
https://bugs.webkit.org/show_bug.cgi?id=86052

Patch by Min Qin <qinmin@google.com> on 2012-05-11
Reviewed by Adam Barth.

Source/WebCore:

It is confusing that enterFullscreen returns a boolean while exitFullscreen does
not do the same. And ios does not need the return value.
So remove the return value on enterFullscreen and make a seperate canEnterFullscreen()
function for android.
No tests as there are no behavior change, just refactoring.

* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::enterFullscreen):
(WebCore):
(WebCore::MediaPlayer::canEnterFullscreen):
* platform/graphics/MediaPlayer.h:
(MediaPlayer):
* platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::enterFullscreen):
(MediaPlayerPrivateInterface):
(WebCore::MediaPlayerPrivateInterface::canEnterFullscreen):

Source/WebKit/chromium:

In WebCore, we splitted bool enterFullscreen() into two seperate calls:
void enterFullscreen() and bool canEnterFullscreen()
This is the change in the chromium part that we needed to support the WebCore change
No behavior change, just refactoring.

* public/WebMediaPlayer.h:
(WebMediaPlayer):
(WebKit::WebMediaPlayer::enterFullscreen):
(WebKit::WebMediaPlayer::canEnterFullscreen):
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::enterFullscreen):
(WebKit):
(WebKit::WebMediaPlayerClientImpl::exitFullscreen):
* src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::enterFullScreenForElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Gardening failure test cases.
commit-queue@webkit.org [Fri, 11 May 2012 16:51:30 +0000 (16:51 +0000)]
[EFL] Gardening failure test cases.
https://bugs.webkit.org/show_bug.cgi?id=86212

Unreviewed EFL gardening.

Test expectations update, moving related bugs from Skipped list to test_expectations.txt.

Patch by Krzysztof Czech <k.czech@samsung.com> on 2012-05-11

* platform/efl/Skipped:
* platform/efl/test_expectations.txt: adding new bug regarding to missing contextClick implementation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: move breakpoint manager from debuggerPresentationModel to WebInspector.
pfeldman@chromium.org [Fri, 11 May 2012 16:46:02 +0000 (16:46 +0000)]
Web Inspector: move breakpoint manager from debuggerPresentationModel to WebInspector.
https://bugs.webkit.org/show_bug.cgi?id=86220

Reviewed by Yury Semikhatsky.

Source/WebCore:

Now that breakpoint manager does not depend on the source mapping instance from the
debugger presentation model, it can be moved out.

* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
* inspector/front-end/JavaScriptSource.js:
(WebInspector.JavaScriptSource):
(WebInspector.JavaScriptSource.prototype.setFormatted.didGetContent.didFormatContent):
(WebInspector.JavaScriptSource.prototype.setFormatted.didGetContent):
(WebInspector.JavaScriptSource.prototype.setFormatted):
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
* inspector/front-end/ScriptsPanel.js:
* inspector/front-end/inspector.js:

LayoutTests:

* inspector/debugger/scripts-panel.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Move instantiation of texture uploader to LayerRendererChromium.
commit-queue@webkit.org [Fri, 11 May 2012 16:41:53 +0000 (16:41 +0000)]
[Chromium] Move instantiation of texture uploader to LayerRendererChromium.
https://bugs.webkit.org/show_bug.cgi?id=85893

Patch by David Reveman <reveman@chromium.org> on 2012-05-11
Reviewed by Adrienne Walker.

Source/WebCore:

Move instantiation of texture uploader to LayerRendererChromium and
allow CCProxy to decide between a throttled or unthrottled uploader
using a flag passed to the LayerRendererChromium constructor.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::create):
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::initializeSharedObjects):
* platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromium):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::initializeLayerRenderer):
(WebCore::CCSingleThreadProxy::recreateContext):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::initializeLayerRendererOnImplThread):
(WebCore::CCThreadProxy::recreateContextOnImplThread):

Source/WebKit/chromium:

* tests/CCLayerTreeHostImplTest.cpp:
(WebKitTests::CCLayerTreeHostImplTest::CCLayerTreeHostImplTest):
(WebKitTests::TEST_F):
* tests/LayerRendererChromiumTest.cpp:
(FakeLayerRendererChromium::FakeLayerRendererChromium):
(LayerRendererChromiumTest::LayerRendererChromiumTest):
(TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] LayoutTests/svg/batik/text/verticalText.svg fails to display Chinese characters
commit-queue@webkit.org [Fri, 11 May 2012 16:41:43 +0000 (16:41 +0000)]
[GTK] LayoutTests/svg/batik/text/verticalText.svg fails to display Chinese characters
https://bugs.webkit.org/show_bug.cgi?id=86198

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-11
Reviewed by Martin Robinson.

Tools:

Update webkitgtk-fonts package to v0.0.3 in order to get new Kochi
Mincho / Gothic fonts to display Japanese and Chinese characters.

* gtk/jhbuild.modules:

LayoutTests:

Rebaseline svg/batik/text/verticalText.svg now that GTK's
DumpRenderTree is able to display Chinese characters.

* platform/gtk/svg/batik/text/verticalText-expected.png:
* platform/gtk/svg/batik/text/verticalText-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116778 268f45cc-cd09-0410-ab3c-d52691b4dbfc