WebKit-https.git
7 years agoUse webkit-queeus.appspot.com instead of webkit-commit-queue.appspot.com
rniwa@webkit.org [Thu, 11 Apr 2013 00:15:13 +0000 (00:15 +0000)]
Use webkit-queeus.appspot.com instead of webkit-commit-queue.appspot.com
https://bugs.webkit.org/show_bug.cgi?id=114397

Reviewed by Benjamin Poulain.

* Scripts/webkitpy/common/net/statusserver.py:
(StatusServer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CMAKE] Build fix after r148147, r148148
ryuan.choi@samsung.com [Thu, 11 Apr 2013 00:10:18 +0000 (00:10 +0000)]
[CMAKE] Build fix after r148147, r148148
https://bugs.webkit.org/show_bug.cgi?id=114395

Unreviewed build fix.

Use StorageAreaImpl, StorageNamespaceImpl instead of StorageAreaProxy, StorageNamespaceProxy.

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-04-10

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake old EWS bubbles less opaque to disambiguate two set of bubbles.
rniwa@webkit.org [Thu, 11 Apr 2013 00:09:34 +0000 (00:09 +0000)]
Make old EWS bubbles less opaque to disambiguate two set of bubbles.

Rubber-stamped by Benjamin Poulain.

* code-review.js:
* template/en/custom/attachment/edit.html.tmpl:
* template/en/custom/attachment/list.html.tmpl:
* template/en/custom/attachment/reviewform.html.tmpl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLog when the animation timer fires
simon.fraser@apple.com [Thu, 11 Apr 2013 00:04:06 +0000 (00:04 +0000)]
Log when the animation timer fires
https://bugs.webkit.org/show_bug.cgi?id=114393

Reviewed by Dean Jackson.

Logging to the Animations log channel when the updateAnimationTimer
fires is useful, because it indicates whether we're running
software animations.

* page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::updateAnimationTimer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd a stubbed out StorageAreaMap class
andersca@apple.com [Thu, 11 Apr 2013 00:02:01 +0000 (00:02 +0000)]
Add a stubbed out StorageAreaMap class
https://bugs.webkit.org/show_bug.cgi?id=114392

Reviewed by Andreas Kling.

The intention is that StorageAreaMap is going to take over responsibility for storing the storage values in the
web process, as well as dispatching events. A StorageAreaMap will be shared between multiple StorageAreaImpl objects,
for example if multiple frames with the same origin use local storage.

* DerivedSources.make:
* UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::StorageArea::dispatchEvents):
(WebKit::StorageManager::setItem):
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/Storage/StorageAreaImpl.cpp:
(WebKit::StorageAreaImpl::StorageAreaImpl):
(WebKit::StorageAreaImpl::~StorageAreaImpl):
* WebProcess/Storage/StorageAreaMap.cpp: Added.
(WebKit):
(WebKit::StorageAreaMap::create):
(WebKit::StorageAreaMap::StorageAreaMap):
(WebKit::StorageAreaMap::~StorageAreaMap):
(WebKit::StorageAreaMap::didSetItem):
(WebKit::StorageAreaMap::dispatchStorageEvent):
* WebProcess/Storage/StorageAreaMap.h: Added.
(WebKit):
(StorageAreaMap):
* WebProcess/Storage/StorageAreaMap.messages.in: Renamed from Source/WebKit2/WebProcess/Storage/StorageAreaImpl.messages.in.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBugzilla should show bubbles from webkit-queues.appspot.com
rniwa@webkit.org [Thu, 11 Apr 2013 00:00:32 +0000 (00:00 +0000)]
Bugzilla should show bubbles from webkit-queues.appspot.com
https://bugs.webkit.org/show_bug.cgi?id=114391

Reviewed by Benjamin Poulain.

Include iframe from webkit-queues.appspot.com as well as one for webkit-commit-queue.appspot.com.

* code-review.js:
* template/en/custom/attachment/edit.html.tmpl:
* template/en/custom/attachment/list.html.tmpl:
* template/en/custom/attachment/reviewform.html.tmpl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove abarth from watchlists
abarth@webkit.org [Wed, 10 Apr 2013 23:53:42 +0000 (23:53 +0000)]
Remove abarth from watchlists
https://bugs.webkit.org/show_bug.cgi?id=114390

Reviewed by Ryosuke Niwa.

I'm trying to cut down on the amount of bugmail I get so that I'll have
more of a chance to notice a piece of bugmail directed at me.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowebkit-test-results.appspot.com loads the dashboard for Chromium by default
rniwa@webkit.org [Wed, 10 Apr 2013 23:44:07 +0000 (23:44 +0000)]
webkit-test-results.appspot.com loads the dashboard for Chromium by default
https://bugs.webkit.org/show_bug.cgi?id=114381

Reviewed by Benjamin Poulain.

Changed the defaults.

* TestResultServer/static-dashboards/builders.js:
* TestResultServer/static-dashboards/dashboard_base.js:
(currentBuilderGroupCategory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoInspector highlights are offset when the WKView has a header
bdakin@apple.com [Wed, 10 Apr 2013 23:25:53 +0000 (23:25 +0000)]
Inspector highlights are offset when the WKView has a header
https://bugs.webkit.org/show_bug.cgi?id=114389
-and corresponding-
<rdar://problem/13522434>

Reviewed by Sam Weinig.

rootViewToContents() and contentsToRootView() need to factor in the
headerHeight(), much like windowToContents() and contentsToWindow() do already.
* platform/ScrollView.cpp:
(WebCore::ScrollView::rootViewToContents):
(WebCore::ScrollView::contentsToRootView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRename StorageAreaProxy to StorageAreaImpl.
andersca@apple.com [Wed, 10 Apr 2013 23:22:02 +0000 (23:22 +0000)]
Rename StorageAreaProxy to StorageAreaImpl.

Rubber-stamped by Beth Dakin.

* DerivedSources.make:
* UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::StorageArea::dispatchEvents):
(WebKit::StorageManager::setItem):
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/Storage/StorageAreaImpl.cpp: Renamed from Source/WebKit2/WebProcess/Storage/StorageAreaProxy.cpp.
* WebProcess/Storage/StorageAreaImpl.h: Renamed from Source/WebKit2/WebProcess/Storage/StorageAreaProxy.h.
* WebProcess/Storage/StorageAreaImpl.messages.in: Renamed from Source/WebKit2/WebProcess/Storage/StorageAreaProxy.messages.in.
* WebProcess/Storage/StorageNamespaceImpl.cpp:
(WebKit::StorageNamespaceImpl::storageArea):
* WebProcess/Storage/StorageNamespaceImpl.h:
(WebKit):
(StorageNamespaceImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRename StorageNamespaceProxy to StorageNamespaceImpl.
andersca@apple.com [Wed, 10 Apr 2013 23:21:59 +0000 (23:21 +0000)]
Rename StorageNamespaceProxy to StorageNamespaceImpl.

Rubber-stamped by Beth Dakin.

* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/Storage/StorageAreaProxy.cpp:
(WebKit::StorageAreaProxy::create):
(WebKit::StorageAreaProxy::StorageAreaProxy):
* WebProcess/Storage/StorageAreaProxy.h:
(StorageAreaProxy):
* WebProcess/Storage/StorageNamespaceImpl.cpp: Renamed from Source/WebKit2/WebProcess/Storage/StorageNamespaceProxy.cpp.
* WebProcess/Storage/StorageNamespaceImpl.h: Renamed from Source/WebKit2/WebProcess/Storage/StorageNamespaceProxy.h.
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::sessionStorageNamespace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove Chromium EWS bots from the queue status server
rniwa@webkit.org [Wed, 10 Apr 2013 23:11:24 +0000 (23:11 +0000)]
Remove Chromium EWS bots from the queue status server
https://bugs.webkit.org/show_bug.cgi?id=113988

Reviewed by Benjamin Poulain.

Removed Chromium EWS bots. Also updated it to use webkit-queues.appspot.com.

* QueueStatusServer/app.yaml:
* QueueStatusServer/config/queues.py:
* QueueStatusServer/model/queues.py:
(Queue.short_name):
(Queue.display_name):
* QueueStatusServer/model/queues_unittest.py:
(QueueTest.test_short_name):
(QueueTest.test_display_name):
(QueueTest.test_name_with_underscores):
* QueueStatusServer/templates/activebots.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFlesh out the Animations logging
simon.fraser@apple.com [Wed, 10 Apr 2013 22:47:07 +0000 (22:47 +0000)]
Flesh out the Animations logging
https://bugs.webkit.org/show_bug.cgi?id=114388

Reviewed by Dean Jackson.

Log state changes and transition/animation creation and destruction
to the Animations log channel.

* page/animation/AnimationBase.cpp:
(WebCore::nameForState):
(WebCore::AnimationBase::updateStateMachine):
(WebCore::AnimationBase::fireAnimationEventsIfNeeded):
(WebCore::AnimationBase::goIntoEndingOrLoopingState):
(WebCore::AnimationBase::freezeAtTime):
* page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::updateTransitions):
(WebCore::CompositeAnimation::updateKeyframeAnimations):
* page/animation/KeyframeAnimation.h:
(WebCore::KeyframeAnimation::keyframes):
(KeyframeAnimation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago <rdar://problem/13047266> External XML entities are not loaded with modern...
ap@apple.com [Wed, 10 Apr 2013 22:45:35 +0000 (22:45 +0000)]
    <rdar://problem/13047266> External XML entities are not loaded with modern libxml2
        https://bugs.webkit.org/show_bug.cgi?id=114377

        Reviewed by Darin Adler.

        Covered by http/tests/security/xss-DENIED-xml-external-entity.xhtml when using
        new enough libxml2.

        * xml/parser/XMLDocumentParserLibxml2.cpp:
        (WebCore::switchToUTF16): Added a FIXME with an idea for improvement.
        (WebCore::XMLParserContext::createStringParser): Apply XML_PARSE_NOENT in a non-hacky
        way, so that the new libxml2 check doesn't fail.
        (WebCore::XMLParserContext::createMemoryParser): Updated an unhelpful and incorrect
        comment (XML_PARSE_NODICT actually means "Do not reuse the context dictionary").

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[wk2] Un-pollute TCADA methods with "PageOverlayLayerMap::iterator end"
timothy_horton@apple.com [Wed, 10 Apr 2013 22:35:29 +0000 (22:35 +0000)]
[wk2] Un-pollute TCADA methods with "PageOverlayLayerMap::iterator end"
https://bugs.webkit.org/show_bug.cgi?id=114387

Reviewed by Simon Fraser.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::updatePreferences):
(WebKit::TiledCoreAnimationDrawingArea::paintContents):
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
(WebKit::TiledCoreAnimationDrawingArea::setExposedRect):
(WebKit::TiledCoreAnimationDrawingArea::mainFrameScrollabilityChanged):
(WebKit::TiledCoreAnimationDrawingArea::updateGeometry):
(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoJSObject::getOwnNonIndexPropertyNames calculates numCacheableSlots incorrectly
mhahnenberg@apple.com [Wed, 10 Apr 2013 22:25:36 +0000 (22:25 +0000)]
JSObject::getOwnNonIndexPropertyNames calculates numCacheableSlots incorrectly
https://bugs.webkit.org/show_bug.cgi?id=114235

Reviewed by Filip Pizlo.

If the object doesn't have any properties but the prototype does, we'll assume those prototype properties are
accessible in the base object's backing store, which is bad.

Source/JavaScriptCore:

* runtime/JSObject.cpp:
(JSC::JSObject::getPropertyNames):
(JSC::JSObject::getOwnNonIndexPropertyNames):
* runtime/PropertyNameArray.h:
(JSC::PropertyNameArray::PropertyNameArray):
(JSC::PropertyNameArray::setNumCacheableSlotsForObject):
(JSC::PropertyNameArray::setBaseObject):
(PropertyNameArray):

LayoutTests:

* fast/js/get-by-pname-only-prototype-properties-expected.txt: Added.
* fast/js/get-by-pname-only-prototype-properties.html: Added.
* fast/js/script-tests/get-by-pname-only-prototype-properties.js: Added.
(foo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[wk2] REGRESSION: Find highlight does not update when the view is resized
timothy_horton@apple.com [Wed, 10 Apr 2013 22:18:49 +0000 (22:18 +0000)]
[wk2] REGRESSION: Find highlight does not update when the view is resized
https://bugs.webkit.org/show_bug.cgi?id=114382
<rdar://problem/13599797>

Reviewed by Simon Fraser.

Invalidate the page overlays from TiledCoreAnimationDrawingArea::updateGeometry.
This will have no effect if the page overlay hasn't previously asked to be painted
(as drawsContent will remain false on the layer).

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
(TiledCoreAnimationDrawingArea): Add invalidateAllPageOverlays.
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::invalidateAllPageOverlays): Factor this out of didChangeScrollOffsetForAnyFrame.
(WebKit::TiledCoreAnimationDrawingArea::didChangeScrollOffsetForAnyFrame): Call invalidateAllPageOverlays.
(WebKit::TiledCoreAnimationDrawingArea::updateGeometry): Call invalidateAllPageOverlays.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Mac] in-band tracks sometimes not recognized
eric.carlson@apple.com [Wed, 10 Apr 2013 21:53:28 +0000 (21:53 +0000)]
[Mac] in-band tracks sometimes not recognized
https://bugs.webkit.org/show_bug.cgi?id=114380

Reviewed by Jer Noble.

No new tests, covered by existing in-band tests.

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): Don't call selectMediaOption,
    availableMediaCharacteristicsWithMediaSelectionOptions is unlikely to be loaded at this time.
(WebCore::MediaPlayerPrivateAVFoundationObjC::processTextTracks): Disable automatic text track
    selection.
(WebCore::assetMetadataKeyNames): Watch for the status of availableMediaCharacteristicsWithMediaSelectionOptions
    to change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Exclusions] Zoom causes shape-inside to fail when shape-padding is specified
hmuller@adobe.com [Wed, 10 Apr 2013 21:22:39 +0000 (21:22 +0000)]
[CSS Exclusions] Zoom causes shape-inside to fail when shape-padding is specified
https://bugs.webkit.org/show_bug.cgi?id=113730

Reviewed by Dirk Schulze.

Source/WebCore:

Snap computed margin and polygon boundaries to the LayoutUnit grid to ensure
that they fall within the shape's LayoutUnit bounding box.

Test: fast/exclusions/shape-inside/shape-inside-polygon-zoom.html

* rendering/ExclusionPolygon.cpp:
(WebCore::snapVerticesToLayoutUnitGrid): Convert the FloatPoint coordinates to LayoutUnits and then back to floats.
(WebCore::computeShapePaddingBounds): Now calls snapVerticesToLayoutUnitGrid() before creating a FloatPolygon.
(WebCore::computeShapeMarginBounds): Ditto.

LayoutTests:

Verify that content lays out within a padded shape-inside polygon when the
document has been zoomed.

* fast/exclusions/shape-inside/shape-inside-polygon-zoom-expected.html: Added.
* fast/exclusions/shape-inside/shape-inside-polygon-zoom.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoOne more unreviewed buildfix after r148123.
ossy@webkit.org [Wed, 10 Apr 2013 21:11:23 +0000 (21:11 +0000)]
One more unreviewed buildfix after r148123.

* platform/graphics/filters/CustomFilterMeshGenerator.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFindBanner matches are offset when the WKView has a header or footer
bdakin@apple.com [Wed, 10 Apr 2013 20:57:25 +0000 (20:57 +0000)]
FindBanner matches are offset when the WKView has a header or footer
https://bugs.webkit.org/show_bug.cgi?id=114314
-and corresponding-
<rdar://problem/13522434>

Reviewed by Simon Fraser.

Source/WebCore:

There were already a few places in the code where we needed to adjust the
scrollOffset() to pretend that (0,0) is that the top of the Document rather than
the top of the header. To fix the FindBanner issues, we need to know that version
of the offset in a few more places, so I added a function on ScrollView to fetch
it called scrollOffsetRelativeToDocument().

New function subtracts out the headerHeight() to treat the top of
the document as (0,0).
* WebCore.exp.in:
* platform/ScrollView.cpp:
(WebCore::ScrollView::scrollOffsetRelativeToDocument):

Use scrollOffsetRelativeToDocument() where we were previously making this
calculation. Also re-name an inaccurately named variable where we are actually
converting FROM a document offset to a ScrollableArea offset.
(WebCore::ScrollView::windowToContents):
* platform/ScrollView.h:
(ScrollView):

getRectToExpose needs to know about the actual visibleContentRect and the
visibleContentRect that is relative to the Document. So this
patch adds a new parameter to getRectToExpose for that purpose.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollRectToVisible):
(WebCore::RenderLayer::getRectToExpose):
* rendering/RenderLayer.h:

Source/WebKit2:

When calculating the matching rects, also adjust to the scroll offset that is
relative to the Document.
* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::rectsForTextMatches):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowhen ARIA button contains a link, label text is ignored (affects main buttons on...
cfleizach@apple.com [Wed, 10 Apr 2013 20:45:43 +0000 (20:45 +0000)]
when ARIA button contains a link, label text is ignored (affects main buttons on m.facebook.com)
https://bugs.webkit.org/show_bug.cgi?id=113906

Reviewed by Tim Horton.

Source/WebCore:

If an element does not expose any children, then it's safe to include all of its sub children when determining
the visible text.
The bug is that all elements were ignoring focusable elements (like <a>) when determining visible children text

Test: accessibility/link-inside-button-accessible-text.html

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::shouldUseAccessiblityObjectInnerText):
* accessibility/AccessibilityNodeObject.h:
(AccessibilityNodeObject):
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isDescendantOfBarrenParent):
(AccessibilityObject):

LayoutTests:

The static-text-role-uses-text-under-element.html relies on similar logic to this bug.

I realized that it was verifying the wrong thing and if we had looked closely at this layout test
we would have caught this regression earlier most likely.

* accessibility/link-inside-button-accessible-text-expected.txt: Added.
* accessibility/link-inside-button-accessible-text.html: Added.
* platform/mac/accessibility/static-text-role-uses-text-under-element-expected.txt:
* platform/mac/accessibility/static-text-role-uses-text-under-element.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAX: Make sure all AX methods called from outside call prepareAccessibility
cfleizach@apple.com [Wed, 10 Apr 2013 20:38:25 +0000 (20:38 +0000)]
AX: Make sure all AX methods called from outside call prepareAccessibility
https://bugs.webkit.org/show_bug.cgi?id=113818

Reviewed by Darin Adler.

Make sure any calls that can be made from outside WebCore are protected with the
prepareAccessibility method.

* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityMathRootIndexObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathRadicandObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathNumeratorObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathDenominatorObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathBaseObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathSubscriptObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathSuperscriptObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathUnderObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathOverObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathFencedOpenString]):
(-[WebAccessibilityObjectWrapper accessibilityMathFencedCloseString]):
(-[WebAccessibilityObjectWrapper accessibilityIsMathTopObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathType]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove code duplicates from MacroAssemblerARM
paroga@webkit.org [Wed, 10 Apr 2013 20:30:19 +0000 (20:30 +0000)]
Remove code duplicates from MacroAssemblerARM
https://bugs.webkit.org/show_bug.cgi?id=104457

Reviewed by Oliver Hunt.

Reuse some existing methods to avoid duplicated code.

* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::store8):
(JSC::MacroAssemblerARM::store32):
(JSC::MacroAssemblerARM::swap):
(JSC::MacroAssemblerARM::add32):
(JSC::MacroAssemblerARM::sub32):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed buildfix after r148123.
ossy@webkit.org [Wed, 10 Apr 2013 20:21:02 +0000 (20:21 +0000)]
Unreviewed buildfix after r148123.

* inspector/InspectorInstrumentation.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChange all instances of test-results.appspot.com to webkit-test-results.appspot.com
ojan@chromium.org [Wed, 10 Apr 2013 20:05:48 +0000 (20:05 +0000)]
Change all instances of test-results.appspot.com to webkit-test-results.appspot.com
https://bugs.webkit.org/show_bug.cgi?id=114370

Reviewed by Ryosuke Niwa.

Finish the transition of WebKit over to it's own instance of the flakiness dashboard.
Unfortunately, there's no way to test this until this is committed and there is
a master restart.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
* TestResultServer/generate_builders_json.py:
* TestResultServer/static-dashboards/dashboard_base.js:
* TestResultServer/static-dashboards/loader.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoClicking on the volume slider of HTML5 elements is pausing sometimes
commit-queue@webkit.org [Wed, 10 Apr 2013 20:02:43 +0000 (20:02 +0000)]
Clicking on the volume slider of HTML5 elements is pausing sometimes
https://bugs.webkit.org/show_bug.cgi?id=112548

Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-04-10
Reviewed by Eric Carlson.

Source/WebCore:

Test: media/click-volume-bar-not-pausing.html

* html/shadow/MediaControlElementTypes.cpp:
(WebCore::MediaControlVolumeSliderElement::defaultEventHandler):
Calling the setDefaultHandled() method on the event prevents it
from being incorrectly propagated from the volume button up to the
MediaDocument.

LayoutTests:

Added test.

* media/click-volume-bar-not-pausing-expected.txt: Added.
* media/click-volume-bar-not-pausing.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDFG: Negative size for new Array() interpreted as large unsigned int
msaboff@apple.com [Wed, 10 Apr 2013 20:01:14 +0000 (20:01 +0000)]
DFG: Negative size for new Array() interpreted as large unsigned int
https://bugs.webkit.org/show_bug.cgi?id=114366

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Added new check in operationNewArrayWithSize() for a negative
size.  If size is negative throw a "RangeError: Array size is not a
small enough positive integer" exception.

* dfg/DFGOperations.cpp:

LayoutTests:

New test to make sure DFG generated code for new Array() with a
computed negative size throws an exception.

* fast/js/dfg-negative-array-size-expected.txt: Added.
* fast/js/dfg-negative-array-size.html: Added.
* fast/js/script-tests/dfg-negative-array-size.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Rename BlackBerry specific Texture class
anilsson@rim.com [Wed, 10 Apr 2013 19:56:23 +0000 (19:56 +0000)]
[BlackBerry] Rename BlackBerry specific Texture class
https://bugs.webkit.org/show_bug.cgi?id=95781

Reviewed by Rob Buis.

Texture was a bit too generic and prone to name conflicts. Renamed it
to LayerTexture.

Source/WebCore:

No change in behavior, no new tests.

PR 322882

* PlatformBlackBerry.cmake:
* platform/graphics/blackberry/LayerCompositingThread.cpp:
(WebCore::LayerCompositingThread::drawSurface):
(WebCore::LayerCompositingThread::contentsTexture):
* platform/graphics/blackberry/LayerCompositingThread.h:
(LayerCompositingThread):
* platform/graphics/blackberry/LayerCompositingThreadClient.h:
(WebCore):
(WebCore::LayerCompositingThreadClient::contentsTexture):
* platform/graphics/blackberry/LayerFilterRenderer.cpp:
(WebCore::LayerFilterRenderer::applyActions):
* platform/graphics/blackberry/LayerFilterRenderer.h:
(LayerFilterRenderer):
* platform/graphics/blackberry/LayerRendererSurface.h:
(WebCore::LayerRendererSurface::texture):
(LayerRendererSurface):
* platform/graphics/blackberry/LayerTexture.cpp: Renamed from Source/WebCore/platform/graphics/blackberry/Texture.cpp.
(WebCore):
(WebCore::LayerTexture::LayerTexture):
(WebCore::LayerTexture::~LayerTexture):
(WebCore::LayerTexture::updateContents):
(WebCore::LayerTexture::setContentsToColor):
(WebCore::LayerTexture::protect):
* platform/graphics/blackberry/LayerTexture.h: Renamed from Source/WebCore/platform/graphics/blackberry/Texture.h.
(WebCore):
(LayerTexture):
(WebCore::LayerTexture::create):
(WebCore::LayerTexture::textureId):
(WebCore::LayerTexture::isDirty):
(WebCore::LayerTexture::hasTexture):
(WebCore::LayerTexture::isColor):
(WebCore::LayerTexture::isOpaque):
(WebCore::LayerTexture::isProtected):
(WebCore::LayerTexture::protect):
(WebCore::LayerTexture::unprotect):
(WebCore::LayerTexture::size):
(WebCore::LayerTexture::width):
(WebCore::LayerTexture::height):
(WebCore::LayerTexture::bytesPerPixel):
(WebCore::LayerTexture::sizeInBytes):
(WebCore::LayerTexture::setTextureId):
(WebCore::LayerTexture::setSize):
* platform/graphics/blackberry/LayerTile.cpp:
(WebCore::LayerTile::setContents):
(WebCore::LayerTile::updateContents):
(WebCore::LayerTile::setTexture):
* platform/graphics/blackberry/LayerTile.h:
(WebCore::LayerTile::texture):
(LayerTile):
* platform/graphics/blackberry/LayerTiler.cpp:
(WebCore::LayerTiler::drawTile):
(WebCore::LayerTiler::contentsTexture):
* platform/graphics/blackberry/LayerTiler.h:
(LayerTiler):
(WebCore::LayerTiler::TextureJob::TextureJob):
(WebCore::LayerTiler::TextureJob::setContents):
(WebCore::LayerTiler::TextureJob::updateContents):
(TextureJob):
* platform/graphics/blackberry/TextureCacheCompositingThread.cpp:
(WebCore::TextureProtector::TextureProtector):
(TextureProtector):
(WebCore::TextureCacheCompositingThread::allocateTextureId):
(WebCore::freeTextureId):
(WebCore::TextureCacheCompositingThread::textureResized):
(WebCore::TextureCacheCompositingThread::textureSizeInBytesChanged):
(WebCore::TextureCacheCompositingThread::textureDestroyed):
(WebCore::TextureCacheCompositingThread::install):
(WebCore::TextureCacheCompositingThread::resizeTexture):
(WebCore::TextureCacheCompositingThread::evict):
(WebCore::TextureCacheCompositingThread::textureAccessed):
(WebCore::TextureCacheCompositingThread::prune):
(WebCore::TextureCacheCompositingThread::textureForTiledContents):
(WebCore::TextureCacheCompositingThread::textureForColor):
(WebCore::TextureCacheCompositingThread::updateContents):
* platform/graphics/blackberry/TextureCacheCompositingThread.h:
(WebCore::TextureCacheCompositingThread::createTexture):
(TextureCacheCompositingThread):
(WebCore::TextureCacheCompositingThread::ZombieTexture::ZombieTexture):
(ZombieTexture):

Source/WebKit/blackberry:

PR 322882

* Api/WebOverlay.cpp:
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):
* Api/WebOverlay_p.h:
(WebOverlayLayerCompositingThreadClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDisallow programmatic movement of the browser window while user gestures are in progress.
akling@apple.com [Wed, 10 Apr 2013 19:38:07 +0000 (19:38 +0000)]
Disallow programmatic movement of the browser window while user gestures are in progress.
<http://webkit.org/b/114271>
<rdar://problem/13226530>

Reviewed by Oliver Hunt.

* page/DOMWindow.cpp:
(WebCore::DOMWindow::moveBy):
(WebCore::DOMWindow::moveTo):
(WebCore::DOMWindow::resizeBy):
(WebCore::DOMWindow::resizeTo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWinCairo build fails to link.
commit-queue@webkit.org [Wed, 10 Apr 2013 19:33:39 +0000 (19:33 +0000)]
WinCairo build fails to link.
https://bugs.webkit.org/show_bug.cgi?id=114358

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-04-10
Reviewed by Brent Fulgham.

Export the symbol WTF::MD5::checksum().

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
* JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix regression to test-webkitpy.
glenn@skynav.com [Wed, 10 Apr 2013 19:24:46 +0000 (19:24 +0000)]
[Qt] Fix regression to test-webkitpy.
https://bugs.webkit.org/show_bug.cgi?id=114368

Reviewed by Ryosuke Niwa.

* Scripts/webkitpy/layout_tests/port/factory.py:
(PortFactory._default_port): Return qt-linux instead of chromium-linux as default port for linux/freebsd.
(PortFactory.get): Remove obsolete chromium port related code.
* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort.default_child_processes): Prevent type error if can't determine total memory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFixed build failure in Plugin.h: FloatPoint was not in namespace WebCore
commit-queue@webkit.org [Wed, 10 Apr 2013 19:18:46 +0000 (19:18 +0000)]
Fixed build failure in Plugin.h: FloatPoint was not in namespace WebCore

make[1]: *** Waiting for unfinished jobs....
In file included from Source/WebKit2/PluginProcess/PluginCreationParameters.h:31:0,
                 from Source/WebKit2/PluginProcess/PluginCreationParameters.cpp:27:
./Source/WebKit2/WebProcess/Plugins/Plugin.h:268:58: error: 'FloatPoint' in namespace 'WebCore' does not name a type
./Source/WebKit2/WebProcess/Plugins/Plugin.h:268:77: error: ISO C++ forbids declaration of 'parameter' with no type [-fpermissive]
cc1plus: warning: unrecognized command line option "-Wno-c++11-extensions" [enabled by default]
make[1]: *** [Source/WebKit2/PluginProcess/libwebkit2gtk_3_0_la-PluginCreationParameters.lo] Error 1

It now passes that make target.

https://bugs.webkit.org/show_bug.cgi?id=111862

Patch by Tobias Mueller <tobiasmue@gnome.org> on 2013-04-10
Reviewed by Darin Adler.

* WebProcess/Plugins/Plugin.h:
(WebCore): Added FloatPoint to the WebCore namespace

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRefactor Editor::markAndReplaceFor before fixing autocorrection bugs
rniwa@webkit.org [Wed, 10 Apr 2013 19:16:58 +0000 (19:16 +0000)]
Refactor Editor::markAndReplaceFor before fixing autocorrection bugs
https://bugs.webkit.org/show_bug.cgi?id=114344

Reviewed by Enrica Casucci.

This patch refactors Editor::markAndReplaceFor so that we can start fixing bugs in a sane state.
Extracted isAutomaticTextReplacementType and correctSpellcheckingPreservingTextCheckingParagraph,
and made convenience local variables const.

In particular, shouldMarkSpelling used to be assigned of false when shouldShowCorrectionPanel was true
in a middle of a function but this was removed in favor of explicitly checking this condition later
since shouldMarkSpelling was only referenced once after the assignment.

* editing/Editor.cpp:
(WebCore::isAutomaticTextReplacementType): Extracted.

(WebCore::correctSpellcheckingPreservingTextCheckingParagraph): Extracted.  Used highestAncestor
and rangeFromLocationAndLength to match the rest of the up-to-date editing code.

(WebCore::Editor::markAndReplaceFor): See above.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove unneeded headers from FrameLoader.h
andersca@apple.com [Wed, 10 Apr 2013 19:11:20 +0000 (19:11 +0000)]
Remove unneeded headers from FrameLoader.h
https://bugs.webkit.org/show_bug.cgi?id=114223

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Update for WTF changes.

* bytecode/SpeculatedType.h:
* runtime/JSCJSValue.h:

Source/WebCore:

Remove unneeded headers from FrameLoader.h and add them back into the respective .cpp files where needed.

* dom/Document.cpp:
* history/CachedFrame.cpp:
* history/PageCache.cpp:
* inspector/InspectorResourceAgent.cpp:
* loader/DocumentLoader.cpp:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::FrameLoader):
(WebCore::FrameLoader::retryAfterFailedCacheOnlyMainResourceLoad):
* loader/FrameLoader.h:
(WebCore):
(WebCore::FrameLoader::policyChecker):
(WebCore::FrameLoader::history):
(WebCore::FrameLoader::icon):
* loader/MixedContentChecker.h:
* loader/icon/IconLoader.cpp:
* page/History.cpp:
* page/Page.cpp:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
* testing/Internals.cpp:

Source/WebKit/blackberry:

Include HistoryController.h from WebCore.

* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

Source/WebKit/mac:

Include HistoryController.h from WebCore.

* WebCoreSupport/WebFrameLoaderClient.mm:
* WebView/WebView.mm:

Source/WebKit/win:

Include HistoryController.h from WebCore.

* WebView.cpp:

Source/WebKit2:

Include HistoryController.h from WebCore.

* WebProcess/Plugins/PDF/SimplePDFPlugin.h:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
* WebProcess/WebPage/WebPage.cpp:

Source/WTF:

* wtf/Forward.h:
Add PrintStream.

* wtf/HashTable.h:
Don't include DataLog.h unless DUMP_HASHTABLE_STATS_PER_TABLE is 1.

Tools:

Add back headers implicitly included by other headers.

* WebKitTestRunner/WorkQueueManager.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMinor code cleanup in AnimationBase::progress
simon.fraser@apple.com [Wed, 10 Apr 2013 19:03:02 +0000 (19:03 +0000)]
Minor code cleanup in AnimationBase::progress
https://bugs.webkit.org/show_bug.cgi?id=114371

Reviewed by Dean Jackson.

Convert some "return; else if" to just "return; if".

* page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::progress):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEmpty inline continuations should only get lineboxes if the padding applies to their...
robert@webkit.org [Wed, 10 Apr 2013 18:56:36 +0000 (18:56 +0000)]
Empty inline continuations should only get lineboxes if the padding applies to their side of the inline
https://bugs.webkit.org/show_bug.cgi?id=113896

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/inline/inline-with-empty-inline-continuations.html

Where an empty inline is split across anonymous blocks we should only give lineboxes to the 'sides' of the
inline that have borders, padding or margin.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::shouldApplyStartBorderPaddingOrMargin):
(WebCore):
(WebCore::shouldApplyEndBorderPaddingOrMargin):
(WebCore::hasInlineDirectionBordersPaddingOrMargin):
(WebCore::alwaysRequiresLineBox):

LayoutTests:

* fast/inline/inline-with-empty-inline-continuations-expected.txt: Added.
* fast/inline/inline-with-empty-inline-continuations.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Exclusions] Increasing padding does not correctly layout child blocks
zoltan@webkit.org [Wed, 10 Apr 2013 18:53:49 +0000 (18:53 +0000)]
[CSS Exclusions] Increasing padding does not correctly layout child blocks
https://bugs.webkit.org/show_bug.cgi?id=112929

Reviewed by David Hyatt.

If a child block has changed dimension inside a shape and it has affected the block siblings
we need to relayout the content inside the shape.

Source/WebCore:

Test: fast/exclusions/shape-inside/shape-inside-sibling-block-dimension-change-needs-relayout.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateRegionsAndExclusionsAfterChildLayout): Add condition for dimension change.
(WebCore::RenderBlock::layoutBlock): Call updateRegionsAndExclusionsAfterChildLayout with the new parameter.
* rendering/RenderBlock.h:
(RenderBlock): Add extra parameter to updateRegionsAndExclusionsAfterChildLayout(...)

LayoutTests:

* fast/exclusions/shape-inside/shape-inside-sibling-block-dimension-change-needs-relayout-expected.html: Added.
* fast/exclusions/shape-inside/shape-inside-sibling-block-dimension-change-needs-relayout.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemoved bitrotted TimeoutChecker code
ggaren@apple.com [Wed, 10 Apr 2013 18:51:47 +0000 (18:51 +0000)]
Removed bitrotted TimeoutChecker code
https://bugs.webkit.org/show_bug.cgi?id=114336

Reviewed by Alexey Proskuryakov.

../JavaScriptCore:

This mechanism hasn't worked for a while.

MarkL is working on a new version of this feature with a distinct
implementation.

* API/APIShims.h:
(JSC::APIEntryShim::~APIEntryShim):
(JSC::APIEntryShim::init):
* GNUmakefile.list.am:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
* JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* dfg/DFGGPRInfo.h:
* jit/JIT.cpp:
* jit/JIT.h:
* jit/JITStubs.cpp:
* jit/JITStubs.h:
* jit/JSInterfaceJIT.h:
(JSInterfaceJIT):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:
* runtime/JSGlobalObject.cpp:
* runtime/JSONObject.cpp:
(JSC::Stringifier::appendStringifiedValue):
(JSC::Walker::walk):
* runtime/TimeoutChecker.cpp: Removed.
* runtime/TimeoutChecker.h: Removed.

../WebCore:

This mechanism hasn't worked for a while.

MarkL is working on a new version of this feature with a distinct
implementation.

* bindings/js/JSCallbackData.cpp:
(WebCore::JSCallbackData::invokeCallback):
* bindings/js/JSCustomXPathNSResolver.cpp:
(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::commonJSGlobalData):
* bindings/js/JSErrorHandler.cpp:
(WebCore::JSErrorHandler::handleEvent):
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
* bindings/js/JSMutationCallback.cpp:
(WebCore::JSMutationCallback::call):
* bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::executeFunctionInContext):
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::evaluateInWorld):
* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneBase::CloneBase):
(WebCore::CloneSerializer::serialize):
(WebCore::CloneDeserializer::deserialize):
* bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::evaluate):
* bindings/objc/WebScriptObject.mm:
(-[WebScriptObject callWebScriptMethod:withArguments:]):
(-[WebScriptObject evaluateWebScript:]):

../WebKit/blackberry:

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::setTimeoutForJavaScriptExecution):

../WebKit/mac:

This mechanism hasn't worked for a while.

MarkL is working on a new version of this feature with a distinct
implementation.

* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::evaluate):

../WebKit/qt:

* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::createDocumentLoader):

../WebKit2:

This mechanism hasn't worked for a while.

MarkL is working on a new version of this feature with a distinct
implementation.

* WebProcess/Plugins/Netscape/NPJSObject.cpp:
(WebKit::NPJSObject::construct):
(WebKit::NPJSObject::invoke):
* WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
(WebKit::NPRuntimeObjectMap::evaluate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoReplace ENABLE_JAVASCRIPT_DEBUGGER preprocessor statements in IDL files with Conditio...
paroga@webkit.org [Wed, 10 Apr 2013 18:50:15 +0000 (18:50 +0000)]
Replace ENABLE_JAVASCRIPT_DEBUGGER preprocessor statements in IDL files with Conditional attribute
https://bugs.webkit.org/show_bug.cgi?id=114352

Reviewed by Timothy Hatcher.

The Conditional attribute does not need a preprocessor, which is source of much pain on native windows.

* page/Console.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLayers with opacity and blur filters are reported as opaque to the compositor
achicu@adobe.com [Wed, 10 Apr 2013 18:48:01 +0000 (18:48 +0000)]
Layers with opacity and blur filters are reported as opaque to the compositor
https://bugs.webkit.org/show_bug.cgi?id=114295

Reviewed by Simon Fraser.

Source/WebCore:

Test: compositing/contents-opaque/filter.html

Some filters like opacity and blur might still trigger transparency in the layer, even though the
background is opaque. I've added the special case in RenderLayer::backgroundIsKnownToBeOpaqueInRect to check
for filters that might have transparency. Note that this special case is required only for software drawn
filters, as the transparency is going to be backed in the GraphicsLayer content. Composited filters can
figure it out in the compositor.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::backgroundIsKnownToBeOpaqueInRect):

LayoutTests:

Added test to check for blur and opacity filters drawn in software mode which needs
to force the layer report non-opaque to the compositor.

* compositing/contents-opaque/filter-expected.txt: Added.
* compositing/contents-opaque/filter.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Texmap] In certain situations nested blending with overflow:hidden displays clipped...
commit-queue@webkit.org [Wed, 10 Apr 2013 18:26:26 +0000 (18:26 +0000)]
[Texmap] In certain situations nested blending with overflow:hidden displays clipped results
https://bugs.webkit.org/show_bug.cgi?id=114290

Patch by Noam Rosenthal <noam@webkit.org> on 2013-04-10
Reviewed by Allan Sandfeld Jensen.

Source/WebCore:

Always apply the clip when binding a surface, even if it hasn't changed.
Otherwise when binding a nested surface and rebinding its container surface,
the clip wouldn't apply.

Test: compositing/overlap-blending/nested-overlap-overflow.html

* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::bind):

LayoutTests:

Added a ref-test that exposes an issue with TextureMapper overlap blending when composited.
This ref-test does not show correct results on Mac, skipped in TestExpectations and created a bug.

* compositing/overlap-blending/nested-overlap-overflow-expected.html: Added.
* compositing/overlap-blending/nested-overlap-overflow.html: Added.
* platform/mac/TestExpectations: Skipped new tests and created bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoI should know better than to lie in ChangeLog entries.
mrowe@apple.com [Wed, 10 Apr 2013 18:17:16 +0000 (18:17 +0000)]
I should know better than to lie in ChangeLog entries.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago<rdar://problem/13617144> WKNavigationData needs to expose the destination of the...
mrowe@apple.com [Wed, 10 Apr 2013 18:14:42 +0000 (18:14 +0000)]
<rdar://problem/13617144> WKNavigationData needs to expose the destination of the navigation

Introduce WKNavigationDataCopyNavigationDestinationURL to access the destination of the navigation.

Reviewed by Darin Adler.

* UIProcess/API/C/WKNavigationData.cpp:
(WKNavigationDataCopyURL): Add a note about returning the URL from the original request for sake of
backwards-compatibility.
(WKNavigationDataCopyNavigationDestinationURL): Return the URL from our underlying WebNavigationDataStore.
* UIProcess/API/C/WKNavigationData.h:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::updateGlobalHistory): Store the current URL in to the WebNavigationDataStore
object. WKNavigationData can retrieve the value that we were previously storing here via the originalRequest.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago<rdar://problem/13617104> WKPageCopySessionState needs to provide more context to...
mrowe@apple.com [Wed, 10 Apr 2013 18:14:33 +0000 (18:14 +0000)]
<rdar://problem/13617104> WKPageCopySessionState needs to provide more context to the filter callback

Introduce a new value type for WKPageSessionStateFilterCallback that represents the passing
of whole WKBackForwardListItemRefs to the filter callback. This allows clients to consider
more than the original URL of the item when filtering entries from the session state.

Reviewed by Darin Adler.

* UIProcess/API/C/WKPage.cpp:
(WKPageGetSessionBackForwardListItemValueType): Return a static string representing our new value type.
* UIProcess/API/C/WKPage.h:
* UIProcess/cf/WebBackForwardListCF.cpp:
(WebKit::WebBackForwardList::createCFDictionaryRepresentation): Call the filter function with each of the
possible value types in turn, respecting the first false value, if any, that is returned.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse minimal tiles during live resize
antti@apple.com [Wed, 10 Apr 2013 18:07:41 +0000 (18:07 +0000)]
Use minimal tiles during live resize
https://bugs.webkit.org/show_bug.cgi?id=114364

Reviewed by Darin Adler.

We currently update non-visible speculative tiles during resizing. We should just drop them.

* page/FrameView.cpp:
(WebCore::FrameView::willStartLiveResize):
(WebCore::FrameView::willEndLiveResize):
* page/FrameView.h:
* rendering/RenderLayerBacking.cpp:
(WebCore::computeTileCoverage):

    Use minimal coverage in live resize state.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Include a crash-fixing patch for the at-spi2-atk dependency
zandobersek@gmail.com [Wed, 10 Apr 2013 18:05:41 +0000 (18:05 +0000)]
[GTK] Include a crash-fixing patch for the at-spi2-atk dependency
https://bugs.webkit.org/show_bug.cgi?id=114365

Reviewed by Martin Robinson.

Add a patch for the at-spi2-atk 2.8.0 dependency that is applied through the Jhbuild setup.
The patch addresses crashes in the tally_event_reply method. It is already committed into the
at-spi2-atk source tree and will be available with the next stable release, after which the
patch should be removed and the dependency version bumped.

* gtk/jhbuild.modules:
* gtk/patches/at-spi2-atk-2.8.0-null-check-after-cleanup.patch: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r148073): WebKit Nightly r148082 crashes on launch in JSObjectSetPrivate
oliver@apple.com [Wed, 10 Apr 2013 17:47:44 +0000 (17:47 +0000)]
REGRESSION (r148073): WebKit Nightly r148082 crashes on launch in JSObjectSetPrivate
https://bugs.webkit.org/show_bug.cgi?id=114341

Reviewed by Alexey Proskuryakov.

Make JSObjectSetPrivate use uncheckedToJS as some clients
clear their private data during finalization for some reason.

* API/JSObjectRef.cpp:
(JSObjectSetPrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBlob content type normalization.
commit-queue@webkit.org [Wed, 10 Apr 2013 17:13:40 +0000 (17:13 +0000)]
Blob content type normalization.
https://bugs.webkit.org/show_bug.cgi?id=111380

Patch by Victor Costan <costan@gmail.com> on 2013-04-10
Reviewed by Alexey Proskuryakov.

Source/WebCore:

Tests: http/tests/fast/files/blob-constructor.js
       http/tests/fileapi/xhr-send-form-data-filename-escaping.html
       http/tests/fileapi/xhr-send-form-data-mimetype-normalization.html

* WebCore.exp.in: exported Blob::isNormalizedContentType()
* bindings/js/JSBlobCustom.cpp:
(WebCore::JSBlobConstructor::constructJSBlob): remove checks on Blob type, BlobBuilder will normalize it
* fileapi/Blob.cpp:
(BlobType): utilities for normalizing a Blob's type according to the File API spec
(WebCore::BlobType::isValid): content type validity checks in the File API spec
(WebCore::BlobType::normalize): implements the normalization rules in the File API spec
(WebCore::BlobType::isNormalized): useful for ASSERTing that a Blob type has been normalized
(WebCore): implement Blob type normalization according to the File API spec
(WebCore::Blob::Blob): normalize the Blob type in the data URL
(WebCore::Blob::slice): normalize the Blob type argument
* fileapi/Blob.h:
(BlobType): utilities for normalizing a Blob's type according to the File API spec
(WebCore::Blob::create): assert that the deserialized Blob's type was normalized
* fileapi/File.cpp:
(WebCore::createBlobDataForFileWithType): assert that the File's MIME type is a normalized Blob type
* fileapi/WebKitBlobBuilder.cpp:
(WebCore::BlobBuilder::getBlob): normalize the Blob's type before building it
* platform/network/BlobData.h:
(WebCore::BlobData::setContentType): assert that the Blob type has been normalized
* platform/network/FormData.cpp:
(WebCore::FormData::appendKeyValuePairItems): assert that Blob's type has been normalized
* platform/network/FormDataBuilder.cpp:
(WebCore::FormDataBuilder::addContentTypeToMultiPartHeader): assert that the Content-Type field is normalized
* xml/XMLHttpRequest.cpp: when responseType is blob, normalize Content-Type before passing to Blob constructor

LayoutTests:

* http/tests/fast/files/script-tests/blob-constructor.js: added/updated test cases for Blob type normalization
* http/tests/fast/files/blob-constructor-expected.txt: added/updated test cases for Blob type normalization
* http/tests/fileapi/xhr-send-form-data-filename-escaping-expected.txt: Added.
* http/tests/fileapi/xhr-send-form-data-filename-escaping.html: Added.
* http/tests/fileapi/xhr-send-form-data-mimetype-normalization-expected.txt: Added.
* http/tests/fileapi/xhr-send-form-data-mimetype-normalization.html: Added.
* http/tests/local/formdata/resources/send-form-data-common.js:
(dumpResponse): return the HTTP response text so it can be used in JS test code
(sendFormData): passthrough the HTTP response text returned by dumpResponse()
(testSendingFormData): passthrough the HTTP response text returned by dumpResponse()
* http/tests/xmlhttprequest/post-blob-content-type-async-expected.txt: updated expectation for invalid Content-Type
* http/tests/xmlhttprequest/post-blob-content-type-sync-expected.txt: updated expectation for invalid Content-Type
* http/tests/xmlhttprequest/post-blob-content-type-tests.js: updated expectation for invalid Content-Type

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline four tiled drawing tests affeted by r148049.
simon.fraser@apple.com [Wed, 10 Apr 2013 17:11:07 +0000 (17:11 +0000)]
Rebaseline four tiled drawing tests affeted by r148049.

Move results from platform/mac/platform/mac-wk2/tiled-drawing to  platform/mac-wk2/tiled-drawing

* platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-body-layer-expected.txt:
* platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-expected.txt:
* platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-opacity-html-expected.txt:
* platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-positioned-expected.txt:
* platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-transformed-html-expected.txt:
* platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.txt:
* platform/mac-wk2/tiled-drawing/fixed-background/fixed-html-background-expected.txt:
* platform/mac-wk2/tiled-drawing/fixed/four-bars-expected.txt:
* platform/mac-wk2/tiled-drawing/fixed/four-bars-with-header-and-footer-expected.txt:
* platform/mac-wk2/tiled-drawing/fixed/four-bars-zoomed-expected.txt:
* platform/mac-wk2/tiled-drawing/fixed/negative-scroll-offset-in-view-expected.txt:
* platform/mac-wk2/tiled-drawing/sticky/sticky-vertical-expected.txt:
* platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-body-layer-expected.txt: Removed.
* platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-expected.txt: Removed.
* platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-opacity-html-expected.txt: Removed.
* platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-positioned-expected.txt: Removed.
* platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-transformed-html-expected.txt: Removed.
* platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.txt: Removed.
* platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-html-background-expected.txt: Removed.
* platform/mac/platform/mac-wk2/tiled-drawing/sticky/sticky-vertical-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WinCairo] Unreviewed build fix. Correct DropBox download link.
bfulgham@webkit.org [Wed, 10 Apr 2013 16:50:41 +0000 (16:50 +0000)]
[WinCairo] Unreviewed build fix. Correct DropBox download link.

* Scripts/update-webkit-wincairo-libs: Revise download URL to
match change in DropBox server behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTileController doesn't remove tiles when the view is resized, leading to stale content
timothy_horton@apple.com [Wed, 10 Apr 2013 16:32:51 +0000 (16:32 +0000)]
TileController doesn't remove tiles when the view is resized, leading to stale content
https://bugs.webkit.org/show_bug.cgi?id=114323
<rdar://problem/13520671>

Reviewed by Simon Fraser.

Ensure that tiles are removed if the view shrinks, so that they are not displayed
with stale content if the view later grows again (they will not be repainted by WebCore
while out-of-view).

* platform/graphics/ca/mac/TileController.h:
* platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::revalidateTiles):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate the localizable strings file.
jberlin@webkit.org [Wed, 10 Apr 2013 16:28:34 +0000 (16:28 +0000)]
Update the localizable strings file.

Rubber-stamped by Dan Bernstein.

* English.lproj/Localizable.strings:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoReplace ENABLE_CHANNEL_MESSAGING preprocessor statements in IDL files with Conditiona...
paroga@webkit.org [Wed, 10 Apr 2013 16:27:10 +0000 (16:27 +0000)]
Replace ENABLE_CHANNEL_MESSAGING preprocessor statements in IDL files with Conditional attribute
https://bugs.webkit.org/show_bug.cgi?id=114346

Reviewed by Geoffrey Garen.

The Conditional attribute does not need a preprocessor, which is source of much pain on native windows.

* page/DOMWindow.idl:
* workers/WorkerContext.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate all float attributes in HTMLMediaElement to double
eric.carlson@apple.com [Wed, 10 Apr 2013 16:25:14 +0000 (16:25 +0000)]
Update all float attributes in HTMLMediaElement to double
https://bugs.webkit.org/show_bug.cgi?id=113615

Reviewed by Geoffrey Garen
Patch by Aaron Colwell

No new tests. Primary behavior doesn't change. Just time, playbackRate, and volume precision.
All existing LayoutTests/media tests still pass.

* WebCore.exp.in: Remove function that no longer need to be exported.

* html/HTMLMediaElement.cpp: Change all float attributes to double.
* html/HTMLMediaElement.h: Ditto.
* html/HTMLMediaElement.idl: Ditto.
* html/MediaController.cpp: Ditto.
* html/MediaController.h: Ditto.
* html/MediaControllerInterface.h: Ditto.
* html/TimeRanges.cpp: Ditto.
* html/TimeRanges.idl: Ditto.
* html/shadow/MediaControlElementTypes.cpp: Ditto.
* html/shadow/MediaControlElementTypes.h: Ditto.
* html/shadow/MediaControlElements.cpp: Ditto.
* html/shadow/MediaControlElements.h: Ditto.
* html/shadow/MediaControls.cpp: Ditto.
* html/shadow/MediaControlsApple.cpp: Ditto.
* html/shadow/MediaControlsBlackBerry.cpp: Ditto.
* html/shadow/MediaControlsBlackBerry.h: Ditto.
* html/shadow/MediaControlsGtk.cpp: Ditto.
* html/track/TextTrackCue.cpp: Ditto.
* html/track/TextTrackCue.h: Ditto.
* platform/Clock.h: Ditto.
* platform/ClockGeneric.cpp: Ditto.
* platform/ClockGeneric.h: Ditto.
* platform/graphics/MediaPlayer.cpp: Ditto.
* platform/graphics/MediaPlayer.h: Ditto.
* platform/graphics/MediaPlayerPrivate.h: Ditto.
* platform/mac/PlatformClockCA.cpp: Ditto.
* platform/mac/PlatformClockCA.h: Ditto.
* platform/mac/PlatformClockCM.h: Ditto.
* platform/mac/PlatformClockCM.mm: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoReplace ENABLE_MICRODATA preprocessor statements in IDL files with Conditional attribute
paroga@webkit.org [Wed, 10 Apr 2013 16:16:13 +0000 (16:16 +0000)]
Replace ENABLE_MICRODATA preprocessor statements in IDL files with Conditional attribute
https://bugs.webkit.org/show_bug.cgi?id=114349

Reviewed by Geoffrey Garen.

The Conditional attribute does not need a preprocessor, which is source of much pain on native windows.

* dom/Document.idl:
* html/HTMLElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r148034): IconDatabase::updateIconRecord crashes with null iconData and...
rakuco@webkit.org [Wed, 10 Apr 2013 16:13:35 +0000 (16:13 +0000)]
REGRESSION(r148034): IconDatabase::updateIconRecord crashes with null iconData and iconBitmap.
https://bugs.webkit.org/show_bug.cgi?id=114356

Reviewed by Tim Horton.

When loading an icon fails (for example, when a non-existent URI is
passed to the loader), updateIconRecord can be called with both
iconData and iconBitmap having no data.

This used to be fine before r148034, but causes an assertion now.

No new tests, existing tests such as fast/encoding/mispositioned-meta.html
were crashing.

* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::updateIconRecord): Change the ASSERT() to check
for a NAND condition that only fails if both iconData and iconBitmap
are not 0.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemoved an annoying message from svn-create-patch
ggaren@apple.com [Wed, 10 Apr 2013 15:44:29 +0000 (15:44 +0000)]
Removed an annoying message from svn-create-patch
https://bugs.webkit.org/show_bug.cgi?id=114332

Reviewed by Alexey Proskuryakov.

I see this message basically every time I write a patch, so it must not
be true.

* Scripts/svn-create-patch:
(generateDiff):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Add API in QWebSettings for setting the CSS media type
commit-queue@webkit.org [Wed, 10 Apr 2013 15:10:08 +0000 (15:10 +0000)]
[Qt] Add API in QWebSettings for setting the CSS media type
https://bugs.webkit.org/show_bug.cgi?id=113853

Patch by Jose Lejin PJ <jose.lejin@gmail.com> on 2013-04-10
Reviewed by Jocelyn Turcotte.

* Api/qwebsettings.cpp:
(QWebSettingsPrivate):
(QWebSettingsPrivate::apply):
(QWebSettings::setCSSMediaType):
(QWebSettings::cssMediaType):
* Api/qwebsettings.h:
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::overrideMediaType):
* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage):
(tst_QWebPage::cssMediaTypeGlobalSetting):
(tst_QWebPage::cssMediaTypePageSetting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Texmap] Update a dirty region which is not covered with keepRect.
commit-queue@webkit.org [Wed, 10 Apr 2013 14:58:37 +0000 (14:58 +0000)]
[Texmap] Update a dirty region which is not covered with keepRect.
https://bugs.webkit.org/show_bug.cgi?id=113752

Patch by JungJik Lee <jungjik.lee@samsung.com> on 2013-04-10
Reviewed by Jocelyn Turcotte.

There can be a dirty region which is not covered with keepRect.
However the dirty could be inside the tile area. In this case,
currently we ignore the dirty by intersecting with keepRect
and the dirty region will not be invalidated until the tile is
recreated. We must expand the keep rect to its intersecting tiles
to make sure that the dirty region is applied to existing tiles.

No tests needed, change is unobservable.

* platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::invalidate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove ENABLE_3D_PLUGIN
l.gombos@samsung.com [Wed, 10 Apr 2013 14:36:00 +0000 (14:36 +0000)]
Remove ENABLE_3D_PLUGIN
https://bugs.webkit.org/show_bug.cgi?id=108002

Source/WebCore:

Remove ENABLE_3D_PLUGIN, it was only used by Chromium.

Reviewed by Antti Koivisto.

No new tests, removing dead code.

* loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::loadPlugin):

Source/WTF:

Reviewed by Antti Koivisto.

Remove ENABLE_3D_PLUGIN, it was only used by Chromium.

* wtf/FeatureDefines.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Regions] Add tests for lists and counters
abucur@adobe.com [Wed, 10 Apr 2013 13:47:24 +0000 (13:47 +0000)]
[CSS Regions] Add tests for lists and counters
https://bugs.webkit.org/show_bug.cgi?id=103975

Reviewed by Antti Koivisto.

Lists and counters work correctly with regions since r148026 (http://trac.webkit.org/changeset/148026).
This patch adds W3C formatted ref tests to our battery.

* fast/regions/counters/extract-list-items-001-expected.html: Added.
* fast/regions/counters/extract-list-items-001.html: Added.
* fast/regions/counters/extract-list-items-002-expected.html: Added.
* fast/regions/counters/extract-list-items-002.html: Added.
* fast/regions/counters/extract-list-items-003-expected.html: Added.
* fast/regions/counters/extract-list-items-003.html: Added.
* fast/regions/counters/extract-list-items-004-expected.html: Added.
* fast/regions/counters/extract-list-items-004.html: Added.
* fast/regions/counters/extract-list-items-005-expected.html: Added.
* fast/regions/counters/extract-list-items-005.html: Added.
* fast/regions/counters/extract-list-items-006-expected.html: Added.
* fast/regions/counters/extract-list-items-006.html: Added.
* fast/regions/counters/extract-list-items-007-expected.html: Added.
* fast/regions/counters/extract-list-items-007.html: Added.
* fast/regions/counters/extract-list-items-008-expected.html: Added.
* fast/regions/counters/extract-list-items-008.html: Added.
* fast/regions/counters/extract-list-items-009-expected.html: Added.
* fast/regions/counters/extract-list-items-009.html: Added.
* fast/regions/counters/extract-list-items-010-expected.html: Added.
* fast/regions/counters/extract-list-items-010.html: Added.
* fast/regions/counters/extract-list-items-011-expected.html: Added.
* fast/regions/counters/extract-list-items-011.html: Added.
* fast/regions/counters/extract-list-items-012-expected.html: Added.
* fast/regions/counters/extract-list-items-012.html: Added.
* fast/regions/counters/extract-list-items-013-expected.html: Added.
* fast/regions/counters/extract-list-items-013.html: Added.
* fast/regions/counters/extract-list-items-014-expected.html: Added.
* fast/regions/counters/extract-list-items-014.html: Added.
* fast/regions/counters/extract-list-items-015-expected.html: Added.
* fast/regions/counters/extract-list-items-015.html: Added.
* fast/regions/counters/extract-numbered-paragraphs-divs-001-expected.html: Added.
* fast/regions/counters/extract-numbered-paragraphs-divs-001.html: Added.
* fast/regions/counters/extract-numbered-paragraphs-divs-002-expected.html: Added.
* fast/regions/counters/extract-numbered-paragraphs-divs-002.html: Added.
* fast/regions/counters/extract-numbered-paragraphs-expected.html: Added.
* fast/regions/counters/extract-numbered-paragraphs.html: Added.
* fast/regions/counters/extract-numbered-spans-display-only-some-expected.html: Added.
* fast/regions/counters/extract-numbered-spans-display-only-some.html: Added.
* fast/regions/counters/extract-ordered-lists-in-regions-001-expected.html: Added.
* fast/regions/counters/extract-ordered-lists-in-regions-001.html: Added.
* fast/regions/counters/extract-ordered-lists-in-regions-002-expected.html: Added.
* fast/regions/counters/extract-ordered-lists-in-regions-002.html: Added.
* fast/regions/counters/extract-ordered-lists-in-regions-003-expected.html: Added.
* fast/regions/counters/extract-ordered-lists-in-regions-003.html: Added.
* fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-001-expected.html: Added.
* fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-001.html: Added.
* fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-002-expected.html: Added.
* fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-002.html: Added.
* fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-003-expected.html: Added.
* fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-003.html: Added.
* fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-004-expected.html: Added.
* fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-004.html: Added.
* fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005-expected.html: Added.
* fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005.html: Added.
* fast/regions/counters/extract-unordered-lists-in-regions-expected.html: Added.
* fast/regions/counters/extract-unordered-lists-in-regions.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Unreviewed gardening. Rebaselining after r148049.
zarvai@inf.u-szeged.hu [Wed, 10 Apr 2013 12:18:33 +0000 (12:18 +0000)]
[Qt][WK2] Unreviewed gardening. Rebaselining after r148049.

* platform/qt-5.0-wk2/compositing/iframes/composited-parent-iframe-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe2-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe3-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/enter-compositing-iframe-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/iframe-resize-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/invisible-nested-iframe-show-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/overlapped-iframe-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Texmap] Hierarchy of layers with opacity may result in wrong blending.
commit-queue@webkit.org [Wed, 10 Apr 2013 11:48:32 +0000 (11:48 +0000)]
[Texmap] Hierarchy of layers with opacity may result in wrong blending.
https://bugs.webkit.org/show_bug.cgi?id=113732

Patch by Noam Rosenthal <noam@webkit.org> on 2013-04-10
Reviewed by Allan Sandfeld Jensen.

Source/WebCore:

This is a combination of three issues with nested intermediate surfaces:
- glScissor inside an intermediate surface should not be mirrored.
- The current surface should be passed to the next surface in paintOptions.
- When clipping for the non-overlap region, the containing surface offset
should be applied.

Though the changes are separate, they cannot be tested separately as neither
fixes a testable case on its own.

Tests: compositing/overlap-blending/nested-non-overlap-clipping.html
       compositing/overlap-blending/nested-overlap.html

* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::ClipStack::reset):
(WebCore::TextureMapperGL::ClipStack::apply):
(WebCore::TextureMapperGL::beginPainting):
(WebCore::BitmapTextureGL::clearIfNeeded):
* platform/graphics/texmap/TextureMapperGL.h:
(ClipStack):
    Do not mirror the scissor clip when painting to an FBO.
    Also a minor refactor to avoid reading the viewport values from the driver.

* platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::paintUsingOverlapRegions):
    Apply the offset when clipping for a non-overlap region.
(WebCore::TextureMapperLayer::paintIntoSurface):
    Make sure the current surface is passed to the next one.

LayoutTests:

Added two ref-tests for nested composited overlaps.
This ref-test does not work on Mac due to a slight mismatch opacity value on CoreAnimation.
A new bug has been posted, and TestExpectations has been updated.

* compositing/overlap-blending/nested-non-overlap-clipping-expected.html: Added.
* compositing/overlap-blending/nested-non-overlap-clipping.html: Added.
* compositing/overlap-blending/nested-overlap-expected.html: Added.
* compositing/overlap-blending/nested-overlap.html: Added.
* platform/mac/TestExpectations: Skipped new tests and created bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCreate fewer tiles when page is loading
antti@apple.com [Wed, 10 Apr 2013 11:34:53 +0000 (11:34 +0000)]
Create fewer tiles when page is loading
https://bugs.webkit.org/show_bug.cgi?id=114294

Source/WebCore:

Reviewed by Anders Carlsson.

We currently create speculative tiles immediately. Page is often changing rapidly during loading and
keeping the speculative tiles up to date creates extra work.

Tests: platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll-speculative.html
       platform/mac-wk2/tiled-drawing/tile-coverage-speculative.html

       * loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadProgressingStatusChanged):
* page/FrameView.cpp:
(WebCore::FrameView::adjustTiledBackingCoverage):
(WebCore::FrameView::setWasScrolledByUser):

    User scrolling enables speculative tiling no matter what the load status.

* page/FrameView.h:
* rendering/RenderLayerBacking.cpp:
(WebCore::computeTileCoverage):
(WebCore::RenderLayerBacking::adjustTiledBackingCoverage):

    Cover only the viewport during loading.

LayoutTests:

Reviewed by Anders Carlsson.

Reduced initial tile counts and new tests for speculative tiles.

* platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-no-image-expected.txt:
* platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll-expected.txt:
* platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll-speculative-expected.txt: Added.
* platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll-speculative.html: Added.
* platform/mac-wk2/tiled-drawing/tile-coverage-scroll-to-bottom-expected.txt:
* platform/mac-wk2/tiled-drawing/tile-coverage-speculative-expected.txt: Added.
* platform/mac-wk2/tiled-drawing/tile-coverage-speculative.html: Added.
* platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-expected.txt:
* platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-scrolled-expected.txt:
* platform/mac-wk2/tiled-drawing/use-tiled-drawing-expected.txt:
* platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-body-layer-expected.txt:
* platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-expected.txt:
* platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-opacity-html-expected.txt:
* platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-positioned-expected.txt:
* platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-transformed-html-expected.txt:
* platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.txt:
* platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-html-background-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Add support for Page Visibility
mario@webkit.org [Wed, 10 Apr 2013 10:48:30 +0000 (10:48 +0000)]
[GTK] Add support for Page Visibility
https://bugs.webkit.org/show_bug.cgi?id=97324

Patch by Anton Obzhirov <a.obzhirov@samsung.com> on 2013-04-10
Reviewed by Sam Weinig.

.:

Page Visibility has been enabled for GTK port.
New GTK unittest has been added.

* Source/autotools/SetupWebKitFeatures.m4:

Source/WebKit/gtk:

Implemented access to page visibility API for GTK test runner.

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::setPageVisibility):
* WebCoreSupport/DumpRenderTreeSupportGtk.h:

Source/WebKit2:

Added new unittest to test page visibility using GTK Widget visibility API.

* UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewPageVisibility):
(beforeAll):
* UIProcess/API/gtk/tests/WebViewTest.cpp:
(WebViewTest::showInWindow):
* UIProcess/API/gtk/tests/WebViewTest.h:

Tools:

Implemented test runner API for page visibility layout tests.

* DumpRenderTree/gtk/TestRunnerGtk.cpp:
(TestRunner::resetPageVisibility):
(TestRunner::setPageVisibility):
* Scripts/webkitperl/FeatureList.pm:

LayoutTests:

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] RenderThemeBlackBerry: get rid of all the SKIA code
commit-queue@webkit.org [Wed, 10 Apr 2013 09:47:41 +0000 (09:47 +0000)]
[BlackBerry] RenderThemeBlackBerry: get rid of all the SKIA code
https://bugs.webkit.org/show_bug.cgi?id=114339

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-10
Reviewed by Carlos Garcia Campos.

* platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::paintMediaSliderTrack):
(WebCore::RenderThemeBlackBerry::paintMediaSliderThumb):
(WebCore::RenderThemeBlackBerry::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeBlackBerry::paintMediaVolumeSliderThumb):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[ATK] REGRESSION(r148033): Add a stub for AccessibilityUIElement::pathDescription().
rakuco@webkit.org [Wed, 10 Apr 2013 09:17:09 +0000 (09:17 +0000)]
[ATK] REGRESSION(r148033): Add a stub for AccessibilityUIElement::pathDescription().
https://bugs.webkit.org/show_bug.cgi?id=114342

Reviewed by Gyuyoung Kim.

Commit 148033 only added an implementation for the Mac port, which made
other ports fail most tests since loading the injected bundle failed
with a missing symbol.

* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::pathDescription):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening. Rebaselining after r148049.
zarvai@inf.u-szeged.hu [Wed, 10 Apr 2013 09:06:48 +0000 (09:06 +0000)]
[Qt] Unreviewed gardening. Rebaselining after r148049.

* platform/qt-5.0-wk2/compositing/iframes/page-cache-layer-tree-expected.txt: Removed.
* platform/qt/compositing/iframes/page-cache-layer-tree-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk1/compositing/iframes/page-cache-layer-tree-expected.txt.
* platform/qt/fast/multicol/shadow-breaking-expected.txt:
* platform/qt/svg/css/composite-shadow-text-expected.png:
* platform/qt/svg/css/composite-shadow-text-expected.txt:
* platform/qt/svg/css/group-with-shadow-expected.txt:
* platform/qt/svg/css/path-with-shadow-expected.txt:
* platform/qt/svg/css/shadow-and-opacity-expected.txt:
* platform/qt/svg/css/shadow-breaking-expected.png: Added.
* platform/qt/svg/css/text-shadow-multiple-expected.txt:
* platform/qt/transitions/svg-text-shadow-transition-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Add spell checking option to MiniBrowser
commit-queue@webkit.org [Wed, 10 Apr 2013 07:55:54 +0000 (07:55 +0000)]
[EFL] Add spell checking option to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=114282

Patch by Artur Moryc <a.moryc@samsung.com> on 2013-04-10
Reviewed by Ryosuke Niwa.

Spell checking is enabled by adding a flag (t/text-checking)
with launching MiniBrowser.

* MiniBrowser/efl/main.c:
(window_create):
(elm_main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r146518): WebKit2APITests/TestInspector is failing
zandobersek@gmail.com [Wed, 10 Apr 2013 07:39:18 +0000 (07:39 +0000)]
REGRESSION (r146518): WebKit2APITests/TestInspector is failing
https://bugs.webkit.org/show_bug.cgi?id=113281

Reviewed by Darin Adler.

Source/WebKit2:

Changes to the WebInspectorProxy opening processing in r146518 caused the change in how the GTK-specific
WebInspectorProxy code operates, specifically the 'bring-to-front' signal is not emitted anymore when opening the
inspector due to the WebInspectorProxy::bringToFront method now only bringing the inspector window to front if it exists
and opening it (and thus unable to bring it to front) otherwise.

Closing of the inspector through the didClose method is now done immediately after sending the WebInspector::Close()
message to the WebProcess rather than waiting for the WebProcess to communicate back the order of closing. Due to this
the relevant code in the test cases had to be changed to not run the loop but rather just check that the closing was
successful.

(InspectorTest::InspectorTest): Remove the initialization of the now redundant m_quitOnBringToFront member variable.
(InspectorTest::bringToFront): Quit the loop without checking the removed member variable.
(InspectorTest::closed): Do not quit the loop as it is not run anymore.
(InspectorTest::showIdle): A helper method that asynchronously calls the webkit_web_inspector_show method, removing some
unnecessary complexity about under what exact circumstances to quit the loop in open-window/bring-to-front callbacks.
(InspectorTest::show): Replaces the showAndWaitUntilFinished method, adding an idle invocation of the showIdle helper
method and running the loop.
(InspectorTest::close): Formerly closeAndWaitUntilClosed, now does not run the loop anymore as there's no need for it.
(testInspectorDefault): Only the window opening event is now expected upon showing the inspector for the first time.
Adjusting callsites to use InspectorTest::show and InspectorTest::close instead of
InspectorTest::showAndWaitUntilFinished and InspectorTest::showAndWaitUntilFinished.
(CustomInspectorTest::destroyWindow): Formerly destroyWindowAndWaitUntilClosed, the closing is not asynchronous anymore
so the loop is not run.
(testInspectorManualAttachDetach): Only the window opening event is now expected upon showing the inspector for the first time.
Adjusting callsites to use InspectorTest::show and InspectorTest::close instead of
InspectorTest::showAndWaitUntilFinished and InspectorTest::showAndWaitUntilFinished.
(testInspectorCustomContainerDestroyed): Adjusting callsites to use InspectorTest::show and CustomInspectorTest::destroyWindow
instead of InspectorTest::showAndWaitUntilFinished and CustomInspectorTest::destroyWindowAndWaitUntilClosed.
* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::show): When showing a connected WebInspectorProxy, call the bringToFront method which will
open the inspector if it's not yet visible or bring it to the front otherwise.

Tools:

* Scripts/run-gtk-tests:
(TestRunner): Remove the skip entry for the WebKit2APITests/TestInspector unit test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK][WK2] Implement WebInspectorProxy::platformInspectedWindowWidth
zandobersek@gmail.com [Wed, 10 Apr 2013 07:38:02 +0000 (07:38 +0000)]
[GTK][WK2] Implement WebInspectorProxy::platformInspectedWindowWidth
https://bugs.webkit.org/show_bug.cgi?id=113498

Patch by Zan Dobersek <zandobersek@gmail.com> on 2013-04-10
Reviewed by Martin Robinson.

The method was introduced in r147004.

* UIProcess/API/gtk/tests/TestInspector.cpp: Specify the gMinimumAttachedInspectorWidth variable, reflecting the value
of WebInspectorProxy::minimumAttachedWidth. Use it as the width to which the inspected view should be resized in
InspectorTest::resizeViewAndAttach.
* UIProcess/gtk/WebInspectorProxyGtk.cpp:
(WebKit::WebInspectorProxy::platformInspectedWindowHeight): Use the gtk_widget_get_allocated_height method to return the
widget height.
(WebKit::WebInspectorProxy::platformInspectedWindowWidth): Newly implemented, similarly uses the
gtk_widget_get_allocated_width method to return the widget width.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r147719): Failures in two a11y tests on GTK
zandobersek@gmail.com [Wed, 10 Apr 2013 07:36:42 +0000 (07:36 +0000)]
REGRESSION (r147719): Failures in two a11y tests on GTK
https://bugs.webkit.org/show_bug.cgi?id=114259

Reviewed by Ryosuke Niwa.

No new tests - covered by existing tests.

Partially revert r147719, restoring the possible creation of the AXObject cache
and the subsequent call to its handleFocusedUIElementChanged method. Removing this
code caused regressions in accessibility tests on the GTK port, so the comment about
the AXObject cache is adjusted accordingly.

* dom/Document.cpp:
(WebCore::Document::setFocusedNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening. Rebaselining after r148049.
zandobersek@gmail.com [Wed, 10 Apr 2013 07:18:22 +0000 (07:18 +0000)]
Unreviewed GTK gardening. Rebaselining after r148049.

* platform/gtk/fast/multicol/shadow-breaking-expected.txt:
* platform/gtk/svg/css/composite-shadow-text-expected.txt:
* platform/gtk/svg/css/group-with-shadow-expected.txt:
* platform/gtk/svg/css/path-with-shadow-expected.txt:
* platform/gtk/svg/css/shadow-and-opacity-expected.txt:
* platform/gtk/svg/css/shadow-changes-expected.txt:
* platform/gtk/svg/css/text-gradient-shadow-expected.txt:
* platform/gtk/svg/css/text-shadow-multiple-expected.txt:
* platform/gtk/svg/custom/transform-with-shadow-and-gradient-expected.txt:
* platform/gtk/transitions/svg-text-shadow-transition-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GStreamer] playbin uri getter is invalid
philn@webkit.org [Wed, 10 Apr 2013 06:59:28 +0000 (06:59 +0000)]
[GStreamer] playbin uri getter is invalid
https://bugs.webkit.org/show_bug.cgi?id=113884

Reviewed by Martin Robinson.

Source/WebCore:

When loading a new media location use the url stored as a member
variable instead of the one stored as a playbin property. The uri
property semantic changed in playbin since 0.10.36+. One should
now use current-uri but to avoid ifdefs depending on GStreamer
version we simply use the url already known as member variable.

Test: http/tests/media/video-redirect.html

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

LayoutTests:

New test for Quicktime reference movie redirect
support.

* http/tests/media/resources/redirect-to-counting-captioned.mov: Added.
* http/tests/media/video-redirect-expected.txt: Added.
* http/tests/media/video-redirect.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWKFrameIsDisplayingMarkupDocument should return true for Web Archives
graouts@apple.com [Wed, 10 Apr 2013 06:45:02 +0000 (06:45 +0000)]
WKFrameIsDisplayingMarkupDocument should return true for Web Archives
https://bugs.webkit.org/show_bug.cgi?id=114291

Reviewed by Dean Jackson.

Also return true for the Web Archive MIME type since a Web Archive
is displaying a markup document by nature.

* UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::isDisplayingMarkupDocument):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix trivial test-webkitpy regression introduced by http://trac.webkit.org/changeset...
glenn@skynav.com [Wed, 10 Apr 2013 05:21:09 +0000 (05:21 +0000)]
Fix trivial test-webkitpy regression introduced by trac.webkit.org/changeset/148075.

Unreviewed.

* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(RunTest.test_build_check):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[JSC] Script run from an isolated world should bypass a page's CSP
ggaren@apple.com [Wed, 10 Apr 2013 05:12:54 +0000 (05:12 +0000)]
[JSC] Script run from an isolated world should bypass a page's CSP
https://bugs.webkit.org/show_bug.cgi?id=100815

Reviewed by Oliver Hunt.

Source/WebCore:

* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::shouldBypassMainWorldContentSecurityPolicy):
* bindings/js/ScriptController.h: Test the current caller's DOM wrapper
world to decide whether CSP should be enforced.

Like most of CSP, this is a stupid policy because it doesn't address
second-order effects like <script> parsing or event handler execution,
which might be triggered indirectly by privileged scripts. These indirect
effects are still broken. Oh well.

LayoutTests:

Enabled these tests, now that they pass.

I removed all the nonsense in these tests about setting an isolated world's
CSP and origin manually, since we have no use for those features.

* http/tests/security/isolatedWorld/bypass-main-world-csp-expected.txt:
* http/tests/security/isolatedWorld/bypass-main-world-csp-for-xhr-expected.txt:
* http/tests/security/isolatedWorld/bypass-main-world-csp-for-xhr.html:
* http/tests/security/isolatedWorld/bypass-main-world-csp.html:
* platform/efl/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:
* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[webkitpy] Remove chromium ports.
glenn@skynav.com [Wed, 10 Apr 2013 04:59:35 +0000 (04:59 +0000)]
[webkitpy] Remove chromium ports.
https://bugs.webkit.org/show_bug.cgi?id=114326

Reviewed by Dirk Pranke.

As a side effect, also:

- remove chromium builders from webkitpy.layout_tests.port.builders
- remove chromium builders from rebaseline
- rewrite chromium dependent tests in rebaseline_unittest
- remove chromium platform from garden-o-matic
- select apple platform as default platform in garden-o-matic
- remove chromium port dependencies from a few other tests (run_webkit_tests_integrationtest, factory_unittest, style.checkers.test_expectations_unittest)

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
* Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
(BaselineOptimizerTest.test_move_baselines):
(BaselineOptimizerTest.test_efl):
(BaselineOptimizerTest.test_no_add_mac_future):
(BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
(BaselineOptimizerTest.test_common_directory_includes_root):
(BaselineOptimizerTest.test_complex_shadowing):
(BaselineOptimizerTest.test_virtual_ports_filtered):
* Scripts/webkitpy/layout_tests/port/builders.py:
* Scripts/webkitpy/layout_tests/port/chromium.py: Removed.
* Scripts/webkitpy/layout_tests/port/chromium_android.py: Removed.
* Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py: Removed.
* Scripts/webkitpy/layout_tests/port/chromium_linux.py: Removed.
* Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: Removed.
* Scripts/webkitpy/layout_tests/port/chromium_mac.py: Removed.
* Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: Removed.
* Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py: Removed.
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Removed.
* Scripts/webkitpy/layout_tests/port/chromium_win.py: Removed.
* Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: Removed.
* Scripts/webkitpy/layout_tests/port/factory.py:
(platform_options):
(PortFactory):
* Scripts/webkitpy/layout_tests/port/factory_unittest.py:
(FactoryTest.test_qt):
(FactoryTest.test_get_from_builder_name):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(RunTest.test_build_check):
* Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
(TestExpectationsTestCase.test_determine_port_from_expectations_path):
* Scripts/webkitpy/tool/commands/rebaseline.py:
(Rebaseline._builders_to_pull_from):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(_BaseTestCase):
(_BaseTestCase.setUp):
(TestRebaselineTest.setUp):
(TestRebaselineTest.test_baseline_directory):
(test_rebaseline_updates_expectations_file):
(test_rebaseline_does_not_include_overrides):
(test_rebaseline_test):
(test_rebaseline_test_and_print_scm_changes):
(test_rebaseline_and_copy_test):
(test_rebaseline_and_copy_test_no_existing_result):
(test_rebaseline_and_copy_test_with_lion_result):
(test_rebaseline_and_copy_no_overwrite_test):
(TestRebaselineExpectations.test_rebaseline_expectations):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove chromium exceptions from WebCore's gitattributes
benjamin@webkit.org [Wed, 10 Apr 2013 01:59:52 +0000 (01:59 +0000)]
Remove chromium exceptions from WebCore's gitattributes
https://bugs.webkit.org/show_bug.cgi?id=114327

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-09
Reviewed by Darin Adler.

* .gitattributes:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd liveness tests to JSC API entry points
oliver@apple.com [Wed, 10 Apr 2013 01:23:53 +0000 (01:23 +0000)]
Add liveness tests to JSC API entry points
https://bugs.webkit.org/show_bug.cgi?id=114318

Reviewed by Geoffrey Garen.

Add simple checks for the existence of a method table on any
JSCells passed across the API.  This in turn forces a structure
validity test.

* API/APICast.h:
(toJS):
(toJSForGC):
(unsafeToJS):
* API/JSObjectRef.cpp:
(JSObjectGetPrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate Document's event listener type bitfield when adopting a Node
adamk@chromium.org [Wed, 10 Apr 2013 01:11:50 +0000 (01:11 +0000)]
Update Document's event listener type bitfield when adopting a Node
https://bugs.webkit.org/show_bug.cgi?id=114322

Reviewed by Darin Adler.

Source/WebCore:

Without this, moving a Node between documents can silently deactivate
an event listener, if it's one of the types that whose creation is
optimized away by Document::hasListenerType.

An alternate approach would be to simply copy the old document's
bitfield over. It's a tradeoff between making adoption fast and making
the operation of any operation depending on these event types fast.
The latter seems like the right optimization given that adoption
doesn't happen very often.

Test: fast/events/event-listener-moving-documents.html

* dom/Node.cpp:
(WebCore::Node::didMoveToNewDocument): For each event listener type on the adopted node, update the new document's list of listener types.

LayoutTests:

* fast/events/event-listener-moving-documents-expected.txt: Added.
* fast/events/event-listener-moving-documents.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd logging channel for animations
dino@apple.com [Wed, 10 Apr 2013 00:57:52 +0000 (00:57 +0000)]
Add logging channel for animations
https://bugs.webkit.org/show_bug.cgi?id=114325

Reviewed by Simon Fraser.

* platform/Logging.cpp: Add LogAnimations.
(WebCore::getChannelFromName): Return LogAnimations for "Animations".
* platform/Logging.h: Add LogAnimations.
* platform/mac/LoggingMac.mm:
(WebCore::initializeLoggingChannelsIfNecessary): Copy preference.
* platform/win/LoggingWin.cpp:
(WebCore::initializeLoggingChannelsIfNecessary): Copy preference.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS3] Parsing the property, text-justify.
dw.im@samsung.com [Wed, 10 Apr 2013 00:32:39 +0000 (00:32 +0000)]
[CSS3] Parsing the property, text-justify.
https://bugs.webkit.org/show_bug.cgi?id=100058

Reviewed by Andreas Kling.

This patch implements the parsing side of the "text-justify" property specified
in CSS3 working draft, with "-webkit-" prefix, under ENABLE_CSS3_TEXT flag.
Specification link : http://www.w3.org/TR/css3-text/#text-justify

Source/WebCore:

Tests: fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify-inherited.html
       fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore):
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator TextJustify):
* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
* css/CSSPropertyNames.in:
* css/CSSValueKeywords.in:
* css/StyleBuilder.cpp:
(WebCore::StyleBuilder::StyleBuilder):
* css/StylePropertySet.cpp:
(WebCore):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
* rendering/style/RenderStyle.h:
* rendering/style/RenderStyleConstants.h:
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
* rendering/style/StyleRareInheritedData.h:
(StyleRareInheritedData):

LayoutTests:

* fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify-expected.txt: Added.
* fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify-inherited-expected.txt: Added.
* fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify-inherited.html: Added.
* fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify.html: Added.
* fast/css3-text/css3-text-justify/getComputedStyle/script-tests/getComputedStyle-text-justify-inherited.js: Added.
(testComputedStyle):
(ownValueTest):
(inheritanceTest):
* fast/css3-text/css3-text-justify/getComputedStyle/script-tests/getComputedStyle-text-justify.js: Added.
(testElementStyle):
(testComputedStyle):
(valueSettingTest):
(invalidValueSettingTest):
* platform/mac/TestExpectations: ditto
* platform/qt-4.8/TestExpectations: ditto
* platform/qt-mac/TestExpectations: ditto
* platform/qt/TestExpectations: ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK][AC] Adding contentsLayer for image and video
joone.hur@intel.com [Wed, 10 Apr 2013 00:17:04 +0000 (00:17 +0000)]
[GTK][AC] Adding contentsLayer for image and video
https://bugs.webkit.org/show_bug.cgi?id=113912

Reviewed by Gustavo Noronha Silva.

contentsLayer is a ClutterActor, which is added to the main layer
as a child when GraphicsLayer needs to render an image or video.

No new tests, already covered by existing AC tests.

* platform/graphics/clutter/GraphicsLayerActor.cpp:
(graphicsLayerActorUpdateTexture):
* platform/graphics/clutter/GraphicsLayerClutter.cpp:
(WebCore::GraphicsLayerClutter::GraphicsLayerClutter):
(WebCore::GraphicsLayerClutter::~GraphicsLayerClutter):
(WebCore):
(WebCore::GraphicsLayerClutter::setContentsToImage): Pass a Cairo surface to GraphicsLayer.
(WebCore::GraphicsLayerClutter::setContentsNeedsDisplay):
(WebCore::GraphicsLayerClutter::setContentsRect):
(WebCore::GraphicsLayerClutter::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerClutter::setupContentsLayer):
(WebCore::GraphicsLayerClutter::updateContentsImage): Set the Cairo surface for contentsLayer
to upload it as a texture.
(WebCore::GraphicsLayerClutter::updateContentsNeedsDisplay):
(WebCore::GraphicsLayerClutter::updateContentsRect):
(WebCore::GraphicsLayerClutter::updateSublayerList):
* platform/graphics/clutter/GraphicsLayerClutter.h:
(WebCore::GraphicsLayerClutter::hasContentsLayer):
(GraphicsLayerClutter):
(WebCore::GraphicsLayerClutter::contentsLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago REGRESSION: Blob URLs broken with NetworkProcess
ap@apple.com [Wed, 10 Apr 2013 00:04:55 +0000 (00:04 +0000)]
    REGRESSION: Blob URLs broken with NetworkProcess
        https://bugs.webkit.org/show_bug.cgi?id=114320

        Reviewed by Brady Eidson.

        Update BlobResourceHandle to use modern resource client calls.

        * platform/network/BlobResourceHandle.cpp:
        (WebCore::BlobResourceHandle::readSync): Don't call notifyReceiveData if there is
        no data (it's especially egregious when length is -1, signaling an error).
        (WebCore::BlobResourceHandle::notifyResponseOnSuccess): Use didReceiveResponseAsync
        when a client wants async callbacks. This is not very clean, as we don't wait
        for response, but should be workable for blobs.
        (WebCore::BlobResourceHandle::notifyResponseOnError): Ditto.
        (WebCore::BlobResourceHandle::notifyReceiveData): Use didReceiveBuffer (clients
        that only implement didReceiveData will have it automatically unwrapped).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRollout last patch as it destroyed everything
oliver@apple.com [Wed, 10 Apr 2013 00:03:30 +0000 (00:03 +0000)]
Rollout last patch as it destroyed everything

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agor148048 revealed that compositing/plugins/invalidate_rect.html was
simon.fraser@apple.com [Wed, 10 Apr 2013 00:00:59 +0000 (00:00 +0000)]
r148048 revealed that compositing/plugins/invalidate_rect.html was
only succeeded through chance, and cannot work as designed because
plugin painting is async on some platforms. Mark it as flakey.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r123837): Full screen transition is broken at apple.com
jer.noble@apple.com [Tue, 9 Apr 2013 23:57:39 +0000 (23:57 +0000)]
REGRESSION (r123837): Full screen transition is broken at apple.com
https://bugs.webkit.org/show_bug.cgi?id=95650

Reviewed by Simon Fraser.

Cancel any outstanding animations on <video> elements as they enter full screen, so as to
not confuse the WebKit/WebKit2 full screen window animation about the starting and destination
screen rects.

* css/fullscreen.css:
(video:-webkit-full-screen, audio:-webkit-full-screen):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohang in mediaSelectionGroupForMediaCharacteristic
jer.noble@apple.com [Tue, 9 Apr 2013 23:52:23 +0000 (23:52 +0000)]
hang in mediaSelectionGroupForMediaCharacteristic
https://bugs.webkit.org/show_bug.cgi?id=114054

Reviewed by Eric Carlson.

No new tests; Fixes sporadic hangs in media/ tests.

-[AVURLAsset mediaSelectionGroupForMediaCharacteristic:] can deadlock in certain situations: When AVURLAsset
posts a synchronous AVAssetResourceLoader notification to the main thread, calling -mediaSelectionGroupForMediaCharacteristic:
on the main thread requires IO to occur if the media characteristics are not yet loaded. Instead of blocking,
bail out early if the media characteristics are not yet known.

Add a new method, safeMediaSelectionGroupForLegibleMedia(), which first checks selection group availability
before calling mediaSelectionGroupForMediaCharacteristic:.

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
(MediaPlayerPrivateAVFoundationObjC):
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::safeMediaSelectionGroupForLegibleMedia): Added.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): Use new safe method.
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::processTextTracks): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setCurrentTrack): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAX: Bounding paths should be made available through accessibility
cfleizach@apple.com [Tue, 9 Apr 2013 23:29:25 +0000 (23:29 +0000)]
AX: Bounding paths should be made available through accessibility
https://bugs.webkit.org/show_bug.cgi?id=113817

Unreviewed build fix for iOS.

* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper _accessibilityPath]):
* accessibility/mac/WebAccessibilityObjectWrapperBase.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd liveness tests to JSC API entry points
oliver@apple.com [Tue, 9 Apr 2013 23:28:59 +0000 (23:28 +0000)]
Add liveness tests to JSC API entry points
https://bugs.webkit.org/show_bug.cgi?id=114318

Reviewed by Filip Pizlo.

Add simple checks for the existence of a method table on any
JSCells passed across the API.  This in turn forces a structure
validity test.

* API/APICast.h:
(toJS):
(toJSForGC):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed correctness fix: use lroundf instead of lround for a float to int conversion.
eric.carlson@apple.com [Tue, 9 Apr 2013 23:22:42 +0000 (23:22 +0000)]
Unreviewed correctness fix: use lroundf instead of lround for a float to int conversion.

* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateTimerFired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChange requisite hardware checks for enabling antialiasing.
roger_fong@apple.com [Tue, 9 Apr 2013 23:04:47 +0000 (23:04 +0000)]
Change requisite hardware checks for enabling antialiasing.
https://bugs.webkit.org/show_bug.cgi?id=114101
<rdar://problem/12342776>.

m_maySupportMultisampling should be true by default for all platforms/hardware now except older versions of AMD.

Reviewed by Dean Jackson.

* platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
(WebCore::Extensions3DOpenGLCommon::Extensions3DOpenGLCommon):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r148010.
rniwa@webkit.org [Tue, 9 Apr 2013 22:55:47 +0000 (22:55 +0000)]
Unreviewed, rolling out r148010.
http://trac.webkit.org/changeset/148010
https://bugs.webkit.org/show_bug.cgi?id=114310

Causes problems with focus rings (Requested by anttik on
#webkit).

Source/WebCore:

* css/StyleBuilder.cpp:
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyComputeLength::createHandler):
(WebCore::StyleBuilder::StyleBuilder):

LayoutTests:

* fast/borders/border-width-less-then-a-unit-of-pt-expected.html: Removed.
* fast/borders/border-width-less-then-a-unit-of-pt.html: Removed.
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
* tables/mozilla_expected_failures/bugs/bug89315-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, another fix for the Windows build after r148050.
eric.carlson@apple.com [Tue, 9 Apr 2013 22:52:04 +0000 (22:52 +0000)]
Unreviewed, another fix for the Windows build after r148050.

* html/track/TextTrackCueGeneric.cpp:
(WebCore::TextTrackCueGeneric::setFontSize): Use lround().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline tests affected by r148049 or r148048.
simon.fraser@apple.com [Tue, 9 Apr 2013 22:37:58 +0000 (22:37 +0000)]
Rebaseline tests affected by r148049 or r148048.

* compositing/layer-creation/rotate3d-overlap-expected.txt:
* compositing/repaint/resize-repaint-expected.txt:
* compositing/repaint/resize-repaint.html: Allow the test to run
outside WTR/DRT.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Exclusions] Properly position multiple stacked floats with non rectangular shape...
commit-queue@webkit.org [Tue, 9 Apr 2013 22:31:55 +0000 (22:31 +0000)]
[CSS Exclusions] Properly position multiple stacked floats with non rectangular shape outside
https://bugs.webkit.org/show_bug.cgi?id=110372

Patch by Bem Jones-Bey <bjonesbe@adobe.com> on 2013-04-09
Reviewed by Dean Jackson.

Source/WebCore:

Stacked floats get positioned based on the bounding box of the shape,
not on the shape contours itself. This patch causes that to happen.

Test: fast/exclusions/shape-outside-floats/shape-outside-floats-stacked.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeLogicalLocationForFloat): Use the
    "BoundingBoxOffset" mode so that we compute offsets based on the shape
    bounding boxes of previous floats, not the shape contour.
(WebCore::RenderBlock::logicalLeftOffsetForLine): Check the
    ShapeOutsideFloatOffsetMode to determine if the offset should be
    adjusted for the shape contour or not.
(WebCore::RenderBlock::logicalRightOffsetForLine): Ditto.
* rendering/RenderBlock.h:
(WebCore::RenderBlock::logicalRightOffsetForLine): Add parameter for offset mode.
(WebCore::RenderBlock::logicalLeftOffsetForLine): Ditto.
(RenderBlock):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded): If the
    new float is being added on top of a previous float on the same line,
    undo the offset for the previous float's shape contour so that we
    position the new float based on the bounding box.

LayoutTests:

Tests demonstrating stacked floats properly working with shape-outside.

* fast/exclusions/shape-outside-floats/shape-outside-floats-stacked-expected.html: Added.
* fast/exclusions/shape-outside-floats/shape-outside-floats-stacked.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonewcommitbot (WKR) requires a subversion checkout
rniwa@webkit.org [Tue, 9 Apr 2013 22:02:17 +0000 (22:02 +0000)]
newcommitbot (WKR) requires a subversion checkout
https://bugs.webkit.org/show_bug.cgi?id=114309

Reviewed by Benjamin Poulain.

Directly talk to the subversion server instead of relying on a local checkout.
This allows us to run WKR off of a git clone.

* Scripts/webkitpy/tool/commands/newcommitbot.py:
(NewCommitBot.next_work_item):
(NewCommitBot.process_work_item):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r147454): Youtube annotation links to new window broken
andersca@apple.com [Tue, 9 Apr 2013 21:35:39 +0000 (21:35 +0000)]
REGRESSION (r147454): Youtube annotation links to new window broken
https://bugs.webkit.org/show_bug.cgi?id=114242
<rdar://problem/13609940>

Reviewed by Beth Dakin.

Set the current user gesture to "DefinitelyProcessingNewUserGesture" if popups are allowed.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::performFrameLoadURLRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148054 268f45cc-cd09-0410-ab3c-d52691b4dbfc