WebKit-https.git
7 years ago[Perf tests] Reduce the number of loops in dom-attributes.html
haraken@chromium.org [Wed, 7 Mar 2012 04:56:37 +0000 (04:56 +0000)]
[Perf tests] Reduce the number of loops in dom-attributes.html
https://bugs.webkit.org/show_bug.cgi?id=80077

Reviewed by Ryosuke Niwa.

dom-attributes.html takes 100~ seconds in the perf bots. This patch reduces
the time by reducing the number of loops.

This is just a temporary fix. After more detailed investigation, I will reduce
the number of tests in dom-attributes.html, and revert back the number of loops
to guarantee the reliability of the perf test results.

* Bindings/dom-attributes.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDFG BasicBlock should group the Phi nodes together and separate them
yuqiang.xian@intel.com [Wed, 7 Mar 2012 04:56:05 +0000 (04:56 +0000)]
DFG BasicBlock should group the Phi nodes together and separate them
from the other nodes
https://bugs.webkit.org/show_bug.cgi?id=80361

Reviewed by Filip Pizlo.

This would make it more efficient to remove the redundant Phi nodes or
insert new Phi nodes for SSA, besides providing a cleaner BasicBlock structure.
This is performance neutral on SunSpider, V8 and Kraken.

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::clobberStructures):
(JSC::DFG::AbstractState::dump):
* dfg/DFGBasicBlock.h:
(JSC::DFG::BasicBlock::BasicBlock):
(BasicBlock):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::addToGraph):
(JSC::DFG::ByteCodeParser::insertPhiNode):
* dfg/DFGCFAPhase.cpp:
(JSC::DFG::CFAPhase::performBlockCFA):
* dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::pureCSE):
(JSC::DFG::CSEPhase::impureCSE):
(JSC::DFG::CSEPhase::globalVarLoadElimination):
(JSC::DFG::CSEPhase::getByValLoadElimination):
(JSC::DFG::CSEPhase::checkFunctionElimination):
(JSC::DFG::CSEPhase::checkStructureLoadElimination):
(JSC::DFG::CSEPhase::getByOffsetLoadElimination):
(JSC::DFG::CSEPhase::getPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::getIndexedPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::getScopeChainLoadElimination):
(JSC::DFG::CSEPhase::performBlockCSE):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agorefactor method names in RenderFlexibleBox to make them more consistent
tony@chromium.org [Wed, 7 Mar 2012 04:39:53 +0000 (04:39 +0000)]
refactor method names in RenderFlexibleBox to make them more consistent
https://bugs.webkit.org/show_bug.cgi?id=80446

Reviewed by Ojan Vafai.

No new tests, just renaming internal methods.

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::flowAwareBorderAfter): New, used by layoutAndPlaceChildren
(WebCore::RenderFlexibleBox::flowAwarePaddingAfter): New, used by layoutAndPlaceChildren
(WebCore::RenderFlexibleBox::marginBoxAscentForChild): Add ForChild for consistency.
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren): We were adding the before padding+border twice (it's in the offset and
crossAxisBorderAndPaddingExtent() and subtracting it once.  Instead, just add the after padding+border.
(WebCore::RenderFlexibleBox::alignChildren):
* rendering/RenderFlexibleBox.h:
(RenderFlexibleBox): Reorder methods to match the .cpp file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r109969.
haraken@chromium.org [Wed, 7 Mar 2012 03:53:17 +0000 (03:53 +0000)]
Unreviewed, rolling out r109969.
http://trac.webkit.org/changeset/109969
https://bugs.webkit.org/show_bug.cgi?id=80376

layout tests crash

* bindings/v8/V8HiddenPropertyName.cpp:
(WebCore):
(WebCore::V8HiddenPropertyName::hiddenReferenceName):
* bindings/v8/V8HiddenPropertyName.h:
(WebCore):
(V8HiddenPropertyName):
* bindings/v8/custom/V8DOMStringMapCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8DOMTokenListCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8NamedNodeMapCustom.cpp:
(WebCore::toV8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r109999.
haraken@chromium.org [Wed, 7 Mar 2012 03:52:00 +0000 (03:52 +0000)]
Unreviewed, rolling out r109999.
http://trac.webkit.org/changeset/109999

layout tests crash

* bindings/v8/custom/V8DOMStringMapCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8DOMTokenListCustom.cpp:
(WebCore::toV8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix a compilation warning encountered during the GTK+ build.
mrobinson@webkit.org [Wed, 7 Mar 2012 03:50:04 +0000 (03:50 +0000)]
Fix a compilation warning encountered during the GTK+ build.

Reviewed by Gustavo Noronha Silva.

* tests/testcopyandpaste.c:
(test_copy_and_paste): Cast the WebKitWebView to a GtkWidget.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, update mac text baselines after r109851
enne@google.com [Wed, 7 Mar 2012 03:26:02 +0000 (03:26 +0000)]
Unreviewed, update mac text baselines after r109851

* compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
* compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
* compositing/geometry/limit-layer-bounds-positioned-expected.txt:
* compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt:
* compositing/geometry/limit-layer-bounds-transformed-expected.txt:
* compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove the no-longer-needed 'CPU' and 'GPU' modifiers.
dpranke@chromium.org [Wed, 7 Mar 2012 02:47:11 +0000 (02:47 +0000)]
Remove the no-longer-needed 'CPU' and 'GPU' modifiers.

Unreviewed, expectations change.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, fix crashes.
haraken@chromium.org [Wed, 7 Mar 2012 02:45:30 +0000 (02:45 +0000)]
Unreviewed, fix crashes.

* bindings/v8/custom/V8DOMStringMapCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8DOMTokenListCustom.cpp:
(WebCore::toV8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRe-sort the platform/chromium/virtual/gpu expectations next to the original expectations.
dpranke@chromium.org [Wed, 7 Mar 2012 02:40:49 +0000 (02:40 +0000)]
Re-sort the platform/chromium/virtual/gpu expectations next to the original expectations.

Unreviewed, expectations change.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] FrameLoader signals: gtk-doc fixes
mrobinson@webkit.org [Wed, 7 Mar 2012 02:40:39 +0000 (02:40 +0000)]
[GTK] FrameLoader signals: gtk-doc fixes
https://bugs.webkit.org/show_bug.cgi?id=79495

Patch by Philippe Normand <pnormand@igalia.com> on 2012-03-06
Reviewed by Martin Robinson.

* webkit/webkitwebframe.cpp:
(webkit_web_frame_class_init):
* webkit/webkitwebresource.cpp:
(webkit_web_resource_class_init):
* webkit/webkitwebview.cpp:
(webkit_web_view_class_init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agorebaseline_chromium_webkit_tests is obsolete and should be removed
dpranke@chromium.org [Wed, 7 Mar 2012 02:22:59 +0000 (02:22 +0000)]
rebaseline_chromium_webkit_tests is obsolete and should be removed
https://bugs.webkit.org/show_bug.cgi?id=80347

Reviewed by Tony Chang.

* Scripts/rebaseline-chromium-webkit-tests: Removed.
* Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py: Removed.
* Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agotest_start_cmd (webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer...
dpranke@chromium.org [Wed, 7 Mar 2012 02:20:18 +0000 (02:20 +0000)]
test_start_cmd (webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer) is broken
https://bugs.webkit.org/show_bug.cgi?id=80468

Unreviewed, build fix.

Fixing a bug revealed by r80443 when we fixed filesystem.copyfile().

* Scripts/webkitpy/layout_tests/servers/http_server.py:
(Lighttpd._prepare_config):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoremove chromium_gpu ports
dpranke@chromium.org [Wed, 7 Mar 2012 02:17:44 +0000 (02:17 +0000)]
remove chromium_gpu ports
https://bugs.webkit.org/show_bug.cgi?id=80345

Reviewed by Ojan Vafai.

This change leaves in the 'graphics_type' distinction in the
test_expectations; removing that will require more updates and a
pass over test_expectations.txt, so I'm separating that out.

* Scripts/webkitpy/layout_tests/port/builders.py:
* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort):
* Scripts/webkitpy/layout_tests/port/chromium_gpu.py: Removed.
* Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py: Removed.
* Scripts/webkitpy/layout_tests/port/factory.py:
(PortFactory):
(PortFactory.get):
* Scripts/webkitpy/layout_tests/port/factory_unittest.py:
(FactoryTest.test_qt):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaseline.test_rebaseline_expectations):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Fix threaded compositing issues in WebGLLayerChromium (except for printing)
jamesr@google.com [Wed, 7 Mar 2012 02:13:00 +0000 (02:13 +0000)]
[chromium] Fix threaded compositing issues in WebGLLayerChromium (except for printing)
https://bugs.webkit.org/show_bug.cgi?id=80459

Reviewed by Kenneth Russell.

This fixes a few wrong-thread issues in WebGLLayerChromium for threaded compositing.  The key requirements that
threaded compositing imposes on LayerChromium subclasses are that the compositor's context can only be used from
the compositor thread, meaning inside of updateCompositorResources() and pushPropertiesTo(), and that
non-compositor contexts can only be used from the main thread. This means specifically that we can't use the
DrawingBuffer's context in either of these two functions.

Summary of changes:
*) Move the publishToPlatformLayer() call and related logic inside of paintContentsIfDirty(), which is called
on the main thread.
*) Move lost context tracking outside of drawsContent(), since that function is called from both threads, to a
separate bool that is updated after each WebGL composite and setDrawingBuffer call.

Printing still doesn't work in threaded mode with this patch, I'll address that separately. Printing and lost
context recovery still work as they did in the single-threaded path.

* platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::WebGLLayerChromium):
(WebCore::WebGLLayerChromium::drawsContent):
(WebCore::WebGLLayerChromium::paintContentsIfDirty):
(WebCore::WebGLLayerChromium::updateCompositorResources):
(WebCore::WebGLLayerChromium::setDrawingBuffer):
* platform/graphics/chromium/WebGLLayerChromium.h:
(WebGLLayerChromium):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCracks between tiles when zoomed in
andersca@apple.com [Wed, 7 Mar 2012 01:58:21 +0000 (01:58 +0000)]
Cracks between tiles when zoomed in
https://bugs.webkit.org/show_bug.cgi?id=80460
<rdar://problem/10996688>

Use enclosingIntRect instead of enclosedIntRect when converting from FloatRect to IntRect.

* platform/graphics/mac/WebLayer.mm:
(drawLayerContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTile cache layers should always be clipped to the view's bounds
andersca@apple.com [Wed, 7 Mar 2012 01:25:46 +0000 (01:25 +0000)]
Tile cache layers should always be clipped to the view's bounds
https://bugs.webkit.org/show_bug.cgi?id=80456
<rdar://problem/10996174>

Reviewed by Simon Fraser.

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::shouldClipCompositedBounds):
Factor this code out into a separate function for better clarity. Always return true if we have a tile cache layer.

(WebCore::RenderLayerBacking::updateCompositedBounds):
Call shouldClipCompositedBounds directly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Null-check m_layerRenderer in CCLayerTreeHostImpl::finishAllRendering()
jamesr@google.com [Wed, 7 Mar 2012 01:16:04 +0000 (01:16 +0000)]
[chromium] Null-check m_layerRenderer in CCLayerTreeHostImpl::finishAllRendering()
https://bugs.webkit.org/show_bug.cgi?id=80445

Reviewed by Adrienne Walker.

Source/WebCore:

Null-check CCLayerTreeHostImpl::m_layerRenderer since it won't be set if context initialiation failed for any
reason.

Covered by new unit test in CCLayerTreeHostImplTest.

* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::finishAllRendering):

Source/WebKit/chromium:

* tests/CCLayerTreeHostImplTest.cpp:
(FakeWebGraphicsContext3DMakeCurrentFails):
(WebKit::FakeWebGraphicsContext3DMakeCurrentFails::makeContextCurrent):
(WebKit):
(WebKit::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCan't select a line of RTL text on Facebook
rniwa@webkit.org [Wed, 7 Mar 2012 01:13:54 +0000 (01:13 +0000)]
Can't select a line of RTL text on Facebook
https://bugs.webkit.org/show_bug.cgi?id=59435

Reviewed by Eric Seidel.

Source/WebCore:

Deploy prevLeafChildIgnoringLineBreak and nextLeafChildIgnoringLineBreak
in RenderedPosition::leftBoundaryOfBidiRun and RenderedPosition::rightBoundaryOfBidiRun.

Without this patch, WebKit extends selection from right to left when the user selects
<span dir="rtl">ABC<br></span> from left to right by a mouse drag.

Test: editing/selection/select-bidi-run.html

* editing/RenderedPosition.cpp:
(WebCore::RenderedPosition::leftBoundaryOfBidiRun):
(WebCore::RenderedPosition::rightBoundaryOfBidiRun):

LayoutTests:

Added a regression test case.

* editing/selection/select-bidi-run-expected.txt:
* editing/selection/select-bidi-run.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoundefined reference to JSC::IdentifierTable::~IdentifierTable() on EFL port
kubo@profusion.mobi [Wed, 7 Mar 2012 01:11:38 +0000 (01:11 +0000)]
undefined reference to JSC::IdentifierTable::~IdentifierTable() on EFL port
https://bugs.webkit.org/show_bug.cgi?id=80282

Reviewed by Antonio Gomes.

.:

Remove transitive library dependencies; they are especially
dangerous when one ends up linking against WTF, JSC and then WTF
again, since some symbols will not be defined.

Passing --no-copy-dt-needed-entries and --as-needed to the linker
(which some recent Linux distros do by default) makes the issue
even more evident.

* CMakeLists.txt: Set CMAKE_LINK_INTERFACE_LIBRARIES to an empty
list to prevent implicit transitive library dependencies from
being created by default.

Source/WebCore:

No new tests, this is a buildsystem change.

Remove transitive library dependencies; they are especially
dangerous when one ends up linking against WTF, JSC and then WTF
again, since some symbols will not be defined.

Passing --no-copy-dt-needed-entries and --as-needed to the linker
(which some recent Linux distros do by default) makes the issue
even more evident.

* CMakeLists.txt: Explicitly link to WTF as WebCore uses symbols
from it.
* PlatformEfl.cmake: Explicitly link against libjpeg and libpng.

Tools:

Remove transitive library dependencies; they are especially
dangerous when one ends up linking against WTF, JSC and then WTF
again, since some symbols will not be defined.

Passing --no-copy-dt-needed-entries and --as-needed to the linker
(which some recent Linux distros do by default) makes the issue
even more evident.

* DumpRenderTree/efl/CMakeLists.txt: Do not link directly to WTF,
as the other libraries have the needed symbols. Explicitly link
against fontconfig.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] REGRESSION(109469): WebGL printing busted
jamesr@google.com [Wed, 7 Mar 2012 01:08:12 +0000 (01:08 +0000)]
[chromium] REGRESSION(109469): WebGL printing busted
https://bugs.webkit.org/show_bug.cgi?id=80450

Reviewed by Kenneth Russell.

Avoid marking layers as needing display in setContentsTo...() since this breaks WebGL's damage tracking and is
unnecessary.

Tested WebGL printing manually.

* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setContentsToCanvas):
(WebCore::GraphicsLayerChromium::setContentsToMedia):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoOverlap map for compositing should ignore empty layers
enne@google.com [Wed, 7 Mar 2012 01:05:52 +0000 (01:05 +0000)]
Overlap map for compositing should ignore empty layers
https://bugs.webkit.org/show_bug.cgi?id=63499

Reviewed by Simon Fraser.

Source/WebCore:

Test: compositing/layer-creation/overlap-empty-layer.html

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::addToOverlapMap):
(WebCore::RenderLayerCompositor::computeCompositingRequirements):

LayoutTests:

* compositing/layer-creation/overlap-empty-layer-expected.txt: Added.
* compositing/layer-creation/overlap-empty-layer.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Rebaseline of input-appearance-numberandspeech.html for r109876.
tkent@chromium.org [Wed, 7 Mar 2012 01:02:47 +0000 (01:02 +0000)]
[Chromium] Rebaseline of input-appearance-numberandspeech.html for r109876.
https://bugs.webkit.org/show_bug.cgi?id=78326

* platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.png:
* platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.txt:
* platform/chromium-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.png:
* platform/chromium-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.png:
* platform/chromium-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.txt:
* platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.png:
* platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] More test_expectations updates after the svg <use> change.
senorblanco@chromium.org [Wed, 7 Mar 2012 00:59:32 +0000 (00:59 +0000)]
[chromium] More test_expectations updates after the svg <use> change.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofilter-build-webkit needs more filters
dino@apple.com [Wed, 7 Mar 2012 00:33:12 +0000 (00:33 +0000)]
filter-build-webkit needs more filters
https://bugs.webkit.org/show_bug.cgi?id=80440

Reviewed by Joseph Pecoraro.

Added as many missing filters as I could find for Apple
builds. Plus a few minor style updates.

* Scripts/filter-build-webkit:
(printLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Increase the accelerated canvas min size to 256 * 256
vangelis@chromium.org [Wed, 7 Mar 2012 00:16:41 +0000 (00:16 +0000)]
[chromium] Increase the accelerated canvas min size to 256 * 256
https://bugs.webkit.org/show_bug.cgi?id=80451

Reviewed by Stephen White.

Test: Manually

* page/Settings.cpp:
(WebCore::Settings::Settings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed gardening.
senorblanco@chromium.org [Wed, 7 Mar 2012 00:12:41 +0000 (00:12 +0000)]
[chromium] Unreviewed gardening.

New text results for css3 filters tests.

* platform/chromium-mac/css3/filters: Added.
* platform/chromium-mac/css3/filters/composited-during-animation-layertree-expected.txt: Added.
* platform/chromium-win/css3/filters/composited-during-animation-layertree-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8][Performance] Optimize V8 bindings for HTMLElement.classList,
haraken@chromium.org [Tue, 6 Mar 2012 23:54:46 +0000 (23:54 +0000)]
[V8][Performance] Optimize V8 bindings for HTMLElement.classList,
Element.dataset and Node.attributes
https://bugs.webkit.org/show_bug.cgi?id=80376

Reviewed by Adam Barth.

This patch improves the performance of HTMLElement.classList, Element.dataset
and Node.attributes by 6.4 times, 7.1 times and 10.9 times, respectively.

Previously, a 'hiddenReferenceName' string was allocated on v8::Handle and
created every time the DOM attribute is accessed, in spite of the fact that
the 'hiddenReferenceName' string is static.

This patch moves the 'hiddenReferenceName' string to v8::Persistent and makes it static.
Also, this patch removes 'if (!elementValue.IsEmpty() && elementValue->IsObject())',
since if 'element' exists, it is guaranteed that 'elementValue' is not empty
and is an Object.

Performance tests: https://bugs.webkit.org/attachment.cgi?id=130283

AppleWebKit/JavaScriptCore:
div.classList : 382ms
div.classList.foo = 123 : 335ms
div.dataset : 403ms
div.dataset.foo = 123 : 5250ms
div.attributes : 183ms

Chromium/V8 (without this patch):
div.classList : 9140ms
div.classList.foo = 123 : 9086ms
div.dataset : 9930ms
div.dataset.foo = 123 : 49698ms
div.attributes : 13489ms

Chromium/V8 (with this patch):
div.classList : 1435ms
div.classList.foo = 123 : 1470ms
div.dataset : 1400ms
div.dataset.foo = 123 : 30396ms
div.attributes : 1242ms

No tests. No change in behavior.

* bindings/v8/custom/V8DOMStringMapCustom.cpp: Modified as described above.
(WebCore::toV8):
* bindings/v8/custom/V8DOMTokenListCustom.cpp: Ditto.
(WebCore::toV8):
* bindings/v8/custom/V8NamedNodeMapCustom.cpp: Ditto.
(WebCore::toV8):

* bindings/v8/V8HiddenPropertyName.cpp: Defined a hidden property name string statically
to optimize the macro.
(WebCore):
(WebCore::V8HiddenPropertyName::hiddenReferenceName):
* bindings/v8/V8HiddenPropertyName.h: Modified to switch two prefixes "WebCore::HiddenProperty::"
and "WebCore::HiddenReference::", depending on whether a given name represents a hidden property
or a hidden reference.
(WebCore):
(V8HiddenPropertyName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agogetComputedStyle returns incorrect values for the width and height of pseudo-elements
alexis.menard@openbossa.org [Tue, 6 Mar 2012 23:52:29 +0000 (23:52 +0000)]
getComputedStyle returns incorrect values for the width and height of pseudo-elements
https://bugs.webkit.org/show_bug.cgi?id=37835

Reviewed by Tony Chang.

Source/WebCore:

In case we are querying the computed style of an element with a pseudo-element we can't use
the renderer of the element as this one is not the one used to render the pseudo-element. We need
to use the one created to render the pseudo-element.

No new tests : Extend the existing getComputedStyle-with-pseudo-element.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

Extend existing test to cover the bug.

* fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt:
* fast/css/getComputedStyle/getComputedStyle-with-pseudo-element.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r109191): Shadow DOM tests stopped running on ports that do not have SHADO...
dglazkov@chromium.org [Tue, 6 Mar 2012 23:50:15 +0000 (23:50 +0000)]
REGRESSION(r109191): Shadow DOM tests stopped running on ports that do not have SHADOW_DOM flag enabled.
https://bugs.webkit.org/show_bug.cgi?id=80449

Reviewed by Ryosuke Niwa.

* fast/dom/shadow/resources/create-dom.js:
(createDOM): Fixed a typo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed gardening.
senorblanco@chromium.org [Tue, 6 Mar 2012 23:35:59 +0000 (23:35 +0000)]
[chromium] Unreviewed gardening.

* platform/chromium-mac-snowleopard/css3/filters/composited-during-transition-layertree-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/css/circle-in-mask-with-shadow-expected.png: Added.
* platform/chromium-win/css3/filters/composited-during-transition-layertree-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Make compositeAndReadback and damage tracking play nicely together
shawnsingh@chromium.org [Tue, 6 Mar 2012 23:09:37 +0000 (23:09 +0000)]
[chromium] Make compositeAndReadback and damage tracking play nicely together
https://bugs.webkit.org/show_bug.cgi?id=80199

Reviewed by James Robinson.

Requires system-level testing (pixels on front-buffer should be
observed for correct behavior) that cannot be done by layout tests
or unit tests, have to rely on manual testing.

* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::compositeAndReadback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake CSSStyleSelector::convertToLength() behave more like CSSPrimitiveValue::convertT...
macpherson@chromium.org [Tue, 6 Mar 2012 23:06:51 +0000 (23:06 +0000)]
Make CSSStyleSelector::convertToLength() behave more like CSSPrimitiveValue::convertToLength().
https://bugs.webkit.org/show_bug.cgi?id=80375

Reviewed by Eric Seidel.

No new tests / cleanup only.

This patch removes the bool* ok parameter from CSSStyleSelector's convertToLength,
and instead uses the recently added Length(Undefined) value to indicate failure.
This paves the way for a future patch that will call primitiveValue->convertToLength directly.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCopying old baselines throws an error if the new directory doesn't exist
ojan@chromium.org [Tue, 6 Mar 2012 22:52:33 +0000 (22:52 +0000)]
Copying old baselines throws an error if the new directory doesn't exist
https://bugs.webkit.org/show_bug.cgi?id=80443

Reviewed by Adam Barth.

Existing tests cover the new code with the fix to filesystem_mock.

* Scripts/webkitpy/common/system/filesystem_mock.py:
(MockFileSystem.copyfile):
Fix the mock to better match python's copyfile semantics.

* Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
(Rebaseliner._create_html_baseline_files):
* Scripts/webkitpy/tool/commands/rebaseline.py:
(RebaselineTest._copy_existing_baseline):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd state variable and ASSERTs to DocumentWriter to help track down
commit-queue@webkit.org [Tue, 6 Mar 2012 22:45:12 +0000 (22:45 +0000)]
Add state variable and ASSERTs to DocumentWriter to help track down
https://bugs.webkit.org/show_bug.cgi?id=80427 and prevent illegal usage
of DocumentWriter. This also makes endIfNotLoadingMainResource() private
as there is no external usage.

Patch by Raymes Khoury <raymes@chromium.org> on 2012-03-06
Reviewed by Adam Barth.

This only adds ASSERT/CRASH and does not change existing behaviour.

* loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::DocumentWriter):
(WebCore::DocumentWriter::begin):
(WebCore::DocumentWriter::addData):
(WebCore::DocumentWriter::endIfNotLoadingMainResource):
(WebCore::DocumentWriter::setDocumentWasLoadedAsPartOfNavigation):
* loader/DocumentWriter.h:
(DocumentWriter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSSRegions][CSSOM]Restrict parsing of named flow name
mihnea@adobe.com [Tue, 6 Mar 2012 22:41:28 +0000 (22:41 +0000)]
[CSSRegions][CSSOM]Restrict parsing of named flow name
https://bugs.webkit.org/show_bug.cgi?id=80359

Reviewed by Andreas Kling.

The function that does the parsing for flow thread name should restrict the
number of parsed properties to 1, otherwise it would allow parsing of
"-webkit-flow-into: flow; color: red;" constructions.

Source/WebCore:

Modified fast/regions/webkit-named-flow-invalid-name.html to include the above case.

* css/CSSParser.cpp:
(WebCore::validFlowName):
(WebCore::CSSParser::parseFlowThread):

LayoutTests:

* fast/regions/webkit-named-flow-invalid-name-expected.txt:
* fast/regions/webkit-named-flow-invalid-name.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Remove unused and unneeded WebPageClient::downloadRequested(NetworkRequest&)
commit-queue@webkit.org [Tue, 6 Mar 2012 22:16:32 +0000 (22:16 +0000)]
[BlackBerry] Remove unused and unneeded WebPageClient::downloadRequested(NetworkRequest&)
https://bugs.webkit.org/show_bug.cgi?id=80438

Patch by Lianghui Chen <liachen@rim.com> on 2012-03-06
Reviewed by Antonio Gomes.

* Api/WebPageClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Add OVERRIDEs to WebWorkerClientImpl.h
dgrogan@chromium.org [Tue, 6 Mar 2012 21:59:57 +0000 (21:59 +0000)]
[Chromium] Add OVERRIDEs to WebWorkerClientImpl.h
https://bugs.webkit.org/show_bug.cgi?id=80434

Reviewed by Tony Chang.

Tests: just that it compiles.

* src/WebWorkerClientImpl.h:
(WebWorkerClientImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMiniBrowser --window-size 480x800 www.nytimes.com doesn't paint bottom tiles.
commit-queue@webkit.org [Tue, 6 Mar 2012 21:43:11 +0000 (21:43 +0000)]
MiniBrowser --window-size 480x800 nytimes.com doesn't paint bottom tiles.
https://bugs.webkit.org/show_bug.cgi?id=80313

Patch by Hugo Parente Lima <hugo.lima@openbossa.org> on 2012-03-06
Reviewed by Kenneth Rohde Christiansen.

Fix the math to get the visible rectangle and add a method to get it.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::visibleContentsRect):
(QQuickWebViewFlickablePrivate::_q_commitScaleChange):
(QQuickWebViewPrivate::_q_commitPositionChange):
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGCActivityCallback timer should vary with the length of the previous GC
mhahnenberg@apple.com [Tue, 6 Mar 2012 21:32:24 +0000 (21:32 +0000)]
GCActivityCallback timer should vary with the length of the previous GC
https://bugs.webkit.org/show_bug.cgi?id=80344

Reviewed by Geoffrey Garen.

* heap/Heap.cpp: Gave Heap the ability to keep track of the length of its last
GC length so that the GC Activity Callback can use it.
(JSC::Heap::Heap):
(JSC::Heap::collect):
* heap/Heap.h:
(JSC::Heap::lastGCLength):
(Heap):
* runtime/GCActivityCallbackCF.cpp:
(JSC):
(JSC::DefaultGCActivityCallback::operator()): Use the length of the Heap's last
GC to determine the length of our timer trigger (currently set at 100x the duration
of the last GC).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate Chromium/SVG expectations after the <use> rewrite
schenney@chromium.org [Tue, 6 Mar 2012 21:32:03 +0000 (21:32 +0000)]
Update Chromium/SVG expectations after the <use> rewrite
https://bugs.webkit.org/show_bug.cgi?id=79568

Unreviewed Chromium test_expectations update.

As expected, some tests are failing due to missing or incorrect baselines.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed build fix for minimal build after r109939.
joepeck@webkit.org [Tue, 6 Mar 2012 21:11:45 +0000 (21:11 +0000)]
Unreviewed build fix for minimal build after r109939.

Guard access to page->inspectorController with ENABLE(INSPECTOR).

* page/FrameView.cpp:
(WebCore::FrameView::performPostLayoutTasks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEnable compositing when a CSS filter is animating
dino@apple.com [Tue, 6 Mar 2012 21:01:19 +0000 (21:01 +0000)]
Enable compositing when a CSS filter is animating
https://bugs.webkit.org/show_bug.cgi?id=79048

Reviewed by Simon Fraser.

Source/WebCore:

Now that some systems (e.g. OS X) have both hardware accelerated
CSS filters, and the ability to animate them via the hardware
compositor, all CSS filters should be composited when animating.

Tests: css3/filters/composited-during-animation-layertree.html
       css3/filters/composited-during-animation.html
       css3/filters/composited-during-transition-layertree.html

* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore):
(WebCore::supportsAcceleratedFilterAnimations):
    new method that returns true if the platform supports
    hardware animations of filters.
(WebCore::GraphicsLayerCA::addAnimation):
(WebCore::GraphicsLayerCA::createAnimationFromKeyframes):
    only create layer-animations if the platform supports it.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForAnimation):
    create a compositing layer if animating a filter on a
    supported platform.

LayoutTests:

* platform/mac/css3/filters/composited-during-animation-expected.txt: Added.
* platform/mac/css3/filters/composited-during-animation-layertree-expected.txt: Added.
* css3/filters/composited-during-animation-layertree.html: Added.
* css3/filters/composited-during-animation.html: Added.
* platform/mac/css3/filters/composited-during-transition-layertree-expected.txt: Added.
* css3/filters/composited-during-transition-layertree.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBlackBerry] Fix cast-align gcc warnings when compiling JSC
rwlbuis@webkit.org [Tue, 6 Mar 2012 20:50:12 +0000 (20:50 +0000)]
BlackBerry] Fix cast-align gcc warnings when compiling JSC
https://bugs.webkit.org/show_bug.cgi?id=80420

Reviewed by Gavin Barraclough.

Fix warnings given in Blackberry build.

* heap/CopiedBlock.h:
(JSC::CopiedBlock::CopiedBlock):
* wtf/RefCountedArray.h:
(WTF::RefCountedArray::Header::fromPayload):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate Chromium/SVG expectations after the <use> rewrite
schenney@chromium.org [Tue, 6 Mar 2012 20:30:35 +0000 (20:30 +0000)]
Update Chromium/SVG expectations after the <use> rewrite
https://bugs.webkit.org/show_bug.cgi?id=79568

Unreviewed Chromium expectation updates.

This covers the remaining text failures after r109097. There are no
image updates here (expect a missing one) because the flakiness board
indicated that no images were failing that were not already failing.
Of course, that may be incorrect but the best way to find out is to
try it.

* platform/chromium-linux-x86/svg/filters/filter-refresh-expected.txt:
* platform/chromium-linux-x86/svg/stroke: Added.
* platform/chromium-linux-x86/svg/stroke/zero-length-path-linecap-rendering-expected.txt: Added.
* platform/chromium-linux-x86/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-77-t-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/text-path-01-b-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/text-text-05-t-expected.txt: Added.
* platform/chromium-linux/svg/batik/text/smallFonts-expected.png: Added.
* platform/chromium-linux/svg/batik/text/textPosition-expected.txt:
* platform/chromium-linux/svg/batik/text/textPosition2-expected.txt:
* platform/chromium-linux/svg/carto.net/window-expected.txt: Removed.
* platform/chromium-linux/svg/filters/filter-refresh-expected.txt:
* platform/chromium-linux/svg/stroke/zero-length-path-linecap-rendering-expected.txt: Added.
* platform/chromium-linux/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt: Added.
* platform/chromium-mac-leopard/svg/batik/text/smallFonts-expected.png: Added.
* platform/chromium-mac-leopard/svg/filters/filter-refresh-expected.txt:
* platform/chromium-mac-leopard/svg/stroke: Added.
* platform/chromium-mac-leopard/svg/stroke/zero-length-path-linecap-rendering-expected.txt: Added.
* platform/chromium-mac-leopard/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/text-text-05-t-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/batik/paints/patternPreserveAspectRatioA-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/batik/text/longTextOnPath-expected.txt:
* platform/chromium-mac-snowleopard/svg/batik/text/smallFonts-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/batik/text/textOnPath2-expected.txt:
* platform/chromium-mac-snowleopard/svg/batik/text/textOnPath3-expected.txt:
* platform/chromium-mac-snowleopard/svg/batik/text/textProperties-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/batik/text/textStyles-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/filters/filter-refresh-expected.txt:
* platform/chromium-mac-snowleopard/svg/stroke/zero-length-path-linecap-rendering-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/text/text-text-05-t-expected.txt: Added.
* platform/chromium-win-vista/svg/filters/filter-refresh-expected.txt:
* platform/chromium-win-vista/svg/stroke: Added.
* platform/chromium-win-vista/svg/stroke/zero-length-path-linecap-rendering-expected.txt: Added.
* platform/chromium-win-vista/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt: Added.
* platform/chromium-win-xp/svg/filters/filter-refresh-expected.txt:
* platform/chromium-win-xp/svg/stroke: Added.
* platform/chromium-win-xp/svg/stroke/zero-length-path-linecap-rendering-expected.txt: Added.
* platform/chromium-win-xp/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt: Added.
* platform/chromium-win-xp/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Removed.
* platform/chromium-win/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-30-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/struct-image-02-b-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/struct-use-03-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/text-text-04-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/text-text-06-t-expected.txt:
* platform/chromium-win/svg/batik/filters/feTile-expected.txt:
* platform/chromium-win/svg/batik/filters/filterRegions-expected.txt:
* platform/chromium-win/svg/batik/masking/maskRegions-expected.txt:
* platform/chromium-win/svg/batik/paints/gradientLimit-expected.txt:
* platform/chromium-win/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
* platform/chromium-win/svg/batik/paints/patternRegionA-expected.txt:
* platform/chromium-win/svg/batik/paints/patternRegions-expected.txt:
* platform/chromium-win/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
* platform/chromium-win/svg/batik/text/longTextOnPath-expected.txt:
* platform/chromium-win/svg/batik/text/smallFonts-expected.png: Added.
* platform/chromium-win/svg/batik/text/smallFonts-expected.txt: Added.
* platform/chromium-win/svg/batik/text/textAnchor-expected.txt:
* platform/chromium-win/svg/batik/text/textDecoration-expected.txt:
* platform/chromium-win/svg/batik/text/textEffect-expected.txt:
* platform/chromium-win/svg/batik/text/textEffect2-expected.txt:
* platform/chromium-win/svg/batik/text/textEffect3-expected.txt:
* platform/chromium-win/svg/batik/text/textFeatures-expected.txt:
* platform/chromium-win/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
* platform/chromium-win/svg/batik/text/textLayout-expected.txt:
* platform/chromium-win/svg/batik/text/textLayout2-expected.txt:
* platform/chromium-win/svg/batik/text/textLength-expected.txt:
* platform/chromium-win/svg/batik/text/textOnPath-expected.txt:
* platform/chromium-win/svg/batik/text/textOnPath2-expected.txt:
* platform/chromium-win/svg/batik/text/textOnPath3-expected.txt:
* platform/chromium-win/svg/batik/text/textOnPathSpaces-expected.txt:
* platform/chromium-win/svg/batik/text/textPosition-expected.txt:
* platform/chromium-win/svg/batik/text/textPosition2-expected.txt:
* platform/chromium-win/svg/batik/text/textProperties-expected.txt:
* platform/chromium-win/svg/batik/text/textProperties2-expected.txt:
* platform/chromium-win/svg/batik/text/textStyles-expected.txt:
* platform/chromium-win/svg/batik/text/verticalText-expected.txt:
* platform/chromium-win/svg/batik/text/verticalTextOnPath-expected.txt:
* platform/chromium-win/svg/carto.net/button-expected.txt:
* platform/chromium-win/svg/carto.net/colourpicker-expected.txt:
* platform/chromium-win/svg/carto.net/slider-expected.txt:
* platform/chromium-win/svg/carto.net/window-expected.txt:
* platform/chromium-win/svg/filters/filter-refresh-expected.txt:
* platform/chromium-win/svg/hixie/error/017-expected.txt:
* platform/chromium-win/svg/stroke/zero-length-path-linecap-rendering-expected.txt: Added.
* platform/chromium-win/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt: Added.
* platform/chromium-win/svg/text/text-gradient-positioning-expected.txt:
* platform/chromium-win/svg/text/text-path-01-b-expected.txt:
* platform/chromium-win/svg/text/text-text-04-t-expected.txt:
* platform/chromium-win/svg/text/text-text-05-t-expected.txt:
* platform/chromium-win/svg/text/text-text-06-t-expected.txt:
* platform/chromium-win/svg/transforms/svg-css-transforms-clip-path-expected.txt:
* platform/chromium-win/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Added.
* platform/chromium/svg/stroke/zero-length-arc-linecaps-rendering-expected.txt: Replaced.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed gardening.
senorblanco@chromium.org [Tue, 6 Mar 2012 20:23:46 +0000 (20:23 +0000)]
[chromium] Unreviewed gardening.

* platform/chromium-mac-leopard/svg/custom/use-on-text-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowritable/configurable not respected for some properties of Function/String/Arguments
barraclough@apple.com [Tue, 6 Mar 2012 20:20:04 +0000 (20:20 +0000)]
writable/configurable not respected for some properties of Function/String/Arguments
https://bugs.webkit.org/show_bug.cgi?id=80436

Reviewed by Oliver Hunt.

Special properties should behave like regular properties.

Source/JavaScriptCore:

* runtime/Arguments.cpp:
(JSC::Arguments::defineOwnProperty):
    - Mis-nested logic for making read-only properties non-live.
* runtime/JSFunction.cpp:
(JSC::JSFunction::put):
    - arguments/length/caller are non-writable, non-configurable - reject appropriately.
(JSC::JSFunction::deleteProperty):
    - Attempting to delete prototype/caller should fail.
(JSC::JSFunction::defineOwnProperty):
    - Ensure prototype is reified on attempt to reify it.
    - arguments/length/caller are non-writable, non-configurable - reject appropriately.
* runtime/JSFunction.h:
    - added declaration for defineOwnProperty.
(JSFunction):
* runtime/StringObject.cpp:
(JSC::StringObject::put):
    - length is non-writable, non-configurable - reject appropriately.

LayoutTests:

* fast/js/mozilla/strict/10.6-expected.txt:
* fast/js/mozilla/strict/15.3.5.1-expected.txt:
* fast/js/mozilla/strict/15.3.5.2-expected.txt:
* fast/js/mozilla/strict/15.5.5.1-expected.txt:
    - Check in passing test results.
* fast/js/script-tests/arguments.js:
    - Fix test - this was asserting incorrect behaviour.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Check WebCommonWorkerClient::allowIndexedDB before proceeding from a share...
dgrogan@chromium.org [Tue, 6 Mar 2012 20:16:45 +0000 (20:16 +0000)]
IndexedDB: Check WebCommonWorkerClient::allowIndexedDB before proceeding from a shared worker
https://bugs.webkit.org/show_bug.cgi?id=79954

Tests: The 'allow' case will be tested once the patch at
http://webkit.org/b/80189 and
https://chromiumcodereview.appspot.com/9585031/ both land. Bug for
testing the 'deny' case is http://crbug.com/113738.

Reviewed by Tony Chang.

* public/WebCommonWorkerClient.h:
(WebKit::WebCommonWorkerClient::allowDatabase):
(WebKit::WebCommonWorkerClient::allowFileSystem):
(WebKit::WebCommonWorkerClient::openFileSystem):
(WebCommonWorkerClient):
(WebKit::WebCommonWorkerClient::allowIndexedDB):
* public/WebSharedWorkerClient.h:
(WebSharedWorkerClient):
* src/IDBFactoryBackendProxy.cpp:
(WebKit::AllowIndexedDBMainThreadBridge::create):
(WebKit::AllowIndexedDBMainThreadBridge::cancel):
(WebKit::AllowIndexedDBMainThreadBridge::signalCompleted):
(WebKit::AllowIndexedDBMainThreadBridge::AllowIndexedDBMainThreadBridge):
(WebKit::AllowIndexedDBMainThreadBridge::allowIndexedDBTask):
(AllowIndexedDBMainThreadBridge):
(WebKit::IDBFactoryBackendProxy::allowIDBFromWorkerThread):
* src/WebWorkerClientImpl.cpp:
(WebKit):
(WebKit::WebWorkerClientImpl::allowIndexedDB):
* src/WebWorkerClientImpl.h:
(WebWorkerClientImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r109825.
senorblanco@chromium.org [Tue, 6 Mar 2012 20:13:37 +0000 (20:13 +0000)]
Unreviewed, rolling out r109825.
http://trac.webkit.org/changeset/109825
https://bugs.webkit.org/show_bug.cgi?id=79413

Broke webkit_unit_tests on Chromium Win

Source/WebCore:

* Modules/indexeddb/IDBLevelDBBackingStore.cpp:
(WebCore::IDBLevelDBBackingStore::open):
* platform/leveldb/LevelDBDatabase.cpp:
(WebCore):
* platform/leveldb/LevelDBDatabase.h:
(LevelDBDatabase):

Source/WebKit/chromium:

* WebKit.gypi:
* tests/LevelDBTest.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd a mechanism to rebaseline new ports
ojan@chromium.org [Tue, 6 Mar 2012 20:11:04 +0000 (20:11 +0000)]
Add a mechanism to rebaseline new ports
https://bugs.webkit.org/show_bug.cgi?id=80355

Reviewed by Adam Barth.

For a test that's only failing on a new port, we want
to first copy the existing result into the location for the
port it's replacing in order to not break that port.

For example, bringing up the chromium-lion port, if we just
stick the results in the chromium-mac directory, the snow leopard
will start failing. Instead, we first copy the existing result
to the chromium-mac-snowleopard directory.

* Scripts/webkitpy/layout_tests/port/builders.py:
(builder_path_for_port_name):
(fallback_port_name_for_new_port):
* Scripts/webkitpy/tool/commands/rebaseline.py:
(RebaselineTest):
(RebaselineTest._copy_existing_baseline):
(RebaselineTest._rebaseline_test):
(RebaselineTest.execute):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaseline.test_rebaseline_test):
(TestRebaseline):
(TestRebaseline.test_rebaseline_and_copy_test):
(test_rebaseline_and_copy_test_no_existing_result):
(test_rebaseline_and_copy_test_with_lion_result):
(test_rebaseline_and_copy_no_overwrite_test):
* Scripts/webkitpy/tool/servers/gardeningserver.py:
(GardeningHTTPRequestHandler.rebaseline):
* Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
(GardeningServerTest.test_rebaseline):
(GardeningServerTest):
(GardeningServerTest.test_rebaseline_new_port):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttps://bugs.webkit.org/show_bug.cgi?id=80351
bdakin@apple.com [Tue, 6 Mar 2012 20:08:56 +0000 (20:08 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=80351
InlineTextBox is using the wrong origin when calling
addRelevantRepaintedObject
-and corresponding-
<rdar://problem/10970221>

Reviewed by Sam Weinig.

Source/WebCore:

boxOrigin represents the actual location of the text. The adjustedPaintOffset
(which I was using previously) will only correspond to the first line in a
block of lines.
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):

Tools:

This test has actually been broken since revision 109273. This change makes
the test pass again, and it makes it specifically exercise the fix for this
bug.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
(TestWebKitAPI::TEST):

Adjust comments in the other tests to reflect the API changes from 109273.
* TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
(TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::didCreatePage):
* TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
(TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::didCreatePage):
* TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
(TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::didCreatePage):
* TestWebKitAPI/Tests/WebKit2/lots-of-text.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Disable border radius clips (r95239) for BlackBerry
commit-queue@webkit.org [Tue, 6 Mar 2012 19:59:31 +0000 (19:59 +0000)]
[BlackBerry] Disable border radius clips (r95239) for BlackBerry
https://bugs.webkit.org/show_bug.cgi?id=80416

Patch by Filip Spacek <fspacek@rim.com> on 2012-03-06
Reviewed by Antonio Gomes

The BlackBerry port suffers from the same performance
degradation when border radius clip is enabled as Chromium.

* rendering/RenderLayer.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r109832.
senorblanco@chromium.org [Tue, 6 Mar 2012 19:55:53 +0000 (19:55 +0000)]
Unreviewed, rolling out r109832.
http://trac.webkit.org/changeset/109832
https://bugs.webkit.org/show_bug.cgi?id=80356

Broke WebSocket tests on Chrome Mac and Linux

* Modules/websockets/ThreadableWebSocketChannel.h:
(ThreadableWebSocketChannel):
* Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:
(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
(WebCore::ThreadableWebSocketChannelClientWrapper::sendRequestResult):
(WebCore::ThreadableWebSocketChannelClientWrapper::setSendRequestResult):
* Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:
(ThreadableWebSocketChannelClientWrapper):
* Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::send):
* Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::send):
(WebCore::WebSocketChannel::enqueueTextFrame):
(WebCore::WebSocketChannel::processOutgoingFrameQueue):
* Modules/websockets/WebSocketChannel.h:
(WebSocketChannel):
(QueuedFrame):
* Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::send):
(WebCore::workerContextDidSend):
(WebCore::WorkerThreadableWebSocketChannel::Peer::send):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::send):
* Modules/websockets/WorkerThreadableWebSocketChannel.h:
(WorkerThreadableWebSocketChannel):
(Bridge):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r109840.
senorblanco@chromium.org [Tue, 6 Mar 2012 19:50:48 +0000 (19:50 +0000)]
Unreviewed, rolling out r109840.
http://trac.webkit.org/changeset/109840
https://bugs.webkit.org/show_bug.cgi?id=80103

Broke WebSocket tests on Chrome Mac and Linux

Source/WebCore:

* Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::send):
(WebCore::WebSocket::close):
* Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::send):

LayoutTests:

* http/tests/websocket/tests/hybi/close-expected.txt:
* http/tests/websocket/tests/hybi/unpaired-surrogates-in-close-reason-expected.txt: Removed.
* http/tests/websocket/tests/hybi/unpaired-surrogates-in-close-reason.html: Removed.
* http/tests/websocket/tests/hybi/unpaired-surrogates-in-message-expected.txt: Removed.
* http/tests/websocket/tests/hybi/unpaired-surrogates-in-message.html: Removed.
* http/tests/websocket/tests/hybi/workers/close-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago<http://webkit.org/b/78575> Web Inspector: Disable dock button when not allowed to...
joepeck@webkit.org [Tue, 6 Mar 2012 19:33:07 +0000 (19:33 +0000)]
<webkit.org/b/78575> Web Inspector: Disable dock button when not allowed to dock

There are times when an undocked inspector frontend is not allowed to
attach to the main window. We can disable the dock button in those cases.

Reviewed by Pavel Feldman.

No new tests. This functionality is port specific right now.

* page/FrameView.cpp:
(WebCore::FrameView::performPostLayoutTasks):
When the main frame is resized we let the inspector client know,
so that it can react to it as needed.

* WebCore.exp.in:
* inspector/InspectorClient.h:
(WebCore::InspectorClient::didResizeMainFrame):
* inspector/InspectorController.cpp:
* inspector/InspectorController.h:
(WebCore::InspectorController::inspectorClient):
Call up to the port though to the InspectorClient.

* inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::frontendLoaded):
(WebCore::InspectorFrontendClientLocal::setDockingUnavailable):
* inspector/InspectorFrontendClientLocal.h:
On ports where the inspector frontend client is local, provide a
setDockingUnavailable InspectorFrontendAPI to update the docking state.
Automatically update availability when the frontend completes loading.

* inspector/front-end/InspectorFrontendAPI.js:
(InspectorFrontendAPI.setDockingUnavailable):
* inspector/front-end/inspector.js:
(WebInspector._createGlobalStatusBarItems):
(WebInspector.setAttachedWindow):
(WebInspector.setDockingUnavailable):
(WebInspector.updateDockToggleButton):
Update the dock button's enabled/disabled state when its created,
when the attached state changes, when get a frontend API notification
that we cannot attach.

* inspector/front-end/InspectorFrontendHostStub.js:
Remove unused canAttachWindow method.

Source/WebKit/mac: Web Inspector: Hide dock button when not allowed to dock
https://bugs.webkit.org/show_bug.cgi?id=78575

Reviewed by Pavel Feldman.

* WebCoreSupport/WebInspectorClient.h:
(WebCore):
(WebInspectorClient):
* WebCoreSupport/WebInspectorClient.mm:
(WebInspectorClient::didResizeMainFrame):

Source/WebKit2: Web Inspector: Hide dock button when not allowed to dock
https://bugs.webkit.org/show_bug.cgi?id=78575

Reviewed by Pavel Feldman.

* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::didResizeMainFrame):
* WebProcess/WebCoreSupport/WebInspectorClient.h:
* WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::updateDockingAvailability):
* WebProcess/WebPage/WebInspector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSpeech JavaScript API: add SpeechRecognitionError
hans@chromium.org [Tue, 6 Mar 2012 19:23:15 +0000 (19:23 +0000)]
Speech JavaScript API: add SpeechRecognitionError
https://bugs.webkit.org/show_bug.cgi?id=80410

Source/WebCore:

Reviewed by Adam Barth.

Add SpeechRecognitionError.

Test: fast/speech/scripted/speechrecognitionerror-basics.html

* Modules/speech/DOMWindowSpeech.idl: Added.
* Modules/speech/SpeechRecognitionError.cpp: Added.
(WebCore):
(WebCore::SpeechRecognitionError::create):
(WebCore::SpeechRecognitionError::SpeechRecognitionError):
* Modules/speech/SpeechRecognitionError.h: Added.
(WebCore):
(SpeechRecognitionError):
(WebCore::SpeechRecognitionError::code):
(WebCore::SpeechRecognitionError::message):
* Modules/speech/SpeechRecognitionError.idl: Added.
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:

Tools:

Chromium: enable the runtime flag for scripted speech so we can run
the layout tests for it.

Reviewed by Adam Barth.

* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):

LayoutTests:

Add a test for SpeechRecognitionError.

Reviewed by Adam Barth.

* fast/speech/scripted/speechrecognitionerror-basics.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEnable universal newlines in chromium android layout test runner
commit-queue@webkit.org [Tue, 6 Mar 2012 19:08:26 +0000 (19:08 +0000)]
Enable universal newlines in chromium android layout test runner
https://bugs.webkit.org/show_bug.cgi?id=80418

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-03-06
Reviewed by Adam Barth.

The Chromium Android layout test runner uses the 'adb' program to
communicate with the Android device. Adb uses CRLF ('\r\n') to delimit
output lines from the test runner, while the test expectation files are
written with LF ('\n') delimiters. This causes the results to have
spurious whitespace differences, making them more difficult to
interpret.

The fix is to enable universal newlines for the DumpRenderTree pipe,
causing the output to only contain LF newlines like on other platforms.

* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidDriver._start):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoselect-line-break-with-opposite-directionality.html is flaky
rniwa@webkit.org [Tue, 6 Mar 2012 18:35:13 +0000 (18:35 +0000)]
select-line-break-with-opposite-directionality.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=80227

Unreviewed test fix attempt.

* editing/selection/select-line-break-with-opposite-directionality.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreleased gst_object_reference to audio sink in MediaPlayerPrivateGStreamer
commit-queue@webkit.org [Tue, 6 Mar 2012 18:15:00 +0000 (18:15 +0000)]
Unreleased gst_object_reference to audio sink in MediaPlayerPrivateGStreamer
https://bugs.webkit.org/show_bug.cgi?id=79795

Bug fix: Used a GRefPtr to hold the reference to the audio sink instead of a GstElement*.
Code cleanup: Used the same pattern for webkit web source and removed explicit gst_unref in destructor.

Patch by David Corvoysier <david.corvoysier@orange.com> on 2012-03-06
Reviewed by Philippe Normand.

No new tests. No change in behavior.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(MediaPlayerPrivateGStreamer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CMake] Build fix for !ENABLE(WORKERS) after r109556 and r109833.
paroga@webkit.org [Tue, 6 Mar 2012 18:03:02 +0000 (18:03 +0000)]
[CMake] Build fix for !ENABLE(WORKERS) after r109556 and r109833.

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Crash in Frame.cpp when loading index.hu
commit-queue@webkit.org [Tue, 6 Mar 2012 17:57:46 +0000 (17:57 +0000)]
[Qt][WK2] Crash in Frame.cpp when loading index.hu
https://bugs.webkit.org/show_bug.cgi?id=80165

Guard against possible null document, which can happen
when unsetting a document in a frame.

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-03-06
Reviewed by Kenneth Rohde Christiansen.

* page/Frame.cpp:
(WebCore::Frame::setDocument):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Interaction Engine suspends content during pageload.
abecsi@webkit.org [Tue, 6 Mar 2012 17:54:43 +0000 (17:54 +0000)]
[Qt] Interaction Engine suspends content during pageload.
https://bugs.webkit.org/show_bug.cgi?id=80294

Only suspend content when viewport updates are deferred
for a non-instantanious interaction.

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-03-06
Reviewed by Kenneth Rohde Christiansen.

* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::ViewportUpdateDeferrer::ViewportUpdateDeferrer):
(WebKit::ViewportUpdateDeferrer::~ViewportUpdateDeferrer):
(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::flickableMoveStarted):
(WebKit::QtViewportInteractionEngine::scaleAnimationStateChanged):
* UIProcess/qt/QtViewportInteractionEngine.h:
(QtViewportInteractionEngine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebCore build exceeds address space on 32-bit Windows builds.
jberlin@webkit.org [Tue, 6 Mar 2012 17:51:31 +0000 (17:51 +0000)]
WebCore build exceeds address space on 32-bit Windows builds.
https://bugs.webkit.org/show_bug.cgi?id=80346

Patch by Lucas Forschler <lforschler@apple.com> on 2012-03-06
Reviewed by Jessie Berlin.

Patch by Lucas Forschler, landed by Jessie Berlin.

Add AllInOne.cpp files for a few projects.
This will only affect Production and Release builds.
Let VS rebuild the project file.

* WebCore.vcproj/WebCore.vcproj:
* css/MediaAllInOne.cpp: Added.
* loader/appcache/ApplicationCacheAllInOne.cpp: Added.
* mathml/MathMLAllInOne.cpp: Added.
* platform/text/TextAllInOne.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] fullscreen/full-screen-iframe-legacy.html is flaky
philn@webkit.org [Tue, 6 Mar 2012 17:46:29 +0000 (17:46 +0000)]
[GTK] fullscreen/full-screen-iframe-legacy.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=74279

Reviewed by Eric Carlson.

* fullscreen/full-screen-iframe-legacy.html: Wait for canplaythrough
event on the video and increase the timeout to 100ms to reduce
flakiness. Also set the iframe video url from the main frame
before installing the canplaythrough event listener.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: add support for inspection of huge (1M elements) arrays.
pfeldman@chromium.org [Tue, 6 Mar 2012 17:17:13 +0000 (17:17 +0000)]
Web Inspector: add support for inspection of huge (1M elements) arrays.
https://bugs.webkit.org/show_bug.cgi?id=80421

Reviewed by Vsevolod Vlasov.

Source/WebCore:

* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.completionsForExpression.evaluated):
* inspector/front-end/ElementsPanel.js:
* inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertiesSection.prototype.update.callback):
(WebInspector.ObjectPropertiesSection.prototype.update):
(WebInspector.ObjectPropertiesSection.prototype.updateProperties):
(WebInspector.ObjectPropertyTreeElement.prototype.onpopulate.callback):
(WebInspector.ObjectPropertyTreeElement.prototype.onpopulate):
(WebInspector.ArrayGroupingTreeElement):
(WebInspector.ArrayGroupingTreeElement._populateArray):
(WebInspector.ArrayGroupingTreeElement._populateRanges):
(WebInspector.ArrayGroupingTreeElement._populateRanges.callback):
(WebInspector.ArrayGroupingTreeElement._populateAsFragment):
(WebInspector.ArrayGroupingTreeElement._populateAsFragment.processArrayFragment):
(WebInspector.ArrayGroupingTreeElement._populateAsFragment.processProperties):
(WebInspector.ArrayGroupingTreeElement._populateNonIndexProperties.buildObjectFragment):
(WebInspector.ArrayGroupingTreeElement._populateNonIndexProperties.processObjectFragment):
(WebInspector.ArrayGroupingTreeElement._populateNonIndexProperties.processProperties):
(WebInspector.ArrayGroupingTreeElement._populateNonIndexProperties):
(WebInspector.ArrayGroupingTreeElement.prototype.onpopulate):
(WebInspector.ArrayGroupingTreeElement.prototype.onattach):
* inspector/front-end/PropertiesSidebarPane.js:
(WebInspector.PropertiesSidebarPane.prototype.update.nodeResolved):
* inspector/front-end/RemoteObject.js:
(WebInspector.RemoteObject.prototype.callFunction):
(WebInspector.RemoteObject.prototype.callFunctionJSON):

LayoutTests:

* http/tests/inspector/indexeddb/database-data.html:
* inspector/console/console-big-array.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Don't suspend accel comp when backgrounding a page.
jpetsovits@rim.com [Tue, 6 Mar 2012 17:09:56 +0000 (17:09 +0000)]
[BlackBerry] Don't suspend accel comp when backgrounding a page.
https://bugs.webkit.org/show_bug.cgi?id=80369
RIM PR: 137609

Reviewed by Adam Treat.

Just because the page is in the background doesn't mean
it's invisible, doesn't mean it won't have to be redrawn
at some point - on rotation, for instance.

We still suspend accelerated compositing on setVisible(false).

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::notifyPageBackground):
(BlackBerry::WebKit::WebPage::notifyPageForeground):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Rebaseline some SVG tests now giving correct results.
senorblanco@chromium.org [Tue, 6 Mar 2012 16:58:16 +0000 (16:58 +0000)]
[chromium] Rebaseline some SVG tests now giving correct results.

Unreviewed gardening.

* platform/chromium-linux/svg/custom/use-on-text-expected.png:
* platform/chromium-linux/svg/custom/use-referencing-nonexisting-symbol-expected.png: Added.
* platform/chromium-linux/svg/custom/use-setAttribute-crash-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/use-on-text-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/use-on-text-expected.txt: Removed.
* platform/chromium-mac-snowleopard/svg/custom/use-referencing-nonexisting-symbol-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/use-referencing-nonexisting-symbol-expected.txt: Removed.
* platform/chromium-mac-snowleopard/svg/custom/use-setAttribute-crash-expected.png:
* platform/chromium-win/svg/custom/use-on-text-expected.png:
* platform/chromium-win/svg/custom/use-referencing-nonexisting-symbol-expected.png:
* platform/chromium-win/svg/custom/use-setAttribute-crash-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Open link in resources panel only works the second time
vsevik@chromium.org [Tue, 6 Mar 2012 16:33:59 +0000 (16:33 +0000)]
Web Inspector: Open link in resources panel only works the second time
https://bugs.webkit.org/show_bug.cgi?id=80407

Reviewed by Pavel Feldman.

* inspector/front-end/inspector.js:
(WebInspector.openResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: InspectorCounters mechanism should be thread-safe
yurys@chromium.org [Tue, 6 Mar 2012 16:20:30 +0000 (16:20 +0000)]
Web Inspector: InspectorCounters mechanism should be thread-safe
https://bugs.webkit.org/show_bug.cgi?id=80166

Make InspectorCounters instance thread local so that it can be safely accessed
in workers.

Reviewed by Pavel Feldman.

* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::JSEventListener):
(WebCore::JSEventListener::~JSEventListener):
* bindings/v8/V8AbstractEventListener.cpp:
(WebCore::V8AbstractEventListener::V8AbstractEventListener):
(WebCore::V8AbstractEventListener::~V8AbstractEventListener):
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::~Document):
* dom/Document.h:
(WebCore::Node::Node):
* dom/Node.cpp:
(WebCore::Node::~Node):
* inspector/InspectorCounters.cpp:
(WebCore::InspectorCounters::InspectorCounters):
(WebCore::InspectorCounters::counterValue):
(WebCore):
(WebCore::InspectorCounters::current):
* inspector/InspectorCounters.h:
(WebCore::InspectorCounters::incrementCounter):
(WebCore::InspectorCounters::decrementCounter):
(InspectorCounters):
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::setHeapSizeStatistic):
* platform/ThreadGlobalData.cpp:
(WebCore::ThreadGlobalData::ThreadGlobalData):
(WebCore::ThreadGlobalData::destroy):
* platform/ThreadGlobalData.h:
(WebCore):
(ThreadGlobalData):
(WebCore::ThreadGlobalData::inspectorCounters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GStreamer] media/video-played-collapse.html
philn@webkit.org [Tue, 6 Mar 2012 16:10:58 +0000 (16:10 +0000)]
[GStreamer] media/video-played-collapse.html
https://bugs.webkit.org/show_bug.cgi?id=36165

Reviewed by Eric Carlson.

Refactored the test to minimize flakiness risks.

* media/video-played-collapse-expected.txt:
* media/video-played-collapse.html:
* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Upstream typedef of NativeImageSourcePtr and NativeImagePtr
leo.yang@torchmobile.com.cn [Tue, 6 Mar 2012 15:50:04 +0000 (15:50 +0000)]
[BlackBerry] Upstream typedef of NativeImageSourcePtr and NativeImagePtr
https://bugs.webkit.org/show_bug.cgi?id=80388

Reviewed by Antonio Gomes.

These are the BlackBerry typdefs of NativeImageSourcePtr and NativeImagePtr.

* platform/graphics/ImageSource.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTypedArray subarray call for subarray does not clamp the end index parameter properly
commit-queue@webkit.org [Tue, 6 Mar 2012 15:30:51 +0000 (15:30 +0000)]
TypedArray subarray call for subarray does not clamp the end index parameter properly
https://bugs.webkit.org/show_bug.cgi?id=80285

Patch by Ulan Degenbaev <ulan@chromium.org> on 2012-03-06
Reviewed by Kenneth Russell.

Source/JavaScriptCore:

* wtf/ArrayBufferView.h:
(WTF::ArrayBufferView::calculateOffsetAndLength):

LayoutTests:

* fast/canvas/webgl/array-unit-tests-expected.txt:
* fast/canvas/webgl/array-unit-tests.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate Chromium/SVG expectations after the <use> rewrite
schenney@chromium.org [Tue, 6 Mar 2012 15:17:00 +0000 (15:17 +0000)]
Update Chromium/SVG expectations after the <use> rewrite
https://bugs.webkit.org/show_bug.cgi?id=79568

Unreviewed Chromium expectations update.

Stage 1 of expectations updating for SVG <use> refactor. This covers the svg/custom directory.

* platform/chromium-linux-x86/svg/custom/use-disappears-after-style-update-expected.txt:
* platform/chromium-linux-x86/svg/custom/use-on-symbol-inside-pattern-expected.txt:
* platform/chromium-linux-x86/svg/custom/use-setAttribute-crash-expected.txt: Added.
* platform/chromium-linux/svg/custom/use-disappears-after-style-update-expected.txt:
* platform/chromium-linux/svg/custom/use-on-symbol-inside-pattern-expected.txt:
* platform/chromium-linux/svg/custom/use-on-text-expected.png:
* platform/chromium-linux/svg/custom/use-referencing-nonexisting-symbol-expected.png: Removed.
* platform/chromium-linux/svg/custom/use-referencing-nonexisting-symbol-expected.txt:
* platform/chromium-linux/svg/custom/use-setAttribute-crash-expected.png: Removed.
* platform/chromium-linux/svg/custom/use-setAttribute-crash-expected.txt:
* platform/chromium-mac-leopard/svg/custom/use-disappears-after-style-update-expected.txt: Added.
* platform/chromium-mac-leopard/svg/custom/use-font-face-crash-expected.txt:
* platform/chromium-mac-leopard/svg/custom/use-on-text-expected.png:
* platform/chromium-mac-leopard/svg/custom/use-setAttribute-crash-expected.txt:
* platform/chromium-mac-snowleopard/svg/custom/broken-internal-references-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/clip-path-referencing-use2-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/custom/recursive-clippath-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/recursive-mask-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/recursive-pattern-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/use-css-events-expected.txt:
* platform/chromium-mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/custom/use-events-crash-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/use-on-disallowed-foreign-object-1-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/use-on-disallowed-foreign-object-2-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/use-on-disallowed-foreign-object-5-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/use-on-disallowed-foreign-object-6-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/use-on-non-svg-namespaced-element-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/use-on-symbol-inside-pattern-expected.txt:
* platform/chromium-mac-snowleopard/svg/custom/use-on-text-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/use-on-text-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/custom/use-referencing-nonexisting-symbol-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/use-referencing-nonexisting-symbol-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/custom/use-setAttribute-crash-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/use-setAttribute-crash-expected.txt:
* platform/chromium-mac/svg/custom/broken-internal-references-expected.png: Removed.
* platform/chromium-mac/svg/custom/clip-path-referencing-use2-expected.txt: Removed.
* platform/chromium-mac/svg/custom/recursive-clippath-expected.png: Removed.
* platform/chromium-mac/svg/custom/recursive-mask-expected.png: Removed.
* platform/chromium-mac/svg/custom/recursive-pattern-expected.png: Removed.
* platform/chromium-mac/svg/custom/use-events-crash-expected.png: Removed.
* platform/chromium-mac/svg/custom/use-on-disallowed-foreign-object-1-expected.png: Removed.
* platform/chromium-mac/svg/custom/use-on-disallowed-foreign-object-2-expected.png: Removed.
* platform/chromium-mac/svg/custom/use-on-disallowed-foreign-object-5-expected.png: Removed.
* platform/chromium-mac/svg/custom/use-on-disallowed-foreign-object-6-expected.png: Removed.
* platform/chromium-mac/svg/custom/use-on-non-svg-namespaced-element-expected.png: Removed.
* platform/chromium-win-vista/svg/custom/use-disappears-after-style-update-expected.txt:
* platform/chromium-win-vista/svg/custom/use-setAttribute-crash-expected.txt:
* platform/chromium-win-xp/svg/custom/use-disappears-after-style-update-expected.txt:
* platform/chromium-win-xp/svg/custom/use-setAttribute-crash-expected.txt:
* platform/chromium-win/svg/custom/broken-internal-references-expected.txt:
* platform/chromium-win/svg/custom/clip-path-referencing-use-expected.txt:
* platform/chromium-win/svg/custom/clip-path-referencing-use2-expected.txt:
* platform/chromium-win/svg/custom/embedding-external-svgs-expected.txt:
* platform/chromium-win/svg/custom/path-textPath-simulation-expected.txt:
* platform/chromium-win/svg/custom/pattern-rotate-expected.txt:
* platform/chromium-win/svg/custom/recursive-clippath-expected.txt:
* platform/chromium-win/svg/custom/recursive-mask-expected.txt:
* platform/chromium-win/svg/custom/recursive-pattern-expected.txt:
* platform/chromium-win/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt:
* platform/chromium-win/svg/custom/relative-sized-shadow-tree-content-expected.txt:
* platform/chromium-win/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt:
* platform/chromium-win/svg/custom/relative-sized-use-on-symbol-expected.txt:
* platform/chromium-win/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt:
* platform/chromium-win/svg/custom/struct-use-09-b-expected.txt:
* platform/chromium-win/svg/custom/use-clipped-hit-expected.txt:
* platform/chromium-win/svg/custom/use-css-events-expected.txt:
* platform/chromium-win/svg/custom/use-disappears-after-style-update-expected.png:
* platform/chromium-win/svg/custom/use-disappears-after-style-update-expected.txt:
* platform/chromium-win/svg/custom/use-dynamic-append-expected.txt:
* platform/chromium-win/svg/custom/use-elementInstance-event-target-expected.txt:
* platform/chromium-win/svg/custom/use-elementInstance-methods-expected.txt:
* platform/chromium-win/svg/custom/use-event-handler-on-referenced-element-expected.txt:
* platform/chromium-win/svg/custom/use-event-handler-on-use-element-expected.txt:
* platform/chromium-win/svg/custom/use-events-crash-expected.txt:
* platform/chromium-win/svg/custom/use-font-face-crash-expected.txt:
* platform/chromium-win/svg/custom/use-instanceRoot-modifications-expected.txt:
* platform/chromium-win/svg/custom/use-modify-container-in-target-expected.txt:
* platform/chromium-win/svg/custom/use-modify-target-container-expected.txt:
* platform/chromium-win/svg/custom/use-modify-target-symbol-expected.txt:
* platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-1-expected.txt:
* platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-2-expected.txt:
* platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-3-expected.txt:
* platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-4-expected.txt:
* platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
* platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
* platform/chromium-win/svg/custom/use-on-g-containing-symbol-expected.txt:
* platform/chromium-win/svg/custom/use-on-g-containing-use-expected.txt:
* platform/chromium-win/svg/custom/use-on-g-expected.txt:
* platform/chromium-win/svg/custom/use-on-non-svg-namespaced-element-expected.txt:
* platform/chromium-win/svg/custom/use-on-rect-expected.txt:
* platform/chromium-win/svg/custom/use-on-symbol-expected.txt:
* platform/chromium-win/svg/custom/use-on-symbol-inside-pattern-expected.txt:
* platform/chromium-win/svg/custom/use-on-text-expected.png:
* platform/chromium-win/svg/custom/use-on-text-expected.txt:
* platform/chromium-win/svg/custom/use-on-use-expected.txt:
* platform/chromium-win/svg/custom/use-property-changes-through-dom-expected.txt:
* platform/chromium-win/svg/custom/use-property-changes-through-svg-dom-expected.txt:
* platform/chromium-win/svg/custom/use-recursion-1-expected.txt:
* platform/chromium-win/svg/custom/use-recursion-2-expected.txt:
* platform/chromium-win/svg/custom/use-recursion-3-expected.txt:
* platform/chromium-win/svg/custom/use-recursion-4-expected.txt:
* platform/chromium-win/svg/custom/use-referencing-nonexisting-symbol-expected.png:
* platform/chromium-win/svg/custom/use-referencing-nonexisting-symbol-expected.txt:
* platform/chromium-win/svg/custom/use-setAttribute-crash-expected.png:
* platform/chromium-win/svg/custom/use-setAttribute-crash-expected.txt:
* platform/chromium-win/svg/custom/use-transform-expected.txt:
* platform/chromium/test_expectations.txt:
* platform/mac-future/svg/custom: Added.
* platform/mac-future/svg/custom/use-on-symbol-inside-pattern-expected.png: Added.
* platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSVG transform-origin presentation attribute
commit-queue@webkit.org [Tue, 6 Mar 2012 15:05:34 +0000 (15:05 +0000)]
SVG transform-origin presentation attribute
https://bugs.webkit.org/show_bug.cgi?id=79678

Patch by Hans Muller <hmuller@adobe.com> on 2012-03-06
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Added the SVG transform-origin presentation attribute.  Currently WebCore::mapAttributeToCSSProperty()
just maps it to -webkit-transform-origin.  When the transform-origin CSS property is supported, this
part of the change can be removed.

Test: svg/transforms/transform-origin-presentation-attribute.xhtml

* svg/SVGStyledElement.cpp:
(WebCore::mapAttributeToCSSProperty):
(WebCore::SVGStyledElement::cssPropertyIdForSVGAttributeName):
* svg/svgattrs.in:

LayoutTests:

Test case just verifies that the transform-origin presentation attribute
changes an SVG element's getComputedStyle() as expected.

* svg/transforms/transform-origin-presentation-attribute-expected.txt: Added.
* svg/transforms/transform-origin-presentation-attribute.xhtml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GStreamer] disable GStreamerGWorld when building against 0.11
philn@webkit.org [Tue, 6 Mar 2012 15:02:46 +0000 (15:02 +0000)]
[GStreamer] disable GStreamerGWorld when building against 0.11
https://bugs.webkit.org/show_bug.cgi?id=77088

Source/WebCore:

Reviewed by Martin Robinson.

Don't build GStreamerGWorld and PlatformVideoWindow under
GStreamer 0.11. It's supposed to be removed soon anyway.

* platform/graphics/gstreamer/GStreamerGWorld.cpp:
* platform/graphics/gstreamer/GStreamerGWorld.h:
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::totalBytes):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(MediaPlayerPrivateGStreamer):
* platform/graphics/gstreamer/PlatformVideoWindow.h:
* platform/graphics/gstreamer/PlatformVideoWindowEfl.cpp:
* platform/graphics/gstreamer/PlatformVideoWindowGtk.cpp:
* platform/graphics/gstreamer/PlatformVideoWindowMac.mm:
* platform/graphics/gstreamer/PlatformVideoWindowQt.cpp:

Source/WebKit/gtk:

Disable the FullscreenVideoController if we build against
GStreamer 0.11. This code depends on GStreamerGWorld which wasn't
ported to 0.11 because it will soon be removed anyway.

Reviewed by Martin Robinson.

* WebCoreSupport/FullscreenVideoController.cpp:
* WebCoreSupport/FullscreenVideoController.h:
* webkit/webkitwebview.cpp:
(webViewEnterFullscreen):
(webViewExitFullscreen):
* webkit/webkitwebviewprivate.h:
(_WebKitWebViewPrivate):

Source/WebKit/qt:

Reviewed by Martin Robinson.

* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::ChromeClientQt):
(WebCore::ChromeClientQt::~ChromeClientQt):
(WebCore):
* WebCoreSupport/FullScreenVideoQt.cpp:
(WebCore):
(WebCore::FullScreenVideoQt::FullScreenVideoQt):
(WebCore::FullScreenVideoQt::~FullScreenVideoQt):
(WebCore::FullScreenVideoQt::enterFullScreenForNode):
(WebCore::FullScreenVideoQt::exitFullScreenForNode):
(WebCore::FullScreenVideoQt::isValid):
* WebCoreSupport/FullScreenVideoQt.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRename m_tileCreationTimer in the tiled backing store https://bugs.webkit.org/show_bu...
ahf@0x90.dk [Tue, 6 Mar 2012 14:10:12 +0000 (14:10 +0000)]
Rename m_tileCreationTimer in the tiled backing store https://bugs.webkit.org/show_bug.cgi?id=80414

Patch by Kenneth Rohde Christiansen and Alexander Færøy.

Reviewed by Tor Arne Vestbø.

The m_tileCreationTimer member is currently being used to represent a
timer that is fired when the backing store has been updated which is
confusing with its current name.  This patch fixes this by renaming
the m_tileCreationTimer to m_backingStoreUpdateTimer.

* platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::TiledBackingStore):
(WebCore::TiledBackingStore::setTileSize):
(WebCore::TiledBackingStore::coverWithTilesIfNeeded):
(WebCore::TiledBackingStore::createTiles):
(WebCore::TiledBackingStore::startBackingStoreUpdateTimer):
(WebCore::TiledBackingStore::backingStoreUpdateTimerFired):
(WebCore::TiledBackingStore::setContentsFrozen):
* platform/graphics/TiledBackingStore.h:
(TiledBackingStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Heap Snapshot test: split overal time metric into separate metrics.
loislo@chromium.org [Tue, 6 Mar 2012 13:41:21 +0000 (13:41 +0000)]
Web Inspector: Heap Snapshot test: split overal time metric into separate metrics.
https://bugs.webkit.org/show_bug.cgi?id=80409

Reviewed by Yury Semikhatsky.

* inspector/detailed-heapshots-smoke-test.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Make QQuickWebView's url property work with a flickable webview
hausmann@webkit.org [Tue, 6 Mar 2012 13:37:58 +0000 (13:37 +0000)]
[Qt] Make QQuickWebView's url property work with a flickable webview

Reviewed by Tor Arne Vestbø.

QQuickWebViewPrivate::onComponentComplete implements the deferred url loading
when the url property is set in the component instantiation. QQuickWebViewFlickablePrivate
is the private sub-class used for a flickable webview, which re-implemented onComponentComplete
but forgot to call the base implementation.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewFlickablePrivate::onComponentComplete):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Unreviewed; fix the build after r109877.
kubo@profusion.mobi [Tue, 6 Mar 2012 13:37:44 +0000 (13:37 +0000)]
[EFL] Unreviewed; fix the build after r109877.

* CMakeLists.txt: Add WebCore/Modules/webdatabase to the list of
include directories so that #include'ing DatabaseDetails.h and
friends still works.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove TileTimer typedef from the tiled backing store https://bugs.webkit.org/show_bu...
ahf@0x90.dk [Tue, 6 Mar 2012 13:32:48 +0000 (13:32 +0000)]
Remove TileTimer typedef from the tiled backing store https://bugs.webkit.org/show_bug.cgi?id=80408

Patch by Kenneth Rohde Christiansen and Alexander Færøy.

Reviewed by Tor Arne Vestbø.

* platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::tileBufferUpdateTimerFired):
(WebCore::TiledBackingStore::tileCreationTimerFired):
* platform/graphics/TiledBackingStore.h:
(TiledBackingStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Revert r109900, it was completly busted
vestbo@webkit.org [Tue, 6 Mar 2012 13:25:21 +0000 (13:25 +0000)]
[Qt] Revert r109900, it was completly busted

HAVE_FOO does _not_ have a WTF_ prefix, go figure.

We still leave in the HAVE(FOO) in QtInitializeTestFonts.cpp, instead
of manual define checks.

Reviewed by Ossy.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Upstream LayerRenderer.{h, cpp}
commit-queue@webkit.org [Tue, 6 Mar 2012 13:15:06 +0000 (13:15 +0000)]
[BlackBerry] Upstream LayerRenderer.{h, cpp}
https://bugs.webkit.org/show_bug.cgi?id=79874

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-03-06
Reviewed by Antonio Gomes.

Initial upstream, no new tests.

* platform/graphics/blackberry/LayerRenderer.cpp: Added.
(WebCore):
(WebCore::checkGLError):
(WebCore::loadShader):
(WebCore::loadShaderProgram):
(WebCore::orthoMatrix):
(WebCore::rawPtrVectorFromRefPtrVector):
(WebCore::LayerRenderer::create):
(WebCore::LayerRenderer::LayerRenderer):
(WebCore::LayerRenderer::~LayerRenderer):
(WebCore::LayerRenderer::releaseLayerResources):
(WebCore::compareLayerZ):
(WebCore::LayerRenderer::drawLayers):
(WebCore::LayerRenderer::useSurface):
(WebCore::LayerRenderer::drawLayersOnSurfaces):
(WebCore::LayerRenderer::setRootLayer):
(WebCore::LayerRenderer::addLayer):
(WebCore::LayerRenderer::removeLayer):
(WebCore::LayerRenderer::addLayerToReleaseTextureResourcesList):
(WebCore::LayerRenderer::toOpenGLWindowCoordinates):
(WebCore::LayerRenderer::toWebKitWindowCoordinates):
(WebCore::LayerRenderer::toWebKitDocumentCoordinates):
(WebCore::LayerRenderer::drawDebugBorder):
(WebCore::LayerRenderer::drawHolePunchRect):
(WebCore::LayerRenderer::updateLayersRecursive):
(WebCore::hasRotationalComponent):
(WebCore::LayerRenderer::layerAlreadyOnSurface):
(WebCore::collect3DPreservingLayers):
(WebCore::LayerRenderer::compositeLayersRecursive):
(WebCore::LayerRenderer::updateScissorIfNeeded):
(WebCore::LayerRenderer::makeContextCurrent):
(WebCore::LayerRenderer::bindCommonAttribLocation):
(WebCore::LayerRenderer::initializeSharedGLObjects):
(WebCore::LayerRenderingResults::holePunchRect):
(WebCore::LayerRenderingResults::addHolePunchRect):
(WebCore::LayerRenderingResults::addDirtyRect):
(WebCore::LayerRenderingResults::isEmpty):
* platform/graphics/blackberry/LayerRenderer.h: Added.
(WebCore):
(LayerRenderingResults):
(WebCore::LayerRenderingResults::LayerRenderingResults):
(WebCore::LayerRenderingResults::holePunchRectSize):
(WebCore::LayerRenderingResults::dirtyRect):
(LayerRenderer):
(WebCore::LayerRenderer::rootLayer):
(WebCore::LayerRenderer::hardwareCompositing):
(WebCore::LayerRenderer::setClearSurfaceOnDrawLayers):
(WebCore::LayerRenderer::clearSurfaceOnDrawLayers):
(WebCore::LayerRenderer::context):
(WebCore::LayerRenderer::lastRenderingResults):
(WebCore::LayerRenderer::setNeedsCommit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] function rename issue after MediaPlayerPrivateBlackBerry.[cpp\h] upstream
commit-queue@webkit.org [Tue, 6 Mar 2012 12:59:38 +0000 (12:59 +0000)]
[BlackBerry] function rename issue after MediaPlayerPrivateBlackBerry.[cpp\h] upstream
https://bugs.webkit.org/show_bug.cgi?id=80377

Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-03-06
Reviewed by Rob Buis.

As some of the function names changed in class MediaPlayerPrivate
with the upstream of MediaPlayerPrivateBlackBerry.[cpp|h], we
should update WebKit/blackberry/Api/WebPage.cpp which uses these
functions accordingly.
Renamed functions in class MediaPlayerPrivate:
windowGet() -> getWindow()
windowPositionGet() -> getWindowPosition()
mmrContextNameGet() -> mmrContextName()

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::enterFullscreenForNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agor109563 caused perf regression
rolandsteiner@chromium.org [Tue, 6 Mar 2012 12:42:54 +0000 (12:42 +0000)]
r109563 caused perf regression
https://bugs.webkit.org/show_bug.cgi?id=80404

Add test for Element or ShadowRoot.

Reviewed by Antti Koivisto.

No new tests. (fix)

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::pushParentElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: prepare for extracting ScriptMapping implementation from DebuggerPrese...
podivilov@chromium.org [Tue, 6 Mar 2012 12:39:33 +0000 (12:39 +0000)]
Web Inspector: prepare for extracting ScriptMapping implementation from DebuggerPresentationModel.
https://bugs.webkit.org/show_bug.cgi?id=80396

Source/WebCore:

Limit RawSourceCode usages to a subset of methods. This subset will be moved to ScriptMapping implementation in a separate change.

Reviewed by Vsevolod Vlasov.

* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype.createPlacard):
(WebInspector.DebuggerPresentationModel.prototype.createLiveLocation):
(WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource):
(WebInspector.DebuggerPresentationModel.prototype._failedToParseScriptSource):
(WebInspector.DebuggerPresentationModel.prototype.setScriptSource.didEditScriptSource):
(WebInspector.DebuggerPresentationModel.prototype.setScriptSource):
(WebInspector.DebuggerPresentationModel.prototype._forceUpdateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessageToScript):
(WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
(WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
(WebInspector.PresentationCallFrame):
(WebInspector.PresentationCallFrame.prototype.uiLocation):
(WebInspector.DebuggerPresentationModel.CallFramePlacard):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.canSetContent):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.setContent):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype._uiSourceCodeForResource):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyRawLocation):

LayoutTests:

Reviewed by Vsevolod Vlasov.

* inspector/debugger/callstack-placards-discarded.html:
* inspector/debugger/linkifier.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Use config test to determine if the compiler supports -MD
vestbo@webkit.org [Tue, 6 Mar 2012 12:34:05 +0000 (12:34 +0000)]
[Qt] Use config test to determine if the compiler supports -MD

We used to assume that unix systems building against Qt5 would have
a compiler that supported -MD. Although this was usually the case,
we failed to take into account broken tools for distributed builds
(e.g. teambuilder or icecream) which would end up producing .d files
in the root of the build dir instead of along-side the object file.

Now that we use a config-test to determine the support, we'll capture
those cases, unless distributed builds are enabled after the initial
build-webkit run.

Reviewed by Csaba Osztrogonác.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Regression] Execution line is not revealed when debugger is stopped...
vsevik@chromium.org [Tue, 6 Mar 2012 12:28:57 +0000 (12:28 +0000)]
Web Inspector: [Regression] Execution line is not revealed when debugger is stopped if scripts panel was not yet shown.
https://bugs.webkit.org/show_bug.cgi?id=80306

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/debugger/reveal-execution-line.html

* inspector/front-end/ConsoleView.js:
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.afterTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype.setExecutionLine):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._executionLineChanged):
(WebInspector.ScriptsPanel.prototype._revealExecutionLine):
(WebInspector.ScriptsPanel.prototype._callFrameSelected):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.willHide):
(WebInspector.SourceFrame.prototype.highlightLine):
(WebInspector.SourceFrame.prototype.revealLine):
(WebInspector.SourceFrame.prototype._clearLineToReveal):
(WebInspector.SourceFrame.prototype.setContent):

LayoutTests:

* inspector/debugger/callstack-placards-discarded-expected.txt:
* inspector/debugger/reveal-execution-line-expected.txt: Added.
* inspector/debugger/reveal-execution-line.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r109294): It broke the unittest of master.cfg
ossy@webkit.org [Tue, 6 Mar 2012 12:25:10 +0000 (12:25 +0000)]
REGRESSION(r109294): It broke the unittest of cfg
https://bugs.webkit.org/show_bug.cgi?id=80253

Reviewed by Tor Arne Vestbø.

* BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Use json instead of simplejson.
(BuildBotConfigLoader._create_mock_passwords_dict):
(BuildBotConfigLoader._mock_open):
(BuildBotConfigLoader._add_dependant_modules_to_sys_modules):
(BuildBotConfigLoader.load_config):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoQt API test buildstep throws exception after buildmaster update
ossy@webkit.org [Tue, 6 Mar 2012 12:24:49 +0000 (12:24 +0000)]
Qt API test buildstep throws exception after buildmaster update
https://bugs.webkit.org/show_bug.cgi?id=80249

This patch based on Peter Gal's work.

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2012-03-06
Reviewed by Csaba Osztrogonác.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunQtAPITests):
(BuildAndTestFactory.__init__): Enable API tests on the Qt platform again.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Use correct define names for HAVE(FOO) style optional dependencies
vestbo@webkit.org [Tue, 6 Mar 2012 12:15:41 +0000 (12:15 +0000)]
[Qt] Use correct define names for HAVE(FOO) style optional dependencies

Reviewed by Simon Hausmann.
Reviewed by Ossy.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: remove reference to RawSourceCode from UISourceCode.
podivilov@chromium.org [Tue, 6 Mar 2012 12:11:05 +0000 (12:11 +0000)]
Web Inspector: remove reference to RawSourceCode from UISourceCode.
https://bugs.webkit.org/show_bug.cgi?id=80395

Reviewed by Vsevolod Vlasov.

Source/WebCore:

* inspector/compile-front-end.sh:
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._handleUISourceCodeListChanged):
(WebInspector.DebuggerPresentationModel.prototype._uiSourceCodeListChanged):
(WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
(WebInspector.DebuggerPresentationModel.prototype.setScriptSource.didEditScriptSource):
(WebInspector.DebuggerPresentationModel.prototype.setScriptSource):
(WebInspector.DebuggerPresentationModel.prototype.continueToLine):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype._createUISourceCode):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):

LayoutTests:

* inspector/debugger/raw-source-code.html:
* inspector/debugger/ui-source-code.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: move timeline panel overview mode toggle buttons to overview sidebar...
caseq@chromium.org [Tue, 6 Mar 2012 12:09:18 +0000 (12:09 +0000)]
Web Inspector: move timeline panel overview mode toggle buttons to overview sidebar tree
https://bugs.webkit.org/show_bug.cgi?id=80304

Reviewed by Pavel Feldman.

* inspector/front-end/Images/statusbarButtonGlyphs.png:
* inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype._showTimelines):
(WebInspector.TimelineOverviewPane.prototype._showMemoryGraph):
(WebInspector.TimelineOverviewPane.prototype._setVerticalOverview):
(WebInspector.TimelineOverviewPane.prototype._onOverviewModeChanged):
(WebInspector.TimelineOverviewPane.prototype.update):
(WebInspector.TimelineOverviewPane.prototype.reset):
(WebInspector.TimelineOverviewPane.prototype._onWindowChanged):
(WebInspector.TimelineVerticalOverview):
(WebInspector.TimelineOverviewModeSelector):
(WebInspector.TimelineOverviewModeSelector.prototype.addButton):
(WebInspector.TimelineOverviewModeSelector.prototype.get value):
(WebInspector.TimelineOverviewModeSelector.prototype._createButton):
(WebInspector.TimelineOverviewModeSelector.prototype._select):
(WebInspector.TimelineOverviewModeSelector.prototype._onClick):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype.get statusBarItems):
(WebInspector.TimelinePanel.prototype._createStatusbarButtons):
(WebInspector.TimelinePanel.prototype._updateEventDividers):
(WebInspector.TimelinePanel.prototype._glueParentButtonClicked):
(WebInspector.TimelinePanel.prototype.revealRecordAt):
* inspector/front-end/inspector.css:
* inspector/front-end/timelinePanel.css:
(.timeline-vertical-overview #timeline-overview-grid):
(.timeline-vertical-overview .timeline-overview-window):
(.timeline-vertical-overview .timeline-overview-dividers-background):
(.timeline-vertical-overview #timeline-overview-memory):
(.timeline-vertical-overview-status-bar-item.toggled-on .glyph):
(.timeline-vertical-overview-bars):
(.timeline-vertical-overview-bars .padding):
(.timeline-vertical-overview-bars .timeline-bar-vertical):
(.timeline.timeline-vertical-overview .resources-divider):
(.sidebar-tree-item .timeline-vertical-overview-status-bar-item):
(.timeline-overview-mode-selector):
(.timeline-overview-mode-selector .glyph):
(.timeline-overview-mode-selector button):
(.timeline-overview-mode-selector button.toggled):
(.timeline-overview-mode-selector button:active):
(.sidebar-tree-item:not(.selected) .timeline-overview-mode-selector button):
(.sidebar-tree-item:not(.selected) .timeline-overview-mode-selector button.toggled):
(.timeline-overview-mode-selector button:first-of-type):
(.timeline-overview-mode-selector button:last-of-type):
(.timeline-mode-vertical-bars .glyph):
(.timeline-mode-horizontal-bars .glyph):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake it explicit when we are allowing updates to the actual backing store or the...
ahf@0x90.dk [Tue, 6 Mar 2012 12:04:28 +0000 (12:04 +0000)]
Make it explicit when we are allowing updates to the actual backing store or the tile buffers https://bugs.webkit.org/show_bug.cgi?id=80288

Patch by Kenneth Rohde Christiansen and Alexander Færøy.

Reviewed by Noam Rosenthal.

* platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::createTiles):
(WebCore::TiledBackingStore::isBackingStoreUpdatesSuspended):
(WebCore):
(WebCore::TiledBackingStore::isTileBufferUpdatesSuspended):
(WebCore::TiledBackingStore::startTileBufferUpdateTimer):
(WebCore::TiledBackingStore::startTileCreationTimer):
* platform/graphics/TiledBackingStore.h:
(TiledBackingStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Don't add recursive qmake_all target if there are no subdirs to recurse
vestbo@webkit.org [Tue, 6 Mar 2012 12:03:46 +0000 (12:03 +0000)]
[Qt] Don't add recursive qmake_all target if there are no subdirs to recurse

Reviewed by Ossy.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix after r109877.
mrowe@apple.com [Tue, 6 Mar 2012 12:00:59 +0000 (12:00 +0000)]
Build fix after r109877.

* WebCore.xcodeproj/project.pbxproj: Ensure that headers are copied in to WebCore.framework so that
WebKit can still find them.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Make sure clean builds are followed by make qmake && make if needed
vestbo@webkit.org [Tue, 6 Mar 2012 11:51:17 +0000 (11:51 +0000)]
[Qt] Make sure clean builds are followed by make qmake && make if needed

On non-GNUmake systems we have to run make qmake so that the generated
sources are generated before we run qmake on the target pro files. This
is achieved by using the 'incremental' target.

Reviewed by Ossy.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove incorrect WTF::Vector traits for CSSProperty.
kling@webkit.org [Tue, 6 Mar 2012 11:31:04 +0000 (11:31 +0000)]
Remove incorrect WTF::Vector traits for CSSProperty.
<http://webkit.org/b/53285>
<rdar://problem/10161286>

Reviewed by Antti Koivisto.

We shouldn't allow copying Vector<CSSProperty> contents around with memcpy()
as CSSProperty has a RefPtr member and this would muck up the refcount.
This was added to facilitate fast comparison of property vectors, and we no
longer use that, so there shouldn't be any performance concerns here.

* css/CSSProperty.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDumpRenderTree should support preciseTime()
fpizlo@apple.com [Tue, 6 Mar 2012 10:56:25 +0000 (10:56 +0000)]
DumpRenderTree should support preciseTime()
https://bugs.webkit.org/show_bug.cgi?id=80397

Reviewed by Gavin Barraclough.

* DumpRenderTree/LayoutTestController.cpp:
(preciseTimeCallback):
(LayoutTestController::staticFunctions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Gardening, skip some failing tests.
ossy@webkit.org [Tue, 6 Mar 2012 10:50:25 +0000 (10:50 +0000)]
[Qt] Gardening, skip some failing tests.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-03-06
Reviewed by Csaba Osztrogonác.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r109887.
ossy@webkit.org [Tue, 6 Mar 2012 10:39:40 +0000 (10:39 +0000)]
Unreviewed, rolling out r109887.
http://trac.webkit.org/changeset/109887
https://bugs.webkit.org/show_bug.cgi?id=80402

It broke the build (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-06

* DumpRenderTree/qt/DumpRenderTree.pro:
* DumpRenderTree/qt/QtInitializeTestFonts.cpp:
(WebKit::initializeTestFonts):
* QtTestBrowser/QtTestBrowser.pro:
* WebKitTestRunner/InjectedBundle/Target.pri:
* qmake/mkspecs/features/features.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109890 268f45cc-cd09-0410-ab3c-d52691b4dbfc