WebKit-https.git
4 years agoMac production build fix attempt after r190155.
rniwa@webkit.org [Wed, 23 Sep 2015 17:00:11 +0000 (17:00 +0000)]
Mac production build fix attempt after r190155.

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAvoid unnecessary ancestor traversal in Range::selectNodeContents()
cdumez@apple.com [Wed, 23 Sep 2015 16:23:25 +0000 (16:23 +0000)]
Avoid unnecessary ancestor traversal in Range::selectNodeContents()
https://bugs.webkit.org/show_bug.cgi?id=149491

Reviewed by Andreas Kling.

Avoid unnecessary ancestor traversal in Range::selectNodeContents().
A DocumentType Node cannot have children, therefore, there is no need
to check if ancestors are docTypes. We now simply check if the current
node is a DocumentType Node, as per the specification:
- https://dom.spec.whatwg.org/#dom-range-selectnodecontents (step 1)

* dom/Range.cpp:
(WebCore::Range::selectNodeContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRange's setStartBefore() / setStartAfter() / setEndBefore() / setEndAfter() do not...
cdumez@apple.com [Wed, 23 Sep 2015 16:21:33 +0000 (16:21 +0000)]
Range's setStartBefore() / setStartAfter() / setEndBefore() / setEndAfter() do not match the specification
https://bugs.webkit.org/show_bug.cgi?id=149490

Reviewed by Andreas Kling.

LayoutTests/imported/w3c:

Rebaseline several W3C DOM tests now that more checks are passing.

* web-platform-tests/dom/ranges/Range-selectNode-expected.txt:
* web-platform-tests/dom/ranges/Range-surroundContents-expected.txt:

Source/WebCore:

Range's setStartBefore() / setStartAfter() / setEndBefore() / setEndAfter()
behavior do not match the DOM specification:
- https://dom.spec.whatwg.org/#dom-range-setstartbefore
- https://dom.spec.whatwg.org/#dom-range-setstartafter
- https://dom.spec.whatwg.org/#dom-range-setendbefore
- https://dom.spec.whatwg.org/#dom-range-setendafter

In particular, instead of step 2:
"If parent is null, throw an InvalidNodeTypeError exception."

Our implementation was doing more checks and throwing exceptions in cases
that the specification does not say we should. We were calling
checkNodeBA() which had restrictions on both the node type and its
root type. This is now replaced by a simple null check on the parent,
as per the specification.

Firefox's behavior matches the specification.

No new tests, already covered by existing tests.

* dom/Range.cpp:
(WebCore::Range::setStartAfter):
(WebCore::Range::setEndBefore):
(WebCore::Range::setEndAfter):
(WebCore::Range::setStartBefore):
(WebCore::Range::cloneRange): Deleted.
(WebCore::Range::selectNode): Deleted.
(WebCore::Range::selectNodeContents): Deleted.
(WebCore::Range::absoluteTextRects): Deleted.
* dom/Range.h:

LayoutTests:

Update test that expected an assertion in a case where we no longer
throw. I checked that Firefox does not throw in this case either.

* fast/dom/Range/range-exceptions-expected.txt:
* fast/dom/Range/script-tests/range-exceptions.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, rolling out r190168.
commit-queue@webkit.org [Wed, 23 Sep 2015 16:06:00 +0000 (16:06 +0000)]
Unreviewed, rolling out r190168.
https://bugs.webkit.org/show_bug.cgi?id=149502

it broke debug builds. (Requested by zalan on #webkit).

Reverted changeset:

"HTMLOutputElement.htmlFor should be settable"
https://bugs.webkit.org/show_bug.cgi?id=149418
http://trac.webkit.org/changeset/190168

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, rolling out r190160.
commit-queue@webkit.org [Wed, 23 Sep 2015 15:34:16 +0000 (15:34 +0000)]
Unreviewed, rolling out r190160.
https://bugs.webkit.org/show_bug.cgi?id=149501

media/media-controls-play-button-updates.html fails on
Yosemite and EFL (Requested by zalan on #webkit).

Reverted changeset:

"[GTK] playbutton in media controls is not changed when it is
clicked."
https://bugs.webkit.org/show_bug.cgi?id=149113
http://trac.webkit.org/changeset/190160

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoTry to fix build.
antti@apple.com [Wed, 23 Sep 2015 15:23:39 +0000 (15:23 +0000)]
Try to fix build.

* css/DocumentRuleSets.h:
* inspector/InspectorInstrumentation.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFix sorting
antti@apple.com [Wed, 23 Sep 2015 15:07:09 +0000 (15:07 +0000)]
Fix sorting

* dom/DOMAllInOne.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoSplit author style code out from DocumentStyleSheetCollection
antti@apple.com [Wed, 23 Sep 2015 15:04:16 +0000 (15:04 +0000)]
Split author style code out from DocumentStyleSheetCollection
https://bugs.webkit.org/show_bug.cgi?id=149446

Reviewed by Andreas Kling.

Shadow trees may have their own author style. Factor the related code out so we can use
it outside the document context.

DocumentStyleSheetCollection is replaced by two classes:

AuthorStyleSheets - author stylesheets and mutation optimization code
ExtensionStyleSheets - user stylesheets, injected author stylesheets, content extension stylesheets

* WebCore.xcodeproj/project.pbxproj:
* contentextensions/ContentExtensionsBackend.cpp:
(WebCore::ContentExtensions::ContentExtensionsBackend::processContentExtensionRulesForLoad):
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::didMutateRules):
* css/DocumentRuleSets.cpp:
(WebCore::DocumentRuleSets::~DocumentRuleSets):
(WebCore::DocumentRuleSets::initUserStyle):
* css/DocumentRuleSets.h:
(WebCore::DocumentRuleSets::sibling):
(WebCore::DocumentRuleSets::uncommonAttribute):
* css/InspectorCSSOMWrappers.cpp:
(WebCore::InspectorCSSOMWrappers::collectFromStyleSheets):
(WebCore::InspectorCSSOMWrappers::getWrapperForRuleInSheets):
(WebCore::InspectorCSSOMWrappers::collectFromDocumentStyleSheetCollection): Deleted.
* css/InspectorCSSOMWrappers.h:
* css/StyleResolver.cpp:
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::appendAuthorStyleSheets):
* css/StyleSheetList.cpp:
(WebCore::StyleSheetList::styleSheets):
(WebCore::StyleSheetList::detachFromDocument):
(WebCore::StyleSheetList::length):
* dom/AuthorStyleSheets.cpp: Added.
(WebCore::AuthorStyleSheets::AuthorStyleSheets):
(WebCore::AuthorStyleSheets::combineCSSFeatureFlags):
(WebCore::AuthorStyleSheets::resetCSSFeatureFlags):
(WebCore::AuthorStyleSheets::addAuthorSheet):
(WebCore::AuthorStyleSheets::removePendingSheet):
(WebCore::AuthorStyleSheets::addStyleSheetCandidateNode):
(WebCore::AuthorStyleSheets::removeStyleSheetCandidateNode):
(WebCore::AuthorStyleSheets::collectActiveStyleSheets):
(WebCore::AuthorStyleSheets::analyzeStyleSheetChange):
(WebCore::filterEnabledNonemptyCSSStyleSheets):
(WebCore::AuthorStyleSheets::updateActiveStyleSheets):
(WebCore::AuthorStyleSheets::activeStyleSheetsForInspector):
(WebCore::AuthorStyleSheets::activeStyleSheetsContains):
(WebCore::AuthorStyleSheets::detachFromDocument):
* dom/AuthorStyleSheets.h: Added.
(WebCore::AuthorStyleSheets::activeStyleSheets):
(WebCore::AuthorStyleSheets::styleSheets):
(WebCore::AuthorStyleSheets::styleSheetsForStyleSheetList):
(WebCore::AuthorStyleSheets::pendingUpdateType):
(WebCore::AuthorStyleSheets::setPendingUpdateType):
(WebCore::AuthorStyleSheets::flushPendingUpdates):
(WebCore::AuthorStyleSheets::preferredStylesheetSetName):
(WebCore::AuthorStyleSheets::selectedStylesheetSetName):
(WebCore::AuthorStyleSheets::setPreferredStylesheetSetName):
(WebCore::AuthorStyleSheets::setSelectedStylesheetSetName):
(WebCore::AuthorStyleSheets::addPendingSheet):
(WebCore::AuthorStyleSheets::hasPendingSheets):
(WebCore::AuthorStyleSheets::usesFirstLineRules):
(WebCore::AuthorStyleSheets::usesFirstLetterRules):
(WebCore::AuthorStyleSheets::usesRemUnits):
(WebCore::AuthorStyleSheets::setUsesRemUnit):
(WebCore::AuthorStyleSheets::usesStyleBasedEditability):
(WebCore::AuthorStyleSheets::setUsesStyleBasedEditability):
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::setCompatibilityMode):
(WebCore::Document::recalcStyle):
(WebCore::Document::createStyleResolver):
(WebCore::Document::fontsNeedUpdate):
(WebCore::Document::usesStyleBasedEditability):
(WebCore::Document::processHttpEquiv):
(WebCore::Document::preferredStylesheetSet):
(WebCore::Document::selectedStylesheetSet):
(WebCore::Document::setSelectedStylesheetSet):
(WebCore::Document::scheduleOptimizedStyleSheetUpdate):
(WebCore::Document::styleResolverChanged):
(WebCore::Document::haveStylesheetsLoaded):
(WebCore::Document::getCachedLocale):
* dom/Document.h:
(WebCore::Document::authorStyleSheets):
(WebCore::Document::extensionStyleSheets):
(WebCore::Document::gotoAnchorNeededAfterStylesheetsLoad):
(WebCore::Document::setGotoAnchorNeededAfterStylesheetsLoad):
(WebCore::Document::styleSheetCollection): Deleted.
* dom/DocumentStyleSheetCollection.cpp: Removed.
* dom/DocumentStyleSheetCollection.h: Removed.
* dom/ExtensionStyleSheets.cpp: Copied from Source/WebCore/dom/DocumentStyleSheetCollection.cpp.
(WebCore::ExtensionStyleSheets::ExtensionStyleSheets):
(WebCore::ExtensionStyleSheets::pageUserSheet):
(WebCore::ExtensionStyleSheets::clearPageUserSheet):
(WebCore::ExtensionStyleSheets::updatePageUserSheet):
(WebCore::ExtensionStyleSheets::injectedUserStyleSheets):
(WebCore::ExtensionStyleSheets::injectedAuthorStyleSheets):
(WebCore::ExtensionStyleSheets::updateInjectedStyleSheetCache):
(WebCore::ExtensionStyleSheets::invalidateInjectedStyleSheetCache):
(WebCore::ExtensionStyleSheets::addUserSheet):
(WebCore::ExtensionStyleSheets::addDisplayNoneSelector):
(WebCore::ExtensionStyleSheets::maybeAddContentExtensionSheet):
(WebCore::ExtensionStyleSheets::styleResolverChangedTimerFired):
(WebCore::ExtensionStyleSheets::detachFromDocument):
(WebCore::DocumentStyleSheetCollection::DocumentStyleSheetCollection): Deleted.
(WebCore::DocumentStyleSheetCollection::combineCSSFeatureFlags): Deleted.
(WebCore::DocumentStyleSheetCollection::resetCSSFeatureFlags): Deleted.
(WebCore::DocumentStyleSheetCollection::pageUserSheet): Deleted.
(WebCore::DocumentStyleSheetCollection::clearPageUserSheet): Deleted.
(WebCore::DocumentStyleSheetCollection::updatePageUserSheet): Deleted.
(WebCore::DocumentStyleSheetCollection::injectedUserStyleSheets): Deleted.
(WebCore::DocumentStyleSheetCollection::injectedAuthorStyleSheets): Deleted.
(WebCore::DocumentStyleSheetCollection::updateInjectedStyleSheetCache): Deleted.
(WebCore::DocumentStyleSheetCollection::invalidateInjectedStyleSheetCache): Deleted.
(WebCore::DocumentStyleSheetCollection::addAuthorSheet): Deleted.
(WebCore::DocumentStyleSheetCollection::addUserSheet): Deleted.
(WebCore::DocumentStyleSheetCollection::addDisplayNoneSelector): Deleted.
(WebCore::DocumentStyleSheetCollection::maybeAddContentExtensionSheet): Deleted.
(WebCore::DocumentStyleSheetCollection::styleResolverChangedTimerFired): Deleted.
(WebCore::DocumentStyleSheetCollection::removePendingSheet): Deleted.
(WebCore::DocumentStyleSheetCollection::addStyleSheetCandidateNode): Deleted.
(WebCore::DocumentStyleSheetCollection::removeStyleSheetCandidateNode): Deleted.
(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets): Deleted.
(WebCore::DocumentStyleSheetCollection::analyzeStyleSheetChange): Deleted.
(WebCore::filterEnabledNonemptyCSSStyleSheets): Deleted.
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets): Deleted.
(WebCore::DocumentStyleSheetCollection::activeStyleSheetsForInspector): Deleted.
(WebCore::DocumentStyleSheetCollection::activeStyleSheetsContains): Deleted.
(WebCore::DocumentStyleSheetCollection::detachFromDocument): Deleted.
* dom/ExtensionStyleSheets.h: Copied from Source/WebCore/dom/DocumentStyleSheetCollection.h.
(WebCore::ExtensionStyleSheets::documentUserStyleSheets):
(WebCore::DocumentStyleSheetCollection::styleSheetsForStyleSheetList): Deleted.
(WebCore::DocumentStyleSheetCollection::activeAuthorStyleSheets): Deleted.
(WebCore::DocumentStyleSheetCollection::documentUserStyleSheets): Deleted.
(WebCore::DocumentStyleSheetCollection::documentAuthorStyleSheets): Deleted.
(WebCore::DocumentStyleSheetCollection::pendingUpdateType): Deleted.
(WebCore::DocumentStyleSheetCollection::setPendingUpdateType): Deleted.
(WebCore::DocumentStyleSheetCollection::flushPendingUpdates): Deleted.
(WebCore::DocumentStyleSheetCollection::preferredStylesheetSetName): Deleted.
(WebCore::DocumentStyleSheetCollection::selectedStylesheetSetName): Deleted.
(WebCore::DocumentStyleSheetCollection::setPreferredStylesheetSetName): Deleted.
(WebCore::DocumentStyleSheetCollection::setSelectedStylesheetSetName): Deleted.
(WebCore::DocumentStyleSheetCollection::addPendingSheet): Deleted.
(WebCore::DocumentStyleSheetCollection::hasPendingSheets): Deleted.
(WebCore::DocumentStyleSheetCollection::usesFirstLineRules): Deleted.
(WebCore::DocumentStyleSheetCollection::usesFirstLetterRules): Deleted.
(WebCore::DocumentStyleSheetCollection::usesRemUnits): Deleted.
(WebCore::DocumentStyleSheetCollection::setUsesRemUnit): Deleted.
(WebCore::DocumentStyleSheetCollection::usesStyleBasedEditability): Deleted.
(WebCore::DocumentStyleSheetCollection::setUsesStyleBasedEditability): Deleted.
* dom/InlineStyleSheetOwner.cpp:
(WebCore::InlineStyleSheetOwner::insertedIntoDocument):
(WebCore::InlineStyleSheetOwner::removedFromDocument):
(WebCore::InlineStyleSheetOwner::clearDocumentData):
(WebCore::InlineStyleSheetOwner::childrenChanged):
(WebCore::InlineStyleSheetOwner::createSheet):
(WebCore::InlineStyleSheetOwner::sheetLoaded):
(WebCore::InlineStyleSheetOwner::startLoadingDynamicSheet):
* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::~ProcessingInstruction):
(WebCore::ProcessingInstruction::nodeName):
(WebCore::ProcessingInstruction::checkStyleSheet):
(WebCore::ProcessingInstruction::sheetLoaded):
(WebCore::ProcessingInstruction::insertedInto):
(WebCore::ProcessingInstruction::removedFrom):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::~HTMLLinkElement):
(WebCore::HTMLLinkElement::insertedInto):
(WebCore::HTMLLinkElement::removedFrom):
(WebCore::HTMLLinkElement::addPendingSheet):
(WebCore::HTMLLinkElement::removePendingSheet):
* html/HTMLQuoteElement.cpp:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::collectAllDocumentStyleSheets):
(WebCore::InspectorCSSAgent::buildObjectForRule):
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::commitData):
* page/Page.cpp:
(WebCore::Page::userStyleSheetLocationChanged):
(WebCore::Page::setUserContentController):
* page/PageGroup.cpp:
* page/UserContentController.cpp:
(WebCore::UserContentController::invalidateInjectedStyleSheetCacheInAllFrames):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::lineHeight):
(WebCore::RenderBlock::getFirstLetter):
* rendering/RenderElement.cpp:
(WebCore::RenderElement::uncachedFirstLineStyle):
(WebCore::RenderElement::cachedFirstLineStyle):
* rendering/RenderElement.h:
(WebCore::RenderElement::firstLineStyle):
(WebCore::RenderElement::setAncestorLineBoxDirty):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::updateAlwaysCreateLineBoxes):
(WebCore::RenderInline::lineHeight):
* rendering/RenderLineBreak.cpp:
(WebCore::RenderLineBreak::lineHeight):
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::verticalPositionForBox):
* style/StyleResolveTree.cpp:
(WebCore::Style::resolveLocal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoHTMLOutputElement.htmlFor should be settable
cdumez@apple.com [Wed, 23 Sep 2015 14:32:36 +0000 (14:32 +0000)]
HTMLOutputElement.htmlFor should be settable
https://bugs.webkit.org/show_bug.cgi?id=149418

Reviewed by Ryosuke Niwa.

Source/WebCore:

HTMLOutputElement.htmlFor should be settable as per the latest HTML
specification:
- https://html.spec.whatwg.org/multipage/forms.html#the-output-element

It is supposed to call DOMSettableTokenList.setValue() with the input
String. This patch adds support for this by adding [PutForwards=value]
IDL extended attribute.

This aligns our behavior with the specification, Firefox and Chrome.

No new tests, already covered by existing test.

* html/AttributeDOMTokenList.cpp:
(WebCore::AttributeDOMTokenList::AttributeDOMTokenList):
(WebCore::AttributeDOMTokenList::attributeValueChanged):
* html/AttributeDOMTokenList.h:
- Have AttributeDOMTokenList subclass DOMSettableTokenList instead of
DOMTokenList so that it can be used in places where the IDL expects
us to return a DOMSettableTokenList (e.g. HTMLOutputElement.htmlFor).
- Mark AttributeDOMTokenList as fast allocated.

* html/DOMSettableTokenList.cpp:
(WebCore::DOMSettableTokenList::setValue):
* html/DOMSettableTokenList.h:
- Move setValue() from DOMTokenList to DOMSettableTokenList
  as it is only needed by DOMSettableTokenList.
- Get rid of the factory function as all call sites are using
  AttributeDOMTokenList now.
- Stop inheriting RefCounted as AttributeDOMTokenList handles its
  own refcounting.

* html/DOMTokenList.cpp:
(WebCore::DOMTokenList::setValueInternal):
* html/DOMTokenList.h:
Rename setValue() to setValueInternal() as this version does not
update the associated attribute value, only the tokens.

* html/HTMLLinkElement.cpp:
* html/HTMLLinkElement.h:
- Have HTMLLinkElement.sizes use an AttributeDOMTokenList instead of
  a DOMSettableTokenList as there is an associated attribute. The
  previous code had a bug has setting HTMLLinkElement.sizes would not
  update the associated 'sizes' attribute. Switching to using
  AttributeDOMTokenList fixes this and a new layout test has been added
  to cover this.
- Create the AttributeDOMTokenList lazily to avoid updating it every
  time the sizes attribute changes until it is actually accessed.

* html/HTMLOutputElement.cpp:
* html/HTMLOutputElement.h:
- Have HTMLLinkElement.htmlFor use an AttributeDOMTokenList instead of
  a DOMSettableTokenList as there is an associated attribute.
- Create the AttributeDOMTokenList lazily to avoid updating it every
  time the sizes attribute changes until it is actually accessed.

* html/HTMLOutputElement.idl:
Add [PutForwards=value] on the htmlFor attribute, as per the
HTML specification.

LayoutTests:

* fast/dom/HTMLLinkElement/sizes-setter.html: Added
* fast/dom/HTMLLinkElement/sizes-setter-expected.txt: Added
Add layout test to make sure that setting HTMLLinkElement.sizes actually
updates the 'sizes' associated attribute.

* fast/dom/HTMLOutputElement/dom-settable-token-list-expected.txt:
* fast/dom/HTMLOutputElement/script-tests/dom-settable-token-list.js:
Update existing layout test now that HTMLOutputElement.htmlFor is
settable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Streams API] Add transform stream general tests
calvaris@igalia.com [Wed, 23 Sep 2015 11:33:41 +0000 (11:33 +0000)]
[Streams API] Add transform stream general tests
https://bugs.webkit.org/show_bug.cgi?id=149267

Reviewed by Darin Adler.

* streams/reference-implementation/transform-stream-expected.txt: Added.
* streams/reference-implementation/transform-stream.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Streams API] Added transform stream error tests
calvaris@igalia.com [Wed, 23 Sep 2015 11:27:58 +0000 (11:27 +0000)]
[Streams API] Added transform stream error tests
https://bugs.webkit.org/show_bug.cgi?id=149266

Reviewed by Darin Adler.

* streams/reference-implementation/transform-stream-errors-expected.txt: Added.
* streams/reference-implementation/transform-stream-errors.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Streams API] Added pipe-through transform stream tests
calvaris@igalia.com [Wed, 23 Sep 2015 11:25:03 +0000 (11:25 +0000)]
[Streams API] Added pipe-through transform stream tests
https://bugs.webkit.org/show_bug.cgi?id=149265

Reviewed by Darin Adler.

* streams/reference-implementation/pipe-through-expected.txt: Added.
* streams/reference-implementation/pipe-through.html: Added.
* streams/reference-implementation/resources/streams-utils.js: Added duckTypedPassThroughTransform function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Streams API] Add count queuing strategy tests for writable streams
calvaris@igalia.com [Wed, 23 Sep 2015 11:23:26 +0000 (11:23 +0000)]
[Streams API] Add count queuing strategy tests for writable streams
https://bugs.webkit.org/show_bug.cgi?id=148303

Reviewed by Darin Adler.

* streams/reference-implementation/count-queuing-strategy-expected.txt: Added new expectations.
* streams/reference-implementation/count-queuing-strategy.html: Added new writable stream tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Streams API] Add byte length queuing strategy tests for writable streams
calvaris@igalia.com [Wed, 23 Sep 2015 11:17:39 +0000 (11:17 +0000)]
[Streams API] Add byte length queuing strategy tests for writable streams
https://bugs.webkit.org/show_bug.cgi?id=148302

Reviewed by Darin Adler.

* streams/reference-implementation/byte-length-queuing-strategy-expected.txt: Added new expectations.
* streams/reference-implementation/byte-length-queuing-strategy.html: Added new writable stream tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Streams API] Add brand checks tests for writable streams
calvaris@igalia.com [Wed, 23 Sep 2015 11:14:50 +0000 (11:14 +0000)]
[Streams API] Add brand checks tests for writable streams
https://bugs.webkit.org/show_bug.cgi?id=148301

Reviewed by Darin Adler.

* streams/reference-implementation/brand-checks-expected.txt: Added new expectations.
* streams/reference-implementation/brand-checks.html: Added new writable stream tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Streams API] bad underlying sinks tests about writable streams
calvaris@igalia.com [Wed, 23 Sep 2015 11:12:58 +0000 (11:12 +0000)]
[Streams API] bad underlying sinks tests about writable streams
https://bugs.webkit.org/show_bug.cgi?id=148295

Reviewed by Darin Adler.

* streams/reference-implementation/bad-underlying-sinks-expected.txt: Added.
* streams/reference-implementation/bad-underlying-sinks.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[GTK] playbutton in media controls is not changed when it is clicked.
changseok.oh@collabora.com [Wed, 23 Sep 2015 11:07:15 +0000 (11:07 +0000)]
[GTK] playbutton in media controls is not changed when it is clicked.
https://bugs.webkit.org/show_bug.cgi?id=149113

Reviewed by Philippe Normand.

Source/WebCore:

When the play button in media controls is clicked, a 'paused' class is added or removed
for the element to update its appearance. Although Document::recalcStyle is triggered
by that class attribute change, the play button is not changed since there is
no difference in styles whether having the 'paused' class or not. Gtk port
does not define the -webkit-media-controls-play-button.paused. To fix this,
-webkit-media-controls-play-button.paused is newly defined with a dummy style,
"position: relative;", which should not change the play button appearance,
but be clearly different in style.

Test: media/media-controls-play-button-updates.html

* css/mediaControlsGtk.css:
(video::-webkit-media-controls-play-button.paused):

LayoutTests:

* media/media-controls-play-button-updates-expected.png: Added.
* media/media-controls-play-button-updates-expected.txt: Added.
* media/media-controls-play-button-updates.html: Added.
* platform/gtk/media/media-controls-play-button-updates-expected.png: Added.
* platform/gtk/media/media-controls-play-button-updates-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Streams API] Add bad strategies writable streams tests
calvaris@igalia.com [Wed, 23 Sep 2015 11:03:08 +0000 (11:03 +0000)]
[Streams API] Add bad strategies writable streams tests
https://bugs.webkit.org/show_bug.cgi?id=148300

Reviewed by Darin Adler.

* streams/reference-implementation/bad-strategies-expected.txt: Added new expectations.
* streams/reference-implementation/bad-strategies.html: Added new writable stream tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Streams API] Change a const in the tee tests
calvaris@igalia.com [Wed, 23 Sep 2015 10:04:24 +0000 (10:04 +0000)]
[Streams API] Change a const in the tee tests
https://bugs.webkit.org/show_bug.cgi?id=148294

Reviewed by Darin Adler.

* streams/reference-implementation/readable-stream-tee.html: Dumb change, replaced a const with var and added
the checkpoint of the spec commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[GTK] media/media-controls-timeline-updates.html timeouts
changseok.oh@collabora.com [Wed, 23 Sep 2015 08:32:59 +0000 (08:32 +0000)]
[GTK] media/media-controls-timeline-updates.html timeouts
https://bugs.webkit.org/show_bug.cgi?id=139363

Reviewed by Philippe Normand.

The default timeout value of gtk port is 6000ms for release build layout tests.
But this is too short to pass some media tests such as media-controls-timeline-updates.html
Let's tweak the test to have shorter test time by seeking.

* media/media-controls-timeline-updates.html:
* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoDisable QuickLook on tvOS
aestes@apple.com [Wed, 23 Sep 2015 07:33:05 +0000 (07:33 +0000)]
Disable QuickLook on tvOS
https://bugs.webkit.org/show_bug.cgi?id=149492
<rdar://problem/22741586>

Reviewed by Dan Bernstein.

Source/WebKit/mac:

We can't use USE(QUICK_LOOK) in a Private header, and postprocess-headers.sh doesn't know how to strip things
that aren't feature flags. So, if QuickLook is disabled, we'll just always define WebQuickLookFileNameKey and
WebQuickLookUTIKey, and we'll also define -quickLookContentForURL: but have it return nil.

* WebView/WebView.mm:
(-[WebView quickLookContentForURL:]):

Source/WTF:

* wtf/Platform.h: Stopped enabling QuickLook on tvOS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Streams API] Implement ReadableStream pipeThrough
youenn.fablet@crf.canon.fr [Wed, 23 Sep 2015 07:24:42 +0000 (07:24 +0000)]
[Streams API] Implement ReadableStream pipeThrough
https://bugs.webkit.org/show_bug.cgi?id=147556

Reviewed by Darin Adler.

Source/JavaScriptCore:

Updating BuiltIns infrastructure to make it reusable from WebCore.
Extracting macros from BuiltinNames and createBuiltinExecutable from BuiltinExecutables.
Updated generate-js-builtins to allow generating builtin CPP/H files in WebCore namespace.

* JavaScriptCore.xcodeproj/project.pbxproj:
* builtins/BuiltinExecutables.cpp:
(JSC::BuiltinExecutables::createDefaultConstructor):
(JSC::BuiltinExecutables::createBuiltinExecutable):
(JSC::createBuiltinExecutable):
(JSC::createExecutableInternal):
* builtins/BuiltinExecutables.h:
* builtins/BuiltinNames.h:
(JSC::BuiltinNames::BuiltinNames): Deleted.
* builtins/BuiltinUtils.h: Extracting code from BuiltinNames and BuiltinExecutables.h.
* bytecode/UnlinkedFunctionExecutable.h:
* generate-js-builtins:
(getFunctions):
(writeIncludeDirectives):

Source/WebCore:

Adding initial support for JS builtins within WebCore.
This patch allows implementing IDL interface methods in JS, by using the new JSBuiltin keyword.
(No support yet for private identifiers, constructors or accessors).
Integration of the built-in executables and names is implemented within WebCoreJSClientData.
Two files are generated for each JS builtin file:
- builtin h/cpp files similar to JSCBuiltins.cpp/.h, generated through WebCore/generate-js-builtins from JavaScriptCore/generate-js-builtins)
- A builtin wrapper file mimicking BuiltinExecutables (generated from WebCore/generate-js-builtins)
Contrary to JSC, each js file is generating its own cpp/h file.
This allows including those files within the JSXX.cpp/.h files generated from the IDL where compilation guard may take effect.

Disabled GObject binding for JSBuiltin methods.

Test: streams/readable-stream-pipeThrough.html

* CMakeLists.txt: Triggering generate-js-builtins for JS files.
* DerivedSources.make: Ditto.
* ForwardingHeaders/builtins/BuiltinUtils.h: Added.
* ForwardingHeaders/bytecode/UnlinkedFunctionExecutable.h: Added.
* ForwardingHeaders/runtime/ConstructAbility.h: Added.
* Modules/streams/ReadableStream.idl: Marking pipeThrough as JS builtin
* Modules/streams/ReadableStream.js: Added.
(pipeThrough):
* bindings/js/JSReadableStreamCustom.cpp:
* bindings/js/WebCoreJSClientData.h: Adding ReadableStreamBuiltinsWrapper to store ReadableStream builtin executable
(WebCore::WebCoreJSClientData::WebCoreJSClientData):
(WebCore::WebCoreJSClientData::readableStreamBuiltins):
(WebCore::initNormalWorldClientData):
* bindings/scripts/CodeGeneratorGObject.pm: Disabled GObject binding for JSBuiltin methods.
* bindings/scripts/CodeGeneratorJS.pm: Adding support for JSBuiltin keyword.
(GetFunctionName):
(GenerateHeader):
(GenerateImplementation):
(GenerateHashTableValueArray):
(ComputeFunctionSpecial):
(UseJSBuiltins):
* bindings/scripts/IDLAttributes.txt: Adding JSBuiltin.
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_js_builtin_method):
(webkit_dom_test_obj_js_builtin_method_with_args):
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/JS/JSTestObj.cpp:
* bindings/scripts/test/JS/JSTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj jsBuiltinMethod]):
(-[DOMTestObj jsBuiltinMethodWithArgs:strArg:objArg:]):
* bindings/scripts/test/TestObj.idl:
* generate-js-builtins: Added.

LayoutTests:

Rebased test that is now passing.
Adding new tests to improve pipeThrough coverage.

* streams/readable-stream-pipeThrough-expected.txt: Added.
* streams/readable-stream-pipeThrough.html: Added.
* streams/reference-implementation/brand-checks-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoGardening: speculative non-JIT build fix after r189999.
mark.lam@apple.com [Wed, 23 Sep 2015 06:43:44 +0000 (06:43 +0000)]
Gardening: speculative non-JIT build fix after r189999.

Not reviewed.

* bytecode/ValueRecovery.h:
(JSC::ValueRecovery::jsValueRegs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoEvent fired on a detached node does not bubble up
rniwa@webkit.org [Wed, 23 Sep 2015 01:42:03 +0000 (01:42 +0000)]
Event fired on a detached node does not bubble up
https://bugs.webkit.org/show_bug.cgi?id=149488

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

Rebaselined a test now that one more test case passes.

* web-platform-tests/dom/events/EventTarget-dispatchEvent-expected.txt:

Source/WebCore:

The bug was caused by an explicit check inside EventPath to match an old Firefox behavior (see r19897).
Since Firefox's behavior has changed to match DOM4: https://dom.spec.whatwg.org/#concept-event-dispatch

Fixed the bug by removing the check. The new behavior matches DO4 and behaviors of Firefox and Chrome.

Test: fast/events/event-propagation-in-detached-tree.html

* dom/EventDispatcher.cpp:
(WebCore::EventPath::EventPath):

LayoutTests:

Added a regression test. Also modified and rebaselined mouseout-dead-node.html added in r19897
since our new behavior matches that of the latest Firefox as well as Chrome.

* fast/events/event-propagation-in-detached-tree-expected.txt: Added.
* fast/events/event-propagation-in-detached-tree.html: Added.
* fast/events/mouseout-dead-node-expected.txt:
* fast/events/mouseout-dead-node.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdd a file of pointer-lock to cmake ports
gyuyoung.kim@webkit.org [Wed, 23 Sep 2015 01:37:42 +0000 (01:37 +0000)]
Add a file of pointer-lock to cmake ports
https://bugs.webkit.org/show_bug.cgi?id=149453

Reviewed by Csaba Osztrogon√°c.

.:

* Source/cmake/OptionsEfl.cmake: Add a ENABLE_POINTER_LOCK.

Source/WebCore:

Some cmake ports will be able to enable POINTER_LOCK. To support it,
this patch adds PointerLockController.cpp, and fix a build break in WK2.

* CMakeLists.txt:

Source/WebKit2:

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::navigateToPDFLinkWithSimulatedClick): Fix a build break.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoGCThreadSharedData is just a bad way of saying Heap
fpizlo@apple.com [Wed, 23 Sep 2015 01:35:49 +0000 (01:35 +0000)]
GCThreadSharedData is just a bad way of saying Heap
https://bugs.webkit.org/show_bug.cgi?id=149435

Reviewed by Mark Lam.

This removes the GCThreadSharedData class and moves its members into Heap. This is a net
simplification since GCThreadSharedData had a 1-to-1 mapping to Heap and the two classes had a
vast contract with a lot of interdependencies. Heap would call a lot of GCThreadSharedData
methods; now a lot of those are inlined since they were only called from the one place in Heap.
This makes it a lot easier to see what is going on. For example, you no longer have to look at
code in two places (Heap and GCThreadSharedData) to figure out the timing and synchronization
of GC phases - all of that code is in Heap now.

This also removes weird indirections in other places. It used to be that a lot of GC helper
classes woud have a pointer to GCThreadSharedData, and then would use that to get to Heap, VM,
and the visitors. Now these helpers just point to Heap.

I think that GCThreadSharedData was only useful for defining the set of things that we need to
know to collect garbage. That's how we decided if something would go into GCThreadSharedData
instead of Heap. But I think that separating things into multiple classes usually makes the
code less hackable, so there should be a very high bar for doing this in a way that produces a
1-to-1 mapping between two classes - where one instance of one of the classes is always paired
with exactly one instance of the other class and vice-versa.

* CMakeLists.txt:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
* JavaScriptCore.xcodeproj/project.pbxproj:
* heap/CopiedSpace.h:
* heap/CopyVisitor.cpp:
(JSC::CopyVisitor::CopyVisitor):
(JSC::CopyVisitor::copyFromShared):
* heap/CopyVisitor.h:
* heap/CopyVisitorInlines.h:
(JSC::CopyVisitor::allocateNewSpaceSlow):
(JSC::CopyVisitor::startCopying):
(JSC::CopyVisitor::doneCopying):
(JSC::CopyVisitor::didCopy):
* heap/GCThread.cpp:
(JSC::GCThread::GCThread):
(JSC::GCThread::waitForNextPhase):
(JSC::GCThread::gcThreadMain):
* heap/GCThread.h:
* heap/GCThreadSharedData.cpp: Removed.
* heap/GCThreadSharedData.h: Removed.
* heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::~Heap):
(JSC::Heap::isPagedOut):
(JSC::Heap::markRoots):
(JSC::Heap::copyBackingStores):
(JSC::Heap::updateObjectCounts):
(JSC::Heap::resetVisitors):
(JSC::Heap::objectCount):
(JSC::Heap::sweepNextLogicallyEmptyWeakBlock):
(JSC::Heap::threadVisitCount):
(JSC::Heap::threadBytesVisited):
(JSC::Heap::threadBytesCopied):
(JSC::Heap::startNextPhase):
(JSC::Heap::endCurrentPhase):
* heap/Heap.h:
* heap/HeapInlines.h:
(JSC::Heap::unregisterWeakGCMap):
(JSC::Heap::getNextBlocksToCopy):
* heap/ListableHandler.h:
* heap/SlotVisitor.cpp:
(JSC::SlotVisitor::SlotVisitor):
(JSC::SlotVisitor::didStartMarking):
(JSC::SlotVisitor::reset):
(JSC::SlotVisitor::donateKnownParallel):
(JSC::SlotVisitor::drain):
(JSC::SlotVisitor::drainFromShared):
(JSC::SlotVisitor::mergeOpaqueRoots):
(JSC::SlotVisitor::harvestWeakReferences):
(JSC::SlotVisitor::finalizeUnconditionalFinalizers):
* heap/SlotVisitor.h:
(JSC::SlotVisitor::markStack):
(JSC::SlotVisitor::isEmpty):
(JSC::SlotVisitor::sharedData): Deleted.
* heap/SlotVisitorInlines.h:
(JSC::SlotVisitor::addWeakReferenceHarvester):
(JSC::SlotVisitor::addUnconditionalFinalizer):
(JSC::SlotVisitor::addOpaqueRoot):
(JSC::SlotVisitor::containsOpaqueRoot):
(JSC::SlotVisitor::containsOpaqueRootTriState):
(JSC::SlotVisitor::opaqueRootCount):
(JSC::SlotVisitor::mergeOpaqueRootsIfNecessary):
(JSC::SlotVisitor::copyLater):
(JSC::SlotVisitor::heap):
(JSC::SlotVisitor::vm):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoMark http/tests/notifications/events.html flaky again (crash/timeout this time).
zalan@apple.com [Wed, 23 Sep 2015 01:35:04 +0000 (01:35 +0000)]
Mark http/tests/notifications/events.html flaky again (crash/timeout this time).

Unreviewed.

* TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: The right sidebar always opens up on breakpoint
commit-queue@webkit.org [Wed, 23 Sep 2015 01:29:36 +0000 (01:29 +0000)]
Web Inspector: The right sidebar always opens up on breakpoint
https://bugs.webkit.org/show_bug.cgi?id=149261

Patch by Devin Rousso <dcrousso+webkit@gmail.com> on 2015-09-22
Reviewed by Timothy Hatcher.

Whenever the debugger was paused, the sidebar was being forced to open.
This has been removed in favor of letting the user decide.

* UserInterface/Base/Main.js:
(WebInspector._debuggerDidPause):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: [ES6] Improve Type Profiler Support for Arrow Functions
sbarati@apple.com [Wed, 23 Sep 2015 00:39:09 +0000 (00:39 +0000)]
Web Inspector: [ES6] Improve Type Profiler Support for Arrow Functions
https://bugs.webkit.org/show_bug.cgi?id=143171

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

We now need to take into account TypeProfilerSearchDescriptor when
hashing results for type profiler queries. Before, we've gotten
away with not doing this because before we would never have a text
collision between a return type text offset and a normal expression text
offset. But, with arrow functions, we will have collisions when
the arrow function doesn't have parens around its single parameter.
I.e: "param => { ... };"

* runtime/TypeProfiler.cpp:
(JSC::TypeProfiler::findLocation):
* runtime/TypeProfiler.h:
(JSC::QueryKey::QueryKey):
(JSC::QueryKey::isHashTableDeletedValue):
(JSC::QueryKey::operator==):
(JSC::QueryKey::hash):
* tests/typeProfiler/arrow-functions.js: Added.

Source/WebInspectorUI:

Esprima and JSC both support arrow functions. We just
need to support it in our AST and do the right things
to include support in the type profiler bits.

* UserInterface/Controllers/TypeTokenAnnotator.js:
(WebInspector.TypeTokenAnnotator.prototype._insertTypeToken):
(WebInspector.TypeTokenAnnotator.prototype._translateToOffsetAfterFunctionParameterList.isLineTerminator):
(WebInspector.TypeTokenAnnotator.prototype._translateToOffsetAfterFunctionParameterList):
* UserInterface/Models/ScriptSyntaxTree.js:
(WebInspector.ScriptSyntaxTree.prototype.containsNonEmptyReturnStatement.removeFunctionsFilter):
(WebInspector.ScriptSyntaxTree.prototype.containsNonEmptyReturnStatement):
(WebInspector.ScriptSyntaxTree.functionReturnDivot):
(WebInspector.ScriptSyntaxTree.prototype._recurse):
(WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
(WebInspector.ScriptSyntaxTree):

LayoutTests:

* inspector/model/parse-script-syntax-tree-expected.txt:
* inspector/model/parse-script-syntax-tree.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoDrop unnecessary ancestor traversal in Range::selectNode()
cdumez@apple.com [Wed, 23 Sep 2015 00:33:21 +0000 (00:33 +0000)]
Drop unnecessary ancestor traversal in Range::selectNode()
https://bugs.webkit.org/show_bug.cgi?id=149482

Reviewed by Ryosuke Niwa.

Drop unnecessary ancestor traversal in Range::selectNode(). It traversed
the ancestors to throw a INVALID_NODE_TYPE_ERR if one of them was a
DocumentType Node. However, it is impossible for a DocumentType Node to
have children.

* dom/Range.cpp:
(WebCore::Range::selectNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, fix argument types in WASMFunctionSyntaxChecker.h.
sukolsak@gmail.com [Wed, 23 Sep 2015 00:27:54 +0000 (00:27 +0000)]
Unreviewed, fix argument types in WASMFunctionSyntaxChecker.h.

* wasm/WASMFunctionSyntaxChecker.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoError message in ContentExtensionError.cpp shouldn't have two spaces between sentences.
bweinstein@apple.com [Tue, 22 Sep 2015 23:51:48 +0000 (23:51 +0000)]
Error message in ContentExtensionError.cpp shouldn't have two spaces between sentences.
https://bugs.webkit.org/show_bug.cgi?id=149479

Reviewed by Andy Estes.

* contentextensions/ContentExtensionError.cpp:
(WebCore::ContentExtensions::contentExtensionErrorCategory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoURL of page visited in private browsing still appears in Activity Monitor after page...
andersca@apple.com [Tue, 22 Sep 2015 23:32:53 +0000 (23:32 +0000)]
URL of page visited in private browsing still appears in Activity Monitor after page is closed
https://bugs.webkit.org/show_bug.cgi?id=149475
rdar://problem/22684521

Reviewed by Dan Bernstein.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::close):
Make sure to call updateActivePages after removing the page from the page map.

* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::updateActivePages):
Don't include pages that have private browsing enabled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRange.surroundContents() should check for partially contained non-Text nodes first
cdumez@apple.com [Tue, 22 Sep 2015 23:14:56 +0000 (23:14 +0000)]
Range.surroundContents() should check for partially contained non-Text nodes first
https://bugs.webkit.org/show_bug.cgi?id=149476

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline existing W3C DOM test now that more checks are passing.

* web-platform-tests/dom/ranges/Range-surroundContents-expected.txt:

Source/WebCore:

Range.surroundContents() should check for partially contained non-Text
nodes first, before checking the type of the newParent parameter:
- https://dom.spec.whatwg.org/#dom-range-surroundcontents (step 1 and 2)

Firefox and Chrome follow the specification.

No new tests, already covered by existing test.

* dom/Range.cpp:
(WebCore::Range::surroundContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, rolling out r190134.
cdumez@apple.com [Tue, 22 Sep 2015 23:06:24 +0000 (23:06 +0000)]
Unreviewed, rolling out r190134.
https://bugs.webkit.org/show_bug.cgi?id=149481

"Seems to cause crashes during garbage collection" (Requested
by cdumez on #webkit).

Reverted changeset:

"HTMLOutputElement.htmlFor should be settable"
https://bugs.webkit.org/show_bug.cgi?id=149418
http://trac.webkit.org/changeset/190134

Patch by Commit Queue <commit-queue@webkit.org> on 2015-09-22

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRange.intersectsNode() does not behave according to the specification when start...
cdumez@apple.com [Tue, 22 Sep 2015 22:27:27 +0000 (22:27 +0000)]
Range.intersectsNode() does not behave according to the specification when start / end are equal
https://bugs.webkit.org/show_bug.cgi?id=148774
<rdar://problem/22571418>

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline W3C Range test now that another check is passing.

* web-platform-tests/dom/ranges/Range-intersectsNode-expected.txt:

Source/WebCore:

Range.intersectsNode() does not behave according to the specification
when start / end are equal:
https://dom.spec.whatwg.org/#dom-range-intersectsnode

The specification says:
"If (parent, offset) is before end and (parent, offset + 1) is after
start, return true."

However, the way we were detecting "is before end" and "is after start"
was flawed in the case where start / end were equal. This is because when
comparePoint() return 0, then it means that the node/offset is not only
equal to start but also equal to end. As such, it is not "after start"
/ "before end".

No new tests, already covered by existing.

* dom/Range.cpp:
(WebCore::Range::intersectsNode):
(WebCore::highestAncestorUnderCommonRoot): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoMark http/tests/notifications/events.html flaky.
zalan@apple.com [Tue, 22 Sep 2015 21:39:59 +0000 (21:39 +0000)]
Mark http/tests/notifications/events.html flaky.
https://bugs.webkit.org/show_bug.cgi?id=149218

Unreviewed.

* TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoHTMLOutputElement.htmlFor should be settable
cdumez@apple.com [Tue, 22 Sep 2015 21:24:28 +0000 (21:24 +0000)]
HTMLOutputElement.htmlFor should be settable
https://bugs.webkit.org/show_bug.cgi?id=149418

Reviewed by Darin Adler.

Source/WebCore:

HTMLOutputElement.htmlFor should be settable as per the latest HTML
specification:
- https://html.spec.whatwg.org/multipage/forms.html#the-output-element

It is supposed to call DOMSettableTokenList.setValue() with the input
String. This patch adds support for this by adding [PutForwards=value]
IDL extended attribute.

This aligns our behavior with the specification, Firefox and Chrome.

No new tests, already covered by existing test.

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::classList):
* dom/Element.cpp:
(WebCore::Element::classList):
* dom/ElementRareData.h:
(WebCore::ElementRareData::setClassList):
* html/AttributeDOMTokenList.h:
* html/DOMSettableTokenList.h:
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::relList):
* html/HTMLAnchorElement.h:
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::relList):
* html/HTMLLinkElement.h:
* html/HTMLOutputElement.cpp:
(WebCore::HTMLOutputElement::HTMLOutputElement):
(WebCore::HTMLOutputElement::parseAttribute):
(WebCore::HTMLOutputElement::childrenChanged): Deleted.
* html/HTMLOutputElement.h:
* html/HTMLOutputElement.idl:

LayoutTests:

Update existing layout test now that HTMLOutputElement.htmlFor is
settable.

* fast/dom/HTMLOutputElement/dom-settable-token-list-expected.txt:
* fast/dom/HTMLOutputElement/script-tests/dom-settable-token-list.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoContentFiltering.AllowDownloadAfterAddData is very flaky
aestes@apple.com [Tue, 22 Sep 2015 21:11:35 +0000 (21:11 +0000)]
ContentFiltering.AllowDownloadAfterAddData is very flaky
https://bugs.webkit.org/show_bug.cgi?id=148885
<rdar://problem/22729563>

Reviewed by Alexey Proskuryakov.

The AllowDownload* tests were relying on -_downloadDidStart: being called before -webView:didFinishNavigation:,
but there is no guarantee of this. For tests that should allow a download, spin the runloop until
-_downloadDidStart: is called. The test will now timeout on failure, but will no longer produce false failures.

* TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
(downloadTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoDemystify why a few text tests depend on threaded scrolling being disabled
timothy_horton@apple.com [Tue, 22 Sep 2015 21:08:40 +0000 (21:08 +0000)]
Demystify why a few text tests depend on threaded scrolling being disabled

* fast/text/combining-character-sequence-vertical.html:
* fast/text/descent-clip-in-scaled-page-expected.html:
* fast/text/descent-clip-in-scaled-page.html:
* fast/text/vertical-quotation-marks.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoGet rid of ENABLE(PARALLEL_GC)
fpizlo@apple.com [Tue, 22 Sep 2015 20:41:25 +0000 (20:41 +0000)]
Get rid of ENABLE(PARALLEL_GC)
https://bugs.webkit.org/show_bug.cgi?id=149436

Reviewed by Mark Lam.

We always enable parallel GC everywhere but Windows, and it doesn't look like it was disabled
there for any good reason. So, get rid of the flag.

Source/JavaScriptCore:

The only effect of this change is that parallel GC will now be enabled on Windows, provided
that the CPU detection finds more than one.

* heap/GCThread.cpp:
(JSC::GCThread::gcThreadMain):
* heap/GCThreadSharedData.cpp:
(JSC::GCThreadSharedData::resetChildren):
(JSC::GCThreadSharedData::childBytesCopied):
(JSC::GCThreadSharedData::GCThreadSharedData):
(JSC::GCThreadSharedData::~GCThreadSharedData):
(JSC::GCThreadSharedData::reset):
(JSC::GCThreadSharedData::didStartMarking):
* heap/Heap.cpp:
(JSC::Heap::converge):
(JSC::Heap::visitWeakHandles):
(JSC::Heap::updateObjectCounts):
(JSC::Heap::resetVisitors):
* heap/MarkedBlock.h:
* heap/SlotVisitor.cpp:
(JSC::SlotVisitor::didStartMarking):
(JSC::SlotVisitor::reset):
(JSC::SlotVisitor::drain):
(JSC::SlotVisitor::drainFromShared):
(JSC::SlotVisitor::mergeOpaqueRoots):
(JSC::JSString::tryHashConsLock):
(JSC::JSString::releaseHashConsLock):
* heap/SlotVisitorInlines.h:
(JSC::SlotVisitor::addOpaqueRoot):
(JSC::SlotVisitor::containsOpaqueRoot):
(JSC::SlotVisitor::containsOpaqueRootTriState):
(JSC::SlotVisitor::opaqueRootCount):
(JSC::SlotVisitor::mergeOpaqueRootsIfNecessary):
* runtime/Options.cpp:
(JSC::computeNumberOfGCMarkers):

Source/WTF:

* wtf/MainThread.cpp:
(WTF::canAccessThreadLocalDataForThread):
(WTF::initializeGCThreads):
(WTF::registerGCThread):
(WTF::isMainThreadOrGCThread):
* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoImplement min and max instructions in WebAssembly
sukolsak@gmail.com [Tue, 22 Sep 2015 20:11:45 +0000 (20:11 +0000)]
Implement min and max instructions in WebAssembly
https://bugs.webkit.org/show_bug.cgi?id=149454

Reviewed by Geoffrey Garen.

This patch implements min and max instructions in WebAssembly.

* tests/stress/wasm-arithmetic-float64.js:
* tests/stress/wasm-arithmetic-int32.js:
* tests/stress/wasm/arithmetic-float64.wasm:
* tests/stress/wasm/arithmetic-int32.wasm:
* wasm/WASMFunctionCompiler.h:
(JSC::WASMFunctionCompiler::buildMinOrMaxI32):
(JSC::WASMFunctionCompiler::buildMinOrMaxF64):
* wasm/WASMFunctionParser.cpp:
(JSC::WASMFunctionParser::parseExpressionI32):
(JSC::WASMFunctionParser::parseMinOrMaxExpressionI32):
(JSC::WASMFunctionParser::parseExpressionF64):
(JSC::WASMFunctionParser::parseMinOrMaxExpressionF64):
* wasm/WASMFunctionParser.h:
* wasm/WASMFunctionSyntaxChecker.h:
(JSC::WASMFunctionSyntaxChecker::buildMinOrMaxI32):
(JSC::WASMFunctionSyntaxChecker::buildMinOrMaxF64):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoGet rid of ENABLE(GGC)
fpizlo@apple.com [Tue, 22 Sep 2015 20:01:15 +0000 (20:01 +0000)]
Get rid of ENABLE(GGC)
https://bugs.webkit.org/show_bug.cgi?id=149472

Reviewed by Mark Hahnenberg and Mark Lam.

Source/JavaScriptCore:

Getting rid of this feature flag allows us to remove a lot of yuck.

* bytecode/CodeBlock.h:
(JSC::CodeBlockSet::mark):
(JSC::ScriptExecutable::forEachCodeBlock):
* bytecode/PolymorphicAccess.cpp:
(JSC::AccessCase::generate):
* dfg/DFGOSRExitCompilerCommon.cpp:
(JSC::DFG::reifyInlinedCallFrames):
(JSC::DFG::osrWriteBarrier):
(JSC::DFG::adjustAndJumpToTarget):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::linkBranches):
(JSC::DFG::SpeculativeJIT::compileStoreBarrier):
(JSC::DFG::SpeculativeJIT::writeBarrier):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::masqueradesAsUndefinedWatchpointIsStillValid):
(JSC::DFG::SpeculativeJIT::selectScratchGPR):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compileBaseValueStoreBarrier):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::writeBarrier):
(JSC::DFG::SpeculativeJIT::moveTrueTo):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compileBaseValueStoreBarrier):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::writeBarrier):
(JSC::DFG::SpeculativeJIT::moveTrueTo):
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::emitStoreBarrier):
* heap/CodeBlockSet.cpp:
(JSC::CodeBlockSet::rememberCurrentlyExecutingCodeBlocks):
(JSC::CodeBlockSet::dump):
* heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::markRoots):
(JSC::Heap::clearRememberedSet):
(JSC::Heap::updateObjectCounts):
(JSC::Heap::flushWriteBarrierBuffer):
(JSC::Heap::shouldDoFullCollection):
(JSC::Heap::addLogicallyEmptyWeakBlock):
* heap/HeapInlines.h:
(JSC::Heap::isWriteBarrierEnabled):
(JSC::Heap::writeBarrier):
(JSC::Heap::reportExtraMemoryAllocated):
(JSC::Heap::reportExtraMemoryVisited):
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::clearMarks):
* heap/MarkedSpace.cpp:
(JSC::MarkedSpace::resetAllocators):
(JSC::MarkedSpace::visitWeakSets):
* heap/MarkedSpace.h:
(JSC::MarkedSpace::didAllocateInBlock):
(JSC::MarkedSpace::objectCount):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emitWriteBarrier):
(JSC::JIT::emitIdentifierCheck):
(JSC::JIT::privateCompilePutByVal):
* llint/LLIntOfflineAsmConfig.h:
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:

Source/WebCore:

No new tests because no new behavior.

* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::commonVM):

Source/WTF:

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agothe toInt32 operation inside DFGSpeculativeJIT.cpp can't throw so we shouldn't emit...
sbarati@apple.com [Tue, 22 Sep 2015 19:33:07 +0000 (19:33 +0000)]
the toInt32 operation inside DFGSpeculativeJIT.cpp can't throw so we shouldn't emit an exceptionCheck after it.
https://bugs.webkit.org/show_bug.cgi?id=149467

Reviewed by Mark Lam.

The callOperation for toInt32 won't store a call site index in the call frame.
Therefore, if this is the first callOperation in the current compilation,
and we emit an exception check inside a try block, we will hit an assertion
saying that we must have DFGCommonData::codeOrigins.size() be > 0 inside
DFGCommonData::lastCallSite(). Therefore, it is imperative that we don't
emit exception checks for callOperations that don't throw exceptions and
don't store a call site index in the call frame.

* dfg/DFGCommonData.cpp:
(JSC::DFG::CommonData::lastCallSite):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoMavericks: Media tests start to time out after a few days of bot uptime
ap@apple.com [Tue, 22 Sep 2015 19:28:55 +0000 (19:28 +0000)]
Mavericks: Media tests start to time out after a few days of bot uptime
https://bugs.webkit.org/show_bug.cgi?id=149468

Reviewed by Chris Dumez.

* Scripts/webkitpy/port/base.py:
* Scripts/webkitpy/port/driver.py:
* Scripts/webkitpy/port/mac.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[CMake] Allow to enable OpenMP support.
clopez@igalia.com [Tue, 22 Sep 2015 19:15:18 +0000 (19:15 +0000)]
[CMake] Allow to enable OpenMP support.
https://bugs.webkit.org/show_bug.cgi?id=149457

Reviewed by Csaba Osztrogon√°c.

* Source/cmake/OptionsCommon.cmake: Add the option USE_OPENMP that
will enable the support for OpenMP. Currently this is only used as
an alternative implementation to native threads for the parallelization
of the SVG filters. But name the option with a generic name (USE_OPENMP)
as it could be also used to enable future features that depend on OpenMP.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoImplement the conditional instruction in WebAssembly
sukolsak@gmail.com [Tue, 22 Sep 2015 18:46:45 +0000 (18:46 +0000)]
Implement the conditional instruction in WebAssembly
https://bugs.webkit.org/show_bug.cgi?id=149451

Reviewed by Geoffrey Garen.

This patch implements the conditional (ternary) instruction in WebAssembly.
This is basically "condition ? exp1 : exp2" in JavaScript.

The use of context.discard() in WASMFunctionParser::parseConditional()
is not ideal. We don't discard anything. We just use it to decrement the
stack top in the WebAssembly baseline JIT. When we optimize the JIT by
storing results directly into the destination like the JavaScript
baseline JIT, the code will look like this:

    ContextExpression temp = context.newTemporary();
    ContextExpression condition = parseExpressionI32(context);
    context.jumpToTargetIf(Context::JumpCondition::Zero, condition, elseTarget);

    parseExpression(context, temp, expressionType);
    context.jumpToTarget(end);

    context.linkTarget(elseTarget);
    parseExpression(context, temp, expressionType);
    context.linkTarget(end);

    return temp;

which looks cleaner than using discard().

* tests/stress/wasm-control-flow.js:
* tests/stress/wasm/control-flow.wasm:
* wasm/WASMFunctionParser.cpp:
(JSC::WASMFunctionParser::parseExpressionI32):
(JSC::WASMFunctionParser::parseExpressionF32):
(JSC::WASMFunctionParser::parseExpressionF64):
(JSC::WASMFunctionParser::parseConditional):
* wasm/WASMFunctionParser.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoMake it more obvious when using an unaccelerated image buffer, and fix a few callers...
timothy_horton@apple.com [Tue, 22 Sep 2015 18:45:54 +0000 (18:45 +0000)]
Make it more obvious when using an unaccelerated image buffer, and fix a few callers who do
https://bugs.webkit.org/show_bug.cgi?id=149428

Reviewed by Simon Fraser and Darin Adler.

* platform/graphics/ImageBuffer.cpp:
(WebCore::ImageBuffer::createCompatibleBuffer):
* platform/graphics/ImageBuffer.h:
(WebCore::ImageBuffer::create):
Make the RenderingMode parameter to ImageBuffer::create non-optional.

* platform/graphics/GraphicsContext.h:
(WebCore::GraphicsContext::renderingMode):
* platform/graphics/GraphicsTypes.h:
Add renderingMode() getter so that every caller doesn't need to do the conversion to RenderingMode.

* css/CSSFilterImageValue.cpp:
(WebCore::CSSFilterImageValue::image):
* html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::LRUImageBufferCache::imageBuffer):
* rendering/shapes/Shape.cpp:
(WebCore::Shape::createRasterShape):
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::createTextTrackRepresentationImage):
* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::putByteArray):
These five callers create unconditionally unaccelerated ImageBuffers which
should probably instead respect the acceleration bit from the context
that the ImageBuffer will eventually be painted into. Bugs have been filed.

* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::createImageBuffer):
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::createCompositingBuffer):
* platform/graphics/CrossfadeGeneratedImage.cpp:
(WebCore::CrossfadeGeneratedImage::drawPattern):
Adjust the argument order and remove defaults which are passed explicitly.

* page/FrameSnapshotting.cpp:
(WebCore::snapshotFrameRect):
Snapshots are (currently) meant to be taken without accelerated drawing.
Make this explicit.

* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::drawPattern):
Make use of createCompatibleBuffer. This caller was previously creating
an unconditionally unaccelerated context!

* platform/graphics/NamedImageGeneratedImage.cpp:
(WebCore::NamedImageGeneratedImage::drawPattern):
Remove a comment.

* platform/graphics/ShadowBlur.cpp:
(WebCore::ScratchBuffer::getScratchBuffer):
ShadowBlur is only used with unaccelerated contexts, so it's OK to hardcode Unaccelerated here.

* platform/graphics/filters/FilterEffect.cpp:
(WebCore::FilterEffect::asImageBuffer):
(WebCore::FilterEffect::createImageBufferResult):
Flip the order of the arguments.

(WebCore::FilterEffect::openCLImageToImageBuffer):
This caller was previously creating an unaccelerated buffer; instead, match the destination buffer.

* rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::allocateBackingStoreIfNeeded):
Adjust the argument order and remove defaults which are passed explicitly.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects):
Get rid of the unneeded renderingMode local, and factor out retrieval of Frame.

* rendering/svg/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::applyClippingToContext):
* rendering/svg/RenderSVGResourceMasker.cpp:
(WebCore::RenderSVGResourceMasker::applyResource):
These two callers are unconditionally creating unaccelerated buffers,
and changing this to match the destination context seems to actually
break things. This needs further investigation.

* rendering/svg/RenderSVGResourceGradient.cpp:
(WebCore::createMaskAndSwapContextForTextGradient):
This caller was previously creating an unaccelerated buffer; instead, match the destination buffer.

* rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::buildPattern):
Make use of renderingMode().

* rendering/svg/SVGRenderingContext.cpp:
(WebCore::SVGRenderingContext::createImageBuffer):
Adjust the argument order.

* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::nativeImageForCurrentFrame):

* WebCoreSupport/WebContextMenuClient.mm:
(WebContextMenuClient::imageForCurrentSharingServicePickerItem):

* Shared/CoordinatedGraphics/threadedcompositor/ThreadSafeCoordinatedSurface.cpp:
(WebKit::ThreadSafeCoordinatedSurface::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoXMLHttpRequest properties should be on the prototype
cdumez@apple.com [Tue, 22 Sep 2015 18:27:26 +0000 (18:27 +0000)]
XMLHttpRequest properties should be on the prototype
https://bugs.webkit.org/show_bug.cgi?id=149465

Reviewed by Darin Adler.

Source/WebCore:

Move most XMLHttpRequest properties to the prototype, as per the Web IDL
specification. This should be web-compatible now that properties on the
prototype are configurable after r190104.

The 'response' / 'responseText' properties are still incorrectly on the
instance because they are currently using a [CustomGetter] in our IDL
and the bindings generator currently does not move such properties to
the prototype.

Test:
fast/xmlhttprequest/xmlhttprequest-properties-prototype.html
js/dom/xhr-prototype-define-property.html

* bindings/scripts/CodeGeneratorJS.pm:
(InterfaceRequiresAttributesOnInstanceForCompatibility): Deleted.

LayoutTests:

Add layout test to check that XMLHttpRequest properties are on the
prototype and have the right properties (enumerable and configurable).

* fast/xmlhttprequest/xmlhttprequest-properties-prototype-expected.txt: Added.
* fast/xmlhttprequest/xmlhttprequest-properties-prototype.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, add myself to the committers list.
n_wang@apple.com [Tue, 22 Sep 2015 17:54:12 +0000 (17:54 +0000)]
Unreviewed, add myself to the committers list.

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[WK2][NetworkCache] New entry bodies remain in dirty memory after being written to...
akling@apple.com [Tue, 22 Sep 2015 17:48:28 +0000 (17:48 +0000)]
[WK2][NetworkCache] New entry bodies remain in dirty memory after being written to disk.
<https://webkit.org/b/149463>

Reviewed by Antti Koivisto.

Call msync(MS_ASYNC) on cache entry bodies after writing their data to a
memory-mapped file. This turns the previously dirty memory into clean memory,
reducing our effective footprint.

I previously believed this would happen automatically when the kernel finds
itself under memory pressure, around the same time as it starts dropping
volatile pages. Turns out that's not the case. Even under considerable pressure,
we never flush this memory to file. So let's take care of it ourselves.

If this ends up generating more IO activity than we're comfortable with on some
scenario, we can look at throttling.

* NetworkProcess/cache/NetworkCacheData.cpp:
(WebKit::NetworkCache::Data::mapToFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoDrop support for legacy EntityReference DOM Node type
cdumez@apple.com [Tue, 22 Sep 2015 17:17:12 +0000 (17:17 +0000)]
Drop support for legacy EntityReference DOM Node type
https://bugs.webkit.org/show_bug.cgi?id=149348

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline W3C DOM test now that more checks are passing.

* web-platform-tests/dom/historical-expected.txt:

Source/WebCore:

Drop support for legacy EntityReference DOM Node type.

EntityReference has been dropped from the DOM specification:
- https://dom.spec.whatwg.org/#dom-core-changes

EntityReference is not supported in Firefox:
- https://developer.mozilla.org/en-US/docs/Web/API/EntityReference
- https://developer.mozilla.org/en-US/docs/Web/API/NodeIterator.expandEntityReferences
- https://developer.mozilla.org/en-US/docs/Web/API/TreeWalker.expandEntityReferences

Chrome dropped support for EntityReference a while back (May 2013):
- EntityReference: https://code.google.com/p/chromium/issues/detail?id=226628
- NodeFilter / TreeWalker.expandEntityReferences:
  - https://groups.google.com/a/chromium.org/d/msg/blink-dev/-ZO3eja4maA/86T13XJwQpUJ
  - https://src.chromium.org/viewvc/blink?view=rev&revision=185771

IE also dropped support for EntityReference Nodes:
https://msdn.microsoft.com/library/ff974819(v=vs.85).aspx (Remarks section)

No new tests, already covered by existing test.

* DerivedSources.cpp:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* bindings/gobject/WebKitDOMPrivate.cpp:
(WebKit::wrap): Deleted.
* bindings/js/JSNodeCustom.cpp:
(WebCore::createWrapperInline): Deleted.
* bindings/objc/DOM.mm:
(kitClass): Deleted.
* bindings/scripts/CodeGeneratorGObject.pm:
(SkipFunction): Skip webkit_dom_document_create_entity_reference until Carlos fixes it.
* dom/Attr.cpp:
(WebCore::Attr::childTypeAllowed):
(WebCore::Attr::childrenChanged): Deleted.
* dom/Attr.h:
* dom/ContainerNode.cpp:
(WebCore::checkAcceptChild): Deleted.
(WebCore::checkAcceptChildGuaranteedNodeTypes): Deleted.
(WebCore::ContainerNode::removeChild): Deleted.
* dom/Document.cpp:
(WebCore::Document::createEntityReference):
(WebCore::Document::createNodeIterator):
(WebCore::Document::createTreeWalker):
(WebCore::Document::createEditingTextNode): Deleted.
(WebCore::Document::importNode): Deleted.
(WebCore::Document::adoptNode): Deleted.
(WebCore::Document::scheduleForcedStyleRecalc): Deleted.
(WebCore::Document::scheduleStyleRecalc): Deleted.
(WebCore::Document::childTypeAllowed): Deleted.
(WebCore::Document::canAcceptChild): Deleted.
* dom/Document.h:
* dom/Document.idl:
* dom/DocumentFragment.cpp:
(WebCore::DocumentFragment::childTypeAllowed): Deleted.
* dom/Element.cpp:
(WebCore::Element::childTypeAllowed): Deleted.
* dom/EntityReference.cpp:
(WebCore::EntityReference::EntityReference):
* dom/EntityReference.h:
* dom/EntityReference.idl:
* dom/Node.cpp:
(WebCore::Node::setNodeValue):
(WebCore::Node::dumpStatistics): Deleted.
(WebCore::Node::childNodes): Deleted.
(WebCore::Node::lastDescendant): Deleted.
(WebCore::Node::isDescendantOf): Deleted.
(WebCore::Node::textContent): Deleted.
(WebCore::Node::ancestorElement): Deleted.
(WebCore::hashPointer): Deleted.
* dom/Node.h:
(WebCore::Node::isDocumentTypeNode): Deleted.
* dom/NodeIterator.cpp:
(WebCore::NodeIterator::NodeIterator):
* dom/NodeIterator.h:
(WebCore::NodeIterator::create):
* dom/NodeIterator.idl:
* dom/Range.cpp:
(WebCore::Range::checkDeleteExtract):
(WebCore::lengthOfContentsInNode): Deleted.
(WebCore::Range::processContentsBetweenOffsets): Deleted.
(WebCore::Range::insertNode): Deleted.
(WebCore::Range::checkNodeWOffset): Deleted.
(WebCore::Range::checkNodeBA): Deleted.
(WebCore::Range::cloneRange): Deleted.
(WebCore::Range::selectNode): Deleted.
(WebCore::Range::selectNodeContents): Deleted.
(WebCore::Range::surroundContents): Deleted.
(WebCore::Range::shadowRoot): Deleted.
(WebCore::Range::pastLastNode): Deleted.
(WebCore::Range::absoluteBoundingBox): Deleted.
(WebCore::Range::absoluteTextRects): Deleted.
* dom/Range.h:
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::childTypeAllowed): Deleted.
* dom/Traversal.cpp:
(WebCore::NodeIteratorBase::NodeIteratorBase):
(WebCore::NodeIteratorBase::acceptNode): Deleted.
* dom/Traversal.h:
(WebCore::NodeIteratorBase::expandEntityReferences):
* dom/TreeWalker.cpp:
(WebCore::TreeWalker::TreeWalker):
* dom/TreeWalker.h:
(WebCore::TreeWalker::create):
* dom/TreeWalker.idl:
* editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::appendStartMarkup): Deleted.
* xml/XPathUtil.cpp:
(WebCore::XPath::isValidContextNode): Deleted.

Source/WebKit2:

Drop handling EntityReference Nodes.

* WebProcess/InjectedBundle/API/mac/WKDOMInternals.mm:
(WebKit::WKDOMNodeClass): Deleted.
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::isAssistableElement):

LayoutTests:

Drop several outdated DOM compliance tests. Update / Rebaseline others.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, rebaseline several W3C html tests on iOS after r190106 and r190085.
cdumez@apple.com [Tue, 22 Sep 2015 16:13:34 +0000 (16:13 +0000)]
Unreviewed, rebaseline several W3C html tests on iOS after r190106 and r190085.

* platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt:
* platform/ios-simulator/imported/w3c/web-platform-tests/html/semantics/interfaces-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed 32-bit Yosemite build fix.
eric.carlson@apple.com [Tue, 22 Sep 2015 16:13:10 +0000 (16:13 +0000)]
Unreviewed 32-bit Yosemite build fix.

* platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm:
(WebCore::WebAudioSourceProviderAVFObjC::provideInput):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, rebaseline fast/table/rowindex.html after r190099.
cdumez@apple.com [Tue, 22 Sep 2015 16:11:06 +0000 (16:11 +0000)]
Unreviewed, rebaseline fast/table/rowindex.html after r190099.

* platform/efl/fast/table/rowindex-expected.txt:
* platform/gtk/fast/table/rowindex-expected.txt:
* platform/win/fast/table/rowindex-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[MediaStream Mac] implement WebAudioSourceProvider
eric.carlson@apple.com [Tue, 22 Sep 2015 14:31:24 +0000 (14:31 +0000)]
[MediaStream Mac] implement WebAudioSourceProvider
https://bugs.webkit.org/show_bug.cgi?id=149419

Reviewed by Darin Adler.

* Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::audioSourceProvider): New.
* Modules/mediastream/MediaStreamTrack.h:

* Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::createMediaStreamSource): Rewrite.

* Modules/webaudio/MediaStreamAudioDestinationNode.cpp:
(WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode): We know the Vector
  size, so reserve capacity.

* Modules/webaudio/MediaStreamAudioSource.cpp:
(WebCore::MediaStreamAudioSource::audioSourceProvider): Add.
* Modules/webaudio/MediaStreamAudioSource.h:
(WebCore::MediaStreamAudioSource::~MediaStreamAudioSource):
(WebCore::MediaStreamAudioSource::deviceId):
(WebCore::MediaStreamAudioSource::setDeviceId):
(WebCore::MediaStreamAudioSource::useIDForTrackID): Deleted.

* Modules/webaudio/MediaStreamAudioSourceNode.cpp:
(WebCore::MediaStreamAudioSourceNode::create): Context and track can't be null so take references.
(WebCore::MediaStreamAudioSourceNode::MediaStreamAudioSourceNode): Ditto.
(WebCore::MediaStreamAudioSourceNode::~MediaStreamAudioSourceNode): Clear provider client.
(WebCore::MediaStreamAudioSourceNode::setFormat): Create a resampler when necessary.
(WebCore::MediaStreamAudioSourceNode::process): Process.
(WebCore::MediaStreamAudioSourceNode::reset): Deleted.
* Modules/webaudio/MediaStreamAudioSourceNode.h:
(WebCore::MediaStreamAudioSourceNode::mediaStream):
(WebCore::MediaStreamAudioSourceNode::audioSourceProvider): Deleted.

* WebCore.xcodeproj/project.pbxproj: Add WebAudioSourceProviderAVFObjC.cpp/h.

* platform/mediastream/MediaStreamTrackPrivate.cpp:
(WebCore::MediaStreamTrackPrivate::audioSourceProvider): New, passthrough to source.
* platform/mediastream/MediaStreamTrackPrivate.h:
* platform/mediastream/RealtimeMediaSource.h:
(WebCore::RealtimeMediaSource::audioSourceProvider):

* platform/mediastream/mac/AVAudioCaptureSource.h:
* platform/mediastream/mac/AVAudioCaptureSource.mm:
(WebCore::AVAudioCaptureSource::audioSourceProvider): New.
* platform/mediastream/mac/AVCaptureDeviceManager.mm:
* platform/mediastream/mac/AVMediaCaptureSource.h:
* platform/mediastream/mac/AVMediaCaptureSource.mm:
(WebCore::AVMediaCaptureSource::audioSourceProvider): Assert, this shouldn't be reachable.

* platform/mediastream/mac/WebAudioSourceProviderAVFObjC.h: Added.
* platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm: Added.
(WebCore::WebAudioSourceProviderAVFObjC::create):
(WebCore::WebAudioSourceProviderAVFObjC::WebAudioSourceProviderAVFObjC):
(WebCore::WebAudioSourceProviderAVFObjC::~WebAudioSourceProviderAVFObjC):
(WebCore::WebAudioSourceProviderAVFObjC::startProducingData):
(WebCore::WebAudioSourceProviderAVFObjC::stopProducingData):
(WebCore::WebAudioSourceProviderAVFObjC::provideInput):
(WebCore::WebAudioSourceProviderAVFObjC::setClient):
(WebCore::operator==):
(WebCore::operator!=):
(WebCore::WebAudioSourceProviderAVFObjC::prepare):
(WebCore::WebAudioSourceProviderAVFObjC::unprepare):
(WebCore::WebAudioSourceProviderAVFObjC::process):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoSource/WebCore:
commit-queue@webkit.org [Tue, 22 Sep 2015 13:59:38 +0000 (13:59 +0000)]
Source/WebCore:
CurrentTime on mediaController is set as 0 when playback is completed.
https://bugs.webkit.org/show_bug.cgi?id=149154

Patch by sangdeug.kim <sangdeug.kim@samsung.com> on 2015-09-22
Reviewed by Eric Carlson.

Test : media/media-controller-time-clamp.html

* html/MediaController.cpp:
(MediaController::setCurrentTime):
(MediaController::updatePlaybackState):
* html/MediaController.h:

LayoutTests:
Add test for checking currentTime of mediacontroller when playback is completed.
https://bugs.webkit.org/show_bug.cgi?id=149154

Patch by sangdeug.kim <sangdeug.kim@samsung.com> on 2015-09-22
Reviewed by Eric Carlson.

* media/media-controller-time-clamp-expected.txt:
* media/media-controller-time-clamp.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, rolling out r189616.
commit-queue@webkit.org [Tue, 22 Sep 2015 12:21:31 +0000 (12:21 +0000)]
Unreviewed, rolling out r189616.
https://bugs.webkit.org/show_bug.cgi?id=149456

suspected cause of multiple regressions (Requested by kling on
#webkit).

Reverted changeset:

"[JSC] Weak should only accept cell pointees."
https://bugs.webkit.org/show_bug.cgi?id=148955
http://trac.webkit.org/changeset/189616

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFix the all-in-one build with GCC
ossy@webkit.org [Tue, 22 Sep 2015 10:06:07 +0000 (10:06 +0000)]
Fix the all-in-one build with GCC
https://bugs.webkit.org/show_bug.cgi?id=148428

Reviewed by Darin Adler.

Removed Source/WebCore/inspector/InspectorIndexedDBAgent.cpp from the all-in-one build.

* WebCore.vcxproj/WebCore.vcxproj:
* inspector/InspectorAllInOne.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFix warnings in IDLParser.pm
ossy@webkit.org [Tue, 22 Sep 2015 09:32:12 +0000 (09:32 +0000)]
Fix warnings in IDLParser.pm
https://bugs.webkit.org/show_bug.cgi?id=149406

Reviewed by Alex Christensen.

* bindings/scripts/IDLParser.pm:
(typeHasNullableSuffix):
(typeRemoveNullableSuffix):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: update Esprima to latest version
sbarati@apple.com [Tue, 22 Sep 2015 08:26:50 +0000 (08:26 +0000)]
Web Inspector: update Esprima to latest version
https://bugs.webkit.org/show_bug.cgi?id=148960

Reviewed by Joseph Pecoraro.

Source/WebInspectorUI:

Esprima version 2.6 further supports ES6. We're
updating to it so we can support more ES6 features
in our script syntax tree.

* UserInterface/External/Esprima/LICENSE:
* UserInterface/External/Esprima/esprima.js:
* UserInterface/Models/ScriptSyntaxTree.js:
(WebInspector.ScriptSyntaxTree.prototype._gatherIdentifiersInDeclaration.gatherIdentifiers):
(WebInspector.ScriptSyntaxTree.prototype._gatherIdentifiersInDeclaration):
(WebInspector.ScriptSyntaxTree.prototype._recurse):
(WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
(WebInspector.ScriptSyntaxTree):

LayoutTests:

* inspector/model/parse-script-syntax-tree-expected.txt:
* inspector/model/parse-script-syntax-tree.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoinvalidateSlotAssignments should trigger style recalc
rniwa@webkit.org [Tue, 22 Sep 2015 08:17:09 +0000 (08:17 +0000)]
invalidateSlotAssignments should trigger style recalc
https://bugs.webkit.org/show_bug.cgi?id=149447

Reviewed by Antti Koivisto.

Source/WebCore:

Invalidate the render tree of a shadow host when a new child is inserted, an existing child is removed,
or slot attribute of a child is modified.

No new tests. Covered by existing tests added in r190101.

* dom/Element.cpp:
(WebCore::Element::childrenChanged): Call invalidateSlotAssignments or invalidateDefaultSlotAssignments
depending on the types of children being inserted or removed since text nodes can only be assigned into
a default slot.
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::invalidateSlotAssignments):
(WebCore::ShadowRoot::invalidateDefaultSlotAssignments): Added.
* dom/ShadowRoot.h:
* dom/SlotAssignment.cpp:
(WebCore::SlotAssignment::invalidate): Reconstruct the render tree for the whole host. We can optimize
in the future by only invalidating active slot elements instead.
(WebCore::SlotAssignment::invalidateDefaultSlot): Added.
* dom/SlotAssignment.h:

LayoutTests:

Removed failing expectations from newly passing tests.

Also added test cases for inserting and removing text nodes, and modified the style recalc tests
to force layout between each DOM change to test case separately.

* fast/shadow-dom/shadow-layout-after-host-child-changes.html:
* fast/shadow-dom/shadow-layout-after-inserting-or-removing-host-child.html:
* fast/shadow-dom/shadow-layout-after-slot-changes.html:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: Basic Block Annotations and Type Profiler annotations wrong for script...
sbarati@apple.com [Tue, 22 Sep 2015 07:35:27 +0000 (07:35 +0000)]
Web Inspector: Basic Block Annotations and Type Profiler annotations wrong for script with "class" with default constructor
https://bugs.webkit.org/show_bug.cgi?id=149248

Reviewed by Mark Lam.

We keep track of which functions have and have not
executed so we can show visually, inside the inspector,
which functions have and have not executed. With a default
constructor, our parser parses code that isn't in the actual
JavaScript source code of the user. Our parser would then
give us a range of starting at "1" to "1 + default constructor length"
as being the text range of a function. But, this would then pollute
actual source code that was at these ranges.

Therefore, we should treat these default constructor source
codes as having "invalid" ranges. We use [UINT_MAX, UINT_MAX]
as the invalid range. This range has the effect of not polluting
valid ranges inside the source code.

* bytecode/UnlinkedFunctionExecutable.cpp:
(JSC::UnlinkedFunctionExecutable::unlinkedCodeBlockFor):
(JSC::UnlinkedFunctionExecutable::setInvalidTypeProfilingOffsets):
* bytecode/UnlinkedFunctionExecutable.h:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitNewDefaultConstructor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[EFL] Build break when DEVELOPER_MODE is OFF
ryuan.choi@navercorp.com [Tue, 22 Sep 2015 07:29:44 +0000 (07:29 +0000)]
[EFL] Build break when DEVELOPER_MODE is OFF
https://bugs.webkit.org/show_bug.cgi?id=149448

Reviewed by Gyuyoung Kim.

Since r187191, DatabaseProcessMainUnix is missing in symbol filter.

* Source/cmake/eflsymbols.filter:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agotime element should use HTMLTimeElement interface
cdumez@apple.com [Tue, 22 Sep 2015 06:25:02 +0000 (06:25 +0000)]
time element should use HTMLTimeElement interface
https://bugs.webkit.org/show_bug.cgi?id=148840
<rdar://problem/22586690>

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline W3C HTML test now that more checks are passing.

* web-platform-tests/html/semantics/text-level-semantics/the-time-element/001-expected.txt:

Source/WebCore:

Time element should be an instance of HTMLTimeElement instead of generic
HTMLElement:
https://html.spec.whatwg.org/multipage/semantics.html#the-time-element

Firefox exposes HTMLTimeElement. This patch aligns our behavior with
the specification and Firefox.

No new tests, already covered by existing test.

* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* html/HTMLElementsAllInOne.cpp:
* html/HTMLTagNames.in:
* html/HTMLTimeElement.cpp: Added.
(WebCore::HTMLTimeElement::create):
(WebCore::HTMLTimeElement::HTMLTimeElement):
* html/HTMLTimeElement.h: Added.
* html/HTMLTimeElement.idl: Added.

LayoutTests:

Rebaseline existing test now that HTMLTimeElement is exposed on the
global Window object.

* js/dom/global-constructors-attributes-expected.txt:
* platform/efl/js/dom/global-constructors-attributes-expected.txt:
* platform/gtk/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
* platform/mac/js/dom/global-constructors-attributes-expected.txt:
* platform/win/js/dom/global-constructors-attributes-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoImplement the comma instruction in WebAssembly
sukolsak@gmail.com [Tue, 22 Sep 2015 06:01:14 +0000 (06:01 +0000)]
Implement the comma instruction in WebAssembly
https://bugs.webkit.org/show_bug.cgi?id=149425

Reviewed by Geoffrey Garen.

This patch implements the comma instruction in WebAssembly. The comma
instruction evaluates the left operand and then the right operand and
returns the value of the right operand.

* tests/stress/wasm-comma.js: Added.
(shouldBe):
* wasm/WASMFunctionCompiler.h:
(JSC::WASMFunctionCompiler::discard):
* wasm/WASMFunctionParser.cpp:
(JSC::WASMFunctionParser::parseExpressionI32):
(JSC::WASMFunctionParser::parseExpressionF32):
(JSC::WASMFunctionParser::parseExpressionF64):
(JSC::WASMFunctionParser::parseComma):
* wasm/WASMFunctionParser.h:
* wasm/WASMFunctionSyntaxChecker.h:
(JSC::WASMFunctionSyntaxChecker::discard):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoDOM attributes on prototypes should be configurable
cdumez@apple.com [Tue, 22 Sep 2015 05:36:53 +0000 (05:36 +0000)]
DOM attributes on prototypes should be configurable
https://bugs.webkit.org/show_bug.cgi?id=134364

Reviewed by Sam Weinig.

Source/WebCore:

DOM attributes on prototypes should be configurable as per the Web IDL
specification:
https://heycam.github.io/webidl/#es-attributes

This patch aligns our behavior with the specification and Firefox.

Test: fast/dom/attributes-configurable.html

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateAttributesHashTable):

LayoutTests:

Add a layout test to confirm that attributes on prototypes are configurable.

* fast/dom/attributes-configurable-expected.txt: Added.
* fast/dom/attributes-configurable.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAlways use the compiler's CAS implementation and get rid of ENABLE(COMPARE_AND_SWAP)
fpizlo@apple.com [Tue, 22 Sep 2015 04:34:19 +0000 (04:34 +0000)]
Always use the compiler's CAS implementation and get rid of ENABLE(COMPARE_AND_SWAP)
https://bugs.webkit.org/show_bug.cgi?id=149438

Reviewed by Mark Lam.

Source/JavaScriptCore:

* heap/HeapInlines.h:
(JSC::Heap::reportExtraMemoryVisited):
(JSC::Heap::deprecatedReportExtraMemory):

Source/WebCore:

No new tests because no new behavior.

* platform/text/TextBreakIterator.cpp:
(WebCore::compareAndSwapNonSharedCharacterBreakIterator):
(WebCore::NonSharedCharacterBreakIterator::NonSharedCharacterBreakIterator):

Source/WTF:

* wtf/Atomics.h: Make weakCompareAndSwap() just forward to the system CAS via WTF::Atomic.
(WTF::weakCompareAndSwap):
(WTF::weakCompareAndSwapUIntPtr): Deleted.
(WTF::weakCompareAndSwapSize): Deleted.
* wtf/Bitmap.h: Small changes to use the new API.
(WTF::WordType>::concurrentTestAndSet):
* wtf/Platform.h: Remove ENABLE(COMPARE_AND_SWAP)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAllow DataDetectors to pre-filter telephone number menu items
timothy_horton@apple.com [Tue, 22 Sep 2015 04:27:09 +0000 (04:27 +0000)]
Allow DataDetectors to pre-filter telephone number menu items
https://bugs.webkit.org/show_bug.cgi?id=149444
<rdar://problem/19286320>

Reviewed by Sam Weinig.

Source/WebCore:

* platform/spi/mac/DataDetectorsSPI.h:
Add some SPI.

Source/WebKit2:

* Platform/mac/MenuUtilities.mm:
(WebKit::menuItemForTelephoneNumber):
(WebKit::menuForTelephoneNumber):
Let DataDetectors know what kind of items we want, so that they can avoid
some unnecessary work in cases where we were just going to throw away the items anyway.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdd some style recalc tests for shadow DOM
rniwa@webkit.org [Tue, 22 Sep 2015 04:01:29 +0000 (04:01 +0000)]
Add some style recalc tests for shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=149445

Reviewed by Antti Koivisto.

Add tests to make sure we trigger necessary style recalc.

* fast/shadow-dom/shadow-layout-after-attach-shadow-expected.html: Copied from LayoutTests/fast/shadow-dom/css-scoping-shadow-root-hides-children-expected.html.
* fast/shadow-dom/shadow-layout-after-attach-shadow.html: Added.
* fast/shadow-dom/shadow-layout-after-host-child-changes-expected.html: Copied from LayoutTests/fast/shadow-dom/css-scoping-shadow-root-hides-children-expected.html.
* fast/shadow-dom/shadow-layout-after-host-child-changes.html: Added.
* fast/shadow-dom/shadow-layout-after-inserting-or-removing-host-child-expected.html: Copied from LayoutTests/fast/shadow-dom/css-scoping-shadow-root-hides-children-expected.html.
* fast/shadow-dom/shadow-layout-after-inserting-or-removing-host-child.html: Added.
* fast/shadow-dom/shadow-layout-after-slot-changes-expected.html: Copied from LayoutTests/fast/shadow-dom/css-scoping-shadow-root-hides-children-expected.html.
* fast/shadow-dom/shadow-layout-after-slot-changes.html: Added.
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agohttps://bugs.webkit.org/show_bug.cgi?id=149415
ap@apple.com [Tue, 22 Sep 2015 03:06:04 +0000 (03:06 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=149415
REGRESSION (r182648): UIWebView does not set location.hash synchronously
<rdar://problem/22169467>

Reviewed by Darin Adler.

* fast/loader/location-hash-user-gesture-expected.txt: Added.
* fast/loader/location-hash-user-gesture.html: Added.
* platform/ios-simulator-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUpdate HTMLTableRowElement.rowIndex to behave according to the specification
cdumez@apple.com [Tue, 22 Sep 2015 02:57:44 +0000 (02:57 +0000)]
Update HTMLTableRowElement.rowIndex to behave according to the specification
https://bugs.webkit.org/show_bug.cgi?id=148842
<rdar://problem/22586914>

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline W3C HTML test now that one more check is passing.

* web-platform-tests/html/semantics/tabular-data/the-tr-element/rowIndex-expected.txt:

Source/WebCore:

Update HTMLTableRowElement.rowIndex to behave according to the
specification:
https://html.spec.whatwg.org/multipage/tables.html#dom-tr-rowindex

In particular, rowIndex no longer returns -1 for <tr> elements that are
direct children of the table Element. Also,<tr> Elements in all <thead> /
<tfoot> children of the table Element now get a rowIndex, as per the
specification:
- https://html.spec.whatwg.org/multipage/tables.html#dom-table-rows

Previously, only <tr> elements in the first <thead> and the first <tbody>
children of the table would get a rowIndex.

Also, we now abort early and return -1 if the row is a grand-child of a
table element but its direct parent is not a <thead> / <tbody> / <tfoot>.
This avoid unnecessary traversal and matches the specification.

The code is refactored a bit to leverage HTMLTableElement.rows(), as
per the specification:
"return the index of the tr element in that table element's rows collection"

Previously, we would duplicate the table traversal logic. This
simplifies the code and fixes a bug as the traversal logic was slightly
different here and in HTMLTableRowsCollection. Because of this, only
<tr> elements in the first <thead> / <tfoot> would get a rowIndex.
Performance should be similar.

No new tests, already covered by existing test.

* html/HTMLTableRowElement.cpp:
(WebCore::HTMLTableRowElement::rowIndex):
(WebCore::HTMLTableRowElement::sectionRowIndex): Deleted.
(WebCore::HTMLTableRowElement::insertCell): Deleted.

LayoutTests:

Rebaseline existing test because rows in all <thead> / <tfoot> children
of the <table> Element now get a rowIndex.

* platform/mac/fast/table/rowindex-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdd more rendering tests for shadow DOM
rniwa@webkit.org [Tue, 22 Sep 2015 02:26:28 +0000 (02:26 +0000)]
Add more rendering tests for shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=149437

Reviewed by Antti Koivisto.

Added various tests for shadow tree rendering as well as tests for :host pseudo class and ::slotted pseudo element.

* fast/shadow-dom/css-scoping-shadow-assigned-node-with-before-after-expected.html: Copied from LayoutTests/fast/shadow-dom/css-scoping-shadow-root-hides-children-expected.html.
* fast/shadow-dom/css-scoping-shadow-assigned-node-with-before-after.html: Added.
* fast/shadow-dom/css-scoping-shadow-assigned-node-with-rules-expected.html: Copied from LayoutTests/fast/shadow-dom/css-scoping-shadow-root-hides-children-expected.html.
* fast/shadow-dom/css-scoping-shadow-assigned-node-with-rules.html: Added.
* fast/shadow-dom/css-scoping-shadow-host-functional-rule-expected.html: Copied from LayoutTests/fast/shadow-dom/css-scoping-shadow-root-hides-children-expected.html.
* fast/shadow-dom/css-scoping-shadow-host-functional-rule.html: Added.
* fast/shadow-dom/css-scoping-shadow-host-rule-expected.html: Copied from LayoutTests/fast/shadow-dom/css-scoping-shadow-root-hides-children-expected.html.
* fast/shadow-dom/css-scoping-shadow-host-rule.html: Added.
* fast/shadow-dom/css-scoping-shadow-host-with-before-after-expected.html: Copied from LayoutTests/fast/shadow-dom/css-scoping-shadow-root-hides-children-expected.html.
* fast/shadow-dom/css-scoping-shadow-host-with-before-after.html: Added.
* fast/shadow-dom/css-scoping-shadow-slot-display-override-expected.html: Copied from LayoutTests/fast/shadow-dom/css-scoping-shadow-root-hides-children-expected.html.
* fast/shadow-dom/css-scoping-shadow-slot-display-override.html: Added.
* fast/shadow-dom/css-scoping-shadow-slotted-rule-expected.html: Copied from LayoutTests/fast/shadow-dom/css-scoping-shadow-root-hides-children-expected.html.
* fast/shadow-dom/css-scoping-shadow-slotted-rule.html: Added.
* fast/shadow-dom/css-scoping-shadow-with-outside-rules-expected.html: Copied from LayoutTests/fast/shadow-dom/css-scoping-shadow-root-hides-children-expected.html.
* fast/shadow-dom/css-scoping-shadow-with-outside-rules.html: Added.
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFix release builds with security assertion after r190007.
rniwa@webkit.org [Tue, 22 Sep 2015 01:27:54 +0000 (01:27 +0000)]
Fix release builds with security assertion after r190007.

* dom/DocumentOrderedMap.cpp:
* dom/DocumentOrderedMap.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agofunctionProtoFuncToString should not rely on typeProfilingEndOffset()
sbarati@apple.com [Tue, 22 Sep 2015 01:21:47 +0000 (01:21 +0000)]
functionProtoFuncToString should not rely on typeProfilingEndOffset()
https://bugs.webkit.org/show_bug.cgi?id=149429

Reviewed by Geoffrey Garen.

We should be able to freely change typeProfilingEndOffset()
without worrying we will break Function.prototype.toString.

* runtime/FunctionPrototype.cpp:
(JSC::functionProtoFuncToString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Threaded Compositor] Modified to use reference of GraphicsContext instead of pointer
yoon@igalia.com [Tue, 22 Sep 2015 00:51:41 +0000 (00:51 +0000)]
[Threaded Compositor] Modified to use reference of GraphicsContext instead of pointer
https://bugs.webkit.org/show_bug.cgi?id=149399

Reviewed by Darin Adler.

This fixes build failure after r189144

Source/WebCore:

* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::tiledBackingStorePaint):
* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
* platform/graphics/texmap/coordinated/CoordinatedImageBacking.cpp:
* platform/graphics/texmap/coordinated/CoordinatedSurface.h:
* platform/graphics/texmap/coordinated/Tile.cpp:
(WebCore::Tile::paintToSurfaceContext):
* platform/graphics/texmap/coordinated/Tile.h:
* platform/graphics/texmap/coordinated/TiledBackingStoreClient.h:
* platform/graphics/texmap/coordinated/UpdateAtlas.cpp:

Source/WebKit2:

* Shared/CoordinatedGraphics/threadedcompositor/ThreadSafeCoordinatedSurface.cpp:
(WebKit::ThreadSafeCoordinatedSurface::paintToSurface):
(WebKit::ThreadSafeCoordinatedSurface::beginPaint):
(WebKit::ThreadSafeCoordinatedSurface::endPaint):
* Shared/CoordinatedGraphics/threadedcompositor/ThreadSafeCoordinatedSurface.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Win] Unreviewed build fix.
bfulgham@apple.com [Tue, 22 Sep 2015 00:38:14 +0000 (00:38 +0000)]
[Win] Unreviewed build fix.

* WebKit.vcxproj/WebKit/WebKitApple.props: We need to link against
libdispatch on Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoThe binding for getDistributedNodes unnecessarily makes a vector of nodes
rniwa@webkit.org [Tue, 22 Sep 2015 00:26:06 +0000 (00:26 +0000)]
The binding for getDistributedNodes unnecessarily makes a vector of nodes
https://bugs.webkit.org/show_bug.cgi?id=149434

Reviewed by Darin Adler.

Added a jsArray for const Vector<T*>* so that we can generate the binding code for getDistributedNodes()
without having to create Vector<RefPtr<Node>> out of Vector<Node*>*.

* bindings/js/JSDOMBinding.h:
(WebCore::jsArray): Added.
* html/HTMLSlotElement.cpp:
(WebCore::HTMLSlotElement::assignedNodes):
(WebCore::HTMLSlotElement::getDistributedNodes): Deleted.
* html/HTMLSlotElement.h:
* html/HTMLSlotElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoREGRESSION (r182648): UIWebView does not set location.hash synchronously
ap@apple.com [Tue, 22 Sep 2015 00:21:22 +0000 (00:21 +0000)]
REGRESSION (r182648): UIWebView does not set location.hash synchronously
https://bugs.webkit.org/show_bug.cgi?id=149415
<rdar://problem/22169467>

Reviewed by Darin Adler.

The problem was that the delegate in UI thread became asynchronous due to calling
into LaunchServices.

* WebCoreSupport/WebFrameLoaderClient.mm: (shouldTryAppLink): Don't attempt app
links for same domain navigations. This check is part of substantially more complicated
logic in WebKit2 that I don't understand, but that should be enough to demonstrate
that this fix is an improvement at least.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoSource/WebCore:
bfulgham@apple.com [Tue, 22 Sep 2015 00:07:40 +0000 (00:07 +0000)]
Source/WebCore:
[Win] Show tiled drawing debug overlay on Windows
https://bugs.webkit.org/show_bug.cgi?id=149426

Reviewed by Dean Jackson.

No new tests: No change in behavior.

* platform/graphics/ca/PlatformCALayer.cpp:
(WebCore::PlatformCALayer::drawRepaintIndicator): Revise signature to accept
a scale value and a font size.
(WebCore::PlatformCALayer::drawTextAtPoint): Revise signature for new arguments.
* platform/graphics/ca/PlatformCALayer.h:
* platform/graphics/ca/TileGrid.cpp:
(WebCore::TileGrid::drawTileMapContents): Removing scaling and text drawing code,
and call common CALayer drawing routine.
* platform/graphics/ca/win/CACFLayerTreeHost.cpp:
(WebCore::CACFLayerTreeHost::create): Switch to nullptr.
(WebCore::CACFLayerTreeHost::CACFLayerTreeHost): Switch to C++14 initializers.
(WebCore::CACFLayerTreeHost::setPage): Added.
(WebCore::CACFLayerTreeHost::rootLayer): Update debug info layer if requested by settings.
(WebCore::CACFLayerTreeHost::layerTreeDidChange): Ditto.
(WebCore::CACFLayerTreeHost::mainFrameTiledBacking): Added.
(WebCore::CACFLayerTreeHost::updateDbugInfoLayer): Added.
* platform/graphics/ca/win/CACFLayerTreeHost.h:
* platform/graphics/ca/win/PlatformCALayerWin.cpp:
(WebCore::PlatformCALayerWin::drawTextAtPoint): Revised signature for new arguments. Use
argument for font size (rather than hard-coded '18'). Adjust font size by passed scale value.
* platform/graphics/ca/win/PlatformCALayerWin.h:

Source/WebKit/win:
[Win] Show tiled drawing debug overlay on Windows
https://bugs.webkit.org/show_bug.cgi?id=149426

Reviewed by Dean Jackson.

* Interfaces/IWebPreferencesPrivate.idl: Add new IWebPreferencesPrivate3 API version
so we can add new methods this cycle.
* WebPreferenceKeysPrivate.h: Add key for 'WebKitShowTiledScrollingIndicator'
* WebPreferences.cpp:
(WebPreferences::QueryInterface): Recognize the new IWebPreferencesPrivate3 API.
(WebPreferences::showTiledScrollingIndicator): Added.
(WebPreferences::setShowTiledScrollingIndicator): Ditto.
* WebPreferences.h:
* WebView.cpp:
(WebView::notifyPreferencesChanged): Update to recognize 'showTiledScrollingIndicator'.
(WebView::setAcceleratedCompositing): Link the CACFLayerTreeHost to the WebCore Page object
so that it can see settings information.

Tools:
Remove 'nullable' to fix older iOS builds.

Patch by Simon Fraser <simon.fraser@apple.com> on 2015-09-21

* WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
(-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRemove old GCC cruft from wtf/StdLibExtras.h
ossy@webkit.org [Tue, 22 Sep 2015 00:05:17 +0000 (00:05 +0000)]
Remove old GCC cruft from wtf/StdLibExtras.h
https://bugs.webkit.org/show_bug.cgi?id=149401

Reviewed by Alex Christensen.

* wtf/StdLibExtras.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoDisable Parental Controls on the Apple TV platform
aestes@apple.com [Mon, 21 Sep 2015 23:22:35 +0000 (23:22 +0000)]
Disable Parental Controls on the Apple TV platform
https://bugs.webkit.org/show_bug.cgi?id=149421

Reviewed by Darin Adler.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, rolling out r190086.
commit-queue@webkit.org [Mon, 21 Sep 2015 23:03:17 +0000 (23:03 +0000)]
Unreviewed, rolling out r190086.
https://bugs.webkit.org/show_bug.cgi?id=149427

Broke LayoutTests/inspector/model/remote-object.htm (Requested
by saamyjoon on #webkit).

Reverted changeset:

"Web Inspector: Basic Block Annotations and Type Profiler
annotations wrong for script with "class" with default
constructor"
https://bugs.webkit.org/show_bug.cgi?id=149248
http://trac.webkit.org/changeset/190086

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRemove 'nullable' to fix older iOS builds.
simon.fraser@apple.com [Mon, 21 Sep 2015 22:50:47 +0000 (22:50 +0000)]
Remove 'nullable' to fix older iOS builds.

* WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
(-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: Basic Block Annotations and Type Profiler annotations wrong for script...
sbarati@apple.com [Mon, 21 Sep 2015 22:42:12 +0000 (22:42 +0000)]
Web Inspector: Basic Block Annotations and Type Profiler annotations wrong for script with "class" with default constructor
https://bugs.webkit.org/show_bug.cgi?id=149248

Reviewed by Mark Lam.

We keep track of which functions have and have not
executed so we can show visually, inside the inspector,
which functions have and have not executed. With a default
constructor, our parser parses code that isn't in the actual
JavaScript source code of the user. Our parser would then
give us a range of starting at "1" to "1 + default constructor length"
as being the text range of a function. But, this would then pollute
actual source code that was at these ranges.

Therefore, we should treat these default constructor source
codes as having "invalid" ranges. We use [UINT_MAX, UINT_MAX]
as the invalid range. This range has the effect of not polluting
valid ranges inside the source code.

* bytecode/UnlinkedFunctionExecutable.cpp:
(JSC::UnlinkedFunctionExecutable::unlinkedCodeBlockFor):
(JSC::UnlinkedFunctionExecutable::setInvalidTypeProfilingOffsets):
* bytecode/UnlinkedFunctionExecutable.h:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitNewDefaultConstructor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[JS Bindings] prototype.constructor should be writable
cdumez@apple.com [Mon, 21 Sep 2015 22:39:25 +0000 (22:39 +0000)]
[JS Bindings] prototype.constructor should be writable
https://bugs.webkit.org/show_bug.cgi?id=149412
<rdar://problem/22545096>

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Rebaseline W3C DOM / HTML tests now that more checks are passing.

* web-platform-tests/dom/interfaces-expected.txt:
* web-platform-tests/html/dom/interfaces-expected.txt:

Source/WebCore:

prototype.constructor should have the following properties:
{ [[Writable]]: true, [[Enumerable]]: false, [[Configurable]]: true }

as per the Web IDL specification:
https://heycam.github.io/webidl/#interface-prototype-object

In WebKit, it is currently not writable. It is writable in Firefox.

Test: fast/events/event-prototype-constructor-properties.html

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateAttributesHashTable):
* bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
* bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
* bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
* bindings/scripts/test/JS/JSTestEventConstructor.cpp:
* bindings/scripts/test/JS/JSTestEventTarget.cpp:
* bindings/scripts/test/JS/JSTestException.cpp:
* bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
* bindings/scripts/test/JS/JSTestInterface.cpp:
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
* bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
* bindings/scripts/test/JS/JSTestNode.cpp:
* bindings/scripts/test/JS/JSTestNondeterministic.cpp:
* bindings/scripts/test/JS/JSTestObj.cpp:
* bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
* bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
* bindings/scripts/test/JS/JSTestTypedefs.cpp:
* bindings/scripts/test/JS/JSattribute.cpp:
* bindings/scripts/test/JS/JSreadonly.cpp:

LayoutTests:

Add layout test that checks that Event.prototype.constructor has the
expected properties and that it is actually writable.

* fast/events/event-prototype-constructor-properties-expected.txt: Added.
* fast/events/event-prototype-constructor-properties.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoHTMLSlotElement should render its assigned nodes
antti@apple.com [Mon, 21 Sep 2015 22:27:28 +0000 (22:27 +0000)]
HTMLSlotElement should render its assigned nodes
https://bugs.webkit.org/show_bug.cgi?id=149242

Reviewed by Ryosuke Niwa.

Source/WebCore:

Support rendering the assigned nodes under HTMLSlotElement.

* dom/SlotAssignment.cpp:
(WebCore::SlotAssignment::assignSlots):

    Move the empty slot finding to the loop as the hash table may mutate.

* html/HTMLSlotElement.cpp:
(WebCore::HTMLSlotElement::attributeChanged):
(WebCore::HTMLSlotElement::assignedNodes):
(WebCore::HTMLSlotElement::getDistributedNodes):
* html/HTMLSlotElement.h:
* style/StyleResolveTree.cpp:
(WebCore::Style::attachBeforeOrAfterPseudoElementIfNeeded):
(WebCore::Style::attachSlot):
(WebCore::Style::attachRenderTree):
(WebCore::Style::detachChildren):
(WebCore::Style::detachShadowRoot):
(WebCore::Style::detachSlot):
(WebCore::Style::detachRenderTree):
(WebCore::Style::resolveChildren):
(WebCore::Style::resolveSlot):
(WebCore::Style::resolveTree):

LayoutTests:

Enable the relevant tests.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Win] Use command-line argument to launch in regular or High DPI mode.
bfulgham@apple.com [Mon, 21 Sep 2015 22:02:38 +0000 (22:02 +0000)]
[Win] Use command-line argument to launch in regular or High DPI mode.
https://bugs.webkit.org/show_bug.cgi?id=149417

Reviewed by Dean Jackson.

* MiniBrowser/win/Common.cpp:
(parseCommandLine): Ignore the '--highDPI' argument. It's used at the
very start of execution, before the MiniBrowser.dll is loaded.
* win/DLLLauncher/DLLLauncherMain.cpp:
(shouldUseHighDPI): Check for '--highDPI', and use this mode if
present. On WinCairo, always use High DPI.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRemove Windows-specific navigator-detached-no-crash-expected.
achristensen@apple.com [Mon, 21 Sep 2015 21:52:09 +0000 (21:52 +0000)]
Remove Windows-specific navigator-detached-no-crash-expected.
https://bugs.webkit.org/show_bug.cgi?id=149414

Reviewed by Filip Pizlo.

When we switched to CMake, NAVIGATOR_HWCONCURRENCY got enabled.
There is no reason to disable it, and the expectations match the default expectations now.

* platform/win/fast/dom/navigator-detached-no-crash-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoImplement call statements and call expressions of type void in WebAssembly
sukolsak@gmail.com [Mon, 21 Sep 2015 21:20:25 +0000 (21:20 +0000)]
Implement call statements and call expressions of type void in WebAssembly
https://bugs.webkit.org/show_bug.cgi?id=149411

Reviewed by Mark Lam.

Call instructions in WebAssembly can be both statements and expressions.
This patch implements call statements. It also implements call
expressions of type void. The only place where call expressions of type
void can occur is the left-hand side of the comma (,) operator, which
will be implemented in a subsequent patch. The comma operator requires
both of its operands to be expressions.

* tests/stress/wasm-calls.js:
* tests/stress/wasm/calls.wasm:
* wasm/WASMConstants.h:
* wasm/WASMFunctionParser.cpp:
(JSC::WASMFunctionParser::parseStatement):
(JSC::WASMFunctionParser::parseExpression):
(JSC::WASMFunctionParser::parseExpressionI32):
(JSC::WASMFunctionParser::parseExpressionF32):
(JSC::WASMFunctionParser::parseExpressionF64):
(JSC::WASMFunctionParser::parseExpressionVoid):
(JSC::WASMFunctionParser::parseCallInternal):
(JSC::WASMFunctionParser::parseCallIndirect):
(JSC::WASMFunctionParser::parseCallImport):
* wasm/WASMFunctionParser.h:
* wasm/WASMReader.cpp:
(JSC::WASMReader::readOpExpressionVoid):
* wasm/WASMReader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agosvg/custom/hidpi-masking-clipping.svg fails with accelerated drawing on
timothy_horton@apple.com [Mon, 21 Sep 2015 21:01:53 +0000 (21:01 +0000)]
svg/custom/hidpi-masking-clipping.svg fails with accelerated drawing on
https://bugs.webkit.org/show_bug.cgi?id=149413
<rdar://problem/22787058>

Reviewed by Dean Jackson.

No new tests, this is covered by existing tests.

* rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::buildPattern):
(WebCore::RenderSVGResourcePattern::applyResource):
(WebCore::RenderSVGResourcePattern::createTileImage):
* rendering/svg/RenderSVGResourcePattern.h:
Make pattern images respect the accelerated bit of the parent GraphicsContext.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoDOMTokenList.add() / remove() should run the update steps even if tokens were not...
cdumez@apple.com [Mon, 21 Sep 2015 20:59:12 +0000 (20:59 +0000)]
DOMTokenList.add() / remove() should run the update steps even if tokens were not modified
https://bugs.webkit.org/show_bug.cgi?id=148780
<rdar://problem/22571794>

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline W3C DOM test now that more checks are passing.

* web-platform-tests/dom/nodes/MutationObserver-attributes-expected.txt:

Source/WebCore:

DOMTokenList.add() / remove() should run the update steps even if tokens
were not modified, as per the DOM specification:
- https://dom.spec.whatwg.org/#dom-domtokenlist-add
- https://dom.spec.whatwg.org/#dom-domtokenlist-remove

The update steps are specified at:
- https://dom.spec.whatwg.org/#concept-DTL-update

This will have several side effects if the DOMTokenList has an associated
attribute. It will overwrite the attribute value which will:
1. Generate a Mutation event.
2. Possibly change the attribute value as the new value is the "ordered
   set serializer for tokens". So it will get rid of extra spaces and
   duplicates in the attribute value.

Firefox already behaves according to the specification.

No new tests, already covered by existing tests.

* html/DOMTokenList.cpp:
(WebCore::DOMTokenList::addInternal):
(WebCore::DOMTokenList::removeInternal):
(WebCore::DOMTokenList::remove): Deleted.

LayoutTests:

Update / Rebaseline several classList /relList tests now that our
behavior has changed.

* fast/dom/HTMLElement/class-list-expected.txt:
* fast/dom/HTMLElement/class-list-quirks-expected.txt:
* fast/dom/HTMLElement/script-tests/class-list.js:
* fast/dom/rel-list-expected.txt:
* fast/dom/rel-list.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoDisable PICTURE_SIZES in Windows CMake build like r189745.
achristensen@apple.com [Mon, 21 Sep 2015 20:57:05 +0000 (20:57 +0000)]
Disable PICTURE_SIZES in Windows CMake build like r189745.
https://bugs.webkit.org/show_bug.cgi?id=149125

* Source/cmake/OptionsWin.cmake:
Do the same thing as r189745.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoJSC should infer property types
fpizlo@apple.com [Mon, 21 Sep 2015 20:49:04 +0000 (20:49 +0000)]
JSC should infer property types
https://bugs.webkit.org/show_bug.cgi?id=148610

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

This change brings recursive type inference to JavaScript object properties in JSC. We check that a
value being stored into a property obeys a property's type before we do the store. If it doesn't,
we broaden the property's type to include the new value. If optimized code was relying on the old
type, we deoptimize that code.

The type system that this supports includes important primitive types like Int32 and Boolean. But
it goes further and also includes a type kind called ObjectWithStructure, which means that we
expect the property to always point to objects with a particular structure. This only works for
leaf structures (i.e. structures that have a valid transition watchpoint set). Invalidation of the
transition set causes the property type to become Object (meaning an object with any structure).
This capability gives us recursive type inference. It's possible for an expression like "o.f.g.h"
to execute without any type checks if .f and .g are both ObjectWithStructure.

The type inference of a property is tracked by an InferredType instance, which is a JSCell. This
means that it manages its own memory. That's convenient. For example, when the DFG is interested in
one of these, it can just list the InferredType as a weak reference in addition to setting a
watchpoint. This ensures that even if the InferredType is dropped by the owning structure, the DFG
won't read a dangling pointer. A mapping from property name to InferredType is implemented by
InferredTypeTable, which is also a JSCell. Each Structure may point to some InferredTypeTable.

This feature causes programs to be happier (run faster without otherwise doing bad things like
using lots of memory) when four conditions hold:

1) A property converges to one of the types that we support.
2) The property is loaded from more frequently than it is stored to.
3) The stores are all cached, so that we statically emit a type check.
4) We don't allocate a lot of meta-data for the property's type.

We maximize the likelihood of (1) by having a rich type system. But having a rich type system means
that a reflective put to a property has to have a large switch over the inferred type to decide how
to do the type check. That's why we need (3). We ensure (3) by having every reflective property
store (i.e. putDirectInternal in any context that isn't PutById) force the inferred type to become
Top. We don't really worry about ensuring (2); this is statistically true for most programs
already.

Probably the most subtle trickery goes into (4). Logically we'd like to say that each
(Structure, Property) maps to its own InferredType. If structure S1 has a transition edge to S2,
then we could ensure that the InferredType I1 where (S1, Property)->I1 has a data flow constraint
to I2 where (S2, Property)->I2. That would work, but it would involve a lot of memory. And when I1
gets invalidated in some way, it would have to tell I2 about it, and then I2 might tell other
InferredType objects downstream. That's madness. So, the first major compromise that we make here
is to say that if some property has some InferredType at some Structure, then anytime we
transition from that Structure, the new Structure shares the same InferredType for that property.
This unifies the type of the property over the entire transition tree starting at the Structure at
which the property was added. But this would still mean that each Structure would have its own
InferredTypeTable. We don't want that because experience with PropertyTable shows that this can be
a major memory hog. So, we don't create an InferredTypeTable until someone adds a property that is
subject to type inference (i.e. it was added non-reflectively), and we share that InferredTypeTable
with the entire structure transition tree rooted at the Structure that had the first inferred
property. We also drop the InferredTypeTable anytime that we do a dictionary transition, and we
don't allow further property type inference if a structure had ever been a dictionary.

This is a 3% speed-up on Octane and a 12% speed-up on Kraken on my setup. It's not a significant
slow-down on any benchmark I ran.

* CMakeLists.txt:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
* JavaScriptCore.xcodeproj/project.pbxproj:
* assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::branchTest64):
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::branchTest64):
(JSC::MacroAssemblerX86_64::test64):
* bytecode/PolymorphicAccess.cpp:
(JSC::AccessCase::generate):
* bytecode/PutByIdFlags.cpp:
(WTF::printInternal):
* bytecode/PutByIdFlags.h:
(JSC::encodeStructureID):
(JSC::decodeStructureID):
* bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFromLLInt):
(JSC::PutByIdStatus::computeFor):
(JSC::PutByIdStatus::computeForStubInfo):
* bytecode/PutByIdVariant.cpp:
(JSC::PutByIdVariant::operator=):
(JSC::PutByIdVariant::replace):
(JSC::PutByIdVariant::transition):
(JSC::PutByIdVariant::setter):
(JSC::PutByIdVariant::attemptToMerge):
(JSC::PutByIdVariant::dumpInContext):
* bytecode/PutByIdVariant.h:
(JSC::PutByIdVariant::newStructure):
(JSC::PutByIdVariant::requiredType):
* bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedInstruction::UnlinkedInstruction):
* bytecode/Watchpoint.h:
(JSC::InlineWatchpointSet::touch):
(JSC::InlineWatchpointSet::isBeingWatched):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::addConstantValue):
(JSC::BytecodeGenerator::emitPutById):
(JSC::BytecodeGenerator::emitDirectPutById):
* dfg/DFGAbstractInterpreter.h:
(JSC::DFG::AbstractInterpreter::filter):
(JSC::DFG::AbstractInterpreter::filterByValue):
* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
(JSC::DFG::AbstractInterpreter<AbstractStateType>::filter):
* dfg/DFGAbstractValue.cpp:
(JSC::DFG::AbstractValue::setType):
(JSC::DFG::AbstractValue::set):
(JSC::DFG::AbstractValue::fixTypeForRepresentation):
(JSC::DFG::AbstractValue::mergeOSREntryValue):
(JSC::DFG::AbstractValue::isType):
(JSC::DFG::AbstractValue::filter):
(JSC::DFG::AbstractValue::filterValueByType):
* dfg/DFGAbstractValue.h:
(JSC::DFG::AbstractValue::setType):
(JSC::DFG::AbstractValue::isType):
(JSC::DFG::AbstractValue::validate):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleConstantInternalFunction):
(JSC::DFG::ByteCodeParser::handleGetByOffset):
(JSC::DFG::ByteCodeParser::handlePutByOffset):
(JSC::DFG::ByteCodeParser::load):
(JSC::DFG::ByteCodeParser::store):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::handlePutById):
* dfg/DFGClobbersExitState.cpp:
(JSC::DFG::clobbersExitState):
* dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
(JSC::DFG::ConstantFoldingPhase::emitGetByOffset):
(JSC::DFG::ConstantFoldingPhase::emitPutByOffset):
(JSC::DFG::ConstantFoldingPhase::addBaseCheck):
* dfg/DFGDesiredInferredType.h: Added.
(JSC::DFG::DesiredInferredType::DesiredInferredType):
(JSC::DFG::DesiredInferredType::operator bool):
(JSC::DFG::DesiredInferredType::object):
(JSC::DFG::DesiredInferredType::expected):
(JSC::DFG::DesiredInferredType::isStillValid):
(JSC::DFG::DesiredInferredType::add):
(JSC::DFG::DesiredInferredType::operator==):
(JSC::DFG::DesiredInferredType::operator!=):
(JSC::DFG::DesiredInferredType::isHashTableDeletedValue):
(JSC::DFG::DesiredInferredType::hash):
(JSC::DFG::DesiredInferredType::dumpInContext):
(JSC::DFG::DesiredInferredType::dump):
(JSC::DFG::DesiredInferredTypeHash::hash):
(JSC::DFG::DesiredInferredTypeHash::equal):
* dfg/DFGDesiredWatchpoints.cpp:
(JSC::DFG::AdaptiveStructureWatchpointAdaptor::add):
(JSC::DFG::InferredTypeAdaptor::add):
(JSC::DFG::DesiredWatchpoints::DesiredWatchpoints):
(JSC::DFG::DesiredWatchpoints::~DesiredWatchpoints):
(JSC::DFG::DesiredWatchpoints::addLazily):
(JSC::DFG::DesiredWatchpoints::consider):
(JSC::DFG::DesiredWatchpoints::reallyAdd):
(JSC::DFG::DesiredWatchpoints::areStillValid):
(JSC::DFG::DesiredWatchpoints::dumpInContext):
* dfg/DFGDesiredWatchpoints.h:
(JSC::DFG::AdaptiveStructureWatchpointAdaptor::dumpInContext):
(JSC::DFG::InferredTypeAdaptor::hasBeenInvalidated):
(JSC::DFG::InferredTypeAdaptor::dumpInContext):
(JSC::DFG::DesiredWatchpoints::isWatched):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::isSafeToLoad):
(JSC::DFG::Graph::inferredTypeFor):
(JSC::DFG::Graph::livenessFor):
(JSC::DFG::Graph::tryGetConstantProperty):
(JSC::DFG::Graph::inferredValueForProperty):
(JSC::DFG::Graph::tryGetConstantClosureVar):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::registerInferredType):
(JSC::DFG::Graph::inferredTypeForProperty):
* dfg/DFGInferredTypeCheck.cpp: Added.
(JSC::DFG::insertInferredTypeCheck):
* dfg/DFGInferredTypeCheck.h: Added.
* dfg/DFGNode.h:
* dfg/DFGObjectAllocationSinkingPhase.cpp:
* dfg/DFGPropertyTypeKey.h: Added.
(JSC::DFG::PropertyTypeKey::PropertyTypeKey):
(JSC::DFG::PropertyTypeKey::operator bool):
(JSC::DFG::PropertyTypeKey::structure):
(JSC::DFG::PropertyTypeKey::uid):
(JSC::DFG::PropertyTypeKey::operator==):
(JSC::DFG::PropertyTypeKey::operator!=):
(JSC::DFG::PropertyTypeKey::hash):
(JSC::DFG::PropertyTypeKey::isHashTableDeletedValue):
(JSC::DFG::PropertyTypeKey::dumpInContext):
(JSC::DFG::PropertyTypeKey::dump):
(JSC::DFG::PropertyTypeKey::deletedUID):
(JSC::DFG::PropertyTypeKeyHash::hash):
(JSC::DFG::PropertyTypeKeyHash::equal):
* dfg/DFGSafeToExecute.h:
(JSC::DFG::SafeToExecuteEdge::operator()):
(JSC::DFG::safeToExecute):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileTypeOf):
(JSC::DFG::SpeculativeJIT::compileCheckStructure):
(JSC::DFG::SpeculativeJIT::compileAllocatePropertyStorage):
(JSC::DFG::SpeculativeJIT::speculateCell):
(JSC::DFG::SpeculativeJIT::speculateCellOrOther):
(JSC::DFG::SpeculativeJIT::speculateObject):
(JSC::DFG::SpeculativeJIT::speculate):
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGStoreBarrierInsertionPhase.cpp:
* dfg/DFGStructureAbstractValue.h:
(JSC::DFG::StructureAbstractValue::at):
(JSC::DFG::StructureAbstractValue::operator[]):
(JSC::DFG::StructureAbstractValue::onlyStructure):
(JSC::DFG::StructureAbstractValue::forEach):
* dfg/DFGUseKind.cpp:
(WTF::printInternal):
* dfg/DFGUseKind.h:
(JSC::DFG::typeFilterFor):
* dfg/DFGValidate.cpp:
(JSC::DFG::Validate::validate):
* ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::compileCheckStructure):
(JSC::FTL::DFG::LowerDFGToLLVM::compileCheckCell):
(JSC::FTL::DFG::LowerDFGToLLVM::compileMultiPutByOffset):
(JSC::FTL::DFG::LowerDFGToLLVM::numberOrNotCellToInt32):
(JSC::FTL::DFG::LowerDFGToLLVM::checkInferredType):
(JSC::FTL::DFG::LowerDFGToLLVM::loadProperty):
(JSC::FTL::DFG::LowerDFGToLLVM::speculate):
(JSC::FTL::DFG::LowerDFGToLLVM::speculateCell):
(JSC::FTL::DFG::LowerDFGToLLVM::speculateCellOrOther):
(JSC::FTL::DFG::LowerDFGToLLVM::speculateMachineInt):
(JSC::FTL::DFG::LowerDFGToLLVM::appendOSRExit):
* jit/AssemblyHelpers.cpp:
(JSC::AssemblyHelpers::decodedCodeMapFor):
(JSC::AssemblyHelpers::branchIfNotType):
(JSC::AssemblyHelpers::purifyNaN):
* jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::branchIfEqual):
(JSC::AssemblyHelpers::branchIfNotCell):
(JSC::AssemblyHelpers::branchIfCell):
(JSC::AssemblyHelpers::branchIfNotOther):
(JSC::AssemblyHelpers::branchIfInt32):
(JSC::AssemblyHelpers::branchIfNotInt32):
(JSC::AssemblyHelpers::branchIfNumber):
(JSC::AssemblyHelpers::branchIfNotNumber):
(JSC::AssemblyHelpers::branchIfEmpty):
(JSC::AssemblyHelpers::branchStructure):
* jit/Repatch.cpp:
(JSC::tryCachePutByID):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
* llint/LowLevelInterpreter.asm:
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:
* runtime/InferredType.cpp: Added.
(JSC::InferredType::create):
(JSC::InferredType::destroy):
(JSC::InferredType::createStructure):
(JSC::InferredType::visitChildren):
(JSC::InferredType::kindForFlags):
(JSC::InferredType::Descriptor::forValue):
(JSC::InferredType::Descriptor::forFlags):
(JSC::InferredType::Descriptor::putByIdFlags):
(JSC::InferredType::Descriptor::merge):
(JSC::InferredType::Descriptor::removeStructure):
(JSC::InferredType::Descriptor::subsumes):
(JSC::InferredType::Descriptor::dumpInContext):
(JSC::InferredType::Descriptor::dump):
(JSC::InferredType::InferredType):
(JSC::InferredType::~InferredType):
(JSC::InferredType::canWatch):
(JSC::InferredType::addWatchpoint):
(JSC::InferredType::dump):
(JSC::InferredType::willStoreValueSlow):
(JSC::InferredType::makeTopSlow):
(JSC::InferredType::set):
(JSC::InferredType::removeStructure):
(JSC::InferredType::InferredStructureWatchpoint::fireInternal):
(JSC::InferredType::InferredStructureFinalizer::finalizeUnconditionally):
(JSC::InferredType::InferredStructure::InferredStructure):
(WTF::printInternal):
* runtime/InferredType.h: Added.
* runtime/InferredTypeTable.cpp: Added.
(JSC::InferredTypeTable::create):
(JSC::InferredTypeTable::destroy):
(JSC::InferredTypeTable::createStructure):
(JSC::InferredTypeTable::visitChildren):
(JSC::InferredTypeTable::get):
(JSC::InferredTypeTable::willStoreValue):
(JSC::InferredTypeTable::makeTop):
(JSC::InferredTypeTable::InferredTypeTable):
(JSC::InferredTypeTable::~InferredTypeTable):
* runtime/InferredTypeTable.h: Added.
* runtime/JSObject.h:
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::putDirectWithoutTransition):
* runtime/Structure.cpp:
(JSC::Structure::materializePropertyMap):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::removePropertyTransition):
(JSC::Structure::startWatchingInternalProperties):
(JSC::Structure::willStoreValueSlow):
(JSC::Structure::visitChildren):
(JSC::Structure::prototypeChainMayInterceptStoreTo):
* runtime/Structure.h:
(JSC::PropertyMapEntry::PropertyMapEntry):
* runtime/StructureInlines.h:
(JSC::Structure::get):
* runtime/VM.cpp:
(JSC::VM::VM):
* runtime/VM.h:
* tests/stress/prop-type-boolean-then-string.js: Added.
* tests/stress/prop-type-int32-then-string.js: Added.
* tests/stress/prop-type-number-then-string.js: Added.
* tests/stress/prop-type-object-or-other-then-string.js: Added.
* tests/stress/prop-type-object-then-string.js: Added.
* tests/stress/prop-type-other-then-string.js: Added.
* tests/stress/prop-type-string-then-object.js: Added.
* tests/stress/prop-type-struct-or-other-then-string.js: Added.
* tests/stress/prop-type-struct-then-object.js: Added.
* tests/stress/prop-type-struct-then-object-opt.js: Added.
* tests/stress/prop-type-struct-then-object-opt-fold.js: Added.
* tests/stress/prop-type-struct-then-object-opt-multi.js: Added.

Source/WTF:

* wtf/HashTable.h:
(WTF::HashTableAddResult::HashTableAddResult): Make it possible to say "HashMap::AddResult result" without assigning anything to it yet.
* wtf/PrintStream.h:
(WTF::printInternal): Beef up printing of some common WTF types, in particular RefPtr<UniquedStringImpl>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago32-bit Mac build fix attempt after r190065.
rniwa@webkit.org [Mon, 21 Sep 2015 20:34:37 +0000 (20:34 +0000)]
32-bit Mac build fix attempt after r190065.

* WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdd some tests for shadow DOM rendering
rniwa@webkit.org [Mon, 21 Sep 2015 20:24:02 +0000 (20:24 +0000)]
Add some tests for shadow DOM rendering
https://bugs.webkit.org/show_bug.cgi?id=149330

Reviewed by Antti Koivisto.

Added some ref tests for new shadow DOM API rendering with failing expectations everywhere.

This is a relanding of r189962 excluding css-scoping-shadow-rendering.html since it has since been added in r190006
as css-scoping-shadow-root-hides-children.html by Antti.

* fast/shadow-dom/css-scoping-shadow-invisible-slot-expected.html: Added.
* fast/shadow-dom/css-scoping-shadow-invisible-slot.html: Added.
* fast/shadow-dom/css-scoping-shadow-slot-expected.html: Added.
* fast/shadow-dom/css-scoping-shadow-slot.html: Added.
* fast/shadow-dom/css-scoping-shadow-with-rules-expected.html: Added.
* fast/shadow-dom/css-scoping-shadow-with-rules.html: Added.
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWebCore shouldn't have to include DFG headers
fpizlo@apple.com [Mon, 21 Sep 2015 20:10:04 +0000 (20:10 +0000)]
WebCore shouldn't have to include DFG headers
https://bugs.webkit.org/show_bug.cgi?id=149337

Reviewed by Michael Saboff.

This does some simple rewiring and outlining of CodeBlock/Heap functionality so that
those headers don't have to include DFG headers. As a result, WebCore no longer includes
DFG headers, except for two fairly innocent ones (DFGCommon.h and DFGCompilationMode.h).
This also changes the Xcode project file so that all but those two headers are Project
rather than Private. So, if WebCore accidentally includes any of them, we'll get a build
error.

The main group of headers that this prevents WebCore from including are the DFGDesired*.h
files and whatever those include. Those headers used to be fairly simple, but now they
are growing in complexity (especially with things like http://webkit.org/b/148610). So,
it makes sense to make sure they don't leak out of JSC.

* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/CallLinkInfo.cpp:
(JSC::CallLinkInfo::CallLinkInfo):
(JSC::CallLinkInfo::~CallLinkInfo):
(JSC::CallLinkInfo::clearStub):
(JSC::CallLinkInfo::visitWeak):
(JSC::CallLinkInfo::setFrameShuffleData):
* bytecode/CallLinkInfo.h:
(JSC::CallLinkInfo::isVarargsCallType):
(JSC::CallLinkInfo::specializationKindFor):
(JSC::CallLinkInfo::frameShuffleData):
(JSC::CallLinkInfo::CallLinkInfo): Deleted.
(JSC::CallLinkInfo::~CallLinkInfo): Deleted.
(JSC::CallLinkInfo::setFrameShuffleData): Deleted.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::getOrAddArrayProfile):
(JSC::CodeBlock::codeOrigins):
(JSC::CodeBlock::numberOfDFGIdentifiers):
(JSC::CodeBlock::identifier):
(JSC::CodeBlock::updateAllPredictionsAndCountLiveness):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::hasExpressionInfo):
(JSC::CodeBlock::hasCodeOrigins):
(JSC::CodeBlock::numberOfIdentifiers):
(JSC::CodeBlock::identifier):
(JSC::CodeBlock::codeOrigins): Deleted.
(JSC::CodeBlock::numberOfDFGIdentifiers): Deleted.
* bytecode/CodeOrigin.h:
* dfg/DFGDesiredIdentifiers.cpp:
* heap/Heap.cpp:
(JSC::Heap::didFinishIterating):
(JSC::Heap::completeAllDFGPlans):
(JSC::Heap::markRoots):
(JSC::Heap::deleteAllCodeBlocks):
* heap/Heap.h:
* heap/HeapInlines.h:
(JSC::Heap::deprecatedReportExtraMemory):
(JSC::Heap::forEachCodeBlock):
(JSC::Heap::forEachProtectedCell):
* runtime/Executable.h:
* runtime/JSCInlines.h:
(JSC::Heap::forEachCodeBlock): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[MediaStream] Clean up MediaStream private interfaces
eric.carlson@apple.com [Mon, 21 Sep 2015 20:09:51 +0000 (20:09 +0000)]
[MediaStream] Clean up MediaStream private interfaces
https://bugs.webkit.org/show_bug.cgi?id=149381

Reviewed by Jer Noble.

No new tests, no functional change.

* Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::create):
(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::clone):
(WebCore::MediaStream::getTrackById):
(WebCore::MediaStream::getAudioTracks):
(WebCore::MediaStream::getVideoTracks):
(WebCore::MediaStream::getTracks):
(WebCore::MediaStream::activeStatusChanged):
(WebCore::MediaStream::didAddTrack):
(WebCore::MediaStream::didRemoveTrack):
(WebCore::MediaStream::registry):
(WebCore::MediaStream::trackVectorForType):
(WebCore::MediaStream::didAddTrackToPrivate): Deleted.
(WebCore::MediaStream::didRemoveTrackFromPrivate): Deleted.
* Modules/mediastream/MediaStream.h:

* Modules/mediastream/MediaStreamRegistry.cpp:
(WebCore::MediaStreamRegistry::lookup):
(WebCore::MediaStreamRegistry::MediaStreamRegistry):
* Modules/mediastream/MediaStreamRegistry.h:

* Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::MediaStreamTrack):
(WebCore::MediaStreamTrack::~MediaStreamTrack):
(WebCore::MediaStreamTrack::kind):
(WebCore::MediaStreamTrack::removeObserver):
(WebCore::MediaStreamTrack::trackEnded):
(WebCore::MediaStreamTrack::trackMutedChanged):
(WebCore::MediaStreamTrack::trackStatesChanged):
(WebCore::MediaStreamTrack::configureTrackRendering):
* Modules/mediastream/MediaStreamTrack.h:

* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::supportsType):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::load):

* platform/graphics/avfoundation/objc/MediaStreamPrivateAVFObjC.h:
* platform/graphics/avfoundation/objc/MediaStreamPrivateAVFObjC.mm:
(WebCore::MediaStreamPrivateAVFObjC::create):
(WebCore::MediaStreamPrivateAVFObjC::MediaStreamPrivateAVFObjC):

* platform/mediastream/MediaStreamPrivate.cpp:
(WebCore::MediaStreamPrivate::create):
(WebCore::MediaStreamPrivate::MediaStreamPrivate):
(WebCore::MediaStreamPrivate::~MediaStreamPrivate):
(WebCore::MediaStreamPrivate::tracks):
(WebCore::MediaStreamPrivate::addTrack):
(WebCore::MediaStreamPrivate::removeTrack):
* platform/mediastream/MediaStreamPrivate.h:
(WebCore::MediaStreamPrivateClient::~MediaStreamPrivateClient):
(WebCore::MediaStreamPrivate::id):
(WebCore::MediaStreamPrivate::active):
(WebCore::MediaStreamPrivate::MediaStreamPrivate): Deleted.
(WebCore::MediaStreamPrivate::~MediaStreamPrivate): Deleted.

* platform/mediastream/MediaStreamTrackPrivate.cpp:
(WebCore::MediaStreamTrackPrivate::MediaStreamTrackPrivate):
(WebCore::MediaStreamTrackPrivate::~MediaStreamTrackPrivate):
(WebCore::MediaStreamTrackPrivate::addObserver):
(WebCore::MediaStreamTrackPrivate::removeObserver):
(WebCore::MediaStreamTrackPrivate::label):
(WebCore::MediaStreamTrackPrivate::endTrack):
(WebCore::MediaStreamTrackPrivate::sourceStopped):
(WebCore::MediaStreamTrackPrivate::sourceMutedChanged):
(WebCore::MediaStreamTrackPrivate::sourceStatesChanged):
(WebCore::MediaStreamTrackPrivate::preventSourceFromStopping):
* platform/mediastream/MediaStreamTrackPrivate.h:
(WebCore::MediaStreamTrackPrivate::Observer::~Observer):
(WebCore::MediaStreamTrackPrivate::ended):
(WebCore::MediaStreamTrackPrivate::startProducingData):
(WebCore::MediaStreamTrackPrivate::stopProducingData):
(WebCore::MediaStreamTrackPrivate::setMuted):
(WebCore::MediaStreamTrackPrivateClient::~MediaStreamTrackPrivateClient): Deleted.
(WebCore::MediaStreamTrackPrivate::setClient): Deleted.
(WebCore::MediaStreamTrackPrivate::client): Deleted.

* platform/mediastream/MediaStreamTrackSourcesRequestClient.h:
(WebCore::TrackSourceInfo::create):
(WebCore::TrackSourceInfo::id):
(WebCore::TrackSourceInfo::label):
(WebCore::TrackSourceInfo::groupId):
(WebCore::TrackSourceInfo::kind):
(WebCore::TrackSourceInfo::TrackSourceInfo):
(WebCore::TrackSourceInfo::deviceId): Deleted.

* platform/mediastream/RealtimeMediaSource.cpp:
(WebCore::RealtimeMediaSource::RealtimeMediaSource):
(WebCore::RealtimeMediaSource::reset):
(WebCore::RealtimeMediaSource::setMuted):
(WebCore::RealtimeMediaSource::statesDidChanged):
(WebCore::RealtimeMediaSource::readonly):
* platform/mediastream/RealtimeMediaSource.h:
(WebCore::RealtimeMediaSource::id):
(WebCore::RealtimeMediaSource::persistentId):
(WebCore::RealtimeMediaSource::setPersistentId):
(WebCore::RealtimeMediaSource::type):
(WebCore::RealtimeMediaSource::stopped):
* platform/mediastream/RealtimeMediaSourceCenter.h:
* platform/mediastream/mac/AVCaptureDeviceManager.mm:
(WebCore::AVCaptureDeviceManager::getSourcesInfo):

* platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp:
(WebCore::RealtimeMediaSourceCenterMac::~RealtimeMediaSourceCenterMac):
(WebCore::RealtimeMediaSourceCenterMac::validateRequestConstraints):
(WebCore::RealtimeMediaSourceCenterMac::createMediaStream):
(WebCore::RealtimeMediaSourceCenterMac::getMediaStreamTrackSources):
* platform/mediastream/mac/RealtimeMediaSourceCenterMac.h:

* platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.cpp:
(WebCore::RealtimeMediaSourceCenterOwr::~RealtimeMediaSourceCenterOwr):
(WebCore::RealtimeMediaSourceCenterOwr::validateRequestConstraints):
* platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.h:

* platform/mock/MockRealtimeMediaSourceCenter.cpp:
(WebCore::MockRealtimeMediaSourceCenter::registerMockRealtimeMediaSourceCenter):
(WebCore::MockRealtimeMediaSourceCenter::validateRequestConstraints):
(WebCore::MockRealtimeMediaSourceCenter::createMediaStream):
(WebCore::MockRealtimeMediaSourceCenter::getMediaStreamTrackSources):
* platform/mock/MockRealtimeMediaSourceCenter.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdd image-only failure expectation to fast/shadow-dom/css-scoping-shadow-root-hides...
rniwa@webkit.org [Mon, 21 Sep 2015 20:05:51 +0000 (20:05 +0000)]
Add image-only failure expectation to fast/shadow-dom/css-scoping-shadow-root-hides-children.html on non-Mac ports.

* TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[OS X] Update for Xcode 7.0 on Yosemite
ap@apple.com [Mon, 21 Sep 2015 19:43:12 +0000 (19:43 +0000)]
[OS X] Update for Xcode 7.0 on Yosemite
https://bugs.webkit.org/show_bug.cgi?id=149389

Reviewed by Dan Bernstein.

* DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
* WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
Removed unneeded declarations - conforming to a protocol is sufficient.

* DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
* WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
Changed the definitions to be compiled whenever the SDK requires it (so we will have
dead code compiled in when building for 10.10 with 10.11 SDK, somewhat unfortunately).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190070 268f45cc-cd09-0410-ab3c-d52691b4dbfc