WebKit-https.git
7 years agoCreate a MAC EWS startup shell script.
lforschler@apple.com [Tue, 22 Jan 2013 23:13:33 +0000 (23:13 +0000)]
Create a MAC EWS startup shell script.

Reviewed by Ryosuke Niwa.

* EWSTools/start-queue-mac.sh: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix scrollperf logging
simon.fraser@apple.com [Tue, 22 Jan 2013 23:03:28 +0000 (23:03 +0000)]
Fix scrollperf logging
https://bugs.webkit.org/show_bug.cgi?id=107589

Reviewed by Tim Horton.

The scrollperf logging had two issues:

1. It relied on a paint logging a "filled" event, but it's possible
for existing tiles to be moved into the viewport and filling it, so
we need to log from the scrolling thread both when we have unfilled pixels,
and when the last scroll revealed unfilled pixels.

2. On some pages, z-index:-1 elements behind the body cause the root
TileCache to have drawsContent set to false, so none of its tiles paint. In
that case, the check for a non-zero paintCount in TileCache::blankPixelCountForTiles()
was wrong; we don't think there's a way to have an unpainted tile in the tree.

Also fix the signature of blankPixelCountForTiles() to take references.

* page/scrolling/mac/ScrollingTreeScrollingNodeMac.h:
(ScrollingTreeScrollingNodeMac):
* page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::ScrollingTreeScrollingNodeMac):
(WebCore::ScrollingTreeScrollingNodeMac::logExposedUnfilledArea):
* platform/graphics/ca/mac/TileCache.h:
* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::blankPixelCountForTiles):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agosputnik/Conformance/08_Types/8.4_The_String_Type/S8.4_A7.2.html is crashing
msaboff@apple.com [Tue, 22 Jan 2013 22:46:49 +0000 (22:46 +0000)]
sputnik/Conformance/08_Types/8.4_The_String_Type/S8.4_A7.2.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=90742

Unreviewed.  Test passes without any error or crashing.  Suspect
that the original issue has been resolved.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake CompactHTMLToken a little more compact
hclam@chromium.org [Tue, 22 Jan 2013 22:46:35 +0000 (22:46 +0000)]
Make CompactHTMLToken a little more compact
https://bugs.webkit.org/show_bug.cgi?id=107317

Patch by Eric Seidel <eric@webkit.org> on 2013-01-22
Reviewed by Adam Barth.

The windows builders got sad because MSVC won't combine
adjacent bit-fields with different types.  Changing
bool to unsigned should fix the problem.

* html/parser/CompactHTMLToken.h:
(CompactHTMLToken):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoJavaScriptCore property sheets, project files and modified build scripts.
roger_fong@apple.com [Tue, 22 Jan 2013 22:39:57 +0000 (22:39 +0000)]
JavaScriptCore property sheets, project files and modified build scripts.
https://bugs.webkit.org/show_bug.cgi?id=106987

Reviewed by Brent Fulgham.

* JavaScriptCore.vcxproj: Added.
* JavaScriptCore.vcxproj/JavaScriptCore.resources: Added.
* JavaScriptCore.vcxproj/JavaScriptCore.resources/Info.plist: Added.
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: Added.
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters: Added.
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.user: Added.
* JavaScriptCore.vcxproj/JavaScriptCoreCF.props: Added.
* JavaScriptCore.vcxproj/JavaScriptCoreCommon.props: Added.
* JavaScriptCore.vcxproj/JavaScriptCoreDebug.props: Added.
* JavaScriptCore.vcxproj/JavaScriptCoreExports.def: Added.
* JavaScriptCore.vcxproj/JavaScriptCoreGenerated.make: Added.
* JavaScriptCore.vcxproj/JavaScriptCoreGenerated.vcxproj: Added.
* JavaScriptCore.vcxproj/JavaScriptCoreGenerated.vcxproj.filters: Added.
* JavaScriptCore.vcxproj/JavaScriptCoreGenerated.vcxproj.user: Added.
* JavaScriptCore.vcxproj/JavaScriptCoreGeneratedCommon.props: Added.
* JavaScriptCore.vcxproj/JavaScriptCoreGeneratedDebug.props: Added.
* JavaScriptCore.vcxproj/JavaScriptCoreGeneratedRelease.props: Added.
* JavaScriptCore.vcxproj/JavaScriptCorePostBuild.cmd: Added.
* JavaScriptCore.vcxproj/JavaScriptCorePreBuild.cmd: Added.
* JavaScriptCore.vcxproj/JavaScriptCorePreLink.cmd: Added.
* JavaScriptCore.vcxproj/JavaScriptCoreRelease.props: Added.
* JavaScriptCore.vcxproj/LLInt.vcproj: Added.
* JavaScriptCore.vcxproj/LLInt.vcproj/LLIntAssembly: Added.
* JavaScriptCore.vcxproj/LLInt.vcproj/LLIntAssembly/LLIntAssembly.make: Added.
* JavaScriptCore.vcxproj/LLInt.vcproj/LLIntAssembly/LLIntAssembly.vcxproj: Added.
* JavaScriptCore.vcxproj/LLInt.vcproj/LLIntAssembly/LLIntAssembly.vcxproj.user: Added.
* JavaScriptCore.vcxproj/LLInt.vcproj/LLIntAssembly/build-LLIntAssembly.sh: Added.
* JavaScriptCore.vcxproj/LLInt.vcproj/LLIntDesiredOffsets: Added.
* JavaScriptCore.vcxproj/LLInt.vcproj/LLIntDesiredOffsets/LLIntDesiredOffsets.make: Added.
* JavaScriptCore.vcxproj/LLInt.vcproj/LLIntDesiredOffsets/LLIntDesiredOffsets.vcxproj: Added.
* JavaScriptCore.vcxproj/LLInt.vcproj/LLIntDesiredOffsets/LLIntDesiredOffsets.vcxproj.user: Added.
* JavaScriptCore.vcxproj/LLInt.vcproj/LLIntDesiredOffsets/build-LLIntDesiredOffsets.sh: Added.
* JavaScriptCore.vcxproj/LLInt.vcproj/LLIntOffsetsExtractor: Added.
* JavaScriptCore.vcxproj/LLInt.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractor.vcxproj: Added.
* JavaScriptCore.vcxproj/LLInt.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractor.vcxproj.user: Added.
* JavaScriptCore.vcxproj/LLInt.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractorCommon.props: Added.
* JavaScriptCore.vcxproj/LLInt.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractorDebug.props: Added.
* JavaScriptCore.vcxproj/LLInt.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractorRelease.props: Added.
* JavaScriptCore.vcxproj/build-generated-files.sh: Added.
* JavaScriptCore.vcxproj/copy-files.cmd: Added.
* JavaScriptCore.vcxproj/jsc: Added.
* JavaScriptCore.vcxproj/jsc/jsc.vcxproj: Added.
* JavaScriptCore.vcxproj/jsc/jsc.vcxproj.filters: Added.
* JavaScriptCore.vcxproj/jsc/jsc.vcxproj.user: Added.
* JavaScriptCore.vcxproj/jsc/jscCommon.props: Added.
* JavaScriptCore.vcxproj/jsc/jscDebug.props: Added.
* JavaScriptCore.vcxproj/jsc/jscPostBuild.cmd: Added.
* JavaScriptCore.vcxproj/jsc/jscPreBuild.cmd: Added.
* JavaScriptCore.vcxproj/jsc/jscPreLink.cmd: Added.
* JavaScriptCore.vcxproj/jsc/jscRelease.props: Added.
* config.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Update test expectations
hclam@chromium.org [Tue, 22 Jan 2013 22:36:41 +0000 (22:36 +0000)]
[chromium] Update test expectations
https://bugs.webkit.org/show_bug.cgi?id=107587

Unreviewed. Mark these tests as slow on Win7 Debug:
platform/chromium/virtual/gpu/fast/hidpi/clip-text-in-hidpi.html
platform/chromium/virtual/gpu/fast/hidpi/device-scale-factor-paint.html
platform/chromium/virtual/gpu/fast/hidpi/focus-rings.html

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Blackberry] Static code analysis warning fixes
commit-queue@webkit.org [Tue, 22 Jan 2013 22:22:15 +0000 (22:22 +0000)]
[Blackberry] Static code analysis warning fixes
https://bugs.webkit.org/show_bug.cgi?id=107464

Patch by Anthony Scian <ascian@rim.com> on 2013-01-22
Reviewed by Rob Buis.

Klocwork issues: 1367, 2367
- add NULL pointer checks detected by static code analysis

* platform/blackberry/WidgetBlackBerry.cpp:
(WebCore::Widget::setCursor):
* plugins/blackberry/PluginViewBlackBerry.cpp:
(WebCore::PluginView::updatePluginWidget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Mac] Enable Page Visibility (PAGE_VISIBILITY_API)
joepeck@webkit.org [Tue, 22 Jan 2013 22:13:59 +0000 (22:13 +0000)]
[Mac] Enable Page Visibility (PAGE_VISIBILITY_API)
https://bugs.webkit.org/show_bug.cgi?id=107230

Reviewed by David Kilzer.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

No new tests. Covered by existing tests which are now unskipped.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Tools:

* DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::resetPageVisibility):
Fix a typo in the original implementation. resetPageVisibility should
pass initialState YES so an event is not dispatched, which causes
issues in multiple tests. This now matches other ports.

LayoutTests:

* fast/events/page-visibility-iframe-delete-test-expected.txt:
* fast/events/page-visibility-iframe-delete-test.html:
Fix a typo.

* platform/mac/TestExpectations:
Unskip the tests on OS X.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove empty file WebPageProxyMessageKinds.h
joepeck@webkit.org [Tue, 22 Jan 2013 22:13:41 +0000 (22:13 +0000)]
Remove empty file WebPageProxyMessageKinds.h
https://bugs.webkit.org/show_bug.cgi?id=107335

Reviewed by Kentaro Hara.

* GNUmakefile.list.am:
* Shared/CoreIPCSupport/WebPageProxyMessageKinds.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake BackgroundHTMLParser track line/column numbers
tonyg@chromium.org [Tue, 22 Jan 2013 22:12:52 +0000 (22:12 +0000)]
Make BackgroundHTMLParser track line/column numbers
https://bugs.webkit.org/show_bug.cgi?id=107561

Reviewed by Adam Barth.

No new tests because covered by existing fast/parser tests.

* html/parser/BackgroundHTMLParser.cpp:
(WebCore::BackgroundHTMLParser::pumpTokenizer):
* html/parser/CompactHTMLToken.cpp:
(WebCore::CompactHTMLToken::CompactHTMLToken):
* html/parser/CompactHTMLToken.h:
(CompactHTMLToken):
(WebCore::CompactHTMLToken::textPosition):
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::didReceiveTokensFromBackgroundParser):
(WebCore::HTMLDocumentParser::lineNumber):
(WebCore::HTMLDocumentParser::textPosition):
* html/parser/HTMLDocumentParser.h:
(HTMLDocumentParser):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Update test expectations
hclam@chromium.org [Tue, 22 Jan 2013 22:04:41 +0000 (22:04 +0000)]
[chromium] Update test expectations
https://bugs.webkit.org/show_bug.cgi?id=107328

Unreviewed. Mark this test as missing:
fast/forms/form-associated-element-crash3.html

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Don't assert when deprecated setCallbacks is called
alecflett@chromium.org [Tue, 22 Jan 2013 22:04:09 +0000 (22:04 +0000)]
IndexedDB: Don't assert when deprecated setCallbacks is called
https://bugs.webkit.org/show_bug.cgi?id=107580

Reviewed by Tony Chang.

Remove an assert for IDBTransactionBackendImpl that was deprecated
in a previous commit, but is still called by old chromium code.
After the chromium code is removed, this method will be removed
entirely.

* Modules/indexeddb/IDBTransactionBackendImpl.h:
(WebCore::IDBTransactionBackendImpl::setCallbacks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Update test expectations.
hclam@chromium.org [Tue, 22 Jan 2013 21:42:06 +0000 (21:42 +0000)]
[chromium] Update test expectations.

Unreviewed rebaseline for layout test:
platform/chromium/fast/events/touch/touch-hit-rects-in-iframe.html

* platform/chromium-mac/platform/chromium/fast/events/touch/touch-hit-rects-in-iframe-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/platform/chromium/fast/events/touch/touch-hit-rects-in-iframe-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] webaudio/realtimeanalyser-fft-sizing.html is failing on Win7
hclam@chromium.org [Tue, 22 Jan 2013 21:31:28 +0000 (21:31 +0000)]
[chromium] webaudio/realtimeanalyser-fft-sizing.html is failing on Win7
https://bugs.webkit.org/show_bug.cgi?id=107581

Unreviewed build fix. Mark the following test as failing on Win7:
webaudio/realtimeanalyser-fft-sizing.html

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Disable CSS Regions in release builds
zandobersek@gmail.com [Tue, 22 Jan 2013 21:28:41 +0000 (21:28 +0000)]
[GTK] Disable CSS Regions in release builds
https://bugs.webkit.org/show_bug.cgi?id=106541

Patch by Zan Dobersek <zandobersek@gmail.com> on 2013-01-22
Reviewed by Martin Robinson.

The CSS Regions feature is not yet deemed stable enough to be enabled
in release builds, so disable it. It's still enabled for development
builds, via FeatureList.pm.

No new tests - no testable changes.

* GNUmakefile.features.am.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Enable CSS Image Orientation feature
zandobersek@gmail.com [Tue, 22 Jan 2013 21:27:13 +0000 (21:27 +0000)]
[GTK] Enable CSS Image Orientation feature
https://bugs.webkit.org/show_bug.cgi?id=99040

Patch by Zan Dobersek <zandobersek@gmail.com> on 2013-01-22
Reviewed by Martin Robinson.

Tools:

Enable the CSS Image Orientation feature in the development
builds of the GTK port. The feature is still disabled in the release
builds.

* Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Remove the general expectation, replacing it with a failure expectation
for the test that's failing due to whitespace problems in the cssText attribute
value after the image orientation attribute is set.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Enable the <template> element support in development builds
zandobersek@gmail.com [Tue, 22 Jan 2013 21:26:08 +0000 (21:26 +0000)]
[GTK] Enable the <template> element support in development builds
https://bugs.webkit.org/show_bug.cgi?id=106575

Patch by Zan Dobersek <zandobersek@gmail.com> on 2013-01-22
Reviewed by Martin Robinson.

Source/WebCore:

Add a missing build target that contains the custom JS bindings.

No new tests - the related tests are being unskipped and mostly pass.

* GNUmakefile.list.am:

Tools:

Enable the <template> element support in the development builds of the GTK port.

* Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Remove the skip entry for the layout tests of the element.
Add a failure expectation for a flaky test that's being unskipped.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPrettify the output of the override-feature-defines script
zandobersek@gmail.com [Tue, 22 Jan 2013 21:23:41 +0000 (21:23 +0000)]
Prettify the output of the override-feature-defines script
https://bugs.webkit.org/show_bug.cgi?id=106542

Patch by Zan Dobersek <zandobersek@gmail.com> on 2013-01-22
Reviewed by Martin Robinson.

The output now clearly lists the feature defines being overridden
along with the default and overriding values for each feature define.

* gtk/override-feature-defines:
(adjust_feature_defines_makefile):
(adjust_feature_defines_makefile.override_feature_define):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Remove dependency on IDBKey type from IDLs
jsbell@chromium.org [Tue, 22 Jan 2013 21:21:34 +0000 (21:21 +0000)]
IndexedDB: Remove dependency on IDBKey type from IDLs
https://bugs.webkit.org/show_bug.cgi?id=106912

Reviewed by Kentaro Hara.

This is a preamble to wkbug.com/97375 "Remove IDBKey from WebKitIDL"; IDBKey is
not a concept from the Indexed DB spec but a convenient internal type. It was
exposed in the IDL with custom binding code and special cases in the generator
to map from script values to the WebCore type. To remove those special cases
and match the WebIDL in the spec, the IDLs are changed to use "any" and the
implementations now take ScriptValues. This does mean that each call site must
call into IDBBindingUtilities to map from ScriptValue to IDBKey.

No new tests - just a refactor.

* Modules/indexeddb/IDBAny.cpp: Remove IDBKey as a variant type - just use ScriptValue.
* Modules/indexeddb/IDBAny.h:
(WebCore):
(IDBAny):
* Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::continueFunction): Now takes any/ScriptValue.
(WebCore):
* Modules/indexeddb/IDBCursor.h:
(WebCore::IDBCursor::continueFunction):
(IDBCursor):
* Modules/indexeddb/IDBCursor.idl:
* Modules/indexeddb/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::deleteFunction):
* Modules/indexeddb/IDBFactory.cpp:
(WebCore::IDBFactory::cmp): Now takes any/ScriptValue.
* Modules/indexeddb/IDBFactory.h:
(IDBFactory):
* Modules/indexeddb/IDBFactory.idl:
* Modules/indexeddb/IDBIndex.cpp:
(WebCore::IDBIndex::openCursor): Now takes any/ScriptValue.
(WebCore::IDBIndex::count): Now takes any/ScriptValue.
(WebCore::IDBIndex::openKeyCursor): Now takes any/ScriptValue.
(WebCore::IDBIndex::get): Now takes any/ScriptValue.
(WebCore::IDBIndex::getKey): Now takes any/ScriptValue.
* Modules/indexeddb/IDBIndex.h:
(WebCore::IDBIndex::openCursor):
(IDBIndex):
(WebCore::IDBIndex::openKeyCursor):
* Modules/indexeddb/IDBIndex.idl:
* Modules/indexeddb/IDBKeyRange.cpp:
(WebCore::IDBKeyRange::create): Add helper for back-end creation of single-key ranges.
(WebCore):
(WebCore::IDBKeyRange::lowerValue): Impl. of new "any" type accessor exposed to script.
(WebCore::IDBKeyRange::upperValue): Ditto.
(WebCore::IDBKeyRange::only): Now takes any/ScriptValue.
(WebCore::IDBKeyRange::lowerBound): Now takes any/ScriptValue.
(WebCore::IDBKeyRange::upperBound): Now takes any/ScriptValue.
(WebCore::IDBKeyRange::bound): Now takes any/ScriptValue.
* Modules/indexeddb/IDBKeyRange.h:
(IDBKeyRange):
(WebCore::IDBKeyRange::lowerBound):
(WebCore::IDBKeyRange::upperBound):
(WebCore::IDBKeyRange::bound):
* Modules/indexeddb/IDBKeyRange.idl:
* Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::get): Now takes any/ScriptValue.
(WebCore::IDBObjectStore::add): Now takes any/ScriptValue.
(WebCore):
(WebCore::IDBObjectStore::put): Now takes any/ScriptValue.
(WebCore::IDBObjectStore::deleteFunction): Now takes any/ScriptValue.
(WebCore::IDBObjectStore::openCursor): Now takes any/ScriptValue.
(WebCore::IDBObjectStore::count): Now takes any/ScriptValue.
* Modules/indexeddb/IDBObjectStore.h:
(IDBObjectStore):
(WebCore::IDBObjectStore::openCursor):
* Modules/indexeddb/IDBObjectStore.idl:
* Modules/indexeddb/IDBRequest.cpp: Result IDBAny type is now ScriptValue.
(WebCore::IDBRequest::onSuccess):
* bindings/js/IDBBindingUtilities.cpp:
(WebCore::scriptValueToIDBKey): The inverse of idbKeyToScriptValue().
(WebCore):
* bindings/js/IDBBindingUtilities.h:
(WebCore):
* bindings/js/JSIDBAnyCustom.cpp:
(WebCore::toJS):
* bindings/v8/IDBBindingUtilities.cpp:
(WebCore::scriptValueToIDBKey): Ditto.
(WebCore):
* bindings/v8/IDBBindingUtilities.h:
(WebCore):
* bindings/v8/custom/V8IDBAnyCustom.cpp:
(WebCore::toV8): Remove IDBKey variant type.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove uses of deprecated unittest.TestCase aliases
zandobersek@gmail.com [Tue, 22 Jan 2013 21:20:26 +0000 (21:20 +0000)]
Remove uses of deprecated unittest.TestCase aliases
https://bugs.webkit.org/show_bug.cgi?id=102252

Reviewed by Adam Barth.

Replace the deprecated assertEquals method of the TestCase interface
used in some webkitpy unittests with the assertEqual method.

* Scripts/webkitpy/common/system/profiler_unittest.py:
(ProfilerFactoryTest._assert_default_profiler_name):
(ProfilerFactoryTest.test_default_profiler_output):
* Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
(GtkPortTest.test_expectations_files):
* Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
(TestHttpServer.test_win32_start_and_stop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTRANSFORMATION_MATRIX_USE_X86_64_SSE2 broken for 64-bit Windows builds
jschuh@chromium.org [Tue, 22 Jan 2013 21:20:05 +0000 (21:20 +0000)]
TRANSFORMATION_MATRIX_USE_X86_64_SSE2 broken for 64-bit Windows builds
https://bugs.webkit.org/show_bug.cgi?id=107498

Reviewed by James Robinson.

Enable TRANSFORMATION_MATRIX_USE_X86_64_SSE2 for 64-bit Windows.

No new tests. Covered by existing tests.

* platform/graphics/transforms/TransformationMatrix.h:
(WebCore):
(TransformationMatrix):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix a race condition on SkBitmap::lockPixels()/unlockPixels() for lazy image decoding
commit-queue@webkit.org [Tue, 22 Jan 2013 21:09:07 +0000 (21:09 +0000)]
Fix a race condition on SkBitmap::lockPixels()/unlockPixels() for lazy image decoding
https://bugs.webkit.org/show_bug.cgi?id=107404

Patch by Min Qin <qinmin@chromium.org> on 2013-01-22
Reviewed by Stephen White.

Skbitmap::lockPixels()/unlockPixels() are not threadsafe.
unlike SkPixelRef, these 2 calls are not protected by an internal mutex.
Bugfix, no behaviral change and hard to test as tests will be flaky.

* platform/graphics/chromium/ImageDecodingStore.cpp:
(WebCore::ImageDecodingStore::lockCache):
(WebCore::ImageDecodingStore::unlockCache):
(WebCore::ImageDecodingStore::insertAndLockCache):
(WebCore::ImageDecodingStore::overwriteAndLockCache):
* platform/graphics/chromium/ImageDecodingStore.h:
(ImageDecodingStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake CompactHTMLToken a little more compact
eric@webkit.org [Tue, 22 Jan 2013 21:01:42 +0000 (21:01 +0000)]
Make CompactHTMLToken a little more compact
https://bugs.webkit.org/show_bug.cgi?id=107317

Reviewed by Darin Adler.

Reduce the size of CompactHTMLToken by two pointers.
The abuse of the attribute vector to store the DOCTYPE strings
is kinda lame, but makes a lot of sense given how rare DOCTYPE tokens are.

The resulting CompactHTMLToken vector should be a smaller malloc and thus faster.
However I saw no perf change on html-parser-srcdoc.html.

* html/parser/CompactHTMLToken.cpp:
(SameSizeAsCompactHTMLToken):
(WebCore):
(WebCore::CompactHTMLToken::CompactHTMLToken):
(WebCore::CompactHTMLToken::isSafeToSendToAnotherThread):
* html/parser/CompactHTMLToken.h:
(WebCore::CompactHTMLToken::type):
(CompactHTMLToken):
(WebCore::CompactHTMLToken::publicIdentifier):
(WebCore::CompactHTMLToken::systemIdentifier):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAssertion parent->inDocument() failed in WebCore::PseudoElement::PseudoElement
esprehn@chromium.org [Tue, 22 Jan 2013 20:57:32 +0000 (20:57 +0000)]
Assertion parent->inDocument() failed in WebCore::PseudoElement::PseudoElement
https://bugs.webkit.org/show_bug.cgi?id=106224

Reviewed by Ojan Vafai.

Appending a node that contains a <style> and also elements that should have
generated content can cause us to create PseudoElements in nodes that are not
yet inDocument because we may recalcStyle in HTMLStyleElement::insertedInto
triggering a reattach() which could then traverse into the siblings of the
<style> attaching them even though they are not yet inDocument.

This means that we should not assert about the parent of a PseudoElement
being inDocument as this is not always the case.

Instead forward Node::insertedInto and removedFrom notifications to
PseudoElements so they will correctly get their inDocument bit set. Nothing
in the code appears to depend on them being inDocument we just make sure to
set it so they're consistent with the rest of the document.

No new tests, there's no way to test that PseudoElements are really inDocument.

* dom/Element.cpp:
(WebCore::Element::insertedInto):
(WebCore::Element::removedFrom):
* dom/PseudoElement.cpp:
(WebCore::PseudoElement::PseudoElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWTF project files and property sheets for getting WebKit to compile in VS2010.
roger_fong@apple.com [Tue, 22 Jan 2013 20:30:11 +0000 (20:30 +0000)]
WTF project files and property sheets for getting WebKit to compile in VS2010.
https://bugs.webkit.org/show_bug.cgi?id=106986

Reviewed by Timothy Horton and Brent Fulgham.

* WTF.vcproj/WTF.sln:
* WTF.vcxproj: Added.
* WTF.vcxproj/WTF.vcxproj: Added.
* WTF.vcxproj/WTF.vcxproj.filters: Added.
* WTF.vcxproj/WTF.vcxproj.user: Added.
* WTF.vcxproj/WTFCommon.props: Added.
* WTF.vcxproj/WTFDebug.props: Added.
* WTF.vcxproj/WTFGenerated.make: Added.
* WTF.vcxproj/WTFGenerated.vcxproj: Added.
* WTF.vcxproj/WTFGenerated.vcxproj.filters: Added.
* WTF.vcxproj/WTFGenerated.vcxproj.user: Added.
* WTF.vcxproj/WTFGeneratedCommon.props: Added.
* WTF.vcxproj/WTFGeneratedDebug.props: Added.
* WTF.vcxproj/WTFGeneratedRelease.props: Added.
* WTF.vcxproj/WTFPostBuild.cmd: Added.
* WTF.vcxproj/WTFPreBuild.cmd: Added.
* WTF.vcxproj/WTFPreLink.cmd: Added.
* WTF.vcxproj/WTFRelease.props: Added.
* WTF.vcxproj/build-generated-files.sh: Added.
* WTF.vcxproj/copy-files.cmd: Added.
* WTF.vcxproj/work-around-vs-dependency-tracking-bugs.py: Added.
* config.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r140231): media track layout tests crashing
hclam@chromium.org [Tue, 22 Jan 2013 20:26:44 +0000 (20:26 +0000)]
REGRESSION(r140231): media track layout tests crashing
https://bugs.webkit.org/show_bug.cgi?id=107579

Unreviewed. Mark 3 tests as crashing:
media/track/track-css-cue-lifetime.html
media/track/track-css-matching.html
media/track/track-css-property-whitelist.html

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r140392): InjectIDBKeyTest.TopLevelPropertyStringValue is crashing
hclam@chromium.org [Tue, 22 Jan 2013 20:12:29 +0000 (20:12 +0000)]
REGRESSION(r140392): InjectIDBKeyTest.TopLevelPropertyStringValue is crashing
https://bugs.webkit.org/show_bug.cgi?id=107578

Unreviewed build fix. Disabled 2 tests that are crashing after r140392.

* tests/IDBBindingUtilitiesTest.cpp:
(WebKit::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAllow construction of unprefixed transition DOM events.
alexis@webkit.org [Tue, 22 Jan 2013 20:07:35 +0000 (20:07 +0000)]
Allow construction of unprefixed transition DOM events.
https://bugs.webkit.org/show_bug.cgi?id=107319

Reviewed by Dean Jackson.

Source/WebCore:

Make possible to construct unprefixed DOM events for transitions.
Unfortunately I have to duplicate the C++ implementation class of the
events (TransitionEvent.h and TransitionEvent.cpp). I can't find a
better way to re-use the WebKitTransitionEvent class to back the
TransitionEvent.idl as our code generators don't allow to have a
different name for the C++ class used in the generated file than the
interface name specified in the IDL file. Unfortunately
https://trac.webkit.org/wiki/WebKitIDL#InterfaceName doesn't help as
it's only a way to unlink the interface name specified in the IDL with
the one exposed in JavaScript. I don't think we should support such a
feature in our code generators as WebKitTransitionEvent class and more
exactly prefixed DOM events for transitions will be removed one day so
this use case will become obselete.

Test: fast/events/constructors/transition-event-constructor.html

* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/DOMAllInOne.cpp:
* dom/EventNames.in:
* dom/TransitionEvent.cpp: Added.
(WebCore):
(WebCore::TransitionEventInit::TransitionEventInit):
(WebCore::TransitionEvent::TransitionEvent):
(WebCore::TransitionEvent::~TransitionEvent):
(WebCore::TransitionEvent::propertyName):
(WebCore::TransitionEvent::elapsedTime):
(WebCore::TransitionEvent::interfaceName):
* dom/TransitionEvent.h: Added.
(WebCore):
(TransitionEventInit):
(TransitionEvent):
(WebCore::TransitionEvent::create):
* dom/TransitionEvent.idl: Added.
* page/DOMWindow.idl:
* page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::fireEventsAndUpdateStyle): always
create a TransitionEvent now. EventTarget will be responsible to create
a WebKitTransitionEvent if necessary.

LayoutTests:

Add new tests to cover the feature. Update some existing ones with new
expected results as a new constructor was added.

* fast/dom/constructed-objects-prototypes.html:
* fast/dom/constructed-objects-prototypes-expected.txt:
* fast/events/constructors/transition-event-constructor-expected.txt: Added.
* fast/events/constructors/transition-event-constructor.html: Added.
* fast/events/event-creation.html:
* platform/chromium/TestExpectations: Chromium turns the feature off.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWean BackgroundHTMLParser off HTMLInputStream
abarth@webkit.org [Tue, 22 Jan 2013 19:55:01 +0000 (19:55 +0000)]
Wean BackgroundHTMLParser off HTMLInputStream
https://bugs.webkit.org/show_bug.cgi?id=107575

Reviewed by Eric Seidel.

The BackgroundHTMLParser doesn't need to use HTMLInputStream because it
doesn't need to handle nested calls to document.write. Instead, we can
just use a SegmentedString directly, which will let us checkpoint
m_input for speculation.

* html/parser/BackgroundHTMLParser.cpp:
(WebCore::BackgroundHTMLParser::append):
(WebCore::BackgroundHTMLParser::finish):
(WebCore::BackgroundHTMLParser::markEndOfFile):
(WebCore):
(WebCore::BackgroundHTMLParser::pumpTokenizer):
* html/parser/BackgroundHTMLParser.h:
(BackgroundHTMLParser):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Soup] Random thread crashes
sergio@webkit.org [Tue, 22 Jan 2013 19:24:58 +0000 (19:24 +0000)]
[Soup] Random thread crashes
https://bugs.webkit.org/show_bug.cgi?id=107439

Reviewed by Martin Robinson.

Process all pending requests in the inner GMainContext created to
perform synchronous requests before restoring the thread default. No
new tests required, already covered by network tests.

* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::WebCoreSynchronousLoader::~WebCoreSynchronousLoader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[gstreamer] GstBus signal watch should be removed on clean up
christophe.dumez@intel.com [Tue, 22 Jan 2013 19:15:38 +0000 (19:15 +0000)]
[gstreamer] GstBus signal watch should be removed on clean up
https://bugs.webkit.org/show_bug.cgi?id=107544

Reviewed by Philippe Normand.

Our gstreamer backend code currently calls gst_bus_add_signal_watch()
on GstBus to add a signal watch. As per the gstreamer  documentation,
"To clean up, the caller is responsible for calling
gst_bus_remove_signal_watch() as many times as this function is
called". This is because gst_bus_add_signal_watch() causes the GstBus
object to be ref'd and gst_bus_remove_signal_watch() needs to be
called to properly unref it.

This patch makes sure that gst_bus_remove_signal_watch() is called
on the GstBus object when cleaning up. This patch also uses smart
pointers for GstBus objects for consistency.

No new tests, no behavior change for layout tests.

* platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):
(WebCore::AudioDestinationGStreamer::~AudioDestinationGStreamer):
* platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(WebCore::AudioFileReader::~AudioFileReader):
(WebCore::AudioFileReader::decodeAudioForBusCreation):
* platform/graphics/gstreamer/GStreamerGWorld.cpp:
(WebCore::GStreamerGWorld::GStreamerGWorld):
* platform/graphics/gstreamer/GStreamerVersioning.cpp:
(webkitGstPipelineGetBus):
* platform/graphics/gstreamer/GStreamerVersioning.h:
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r140344): Repeated crashes in WKTR PlatformWebView::viewSupportsOptions().
jer.noble@apple.com [Tue, 22 Jan 2013 19:13:58 +0000 (19:13 +0000)]
REGRESSION(r140344): Repeated crashes in WKTR PlatformWebView::viewSupportsOptions().
https://bugs.webkit.org/show_bug.cgi?id=107562

Rubber-stamped by Alexy Proskuryakov.

The input to WKBooleanGetValue() is not NULL-safe, so NULL check its inputs before calling.

* WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::viewSupportsOptions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBackgroundHTMLParser should simulate tree building in a separate function
abarth@webkit.org [Tue, 22 Jan 2013 19:12:15 +0000 (19:12 +0000)]
BackgroundHTMLParser should simulate tree building in a separate function
https://bugs.webkit.org/show_bug.cgi?id=107569

Reviewed by Eric Seidel.

This patch cleans up BackgroundHTMLParser::pumpTokenizer to prepare for
implementing speculative parsing.

* html/parser/BackgroundHTMLParser.cpp:
(WebCore::BackgroundHTMLParser::simulateTreeBuilder):
(WebCore):
(WebCore::BackgroundHTMLParser::pumpTokenizer):
* html/parser/BackgroundHTMLParser.h:
(BackgroundHTMLParser):
* page/Settings.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Debug build failure on x86-64
kov@webkit.org [Tue, 22 Jan 2013 18:52:52 +0000 (18:52 +0000)]
[GTK] Debug build failure on x86-64
https://bugs.webkit.org/show_bug.cgi?id=107400

Reviewed by Xan Lopez.

* configure.ac: use thin archives for convenience libraries, if AR_FLAGS was not
overriden through the environment variable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r140435.
commit-queue@webkit.org [Tue, 22 Jan 2013 18:50:36 +0000 (18:50 +0000)]
Unreviewed, rolling out r140435.
http://trac.webkit.org/changeset/140435
https://bugs.webkit.org/show_bug.cgi?id=107565

Crashes on ClusterFuzz due to float not removed (Requested by
inferno-sec on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-22

Source/WebCore:

* rendering/RenderBox.cpp:
(WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):

LayoutTests:

* fast/block/float/overhanging-float-not-removed-crash-expected.txt: Removed.
* fast/block/float/overhanging-float-not-removed-crash.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoYarr JIT isn't big endian compatible
commit-queue@webkit.org [Tue, 22 Jan 2013 18:34:54 +0000 (18:34 +0000)]
Yarr JIT isn't big endian compatible
https://bugs.webkit.org/show_bug.cgi?id=102897

Patch by Tobias Netzel <tobias.netzel@googlemail.com> on 2013-01-22
Reviewed by Oliver Hunt.

This patch was tested in the current mozilla codebase only and has passed the regexp tests there.

* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::generatePatternCharacterOnce):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix DateMath.cpp to compile with -Wshorten-64-to-32
ddkilzer@apple.com [Tue, 22 Jan 2013 18:27:23 +0000 (18:27 +0000)]
Fix DateMath.cpp to compile with -Wshorten-64-to-32
<http://webkit.org/b/107503>

Reviewed by Darin Adler.

Source/JavaScriptCore:

* runtime/JSDateMath.cpp:
(JSC::parseDateFromNullTerminatedCharacters): Remove unneeded
static_cast<int>().

Source/WTF:

Fixes the following build errors with -Wshorten-64-to-32:

    DateMath.cpp:742:47: error: implicit conversion loses integer precision: 'long' to 'int' [-Werror,-Wshorten-64-to-32]
        if (month == 2 && day > 28 && !isLeapYear(year))
                                       ~~~~~~~~~~ ^~~~
    DateMath.cpp:757:48: error: implicit conversion loses integer precision: 'long' to 'int' [-Werror,-Wshorten-64-to-32]
        double dateSeconds = ymdhmsToSeconds(year, month, day, hours, minutes, seconds) - timeZoneSeconds;
                             ~~~~~~~~~~~~~~~       ^~~~~
    DateMath.cpp:757:55: error: implicit conversion loses integer precision: 'long' to 'int' [-Werror,-Wshorten-64-to-32]
        double dateSeconds = ymdhmsToSeconds(year, month, day, hours, minutes, seconds) - timeZoneSeconds;
                             ~~~~~~~~~~~~~~~              ^~~
    DateMath.cpp:757:60: error: implicit conversion loses integer precision: 'long' to 'int' [-Werror,-Wshorten-64-to-32]
        double dateSeconds = ymdhmsToSeconds(year, month, day, hours, minutes, seconds) - timeZoneSeconds;
                             ~~~~~~~~~~~~~~~                   ^~~~~
    DateMath.cpp:757:67: error: implicit conversion loses integer precision: 'long' to 'int' [-Werror,-Wshorten-64-to-32]
        double dateSeconds = ymdhmsToSeconds(year, month, day, hours, minutes, seconds) - timeZoneSeconds;
                             ~~~~~~~~~~~~~~~                          ^~~~~~~
    DateMath.cpp:996:59: error: implicit conversion loses integer precision: 'long' to 'int' [-Werror,-Wshorten-64-to-32]
                        offset = ((o / 100) * 60 + (o % 100)) * sgn;
                               ~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
    DateMath.cpp:998:37: error: implicit conversion loses integer precision: 'long' to 'int' [-Werror,-Wshorten-64-to-32]
                        offset = o * 60 * sgn;
                               ~ ~~~~~~~^~~~~
    DateMath.cpp:1005:40: error: implicit conversion loses integer precision: 'long' to 'int' [-Werror,-Wshorten-64-to-32]
                    offset = (o * 60 + o2) * sgn;
                           ~ ~~~~~~~~~~~~~~^~~~~
    DateMath.cpp:1041:40: error: implicit conversion loses integer precision: 'long' to 'int' [-Werror,-Wshorten-64-to-32]
        return ymdhmsToSeconds(year, month + 1, day, hour, minute, second) * msPerSecond;
               ~~~~~~~~~~~~~~~       ~~~~~~^~~
    DateMath.cpp:1041:45: error: implicit conversion loses integer precision: 'long' to 'int' [-Werror,-Wshorten-64-to-32]
        return ymdhmsToSeconds(year, month + 1, day, hour, minute, second) * msPerSecond;
               ~~~~~~~~~~~~~~~                  ^~~
    DateMath.cpp:1041:50: error: implicit conversion loses integer precision: 'long' to 'int' [-Werror,-Wshorten-64-to-32]
        return ymdhmsToSeconds(year, month + 1, day, hour, minute, second) * msPerSecond;
               ~~~~~~~~~~~~~~~                       ^~~~
    DateMath.cpp:1041:56: error: implicit conversion loses integer precision: 'long' to 'int' [-Werror,-Wshorten-64-to-32]
        return ymdhmsToSeconds(year, month + 1, day, hour, minute, second) * msPerSecond;
               ~~~~~~~~~~~~~~~                             ^~~~~~
    12 errors generated.

* wtf/DateMath.cpp:
(WTF::ymdhmsToSeconds): Change year argument from long to int.
Change mon, day, hour, minute arguments from int to long.
(WTF::parseInt): Add.  Identical to parseLong but bounds checks
for type int.
(WTF::parseLong): Switch to std::numeric_limits<long> instead of
macros.
(WTF::parseES5DatePortion): Change year argument from long to
int.
(WTF::parseES5DateFromNullTerminatedCharacters): Change year
local variable from long to int.
(WTF::parseDateFromNullTerminatedCharacters): Change year and
offset local variables from long to int.  Switch from using
parseLong() to parseInt() as needed.  Ditto for labs() to abs().
Add overflow check when switching from "MM/DD/YYYY" to
"YYYY/MM/DD" parsing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWhen we do setAttribute("border", null) on a table we should create a border like...
robert@webkit.org [Tue, 22 Jan 2013 18:22:01 +0000 (18:22 +0000)]
When we do setAttribute("border", null) on a table we should create a border like every other browser
https://bugs.webkit.org/show_bug.cgi?id=102112

Reviewed by Ryosuke Niwa.

Source/WebCore:

http://www.whatwg.org/specs/web-apps/current-work/multipage/rendering.html#tables says:
"If the [table's border] attribute is present but parsing the attribute's value using the rules for parsing
non-negative integers generates an error, a default value of 1px is expected to be used for that property instead."

Match the spec and bring us into line with other browsers by observing the 'parsing non-negative integers' algorithm.

Tests: fast/dom/HTMLTableElement/table-with-invalid-border.html
       fast/table/table-with-borderattr-null.html
       fast/table/table-with-borderattr-set-to-null.html

* html/HTMLElement.cpp:
(WebCore::HTMLElement::parseBorderWidthAttribute):
(WebCore::HTMLElement::applyBorderAttributeToStyle):
* html/HTMLElement.h:
(HTMLElement):
* html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::collectStyleForPresentationAttribute):
(WebCore::HTMLTableElement::parseAttribute):

LayoutTests:

* fast/dom/HTMLTableElement/table-with-invalid-border-expected.txt: Added.
* fast/dom/HTMLTableElement/table-with-invalid-border.html: Added.
* fast/table/table-with-borderattr-null-expected.txt: Added.
* fast/table/table-with-borderattr-null.html: Added.
* fast/table/table-with-borderattr-set-to-null-expected.txt: Added.
* fast/table/table-with-borderattr-set-to-null.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoHeap-use-after-free in WebCore::RenderObject::isDescendantOf
inferno@chromium.org [Tue, 22 Jan 2013 18:17:37 +0000 (18:17 +0000)]
Heap-use-after-free in WebCore::RenderObject::isDescendantOf
https://bugs.webkit.org/show_bug.cgi?id=107226

Reviewed by Emil A Eklund.

Source/WebCore:

Test: fast/block/float/overhanging-float-not-removed-crash.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):
Skip anonymous blocks in the chain to get the enclosing block and
be able to correctly mark the overhanging floats in the next siblings.

LayoutTests:

* fast/block/float/overhanging-float-not-removed-crash-expected.txt: Added.
* fast/block/float/overhanging-float-not-removed-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago One is not allowed to use commit-queue to make oneself a committer.
ap@apple.com [Tue, 22 Jan 2013 18:02:41 +0000 (18:02 +0000)]
    One is not allowed to use commit-queue to make oneself a committer.

        * Scripts/webkitpy/common/config/committers.py: Removing eustas@chromium.org.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSilence MSVC 64-bit build warning c4309 for FrameTree::invalidCount
jschuh@chromium.org [Tue, 22 Jan 2013 17:47:28 +0000 (17:47 +0000)]
Silence MSVC 64-bit build warning c4309 for FrameTree::invalidCount
https://bugs.webkit.org/show_bug.cgi?id=107439

Reviewed by Dimitri Glazkov.

MSVC detects that the constant notFound is truncated on assignment to
invalidCount. Since we never compare them (as it would always fail on
64-bit anyway), just initialize invalidCount directly to -1.

No new tests. No behavior changed.

* page/FrameTree.h:
(FrameTree):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Autotools] Remove the Canvas Path configuration option
zandobersek@gmail.com [Tue, 22 Jan 2013 17:17:13 +0000 (17:17 +0000)]
[Autotools] Remove the Canvas Path configuration option
https://bugs.webkit.org/show_bug.cgi?id=107537

Reviewed by Martin Robinson.

.:

* configure.ac: Remove the configuration option for the Canvas Path
feature as this is not in line with the new guidelines about feature
enablement in the autotools build system.

Source/WebCore:

No new tests - no new testable functionality.

* GNUmakefile.am: Remove the Automake conditional analysis, the related
configuration option is being removed as well.
* GNUmakefile.features.am.in: Add the ENABLE_CANVAS_PATH feature define,
defaulting to 0 in release builds (but is disabled in development builds
of the GTK port as well at the moment).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Autotools] Place a warning in configure.ac about adding new configuration options
zandobersek@gmail.com [Tue, 22 Jan 2013 17:15:25 +0000 (17:15 +0000)]
[Autotools] Place a warning in configure.ac about adding new configuration options
https://bugs.webkit.org/show_bug.cgi?id=107559

Reviewed by Martin Robinson.

* configure.ac: Add an eye-catching section explaining that changes in this file might
not be necessary at all and a link pointing to the guidelines on the Trac wiki.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAsserts when textPath is used with no path
schenney@chromium.org [Tue, 22 Jan 2013 16:52:49 +0000 (16:52 +0000)]
Asserts when textPath is used with no path
https://bugs.webkit.org/show_bug.cgi?id=107324

Reviewed by Eric Seidel.

Source/WebCore:

We assert when there is no path associated with an SVG text path
element. Instead, this patch detects the condition and stops trying to
layout text for that textPath  element.

Test: svg/text/tpath-without-path.svg

* rendering/svg/SVGTextLayoutEngine.cpp:
(WebCore::SVGTextLayoutEngine::beginTextPathLayout):
(WebCore::SVGTextLayoutEngine::layoutTextOnLineOrPath):

LayoutTests:

Test will assert in debug without this patch.

* svg/text/tpath-without-path-expected.txt: Added.
* svg/text/tpath-without-path.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Canvas] jump to prev/next drawing call in the replay
aandrey@chromium.org [Tue, 22 Jan 2013 16:41:26 +0000 (16:41 +0000)]
Web Inspector: [Canvas] jump to prev/next drawing call in the replay
https://bugs.webkit.org/show_bug.cgi?id=107551

Reviewed by Pavel Feldman.

Implement jumping to the next(previous) drawing call in the WebGL and canvas 2D replay.

* English.lproj/localizedStrings.js:
* inspector/InjectedScriptCanvasModuleSource.js:
(.):
* inspector/Inspector.json:
* inspector/front-end/CanvasProfileView.js:
(WebInspector.CanvasProfileView):
(WebInspector.CanvasProfileView.prototype.dispose):
(WebInspector.CanvasProfileView.prototype._onReplayDrawingCallClick):
* inspector/front-end/canvasProfiler.css:
(.canvas-replay-prev-draw img):
(.canvas-replay-next-draw img):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: remove asynchronous behavior from DTE paintLines method
commit-queue@webkit.org [Tue, 22 Jan 2013 16:19:11 +0000 (16:19 +0000)]
Web Inspector: remove asynchronous behavior from DTE paintLines method
https://bugs.webkit.org/show_bug.cgi?id=107550

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-01-22
Reviewed by Pavel Feldman.

Remove paintLinesOperationCredit and all asynchronous behaviour from paintLines method;
also, remove paintLineChunks method.

* inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.prototype.expandChunks):
(WebInspector.TextEditorMainPanel.prototype._highlightDataReady):
(WebInspector.TextEditorMainPanel.prototype._paintLines):
(WebInspector.TextEditorMainPanel.prototype._renderRanges):
(WebInspector.TextEditorMainPanel.prototype._paintLine):
(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Network] "Secure" cookies can not be deleted.
commit-queue@webkit.org [Tue, 22 Jan 2013 16:07:21 +0000 (16:07 +0000)]
Web Inspector: [Network] "Secure" cookies can not be deleted.
https://bugs.webkit.org/show_bug.cgi?id=107543

Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2013-01-22
Reviewed by Pavel Feldman.

To delete secure cookie URL schema need to be "https" instead of "http".

* inspector/front-end/CookieItemsView.js:
(WebInspector.CookieItemsView.prototype._deleteCookie):
Take care of secure cookies.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r140420.
commit-queue@webkit.org [Tue, 22 Jan 2013 16:05:39 +0000 (16:05 +0000)]
Unreviewed, rolling out r140420.
http://trac.webkit.org/changeset/140420
https://bugs.webkit.org/show_bug.cgi?id=107557

Still causes crashes (EFL this time) (Requested by kov on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-22

* platform/graphics/gstreamer/GStreamerVersioning.cpp:
* platform/graphics/gstreamer/GStreamerVersioning.h:
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(StreamingClient):
(_WebKitWebSrcPrivate):
(webKitWebSrcFinalize):
(webKitWebSrcStop):
(StreamingClient::didReceiveData):
* platform/network/ResourceHandleClient.h:
(ResourceHandleClient):
* platform/network/ResourceHandleInternal.h:
(WebCore::ResourceHandleInternal::ResourceHandleInternal):
(ResourceHandleInternal):
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::cleanupSoupRequestOperation):
(WebCore::nextMultipartResponsePartCallback):
(WebCore::sendRequestCallback):
(WebCore::readCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Unskipping some Accessibility Layout Tests for WK2.
commit-queue@webkit.org [Tue, 22 Jan 2013 15:34:18 +0000 (15:34 +0000)]
[EFL] Unskipping some Accessibility Layout Tests for WK2.
https://bugs.webkit.org/show_bug.cgi?id=107555

Unreviewed EFL gardening.

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-01-22

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Crash in PasteboardQt.cpp Pasteboard::writeSelection
commit-queue@webkit.org [Tue, 22 Jan 2013 15:03:15 +0000 (15:03 +0000)]
[Qt] Crash in PasteboardQt.cpp Pasteboard::writeSelection
https://bugs.webkit.org/show_bug.cgi?id=102192

Patch by Fabien Valée
Patch by Allan Sandfeld Jensen <allan.jensen@digia.com> on 2013-01-22
Reviewed by Jocelyn Turcotte.

QClipboard::setMimeData transfers ownership of QMimeData to the clipboard,
so we should not access it afterwards.

* platform/qt/PasteboardQt.cpp:
(WebCore::Pasteboard::writeSelection):
(WebCore::Pasteboard::writePlainText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRegression(r140414): It is causing crashes with gstreamer 0.10
christophe.dumez@intel.com [Tue, 22 Jan 2013 14:53:28 +0000 (14:53 +0000)]
Regression(r140414): It is causing crashes with gstreamer 0.10
https://bugs.webkit.org/show_bug.cgi?id=107554

Reviewed by Philippe Normand.

gstreamer 0.10 doc led me to believe that gst_element_factory_make()
was not returning a floating reference. However, based on testing
(and results on Qt port) it does so we should NOT adopt the
returned GstElement object.

No new tests, already covered by existing tests.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: do not highlight really long lines in DTE.
commit-queue@webkit.org [Tue, 22 Jan 2013 14:43:38 +0000 (14:43 +0000)]
Web Inspector: do not highlight really long lines in DTE.
https://bugs.webkit.org/show_bug.cgi?id=107531

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-01-22
Reviewed by Pavel Feldman.

Source/WebCore:

Improve TextEditorHighlighter.orderedRangesPerLine method to return
only ranges that start before particular column.

Test: inspector/editor/text-editor-long-line.html

* inspector/front-end/TextEditorHighlighter.js:
(WebInspector.TextEditorHighlighter):
(WebInspector.TextEditorHighlighter.prototype.setHighlightLineLimit):
(WebInspector.TextEditorHighlighter.prototype.orderedRangesPerLine.comparator):
(WebInspector.TextEditorHighlighter.prototype.orderedRangesPerLine):

LayoutTests:

Layout test to verify that Default Text Editor does not spend time for
highlighting really long lines of code.

* inspector/editor/highlighter-long-line.html: Correct highlighter defaults in initialization.
* inspector/editor/text-editor-long-line-expected.txt: Added.
* inspector/editor/text-editor-long-line.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GStreamer][Soup] Let GStreamer provide the buffer data is downloaded to, to avoid...
kov@webkit.org [Tue, 22 Jan 2013 14:40:50 +0000 (14:40 +0000)]
[GStreamer][Soup] Let GStreamer provide the buffer data is downloaded to, to avoid copying
https://bugs.webkit.org/show_bug.cgi?id=105552

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-01-22
Reviewed by Philippe Normand.

Makes it possible for the GStreamer media backend to provide the buffer to which
the Soup networking backend will use to download data to. This makes copying
memory unnecessary when ResourceHandle hands data over to the media player's
StreamingClient. Thanks to Dan Winship for help designing the interface.

No behaviour change, covered by existing tests.

* platform/graphics/gstreamer/GStreamerVersioning.cpp:
(createGstBufferForData): New helper to create a GstBuffer when
we have a data pointer and a length.
(getGstBufferSize): Abstract obtaining the size of the buffer, so the code
is cleaner while still working for both GST 0.10 and 1.0.
(setGstBufferSize): Ditto, but for setting the size.
(getGstBufferDataPointer): Ditto, but for grabbing the data pointer.
(mapGstBuffer): Convenience method to take care of mapping the buffer so that
we can provide the data pointer to ResourceHandle.
(unmapGstBuffer): Convenience method which takes care of unmapping the buffer
and properly freeing the GstMapInfo.
* platform/graphics/gstreamer/GStreamerVersioning.h:
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(StreamingClient): New methods.
(_WebKitWebSrcPrivate): We now store the GstBuffer we provided the data pointer from
so we can later unmap it and push it to the pipeline.
(webKitWebSrcDispose): Deal with the GstBuffer in case it exists when the source is
destroyed.
(webKitWebSrcStop): Also clear the GstBuffer in this case.
(StreamingClient::didReceiveData): Handle the hand-over of the buffer.
(StreamingClient::getBuffer): Provide ResourceHandle with a new GstBuffer's data pointer.
* platform/network/ResourceHandleClient.h:
(ResourceHandleClient):
(WebCore::ResourceHandleClient::ResourceHandleClient): Constructor to initialize the buffer
member variable to 0.
(WebCore::ResourceHandleClient::~ResourceHandleClient): Destructor to free the buffer if it
has been allocated.
(WebCore::ResourceHandleClient::getBuffer): Default implementation which returns a
newly allocated char pointer.
* platform/network/ResourceHandleInternal.h:
(WebCore::ResourceHandleInternal::ResourceHandleInternal):
(ResourceHandleInternal): Store actual buffer size, which is no longer a constant.
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::cleanupSoupRequestOperation): Clear the buffer pointer, the life-cycle of the
buffer is handled by the ResourceHandleClient.
(WebCore::nextMultipartResponsePartCallback): Get a new buffer from the client before reading.
(WebCore::sendRequestCallback): Ditto.
(WebCore::readCallback): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Fix context menu localized string
commit-queue@webkit.org [Tue, 22 Jan 2013 14:20:44 +0000 (14:20 +0000)]
[EFL] Fix context menu localized string
https://bugs.webkit.org/show_bug.cgi?id=107536

One of localized string has a marker. Since EFL port does not support them
it has to be removed, so the string will be displayed properly.

Patch by Michał Pakuła vel Rutka <m.pakula@samsung.com> on 2013-01-22
Reviewed by Laszlo Gombos.

* platform/efl/LocalizedStringsEfl.cpp:
(WebCore::contextMenuItemTagCheckSpellingWhileTyping)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd myself to commiters.py
commit-queue@webkit.org [Tue, 22 Jan 2013 13:43:11 +0000 (13:43 +0000)]
Add myself to commiters.py
https://bugs.webkit.org/show_bug.cgi?id=107546

Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2013-01-22
Reviewed by Kentaro Hara.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][Chromium] Unreviewed gardening.
thiago.santos@intel.com [Tue, 22 Jan 2013 13:33:12 +0000 (13:33 +0000)]
[EFL][Chromium] Unreviewed gardening.

Added expectations for a crashing EFL test and fixed
a typo on Chromium's expectations for the same test.

* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Enable sub-pixel tests
dominik.rottsches@intel.com [Tue, 22 Jan 2013 13:26:25 +0000 (13:26 +0000)]
[EFL] Enable sub-pixel tests
https://bugs.webkit.org/show_bug.cgi?id=107548

Unreviewed gardening.

I will run this through EWS'ses and give others a chance to comment
since I am removing the sub-pixel skipping from the wk2/TestExpectations file.
This set of tests seems to be specifically skipped
in all platforms that don't want to run these tests.

* platform/efl/TestExpectations:
* platform/efl/fast/sub-pixel/inline-block-with-padding-expected.txt: Added.
* platform/efl/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.png: Added.
* platform/efl/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.txt: Added.
* platform/efl/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.png: Added.
* platform/efl/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.txt: Added.
* platform/efl/fast/sub-pixel/sub-pixel-accumulates-to-layers-expected.png: Added.
* platform/efl/fast/sub-pixel/sub-pixel-accumulates-to-layers-expected.txt: Added.
* platform/efl/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.png: Added.
* platform/efl/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.txt: Added.
* platform/efl/fast/sub-pixel/transformed-iframe-copy-on-scroll-expected.png: Added.
* platform/efl/fast/sub-pixel/transformed-iframe-copy-on-scroll-expected.txt: Added.
* platform/wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r140412.
commit-queue@webkit.org [Tue, 22 Jan 2013 13:09:10 +0000 (13:09 +0000)]
Unreviewed, rolling out r140412.
http://trac.webkit.org/changeset/140412
https://bugs.webkit.org/show_bug.cgi?id=107549

Broke rendering of buttons on gmail (Requested by carewolf on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-22

* platform/graphics/qt/TransparencyLayer.h:
(WebCore::TransparencyLayer::TransparencyLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[gstreamer] MediaPlayerPrivateGStreamer should take ownership of the playbin
christophe.dumez@intel.com [Tue, 22 Jan 2013 12:55:22 +0000 (12:55 +0000)]
[gstreamer] MediaPlayerPrivateGStreamer should take ownership of the playbin
https://bugs.webkit.org/show_bug.cgi?id=107445

Reviewed by Philippe Normand.

In gstreamer 1.0, gst_element_factory_make() now returns a floating reference.
MediaPlayerPrivateGStreamer calls gst_element_factory_make() to create the
playbin object but does not take ownership of the object. As a consequence,
the object keeps floating until it is unref'd in the
MediaPlayerPrivateGStreamer destructor.

This patch uses a GRefPtr<GstElement> to store the playbin object and only
adopt the object returned by gst_element_factory_make() if gstreamer 0.10
is used. When gstreamer 1.0 is used, the returned object will not be adopted,
which will remove the floating reference. This way, we ensure that the
playbin object is owned by MediaPlayerPrivateGStreamer.

No new tests, no behavior change for layout tests.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::load):
(WebCore::MediaPlayerPrivateGStreamer::playbackPosition):
(WebCore::MediaPlayerPrivateGStreamer::changePipelineState):
(WebCore::MediaPlayerPrivateGStreamer::duration):
(WebCore::MediaPlayerPrivateGStreamer::seek):
(WebCore::MediaPlayerPrivateGStreamer::paused):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVideo):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfAudio):
(WebCore::MediaPlayerPrivateGStreamer::setVolume):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVolumeChange):
(WebCore::MediaPlayerPrivateGStreamer::setRate):
(WebCore::MediaPlayerPrivateGStreamer::buffered):
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
(WebCore::MediaPlayerPrivateGStreamer::fillTimerFired):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(MediaPlayerPrivateGStreamer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Fix closure compiler warning in inspector front-end after r140390.
yurys@chromium.org [Tue, 22 Jan 2013 12:46:03 +0000 (12:46 +0000)]
Unreviewed. Fix closure compiler warning in inspector front-end after r140390.

* inspector/front-end/HeapSnapshotView.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Box shadows on a transparency layer is very slow
allan.jensen@digia.com [Tue, 22 Jan 2013 12:36:14 +0000 (12:36 +0000)]
[Qt] Box shadows on a transparency layer is very slow
https://bugs.webkit.org/show_bug.cgi?id=107547

Reviewed by Noam Rosenthal.

Set an initial clip on the transparency layer, so that the clipping
bounds will never end up larger than the layer.

* platform/graphics/qt/TransparencyLayer.h:
(WebCore::TransparencyLayer::TransparencyLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove top layer flag from ElementRareData to NodeFlags
falken@chromium.org [Tue, 22 Jan 2013 12:15:14 +0000 (12:15 +0000)]
Move top layer flag from ElementRareData to NodeFlags
https://bugs.webkit.org/show_bug.cgi?id=107542

Reviewed by Hajime Morita.

This is a speculative fix for a perf regression (https://bugs.webkit.org/show_bug.cgi?id=106726)
likely due to checking the top layer flag in Element::removedFrom. It
also simplifies code dealing with top layer and makes it no longer
necessary to allocate rare data for top layer.

* dom/Element.cpp:
(WebCore::Element::removedFrom): Check isInTopLayer first in case it helps fix the perf regression.
(WebCore):
* dom/Element.h: Move top layer functions from Element to Node.
* dom/ElementRareData.h:
(ElementRareData):
(WebCore::ElementRareData::ElementRareData): Remove top layer flag from ElementRareData.
* dom/Node.cpp: Move top layer functions from Element to Node.
(WebCore):
(WebCore::Node::setIsInTopLayer):
* dom/Node.h:
(Node):
(WebCore::Node::isInTopLayer):
* dom/NodeRenderingContext.cpp: Remove unnecessary casts to Element for isInTopLayer().
(WebCore::isRendererReparented):
(WebCore::NodeRenderingContext::previousRenderer):
(WebCore::NodeRenderingContext::parentRenderer):
* rendering/RenderLayer.cpp: Ditto.
(WebCore::RenderLayer::isInTopLayer):
(WebCore::RenderLayer::rebuildZOrderLists):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix broken mac builds due to <http://trac.webkit.org/changeset/140399>.
mark.lam@apple.com [Tue, 22 Jan 2013 12:11:06 +0000 (12:11 +0000)]
Fix broken mac builds due to <trac.webkit.org/changeset/140399>.
https://bugs.webkit.org/show_bug.cgi?id=100710.

Not reviewed.

No new tests.

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[v8] Convert string conversion calls to one byte versions
commit-queue@webkit.org [Tue, 22 Jan 2013 11:59:19 +0000 (11:59 +0000)]
[v8] Convert string conversion calls to one byte versions
https://bugs.webkit.org/show_bug.cgi?id=107524

Patch by Dan Carney <dcarney@google.com> on 2013-01-22
Reviewed by Kentaro Hara.

No new tests. No change in functionality.

* bindings/v8/SerializedScriptValue.cpp:
* bindings/v8/V8StringResource.cpp:
(WebCore::WebCoreStringResourceBase::toWebCoreStringResourceBase):
(StringTraits):
(WebCore::true):
(WebCore::v8StringToWebCoreString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Network] CookiesTable refactoring.
commit-queue@webkit.org [Tue, 22 Jan 2013 11:57:31 +0000 (11:57 +0000)]
Web Inspector: [Network] CookiesTable refactoring.
https://bugs.webkit.org/show_bug.cgi?id=107511

Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2013-01-22
Reviewed by Pavel Feldman.

CookiesTable uses integer indexes as column identifiers.
This leads to cryptic code.

Descriptive column identifiers will make code clearer.
Also "addCookiesFolder" replaced with "setCookieFolders" to avoid
repetitive "_rebuildTable" invocation.

* inspector/front-end/CookiesTable.js:
(WebInspector.CookiesTable): Use descriptive column identifiers.
(WebInspector.CookiesTable.prototype.setCookieFolders):
Accept multiple folders.
(WebInspector.CookiesTable.prototype._rebuildTable):
Use descriptive column identifiers.
(WebInspector.CookiesTable.prototype._sortCookies):
Ditto.
(WebInspector.CookiesTable.prototype._createGridNode):
Ditto.
* inspector/front-end/RequestCookiesView.js:
(WebInspector.RequestCookiesView.prototype._buildCookiesTable):
Use "setCookieFolders".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Disable support for unprefixed CSS animations, transitions, transforms in relea...
zandobersek@gmail.com [Tue, 22 Jan 2013 11:41:46 +0000 (11:41 +0000)]
[GTK] Disable support for unprefixed CSS animations, transitions, transforms in release builds
https://bugs.webkit.org/show_bug.cgi?id=107436

Reviewed by Alexis Menard.

Disable the unprefixed CSS animations, transitions and transforms support
in the release builds for now. The work in this area is not yet complete
and should not ship in such state.

No new tests - no new functionality.

* GNUmakefile.features.am.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Tue, 22 Jan 2013 11:31:36 +0000 (11:31 +0000)]
Unreviewed GTK gardening.

Adding back an expectation that was errornously removed in r140404.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [REGRESSION] SASSSourceMapping broken: _bindUISourceCode method is...
apavlov@chromium.org [Tue, 22 Jan 2013 11:13:13 +0000 (11:13 +0000)]
Web Inspector: [REGRESSION] SASSSourceMapping broken: _bindUISourceCode method is absent
https://bugs.webkit.org/show_bug.cgi?id=107529

Reviewed by Pavel Feldman.

* inspector/front-end/SASSSourceMapping.js:
(WebInspector.SASSSourceMapping.prototype._fileSaveFinished):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Tue, 22 Jan 2013 10:34:29 +0000 (10:34 +0000)]
Unreviewed GTK gardening.

Adding timeout expectations for two tests from the JSRegress suite that
were added in r140276. The timeouts are GTK-specific.
Expanding the main failure expectation for all Encrypted Media tests to
expect either failures or timeouts.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAtomicMarkupTokenBase must die
abarth@webkit.org [Tue, 22 Jan 2013 10:26:20 +0000 (10:26 +0000)]
AtomicMarkupTokenBase must die
https://bugs.webkit.org/show_bug.cgi?id=107513

Reviewed by Eric Seidel.

Now that NEW_XML has been removed from the tree, there is no reason to
have AtomicMarkupTokenBase exist as a templated base class for
AtomicHTMLToken. This patch just merges the code back into
AtomicHTMLToken.

* html/parser/HTMLToken.h:
(AtomicHTMLToken):
(WebCore::AtomicHTMLToken::type):
(WebCore::AtomicHTMLToken::name):
(WebCore::AtomicHTMLToken::setName):
(WebCore::AtomicHTMLToken::selfClosing):
(WebCore::AtomicHTMLToken::getAttributeItem):
(WebCore::AtomicHTMLToken::attributes):
(WebCore::AtomicHTMLToken::characters):
(WebCore::AtomicHTMLToken::charactersLength):
(WebCore::AtomicHTMLToken::isAll8BitData):
(WebCore::AtomicHTMLToken::comment):
(WebCore::AtomicHTMLToken::publicIdentifier):
(WebCore::AtomicHTMLToken::systemIdentifier):
(WebCore::AtomicHTMLToken::clearExternalCharacters):
(WebCore::AtomicHTMLToken::AtomicHTMLToken):
(WebCore::AtomicMarkupTokenBase::initializeAttributes):
(WebCore):
* xml/parser/MarkupTokenBase.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTurn on ENABLE_THREADED_HTML_PARSER for Chromium (it's still disabled at runtime)
eric@webkit.org [Tue, 22 Jan 2013 10:24:30 +0000 (10:24 +0000)]
Turn on ENABLE_THREADED_HTML_PARSER for Chromium (it's still disabled at runtime)
https://bugs.webkit.org/show_bug.cgi?id=107519

Reviewed by Adam Barth.

Source/WebCore:

Add some ASSERTs to be double-dog-sure that we're never using
any of the threading code when threading is not enabled.

I also removed an if-branch in the !ENABLE_THREADED_HTML_PARSER case
as it's not needed.

* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::prepareToStopParsing):
(WebCore::HTMLDocumentParser::startBackgroundParser):
(WebCore::HTMLDocumentParser::stopBackgroundParser):

Source/WebKit/chromium:

This makes our development lives easier, and makes it possible for the bots
to run threaded-parser-only tests by toggling the runtime enable
via window.internals.settings.

* features.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Make an Isolate parameter mandatory in toV8()
haraken@chromium.org [Tue, 22 Jan 2013 09:48:22 +0000 (09:48 +0000)]
[V8] Make an Isolate parameter mandatory in toV8()
https://bugs.webkit.org/show_bug.cgi?id=107520

Reviewed by Adam Barth.

Now it's safe to remove an optional Isolate parameter.

No tests. No change in behavior.

Source/WebCore:

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
* bindings/scripts/test/V8/V8Float64Array.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestEventConstructor.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestEventTarget.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestException.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestInterface.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestNamedConstructor.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestNode.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestObj.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestOverloadedConstructors.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(WebCore::toV8):
* css/MediaQueryListListener.cpp:
(WebCore::MediaQueryListListener::queryChanged):
* testing/v8/WebCoreTestSupport.cpp:
(WebCoreTestSupport::injectInternalsObject):

Source/WebKit/chromium:

* src/InspectorFrontendClientImpl.cpp:
(WebKit::InspectorFrontendClientImpl::windowObjectCleared):
* src/WebArrayBuffer.cpp:
(WebKit::WebArrayBuffer::toV8Value):
* src/WebBlob.cpp:
(WebKit::WebBlob::toV8Value):
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::createFileSystem):
(WebKit::WebFrameImpl::createSerializableFileSystem):
(WebKit::WebFrameImpl::createFileEntry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Regions] min-max height will not trigger a relayout when set on a region with...
mihnea@adobe.com [Tue, 22 Jan 2013 09:43:45 +0000 (09:43 +0000)]
[CSS Regions] min-max height will not trigger a relayout when set on a region with auto-height
https://bugs.webkit.org/show_bug.cgi?id=103738

Reviewed by David Hyatt.

Source/WebCore:

When the style of an auto-height region changes with different min/max-height, we have to make sure
that the 2-pass layout algorithm is run so that the region height is properly computed. When doing a 2-pass layout
for auto-height regions, we have to make sure that in the first pass, all auto-height regions start without a previously
computed overrideLogicalContentHeight, otherwise we may end-up with incorrect results, illustrated by tests
autoheight-two-pass-layout-complex-001.html and autoheight-two-pass-layout-complex-002.html.

If we do not have auto height regions, a single pass layout in enough to correctly flow content inside regions.
When we have auto height regions, the algorithm to lay out content should be:
1. If the flow thread content does not need lay out, we do a single pass layout.
If during the layout, an auto-height region needs layout or a normal (not auto height) region changes its box dimensions,
we need to perform a new 2-pass layout after this layout completes. If not, we bail out and skip step 2.
2. Do a full two pass layout and make sure that all auto height regions start the 2-pass layout without a previously computed
override logical content height.

Tests: fast/regions/autoheight-region-decrease-maxheight.html
       fast/regions/autoheight-region-decrease-minheight.html
       fast/regions/autoheight-region-decrease-width.html
       fast/regions/autoheight-region-increase-maxheight.html
       fast/regions/autoheight-region-increase-minheight.html
       fast/regions/autoheight-region-increase-width.html
       fast/regions/autoheight-region-new-maxheight-vrl.html
       fast/regions/autoheight-region-new-maxheight.html
       fast/regions/autoheight-region-new-minheight-vlr.html
       fast/regions/autoheight-region-new-minheight.html
       fast/regions/autoheight-region-remove-maxheight.html
       fast/regions/autoheight-region-remove-minheight.html
       fast/regions/autoheight-two-pass-layout-complex-001.html
       fast/regions/autoheight-two-pass-layout-complex-002.html
       fast/regions/region-height-auto-to-defined.html
       fast/regions/region-height-defined-to-auto.html

* rendering/FlowThreadController.cpp: Added a flag that is needed to mark whether we need a full 2-pass layout.
(WebCore::FlowThreadController::FlowThreadController):
* rendering/FlowThreadController.h:
(WebCore::FlowThreadController::needsTwoPassLayoutForAutoHeightRegions):
(WebCore::FlowThreadController::setNeedsTwoPassLayoutForAutoHeightRegions):
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::resetRegionsOverrideLogicalContentHeight): Use invalidateRegions because we need also to mark the flow thread as needing layout.
(WebCore::RenderFlowThread::markAutoLogicalHeightRegionsForLayout):
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::layout): Make sure we do a 2-pass layout if needed.
* rendering/RenderView.cpp:
(WebCore::RenderView::layoutContentInAutoLogicalHeightRegions): Added a new function that models the layout algorithm for the case when we have auto height regions
and flow threads.
(WebCore::RenderView::layout):
(WebCore::RenderView::checkTwoPassLayoutForAutoHeightRegions):
* rendering/RenderView.h:

LayoutTests:

Added tests for dynamically change the min/max-height for auto-height regions, including also vertical writing modes.
Added tests for dynamically changing the width of auto-height regions to make sure we are correctly computing their height.
Added two tests for complex auto-height regions layout which require a full two-pass layout after some regions from region
chain are laid out.

* fast/regions/autoheight-region-decrease-maxheight-expected.txt: Added.
* fast/regions/autoheight-region-decrease-maxheight.html: Added.
* fast/regions/autoheight-region-decrease-minheight-expected.txt: Added.
* fast/regions/autoheight-region-decrease-minheight.html: Added.
* fast/regions/autoheight-region-decrease-width-expected.txt: Added.
* fast/regions/autoheight-region-decrease-width.html: Added.
* fast/regions/autoheight-region-increase-maxheight-expected.txt: Added.
* fast/regions/autoheight-region-increase-maxheight.html: Added.
* fast/regions/autoheight-region-increase-minheight-expected.txt: Added.
* fast/regions/autoheight-region-increase-minheight.html: Added.
* fast/regions/autoheight-region-increase-width-expected.txt: Added.
* fast/regions/autoheight-region-increase-width.html: Added.
* fast/regions/autoheight-region-new-maxheight-expected.txt: Added.
* fast/regions/autoheight-region-new-maxheight-vrl-expected.txt: Added.
* fast/regions/autoheight-region-new-maxheight-vrl.html: Added.
* fast/regions/autoheight-region-new-maxheight.html: Added.
* fast/regions/autoheight-region-new-minheight-expected.txt: Added.
* fast/regions/autoheight-region-new-minheight-vlr-expected.txt: Added.
* fast/regions/autoheight-region-new-minheight-vlr.html: Added.
* fast/regions/autoheight-region-new-minheight.html: Added.
* fast/regions/autoheight-region-remove-maxheight-expected.txt: Added.
* fast/regions/autoheight-region-remove-maxheight.html: Added.
* fast/regions/autoheight-region-remove-minheight-expected.txt: Added.
* fast/regions/autoheight-region-remove-minheight.html: Added.
* fast/regions/autoheight-two-pass-layout-complex-001-expected.txt: Added.
* fast/regions/autoheight-two-pass-layout-complex-001.html: Added.
* fast/regions/autoheight-two-pass-layout-complex-002-expected.txt: Added.
* fast/regions/autoheight-two-pass-layout-complex-002.html: Added.
* fast/regions/region-height-auto-to-defined-expected.txt: Added.
* fast/regions/region-height-auto-to-defined.html: Added.
* fast/regions/region-height-defined-to-auto-expected.txt: Added.
* fast/regions/region-height-defined-to-auto.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoENABLE(NEW_XML) isn't used by anyone and no one is actively working on it
abarth@webkit.org [Tue, 22 Jan 2013 09:16:16 +0000 (09:16 +0000)]
ENABLE(NEW_XML) isn't used by anyone and no one is actively working on it
https://bugs.webkit.org/show_bug.cgi?id=100710

Reviewed by Eric Seidel.

As discussed on webkit-dev
<http://lists.webkit.org/pipermail/webkit-dev/2012-August/022103.html>,
ENABLE(NEW_XML) isn't used by anyone and no one is actively working on
it. We should remove it from the code base for the time being. If folks
want to work on it again, we can restore it from SVN history.

* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/Document.cpp:
(WebCore::Document::createParser):
* dom/DocumentFragment.cpp:
(WebCore::DocumentFragment::parseXML):
* xml/parser/NewXMLDocumentParser.cpp: Removed.
* xml/parser/NewXMLDocumentParser.h: Removed.
* xml/parser/XMLCharacterReferenceParser.cpp: Removed.
* xml/parser/XMLCharacterReferenceParser.h: Removed.
* xml/parser/XMLToken.h: Removed.
* xml/parser/XMLTokenizer.cpp: Removed.
* xml/parser/XMLTokenizer.h: Removed.
* xml/parser/XMLTreeBuilder.cpp: Removed.
* xml/parser/XMLTreeBuilder.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebKit/gtk: [GTK] Add listener for direction-changed signal in WebKitWebView
commit-queue@webkit.org [Tue, 22 Jan 2013 09:15:07 +0000 (09:15 +0000)]
Source/WebKit/gtk: [GTK] Add listener for direction-changed signal in WebKitWebView
https://bugs.webkit.org/show_bug.cgi?id=107131

Patch by Manuel Rego Casasnovas <rego@igalia.com> on 2013-01-22
Reviewed by Philippe Normand.

* webkit/webkitwebview.cpp:
(webkit_web_view_init): Add listener for direction-changed signal.
(webkitWebViewDirectionChanged): Implement listener using
Editor::setBaseWritingDirection().

Tools: [GTK] Implement TestRunner::setTextDirection
https://bugs.webkit.org/show_bug.cgi?id=107131

Patch by Manuel Rego Casasnovas <rego@igalia.com> on 2013-01-22
Reviewed by Philippe Normand.

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues): Reset direction to default value.
* DumpRenderTree/gtk/TestRunnerGtk.cpp:
(TestRunner::setTextDirection): Implement method using
gtk_widget_set_direction.

LayoutTests: [GTK] Implement testRunner::setTextDirection
https://bugs.webkit.org/show_bug.cgi?id=107131

Patch by Manuel Rego Casasnovas <rego@igalia.com> on 2013-01-22
Reviewed by Philippe Normand.

* platform/gtk-wk2/TestExpectations: Unflag
fast/html/set-text-direction.html as it was already passing in WK2.
* platform/gtk/TestExpectations: Remove
fast/html/set-text-direction.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Pass an Isolate to toV8() of event listeners
haraken@chromium.org [Tue, 22 Jan 2013 09:06:22 +0000 (09:06 +0000)]
[V8] Pass an Isolate to toV8() of event listeners
https://bugs.webkit.org/show_bug.cgi?id=107517

Reviewed by Adam Barth.

By using Context::GetIsolate(), this patch passes an Isolate to toV8().
I think this would be the last patch to pass an Isolate to toV8().
In the next patch, I will make an Isolate parameter mandatory for toV8().

No tests. No change in behavior.

* bindings/v8/V8AbstractEventListener.cpp:
(WebCore::V8AbstractEventListener::getReceiverObject):
* bindings/v8/V8AbstractEventListener.h:
(V8AbstractEventListener):
* bindings/v8/V8EventListener.cpp:
(WebCore::V8EventListener::callListenerFunction):
* bindings/v8/V8LazyEventListener.cpp:
(WebCore::toObjectWrapper):
(WebCore::V8LazyEventListener::callListenerFunction):
(WebCore::V8LazyEventListener::prepareListenerObject):
* bindings/v8/V8WorkerContextEventListener.cpp:
(WebCore::V8WorkerContextEventListener::getReceiverObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] move spell checking mocks to TestRunner library
jochen@chromium.org [Tue, 22 Jan 2013 09:00:37 +0000 (09:00 +0000)]
[chromium] move spell checking mocks to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=107455

Reviewed by Kent Tamura.

The content module doesn't provide its own WebSpellCheckClient.

* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
(WebTestRunner::WebTestDelegate::fillSpellingSuggestionList):
* DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
(WebKit):
(WebTestRunner):
(WebTestProxyBase):
* DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
(WebTestRunner):
(WebTestRunner::makeMenuItemStringsFor):
* DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Renamed from Tools/DumpRenderTree/chromium/MockGrammarCheck.cpp.
(MockGrammarCheck::checkGrammarOfString):
* DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Renamed from Tools/DumpRenderTree/chromium/MockGrammarCheck.h.
(WebKit):
(MockGrammarCheck):
* DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Renamed from Tools/DumpRenderTree/chromium/MockSpellCheck.cpp.
(MockSpellCheck::MockSpellCheck):
(MockSpellCheck::~MockSpellCheck):
(isNotASCIIAlpha):
(MockSpellCheck::spellCheckWord):
(MockSpellCheck::fillSuggestionList):
(MockSpellCheck::initializeIfNeeded):
* DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Renamed from Tools/DumpRenderTree/chromium/MockSpellCheck.h.
(MockSpellCheck):
* DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Added.
(WebTestRunner::SpellCheckClient::SpellCheckClient):
(WebTestRunner):
(WebTestRunner::SpellCheckClient::~SpellCheckClient):
(WebTestRunner::SpellCheckClient::setDelegate):
(WebTestRunner::SpellCheckClient::spellCheck):
(WebTestRunner::SpellCheckClient::checkTextOfParagraph):
(WebTestRunner::SpellCheckClient::requestCheckingOfText):
(WebTestRunner::SpellCheckClient::finishLastTextCheck):
(WebTestRunner::SpellCheckClient::autoCorrectWord):
* DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h.
(WebTestRunner):
(SpellCheckClient):
(WebTestRunner::SpellCheckClient::taskList):
(WebTestRunner::SpellCheckClient::mockSpellCheck):
* DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
(TestDelegate):
* DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
(WebTestInterfaces::Internal):
* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::WebTestProxyBase):
(WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
(WebTestRunner::WebTestProxyBase::setDelegate):
(WebTestRunner::WebTestProxyBase::spellCheckClient):
(WebTestRunner):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::WebViewHost):
(WebViewHost::setWebWidget):
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening.
christophe.dumez@intel.com [Tue, 22 Jan 2013 08:58:38 +0000 (08:58 +0000)]
Unreviewed EFL gardening.

Unskip 2 tests that were sometimes asserting on the bots as
the problems seems to have been fixed in r140166.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPDFPlugin: Build PDFPlugin everywhere, enable at runtime
timothy_horton@apple.com [Tue, 22 Jan 2013 08:38:29 +0000 (08:38 +0000)]
PDFPlugin: Build PDFPlugin everywhere, enable at runtime
https://bugs.webkit.org/show_bug.cgi?id=107117

Reviewed by Alexey Proskuryakov.

Since PDFLayerController SPI is all forward-declared, the plugin should build
on all Mac platforms, and can be enabled at runtime.

* Configurations/FeatureDefines.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAX: Should assert if we try to create two AXObjects that point to the same renderer...
dmazzoni@google.com [Tue, 22 Jan 2013 08:33:45 +0000 (08:33 +0000)]
AX: Should assert if we try to create two AXObjects that point to the same renderer or node
https://bugs.webkit.org/show_bug.cgi?id=107504

Reviewed by Chris Fleizach.

If two accessibility objects get created that point to the
same widget, renderer, or node, that can lead to crashes or
memory corruption later; make it assert instead of crashing.

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::getOrCreate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Pass an Isolate to toV8()
haraken@chromium.org [Tue, 22 Jan 2013 08:32:01 +0000 (08:32 +0000)]
[V8] Pass an Isolate to toV8()
https://bugs.webkit.org/show_bug.cgi?id=107512

Reviewed by Adam Barth.

By using Context::GetIsolate(), this patch passes an Isolate to toV8().

No tests. No change in behavior.

* bindings/v8/IDBBindingUtilities.cpp:
(WebCore::injectIDBKeyIntoScriptValue):
(WebCore::idbKeyToScriptValue):
* bindings/v8/ScriptController.cpp:
(WebCore::createScriptObject):
(WebCore::ScriptController::createScriptObjectForPluginElement):
* bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::currentCallFrame):
* bindings/v8/ScriptObject.cpp:
(WebCore::ScriptGlobalObject::set):
* bindings/v8/V8AbstractEventListener.cpp:
(WebCore::V8AbstractEventListener::handleEvent):
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::updateDocumentProperty):
* bindings/v8/V8MutationCallback.cpp:
(WebCore::V8MutationCallback::handleEvent):
* bindings/v8/V8NodeFilterCondition.cpp:
(WebCore::V8NodeFilterCondition::acceptNode):
* bindings/v8/V8WorkerContextEventListener.cpp:
(WebCore::V8WorkerContextEventListener::handleEvent):
* bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
(WebCore::V8SQLStatementErrorCallback::handleEvent):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::nodeAsScriptValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Show requests in `curl` syntax in DevTools → Network → Headers
commit-queue@webkit.org [Tue, 22 Jan 2013 08:13:08 +0000 (08:13 +0000)]
Web Inspector: Show requests in `curl` syntax in DevTools → Network → Headers
https://bugs.webkit.org/show_bug.cgi?id=107276

Patch by Sergey Ryazanov <serya@chromium.org> on 2013-01-22
Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/curl-command.html

* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._generateCurlCommand):

LayoutTests:

* inspector/curl-command-expected.txt: Added.
* inspector/curl-command.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: reuse JS heap profiler UI for native heap graph representaion
yurys@chromium.org [Tue, 22 Jan 2013 08:10:10 +0000 (08:10 +0000)]
Web Inspector: reuse JS heap profiler UI for native heap graph representaion
https://bugs.webkit.org/show_bug.cgi?id=107452

Reviewed by Pavel Feldman.

NativeHeapSnapshot is introduced to leverage JS heap snapshot processing algorithms
for native heap graph. New snapshot type ("Native Heap Snapshot") is added to the
profiles panel. It will represent native heap snapshots using the same UI as we use
for JS heap snapshots.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot):
(WebInspector.HeapSnapshot.prototype._init):
* inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotWorker):
* inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapProfileHeader.prototype.load):
(WebInspector.HeapProfileHeader.prototype.startSnapshotTransfer): extracted a few methods
to support overrides for native heap snapshots.
(WebInspector.HeapProfileHeader.prototype.snapshotConstructorName):
(WebInspector.HeapProfileHeader.prototype._setupWorker):
* inspector/front-end/NativeHeapSnapshot.js: Added.
(WebInspector.NativeHeapSnapshot):
(WebInspector.NativeHeapSnapshot.prototype.createNode):
(WebInspector.NativeHeapSnapshot.prototype.createEdge):
(WebInspector.NativeHeapSnapshot.prototype.createRetainingEdge):
(WebInspector.NativeHeapSnapshot.prototype._markInvisibleEdges):
(WebInspector.NativeHeapSnapshot.prototype._calculateFlags):
(WebInspector.NativeHeapSnapshot.prototype.canHaveDistanceOne):
(WebInspector.NativeHeapSnapshot.prototype.userObjectsMapAndFlag):
(WebInspector.NativeHeapSnapshotNode):
(WebInspector.NativeHeapSnapshotNode.prototype.canBeQueried):
(WebInspector.NativeHeapSnapshotNode.prototype.isUserObject):
(WebInspector.NativeHeapSnapshotNode.prototype.className):
(WebInspector.NativeHeapSnapshotNode.prototype.classIndex):
(WebInspector.NativeHeapSnapshotNode.prototype.id):
(WebInspector.NativeHeapSnapshotNode.prototype.name):
(WebInspector.NativeHeapSnapshotNode.prototype.isHidden):
(WebInspector.NativeHeapSnapshotNode.prototype.isSynthetic):
(WebInspector.NativeHeapSnapshotNode.prototype.isWindow):
(WebInspector.NativeHeapSnapshotNode.prototype.isDetachedDOMTreesRoot):
(WebInspector.NativeHeapSnapshotNode.prototype.isDetachedDOMTree):
(WebInspector.NativeHeapSnapshotEdge):
(WebInspector.NativeHeapSnapshotEdge.prototype.clone):
(WebInspector.NativeHeapSnapshotEdge.prototype.hasStringName):
(WebInspector.NativeHeapSnapshotEdge.prototype.isElement):
(WebInspector.NativeHeapSnapshotEdge.prototype.isHidden):
(WebInspector.NativeHeapSnapshotEdge.prototype.isWeak):
(WebInspector.NativeHeapSnapshotEdge.prototype.isInternal):
(WebInspector.NativeHeapSnapshotEdge.prototype.isInvisible):
(WebInspector.NativeHeapSnapshotEdge.prototype.isShortcut):
(WebInspector.NativeHeapSnapshotEdge.prototype.name):
(WebInspector.NativeHeapSnapshotEdge.prototype.toString):
(WebInspector.NativeHeapSnapshotEdge.prototype._nameOrIndex):
(WebInspector.NativeHeapSnapshotRetainerEdge):
(WebInspector.NativeHeapSnapshotRetainerEdge.prototype.clone):
(WebInspector.NativeHeapSnapshotRetainerEdge.prototype.isElement):
(WebInspector.NativeHeapSnapshotRetainerEdge.prototype.isHidden):
(WebInspector.NativeHeapSnapshotRetainerEdge.prototype.isInternal):
(WebInspector.NativeHeapSnapshotRetainerEdge.prototype.isInvisible):
(WebInspector.NativeHeapSnapshotRetainerEdge.prototype.isShortcut):
(WebInspector.NativeHeapSnapshotRetainerEdge.prototype.isWeak):
* inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.NativeSnapshotProfileType):
(WebInspector.NativeSnapshotProfileType.prototype.get buttonTooltip):
(WebInspector.NativeSnapshotProfileType.prototype.buttonClicked.didReceiveMemorySnapshot):
(WebInspector.NativeSnapshotProfileType.prototype.buttonClicked):
(WebInspector.NativeSnapshotProfileType.prototype.get treeItemTitle):
(WebInspector.NativeSnapshotProfileType.prototype.get description):
(WebInspector.NativeSnapshotProfileType.prototype.createTemporaryProfile):
(WebInspector.NativeSnapshotProfileType.prototype.createProfile):
(WebInspector.NativeSnapshotProfileHeader):
(WebInspector.NativeSnapshotProfileHeader.prototype.createView):
(WebInspector.NativeSnapshotProfileHeader.prototype.startSnapshotTransfer):
(WebInspector.NativeSnapshotProfileHeader.prototype.snapshotConstructorName):
(WebInspector.NativeSnapshotProfileHeader.prototype._takeNativeSnapshot): build a datastructure
resembling one used for JS heap snapshots but populated with the data from the native snaphot.
(WebInspector.NativeHeapSnapshotView):
(WebInspector.NativeHeapSnapshotView.prototype.get profile):
(WebInspector.NativeMemoryProfileType):
(WebInspector.NativeMemoryProfileType.prototype.get buttonTooltip):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel):
* inspector/front-end/WebKit.qrc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebKit: [EFL] Adds Accessibility support to wk1
commit-queue@webkit.org [Tue, 22 Jan 2013 08:02:36 +0000 (08:02 +0000)]
Source/WebKit: [EFL] Adds Accessibility support to wk1
https://bugs.webkit.org/show_bug.cgi?id=107440

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-01-22
Reviewed by Gyuyoung Kim.

* PlatformEfl.cmake: Adds ATK headers and libraries.

Source/WebKit/efl: [EFL] Adds Accessibility support to wk1.
https://bugs.webkit.org/show_bug.cgi?id=107440

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-01-22
Reviewed by Gyuyoung Kim.

Adds possibility of focusing and retrieving accessible object.

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::rootAccessibleElement):
(DumpRenderTreeSupportEfl::focusedAccessibleElement):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools: [EFL] Adds Accessibility support to wk1
https://bugs.webkit.org/show_bug.cgi?id=107440

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-01-22
Reviewed by Gyuyoung Kim.

* DumpRenderTree/efl/CMakeLists.txt: Adds ATK headers and libraries.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Mac] WK1 MiniBrowser should clear delegates before releasing webview
commit-queue@webkit.org [Tue, 22 Jan 2013 07:39:52 +0000 (07:39 +0000)]
[Mac] WK1 MiniBrowser should clear delegates before releasing webview
https://bugs.webkit.org/show_bug.cgi?id=107506

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-01-21
Reviewed by Dan Bernstein.

* MiniBrowser/mac/WK1BrowserWindowController.m:
(-[WK1BrowserWindowController dealloc]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] ScriptState::isolate() should use Context::GetIsolate()
haraken@chromium.org [Tue, 22 Jan 2013 07:33:16 +0000 (07:33 +0000)]
[V8] ScriptState::isolate() should use Context::GetIsolate()
https://bugs.webkit.org/show_bug.cgi?id=107490

Reviewed by Adam Barth.

Now V8 provides Context::GetIsolate(). We should use it
in ScriptState::isolate().

* bindings/v8/ScriptState.h:
(WebCore::ScriptState::isolate):
(ScriptState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Missing context menus strings
commit-queue@webkit.org [Tue, 22 Jan 2013 06:42:23 +0000 (06:42 +0000)]
[EFL] Missing context menus strings
https://bugs.webkit.org/show_bug.cgi?id=107104

Patch by Michał Pakuła vel Rutka <m.pakula@samsung.com> on 2013-01-21
Reviewed by Kenneth Rohde Christiansen.

Add 5 missing localization strings for text direction context menus.

* platform/efl/LocalizedStringsEfl.cpp:
(WebCore::contextMenuItemTagRightToLeft):
(WebCore::contextMenuItemTagLeftToRight):
(WebCore::contextMenuItemTagWritingDirectionMenu):
(WebCore::contextMenuItemTagTextDirectionMenu):
(WebCore::contextMenuItemTagDefaultDirection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDate selection from calendar picker should dispatch 'input' event in addition to...
tkent@chromium.org [Tue, 22 Jan 2013 06:17:21 +0000 (06:17 +0000)]
Date selection from calendar picker should dispatch 'input' event in addition to 'change' event
https://bugs.webkit.org/show_bug.cgi?id=107427

Reviewed by Kentaro Hara.

Source/WebCore:

According to the specification and Opera's behavior, we should dispatch
not only 'change' event but also 'input' event when a user chooses a
date from the calender picker.

http://www.whatwg.org/specs/web-apps/current-work/multipage/common-input-element-attributes.html#common-event-behaviors
> When the user agent changes the element's value on behalf of the user
> (e.g. as part of a form prefilling feature), the user agent must follow
> these steps:
> 1. If the input event applies, queue a task to fire a simple event
> that bubbles named input at the input element.
> 2. If the change event applies, queue a task to fire a simple event
> that bubbles named change at the input element.

Tests: platform/chromium/fast/forms/calendar-picker/date-picker-events.html
       platform/chromium/fast/forms/calendar-picker/datetimelocal-picker-events.html

* html/InputType.cpp:
(WebCore::InputType::setValue): Add DispatchInputAndChangeEvent support.
* html/BaseChooserOnlyDateAndTimeInputType.cpp:
(WebCore::BaseChooserOnlyDateAndTimeInputType::didChooseValue):
Use DispatchInputAndChangeEvent, not DispatchChangeEvent.
* html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::pickerIndicatorChooseValue):
Ditto.

LayoutTests:

* platform/chromium/fast/forms/calendar-picker/date-picker-events-expected.txt: Added.
* platform/chromium/fast/forms/calendar-picker/date-picker-events.html: Added.
* platform/chromium/fast/forms/calendar-picker/datetimelocal-picker-events-expected.txt: Added.
* platform/chromium/fast/forms/calendar-picker/datetimelocal-picker-events.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CHROMIUM] Suppress c4267 build warnings for Win64 targets
jschuh@chromium.org [Tue, 22 Jan 2013 06:13:26 +0000 (06:13 +0000)]
[CHROMIUM] Suppress c4267 build warnings for Win64 targets
https://bugs.webkit.org/show_bug.cgi?id=107499

Reviewed by Abhishek Arya.

Source/JavaScriptCore:

* JavaScriptCore.gyp/JavaScriptCore.gyp:

Source/Platform:

* Platform.gyp/Platform.gyp:

Source/WebCore:

No new tests. No code changes.

* WebCore.gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCSSSelector::value() should assert that m_match != Tag.
akling@apple.com [Tue, 22 Jan 2013 06:02:03 +0000 (06:02 +0000)]
CSSSelector::value() should assert that m_match != Tag.
<http://webkit.org/b/107500>

Reviewed by Anders Carlsson.

Add an assertion to catch anyone trying to extract a value() from a Tag selector.

* css/CSSSelector.h:
(CSSSelector):
(WebCore::CSSSelector::value):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove HTML Attribute case-sensitivity logic out of SelectorChecker to HTMLDocument.
dglazkov@chromium.org [Tue, 22 Jan 2013 05:07:16 +0000 (05:07 +0000)]
Move HTML Attribute case-sensitivity logic out of SelectorChecker to HTMLDocument.
https://bugs.webkit.org/show_bug.cgi?id=107460

The case-sensitivity of HTML attributes is defined in HTML spec and is only applicable in HTML documents,
so having this logic in HTMLDocument seems like a good thing.

Reviewed by Eric Seidel.

Refactoring, covered by existing tests.

* css/SelectorChecker.cpp:
(WebCore): Moved code out of here.
(WebCore::isFastCheckableMatch): Changed the callsite to use new location.
(WebCore::SelectorChecker::checkOne): Ditto.
* html/HTMLDocument.cpp:
(WebCore::addLocalNameToSet): Moved the code into here.
(WebCore): Ditto.
(WebCore::createHtmlCaseInsensitiveAttributesSet): Ditto.
(WebCore::HTMLDocument::isCaseSensitiveAttribute): Ditto.
* html/HTMLDocument.h:
(HTMLDocument): Added decl for the newly moved function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFrameSelection should use shadowHost instead of shadowAncestorNode
shinyak@chromium.org [Tue, 22 Jan 2013 05:04:29 +0000 (05:04 +0000)]
FrameSelection should use shadowHost instead of shadowAncestorNode
https://bugs.webkit.org/show_bug.cgi?id=107220

Reviewed by Kent Tamura.

shadowAncestorNode() is deprecated and we want to use shadowHost.
Here, all objects calling shadowAncestorNode() is in ShadowDOM, we can safely convert
the call to shadowHost().

No new tests, simple refactoring.

* editing/FrameSelection.cpp:
(WebCore::FrameSelection::selectAll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled Chromium DEPS to r177962. Requested by
commit-queue@webkit.org [Tue, 22 Jan 2013 03:29:42 +0000 (03:29 +0000)]
Unreviewed.  Rolled Chromium DEPS to r177962.  Requested by
"Yoshifumi Inoue" <yosin@chromium.org> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-21

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] REGRESSION(r139347) roll chromium deps broke webkit-unit-tests
noel.gordon@gmail.com [Tue, 22 Jan 2013 02:41:42 +0000 (02:41 +0000)]
[chromium] REGRESSION(r139347) roll chromium deps broke webkit-unit-tests
https://bugs.webkit.org/show_bug.cgi?id=106631

Reviewed by Kent Tamura.

Fixed in http://crrev.com/177931 and rolled. Renable these tests.

* tests/WebImageTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Update webaudio/realtimeanalyser-fft-sizing.html expectation on Win
noel.gordon@gmail.com [Tue, 22 Jan 2013 02:37:16 +0000 (02:37 +0000)]
[chromium] Update webaudio/realtimeanalyser-fft-sizing.html expectation on Win

Unreviewed gardening.

* platform/chromium-win-xp/webaudio/realtimeanalyser-fft-sizing-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd build flag for Canvas's Path object (disabled by default)
commit-queue@webkit.org [Tue, 22 Jan 2013 02:26:20 +0000 (02:26 +0000)]
Add build flag for Canvas's Path object (disabled by default)
https://bugs.webkit.org/show_bug.cgi?id=107473

Patch by Dirk Schulze <dschulze@adobe.com> on 2013-01-21
Reviewed by Dean Jackson.

.:

Add CANVAS_PATH build flag to build systems.

* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:
* configure.ac:

Source/JavaScriptCore:

Add CANVAS_PATH build flag to build systems.

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Add CANVAS_PATH build flag to build systems.

* Configurations/FeatureDefines.xcconfig:
* GNUmakefile.am:

Source/WebKit/chromium:

Add CANVAS_PATH build flag to build systems.

* features.gypi:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Add CANVAS_PATH build flag to build systems.

* Configurations/FeatureDefines.xcconfig:

Tools:

Add CANVAS_PATH build flag to build systems.

* Scripts/webkitperl/FeatureList.pm:

WebKitLibraries:

Add CANVAS_PATH build flag to build systems.

* win/tools/vsprops/FeatureDefines.vsprops:
* win/tools/vsprops/FeatureDefinesCairo.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Add APIs to set/get view source mode
commit-queue@webkit.org [Tue, 22 Jan 2013 01:52:48 +0000 (01:52 +0000)]
[EFL][WK2] Add APIs to set/get view source mode
https://bugs.webkit.org/show_bug.cgi?id=106633

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-01-21
Reviewed by Gyuyoung Kim.

Source/WebKit2:

Added APIs to set/get view source mode for enabling to load
the source code of the web page.

* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_source_mode_set):
(ewk_view_source_mode_get):
* UIProcess/API/efl/ewk_view.h:
* UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::setMainFrameInViewSourceMode):
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::mainFrameInViewSourceMode):
(WebPageProxy):

Tools:

Added a shotcut 'F8' in Minibrowser to display a source code
of the web page in a new window.

       * MiniBrowser/efl/main.c:
(on_key_down):
(on_window_create):
(window_create):
(elm_main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Don't archive generated source files.
thakis@chromium.org [Tue, 22 Jan 2013 01:44:42 +0000 (01:44 +0000)]
[chromium] Don't archive generated source files.
https://bugs.webkit.org/show_bug.cgi?id=106736

Reviewed by Eric Seidel.

They shouldn't be needed to run tests. They don't need a lot of space,
but add many lines to the "extracting" stdout. This attempts to reduce
that noise a bit.

* BuildSlaveSupport/built-product-archive:
(archiveBuiltProduct):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening. Updating expectations for Mac platforms after r140370.
leviw@chromium.org [Tue, 22 Jan 2013 01:39:17 +0000 (01:39 +0000)]
Unreviewed gardening. Updating expectations for Mac platforms after r140370.

* platform/chromium-mac-snowleopard/platform/chromium/fast/events: Added.
* platform/chromium-mac-snowleopard/platform/chromium/fast/events/touch: Added.
* platform/chromium-mac-snowleopard/platform/chromium/fast/events/touch/touch-hit-rects-in-iframe-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed, update baselines after r140358. See also bug 107476.
thakis@chromium.org [Tue, 22 Jan 2013 01:04:37 +0000 (01:04 +0000)]
[chromium] Unreviewed, update baselines after r140358. See also bug 107476.
https://bugs.webkit.org/show_bug.cgi?id=107483

* platform/chromium-mac/fast/block/float/024-expected.txt:
* platform/chromium-mac/fast/block/margin-collapse/empty-clear-blocks-expected.txt:
* platform/chromium/fast/block/float/024-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/block/float/024-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140373 268f45cc-cd09-0410-ab3c-d52691b4dbfc