WebKit-https.git
7 years agoRename WKProcessClass to WKProcessPool
andersca@apple.com [Mon, 24 Feb 2014 21:10:50 +0000 (21:10 +0000)]
Rename WKProcessClass to WKProcessPool
https://bugs.webkit.org/show_bug.cgi?id=129268

Reviewed by Dan Bernstein.

Stage this rename by adding back WKProcessClass and WKProcessClassConfiguration as subclasses of the renamed classes.

* Shared/Cocoa/APIObject.mm:
(API::Object::newObject):
* UIProcess/API/Cocoa/WKProcessClass.h:
* UIProcess/API/Cocoa/WKProcessClass.mm:
* UIProcess/API/Cocoa/WKProcessClassConfiguration.h:
* UIProcess/API/Cocoa/WKProcessClassConfiguration.mm:
* UIProcess/API/Cocoa/WKProcessClassConfigurationPrivate.h:
* UIProcess/API/Cocoa/WKProcessClassPrivate.h:
* UIProcess/API/Cocoa/WKProcessPool.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKProcessClass.h.
* UIProcess/API/Cocoa/WKProcessPool.mm: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKProcessClass.mm.
(-[WKProcessPool init]):
(-[WKProcessPool initWithConfiguration:]):
(-[WKProcessPool dealloc]):
(-[WKProcessPool description]):
(-[WKProcessPool configuration]):
(-[WKProcessPool API::]):
(-[WKProcessPool _setAllowsSpecificHTTPSCertificate:forHost:]):
* UIProcess/API/Cocoa/WKProcessPoolConfiguration.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKProcessClassConfiguration.h.
* UIProcess/API/Cocoa/WKProcessPoolConfiguration.mm: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKProcessClassConfiguration.mm.
(-[WKProcessPoolConfiguration _injectedBundleURL]):
(-[WKProcessPoolConfiguration _setInjectedBundleURL:]):
(-[WKProcessPoolConfiguration description]):
(-[WKProcessPoolConfiguration copyWithZone:]):
* UIProcess/API/Cocoa/WKProcessPoolConfigurationPrivate.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKProcessClassConfigurationPrivate.h.
* UIProcess/API/Cocoa/WKProcessPoolInternal.h: Renamed from Source/WebKit2/UIProcess/API/Cocoa/WKProcessClassInternal.h.
(WebKit::wrapper):
* UIProcess/API/Cocoa/WKProcessPoolPrivate.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKProcessClassPrivate.h.
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]):
* UIProcess/API/Cocoa/WKWebViewConfiguration.h:
* UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration description]):
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration processPool]):
(-[WKWebViewConfiguration setProcessPool:]):
* UIProcess/API/Cocoa/WKWebViewConfigurationToBeRemoved.mm: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKProcessClassPrivate.h.
(-[WKWebViewConfiguration setProcessClass:]):
(-[WKWebViewConfiguration processClass]):
* UIProcess/API/mac/WKView.mm:
* UIProcess/ios/WKContentView.mm:
(-[WKContentView _decidePolicyForGeolocationRequestFromOrigin:frame:request:]):
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WebRTC] Validating RTCConfiguration according to the spec
thiago.lacerda@openbossa.org [Mon, 24 Feb 2014 21:00:36 +0000 (21:00 +0000)]
[WebRTC] Validating RTCConfiguration according to the spec
https://bugs.webkit.org/show_bug.cgi?id=129182

Reviewed by Eric Carlson.

Spec states that:
    - iceServers should not be an empty list
    - the entry in the configuration dictionary is "urls", instead of "url"
    - urls can be either a list or a string
Fixing all that in RTCConfiguration validation when creating a RTCPeerConnection

Source/WebCore:

Existing tests were updated.

* Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::appendIceServer): Added.
(WebCore::processIceServer): Added.
(WebCore::RTCPeerConnection::parseConfiguration):

LayoutTests:

* fast/mediastream/RTCPeerConnection-AddRemoveStream.html:
* fast/mediastream/RTCPeerConnection-createAnswer.html:
* fast/mediastream/RTCPeerConnection-createOffer.html:
* fast/mediastream/RTCPeerConnection-datachannel.html:
* fast/mediastream/RTCPeerConnection-dtmf.html:
* fast/mediastream/RTCPeerConnection-events.html:
* fast/mediastream/RTCPeerConnection-expected.txt:
* fast/mediastream/RTCPeerConnection-have-local-answer.html:
* fast/mediastream/RTCPeerConnection-have-local-offer.html:
* fast/mediastream/RTCPeerConnection-have-local-pranswer.html:
* fast/mediastream/RTCPeerConnection-have-remote-offer.html:
* fast/mediastream/RTCPeerConnection-have-remote-pranswer.html:
* fast/mediastream/RTCPeerConnection-ice-expected.txt:
* fast/mediastream/RTCPeerConnection-ice.html:
* fast/mediastream/RTCPeerConnection-localDescription.html:
* fast/mediastream/RTCPeerConnection-onnegotiationneeded.html:
* fast/mediastream/RTCPeerConnection-remoteDescription.html:
* fast/mediastream/RTCPeerConnection-stable.html:
* fast/mediastream/RTCPeerConnection-state-expected.txt:
* fast/mediastream/RTCPeerConnection-state.html:
* fast/mediastream/RTCPeerConnection-stats-expected.txt:
* fast/mediastream/RTCPeerConnection-stats.html:
* fast/mediastream/RTCPeerConnection-statsSelector-expected.txt:
* fast/mediastream/RTCPeerConnection-statsSelector.html:
* fast/mediastream/RTCPeerConnection.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove non-API files out of WebKit2/UIProcess/API/mac
simon.fraser@apple.com [Mon, 24 Feb 2014 20:53:02 +0000 (20:53 +0000)]
Move non-API files out of WebKit2/UIProcess/API/mac
https://bugs.webkit.org/show_bug.cgi?id=129267

Reviewed by Anders Carlsson.

* UIProcess/mac/FindIndicatorWindow.h: Renamed from Source/WebKit2/UIProcess/API/mac/FindIndicatorWindow.h.
* UIProcess/mac/FindIndicatorWindow.mm: Renamed from Source/WebKit2/UIProcess/API/mac/FindIndicatorWindow.mm.
* UIProcess/mac/PDFViewController.h: Renamed from Source/WebKit2/UIProcess/API/mac/PDFViewController.h.
* UIProcess/mac/PDFViewController.mm: Renamed from Source/WebKit2/UIProcess/API/mac/PDFViewController.mm.
* UIProcess/mac/WKPrintingView.h: Renamed from Source/WebKit2/UIProcess/API/mac/WKPrintingView.h.
* UIProcess/mac/WKPrintingView.mm: Renamed from Source/WebKit2/UIProcess/API/mac/WKPrintingView.mm.
* UIProcess/mac/WKTextInputWindowController.h: Renamed from Source/WebKit2/UIProcess/API/mac/WKTextInputWindowController.h.
* UIProcess/mac/WKTextInputWindowController.mm: Renamed from Source/WebKit2/UIProcess/API/mac/WKTextInputWindowController.mm.
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Regions] Relative positioned elements overflowing the region do not get painted...
stavila@adobe.com [Mon, 24 Feb 2014 20:51:05 +0000 (20:51 +0000)]
[CSS Regions] Relative positioned elements overflowing the region do not get painted into the next tile
https://bugs.webkit.org/show_bug.cgi?id=129254

Reviewed by Antti Koivisto.

Source/WebCore:

The painting of the region's layer should not be aborted so early if the region's fragment shouldn't be painted
because that would prevent all the layer's children from being painted.

Another problem this patch addresses is that clipping should also be performed when the clip rect is empty,
which is what happens when painting in a tile in which the flowed element would normally be painted
if it wasn't clipped by the region.

Test: fast/regions/content-relative-next-tile.html

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintFlowThreadIfRegionForFragments):

LayoutTests:

Added test for the painting across tiles of relative positioned elements flowed into regions.

* fast/regions/content-relative-next-tile-expected.html: Added.
* fast/regions/content-relative-next-tile.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove non-API files in the API/ios directory out to UIProcess/ios
simon.fraser@apple.com [Mon, 24 Feb 2014 20:31:04 +0000 (20:31 +0000)]
Move non-API files in the API/ios directory out to UIProcess/ios
https://bugs.webkit.org/show_bug.cgi?id=129264

Reviewed by Anders Carlsson.

* UIProcess/ios/PageClientImplIOS.h: Renamed from Source/WebKit2/UIProcess/API/ios/PageClientImplIOS.h.
* UIProcess/ios/PageClientImplIOS.mm: Renamed from Source/WebKit2/UIProcess/API/ios/PageClientImplIOS.mm.
* UIProcess/ios/WKActionSheet.h: Renamed from Source/WebKit2/UIProcess/API/ios/WKActionSheet.h.
* UIProcess/ios/WKActionSheet.mm: Renamed from Source/WebKit2/UIProcess/API/ios/WKActionSheet.mm.
* UIProcess/ios/WKContentViewInternal.h: Renamed from Source/WebKit2/UIProcess/API/ios/WKContentViewInternal.h.
* UIProcess/ios/WKGeolocationProviderIOS.h: Renamed from Source/WebKit2/UIProcess/API/ios/WKGeolocationProviderIOS.h.
* UIProcess/ios/WKGeolocationProviderIOS.mm: Renamed from Source/WebKit2/UIProcess/API/ios/WKGeolocationProviderIOS.mm.
* UIProcess/ios/WKInteractionView.h: Renamed from Source/WebKit2/UIProcess/API/ios/WKInteractionView.h.
* UIProcess/ios/WKInteractionView.mm: Renamed from Source/WebKit2/UIProcess/API/ios/WKInteractionView.mm.
* UIProcess/ios/WKScrollView.h: Renamed from Source/WebKit2/UIProcess/API/ios/WKScrollView.h.
* UIProcess/ios/WKScrollView.mm: Renamed from Source/WebKit2/UIProcess/API/ios/WKScrollView.mm.
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRename PageClientImplIOS::m_view to m_contentView
simon.fraser@apple.com [Mon, 24 Feb 2014 20:18:10 +0000 (20:18 +0000)]
Rename PageClientImplIOS::m_view to m_contentView
https://bugs.webkit.org/show_bug.cgi?id=129124

Reviewed by Benjamin Poulain.

Simple rename of m_view to m_contentView in preparation for
also holding onto the WKView.

* UIProcess/API/ios/PageClientImplIOS.h:
* UIProcess/API/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::PageClientImpl):
(WebKit::PageClientImpl::createDrawingAreaProxy):
(WebKit::PageClientImpl::viewSize):
(WebKit::PageClientImpl::isViewInWindow):
(WebKit::PageClientImpl::processDidExit):
(WebKit::PageClientImpl::didRelaunchProcess):
(WebKit::PageClientImpl::decidePolicyForGeolocationPermissionRequest):
(WebKit::PageClientImpl::didCommitLoadForMainFrame):
(WebKit::PageClientImpl::interpretKeyEvent):
(WebKit::PageClientImpl::positionInformationDidChange):
(WebKit::PageClientImpl::selectionDidChange):
(WebKit::PageClientImpl::screenToRootView):
(WebKit::PageClientImpl::rootViewToScreen):
(WebKit::PageClientImpl::setAcceleratedCompositingRootLayer):
(WebKit::PageClientImpl::takeViewSnapshot):
(WebKit::PageClientImpl::didGetTapHighlightGeometries):
(WebKit::PageClientImpl::didCommitLayerTree):
(WebKit::PageClientImpl::startAssistingNode):
(WebKit::PageClientImpl::stopAssistingNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r164438): [GTK] Tests /webkit2/WebKitWebView/tls-errors-policy and /webkit...
commit-queue@webkit.org [Mon, 24 Feb 2014 19:43:19 +0000 (19:43 +0000)]
REGRESSION(r164438): [GTK] Tests /webkit2/WebKitWebView/tls-errors-policy and /webkit2/WebKitWebContext/uri-scheme fail
https://bugs.webkit.org/show_bug.cgi?id=129252

Patch by Enrique Ocaña González <eocanha@igalia.com> on 2014-02-24
Reviewed by Carlos Garcia Campos.

* UIProcess/API/gtk/WebKitPrivate.cpp: Manage error values generated by the user application and not present in WebCore
(toWebKitError):
(toWebCoreError):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r164438): [GTK] Tests /WebKitGtk/testcontextmenu, /WebKitGtk/testmimehandl...
commit-queue@webkit.org [Mon, 24 Feb 2014 19:23:08 +0000 (19:23 +0000)]
REGRESSION(r164438): [GTK] Tests /WebKitGtk/testcontextmenu, /WebKitGtk/testmimehandling, /WebKitGtk/testloading assert in Debug build
https://bugs.webkit.org/show_bug.cgi?id=129256

Patch by Enrique Ocaña González <eocanha@igalia.com> on 2014-02-24
Reviewed by Carlos Garcia Campos.

* WebCoreSupport/FrameLoaderClientGtk.cpp: Manage error values not present in WebCore
(WebKit::toWebKitNetworkError):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoiOS build fix after r164577.
mitz@apple.com [Mon, 24 Feb 2014 19:13:16 +0000 (19:13 +0000)]
iOS build fix after r164577.

* DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(AccessibilityUIElement::selectedChildrenCount):
(AccessibilityUIElement::selectedChildAtIndex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGet rid of the unused 'immediate' parameters from repaint related functions
commit-queue@webkit.org [Mon, 24 Feb 2014 19:05:21 +0000 (19:05 +0000)]
Get rid of the unused 'immediate' parameters from repaint related functions
https://bugs.webkit.org/show_bug.cgi?id=129111

Patch by Renata Hodovan <rhodovan.u-szeged@partner.samsung.com> on 2014-02-24
Reviewed by Simon Fraser.

Removing the 'immediate' parameters from repaint related functions - accoring
to the FIXME in RenderView::repaintViewRectangle() - since they have no effect.

Source/WebCore:

No new tests are necessary because there is no behavior change

* dom/Element.cpp:
(WebCore::Element::setActive):
* loader/EmptyClients.h:
* page/Chrome.cpp:
(WebCore::Chrome::invalidateRootView):
(WebCore::Chrome::invalidateContentsAndRootView):
(WebCore::Chrome::invalidateContentsForSlowScroll):
* page/Chrome.h:
* page/ChromeClient.h:
* page/Frame.cpp:
(WebCore::Frame::tiledBackingStorePaintEnd):
* page/FrameView.cpp:
(WebCore::FrameView::invalidateRect):
(WebCore::FrameView::scrollContentsFastPath):
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::shouldUpdate):
* page/FrameView.h:
* platform/HostWindow.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::scrollContents):
(WebCore::ScrollView::scrollContentsSlowPath):
(WebCore::ScrollView::repaintContentRectangle):
(WebCore::ScrollView::updateOverhangAreas):
(WebCore::ScrollView::addPanScrollIcon):
(WebCore::ScrollView::removePanScrollIcon):
(WebCore::ScrollView::platformRepaintContentRectangle):
* platform/ScrollView.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::repaintLayerRectsForImage):
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::repaintRectangleInRegions):
* rendering/RenderFlowThread.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::setFilterBackendNeedsRepaintingInRect):
* rendering/RenderLayer.h:
* rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::repaintFlowThreadContent):
* rendering/RenderMultiColumnSet.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintUsingContainer):
(WebCore::RenderObject::repaint):
(WebCore::RenderObject::repaintRectangle):
(WebCore::RenderObject::repaintSlowRepaintObject):
* rendering/RenderObject.h:
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::repaintFlowThreadContent):
(WebCore::RenderRegion::repaintFlowThreadContentRectangle):
* rendering/RenderRegion.h:
* rendering/RenderView.cpp:
(WebCore::RenderView::repaintViewRectangle):
(WebCore::RenderView::flushAccumulatedRepaintRegion):
(WebCore::RenderView::repaintRectangleInViewAndCompositedLayers):
* rendering/RenderView.h:
* svg/graphics/SVGImageChromeClient.h:

Source/WebKit/efl:

* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::invalidateContents):
(WebCore::ChromeClientEfl::invalidateRootView):
(WebCore::ChromeClientEfl::invalidateContentsAndRootView):
(WebCore::ChromeClientEfl::invalidateContentsForSlowScroll):
* WebCoreSupport/ChromeClientEfl.h:

Source/WebKit/gtk:

* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::invalidateRootView):
(WebKit::ChromeClient::invalidateContentsAndRootView):
(WebKit::ChromeClient::invalidateContentsForSlowScroll):
* WebCoreSupport/ChromeClientGtk.h:

Source/WebKit/win:

* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::invalidateRootView):
(WebChromeClient::invalidateContentsAndRootView):
(WebChromeClient::invalidateContentsForSlowScroll):
* WebCoreSupport/WebChromeClient.h:

Source/WebKit/wince:

* WebCoreSupport/ChromeClientWinCE.cpp:
(WebKit::ChromeClientWinCE::invalidateRootView):
(WebKit::ChromeClientWinCE::invalidateContentsAndRootView):
(WebKit::ChromeClientWinCE::invalidateContentsForSlowScroll):
(WebKit::ChromeClientWinCE::scroll):
* WebCoreSupport/ChromeClientWinCE.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago<rdar://problem/16059894> Update AppleConnect sandbox profile for XPC process names.
ap@apple.com [Mon, 24 Feb 2014 18:49:01 +0000 (18:49 +0000)]
<rdar://problem/16059894> Update AppleConnect sandbox profile for XPC process names.

Patch by Ivan KrstiÄ\87, reviewed and landed by me.

* Resources/PlugInSandboxProfiles/com.apple.ist.ds.appleconnect.webplugin.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTransform more clip-path pixel tests to reference tests
krit@webkit.org [Mon, 24 Feb 2014 18:34:51 +0000 (18:34 +0000)]
Transform more clip-path pixel tests to reference tests
https://bugs.webkit.org/show_bug.cgi?id=129230

Reviewed by Andreas Kling.

* svg/clip-path/clip-path-content-use-007-expected.svg: Added.
* svg/clip-path/clip-path-content-use-007.svg: Added.
* svg/clip-path/clip-path-css-transform-003-expected.svg: Added.
* svg/clip-path/clip-path-css-transform-003.svg: Added.
* svg/clip-path/clip-path-css-transform-004-expected.svg: Added.
* svg/clip-path/clip-path-css-transform-004.svg: Added.
* svg/clip-path/clip-path-document-change-assert-expected.txt: Renamed from LayoutTests/svg/custom/clip-path-document-change-assert-expected.txt.
* svg/clip-path/clip-path-document-change-assert.html: Renamed from LayoutTests/svg/custom/clip-path-document-change-assert.html.
* svg/clip-path/clip-path-dom-child-changes-expected.svg: Added.
* svg/clip-path/clip-path-dom-child-changes.svg: Added.
* svg/clip-path/clip-path-dom-clippathunits-expected.svg: Added.
* svg/clip-path/clip-path-dom-clippathunits.svg: Added.
* svg/clip-path/clip-path-dom-href-expected.svg: Added.
* svg/clip-path/clip-path-dom-href.svg: Added.
* svg/clip-path/clip-path-dom-id-expected.svg: Added.
* svg/clip-path/clip-path-dom-id.svg: Added.
* svg/clip-path/clip-path-negative-scale-expected.svg: Added.
* svg/clip-path/clip-path-negative-scale.svg: Added.
* svg/clip-path/clip-path-no-content-004-expected.svg: Added.
* svg/clip-path/clip-path-no-content-004.svg: Added.
* svg/clip-path/clip-path-on-marker-001-expected.svg: Added.
* svg/clip-path/clip-path-on-marker-001.svg: Added.
* svg/clip-path/clip-path-on-marker-002-expected.svg: Added.
* svg/clip-path/clip-path-on-marker-002.svg: Added.
* svg/clip-path/clip-path-on-marker-003-expected.svg: Added.
* svg/clip-path/clip-path-on-marker-003.svg: Added.
* svg/clip-path/clip-path-recursion-001-expected.svg: Renamed from LayoutTests/svg/custom/circular-clip-path-references-crash-expected.svg.
* svg/clip-path/clip-path-recursion-001.svg: Renamed from LayoutTests/svg/custom/circular-clip-path-references-crash.svg.
* svg/clip-path/clip-path-recursion-002-expected.svg: Added.
* svg/clip-path/clip-path-recursion-002.svg: Added.
* svg/clip-path/clip-path-shape-stroke-expected.svg:
* svg/clip-path/clip-path-with-transform-expected.svg: Added.
* svg/clip-path/clip-path-with-transform.svg: Added.
* svg/clip-path/mask-nested-clip-path-010-expected.svg: Renamed from LayoutTests/svg/custom/clamped-masking-clipping-expected.svg.
* svg/clip-path/mask-nested-clip-path-010.svg: Renamed from LayoutTests/svg/custom/clamped-masking-clipping.svg.
* svg/custom/clip-mask-negative-scale-expected.txt: Removed.
* svg/custom/clip-mask-negative-scale.svg: Removed.
* svg/custom/clip-path-child-changes-expected.txt: Removed.
* svg/custom/clip-path-child-changes.svg: Removed.
* svg/custom/clip-path-href-changes-expected.txt: Removed.
* svg/custom/clip-path-href-changes.svg: Removed.
* svg/custom/clip-path-id-changes-expected.txt: Removed.
* svg/custom/clip-path-id-changes.svg: Removed.
* svg/custom/clip-path-referencing-use.svg: Removed.
* svg/custom/clip-path-referencing-use2.svg: Removed.
* svg/custom/clip-path-units-changes-expected.txt: Removed.
* svg/custom/clip-path-units-changes.svg: Removed.
* svg/custom/clip-path-with-css-transform-1-expected.txt: Removed.
* svg/custom/clip-path-with-css-transform-1.svg: Removed.
* svg/custom/clip-path-with-css-transform-2-expected.txt: Removed.
* svg/custom/clip-path-with-css-transform-2.svg: Removed.
* svg/custom/clip-path-with-transform-expected.txt: Removed.
* svg/custom/clip-path-with-transform.svg: Removed.
* svg/custom/empty-clip-path.svg: Removed.
* svg/custom/recursive-clippath.svg: Removed.
* svg/masking/mask-negative-scale.svg: Added.
* svg/masking/mast-negative-scale-expected.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTransform more clip-path pixel tests to reference tests
krit@webkit.org [Mon, 24 Feb 2014 18:32:52 +0000 (18:32 +0000)]
Transform more clip-path pixel tests to reference tests
https://bugs.webkit.org/show_bug.cgi?id=129230

Reviewed by Andreas Kling.

Remove unnecessary pixel test results.

* platform/efl/svg/custom/clip-mask-negative-scale-expected.png: Removed.
* platform/gtk/svg/custom/clip-mask-negative-scale-expected.png: Removed.
* platform/gtk/svg/custom/clip-mask-negative-scale-expected.txt: Removed.
* platform/gtk/svg/custom/clip-path-child-changes-expected.png: Removed.
* platform/gtk/svg/custom/clip-path-href-changes-expected.png: Removed.
* platform/gtk/svg/custom/clip-path-id-changes-expected.png: Removed.
* platform/gtk/svg/custom/clip-path-referencing-use-expected.png: Removed.
* platform/gtk/svg/custom/clip-path-referencing-use-expected.txt: Removed.
* platform/gtk/svg/custom/clip-path-referencing-use2-expected.png: Removed.
* platform/gtk/svg/custom/clip-path-referencing-use2-expected.txt: Removed.
* platform/gtk/svg/custom/clip-path-units-changes-expected.png: Removed.
* platform/gtk/svg/custom/clip-path-with-css-transform-1-expected.png: Removed.
* platform/gtk/svg/custom/clip-path-with-css-transform-2-expected.png: Removed.
* platform/gtk/svg/custom/clip-path-with-transform-expected.png: Removed.
* platform/gtk/svg/custom/empty-clip-path-expected.png: Removed.
* platform/gtk/svg/custom/empty-clip-path-expected.txt: Removed.
* platform/gtk/svg/custom/recursive-clippath-expected.png: Removed.
* platform/gtk/svg/custom/recursive-clippath-expected.txt: Removed.
* platform/mac/svg/custom/clip-mask-negative-scale-expected.png: Removed.
* platform/mac/svg/custom/clip-path-child-changes-expected.png: Removed.
* platform/mac/svg/custom/clip-path-display-none-child-expected.png: Removed.
* platform/mac/svg/custom/clip-path-display-none-child-expected.txt: Removed.
* platform/mac/svg/custom/clip-path-href-changes-expected.png: Removed.
* platform/mac/svg/custom/clip-path-id-changes-expected.png: Removed.
* platform/mac/svg/custom/clip-path-referencing-use-expected.png: Removed.
* platform/mac/svg/custom/clip-path-referencing-use-expected.txt: Removed.
* platform/mac/svg/custom/clip-path-referencing-use2-expected.png: Removed.
* platform/mac/svg/custom/clip-path-referencing-use2-expected.txt: Removed.
* platform/mac/svg/custom/clip-path-units-changes-expected.png: Removed.
* platform/mac/svg/custom/clip-path-with-css-transform-1-expected.png: Removed.
* platform/mac/svg/custom/clip-path-with-css-transform-2-expected.png: Removed.
* platform/mac/svg/custom/clip-path-with-transform-expected.png: Removed.
* platform/mac/svg/custom/empty-clip-path-expected.png: Removed.
* platform/mac/svg/custom/empty-clip-path-expected.txt: Removed.
* platform/mac/svg/custom/recursive-clippath-expected.png: Removed.
* platform/mac/svg/custom/recursive-clippath-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTurn GenGC on for 32-bit systems
mhahnenberg@apple.com [Mon, 24 Feb 2014 18:15:47 +0000 (18:15 +0000)]
Turn GenGC on for 32-bit systems
https://bugs.webkit.org/show_bug.cgi?id=128824

Reviewed by Geoffrey Garen.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[ASan] Remove methods from ignore list that no longer cause crashes
ddkilzer@apple.com [Mon, 24 Feb 2014 17:07:22 +0000 (17:07 +0000)]
[ASan] Remove methods from ignore list that no longer cause crashes
<http://webkit.org/b/129257>

Reviewed by Anders Carlsson.

* asan/webkit-asan-ignore.txt: Remove old methods.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Remove single quote characters from Web Inspector JavaScript files
commit-queue@webkit.org [Mon, 24 Feb 2014 17:05:33 +0000 (17:05 +0000)]
Web Inspector: Remove single quote characters from Web Inspector JavaScript files
https://bugs.webkit.org/show_bug.cgi?id=129253

Patch by Diego Pino Garcia <dpino@igalia.com> on 2014-02-24
Reviewed by Timothy Hatcher.

* UserInterface/Base/Main.js:
(WebInspector.openURL):
* UserInterface/Views/CookieStorageContentView.js:
(WebInspector.cookieDomainMatchesResourceDomain):
* UserInterface/Views/DOMTreeElement.js:
(WebInspector.DOMTreeElement.prototype._insertInLastAttributePosition):
(WebInspector.DOMTreeElement.prototype._startEditingTagName.editingComitted):
(WebInspector.DOMTreeElement.prototype._startEditingTagName.editingCancelled):
(WebInspector.DOMTreeElement.prototype._startEditingTagName):
* UserInterface/Views/DOMTreeOutline.js:
(WebInspector.DOMTreeOutline.prototype._ondragover):
* UserInterface/Views/DataGrid.js:
(WebInspector.DataGrid.prototype.addPlaceholderNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCode cleanup: remove leftover ENABLE(WORKERS) macros and support.
commit-queue@webkit.org [Mon, 24 Feb 2014 15:52:42 +0000 (15:52 +0000)]
Code cleanup: remove leftover ENABLE(WORKERS) macros and support.
https://bugs.webkit.org/show_bug.cgi?id=129255

Patch by Tamas Gergely <tgergely.u-szeged@partner.samsung.com> on 2014-02-24
Reviewed by Csaba Osztrogonác.

Source/JavaScriptCore:

ENABLE_WORKERS macro was removed in r159679.
Support is now also removed from xcconfig files.

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

ENABLE_WORKERS macro was removed in r159679, but r161589 added back some occurrences.
Support is now also removed from xcconfig files.

No new tests needed.

* Configurations/FeatureDefines.xcconfig:
* platform/ThreadGlobalData.cpp:
* platform/ThreadGlobalData.h:
* platform/Timer.h:
(WebCore::TimerBase::isActive):
* platform/ios/wak/WebCoreThread.mm:
(RunWebThread):
(StartWebThread):

Source/WebKit/mac:

ENABLE_WORKERS macro was removed in r159679.
Support is now also removed from xcconfig files.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

ENABLE_WORKERS macro was removed in r159679.
Support is now also removed from xcconfig files.

* Configurations/FeatureDefines.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CMake] Get rid of "FIXME: The Blackberry port ..." from WebCore/CmakeLists.txt
commit-queue@webkit.org [Mon, 24 Feb 2014 15:47:16 +0000 (15:47 +0000)]
[CMake] Get rid of "FIXME: The Blackberry port ..." from WebCore/CmakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=129152

Patch by Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com> on 2014-02-24
Reviewed by Gyuyoung Kim.

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoExtract common parts from jhbuildrc files.
commit-queue@webkit.org [Mon, 24 Feb 2014 15:45:27 +0000 (15:45 +0000)]
Extract common parts from jhbuildrc files.
https://bugs.webkit.org/show_bug.cgi?id=125986

Patch by Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com> on 2014-02-24
Reviewed by Csaba Osztrogonác.

Co-authored with Peter Szanka <h868064@stud.u-szeged.hu>.

* Scripts/run-gtk-tests:
(TestRunner._setup_testing_environment):
* efl/common.py: Removed.
* efl/jhbuildrc:
* gtk/check-gdom-symbols:
* gtk/common.py:
(binary_build_path):
(get_build_path):
* gtk/find-make-dist-errors:
(get_missing_headers):
* gtk/generate-gtkdoc:
(get_webkit2_options):
(get_webkit1_options.src_path):
(get_webkit1_options):
(get_webkitdom_options.src_path):
(get_webkitdom_options):
* gtk/generate-inspector-gresource-manifest.py:
* gtk/jhbuildrc:
* jhbuild/jhbuildrc_common.py: Added.
(script_path):
(top_level_path):
(init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Wrong active context when destroying GL objects.
commit-queue@webkit.org [Mon, 24 Feb 2014 15:24:42 +0000 (15:24 +0000)]
[GTK] Wrong active context when destroying GL objects.
https://bugs.webkit.org/show_bug.cgi?id=129244

Patch by Iago Toral Quiroga <itoral@igalia.com> on 2014-02-24
Reviewed by Martin Robinson.

* WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::invalidate): make context current before destroying GL objects.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove unused error.h header.
berto@igalia.com [Mon, 24 Feb 2014 15:06:13 +0000 (15:06 +0000)]
Remove unused error.h header.
https://bugs.webkit.org/show_bug.cgi?id=126774

Patch by Koop Mast <kwm@FreeBSD.org> on 2014-02-24
Reviewed by Anders Carlsson.

This header doesn't exists on FreeBSD. According to
https://www.gnu.org/software/gnulib/manual/html_node/error_002eh.html
the function that this header implements are not present in the file.
So there isn't any need for this header.

* NetworkProcess/unix/NetworkProcessMainUnix.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Fix code indentation and spacing.
rego@igalia.com [Mon, 24 Feb 2014 12:19:19 +0000 (12:19 +0000)]
Unreviewed. Fix code indentation and spacing.

Patch by Diego Pino Garcia <dpino@igalia.com> on 2014-02-24

* Scripts/webkitpy/style/checkers/js.py:
(SingleQuoteChecker.check):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove redundant setting in FeatureDefines.xcconfig
ddkilzer@apple.com [Mon, 24 Feb 2014 11:24:34 +0000 (11:24 +0000)]
Remove redundant setting in FeatureDefines.xcconfig

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoANGLE: Stop using unsafe strcpy method
ddkilzer@apple.com [Mon, 24 Feb 2014 11:14:29 +0000 (11:14 +0000)]
ANGLE: Stop using unsafe strcpy method
<http://webkit.org/b/129237>
<rdar://problem/11077580>

Reviewed by Dean Jackson.

* include/GLSLANG/ShaderLang.h:
- Drive-by fix for header documentation.

* src/compiler/translator/ShaderLang.cpp:
(ShGetInfoLog):
(ShGetObjectCode):
* src/libGLESv2/Program.cpp:
(gl::InfoLog::append):
- Switch to use strncpy(), and explicitly set NULL terminator at
  the end of the buffer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Blending] An element having -webkit-mix-blend-mode should only blend with the...
commit-queue@webkit.org [Mon, 24 Feb 2014 10:02:10 +0000 (10:02 +0000)]
[CSS Blending] An element having -webkit-mix-blend-mode should only blend with the contents of the parent stacking context
https://bugs.webkit.org/show_bug.cgi?id=129154

Patch by Mihai Tica <mitica@adobe.com> on 2014-02-24
Reviewed by Dean Jackson.

Source/WebCore:

The blending operation of an element having -webkit-mix-blend-mode should be restricted to the parent stacking context.
This change isolates blending, preventing it from blending with other underlying elements besides the parent stacking context.

Tests: css3/compositing/blend-mode-isolated-group-1.html
       css3/compositing/blend-mode-isolated-group-2.html
       css3/compositing/blend-mode-isolated-group-3.html

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer): Initialize added members to false.
(WebCore::RenderLayer::updateBlendMode): Check if a blend mode was set or unset. If so, set the m_updateParentStackingContextShouldIsolateBlendingDirty to true.
(WebCore::RenderLayer::updateParentStackingContextShouldIsolateBlending): Traverse to the parent stacking context and update the
m_isolatesBlending member accordingly.
* rendering/RenderLayer.h:
- Add isolatesBlending() as a condition for creating a transparency layer in the paintsWithTransparency method.
- Add m_updateParentStackingContextShouldIsolateBlendingDirty member.
- Add m_isolatesBlending member and getter.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::computeCompositingRequirements): Call updateParentStackingContextShouldIsolateBlending.

LayoutTests:

Test that isolation is performed for blending, in other words, an element having -webkit-mix-blend-mode is blending with the
contents of the parent stacking context, but not with any of the underlying content.

* css3/compositing/blend-mode-isolated-group-1.html: Added.
* css3/compositing/blend-mode-isolated-group-2.html: Added.
* css3/compositing/blend-mode-isolated-group-3.html: Added.
* platform/mac/css3/compositing/blend-mode-isolated-group-1-expected.png: Added.
* platform/mac/css3/compositing/blend-mode-isolated-group-1-expected.txt: Added.
* platform/mac/css3/compositing/blend-mode-isolated-group-2-expected.png: Added.
* platform/mac/css3/compositing/blend-mode-isolated-group-2-expected.txt: Added.
* platform/mac/css3/compositing/blend-mode-isolated-group-3-expected.png: Added.
* platform/mac/css3/compositing/blend-mode-isolated-group-3-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Remove unneeded method webkitWebViewBaseRequestExitFullScreen
carlosgc@webkit.org [Mon, 24 Feb 2014 09:31:16 +0000 (09:31 +0000)]
[GTK] Remove unneeded method webkitWebViewBaseRequestExitFullScreen
https://bugs.webkit.org/show_bug.cgi?id=129245

Reviewed by Sergio Villar Senin.

* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseKeyPressEvent): Call FullscreenManager::requestExitFullScreen() directly.
* UIProcess/API/gtk/WebKitWebViewBasePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[ATK] Wrong selected element at a given index in a list box.
k.czech@samsung.com [Mon, 24 Feb 2014 09:31:12 +0000 (09:31 +0000)]
[ATK] Wrong selected element at a given index in a list box.
https://bugs.webkit.org/show_bug.cgi?id=129039

Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/select-element-at-index.html

The selected element at a given index was wrong. One should be considered among the
all children of a list box, not only selected ones.

* accessibility/atk/WebKitAccessibleInterfaceSelection.cpp:
(core):
(listObjectForSelection):
(optionFromList):
(optionFromSelection):
(webkitAccessibleSelectionRefSelection):

Tools:

Added missing implementation and proposed some new function for testing selection
in a list boxes.

* DumpRenderTree/AccessibilityUIElement.cpp:
(setSelectedChildAtIndexCallback):
(removeSelectionAtIndexCallback):
(AccessibilityUIElement::getJSClass):
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::selectedChildrenCount):
(AccessibilityUIElement::selectedChildAtIndex):
(AccessibilityUIElement::setSelectedChildAtIndex):
(AccessibilityUIElement::removeSelectionAtIndex):
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::selectedChildrenCount):
(AccessibilityUIElement::selectedChildAtIndex):
* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::setSelectedChildAtIndex):
(WTR::AccessibilityUIElement::removeSelectionAtIndex):
* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
* WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::selectedChildAtIndex):
(WTR::AccessibilityUIElement::selectedChildrenCount):
(WTR::AccessibilityUIElement::setSelectedChildAtIndex):
(WTR::AccessibilityUIElement::removeSelectionAtIndex):

LayoutTests:

Proposed test that checks whether correct element at a given index is retrieved.
Also testing some other scenarios such as removing selection from rows, counting all
selected rows and setting selection.

* accessibility/select-element-at-index-expected.txt: Added.
* accessibility/select-element-at-index.html: Added.
* platform/mac/TestExpectations: Skipping test in Mac, missing implementation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago<rdar://problem/16144508> [iOS] Some definitions of INSTALL_PATH don’t account for...
mitz@apple.com [Mon, 24 Feb 2014 05:29:33 +0000 (05:29 +0000)]
<rdar://problem/16144508> [iOS] Some definitions of INSTALL_PATH don’t account for INSTALL_PATH_PREFIX
https://bugs.webkit.org/show_bug.cgi?id=129241

Reviewed by Mark Rowe.

* Configurations/Base.xcconfig: Define INSTALL_PATH here in terms of INSTALL_PATH_ACTUAL.
* Configurations/BaseLegacyProcess.xcconfig: Define only INSTALL_PATH_ACTUAL.
* Configurations/BaseTarget.xcconfig: Simplify the definition of
NORMAL_WEBKIT2_FRAMEWORKS_DIR, now that it shouldn’t include SDKROOT for the Simulator.
* Configurations/BaseXPCService.xcconfig: Define only INSTALL_PATH_ACTUAL.
* Configurations/WebKit2.xcconfig: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WinCairo] Unreviewed build fix after r164565.
bfulgham@apple.com [Mon, 24 Feb 2014 02:24:36 +0000 (02:24 +0000)]
[WinCairo] Unreviewed build fix after r164565.

* ANGLE.vcxproj/libEGL.vcxproj: Use correct path to files.
* ANGLE.vcxproj/libGLESv2.vcxproj: Ditto.
* ANGLE.vcxproj/libGLESv2.vcxproj.filters: Ditto.
* ANGLE.vcxproj/preprocessor.vcxproj: Ditto.
* ANGLE.vcxproj/translator_common.vcxproj: Ditto.
* ANGLE.vcxproj/translator_common.vcxproj.filters: Ditto.
* ANGLE.vcxproj/translator_glsl.vcxproj: Ditto.
* ANGLE.vcxproj/translator_glsl.vcxproj.filters: Ditto.
* ANGLE.vcxproj/translator_hlsl.vcxproj: Ditto.
* ANGLE.vcxproj/translator_hlsl.vcxproj.filters: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WebGL] Allow ANGLE to initialize unused varyings
dino@apple.com [Mon, 24 Feb 2014 02:11:36 +0000 (02:11 +0000)]
[WebGL] Allow ANGLE to initialize unused varyings
https://bugs.webkit.org/show_bug.cgi?id=129240
<rdar://problem/15203342>

Reviewed by Sam Weinig.

Source/WebCore:

Covered by: conformance/glsl/misc/shaders-with-varyings.html

* platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE):
Add SH_INIT_VARYINGS_WITHOUT_STATIC_USE to compiler flags.

LayoutTests:

Unskip conformance/glsl/misc/shaders-with-varyings.html.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate FeatureDefines.xcconfig
weinig@apple.com [Mon, 24 Feb 2014 02:01:19 +0000 (02:01 +0000)]
Update FeatureDefines.xcconfig

Rubber-stamped by Anders Carlsson.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSort the project file with sort-Xcode-project-file.
dino@apple.com [Mon, 24 Feb 2014 01:59:18 +0000 (01:59 +0000)]
Sort the project file with sort-Xcode-project-file.

Rubber-stamped by Sam Weinig.

Source/JavaScriptCore:

* JavaScriptCore.xcodeproj/project.pbxproj:

Source/WebCore:

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WebKit2] Add C-SPI to enable/disable telephone number detection
weinig@apple.com [Mon, 24 Feb 2014 01:54:04 +0000 (01:54 +0000)]
[WebKit2] Add C-SPI to enable/disable telephone number detection
https://bugs.webkit.org/show_bug.cgi?id=129239

Reviewed by Dean Jackson.

* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetTelephoneNumberParsingEnabled):
(WKPreferencesGetTelephoneNumberParsingEnabled):
* UIProcess/API/C/WKPreferencesPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix incorrectly commented out code.
weinig@apple.com [Mon, 24 Feb 2014 01:43:06 +0000 (01:43 +0000)]
Fix incorrectly commented out code.

* platform/TelephoneNumberDetector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoExtract platform specific parts of telephone number detection
weinig@apple.com [Mon, 24 Feb 2014 01:35:02 +0000 (01:35 +0000)]
Extract platform specific parts of telephone number detection
https://bugs.webkit.org/show_bug.cgi?id=129238

Reviewed by Dean Jackson.

* WebCore.xcodeproj/project.pbxproj:
Add new files.

* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::linkifyPhoneNumbers):
(WebCore::HTMLTreeBuilder::processCharacterBufferForInBody):
* platform/TelephoneNumberDetector.h: Added.
* platform/cocoa/TelephoneNumberDetectorCocoa.cpp: Added.
(WebCore::TelephoneNumberDetector::phoneNumbersScanner):
(WebCore::TelephoneNumberDetector::isSupported):
(WebCore::TelephoneNumberDetector::find):
Move code to TelephoneNumberDetector.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChange a url parameter type with URL in NavigatorContentUtils
gyuyoung.kim@samsung.com [Mon, 24 Feb 2014 01:23:57 +0000 (01:23 +0000)]
Change a url parameter type with URL in NavigatorContentUtils
https://bugs.webkit.org/show_bug.cgi?id=129202

Reviewed by Sam Weinig.

It would be good if we use *URL* for url parameters instead of using String.

Merge from blink. https://src.chromium.org/viewvc/blink?view=rev&revision=165458.

Source/WebCore:

* Modules/navigatorcontentutils/NavigatorContentUtils.cpp:
(WebCore::verifyCustomHandlerURL):
(WebCore::NavigatorContentUtils::registerProtocolHandler):
(WebCore::NavigatorContentUtils::isProtocolHandlerRegistered):
(WebCore::NavigatorContentUtils::unregisterProtocolHandler):
* Modules/navigatorcontentutils/NavigatorContentUtilsClient.h:

Source/WebKit/efl:

* WebCoreSupport/NavigatorContentUtilsClientEfl.cpp:
(WebCore::NavigatorContentUtilsClientEfl::registerProtocolHandler):
(WebCore::NavigatorContentUtilsClientEfl::isProtocolHandlerRegistered):
(WebCore::NavigatorContentUtilsClientEfl::unregisterProtocolHandler):
* WebCoreSupport/NavigatorContentUtilsClientEfl.h:

Source/WebKit/gtk:

* WebCoreSupport/NavigatorContentUtilsClientGtk.cpp:
(WebKit::NavigatorContentUtilsClient::registerProtocolHandler):
* WebCoreSupport/NavigatorContentUtilsClientGtk.h:

Source/WebKit2:

* WebProcess/WebCoreSupport/WebNavigatorContentUtilsClient.h:
(WebKit::WebNavigatorContentUtilsClient::isProtocolHandlerRegistered):
(WebKit::WebNavigatorContentUtilsClient::unregisterProtocolHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMissing files from previous commit.
dino@apple.com [Mon, 24 Feb 2014 00:58:19 +0000 (00:58 +0000)]
Missing files from previous commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemoved -Wno-format-y2k from WARNING_CFLAGS
mitz@apple.com [Mon, 24 Feb 2014 00:51:05 +0000 (00:51 +0000)]
Removed -Wno-format-y2k from WARNING_CFLAGS

Rubber-stamped by Sam Weinig.

* Configurations/Base.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate ANGLE to 836bd2176e5607b14846cf1fbc5932dbc91318f4
dino@apple.com [Mon, 24 Feb 2014 00:43:48 +0000 (00:43 +0000)]
Update ANGLE to 836bd2176e5607b14846cf1fbc5932dbc91318f4
https://bugs.webkit.org/show_bug.cgi?id=129232

Reviewed by Brent Fulgham.

Source/ThirdParty/ANGLE:

I also reapplied some of our changes from previous updates, including disabling the clang deprecation
warnings in some files, adding the Apple note about license and defining YY_NO_INPUT.

Huge list of source changes omitted.

Source/WebCore:

New files added, derived sources compiled directly, and generated
steps removed for both EFL and GTK, with much-needed help from
Sergio Correia.

* CMakeLists.txt:
* GNUMakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove RenderMathMLMenclose.h/cpp to the right place in the Xcode project and sort.
weinig@apple.com [Sun, 23 Feb 2014 23:43:20 +0000 (23:43 +0000)]
Move RenderMathMLMenclose.h/cpp to the right place in the Xcode project and sort.

Rubber-stamped by Anders Carlsson.

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove telephone number detection behind its own ENABLE macro
weinig@apple.com [Sun, 23 Feb 2014 23:37:46 +0000 (23:37 +0000)]
Move telephone number detection behind its own ENABLE macro
https://bugs.webkit.org/show_bug.cgi?id=129236

Reviewed by Dean Jackson.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:
Add ENABLE_TELEPHONE_NUMBER_DETECTION.

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:
Add ENABLE_TELEPHONE_NUMBER_DETECTION.

* dom/Document.cpp:
(WebCore::Document::Document):
* dom/Document.h:
* html/parser/HTMLConstructionSite.h:
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processCharacterBufferForInBody):
* html/parser/HTMLTreeBuilder.h:
Use ENABLE(TELEPHONE_NUMBER_DETECTION).

* platform/mac/SoftLinking.h:
Remove PLATOFORM(IOS) from SOFT_LINK_PRIVATE_FRAMEWORK_OPTIONAL, it is not iOS specific.

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:
Add ENABLE_TELEPHONE_NUMBER_DETECTION.

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:
Add ENABLE_TELEPHONE_NUMBER_DETECTION.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Fix build after Web Inspector code reorganization (r164543)
commit-queue@webkit.org [Sun, 23 Feb 2014 22:44:23 +0000 (22:44 +0000)]
[GTK] Fix build after Web Inspector code reorganization (r164543)
https://bugs.webkit.org/show_bug.cgi?id=129231

Patch by Diego Pino García <dpino@igalia.com> on 2014-02-23
Reviewed by Dean Jackson.

Source/WebInspectorUI:

* GNUmakefile.am:
Modify paths to Web Inspector code.

Source/WebKit2:

* PlatformGTK.cmake:
Modify paths to Web Inspector code.

Tools:

* gtk/generate-inspector-gresource-manifest.py:
Modify paths to Web Inspector code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: color picker sliders aren't laid out correctly
graouts@webkit.org [Sun, 23 Feb 2014 21:43:20 +0000 (21:43 +0000)]
Web Inspector: color picker sliders aren't laid out correctly
https://bugs.webkit.org/show_bug.cgi?id=129234

Reviewed by Joseph Pecoraro.

While it's unclear to me what happened, the "position" property for the color picker sliders
wasn't being computed as expected and used relative positioning. I assume this is related to
r164543 when the order of CSS files changed.

* UserInterface/Views/Slider.css:
(.slider):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] generate-gtkdoc should use argparse
mrobinson@webkit.org [Sun, 23 Feb 2014 21:41:11 +0000 (21:41 +0000)]
[GTK] generate-gtkdoc should use argparse
https://bugs.webkit.org/show_bug.cgi?id=128418

Reviewed by Carlos Garcia Campos.

* gtk/generate-gtkdoc: Get all arguments from argparse, pass then as parameters
to all functions, and guard the main routine with a __name__ == __main__ check.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK][CMake] Many plugin tests fail when running WebKit1 layout tests
mrobinson@webkit.org [Sun, 23 Feb 2014 21:39:58 +0000 (21:39 +0000)]
[GTK][CMake] Many plugin tests fail when running WebKit1 layout tests
https://bugs.webkit.org/show_bug.cgi?id=129191

Reviewed by Anders Carlsson.

* DumpRenderTree/PlatformGTK.cmake: Properly specify the library build directory
for the GTK+ DumpRenderTree build. We could manually construct this path, but the
name of the directory is "lib" and not "libs". Instead we should use the CMake
variable specifically assigned to this task.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRefine DFG+FTL inlining and compilation limits
fpizlo@apple.com [Sun, 23 Feb 2014 18:48:43 +0000 (18:48 +0000)]
Refine DFG+FTL inlining and compilation limits
https://bugs.webkit.org/show_bug.cgi?id=129212

Reviewed by Mark Hahnenberg.

Allow larger functions to be DFG-compiled. Institute a limit on FTL compilation,
and set that limit quite high. Institute a limit on inlining-into. The idea here is
that large functions tend to be autogenerated, and code generators like emscripten
appear to leave few inlining opportunities anyway. Also, we don't want the code
size explosion that we would risk if we allowed compilation of a large function and
then inlined a ton of stuff into it.

This is a 0.5% speed-up on Octane v2 and almost eliminates the typescript
regression. This is a 9% speed-up on AsmBench.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::noticeIncomingCall):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleInlining):
* dfg/DFGCapabilities.h:
(JSC::DFG::isSmallEnoughToInlineCodeInto):
* ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
* ftl/FTLState.h:
(JSC::FTL::shouldShowDisassembly):
* runtime/Options.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[ASan] Add JSC::DFG::prepareOSREntry() to ignore list
ddkilzer@apple.com [Sun, 23 Feb 2014 18:06:16 +0000 (18:06 +0000)]
[ASan] Add JSC::DFG::prepareOSREntry() to ignore list
<http://webkit.org/b/129209>

Reviewed by Geoffrey Garen.

* asan/webkit-asan-ignore.txt: Add DFG::prepareOSREntry() to the
ignore list to make ASan builds usable again.  Follow-up
investigation is tracked by <rdar://problem/16055903>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSubpixel rendering: Fix bleed avoidance subpixel calculation.
zalan@apple.com [Sun, 23 Feb 2014 16:25:43 +0000 (16:25 +0000)]
Subpixel rendering: Fix bleed avoidance subpixel calculation.
https://bugs.webkit.org/show_bug.cgi?id=129225

Reviewed by Simon Fraser.

static_cast<LayoutUnit>(int value) only produces the desired result when subpixel is off.

Currently not testable.

* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::getBackgroundRoundedRect):
(WebCore::shrinkRectByOneDevicePixel):
(WebCore::RenderBoxModelObject::borderInnerRectAdjustedForBleedAvoidance):
(WebCore::RenderBoxModelObject::backgroundRoundedRectAdjustedForBleedAvoidance):
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
* rendering/RenderBoxModelObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSubpixel rendering: Add devicepixel based computation to BorderEdge class.
zalan@apple.com [Sun, 23 Feb 2014 16:22:58 +0000 (16:22 +0000)]
Subpixel rendering: Add devicepixel based computation to BorderEdge class.
https://bugs.webkit.org/show_bug.cgi?id=129224

Reviewed by Simon Fraser.

To produce correct width (and type) results, BorderEdge class needs to take device pixel ratio into account.

Currently not testable.

* rendering/RenderBoxModelObject.cpp:
(WebCore::BorderEdge::BorderEdge):
(WebCore::BorderEdge::obscuresBackgroundEdge):
(WebCore::BorderEdge::getDoubleBorderStripeWidths): this does not always produce the same
result as before, but the sum of inner and outer is not different.
(WebCore::BorderEdge::borderWidthInDevicePixel):
(WebCore::RenderBoxModelObject::getBorderEdgeInfo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r164507): Crash beneath JSGlobalObjectInspectorController::reportAPIExcep...
mitz@apple.com [Sun, 23 Feb 2014 05:44:05 +0000 (05:44 +0000)]
REGRESSION (r164507): Crash beneath JSGlobalObjectInspectorController::reportAPIException at facebook.com, twitter.com, youtube.com
https://bugs.webkit.org/show_bug.cgi?id=129227

Reviewed by Eric Carlson.

Reverted r164507.

Source/JavaScriptCore:

* API/JSBase.cpp:
(JSEvaluateScript):
(JSCheckScriptSyntax):
* API/JSObjectRef.cpp:
(JSObjectMakeFunction):
(JSObjectMakeArray):
(JSObjectMakeDate):
(JSObjectMakeError):
(JSObjectMakeRegExp):
(JSObjectGetProperty):
(JSObjectSetProperty):
(JSObjectGetPropertyAtIndex):
(JSObjectSetPropertyAtIndex):
(JSObjectDeleteProperty):
(JSObjectCallAsFunction):
(JSObjectCallAsConstructor):
* API/JSValue.mm:
(valueToArray):
(valueToDictionary):
* API/JSValueRef.cpp:
(JSValueIsEqual):
(JSValueIsInstanceOfConstructor):
(JSValueCreateJSONString):
(JSValueToNumber):
(JSValueToStringCopy):
(JSValueToObject):
* inspector/ConsoleMessage.cpp:
(Inspector::ConsoleMessage::ConsoleMessage):
(Inspector::ConsoleMessage::autogenerateMetadata):
* inspector/ConsoleMessage.h:
* inspector/JSGlobalObjectInspectorController.cpp:
(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
* inspector/JSGlobalObjectInspectorController.h:
* inspector/ScriptCallStack.cpp:
* inspector/ScriptCallStack.h:
* inspector/ScriptCallStackFactory.cpp:
(Inspector::createScriptCallStack):
(Inspector::createScriptCallStackForConsole):
(Inspector::createScriptCallStackFromException):
* inspector/ScriptCallStackFactory.h:
* inspector/agents/InspectorConsoleAgent.cpp:
(Inspector::InspectorConsoleAgent::enable):
(Inspector::InspectorConsoleAgent::addMessageToConsole):
(Inspector::InspectorConsoleAgent::count):
* inspector/agents/JSGlobalObjectDebuggerAgent.cpp:
(Inspector::JSGlobalObjectDebuggerAgent::breakpointActionLog):

Source/WebCore:

* bindings/js/JSDOMBinding.cpp:
(WebCore::reportException):
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::buildInitiatorObject):
* inspector/PageDebuggerAgent.cpp:
(WebCore::PageDebuggerAgent::breakpointActionLog):
* inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createGenericRecord):
* page/Console.cpp:
(WebCore::internalAddMessage):
(WebCore::Console::profile):
(WebCore::Console::profileEnd):
(WebCore::Console::timeEnd):
* page/ContentSecurityPolicy.cpp:
(WebCore::gatherSecurityPolicyViolationEventData):
(WebCore::ContentSecurityPolicy::reportViolation):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::postMessage):

Source/WebInspectorUI:

* UserInterface/Views/ConsoleMessageImpl.js:
(WebInspector.ConsoleMessageImpl.prototype._formatMessage):
(WebInspector.ConsoleMessageImpl.prototype._populateStackTraceTreeElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove some unreachable code (-Wunreachable-code)
commit-queue@webkit.org [Sun, 23 Feb 2014 01:38:07 +0000 (01:38 +0000)]
Remove some unreachable code (-Wunreachable-code)
https://bugs.webkit.org/show_bug.cgi?id=129220

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-02-22
Reviewed by Eric Carlson.

Source/JavaScriptCore:

* API/tests/testapi.c:
(EvilExceptionObject_convertToType):
* disassembler/udis86/udis86_decode.c:
(decode_operand):

Source/WebCore:

* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processCharacterBuffer):
(WebCore::HTMLTreeBuilder::processEndTag):
The only tricky case. Here there was a break inside the
#if, but not the #else, and a break after the #endif.
Remove the break inside the #if, and always use the
break after the #endif.

* Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::modeToString):
* bindings/js/JSTrackCustom.cpp:
(WebCore::toJS):
* bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::functionForUniform):
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute):
* page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::CaptionUserPreferencesMediaAF::captionDisplayMode):

Source/WebKit2:

* WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
(WebKit::toAPI):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLetterpress effect disabled for synthetic italic
dino@apple.com [Sat, 22 Feb 2014 23:59:16 +0000 (23:59 +0000)]
Letterpress effect disabled for synthetic italic
https://bugs.webkit.org/show_bug.cgi?id=129218
<rdar://problem/15997846>

Reviewed by Dan Bernstein.

There was no need to guard against synthetic italics and letterpress.

* platform/graphics/mac/FontMac.mm:
(WebCore::Font::drawGlyphs): Remove !useLetterpressEffect from conditional.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoExpose phase and momentum phase as SPI on DOMWheelEvent
weinig@apple.com [Sat, 22 Feb 2014 23:56:26 +0000 (23:56 +0000)]
Expose phase and momentum phase as SPI on DOMWheelEvent
<rdar://problem/16110871>
https://bugs.webkit.org/show_bug.cgi?id=129184

Reviewed by Anders Carlsson.

../WebCore:

* WebCore.exp.in:
Export core(DOMWheelEvent).

* WebCore.xcodeproj/project.pbxproj:
Make DOMWheelEventInternal.h available in WebKit.

* dom/Element.cpp:
(WebCore::Element::dispatchWheelEvent):
* dom/WheelEvent.cpp:
(WebCore::determineDeltaMode):
(WebCore::WheelEvent::WheelEvent):
(WebCore::WheelEvent::initWheelEvent):
(WebCore::WheelEvent::initWebKitWheelEvent):
Move PlatformWheelEvent -> DOMWheelEvent conversion to DOMWheelEvent.

* dom/WheelEvent.h:
(WebCore::WheelEvent::create):
(WebCore::WheelEvent::phase):
(WebCore::WheelEvent::momentumPhase):
Store phase and momentumPhase on the WheelEvent.

../WebKit/mac:

* DOM/WebDOMOperations.mm:
(toNSEventPhase):
(-[DOMWheelEvent _phase]):
(-[DOMWheelEvent _momentumPhase]):
* DOM/WebDOMOperationsPrivate.h:
Expose _phase and _momentumPhase as SPI.

* MigrateHeaders.make:
Make DOMWheelEventInternal.h to WebKit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Cocoa] WKUIDelegate.h is a project header
mitz@apple.com [Sat, 22 Feb 2014 22:39:22 +0000 (22:39 +0000)]
[Cocoa] WKUIDelegate.h is a project header
https://bugs.webkit.org/show_bug.cgi?id=129215

Reviewed by Anders Carlsson.

* WebKit2.xcodeproj/project.pbxproj: Make it a public header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, ARMv7 build fix.
fpizlo@apple.com [Sat, 22 Feb 2014 20:03:01 +0000 (20:03 +0000)]
Unreviewed, ARMv7 build fix.

* assembler/ARMv7Assembler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIt should be possible for a LinkBuffer to outlive the MacroAssembler and still be...
fpizlo@apple.com [Sat, 22 Feb 2014 19:55:12 +0000 (19:55 +0000)]
It should be possible for a LinkBuffer to outlive the MacroAssembler and still be useful
https://bugs.webkit.org/show_bug.cgi?id=124733

Reviewed by Oliver Hunt.

This also takes the opportunity to de-duplicate some branch compaction code.

* assembler/ARM64Assembler.h:
* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::buffer):
* assembler/AssemblerBuffer.h:
(JSC::AssemblerData::AssemblerData):
(JSC::AssemblerBuffer::AssemblerBuffer):
(JSC::AssemblerBuffer::storage):
(JSC::AssemblerBuffer::grow):
* assembler/LinkBuffer.h:
(JSC::LinkBuffer::LinkBuffer):
(JSC::LinkBuffer::executableOffsetFor):
(JSC::LinkBuffer::applyOffset):
* assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::link):
* assembler/MacroAssemblerARMv7.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago<rdar://problem/12500358> [Cocoa] Development variants of XPC services should not...
mitz@apple.com [Sat, 22 Feb 2014 18:44:28 +0000 (18:44 +0000)]
<rdar://problem/12500358> [Cocoa] Development variants of XPC services should not be installed in WebKit2.framework/XPCServices
https://bugs.webkit.org/show_bug.cgi?id=129197

Reviewed by Sam Weinig.

* Configurations/BaseXPCService.xcconfig: Made INSTALL_PATH vary based on
WK_XPC_SERVICE_VARIANT. For the Development variant, use an install path outside the
framework. Note that engineering builds using the build action continue to have the
Development variants copied into the framework by a script build phase.
* Configurations/DatabaseService.Development.xcconfig: Set WK_XPC_SERVICE_VARIANT.
* Configurations/DatabaseService.xcconfig: Ditto.
* Configurations/NetworkService.Development.xcconfig: Ditto.
* Configurations/NetworkService.xcconfig: Ditto.
* Configurations/PluginService.32.xcconfig: Ditto.
* Configurations/PluginService.64.xcconfig: Ditto.
* Configurations/PluginService.Development.xcconfig: Ditto.
* Configurations/WebContentService.Development.xcconfig: Ditto.
* Configurations/WebContentService.xcconfig: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRename JWK key_ops values from wrap/unwrap to wrapKey/unwrapKey
ap@apple.com [Sat, 22 Feb 2014 18:10:37 +0000 (18:10 +0000)]
Rename JWK key_ops values from wrap/unwrap to wrapKey/unwrapKey
https://bugs.webkit.org/show_bug.cgi?id=129121

Reviewed by Sam Weinig.

Source/WebCore:

* bindings/js/JSCryptoKeySerializationJWK.cpp:
(WebCore::JSCryptoKeySerializationJWK::reconcileUsages): Updated to newer names.
(WebCore::addUsagesToJSON): Ditto.
(WebCore::JSCryptoKeySerializationJWK::serialize): rsa-oaep-key-manipulation test
started ot fail, because RSA-OAEP with 2048 bit key and sha-1 can only encrypt
214 bytes, and the new longer names made JSON serialization slightly longer.
Compensate by not doing any indentation in JSON.

LayoutTests:

* crypto/subtle/aes-export-key-expected.txt:
* crypto/subtle/aes-export-key.html:
* crypto/subtle/jwk-export-use-values-expected.txt:
* crypto/subtle/jwk-export-use-values.html:
* crypto/subtle/jwk-import-use-values-expected.txt:
* crypto/subtle/jwk-import-use-values.html:
* crypto/subtle/rsa-oaep-key-manipulation-expected.txt:
* crypto/subtle/rsa-oaep-key-manipulation.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix tests.
timothy@apple.com [Sat, 22 Feb 2014 17:50:55 +0000 (17:50 +0000)]
Fix tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix production builds and tests.
timothy@apple.com [Sat, 22 Feb 2014 17:48:46 +0000 (17:48 +0000)]
Fix production builds and tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoOrganize WebInspectorUI/UserInterface into sub-directories.
timothy@apple.com [Sat, 22 Feb 2014 17:33:44 +0000 (17:33 +0000)]
Organize WebInspectorUI/UserInterface into sub-directories.

https://bugs.webkit.org/show_bug.cgi?id=129194

Rubber-stamped by Joseph Pecoraro.

* Scripts/copy-user-interface-resources.sh: Fix Image URLs and Protocol paths.
* UserInterface/Base: Added.
* UserInterface/Controllers: Added.
* UserInterface/Images: Added.
* UserInterface/Main.html: Updated.
* UserInterface/Models Added.
* UserInterface/Protocol Added.
* UserInterface/Views: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRevert r164434 since it actually broke ASan builds
ddkilzer@apple.com [Sat, 22 Feb 2014 17:31:15 +0000 (17:31 +0000)]
Revert r164434 since it actually broke ASan builds
<http://webkit.org/b/128871>

* Configurations/WebKit.xcconfig: This caused -asan-blacklist to
be included twice on every compiler command, which caused clang
to error out.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd inspection user interface for IndexedDB.
timothy@apple.com [Sat, 22 Feb 2014 16:06:41 +0000 (16:06 +0000)]
Add inspection user interface for IndexedDB.

https://bugs.webkit.org/show_bug.cgi?id=129162

Reviewed by Joseph Pecoraro.

Source/WebInspectorUI:

* Localizations/en.lproj/localizedStrings.js: Updated.
* UserInterface/ContentView.js:
(WebInspector.ContentView):
(WebInspector.ContentView.isViewable):
* UserInterface/IndexedDatabase.js: Added.
(WebInspector.IndexedDatabase):
(WebInspector.IndexedDatabase.prototype.get name):
(WebInspector.IndexedDatabase.prototype.get securityOrigin):
(WebInspector.IndexedDatabase.prototype.get host):
(WebInspector.IndexedDatabase.prototype.get version):
(WebInspector.IndexedDatabase.prototype.get objectStores):
(WebInspector.IndexedDatabase.prototype.saveIdentityToCookie):
* UserInterface/IndexedDatabaseEntryDataGridNode.js: Added.
(WebInspector.IndexedDatabaseEntryDataGridNode):
(WebInspector.IndexedDatabaseEntryDataGridNode.prototype.get entry):
(WebInspector.IndexedDatabaseEntryDataGridNode.prototype.createCellContent):
* UserInterface/IndexedDatabaseHostTreeElement.js: Added.
(WebInspector.IndexedDatabaseHostTreeElement):
(WebInspector.IndexedDatabaseHostTreeElement.prototype.get name):
(WebInspector.IndexedDatabaseHostTreeElement.prototype.get categoryName):
* UserInterface/IndexedDatabaseObjectStore.js: Added.
(WebInspector.IndexedDatabaseObjectStore):
(WebInspector.IndexedDatabaseObjectStore.prototype.get name):
(WebInspector.IndexedDatabaseObjectStore.prototype.get keyPath):
(WebInspector.IndexedDatabaseObjectStore.prototype.get autoIncrement):
(WebInspector.IndexedDatabaseObjectStore.prototype.get parentDatabase):
(WebInspector.IndexedDatabaseObjectStore.prototype.get indexes):
(WebInspector.IndexedDatabaseObjectStore.prototype.saveIdentityToCookie):
(WebInspector.IndexedDatabaseObjectStore.prototype.establishRelationship):
* UserInterface/IndexedDatabaseObjectStoreContentView.css: Added.
(.content-view.indexed-database-object-store > .data-grid):
(.content-view.indexed-database-object-store > .data-grid td .section .header):
(.content-view.indexed-database-object-store > .data-grid td .section .header::before):
(.content-view.indexed-database-object-store > .data-grid td .section .header .title):
(.content-view.indexed-database-object-store > .data-grid table.data):
(.content-view.indexed-database-object-store > .data-grid table.data tr:nth-child(even)):
(.content-view.indexed-database-object-store > .data-grid table.data tr:nth-child(odd)):
(.content-view.indexed-database-object-store > .data-grid table.data tr.filler):
(.content-view.indexed-database-object-store > .data-grid :focus tr.selected td .section .header::before):
(.content-view.indexed-database-object-store > .data-grid :focus tr.selected td .section.expanded .header::before):
(.content-view.indexed-database-object-store > .data-grid :focus tr.selected td .properties-tree li.parent::before):
(.content-view.indexed-database-object-store > .data-grid :focus tr.selected td .properties-tree li.parent.expanded::before):
(.content-view.indexed-database-object-store > .data-grid :focus tr.selected td .properties-tree li *):
* UserInterface/IndexedDatabaseObjectStoreContentView.js: Added.
(WebInspector.IndexedDatabaseObjectStoreContentView.displayKeyPath):
(WebInspector.IndexedDatabaseObjectStoreContentView):
(WebInspector.IndexedDatabaseObjectStoreContentView.prototype.closed):
(WebInspector.IndexedDatabaseObjectStoreContentView.prototype.saveToCookie):
(WebInspector.IndexedDatabaseObjectStoreContentView.prototype.updateLayout):
(WebInspector.IndexedDatabaseObjectStoreContentView.prototype._reset):
(WebInspector.IndexedDatabaseObjectStoreContentView.prototype._dataGridScrolled):
(WebInspector.IndexedDatabaseObjectStoreContentView.prototype._fetchMoreData.processEntries):
(WebInspector.IndexedDatabaseObjectStoreContentView.prototype._fetchMoreData):
* UserInterface/IndexedDatabaseObjectStoreIndex.js: Added.
(WebInspector.IndexedDatabaseObjectStoreIndex):
(WebInspector.IndexedDatabaseObjectStoreIndex.prototype.get name):
(WebInspector.IndexedDatabaseObjectStoreIndex.prototype.get keyPath):
(WebInspector.IndexedDatabaseObjectStoreIndex.prototype.get unique):
(WebInspector.IndexedDatabaseObjectStoreIndex.prototype.get multiEntry):
(WebInspector.IndexedDatabaseObjectStoreIndex.prototype.get parentObjectStore):
(WebInspector.IndexedDatabaseObjectStoreIndex.prototype.saveIdentityToCookie):
(WebInspector.IndexedDatabaseObjectStoreIndex.prototype.establishRelationship):
* UserInterface/IndexedDatabaseObjectStoreIndexTreeElement.js: Added.
(WebInspector.IndexedDatabaseObjectStoreIndexTreeElement):
(WebInspector.IndexedDatabaseObjectStoreIndexTreeElement.prototype.get objectStoreIndex):
* UserInterface/IndexedDatabaseObjectStoreTreeElement.js: Added.
(WebInspector.IndexedDatabaseObjectStoreTreeElement):
(WebInspector.IndexedDatabaseObjectStoreTreeElement.prototype.get objectStore):
(WebInspector.IndexedDatabaseObjectStoreTreeElement.prototype.oncollapse):
(WebInspector.IndexedDatabaseObjectStoreTreeElement.prototype.onpopulate):
* UserInterface/IndexedDatabaseTreeElement.js: Added.
(WebInspector.IndexedDatabaseTreeElement):
(WebInspector.IndexedDatabaseTreeElement.prototype.get indexedDatabase):
(WebInspector.IndexedDatabaseTreeElement.prototype.oncollapse):
(WebInspector.IndexedDatabaseTreeElement.prototype.onpopulate):
* UserInterface/Main.html:
* UserInterface/Main.js:
(WebInspector.sidebarPanelForRepresentedObject):
* UserInterface/ResourceSidebarPanel.js:
(WebInspector.ResourceSidebarPanel):
(WebInspector.ResourceSidebarPanel.prototype._treeElementSelected):
(WebInspector.ResourceSidebarPanel.prototype._indexedDatabaseWasAdded):
(WebInspector.ResourceSidebarPanel.prototype._storageCleared):
* UserInterface/StorageManager.js:
(WebInspector.StorageManager):
(WebInspector.StorageManager.prototype.initialize):
(WebInspector.StorageManager.prototype.processData):
(WebInspector.StorageManager.prototype.requestIndexedDatabaseData):
(WebInspector.StorageManager.prototype._mainResourceDidChange):
(WebInspector.StorageManager.prototype._addIndexedDBDatabasesIfNeeded.processDatabaseNames):
(WebInspector.StorageManager.prototype._addIndexedDBDatabasesIfNeeded.processDatabase):
(WebInspector.StorageManager.prototype._addIndexedDBDatabasesIfNeeded):
(WebInspector.StorageManager.prototype._addIndexedDBDatabasesIfNeeded.processObjectStore):
(WebInspector.StorageManager.prototype._addIndexedDBDatabasesIfNeeded.processObjectStoreIndex):
(WebInspector.StorageManager.prototype._securityOriginDidChange):
* UserInterface/URLUtilities.js:
(parseSecurityOrigin):

LayoutTests:

* http/tests/inspector-protocol/resources/InspectorTest.js:
(InspectorTest.initializeInspectorModels): Add IndexedDatabase models and StorageManager.
* inspector-protocol/indexeddb/basics-expected.txt: Added.
* inspector-protocol/indexeddb/basics.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: allow drag-to-adjust on angle input of gradients editor
graouts@webkit.org [Sat, 22 Feb 2014 15:29:13 +0000 (15:29 +0000)]
Web Inspector: allow drag-to-adjust on angle input of gradients editor
https://bugs.webkit.org/show_bug.cgi?id=129095

Reviewed by Timothy Hatcher.

Rename CodeMirrorDragToAlterNumberController to CodeMirrorDragToAdjustNumberController and move
the core logic of a drag-to-adjust behavior out of it to a new generic class DragToAdjustController.
We use this new class from CodeMirrorGradientEditingController to provide drag-to-adjust behavior
in the angle input field of the gradient editor and also as a supporting object for the CodeMirror-
specific class.

* UserInterface/CodeMirrorDragToAdjustNumberController.css: Renamed from Source/WebInspectorUI/UserInterface/CodeMirrorDragToAlterNumberController.css.
(.CodeMirror.drag-to-adjust .CodeMirror-lines):

* UserInterface/CodeMirrorDragToAdjustNumberController.js: Added.
Removed the UI logic and use the new DragToAdjustController as a supporting object instead. We implement
the various DragToAdjustController delegate methods in order to customize its behavior to work within the
context of a CodeMirror editor, specifically to prevent activation when the editor is read-only and to
prevent adjustment when the hovered token isn't a number.

(WebInspector.CodeMirrorDragToAdjustNumberController):
(WebInspector.CodeMirrorDragToAdjustNumberController.prototype.get enabled):
(WebInspector.CodeMirrorDragToAdjustNumberController.prototype.set enabled):
(WebInspector.CodeMirrorDragToAdjustNumberController.prototype.dragToAdjustControllerActiveStateChanged):
(WebInspector.CodeMirrorDragToAdjustNumberController.prototype.dragToAdjustControllerCanBeActivated):
(WebInspector.CodeMirrorDragToAdjustNumberController.prototype.dragToAdjustControllerCanBeAdjusted):
(WebInspector.CodeMirrorDragToAdjustNumberController.prototype.dragToAdjustControllerWasAdjustedByAmount):
(WebInspector.CodeMirrorDragToAdjustNumberController.prototype.dragToAdjustControllerDidReset):
(WebInspector.CodeMirrorDragToAdjustNumberController.prototype.dragToAdjustControllerCanAdjustObjectAtPoint):

* UserInterface/CodeMirrorGradientEditingController.css:
(.gradient-editing-controller > label.drag-to-adjust > input):

* UserInterface/CodeMirrorGradientEditingController.js:
Adopt the new DragToAdjustController to make the angle input field value adjustable by dragging.

(WebInspector.CodeMirrorGradientEditingController.prototype.popoverWillPresent):
(WebInspector.CodeMirrorGradientEditingController.prototype.dragToAdjustControllerWasAdjustedByAmount):
(WebInspector.CodeMirrorGradientEditingController.prototype._handleInputEvent):
(WebInspector.CodeMirrorGradientEditingController.prototype._angleInputValueDidChange):

* UserInterface/DragToAdjustController.js: Renamed from Source/WebInspectorUI/UserInterface/CodeMirrorDragToAlterNumberController.js.
New DragToAdjustController class exposing only the core UI logic of a drag-to-adjust behavior in the context
of a DOM element, exposing a few delegation methods to customize the controller's behavior:

- dragToAdjustControllerActiveStateChanged() notifies that the .active property has changed, allowing bringup
and cleanup work to be performed.

- dragToAdjustControllerDidReset() notifies that the various tracking states of the controller have been reset
allowing other state objects used by clients to be cleared.

- dragToAdjustControllerCanBeActivated() is used to check whether the controller may enter the active state upon
first hovering the target element.

- dragToAdjustControllerCanBeAdjusted() is used to check whether adjustment can be performed at the moment when
the user actually is about to engage in a drag-to-adjust interaction.

- dragToAdjustControllerCanAdjustObjectAtPoint() is used to check whether the object at the provided point (mouse
location) is an adjustable value.

- dragToAdjustControllerWasAdjustedByAmount() notifies that there is a new amount to add to the current value
following a drag-to-adjust interaction.

(WebInspector.DragToAdjustController):
(WebInspector.DragToAdjustController.prototype.get element):
(WebInspector.DragToAdjustController.prototype.set element):
(WebInspector.DragToAdjustController.prototype.set enabled):
(WebInspector.DragToAdjustController.prototype.get active):
(WebInspector.DragToAdjustController.prototype.set active):
(WebInspector.DragToAdjustController.prototype.reset):
(WebInspector.DragToAdjustController.prototype.handleEvent):
(WebInspector.DragToAdjustController.prototype._setDragging):
(WebInspector.DragToAdjustController.prototype._setTracksMouseClickAndDrag):
(WebInspector.DragToAdjustController.prototype._modifiersDidChange):
(WebInspector.DragToAdjustController.prototype._mouseMoved):
(WebInspector.DragToAdjustController.prototype._mouseWasPressed):
(WebInspector.DragToAdjustController.prototype._mouseWasDragged):
(WebInspector.DragToAdjustController.prototype._mouseWasReleased):

* UserInterface/Main.html:
Link in new source files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoReplace svg/clip-path pixel tests by reference tests
krit@webkit.org [Sat, 22 Feb 2014 13:58:51 +0000 (13:58 +0000)]
Replace svg/clip-path pixel tests by reference tests
https://bugs.webkit.org/show_bug.cgi?id=129177

Patch by Dirk Schulze <krit@webkit.org> on 2014-02-21
Rubber-stamped by Ryosuke Niwa.

This patch removes all pixel tests.

* platform/efl/svg/clip-path/clip-in-mask-expected.png: Removed.
* platform/efl/svg/clip-path/clip-path-childs-clipped-expected.png: Removed.
* platform/efl/svg/clip-path/clip-path-clipped-evenodd-twice-expected.png: Removed.
* platform/efl/svg/clip-path/clip-path-clipped-expected.png: Removed.
* platform/efl/svg/clip-path/clip-path-clipped-nonzero-expected.png: Removed.
* platform/efl/svg/clip-path/clip-path-css-transform-1-expected.png: Removed.
* platform/efl/svg/clip-path/clip-path-css-transform-2-expected.png: Removed.
* platform/efl/svg/clip-path/clip-path-objectBoundingBox-expected.png: Removed.
* platform/efl/svg/clip-path/clip-path-on-clipped-use-expected.png: Removed.
* platform/efl/svg/clip-path/clip-path-on-g-and-child-expected.png: Removed.
* platform/efl/svg/clip-path/clip-path-on-g-expected.png: Removed.
* platform/efl/svg/clip-path/clip-path-on-svg-and-child-expected.png: Removed.
* platform/efl/svg/clip-path/clip-path-on-svg-expected.png: Removed.
* platform/efl/svg/clip-path/clip-path-pixelation-expected.png: Removed.
* platform/efl/svg/clip-path/clip-path-text-and-stroke-expected.png: Removed.
* platform/efl/svg/clip-path/clip-path-text-expected.png: Removed.
* platform/efl/svg/clip-path/clip-path-transform-2-expected.png: Removed.
* platform/efl/svg/clip-path/clip-path-tspan-and-stroke-expected.png: Removed.
* platform/efl/svg/clip-path/clip-path-use-as-child-expected.png: Removed.
* platform/efl/svg/clip-path/clip-path-userSpaceOnUse-expected.png: Removed.
* platform/efl/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.png: Removed.
* platform/efl/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.txt: Removed.
* platform/efl/svg/clip-path/deep-nested-clip-in-mask-expected.png: Removed.
* platform/efl/svg/clip-path/deep-nested-clip-in-mask-panning-expected.png: Removed.
* platform/efl/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.png: Removed.
* platform/efl/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.png: Removed.
* platform/efl/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.png: Removed.
* platform/gtk/svg/clip-path/clip-in-mask-expected.png: Removed.
* platform/gtk/svg/clip-path/clip-path-child-clipped-expected.png: Removed.
* platform/gtk/svg/clip-path/clip-path-childs-clipped-expected.png: Removed.
* platform/gtk/svg/clip-path/clip-path-clipped-evenodd-twice-expected.png: Removed.
* platform/gtk/svg/clip-path/clip-path-clipped-expected.png: Removed.
* platform/gtk/svg/clip-path/clip-path-clipped-nonzero-expected.png: Removed.
* platform/gtk/svg/clip-path/clip-path-css-transform-1-expected.png: Removed.
* platform/gtk/svg/clip-path/clip-path-css-transform-2-expected.png: Removed.
* platform/gtk/svg/clip-path/clip-path-evenodd-expected.png: Removed.
* platform/gtk/svg/clip-path/clip-path-evenodd-nonzero-expected.png: Removed.
* platform/gtk/svg/clip-path/clip-path-nonzero-evenodd-expected.png: Removed.
* platform/gtk/svg/clip-path/clip-path-nonzero-expected.png: Removed.
* platform/gtk/svg/clip-path/clip-path-objectBoundingBox-expected.png: Removed.
* platform/gtk/svg/clip-path/clip-path-on-clipped-use-expected.png: Removed.
* platform/gtk/svg/clip-path/clip-path-on-g-and-child-expected.png: Removed.
* platform/gtk/svg/clip-path/clip-path-on-g-expected.png: Removed.
* platform/gtk/svg/clip-path/clip-path-on-svg-and-child-expected.png: Removed.
* platform/gtk/svg/clip-path/clip-path-on-svg-expected.png: Removed.
* platform/gtk/svg/clip-path/clip-path-pixelation-expected.png: Removed.
* platform/gtk/svg/clip-path/clip-path-text-and-shape-expected.png: Removed.
* platform/gtk/svg/clip-path/clip-path-text-and-stroke-expected.png: Removed.
* platform/gtk/svg/clip-path/clip-path-text-expected.png: Removed.
* platform/gtk/svg/clip-path/clip-path-transform-2-expected.png: Removed.
* platform/gtk/svg/clip-path/clip-path-tspan-and-stroke-expected.png: Removed.
* platform/gtk/svg/clip-path/clip-path-use-as-child-expected.png: Removed.
* platform/gtk/svg/clip-path/clip-path-userSpaceOnUse-expected.png: Removed.
* platform/gtk/svg/clip-path/clip-path-with-text-clipped-expected.png: Removed.
* platform/gtk/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.png: Removed.
* platform/gtk/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.txt: Removed.
* platform/gtk/svg/clip-path/deep-nested-clip-in-mask-expected.png: Removed.
* platform/gtk/svg/clip-path/deep-nested-clip-in-mask-panning-expected.png: Removed.
* platform/gtk/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.png: Removed.
* platform/gtk/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.png: Removed.
* platform/gtk/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.png: Removed.
* platform/mac/svg/clip-path/clip-in-clip-expected.png: Removed.
* platform/mac/svg/clip-path/clip-in-mask-expected.png: Removed.
* platform/mac/svg/clip-path/clip-in-mask-objectBoundingBox-expected.png: Removed.
* platform/mac/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.png: Removed.
* platform/mac/svg/clip-path/clip-path-child-clipped-expected.png: Removed.
* platform/mac/svg/clip-path/clip-path-childs-clipped-expected.png: Removed.
* platform/mac/svg/clip-path/clip-path-clipped-evenodd-twice-expected.png: Removed.
* platform/mac/svg/clip-path/clip-path-clipped-expected.png: Removed.
* platform/mac/svg/clip-path/clip-path-clipped-no-content-expected.png: Removed.
* platform/mac/svg/clip-path/clip-path-clipped-nonzero-expected.png: Removed.
* platform/mac/svg/clip-path/clip-path-css-transform-1-expected.png: Removed.
* platform/mac/svg/clip-path/clip-path-css-transform-2-expected.png: Removed.
* platform/mac/svg/clip-path/clip-path-evenodd-expected.png: Removed.
* platform/mac/svg/clip-path/clip-path-evenodd-nonzero-expected.png: Removed.
* platform/mac/svg/clip-path/clip-path-nonzero-evenodd-expected.png: Removed.
* platform/mac/svg/clip-path/clip-path-nonzero-expected.png: Removed.
* platform/mac/svg/clip-path/clip-path-objectBoundingBox-expected.png: Removed.
* platform/mac/svg/clip-path/clip-path-on-clipped-use-expected.png: Removed.
* platform/mac/svg/clip-path/clip-path-on-g-and-child-expected.png: Removed.
* platform/mac/svg/clip-path/clip-path-on-g-expected.png: Removed.
* platform/mac/svg/clip-path/clip-path-on-svg-and-child-expected.png: Removed.
* platform/mac/svg/clip-path/clip-path-on-svg-expected.png: Removed.
* platform/mac/svg/clip-path/clip-path-pixelation-expected.png: Removed.
* platform/mac/svg/clip-path/clip-path-pixelation-expected.txt: Removed.
* platform/mac/svg/clip-path/clip-path-recursive-call-by-child-expected.png: Removed.
* platform/mac/svg/clip-path/clip-path-recursive-call-expected.png: Removed.
* platform/mac/svg/clip-path/clip-path-text-and-shape-expected.png: Removed.
* platform/mac/svg/clip-path/clip-path-text-and-shape-expected.txt: Removed.
* platform/mac/svg/clip-path/clip-path-text-and-stroke-expected.png: Removed.
* platform/mac/svg/clip-path/clip-path-text-and-stroke-expected.txt: Removed.
* platform/mac/svg/clip-path/clip-path-text-expected.png: Removed.
* platform/mac/svg/clip-path/clip-path-text-expected.txt: Removed.
* platform/mac/svg/clip-path/clip-path-transform-1-expected.png: Removed.
* platform/mac/svg/clip-path/clip-path-transform-2-expected.png: Removed.
* platform/mac/svg/clip-path/clip-path-tspan-and-stroke-expected.png: Removed.
* platform/mac/svg/clip-path/clip-path-tspan-and-stroke-expected.txt: Removed.
* platform/mac/svg/clip-path/clip-path-use-as-child-expected.png: Removed.
* platform/mac/svg/clip-path/clip-path-use-as-child2-expected.png: Removed.
* platform/mac/svg/clip-path/clip-path-use-as-child3-expected.png: Removed.
* platform/mac/svg/clip-path/clip-path-use-as-child4-expected.png: Removed.
* platform/mac/svg/clip-path/clip-path-use-as-child5-expected.png: Removed.
* platform/mac/svg/clip-path/clip-path-userSpaceOnUse-expected.png: Removed.
* platform/mac/svg/clip-path/clip-path-with-container-expected.png: Removed.
* platform/mac/svg/clip-path/clip-path-with-different-unittypes-expected.png: Removed.
* platform/mac/svg/clip-path/clip-path-with-different-unittypes2-expected.png: Removed.
* platform/mac/svg/clip-path/clip-path-with-invisibile-child-expected.png: Removed.
* platform/mac/svg/clip-path/clip-path-with-text-clipped-expected.png: Removed.
* platform/mac/svg/clip-path/clip-path-with-text-clipped-expected.txt: Removed.
* platform/mac/svg/clip-path/clipper-placement-issue-expected.png: Removed.
* platform/mac/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.png: Removed.
* platform/mac/svg/clip-path/deep-nested-clip-in-mask-expected.png: Removed.
* platform/mac/svg/clip-path/deep-nested-clip-in-mask-expected.txt: Removed.
* platform/mac/svg/clip-path/deep-nested-clip-in-mask-panning-expected.png: Removed.
* platform/mac/svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt: Removed.
* platform/mac/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.png: Removed.
* platform/mac/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.png: Removed.
* platform/mac/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.png: Removed.
* svg/clip-path/clip-in-clip-expected.png: Removed.
* svg/clip-path/clip-in-clip-expected.txt: Removed.
* svg/clip-path/clip-in-clip.svg: Removed.
* svg/clip-path/clip-in-mask-expected.txt: Removed.
* svg/clip-path/clip-in-mask-objectBoundingBox-expected.txt: Removed.
* svg/clip-path/clip-in-mask-objectBoundingBox.svg: Removed.
* svg/clip-path/clip-in-mask-userSpaceOnUse-expected.txt: Removed.
* svg/clip-path/clip-in-mask-userSpaceOnUse.svg: Removed.
* svg/clip-path/clip-in-mask.svg: Removed.
* svg/clip-path/clip-path-child-clipped-expected.txt: Removed.
* svg/clip-path/clip-path-child-clipped.svg: Removed.
* svg/clip-path/clip-path-childs-clipped-expected.txt: Removed.
* svg/clip-path/clip-path-childs-clipped.svg: Removed.
* svg/clip-path/clip-path-clipped-evenodd-twice-expected.txt: Removed.
* svg/clip-path/clip-path-clipped-evenodd-twice.svg: Removed.
* svg/clip-path/clip-path-clipped-expected.txt: Removed.
* svg/clip-path/clip-path-clipped-no-content-expected.png: Removed.
* svg/clip-path/clip-path-clipped-no-content-expected.txt: Removed.
* svg/clip-path/clip-path-clipped-no-content.svg: Removed.
* svg/clip-path/clip-path-clipped-nonzero-expected.txt: Removed.
* svg/clip-path/clip-path-clipped-nonzero.svg: Removed.
* svg/clip-path/clip-path-clipped.svg: Removed.
* svg/clip-path/clip-path-css-transform-1-expected.txt: Removed.
* svg/clip-path/clip-path-css-transform-1.svg: Removed.
* svg/clip-path/clip-path-css-transform-2-expected.txt: Removed.
* svg/clip-path/clip-path-css-transform-2.svg: Removed.
* svg/clip-path/clip-path-evenodd-expected.txt: Removed.
* svg/clip-path/clip-path-evenodd-nonzero-expected.txt: Removed.
* svg/clip-path/clip-path-evenodd-nonzero.svg: Removed.
* svg/clip-path/clip-path-evenodd.svg: Removed.
* svg/clip-path/clip-path-nonzero-evenodd-expected.txt: Removed.
* svg/clip-path/clip-path-nonzero-evenodd.svg: Removed.
* svg/clip-path/clip-path-nonzero-expected.txt: Removed.
* svg/clip-path/clip-path-nonzero.svg: Removed.
* svg/clip-path/clip-path-objectBoundingBox-expected.txt: Removed.
* svg/clip-path/clip-path-objectBoundingBox.svg: Removed.
* svg/clip-path/clip-path-on-clipped-use-expected.txt: Removed.
* svg/clip-path/clip-path-on-clipped-use.svg: Removed.
* svg/clip-path/clip-path-on-g-and-child-expected.txt: Removed.
* svg/clip-path/clip-path-on-g-and-child.svg: Removed.
* svg/clip-path/clip-path-on-g-expected.txt: Removed.
* svg/clip-path/clip-path-on-g.svg: Removed.
* svg/clip-path/clip-path-on-svg-and-child-expected.txt: Removed.
* svg/clip-path/clip-path-on-svg-and-child.svg: Removed.
* svg/clip-path/clip-path-on-svg-expected.txt: Removed.
* svg/clip-path/clip-path-on-svg.svg: Removed.
* svg/clip-path/clip-path-pixelation-expected.txt: Removed.
* svg/clip-path/clip-path-pixelation.svg: Removed.
* svg/clip-path/clip-path-recursive-call-by-child-expected.png: Removed.
* svg/clip-path/clip-path-recursive-call-by-child-expected.txt: Removed.
* svg/clip-path/clip-path-recursive-call-by-child.svg: Removed.
* svg/clip-path/clip-path-recursive-call-expected.png: Removed.
* svg/clip-path/clip-path-recursive-call-expected.txt: Removed.
* svg/clip-path/clip-path-recursive-call.svg: Removed.
* svg/clip-path/clip-path-text-and-shape-expected.txt: Removed.
* svg/clip-path/clip-path-text-and-shape.svg: Removed.
* svg/clip-path/clip-path-text-and-stroke-expected.txt: Removed.
* svg/clip-path/clip-path-text-and-stroke.svg: Removed.
* svg/clip-path/clip-path-text-expected.txt: Removed.
* svg/clip-path/clip-path-text.svg: Removed.
* svg/clip-path/clip-path-transform-1-expected.txt: Removed.
* svg/clip-path/clip-path-transform-1.svg: Removed.
* svg/clip-path/clip-path-transform-2-expected.txt: Removed.
* svg/clip-path/clip-path-transform-2.svg: Removed.
* svg/clip-path/clip-path-tspan-and-stroke-expected.txt: Removed.
* svg/clip-path/clip-path-tspan-and-stroke.svg: Removed.
* svg/clip-path/clip-path-use-as-child-expected.txt: Removed.
* svg/clip-path/clip-path-use-as-child.svg: Removed.
* svg/clip-path/clip-path-use-as-child2-expected.png: Removed.
* svg/clip-path/clip-path-use-as-child2-expected.txt: Removed.
* svg/clip-path/clip-path-use-as-child2.svg: Removed.
* svg/clip-path/clip-path-use-as-child3-expected.png: Removed.
* svg/clip-path/clip-path-use-as-child3-expected.txt: Removed.
* svg/clip-path/clip-path-use-as-child3.svg: Removed.
* svg/clip-path/clip-path-use-as-child4-expected.png: Removed.
* svg/clip-path/clip-path-use-as-child4-expected.txt: Removed.
* svg/clip-path/clip-path-use-as-child4.svg: Removed.
* svg/clip-path/clip-path-use-as-child5-expected.png: Removed.
* svg/clip-path/clip-path-use-as-child5-expected.txt: Removed.
* svg/clip-path/clip-path-use-as-child5.svg: Removed.
* svg/clip-path/clip-path-userSpaceOnUse-expected.txt: Removed.
* svg/clip-path/clip-path-userSpaceOnUse.svg: Removed.
* svg/clip-path/clip-path-with-container-expected.png: Removed.
* svg/clip-path/clip-path-with-container-expected.txt: Removed.
* svg/clip-path/clip-path-with-container.svg: Removed.
* svg/clip-path/clip-path-with-different-unittypes-expected.png: Removed.
* svg/clip-path/clip-path-with-different-unittypes-expected.txt: Removed.
* svg/clip-path/clip-path-with-different-unittypes.svg: Removed.
* svg/clip-path/clip-path-with-different-unittypes2-expected.png: Removed.
* svg/clip-path/clip-path-with-different-unittypes2-expected.txt: Removed.
* svg/clip-path/clip-path-with-different-unittypes2.svg: Removed.
* svg/clip-path/clip-path-with-invisibile-child-expected.png: Removed.
* svg/clip-path/clip-path-with-invisibile-child-expected.txt: Removed.
* svg/clip-path/clip-path-with-invisibile-child.svg: Removed.
* svg/clip-path/clip-path-with-text-clipped-expected.txt: Removed.
* svg/clip-path/clip-path-with-text-clipped.svg: Removed.
* svg/clip-path/clipper-placement-issue-expected.png: Removed.
* svg/clip-path/clipper-placement-issue-expected.txt: Removed.
* svg/clip-path/clipper-placement-issue.svg: Removed.
* svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.txt: Removed.
* svg/clip-path/deep-nested-clip-in-mask-different-unitTypes.svg: Removed.
* svg/clip-path/deep-nested-clip-in-mask-expected.txt: Removed.
* svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt: Removed.
* svg/clip-path/deep-nested-clip-in-mask-panning.svg: Removed.
* svg/clip-path/deep-nested-clip-in-mask.svg: Removed.
* svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.txt: Removed.
* svg/clip-path/nested-clip-in-mask-image-based-clipping.svg: Removed.
* svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.txt: Removed.
* svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping.svg: Removed.
* svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.txt: Removed.
* svg/clip-path/nested-clip-in-mask-path-based-clipping.svg: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoOnly skip stretchy operators when determining the stretch height.
fred.wang@free.fr [Sat, 22 Feb 2014 10:21:18 +0000 (10:21 +0000)]
Only skip stretchy operators when determining the stretch height.
https://bugs.webkit.org/show_bug.cgi?id=126842

Reviewed by Chris Fleizach.

Source/WebCore:

The MathML code only takes into account non-mo children for the computation of the stretch size. This change includes non-stretchy mo in that computation. A new test is added into mathml/presentation/stretchy-depth-height.html.

* rendering/mathml/RenderMathMLRow.cpp:
(WebCore::RenderMathMLRow::layout):

LayoutTests:

* mathml/presentation/stretchy-depth-height.html: Add a test with non-stretchy mo siblings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImplement asymmetric/symmetric stretching of vertical operators.
fred.wang@free.fr [Sat, 22 Feb 2014 10:14:41 +0000 (10:14 +0000)]
Implement asymmetric/symmetric stretching of vertical operators.
https://bugs.webkit.org/show_bug.cgi?id=124827.

Reviewed by Chris Fleizach.

Source/WebCore:

The MathML code stretches vertical operators asymmetrically by default. This patch takes into account the symmetric attribute or the symmetric property of the operator dictionary to stretch operators symmetrically.

Test: mathml/presentation/stretchy-depth-height-symmetric.html

* rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::stretchTo):
(WebCore::RenderMathMLOperator::updateFromElement):
(WebCore::RenderMathMLOperator::updateStyle):

LayoutTests:

Add a new test to verify the symmetric property of operators (either implicit by the operator dictionary or explicit via an mo attribute).

* LayoutTests/platform/mac/mathml/presentation/mo-stretch-expected.txt: rebased.
* mathml/presentation/stretchy-depth-height-symmetric-expected.txt: Added.
* mathml/presentation/stretchy-depth-height-symmetric.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBug 119043 - Large stretch size error for MathML operators.
fred.wang@free.fr [Sat, 22 Feb 2014 10:08:02 +0000 (10:08 +0000)]
Bug 119043 - Large stretch size error for MathML operators.
https://bugs.webkit.org/show_bug.cgi?id=119043

Reviewed by Chris Fleizach.

Source/WebCore:

The MathML code used some arbitrary gOperatorExpansion factor for the
stretch size and 2/3 1/2 constants for the baseline. This change tries
to consider height/depth of siblings of the stretchy operator so that
the stretchy operator now matches its target.

Test: mathml/presentation/stretchy-depth-height.html

* rendering/RenderObject.h:
(WebCore::RenderObject::isRenderMathMLTable):
* rendering/mathml/RenderMathMLBlock.h:
* rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::RenderMathMLOperator):
(WebCore::RenderMathMLOperator::stretchTo):
(WebCore::RenderMathMLOperator::findAcceptableStretchyCharacter):
(WebCore::RenderMathMLOperator::updateStyle):
(WebCore::RenderMathMLOperator::firstLineBaseline):
(WebCore::RenderMathMLOperator::computeLogicalHeight):
* rendering/mathml/RenderMathMLOperator.h:
* rendering/mathml/RenderMathMLRow.cpp:
(WebCore::RenderMathMLRow::layout):

LayoutTests:

This adds a test to check that the depth/height of stretchy operators match the maximum of their siblings. This also fixes the reference of mo-stretch.html to ignore the stretch error.

* mathml/presentation/stretchy-depth-height-expected.txt: Added.
* mathml/presentation/stretchy-depth-height.html: Added.
* platform/mac/mathml/presentation/mo-stretch-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r164534.
fred.wang@free.fr [Sat, 22 Feb 2014 09:57:35 +0000 (09:57 +0000)]
Unreviewed, rolling out r164534.
http://trac.webkit.org/changeset/164534
https://bugs.webkit.org/show_bug.cgi?id=119043

missing tests

Source/WebCore:

* rendering/RenderObject.h:
* rendering/mathml/RenderMathMLBlock.h:
* rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::RenderMathMLOperator):
(WebCore::RenderMathMLOperator::expandedStretchHeight):
(WebCore::RenderMathMLOperator::stretchToHeight):
(WebCore::RenderMathMLOperator::findAcceptableStretchyCharacter):
(WebCore::RenderMathMLOperator::updateStyle):
(WebCore::RenderMathMLOperator::firstLineBaseline):
(WebCore::RenderMathMLOperator::computeLogicalHeight):
* rendering/mathml/RenderMathMLOperator.h:
* rendering/mathml/RenderMathMLRow.cpp:
(WebCore::RenderMathMLRow::layout):

LayoutTests:

* mathml/presentation/stretchy-depth-height-expected.txt: Removed.
* mathml/presentation/stretchy-depth-height.html: Removed.
* platform/mac/mathml/presentation/mo-stretch-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBug 119043 - Large stretch size error for MathML operators.
fred.wang@free.fr [Sat, 22 Feb 2014 09:50:47 +0000 (09:50 +0000)]
Bug 119043 - Large stretch size error for MathML operators.
https://bugs.webkit.org/show_bug.cgi?id=119043

Reviewed by Chris Fleizach.

Source/WebCore:

The MathML code used some arbitrary gOperatorExpansion factor for the
stretch size and 2/3 1/2 constants for the baseline. This change tries
to consider height/depth of siblings of the stretchy operator so that
the stretchy operator now matches its target.

Test: mathml/presentation/stretchy-depth-height.html

* rendering/RenderObject.h:
(WebCore::RenderObject::isRenderMathMLTable):
* rendering/mathml/RenderMathMLBlock.h:
* rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::RenderMathMLOperator):
(WebCore::RenderMathMLOperator::stretchTo):
(WebCore::RenderMathMLOperator::findAcceptableStretchyCharacter):
(WebCore::RenderMathMLOperator::updateStyle):
(WebCore::RenderMathMLOperator::firstLineBaseline):
(WebCore::RenderMathMLOperator::computeLogicalHeight):
* rendering/mathml/RenderMathMLOperator.h:
* rendering/mathml/RenderMathMLRow.cpp:
(WebCore::RenderMathMLRow::layout):

LayoutTests:

This adds a test to check that the depth/height of stretchy operators match the maximum of their siblings. This also fixes the reference of mo-stretch.html to ignore the stretch error.

* mathml/presentation/stretchy-depth-height-expected.txt: Added.
* mathml/presentation/stretchy-depth-height.html: Added.
* platform/mac/mathml/presentation/mo-stretch-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, EFL WK2 gardening. Skip a webgl test because of crashing.
gyuyoung.kim@samsung.com [Sat, 22 Feb 2014 09:23:33 +0000 (09:23 +0000)]
Unreviewed, EFL WK2 gardening. Skip a webgl test because of crashing.
Besides a bug is filed and assigned to those crash tests.

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r164412): Pixel cracks when zooming in to any web content.
zalan@apple.com [Sat, 22 Feb 2014 07:24:45 +0000 (07:24 +0000)]
REGRESSION(r164412): Pixel cracks when zooming in to any web content.
https://bugs.webkit.org/show_bug.cgi?id=129195

Reviewed by Simon Fraser.

Integral clipping of the repaint rect was prematurely removed in RenderLayerBacking::paintContents().
Repaint rects needs a uniform, device pixel precise clipping across the painting flow including RenderLayer,
RenderView and TileController.

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintContents):
(WebCore::RenderLayerBacking::compositedBoundsIncludingMargin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoReplace svg/clip-path pixel tests by reference tests
krit@webkit.org [Sat, 22 Feb 2014 07:20:16 +0000 (07:20 +0000)]
Replace svg/clip-path pixel tests by reference tests
https://bugs.webkit.org/show_bug.cgi?id=129177

Reviewed by Dean Jackson.

New reference tests for SVG clip-path.

* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/win/TestExpectations:
* svg/clip-path/clip-path-clip-expected.svg: Added.
* svg/clip-path/clip-path-clip-nested-twice-expected.svg: Added.
* svg/clip-path/clip-path-clip-nested-twice.svg: Added.
* svg/clip-path/clip-path-clip-rule-001-expected.svg: Added.
* svg/clip-path/clip-path-clip-rule-001.svg: Added.
* svg/clip-path/clip-path-clip-rule-002-expected.svg: Added.
* svg/clip-path/clip-path-clip-rule-002.svg: Added.
* svg/clip-path/clip-path-clip-rule-003-expected.svg: Added.
* svg/clip-path/clip-path-clip-rule-003.svg: Added.
* svg/clip-path/clip-path-clip-rule-004-expected.svg: Added.
* svg/clip-path/clip-path-clip-rule-004.svg: Added.
* svg/clip-path/clip-path-clip-rule-005-expected.svg: Added.
* svg/clip-path/clip-path-clip-rule-005.svg: Added.
* svg/clip-path/clip-path-clip-rule-006-expected.svg: Added.
* svg/clip-path/clip-path-clip-rule-006.svg: Added.
* svg/clip-path/clip-path-clip-rule-007-expected.svg: Added.
* svg/clip-path/clip-path-clip-rule-007.svg: Added.
* svg/clip-path/clip-path-clip-rule-008-expected.svg: Added.
* svg/clip-path/clip-path-clip-rule-008.svg: Added.
* svg/clip-path/clip-path-clip-rule-009-expected.svg: Added.
* svg/clip-path/clip-path-clip-rule-009.svg: Added.
* svg/clip-path/clip-path-clip-rule-010-expected.svg: Added.
* svg/clip-path/clip-path-clip-rule-010.svg: Added.
* svg/clip-path/clip-path-clip.svg: Added.
* svg/clip-path/clip-path-content-clip-001-expected.svg: Added.
* svg/clip-path/clip-path-content-clip-001.svg: Added.
* svg/clip-path/clip-path-content-clip-002-expected.svg: Added.
* svg/clip-path/clip-path-content-clip-002.svg: Added.
* svg/clip-path/clip-path-content-clip-003-expected.svg: Added.
* svg/clip-path/clip-path-content-clip-003.svg: Added.
* svg/clip-path/clip-path-content-invisible-expected.svg: Added.
* svg/clip-path/clip-path-content-invisible.svg: Added.
* svg/clip-path/clip-path-content-syling-expected.svg: Added.
* svg/clip-path/clip-path-content-syling.svg: Added.
* svg/clip-path/clip-path-content-use-001-expected.svg: Added.
* svg/clip-path/clip-path-content-use-001.svg: Added.
* svg/clip-path/clip-path-content-use-002-expected.svg: Added.
* svg/clip-path/clip-path-content-use-002.svg: Added.
* svg/clip-path/clip-path-content-use-003-expected.svg: Added.
* svg/clip-path/clip-path-content-use-003.svg: Added.
* svg/clip-path/clip-path-content-use-004-expected.svg: Added.
* svg/clip-path/clip-path-content-use-004.svg: Added.
* svg/clip-path/clip-path-content-use-005-expected.svg: Added.
* svg/clip-path/clip-path-content-use-005.svg: Added.
* svg/clip-path/clip-path-content-use-006-expected.svg: Added.
* svg/clip-path/clip-path-content-use-006.svg: Added.
* svg/clip-path/clip-path-css-transform-001-expected.svg: Added.
* svg/clip-path/clip-path-css-transform-001.svg: Added.
* svg/clip-path/clip-path-css-transform-002-expected.svg: Added.
* svg/clip-path/clip-path-css-transform-002.svg: Added.
* svg/clip-path/clip-path-invalid-expected.svg: Added.
* svg/clip-path/clip-path-invalid.svg: Added.
* svg/clip-path/clip-path-no-content-001-expected.svg: Added.
* svg/clip-path/clip-path-no-content-001.svg: Added.
* svg/clip-path/clip-path-no-content-002-expected.svg: Added.
* svg/clip-path/clip-path-no-content-002.svg: Added.
* svg/clip-path/clip-path-no-content-003-expected.svg: Added.
* svg/clip-path/clip-path-no-content-003.svg: Added.
* svg/clip-path/clip-path-objectboundingbox-001-expected.svg: Added.
* svg/clip-path/clip-path-objectboundingbox-001.svg: Added.
* svg/clip-path/clip-path-objectboundingbox-002-expected.svg: Added.
* svg/clip-path/clip-path-objectboundingbox-002.svg: Added.
* svg/clip-path/clip-path-objectboundingbox-003-expected.svg: Added.
* svg/clip-path/clip-path-objectboundingbox-003.svg: Added.
* svg/clip-path/clip-path-objectboundingbox-004-expected.svg: Added.
* svg/clip-path/clip-path-objectboundingbox-004.svg: Added.
* svg/clip-path/clip-path-on-g-001-expected.svg: Added.
* svg/clip-path/clip-path-on-g-001.svg: Added.
* svg/clip-path/clip-path-on-g-002-expected.svg: Added.
* svg/clip-path/clip-path-on-g-002.svg: Added.
* svg/clip-path/clip-path-on-g-003-expected.svg: Added.
* svg/clip-path/clip-path-on-g-003.svg: Added.
* svg/clip-path/clip-path-on-g-004-expected.svg: Added.
* svg/clip-path/clip-path-on-g-004.svg: Added.
* svg/clip-path/clip-path-on-g-005-expected.svg: Added.
* svg/clip-path/clip-path-on-g-005.svg: Added.
* svg/clip-path/clip-path-on-svg-001-expected.svg: Added.
* svg/clip-path/clip-path-on-svg-001.svg: Added.
* svg/clip-path/clip-path-on-svg-002-expected.svg: Added.
* svg/clip-path/clip-path-on-svg-002.svg: Added.
* svg/clip-path/clip-path-on-use-001-expected.svg: Added.
* svg/clip-path/clip-path-on-use-001.svg: Added.
* svg/clip-path/clip-path-on-use-002-expected.svg: Added.
* svg/clip-path/clip-path-on-use-002.svg: Added.
* svg/clip-path/clip-path-precision-001-expected.svg: Added.
* svg/clip-path/clip-path-precision-001.svg: Added.
* svg/clip-path/clip-path-text-001-expected.svg: Added.
* svg/clip-path/clip-path-text-001.svg: Added.
* svg/clip-path/clip-path-text-002-expected.svg: Added.
* svg/clip-path/clip-path-text-002.svg: Added.
* svg/clip-path/clip-path-text-003-expected.svg: Added.
* svg/clip-path/clip-path-text-003.svg: Added.
* svg/clip-path/clip-path-text-004-expected.svg: Added.
* svg/clip-path/clip-path-text-004.svg: Added.
* svg/clip-path/clip-path-text-005-expected.svg: Added.
* svg/clip-path/clip-path-text-005.svg: Added.
* svg/clip-path/clip-path-userspaceonuse-001-expected.svg: Added.
* svg/clip-path/clip-path-userspaceonuse-001.svg: Added.
* svg/clip-path/mask-nested-clip-path-001-expected.svg: Added.
* svg/clip-path/mask-nested-clip-path-001.svg: Added.
* svg/clip-path/mask-nested-clip-path-002-expected.svg: Added.
* svg/clip-path/mask-nested-clip-path-002.svg: Added.
* svg/clip-path/mask-nested-clip-path-003-expected.svg: Added.
* svg/clip-path/mask-nested-clip-path-003.svg: Added.
* svg/clip-path/mask-nested-clip-path-004-expected.svg: Added.
* svg/clip-path/mask-nested-clip-path-004.svg: Added.
* svg/clip-path/mask-nested-clip-path-005-expected.svg: Added.
* svg/clip-path/mask-nested-clip-path-005.svg: Added.
* svg/clip-path/mask-nested-clip-path-006-expected.svg: Added.
* svg/clip-path/mask-nested-clip-path-006.svg: Added.
* svg/clip-path/mask-nested-clip-path-007-expected.svg: Added.
* svg/clip-path/mask-nested-clip-path-007.svg: Added.
* svg/clip-path/mask-nested-clip-path-008-expected.svg: Added.
* svg/clip-path/mask-nested-clip-path-008.svg: Added.
* svg/clip-path/mask-nested-clip-path-009-expected.svg: Added.
* svg/clip-path/mask-nested-clip-path-009.svg: Added.
* svg/clip-path/mask-nested-clip-path-panning-001-expected.svg: Added.
* svg/clip-path/mask-nested-clip-path-panning-001.svg: Added.
* svg/clip-path/mask-nested-clip-path-panning-002-expected.svg: Added.
* svg/clip-path/mask-nested-clip-path-panning-002.svg: Added.
* svg/clip-path/mask-objectboundingbox-content-clip-expected.svg: Added.
* svg/clip-path/mask-objectboundingbox-content-clip-transform-expected.svg: Added.
* svg/clip-path/mask-objectboundingbox-content-clip-transform.svg: Added.
* svg/clip-path/mask-objectboundingbox-content-clip.svg: Added.
* svg/clip-path/mask-userspaceonuse-content-clip-expected.svg: Added.
* svg/clip-path/mask-userspaceonuse-content-clip-transform-expected.svg: Added.
* svg/clip-path/mask-userspaceonuse-content-clip-transform.svg: Added.
* svg/clip-path/mask-userspaceonuse-content-clip.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed Mac build fix after r164529.
jer.noble@apple.com [Sat, 22 Feb 2014 06:56:55 +0000 (06:56 +0000)]
Unreviewed Mac build fix after r164529.

Replace the string-to-array algorithm with a archictecture-independant
one.

* platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:
(WebCore::CDMSessionMediaSourceAVFObjC::generateKeyRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EME] Add a CDMSession for MediaPlayerPrivateMediaSourceAVFObjC
jer.noble@apple.com [Sat, 22 Feb 2014 06:17:53 +0000 (06:17 +0000)]
[EME] Add a CDMSession for MediaPlayerPrivateMediaSourceAVFObjC
https://bugs.webkit.org/show_bug.cgi?id=129166

Reviewed by Eric Carlson.

Add a new CDMSession, cerated by MediaPlayerPrivateMediaSourceAVFObjC allowing
media-source-backed media elements to play protected content.

Add a new CDMSessionMediaSourceAVFObjC class:
* platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.h: Added.
(WebCore::CDMSessionMediaSourceAVFObjC::~CDMSessionMediaSourceAVFObjC):
* platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm: Added.
(WebCore::CDMSessionMediaSourceAVFObjC::CDMSessionMediaSourceAVFObjC):
(WebCore::CDMSessionMediaSourceAVFObjC::generateKeyRequest): Do not actually generate a
    key request until the certificate data has been added via update();
(WebCore::CDMSessionMediaSourceAVFObjC::releaseKeys): No-op.
(WebCore::CDMSessionMediaSourceAVFObjC::update): If no certificate data has yet been
    added, assume the incoming message contains it.

* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::registerMediaEngine): Add supportsKeySystem.
(WebCore::keySystemIsSupported): Use "com.apple.fps.2_0" to distinguish from the not-media-source scheme.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::supportsType): Check the keySystem type.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::supportsKeySystem): Added.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::createSession): Added, pass through to MediaSourcePrivate.
* platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.h:
* platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm:
(WebCore::MediaSourcePrivateAVFObjC::createSession): Added.
(WebCore::MediaSourcePrivateAVFObjC::sourceBufferKeyNeeded): Pass through to MediaPlayer.
* platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
* platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(-[WebAVStreamDataParserListener streamDataParser:didProvideContentKeyRequestInitializationData:forTrackID:]):
    Added, pass through to SourceBufferPrivate.
(WebCore::SourceBufferPrivateAVFObjC::SourceBufferPrivateAVFObjC):
(WebCore::SourceBufferPrivateAVFObjC::didProvideContentKeyRequestInitializationDataForTrackID): Remember
    which track is requesting the key, and pass the request to MediaSourcePrivate.

Add new files to the project.
* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify contains seemingly accidental unreac...
ap@apple.com [Sat, 22 Feb 2014 06:07:41 +0000 (06:07 +0000)]
CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify contains seemingly accidental unreachable code
https://bugs.webkit.org/show_bug.cgi?id=129193

Reviewed by Joseph Pecoraro.

* crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify): Fix the accidental code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoExtend media support for WebVTT sources
bfulgham@apple.com [Sat, 22 Feb 2014 05:05:53 +0000 (05:05 +0000)]
Extend media support for WebVTT sources
https://bugs.webkit.org/show_bug.cgi?id=129156

Reviewed by Eric Carlson.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig: Add new feature define for AVF_CAPTIONS

Source/WebCore:

* Configurations/FeatureDefines.xcconfig: Add new feature define for AVF_CAPTIONS
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::outOfBandTrackSources): Added.
* html/HTMLMediaElement.h:
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::outOfBandTrackSources): Added.
* platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::outOfBandTrackSources): Added.
* platform/graphics/PlatformTextTrack.h:
(WebCore::PlatformTextTrack::create): Update for new constructor signature.
(WebCore::PlatformTextTrack::createOutOfBand): Added.
(WebCore::PlatformTextTrack::url): Added.
(WebCore::PlatformTextTrack::isDefault): Added.
(WebCore::PlatformTextTrack::PlatformTextTrack): Revised to take new URL and
'isDefault' arguments.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::mediaDescriptionForKind): Added.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Tell AVFoundation about any
WebVTT tracks supplied by the web page.
(WebCore::MediaPlayerPrivateAVFoundationObjC::processMediaSelectionOptions): Filter out any out-of-band
WebVTT tracks returned by the media engine to avoid double-counting tracks.

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig: Add new feature define for AVF_CAPTIONS

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig: Add new feature define for AVF_CAPTIONS

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoInner text element should not use -webkit-user-modify
rniwa@webkit.org [Sat, 22 Feb 2014 04:09:28 +0000 (04:09 +0000)]
Inner text element should not use -webkit-user-modify
https://bugs.webkit.org/show_bug.cgi?id=129035

Reviewed by Andreas Kling.

Source/WebCore:

To eliminate the internal use of -webkit-user-modify, use contenteditable attribute in the inner text elements
instead of manually inspecting disabled-ness and readonly-ness in RenderTextControl.

Unfortunately, we still have to manually set UserModify value in RenderTextControl::adjustInnerTextStyle since
RenderTextControl::styleDidChange creates RenderStyle for its inner text from scratch via createInnerTextStyle.

* html/HTMLFieldSetElement.cpp:
(WebCore::HTMLFieldSetElement::disabledStateChanged): Don't use childrenOfType iterator which asserts that DOM
isn't mutated during the traversal since we now set contenteditable attribute inside disabledStateChanged via
updateFromControlElementsAncestorDisabledStateUnder.

* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::parseAttribute): Extracted readOnlyAttributeChanged out of this function so
that HTMLTextFormControl could override it to call updateInnerTextElementEditability.
(WebCore::HTMLFormControlElement::readOnlyAttributeChanged): Ditto.
* html/HTMLFormControlElement.h:

* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::didAddUserAgentShadowRoot): Call updateInnerTextElementEditability after creating
shadow DOM for the current input type.
(WebCore::HTMLInputElement::updateType): Ditto.
(WebCore::HTMLInputElement::parseAttribute): Ditto.

* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::didAddUserAgentShadowRoot): Call updateInnerTextElementEditability.

* html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::disabledStateChanged): Added to update contenteditable attribute since
the editability of the inner text element depends on disabled-ness of the element.
(WebCore::HTMLTextFormControlElement::readOnlyAttributeChanged): Ditto for the readonly-ness of the element.
(WebCore::HTMLTextFormControlElement::updateInnerTextElementEditability): Added.
* html/HTMLTextFormControlElement.h:

* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::adjustInnerTextStyle): Use the inner text element's presentationAttributeStyle() to
compute the appropriate EUserModify value instead of hard-coding it here.
* rendering/RenderTextControl.h:

LayoutTests:

Rebaselined tests as the user agent shadow DOM of input and textarea elements now have contenteditable attribute.

* editing/input/paste-text-ending-with-interchange-newline-expected.txt:
* editing/inserting/5607069-2-expected.txt:
* editing/inserting/5607069-3-expected.txt:
* editing/pasteboard/copy-image-with-alt-text-expected.txt:
* editing/pasteboard/copy-null-characters-expected.txt:
* editing/pasteboard/nested-blocks-with-text-area-expected.txt:
* editing/pasteboard/nested-blocks-with-text-field-expected.txt:
* editing/selection/dump-as-markup-expected.txt:
* editing/selection/dump-as-markup-form-text-expected.txt:
* fast/forms/suggested-value-after-setvalue-expected.txt:
* fast/forms/suggested-value-expected.txt:
* fast/parser/object-with-textarea-fallback-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Support WEBGL_draw_buffers extension.
changseok.oh@collabora.com [Sat, 22 Feb 2014 03:56:33 +0000 (03:56 +0000)]
[GTK] Support WEBGL_draw_buffers extension.
https://bugs.webkit.org/show_bug.cgi?id=129143

Reviewed by Dean Jackson.

Support the WEBGL_draw_buffers WebGL extension for gtk port. Relevant opengl APIs
are exposed for WebGLRenderingContext to access them properly.

Covered by fast/canvas/webgl/webgl-draw-buffers.html

* platform/graphics/OpenGLShims.cpp:
(WebCore::initializeOpenGLShims):
* platform/graphics/OpenGLShims.h:
* platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::supportsExtension):
(WebCore::Extensions3DOpenGL::drawBuffersEXT):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMac port uses ANGLE_instanced_arrays related apis through those in GraphicsContext3DC...
changseok.oh@collabora.com [Sat, 22 Feb 2014 03:53:53 +0000 (03:53 +0000)]
Mac port uses ANGLE_instanced_arrays related apis through those in GraphicsContext3DCommon.cpp
https://bugs.webkit.org/show_bug.cgi?id=128803

Reviewed by Dean Jackson.

Merge mac port implementation of ANGLE_instanced_arrays into common code.

No new tests, no functionality changed.

* platform/graphics/mac/GraphicsContext3DMac.mm:
* platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::drawArraysInstanced):
(WebCore::Extensions3DOpenGL::drawElementsInstanced):
(WebCore::Extensions3DOpenGL::vertexAttribDivisor):
* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::vertexAttribDivisor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[iOS WebKit2] Keyboard appears every time a link is tapped after searching Google
enrica@apple.com [Sat, 22 Feb 2014 03:39:46 +0000 (03:39 +0000)]
[iOS WebKit2] Keyboard appears every time a link is tapped after searching Google
<rdar://problem/16072563>.

Reviewed by Benjamin Poulain.

We need to stop assisting the node if we have
navigated to a different page.

* UIProcess/API/ios/WKContentView.mm:
(-[WKContentView _didCommitLoadForMainFrame]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMade WKWebView implement all WKContentViewDelegate methods.
mitz@apple.com [Sat, 22 Feb 2014 03:15:47 +0000 (03:15 +0000)]
Made WKWebView implement all WKContentViewDelegate methods.

Reviewed by Anders Carlsson.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView takeViewSnapshotForContentView:]): Moved from WKViewIOS.mm.
* UIProcess/API/ios/WKContentView.h: Made all protocol methods required.
* UIProcess/API/ios/WKViewIOS.mm:
(-[WKView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]): Removed code
to set self as the delegate on the content view.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAfter copy and paste, cursor may appear to be above the bottom of content
mmaxfield@apple.com [Sat, 22 Feb 2014 03:14:13 +0000 (03:14 +0000)]
After copy and paste, cursor may appear to be above the bottom of content
https://bugs.webkit.org/show_bug.cgi?id=129167

Reviewed by Ryosuke Niwa.

Source/WebCore:

Adding a clear:both to the end of content.

I can't handle the case of the cursor appearing above the bottom of
absolutely positioned divs (of the case of floats inside absolutely
positioned divs) because you can't know where the bottom of a div
will end up being rendered (it is affected by things like browser
window width and text size settings). Therefore, the only case I
can handle is the case where there is a floating div in the same
level as the document itself.

Test: editing/pasteboard/copy-paste-inserts-clearing-div.html

* editing/EditingStyle.cpp:
(WebCore::EditingStyle::isFloating):
* editing/EditingStyle.h:
* editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::StyledMarkupAccumulator):
(WebCore::StyledMarkupAccumulator::appendElement):
(WebCore::createMarkupInternal):

LayoutTests:

Makes sure that the clearing div is inserted.

* editing/pasteboard/copy-paste-inserts-clearing-div-expected.txt: Added.
* editing/pasteboard/copy-paste-inserts-clearing-div.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed build fix after r164505
bfulgham@apple.com [Sat, 22 Feb 2014 02:58:13 +0000 (02:58 +0000)]
Unreviewed build fix after r164505

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Update exports
definition for TreeScope::getElementById.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[iOS Media] Wireless target UI
dino@apple.com [Sat, 22 Feb 2014 02:45:01 +0000 (02:45 +0000)]
[iOS Media] Wireless target UI
https://bugs.webkit.org/show_bug.cgi?id=129189
<rdar://problem/15349928>
<rdar://problem/16100060>

Reviewed by Eric Carlson.

Implement a prototype UI for wireless playback targets. The UI
doesn't currently work, but can be simulated via a class variable
in ControllerIOS.

* Modules/mediacontrols/mediaControlsiOS.css:
(audio::-webkit-media-controls-panel button): Reset the default style of
button elements, to avoid getting a border.
(audio::-webkit-media-controls-wireless-playback-status): Holds the UI showing
the user that the media is playing on another target.
(audio::-webkit-media-controls-wireless-playback-status.hidden):
(audio::-webkit-media-controls-wireless-playback-picker-button): The button to
trigger selection of targets.
(audio::-webkit-media-controls-wireless-playback-picker-button.active):
(audio::-webkit-media-controls-panel): This needs to be position absolute for
the wireless playback status to fill the viewport.
* Modules/mediacontrols/mediaControlsiOS.js:
(ControllerIOS): Check for targets.
(ControllerIOS.prototype.addVideoListeners):
(ControllerIOS.prototype.removeVideoListeners):
(ControllerIOS.prototype.UIString): New method to return localized strings (with
a FIXME).
(ControllerIOS.prototype.shouldHaveAnyUI): Needs to display if there is a wireless
target.
(ControllerIOS.prototype.currentPlaybackTargetIsWireless):
(ControllerIOS.prototype.updateWirelessPlaybackStatus): Create the status content,
replacing the device name if it is available.
(ControllerIOS.prototype.updateWirelessTargetAvailable):
(ControllerIOS.prototype.createControls):
(ControllerIOS.prototype.configureInlineControls):
(ControllerIOS.prototype.handleWirelessPlaybackChange):
(ControllerIOS.prototype.handleWirelessTargetAvailableChange):
(ControllerIOS.prototype.handleWirelessPickerButtonClicked):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove unported Web Inspector tests to LayoutTests/inspector-obsolete
bburg@apple.com [Sat, 22 Feb 2014 01:58:54 +0000 (01:58 +0000)]
Move unported Web Inspector tests to LayoutTests/inspector-obsolete
https://bugs.webkit.org/show_bug.cgi?id=129183

Rubber-stamped by Timothy Hatcher.

Move inspector/ to inspector-obsolete/.
Move http/tests/inspector/ to inspector-obsolete/http-tests/.
Fold http/tests/inspector-enabled/ into inspector-obsolete/http-tests/.

I have elided about 1100 lines of rename Changelog spew;
no filenames have been altered in this reorganization.

Remove mentions of obsolete tests from TestExpectations. Remove skips
for inspector-obsolete/ from port-specific expectations, and just
put it in the generic expectations file.

Remove inspector-protocol/heap-profiler tests, as they are obsolete.

* TestExpectations:
 * inspector-protocol/heap-profiler/heap-snapshot-with-detached-dom-tree-expected.txt: Removed.
* inspector-protocol/heap-profiler/heap-snapshot-with-detached-dom-tree.html: Removed.
* inspector-protocol/heap-profiler/heap-snapshot-with-event-listener-expected.txt: Removed.
* inspector-protocol/heap-profiler/heap-snapshot-with-event-listener.html: Removed.
* inspector-protocol/heap-profiler/resources/heap-snapshot-common.js: Removed.
* inspector-protocol/heap-profiler/resources/page-with-function.html: Removed.
* inspector-protocol/heap-profiler/take-heap-snapshot-expected.txt: Removed.
* inspector-protocol/heap-profiler/take-heap-snapshot.html: Removed.
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac-wk2/TestExpectations:
* platform/mac/TestExpectations:
* platform/win-xp/TestExpectations:
* platform/win/TestExpectations:
* platform/wincairo/TestExpectations:
* platform/wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago<rdar://problem/16073882> Please add _AbandonCoalition key to plugin XPC service...
weinig@apple.com [Sat, 22 Feb 2014 01:03:51 +0000 (01:03 +0000)]
<rdar://problem/16073882> Please add _AbandonCoalition key to plugin XPC service Info.plist

Anders Carlsson.

* PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist:
* PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/Info.plist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Mac] Cache callbacks for cache partitioning may be passed null
jpfau@apple.com [Sat, 22 Feb 2014 00:31:23 +0000 (00:31 +0000)]
[Mac] Cache callbacks for cache partitioning may be passed null
https://bugs.webkit.org/show_bug.cgi?id=129175

Reviewed by Brady Eidson.

Source/WebKit2:

* WebProcess/ResourceCache/cf/WebResourceCacheManagerCFNet.cpp:
(WebKit::WebResourceCacheManager::cfURLCacheHostNamesWithCallback):

WebKitLibraries:

* libWebKitSystemInterfaceLion.a:
* libWebKitSystemInterfaceMavericks.a:
* libWebKitSystemInterfaceMountainLion.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: remove old inspector tests that cannot be ported
bburg@apple.com [Sat, 22 Feb 2014 00:28:49 +0000 (00:28 +0000)]
Web Inspector: remove old inspector tests that cannot be ported
https://bugs.webkit.org/show_bug.cgi?id=129168

Reviewed by Timothy Hatcher.

Remove many tests that were specific to the old inspector user interface.
These cannot be ported either because they were specific to the UI, or
they test features that no longer exist in the Web Inspector.

* inspector/audits/audits-panel-functional-expected.txt: Removed.
* inspector/audits/audits-panel-functional.html: Removed.
* inspector/audits/audits-panel-noimages-functional-expected.txt: Removed.
* inspector/audits/audits-panel-noimages-functional.html: Removed.
* inspector/audits/audits-test.js: Removed.
* inspector/audits/resources/audits-script1.js: Removed.
* inspector/audits/resources/audits-script2.js: Removed.
* inspector/audits/resources/audits-style1.css: Removed.
* inspector/console/command-line-api-getEventListeners-expected.txt: Removed.
* inspector/console/command-line-api-getEventListeners.html: Removed.
* inspector/console/console-big-array-expected.txt: Removed.
* inspector/console/console-big-array.html: Removed.
* inspector/console/console-clear-expected.txt: Removed.
* inspector/console/console-clear.html: Removed.
* inspector/console/console-dirxml-expected.txt: Removed.
* inspector/console/console-dirxml.html: Removed.
* inspector/console/console-filter-test-expected.txt: Removed.
* inspector/console/console-filter-test.html: Removed.
* inspector/console/console-format-collections-expected.txt: Removed.
* inspector/console/console-format-collections.html: Removed.
* inspector/console/console-format-expected.txt: Removed.
* inspector/console/console-format-style-expected.txt: Removed.
* inspector/console/console-format-style-whitelist-expected.txt: Removed.
* inspector/console/console-format-style-whitelist.html: Removed.
* inspector/console/console-format-style.html: Removed.
* inspector/console/console-format-table-expected.txt: Removed.
* inspector/console/console-format-table.html: Removed.
* inspector/console/console-format.html: Removed.
* inspector/console/console-trim-long-urls-expected.txt: Removed.
* inspector/console/console-trim-long-urls.html: Removed.
* inspector/cookie-parser-expected.txt: Removed.
* inspector/cookie-parser.html: Removed.
* inspector/cookie-resource-match-expected.txt: Removed.
* inspector/cookie-resource-match.html: Removed.
* inspector/curl-command-expected.txt: Removed.
* inspector/curl-command.html: Removed.
* inspector/database-table-name-excaping-expected.txt: Removed.
* inspector/database-table-name-excaping.html: Removed.
* inspector/datagrid-autosize-expected.txt: Removed.
* inspector/datagrid-autosize.html: Removed.
* inspector/debugger/breakpoint-manager-listeners-count-expected.txt: Removed.
* inspector/debugger/breakpoint-manager-listeners-count.html: Removed.
* inspector/debugger/callstack-placards-discarded-expected.txt: Removed.
* inspector/debugger/callstack-placards-discarded.html: Removed.
* inspector/debugger/content-providers-expected.txt: Removed.
* inspector/debugger/content-providers.html: Removed.
* inspector/debugger/debug-inlined-scripts-expected.txt: Removed.
* inspector/debugger/debug-inlined-scripts.html-disabled: Removed.
* inspector/debugger/debugger-expand-scope-expected.txt: Removed.
* inspector/debugger/debugger-expand-scope.html: Removed.
* inspector/debugger/debugger-proto-property-expected.txt: Removed.
* inspector/debugger/debugger-proto-property.html: Removed.
* inspector/debugger/debugger-script-preprocessor-expected.txt: Removed.
* inspector/debugger/debugger-script-preprocessor.html: Removed.
* inspector/debugger/debugger-step-into-event-listener-expected.txt: Removed.
* inspector/debugger/debugger-step-into-event-listener.html: Removed.
* inspector/debugger/disable-script-expected.txt: Removed.
* inspector/debugger/disable-script.html: Removed.
* inspector/debugger/dom-breakpoints-expected.txt: Removed.
* inspector/debugger/dom-breakpoints.html: Removed.
* inspector/debugger/dynamic-script-tag-expected.txt: Removed.
* inspector/debugger/dynamic-script-tag.html: Removed.
* inspector/debugger/dynamic-scripts-expected.txt: Removed.
* inspector/debugger/dynamic-scripts.html: Removed.
* inspector/debugger/error-in-watch-expressions-expected.txt: Removed.
* inspector/debugger/error-in-watch-expressions.html: Removed.
* inspector/debugger/event-listener-breakpoints-expected.txt: Removed.
* inspector/debugger/event-listener-breakpoints.html: Removed.
* inspector/debugger/file-system-project-mapping-expected.txt: Removed.
* inspector/debugger/file-system-project-mapping.html: Removed.
* inspector/debugger/linkifier-expected.txt: Removed.
* inspector/debugger/linkifier.html: Removed.
* inspector/debugger/live-edit-breakpoints-expected.txt: Removed.
* inspector/debugger/live-edit-breakpoints.html: Removed.
* inspector/debugger/live-edit-expected.txt: Removed.
* inspector/debugger/live-edit.html: Removed.
* inspector/debugger/mutation-observer-suspend-while-paused-expected.txt: Removed.
* inspector/debugger/mutation-observer-suspend-while-paused.html: Removed.
* inspector/debugger/navigator-view-expected.txt: Removed.
* inspector/debugger/navigator-view.html: Removed.
* inspector/debugger/network-uisourcecode-provider-expected.txt: Removed.
* inspector/debugger/network-uisourcecode-provider.html: Removed.
* inspector/debugger/properties-special-expected.txt: Removed.
* inspector/debugger/properties-special.html: Removed.
* inspector/debugger/resource-script-mapping-expected.txt: Removed.
* inspector/debugger/resource-script-mapping.html: Removed.
* inspector/debugger/reveal-execution-line-expected.txt: Removed.
* inspector/debugger/reveal-execution-line.html: Removed.
* inspector/debugger/script-extract-outline-expected.txt: Removed.
* inspector/debugger/script-extract-outline.html: Removed.
* inspector/debugger/script-formatter-breakpoints-expected.txt: Removed.
* inspector/debugger/script-formatter-breakpoints.html: Removed.
* inspector/debugger/script-formatter-console-expected.txt: Removed.
* inspector/debugger/script-formatter-console.html: Removed.
* inspector/debugger/script-snippet-model-expected.txt: Removed.
* inspector/debugger/script-snippet-model.html: Removed.
* inspector/debugger/scripts-panel-expected.txt: Removed.
* inspector/debugger/scripts-panel.html: Removed.
* inspector/debugger/scripts-sorting-expected.txt: Removed.
* inspector/debugger/scripts-sorting.html: Removed.
* inspector/debugger/selected-call-frame-after-formatting-source-expected.txt: Removed.
* inspector/debugger/selected-call-frame-after-formatting-source.html: Removed.
* inspector/debugger/set-breakpoint-expected.txt: Removed.
* inspector/debugger/set-breakpoint.html: Removed.
* inspector/debugger/source-frame-count-expected.txt: Removed.
* inspector/debugger/source-frame-count.html: Removed.
* inspector/debugger/source-frame-expected.txt: Removed.
* inspector/debugger/source-frame.html: Removed.
* inspector/debugger/step-through-event-listeners-expected.txt: Removed.
* inspector/debugger/step-through-event-listeners.html: Removed.
* inspector/debugger/ui-source-code-display-name-expected.txt: Removed.
* inspector/debugger/ui-source-code-display-name.html: Removed.
* inspector/debugger/ui-source-code-expected.txt: Removed.
* inspector/debugger/ui-source-code.html: Removed.
* inspector/debugger/watch-expressions-panel-switch-expected.txt: Removed.
* inspector/debugger/watch-expressions-panel-switch.html: Removed.
* inspector/debugger/watch-expressions-preserve-expansion-expected.txt: Removed.
* inspector/debugger/watch-expressions-preserve-expansion.html: Removed.
* inspector/debugger/xhr-breakpoints-expected.txt: Removed.
* inspector/debugger/xhr-breakpoints.html: Removed.
* inspector/dom-statistics-expected.txt: Removed.
* inspector/dom-statistics.html-disabled: Removed.
* inspector/editor/brace-matcher-expected.txt: Removed.
* inspector/editor/brace-matcher.html: Removed.
* inspector/editor/editor-test.js: Removed.
* inspector/editor/highlighter-basics-expected.txt: Removed.
* inspector/editor/highlighter-basics.html: Removed.
* inspector/editor/highlighter-chunk-limit-expected.txt: Removed.
* inspector/editor/highlighter-chunk-limit.html: Removed.
* inspector/editor/highlighter-long-line-expected.txt: Removed.
* inspector/editor/highlighter-long-line.html: Removed.
* inspector/editor/highlighter-paste-in-comment-expected.txt: Removed.
* inspector/editor/highlighter-paste-in-comment.html: Removed.
* inspector/editor/highlighter-test.js: Removed.
* inspector/editor/indentation-expected.txt: Removed.
* inspector/editor/indentation.html: Removed.
* inspector/editor/text-editor-brace-highlighter-expected.txt: Removed.
* inspector/editor/text-editor-brace-highlighter.html: Removed.
* inspector/editor/text-editor-char-to-coordinates-expected.txt: Removed.
* inspector/editor/text-editor-char-to-coordinates.html: Removed.
* inspector/editor/text-editor-formatter-expected.txt: Removed.
* inspector/editor/text-editor-formatter.html: Removed.
* inspector/editor/text-editor-highlight-api-expected.txt: Removed.
* inspector/editor/text-editor-highlight-api.html: Removed.
* inspector/editor/text-editor-highlight-token-expected.txt: Removed.
* inspector/editor/text-editor-highlight-token.html: Removed.
* inspector/editor/text-editor-home-button-expected.txt: Removed.
* inspector/editor/text-editor-home-button.html: Removed.
* inspector/editor/text-editor-line-breaks-expected.txt: Removed.
* inspector/editor/text-editor-line-breaks.html: Removed.
* inspector/editor/text-editor-long-line-expected.txt: Removed.
* inspector/editor/text-editor-long-line.html: Removed.
* inspector/editor/text-editor-model-expected.txt: Removed.
* inspector/editor/text-editor-model.html: Removed.
* inspector/editor/text-editor-remove-chunks-from-dom-expected.txt: Removed.
* inspector/editor/text-editor-remove-chunks-from-dom.html: Removed.
* inspector/editor/text-editor-selection-expected.txt: Removed.
* inspector/editor/text-editor-selection-to-search-expected.txt: Removed.
* inspector/editor/text-editor-selection-to-search.html: Removed.
* inspector/editor/text-editor-selection.html: Removed.
* inspector/editor/text-editor-show-whitespace-expected.txt: Removed.
* inspector/editor/text-editor-show-whitespace.html: Removed.
* inspector/editor/text-editor-smart-braces-expected.txt: Removed.
* inspector/editor/text-editor-smart-braces.html: Removed.
* inspector/editor/text-editor-token-at-position-expected.txt: Removed.
* inspector/editor/text-editor-token-at-position.html: Removed.
* inspector/editor/text-editor-type-over-decoration-expected.txt: Removed.
* inspector/editor/text-editor-type-over-decoration.html: Removed.
* inspector/editor/text-editor-undo-redo-expected.txt: Removed.
* inspector/editor/text-editor-undo-redo.html: Removed.
* inspector/editor/text-editor-word-jumps-expected.txt: Removed.
* inspector/editor/text-editor-word-jumps.html: Removed.
* inspector/elements/breadcrumb-updates-expected.txt: Removed.
* inspector/elements/breadcrumb-updates.html: Removed.
* inspector/elements/delete-from-document-expected.txt: Removed.
* inspector/elements/delete-from-document.html: Removed.
* inspector/elements/edit-dom-actions-expected.txt: Removed.
* inspector/elements/edit-dom-actions.html: Removed.
* inspector/elements/elements-delete-inline-style-expected.txt: Removed.
* inspector/elements/elements-delete-inline-style.html: Removed.
* inspector/elements/elements-img-tooltip-expected.txt: Removed.
* inspector/elements/elements-img-tooltip.html: Removed.
* inspector/elements/elements-inspect-iframe-from-different-domain-expected.txt: Removed.
* inspector/elements/elements-inspect-iframe-from-different-domain.html: Removed.
* inspector/elements/elements-panel-limited-children-expected.txt: Removed.
* inspector/elements/elements-panel-limited-children.html: Removed.
* inspector/elements/elements-panel-rewrite-href-expected.txt: Removed.
* inspector/elements/elements-panel-rewrite-href.html: Removed.
* inspector/elements/elements-panel-selection-on-refresh-expected.txt: Removed.
* inspector/elements/elements-panel-selection-on-refresh.html: Removed.
* inspector/elements/elements-panel-structure-expected.txt: Removed.
* inspector/elements/elements-panel-structure.html: Removed.
* inspector/elements/elements-panel-xhtml-structure-expected.txt: Removed.
* inspector/elements/elements-panel-xhtml-structure.xhtml-disabled: Removed.
* inspector/elements/event-listener-sidebar-expected.txt: Removed.
* inspector/elements/event-listener-sidebar.html: Removed.
* inspector/elements/event-listeners-about-blank-expected.txt: Removed.
* inspector/elements/event-listeners-about-blank.html: Removed.
* inspector/elements/expand-recursively-expected.txt: Removed.
* inspector/elements/expand-recursively.html: Removed.
* inspector/elements/hide-shortcut-expected.txt: Removed.
* inspector/elements/hide-shortcut.html: Removed.
* inspector/elements/iframe-load-event-expected.txt: Removed.
* inspector/elements/iframe-load-event.html: Removed.
* inspector/elements/insert-node-collapsed-expected.txt: Removed.
* inspector/elements/insert-node-collapsed.html: Removed.
* inspector/elements/insert-node-expected.txt: Removed.
* inspector/elements/insert-node.html: Removed.
* inspector/elements/modify-chardata-expected.txt: Removed.
* inspector/elements/modify-chardata.html: Removed.
* inspector/elements/move-node-expected.txt: Removed.
* inspector/elements/move-node.html: Removed.
* inspector/elements/node-xpath-expected.txt: Removed.
* inspector/elements/node-xpath.xhtml: Removed.
* inspector/elements/remove-node-expected.txt: Removed.
* inspector/elements/remove-node.html: Removed.
* inspector/elements/resources/iframe-load-event-iframe-1.html: Removed.
* inspector/elements/resources/iframe-load-event-iframe-2.html: Removed.
* inspector/elements/resources/iframe-load-event-iframe.js: Removed.
* inspector/elements/resources/user-properties.js: Removed.
* inspector/elements/set-html-via-resource-expected.txt: Removed.
* inspector/elements/shadow-dom-modify-chardata-expected.txt: Removed.
* inspector/elements/shadow-dom-modify-chardata.html: Removed.
* inspector/elements/shadow-root-expected.txt: Removed.
* inspector/elements/shadow-root.html: Removed.
* inspector/elements/undo-dom-edits-2-expected.txt: Removed.
* inspector/elements/undo-dom-edits-2.html: Removed.
* inspector/elements/undo-dom-edits-expected.txt: Removed.
* inspector/elements/undo-dom-edits.html: Removed.
* inspector/elements/update-shadowdom-expected.txt: Removed.
* inspector/elements/update-shadowdom.html: Removed.
* inspector/elements/user-properties-expected.txt: Removed.
* inspector/elements/user-properties.html: Removed.
* inspector/evaluate-in-page-expected.txt: Removed.
* inspector/evaluate-in-page.html: Removed.
* inspector/extensions/extensions-api-expected.txt: Removed.
* inspector/extensions/extensions-api.html: Removed.
* inspector/extensions/extensions-audits-api-expected.txt: Removed.
* inspector/extensions/extensions-audits-api.html: Removed.
* inspector/extensions/extensions-audits-content-script-expected.txt: Removed.
* inspector/extensions/extensions-audits-content-script.html: Removed.
* inspector/extensions/extensions-audits-expected.txt: Removed.
* inspector/extensions/extensions-audits-tests.js: Removed.
* inspector/extensions/extensions-audits.html: Removed.
* inspector/extensions/extensions-console-expected.txt: Removed.
* inspector/extensions/extensions-console.html: Removed.
* inspector/extensions/extensions-eval-content-script-expected.txt: Removed.
* inspector/extensions/extensions-eval-content-script.html: Removed.
* inspector/extensions/extensions-eval-expected.txt: Removed.
* inspector/extensions/extensions-eval.html: Removed.
* inspector/extensions/extensions-events-expected.txt: Removed.
* inspector/extensions/extensions-events.html: Removed.
* inspector/extensions/extensions-network-expected.txt: Removed.
* inspector/extensions/extensions-network.html: Removed.
* inspector/extensions/extensions-panel-expected.txt: Removed.
* inspector/extensions/extensions-panel.html: Removed.
* inspector/extensions/extensions-reload-expected.txt: Removed.
* inspector/extensions/extensions-reload.html: Removed.
* inspector/extensions/extensions-resources-expected.txt: Removed.
* inspector/extensions/extensions-resources.html: Removed.
* inspector/extensions/extensions-sidebar-expected.txt: Removed.
* inspector/extensions/extensions-sidebar.html: Removed.
* inspector/extensions/resources/abe.png: Removed.
* inspector/extensions/resources/audits-style1.css: Removed.
* inspector/extensions/resources/test-script.js: Removed.
* inspector/file-mapping-expected.txt: Removed.
* inspector/file-mapping.html: Removed.
* inspector/file-system-mapping-expected.txt: Removed.
* inspector/file-system-mapping.html: Removed.
* inspector/file-system-project-expected.txt: Removed.
* inspector/file-system-project.html: Removed.
* inspector/filtered-item-selection-dialog-filtering-expected.txt: Removed.
* inspector/filtered-item-selection-dialog-filtering.html: Removed.
* inspector/inspector-backend-commands-generation-expected.txt: Removed.
* inspector/inspector-backend-commands-generation.html: Removed.
* inspector/map-expected.txt: Removed.
* inspector/map.html: Removed.
* inspector/network-status-non-http-expected.txt: Removed.
* inspector/network-status-non-http.html: Removed.
* inspector/profiler/canvas-profiler-test.js: Removed.
* inspector/profiler/canvas2d/canvas-has-uninstrumented-canvases-expected.txt: Removed.
* inspector/profiler/canvas2d/canvas-has-uninstrumented-canvases.html: Removed.
* inspector/profiler/canvas2d/canvas-replay-log-grid-expected.txt: Removed.
* inspector/profiler/canvas2d/canvas-replay-log-grid.html: Removed.
* inspector/profiler/canvas2d/canvas-stack-trace-expected.txt: Removed.
* inspector/profiler/canvas2d/canvas-stack-trace.html: Removed.
* inspector/profiler/canvas2d/canvas2d-api-changes-expected.txt: Removed.
* inspector/profiler/canvas2d/canvas2d-api-changes.html: Removed.
* inspector/profiler/canvas2d/canvas2d-gradient-capturing-expected.txt: Removed.
* inspector/profiler/canvas2d/canvas2d-gradient-capturing.html: Removed.
* inspector/profiler/canvas2d/canvas2d-profiler-capturing-basics-expected.txt: Removed.
* inspector/profiler/canvas2d/canvas2d-profiler-capturing-basics.html: Removed.
* inspector/profiler/heap-snapshot-comparison-dom-groups-change-expected.txt: Removed.
* inspector/profiler/heap-snapshot-comparison-dom-groups-change.html: Removed.
* inspector/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting-expected.txt: Removed.
* inspector/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting.html: Removed.
* inspector/profiler/heap-snapshot-comparison-show-all-expected.txt: Removed.
* inspector/profiler/heap-snapshot-comparison-show-all.html: Removed.
* inspector/profiler/heap-snapshot-comparison-show-next-expected.txt: Removed.
* inspector/profiler/heap-snapshot-comparison-show-next.html: Removed.
* inspector/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting-expected.txt: Removed.
* inspector/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting.html: Removed.
* inspector/profiler/heap-snapshot-comparison-sorting-expected.txt: Removed.
* inspector/profiler/heap-snapshot-comparison-sorting.html: Removed.
* inspector/profiler/heap-snapshot-containment-expansion-preserved-when-sorting-expected.txt: Removed.
* inspector/profiler/heap-snapshot-containment-expansion-preserved-when-sorting.html: Removed.
* inspector/profiler/heap-snapshot-containment-show-all-expected.txt: Removed.
* inspector/profiler/heap-snapshot-containment-show-all.html: Removed.
* inspector/profiler/heap-snapshot-containment-show-next-expected.txt: Removed.
* inspector/profiler/heap-snapshot-containment-show-next.html: Removed.
* inspector/profiler/heap-snapshot-containment-shown-node-count-preserved-when-sorting-expected.txt: Removed.
* inspector/profiler/heap-snapshot-containment-shown-node-count-preserved-when-sorting.html: Removed.
* inspector/profiler/heap-snapshot-containment-sorting-expected.txt: Removed.
* inspector/profiler/heap-snapshot-containment-sorting.html: Removed.
* inspector/profiler/heap-snapshot-dominators-expansion-preserved-when-sorting-expected.txt: Removed.
* inspector/profiler/heap-snapshot-dominators-expansion-preserved-when-sorting.html: Removed.
* inspector/profiler/heap-snapshot-dominators-show-all-expected.txt: Removed.
* inspector/profiler/heap-snapshot-dominators-show-all.html: Removed.
* inspector/profiler/heap-snapshot-dominators-show-next-actual.txt: Removed.
* inspector/profiler/heap-snapshot-dominators-show-next-expected.txt: Removed.
* inspector/profiler/heap-snapshot-dominators-show-next.html: Removed.
* inspector/profiler/heap-snapshot-dominators-shown-node-count-preserved-when-sorting-expected.txt: Removed.
* inspector/profiler/heap-snapshot-dominators-shown-node-count-preserved-when-sorting.html: Removed.
* inspector/profiler/heap-snapshot-dominators-sorting-expected.txt: Removed.
* inspector/profiler/heap-snapshot-dominators-sorting.html: Removed.
* inspector/profiler/heap-snapshot-expected.txt: Removed.
* inspector/profiler/heap-snapshot-get-profile-crash-expected.txt: Removed.
* inspector/profiler/heap-snapshot-get-profile-crash.html: Removed.
* inspector/profiler/heap-snapshot-inspect-dom-wrapper-expected.txt: Removed.
* inspector/profiler/heap-snapshot-inspect-dom-wrapper.html: Removed.
* inspector/profiler/heap-snapshot-loader-expected.txt: Removed.
* inspector/profiler/heap-snapshot-loader.html: Removed.
* inspector/profiler/heap-snapshot-reveal-in-dominators-view-expected.txt: Removed.
* inspector/profiler/heap-snapshot-reveal-in-dominators-view.html: Removed.
* inspector/profiler/heap-snapshot-summary-expansion-preserved-when-sorting-expected.txt: Removed.
* inspector/profiler/heap-snapshot-summary-expansion-preserved-when-sorting.html: Removed.
* inspector/profiler/heap-snapshot-summary-retainers-expected.txt: Removed.
* inspector/profiler/heap-snapshot-summary-retainers.html: Removed.
* inspector/profiler/heap-snapshot-summary-show-all-expected.txt: Removed.
* inspector/profiler/heap-snapshot-summary-show-all.html: Removed.
* inspector/profiler/heap-snapshot-summary-show-next-expected.txt: Removed.
* inspector/profiler/heap-snapshot-summary-show-next.html: Removed.
* inspector/profiler/heap-snapshot-summary-show-ranges-expected.txt: Removed.
* inspector/profiler/heap-snapshot-summary-show-ranges.html: Removed.
* inspector/profiler/heap-snapshot-summary-shown-node-count-preserved-when-sorting-expected.txt: Removed.
* inspector/profiler/heap-snapshot-summary-shown-node-count-preserved-when-sorting.html: Removed.
* inspector/profiler/heap-snapshot-summary-sorting-expected.txt: Removed.
* inspector/profiler/heap-snapshot-summary-sorting-fields-expected.txt: Removed.
* inspector/profiler/heap-snapshot-summary-sorting-fields.html: Removed.
* inspector/profiler/heap-snapshot-summary-sorting-instances-expected.txt: Removed.
* inspector/profiler/heap-snapshot-summary-sorting-instances.html: Removed.
* inspector/profiler/heap-snapshot-summary-sorting.html: Removed.
* inspector/profiler/heap-snapshot-test.js: Removed.
* inspector/profiler/heap-snapshot.html: Removed.
* inspector/profiler/resources/image.jpeg: Removed.
* inspector/profiler/selector-profiler-url-expected.txt: Removed.
* inspector/profiler/selector-profiler-url.html: Removed.
* inspector/profiler/webgl/webgl-profiler-api-changes-expected.txt: Removed.
* inspector/profiler/webgl/webgl-profiler-api-changes.html: Removed.
* inspector/profiler/webgl/webgl-profiler-get-error-expected.txt: Removed.
* inspector/profiler/webgl/webgl-profiler-get-error.html: Removed.
* inspector/progress-bar-expected.txt: Removed.
* inspector/progress-bar.html: Removed.
* inspector/snippet-storage-expected.txt: Removed.
* inspector/snippet-storage.html: Removed.
* inspector/styles/commit-selector-expected.txt: Removed.
* inspector/styles/commit-selector.html: Removed.
* inspector/styles/css-live-edit-expected.txt: Removed.
* inspector/styles/css-live-edit.html: Removed.
* inspector/styles/edit-inspector-stylesheet-expected.txt: Removed.
* inspector/styles/edit-inspector-stylesheet.html: Removed.
* inspector/styles/edit-value-with-trimmed-url-expected.txt: Removed.
* inspector/styles/edit-value-with-trimmed-url.html: Removed.
* inspector/styles/force-pseudo-state-expected.txt: Removed.
* inspector/styles/force-pseudo-state.html: Removed.
* inspector/styles/inactive-properties-expected.txt: Removed.
* inspector/styles/inactive-properties.html: Removed.
* inspector/styles/lazy-computed-style-expected.txt: Removed.
* inspector/styles/lazy-computed-style.html: Removed.
* inspector/styles/media-emulation-expected.txt: Removed.
* inspector/styles/media-emulation.html: Removed.
* inspector/styles/media-queries-expected.txt: Removed.
* inspector/styles/media-queries.html: Removed.
* inspector/styles/metrics-box-sizing-expected.txt: Removed.
* inspector/styles/metrics-box-sizing.html: Removed.
* inspector/styles/paste-property-expected.txt: Removed.
* inspector/styles/paste-property.html: Removed.
* inspector/styles/perform-undo-perform-of-mergable-action-expected.txt: Removed.
* inspector/styles/perform-undo-perform-of-mergable-action.html: Removed.
* inspector/styles/protocol-css-regions-commands-expected.txt: Removed.
* inspector/styles/protocol-css-regions-commands.html: Removed.
* inspector/styles/selector-line-expected.txt: Removed.
* inspector/styles/selector-line.html: Removed.
* inspector/styles/show-user-agent-styles-expected.txt: Removed.
* inspector/styles/show-user-agent-styles.html: Removed.
* inspector/styles/styles-add-new-rule-expected.txt: Removed.
* inspector/styles/styles-add-new-rule.html: Removed.
* inspector/styles/styles-cancel-editing-expected.txt: Removed.
* inspector/styles/styles-cancel-editing.html: Removed.
* inspector/styles/styles-change-node-while-editing-expected.txt: Removed.
* inspector/styles/styles-change-node-while-editing.html: Removed.
* inspector/styles/styles-commit-editing-expected.txt: Removed.
* inspector/styles/styles-commit-editing.html: Removed.
* inspector/styles/styles-edit-property-after-invalid-rule-expected.txt: Removed.
* inspector/styles/styles-edit-property-after-invalid-rule.html: Removed.
* inspector/styles/styles-update-from-js-expected.txt: Removed.
* inspector/styles/styles-update-from-js.html: Removed.
* inspector/styles/styles-url-linkify-expected.txt: Removed.
* inspector/styles/styles-url-linkify.html: Removed.
* inspector/styles/svg-style-expected.txt: Removed.
* inspector/styles/svg-style.xhtml: Removed.
* inspector/styles/up-down-numerics-and-colors-expected.txt: Removed.
* inspector/styles/up-down-numerics-and-colors.html: Removed.
* inspector/styles/updates-during-dom-traversal-expected.txt: Removed.
* inspector/styles/updates-during-dom-traversal.html: Removed.
* inspector/styles/updates-throttled-expected.txt: Removed.
* inspector/styles/updates-throttled.html: Removed.
* inspector/styles/url-color-swatch-expected.txt: Removed.
* inspector/styles/url-color-swatch.html: Removed.
* inspector/styles/variables/css-variables-expected.txt: Removed.
* inspector/styles/variables/css-variables.html: Removed.
* inspector/styles/vendor-prefixes-expected.txt: Removed.
* inspector/styles/vendor-prefixes.html: Removed.
* inspector/syntax-highlight-css-expected.txt: Removed.
* inspector/syntax-highlight-css.html: Removed.
* inspector/syntax-highlight-html-expected.txt: Removed.
* inspector/syntax-highlight-html.html: Removed.
* inspector/syntax-highlight-javascript-expected.txt: Removed.
* inspector/syntax-highlight-javascript.html: Removed.
* inspector/syntax-highlight.js: Removed.
* inspector/tabbed-editors-history-expected.txt: Removed.
* inspector/tabbed-editors-history.html: Removed.
* inspector/tabbed-pane-max-tab-width-calculation-expected.txt: Removed.
* inspector/tabbed-pane-max-tab-width-calculation.html: Removed.
* inspector/tabbed-pane-tabs-to-show-expected.txt: Removed.
* inspector/tabbed-pane-tabs-to-show.html: Removed.
* inspector/timeline-dfs-expected.txt: Removed.
* inspector/timeline-dfs.html: Removed.
* inspector/timeline/timeline-coalescing-expected.txt: Removed.
* inspector/timeline/timeline-coalescing.html: Removed.
* inspector/timeline/timeline-enum-stability-expected.txt: Removed.
* inspector/timeline/timeline-enum-stability.html: Removed.
* inspector/uisourcecode-revisions-expected.txt: Removed.
* inspector/uisourcecode-revisions.html: Removed.
* inspector/user-metrics-expected.txt: Removed.
* inspector/user-metrics.html: Removed.
* inspector/utilities-highlight-results-expected.txt: Removed.
* inspector/utilities-highlight-results.html: Removed.
* inspector/version-controller-expected.txt: Removed.
* inspector/version-controller.html: Removed.
* inspector/view-css-expected.txt: Removed.
* inspector/view-css.html: Removed.
* inspector/view-events-expected.txt: Removed.
* inspector/view-events.html: Removed.
* inspector/workspace-mapping-expected.txt: Removed.
* inspector/workspace-mapping.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake a generic CDMPrivateMediaPlayer and move its CDMSession into platform/.
jer.noble@apple.com [Sat, 22 Feb 2014 00:13:01 +0000 (00:13 +0000)]
Make a generic CDMPrivateMediaPlayer and move its CDMSession into platform/.
https://bugs.webkit.org/show_bug.cgi?id=129164

Reviewed by Eric Carlson.

Move the session created by CDMPrivateAVFoundation into platform, and rename
CDMPrivateAVFoundation to CDMPrivateMediaPlayer. Future media engines who want
to support a keysystem from within the media engine can create their own
CDMSession as part of the MediaPlayerPrivate interface.

* Modules/encryptedmedia/CDM.cpp:
(WebCore::installedCDMFactories):
(WebCore::CDM::createSession):
* Modules/encryptedmedia/CDM.h:
* Modules/encryptedmedia/CDMPrivate.h:
* Modules/encryptedmedia/MediaKeySession.cpp:
* Modules/encryptedmedia/MediaKeySession.h:
* Modules/encryptedmedia/CDMPrivateAVFoundation.mm: Removed.
* Modules/encryptedmedia/CDMPrivateMediaPlayer.cpp: Renamed from Source/WebCore/Modules/encryptedmedia/CDMPrivateAVFoundation.cpp.
(WebCore::CDMPrivateMediaPlayer::supportsKeySystem):
(WebCore::CDMPrivateMediaPlayer::supportsKeySystemAndMimeType):
(WebCore::CDMPrivateMediaPlayer::supportsMIMEType):
(WebCore::CDMPrivateMediaPlayer::createSession):
* Modules/encryptedmedia/CDMPrivateMediaPlayer.h: Renamed from Source/WebCore/Modules/encryptedmedia/CDMPrivateAVFoundation.h.
(WebCore::CDMPrivateMediaPlayer::create):
(WebCore::CDMPrivateMediaPlayer::~CDMPrivateMediaPlayer):
(WebCore::CDMPrivateMediaPlayer::cdm):
(WebCore::CDMPrivateMediaPlayer::CDMPrivateMediaPlayer):
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/CDMSession.h: Extracted from CDMPrivateAVFoundation.h.
(WebCore::CDMSessionClient::~CDMSessionClient):
(WebCore::CDMSession::CDMSession):
(WebCore::CDMSession::~CDMSession):
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::createSession):
* platform/graphics/MediaPlayer.h:
* platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::createSession):
* platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.h: Renamed from Source/WebCore/Modules/encryptedmedia/CDMPrivateAVFoundation.h.
(WebCore::CDMSessionAVFoundationObjC::~CDMSessionAVFoundationObjC):
* platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.mm: Renamed from Source/WebCore/Modules/encryptedmedia/CDMPrivateAVFoundation.mm.
(WebCore::CDMSessionAVFoundationObjC::CDMSessionAVFoundationObjC):
(WebCore::CDMSessionAVFoundationObjC::generateKeyRequest):
(WebCore::CDMSessionAVFoundationObjC::releaseKeys):
(WebCore::CDMSessionAVFoundationObjC::update):
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createSession):
* testing/MockCDM.cpp:
(WebCore::MockCDMSession::setClient):
(WebCore::MockCDM::createSession):
* testing/MockCDM.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd a supportsKeySystem media engine factory parameter.
jer.noble@apple.com [Sat, 22 Feb 2014 00:12:51 +0000 (00:12 +0000)]
Add a supportsKeySystem media engine factory parameter.
https://bugs.webkit.org/show_bug.cgi?id=129161

Reviewed by Eric Carlson.

Add a new parameter to the MediaPlayerFactory to allow registered media
engines to be queried for keySystem support:
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayerFactory::MediaPlayerFactory):
(WebCore::MediaPlayer::supportsKeySystem):
* platform/graphics/MediaPlayer.h:

Support this new field in MediaPlayerPrivateAVFoundationObjC:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::registerMediaEngine):
(WebCore::keySystemIsSupported):
(WebCore::MediaPlayerPrivateAVFoundationObjC::supportsKeySystem):
(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource):

Add an empty field for SupportsKeySystem to the remaining media engines:
* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::MediaPlayerPrivateAVFoundationCF::registerMediaEngine):
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::registerMediaEngine):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::registerMediaEngine):
* platform/graphics/ios/MediaPlayerPrivateIOS.mm:
(WebCore::MediaPlayerPrivateIOS::registerMediaEngine):
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::registerMediaEngine):
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::registerMediaEngine):
* platform/mock/mediasource/MockMediaPlayerMediaSource.cpp:
(WebCore::MockMediaPlayerMediaSource::registerMediaEngine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Replace binarySearch with lowerBound and upperBound functions
commit-queue@webkit.org [Sat, 22 Feb 2014 00:10:53 +0000 (00:10 +0000)]
Web Inspector: Replace binarySearch with lowerBound and upperBound functions
https://bugs.webkit.org/show_bug.cgi?id=118609

Patch by Chi Wai Lau <clau@apple.com> on 2014-02-21
Reviewed by Timothy Hatcher.

Source/WebInspectorUI:

This makes insertionIndexForObjectInListSortedByFunction work in O(log(n)) time instead of O(n).

* UserInterface/BinarySearch.js: Removed.
* UserInterface/Main.html:
* UserInterface/Utilities.js:
* WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
* WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:

LayoutTests:

* inspector/utilities-expected.txt:
* inspector/utilities.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Win] fast/table/col-and-colgroup-offsets.html - offsetHeight differs from Mac results
dbates@webkit.org [Sat, 22 Feb 2014 00:05:25 +0000 (00:05 +0000)]
[Win] fast/table/col-and-colgroup-offsets.html - offsetHeight differs from Mac results
https://bugs.webkit.org/show_bug.cgi?id=129179

The test col-and-colgroup-offsets.html is failing on the Apple Win Debug (Tests) bot due
to platform-specific numeric differences in the computed offsetHeight of the table cells.
For now, I am landing Windows-specific expected results as the behavior tested by the test
is correct despite the numerical differences. I'll further investigate the Window-specific
difference in <https://bugs.webkit.org/show_bug.cgi?id=129179>.

* platform/win/fast/table/col-and-colgroup-offsets-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: animate breakpoint tree elements when probe samples are received
bburg@apple.com [Sat, 22 Feb 2014 00:01:45 +0000 (00:01 +0000)]
Web Inspector: animate breakpoint tree elements when probe samples are received
https://bugs.webkit.org/show_bug.cgi?id=128334

Reviewed by Timothy Hatcher.

Source/WebInspectorUI:

* UserInterface/BreakpointIcons.css: Removed, rules migrated to the following file.

* UserInterface/BreakpointTreeElement.css: When we want to animateon top of the
static icon, we set the icon image as the icon element's background, and animate
a span on top of the icon element.

(.breakpoint-exception-icon .icon): Moved.
(.breakpoint-generic-line-icon .icon):
(.breakpoint-generic-line-icon .icon > span): Added.
(.data-updated.breakpoint-generic-line-icon .icon > span): Added.

* UserInterface/BreakpointTreeElement.js:
(WebInspector.BreakpointTreeElement): Rewrite event listener add/remove to use EventListenerSet.
(WebInspector.BreakpointTreeElement.prototype.ondetach): Override to unregister the instance's listeners.
(WebInspector.BreakpointTreeElement.prototype._addProbeSet): Added.
(WebInspector.BreakpointTreeElement.prototype._removeProbeSet): Added.
(WebInspector.BreakpointTreeElement.prototype._probeSetAdded): Added.
(WebInspector.BreakpointTreeElement.prototype._probeSetRemoved): Added.
Add/remove listeners when probe sets change.

(WebInspector.BreakpointTreeElement.prototype._samplesCleared): Listeners should follow
the active data table.

(WebInspector.BreakpointTreeElement.prototype._dataUpdated): Run the animation when probe data changes.
(WebInspector.BreakpointTreeElement.prototype._breakpointLocationDidChange): Fix a listener leak.
* UserInterface/Main.html: Remove BreakpointIcons.css.
* UserInterface/NavigationSidebarPanel.css:
(.navigation-sidebar-panel-content-tree-outline .item .icon): give icons
'position: relative' so child spans can be absolutely positioned.
* UserInterface/ProbeDetailsSidebarPanel.js: Get probeSet out of the event data
container. The probe set used to be passed as the data container itself.
(WebInspector.ProbeDetailsSidebarPanel.prototype._probeSetAdded):
* UserInterface/ProbeManager.js:
(WebInspector.ProbeManager.prototype._breakpointActionsChanged.set get knownProbeIdentifiers):
(WebInspector.ProbeManager.prototype._breakpointActionsChanged):
(WebInspector.ProbeManager.prototype.get _probeSetForBreakpoint.set this):
* UserInterface/ProbeSet.js:
(WebInspector.ProbeSet.prototype.clearSamples): include the old data table as the SamplesCleared event data.
* UserInterface/TextResourceContentView.js:
(WebInspector.TextResourceContentView.prototype._probeSetsChanged):

LayoutTests:

Adjust probe manager tracing listeners to access the correct data container property.

* inspector-protocol/resources/probe-helper.js:
(ProbeHelper.installTracingListeners):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix WebCore's internals after r164505
benjamin@webkit.org [Fri, 21 Feb 2014 23:44:32 +0000 (23:44 +0000)]
Fix WebCore's internals after r164505

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-02-21

* testing/Internals.cpp:
(WebCore::Internals::findEditingDeleteButton): The call became ambiguous after r164505.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[iOS][WK2] Update the visible content rects on zoom
benjamin@webkit.org [Fri, 21 Feb 2014 23:38:09 +0000 (23:38 +0000)]
[iOS][WK2] Update the visible content rects on zoom
https://bugs.webkit.org/show_bug.cgi?id=129174

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-02-21
Reviewed by Simon Fraser.

Generalize _updateVisibleContentRects to also act during the zoom and not only at the end.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView scrollViewDidZoom:]):
* UIProcess/API/ios/WKViewIOS.mm:
(-[WKView scrollViewDidZoom:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: JSContext inspection should report exceptions in the console
joepeck@webkit.org [Fri, 21 Feb 2014 23:35:32 +0000 (23:35 +0000)]
Web Inspector: JSContext inspection should report exceptions in the console
https://bugs.webkit.org/show_bug.cgi?id=128776

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

When JavaScript API functions have an exception, let the inspector
know so it can log the JavaScript and Native backtrace that caused
the exception.

Include some clean up of ConsoleMessage and ScriptCallStack construction.

* API/JSBase.cpp:
(JSEvaluateScript):
(JSCheckScriptSyntax):
* API/JSObjectRef.cpp:
(JSObjectMakeFunction):
(JSObjectMakeArray):
(JSObjectMakeDate):
(JSObjectMakeError):
(JSObjectMakeRegExp):
(JSObjectGetProperty):
(JSObjectSetProperty):
(JSObjectGetPropertyAtIndex):
(JSObjectSetPropertyAtIndex):
(JSObjectDeleteProperty):
(JSObjectCallAsFunction):
(JSObjectCallAsConstructor):
* API/JSValue.mm:
(reportExceptionToInspector):
(valueToArray):
(valueToDictionary):
* API/JSValueRef.cpp:
(JSValueIsEqual):
(JSValueIsInstanceOfConstructor):
(JSValueCreateJSONString):
(JSValueToNumber):
(JSValueToStringCopy):
(JSValueToObject):
When seeing an exception, let the inspector know there was an exception.

* inspector/JSGlobalObjectInspectorController.h:
* inspector/JSGlobalObjectInspectorController.cpp:
(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
(Inspector::JSGlobalObjectInspectorController::appendAPIBacktrace):
(Inspector::JSGlobalObjectInspectorController::reportAPIException):
Log API exceptions by also grabbing the native backtrace.

* inspector/ScriptCallStack.h:
* inspector/ScriptCallStack.cpp:
(Inspector::ScriptCallStack::firstNonNativeCallFrame):
(Inspector::ScriptCallStack::append):
Minor extensions to ScriptCallStack to make it easier to work with.

* inspector/ConsoleMessage.cpp:
(Inspector::ConsoleMessage::ConsoleMessage):
(Inspector::ConsoleMessage::autogenerateMetadata):
Provide better default information if the first call frame was native.

* inspector/ScriptCallStackFactory.cpp:
(Inspector::createScriptCallStack):
(Inspector::extractSourceInformationFromException):
(Inspector::createScriptCallStackFromException):
Perform the handling here of inserting a fake call frame for exceptions
if there was no call stack (e.g. a SyntaxError) or if the first call
frame had no information.

* inspector/ConsoleMessage.cpp:
(Inspector::ConsoleMessage::ConsoleMessage):
(Inspector::ConsoleMessage::autogenerateMetadata):
* inspector/ConsoleMessage.h:
* inspector/ScriptCallStackFactory.cpp:
(Inspector::createScriptCallStack):
(Inspector::createScriptCallStackForConsole):
* inspector/ScriptCallStackFactory.h:
* inspector/agents/InspectorConsoleAgent.cpp:
(Inspector::InspectorConsoleAgent::enable):
(Inspector::InspectorConsoleAgent::addMessageToConsole):
(Inspector::InspectorConsoleAgent::count):
* inspector/agents/JSGlobalObjectDebuggerAgent.cpp:
(Inspector::JSGlobalObjectDebuggerAgent::breakpointActionLog):
ConsoleMessage cleanup.

Source/WebCore:

Include some clean up of ConsoleMessage and ScriptCallStack construction.

Covered by existing tests.

* bindings/js/JSDOMBinding.cpp:
(WebCore::reportException):
Simplify code now that createStackTraceFromException handles it.

* page/ContentSecurityPolicy.cpp:
(WebCore::gatherSecurityPolicyViolationEventData):
(WebCore::ContentSecurityPolicy::reportViolation):
ScriptCallStack can give us the first non-native callframe.

* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::buildInitiatorObject):
* inspector/PageDebuggerAgent.cpp:
(WebCore::PageDebuggerAgent::breakpointActionLog):
* inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createGenericRecord):
* page/Console.cpp:
(WebCore::internalAddMessage):
(WebCore::Console::profile):
(WebCore::Console::profileEnd):
(WebCore::Console::timeEnd):
* page/ContentSecurityPolicy.cpp:
(WebCore::gatherSecurityPolicyViolationEventData):
(WebCore::ContentSecurityPolicy::reportViolation):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::postMessage):

Source/WebInspectorUI:

* UserInterface/ConsoleMessageImpl.js:
(WebInspector.ConsoleMessageImpl.prototype._formatMessage):
(WebInspector.ConsoleMessageImpl.prototype._shouldHideURL):
(WebInspector.ConsoleMessageImpl.prototype._firstNonNativeCallFrame):
(WebInspector.ConsoleMessageImpl.prototype._populateStackTraceTreeElement):
Provide better handling for "[native code]" and legacy "undefined"
call frame URLs. Never linkify these. Also, when showing a link
for an exception, always use the first non-native call frame as
the link location.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake old-run-webkit-tests work with iOS Simulator WebKitTestRunner
dfarler@apple.com [Fri, 21 Feb 2014 23:30:25 +0000 (23:30 +0000)]
Make old-run-webkit-tests work with iOS Simulator WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=128622

Reviewed by Simon Fraser.

With this change, we now have layout tests running in both DumpRenderTree
and WebKitTestRunner, with WebKit and WebKit2 used respectively in the iOS
simulator.

* Scripts/old-run-webkit-tests:
In general, make any specific reference to DumpRenderTree
able to refer to WebKitTestRunner wherever possible:
- Rename functions to remove DRT-specific naming.
- Name FIFOs after the tool that is being used.
-- Clean up FIFO creation code
Other necessary changes:
- Allow use of an ios-sim-wk2 platform.
- Clean up platform hierarchy creation where the simulator platform behavior differed.
* WebKitTestRunner/TestController.cpp:
Open FIFOs to get dumps out of the simulator as we do in DumpRenderTree.
(WTR::TestController::TestController):
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
Copy the injected bundle into the app bundle.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agojsDocumentPrototypeFunctionGetElementById should not create an AtomicString for the...
benjamin@webkit.org [Fri, 21 Feb 2014 22:47:37 +0000 (22:47 +0000)]
jsDocumentPrototypeFunctionGetElementById should not create an AtomicString for the function argument
https://bugs.webkit.org/show_bug.cgi?id=128893

Reviewed by Darin Adler.

Source/WebCore:

The declaration of TreeScope::getElementById() was taking an AtomicString as the parameter.
Because of this, all the call sites manipulating String were creating and keeping alive an AtomicString
to make the call.

This had two negative consequences:
-The call sites were ref-ing the ID's atomic string for no reason.
-When there is no ID associated with the input string, an atomic string was created for the sole
 purpose of failing the query. Since IDs are stored as AtomicString, if there is not an existing
 AtomicString for the input, there is no reason to query anything.

* WebCore.exp.in:
* bindings/js/JSDOMBinding.cpp:
(WebCore::findAtomicString): Update this after the rename.

* bindings/scripts/CodeGeneratorObjC.pm:
(GenerateImplementation):
* bindings/scripts/IDLAttributes.txt:
Now that there are two overloads for TreeScope::getElementById(), the conversion from NSString*
is ambiguous. I add the keyword ObjCExplicitAtomicString to force an explicit conversion to AtomicString.

* dom/Document.idl:
* dom/TreeScope.cpp:
(WebCore::TreeScope::getElementById):
When getting an AtomicString, the case of a empty string is not important, use isNull() instead.
When getting a String, get the corresponding AtomicString if any and use that for getting the element.

* dom/TreeScope.h:
* html/FTPDirectoryDocument.cpp:
(WebCore::FTPDirectoryDocumentParser::loadDocumentTemplate):
Solve the ambiguous call.

* svg/SVGAElement.cpp:
(WebCore::SVGAElement::defaultEventHandler):
This is a wonderful candidate for substringSharingImpl. The substring does not survive the call since
the new getElementById never create any AtomicString.

* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::getElementById):
It looks like there are opportunities to get faster here, Ryosuke should have a look.

* svg/SVGSVGElement.h:
* xml/XMLTreeViewer.cpp:
(WebCore::XMLTreeViewer::transformDocumentToTreeView):
Unrelated cleanup: noStyleMessage was useless.

Source/WebKit2:

* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::pageNumberForElementById): Remove the explicit conversion to use the right overload.

Source/WTF:

AtomicString::find() is a special case optimized for the JavaScript bindings. The method can only
be called under specific conditions.
The method is renamed to findStringWithHash().

The new AtomicString::find is generic and does not require any propery on the input.

* wtf/text/AtomicString.cpp:
(WTF::AtomicString::findStringWithHash):
(WTF::AtomicString::findSlowCase):
* wtf/text/AtomicString.h:
(WTF::AtomicString::find):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCOL element in table has 0 for offsetWidth
dbates@webkit.org [Fri, 21 Feb 2014 22:38:12 +0000 (22:38 +0000)]
COL element in table has 0 for offsetWidth
https://bugs.webkit.org/show_bug.cgi?id=15277

Reviewed by David Hyatt.

Source/WebCore:

Implements offset{Left, Top, Width, Height} for table columns and column groups
per section Extensions to the HTMLElement Interface of the CSSOM View spec,
<http://www.w3.org/TR/cssom-view/#extensions-to-the-htmlelement-interface> (Draft 17 December 2013).

For now, we fail almost all of the offset{Height, Top} sub-tests in the included test
for the separate border model as we need to fix <https://bugs.webkit.org/show_bug.cgi?id=128988>.

Test: fast/table/col-and-colgroup-offsets.html

* rendering/RenderTable.cpp:
(WebCore::RenderTable::RenderTable): Initialize cached column offset top and offset height.
We cache these offsets since they are the same for all columns in the table.
(WebCore::RenderTable::invalidateCachedColumns): Clear cached effective column index map.
(WebCore::RenderTable::invalidateCachedColumnOffsets): Added.
(WebCore::RenderTable::layout): Invalidate cached column offsets as the location or height
of one or more sections may have changed.
(WebCore::RenderTable::updateColumnCache): Modified to build effective column index map.
(WebCore::RenderTable::effectiveIndexOfColumn): Added.
(WebCore::RenderTable::offsetTopForColumn): Added.
(WebCore::RenderTable::offsetLeftForColumn): Added.
(WebCore::RenderTable::offsetWidthForColumn): Added.
(WebCore::RenderTable::offsetHeightForColumn): Added.
* rendering/RenderTable.h: Make isTableColumnGroupWithColumnChildren() const.
* rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::offsetLeft): Added; turns around and calls RenderTable::offsetLeftForColumn().
(WebCore::RenderTableCol::offsetTop): Added; turns around and calls RenderTable::offsetTopForColumn().
(WebCore::RenderTableCol::offsetWidth): Added; turns around and calls RenderTable::offsetWidthForColumn().
(WebCore::RenderTableCol::offsetHeight): Added; turns around and calls RenderTable::offsetHeightForColumn().
* rendering/RenderTableCol.h:

LayoutTests:

Added test to ensure that offset{Left, Top, Width, Height} return correct results
for table columns and column groups.

For now, we fail almost all of the offset{Height, Top} sub-tests for the separate
border model as we need to fix <https://bugs.webkit.org/show_bug.cgi?id=128988>.

* fast/table/col-and-colgroup-offsets-expected.txt: Added.
* fast/table/col-and-colgroup-offsets.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164504 268f45cc-cd09-0410-ab3c-d52691b4dbfc