WebKit-https.git
7 years agoadd Farstream flags/deps to WebKit, for WebRTC
commit-queue@webkit.org [Tue, 31 Jul 2012 08:46:59 +0000 (08:46 +0000)]
add Farstream flags/deps to WebKit, for WebRTC
https://bugs.webkit.org/show_bug.cgi?id=87524

Patch by Danilo Cesar Lemes de Paula <danilo.cesar@collabora.co.uk> on 2012-07-31
Reviewed by Philippe Normand.

Since Farstream will be used as the backend for GTK's WebRTC, this
patch adds it as a dependency to the build system.

.:

* GNUmakefile.am:
* configure.ac:

Source/WebCore:

No new features or code changes were added, so new tests aren't necessary.

* GNUmakefile.am:

Source/WebKit2:

* GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed crash fix after r124135.
zandobersek@gmail.com [Tue, 31 Jul 2012 08:09:49 +0000 (08:09 +0000)]
Unreviewed crash fix after r124135.

* platform/graphics/cairo/PathCairo.cpp:
(WebCore::Path::Path): Ensure the Cairo path when acquiring its context,
crashes ensue otherwise.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChange Element::isReadOnlyFormControl to Element::shouldMatchReadOnlySelector/shouldM...
yosin@chromium.org [Tue, 31 Jul 2012 07:58:47 +0000 (07:58 +0000)]
Change Element::isReadOnlyFormControl to Element::shouldMatchReadOnlySelector/shouldMatchReadWriteSelector or HTMLFormControlElement::readOnly
https://bugs.webkit.org/show_bug.cgi?id=92602

Reviewed by Kent Tamura.

This patch replaces Element::isReadOnlyFormControl() by
Element::shouldMatchReadOnlySelector/shouldMatchReadOnlySelector or
HTMLFormControlElement::readOnly() to make intention of functions
self descriptive.

No new tests. This patch doesn't change behavior.

* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOneSelector): Replaced isReadOnlyFormControl() by shouldMatchReadOnlySelector() for :read-only pseudo class, and replaced isReadOnlyFormControl() by shouldMatchReadOnlySelector() for :read-only pseudo class.
* dom/Element.cpp:
(WebCore::Element::shouldMatchReadOnlySelector): Added for default implementation.
(WebCore::Element::shouldMatchReadWriteSelector): for default implementation.
* dom/Element.h:
(Element): Removed isReadOnlyFormControl() and added shouldMatchReadOnlySelector and shouldMatchReadWriteSelector.
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::shouldMatchReadOnlySelector): Added.
(WebCore::HTMLFormControlElement::shouldMatchReadWriteSelector): Added.
* html/HTMLFormControlElement.h:
(HTMLFormControlElement): Removed isReadOnlyFormControl() and added shouldMatchReadOnlySelector and shouldMatchReadWriteSelector.
* html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::shouldMatchReadOnlySelector): Added.
(WebCore::SliderThumbElement::shouldMatchReadWriteSelector): Added.
(WebCore::SliderThumbElement::willRespondToMouseMoveEvents): Replaced isReadOnlyFormControl() by readOnly().
(WebCore::SliderThumbElement::willRespondToMouseClickEvents): ditto.
(SliderThumbElement):
* html/shadow/TextControlInnerElements.cpp:
(WebCore::SearchFieldCancelButtonElement::willRespondToMouseClickEvents): Replaced isReadOnlyFormControl() by readOnly().
(WebCore::SpinButtonElement::willRespondToMouseMoveEvents): ditto.
(WebCore::SpinButtonElement::willRespondToMouseClickEvents): ditto.
(WebCore::SpinButtonElement::shouldMatchReadOnlySelector): Added.
(WebCore::SpinButtonElement::shouldMatchReadWriteSelector): Added.
(WebCore::InputFieldSpeechButtonElement::willRespondToMouseClickEvents): Replaced isReadOnlyFormControl() by readOnly().
* html/shadow/TextControlInnerElements.h:
(SpinButtonElement): Removed isReadOnlyFormControl() and added shouldMatchReadOnlySelector and shouldMatchReadWriteSelector.
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::isReadOnlyControl): Replaced isReadOnlyControl() by shouldMatchReadOnlySelector().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Size the Vector in encodeInt/encodeVarInt/encodeString
commit-queue@webkit.org [Tue, 31 Jul 2012 07:12:23 +0000 (07:12 +0000)]
IndexedDB: Size the Vector in encodeInt/encodeVarInt/encodeString
https://bugs.webkit.org/show_bug.cgi?id=91813

Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-07-31
Reviewed by Kentaro Hara.

To avoid memory re-allocation in Vector, init the capability or size of Vector in encodeInt(), encodeVarInt(),
encodeBool(), encodeIDBKey() etc.

No new tests - Low level functions covered by existing layout tests and also covered by Chromium
webkit_unit_tests IDBLevelIDBCodingTest.* which validates the sizes of buffers returned by encodeVarInt.

* Modules/indexeddb/IDBLevelDBCoding.cpp:
(WebCore::IDBLevelDBCoding::encodeInt):
(WebCore::IDBLevelDBCoding::encodeVarInt):
(WebCore::IDBLevelDBCoding::encodeString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Texmap] Remove the backing store after 'style.visibility' for an element sets 'hidden'.
commit-queue@webkit.org [Tue, 31 Jul 2012 06:55:55 +0000 (06:55 +0000)]
[Texmap] Remove the backing store after 'style.visibility' for an element sets 'hidden'.
https://bugs.webkit.org/show_bug.cgi?id=92492

Patch by Huang Dongsung <luxtella@company100.net> on 2012-07-30
Reviewed by Noam Rosenthal.

Source/WebCore:

This patch's purpose is to save vram memory.
When visibility of the element sets hidden, we do not need to draw the element,
so we do not need to keep a texture of the backing store.
Currently, Texmap does not draw the element with visibility:hidden because
RenderLayerBacking::paintIntoLayer does not draw anything.
This patch just removes unused textures.

No new tests - no new testable functionality.

* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::setContentsVisible):
(WebCore):
* platform/graphics/texmap/GraphicsLayerTextureMapper.h:
(GraphicsLayerTextureMapper):
* platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::updateBackingStore):
(WebCore::TextureMapperLayer::paintSelf):
(WebCore::TextureMapperLayer::isVisible):
(WebCore::TextureMapperLayer::syncCompositingStateSelf):
* platform/graphics/texmap/TextureMapperLayer.h:
(State):
(WebCore::TextureMapperLayer::State::State):

Source/WebKit2:

Texmap handles visibility:hidden in this patch, so WebGraphicsLayer
sends the LayerTreeCoordinatorProxyMessages with additional infomation
to UIProcess.

* Shared/WebLayerTreeInfo.h:
* UIProcess/WebLayerTreeRenderer.cpp:
(WebKit::WebLayerTreeRenderer::setLayerState):
* WebProcess/WebPage/LayerTreeCoordinator/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::setContentsVisible):
(WebCore):
(WebCore::WebGraphicsLayer::syncLayerState):
* WebProcess/WebPage/LayerTreeCoordinator/WebGraphicsLayer.h:
(WebGraphicsLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] New lines automatically and repeatedly added to list items in Etherpad
commit-queue@webkit.org [Tue, 31 Jul 2012 06:52:49 +0000 (06:52 +0000)]
[GTK] New lines automatically and repeatedly added to list items in Etherpad
https://bugs.webkit.org/show_bug.cgi?id=89971

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-07-30
Reviewed by Ryosuke Niwa.

Disable the deletion UI by default. This UI, which was enabled as a side-effect
of the addition of the private editing API, seems to expose a bug in Etherpad
which causes the continuous insertion of bullet points.

* WebCoreSupport/EditorClientGtk.cpp:
(WebKit::EditorClient::shouldShowDeleteInterface): Disable the deletion UI by default.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImplement datalist UI for input type color for Chromium
keishi@webkit.org [Tue, 31 Jul 2012 06:27:00 +0000 (06:27 +0000)]
Implement datalist UI for input type color for Chromium
https://bugs.webkit.org/show_bug.cgi?id=92075

Reviewed by Kent Tamura.

Source/Platform:

* chromium/public/WebLocalizedString.h: Added OtherColorLabel.

Source/WebCore:

Test: platform/chromium/fast/forms/color/color-suggestion-picker-appearance.html

* rendering/RenderThemeChromiumCommon.cpp:
(WebCore::RenderThemeChromiumCommon::supportsDataListUI): Added color to types supporting datalist.

Source/WebKit/chromium:

Integrated ColorChooserProxy and WebColorChooserClientImpl into ColorChooserUIController.
ColorChooserUIController can control whether to open the color suggestion picker
popup or the color chooser depending on the responses from ColorChooserClient.

* WebKit.gyp:
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::createColorChooser): Returns ColorChooserUIController which is a ColorChooser.
(WebKit::ChromeClientImpl::createWebColorChooser): Returns WebColorChooser that was created by Chromium.
* src/ChromeClientImpl.h:
(WebKit):
(ChromeClientImpl):
* src/ColorChooserProxy.cpp: Removed.
* src/ColorChooserProxy.h: Removed.
* src/ColorChooserUIController.cpp: Added.
(WebKit):
(WebKit::ColorChooserUIController::ColorChooserUIController): Controls the UI for color chooser. Opens the color suggestion picker popup or color chooser depending on the ColorChooserClient.
(WebKit::ColorChooserUIController::~ColorChooserUIController):
(WebKit::ColorChooserUIController::setSelectedColor):
(WebKit::ColorChooserUIController::endChooser): This is called by WebCore so we close both the popup and the color chooser.
(WebKit::ColorChooserUIController::didChooseColor):
(WebKit::ColorChooserUIController::didEndChooser):
(WebKit::ColorChooserUIController::contentSize): The popup will be resized later from JS so we return an arbitrary size.
(WebKit::ColorChooserUIController::writeDocument):
(WebKit::ColorChooserUIController::setValueAndClosePopup): Performs action based on the numValue.
(WebKit::ColorChooserUIController::didClosePopup):
(WebKit::ColorChooserUIController::openPopup): Opens color chooser suggestion popup.
(WebKit::ColorChooserUIController::closePopup):
(WebKit::ColorChooserUIController::openColorChooser): Opens color chooser.
* src/ColorChooserUIController.h: Renamed from Source/WebKit/chromium/src/WebColorChooserClientImpl.h.
(WebCore):
(WebKit):
(ColorChooserUIController):
* src/WebColorChooserClientImpl.cpp: Removed.

LayoutTests:

* platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png: Added.
* platform/chromium/TestExpectations:
* platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.txt: Added.
* platform/chromium/fast/forms/color/color-suggestion-picker-appearance.html: Added. Tests color suggestion picker popup appearance.
* platform/chromium/fast/forms/datalist/input-list-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago/api/test/runs/chart expires on perf-o-matic
rniwa@webkit.org [Tue, 31 Jul 2012 06:19:17 +0000 (06:19 +0000)]
/api/test/runs/chart expires on perf-o-matic
https://bugs.webkit.org/show_bug.cgi?id=92714

Reviewed by Hajime Morita.

Don't update the entire JSON while generating the dashboard images.
This is a bug and not doing this will reduce the server load significantly.

* Websites/webkit-perf.appspot.com/controller.py:
(RunsChartHandler.post):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r124171.
commit-queue@webkit.org [Tue, 31 Jul 2012 05:46:43 +0000 (05:46 +0000)]
Unreviewed, rolling out r124171.
http://trac.webkit.org/changeset/124171
https://bugs.webkit.org/show_bug.cgi?id=92712

Start failing fast/css/square-button-appearance.html
(Requested by yosin on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-30

* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOneSelector):
* dom/Element.cpp:
* dom/Element.h:
(Element):
(WebCore::Element::isReadOnlyFormControl):
* html/HTMLFormControlElement.h:
(WebCore::HTMLFormControlElement::isReadOnlyFormControl):
* html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::isReadOnlyFormControl):
(WebCore::SliderThumbElement::willRespondToMouseMoveEvents):
(WebCore::SliderThumbElement::willRespondToMouseClickEvents):
* html/shadow/SliderThumbElement.h:
(SliderThumbElement):
* html/shadow/TextControlInnerElements.cpp:
(WebCore::SearchFieldCancelButtonElement::willRespondToMouseClickEvents):
(WebCore::SpinButtonElement::willRespondToMouseMoveEvents):
(WebCore::SpinButtonElement::willRespondToMouseClickEvents):
(WebCore::InputFieldSpeechButtonElement::willRespondToMouseClickEvents):
* html/shadow/TextControlInnerElements.h:
(WebCore::SpinButtonElement::isReadOnlyFormControl):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::isReadOnlyControl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Layout Test fast/forms/date/calendar-picker-appearance.html is flaky
tkent@chromium.org [Tue, 31 Jul 2012 05:28:37 +0000 (05:28 +0000)]
[Chromium] Layout Test fast/forms/date/calendar-picker-appearance.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=92710

* fast/forms/date/calendar-picker-appearance.html:
 Attempt to fix the flakiness.
* platform/chromium/TestExpectations: Add an entry for calendar-picker-appearance.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Baseline and expectation followups after r124142.
pkasting@chromium.org [Tue, 31 Jul 2012 04:20:24 +0000 (04:20 +0000)]
[Chromium] Baseline and expectation followups after r124142.
https://bugs.webkit.org/show_bug.cgi?id=62754
https://bugs.webkit.org/show_bug.cgi?id=80531
http://crbug.com/47826

Unreviewed, test updates.

* platform/chromium-linux-x86/css2.1/20110323: Added.
* platform/chromium-linux-x86/css2.1/20110323/block-replaced-width-001-expected.png: Added.
* platform/chromium-linux-x86/css2.1/20110323/block-replaced-width-001-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/block-replaced-width-001-expected.png: Added.
* platform/chromium-linux/fast/table/colspanMinWidth-vertical-expected.txt: Removed.
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png:
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/image-pattern-rotate-expected.png:
* platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
* platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-styles-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/table/colspanMinWidth-vertical-expected.png: Removed.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/canvas/image-pattern-rotate-expected.png: Added.
* platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png: Added.
* platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt: Added.
* platform/chromium-mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
* platform/chromium-mac/fast/dom/HTMLMeterElement/meter-element-expected.png: Added.
* platform/chromium-mac/fast/dom/HTMLMeterElement/meter-element-expected.txt: Added.
* platform/chromium-mac/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Added.
* platform/chromium-mac/fast/dom/HTMLMeterElement/meter-optimums-expected.txt: Added.
* platform/chromium-mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png: Added.
* platform/chromium-mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt: Added.
* platform/chromium-mac/fast/dom/HTMLMeterElement/meter-styles-expected.png: Added.
* platform/chromium-mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt: Added.
* platform/chromium-mac/fast/table/colspanMinWidth-vertical-expected.png: Added.
* platform/chromium-mac/fast/table/colspanMinWidth-vertical-expected.txt:
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png:
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/image-pattern-rotate-expected.png:
* platform/chromium-win-xp/css2.1/20110323/block-replaced-width-001-expected.png: Added.
* platform/chromium-win/css2.1/20110323/block-replaced-width-001-expected.png: Added.
* platform/chromium-win/css2.1/20110323/block-replaced-width-001-expected.txt: Added.
* platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.png:
* platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.txt:
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png:
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/image-pattern-rotate-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS] Change Element::isReadOnlyFormControl to shouldMatchReadWriteSelector or HTMLTe...
yosin@chromium.org [Tue, 31 Jul 2012 04:19:30 +0000 (04:19 +0000)]
[CSS] Change Element::isReadOnlyFormControl to shouldMatchReadWriteSelector or HTMLTextFormControlElement::readOnly
https://bugs.webkit.org/show_bug.cgi?id=92602

Reviewed by Kent Tamura.

This patch renames Element::isReadOnlyFormControl() to Element::shouldMatchReadWriteSelector()
or HTMLTextFormControlElement::readOnly() to make intention of
shouldMatchReadWriteSelector(was isReadOnlyFormControl) self descriptive.

No new tests. This patch doesn't change behavior.

* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOneSelector): Replaced isReadOnlyFormControl() by shouldMatchReadWriteSelector().
* dom/Element.cpp:
(WebCore::Element::shouldMatchReadWriteSelector): Added default implementation.
* dom/Element.h:
(WebCore::Element::shouldMatchReadWriteSelector): Replaced isReadOnlyFormControl() by shouldMatchReadWriteSelector().
* html/HTMLFormControlElement.h:
* html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::shouldMatchReadWriteSelector): Replaced isReadOnlyFormControl() by shouldMatchReadWriteSelector().
(WebCore::SliderThumbElement::willRespondToMouseMoveEvents): Replaced isReadOnlyFormControl() by readOnly().
(WebCore::SliderThumbElement::willRespondToMouseClickEvents): ditto.
* html/shadow/SliderThumbElement.h:
(SliderThumbElement): Replaced isReadOnlyFormControl() by shouldMatchReadWriteSelector().
* html/shadow/TextControlInnerElements.cpp:
(WebCore::SearchFieldCancelButtonElement::willRespondToMouseClickEvents): Replaced isReadOnlyFormControl() by readOnly().
(WebCore::SpinButtonElement::willRespondToMouseMoveEvents): Replaced isReadOnlyFormControl() by readOnly().
(WebCore::SpinButtonElement::willRespondToMouseClickEvents): Replaced isReadOnlyFormControl() by readOnly().
(WebCore::InputFieldSpeechButtonElement::willRespondToMouseClickEvents): Replaced isReadOnlyFormControl() by readOnly().
* html/shadow/TextControlInnerElements.h:
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::isReadOnlyControl): Replaced isReadOnlyFormControl() by shouldMatchReadWriteSelector().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Add baseline files for calendar-picker-appearance.html
tkent@chromium.org [Tue, 31 Jul 2012 03:49:06 +0000 (03:49 +0000)]
[Chromium] Add baseline files for calendar-picker-appearance.html
https://bugs.webkit.org/show_bug.cgi?id=84827

* platform/chromium-linux-x86/fast/forms/date/calendar-picker-appearance-expected.png: Added.
* platform/chromium-linux/fast/forms/date/calendar-picker-appearance-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/date/calendar-picker-appearance-expected.png:
* platform/chromium-mac/fast/forms/date/calendar-picker-appearance-expected.png: Added.
* platform/chromium-win-xp/fast/forms/date/calendar-picker-appearance-expected.png: Added.
* platform/chromium-win/fast/forms/date/calendar-picker-appearance-expected.png: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd a proper umbrella header for the public WebKit2 API headers
weinig@apple.com [Tue, 31 Jul 2012 03:39:01 +0000 (03:39 +0000)]
Add a proper umbrella header for the public WebKit2 API headers
https://bugs.webkit.org/show_bug.cgi?id=92708
<rdar://problem/11970825>

Reviewed by Dan Bernstein.

Create a new umbrella WebKit2.h and add the currently public (as decided by their
status in Xcode) Objective-C headers.

* UIProcess/API/mac/WebKit2.h: Added.
* WebKit2.xcodeproj/project.pbxproj:
While we are here, make WebKit2_C.h a private header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove overflow: scroll handling in block flow layout methods
jchaffraix@webkit.org [Tue, 31 Jul 2012 03:38:53 +0000 (03:38 +0000)]
Remove overflow: scroll handling in block flow layout methods
https://bugs.webkit.org/show_bug.cgi?id=92689

Reviewed by Simon Fraser.

The overflow: scroll scrollbars creation was done at layout time for all RenderBlocks and
descendants. This was not only wrong ('overflow' only changes at style change time) but it
was also introducing some code duplication.

The gist of this change is to share the code by moving it to RenderLayer::updateScrollbarsAfterStyleChange,
this includes the code from bug 69993 to special case list box part.

Covered by existing tests:
- All fast/overflow ones.
- For the list box change:
    fast/forms/select-overflow-scroll-inherited.html
    fast/forms/select-overflow-scroll.html
- For the flexbox:
    css3/flexbox/preferred-widths-orthogonal.html
    css3/flexbox/preferred-widths.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
* rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutBlock):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
Removed the common code here.

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computePreferredLogicalWidths):
Changed to an ASSERT now that the right scrollbars are created. This is
fine as overflow-x/y are physical coordinates and our access was following that.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::invalidateScrollbarRect):
Added an early return here if we are not attached yet as RenderLayer::styleChanged
is called at attachment time before we are inserted in the tree. This is fine as the
scrollbars are part of the object which will be painted after the first layout.

(WebCore::overflowRequiresAScrollbar):
(WebCore::overflowDefinesAutomaticScrollbar):
Split the logic in those 2 functions.

(WebCore::RenderLayer::updateScrollbarsAfterLayout):
Updated to use the require / can-have functions. Also added
an early return for list box parts as required by bug 69993.

(WebCore::RenderLayer::updateScrollbarsAfterStyleChange):
Added an early return for list box parts as required by bug 69993,
also removed some unneeded NULL-checks that were added for list box parts.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRoll out the DEPS roll (r124164) for now since it broke Chromium Mac builds.
rniwa@webkit.org [Tue, 31 Jul 2012 03:36:44 +0000 (03:36 +0000)]
Roll out the DEPS roll (r124164) for now since it broke Chromium Mac builds.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRevert r124153 and land the "right" build fix per ap's comment on the bug 92676.
rniwa@webkit.org [Tue, 31 Jul 2012 03:22:11 +0000 (03:22 +0000)]
Revert r124153 and land the "right" build fix per ap's comment on the bug 92676.

* MiniBrowser/win/BrowserView.cpp:
(BrowserView::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled DEPS.
rniwa@webkit.org [Tue, 31 Jul 2012 03:17:40 +0000 (03:17 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-30

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRename WebKit2.h to WebKit2_C.h
weinig@apple.com [Tue, 31 Jul 2012 03:15:51 +0000 (03:15 +0000)]
Rename WebKit2.h to WebKit2_C.h
https://bugs.webkit.org/show_bug.cgi?id=92704

Reviewed by Dan Bernstein.

Source/WebKit2:

* GNUmakefile.list.am:
* Target.pri:
* UIProcess/API/C/WebKit2_C.h: Renamed from Source/WebKit2/UIProcess/API/C/WebKit2.h.
* UIProcess/API/gtk/WebKitBackForwardListPrivate.h:
* UIProcess/API/gtk/WebKitPolicyDecisionPrivate.h:
* UIProcess/API/gtk/WebKitPrivate.h:
* UIProcess/API/gtk/WebKitSettingsPrivate.h:
* UIProcess/API/gtk/WebKitWebViewPrivate.h:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
* win/WebKit2Generated.make:
Update for changed header file name.

Tools:

* MiniBrowser/mac/MiniBrowser_Prefix.pch:
* MiniBrowser/win/BrowserView.h:
* TestWebKitAPI/config.h:
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
* WebKitTestRunner/WebKitTestRunnerPrefix.h:
* WebKitTestRunner/config.h:
Update for changed header file name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofillWithEmptyClients method should also initialize chromeClient with EmptyChromeClient
commit-queue@webkit.org [Tue, 31 Jul 2012 03:15:20 +0000 (03:15 +0000)]
fillWithEmptyClients method should also initialize chromeClient with EmptyChromeClient
https://bugs.webkit.org/show_bug.cgi?id=92703

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-07-30
Reviewed by Kent Tamura.

fillWithEmptyClients should also intialize PageClients.chromeClient with EmptyChromeClient
as its required for creating a Empty page and to minimize the exported symbols.

No new tests as no change in functionality.

* loader/EmptyClients.cpp:
(WebCore::fillWithEmptyClients):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Wrap ScrollbarLayerChromium in WebScrollbarLayer
enne@google.com [Tue, 31 Jul 2012 03:02:52 +0000 (03:02 +0000)]
[chromium] Wrap ScrollbarLayerChromium in WebScrollbarLayer
https://bugs.webkit.org/show_bug.cgi?id=91032

Reviewed by James Robinson.

Source/Platform:

Add WebScrollbarLayer class to the Platform API.

* Platform.gypi:
* chromium/public/WebScrollbarLayer.h: Added.
(WebCore):
(WebKit):
(WebScrollbarLayer):
(WebKit::WebScrollbarLayer::WebScrollbarLayer):
(WebKit::WebScrollbarLayer::~WebScrollbarLayer):
(WebKit::WebScrollbarLayer::operator=):

Source/WebCore:

Modify ScrollingCoordinatorChromium to operate on WebScrollbarLayer
instead of ScrollbarLayerChromium. This removes the dependency on
ScrollbarLayerChromium.

No change in functionality, so no new tests.

* page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::ScrollingCoordinatorPrivate::setScrollLayer):
(WebCore::ScrollingCoordinatorPrivate::setHorizontalScrollbarLayer):
(WebCore::ScrollingCoordinatorPrivate::setVerticalScrollbarLayer):
(ScrollingCoordinatorPrivate):
(WebCore::createScrollbarLayer):

Source/WebKit/chromium:

Add implementation of WebScrollbarLayer to the client API.

* WebKit.gyp:
* src/WebScrollbarLayer.cpp: Added.
(WebKit):
(WebKit::WebScrollbarLayer::setScrollLayer):
(WebKit::WebScrollbarLayer::create):
(WebKit::WebScrollbarLayer::WebScrollbarLayer):
(WebKit::WebScrollbarLayer::operator=):
(WebKit::WebScrollbarLayer::operator PassRefPtr<ScrollbarLayerChromium>):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAnother Qt build fix attempt after r124098.
rniwa@webkit.org [Tue, 31 Jul 2012 02:57:28 +0000 (02:57 +0000)]
Another Qt build fix attempt after r124098.
"interface" is a keyword. Don't use it.

* dom/GestureEvent.cpp:
(WebCore::GestureEvent::interfaceName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agochromium win compile broken after removing webkit.py
dpranke@chromium.org [Tue, 31 Jul 2012 02:56:50 +0000 (02:56 +0000)]
chromium win compile broken after removing webkit.py
https://bugs.webkit.org/show_bug.cgi?id=92549

Reviewed by Ryosuke Niwa.

Remove the stub file for webkit.py now that it's no longer
necessary.

* Scripts/webkitpy/layout_tests/port/webkit.py: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake QuotesData use a Vector of pairs
commit-queue@webkit.org [Tue, 31 Jul 2012 02:56:09 +0000 (02:56 +0000)]
Make QuotesData use a Vector of pairs
https://bugs.webkit.org/show_bug.cgi?id=92448

Patch by Elliott Sprehn <esprehn@gmail.com> on 2012-07-30
Reviewed by Julien Chaffraix.

Source/WebCore:

QuotesData::create returned an array of memory that contained in place instantiations
of a QuotesData and then String instances. This changes the code to use a Vector of
pairs making it safer and ensuring that quotes are always balanced. This also uses a
HashMap directly in the QuoteRenderer instead of building it on first access reducing
the amount of code needed for picking quotes by language.

Test: fast/css-generated-content/close-quote-negative-depth.html

* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList): Create pairs and use the new QuotesData API.
* rendering/RenderQuote.cpp:
(WebCore):
(WebCore::quotesDataLanguageMap): New function that returns the HashMap of languages.
(WebCore::basicQuotesData): Returns the simple form of quotes, " and '.
(WebCore::defaultQuotes): Changed to use the new map.
(WebCore::RenderQuote::styleDidChange):
(WebCore::RenderQuote::originalText): Changed to use the new getOpenQuote and getCloseQuote which ensure bounds checks.
* rendering/style/QuotesData.cpp:
(WebCore::QuotesData::create): Now returns a plain instance of QuotesData without the in place allocation.
(WebCore):
(WebCore::QuotesData::addPair): Adds an std::pair of strings ensuring quotes are always balanced.
(WebCore::QuotesData::getOpenQuote):
(WebCore::QuotesData::getCloseQuote):
(WebCore::QuotesData::equals): Renamed equals (added the s).
* rendering/style/QuotesData.h:
(WebCore::QuotesData::create):
(QuotesData):
(WebCore::QuotesData::QuotesData):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::setQuotes):
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::operator==):

LayoutTests:

Test that when quote depths go negative we do not output quotes. The expected result
is wrong right now because we output quotes in this case when we should not.

* fast/css-generated-content/close-quote-negative-depth-expected.html: Added.
* fast/css-generated-content/close-quote-negative-depth.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNode::replaceChild() can create bad DOM topology with MutationEvent
morrita@google.com [Tue, 31 Jul 2012 02:48:33 +0000 (02:48 +0000)]
Node::replaceChild() can create bad DOM topology with MutationEvent
https://bugs.webkit.org/show_bug.cgi?id=92619

Reviewed by Ryosuke Niwa.

Source/WebCore:

Node::replaceChild() calls insertBeforeCommon() after dispatching
a MutationEvent event for removeChild(). But insertBeforeCommon()
expects call sites to check the invariant and doesn't have
suffient check. So a MutationEvent handler can let some bad tree
topology to slip into insertBeforeCommon().

This change adds a guard for checking the invariant using
checkReplaceChild() between removeChild() and insertBeforeCommon().

Test: fast/events/mutation-during-replace-child.html

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::replaceChild): Added a guard.

LayoutTests:

* fast/events/mutation-during-replace-child-expected.txt: Added.
* fast/events/mutation-during-replace-child.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoQt Windows build fix attempt after r124098.
rniwa@webkit.org [Tue, 31 Jul 2012 02:46:58 +0000 (02:46 +0000)]
Qt Windows build fix attempt after r124098.

* dom/GestureEvent.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Enable web audio IPP for x86 chromium android
commit-queue@webkit.org [Tue, 31 Jul 2012 02:46:17 +0000 (02:46 +0000)]
[Chromium] Enable web audio IPP for x86 chromium android
https://bugs.webkit.org/show_bug.cgi?id=91973

Patch by Wei James <james.wei@intel.com> on 2012-07-30
Reviewed by Tony Chang.

Include the IPP libraries at link-time for Android builds when
compiling the Web Audio API with IPP support.

* WebCore.gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWindows build fix attempt after r124092.
rniwa@webkit.org [Tue, 31 Jul 2012 02:43:44 +0000 (02:43 +0000)]
Windows build fix attempt after r124092.

* MiniBrowser/win/BrowserView.cpp:
(BrowserView::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove erroneously committed debugging print call from a test.
rniwa@webkit.org [Tue, 31 Jul 2012 02:06:08 +0000 (02:06 +0000)]
Remove erroneously committed debugging print call from a test.

* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(test_run_generates_results_page):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Forms] Get rid of Element::isReadOnlyFormControl other than CSS related
yosin@chromium.org [Tue, 31 Jul 2012 02:01:24 +0000 (02:01 +0000)]
[Forms] Get rid of Element::isReadOnlyFormControl other than CSS related
https://bugs.webkit.org/show_bug.cgi?id=92612

Reviewed by Kent Tamura.

Source/WebCore:

This patch replaces Element::isReadOnlyFormControl() not related to
CSS selector matching to HTMLFormControlElement::readOnly() for
preparation of introducing Element::shouldMatchReadWriteSelector(), bug 92602.

No new tests. This patch doesn't change behavior.

* html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::defaultEventHandler): Changed isReadOnlyFormControl() to readOnly().
* html/shadow/TextControlInnerElements.cpp:
(WebCore::SearchFieldCancelButtonElement::defaultEventHandler): Changed isReadOnlyFormControl() to readOnly().
(WebCore::SpinButtonElement::defaultEventHandler): ditto.
(WebCore::SpinButtonElement::step): ditto.
(WebCore::InputFieldSpeechButtonElement::defaultEventHandler): ditto.
(WebCore::InputFieldSpeechButtonElement::setRecognitionResult): ditto.
* rendering/RenderTextControl.cpp:
(updateUserModifyProperty): Changed isReadOnlyFormControl() to readOnly().
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintSearchFieldCancelButton): Changed isReadOnlyFormControl() to readOnly().

Source/WebKit/blackberry:

This patch replaces Element::isReadOnlyFormControl() to
HTMLFormControlElement::readOnly() for preparation of introducing
Element::shouldMatchReadWriteSelector(), bug 92602.

* WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::isTextBasedContentEditableElement): Replaced isReadOnlyFormControl() by HTMLTextFormControlElement::readOnly().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix a popup position issue of fast/forms/date/calendar-picker-appearance.html
tkent@chromium.org [Tue, 31 Jul 2012 01:57:02 +0000 (01:57 +0000)]
Fix a popup position issue of fast/forms/date/calendar-picker-appearance.html
https://bugs.webkit.org/show_bug.cgi?id=92609

Reviewed by Hajime Morita.

Force to lay out the document before opening a popup.

* fast/forms/date/calendar-picker-appearance.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Rebaselines and test expectation updates.
pkasting@chromium.org [Tue, 31 Jul 2012 01:50:54 +0000 (01:50 +0000)]
[Chromium] Rebaselines and test expectation updates.
​https://bugs.webkit.org/show_bug.cgi?id=62754
​https://bugs.webkit.org/show_bug.cgi?id=63937
​https://bugs.webkit.org/show_bug.cgi?id=70298
​https://bugs.webkit.org/show_bug.cgi?id=74374
​https://bugs.webkit.org/show_bug.cgi?id=77368
​https://bugs.webkit.org/show_bug.cgi?id=79615
​https://bugs.webkit.org/show_bug.cgi?id=80531
https://bugs.webkit.org/show_bug.cgi?id=80879
​https://bugs.webkit.org/show_bug.cgi?id=81631
https://bugs.webkit.org/show_bug.cgi?id=83717
​https://bugs.webkit.org/show_bug.cgi?id=87880
http://crbug.com/10350
http://crbug.com/26291
http://crbug.com/47826
http://crbug.com/131189

Unreviewed, test updates.

Most of the baselines here are for
http://trac.webkit.org/changeset/119431 and
http://trac.webkit.org/changeset/119748 , as well as some changes to
antialiasing (generally to improve it) for which I couldn't find a CL;
when these were originally landed and new baselines committed, a
Chromium test expectation override file was masking the fact that the
tests here needed new baselines as well.

There is also a small number of other changes mixed in.

* platform/chromium-linux-x86/css1: Added.
* platform/chromium-linux-x86/css1/basic: Added.
* platform/chromium-linux-x86/css1/basic/class_as_selector-expected.png: Added.
* platform/chromium-linux-x86/css1/basic/id_as_selector-expected.png: Added.
* platform/chromium-linux-x86/css1/box_properties: Added.
* platform/chromium-linux-x86/css1/box_properties/border_bottom-expected.png: Added.
* platform/chromium-linux-x86/css1/box_properties/margin_left-expected.png: Added.
* platform/chromium-linux-x86/css1/box_properties/padding_right-expected.png: Added.
* platform/chromium-linux-x86/css1/pseudo: Added.
* platform/chromium-linux-x86/css1/pseudo/anchor-expected.png: Added.
* platform/chromium-linux-x86/editing/input: Added.
* platform/chromium-linux-x86/editing/input/reveal-caret-of-multiline-contenteditable-expected.png: Added.
* platform/chromium-linux-x86/editing/selection: Removed.
* platform/chromium-linux-x86/fast/backgrounds/repeat: Added.
* platform/chromium-linux-x86/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png: Added.
* platform/chromium-linux-x86/fast/block/float: Added.
* platform/chromium-linux-x86/fast/block/float/float-avoidance-expected.png: Added.
* platform/chromium-linux-x86/fast/canvas/image-pattern-rotate-expected.png: Added.
* platform/chromium-linux-x86/fast/events: Added.
* platform/chromium-linux-x86/fast/events/autoscroll-expected.png: Added.
* platform/chromium-linux-x86/fast/events/reveal-link-when-focused-expected.png: Added.
* platform/chromium-linux-x86/fast/forms/textarea: Added.
* platform/chromium-linux-x86/fast/forms/textarea/textarea-placeholder-paint-order-expected.png: Added.
* platform/chromium-linux-x86/fast/overflow: Added.
* platform/chromium-linux-x86/fast/overflow/overflow-with-local-background-attachment-expected.png: Added.
* platform/chromium-linux-x86/fast/selectors: Added.
* platform/chromium-linux-x86/fast/selectors/166-expected.png: Added.
* platform/chromium-linux-x86/fast/selectors/unqualified-hover-strict-expected.png: Added.
* platform/chromium-linux-x86/fast/selectors/unqualified-hover-strict-expected.txt: Added.
* platform/chromium-linux-x86/fast/transforms: Added.
* platform/chromium-linux-x86/fast/transforms/rotated-transform-affects-scrolling-1-expected.png: Added.
* platform/chromium-linux-x86/fonts: Added.
* platform/chromium-linux-x86/fonts/monospace-expected.png: Added.
* platform/chromium-linux-x86/http/tests/navigation: Added.
* platform/chromium-linux-x86/http/tests/navigation/javascriptlink-frames-expected.png: Added.
* platform/chromium-linux-x86/ietestcenter: Added.
* platform/chromium-linux-x86/ietestcenter/css3: Added.
* platform/chromium-linux-x86/ietestcenter/css3/bordersbackgrounds: Added.
* platform/chromium-linux-x86/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png: Added.
* platform/chromium-linux-x86/svg/as-image: Added.
* platform/chromium-linux-x86/svg/as-image/image-respects-pageScaleFactor-expected.png: Added.
* platform/chromium-linux-x86/svg/dom: Added.
* platform/chromium-linux-x86/svg/dom/SVGTransformList-basics-expected.png: Added.
* platform/chromium-linux-x86/svg/dom/css-transforms-expected.png: Added.
* platform/chromium-linux-x86/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Added.
* platform/chromium-linux-x86/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
* platform/chromium-linux-x86/svg/wicd: Added.
* platform/chromium-linux-x86/svg/wicd/test-rightsizing-b-expected.png: Added.
* platform/chromium-linux-x86/tables/mozilla/marvin: Added.
* platform/chromium-linux-x86/tables/mozilla/marvin/backgr_index-expected.png: Added.
* platform/chromium-linux-x86/tables/mozilla/marvin/backgr_layers-opacity-expected.png: Added.
* platform/chromium-linux-x86/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png: Added.
* platform/chromium-linux-x86/transforms: Added.
* platform/chromium-linux-x86/transforms/2d: Added.
* platform/chromium-linux-x86/transforms/2d/hindi-rotated-expected.png: Added.
* platform/chromium-linux-x86/transforms/2d/hindi-rotated-expected.txt: Added.
* platform/chromium-linux/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
* platform/chromium-linux/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png:
* platform/chromium-linux/css1/basic/class_as_selector-expected.png:
* platform/chromium-linux/css1/basic/id_as_selector-expected.png:
* platform/chromium-linux/css1/box_properties/border_bottom-expected.png:
* platform/chromium-linux/css1/box_properties/margin_left-expected.png:
* platform/chromium-linux/css1/box_properties/padding_right-expected.png:
* platform/chromium-linux/css1/pseudo/anchor-expected.png:
* platform/chromium-linux/editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
* platform/chromium-linux/editing/selection/iframe-expected.png:
* platform/chromium-linux/editing/selection/select-all-001-expected.png:
* platform/chromium-linux/editing/selection/select-all-002-expected.png:
* platform/chromium-linux/fast/backgrounds/background-leakage-transforms-expected.png:
* platform/chromium-linux/fast/block/float/float-avoidance-expected.png:
* platform/chromium-linux/fast/borders/border-radius-valid-border-clipping-expected.png:
* platform/chromium-linux/fast/box-shadow/basic-shadows-expected.png:
* platform/chromium-linux/fast/canvas/image-object-in-canvas-expected.png:
* platform/chromium-linux/fast/canvas/image-pattern-rotate-expected.png:
* platform/chromium-linux/fast/events/autoscroll-expected.png:
* platform/chromium-linux/fast/events/reveal-link-when-focused-expected.png:
* platform/chromium-linux/fast/forms/fieldset-align-expected.png:
* platform/chromium-linux/fast/forms/input-appearance-selection-expected.png:
* platform/chromium-linux/fast/forms/input-placeholder-paint-order-expected.png:
* platform/chromium-linux/fast/forms/input-table-expected.png:
* platform/chromium-linux/fast/forms/listbox-bidi-align-expected.png:
* platform/chromium-linux/fast/forms/placeholder-position-expected.png:
* platform/chromium-linux/fast/forms/select-overflow-scroll-expected.png:
* platform/chromium-linux/fast/forms/select-overflow-scroll-inherited-expected.png:
* platform/chromium-linux/fast/forms/textarea-scrollbar-expected.png:
* platform/chromium-linux/fast/forms/textarea/textarea-placeholder-paint-order-expected.png:
* platform/chromium-linux/fast/html/details-position-expected.png:
* platform/chromium-linux/fast/html/details-writing-mode-expected.png:
* platform/chromium-linux/fast/overflow/overflow-update-transform-expected.png:
* platform/chromium-linux/fast/overflow/overflow-with-local-background-attachment-expected.png:
* platform/chromium-linux/fast/replaced/width100percent-radio-expected.png: Added.
* platform/chromium-linux/fast/selectors/166-expected.png:
* platform/chromium-linux/fast/selectors/unqualified-hover-strict-expected.png:
* platform/chromium-linux/fast/selectors/unqualified-hover-strict-expected.txt: Added.
* platform/chromium-linux/fast/transforms/rotated-transform-affects-scrolling-1-expected.png:
* platform/chromium-linux/fonts/monospace-expected.png:
* platform/chromium-linux/http/tests/navigation/javascriptlink-frames-expected.png:
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
* platform/chromium-linux/svg/as-image/image-respects-pageScaleFactor-expected.png:
* platform/chromium-linux/svg/custom/getscreenctm-in-scrollable-div-area-expected.png:
* platform/chromium-linux/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png:
* platform/chromium-linux/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png:
* platform/chromium-linux/svg/custom/pattern-rotate-expected.png:
* platform/chromium-linux/svg/dom/SVGTransformList-basics-expected.png:
* platform/chromium-linux/svg/dom/css-transforms-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png:
* platform/chromium-linux/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png:
* platform/chromium-linux/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png:
* platform/chromium-linux/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png:
* platform/chromium-linux/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png:
* platform/chromium-linux/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
* platform/chromium-linux/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
* platform/chromium-linux/svg/wicd/test-rightsizing-b-expected.png:
* platform/chromium-linux/svg/zoom/page/absolute-sized-document-scrollbars-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-mask-with-percentages-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug2479-3-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/backgr_index-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
* platform/chromium-linux/transforms/2d/hindi-rotated-expected.png:
* platform/chromium-linux/transforms/2d/hindi-rotated-expected.txt:
* platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
* platform/chromium-mac-snowleopard/css2.1/20110323/replaced-intrinsic-ratio-001-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/canvas/image-object-in-canvas-expected.png:
* platform/chromium-mac-snowleopard/fast/canvas/image-pattern-rotate-expected.png:
* platform/chromium-mac-snowleopard/svg/as-border-image: Removed.
* platform/chromium-mac-snowleopard/svg/as-border-image/svg-as-border-image-2-expected.png: Removed.
* platform/chromium-mac-snowleopard/svg/as-border-image/svg-as-border-image-expected.png: Removed.
* platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/pattern-rotate-expected.png:
* platform/chromium-mac-snowleopard/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
* platform/chromium-mac-snowleopard/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/chromium-mac-snowleopard/transforms/2d/hindi-rotated-expected.png:
* platform/chromium-mac/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
* platform/chromium-mac/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png:
* platform/chromium-mac/fast/borders/border-radius-valid-border-clipping-expected.png:
* platform/chromium-mac/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png:
* platform/chromium-mac/fast/canvas/image-object-in-canvas-expected.png:
* platform/chromium-mac/fast/canvas/image-pattern-rotate-expected.png:
* platform/chromium-mac/svg/as-border-image/svg-as-border-image-2-expected.png:
* platform/chromium-mac/svg/as-border-image/svg-as-border-image-expected.png:
* platform/chromium-mac/svg/custom/non-scaling-stroke-expected.png:
* platform/chromium-mac/svg/custom/pattern-rotate-expected.png:
* platform/chromium-mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
* platform/chromium-mac/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/chromium-mac/transforms/2d/hindi-rotated-expected.png: Added.
* platform/chromium-mac/transforms/2d/hindi-rotated-expected.txt: Added.
* platform/chromium-win-xp/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Added.
* platform/chromium-win-xp/css1: Added.
* platform/chromium-win-xp/css1/basic: Added.
* platform/chromium-win-xp/css1/basic/class_as_selector-expected.png: Added.
* platform/chromium-win-xp/css1/basic/containment-expected.png: Added.
* platform/chromium-win-xp/css1/basic/id_as_selector-expected.png: Added.
* platform/chromium-win-xp/css1/box_properties: Added.
* platform/chromium-win-xp/css1/box_properties/border_bottom-expected.png: Added.
* platform/chromium-win-xp/css1/box_properties/border_left-expected.png: Added.
* platform/chromium-win-xp/css1/box_properties/border_right_inline-expected.png: Added.
* platform/chromium-win-xp/css1/box_properties/border_top-expected.png: Added.
* platform/chromium-win-xp/css1/box_properties/clear_float-expected.png: Added.
* platform/chromium-win-xp/css1/box_properties/margin_left-expected.png: Added.
* platform/chromium-win-xp/css1/box_properties/margin_right-expected.png: Added.
* platform/chromium-win-xp/css1/box_properties/padding_left-expected.png: Added.
* platform/chromium-win-xp/css1/box_properties/padding_right-expected.png: Added.
* platform/chromium-win-xp/css1/cascade: Added.
* platform/chromium-win-xp/css1/cascade/cascade_order-expected.png: Added.
* platform/chromium-win-xp/css1/classification: Added.
* platform/chromium-win-xp/css1/classification/list_style_type-expected.png: Added.
* platform/chromium-win-xp/css1/pseudo: Added.
* platform/chromium-win-xp/css1/pseudo/anchor-expected.png: Added.
* platform/chromium-win-xp/css3/selectors3: Added.
* platform/chromium-win-xp/css3/selectors3/html: Added.
* platform/chromium-win-xp/css3/selectors3/html/css3-modsel-161-expected.png: Added.
* platform/chromium-win-xp/css3/selectors3/xhtml: Added.
* platform/chromium-win-xp/css3/selectors3/xhtml/css3-modsel-161-expected.png: Added.
* platform/chromium-win-xp/css3/selectors3/xml: Added.
* platform/chromium-win-xp/css3/selectors3/xml/css3-modsel-161-expected.png: Added.
* platform/chromium-win-xp/editing/input: Added.
* platform/chromium-win-xp/editing/input/caret-at-the-edge-of-input-expected.png: Added.
* platform/chromium-win-xp/editing/input/reveal-caret-of-multiline-contenteditable-expected.png: Added.
* platform/chromium-win-xp/editing/input/reveal-caret-of-multiline-input-expected.png: Added.
* platform/chromium-win-xp/fast/backgrounds/repeat: Removed.
* platform/chromium-win-xp/fast/block/float: Added.
* platform/chromium-win-xp/fast/block/float/float-avoidance-expected.png: Added.
* platform/chromium-win-xp/fast/block/margin-collapse: Added.
* platform/chromium-win-xp/fast/block/margin-collapse/103-expected.png: Added.
* platform/chromium-win-xp/fast/events: Added.
* platform/chromium-win-xp/fast/events/autoscroll-expected.png: Added.
* platform/chromium-win-xp/fast/events/context-no-deselect-expected.png: Added.
* platform/chromium-win-xp/fast/events/reveal-link-when-focused-expected.png: Added.
* platform/chromium-win-xp/fast/forms/date: Added.
* platform/chromium-win-xp/fast/forms/date/date-appearance-expected.png: Added.
* platform/chromium-win-xp/fast/forms/select: Added.
* platform/chromium-win-xp/fast/forms/select/optgroup-rendering-expected.png: Added.
* platform/chromium-win-xp/fast/forms/textarea: Added.
* platform/chromium-win-xp/fast/forms/textarea/textarea-placeholder-paint-order-expected.png: Added.
* platform/chromium-win-xp/fast/frames: Added.
* platform/chromium-win-xp/fast/frames/take-focus-from-iframe-expected.png: Added.
* platform/chromium-win-xp/fast/gradients: Added.
* platform/chromium-win-xp/fast/gradients/background-clipped-expected.png: Added.
* platform/chromium-win-xp/fast/html: Removed.
* platform/chromium-win-xp/fast/html/details-writing-mode-expected.png: Removed.
* platform/chromium-win-xp/fast/invalid: Added.
* platform/chromium-win-xp/fast/invalid/014-expected.png: Added.
* platform/chromium-win-xp/fast/layers: Added.
* platform/chromium-win-xp/fast/layers/scroll-with-transform-composited-layer-expected.png: Added.
* platform/chromium-win-xp/fast/layers/scroll-with-transform-layer-expected.png: Added.
* platform/chromium-win-xp/fast/lists: Added.
* platform/chromium-win-xp/fast/lists/008-expected.png: Added.
* platform/chromium-win-xp/fast/lists/008-vertical-expected.png: Added.
* platform/chromium-win-xp/fast/lists/dynamic-marker-crash-expected.png: Added.
* platform/chromium-win-xp/fast/overflow: Added.
* platform/chromium-win-xp/fast/overflow/overflow-rtl-expected.png: Added.
* platform/chromium-win-xp/fast/overflow/overflow-rtl-vertical-expected.png: Added.
* platform/chromium-win-xp/fast/selectors: Added.
* platform/chromium-win-xp/fast/selectors/166-expected.png: Added.
* platform/chromium-win-xp/fast/selectors/unqualified-hover-strict-expected.png: Added.
* platform/chromium-win-xp/fast/selectors/unqualified-hover-strict-expected.txt: Added.
* platform/chromium-win-xp/fast/speech: Added.
* platform/chromium-win-xp/fast/speech/input-appearance-numberandspeech-expected.png: Added.
* platform/chromium-win-xp/fast/speech/input-appearance-searchandspeech-expected.png: Added.
* platform/chromium-win-xp/fast/speech/input-appearance-speechbutton-expected.png: Added.
* platform/chromium-win-xp/fast/speech/speech-bidi-rendering-expected.png: Added.
* platform/chromium-win-xp/fast/text/drawBidiText-expected.png:
* platform/chromium-win-xp/fast/transforms: Added.
* platform/chromium-win-xp/fast/transforms/rotated-transform-affects-scrolling-1-expected.png: Added.
* platform/chromium-win-xp/fast/transforms/rotated-transform-affects-scrolling-2-expected.png: Added.
* platform/chromium-win-xp/fast/transforms/transformed-focused-text-input-expected.png: Added.
* platform/chromium-win-xp/fonts: Added.
* platform/chromium-win-xp/fonts/monospace-expected.png: Added.
* platform/chromium-win-xp/http/tests/misc: Added.
* platform/chromium-win-xp/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added.
* platform/chromium-win-xp/http/tests/navigation: Added.
* platform/chromium-win-xp/http/tests/navigation/javascriptlink-frames-expected.png: Added.
* platform/chromium-win-xp/plugins: Added.
* platform/chromium-win-xp/plugins/mouse-click-plugin-clears-selection-expected.png: Added.
* platform/chromium-win-xp/svg/as-image/image-respects-pageScaleFactor-expected.png: Removed.
* platform/chromium-win-xp/svg/dom: Removed.
* platform/chromium-win-xp/svg/hixie/mixed: Added.
* platform/chromium-win-xp/svg/hixie/mixed/003-expected.png: Added.
* platform/chromium-win-xp/svg/in-html: Added.
* platform/chromium-win-xp/svg/in-html/circle-expected.png: Added.
* platform/chromium-win-xp/svg/transforms: Added.
* platform/chromium-win-xp/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Added.
* platform/chromium-win-xp/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Added.
* platform/chromium-win-xp/svg/wicd/test-rightsizing-b-expected.png:
* platform/chromium-win-xp/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
* platform/chromium-win-xp/tables/mozilla/core: Added.
* platform/chromium-win-xp/tables/mozilla/core/margins-expected.png: Added.
* platform/chromium-win-xp/tables/mozilla/dom: Added.
* platform/chromium-win-xp/tables/mozilla/dom/tableDom-expected.png: Added.
* platform/chromium-win-xp/tables/mozilla/other: Added.
* platform/chromium-win-xp/tables/mozilla/other/move_row-expected.png: Added.
* platform/chromium-win-xp/tables/mozilla_expected_failures: Added.
* platform/chromium-win-xp/tables/mozilla_expected_failures/bugs: Added.
* platform/chromium-win-xp/tables/mozilla_expected_failures/bugs/bug1725-expected.png: Added.
* platform/chromium-win-xp/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png: Added.
* platform/chromium-win-xp/tables/mozilla_expected_failures/marvin: Added.
* platform/chromium-win-xp/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png: Added.
* platform/chromium-win-xp/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.png: Added.
* platform/chromium-win-xp/transforms/2d/hindi-rotated-expected.png:
* platform/chromium-win/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
* platform/chromium-win/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png:
* platform/chromium-win/css1/basic/class_as_selector-expected.png:
* platform/chromium-win/css1/basic/containment-expected.png:
* platform/chromium-win/css1/basic/id_as_selector-expected.png:
* platform/chromium-win/css1/box_properties/border_bottom-expected.png:
* platform/chromium-win/css1/box_properties/border_left-expected.png:
* platform/chromium-win/css1/box_properties/border_right_inline-expected.png:
* platform/chromium-win/css1/box_properties/border_top-expected.png:
* platform/chromium-win/css1/box_properties/clear_float-expected.png:
* platform/chromium-win/css1/box_properties/margin_left-expected.png:
* platform/chromium-win/css1/box_properties/margin_right-expected.png:
* platform/chromium-win/css1/box_properties/padding_left-expected.png:
* platform/chromium-win/css1/box_properties/padding_right-expected.png:
* platform/chromium-win/css1/cascade/cascade_order-expected.png:
* platform/chromium-win/css1/classification/list_style_type-expected.png:
* platform/chromium-win/css1/pseudo/anchor-expected.png:
* platform/chromium-win/css2.1/20110323/replaced-intrinsic-ratio-001-expected.png:
* platform/chromium-win/css3/selectors3/html/css3-modsel-161-expected.png:
* platform/chromium-win/css3/selectors3/xhtml/css3-modsel-161-expected.png:
* platform/chromium-win/css3/selectors3/xml/css3-modsel-161-expected.png:
* platform/chromium-win/editing/deleting/delete-after-span-ws-001-expected.png:
* platform/chromium-win/editing/deleting/delete-after-span-ws-002-expected.png:
* platform/chromium-win/editing/deleting/delete-after-span-ws-003-expected.png:
* platform/chromium-win/editing/deleting/delete-line-end-ws-001-expected.png:
* platform/chromium-win/editing/deleting/delete-line-end-ws-002-expected.png:
* platform/chromium-win/editing/input/caret-at-the-edge-of-input-expected.png:
* platform/chromium-win/editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
* platform/chromium-win/editing/input/reveal-caret-of-multiline-input-expected.png:
* platform/chromium-win/editing/inserting/4960120-1-expected.png:
* platform/chromium-win/editing/inserting/before-after-input-element-expected.png:
* platform/chromium-win/editing/pasteboard/4806874-expected.png:
* platform/chromium-win/editing/pasteboard/4944770-1-expected.png:
* platform/chromium-win/editing/pasteboard/4944770-2-expected.png:
* platform/chromium-win/editing/pasteboard/drop-text-without-selection-expected.png:
* platform/chromium-win/editing/pasteboard/input-field-1-expected.png:
* platform/chromium-win/editing/pasteboard/pasting-tabs-expected.png:
* platform/chromium-win/editing/selection/3690703-2-expected.png:
* platform/chromium-win/editing/selection/3690703-expected.png:
* platform/chromium-win/editing/selection/3690719-expected.png:
* platform/chromium-win/editing/selection/4397952-expected.png:
* platform/chromium-win/editing/selection/4895428-3-expected.png:
* platform/chromium-win/editing/selection/4975120-expected.png:
* platform/chromium-win/editing/selection/caret-before-select-expected.png:
* platform/chromium-win/editing/selection/drag-select-1-expected.png:
* platform/chromium-win/editing/selection/iframe-expected.png:
* platform/chromium-win/editing/selection/replaced-boundaries-3-expected.png:
* platform/chromium-win/editing/selection/select-across-readonly-input-1-expected.png:
* platform/chromium-win/editing/selection/select-across-readonly-input-2-expected.png:
* platform/chromium-win/editing/selection/select-across-readonly-input-3-expected.png:
* platform/chromium-win/editing/selection/select-across-readonly-input-4-expected.png:
* platform/chromium-win/editing/selection/select-across-readonly-input-5-expected.png:
* platform/chromium-win/editing/selection/select-all-001-expected.png:
* platform/chromium-win/editing/selection/select-all-002-expected.png:
* platform/chromium-win/editing/selection/select-box-expected.png:
* platform/chromium-win/editing/selection/select-element-paragraph-boundary-expected.png:
* platform/chromium-win/editing/selection/unrendered-001-expected.png:
* platform/chromium-win/editing/selection/unrendered-002-expected.png:
* platform/chromium-win/editing/selection/unrendered-003-expected.png:
* platform/chromium-win/editing/selection/unrendered-004-expected.png:
* platform/chromium-win/editing/selection/unrendered-005-expected.png:
* platform/chromium-win/fast/backgrounds/background-inherit-color-bug-expected.png:
* platform/chromium-win/fast/backgrounds/background-leakage-transforms-expected.png:
* platform/chromium-win/fast/block/float/float-avoidance-expected.png:
* platform/chromium-win/fast/block/margin-collapse/103-expected.png:
* platform/chromium-win/fast/borders/border-radius-valid-border-clipping-expected.png:
* platform/chromium-win/fast/borders/mixed-border-styles-radius2-expected.png:
* platform/chromium-win/fast/box-shadow/basic-shadows-expected.png:
* platform/chromium-win/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png:
* platform/chromium-win/fast/canvas/canvas-incremental-repaint-expected.png:
* platform/chromium-win/fast/canvas/canvas-text-alignment-expected.png:
* platform/chromium-win/fast/canvas/image-object-in-canvas-expected.png:
* platform/chromium-win/fast/canvas/image-pattern-rotate-expected.png:
* platform/chromium-win/fast/css/input-search-padding-expected.png:
* platform/chromium-win/fast/css/line-height-expected.png:
* platform/chromium-win/fast/css/nested-rounded-corners-expected.png:
* platform/chromium-win/fast/css/text-input-with-webkit-border-radius-expected.png:
* platform/chromium-win/fast/css/text-overflow-input-expected.png:
* platform/chromium-win/fast/css/text-transform-select-expected.png:
* platform/chromium-win/fast/dom/52776-expected.png:
* platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png:
* platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png:
* platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
* platform/chromium-win/fast/dom/focus-contenteditable-expected.png:
* platform/chromium-win/fast/dom/isindex-001-expected.png:
* platform/chromium-win/fast/dom/isindex-002-expected.png:
* platform/chromium-win/fast/events/autoscroll-expected.png:
* platform/chromium-win/fast/events/context-no-deselect-expected.png:
* platform/chromium-win/fast/events/reveal-link-when-focused-expected.png:
* platform/chromium-win/fast/forms/001-expected.png:
* platform/chromium-win/fast/forms/003-expected.png:
* platform/chromium-win/fast/forms/004-expected.png:
* platform/chromium-win/fast/forms/HTMLOptionElement_label01-expected.png:
* platform/chromium-win/fast/forms/HTMLOptionElement_label02-expected.png:
* platform/chromium-win/fast/forms/HTMLOptionElement_label03-expected.png:
* platform/chromium-win/fast/forms/HTMLOptionElement_label04-expected.png:
* platform/chromium-win/fast/forms/HTMLOptionElement_label05-expected.png:
* platform/chromium-win/fast/forms/HTMLOptionElement_label06-expected.png:
* platform/chromium-win/fast/forms/HTMLOptionElement_label07-expected.png:
* platform/chromium-win/fast/forms/basic-buttons-expected.png:
* platform/chromium-win/fast/forms/basic-inputs-expected.png:
* platform/chromium-win/fast/forms/basic-selects-expected.png:
* platform/chromium-win/fast/forms/button-generated-content-expected.png:
* platform/chromium-win/fast/forms/button-inner-block-reuse-expected.png:
* platform/chromium-win/fast/forms/control-clip-overflow-expected.png:
* platform/chromium-win/fast/forms/control-restrict-line-height-expected.png:
* platform/chromium-win/fast/forms/date/date-appearance-expected.png:
* platform/chromium-win/fast/forms/disabled-select-change-index-expected.png:
* platform/chromium-win/fast/forms/encoding-test-expected.png:
* platform/chromium-win/fast/forms/fieldset-align-expected.png:
* platform/chromium-win/fast/forms/floating-textfield-relayout-expected.png:
* platform/chromium-win/fast/forms/form-element-geometry-expected.png:
* platform/chromium-win/fast/forms/input-align-expected.png:
* platform/chromium-win/fast/forms/input-appearance-default-bkcolor-expected.png:
* platform/chromium-win/fast/forms/input-appearance-disabled-expected.png:
* platform/chromium-win/fast/forms/input-appearance-focus-expected.png:
* platform/chromium-win/fast/forms/input-appearance-height-expected.png:
* platform/chromium-win/fast/forms/input-appearance-preventDefault-expected.png:
* platform/chromium-win/fast/forms/input-appearance-readonly-expected.png:
* platform/chromium-win/fast/forms/input-appearance-selection-expected.png:
* platform/chromium-win/fast/forms/input-appearance-visibility-expected.png:
* platform/chromium-win/fast/forms/input-appearance-width-expected.png:
* platform/chromium-win/fast/forms/input-baseline-expected.png:
* platform/chromium-win/fast/forms/input-disabled-color-expected.png:
* platform/chromium-win/fast/forms/input-double-click-selection-gap-bug-expected.png:
* platform/chromium-win/fast/forms/input-field-text-truncated-expected.png:
* platform/chromium-win/fast/forms/input-placeholder-paint-order-expected.png:
* platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.png:
* platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.png:
* platform/chromium-win/fast/forms/input-readonly-autoscroll-expected.png:
* platform/chromium-win/fast/forms/input-readonly-dimmed-expected.png:
* platform/chromium-win/fast/forms/input-readonly-empty-expected.png:
* platform/chromium-win/fast/forms/input-spaces-expected.png:
* platform/chromium-win/fast/forms/input-table-expected.png:
* platform/chromium-win/fast/forms/input-text-click-inside-expected.png:
* platform/chromium-win/fast/forms/input-text-click-outside-expected.png:
* platform/chromium-win/fast/forms/input-text-double-click-expected.png:
* platform/chromium-win/fast/forms/input-text-option-delete-expected.png:
* platform/chromium-win/fast/forms/input-text-scroll-left-on-blur-expected.png:
* platform/chromium-win/fast/forms/input-text-self-emptying-click-expected.png:
* platform/chromium-win/fast/forms/input-text-word-wrap-expected.png:
* platform/chromium-win/fast/forms/input-type-text-min-width-expected.png:
* platform/chromium-win/fast/forms/input-value-expected.png:
* platform/chromium-win/fast/forms/input-width-expected.png:
* platform/chromium-win/fast/forms/listbox-bidi-align-expected.png:
* platform/chromium-win/fast/forms/listbox-clip-expected.png:
* platform/chromium-win/fast/forms/listbox-scrollbar-incremental-load-expected.png:
* platform/chromium-win/fast/forms/listbox-width-change-expected.png:
* platform/chromium-win/fast/forms/menulist-deselect-update-expected.png:
* platform/chromium-win/fast/forms/menulist-narrow-width-expected.png:
* platform/chromium-win/fast/forms/menulist-no-overflow-expected.png:
* platform/chromium-win/fast/forms/menulist-restrict-line-height-expected.png:
* platform/chromium-win/fast/forms/menulist-separator-painting-expected.png:
* platform/chromium-win/fast/forms/menulist-style-color-expected.png:
* platform/chromium-win/fast/forms/menulist-width-change-expected.png:
* platform/chromium-win/fast/forms/minWidthPercent-expected.png:
* platform/chromium-win/fast/forms/option-script-expected.png:
* platform/chromium-win/fast/forms/option-strip-whitespace-expected.png:
* platform/chromium-win/fast/forms/option-text-clip-expected.png:
* platform/chromium-win/fast/forms/placeholder-position-expected.png:
* platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.png:
* platform/chromium-win/fast/forms/plaintext-mode-2-expected.png:
* platform/chromium-win/fast/forms/search-cancel-button-style-sharing-expected.png:
* platform/chromium-win/fast/forms/search-display-none-cancel-button-expected.png:
* platform/chromium-win/fast/forms/search-rtl-expected.png:
* platform/chromium-win/fast/forms/searchfield-heights-expected.png:
* platform/chromium-win/fast/forms/select-align-expected.png:
* platform/chromium-win/fast/forms/select-background-none-expected.png:
* platform/chromium-win/fast/forms/select-baseline-expected.png:
* platform/chromium-win/fast/forms/select-block-background-expected.png:
* platform/chromium-win/fast/forms/select-change-listbox-size-expected.png:
* platform/chromium-win/fast/forms/select-change-listbox-to-popup-expected.png:
* platform/chromium-win/fast/forms/select-change-popup-to-listbox-expected.png:
* platform/chromium-win/fast/forms/select-dirty-parent-pref-widths-expected.png:
* platform/chromium-win/fast/forms/select-disabled-appearance-expected.png:
* platform/chromium-win/fast/forms/select-initial-position-expected.png:
* platform/chromium-win/fast/forms/select-list-box-with-height-expected.png:
* platform/chromium-win/fast/forms/select-listbox-multiple-no-focusring-expected.png:
* platform/chromium-win/fast/forms/select-overflow-scroll-expected.png:
* platform/chromium-win/fast/forms/select-overflow-scroll-inherited-expected.png:
* platform/chromium-win/fast/forms/select-selected-expected.png:
* platform/chromium-win/fast/forms/select-size-expected.png:
* platform/chromium-win/fast/forms/select-style-expected.png:
* platform/chromium-win/fast/forms/select-visual-hebrew-expected.png:
* platform/chromium-win/fast/forms/select-writing-direction-natural-expected.png:
* platform/chromium-win/fast/forms/select/optgroup-rendering-expected.png:
* platform/chromium-win/fast/forms/selectlist-minsize-expected.png:
* platform/chromium-win/fast/forms/stuff-on-my-optgroup-expected.png:
* platform/chromium-win/fast/forms/tabbing-input-iframe-expected.png:
* platform/chromium-win/fast/forms/text-style-color-expected.png:
* platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.png:
* platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.png:
* platform/chromium-win/fast/forms/textarea-scrollbar-expected.png:
* platform/chromium-win/fast/forms/textarea-scrolled-type-expected.png:
* platform/chromium-win/fast/forms/textarea/textarea-placeholder-paint-order-expected.png:
* platform/chromium-win/fast/forms/textfield-focus-ring-expected.png:
* platform/chromium-win/fast/forms/textfield-overflow-expected.png:
* platform/chromium-win/fast/forms/validation-message-appearance-expected.png:
* platform/chromium-win/fast/forms/visual-hebrew-text-field-expected.png:
* platform/chromium-win/fast/frames/take-focus-from-iframe-expected.png:
* platform/chromium-win/fast/gradients/background-clipped-expected.png:
* platform/chromium-win/fast/html/details-no-summary4-expected.png:
* platform/chromium-win/fast/html/details-open-javascript-expected.png:
* platform/chromium-win/fast/html/details-open2-expected.png:
* platform/chromium-win/fast/html/details-open4-expected.png:
* platform/chromium-win/fast/html/details-position-expected.png:
* platform/chromium-win/fast/html/details-replace-summary-child-expected.png:
* platform/chromium-win/fast/html/details-replace-text-expected.png:
* platform/chromium-win/fast/html/details-writing-mode-expected.png:
* platform/chromium-win/fast/html/keygen-expected.png:
* platform/chromium-win/fast/invalid/014-expected.png:
* platform/chromium-win/fast/layers/scroll-with-transform-composited-layer-expected.png:
* platform/chromium-win/fast/layers/scroll-with-transform-layer-expected.png:
* platform/chromium-win/fast/lists/008-expected.png:
* platform/chromium-win/fast/lists/008-vertical-expected.png:
* platform/chromium-win/fast/lists/dynamic-marker-crash-expected.png:
* platform/chromium-win/fast/overflow/overflow-rtl-expected.png:
* platform/chromium-win/fast/overflow/overflow-rtl-vertical-expected.png:
* platform/chromium-win/fast/overflow/overflow-update-transform-expected.png:
* platform/chromium-win/fast/overflow/overflow-with-local-background-attachment-expected.png:
* platform/chromium-win/fast/parser/document-write-option-expected.png:
* platform/chromium-win/fast/repaint/control-clip-expected.png:
* platform/chromium-win/fast/repaint/moving-shadow-on-container-expected.png:
* platform/chromium-win/fast/repaint/moving-shadow-on-path-expected.png:
* platform/chromium-win/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
* platform/chromium-win/fast/repaint/select-option-background-color-expected.png:
* platform/chromium-win/fast/repaint/subtree-root-skipped-expected.png:
* platform/chromium-win/fast/repaint/transform-absolute-in-positioned-container-expected.png:
* platform/chromium-win/fast/replaced/replaced-breaking-expected.png:
* platform/chromium-win/fast/replaced/replaced-breaking-mixture-expected.png:
* platform/chromium-win/fast/replaced/three-selects-break-expected.png:
* platform/chromium-win/fast/replaced/width100percent-searchfield-expected.png:
* platform/chromium-win/fast/replaced/width100percent-textfield-expected.png:
* platform/chromium-win/fast/selectors/166-expected.png:
* platform/chromium-win/fast/selectors/unqualified-hover-strict-expected.png:
* platform/chromium-win/fast/selectors/unqualified-hover-strict-expected.txt:
* platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.png:
* platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.png:
* platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.png:
* platform/chromium-win/fast/speech/speech-bidi-rendering-expected.png:
* platform/chromium-win/fast/table/003-expected.png:
* platform/chromium-win/fast/table/colspanMinWidth-expected.png:
* platform/chromium-win/fast/table/spanOverlapRepaint-expected.png:
* platform/chromium-win/fast/table/text-field-baseline-expected.png:
* platform/chromium-win/fast/text/drawBidiText-expected.png:
* platform/chromium-win/fast/text/international/bidi-listbox-atsui-expected.png:
* platform/chromium-win/fast/text/international/bidi-listbox-expected.png:
* platform/chromium-win/fast/text/international/bidi-menulist-expected.png:
* platform/chromium-win/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png:
* platform/chromium-win/fast/text/textIteratorNilRenderer-expected.png:
* platform/chromium-win/fast/text/updateNewFont-expected.png:
* platform/chromium-win/fast/transforms/rotated-transform-affects-scrolling-1-expected.png:
* platform/chromium-win/fast/transforms/rotated-transform-affects-scrolling-2-expected.png:
* platform/chromium-win/fast/transforms/transformed-focused-text-input-expected.png:
* platform/chromium-win/fast/writing-mode/border-radius-clipping-vertical-lr-expected.png:
* platform/chromium-win/fast/writing-mode/box-shadow-vertical-lr-expected.png:
* platform/chromium-win/fast/writing-mode/box-shadow-vertical-rl-expected.png:
* platform/chromium-win/fonts/monospace-expected.png:
* platform/chromium-win/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png:
* platform/chromium-win/http/tests/navigation/javascriptlink-frames-expected.png:
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
* platform/chromium-win/plugins/mouse-click-plugin-clears-selection-expected.png:
* platform/chromium-win/svg/as-image/image-respects-pageScaleFactor-expected.png:
* platform/chromium-win/svg/css/composite-shadow-example-expected.png:
* platform/chromium-win/svg/css/composite-shadow-with-opacity-expected.png:
* platform/chromium-win/svg/css/stars-with-shadow-expected.png:
* platform/chromium-win/svg/custom/foreign-object-skew-expected.png:
* platform/chromium-win/svg/custom/getscreenctm-in-scrollable-div-area-expected.png:
* platform/chromium-win/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png:
* platform/chromium-win/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png:
* platform/chromium-win/svg/custom/inline-svg-in-xhtml-expected.png:
* platform/chromium-win/svg/custom/non-scaling-stroke-expected.png:
* platform/chromium-win/svg/custom/object-sizing-no-width-height-expected.png:
* platform/chromium-win/svg/custom/pattern-rotate-expected.png:
* platform/chromium-win/svg/dom/SVGTransformList-basics-expected.png:
* platform/chromium-win/svg/dom/css-transforms-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png:
* platform/chromium-win/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png:
* platform/chromium-win/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png:
* platform/chromium-win/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png:
* platform/chromium-win/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png:
* platform/chromium-win/svg/hixie/mixed/003-expected.png:
* platform/chromium-win/svg/in-html/circle-expected.png:
* platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
* platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
* platform/chromium-win/svg/wicd/rightsizing-grid-expected.png:
* platform/chromium-win/svg/wicd/test-rightsizing-b-expected.png:
* platform/chromium-win/svg/wicd/test-scalable-background-image1-expected.png:
* platform/chromium-win/svg/zoom/page/absolute-sized-document-scrollbars-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-mask-with-percentages-expected.png:
* platform/chromium-win/tables/mozilla/bugs/45621-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug1188-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug12384-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug18359-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug24200-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug2479-2-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug2479-3-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug28928-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug29326-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug30692-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug33855-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug4382-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug44505-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug4527-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug46368-1-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug46368-2-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug51037-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug55545-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug59354-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug7342-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug92647-2-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug96334-expected.png:
* platform/chromium-win/tables/mozilla/core/margins-expected.png:
* platform/chromium-win/tables/mozilla/dom/tableDom-expected.png:
* platform/chromium-win/tables/mozilla/marvin/backgr_index-expected.png:
* platform/chromium-win/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
* platform/chromium-win/tables/mozilla/other/move_row-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.png:
* platform/chromium-win/transforms/2d/hindi-rotated-expected.png:
* platform/chromium-win/transforms/2d/hindi-rotated-expected.txt:
* platform/chromium-win/transforms/2d/zoom-menulist-expected.png:
* platform/chromium/TestExpectations:
* platform/efl/css2.1/20110323/block-replaced-width-001-expected.txt: Removed.
* platform/gtk/css2.1/20110323/block-replaced-width-001-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r124123.
commit-queue@webkit.org [Tue, 31 Jul 2012 01:48:18 +0000 (01:48 +0000)]
Unreviewed, rolling out r124123.
http://trac.webkit.org/changeset/124123
https://bugs.webkit.org/show_bug.cgi?id=92700

ASSERT crashes terminate webkit Layout tests (Requested by
msaboff on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-30

* heap/Heap.cpp:
* heap/Heap.h:
(Heap):
* heap/IncrementalSweeper.cpp:
(JSC::IncrementalSweeper::doSweep):
(JSC::IncrementalSweeper::startSweeping):
(JSC::IncrementalSweeper::IncrementalSweeper):
(JSC):
* heap/IncrementalSweeper.h:
(IncrementalSweeper):
* heap/MarkedAllocator.cpp:
(JSC::MarkedAllocator::tryAllocateHelper):
(JSC::MarkedAllocator::addBlock):
* heap/MarkedAllocator.h:
(JSC::MarkedAllocator::zapFreeList):
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::sweepHelper):
* heap/MarkedSpace.cpp:
* heap/MarkedSpace.h:
(JSC::MarkedSpace::sweep):
(JSC):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::~JSGlobalData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowebkit-patch: system keyring is not used to read my password
commit-queue@webkit.org [Tue, 31 Jul 2012 01:45:44 +0000 (01:45 +0000)]
webkit-patch: system keyring is not used to read my password
https://bugs.webkit.org/show_bug.cgi?id=92532

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2012-07-30
Reviewed by Dirk Pranke.

In case no username can be fetched from environment, git or keychain,
prompt for username, and try to get password from keyring associated
with that username.

* Scripts/webkitpy/common/net/credentials.py:
(Credentials.read_credentials):
* Scripts/webkitpy/common/net/credentials_unittest.py:
(test_keyring_without_git_repo_nor_keychain):
(test_keyring_without_git_repo_nor_keychain.MockKeyring):
(test_keyring_without_git_repo_nor_keychain.MockKeyring.get_password):
(test_keyring_without_git_repo_nor_keychain.FakeCredentials):
(test_keyring_without_git_repo_nor_keychain.FakeCredentials._credentials_from_keychain):
(test_keyring_without_git_repo_nor_keychain.FakeCredentials._credentials_from_environment):
(test_keyring_without_git_repo_nor_keychain.FakeUser):
(test_keyring_without_git_repo_nor_keychain.FakeUser.prompt):
(test_keyring_without_git_repo_nor_keychain.FakeUser.prompt_password):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonrwt: move the code that identifies the chunk of tests to run into finder
dpranke@chromium.org [Tue, 31 Jul 2012 01:40:34 +0000 (01:40 +0000)]
nrwt: move the code that identifies the chunk of tests to run into finder
https://bugs.webkit.org/show_bug.cgi?id=92694

Reviewed by Ryosuke Niwa.

Another patch to make manager.py smaller and clearer; this patch moves
the handling of breaking the list of tests into chunks (--run-part,
--run-chunk) from manager.py to finder.py.

There are no functional changes and this is covered by existing tests.

* Scripts/webkitpy/layout_tests/controllers/finder.py:
(Finder.__init__):
(Finder._read_test_files):
(Finder):
(Finder.split_into_chunks_if_necessary):
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.__init__):
(Manager._collect_tests):
(Manager._parse_expectations):
(Manager.prepare_lists_and_print_output):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGrid Demo spends 1.5% of total time allocating Path objects in RenderBoxModelObject...
eric@webkit.org [Tue, 31 Jul 2012 01:14:15 +0000 (01:14 +0000)]
Grid Demo spends 1.5% of total time allocating Path objects in RenderBoxModelObject::paintBorderSides
https://bugs.webkit.org/show_bug.cgi?id=92252

Reviewed by Simon Fraser.

This change introduces the concept of a "null Path" very similar to a null WTF::String.
Just like String functions as a RefPtr around a StringImpl, Path (for most ports)
functions as an OwnPtr around a PlatformPathPtr.

In various places in the code, we declare a local Path variable, but don't necessarily
use that Path variable in all code paths, or might pass that Path variable along to GraphicsContext
functions, without ever actually adding points to that Path.
On most platforms, this Path default constructor was causing a malloc!
In some of these case, the code-path in question (like paintBorderSides) can be quite hot.
Introducing this null-Path and delaying instantiation of the PlatformPath object
until it's actually needed, saves a malloc for these hot paths.

To test this, I loaded a few popular pages, and added printfs to both the Path constructor
and destructor, logging during construction and destruction when the path was still null at destruction time.

This simple testing showed this to be a small win (avoiding mallocs) on many sites and a huge win for Google Spreadsheets:
apple.com: 147 Paths created, 9 (6%) destroyed null.
google.com: 58 Paths created, 26 (44%) destroyed null (google seems creating 5 paths every second after load?  1 of which is destroyed empty.)
amazon.com: 130 Paths created, 130 (100%) destroyed null.
Loading an empty spreadsheet from drive.google.com: 5237 created, 4861 destroyed null (92%!) :)

* platform/graphics/Path.h:
(Path):
(WebCore::Path::isNull):
(WebCore::Path::ensurePlatformPath):
* platform/graphics/cairo/CairoUtilities.cpp:
(WebCore::appendWebCorePathToCairoContext):
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::clip):
* platform/graphics/cairo/PathCairo.cpp:
(WebCore::Path::Path):
(WebCore::Path::~Path):
(WebCore::Path::ensurePlatformPath):
(WebCore):
(WebCore::Path::operator=):
(WebCore::Path::clear):
(WebCore::Path::isEmpty):
(WebCore::Path::currentPoint):
(WebCore::Path::translate):
(WebCore::Path::moveTo):
(WebCore::Path::addLineTo):
(WebCore::Path::addRect):
(WebCore::Path::addQuadCurveTo):
(WebCore::Path::addBezierCurveTo):
(WebCore::Path::addArc):
(WebCore::Path::addArcTo):
(WebCore::Path::addEllipse):
(WebCore::Path::closeSubpath):
(WebCore::Path::boundingRect):
(WebCore::Path::strokeBoundingRect):
(WebCore::Path::contains):
(WebCore::Path::strokeContains):
(WebCore::Path::apply):
(WebCore::Path::transform):
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawPath):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::clipOut):
* platform/graphics/cg/PathCG.cpp:
(WebCore::Path::Path):
(WebCore::Path::~Path):
(WebCore):
(WebCore::Path::ensurePlatformPath):
(WebCore::Path::operator=):
(WebCore::Path::contains):
(WebCore::Path::strokeContains):
(WebCore::Path::translate):
(WebCore::Path::boundingRect):
(WebCore::Path::fastBoundingRect):
(WebCore::Path::strokeBoundingRect):
(WebCore::Path::moveTo):
(WebCore::Path::addLineTo):
(WebCore::Path::addQuadCurveTo):
(WebCore::Path::addBezierCurveTo):
(WebCore::Path::addArcTo):
(WebCore::Path::platformAddPathForRoundedRect):
(WebCore::Path::closeSubpath):
(WebCore::Path::addArc):
(WebCore::Path::addRect):
(WebCore::Path::addEllipse):
(WebCore::Path::clear):
(WebCore::Path::isEmpty):
(WebCore::Path::currentPoint):
(WebCore::Path::apply):
* platform/graphics/gpu/LoopBlinnPathProcessor.cpp:
(WebCore):
(WebCore::LoopBlinnPathProcessor::buildContours):
* platform/graphics/mac/GraphicsContextMac.mm:
(WebCore::GraphicsContext::drawFocusRing):
* platform/graphics/openvg/PainterOpenVG.cpp:
(WebCore::PainterOpenVG::drawPath):
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::canvasClip):
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
* platform/graphics/skia/PathSkia.cpp:
(WebCore::Path::Path):
(WebCore::Path::~Path):
(WebCore):
(WebCore::Path::ensurePlatformPath):
(WebCore::Path::operator=):
(WebCore::Path::isEmpty):
(WebCore::Path::hasCurrentPoint):
(WebCore::Path::currentPoint):
(WebCore::Path::contains):
(WebCore::Path::translate):
(WebCore::Path::boundingRect):
(WebCore::Path::moveTo):
(WebCore::Path::addLineTo):
(WebCore::Path::addQuadCurveTo):
(WebCore::Path::addBezierCurveTo):
(WebCore::Path::addArcTo):
(WebCore::Path::closeSubpath):
(WebCore::Path::addArc):
(WebCore::Path::addRect):
(WebCore::Path::addEllipse):
(WebCore::Path::clear):
(WebCore::Path::apply):
(WebCore::Path::transform):
(WebCore::Path::strokeBoundingRect):
(WebCore::Path::strokeContains):
* platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
* platform/graphics/wx/GraphicsContextWx.cpp:
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
* platform/graphics/wx/PathWx.cpp:
(WebCore::Path::Path):
(WebCore::Path::~Path):
(WebCore::Path::boundingRect):
(WebCore::Path::operator=):
(WebCore::Path::ensurePlatformPath):
(WebCore):
(WebCore::Path::clear):
(WebCore::Path::moveTo):
(WebCore::Path::addLineTo):
(WebCore::Path::addQuadCurveTo):
(WebCore::Path::addBezierCurveTo):
(WebCore::Path::addArcTo):
(WebCore::Path::closeSubpath):
(WebCore::Path::addArc):
(WebCore::Path::addRect):
(WebCore::Path::addEllipse):
(WebCore::Path::transform):
(WebCore::Path::currentPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd WTF_EXPORT_PRIVATE to deleteOwnedPtr()
paroga@webkit.org [Tue, 31 Jul 2012 01:13:48 +0000 (01:13 +0000)]
Add WTF_EXPORT_PRIVATE to deleteOwnedPtr()
https://bugs.webkit.org/show_bug.cgi?id=92668

Reviewed by Hajime Morita.

When using export macros all non-inlined deleteOwnedPtr()
functions need to be declared with WTF_EXPORT_PRIVATE.

* wtf/OwnPtrCommon.h:
(WTF):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonrwt: split test-finding code out from manager.py
dpranke@chromium.org [Tue, 31 Jul 2012 01:02:13 +0000 (01:02 +0000)]
nrwt: split test-finding code out from manager.py
https://bugs.webkit.org/show_bug.cgi?id=92693

Reviewed by Ryosuke Niwa.

In the interest of making manager.py smaller, this patch moves
the code that actually takes the command line arguments and
--test-file lists of tests to run and expands them into an
actual list of tests out into a separate module.

* Scripts/webkitpy/layout_tests/controllers/finder.py: Added.
(LayoutTestFinder):
(LayoutTestFinder.__init__):
(LayoutTestFinder.find_tests):
(LayoutTestFinder._strip_test_dir_prefixes):
(LayoutTestFinder._strip_test_dir_prefix):
(LayoutTestFinder._read_test_names_from_file):
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._collect_tests):
(Manager._handle_finished_test):
* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(strip_comments):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agocommit-queue is corrupting ChangeLogs
abarth@webkit.org [Tue, 31 Jul 2012 00:49:39 +0000 (00:49 +0000)]
commit-queue is corrupting ChangeLogs
https://bugs.webkit.org/show_bug.cgi?id=92681

Reviewed by Tony Chang.

Some commits made with the commit-queue are ending up with duplicate
ChangeLog entries. I've hot-patched the servers to not use a special
merge driver for ChangeLogs, which should fix this issue. This patch
removes the merge driver from our cold-boot.sh script so that we won't
use it on new commit-queue instances.

* EWSTools/cold-boot.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoinspector/profiler/heap-snapshot-containment-show-all.html test crashing during WebVi...
msaboff@apple.com [Tue, 31 Jul 2012 00:46:23 +0000 (00:46 +0000)]
inspector/profiler/heap-snapshot-containment-show-all.html test crashing during WebView closing
<rdar://problem/11991881>

* platform/mac-lion/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoStructures should be swept after all other objects
mhahnenberg@apple.com [Tue, 31 Jul 2012 00:33:53 +0000 (00:33 +0000)]
Structures should be swept after all other objects
https://bugs.webkit.org/show_bug.cgi?id=92679

Reviewed by Filip Pizlo.

In order to get rid of ClassInfo from our objects, we need to be able to safely get the
ClassInfo during the destruction of objects. We'd like to get the ClassInfo out of the
Structure, but currently it is not safe to do so because the order of destruction of objects
is not guaranteed to sweep objects before their corresponding Structure. We can fix this by
sweeping Structures after everything else.

* heap/Heap.cpp:
(JSC::Heap::isSafeToSweepStructures): Add a function that checks if it is safe to sweep Structures.
If the Heap's IncrementalSweeper member is null, that means we're shutting down this VM and it is
safe to sweep structures since we'll always do Structures last anyways due to the ordering of
MarkedSpace::forEachBlock.
(JSC):
(JSC::Heap::didStartVMShutdown): Add this intermediate function to the Heap that ~JSGlobalData now
calls rather than calling the two HeapTimer objects individually. This allows the Heap to null out
these pointers after it has invalidated them to prevent accidental use-after-free in the sweep()
calls during lastChanceToFinalize().
* heap/Heap.h:
(Heap):
* heap/HeapTimer.h:
(HeapTimer):
* heap/IncrementalSweeper.cpp:
(JSC::IncrementalSweeper::structuresCanBeSwept): Determines if it is currently safe to sweep Structures.
This decision is based on whether we have gotten to the end of the vector of blocks that need sweeping
the first time.
(JSC):
(JSC::IncrementalSweeper::doSweep): We add a second pass over the vector to sweep Structures after we
make our first pass. We now null out the slots as we sweep them so that we can quickly find the
Structures during the second pass.
(JSC::IncrementalSweeper::startSweeping): Initialize our new Structure sweeping index.
(JSC::IncrementalSweeper::willFinishSweeping): Callback that is called by MarkedSpace::sweep to notify
the IncrementalSweeper that we are going to sweep all of the remaining blocks in the Heap so it can
assume that everything is taken care of in the correct order. Since MarkedSpace::forEachBlock
iterates over the Structure blocks after all other blocks, the ordering property for sweeping Structures holds.
(JSC::IncrementalSweeper::IncrementalSweeper): Initialize Structure sweeping index.
* heap/IncrementalSweeper.h: Add declarations for new stuff.
(IncrementalSweeper):
* heap/MarkedAllocator.cpp:
(JSC::MarkedAllocator::tryAllocateHelper): We now check if the current block only contains structures and
if so and it isn't safe to sweep Structures according to the Heap, we just return early instead of doing
the normal lazy sweep. If this proves to be too much of a waste in the future we can add an extra clause that
will sweep some number of other blocks in place of the current block to mitigate the cost of the floating
Structure garbage.
(JSC::MarkedAllocator::addBlock):
* heap/MarkedAllocator.h:
(JSC::MarkedAllocator::zapFreeList): When we zap the free list in the MarkedAllocator, the current block is no
longer valid to allocate from, so we set the current block to null.
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::sweepHelper): Added a couple assertions to make sure that we weren't trying to sweep Structures
at an unsafe time.
* heap/MarkedSpace.cpp:
(JSC::MarkedSpace::sweep): Notify the IncrementalSweeper that the MarkedSpace will finish all currently remaining sweeping.
(JSC):
* heap/MarkedSpace.h:
(JSC):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::~JSGlobalData): Call the new Heap::didStartVMShutdown.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd ability to load from a string to the ObjC WK API
weinig@apple.com [Tue, 31 Jul 2012 00:24:36 +0000 (00:24 +0000)]
Add ability to load from a string to the ObjC WK API
https://bugs.webkit.org/show_bug.cgi?id=92590

Reviewed by Dan Bernstein.

Source/WebKit2:

This adds an often used method to the new Objective-C API and will
be helpful for writing API tests.

* UIProcess/API/mac/WKBrowsingContextController.h:
* UIProcess/API/mac/WKBrowsingContextController.mm:
(-[WKBrowsingContextController loadHTMLString:baseURL:]):
Implement via calling down to WKPageLoadHTMLString.

Tools:

Add tests for [WKBrowsingContextController loadHTMLString:baseURL:]. We will be able
to greatly improve these tests (to test more than just not crashing) when methods to
access page content are added (soon!).

Adds:
    Test: WKBrowsingContextLoadDelegateTest_SimpleLoadOfHTMLString
    Test: WKBrowsingContextLoadDelegateTest_SimpleLoadOfHTMLString_NilBaseURL
    Test: WKBrowsingContextLoadDelegateTest_SimpleLoadOfHTMLString_NilHTMLStringAndBaseURL

* TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
Adds tests and refactors delegates to not use global state.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CMake] TestWebKitAPI bundle should link with WTF
commit-queue@webkit.org [Tue, 31 Jul 2012 00:11:51 +0000 (00:11 +0000)]
[CMake] TestWebKitAPI bundle should link with WTF
https://bugs.webkit.org/show_bug.cgi?id=92616

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-30
Reviewed by Antonio Gomes.

Fixes build when shared core is disabled.

* TestWebKitAPI/CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonrwt: clean up handling of 'expected' stats
dpranke@chromium.org [Tue, 31 Jul 2012 00:01:52 +0000 (00:01 +0000)]
nrwt: clean up handling of 'expected' stats
https://bugs.webkit.org/show_bug.cgi?id=92527

Reviewed by Tony Chang.

This patch alters the way we compute and log the "expected"
results and how we treat skipped tests; we will now log the
number of skipped tests separately from the categories, e.g.:

Found 31607 tests; running 24464.
Expect: 23496 passes   (23496 now,    0 wontfix)
Expect:   548 failures (  543 now,    5 wontfix)
Expect:   420 flaky    (  245 now,  175 wontfix)

(so that the "expect" totals add up to the "running" totals);
in addition, the totals in the one-line-progress reflect the
number of tests we will actually run. If --iterations or
--repeat-each are specified, the number of tests we run are
multiplied as appropriate, but the "expect" numbers are
unchanged, since we don't count multiple invocations of the same
test multiple times. In addition, if we are using --run-part or
--run-chunk, the tests we don't run are treated as skipped
for consistency. We will also log the values for --iterations
and --repeat each as part of the found/running line.

Previously the code had parsed and re-parsed the
TestExpectations files several times in an attempt to come up
with some sane statistics, but this was expensive and lead to
confusing layer; treating files as skipped in the way described
above is more consistent and cleaner.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._split_into_chunks_if_necessary):
(Manager.prepare_lists_and_print_output):
(Manager.run):
* Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ManagerTest.test_interrupt_if_at_failure_limits):
(ManagerTest.test_update_summary_with_result):
(ManagerTest.test_look_for_new_crash_logs):
(ResultSummaryTest.get_result_summary):
* Scripts/webkitpy/layout_tests/models/result_summary.py:
(ResultSummary.__init__):
* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser.expectation_for_skipped_test):
(TestExpectations.__init__):
(TestExpectations.add_skipped_tests):
  Here we make add_skipped_tests() public, so that we can update
  the expectations for tests that we are skipping due to
  --run-part or --run-chunk; we use the wontfix flag so that
  the tests that are intentionally skipped aren't considered
  "fixable".
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(SkippedTests.check):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
* Scripts/webkitpy/layout_tests/views/printing.py:
(Printer.print_found):
(Printer):
(Printer.print_expected):
(Printer._print_result_summary):
(Printer._print_result_summary_entry):
  Here we split out printing the number of tests found and run
  from the expected results, to be clearer and so that we don't
  have to reparse the expectations to update the stats.
* Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(Testprinter.get_result_summary):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoatomicDecrement() never reach 0 on Android so no deref() will be called
commit-queue@webkit.org [Mon, 30 Jul 2012 23:53:20 +0000 (23:53 +0000)]
atomicDecrement() never reach 0 on Android so no deref() will be called
https://bugs.webkit.org/show_bug.cgi?id=92635

Patch by Wei James <james.wei@intel.com> on 2012-07-30
Reviewed by Adam Barth.

With Android NDK 7b and later, __atomic_dec()  is implemented by
__sync_fetch_and_sub(), which will result in that atomicDecrement()
returns the old value instead of new one.

* wtf/Atomics.h:
(WTF):
(WTF::atomicIncrement):
(WTF::atomicDecrement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] Kill the concept of secondary shared process
rafael.lobo@openbossa.org [Mon, 30 Jul 2012 23:34:20 +0000 (23:34 +0000)]
[WK2] Kill the concept of secondary shared process
https://bugs.webkit.org/show_bug.cgi?id=92676

Reviewed by Alexey Proskuryakov.

Build fix after r124092.

* UIProcess/qt/QtWebContext.cpp: Build fix for Qt. In exchange of the
method removed, I've used WebContext::create(String()).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAvoid Assertion Failure in HarfBuzzRun::characterIndexForXPosition
commit-queue@webkit.org [Mon, 30 Jul 2012 23:13:25 +0000 (23:13 +0000)]
Avoid Assertion Failure in HarfBuzzRun::characterIndexForXPosition
https://bugs.webkit.org/show_bug.cgi?id=92376

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-07-30
Reviewed by Tony Chang.

.:

Added manual test to reliably reproduce assertion failure which is solved by this patch.

* ManualTests/harfbuzz-mouse-selection-crash.html: Added.

Source/WebCore:

Previously, the if condition in offsetForPosition gating the call to
characterIndexForXPosition was comparing a different value than what was actually used
as the argument to calling it. In some cases, this can lead to a minuscule difference
when comparing the two floats - enough to trigger the assertion. To resolve this,
the accuracy of the index calculation is improved by changing the types from int
to floats and rephrasing the if condition to be exactly the same as what is checked
for in the assertion.

Manual test ManualTests/harfbuzz-mouse-selection-crash.html added
which reliably reproduces the assertion failure before this change.

* platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::HarfBuzzRun::characterIndexForXPosition): Types changed to float.
(WebCore::HarfBuzzShaper::offsetForPosition): Types changed to float, if condition rephrased.
* platform/graphics/harfbuzz/ng/HarfBuzzShaper.h:
(HarfBuzzRun):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Remove WebTransformationMatrix::mapPoint overrides
jamesr@google.com [Mon, 30 Jul 2012 22:37:54 +0000 (22:37 +0000)]
[chromium] Remove WebTransformationMatrix::mapPoint overrides
https://bugs.webkit.org/show_bug.cgi?id=90329

Reviewed by Adrienne Walker.

Source/Platform:

Remove clipping-unaware mapPoint functions from the WebTransformationMatrix interface.

* chromium/public/WebTransformationMatrix.h:
(WebTransformationMatrix):

Source/WebCore:

Add more functionality for mapping points to CCMathUtil and use it in CCLayerSorter / drawTileQuad. These
mappings should never clip.

* platform/chromium/support/WebTransformationMatrix.cpp:
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawTileQuad):
* platform/graphics/chromium/cc/CCLayerSorter.cpp:
(WebCore::CCLayerSorter::LayerShape::LayerShape):
* platform/graphics/chromium/cc/CCMathUtil.cpp:
(WebCore::mapHomogeneousPoint):
(WebCore::CCMathUtil::mapPoint):
(WebCore):
* platform/graphics/chromium/cc/CCMathUtil.h:
(WebCore::HomogeneousCoordinate::cartesianPoint3d):
(HomogeneousCoordinate):
(CCMathUtil):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in logging code if MIME type is null
andersca@apple.com [Mon, 30 Jul 2012 22:27:38 +0000 (22:27 +0000)]
Crash in logging code if MIME type is null
https://bugs.webkit.org/show_bug.cgi?id=92683
<rdar://problem/11985295>

Reviewed by Dan Bernstein.

If the MIME type is null, try to figure it out from the URL extension. If this fails, return early instead of crashing
trying to insert the null string into a hash set.

* loader/SubframeLoader.cpp:
(WebCore::logPluginRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix with newer bison 2.6.
alexis.menard@openbossa.org [Mon, 30 Jul 2012 22:18:20 +0000 (22:18 +0000)]
Build fix with newer bison 2.6.
https://bugs.webkit.org/show_bug.cgi?id=92264

Reviewed by Adam Barth.

As stated in http://www.gnu.org/software/bison/manual/html_node/Table-of-Symbols.html
YYLEX_PARAM and YYPARSE_PARAM are depecreated since version 1.875. So far all Mac OS
version I had access to as well as recent Linux runs at least version 2.3 so it's safe
to use the replacement of these deprecated macros in favor of %lex-param and %parse-param.
As announced http://lists.gnu.org/archive/html/info-gnu/2012-07/msg00011.html with the release
of version 2.6 YYLEX_PARAM and YYPARSE_PARAM are not supported anymore.

No new tests : build fix and the patch should not trigger any regressions

* css/CSSGrammar.y:
* css/CSSParser.cpp:
* xml/XPathGrammar.y: Refactored a bit to not use an intermediate PARSER define.
* xml/XPathParser.cpp: bison 2.6 declare xpathyyparse in the .h file now, i.e. XPathGrammar.h
therefore including this file within the namespace {} declarations leads to xpathyyparse being
defined part of WebCore::XPath namespaces but the actual implementation of xpathyyparse is in XPathGrammar.cpp
(generated) and not implemented within the WebCore::XPath so it lead to linking issues. Last, XPathGrammar.h needs
to be included after the other includes as it uses some XPath types. It breaks the style but CSSParser.cpp is doing the same.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPropagate gesture events to plugins.
commit-queue@webkit.org [Mon, 30 Jul 2012 22:13:17 +0000 (22:13 +0000)]
Propagate gesture events to plugins.
https://bugs.webkit.org/show_bug.cgi?id=92281

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-07-30
Reviewed by Adam Barth.

Source/WebCore:

Propagate gesture events to plugins. This change does not expose the gesture events
to JavaScript, since there is no spec for that at the moment. Exposing gesture events
to JavaScript will be done separately, once there is a spec for it.

Test: platform/chromium/plugins/gesture-events.html

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* dom/EventNames.h:
(WebCore):
(WebCore::EventNames::isGestureEventType):
(EventNames):
* dom/GestureEvent.cpp: Added.
(WebCore):
(WebCore::GestureEvent::create):
(WebCore::GestureEvent::initGestureEvent):
(WebCore::GestureEvent::interfaceName):
(WebCore::GestureEvent::GestureEvent):
(WebCore::GestureEventDispatchMediator::GestureEventDispatchMediator):
(WebCore::GestureEventDispatchMediator::event):
(WebCore::GestureEventDispatchMediator::dispatchEvent):
* dom/GestureEvent.h: Added.
(WebCore):
(GestureEvent):
(WebCore::GestureEvent::~GestureEvent):
(WebCore::GestureEvent::deltaX):
(WebCore::GestureEvent::deltaY):
(WebCore::GestureEvent::GestureEvent):
(GestureEventDispatchMediator):
(WebCore::GestureEventDispatchMediator::create):
* dom/Node.cpp:
(WebCore):
(WebCore::Node::dispatchGestureEvent):
* dom/Node.h:
(WebCore):
(Node):
* page/EventHandler.cpp:
(WebCore::EventHandler::clear):
(WebCore::EventHandler::handleGestureEvent):
* page/EventHandler.h:

Source/WebKit/chromium:

Propagate gesture events to plugins.

* src/WebInputEventConversion.cpp:
(WebKit):
(WebKit::WebGestureEventBuilder::WebGestureEventBuilder):
* src/WebInputEventConversion.h:
(WebCore):
(WebKit):
(WebGestureEventBuilder):
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::handleEvent):
* src/WebPluginContainerImpl.h:
(WebCore):
(WebPluginContainerImpl):

Tools:

Update TestWebPlugin to receive events, and output logs for the events.

* DumpRenderTree/chromium/TestWebPlugin.cpp:
(TestWebPlugin::handleInputEvent):
* DumpRenderTree/chromium/TestWebPlugin.h:
(TestWebPlugin::acceptsInputEvents):
(TestWebPlugin):

LayoutTests:

Added a layout test to show that the plugins receive the gesture events correctly.

* platform/chromium/plugins/gesture-events-expected.txt: Added.
* platform/chromium/plugins/gesture-events.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPlumb vsync-enabled flag up to compositor thread and support disable-vsync
commit-queue@webkit.org [Mon, 30 Jul 2012 22:04:00 +0000 (22:04 +0000)]
Plumb vsync-enabled flag up to compositor thread and support disable-vsync
https://bugs.webkit.org/show_bug.cgi?id=92323

Patch by John Bates <jbates@google.com> on 2012-07-30
Reviewed by James Robinson.

Source/Platform:

* chromium/public/WebLayerTreeView.h:
(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):

Source/WebCore:

* platform/graphics/chromium/cc/CCFrameRateController.cpp:
(WebCore::CCFrameRateController::CCFrameRateController):
(WebCore::CCFrameRateController::disableTimeSourceThrottling):
(WebCore):
(WebCore::CCFrameRateController::setActive):
(WebCore::CCFrameRateController::postManualTick):
(WebCore::CCFrameRateController::onTimerFired):
(WebCore::CCFrameRateController::didBeginFrame):
(WebCore::CCFrameRateController::didFinishFrame):
* platform/graphics/chromium/cc/CCFrameRateController.h:
(WebCore):
(CCFrameRateController):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCLayerTreeSettings::CCLayerTreeSettings):
(CCLayerTreeSettings):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::initializeImplOnImplThread):
* platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):

Source/WebKit/chromium:

* public/WebSettings.h:
* tests/CCFrameRateControllerTest.cpp:
* src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::Settings::operator CCLayerTreeSettings):
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setRenderVSyncEnabled):
(WebKit):
* src/WebSettingsImpl.h:
(WebSettingsImpl):
(WebKit::WebSettingsImpl::renderVSyncEnabled):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd function to calculate the day in year from a date
paroga@webkit.org [Mon, 30 Jul 2012 21:53:03 +0000 (21:53 +0000)]
Add function to calculate the day in year from a date
https://bugs.webkit.org/show_bug.cgi?id=92671

Reviewed by Ryosuke Niwa.

Replace monthToDayInYear() with dayInYear() which takes a whole
date for calculation and will be used for bug 92286 later.

* wtf/DateMath.cpp:
(WTF::dayInYear):
(WTF::dateToDaysFrom1970):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[jhbuild] gnutls 2.12.14 does not build with glibc 2.16.0
rakuco@webkit.org [Mon, 30 Jul 2012 21:35:10 +0000 (21:35 +0000)]
[jhbuild] gnutls 2.12.14 does not build with glibc 2.16.0
https://bugs.webkit.org/show_bug.cgi?id=90643

Reviewed by Gustavo Noronha Silva.

The 2.x series of gnutls has a version of Gnulib that is
incompatible with glibc 2.16.0, which now does not define gets()
by default.

After talking to kov, mrobinson and philn, it looks like it makes
sense to simply remove gnutls from jhbuild.modules and rely on the
version installed on the system being recent enough.

This means at least version 2.12.8 for PKCS11 support, or at the
very least 2.11.0 (these are the minimum versions enforced by
glib-networking's configure.ac).

* efl/jhbuild.modules: Do not build gnutls anymore, make
glib-networking depend on glib instead, and move the libgcrypt
dependency to eet, which is what currently needs it.
* gtk/jhbuild.modules: Do not build gnutls anymore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Add miscellaneous missing includes and OVERRIDE declarations in compositor...
jamesr@google.com [Mon, 30 Jul 2012 21:33:32 +0000 (21:33 +0000)]
[chromium] Add miscellaneous missing includes and OVERRIDE declarations in compositor code
https://bugs.webkit.org/show_bug.cgi?id=92680

Reviewed by Adrienne Walker.

* platform/graphics/chromium/TextureCopier.h:
(AcceleratedTextureCopier):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
* platform/graphics/chromium/cc/CCPrioritizedTextureManager.h:
* platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:
* platform/graphics/chromium/cc/CCResourceProvider.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago [WK2] Kill the concept of secondary shared process
ap@apple.com [Mon, 30 Jul 2012 21:31:06 +0000 (21:31 +0000)]
    [WK2] Kill the concept of secondary shared process
        https://bugs.webkit.org/show_bug.cgi?id=92676

        Reviewed by Sam Weinig.

        * UIProcess/API/C/WKContext.cpp:
        * UIProcess/API/C/WKContext.h:
        * UIProcess/WebContext.cpp:
        * UIProcess/WebContext.h:
        Deleted shared process related code. We don't need to build the singleton into
        the cross-platform C API, platform-specific API wrappers are perfectly capable
        of doing that.

        * UIProcess/API/efl/ewk_context.cpp: (createDefaultEwkContext):
        * UIProcess/API/gtk/WebKitWebContext.cpp: (createDefaultWebContext):
        Use WKContextCreate() when creating default context.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Remove dependency on ScrollbarTheme from the compositor
enne@google.com [Mon, 30 Jul 2012 21:11:10 +0000 (21:11 +0000)]
[chromium] Remove dependency on ScrollbarTheme from the compositor
https://bugs.webkit.org/show_bug.cgi?id=90528

Reviewed by James Robinson.

Source/Platform:

Flesh out WebScrollbar functions enough to be able to implement
the parts of ScrollbarThemeClient that Chromium uses.

Wrap ScrollbarThemeComposite in the Platform API via two different
classes: WebScrollbarThemePainter is the non-threadsafe version that
is used to paint parts of a scrollbar into a context. This is intended
to only be used on the main thread. WebScrollbarThemeGeometry is the
threadsafe version, used to get the location and sizes of scrollbar
parts on both threads, so they can be painted on the main thread and
composited on the compositor thread.

Unfortunately, there is no way to enforce these thread safety issues,
as other ports use the ScrollbarTheme hierarchy differently than
Chromium does. On the bright side, other than painting, the
ScrollbarTheme code is largely functional and we can enforce this
internally for the Chromium port.

* Platform.gypi:
* chromium/public/WebScrollbar.h:
(WebCore):
(WebKit):
(WebScrollbar):
* chromium/public/WebScrollbarThemeGeometry.h: Added.
(WebCore):
(WebKit):
(WebScrollbarThemeGeometry):
(WebKit::WebScrollbarThemeGeometry::WebScrollbarThemeGeometry):
(WebKit::WebScrollbarThemeGeometry::~WebScrollbarThemeGeometry):
(WebKit::WebScrollbarThemeGeometry::operator=):
(WebKit::WebScrollbarThemeGeometry::isNull):
* chromium/public/WebScrollbarThemePainter.h: Added.
(WebCore):
(WebKit):
(WebScrollbarThemePainter):
(WebKit::WebScrollbarThemePainter::WebScrollbarThemePainter):
(WebKit::WebScrollbarThemePainter::~WebScrollbarThemePainter):
(WebKit::WebScrollbarThemePainter::operator=):
(WebKit::WebScrollbarThemePainter::isNull):

Source/WebCore:

Tested by existing layout tests.

ScrollbarLayerChromium is modified to use the Platform API for
WebScrollbar, WebScrollbarThemePainter, and WebScrollbarThemeGeometry.
This prevents API dependencies from the compositor code into WebCore
scrollbar and theme code.

CCScrollbarLayerImpl::CCScrollbar now implements the WebScrollbar API
instead of the ScrollbarThemeClient API.

Also, CCScrollbarLayerImpl now no longer gets the theme from a static
accessor. It now gets a "copy" of the theme from the main thread via
WebScrollbarThemeGeometry, which is more correct for render theme
scrollbars which were previously using the native theme to get part
geometry. Using the correct theme unfortunately causes crashes due to
bad casts in RenderScrollbarTheme, so this patch turns back off the
use of ScrollbarLayerChromium for themed scrollbars until that can be
resolved.

* page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::createScrollbarLayer):
* platform/ScrollbarThemeClient.h:
(ScrollbarThemeClient):
* platform/graphics/chromium/ScrollbarLayerChromium.cpp:
(WebCore::ScrollbarLayerChromium::create):
(WebCore::ScrollbarLayerChromium::ScrollbarLayerChromium):
(WebCore::ScrollbarLayerChromium::pushPropertiesTo):
(WebCore::ScrollbarBackgroundPainter::create):
(WebCore::ScrollbarBackgroundPainter::ScrollbarBackgroundPainter):
(ScrollbarBackgroundPainter):
(WebCore::ScrollbarThumbPainter::create):
(WebCore::ScrollbarThumbPainter::ScrollbarThumbPainter):
(ScrollbarThumbPainter):
(WebCore::ScrollbarLayerChromium::createTextureUpdaterIfNeeded):
(WebCore::ScrollbarLayerChromium::setTexturePriorities):
(WebCore::ScrollbarLayerChromium::update):
* platform/graphics/chromium/ScrollbarLayerChromium.h:
(ScrollbarLayerChromium):
* platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:
(WebCore::CCScrollbarLayerImpl::CCScrollbarLayerImpl):
(WebCore::CCScrollbarLayerImpl::setScrollbarData):
(WebCore::toUVRect):
(WebCore::CCScrollbarLayerImpl::appendQuads):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::isOverlay):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::value):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::location):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::size):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::enabled):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::maximum):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::totalSize):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::isScrollViewScrollbar):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::isScrollableAreaActive):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::getTickmarks):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::controlSize):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::pressedPart):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::hoveredPart):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::scrollbarOverlayStyle):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::orientation):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::isCustomScrollbar):
* platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:
(CCScrollbarLayerImpl):
(CCScrollbar):

Source/WebKit/chromium:

Add implementations for WebScrollbarThemeGeometry and
WebScrollbarThemePainter. Fill out additional API calls for
WebPluginScrollbarImpl since it derives from WebScrollbar.

Add WebScrollbarImpl to the client API to wrap and own an existing
WebCore Scrollbar object and provide the WebScrollbar interface.

By keeping WebScrollbar separate from WebScrollbarThemeGeometry, the
compositor thread can create its own thread-safe data bag version of a
WebScrollbar (CCScrollbarLayerImpl::CCScrollbar), but this requires
WebScrollbarThemeClientImpl.

WebScrollbarThemeClientImpl does the reverse of WebScrollbarImpl; it
wraps a WebScrollbar and provides the ScrollbarThemeClient interface.
This is so that a WebScrollbar can be passed to the geometry and
painter functions. Then, internally the WebScrollbarThemeClientImpl
can be used to adapt the WebScrollbar to the ScrollbarThemeClient
interface so the geometry and painter functions can call direct
functions on ScrollbarThemeComposite.

* WebKit.gyp:
* src/AssertMatchingEnums.cpp:
* src/ExternalPopupMenu.h:
(WebKit):
* src/WebPluginScrollbarImpl.cpp:
(WebKit::WebPluginScrollbarImpl::WebPluginScrollbarImpl):
(WebKit::WebPluginScrollbarImpl::location):
(WebKit):
(WebKit::WebPluginScrollbarImpl::size):
(WebKit::WebPluginScrollbarImpl::enabled):
(WebKit::WebPluginScrollbarImpl::maximum):
(WebKit::WebPluginScrollbarImpl::totalSize):
(WebKit::WebPluginScrollbarImpl::isScrollViewScrollbar):
(WebKit::WebPluginScrollbarImpl::isScrollableAreaActive):
(WebKit::WebPluginScrollbarImpl::getTickmarks):
(WebKit::WebPluginScrollbarImpl::controlSize):
(WebKit::WebPluginScrollbarImpl::pressedPart):
(WebKit::WebPluginScrollbarImpl::hoveredPart):
(WebKit::WebPluginScrollbarImpl::scrollbarOverlayStyle):
(WebKit::WebPluginScrollbarImpl::orientation):
(WebKit::WebPluginScrollbarImpl::isCustomScrollbar):
(WebKit::WebPluginScrollbarImpl::onMouseUp):
(WebKit::WebPluginScrollbarImpl::onMouseMove):
(WebKit::WebPluginScrollbarImpl::onMouseLeave):
* src/WebPluginScrollbarImpl.h:
(WebPluginScrollbarImpl):
* src/WebScrollbarImpl.cpp: Added.
(WebKit):
(WebKit::WebScrollbar::create):
(WebKit::WebScrollbarImpl::WebScrollbarImpl):
(WebKit::WebScrollbarImpl::isOverlay):
(WebKit::WebScrollbarImpl::value):
(WebKit::WebScrollbarImpl::location):
(WebKit::WebScrollbarImpl::size):
(WebKit::WebScrollbarImpl::enabled):
(WebKit::WebScrollbarImpl::maximum):
(WebKit::WebScrollbarImpl::totalSize):
(WebKit::WebScrollbarImpl::isScrollViewScrollbar):
(WebKit::WebScrollbarImpl::isScrollableAreaActive):
(WebKit::WebScrollbarImpl::getTickmarks):
(WebKit::WebScrollbarImpl::controlSize):
(WebKit::WebScrollbarImpl::pressedPart):
(WebKit::WebScrollbarImpl::hoveredPart):
(WebKit::WebScrollbarImpl::scrollbarOverlayStyle):
(WebKit::WebScrollbarImpl::orientation):
(WebKit::WebScrollbarImpl::isCustomScrollbar):
* src/WebScrollbarImpl.h: Copied from Source/Platform/chromium/public/WebScrollbar.h.
(WebCore):
(WebKit):
(WebScrollbarImpl):
* src/WebScrollbarThemeClientImpl.cpp: Added.
(WebKit):
(WebKit::WebScrollbarThemeClientImpl::WebScrollbarThemeClientImpl):
(WebKit::WebScrollbarThemeClientImpl::x):
(WebKit::WebScrollbarThemeClientImpl::y):
(WebKit::WebScrollbarThemeClientImpl::width):
(WebKit::WebScrollbarThemeClientImpl::height):
(WebKit::WebScrollbarThemeClientImpl::size):
(WebKit::WebScrollbarThemeClientImpl::location):
(WebKit::WebScrollbarThemeClientImpl::parent):
(WebKit::WebScrollbarThemeClientImpl::root):
(WebKit::WebScrollbarThemeClientImpl::setFrameRect):
(WebKit::WebScrollbarThemeClientImpl::frameRect):
(WebKit::WebScrollbarThemeClientImpl::invalidate):
(WebKit::WebScrollbarThemeClientImpl::invalidateRect):
(WebKit::WebScrollbarThemeClientImpl::scrollbarOverlayStyle):
(WebKit::WebScrollbarThemeClientImpl::getTickmarks):
(WebKit::WebScrollbarThemeClientImpl::isScrollableAreaActive):
(WebKit::WebScrollbarThemeClientImpl::isScrollViewScrollbar):
(WebKit::WebScrollbarThemeClientImpl::convertFromContainingWindow):
(WebKit::WebScrollbarThemeClientImpl::isCustomScrollbar):
(WebKit::WebScrollbarThemeClientImpl::orientation):
(WebKit::WebScrollbarThemeClientImpl::value):
(WebKit::WebScrollbarThemeClientImpl::currentPos):
(WebKit::WebScrollbarThemeClientImpl::visibleSize):
(WebKit::WebScrollbarThemeClientImpl::totalSize):
(WebKit::WebScrollbarThemeClientImpl::maximum):
(WebKit::WebScrollbarThemeClientImpl::controlSize):
(WebKit::WebScrollbarThemeClientImpl::lineStep):
(WebKit::WebScrollbarThemeClientImpl::pageStep):
(WebKit::WebScrollbarThemeClientImpl::pressedPart):
(WebKit::WebScrollbarThemeClientImpl::hoveredPart):
(WebKit::WebScrollbarThemeClientImpl::styleChanged):
(WebKit::WebScrollbarThemeClientImpl::enabled):
(WebKit::WebScrollbarThemeClientImpl::setEnabled):
(WebKit::WebScrollbarThemeClientImpl::isOverlayScrollbar):
* src/WebScrollbarThemeClientImpl.h: Added.
(WebCore):
(WebKit):
(WebScrollbarThemeClientImpl):
* src/WebScrollbarThemeGeometry.cpp: Added.
(WebKit):
(WebKit::WebScrollbarThemeGeometry::assign):
(WebKit::WebScrollbarThemeGeometry::thumbPosition):
(WebKit::WebScrollbarThemeGeometry::thumbLength):
(WebKit::WebScrollbarThemeGeometry::trackPosition):
(WebKit::WebScrollbarThemeGeometry::trackLength):
(WebKit::WebScrollbarThemeGeometry::hasButtons):
(WebKit::WebScrollbarThemeGeometry::hasThumb):
(WebKit::WebScrollbarThemeGeometry::trackRect):
(WebKit::WebScrollbarThemeGeometry::thumbRect):
(WebKit::WebScrollbarThemeGeometry::minimumThumbLength):
(WebKit::WebScrollbarThemeGeometry::scrollbarThickness):
(WebKit::WebScrollbarThemeGeometry::backButtonStartRect):
(WebKit::WebScrollbarThemeGeometry::backButtonEndRect):
(WebKit::WebScrollbarThemeGeometry::forwardButtonStartRect):
(WebKit::WebScrollbarThemeGeometry::forwardButtonEndRect):
(WebKit::WebScrollbarThemeGeometry::constrainTrackRectToTrackPieces):
(WebKit::WebScrollbarThemeGeometry::splitTrack):
(WebKit::WebScrollbarThemeGeometry::WebScrollbarThemeGeometry):
* src/WebScrollbarThemePainter.cpp: Added.
(WebKit):
(WebKit::WebScrollbarThemePainter::assign):
(WebKit::WebScrollbarThemePainter::paintScrollbarBackground):
(WebKit::WebScrollbarThemePainter::paintTrackBackground):
(WebKit::WebScrollbarThemePainter::paintBackTrackPart):
(WebKit::WebScrollbarThemePainter::paintForwardTrackPart):
(WebKit::WebScrollbarThemePainter::paintBackButtonStart):
(WebKit::WebScrollbarThemePainter::paintBackButtonEnd):
(WebKit::WebScrollbarThemePainter::paintForwardButtonStart):
(WebKit::WebScrollbarThemePainter::paintForwardButtonEnd):
(WebKit::WebScrollbarThemePainter::paintTickmarks):
(WebKit::WebScrollbarThemePainter::paintThumb):
(WebKit::WebScrollbarThemePainter::WebScrollbarThemePainter):
* tests/ScrollbarLayerChromiumTest.cpp:
(WebCore::MockScrollbar::convertFromContainingWindow):
(WebCore::MockScrollbar::isOverlayScrollbar):
(MockScrollbar):
(WebCore::TEST):

LayoutTests:

Mark custom-composited-different-track-parts.html as failing because
custom scrollbars no longer create ScrollbarLayerChromiums. This is
due to the unsafe casts in RenderThemeScrollbar.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonrwt: --verbose logging does not work right on windows
dpranke@chromium.org [Mon, 30 Jul 2012 21:07:46 +0000 (21:07 +0000)]
nrwt: --verbose logging does not work right on windows
https://bugs.webkit.org/show_bug.cgi?id=92673

Unreviewed, build fix.

The --verbose log level is not being propagated to the worker
processes on windows properly; this has been broken ever since I
refactored logging into the message pool directly :(.

Also, fixing this revealed that outputcapture wasn't saving and
restoring log levels correctly, so I had to fix that as well.

* Scripts/webkitpy/common/message_pool.py:
(_MessagePool._start_workers):
(_MessagePool._worker_log_level):
(_Worker.__init__):
(_Worker._set_up_logging):
(_WorkerLogHandler.__init__):
* Scripts/webkitpy/common/system/outputcapture.py:
(OutputCapture.capture_output):
(OutputCapture.restore_output):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r123636): Heap-use-after-free in StyleResolver::collectMatchingRules.
kling@webkit.org [Mon, 30 Jul 2012 21:06:26 +0000 (21:06 +0000)]
REGRESSION(r123636): Heap-use-after-free in StyleResolver::collectMatchingRules.
<http://webkit.org/b/92430>

Reviewed by Antti Koivisto.

Don't hold on to a reference to StyledElement::classNames() as that may become
invalid after mutating the element's attribute data.

In this case it was happening below Element::hasAttributes() which is unfortunately
naive enough to always serialize lazy attributes. That is a minor inefficiency that
can be addressed in a separate patch.

Covered by valgrind on existing tests.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRules):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBaselines on additional platforms for fast/table/table-row-focus-ring-paint.
tomhudson@google.com [Mon, 30 Jul 2012 21:02:27 +0000 (21:02 +0000)]
Baselines on additional platforms for fast/table/table-row-focus-ring-paint.
https://bugs.webkit.org/show_bug.cgi?id=85348

Unreviewed gardening.

* platform/chromium-linux/fast/table/table-row-focus-ring-paint-expected.png: Removed.
* platform/chromium-mac/fast/table/table-row-focus-ring-paint-expected.png: Added.
* platform/chromium-win/fast/table/table-row-focus-ring-paint-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] critical warning: gdk_window_get_cursor() called on a NULL window
commit-queue@webkit.org [Mon, 30 Jul 2012 20:57:59 +0000 (20:57 +0000)]
[GTK] critical warning: gdk_window_get_cursor() called on a NULL window
https://bugs.webkit.org/show_bug.cgi?id=92651

Patch by Claudio Saavedra <csaavedra@igalia.com> on 2012-07-30
Reviewed by Martin Robinson.

PageClientImpl::setCursor() might get called before the
window is realized, so safeguard against it.

* UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::setCursor): early return if the window is
not realized.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Unreviewed gardening.
rakuco@webkit.org [Mon, 30 Jul 2012 20:52:00 +0000 (20:52 +0000)]
[EFL] Unreviewed gardening.

Fix r124028 by adding the missing expectations to the added lines.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed gardening. Add new baselines for tests
senorblanco@chromium.org [Mon, 30 Jul 2012 20:49:24 +0000 (20:49 +0000)]
[chromium] Unreviewed gardening.  Add new baselines for tests
affected by r124042.

* platform/chromium-linux/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
* platform/chromium-linux/fast/borders/border-image-rotate-transform-expected.png:
* platform/chromium-win-xp/fast/backgrounds/repeat: Removed.
* platform/chromium-win/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
* platform/chromium-win/fast/borders/border-image-rotate-transform-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoForce Mac editing mode on new test so other platforms will pass it.
pkasting@chromium.org [Mon, 30 Jul 2012 20:45:47 +0000 (20:45 +0000)]
Force Mac editing mode on new test so other platforms will pass it.
https://bugs.webkit.org/show_bug.cgi?id=92662

Reviewed by Ryosuke Niwa.

* fast/writing-mode/flipped-blocks-hit-test-line-edges.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Mon, 30 Jul 2012 20:19:05 +0000 (20:19 +0000)]
[Qt] Unreviewed gardening.

* platform/qt-5.0/Skipped: Unskip now passing tests. (bug85203)
* platform/qt-5.0/fast/js/global-constructors-expected.txt: Added. Same as
  platform/qt/...expected.txt, but has more attribute because of enabled SVG_FONTS.
* platform/qt/fast/js/global-constructors-expected.png: Removed, it is text only test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] CCThreadTask should not depend on CrossThreadTask and does not need to...
commit-queue@webkit.org [Mon, 30 Jul 2012 20:05:59 +0000 (20:05 +0000)]
[chromium] CCThreadTask should not depend on CrossThreadTask and does not need to depend on CrossThreadCopier
https://bugs.webkit.org/show_bug.cgi?id=90132

Patch by James Robinson <jamesr@chromium.org> on 2012-07-30
Reviewed by David Levin.

CrossThreadTask is defined in WebCore/dom/ and depends on concepts like ScriptExecutionConcept. CCThreadTask,
being in WebCore/platform/, should not depend on /dom/ or anything from that layer.

CrossThreadCopier is not a layering violation per se, but it's also not at all helpful for CCThreadTask - we
never use any types for which it would be useful.

* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::finishAllRendering):
(WebCore::CCThreadProxy::initializeContext):
(WebCore::CCThreadProxy::setVisible):
(WebCore::CCThreadProxy::initializeLayerRenderer):
(WebCore::CCThreadProxy::recreateContext):
(WebCore::CCThreadProxy::implSideRenderingStats):
(WebCore::CCThreadProxy::start):
(WebCore::CCThreadProxy::stop):
(WebCore::CCThreadProxy::forceSerializeOnSwapBuffers):
(WebCore::CCThreadProxy::beginFrame):
(WebCore::CCThreadProxy::acquireLayerTextures):
* platform/graphics/chromium/cc/CCThreadTask.h:
(CCThreadTask1):
(WebCore::CCThreadTask1::create):
(WebCore::CCThreadTask1::CCThreadTask1):
(CCThreadTask2):
(WebCore::CCThreadTask2::create):
(WebCore::CCThreadTask2::CCThreadTask2):
(CCThreadTask3):
(WebCore::CCThreadTask3::create):
(WebCore::CCThreadTask3::CCThreadTask3):
(CCThreadTask4):
(WebCore::CCThreadTask4::create):
(WebCore::CCThreadTask4::CCThreadTask4):
(CCThreadTask5):
(WebCore::CCThreadTask5::create):
(WebCore::CCThreadTask5::CCThreadTask5):
(WebCore::createCCThreadTask):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed gardening. Rebaseline another test affected by
senorblanco@chromium.org [Mon, 30 Jul 2012 19:51:56 +0000 (19:51 +0000)]
[chromium] Unreviewed gardening.  Rebaseline another test affected by
r124042.

* platform/chromium-linux-x86/fast/gradients: Removed.
* platform/chromium-linux/fast/gradients/background-clipped-expected.png:
* platform/chromium-mac-snowleopard/fast/gradients/background-clipped-expected.png:
* platform/chromium-mac/fast/gradients/background-clipped-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAfter r123895, new-run-webkit-tests can fail with TypeError when a test crashes
dpranke@chromium.org [Mon, 30 Jul 2012 18:55:10 +0000 (18:55 +0000)]
After r123895, new-run-webkit-tests can fail with TypeError when a test crashes
https://bugs.webkit.org/show_bug.cgi?id=92664

Reviewed by Michael Saboff.

Updated to handle crash_logs being returned as a tuple of (stderr, crash_log).

* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort.look_for_new_crash_logs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Rebaseline tests for Skia changes.
pkasting@chromium.org [Mon, 30 Jul 2012 18:54:59 +0000 (18:54 +0000)]
[Chromium] Rebaseline tests for Skia changes.
http://crbug.com/130283
http://crbug.com/131188

Unreviewed, test expectations update.

* platform/chromium-linux/css3/filters/effect-combined-hw-expected.png:
* platform/chromium-linux/css3/filters/effect-saturate-hw-expected.png:
* platform/chromium-linux/css3/filters/effect-sepia-hw-expected.png:
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png:
* platform/chromium-mac/css3/filters/effect-combined-hw-expected.png:
* platform/chromium-mac/css3/filters/effect-grayscale-hw-expected.png:
* platform/chromium-mac/css3/filters/effect-hue-rotate-hw-expected.png:
* platform/chromium-mac/css3/filters/effect-saturate-hw-expected.png:
* platform/chromium-mac/css3/filters/effect-sepia-hw-expected.png:
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png:
* platform/chromium-mac/svg/W3C-SVG-1.1/painting-stroke-04-t-expected.txt: Removed.
* platform/chromium-win/css3/filters/effect-combined-hw-expected.png:
* platform/chromium-win/css3/filters/effect-grayscale-hw-expected.png:
* platform/chromium-win/css3/filters/effect-hue-rotate-hw-expected.png:
* platform/chromium-win/css3/filters/effect-saturate-hw-expected.png:
* platform/chromium-win/css3/filters/effect-sepia-hw-expected.png:
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/painting-stroke-04-t-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd special export macro for string related functions
paroga@webkit.org [Mon, 30 Jul 2012 18:53:42 +0000 (18:53 +0000)]
Add special export macro for string related functions
https://bugs.webkit.org/show_bug.cgi?id=92624

Reviewed by Hajime Morita.

The windows port compiles string related code into every binary for performance reasons (see r59187).
Add the WTF_EXPORT_STRING_API define to allow this behaviour with export macros too.

* wtf/ExportMacros.h:
* wtf/text/AtomicString.h:
(AtomicString):
* wtf/text/StringImpl.h:
(StringImpl):
(WTF):
* wtf/text/WTFString.h:
(WTF):
(String):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r123983.
paroga@webkit.org [Mon, 30 Jul 2012 18:49:49 +0000 (18:49 +0000)]
Unreviewed, rolling out r123983.
http://trac.webkit.org/changeset/123983
https://bugs.webkit.org/show_bug.cgi?id=92663

EFL build is broken when unit tests are enabled (Requested by
paroga on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-30

* CMakeLists.txt:
* PlatformEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Rename Databases to Web SQL
commit-queue@webkit.org [Mon, 30 Jul 2012 18:49:43 +0000 (18:49 +0000)]
Web Inspector: Rename Databases to Web SQL
https://bugs.webkit.org/show_bug.cgi?id=92646

Patch by Paul Irish <paul.irish@gmail.com> on 2012-07-30
Reviewed by Pavel Feldman.

Renamed Databases to Web SQL. Drive-by fix for EmptyView
selection.

* English.lproj/localizedStrings.js:
* inspector/front-end/EmptyView.js:
* inspector/front-end/ResourcesPanel.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonew flexbox should ignore float set on flexitems
tony@chromium.org [Mon, 30 Jul 2012 18:39:53 +0000 (18:39 +0000)]
new flexbox should ignore float set on flexitems
https://bugs.webkit.org/show_bug.cgi?id=70792

Reviewed by Ojan Vafai.

Source/WebCore:

Force flex items to not float.

Test: css3/flexbox/floated-flexitem.html

* css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle): Force NoFloat on flex items.

LayoutTests:

Make an example in the spec into a ref test.  Add some styles to make it a bit more clear what's happening.

* css3/flexbox/floated-flexitem-expected.html: Added.
* css3/flexbox/floated-flexitem.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] New baselines and test expectations update.
pkasting@chromium.org [Mon, 30 Jul 2012 18:33:28 +0000 (18:33 +0000)]
[Chromium] New baselines and test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=88939
https://bugs.webkit.org/show_bug.cgi?id=91485
http://crbug.com/139162

Unreviewed, test expectations update.

* platform/chromium-linux-x86/svg/W3C-SVG-1.1/filters-example-01-b-expected.png: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed gardening. Add new mac baselines for tests
senorblanco@chromium.org [Mon, 30 Jul 2012 18:20:02 +0000 (18:20 +0000)]
[chromium] Unreviewed gardening.  Add new mac baselines for tests
affected by r124042.  Fix a typo in TestExpectations.

* platform/chromium-mac-snowleopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
* platform/chromium-mac-snowleopard/fast/borders/border-image-rotate-transform-expected.png:
* platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
* platform/chromium-mac/fast/borders/border-image-rotate-transform-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Mon, 30 Jul 2012 18:01:07 +0000 (18:01 +0000)]
Unreviewed GTK gardening.

Adding platform-specific baselines that are required after r123793, r123912 and r123914.

* platform/gtk/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
* platform/gtk/fast/hidpi/gradient-with-scaled-ancestor-expected.txt: Added.
* platform/gtk/fast/table/table-row-outline-paint-expected.png: Added.
* platform/gtk/fast/table/table-row-outline-paint-expected.txt: Added.
* platform/gtk/svg/as-image/animated-svg-repaints-completely-in-hidpi-expected.png: Added.
* platform/gtk/svg/as-image/animated-svg-repaints-completely-in-hidpi-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Turn back on ScrollbarLayerChromium for Windows
enne@google.com [Mon, 30 Jul 2012 18:00:29 +0000 (18:00 +0000)]
[chromium] Turn back on ScrollbarLayerChromium for Windows
https://bugs.webkit.org/show_bug.cgi?id=92409

Reviewed by James Robinson.

This reverts r122791. As GDI issues were addressed in Chromium via
http://src.chromium.org/viewvc/chrome?view=rev&revision=148215,
scrollbar parts can now be composited on the thread.

* page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::createScrollbarLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed gardening. Marking two accelerated painting
senorblanco@chromium.org [Mon, 30 Jul 2012 17:56:38 +0000 (17:56 +0000)]
[chromium] Unreviewed gardening.  Marking two accelerated painting
tests as crashing intermittently.
https://bugs.webkit.org/show_bug.cgi?id=92660

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Optimize the generation of selection details generation.
mifenton@rim.com [Mon, 30 Jul 2012 17:48:34 +0000 (17:48 +0000)]
[BlackBerry] Optimize the generation of selection details generation.
https://bugs.webkit.org/show_bug.cgi?id=92522

Reviewed by Antonio Gomes.

PR 179264.

Reduce the number of times we generate selection details notifications.

This removes several notifications that are handled by the standard
notification path and makes skipping duplicate notifications the default
so that only those that must generate a response do.

Reviewed Internally by Gen Mak.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::notifyTransformedContentsSizeChanged):
(BlackBerry::WebKit::WebPagePrivate::updateDelegatedOverlays):
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::setElementUnfocused):
* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::setCaretPosition):
(BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
(BlackBerry::WebKit::SelectionHandler::setSelection):
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
* WebKitSupport/SelectionHandler.h:
(SelectionHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r124025.
commit-queue@webkit.org [Mon, 30 Jul 2012 17:46:47 +0000 (17:46 +0000)]
Unreviewed, rolling out r124025.
http://trac.webkit.org/changeset/124025
https://bugs.webkit.org/show_bug.cgi?id=92658

Causes color-suggestion-picker-appearance layout test to time
out on all Chromium platforms (Requested by tomhudson_ on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-30

Source/Platform:

* chromium/public/WebLocalizedString.h:

Source/WebCore:

* rendering/RenderThemeChromiumCommon.cpp:
(WebCore::RenderThemeChromiumCommon::supportsDataListUI):

Source/WebKit/chromium:

* WebKit.gyp:
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::createColorChooser):
* src/ChromeClientImpl.h:
(WebCore):
(ChromeClientImpl):
* src/ColorChooserProxy.cpp: Copied from Source/WebKit/chromium/src/ColorChooserUIController.h.
(WebKit):
(WebKit::ColorChooserProxy::ColorChooserProxy):
(WebKit::ColorChooserProxy::~ColorChooserProxy):
(WebKit::ColorChooserProxy::setSelectedColor):
(WebKit::ColorChooserProxy::endChooser):
* src/ColorChooserProxy.h: Copied from Source/WebKit/chromium/src/ColorChooserUIController.h.
(WebKit):
(ColorChooserProxy):
* src/ColorChooserUIController.cpp: Removed.
* src/WebColorChooserClientImpl.cpp: Copied from Source/WebKit/chromium/src/ColorChooserUIController.h.
(WebKit):
(WebKit::WebColorChooserClientImpl::WebColorChooserClientImpl):
(WebKit::WebColorChooserClientImpl::~WebColorChooserClientImpl):
(WebKit::WebColorChooserClientImpl::didChooseColor):
(WebKit::WebColorChooserClientImpl::didEndChooser):
* src/WebColorChooserClientImpl.h: Renamed from Source/WebKit/chromium/src/ColorChooserUIController.h.
(WebCore):
(WebKit):
(WebColorChooserClientImpl):

LayoutTests:

* platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png: Removed.
* platform/chromium/TestExpectations:
* platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.txt: Removed.
* platform/chromium/fast/forms/color/color-suggestion-picker-appearance.html: Removed.
* platform/chromium/fast/forms/datalist/input-list-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Mon, 30 Jul 2012 17:44:36 +0000 (17:44 +0000)]
Unreviewed GTK gardening.

Skipping a test that utilizes unsupported isolated worlds and updating
one baseline after r123988.

* platform/gtk/TestExpectations:
* platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION: Focused TR element draws its focus outline in the wrong place
commit-queue@webkit.org [Mon, 30 Jul 2012 17:41:47 +0000 (17:41 +0000)]
REGRESSION: Focused TR element draws its focus outline in the wrong place
https://bugs.webkit.org/show_bug.cgi?id=85348

Patch by Pravin D <pravind.2k4@gmail.com> on 2012-07-30
Reviewed by Julien Chaffraix.

The focus ring used to be drawn around the first row of the table section irrespective of the row in focus.
The issue was fixed by the bug http://www.webkit.org/b/92389 .
Adding a regression test case.

* fast/table/table-row-focus-ring-paint-expected.txt: Added.
* fast/table/table-row-focus-ring-paint.html: Added.
* platform/chromium-linux/fast/table/table-row-focus-ring-paint-expected.png: Added.
* platform/qt-4.8/fast/table/table-row-focus-ring-paint-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdded a SkiaGraphics definition to the watchlist file; cc'ed myself
senorblanco@chromium.org [Mon, 30 Jul 2012 17:40:49 +0000 (17:40 +0000)]
Added a SkiaGraphics definition to the watchlist file; cc'ed myself
to that group.  Unreviewed.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r123966 and r123967.
commit-queue@webkit.org [Mon, 30 Jul 2012 17:27:03 +0000 (17:27 +0000)]
Unreviewed, rolling out r123966 and r123967.
http://trac.webkit.org/changeset/123966
http://trac.webkit.org/changeset/123967
https://bugs.webkit.org/show_bug.cgi?id=92656

This patch is causing assertion failures on the debug bot
(also rolling out a dependent patch) (Requested by mrobinson
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-30

Source/WebCore:

* GNUmakefile.am:
* GNUmakefile.list.am:
* platform/text/gtk/TextCheckerEnchant.cpp: Removed.
* platform/text/gtk/TextCheckerEnchant.h: Removed.

Source/WebKit/gtk:

* webkit/webkitspellcheckerenchant.cpp:
(_WebKitSpellCheckerEnchantPrivate):
(createEnchantBrokerIfNeeded):
(freeSpellCheckingLanguage):
(webkit_spell_checker_enchant_finalize):
(webkit_spell_checker_enchant_class_init):
(webkit_spell_checker_enchant_init):
(wordEndIsAContractionApostrophe):
(checkSpellingOfString):
(getGuessesForWord):
(getAvailableDictionariesCallback):
(updateSpellCheckingLanguages):
(learnWord):
(ignoreWord):

Source/WebKit2:

* GNUmakefile.am:
* GNUmakefile.list.am:
* UIProcess/API/gtk/WebKitPrivate.h:
* UIProcess/API/gtk/WebKitTextChecker.cpp: Removed.
* UIProcess/API/gtk/WebKitTextChecker.h: Removed.
* UIProcess/API/gtk/WebKitWebContext.cpp:
(_WebKitWebContextPrivate):
(createDefaultWebContext):
* UIProcess/API/gtk/WebKitWebContext.h:
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
* UIProcess/API/gtk/tests/TestWebKitWebContext.cpp:
(beforeAll):

Tools:

* gtk/generate-gtkdoc:
(get_webkit2_options):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoASSERTION FAILED: !rect.isEmpty() : void WebCore::GraphicsContext::drawRect(const...
jchaffraix@webkit.org [Mon, 30 Jul 2012 17:24:14 +0000 (17:24 +0000)]
ASSERTION FAILED: !rect.isEmpty()  : void WebCore::GraphicsContext::drawRect(const WebCore::IntRect &)
https://bugs.webkit.org/show_bug.cgi?id=92187

Reviewed by Simon Fraser.

Source/WebCore:

The border painting logic (RenderBoxModelObject::paintOneBorderSide) would pass a rect with a 0px length
to RenderObject::drawLineForBoxSide. We do check the width (thickness) but not the length so we would pass
the rect to GraphicsContext and hit the ASSERT. This change adds a check for the length too as it is the safest
way, it means that we may still do unneeded operations before bailing out but that's an existing problem in the code.

Tests: fast/borders/0px-borders-no-line-height.html
       fast/borders/double-1px-border-assert.html

* rendering/RenderObject.cpp:
(WebCore::RenderObject::drawLineForBoxSide):
Added a 0px length check. While renaming confusing variables and re-using others,
I also found a potential empty border that I fixed (tested by the 2nd case above).

LayoutTests:

* fast/borders/0px-borders-no-line-height-expected.html: Added.
* fast/borders/0px-borders-no-line-height.html: Added.
* fast/borders/double-1px-border-assert-expected.html: Added.
* fast/borders/double-1px-border-assert.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Refactor the computation of resampled bitmap size in
senorblanco@chromium.org [Mon, 30 Jul 2012 17:22:35 +0000 (17:22 +0000)]
[chromium] Refactor the computation of resampled bitmap size in
drawImage and drawPattern.
https://bugs.webkit.org/show_bug.cgi?id=92408

Reviewed by Adrienne Walker.

Source/WebCore:

We used to have a special-purpose function called TransformDimensions()
which did pretty much the same thing as SkRect::mapRect() does.  This
change unifies the drawPattern code to use mapRect() in the same way
that drawImage() does.

Covered by existing tests, e.g., fast/backgrounds/size/*.

* platform/graphics/skia/ImageSkia.cpp:
(WebCore):
(WebCore::Image::drawPattern):
Note:  we're now doing using the original (float) source rect, and
converting to int only after applying the matrix transform.  This
might result in different decisions about resampling mode, but it's
more correct anyway.

LayoutTests:

Mark a test as expected to fail (will need rebaseline).

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][DRT] fast/text/font-variant-ligatures.html fails with missing rendering output
commit-queue@webkit.org [Mon, 30 Jul 2012 17:19:18 +0000 (17:19 +0000)]
[EFL][DRT] fast/text/font-variant-ligatures.html fails with missing rendering output
https://bugs.webkit.org/show_bug.cgi?id=85606

Unreviewed, EFL gardening.

Unskip test that's passing after r123864 due to complex font support.

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-07-30

* platform/efl/TestExpectations: font-variant-ligatures.html unskipped.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Add a non-subprocess jhbuild environment and use it for run-gtk-tests
mrobinson@webkit.org [Mon, 30 Jul 2012 17:17:36 +0000 (17:17 +0000)]
[GTK] Add a non-subprocess jhbuild environment and use it for run-gtk-tests
https://bugs.webkit.org/show_bug.cgi?id=92626

Reviewed by Gustavo Noronha Silva.

Instead of always shelling out to enter a jhbuild environment, add a Python
hook for entering a jhbuild environment directly. This avoids requiring a
script to be wrapped in jhbuild.

* GNUmakefile.am: Remove gtk/run-api-tests from the distribution list.
* Scripts/run-gtk-tests: Move most of the logic from run-api-tests here
with additional code for entering a jhbuild environment directly.
* gtk/run-api-tests: Removed.
* jhbuild/jhbuild-wrapper: Use the new helper methods defined in jhbuildutils.py.
* jhbuild/jhbuildutils.py: Add some new helper methods here including
a method which can transform the current environment into a jhbuild-ified one.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, upgrade apavlov to reviewer.
apavlov@chromium.org [Mon, 30 Jul 2012 16:35:09 +0000 (16:35 +0000)]
Unreviewed, upgrade apavlov to reviewer.
http://lists.webkit.org/mailman/private/webkit-committers/2012-July/000184.html

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttps://bugs.webkit.org/show_bug.cgi?id=92642
commit-queue@webkit.org [Mon, 30 Jul 2012 16:32:57 +0000 (16:32 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=92642
[Bindings]Remove custom JS/V8 bindings for WebSocket::close() using [Clamp]

Patch by Vineet Chaudhary <rgf748@motorola.com> on 2012-07-30
Reviewed by Kentaro Hara.

With support of [Clamp] as extended attribute we can replace custom bindings from WebSocket::close().
Spec for WebSocket::close() : http://www.whatwg.org/specs/web-apps/current-work/multipage/network.html#websocket

No new tests. There should be no behavioural changes
Existing tests under http/websocket/tests/hybi/ should cover this.

* Modules/websockets/WebSocket.h:
(WebCore::WebSocket::close):
* Modules/websockets/WebSocket.idl: Used [Clamp].
* bindings/js/JSWebSocketCustom.cpp: Removed custom call close().
(WebCore):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheck):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateParametersCheck):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionClassMethodWithClamp):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::classMethodWithClampCallback):
* bindings/v8/custom/V8WebSocketCustom.cpp: Removed custom call close().
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening. Unkskip more passing tests after bug85203.
ossy@webkit.org [Mon, 30 Jul 2012 16:19:48 +0000 (16:19 +0000)]
[Qt] Unreviewed gardening. Unkskip more passing tests after bug85203.

* platform/qt-5.0-wk1/Skipped:
* platform/qt-5.0-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Resource agent's reference to cached resources should be weak.
vsevik@chromium.org [Mon, 30 Jul 2012 15:58:48 +0000 (15:58 +0000)]
Web Inspector: Resource agent's reference to cached resources should be weak.
https://bugs.webkit.org/show_bug.cgi?id=92108

Reviewed by Pavel Feldman.

.:

* Source/autotools/symbols.filter:

Source/WebCore:

NetworkResourcesData now stores a raw pointer to CachedResource.
CachedResource now notifies InspectorInstrumentation that it will be destroyed.
InspectorInstrumentation stores a set of InstrumentingAgents and broadcasts willDestroyCachedResource event to all available resourceAgents.
Destroyed resources content is saved to NetworkResourcesData.

Tests: http/tests/inspector/network/cached-resource-destroyed-moved-to-storage.html
       http/tests/inspector/network/cached-resource-destroyed-too-big-discarded.html

* WebCore.exp.in:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::inspectedPageDestroyed):
* inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::willDestroyCachedResourceImpl):
(WebCore::InspectorInstrumentation::registerInstrumentingAgents):
(WebCore::InspectorInstrumentation::unregisterInstrumentingAgents):
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willDestroyCachedResource):
(WebCore):
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::didReceiveData):
(WebCore::InspectorResourceAgent::willDestroyCachedResource):
(WebCore):
(WebCore::InspectorResourceAgent::getResponseBody):
* inspector/InspectorResourceAgent.h:
(InspectorResourceAgent):
* inspector/NetworkResourcesData.cpp:
(WebCore::NetworkResourcesData::ResourceData::ResourceData):
(WebCore::NetworkResourcesData::ResourceData::setContent):
(WebCore::NetworkResourcesData::setResourceContent):
(WebCore::NetworkResourcesData::removeCachedResource):
(WebCore):
* inspector/NetworkResourcesData.h:
(ResourceData):
(WebCore::NetworkResourcesData::ResourceData::base64Encoded):
(WebCore::NetworkResourcesData::ResourceData::cachedResource):
(NetworkResourcesData):
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::~CachedResource):
(WebCore::CachedResource::removeClient):
(WebCore::CachedResource::deleteIfPossible):
(WebCore):
* loader/cache/CachedResource.h:
(CachedResource):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::garbageCollectDocumentResourcesTimerFired):
(WebCore::CachedResourceLoader::garbageCollectDocumentResources):
(WebCore::CachedResourceLoader::clearPreloads):
* loader/cache/CachedResourceLoader.h:
(CachedResourceLoader):
* loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::evict):
* testing/InternalSettings.cpp:
* testing/Internals.cpp:
(WebCore::Internals::garbageCollectDocumentResources):
(WebCore):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:

Source/WebKit2:

* win/WebKit2.def:
* win/WebKit2CFLite.def:

LayoutTests:

* http/tests/inspector/network/cached-resource-destroyed-moved-to-storage-expected.txt: Added.
* http/tests/inspector/network/cached-resource-destroyed-moved-to-storage.html: Added.
* http/tests/inspector/network/cached-resource-destroyed-too-big-discarded-expected.txt: Added.
* http/tests/inspector/network/cached-resource-destroyed-too-big-discarded.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Adapt to changes in the SharedArray platform API
commit-queue@webkit.org [Mon, 30 Jul 2012 15:54:53 +0000 (15:54 +0000)]
[BlackBerry] Adapt to changes in the SharedArray platform API
https://bugs.webkit.org/show_bug.cgi?id=92631

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-07-30
Reviewed by Rob Buis.

Adapt to changes in the SharedArray platform API. No behavioural change.

Source/WebKit/blackberry:

Reviewed internally by Joe Mason.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::getBackForwardList):
* Api/WebPage.h:
* Api/WebPageClient.h:
* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::runOpenPanel):

Tools:

* DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
(LayoutTestController::webHistoryItemCount):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Gardening. Skip failing tests and add a Qt specific expected file.
ossy@webkit.org [Mon, 30 Jul 2012 15:47:33 +0000 (15:47 +0000)]
[Qt] Gardening. Skip failing tests and add a Qt specific expected file.

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-07-30
Reviewed by Csaba Osztrogonác.

* platform/qt-4.8/Skipped: Skip svg/custom/svg-features.html.
* platform/qt/Skipped: Skip http/tests/security/contentSecurityPolicy/object-src-none-blocked.html.
* platform/qt/http/tests/security/xss-DENIED-xsl-document-securityOrigin-expected.txt: Added because of a whitespace difference.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Default sizes for input-text and text-area are different when running DRT/WTR
ossy@webkit.org [Mon, 30 Jul 2012 15:43:02 +0000 (15:43 +0000)]
[Qt] Default sizes for input-text and text-area are different when running DRT/WTR
https://bugs.webkit.org/show_bug.cgi?id=91990

Unreviewed gardening.

* platform/qt-5.0-wk2/Skipped: Skip tests.
* platform/qt-5.0/Skipped: Unskip accidentally skipped tests.
* platform/qt.5-0/fast/text/whitespace/028-expected.png: Remove accidentally committed file.
* platform/qt.5-0/fast/text/whitespace/028-expected.txt: Remove accidentally committed file.
* platform/qt/Skipped: Unskip non-existing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Skip new compositing tests for EFL port
commit-queue@webkit.org [Mon, 30 Jul 2012 15:39:04 +0000 (15:39 +0000)]
[EFL] Skip new compositing tests for EFL port
https://bugs.webkit.org/show_bug.cgi?id=92633

Unreviewed EFL gardening.

Skip new compositing layout tests until accelerated compositing is enabled.

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-07-30

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoProhibit having AuthorShadowDOM of input or textarea element for a while and having...
shinyak@chromium.org [Mon, 30 Jul 2012 15:16:24 +0000 (15:16 +0000)]
Prohibit having AuthorShadowDOM of input or textarea element for a while and having a flag to enable it in Internals.
https://bugs.webkit.org/show_bug.cgi?id=92611

Reviewed by Hajime Morita.

.:

* Source/autotools/symbols.filter:

Source/WebCore:

Prohibit having AuthorShadowDOM of input elemnet unless a flag in RuntimeEnabledFeatures is not enabled.
The flag can be enabled in Internals.

The elements in UserAgentShadowDOM of input element assume that they have a renderer when the input
element has a renderer. However, this does not hold when AuthorShadowDOM is added to input element.
So until we fix the issue, we should disable to have AuthorShadowDOM for input element, because it may
cause crashes and security problems.

Tests: fast/dom/shadow/input-with-validation-without-shadow.html
       fast/dom/shadow/input-with-validation.html
       fast/dom/shadow/shadow-disable.html

* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
* bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::authorShadowDOMForAnyElementEnabled):
(WebCore::RuntimeEnabledFeatures::setAuthorShadowDOMForAnyElementEnabled):
* dom/ShadowRoot.cpp:
(WebCore::allowsAuthorShadowRoot): The input element or textarea element does not allow to have a ShadowDOM unless
is a flag in RuntimeEnabledFeatures is not enabled.
* html/HTMLInputElement.h:
(WebCore::isHTMLInputElement):
(WebCore):
* html/HTMLTextAreaElement.h:
(WebCore::isHTMLTextAreaElement):
(WebCore):
* testing/Internals.cpp:
(WebCore::Internals::setAuthorShadowDOMForAnyElementEnabled):
(WebCore):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:

LayoutTests:

* fast/dom/shadow/input-with-validation-without-shadow.html: Make the test runs even if
new WebKitShadowRoot() throws an exception.
* fast/dom/shadow/input-with-validation.html: Sets a flag to make AuthorShadowDOM available.
* fast/dom/shadow/shadow-disable-expected.txt:
* fast/dom/shadow/shadow-disable.html: Makes it unavailable for input and textarea to have an AuthorShadowDOM.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: support --line-numbers mapping for SASS
pfeldman@chromium.org [Mon, 30 Jul 2012 15:12:23 +0000 (15:12 +0000)]
Web Inspector: support --line-numbers mapping for SASS
https://bugs.webkit.org/show_bug.cgi?id=92400

Reviewed by Vsevolod Vlasov.

There is --debug-info and --line-numbers ways of referencing the source scss file, adding support for --line-numbers here.

* inspector/front-end/SASSSourceMapping.js:
(WebInspector.SASSSourceMapping.prototype._resourceAdded.didRequestContent):
(WebInspector.SASSSourceMapping.prototype._resourceAdded):
(_bindUISourceCode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImplement datalist UI for input type color for Chromium
keishi@webkit.org [Mon, 30 Jul 2012 14:32:16 +0000 (14:32 +0000)]
Implement datalist UI for input type color for Chromium
https://bugs.webkit.org/show_bug.cgi?id=92075

Reviewed by Kent Tamura.

Source/Platform:

* chromium/public/WebLocalizedString.h: Added OtherColorLabel.

Source/WebCore:

Test: platform/chromium/fast/forms/color/color-suggestion-picker-appearance.html

* rendering/RenderThemeChromiumCommon.cpp:
(WebCore::RenderThemeChromiumCommon::supportsDataListUI): Added color to types supporting datalist.

Source/WebKit/chromium:

Integrated ColorChooserProxy and WebColorChooserClientImpl into ColorChooserUIController.
ColorChooserUIController can control whether to open the color suggestion picker
popup or the color chooser depending on the responses from ColorChooserClient.

* WebKit.gyp:
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::createColorChooser): Returns ColorChooserUIController which is a ColorChooser.
(WebKit::ChromeClientImpl::createWebColorChooser): Returns WebColorChooser that was created by Chromium.
* src/ChromeClientImpl.h:
(WebKit):
(ChromeClientImpl):
* src/ColorChooserProxy.cpp: Removed.
* src/ColorChooserProxy.h: Removed.
* src/ColorChooserUIController.cpp: Added.
(WebKit):
(WebKit::ColorChooserUIController::ColorChooserUIController): Controls the UI for color chooser. Opens the color suggestion picker popup or color chooser depending on the ColorChooserClient.
(WebKit::ColorChooserUIController::~ColorChooserUIController):
(WebKit::ColorChooserUIController::setSelectedColor):
(WebKit::ColorChooserUIController::endChooser): This is called by WebCore so we close both the popup and the color chooser.
(WebKit::ColorChooserUIController::didChooseColor):
(WebKit::ColorChooserUIController::didEndChooser):
(WebKit::ColorChooserUIController::contentSize): The popup will be resized later from JS so we return an arbitrary size.
(WebKit::ColorChooserUIController::writeDocument):
(WebKit::ColorChooserUIController::setValueAndClosePopup): Performs action based on the numValue.
(WebKit::ColorChooserUIController::didClosePopup):
(WebKit::ColorChooserUIController::openPopup): Opens color chooser suggestion popup.
(WebKit::ColorChooserUIController::closePopup):
(WebKit::ColorChooserUIController::openColorChooser): Opens color chooser.
* src/ColorChooserUIController.h: Renamed from Source/WebKit/chromium/src/WebColorChooserClientImpl.h.
(WebCore):
(WebKit):
(ColorChooserUIController):
* src/WebColorChooserClientImpl.cpp: Removed.

LayoutTests:

* platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png: Added.
* platform/chromium/TestExpectations:
* platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.txt: Added.
* platform/chromium/fast/forms/color/color-suggestion-picker-appearance.html: Added. Tests color suggestion picker popup appearance.
* platform/chromium/fast/forms/datalist/input-list-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWheel events on a page with frames are not handled in fixed layout
allan.jensen@nokia.com [Mon, 30 Jul 2012 14:23:13 +0000 (14:23 +0000)]
Wheel events on a page with frames are not handled in fixed layout
https://bugs.webkit.org/show_bug.cgi?id=90550

Reviewed by Antonio Gomes.

Based on patch by Andras Becsi.

Frame-rect size is not the right value to check against to see if the document
can be contained within the full visible content rect, since it does not handle
fixedVisibleContentRect. Instead visibleContentRect(true) should be used which
returns the full visible content rect disregarding scrollbars, and which is
the same a frame-rect size when fixedVisibleContentRect is not set.

* platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124024 268f45cc-cd09-0410-ab3c-d52691b4dbfc