WebKit-https.git
9 years ago2011-02-03 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Fri, 4 Feb 2011 00:37:11 +0000 (00:37 +0000)]
2011-02-03  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Nate Chapin.

        SerializedScriptValue should not require v8 to create undefined and null values
        https://bugs.webkit.org/show_bug.cgi?id=53730

        Instead of creating a v8 type and passing that into the constructor, just use
        the writer class directly. While I was at it, I cleaned up the code a bit too
        by getting rid of the WireData/StringValue enum as I found that personally
        confusing.

        This is necessary because these methods are called by IndexedDB in the browser
        process where v8 is not spun up.

        No functionality changed and not possible to test.

        * bindings/v8/SerializedScriptValue.cpp:
        (WebCore::SerializedScriptValue::createFromWire):
        (WebCore::SerializedScriptValue::create):
        (WebCore::SerializedScriptValue::nullValue):
        (WebCore::SerializedScriptValue::undefinedValue):
        (WebCore::SerializedScriptValue::release):
        (WebCore::SerializedScriptValue::SerializedScriptValue):
        * bindings/v8/SerializedScriptValue.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 4 Feb 2011 00:27:37 +0000 (00:27 +0000)]
2011-02-03  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Not all blocks are freed when the heap is freed (counting is hard!)
        https://bugs.webkit.org/show_bug.cgi?id=53732

        * runtime/MarkedSpace.cpp:
        (JSC::MarkedSpace::destroy): Freeing a block compacts the list, so just
        keep freeing block 0 until there are no blocks left.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 4 Feb 2011 00:18:24 +0000 (00:18 +0000)]
2011-02-03  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, build fix.

        Actually make the changes suggested by Mihai in his review
        of bug 53720 :(

        https://bugs.webkit.org/show_bug.cgi?id=53720

        * Scripts/webkitpy/layout_tests/port/test_files.py:
        * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix for <rdar://problem/8944544> Ability to animate track
bdakin@apple.com [Fri, 4 Feb 2011 00:17:53 +0000 (00:17 +0000)]
Fix for <rdar://problem/8944544> Ability to animate track
for WKPainter scrollers

Reviewed by Sam Weinig.

Source/WebCore:

Two new WebKitSystemInterface functions.
* WebCore.exp.in:
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:

Use Scrollbar::convertFromContainingView() to return the right point.
* platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]):

ScrollKnobAnimation is now ScrollbarPartAnimation. It can
now be used to animate the knob or the track.
(-[ScrollbarPartAnimation initWithScrollbarPainter:part:WebCore::scrollAnimator:WebCore::animateAlphaTo:duration:]):
(-[ScrollbarPartAnimation setCurrentProgress:]):
(-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):

Scrollbars need invalodating after the overlay state changes.
(-[ScrollbarPainterDelegate scrollerImp:overlayScrollerStateChangedTo:]):

Source/WebKit/mac:

* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

Source/WebKit2:

* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 4 Feb 2011 00:16:47 +0000 (00:16 +0000)]
2011-02-03  Dimitri Glazkov  <dglazkov@chromium.org>

        Added SL-specific result for the test and put back the original result that
        I've neglected to do in r77539.

        * platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Added.
        * platform/mac/svg/text/font-size-below-point-five-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 4 Feb 2011 00:15:18 +0000 (00:15 +0000)]
2011-02-03  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Mihai Parparita.

        new-run-webkit-tests: Fix bug introduced in r77434 that was
        causing us to run the canvas GPU tests on the Mac GPU port. This
        bug revealed that we were not setting the port.name() field
        properly in many cases, so I've cleaned up all of that code, and
        removed a few comments about "version-specific" GPU ports that
        don't exist and just confused things.

        Testing also revealed that port.abspath_for_test() wasn't
        normalizing paths on Windows properly, so I fixed that as well.

        https://bugs.webkit.org/show_bug.cgi?id=53719

        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
        * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 4 Feb 2011 00:13:43 +0000 (00:13 +0000)]
2011-02-03  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Mihai Parparita.

        new-run-webkit-tests: fix normalization of paths on windows when gathering files

        r77434 introduced a bug that was causing the test expectations
        for the GPU ports to not be treated properly. It turns out that
        when we gathered the list of test files on Windows, we would
        return paths of the form "c:\LayoutTests/fast/canvas", and the
        mixture of backslashes and forward slashes was confusing things.

        This patch normalizes all of the filenames returned from
        test_files.find(), and adds better tests for this (fixing a
        couple of other bugs found in the meantime).

        https://bugs.webkit.org/show_bug.cgi?id=53720

        * Scripts/webkitpy/layout_tests/port/test.py:
        * Scripts/webkitpy/layout_tests/port/test_files.py:
        * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoScroll thumb jumps to top when resizing horizontally.
weinig@apple.com [Fri, 4 Feb 2011 00:11:25 +0000 (00:11 +0000)]
Scroll thumb jumps to top when resizing horizontally.

Reviewed by Beth Dakin.

* platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars): Add call to update
the scrollbar's offset in the case where we may have created
a new scrollbar but have not changed the current position.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Fri, 4 Feb 2011 00:07:45 +0000 (00:07 +0000)]
2011-02-03  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Dirk Schulze.

        startAnimations should use a local, RefCounted Vector.
        https://bugs.webkit.org/show_bug.cgi?id=53458

        Test: svg/custom/use-animation-in-fill.html

        * svg/SVGDocumentExtensions.cpp:
        (WebCore::SVGDocumentExtensions::startAnimations):
2011-02-03  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Dirk Schulze.

        startAnimations should use a local, RefCounted Vector.
        https://bugs.webkit.org/show_bug.cgi?id=53458

        * svg/custom/use-animation-in-fill-expected.txt: Added.
        * svg/custom/use-animation-in-fill.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
ossy@webkit.org [Thu, 3 Feb 2011 23:54:10 +0000 (23:54 +0000)]
Unreviewed.

small text which is scaled to be large renders pixelated
https://bugs.webkit.org/show_bug.cgi?id=12448

* platform/qt/Skipped: Add failing tests until fix.
 - css3/zoom-coords.xhtml
 - svg/zoom/page/zoom-zoom-coords.xhtml

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 3 Feb 2011 23:38:42 +0000 (23:38 +0000)]
2011-02-03  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Change DidSetSize to take a LayerTreeContext parameter
        https://bugs.webkit.org/show_bug.cgi?id=53724

        Since SetSize can cause layout to happen, we need to pass along a layer tree context to
        the DidSetSize message so the UI process can enter/exit accelerated compositing mode appropriately.

        * Shared/LayerTreeContext.h:
        * Shared/mac/LayerTreeContextMac.mm:
        Add equality operators to LayerTreeContext.

        * UIProcess/DrawingAreaProxy.h:
        (WebKit::DrawingAreaProxy::didSetSize):
        This now takes a LayerTreeContext parameter.

        * UIProcess/DrawingAreaProxy.messages.in:
        Add LayerTreeContext parameter.

        * UIProcess/DrawingAreaProxyImpl.cpp:
        Get rid of m_isInAcceleratedCompositingMode and use the current layer context instead.

        (WebKit::DrawingAreaProxyImpl::paint):
        Bail if the call to DidSetSize ended up entering accelerated compositing mode.

        (WebKit::DrawingAreaProxyImpl::didSetSize):
        If the new layer tree context is different, enter/exit accelerated compositing mode accordingly.

        (WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
        (WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode):
        Update the layer tree context.

        * UIProcess/DrawingAreaProxyImpl.h:
        (WebKit::DrawingAreaProxyImpl::isInAcceleratedCompositingMode):
        Add simple getter.

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::setSize):
        Pass along the layer tree context.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 3 Feb 2011 23:34:57 +0000 (23:34 +0000)]
2011-02-03  Adam Barth  <abarth@webkit.org>

        Reviewed by Daniel Bates.

        XSSFilter shouldn't bother to analyze pages without "injection"
        characters in the request
        https://bugs.webkit.org/show_bug.cgi?id=53664

        If the request lacks these "injection" characters, then it's unlikely
        that there's a reflective XSS attack happening.  This hueristic lets us
        avoid analyzing the vast majority of responses for XSS.  Of course, the
        hueristic isn't perfect.  Because of this huerstic, we miss out on
        injections into unquoted attributes.  However, it's a trade-off that's
        worked well in the XSSAuditor.

        * html/parser/XSSFilter.cpp:
        (WebCore::HTMLNames::isRequiredForInjection):
        (WebCore::XSSFilter::XSSFilter):
        (WebCore::XSSFilter::init):
        (WebCore::XSSFilter::filterToken):
        (WebCore::XSSFilter::isContainedInRequest):
        * html/parser/XSSFilter.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 3 Feb 2011 23:34:49 +0000 (23:34 +0000)]
2011-02-03  Dimitri Glazkov  <dglazkov@chromium.org>

        Add a failure until I investigate its cause.

        * platform/chromium/test_expectations.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 3 Feb 2011 23:26:36 +0000 (23:26 +0000)]
2011-02-03  Dimitri Glazkov  <dglazkov@chromium.org>

        Updated platform/mac-leopard baselines for fast/backgrounds after r77485.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 3 Feb 2011 23:16:52 +0000 (23:16 +0000)]
2011-02-03  Dimitri Glazkov  <dglazkov@chromium.org>

        Move Leopard result to the right spot, put back the original result.

        * platform/mac-leopard/svg/text/font-size-below-point-five-expected.txt:
            Renamed from LayoutTests/platform/mac/svg/text/font-size-below-point-five-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkip an SVG test that fails depending on what other tests came before it
aroben@apple.com [Thu, 3 Feb 2011 23:09:27 +0000 (23:09 +0000)]
Skip an SVG test that fails depending on what other tests came before it

Running any other SVG test before this one causes it to fail. If we were to check in new
failing results, it might start passing again if some more tests are added before it that
make it the first test that is run for a particular invocation of DumpRenderTree. So the
safest thing to do for now is to skip it. <http://webkit.org/b/35700> tracks this failure.

* platform/win/Skipped: Added svg/W3C-SVG-1.1-SE/types-dom-01-b.svg.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd links to Windows crash logs in results.html
aroben@apple.com [Thu, 3 Feb 2011 22:54:33 +0000 (22:54 +0000)]
Add links to Windows crash logs in results.html

Fixes <http://webkit.org/b/53718> run-webkit-tests should link to Windows crash logs in
results.html

Reviewed by David Kilzer.

* Scripts/old-run-webkit-tests:
(top level): Added $crashLogTag and $windowsCrashLogFilePrefix (which came from
createDebuggerCommandFile).
(testCrashedOrTimedOut): If the test crashed, capture any saved crash log after the dump
tool has exited.
(captureSavedCrashLog): Added. Finds the crash log for the test that just crashed and moves
it into the test results directory tree. Only implemented for Cygwin currently.
(findNewestFileMatchingGlob): Added. Does what it says.
(htmlForResultsSection): Only link to files that exist.
(linksForErrorTest): Add a link to the crash log.
(deleteExpectedAndActualResults): Delete any old crash log for this test.
(createDebuggerCommandFile): Use the new $windowsCrashLogFilePrefix constant instead of
hardcoding it here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 3 Feb 2011 22:51:17 +0000 (22:51 +0000)]
2011-02-03  Dimitri Glazkov  <dglazkov@chromium.org>

        Updated platform/mac and platform/mac-leopard baselines for svg/ after r77485.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 3 Feb 2011 22:36:28 +0000 (22:36 +0000)]
2011-02-03  Martin Robinson  <mrobinson@igalia.com>

        Fix GTK+ WebGL build after r76600.

        * configure.ac: Make sure to respect configure.ac conventions
        consistently when it comes to capitalization. Remove an old
        reference to enable_3d_canvas.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGet rid of LayerTreeContext::seed on Mac.
andersca@apple.com [Thu, 3 Feb 2011 22:27:24 +0000 (22:27 +0000)]
Get rid of LayerTreeContext::seed on Mac.
Add sequence checks to enterAcceleratedCompositingMode and exitAcceleratedCompositingMode and
have them call newly added overloads that don't have the checks.

Reviewed by Dan Bernstein.

* Shared/LayerTreeContext.h:
* Shared/mac/LayerTreeContextMac.mm:
(WebKit::LayerTreeContext::LayerTreeContext):
(WebKit::LayerTreeContext::encode):
(WebKit::LayerTreeContext::decode):
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
(WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode):
* UIProcess/DrawingAreaProxyImpl.h:
* WebProcess/WebPage/mac/LayerTreeHostMac.mm:
(WebKit::LayerTreeHostMac::LayerTreeHostMac):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 3 Feb 2011 22:19:53 +0000 (22:19 +0000)]
2011-02-03  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Get rid of timestamps in UpdateInfo
        https://bugs.webkit.org/show_bug.cgi?id=53713

        Add a 64-bit sequence number to all DrawingAreaProxy messages, and use it to
        check whether Update messages should be handled or not.

        * Shared/UpdateInfo.cpp:
        (WebKit::UpdateInfo::encode):
        (WebKit::UpdateInfo::decode):
        * Shared/UpdateInfo.h:
        (WebKit::UpdateInfo::UpdateInfo):
        * UIProcess/BackingStore.cpp:
        (WebKit::BackingStore::BackingStore):
        (WebKit::BackingStore::incorporateUpdate):
        * UIProcess/BackingStore.h:
        * UIProcess/DrawingAreaProxy.h:
        (WebKit::DrawingAreaProxy::update):
        (WebKit::DrawingAreaProxy::didSetSize):
        (WebKit::DrawingAreaProxy::enterAcceleratedCompositingMode):
        (WebKit::DrawingAreaProxy::exitAcceleratedCompositingMode):
        * UIProcess/DrawingAreaProxy.messages.in:
        * UIProcess/DrawingAreaProxyImpl.cpp:
        (WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl):
        (WebKit::DrawingAreaProxyImpl::update):
        (WebKit::DrawingAreaProxyImpl::didSetSize):
        (WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
        (WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode):
        * UIProcess/DrawingAreaProxyImpl.h:
        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::generateSequenceNumber):
        (WebKit::DrawingAreaImpl::setSize):
        (WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode):
        (WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
        (WebKit::DrawingAreaImpl::display):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Vangelis Kokkevis <vangelis@chromium.org>
vangelis@chromium.org [Thu, 3 Feb 2011 21:51:24 +0000 (21:51 +0000)]
2011-02-03  Vangelis Kokkevis  <vangelis@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Fixing a compositor crash occurring on layers
        without an associated RenderSurface.
        https://bugs.webkit.org/show_bug.cgi?id=53679
        Regression was introduced by in r77425

        Test: http://webkit.org/blog/386/3d-transforms/ doesn't crash
        anymore.

        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::drawLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 3 Feb 2011 21:44:24 +0000 (21:44 +0000)]
2011-02-03  Dimitri Glazkov  <dglazkov@chromium.org>

        [Chromium] Updated baselines that are specific to Leopard.

        * platform/chromium-mac-leopard/svg/custom/linking-a-03-b-preserveAspectRatio-expected.txt:
        * platform/chromium-mac-leopard/svg/custom/linking-a-03-b-viewTarget-expected.txt:
        * platform/chromium-mac-leopard/svg/custom/linking-a-03-b-zoomAndPan-expected.txt:
        * platform/chromium-mac-leopard/svg/custom/stroked-pattern-expected.png:
        * platform/chromium-mac-leopard/svg/custom/stroked-pattern-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/8948788> Text emphasis marks have wrong orientation for vertical...
mitz@apple.com [Thu, 3 Feb 2011 21:19:58 +0000 (21:19 +0000)]
<rdar://problem/8948788> Text emphasis marks have wrong orientation for vertical text
https://bugs.webkit.org/show_bug.cgi?id=53709

Reviewed by Anders Carlsson.

Source/WebCore:

Covered by rendering of fast/text/emphasis-vertical.html

* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::scaledFontData): Give the scaled font the same orientation this font
has.

LayoutTests:

* platform/mac/fast/text/emphasis-vertical-expected.checksum:
* platform/mac/fast/text/emphasis-vertical-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 3 Feb 2011 20:50:01 +0000 (20:50 +0000)]
2011-02-03  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        Don't send enter/exit accelerated compositing mode messages when handling setSize
        https://bugs.webkit.org/show_bug.cgi?id=53706

        Don't send EnterAcceleratedCompositingMode/ExitAcceleratedCompositing mode when
        the mode changes happen as a result of relayout in setSize, since an updated state
        is going to be sent back in the DidSetSize message.

        * UIProcess/DrawingAreaProxyImpl.cpp:
        (WebKit::DrawingAreaProxyImpl::didSetSize):
        Add an assert.

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::DrawingAreaImpl):
        Initialize m_inSetSize.

        (WebKit::DrawingAreaImpl::setRootCompositingLayer):
        Factor out code into enterAcceleratedCompositingMode and exitAcceleratedCompositingMode.

        (WebKit::DrawingAreaImpl::setSize):
        Set m_inSetSize to true while handling setSize.

        (WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode):
        (WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
        Take over the message sending responsibility from LayerTreeHostMac, and don't send messages
        if we're currently handling a SetSize message.

        * WebProcess/WebPage/DrawingAreaImpl.h:
        Add m_inSetSize.

        * WebProcess/WebPage/LayerTreeHost.h:
        Add layerTreeHost getter.

        * WebProcess/WebPage/mac/LayerTreeHostMac.h:
        * WebProcess/WebPage/mac/LayerTreeHostMac.mm:
        (WebKit::LayerTreeHostMac::LayerTreeHostMac):
        Don't send EnterAcceleratedCompositingMode messages.

        (WebKit::LayerTreeHostMac::layerTreeContext):
        Add getter for the current layer tree context.

        (WebKit::LayerTreeHostMac::invalidate):
        Don't send ExitAcceleratedCompositingMode messages.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 3 Feb 2011 20:42:03 +0000 (20:42 +0000)]
2011-02-03  Martin Robinson  <mrobinson@igalia.com>

        Fix one GTK+ skipped list entry that referred to the wrong test file.

        * platform/gtk/Skipped: Fix skipped list entry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 3 Feb 2011 20:33:11 +0000 (20:33 +0000)]
2011-02-03  Dimitri Glazkov  <dglazkov@chromium.org>

        [Chromium] Removed the checksum that is out of place.

        * platform/chromium-win-xp/svg/text/text-fonts-01-t-expected.checksum: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 3 Feb 2011 20:30:09 +0000 (20:30 +0000)]
2011-02-03  Dimitri Glazkov  <dglazkov@chromium.org>

        [Chromium] Updated SVG baselines after r77485 for Mac and added expectations
        of failure while waiting for platform/mac pixel results to land.

        * platform/chromium-mac/svg/custom/linking-a-03-b-transform-expected.txt: Removed.
        * platform/chromium-mac/svg/custom/stroked-pattern-expected.checksum: Added.
        * platform/chromium-mac/svg/custom/stroked-pattern-expected.png: Added.
        * platform/chromium/test_expectations.txt: Added fails.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry to fix the Mac build.
ggaren@apple.com [Thu, 3 Feb 2011 20:29:02 +0000 (20:29 +0000)]
Try to fix the Mac build.

* JavaScriptCore.xcodeproj/project.pbxproj: The new MarkedBlock.h header
needs to be private, not project, so other projects can include headers
that depend on it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 3 Feb 2011 19:52:52 +0000 (19:52 +0000)]
2011-02-03  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Make the layer tree host keep track of the layer tree context
        https://bugs.webkit.org/show_bug.cgi?id=53698

        Add a LayerTreeContext member variable to the LayerTreeHost object,
        and also add a seed count to the LayerTreeContext so we can keep track of
        how layer tree contexts relate to each other.

        * Shared/LayerTreeContext.h:
        * Shared/mac/LayerTreeContextMac.mm:
        (WebKit::LayerTreeContext::LayerTreeContext):
        (WebKit::LayerTreeContext::makeWithSeed):
        (WebKit::LayerTreeContext::encode):
        (WebKit::LayerTreeContext::decode):

        * WebProcess/WebPage/mac/LayerTreeHostMac.h:
        Add the layer tree context as a member variable.

        * WebProcess/WebPage/mac/LayerTreeHostMac.mm:
        (WebKit::LayerTreeHostMac::LayerTreeHostMac):
        Initialize the layer tree context.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCheck in the results I really meant to commit in r77507
aroben@apple.com [Thu, 3 Feb 2011 19:48:22 +0000 (19:48 +0000)]
Check in the results I really meant to commit in r77507

A flub on the command-line meant that many of the results added in r77507 were identical to
the Mac results, rather than matching what happens on Windows.

* platform/win/svg/W3C-SVG-1.1/text-align-06-b-expected.checksum:
* platform/win/svg/W3C-SVG-1.1/text-align-06-b-expected.png:
* platform/win/svg/W3C-SVG-1.1/text-align-06-b-expected.txt:
* platform/win/svg/batik/masking/maskRegions-expected.checksum: Added.
* platform/win/svg/batik/masking/maskRegions-expected.png: Added.
* platform/win/svg/batik/masking/maskRegions-expected.txt:
* platform/win/svg/batik/text/textGlyphOrientationHorizontal-expected.checksum:
* platform/win/svg/batik/text/textGlyphOrientationHorizontal-expected.png:
* platform/win/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
* platform/win/svg/carto.net/scrollbar-expected.checksum:
* platform/win/svg/carto.net/scrollbar-expected.png:
* platform/win/svg/carto.net/scrollbar-expected.txt:
* platform/win/svg/text/font-size-below-point-five-expected.checksum:
* platform/win/svg/text/font-size-below-point-five-expected.png:
* platform/win/svg/text/font-size-below-point-five-expected.txt:
* platform/win/svg/text/text-align-06-b-expected.checksum:
* platform/win/svg/text/text-align-06-b-expected.png:
* platform/win/svg/text/text-align-06-b-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 3 Feb 2011 19:44:20 +0000 (19:44 +0000)]
2011-02-03  Dimitri Glazkov  <dglazkov@chromium.org>

        [Chromium] Two more updated SVG baselines after r77485 for Linux.

        * platform/chromium-linux/svg/batik/text/verticalText-expected.txt: Added.
        * platform/chromium-linux/svg/custom/js-late-pattern-and-object-creation-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-02 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Thu, 3 Feb 2011 19:31:16 +0000 (19:31 +0000)]
2011-02-02  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Ryosuke Niwa.

        Moving cursor down in table cycles at the end of a row
        https://bugs.webkit.org/show_bug.cgi?id=50012

        Tests downward caret-navigation for tables at the end of a document.

        * editing/selection/move-by-line-cycles-in-table-expected.txt: Added.
        * editing/selection/move-by-line-cycles-in-table.html: Added.
2011-02-02  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Ryosuke Niwa.

        Moving cursor down in table cycles at the end of a row
        https://bugs.webkit.org/show_bug.cgi?id=50012

        Avoids a caret cycling issue with certain content (e.g. tables) found at the very
        end of a document due to a bug in nextLeafWithSameEditability.

        Test: editing/selection/move-by-line-cycles-in-table.html

        * editing/visible_units.cpp:
        (WebCore::nextLeafWithSameEditability): Properly avoid descending back into the
        original leaf node.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 3 Feb 2011 19:28:48 +0000 (19:28 +0000)]
2011-02-03  Dimitri Glazkov  <dglazkov@chromium.org>

        [Chromium] One more update SVG baselines after r77485 for Linux.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Thu, 3 Feb 2011 19:23:42 +0000 (19:23 +0000)]
2011-02-03  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        Start using MarkedBlock instead of CollectorBlock
        https://bugs.webkit.org/show_bug.cgi?id=53693

        SunSpider reports no change.

        * runtime/MarkedBlock.h:
        (JSC::MarkedBlock::blockFor):
        (JSC::MarkedBlock::setMarked):
        (JSC::MarkedBlock::isCellAligned):
        (JSC::MarkedBlock::isPossibleCell): Updated for const-ness.

        * runtime/MarkedSpace.cpp:
        (JSC::MarkedSpace::allocateBlock):
        (JSC::MarkedSpace::containsSlowCase):
        (JSC::MarkedSpace::clearMarkBits): Updated for const-ness.

        * runtime/MarkedSpace.h:
        (JSC::CollectorHeap::collectorBlock):
        (JSC::MarkedSpace::heap):
        (JSC::MarkedSpace::isMarked):
        (JSC::MarkedSpace::testAndSetMarked):
        (JSC::MarkedSpace::setMarked):
        (JSC::MarkedSpace::contains): Switched from CollectorBlock to MarkedBlock,
        and deleted dead CollectorBlock-related code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 3 Feb 2011 19:23:18 +0000 (19:23 +0000)]
2011-02-03  Dimitri Glazkov  <dglazkov@chromium.org>

        [Chromium] Moved XP/Vista-specific baselines to their proper places.

        * platform/chromium-win-vista/svg/text/text-fonts-01-t-expected.checksum:
        * platform/chromium-win-vista/svg/text/text-fonts-01-t-expected.png:
        * platform/chromium-win-xp/svg/batik/text/verticalText-expected.checksum:
        * platform/chromium-win-xp/svg/batik/text/verticalText-expected.png:
        * platform/chromium-win-xp/svg/custom/js-late-pattern-and-object-creation-expected.checksum:
        * platform/chromium-win-xp/svg/custom/js-late-pattern-and-object-creation-expected.png:
        * platform/chromium-win-xp/svg/text/text-intro-05-t-expected.checksum:
        * platform/chromium-win-xp/svg/text/text-intro-05-t-expected.png:
        * platform/chromium-win/svg/batik/text/verticalText-expected.checksum: Removed.
        * platform/chromium-win/svg/batik/text/verticalText-expected.png: Removed.
        * platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.checksum: Removed.
        * platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.png: Removed.
        * platform/chromium-win/svg/text/text-fonts-01-t-expected.checksum: Removed.
        * platform/chromium-win/svg/text/text-fonts-01-t-expected.png: Removed.
        * platform/chromium-win/svg/text/text-intro-05-t-expected.checksum: Removed.
        * platform/chromium-win/svg/text/text-intro-05-t-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 3 Feb 2011 19:05:40 +0000 (19:05 +0000)]
2011-02-03  Dimitri Glazkov  <dglazkov@chromium.org>

        Update expectations after r77495.

        * fast/dom/Window/window-properties-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 3 Feb 2011 18:50:16 +0000 (18:50 +0000)]
2011-02-03  Dimitri Glazkov  <dglazkov@chromium.org>

        [Chromium] Explicitly mark platform/chromium-linux as failing for other platforms.

        * platform/chromium/test_expectations.txt: Added expectation of failure.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTell the debugger the path to the WebKit source tree when saving a crash log
aroben@apple.com [Thu, 3 Feb 2011 18:46:15 +0000 (18:46 +0000)]
Tell the debugger the path to the WebKit source tree when saving a crash log

This allows the debugger to include the crashing line of code in the log.

Fixes <http://webkit.org/b/53678> Crash logs from buildslaves don't show the crashing line
of code

Reviewed by Sam Weinig.

* Scripts/old-run-webkit-tests:
(createDebuggerCommandFile): Added. Saves commands that we'd like the debugger to run to a
file and returns the path to that file. The commands we pass came from
setUpWindowsCrashLogSaving, but I've added a .srcpath command to tell the debugger where the
WebKit source code lives.
(setUpWindowsCrashLogSaving): Instead of specifying the commands directly on the command
line using -c, save them to a file and specify the path to that file using -cf. This works
around what is presumably a bug in Windows's command line parsing, where having multiple
quoted paths in the debugger commands causes the post-mortem debugger not to be invoked at
all. Also pulled the options we pass to the debugger out into a list that is then join()ed
together to make them easier to modify in the future.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 3 Feb 2011 18:41:28 +0000 (18:41 +0000)]
2011-02-03  Dimitri Glazkov  <dglazkov@chromium.org>

        Update expectations after r77495.

        * fast/dom/Window/window-properties-performance-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 3 Feb 2011 18:33:35 +0000 (18:33 +0000)]
2011-02-03  Dimitri Glazkov  <dglazkov@chromium.org>

        [Chromium] Add expectations for r77500.

        * platform/chromium-mac/fast/dom/HTMLInputElement/input-slider-update-expected.checksum: Added.
        * platform/chromium-mac/fast/dom/HTMLInputElement/input-slider-update-expected.png: Added.
        * platform/chromium-win/fast/dom/HTMLInputElement/input-slider-update-expected.checksum: Added.
        * platform/chromium-win/fast/dom/HTMLInputElement/input-slider-update-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Qt build.
weinig@apple.com [Thu, 3 Feb 2011 18:28:14 +0000 (18:28 +0000)]
Fix Qt build.

* UIProcess/API/qt/qwkpage.cpp:
(QWKPage::QWKPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 3 Feb 2011 18:20:57 +0000 (18:20 +0000)]
2011-02-03  Dimitri Glazkov  <dglazkov@chromium.org>

        [Chromium] Update SVG baselines after r77485 for Linux.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Thu, 3 Feb 2011 18:19:24 +0000 (18:19 +0000)]
2011-02-03  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: remove dead code related to changes panel.
        https://bugs.webkit.org/show_bug.cgi?id=53688

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/ChangesView.js: Removed.
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.css:
        (#error-warning-count):
        (#error-warning-count:hover):
        (#error-count + #warning-count):
        * inspector/front-end/inspector.html:
        * inspector/front-end/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd notification of the end of a rubber band.
weinig@apple.com [Thu, 3 Feb 2011 18:13:32 +0000 (18:13 +0000)]
Add notification of the end of a rubber band.
<rdar://problem/8940648>

Reviewed by Anders Carlsson.

Source/WebCore:

* WebCore.exp.in:
Add additional exprots.

* page/ChromeClient.h:
(WebCore::ChromeClient::didCompleteRubberBandForMainFrame):
* page/FrameView.cpp:
(WebCore::FrameView::didCompleteRubberBand):
* page/FrameView.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::didCompleteRubberBand):
* platform/ScrollView.h:
Add hook.

* platform/ScrollableArea.h:
(WebCore::ScrollableArea::inLiveResize):
(WebCore::ScrollableArea::maximumScrollPosition):
(WebCore::ScrollableArea::visibleWidth):
(WebCore::ScrollableArea::overhangAmount):
(WebCore::ScrollableArea::didCompleteRubberBand):
Reorganize and de-virtualize live resize notifications.

* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
Call the new hook when the rubberband ends.

Source/WebKit2:

* UIProcess/API/C/WKPage.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::drawHeader):
(WebKit::WebPageProxy::drawFooter):
(WebKit::WebPageProxy::didCompleteRubberBandForMainFrame):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::didCompleteRubberBandForMainFrame):
* UIProcess/WebUIClient.h:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::didCompleteRubberBandForMainFrame):
* WebProcess/WebCoreSupport/WebChromeClient.h:
Pipe the notification up to the WKUIClient.

Tools:

* MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController awakeFromNib]):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::createOtherPage):
(WTR::TestController::initialize):
Stub out the new WKUIClient function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkip fast/canvas/set-colors.html on Windows
aroben@apple.com [Thu, 3 Feb 2011 18:07:38 +0000 (18:07 +0000)]
Skip fast/canvas/set-colors.html on Windows

It currently fails on some bots but not others.  <http://webkit.org/b/53677> tracks the
investigation.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate Windows results after r77485
aroben@apple.com [Thu, 3 Feb 2011 18:02:25 +0000 (18:02 +0000)]
Update Windows results after r77485

Windows used to match Mac on these tests, but now it doesn't. Presumably this is because
r77485 increased the precision of ascent/descent calculations, making differences in
Windows/Mac font metrics matter more.

One test (svg/W3C-SVG-1.1-SE/types-dom-01-b.svg) is still failing, but it passes when run on
its own, so warrants more investigation.

* platform/win/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.checksum: Added.
* platform/win/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.png: Added.
* platform/win/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.txt:
* platform/win/svg/W3C-SVG-1.1/text-align-06-b-expected.checksum: Added.
* platform/win/svg/W3C-SVG-1.1/text-align-06-b-expected.png: Added.
* platform/win/svg/W3C-SVG-1.1/text-align-06-b-expected.txt: Added.
* platform/win/svg/batik/text/textGlyphOrientationHorizontal-expected.checksum: Added.
* platform/win/svg/batik/text/textGlyphOrientationHorizontal-expected.png: Added.
* platform/win/svg/batik/text/textGlyphOrientationHorizontal-expected.txt: Added.
* platform/win/svg/carto.net/scrollbar-expected.checksum: Added.
* platform/win/svg/carto.net/scrollbar-expected.png: Added.
* platform/win/svg/carto.net/scrollbar-expected.txt: Added.
* platform/win/svg/text/font-size-below-point-five-expected.checksum: Added.
* platform/win/svg/text/font-size-below-point-five-expected.png: Added.
* platform/win/svg/text/font-size-below-point-five-expected.txt: Added.
* platform/win/svg/text/text-align-06-b-expected.checksum: Added.
* platform/win/svg/text/text-align-06-b-expected.png: Added.
* platform/win/svg/text/text-align-06-b-expected.txt: Added.
* platform/win/svg/zoom/page/zoom-mask-with-percentages-expected.checksum: Added.
* platform/win/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
* platform/win/svg/zoom/page/zoom-mask-with-percentages-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 3 Feb 2011 18:00:34 +0000 (18:00 +0000)]
2011-02-03  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed.

        small text which is scaled to be large renders pixelated
        https://bugs.webkit.org/show_bug.cgi?id=12448

        First chunk, updating mac SVG pixel test baseline after r77485.

        * platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png:
        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
...

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Update Qt specific expected results after r77495.
ossy@webkit.org [Thu, 3 Feb 2011 17:54:11 +0000 (17:54 +0000)]
Unreviewed. Update Qt specific expected results after r77495.

* platform/qt/fast/dom/Window/window-properties-expected.txt:
* platform/qt/fast/dom/Window/window-properties-performance-expected.txt: Copied from LayoutTests/fast/dom/Window/window-properties-performance-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-02 Evan Martin <evan@chromium.org>
evan@chromium.org [Thu, 3 Feb 2011 17:49:44 +0000 (17:49 +0000)]
2011-02-02  Evan Martin  <evan@chromium.org>

        Reviewed by Tony Chang.

        [chromium] complex joining characters positioned in wrong place
        https://bugs.webkit.org/show_bug.cgi?id=53637

        Add a test that includes some characters that exhibited the problem.
        Unfortunately it's purely a rendering issue, so it is a pixel test.

        * platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.checksum: Added.
        * platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.png: Added.
        * platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.txt: Added.
        * platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html: Added.
2011-02-02  Evan Martin  <evan@chromium.org>

        Reviewed by Tony Chang.

        [chromium] complex joining characters positioned in wrong place
        https://bugs.webkit.org/show_bug.cgi?id=53637

        Provide the correct font metrics to Harfbuzz related to the font design space.
        There are used in some fonts for GPOS positioning.

        Test: platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html

        * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
        (WebCore::ComplexTextController::setupFontForScriptRun):
        (WebCore::ComplexTextController::allocHarfbuzzFont):
        * platform/graphics/chromium/FontPlatformDataLinux.cpp:
        (WebCore::FontPlatformData::FontPlatformData):
        (WebCore::FontPlatformData::emSizeInFontUnits):
        (WebCore::FontPlatformData::operator=):
        * platform/graphics/chromium/FontPlatformDataLinux.h:
        (WebCore::FontPlatformData::FontPlatformData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 3 Feb 2011 17:42:56 +0000 (17:42 +0000)]
2011-02-03  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed; remove the line I intended to remove.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 3 Feb 2011 17:36:52 +0000 (17:36 +0000)]
2011-02-03  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Chromium test expectation update for
        http://src.chromium.org/viewvc/chrome?view=rev&revision=73469

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-02 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 3 Feb 2011 17:28:41 +0000 (17:28 +0000)]
2011-02-02  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Kent Tamura.

        REGRESSION(r76147): Slider thumb position is not updated when value attribute is changed.
        https://bugs.webkit.org/show_bug.cgi?id=53634

        * fast/dom/HTMLInputElement/input-slider-update.html: Added.
        * platform/mac/fast/dom/HTMLInputElement/input-slider-update-expected.checksum: Added.
        * platform/mac/fast/dom/HTMLInputElement/input-slider-update-expected.png: Added.
        * platform/mac/fast/dom/HTMLInputElement/input-slider-update-expected.txt: Added.
2011-02-02  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Kent Tamura.

        REGRESSION(r76147): Slider thumb position is not updated when value attribute is changed.
        https://bugs.webkit.org/show_bug.cgi?id=53634

        Test: fast/dom/HTMLInputElement/input-slider-update.html

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::setValue): Added a call to InputType::valueChanged.
        * html/InputType.cpp:
        (WebCore::InputType::valueChanged): Added empty implementation.
        * html/InputType.h: Added def.
        * html/RangeInputType.cpp:
        (WebCore::RangeInputType::valueChanged): Added implementation that dirties layout
            bit on the thumb.
        * html/RangeInputType.h: Added def.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 3 Feb 2011 17:22:49 +0000 (17:22 +0000)]
2011-02-03  Dimitri Glazkov  <dglazkov@chromium.org>

        [Chromium] Update SVG baselines after r77485 for Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-02 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Thu, 3 Feb 2011 17:15:15 +0000 (17:15 +0000)]
2011-02-02  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: do not share source frames between resources panel and scripts panel.
        https://bugs.webkit.org/show_bug.cgi?id=53584

        Currently, we show error messages only for resources. This change will allow showing error
        messages in source frame even when resource is not available (eval scripts, inlined scripts).

        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype.addMessage):
        (WebInspector.ConsoleView.prototype.clearMessages):
        * inspector/front-end/ResourceView.js:
        (WebInspector.ResourceView.recreateResourceView):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.FrameResourceTreeElement.prototype._setBubbleText):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._scriptSourceChanged):
        (WebInspector.ScriptsPanel.prototype.addConsoleMessage):
        (WebInspector.ScriptsPanel.prototype.clearConsoleMessages):
        (WebInspector.ScriptsPanel.prototype.reset):
        (WebInspector.ScriptsPanel.prototype._sourceFrameForScriptOrResource):
        (WebInspector.ScriptsPanel.prototype._sourceFrameForResource):
        (WebInspector.ScriptsPanel.prototype._sourceFrameForScript):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rebaseline Qt svg tests after r77485.
ossy@webkit.org [Thu, 3 Feb 2011 17:13:11 +0000 (17:13 +0000)]
Unreviewed, rebaseline Qt svg tests after r77485.

* platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.checksum:
* platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
* platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
* platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.checksum:
* platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt:
* platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.checksum:
* platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt:
* platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.checksum:
* platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png:
* platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
* platform/qt/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.checksum:
* platform/qt/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.checksum:
* platform/qt/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
* platform/qt/svg/custom/stroke-width-large-expected.checksum:
* platform/qt/svg/custom/stroke-width-large-expected.png:
* platform/qt/svg/custom/stroke-width-large-expected.txt:
* platform/qt/svg/custom/text-rotated-gradient-expected.checksum:
* platform/qt/svg/custom/text-rotated-gradient-expected.png:
* platform/qt/svg/custom/text-rotated-gradient-expected.txt:
* platform/qt/svg/foreignObject/text-tref-02-b-expected.checksum:
* platform/qt/svg/foreignObject/text-tref-02-b-expected.png:
* platform/qt/svg/foreignObject/text-tref-02-b-expected.txt:
* platform/qt/svg/text/lengthAdjust-text-metrics-expected.checksum: Added.
* platform/qt/svg/text/lengthAdjust-text-metrics-expected.png: Added.
* platform/qt/svg/text/lengthAdjust-text-metrics-expected.txt:
* platform/qt/svg/text/select-textLength-spacing-squeeze-1-expected.checksum:
* platform/qt/svg/text/select-textLength-spacing-squeeze-1-expected.png:
* platform/qt/svg/text/select-textLength-spacing-squeeze-1-expected.txt:
* platform/qt/svg/text/select-textLength-spacing-squeeze-2-expected.checksum:
* platform/qt/svg/text/select-textLength-spacing-squeeze-2-expected.png:
* platform/qt/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
* platform/qt/svg/text/select-textLength-spacing-squeeze-3-expected.checksum:
* platform/qt/svg/text/select-textLength-spacing-squeeze-3-expected.png:
* platform/qt/svg/text/select-textLength-spacing-squeeze-3-expected.txt:
* platform/qt/svg/text/select-textLength-spacing-squeeze-4-expected.checksum:
* platform/qt/svg/text/select-textLength-spacing-squeeze-4-expected.png:
* platform/qt/svg/text/select-textLength-spacing-squeeze-4-expected.txt:
* platform/qt/svg/text/select-textLength-spacing-stretch-1-expected.checksum:
* platform/qt/svg/text/select-textLength-spacing-stretch-1-expected.png:
* platform/qt/svg/text/select-textLength-spacing-stretch-1-expected.txt:
* platform/qt/svg/text/select-textLength-spacing-stretch-2-expected.checksum:
* platform/qt/svg/text/select-textLength-spacing-stretch-2-expected.png:
* platform/qt/svg/text/select-textLength-spacing-stretch-2-expected.txt:
* platform/qt/svg/text/select-textLength-spacing-stretch-3-expected.checksum:
* platform/qt/svg/text/select-textLength-spacing-stretch-3-expected.png:
* platform/qt/svg/text/select-textLength-spacing-stretch-3-expected.txt:
* platform/qt/svg/text/select-textLength-spacing-stretch-4-expected.checksum:
* platform/qt/svg/text/select-textLength-spacing-stretch-4-expected.png:
* platform/qt/svg/text/select-textLength-spacing-stretch-4-expected.txt:
* platform/qt/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.checksum:
* platform/qt/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.png:
* platform/qt/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt:
* platform/qt/svg/text/select-x-list-1-expected.checksum:
* platform/qt/svg/text/select-x-list-1-expected.png:
* platform/qt/svg/text/select-x-list-1-expected.txt:
* platform/qt/svg/text/select-x-list-2-expected.checksum:
* platform/qt/svg/text/select-x-list-2-expected.png:
* platform/qt/svg/text/select-x-list-2-expected.txt:
* platform/qt/svg/text/select-x-list-3-expected.checksum:
* platform/qt/svg/text/select-x-list-3-expected.png:
* platform/qt/svg/text/select-x-list-3-expected.txt:
* platform/qt/svg/text/select-x-list-4-expected.checksum:
* platform/qt/svg/text/select-x-list-4-expected.png:
* platform/qt/svg/text/select-x-list-4-expected.txt:
* platform/qt/svg/text/select-x-list-with-tspans-1-expected.checksum:
* platform/qt/svg/text/select-x-list-with-tspans-1-expected.png:
* platform/qt/svg/text/select-x-list-with-tspans-1-expected.txt:
* platform/qt/svg/text/select-x-list-with-tspans-2-expected.checksum:
* platform/qt/svg/text/select-x-list-with-tspans-2-expected.png:
* platform/qt/svg/text/select-x-list-with-tspans-2-expected.txt:
* platform/qt/svg/text/select-x-list-with-tspans-3-expected.checksum:
* platform/qt/svg/text/select-x-list-with-tspans-3-expected.png:
* platform/qt/svg/text/select-x-list-with-tspans-3-expected.txt:
* platform/qt/svg/text/select-x-list-with-tspans-4-expected.checksum:
* platform/qt/svg/text/select-x-list-with-tspans-4-expected.png:
* platform/qt/svg/text/select-x-list-with-tspans-4-expected.txt:
* platform/qt/svg/text/selection-doubleclick-expected.checksum:
* platform/qt/svg/text/selection-doubleclick-expected.png:
* platform/qt/svg/text/selection-doubleclick-expected.txt:
* platform/qt/svg/text/selection-tripleclick-expected.checksum:
* platform/qt/svg/text/selection-tripleclick-expected.png:
* platform/qt/svg/text/selection-tripleclick-expected.txt:
* platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.checksum:
* platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.png:
* platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
* platform/qt/svg/zoom/page/zoom-coords-viewattr-01-b-expected.checksum: Added.
* platform/qt/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
* platform/qt/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
* platform/qt/svg/zoom/page/zoom-mask-with-percentages-expected.checksum:
* platform/qt/svg/zoom/page/zoom-mask-with-percentages-expected.png:
* platform/qt/svg/zoom/page/zoom-mask-with-percentages-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 3 Feb 2011 16:58:45 +0000 (16:58 +0000)]
2011-02-03  Simon Fraser  <simon.fraser@apple.com>

        Fix 32-bit builds.

        * platform/graphics/ShadowBlur.cpp:
        (WebCore::ShadowBlur::blurLayerImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Thu, 3 Feb 2011 16:32:32 +0000 (16:32 +0000)]
2011-02-03  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Add reporting of JS heap size limit to 'console.memory'.
        https://bugs.webkit.org/show_bug.cgi?id=53592

        In JSC there is no limit, thus 'undefined' value is returned.
        For V8, the limit reported by the VM is returned.

        * Android.jscbindings.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSBindingsAllInOne.cpp:
        * bindings/js/JSMemoryInfoCustom.cpp: Added.
        * bindings/js/ScriptGCEvent.cpp:
        (WebCore::ScriptGCEvent::getHeapSize):
        * bindings/js/ScriptGCEvent.h:
        * bindings/v8/ScriptGCEvent.cpp:
        (WebCore::ScriptGCEvent::getHeapSize):
        * bindings/v8/ScriptGCEvent.h:
        * inspector/InspectorTimelineAgent.cpp:
        (WebCore::InspectorTimelineAgent::setHeapSizeStatistic):
        * page/MemoryInfo.cpp:
        (WebCore::MemoryInfo::MemoryInfo):
        * page/MemoryInfo.h:
        (WebCore::MemoryInfo::jsHeapSizeLimit):
        * page/MemoryInfo.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 3 Feb 2011 16:29:19 +0000 (16:29 +0000)]
2011-01-27  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] LayoutTests/media/audio-mpeg4-supported.html fails
        https://bugs.webkit.org/show_bug.cgi?id=53125

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::mimeTypeCache): Add audio/x-m4a mimetype in the cache.

LayoutTests:

2011-01-27  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] LayoutTests/media/audio-mpeg4-supported.html fails
        https://bugs.webkit.org/show_bug.cgi?id=53125

        * platform/gtk/Skipped: Unskip fixed test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 3 Feb 2011 16:19:02 +0000 (16:19 +0000)]
2011-02-03  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skipping 2 more websocket tests on GTK, see bug 53683.

        * platform/gtk/Skipped: skip http/tests/websocket/tests/simple.html
        and http/tests/websocket/tests/cross-origin.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 3 Feb 2011 16:10:10 +0000 (16:10 +0000)]
2011-02-03  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Sam Weinig.

        ShadowBlur radius for CSS shadows is slightly too big
        https://bugs.webkit.org/show_bug.cgi?id=53660

        If we follow SVG gaussian blur for CSS shadows, we can end up rendering
        shadows that extend further than the CSS "blur radius", which results
        in the shadows being truncated.

        Fix with a small fudge factor to reduce the kernel diameter slightly
        for CSS shadows.

        Also more closely follow the algorithm described in the SVG spec
        for computing the kernel size for different diameters, and clean up
        some variable naming relating to the shadow bounds.

        * platform/graphics/ShadowBlur.cpp:
        (WebCore::ShadowBlur::blurLayerImage):
        (WebCore::ShadowBlur::drawRectShadowWithTiling):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Thu, 3 Feb 2011 16:02:48 +0000 (16:02 +0000)]
2011-02-03  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Darin Adler.

        Avoid strlen() in AtomicString::fromUTF8
        https://bugs.webkit.org/show_bug.cgi?id=50516

        Add an overload to calculateStringHashFromUTF8 to get
        strlen() of the input data with only one call.

        This change shows about 3% performance win on the xml-parser benchmark.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        * wtf/text/AtomicString.cpp:
        (WTF::AtomicString::fromUTF8):
        * wtf/unicode/UTF8.cpp:
        (WTF::Unicode::calculateStringHashAndLengthFromUTF8Internal):
        (WTF::Unicode::calculateStringHashFromUTF8):
        (WTF::Unicode::calculateStringHashAndLengthFromUTF8):
        * wtf/unicode/UTF8.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 3 Feb 2011 15:51:32 +0000 (15:51 +0000)]
2011-02-03  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, rebaseline GTK svg tests after r77485.

        * platform/gtk/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
        * platform/gtk/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt:
        * platform/gtk/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt:
        * platform/gtk/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
        * platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
        * platform/gtk/svg/css/composite-shadow-text-expected.txt:
        * platform/gtk/svg/css/group-with-shadow-expected.txt:
        * platform/gtk/svg/css/shadow-changes-expected.txt:
        * platform/gtk/svg/css/text-gradient-shadow-expected.txt:
        * platform/gtk/svg/custom/stroke-width-large-expected.txt:
        * platform/gtk/svg/custom/text-rotated-gradient-expected.txt:
        * platform/gtk/svg/custom/text-rotation-expected.txt:
        * platform/gtk/svg/foreignObject/text-tref-02-b-expected.txt:
        * platform/gtk/svg/hixie/text/001-expected.txt:
        * platform/gtk/svg/text/select-textLength-spacing-squeeze-1-expected.txt:
        * platform/gtk/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
        * platform/gtk/svg/text/select-textLength-spacing-squeeze-3-expected.txt:
        * platform/gtk/svg/text/select-textLength-spacing-squeeze-4-expected.txt:
        * platform/gtk/svg/text/select-textLength-spacing-stretch-1-expected.txt:
        * platform/gtk/svg/text/select-textLength-spacing-stretch-2-expected.txt:
        * platform/gtk/svg/text/select-textLength-spacing-stretch-3-expected.txt:
        * platform/gtk/svg/text/select-textLength-spacing-stretch-4-expected.txt:
        * platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt:
        * platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt:
        * platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt:
        * platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt:
        * platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt:
        * platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt:
        * platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt:
        * platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt:
        * platform/gtk/svg/text/select-x-list-1-expected.txt:
        * platform/gtk/svg/text/select-x-list-2-expected.txt:
        * platform/gtk/svg/text/select-x-list-3-expected.txt:
        * platform/gtk/svg/text/select-x-list-4-expected.txt:
        * platform/gtk/svg/text/select-x-list-with-tspans-1-expected.txt:
        * platform/gtk/svg/text/select-x-list-with-tspans-2-expected.txt:
        * platform/gtk/svg/text/select-x-list-with-tspans-3-expected.txt:
        * platform/gtk/svg/text/select-x-list-with-tspans-4-expected.txt:
        * platform/gtk/svg/text/selection-doubleclick-expected.txt:
        * platform/gtk/svg/text/selection-tripleclick-expected.txt:
        * platform/gtk/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
        * platform/gtk/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Thu, 3 Feb 2011 15:24:41 +0000 (15:24 +0000)]
2011-02-01  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: introduce new api for managing JavaScript breakpoints.
        https://bugs.webkit.org/show_bug.cgi?id=53235

        * inspector/report-protocol-errors.html:
2011-02-01  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: introduce new api for managing JavaScript breakpoints.
        https://bugs.webkit.org/show_bug.cgi?id=53235

        Single protocol breakpoint (e.g. set by url) is mapped on zero or more VM breakpoints (set by sourceID).
        removeJavaScriptBreakpoint(breakpointId) removes breakpoint and all linked VM breakpoints.
        Since UI uses VM breakpoint location rather then protocol breakpoint location, all resolved breakpoints locations are passed to frontend.

        SourceFrame is now aware of whether breakpoint is resolved or not and may display it accordingly.
        JavaScriptBreakpointsSidebarPane filters out breakpoints set on nonexistent scripts to avoid UI cluttering.

        * bindings/js/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::setBreakpoint):
        (WebCore::ScriptDebugServer::removeBreakpoint):
        * bindings/js/ScriptDebugServer.h:
        * bindings/v8/DebuggerScript.js:
        ():
        * bindings/v8/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::setBreakpoint):
        * bindings/v8/ScriptDebugServer.h:
        * inspector/Inspector.idl:
        * inspector/InspectorAgent.cpp: clear breakpoints from inspector state when new frontend is created
        (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
        (WebCore::InspectorAgent::populateScriptObjects):
        (WebCore::InspectorAgent::restoreDebugger):
        (WebCore::InspectorAgent::showAndEnableDebugger):
        (WebCore::InspectorAgent::enableDebugger):
        * inspector/InspectorAgent.h:
        * inspector/InspectorDebuggerAgent.cpp: manage relations between protocol breakpoints and VM breakpoints
        (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
        (WebCore::InspectorDebuggerAgent::inspectedURLChanged):
        (WebCore::InspectorDebuggerAgent::setJavaScriptBreakpoint):
        (WebCore::InspectorDebuggerAgent::setJavaScriptBreakpointBySourceId):
        (WebCore::InspectorDebuggerAgent::removeJavaScriptBreakpoint):
        (WebCore::InspectorDebuggerAgent::continueToLocation):
        (WebCore::InspectorDebuggerAgent::resolveBreakpoint):
        (WebCore::InspectorDebuggerAgent::getScriptSource):
        (WebCore::InspectorDebuggerAgent::didParseSource):
        (WebCore::InspectorDebuggerAgent::didPause):
        * inspector/InspectorDebuggerAgent.h:
        (WebCore::InspectorDebuggerAgent::Script::Script):
        * inspector/InspectorValues.cpp:
        (WebCore::InspectorValue::asNumber):
        (WebCore::InspectorBasicValue::asNumber):
        (WebCore::InspectorObject::remove):
        * inspector/InspectorValues.h:
        (WebCore::InspectorObject::getNumber):
        (WebCore::InspectorObject::find):
        * inspector/ScriptBreakpoint.h:
        (WebCore::ScriptBreakpoint::ScriptBreakpoint):
        * inspector/front-end/Breakpoint.js:
        (WebInspector.Breakpoint):
        (WebInspector.Breakpoint.prototype.addLocation):
        * inspector/front-end/BreakpointManager.js: remove all stuff related to JavaScript breakpoints from here
        (WebInspector.BreakpointManager):
        (WebInspector.BreakpointManager.prototype._projectChanged):
        (WebInspector.BreakpointManager.prototype._saveBreakpoints):
        (WebInspector.BreakpointManager.prototype._validateBreakpoints):
        * inspector/front-end/BreakpointsSidebarPane.js:
        (WebInspector.JavaScriptBreakpointsSidebarPane): filter breakpoints set on nonexistent scripts to avoid ui cluttering
        * inspector/front-end/DebuggerModel.js:
        (WebInspector.DebuggerModel): pull all JavaScript from localStorage and push them to fronted when debugger is enabled, save resolved breakpoints data
        * inspector/front-end/Script.js:
        (WebInspector.Script.prototype.sourceLine):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._toggleDebugging):
        * inspector/front-end/Settings.js:
        (WebInspector.Settings):
        * inspector/front-end/SourceFrame.js: handle resolved and unresolved breakpoints differently
        * inspector/front-end/inspector.js:
2011-02-01  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: introduce new api for managing JavaScript breakpoints.
        https://bugs.webkit.org/show_bug.cgi?id=53235

        * src/WebDevToolsAgentImpl.cpp:
        (WebKit::WebDevToolsAgent::shouldInterruptForMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 3 Feb 2011 15:22:07 +0000 (15:22 +0000)]
2011-02-03  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip flaky websocket tests on GTK
        https://bugs.webkit.org/show_bug.cgi?id=53683

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Thu, 3 Feb 2011 15:15:37 +0000 (15:15 +0000)]
2011-02-03  Alexander Pavlov  <apavlov@chromium.org>

        Unreviewed, fix build after r77478.

        * inspector/styles-source-lines-inline.html: Roll back inadvertent function rename.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 3 Feb 2011 14:57:35 +0000 (14:57 +0000)]
2011-02-03  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip flaky test
        fast/frames/sandboxed-iframe-scripting.html on GTK
        https://bugs.webkit.org/show_bug.cgi?id=53680

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 3 Feb 2011 14:46:25 +0000 (14:46 +0000)]
2011-02-03  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        small text which is scaled to be large renders pixelated
        https://bugs.webkit.org/show_bug.cgi?id=12448

        SVG <text> with font-size smaller or equal to 1 does not paint correctly
        https://bugs.webkit.org/show_bug.cgi?id=14242

        misplaced text in SVG
        https://bugs.webkit.org/show_bug.cgi?id=17053

        Don't render very small (but zoomed) text inside SVG
        https://bugs.webkit.org/show_bug.cgi?id=19393

        Tiny fonts scaled up end up too large in Safari
        https://bugs.webkit.org/show_bug.cgi?id=20192

        Stretched SVG Text has awful glyph spacing
        https://bugs.webkit.org/show_bug.cgi?id=21774

        REGRESSION (r72141?): svg/batik/text/smallFonts.svg failing on Leopard
        https://bugs.webkit.org/show_bug.cgi?id=49846

        [Gtk] Text height in zoomed SVG is 1px too high
        https://bugs.webkit.org/show_bug.cgi?id=50313

        SVG text smaller than 0.5px not displayed properly
        https://bugs.webkit.org/show_bug.cgi?id=50528

        When rendering text, we're selecting a font with a size, as specified in the markup.
        This can lead to problems, if the context, where the text is rendered upon, is scaled. If a parent
        element of the <text> defines a transform=".." or the outermost <svg> containing a viewBox the
        problem becomes apparent.

        Consider following two snippets, which should render exactly the same:
        <svg viewBox="0 0 100 100"><text x="25" y="50" font-size="25">test</text></svg>
        <svg viewBox="0 0 1 1"><text x="0.25" y="0.5" font-size="0.25">test</text></svg>

        When selecting a font size below 0.5, FontCacheMac would request a font with size 0,
        which AppKit turns into 12. This lead to huge text rendering, instead of small text on Mac.
        Other platforms have different problems (Qt simply scales the font, leading to pixelation etc.)

        To fix this in a cross-platform fashion, we now always compute the final font size on screen,
        remove any scaling from the context, draw the text using the scaled font size, then reapply
        the context scale. This makes the example snippets above render exactly the same and fixes
        numerous of bugs, present since years. As we're now heavily using floating-point font sizes
        internally, depending on the scale of the document, it's very important to use the new
        floating-point text metrics information (floatAscent/floatDescent/floatHeight) everywhere in SVG.

        Fixes existing tests: css3/zoom-coords.xhtml (cross-platform inconsistencies should be gone, mac now reports floatHeight values for SVG text height)
                              svg/hixie/text/003.html (no more pixelation)
                              svg/batik/text/smallFonts.svg (small fonts aren't rendered huge anymore on mac)
                              svg/hixie/viewbox/preserveAspectRatio/001.xml (bug 21774, no more awful spacing)
                              svg/zoom/page/zoom-zoom-coords.xhtml (cross-platform inconsistencies should be gone, inspired by bug 50313)

        Tests: svg/text/font-size-below-point-five-2.svg (reduction from bug 50528)
               svg/text/font-size-below-point-five.svg (reduction from bug 50528)
               svg/text/scaled-font.svg (reduction from bug 12448)
               svg/text/small-fonts-2.svg (reduction from bug 14242)
               svg/text/small-fonts-3.svg (reduction from bug 17053)
               svg/text/small-fonts-in-html5.html (reduction from bug 19393)
               svg/text/small-fonts.svg (reduction from bug 20192))

        * rendering/svg/RenderSVGInlineText.cpp: Cache 'float scalingFactor' & 'Font scaledFont', whenever the on-screen representation changes.
        * rendering/svg/RenderSVGInlineText.h:
        * rendering/svg/RenderSVGText.cpp: Update scalingFactor/scaledFont, if necessary.
        * rendering/svg/SVGInlineTextBox.cpp: Switch to new font rendering strategy. Always use scaledFont, and remove any context scale before drawing.
        * rendering/svg/SVGInlineTextBox.h:
        * rendering/svg/SVGTextLayoutEngineBaseline.cpp: Use floating-point metrics everywhere.
        * rendering/svg/SVGTextMetrics.cpp: Ditto.
        * rendering/svg/SVGTextMetrics.h: Ditto.
        * rendering/svg/SVGTextQuery.cpp: Ditto.
        * svg/SVGFont.cpp: Adjust stroke thickness, when drawing SVGFonts into a normalized context (no more scale).
        * svg/SVGTextContentElement.cpp: Make <text> elements always dependant on window size changes in combination with viewBox set.
        * svg/SVGTextPositioningElement.cpp: Remove now unnecessary code to determine wheter relative lengths are used as text attributes.
        * svg/SVGTextPositioningElement.h:

2011-02-03  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        small text which is scaled to be large renders pixelated
        https://bugs.webkit.org/show_bug.cgi?id=12448

        Update SVG test results after fixing small font size support. Land new mac/mac-leopard baseline, as text looks slightly different
        in each testcase, as the font-size used for on-screen rendering has changed, this results in hinting differences, inter-glyph
        space changes, etc. This commit only includes the textual result changes, the pixel test baseline will land in chunks in follow-up commits.

        To those who have to rebaseline their platforms: Some of the svg/text pixel test results may look questionable on first sight,
        - svg/text/select-* tests:
          These tests render a certain string 'Foobar' and query the metrics using SVG Text DOM API (getExtentOfChar(firstChar) and getExtentOfChar(lastChar)).
          A red rectangle is drawn, to represent the size of the string, which gives precise results using floating-point accurancy.
          Using eventSender, a selection is simulated, by clicking the first char, holding down, and moving towards the last character.
          The blue selection rect which is drawn, should in theory be equal to the red rectangle.
          In practice it is not, as the selection rect is aligned to integer boundaries (see floor calls in Font::selectionRect...).
          Since we switched to use floating-point precision metrics, the actual drawn selection may exceed the red rectangle up to 1px.

        - svg/text/selection-(doubleclick|tripleclick).svg:
          These tests use DRTs dumpSelectionRect() which draws a red rectangle, highlighting the SelectionController::bounds() obtained through RenderView.
          In theory this red rectangle, should be equal to the drawn blue selection rect. Again it isn't, as the bounds() methods uses selectionRectForRepaint()
          of RenderText, which returns an enclosingIntRect of the actual selection. The drawn selection starts at y=0.93 in the first testcase, the selectionRectForRepaint()
          call returns an IntRect, which starts at y=0. That explains why the red rectangle starts slightly higher as it should be. Again this is no problem, the repaint
          rect may be 1px larger, if it would be smaller, we had a problem. The only way to fix this, would be to pass around FloatRect as repaint rects, but that's not worth it.

        - css3/zoom-coords.* / svg/zoom/page/zoom-zoom-coords*:
          These tests have different expectations now, as we're using the floatAscent/floatDesent/floatHeight FontMetrics methods instead of
          the integer variants ascent/descent/height - hopefully we'll see consistent results across platforms for these tests now, if not please comment in the bug report.

        * css3/zoom-coords-expected.txt:
        * css3/zoom-coords.xhtml:
        * platform/mac-leopard/Skipped:
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.checksum: Added.
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png: Added.
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt: Added.
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.checksum: Added.
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png: Added.
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt: Added.
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt: Added.
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt: Added.
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Added.
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum: Added.
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Added.
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Added.
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt: Added.
...

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Thu, 3 Feb 2011 14:38:58 +0000 (14:38 +0000)]
2011-02-03  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed.

        BUGCR71783 : scrollbars/custom-scrollbar-with-incomplete-style.html = IMAGE
        It is failing since r77459 by Sam Weinig.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkip a new showModalDialog test on Windows
aroben@apple.com [Thu, 3 Feb 2011 14:22:41 +0000 (14:22 +0000)]
Skip a new showModalDialog test on Windows

showModalDialog support is now covered by <http://webkit.org/b/53675>.

I also sorted some sputnik tests that fail when showModalDialog is unsupported, and filed a
new bug (<http://webkit.org/b/53676>) about those failures, since it seems like those tests
should pass even when showModalDialog is unsupported.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCheck in expected failure results for an RTL <select> test
aroben@apple.com [Thu, 3 Feb 2011 14:22:16 +0000 (14:22 +0000)]
Check in expected failure results for an RTL <select> test

The failure is covered by <http://webkit.org/b/53443>.

* platform/win/fast/text/international/bidi-menulist-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd Windows results for test added in r77153
aroben@apple.com [Thu, 3 Feb 2011 14:21:45 +0000 (14:21 +0000)]
Add Windows results for test added in r77153

* platform/win/fast/text/international/text-combine-image-test-expected.checksum: Added.
* platform/win/fast/text/international/text-combine-image-test-expected.png: Added.
* platform/win/fast/text/international/text-combine-image-test-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 3 Feb 2011 13:45:58 +0000 (13:45 +0000)]
2011-02-03  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: resources panel doesn't show frames after reload.
        https://bugs.webkit.org/show_bug.cgi?id=53430

        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype.show):
        (WebInspector.ResourcesPanel.prototype.loadEventFired):
        (WebInspector.ResourcesPanel.prototype._initDefaultSelection):
        (WebInspector.ResourcesPanel.prototype.reset):
        (WebInspector.ResourcesPanel.prototype.clear):
        * inspector/front-end/inspector.js:
        (WebInspector.loadEventFired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
ossy@webkit.org [Thu, 3 Feb 2011 13:43:39 +0000 (13:43 +0000)]
Unreviewed.

[Qt]REGRESSION(r76951): media/controls-without-preload.html fails
https://bugs.webkit.org/show_bug.cgi?id=53674

* platform/qt/Skipped: media/controls-without-preload.html added until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Thu, 3 Feb 2011 13:04:29 +0000 (13:04 +0000)]
2011-02-01  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Remove the *2 suffix from the CSS style-related protocol methods
        https://bugs.webkit.org/show_bug.cgi?id=53492

        WebCore:
        * inspector/Inspector.idl:
        * inspector/InspectorCSSAgent.cpp:
        (WebCore::InspectorCSSAgent::getStylesForNode):
        (WebCore::InspectorCSSAgent::getInlineStyleForNode):
        (WebCore::InspectorCSSAgent::getComputedStyleForNode):
        (WebCore::InspectorCSSAgent::getAllStyles):
        (WebCore::InspectorCSSAgent::getStyleSheet):
        (WebCore::InspectorCSSAgent::getStyleSheetText):
        (WebCore::InspectorCSSAgent::setStyleSheetText):
        (WebCore::InspectorCSSAgent::setPropertyText):
        (WebCore::InspectorCSSAgent::toggleProperty):
        (WebCore::InspectorCSSAgent::setRuleSelector):
        (WebCore::InspectorCSSAgent::addRule):
        * inspector/InspectorCSSAgent.h:
        * inspector/front-end/AuditRules.js:
        (WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
        * inspector/front-end/CSSStyleModel.js:
        (WebInspector.CSSStyleModel.prototype.getStylesAsync):
        (WebInspector.CSSStyleModel.prototype.getComputedStyleAsync):
        (WebInspector.CSSStyleModel.prototype.getInlineStyleAsync):
        (WebInspector.CSSStyleModel.prototype.setRuleSelector):
        (WebInspector.CSSStyleModel.prototype.addRule):
        (WebInspector.CSSStyleModel.prototype._styleSheetChanged):
        (WebInspector.CSSStyleModel.prototype._onRevert):
        (WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt):
        (WebInspector.CSSProperty.prototype.setText):
        (WebInspector.CSSProperty.prototype.setDisabled):
        (WebInspector.CSSStyleSheet.createForId):
        (WebInspector.CSSStyleSheet.prototype.setText):

        LayoutTests:
        * inspector/styles-iframe.html:
        * inspector/styles-new-API.html:
        * inspector/styles-source-lines-inline.html:
        * inspector/styles-source-lines.html:
        * inspector/styles-source-offsets.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 3 Feb 2011 12:52:16 +0000 (12:52 +0000)]
2011-02-03  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip flaky test
        fast/files/workers/worker-read-blob-async.html on GTK
        https://bugs.webkit.org/show_bug.cgi?id=53673

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
rgabor@webkit.org [Thu, 3 Feb 2011 12:36:40 +0000 (12:36 +0000)]
Unreviewed.

Adding myself to committers.py.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
ossy@webkit.org [Thu, 3 Feb 2011 12:33:39 +0000 (12:33 +0000)]
Unreviewed.

[Qt] fast/dynamic/unicode-bidi.html fails
https://bugs.webkit.org/show_bug.cgi?id=53456

Add Qt specific expected files.

* platform/qt/fast/dynamic/unicode-bidi-expected.checksum: Added.
* platform/qt/fast/dynamic/unicode-bidi-expected.png: Added.
* platform/qt/fast/dynamic/unicode-bidi-expected.txt: Copied from LayoutTests/fast/dynamic/unicode-bidi-expected.txt.
* platform/qt/fast/text/bidi-embedding-pop-and-push-same-2-expected.checksum: Added.
* platform/qt/fast/text/bidi-embedding-pop-and-push-same-2-expected.png: Added.
* platform/qt/fast/text/bidi-embedding-pop-and-push-same-2-expected.txt: Copied from LayoutTests/fast/text/bidi-embedding-pop-and-push-same-2-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 3 Feb 2011 12:04:26 +0000 (12:04 +0000)]
2011-02-03  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, GTK baselines for 2 new tests added in r77267 and r77153.

        * platform/gtk/fast/dom/34176-expected.txt: Added.
        * platform/gtk/fast/text/international/text-combine-image-test-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Balazs Kelemen <kbalazs@webkit.org>
kbalazs@webkit.org [Thu, 3 Feb 2011 11:09:56 +0000 (11:09 +0000)]
2011-02-03  Balazs Kelemen  <kbalazs@webkit.org>

        Reviewed by Csaba Osztrogon√°c.

        [Qt][WK2] MiniBrowser's window size should be 800x600
        https://bugs.webkit.org/show_bug.cgi?id=53670

        Make layout test failure debugging easier.
        * MiniBrowser/qt/BrowserWindow.cpp:
        (BrowserWindow::BrowserWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 3 Feb 2011 09:41:28 +0000 (09:41 +0000)]
2011-02-03  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip failing test
        fast/history/timed-refresh-in-cached-frame.html on GTK
        https://bugs.webkit.org/show_bug.cgi?id=53667

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Thu, 3 Feb 2011 09:37:14 +0000 (09:37 +0000)]
2011-02-03  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Ryosuke Niwa.

        Skip some tests that fail in WebKit2 due to missing DRT functionality
        https://bugs.webkit.org/show_bug.cgi?id=53666

        * platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 3 Feb 2011 08:59:03 +0000 (08:59 +0000)]
2011-02-03  Adam Barth  <abarth@webkit.org>

        Reviewed by Daniel Bates.

        Teach XSSFilter about data URLs
        https://bugs.webkit.org/show_bug.cgi?id=53662

        Tests that the XSS filter doesn't block script in data URLs.

        * http/tests/security/xssAuditor/data-urls-work-expected.txt: Added.
        * http/tests/security/xssAuditor/data-urls-work.html: Added.
2011-02-03  Adam Barth  <abarth@webkit.org>

        Reviewed by Daniel Bates.

        Teach XSSFilter about data URLs
        https://bugs.webkit.org/show_bug.cgi?id=53662

        The XSS filter doesn't really make sense for data URLs because
        everything in a "response" from a data URL was part of the request.

        Test: http/tests/security/xssAuditor/data-urls-work.html

        * html/parser/XSSFilter.cpp:
        (WebCore::XSSFilter::init):
        (WebCore::XSSFilter::filterToken):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Thu, 3 Feb 2011 08:11:24 +0000 (08:11 +0000)]
2011-02-03  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r77449.
        http://trac.webkit.org/changeset/77449
        https://bugs.webkit.org/show_bug.cgi?id=53663

        causes many WebKit2 tests to crash (Requested by othermaciej
        on #webkit).

        * Shared/API/c/WKSharedAPICast.h:
        (WebKit::toAPI):
        (WebKit::toCopiedAPI):
        (WebKit::toURLRef):
        (WebKit::toCopiedURLAPI):
        * Shared/WebString.h:
        (WebKit::WebString::isNull):
        (WebKit::WebString::WebString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-02 Chris Evans <cevans@chromium.org>
commit-queue@webkit.org [Thu, 3 Feb 2011 06:21:07 +0000 (06:21 +0000)]
2011-02-02  Chris Evans  <cevans@chromium.org>

        Reviewed by Darin Fisher.

        window.find() can fail when switching case sensitivity
        https://bugs.webkit.org/show_bug.cgi?id=53654

        The test coverage for this area is very poor, so I took the liberty
        of adding a more general test than is needed.

        * fast/text/find-window.html: Added.
        * fast/text/find-window-expected.txt: Added.
2011-02-02  Chris Evans  <cevans@chromium.org>

        Reviewed by Darin Fisher.

        window.find() can fail when switching case sensitivity
        https://bugs.webkit.org/show_bug.cgi?id=53654

        Reset the pattern to a safe one when done, to avoid usearch_reset()
        indirectly touching the old, stale text pointer.

        Test: fast/text/find-window.html

        * editing/TextIterator.cpp:
        (WebCore::SearchBuffer::~SearchBuffer): leave a safe pattern buffer when done.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 3 Feb 2011 05:45:47 +0000 (05:45 +0000)]
2011-02-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Daniel Bates.

        Teach XSSFilter that <param> elements can contain URLs
        https://bugs.webkit.org/show_bug.cgi?id=53652

        When loading plugins for the <object> tag, we're "smart" enough to
        reach into the <param> elements and pull out the URL in some cases.
        This patch teaches the XSSFilter how to block injections into those
        sorts of param elements.

        Fixes:
            http/tests/security/xssAuditor/object-*

        * html/HTMLParamElement.cpp:
        (WebCore::HTMLParamElement::isURLParameter):
        (WebCore::HTMLParamElement::isURLAttribute):
        (WebCore::HTMLParamElement::addSubresourceAttributeURLs):
        * html/HTMLParamElement.h:
            - Add a helper function so that HTMLParamElement can share the
              ground truth for these names with the XSSFilter.
        * html/parser/XSSFilter.cpp:
        (WebCore::XSSFilter::filterTokenInitial):
        (WebCore::XSSFilter::filterParamToken):
        * html/parser/XSSFilter.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix license block issues pointed out by Daniel Bates.
weinig@apple.com [Thu, 3 Feb 2011 05:41:21 +0000 (05:41 +0000)]
Fix license block issues pointed out by Daniel Bates.

* Shared/API/c/WKGraphicsContext.cpp:
* Shared/API/c/WKGraphicsContext.h:
* Shared/API/c/cg/WKGraphicsContextCG.cpp:
* Shared/API/c/cg/WKGraphicsContextCG.h:
* Shared/WebGraphicsContext.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-02 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 3 Feb 2011 05:17:54 +0000 (05:17 +0000)]
2011-02-02  Martin Robinson  <mrobinson@igalia.com>

        Rebaseline two tests after import of editing test results for GTK+.
        Also remove a platform-specific baseline for a test which is now passing.

        * platform/gtk/editing/pasteboard/emacs-ctrl-a-k-y-expected.txt:
        * platform/gtk/editing/selection/find-yensign-and-backslash-expected.txt: Removed.
        * platform/gtk/fast/dom/52776-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-02 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 3 Feb 2011 04:40:58 +0000 (04:40 +0000)]
2011-02-02  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by David Levin.

        GCC compiler on ARM issues bogus warnings and fails to compile.
        https://bugs.webkit.org/show_bug.cgi?id=53620

        Despite warnings explicitly being disallowed (-Wno-uninitialized),
        gcc (Ubuntu 4.4.3-4ubuntu5) 4.4.3 throws up the warnings like:

        "error: 'colorTransparent.unstatic.4909' may be used uninitialized in this function"

        The fix is to add an extra condition, which somehow pacifies the compiler.

        * css/CSSPrimitiveValue.cpp:
        (WebCore::CSSPrimitiveValue::createColor): Added workaround conditions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 3 Feb 2011 04:35:21 +0000 (04:35 +0000)]
2011-02-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Daniel Bates.

        Teach XSSFilter about X-XSS-Protection
        https://bugs.webkit.org/show_bug.cgi?id=53640

        This patch causes us to pass:
            http/tests/security/xssAuditor/full-block-*
            http/tests/security/xssAuditor/no-protection-script-tag.html

        * html/parser/XSSFilter.cpp:
        (WebCore::XSSFilter::XSSFilter):
        (WebCore::XSSFilter::init):
        (WebCore::XSSFilter::filterToken):
        * html/parser/XSSFilter.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 3 Feb 2011 04:23:06 +0000 (04:23 +0000)]
2011-02-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Daniel Bates.

        When XSSFilter blocks JavaScript URLs, use a safe JavaScript URL
        instead of the empty string
        https://bugs.webkit.org/show_bug.cgi?id=53643

        In a URL context, the empty string completes to the URL of the current
        page, which causes these tests to go into an infinite loop.  Instead,
        we should use a "safe" JavaScript URL that does nothing.

        Fixes:
            http/tests/security/xssAuditor/javascript-link*

        * html/parser/XSSFilter.cpp:
        (WebCore::XSSFilter::eraseDangerousAttributesIfInjected):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/8380506> REGRESSION (r61921): RTL text in <b> tag doesn't display...
mitz@apple.com [Thu, 3 Feb 2011 04:13:51 +0000 (04:13 +0000)]
<rdar://problem/8380506> REGRESSION (r61921): RTL text in <b> tag doesn't display in WebKit under certain conditions
https://bugs.webkit.org/show_bug.cgi?id=44942

Reviewed by Sam Weinig.

Source/WebCore:

Test: fast/text/bidi-embedding-pop-and-push-same-2.html

* platform/text/BidiResolver.h:
(WebCore::::commitExplicitEmbedding): Changed to return a boolean indicating whether there was
a change to embedding levels.
(WebCore::::createBidiRunsForLine): If embedding levels did not change as a result of committing
the explicit embedding sequence, then runs were not added, and we should continue normally.

LayoutTests:

* fast/text/bidi-embedding-pop-and-push-same-2-expected.checksum: Added.
* fast/text/bidi-embedding-pop-and-push-same-2-expected.png: Added.
* fast/text/bidi-embedding-pop-and-push-same-2-expected.txt: Added.
* fast/text/bidi-embedding-pop-and-push-same-2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd WKBundleFrameGetVisibleContentBoundsExcludingScrollbars API for WebKit2.
weinig@apple.com [Thu, 3 Feb 2011 03:46:59 +0000 (03:46 +0000)]
Add WKBundleFrameGetVisibleContentBoundsExcludingScrollbars API for WebKit2.

Reviewed by Dan Bernstein.

* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameGetContentBounds):
(WKBundleFrameGetVisibleContentBounds):
(WKBundleFrameGetVisibleContentBoundsExcludingScrollbars):
(WKBundleFrameGetScrollOffset):
* WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::contentBounds):
(WebKit::WebFrame::visibleContentBounds):
(WebKit::WebFrame::visibleContentBoundsExcludingScrollbars):
(WebKit::WebFrame::scrollOffset):
* WebProcess/WebPage/WebFrame.h:
Move implementation of frame geometry to the implementation file
instead of keeping it in the API file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix miscalculation of the overhang area used for painting. We were
weinig@apple.com [Thu, 3 Feb 2011 03:45:32 +0000 (03:45 +0000)]
Fix miscalculation of the overhang area used for painting. We were
not correctly accounting for scrollbars resulting in an non-negative
overhang even when we weren't over the edge.

Reviewed by Dan Bernstein.

* platform/ScrollView.cpp:
(WebCore::ScrollView::calculateOverhangAreasForPainting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-02 Kenneth Russell <kbr@google.com>
kbr@google.com [Thu, 3 Feb 2011 03:01:41 +0000 (03:01 +0000)]
2011-02-02  Kenneth Russell  <kbr@google.com>

        Reviewed by Mihai Parparita.

        gl-teximage.html failing on some WebKit bots
        https://bugs.webkit.org/show_bug.cgi?id=53633

        * fast/canvas/webgl/gl-teximage.html:
          - Synced with upstream test; detect when running in DRT and
            avoid printing the specific pixel value when the test will pass.
        * fast/canvas/webgl/resources/red-indexed.png:
          - Stripped gamma and other colorspace information.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago'update-webkit' should handle OpenSource and Internal using different
aestes@apple.com [Thu, 3 Feb 2011 02:39:42 +0000 (02:39 +0000)]
'update-webkit' should handle OpenSource and Internal using different
VCSs.

Reviewed by Mark Rowe.

* Scripts/update-webkit: Re-check the VCS type when updating Apple's
Internal directory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-02 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Thu, 3 Feb 2011 02:24:03 +0000 (02:24 +0000)]
2011-02-02  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Nate Chapin.

        IDBTransaction and IDBRequest can be deleted while ScriptExecutionContext is iterating....which is bad
        https://bugs.webkit.org/show_bug.cgi?id=52722

        The solution is to change ScriptExecutionContext's destructor to iterate over
        the list in a way that handles the mutations. This new method is destructive,
        but that's OK since the object is going away. I've also added a several asserts.

        There should be no behavior change.

        * dom/ScriptExecutionContext.cpp:
        (WebCore::ScriptExecutionContext::ScriptExecutionContext):
        (WebCore::ScriptExecutionContext::~ScriptExecutionContext):
        (WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects):
        (WebCore::ScriptExecutionContext::suspendActiveDOMObjects):
        (WebCore::ScriptExecutionContext::resumeActiveDOMObjects):
        (WebCore::ScriptExecutionContext::stopActiveDOMObjects):
        (WebCore::ScriptExecutionContext::createdActiveDOMObject):
        (WebCore::ScriptExecutionContext::destroyedActiveDOMObject):
        * dom/ScriptExecutionContext.h:
        * storage/IDBTransaction.cpp:
        (WebCore::IDBTransaction::contextDestroyed):
        * storage/IDBTransaction.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix.
mrowe@apple.com [Thu, 3 Feb 2011 02:11:14 +0000 (02:11 +0000)]
Build fix.

* WebCore.exp.in: Remove some bogus symbols from the .exp.in file.
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::unregisterScrollbar): Look the object
up in the HashMap rather than relying on a local variable that doesn't
exist.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 3 Feb 2011 02:04:09 +0000 (02:04 +0000)]
2011-02-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Daniel Bates.

        Teach XSSFilter about JavaScript URLs
        https://bugs.webkit.org/show_bug.cgi?id=53635

        This patch teaches the XSSFilter to check for JavaScript URLs in
        attribute values.  If this approach has too many false positives, we
        can restrict which attribute names we examine.

        Fixes these tests:
            http/tests/security/xssAuditor/anchor-url-dom-write-location-javascript-URL.html
            http/tests/security/xssAuditor/dom-write-location-javascript-URL.html
            http/tests/security/xssAuditor/iframe-javascript-url*

        * html/parser/XSSFilter.cpp:
        (WebCore::HTMLNames::containsJavaScriptURL):
        (WebCore::XSSFilter::filterTokenInitial):
        (WebCore::XSSFilter::eraseDangerousAttributesIfInjected):
        * html/parser/XSSFilter.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-02 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 3 Feb 2011 02:00:28 +0000 (02:00 +0000)]
2011-02-02  Martin Robinson  <mrobinson@igalia.com>

        Unskip the last batch of editing tests needing GTK+ results.

        * platform/gtk/Skipped: Unskip last batch of tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77453 268f45cc-cd09-0410-ab3c-d52691b4dbfc