WebKit-https.git
6 years agoChange RenderTableCell to use pixelSnappedSize when painting
eae@chromium.org [Mon, 18 Mar 2013 16:16:20 +0000 (16:16 +0000)]
Change RenderTableCell to use pixelSnappedSize when painting
https://bugs.webkit.org/show_bug.cgi?id=112562

Reviewed by Eric Seidel.

Source/WebCore:

Change the paining code in RenderTableCell to use the pixel snapped size
to ensure consistent rounding given that the location was rounded during
layout.

It is currently constructing a paint rect by taking the rounded location
and the precise size and then pixel snapping it. This causes the size to
be rounded incorrectly. By instead using the pixel snapped size the
rounding problem can be avoided.

Test: fast/sub-pixel/table-cell-background.html

* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paintCollapsedBorders):
(WebCore::RenderTableCell::paintBackgroundsBehindCell):
(WebCore::RenderTableCell::paintBoxDecorations):
(WebCore::RenderTableCell::paintMask):

LayoutTests:

Add test for painting of cell backgrounds on a sub-pixel boundary.

* fast/sub-pixel/table-cell-background-expected.html: Added.
* fast/sub-pixel/table-cell-background.html: Added.
* platform/chromium-linux/tables/mozilla/bugs/bug73321-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoObjectPrototype properties should be eagerly created rather than lazily via static...
fpizlo@apple.com [Mon, 18 Mar 2013 16:16:05 +0000 (16:16 +0000)]
ObjectPrototype properties should be eagerly created rather than lazily via static tables
https://bugs.webkit.org/show_bug.cgi?id=112539

Reviewed by Oliver Hunt.

This is the first part of https://bugs.webkit.org/show_bug.cgi?id=112233. Rolling this
in first since it's the less-likely-to-be-broken part.

* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* interpreter/CallFrame.h:
(JSC::ExecState::objectConstructorTable):
* runtime/CommonIdentifiers.h:
* runtime/JSGlobalData.cpp:
(JSC):
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):
* runtime/JSGlobalData.h:
(JSGlobalData):
* runtime/JSObject.cpp:
(JSC::JSObject::putDirectNativeFunction):
(JSC):
* runtime/JSObject.h:
(JSObject):
(JSC):
* runtime/Lookup.cpp:
(JSC::setUpStaticFunctionSlot):
* runtime/ObjectPrototype.cpp:
(JSC):
(JSC::ObjectPrototype::finishCreation):
(JSC::ObjectPrototype::create):
* runtime/ObjectPrototype.h:
(ObjectPrototype):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAccess settings.defaultVideoPosterURL
commit-queue@webkit.org [Mon, 18 Mar 2013 16:13:33 +0000 (16:13 +0000)]
Access settings.defaultVideoPosterURL
https://bugs.webkit.org/show_bug.cgi?id=112378

Patch by Tao Bai <michaelbai@chromium.org> on 2013-03-18
Reviewed by Dimitri Glazkov.

The defaultVideoPosterURL setting has been added in
https://bugs.webkit.org/show_bug.cgi?id=110263,
this added methods to access it in Chromium.
The settings will be used by Android WebView API
WebChromeClient.getDefaultVideoPoster()

* public/WebSettings.h: add setDefaultVideoPosterURL
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setDefaultVideoPosterURL): set defaultVideoPosterURL
* src/WebSettingsImpl.h: add setDefaultVideoPosterURL

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoNeed to use const String in HTMLVideoElement::posterImageURL
commit-queue@webkit.org [Mon, 18 Mar 2013 16:12:00 +0000 (16:12 +0000)]
Need to use const String in HTMLVideoElement::posterImageURL
https://bugs.webkit.org/show_bug.cgi?id=112317

Patch by Tao Bai <michaelbai@chromium.org> on 2013-03-18
Reviewed by Andreas Kling.

No behavioral changes.

This is the followup of https://bugs.webkit.org/show_bug.cgi?id=110263
Need to use String instead of const AtomicString& which means we will do an extra hash lookup

* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::posterImageURL): Change to use String for url

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Unreviewed gardening.
rakuco@webkit.org [Mon, 18 Mar 2013 15:49:50 +0000 (15:49 +0000)]
[EFL] Unreviewed gardening.

* platform/efl/TestExpectations: Remove
editing/pasteboard/paste-4035648-fix.html from the skipped list after
r144999.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] plugins/plugin-clip-subframe.html is failing
zandobersek@gmail.com [Mon, 18 Mar 2013 15:33:13 +0000 (15:33 +0000)]
[GTK] plugins/plugin-clip-subframe.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112570

Reviewed by Martin Robinson.

Tools:

* GNUmakefile.am: Add the LogNPPSetWindow.cpp file to the build.

LayoutTests:

* platform/gtk-wk2/plugins/plugin-clip-subframe-expected.txt: Added the required baseline.
* platform/gtk/TestExpectations: Removing the failure expectation.
* platform/gtk/plugins/plugin-clip-subframe-expected.txt: Added the required baseline.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: [Settings] Register "?" shortcut.
eustas@chromium.org [Mon, 18 Mar 2013 15:11:12 +0000 (15:11 +0000)]
Web Inspector: [Settings] Register "?" shortcut.
https://bugs.webkit.org/show_bug.cgi?id=112545

Reviewed by Vsevolod Vlasov.

F1 and "?" (show shortcuts page) are not mentioned on shortcuts page.

* English.lproj/localizedStrings.js: Added string.
* inspector/front-end/inspector.js: Registered F1 / "?" shortcut.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd USE(PLATFORM_STRATEGIES) ifdefs to StorageNamespace.cpp
commit-queue@webkit.org [Mon, 18 Mar 2013 14:27:22 +0000 (14:27 +0000)]
Add USE(PLATFORM_STRATEGIES) ifdefs to StorageNamespace.cpp
https://bugs.webkit.org/show_bug.cgi?id=112004

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-18
Reviewed by Rob Buis.

Check if platform strategies is enabled before using it, falling
back to StorageNamespaceImpl if it isn't.

* storage/StorageNamespace.cpp:
(WebCore::StorageNamespace::localStorageNamespace):
(WebCore::StorageNamespace::sessionStorageNamespace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: TabbedEditorContainer does not restore last shown file on reload somet...
vsevik@chromium.org [Mon, 18 Mar 2013 14:13:00 +0000 (14:13 +0000)]
Web Inspector: TabbedEditorContainer does not restore last shown file on reload sometimes.
https://bugs.webkit.org/show_bug.cgi?id=112561

Reviewed by Alexander Pavlov.

* inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.prototype.addUISourceCode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] EditorClientBlackBerry: fix access to WebPage attribute
commit-queue@webkit.org [Mon, 18 Mar 2013 13:43:48 +0000 (13:43 +0000)]
[BlackBerry] EditorClientBlackBerry: fix access to WebPage attribute
https://bugs.webkit.org/show_bug.cgi?id=112556

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-18
Reviewed by Rob Buis.

This changed in r145849 and broke the BlackBerry build.

* WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::smartInsertDeleteEnabled):
(WebCore::EditorClientBlackBerry::isSelectTrailingWhitespaceEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Exports leveldb symbols
kov@webkit.org [Mon, 18 Mar 2013 13:19:50 +0000 (13:19 +0000)]
[GTK] Exports leveldb symbols
https://bugs.webkit.org/show_bug.cgi?id=112526

Reviewed by Carlos Garcia Campos.

* Source/autotools/symbols.filter: make leveldb symbols local.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Detach overlays from page when compositor is detached
anilsson@rim.com [Mon, 18 Mar 2013 13:05:16 +0000 (13:05 +0000)]
[BlackBerry] Detach overlays from page when compositor is detached
https://bugs.webkit.org/show_bug.cgi?id=112424

Reviewed by Rob Buis.

PR 309160

Source/WebCore:

Expose a method to retrieve a compositing thread layer's client.

No change in behavior, no new tests.

* platform/graphics/blackberry/LayerCompositingThread.h:
(WebCore::LayerCompositingThread::client):

Source/WebKit/blackberry:

If not detached properly, the overlays would have a dangling pointer to
the page.

* Api/WebOverlay.cpp:
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::WebOverlayLayerCompositingThreadClient):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::WebOverlayPrivateCompositingThread):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::~WebOverlayPrivateCompositingThread):
* Api/WebOverlay_p.h:
(BlackBerry::WebKit::WebOverlayPrivate::setClient):
(WebOverlayLayerCompositingThreadClient):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::overlay):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::overlayDestroyed):
(WebOverlayPrivateCompositingThread):
* Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositorPrivate::detach):
(BlackBerry::WebKit::WebPageCompositorPrivate::setPage):
(WebKit):
(BlackBerry::WebKit::WebPageCompositorPrivate::attachOverlays):
* Api/WebPageCompositor_p.h:
(BlackBerry::WebKit::WebPageCompositorPrivate::attachOverlays):
(BlackBerry::WebKit::WebPageCompositorPrivate::detachOverlays):
(WebPageCompositorPrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: [Resources] Local Storage: duplicate keys are processed inappropriately.
eustas@chromium.org [Mon, 18 Mar 2013 12:52:47 +0000 (12:52 +0000)]
Web Inspector: [Resources] Local Storage: duplicate keys are processed inappropriately.
https://bugs.webkit.org/show_bug.cgi?id=112402

Reviewed by Alexander Pavlov.

When user creates new items or renames existing one some existing item
may be overriden. If value is changed, then frontend will receive
notification and update record appropriately.

If item value hasn't been changed, then no notification comes.
But UI still expect / rely on this notification.

With this patch the "no notification" scenario is fixed:
duplicate items are removed.

Another scenario is when update notification comes when we started
editing value (after entering / renaming key). In this case
selected node should not be changed to leave user in editing mode.

* inspector/front-end/DOMStorageItemsView.js:
Added workarounds for "no notification" and "useless notification".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoClean up RenderFrameSet::nodeAtPoint
allan.jensen@digia.com [Mon, 18 Mar 2013 11:59:18 +0000 (11:59 +0000)]
Clean up RenderFrameSet::nodeAtPoint
https://bugs.webkit.org/show_bug.cgi?id=112450

Reviewed by Eric Seidel.

Remove handling of resizing framesets from RenderFrameSet::nodeAtPoint.
The code has been incorrect since a mistake in r18333 (December 2006),
but has been dead code since r17770 (November 2006) where the then new
EventHandler started taking care of routing events to resizing FrameSets.

Since this was the only special feature of RenderFrameSet::nodeAtPoint,
the method has been removed.

* rendering/RenderFrameSet.cpp:
* rendering/RenderFrameSet.h:
(RenderFrameSet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoThe 'formnovalidate' attribute doesn't work correctly on button elements with child...
commit-queue@webkit.org [Mon, 18 Mar 2013 11:48:57 +0000 (11:48 +0000)]
The 'formnovalidate' attribute doesn't work correctly on button elements with child elements
https://bugs.webkit.org/show_bug.cgi?id=112541

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2013-03-18
Reviewed by Kent Tamura.

Source/WebCore:

Fix a bug where formnovalidate attribute of <button> is not honored
if the target of the click event is an element nested within the button.

Test: fast/forms/interactive-validation-formnovalidate-child.html

* html/HTMLFormElement.cpp:
(WebCore::submitElementFromEvent): Looks for the nearest FormControlElement ancestor of the event target.

LayoutTests:

* fast/forms/interactive-validation-formnovalidate-child-expected.txt: Added.
* fast/forms/interactive-validation-formnovalidate-child.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed EFL rebaseline after r146050.
gyuyoung.kim@samsung.com [Mon, 18 Mar 2013 11:36:51 +0000 (11:36 +0000)]
Unreviewed EFL rebaseline after r146050.

* platform/efl/fast/css/input-search-padding-expected.txt:
* platform/efl/fast/css/text-input-with-webkit-border-radius-expected.txt:
* platform/efl/fast/css/text-overflow-input-expected.txt:
* platform/efl/fast/forms/box-shadow-override-expected.txt:
* platform/efl/fast/forms/control-restrict-line-height-expected.txt:
* platform/efl/fast/forms/input-appearance-height-expected.txt:
* platform/efl/fast/forms/placeholder-position-expected.txt:
* platform/efl/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/efl/fast/forms/search-styled-expected.txt:
* platform/efl/fast/forms/search-vertical-alignment-expected.txt:
* platform/efl/fast/forms/searchfield-heights-expected.txt:
* platform/efl/fast/repaint/search-field-cancel-expected.txt:
* platform/efl/fast/replaced/width100percent-searchfield-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd touch support to the calendar picker
keishi@webkit.org [Mon, 18 Mar 2013 11:02:27 +0000 (11:02 +0000)]
Add touch support to the calendar picker
https://bugs.webkit.org/show_bug.cgi?id=112256

Reviewed by Kent Tamura.

Source/WebCore:

This patch increases the hit target sizes for touch and adds touch event
support to the scroll view, scroll bar and navigation button.

Tests: platform/chromium/fast/forms/calendar-picker/calendar-picker-touch-operations.html
       platform/chromium/fast/forms/calendar-picker/month-picker-touch-operations.html
       platform/chromium/fast/forms/calendar-picker/week-picker-touch-operations.html

* Resources/pagepopups/calendarPicker.js:
(hasInaccuratePointingDevice):
(Animator): Super class for TransitionAnimator and FlingGestureAnimator.
(Animator.prototype.start):
(Animator.prototype.stop):
(Animator.prototype.onAnimationFrame):
(TransitionAnimator): Same as the old Animator. Transition from one value to another.
(TransitionAnimator.prototype.setFrom):
(TransitionAnimator.prototype.start):
(TransitionAnimator.prototype.stop):
(TransitionAnimator.prototype.setTo):
(TransitionAnimator.prototype.onAnimationFrame):
(FlingGestureAnimator):Animates the fling scroll.
(FlingGestureAnimator.prototype._valueAtTime): Returns the value at the given time.
(FlingGestureAnimator.prototype._velocityAtTime): Returns the value change velocity at the given time.
(FlingGestureAnimator.prototype._timeAtVelocity): Returns the time when the value is changing at the given velocity.
(FlingGestureAnimator.prototype.start):
(FlingGestureAnimator.prototype.onAnimationFrame):
(ScrollView): Added support for touch gesture scrolling.
(ScrollView.prototype.onTouchStart):
(ScrollView.prototype.onWindowTouchMove):
(ScrollView.prototype.onWindowTouchEnd):
(ScrollView.prototype.onFlingGestureAnimatorStep):
(ScrollView.prototype.scrollTo):
(ScrubbyScrollBar): Added support for touch.
(ScrubbyScrollBar.prototype.onTouchStart):
(ScrubbyScrollBar.prototype.onWindowTouchMove):
(ScrubbyScrollBar.prototype.onWindowTouchEnd):
(ScrubbyScrollBar.prototype._setThumbPositionFromEventPosition): Accept MouseEvent or Touch.
(ScrubbyScrollBar.prototype.onMouseDown):
(ScrubbyScrollBar.prototype.onWindowMouseMove):
(ScrubbyScrollBar.prototype.onWindowMouseUp):
(YearListCell):
(YearListView):
(YearListView.prototype.onTouchStart):
(YearListView.prototype._animateRow):
(CalendarNavigationButton): Add touch support for long press.
(CalendarNavigationButton.prototype.onTouchStart):
(CalendarNavigationButton.prototype.onWindowTouchEnd):
(CalendarNavigationButton.prototype.onMouseDown):
(CalendarNavigationButton.prototype.onWindowMouseUp):
(CalendarTableView): Disable touch gesture scrolling in the calendar table.

LayoutTests:

* platform/chromium/fast/forms/calendar-picker/calendar-picker-touch-operations-expected.txt: Added.
* platform/chromium/fast/forms/calendar-picker/calendar-picker-touch-operations.html: Added.
* platform/chromium/fast/forms/calendar-picker/month-picker-touch-operations-expected.txt: Added.
* platform/chromium/fast/forms/calendar-picker/month-picker-touch-operations.html: Added.
* platform/chromium/fast/forms/calendar-picker/resources/calendar-picker-common.js:
(hoverOverMonthPopupButton):
(clickMonthPopupButton): Use hoverOverMonthPopupButton.
* platform/chromium/fast/forms/calendar-picker/week-picker-touch-operations-expected.txt: Added.
* platform/chromium/fast/forms/calendar-picker/week-picker-touch-operations.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] BackingStoreClient: remove unnecessary call to toElement()
commit-queue@webkit.org [Mon, 18 Mar 2013 10:52:20 +0000 (10:52 +0000)]
[BlackBerry] BackingStoreClient: remove unnecessary call to toElement()
https://bugs.webkit.org/show_bug.cgi?id=112547

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-18
Reviewed by Carlos Garcia Campos.

* WebKitSupport/BackingStoreClient.cpp:
(BlackBerry::WebKit::BackingStoreClient::absoluteRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Cancel mark on search field is not displayed
gyuyoung.kim@samsung.com [Mon, 18 Mar 2013 10:13:19 +0000 (10:13 +0000)]
[EFL] Cancel mark on search field is not displayed
https://bugs.webkit.org/show_bug.cgi?id=94880

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

adjustSearchFieldCancelButtonStyle() doesn't set style width and height for search cancel button.
So, the button isn't showing up in search input field. Besides the button size should be scaled based
on the font size as chromium, qt, and blackberry ports.

Tests: fast/forms/search-cancel-button-style-sharing.html
       fast/forms/search-rtl.html

* platform/efl/RenderThemeEfl.cpp:
(WebCore):
(WebCore::RenderThemeEfl::adjustSearchFieldCancelButtonStyle):

LayoutTests:

Rebaseline expected results related to search cancel button.

* platform/efl-wk1/TestExpectations: These tests don't work with WK1 pixel test yet.
* platform/efl/TestExpectations:
* platform/efl/fast/forms/search-cancel-button-style-sharing-expected.png:
* platform/efl/fast/forms/search-cancel-button-style-sharing-expected.txt:
* platform/efl/fast/forms/search-rtl-expected.png:
* platform/efl/fast/forms/search-rtl-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Native Memory Timeline affects the performace even if was switched...
yurys@chromium.org [Mon, 18 Mar 2013 09:40:23 +0000 (09:40 +0000)]
Web Inspector: Native Memory Timeline affects the performace even if was switched off.
https://bugs.webkit.org/show_bug.cgi?id=112428

Reviewed by Pavel Feldman.

Source/WebCore:

Whether to include DOM counters and native memory statistics is now
configured using Timeline.start parameters instead of sending separate
commands Timeline.setIncludeDomCounters and Timeline.setIncludeNativeMemoryStatistics.

* inspector/Inspector.json:
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::restore):
(WebCore::InspectorTimelineAgent::start):
* inspector/InspectorTimelineAgent.h:
(InspectorTimelineAgent):
* inspector/front-end/DOMCountersGraph.js:
(WebInspector.DOMCountersGraph):
* inspector/front-end/NativeMemoryGraph.js:
(WebInspector.NativeMemoryGraph):
* inspector/front-end/TimelineManager.js:
(WebInspector.TimelineManager.prototype.start):
* inspector/front-end/TimelineModel.js:
(WebInspector.TimelineModel.prototype.startRecord):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype.get _toggleTimelineButtonClicked):

LayoutTests:

* http/tests/inspector/timeline-test.js: chaned Timeline.start parameters
to match previous behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Exception in timeline DOMCounters
yurys@chromium.org [Mon, 18 Mar 2013 09:32:08 +0000 (09:32 +0000)]
Web Inspector: Exception in timeline DOMCounters
https://bugs.webkit.org/show_bug.cgi?id=112427

Reviewed by Pavel Feldman.

Do not update marker on DOM counters graph if the graphs haven't been
drawn yet.

* inspector/front-end/MemoryStatistics.js:
(WebInspector.MemoryStatistics.prototype._refreshCurrentValues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMediastream.ended should return true when all tracks were removed.
li.yin@intel.com [Mon, 18 Mar 2013 09:28:08 +0000 (09:28 +0000)]
Mediastream.ended should return true when all tracks were removed.
https://bugs.webkit.org/show_bug.cgi?id=112528

Reviewed by Kentaro Hara.

Source/WebCore:

Spec: http://dev.w3.org/2011/webrtc/editor/getusermedia.html#widl-MediaStream-ended
When all tracks have been removed, it should return true as well as all the tracks
were ended.

Test: fast/mediastream/MediaStream-add-remove-tracks.html

* Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::removeTrack):

LayoutTests:

* fast/mediastream/MediaStream-add-remove-tracks-expected.txt:
* fast/mediastream/MediaStream-add-remove-tracks.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: make number of stack frames to capture in Timeline a setting
caseq@chromium.org [Mon, 18 Mar 2013 09:21:59 +0000 (09:21 +0000)]
Web Inspector: make number of stack frames to capture in Timeline a setting
https://bugs.webkit.org/show_bug.cgi?id=110619

Reviewed by Pavel Feldman.

- factor out creation of input type="text" control for better reuse;
- add timelineLimitStackFramesFlag & timelineStackFramesToCapture settings;

* English.lproj/localizedStrings.js: add "Frames to capture" and "Limit number of captured JS stack frames"
* inspector/front-end/Settings.js: add 2 settings;
(WebInspector.Settings):
* inspector/front-end/SettingsScreen.js: UI for the setting;
(WebInspector.GenericSettingsTab):
(WebInspector.GenericSettingsTab.prototype.get _createCSSAutoReloadControls.validateReloadTimeout):
* inspector/front-end/TimelineModel.js: pass the setting value to back-end.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed gardening.
zarvai@inf.u-szeged.hu [Mon, 18 Mar 2013 08:52:00 +0000 (08:52 +0000)]
[Qt] Unreviewed gardening.

* platform/qt-5.0-wk1/TestExpectations:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r146035.
commit-queue@webkit.org [Mon, 18 Mar 2013 08:37:49 +0000 (08:37 +0000)]
Unreviewed, rolling out r146035.
http://trac.webkit.org/changeset/146035
https://bugs.webkit.org/show_bug.cgi?id=112540

fails to build on Windows: singned/unsigned mismatch at ln. 53
of html\HTMLSelectElementWin.cpp (Requested by antonm on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-18

* WebCore.gypi:
* html/HTMLSelectElement.cpp:
(WebCore):
* html/HTMLSelectElementWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r146033.
haraken@chromium.org [Mon, 18 Mar 2013 08:33:30 +0000 (08:33 +0000)]
Unreviewed, rolling out r146033.
http://trac.webkit.org/changeset/146033
https://bugs.webkit.org/show_bug.cgi?id=112521

web audio tests are broken

Source/WebCore:

* Modules/webaudio/AudioNode.cpp:
(WebCore::AudioNode::AudioNode):
* Modules/webaudio/AudioNode.h:
* Modules/webaudio/AudioScheduledSourceNode.h:
* Modules/webaudio/ScriptProcessorNode.idl:

LayoutTests:

* webaudio/javascriptaudionode-expected.txt:
* webaudio/javascriptaudionode.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate test expectations.
antonm@chromium.org [Mon, 18 Mar 2013 08:17:05 +0000 (08:17 +0000)]
Update test expectations.

Unreviewed gardening.

* platform/chromium-win/fast/forms/color/input-appearance-color-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoA placeholder renderer should not be taken to imply the existence of a text renderer...
dominicc@chromium.org [Mon, 18 Mar 2013 08:01:57 +0000 (08:01 +0000)]
A placeholder renderer should not be taken to imply the existence of a text renderer in single line text controls
https://bugs.webkit.org/show_bug.cgi?id=112410

Reviewed by Tony Chang.

Source/WebCore:

The assumption that if a text control had a placeholder renderer
then it also had a text renderer is not valid. If
::-webkit-textfield-decoration-controller is set to display: none;
a single line text control's decoration container renderer and
hence text renderer are not created. This change handles this
corner case where a text control has a placeholder renderer but
not a text renderer.

Tests: fast/forms/search/search-hide-decoration-container-crash.html (Updated)

* html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::fixPlaceholderRenderer):
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::layout):

LayoutTests:

Update search-hide-decoration-container-crash.html to exercise
non-null placeholder renderers and null text renderers.

Cases where neither are rendered already get coverage in
search-scroll-hidden-decoration-container-crash.html and
search-autoscroll-hidden-decoration-container-crash.html.

* fast/forms/search/search-hide-decoration-container-crash.html:
* fast/forms/search/search-hide-decoration-container-crash-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Shadow] offsetParent should never return nodes in user agent Shadow DOM to script
dominicc@chromium.org [Mon, 18 Mar 2013 07:55:30 +0000 (07:55 +0000)]
[Shadow] offsetParent should never return nodes in user agent Shadow DOM to script
https://bugs.webkit.org/show_bug.cgi?id=112530

Reviewed by Elliott Sprehn.

Source/WebCore:

Test: fast/dom/shadow/offset-parent-does-not-leak-ua-shadow.html

* dom/Element.cpp:
(WebCore::Element::bindingsOffsetParent): Filter nodes in UA shadows.
* dom/Element.h:
(Element): Add bindingsOffsetParent.
* dom/Element.idl: bindingsOffsetParent is the implementation of offsetParent.

LayoutTests:

* fast/dom/shadow/offset-parent-does-not-leak-ua-shadow-expected.txt: Added.
* fast/dom/shadow/offset-parent-does-not-leak-ua-shadow.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSupport Windows HTMLSelectElement keystrokes on Chromium win
dmazzoni@google.com [Mon, 18 Mar 2013 06:25:47 +0000 (06:25 +0000)]
Support Windows HTMLSelectElement keystrokes on Chromium win
https://bugs.webkit.org/show_bug.cgi?id=112460

Reviewed by Kent Tamura.

Compile in the windows-specific variant of
HTMLSelectElement::platformHandleKeydownEvent
on Chromium win, in addition to PLATFORM(WIN).

* WebCore.gypi:
    Add html/HTMLSelectElementWin.cpp.
* html/HTMLSelectElement.cpp:
    Don't compile generic platformHandleKeydownEvent on
    Chromium win.
* html/HTMLSelectElementWin.cpp:
    Only compile platformHandleKeydownEvent on Windows.
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMark some more tests as flakey, or asserting in debug.
simon.fraser@apple.com [Mon, 18 Mar 2013 05:54:52 +0000 (05:54 +0000)]
Mark some more tests as flakey, or asserting in debug.

* platform/mac-wk2/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoScriptProcessorNode is garbage collected while still active if unreachable
commit-queue@webkit.org [Mon, 18 Mar 2013 05:51:43 +0000 (05:51 +0000)]
ScriptProcessorNode is garbage collected while still active if unreachable
https://bugs.webkit.org/show_bug.cgi?id=112521

Patch by Russell McClellan <russell.mcclellan@gmail.com> on 2013-03-17
Reviewed by Kentaro Hara.

Source/WebCore:

Fix for issue where ScriptProcessorNodes (and AudioNode js wrappers generally)
would be garbage collected before their time.  Made AudioNode an ActiveDOMElement
marked pending if there are any open audio connections.

Test: webaudio/javascriptaudionode.html

* Modules/webaudio/AudioNode.cpp:
(WebCore::AudioNode::AudioNode):
(WebCore::AudioNode::hasPendingActivity): it's pending (and thus not GCed)
if it has open audio connections.
* Modules/webaudio/AudioNode.h: AudioNode is now an ActiveDOMElement
* Modules/webaudio/AudioScheduledSourceNode.h: added a using declaration
to avoid function name hiding.
* Modules/webaudio/ScriptProcessorNode.idl: AudioNode is an ActiveDOMElement

LayoutTests:

* webaudio/javascriptaudionode-expected.txt:
* webaudio/javascriptaudionode.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoINPUT_MULTIPLE_FIELDS_UI: Step-up/-down of minute/second/millisecond fields should...
commit-queue@webkit.org [Mon, 18 Mar 2013 05:26:10 +0000 (05:26 +0000)]
INPUT_MULTIPLE_FIELDS_UI: Step-up/-down of minute/second/millisecond fields should respect min/max attributes
https://bugs.webkit.org/show_bug.cgi?id=112527

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2013-03-17
Reviewed by Kent Tamura.

Source/WebCore:

Make step-up/-down of the minute, second, and millisecond field
respect the min/max attributes of the element.
Note that it still accepts any keyboard inputs (the element
becomes 'invalid' state when out-of-range values entered).
Also, disable these fields when there is only single possible value.

Tests: fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield.html
       fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html

* html/shadow/DateTimeEditElement.cpp:
(DateTimeEditBuilder): Add fields for min/max of minute/second/millisecond.
(WebCore::DateTimeEditBuilder::DateTimeEditBuilder): Set min/max for the fields.
(WebCore::DateTimeEditBuilder::visitField): Pass min/max parameters to the field constructors.
(WebCore::DateTimeEditBuilder::shouldHourFieldDisabled): Does not disable if minute, second, millisecond fields are all disabled, because we need at least one editable field.
(WebCore::DateTimeEditBuilder::shouldMillisecondFieldDisabled): Disables if min, max, and value are equal.
(WebCore::DateTimeEditBuilder::shouldMinuteFieldDisabled): Ditto.
(WebCore::DateTimeEditBuilder::shouldSecondFieldDisabled): Ditto.
* html/shadow/DateTimeFieldElements.cpp:
(WebCore::DateTimeDayFieldElement::DateTimeDayFieldElement):
(WebCore::DateTimeHourFieldElementBase::DateTimeHourFieldElementBase):
(WebCore::DateTimeHour11FieldElement::DateTimeHour11FieldElement):
(WebCore::DateTimeHour12FieldElement::DateTimeHour12FieldElement):
(WebCore::DateTimeHour23FieldElement::DateTimeHour23FieldElement):
(WebCore::DateTimeHour24FieldElement::DateTimeHour24FieldElement):
(WebCore::DateTimeMillisecondFieldElement::DateTimeMillisecondFieldElement):
(WebCore::DateTimeMillisecondFieldElement::create):
(WebCore::DateTimeMinuteFieldElement::DateTimeMinuteFieldElement):
(WebCore::DateTimeMinuteFieldElement::create):
(WebCore::DateTimeMonthFieldElement::DateTimeMonthFieldElement):
(WebCore::DateTimeSecondFieldElement::DateTimeSecondFieldElement):
(WebCore::DateTimeSecondFieldElement::create):
(WebCore::DateTimeWeekFieldElement::DateTimeWeekFieldElement):
(WebCore::DateTimeYearFieldElement::DateTimeYearFieldElement):
* html/shadow/DateTimeFieldElements.h:
(DateTimeDayFieldElement):
(DateTimeHourFieldElementBase):
(DateTimeHour11FieldElement):
(DateTimeHour12FieldElement):
(DateTimeHour23FieldElement):
(DateTimeHour24FieldElement):
(DateTimeMillisecondFieldElement): Add minimum/maximum parameters.
(DateTimeMinuteFieldElement): Add minimum/maximum parameters.
(DateTimeMonthFieldElement):
(DateTimeSecondFieldElement): Add minimum/maximum parameters.
(DateTimeWeekFieldElement):
(DateTimeYearFieldElement):
* html/shadow/DateTimeNumericFieldElement.cpp:
(WebCore::DateTimeNumericFieldElement::DateTimeNumericFieldElement):
(WebCore::DateTimeNumericFieldElement::formatValue): Use hard-limit value instead of m_range.maximum, because millisecond field with max<100 will be displayed in two digits otherwise.
(WebCore::DateTimeNumericFieldElement::setValueAsInteger):
* html/shadow/DateTimeNumericFieldElement.h:
(DateTimeNumericFieldElement): Changed to have hard limits as a data member.

LayoutTests:

* fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield-expected.txt:
* fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield.html:
* fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer-expected.txt:
* fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Chromium] Remove unused WebNode::hasEventListeners API
abarth@webkit.org [Mon, 18 Mar 2013 03:28:29 +0000 (03:28 +0000)]
[Chromium] Remove unused WebNode::hasEventListeners API
https://bugs.webkit.org/show_bug.cgi?id=112529

Reviewed by James Robinson.

This API no longer has any callers and can be removed.

* public/WebNode.h:
* src/WebNode.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoEncapsulate PlatformMessagePortChannel a little better yet
ap@apple.com [Mon, 18 Mar 2013 02:21:26 +0000 (02:21 +0000)]
Encapsulate PlatformMessagePortChannel a little better yet
https://bugs.webkit.org/show_bug.cgi?id=112479

Reviewed by Sam Weinig.

* dom/MessagePortChannel.h: We no longer expose PlatformMessagePortChannel in
public functions in cross-platform code.

* dom/default/PlatformMessagePortChannel.cpp:
(WebCore::MessagePortChannel::createChannel): Tweaked the factory method to avoid
using the old create() function.
(WebCore::MessagePortChannel::~MessagePortChannel): Removed an unhelpful comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoINPUT_MULTIPLE_FIELDS_UI: Don't update shadow tree by updating any attribute
tkent@chromium.org [Mon, 18 Mar 2013 00:38:09 +0000 (00:38 +0000)]
INPUT_MULTIPLE_FIELDS_UI: Don't update shadow tree by updating any attribute
https://bugs.webkit.org/show_bug.cgi?id=111990

Reviewed by Hajime Morrita.

Source/WebCore:

Bug detail:
Typing '1' then '1' into an hour field doesn't set the field to
'11' if an attribute is updated during these two keyboard inputs
because we always re-construct a shadow DOM tree by updating any
attributes and a shadow node records keyboard input state.

How to fix:
We should not re-construct a shadow DOM tree by updating
unaffected attributes. For example, we should re-construct it by
updating 'min' attribute, but we should not by updating 'class'
attribute.
We have InputType::updateInnerTextValue call in parseAttribute for
text field input types. The multiple fields input types
re-construct shadow DOM tree in updateInnerTextValue. The
updateInnerTextValue call is unnecessary for the multiple fields
input types, and we should call it when it is necessary. So, we
add InputType::attributeChange and text field input types call
updateInnerTextValue in it, and other input types don't.
Also, multiple fields input types need to call
updateInnerTextValue by 'value' attribute change. We add
InputType::valueAttributeChanged.

Tests: Update
fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html. The
value attribute change behavior is covered by
time-multiple-fields-change-layout-by-value.html and
time-multiple-fields-spinbutton-change-and-input-events.html.

* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseAttribute):
- Add a valueAttributeChanged call.
- Calls InputType::attributeChanged
* html/InputType.cpp:
(WebCore::InputType::attributeChanged): Added an empty implementation.
(WebCore::InputType::valueAttributeChanged): Ditto.
* html/InputType.h:
(InputType): Declare attributeChanged and valueAttributeChanged.
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::attributeChanged):
Added. Always call updateInnerTextValue.
* html/TextFieldInputType.h:
(TextFieldInputType): Declare attributeChanged.
* html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::valueAttributeChanged):
Added. Re-construct shadow DOM tree if the input has no dirty value.
* html/BaseMultipleFieldsDateAndTimeInputType.h:
(BaseMultipleFieldsDateAndTimeInputType): Declare valueAttributeChanged.

LayoutTests:

* fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[HTMLTemplateElement] prevent </template> from matching "template" in a non-HTML...
rafaelw@chromium.org [Sun, 17 Mar 2013 23:58:31 +0000 (23:58 +0000)]
[HTMLTemplateElement] prevent </template> from matching "template" in a non-HTML tags on the stack of open elements
https://bugs.webkit.org/show_bug.cgi?id=112487

Reviewed by Adam Barth.

Source/WebCore:

When processing an end template tag, the parser now pops until a "template" tag is parsed, but now ensures that
the "template" it pops is in the HTML namespace.

Tests added to the html5lib test suite.

* html/parser/HTMLElementStack.cpp:
(WebCore::HTMLElementStack::popUntil):
(WebCore):
(WebCore::HTMLElementStack::popUntilPopped):
* html/parser/HTMLElementStack.h:
(HTMLElementStack):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processTemplateEndTag):

LayoutTests:

* html5lib/resources/template.dat:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agofast/frames/flattening/frameset-flattening-subframesets.html is flakey
simon.fraser@apple.com [Sun, 17 Mar 2013 23:06:12 +0000 (23:06 +0000)]
fast/frames/flattening/frameset-flattening-subframesets.html is flakey

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd tests for calendar picker month popup
keishi@webkit.org [Sun, 17 Mar 2013 21:40:38 +0000 (21:40 +0000)]
Add tests for calendar picker month popup
https://bugs.webkit.org/show_bug.cgi?id=112107

Adding tests to check if mouse and keyboard operations work on the month popup.

Reviewed by Kent Tamura.

* platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations-expected.txt:
* platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html:
* platform/chromium/fast/forms/calendar-picker/calendar-picker-mouse-operations-expected.txt:
* platform/chromium/fast/forms/calendar-picker/calendar-picker-mouse-operations.html:
* platform/chromium/fast/forms/calendar-picker/month-picker-key-operations-expected.txt:
* platform/chromium/fast/forms/calendar-picker/month-picker-key-operations.html:
* platform/chromium/fast/forms/calendar-picker/month-picker-mouse-operations-expected.txt:
* platform/chromium/fast/forms/calendar-picker/month-picker-mouse-operations.html:
* platform/chromium/fast/forms/calendar-picker/resources/calendar-picker-common.js:
(clickMonthPopupButton): Clicks the month popup button to open the month popup.
(clickYearListCell): Clicks the year list cell for the given year to reveal the month buttons.
(hoverOverMonthButton): Moves the mouse over to the month button for the given month.
(clickMonthButton): Clicks the month button for the given month.
(checkYearListViewScrollOffset): Checks the year list view scroll offset and returns the difference from the last time it was called.
* platform/chromium/fast/forms/calendar-picker/week-picker-key-operations-expected.txt:
* platform/chromium/fast/forms/calendar-picker/week-picker-key-operations.html:
* platform/chromium/fast/forms/calendar-picker/week-picker-mouse-operations-expected.txt:
* platform/chromium/fast/forms/calendar-picker/week-picker-mouse-operations.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoLegacy CSS vendor prefixes should only work for Dashboard
abarth@webkit.org [Sun, 17 Mar 2013 21:39:31 +0000 (21:39 +0000)]
Legacy CSS vendor prefixes should only work for Dashboard
https://bugs.webkit.org/show_bug.cgi?id=111890

Reviewed by Eric Seidel.

Source/WebCore:

Our experience with the Chromium port is that these legacy CSS vendor
prefixes (-apple- and -khtml-) are not needed for web compatibility.
There is reason to believe, however, that they are needed for
compatibility with Mac OS X Dashboard widgets.

This patch makes the code for these legacy CSS vendor prefixes
enabled at runtime and only enables them when running in Dashboard
compatibility mode. This is the first step towards the plan outlined in
https://lists.webkit.org/pipermail/webkit-dev/2013-March/024085.html.

This patch also removes support for ENABLE(LEGACY_CSS_VENDOR_PREFIXES)
from the V8 bindings because V8 is never used with Dashboard.

* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
* bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::setLegacyCSSVendorPrefixesEnabled):
(WebCore::RuntimeEnabledFeatures::legacyCSSVendorPrefixesEnabled):
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::getCSSPropertyNamePrefix):
(WebCore::cssPropertyIDForJSCSSPropertyName):
* bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
(WebCore::cssPropertyInfo):
* css/CSSParser.cpp:
(WebCore::CSSParser::rewriteSpecifiers):

Source/WebKit/mac:

Enable legacy CSS vendor prefixes when we've been asked to turn on
Dashboard compatibility mode.

* WebView/WebView.mm:
(-[WebView _setDashboardBehavior:to:]):

LayoutTests:

* inspector/styles/vendor-prefixes-expected.txt:
    - Update results to show our new behavior now that -apple- and
      -khtml- are not supported.
* platform/mac/TestExpectations:
    - Skip a test that is testing that we support -apple- prefixes.
* platform/mac/fast/css/dashboard-region-parser.html:
    - Update test to use -webkit- rather than -apple-.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agofast/frames/sandboxed-iframe-navigation-allowed.html sometimes
simon.fraser@apple.com [Sun, 17 Mar 2013 20:54:09 +0000 (20:54 +0000)]
fast/frames/sandboxed-iframe-navigation-allowed.html sometimes
asserts in debug.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBUILD FIX (r145592): AutodrainedPool.h moved to WTF
ddkilzer@apple.com [Sun, 17 Mar 2013 20:09:09 +0000 (20:09 +0000)]
BUILD FIX (r145592): AutodrainedPool.h moved to WTF
<http://webkit.org/b/112171>

Fixes the following build failure:

    Source/WebCore/platform/audio/mac/AudioBusMac.mm:32:9: fatal error: 'AutodrainedPool.h' file not found
    #import "AutodrainedPool.h"
            ^
    1 error generated.

* platform/audio/mac/AudioBusMac.mm: Fix include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Sun, 17 Mar 2013 18:40:14 +0000 (18:40 +0000)]
Unreviewed GTK gardening.

Adding failure expectations for the two reftests added in r145982, failing due to disabled subpixel layout.
Triaging/enhancing failure expectations for spellcheck tests after r145940.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd reload button (and F5 accelerator) to the GtkLauncher toolbar
commit-queue@webkit.org [Sun, 17 Mar 2013 18:11:49 +0000 (18:11 +0000)]
Add reload button (and F5 accelerator) to the GtkLauncher toolbar
https://bugs.webkit.org/show_bug.cgi?id=112442

Patch by Morten Stenshorne <mstensho@opera.com> on 2013-03-17
Reviewed by Gustavo Noronha Silva.

* GtkLauncher/main.c:
(reloadCb):
(createToolbar):
(createWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Fix and improve dist hooks for translations
kov@webkit.org [Sun, 17 Mar 2013 18:10:25 +0000 (18:10 +0000)]
[GTK] Fix and improve dist hooks for translations
https://bugs.webkit.org/show_bug.cgi?id=112519

Reviewed by Carlos Garcia Campos.

Source/WebCore:

* GNUmakefile.am: move translation-related rules and lists to the po directory's
GNUmakefile.am.

Source/WebCore/platform/gtk/po:

* GNUmakefile.am: move dist-related rules here; also move translation-related files
to this file's EXTRA_DIST, making sure to only list the files we actually want
shipped, so junk such as .orig, .rej and backup files do not end up in the tarball.

Source/WebKit/gtk:

* GNUmakefile.am: removed left-over translation files from EXTRA_DIST

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agohttps://bugs.webkit.org/show_bug.cgi?id=97124
simon.fraser@apple.com [Sun, 17 Mar 2013 17:22:42 +0000 (17:22 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=97124
Mark a couple of WK2 tests as possibly asserting in debug.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove font-family applying code to StyleBuilder
eae@chromium.org [Sun, 17 Mar 2013 17:14:33 +0000 (17:14 +0000)]
Move font-family applying code to StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=112441

Reviewed by Allan Sandfeld Jensen.

Many of the font related properties were moved to StyleBuilder in r87362
two years ago. Move font-family as well so that all font properties are
handled the same way.

No new tests, no change in functionality.

* css/StyleBuilder.cpp:
(ApplyPropertyFontFamily):
(WebCore::ApplyPropertyFontFamily::applyInheritValue):
(WebCore::ApplyPropertyFontFamily::applyInitialValue):
(WebCore::ApplyPropertyFontFamily::applyValue):
(WebCore::ApplyPropertyFontFamily::createHandler):
(WebCore::StyleBuilder::StyleBuilder):
Add ApplyPropertyFontFamily for CSSPropertyFontFamily.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
Remove CSSPropertyFontFamily from the giant switch statement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[chromium] Remove the zoom filter operation ifdef
danakj@chromium.org [Sun, 17 Mar 2013 17:12:41 +0000 (17:12 +0000)]
[chromium] Remove the zoom filter operation ifdef
https://bugs.webkit.org/show_bug.cgi?id=112390

Reviewed by Darin Fisher.

This ifdef is not needed once the change that introduced it is
rolled into chromium, and the chromium side guards on the ifdef
are removed. Then it just does nothing and should be deleted.

* chromium/public/WebFilterOperation.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Invalid charset encoding using when substituting a misspelled word in WebKit2
commit-queue@webkit.org [Sun, 17 Mar 2013 16:49:43 +0000 (16:49 +0000)]
[GTK] Invalid charset encoding using when substituting a misspelled word in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=112517

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-17
Reviewed by Alexey Proskuryakov.

The problem is that we are creating the WebContextMenuItemData
with the GtkAction label as UTF-8.

* UIProcess/gtk/WebContextMenuProxyGtk.cpp:
(WebKit::contextMenuItemActivatedCallback): Use String::fromUTF8()
to convert the GtkAction label to UTF-16.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[ENCHANT] Invalid charset encoding used for spelling guess context menu items
commit-queue@webkit.org [Sun, 17 Mar 2013 16:25:41 +0000 (16:25 +0000)]
[ENCHANT] Invalid charset encoding used for spelling guess context menu items
https://bugs.webkit.org/show_bug.cgi?id=112516

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-17
Reviewed by Gustavo Noronha Silva.

Convert spelling guesses returned by enchant to UTF-16 before
passing them to WebCore.

* platform/text/enchant/TextCheckerEnchant.cpp:
(WebCore::TextCheckerEnchant::getGuessesForWord): Use
String::fromUTF8().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMark some more tests as asserting in debug, because of
simon.fraser@apple.com [Sun, 17 Mar 2013 16:21:58 +0000 (16:21 +0000)]
Mark some more tests as asserting in debug, because of
https://bugs.webkit.org/show_bug.cgi?id=105986

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoOccasional assertion in JSNPObject::invalidate() running plugins/object-embed-plugin...
simon.fraser@apple.com [Sun, 17 Mar 2013 16:11:01 +0000 (16:11 +0000)]
Occasional assertion in JSNPObject::invalidate() running plugins/object-embed-plugin-scripting.html
https://bugs.webkit.org/show_bug.cgi?id=112518

Mark this test as [ Crash Pass ] in debug.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Provide default cursor groups as cursor.edc
commit-queue@webkit.org [Sun, 17 Mar 2013 10:44:09 +0000 (10:44 +0000)]
[EFL] Provide default cursor groups as cursor.edc
https://bugs.webkit.org/show_bug.cgi?id=112403

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-03-17
Reviewed by Gyuyoung Kim.

This patch provides a cursor.edc to use the CSS cursor images files in the
WebCore/Resources directory. cursor.edc is included in the default.edc
so that views can use it by default.

* platform/efl/DefaultTheme/CMakeLists.txt:
* platform/efl/DefaultTheme/default.edc:
* platform/efl/DefaultTheme/widget/cursor/cursor.edc: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDisable High DPI Canvas on iOS
psolanki@apple.com [Sun, 17 Mar 2013 06:46:49 +0000 (06:46 +0000)]
Disable High DPI Canvas on iOS
https://bugs.webkit.org/show_bug.cgi?id=112511

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r145898.
commit-queue@webkit.org [Sun, 17 Mar 2013 05:26:04 +0000 (05:26 +0000)]
Unreviewed, rolling out r145898.
http://trac.webkit.org/changeset/145898
https://bugs.webkit.org/show_bug.cgi?id=112512

Causing flakiness on webkit_unit_tests on android bots on
chromium.webkit and chromium.linux (Requested by jochen__ on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-16

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setPageScaleFactor):
(WebKit::WebViewImpl::applyScrollAndScale):
* src/WebViewImpl.h:
(WebViewImpl):
* tests/WebFrameTest.cpp:
* tests/WebViewTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agohttp/tests/notifications/legacy/window-show-on-click.html is flakey
simon.fraser@apple.com [Sat, 16 Mar 2013 21:26:21 +0000 (21:26 +0000)]
http/tests/notifications/legacy/window-show-on-click.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=112499

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove redundant checks from WebInputEvent::isGestureEventType
hans@chromium.org [Sat, 16 Mar 2013 20:47:02 +0000 (20:47 +0000)]
Remove redundant checks from WebInputEvent::isGestureEventType
https://bugs.webkit.org/show_bug.cgi?id=112503

Reviewed by Darin Fisher.

GesturePinchBegin, GesturePinchEnd and GesturePinchUpdate were checked
for twice.

This was found by experimenting with a potential new Clang warning.

* public/WebInputEvent.h:
(WebKit::WebInputEvent::isGestureEventType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoinspector/elements/highlight-node-scaled.html is flakey
simon.fraser@apple.com [Sat, 16 Mar 2013 19:43:41 +0000 (19:43 +0000)]
inspector/elements/highlight-node-scaled.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=112502

Mark this test as flakey.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoReflected video elements hit assertion
simon.fraser@apple.com [Sat, 16 Mar 2013 19:32:26 +0000 (19:32 +0000)]
Reflected video elements hit assertion
https://bugs.webkit.org/show_bug.cgi?id=112490

Disable reflections on video again, since there's some bad behavior
caused by an underlying system framework.

* platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayer::clone):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agosvg/batik/paints/gradientLimit.svg is flakey. Also fix
simon.fraser@apple.com [Sat, 16 Mar 2013 19:20:09 +0000 (19:20 +0000)]
svg/batik/paints/gradientLimit.svg is flakey. Also fix
a couple of recent typos in TestExpectations.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoNotification test is flakey
simon.fraser@apple.com [Sat, 16 Mar 2013 19:10:51 +0000 (19:10 +0000)]
Notification test is flakey
https://bugs.webkit.org/show_bug.cgi?id=112499

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAnother slow sputnik test.
simon.fraser@apple.com [Sat, 16 Mar 2013 19:10:34 +0000 (19:10 +0000)]
Another slow sputnik test.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix typos. Also mark fast/frames/flattening/frameset-flattening-advanced.html
simon.fraser@apple.com [Sat, 16 Mar 2013 18:19:20 +0000 (18:19 +0000)]
Fix typos. Also mark fast/frames/flattening/frameset-flattening-advanced.html
as flakey.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agohttps://bugs.webkit.org/show_bug.cgi?id=93560
simon.fraser@apple.com [Sat, 16 Mar 2013 18:00:06 +0000 (18:00 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=93560

These WebGL tests are flakey on Lion too.

* platform/mac-lion/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoChange fast/events/controlclick-no-onclick.html to be a skip rather than a fail,
simon.fraser@apple.com [Sat, 16 Mar 2013 17:56:59 +0000 (17:56 +0000)]
Change fast/events/controlclick-no-onclick.html to be a skip rather than a fail,
since it times out.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[v8] Disable binding integrity check for WebCore::Text
tsepez@chromium.org [Sat, 16 Mar 2013 17:08:06 +0000 (17:08 +0000)]
[v8] Disable binding integrity check for WebCore::Text
https://bugs.webkit.org/show_bug.cgi?id=112462

Reviewed by Kentaro Hara.

Source/WebCore:

Test: fast/dom/split-cdata.xml

* dom/Text.idl:

LayoutTests:

* fast/dom/split-cdata-expected.txt: Added.
* fast/dom/split-cdata.xml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agofast/frames/sandboxed-iframe-scripting is flakey
mkwst@chromium.org [Sat, 16 Mar 2013 16:43:39 +0000 (16:43 +0000)]
fast/frames/sandboxed-iframe-scripting is flakey
https://bugs.webkit.org/show_bug.cgi?id=112482

Reviewed by Simon Fraser.

Tests that rely on multiple 'iframe' elements loading in a specific
order are a Bad Idea™. This patch splits
'fast/frames/sandboxed-iframe-scripting.html' out into five tests, and
changes two of them (#2 and #4) to use message passing in order to
test in a way that 'js-test-{pre,post}' can cleanly report.

* fast/frames/sandboxed-iframe-scripting-01-expected.txt: Added.
* fast/frames/sandboxed-iframe-scripting-01.html: Added.
* fast/frames/sandboxed-iframe-scripting-02-expected.txt: Added.
* fast/frames/sandboxed-iframe-scripting-02.html: Added.
* fast/frames/sandboxed-iframe-scripting-03-expected.txt: Added.
* fast/frames/sandboxed-iframe-scripting-03.html: Added.
* fast/frames/sandboxed-iframe-scripting-04-expected.txt: Added.
* fast/frames/sandboxed-iframe-scripting-04.html: Added.
* fast/frames/sandboxed-iframe-scripting-05-expected.txt: Added.
* fast/frames/sandboxed-iframe-scripting-05.html: Added.
* fast/frames/sandboxed-iframe-scripting-expected.txt: Removed.
* fast/frames/sandboxed-iframe-scripting.html: Removed.
* platform/mac/TestExpectations:
    Remove the skipped test, since it no longer exists.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate test expectations for content shell.
jochen@chromium.org [Sat, 16 Mar 2013 16:41:34 +0000 (16:41 +0000)]
Update test expectations for content shell.

Unreviewed gardening.

* platform/chromium/ContentShellTestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMark some ref tests as failing on Lion.
simon.fraser@apple.com [Sat, 16 Mar 2013 15:50:46 +0000 (15:50 +0000)]
Mark some ref tests as failing on Lion.

* platform/mac-lion/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMark some more sputnik tests as slow in debug.
simon.fraser@apple.com [Sat, 16 Mar 2013 15:45:42 +0000 (15:45 +0000)]
Mark some more sputnik tests as slow in debug.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAX: aria-hidden on container does not hide descendant popup buttons
cfleizach@apple.com [Sat, 16 Mar 2013 08:51:52 +0000 (08:51 +0000)]
AX: aria-hidden on container does not hide descendant popup buttons
https://bugs.webkit.org/show_bug.cgi?id=112373

Reviewed by Ryosuke Niwa.

Source/WebCore:

There are a number of subclass AX objects that implement accessibilityIsIgnored()
to always return false. This means that even if their parent is aria-hidden=true
they still show up in the tree.

This re-organizes this base case of aria-hidden into AccessibilityObject so that
it can be re-used by these special subclasses where appropriate.

Test: accessibility/aria-hidden-hides-all-elements.html

* accessibility/AccessibilityImageMapLink.h:
(WebCore::AccessibilityImageMapLink::isImageMapLink):
* accessibility/AccessibilityList.cpp:
(WebCore::AccessibilityList::computeAccessibilityIsIgnored):
* accessibility/AccessibilityListBox.cpp:
(WebCore):
* accessibility/AccessibilityListBox.h:
(AccessibilityListBox):
* accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::computeAccessibilityIsIgnored):
* accessibility/AccessibilityMediaControls.cpp:
(WebCore::AccessibilityMediaControl::computeAccessibilityIsIgnored):
(WebCore::AccessibilityMediaControlsContainer::computeAccessibilityIsIgnored):
(WebCore::AccessibilityMediaTimeDisplay::computeAccessibilityIsIgnored):
* accessibility/AccessibilityMediaControls.h:
(AccessibilityMediaControlsContainer):
* accessibility/AccessibilityMenuList.h:
(WebCore::AccessibilityMenuList::roleValue):
* accessibility/AccessibilityMenuListOption.cpp:
(WebCore::AccessibilityMenuListOption::computeAccessibilityIsIgnored):
* accessibility/AccessibilityMenuListPopup.cpp:
(WebCore::AccessibilityMenuListPopup::computeAccessibilityIsIgnored):
* accessibility/AccessibilityMockObject.cpp:
(WebCore::AccessibilityMockObject::computeAccessibilityIsIgnored):
(WebCore):
* accessibility/AccessibilityMockObject.h:
(AccessibilityMockObject):
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::accessibilityIsIgnoredDefaultForObject):
(WebCore):
(WebCore::AccessibilityObject::ariaIsHidden):
(WebCore::AccessibilityObject::accessibilityIsIgnoredBase):
* accessibility/AccessibilityObject.h:
(AccessibilityObject):
* accessibility/AccessibilityProgressIndicator.cpp:
(WebCore::AccessibilityProgressIndicator::computeAccessibilityIsIgnored):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnoredBase):
(WebCore::AccessibilityRenderObject::addImageMapChildren):
* accessibility/AccessibilityRenderObject.h:
(AccessibilityRenderObject):
* accessibility/AccessibilityScrollbar.h:
(AccessibilityScrollbar):
* accessibility/AccessibilitySlider.cpp:
(WebCore):
(WebCore::AccessibilitySliderThumb::computeAccessibilityIsIgnored):
* accessibility/AccessibilitySlider.h:
(AccessibilitySlider):
* accessibility/AccessibilitySpinButton.h:
(WebCore::AccessibilitySpinButton::roleValue):
(AccessibilitySpinButtonPart):

LayoutTests:

* accessibility/aria-hidden-hides-all-elements-expected.txt: Added.
* accessibility/aria-hidden-hides-all-elements.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMac rebaseline after r145977.
rniwa@webkit.org [Sat, 16 Mar 2013 07:43:38 +0000 (07:43 +0000)]
Mac rebaseline after r145977.

* platform/chromium-mac/platform/mac/fast: Added.
* platform/chromium-mac/platform/mac/fast/forms: Added.
* platform/chromium-mac/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt: Added.
* platform/chromium/platform/mac/fast/forms: Removed.
* platform/chromium/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt: Removed.
* platform/mac/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMark two media/track tests as flakey. Tracked by webkit.org/b/112492
simon.fraser@apple.com [Sat, 16 Mar 2013 06:16:59 +0000 (06:16 +0000)]
Mark two media/track tests as flakey. Tracked by webkit.org/b/112492

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove result in platform/mac/platform/mac
simon.fraser@apple.com [Sat, 16 Mar 2013 05:58:15 +0000 (05:58 +0000)]
Remove result in platform/mac/platform/mac

* platform/mac/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix typo in TestExpectations file.
simon.fraser@apple.com [Sat, 16 Mar 2013 05:06:41 +0000 (05:06 +0000)]
Fix typo in TestExpectations file.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoReflected video elements hit assertion on Lion
simon.fraser@apple.com [Sat, 16 Mar 2013 04:56:50 +0000 (04:56 +0000)]
Reflected video elements hit assertion on Lion
https://bugs.webkit.org/show_bug.cgi?id=112490

Disable the new reflected video functionality added in r145915
on Lion because of a nasty re-entrancy problem. Tracked by bug 112490.

* platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayer::clone):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Exclusions] shape-outside on floats for circle and ellipse shapes
commit-queue@webkit.org [Sat, 16 Mar 2013 04:40:04 +0000 (04:40 +0000)]
[CSS Exclusions] shape-outside on floats for circle and ellipse shapes
https://bugs.webkit.org/show_bug.cgi?id=98673

Source/WebCore:

Patch by Bem Jones-Bey <bjonesbe@adobe.com> on 2013-03-15
Reviewed by Dirk Schulze.

Enable circles and ellipses for shape-outside on floats. Most of the
code already supports them, just needed to turn them on and add tests.

Tests: fast/exclusions/shape-outside-floats/shape-outside-floats-simple-circle.html
       fast/exclusions/shape-outside-floats/shape-outside-floats-simple-ellipse.html

* rendering/ExclusionShapeOutsideInfo.cpp:
(WebCore::ExclusionShapeOutsideInfo::isEnabledFor): Enable circles and
    ellipses. Also add a check for if the RenderBox is floating, since
    that test should have been there all along, as shape outside is
    only supported on floats for now.

LayoutTests:

Patch by Bem Jones-Bey <bjonesbe@adobe.com> on 2013-03-15
Reviewed by Dirk Schulze.

Tests for circles and ellipses on floats.

* fast/exclusions/resources/rounded-rectangle.js:
(defined): Helper function to test and see if a js value is defined.
(convertToRoundedRect): Convert a circle or ellipse dimensions to a rounded rect.
(generateShapeOutsideOnFloat): Add ability to generate circles and
    ellipses, since they are just special cases of rounded rectangles.
(generateSimulatedShapeOutsideOnFloat): Add ability to simulate
    circles and ellipses, by treating them as rounded rectangles. Also
    fix minor style issue with an if statement.
(xOutset): Remove unneeded condition in if statement.
* fast/exclusions/shape-outside-floats/shape-outside-floats-simple-circle-expected.html: Added.
* fast/exclusions/shape-outside-floats/shape-outside-floats-simple-circle.html: Added.
* fast/exclusions/shape-outside-floats/shape-outside-floats-simple-ellipse-expected.html: Added.
* fast/exclusions/shape-outside-floats/shape-outside-floats-simple-ellipse.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION (r144884?): WebKit2.DOMWindowExtensionBasic API test is asserting
simon.fraser@apple.com [Sat, 16 Mar 2013 04:37:48 +0000 (04:37 +0000)]
REGRESSION (r144884?): WebKit2.DOMWindowExtensionBasic API test is asserting
https://bugs.webkit.org/show_bug.cgi?id=112205

Disable this API test until Geoff can fix it.

* TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRebaseline after r145977.
simon.fraser@apple.com [Sat, 16 Mar 2013 03:49:13 +0000 (03:49 +0000)]
Rebaseline after r145977.

* platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRebaseline after r145977.
simon.fraser@apple.com [Sat, 16 Mar 2013 03:47:16 +0000 (03:47 +0000)]
Rebaseline after r145977.

* platform/mac/fast/forms/input-appearance-spinbutton-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed new baselines after r145977.
kbr@google.com [Sat, 16 Mar 2013 03:25:55 +0000 (03:25 +0000)]
Unreviewed new baselines after r145977.
https://bugs.webkit.org/show_bug.cgi?id=110837

* platform/chromium-mac-lion/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoConvert old flexbox uses in html.css to new flexbox (non-<select>)
commit-queue@webkit.org [Sat, 16 Mar 2013 02:27:56 +0000 (02:27 +0000)]
Convert old flexbox uses in html.css to new flexbox (non-<select>)
https://bugs.webkit.org/show_bug.cgi?id=110837

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-15
Reviewed by Ojan Vafai.

Source/WebCore:

Covered by existing tests.

* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::layout):
After we set our descendants' heights, we need to mark them for
layout.
(WebCore::RenderTextControlSingleLine::createInnerBlockStyle):
Use new-flexbox style setters.

* css/html.css:
(input::-webkit-textfield-decoration-container):
(input[type="search"]::-webkit-search-cancel-button):
(input[type="search"]::-webkit-search-decoration):
(input[type="search"]::-webkit-search-results-decoration):
(input[type="search"]::-webkit-search-results-button):
(input::-webkit-inner-spin-button):
(input::-webkit-input-speech-button):
(textarea):
(input[type="file"]):
(input[type="color"]::-webkit-color-swatch-wrapper):
(input[type="color"]::-webkit-color-swatch):
(::-webkit-validation-bubble-message):
(::-webkit-validation-bubble-text-block):
* css/themeWin.css:
(input[type="search"]::-webkit-search-results-decoration):
(input[type="search"]::-webkit-search-results-button):
Convert -webkit-box to -webkit-flex and adjust related properties.
Notably switch to auto margins for centering the speech button as well
as the search result and cancel buttons to stay compatible with the
previous centering behaviour. This does not produce visible
differences but eliminates the render tree dump changes.
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::createShadowSubtree):
* html/shadow/TextControlInnerElements.cpp:
(WebCore::TextControlInnerContainer::TextControlInnerContainer):
(WebCore):
(WebCore::TextControlInnerContainer::create):
(WebCore::TextControlInnerContainer::createRenderer):
* html/shadow/TextControlInnerElements.h:
(TextControlInnerContainer):
(WebCore):
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControlInnerContainer::RenderTextControlInnerContainer):
(WebCore):
(WebCore::RenderTextControlInnerContainer::~RenderTextControlInnerContainer):
* rendering/RenderTextControl.h:
(WebCore):
(RenderTextControlInnerContainer):
Create a new DOM element & renderer type for the textfield-decoration
div (the direct child of the <input> in the shadow dom if we have a
special input field). This is necessary because new-flexbox uses a
different algorithm for calculating the baseline, which would
otherwise cause an <input> and an <input type=search> to not be
aligned with each other.
The new renderer just calls back to RenderBlock for calculating the
baseline.
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::layout):
Make sure to mark renderers as needing layout when we change their
style. This didn't use to be necessary because old-flexbox relayouts
children even when they are not marked for needing layout.
(WebCore::RenderTextControlSingleLine::createInnerBlockStyle):
Use new-flexbox CSS properties.
* html/shadow/TextFieldDecorationElement.cpp:
(WebCore::TextFieldDecorationElement::decorate):
Use new-flexbox CSS properties.

LayoutTests:

* fast/forms/placeholder-position-expected.txt:
* platform/chromium-linux/fast/css/input-search-padding-expected.txt:
* platform/chromium-linux/fast/forms/box-shadow-override-expected.txt:
* platform/chromium-linux/fast/forms/control-restrict-line-height-expected.txt:
* platform/chromium-linux/fast/forms/input-appearance-height-expected.txt:
* platform/chromium-linux/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
* platform/chromium-linux/fast/forms/search-styled-expected.txt:
* platform/chromium-linux/fast/forms/searchfield-heights-expected.txt:
* platform/chromium-linux/fast/forms/validation-message-appearance-expected.txt:
* platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.txt:
* platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.txt:
* platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.txt:
* platform/chromium-mac-lion/fast/forms/search-rtl-expected.txt:
* platform/chromium-mac-snowleopard/fast/forms/search-rtl-expected.txt:
* platform/chromium-mac-snowleopard/fast/repaint/search-field-cancel-expected.txt:
* platform/chromium-mac/fast/css/text-overflow-input-expected.txt:
* platform/chromium-mac/fast/forms/box-shadow-override-expected.txt:
* platform/chromium-mac/fast/forms/control-restrict-line-height-expected.txt:
* platform/chromium-mac/fast/forms/input-appearance-height-expected.txt:
* platform/chromium-mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
* platform/chromium-mac/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/chromium-mac/fast/forms/search-rtl-expected.txt:
* platform/chromium-mac/fast/forms/search-vertical-alignment-expected.txt:
* platform/chromium-mac/fast/forms/searchfield-heights-expected.txt:
* platform/chromium-mac/fast/forms/validation-message-appearance-expected.txt:
* platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.txt:
* platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.txt:
* platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.txt:
* platform/chromium-win-xp/fast/forms/search-styled-expected.txt:
* platform/chromium-win/fast/css/input-search-padding-expected.txt:
* platform/chromium-win/fast/css/text-input-with-webkit-border-radius-expected.txt:
* platform/chromium-win/fast/css/text-overflow-input-expected.txt:
* platform/chromium-win/fast/forms/box-shadow-override-expected.txt:
* platform/chromium-win/fast/forms/control-restrict-line-height-expected.txt:
* platform/chromium-win/fast/forms/input-appearance-height-expected.txt:
* platform/chromium-win/fast/forms/number/number-appearance-rtl-expected.txt:
* platform/chromium-win/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
* platform/chromium-win/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
* platform/chromium-win/fast/forms/placeholder-position-expected.txt:
* platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/chromium-win/fast/forms/search-cancel-button-style-sharing-expected.txt:
* platform/chromium-win/fast/forms/search-display-none-cancel-button-expected.txt:
* platform/chromium-win/fast/forms/search-rtl-expected.txt:
* platform/chromium-win/fast/forms/search-styled-expected.txt:
* platform/chromium-win/fast/forms/search-vertical-alignment-expected.txt:
* platform/chromium-win/fast/forms/searchfield-heights-expected.txt:
* platform/chromium-win/fast/forms/validation-message-appearance-expected.txt:
* platform/chromium-win/fast/repaint/search-field-cancel-expected.txt:
* platform/chromium-win/fast/replaced/width100percent-searchfield-expected.txt:
* platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.txt:
* platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.txt:
* platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.txt:
* platform/chromium-win/fast/speech/speech-bidi-rendering-expected.txt:
* platform/chromium/fast/css/input-search-padding-expected.txt:
* platform/chromium/fast/css/text-input-with-webkit-border-radius-expected.txt:
* platform/chromium/fast/forms/number/number-appearance-rtl-expected.txt:
* platform/chromium/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
* platform/chromium/fast/forms/search-cancel-button-style-sharing-expected.txt:
* platform/chromium/fast/forms/search-display-none-cancel-button-expected.txt:
* platform/chromium/fast/forms/search-rtl-expected.txt:
* platform/chromium/fast/forms/search-styled-expected.txt:
* platform/chromium/fast/repaint/search-field-cancel-expected.txt:
* platform/chromium/fast/replaced/width100percent-searchfield-expected.txt:
* platform/chromium/fast/speech/speech-bidi-rendering-expected.txt:
* platform/efl/fast/css/input-search-padding-expected.txt:
* platform/efl/fast/css/text-input-with-webkit-border-radius-expected.txt:
* platform/efl/fast/css/text-overflow-input-expected.txt:
* platform/efl/fast/forms/box-shadow-override-expected.txt:
* platform/efl/fast/forms/control-restrict-line-height-expected.txt:
* platform/efl/fast/forms/input-appearance-height-expected.txt:
* platform/efl/fast/forms/number/number-appearance-rtl-expected.txt:
* platform/efl/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
* platform/efl/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
* platform/efl/fast/forms/placeholder-position-expected.txt:
* platform/efl/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/efl/fast/forms/search-cancel-button-style-sharing-expected.txt:
* platform/efl/fast/forms/search-display-none-cancel-button-expected.txt:
* platform/efl/fast/forms/search-rtl-expected.txt:
* platform/efl/fast/forms/search-styled-expected.txt:
* platform/efl/fast/forms/search-vertical-alignment-expected.txt:
* platform/efl/fast/forms/searchfield-heights-expected.txt:
* platform/efl/fast/forms/validation-message-appearance-expected.txt:
* platform/efl/fast/repaint/search-field-cancel-expected.txt:
* platform/efl/fast/replaced/width100percent-searchfield-expected.txt:
* platform/gtk/fast/css/input-search-padding-expected.txt:
* platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt:
* platform/gtk/fast/css/text-overflow-input-expected.txt:
* platform/gtk/fast/forms/box-shadow-override-expected.txt:
* platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
* platform/gtk/fast/forms/input-appearance-height-expected.txt:
* platform/gtk/fast/forms/number/number-appearance-rtl-expected.txt:
* platform/gtk/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
* platform/gtk/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
* platform/gtk/fast/forms/placeholder-position-expected.txt:
* platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.txt:
* platform/gtk/fast/forms/search-display-none-cancel-button-expected.txt:
* platform/gtk/fast/forms/search-rtl-expected.txt:
* platform/gtk/fast/forms/search-styled-expected.txt:
* platform/gtk/fast/forms/search-vertical-alignment-expected.txt:
* platform/gtk/fast/forms/searchfield-heights-expected.txt:
* platform/gtk/fast/forms/validation-message-appearance-expected.txt:
* platform/gtk/fast/repaint/search-field-cancel-expected.txt:
* platform/gtk/fast/replaced/width100percent-searchfield-expected.txt:
* platform/gtk/fast/speech/input-appearance-searchandspeech-expected.txt:
* platform/mac/fast/css/input-search-padding-expected.txt:
* platform/mac/fast/css/text-input-with-webkit-border-radius-expected.txt:
* platform/mac/fast/css/text-overflow-input-expected.txt:
* platform/mac/fast/forms/box-shadow-override-expected.txt:
* platform/mac/fast/forms/control-restrict-line-height-expected.txt:
* platform/mac/fast/forms/input-appearance-height-expected.txt:
* platform/mac/fast/forms/number/number-appearance-rtl-expected.txt:
* platform/mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
* platform/mac/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
* platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/mac/fast/forms/search-cancel-button-style-sharing-expected.txt:
* platform/mac/fast/forms/search-display-none-cancel-button-expected.txt:
* platform/mac/fast/forms/search-rtl-expected.txt:
* platform/mac/fast/forms/search-styled-expected.txt:
* platform/mac/fast/forms/search-vertical-alignment-expected.txt:
* platform/mac/fast/forms/searchfield-heights-expected.txt:
* platform/mac/fast/forms/validation-message-appearance-expected.txt:
* platform/mac/fast/repaint/search-field-cancel-expected.txt:
* platform/mac/fast/replaced/width100percent-searchfield-expected.txt:
* platform/mac/fast/speech/speech-bidi-rendering-expected.txt:
* platform/qt-5.0/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/qt/fast/css/input-search-padding-expected.txt:
* platform/qt/fast/css/text-input-with-webkit-border-radius-expected.txt:
* platform/qt/fast/css/text-overflow-input-expected.txt:
* platform/qt/fast/forms/box-shadow-override-expected.txt:
* platform/qt/fast/forms/control-restrict-line-height-expected.txt:
* platform/qt/fast/forms/number/number-appearance-rtl-expected.txt:
* platform/qt/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
* platform/qt/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
* platform/qt/fast/forms/placeholder-position-expected.txt:
* platform/qt/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/qt/fast/forms/search-cancel-button-style-sharing-expected.txt:
* platform/qt/fast/forms/search-display-none-cancel-button-expected.txt:
* platform/qt/fast/forms/search-rtl-expected.txt:
* platform/qt/fast/forms/search-styled-expected.txt:
* platform/qt/fast/forms/search-vertical-alignment-expected.txt:
* platform/qt/fast/repaint/search-field-cancel-expected.txt:
* platform/qt/fast/replaced/width100percent-searchfield-expected.txt:
* platform/qt/fast/speech/input-appearance-searchandspeech-expected.txt:
Automated search & replace of RenderDeprecatedFlexibleBox ->
RenderFlexibleBox
* platform/mac/fast/forms/color/input-appearance-color-expected.txt:
* platform/chromium-mac/fast/forms/color/input-appearance-color-expected.txt:
* platform/chromium-win/fast/forms/color/input-appearance-color-expected.txt:
* platform/chromium-linux/fast/forms/color/input-appearance-color-expected.png:
This test shows a minor layout difference (less spacing between
paragraphs with an <input type=color>). The underlying reason is
alignment/baseline-differences with the new flexbox code, and the new
behaviour makes more sense in general (this becomes obvious when
putting text or a <input type=text> next to an <input type=color>).
* platform/chromium/TestExpectations:
Mark input-appearance-color as needing rebaseline on Mac/Win. All
non-Chromium ports ignore fast/forms/color because the feature isn't
enabled, so their TestExpectations need no update.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Rolled Chromium DEPS to r188504. Requested by
commit-queue@webkit.org [Sat, 16 Mar 2013 02:22:07 +0000 (02:22 +0000)]
Unreviewed.  Rolled Chromium DEPS to r188504.  Requested by
"Dana Jansens" <danakj@chromium.org> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-15

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed attempted build fix for Chromium Windows after r145929.
kbr@google.com [Sat, 16 Mar 2013 02:13:47 +0000 (02:13 +0000)]
Unreviewed attempted build fix for Chromium Windows after r145929.
Verified this fix builds and works on Linux.
https://bugs.webkit.org/show_bug.cgi?id=96798

* bindings/v8/V8Binding.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdded some expected results that should be the same across platforms.
simon.fraser@apple.com [Sat, 16 Mar 2013 01:22:05 +0000 (01:22 +0000)]
Added some expected results that should be the same across platforms.
Removed some tests needing rebaseline from Mac TestExpectations.

* compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.txt: Added.
* compositing/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.txt: Added.
* platform/mac-wk2/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMerge MainResourceLoader::willSendRequest into DocumentLoader
japhet@chromium.org [Sat, 16 Mar 2013 01:20:44 +0000 (01:20 +0000)]
Merge MainResourceLoader::willSendRequest into DocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=109757

This is one of the steps to merging MainResourceLoader entirely into
DocumentLoader, given the lack of clear division of responsibility
between the two.

Reviewed by Antti Koivisto.

No new tests, refactor only.

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::mainResourceData):
(WebCore::DocumentLoader::isPostOrRedirectAfterPost):
(WebCore::DocumentLoader::willSendRequest):
(WebCore::DocumentLoader::callContinueAfterNavigationPolicy):
(WebCore::DocumentLoader::continueAfterNavigationPolicy):
(WebCore::DocumentLoader::startLoadingMainResource):
* loader/DocumentLoader.h:
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::resourceData):
(WebCore::MainResourceLoader::redirectReceived):
(WebCore::MainResourceLoader::continueAfterContentPolicy):
(WebCore::MainResourceLoader::reportMemoryUsage):
(WebCore::MainResourceLoader::handleSubstituteDataLoadNow):
(WebCore::MainResourceLoader::load):
* loader/MainResourceLoader.h:
(WebCore::MainResourceLoader::takeIdentifierFromResourceLoader): Temporarily
    exposed for moving from a normal load to SubstituteData load on redirect.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDisable EXT_draw_buffers WebGL extension on Mac
zmo@google.com [Sat, 16 Mar 2013 01:11:00 +0000 (01:11 +0000)]
Disable EXT_draw_buffers WebGL extension on Mac
https://bugs.webkit.org/show_bug.cgi?id=112486

Reviewed by Kenneth Russell.

* html/canvas/EXTDrawBuffers.cpp:
(WebCore::EXTDrawBuffers::supported):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed addition of expectations for test added in r145915.
kbr@google.com [Sat, 16 Mar 2013 00:54:23 +0000 (00:54 +0000)]
Unreviewed addition of expectations for test added in r145915.

* platform/chromium-mac-lion/compositing/video/video-reflection-expected.png: Added.
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/video/video-reflection-expected.png: Added.
* platform/chromium-mac/compositing/video/video-reflection-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/video/video-reflection-expected.png: Added.
* platform/chromium-win/compositing/video/video-reflection-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/softwarecompositing/video/video-reflection-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[chromium] Remove the background filter blur layout tests
danakj@chromium.org [Sat, 16 Mar 2013 00:43:24 +0000 (00:43 +0000)]
[chromium] Remove the background filter blur layout tests
https://bugs.webkit.org/show_bug.cgi?id=112372

Reviewed by James Robinson.

Source/WebCore:

Remove the now-unused hacks to regression test the background
filter blur compositor feature.

* testing/Internals.cpp:
* testing/Internals.h:
(Internals):
* testing/Internals.idl:

LayoutTests:

Given that we now have the ability to write pixel tests directly against
the compositor, these tests are no longer needed to guard against
regressions, and have been duplicated for the compositor as pixel tests
in https://codereview.chromium.org/12518026/ and
https://codereview.chromium.org/12518026/.

* platform/chromium/compositing/filters/background-filter-blur-expected.png: Removed.
* platform/chromium/compositing/filters/background-filter-blur-expected.txt: Removed.
* platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png: Removed.
* platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.txt: Removed.
* platform/chromium/compositing/filters/background-filter-blur-off-axis.html: Removed.
* platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Removed.
* platform/chromium/compositing/filters/background-filter-blur-outsets-expected.txt: Removed.
* platform/chromium/compositing/filters/background-filter-blur-outsets.html: Removed.
* platform/chromium/compositing/filters/background-filter-blur.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMark fast/frames/sandboxed-iframe-scripting as flakey.
simon.fraser@apple.com [Sat, 16 Mar 2013 00:37:35 +0000 (00:37 +0000)]
Mark fast/frames/sandboxed-iframe-scripting as flakey.

webkit.org/b/104848 supposedly fixed fast/frames/sandboxed-iframe-parsing-space-characters.html,
so remove it.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] BlackBerry::Platform::Graphics::GraphicsContext integration related...
anilsson@rim.com [Sat, 16 Mar 2013 00:36:12 +0000 (00:36 +0000)]
[BlackBerry] BlackBerry::Platform::Graphics::GraphicsContext integration related changes in Source/WebKit/blackberry
https://bugs.webkit.org/show_bug.cgi?id=112467

Reviewed by Rob Buis.

PR 293208

This patch contains contributions from many members of the BlackBerry
WebKit team:

Mike Lattanzio
Arvid Nilsson
Jakob Petsovits
Konrad Piascik
Jeff Rogers
Filip Spacek

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::render):
(BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
(BlackBerry::WebKit::BackingStorePrivate::compositeContents):
(BlackBerry::WebKit::BackingStorePrivate::tileSize):
* Api/WebOverlay.cpp:
(BlackBerry::WebKit::WebOverlayPrivate::drawContents):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::paintContents):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::WebOverlayLayerCompositingThreadClient):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setContentsToImage):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::clearUploadedContents):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setContentsToColor):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::drawTextures):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::WebOverlayPrivateCompositingThread):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::removeFromParent):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setContentsToImage):
* Api/WebOverlay.h:
* Api/WebOverlayClient.h:
* Api/WebOverlay_p.h:
(WebOverlayPrivate):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::showDebugBorders):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::showRepaintCounter):
(WebOverlayLayerCompositingThreadClient):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::image):
(WebOverlayPrivateCompositingThread):
* Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
* WebKitSupport/BackingStoreTile.cpp:
(BlackBerry::WebKit::TileBuffer::~TileBuffer):
(BlackBerry::WebKit::TileBuffer::nativeBuffer):
(BlackBerry::WebKit::TileBuffer::paintBackground):
* WebKitSupport/DefaultTapHighlight.cpp:
(BlackBerry::WebKit::DefaultTapHighlight::paintContents):
(BlackBerry::WebKit::DefaultTapHighlight::showDebugBorders):
(WebKit):
(BlackBerry::WebKit::DefaultTapHighlight::showRepaintCounter):
* WebKitSupport/DefaultTapHighlight.h:
(DefaultTapHighlight):
* WebKitSupport/InspectorOverlayBlackBerry.cpp:
(BlackBerry::WebKit::InspectorOverlay::showDebugBorders):
(WebKit):
(BlackBerry::WebKit::InspectorOverlay::showRepaintCounter):
* WebKitSupport/InspectorOverlayBlackBerry.h:
(InspectorOverlay):
* WebKitSupport/SelectionOverlay.cpp:
(BlackBerry::WebKit::SelectionOverlay::draw):
(BlackBerry::WebKit::SelectionOverlay::hide):
(BlackBerry::WebKit::SelectionOverlay::paintContents):
(BlackBerry::WebKit::SelectionOverlay::showDebugBorders):
(WebKit):
(BlackBerry::WebKit::SelectionOverlay::showRepaintCounter):
* WebKitSupport/SelectionOverlay.h:
(SelectionOverlay):
* WebKitSupport/SurfacePool.cpp:
(BlackBerry::WebKit::SurfacePool::createPlatformGraphicsContext):
(BlackBerry::WebKit::SurfacePool::destroyPlatformGraphicsContext):
(BlackBerry::WebKit::SurfacePool::waitForBuffer):
(BlackBerry::WebKit::SurfacePool::notifyBuffersComposited):
(BlackBerry::WebKit::SurfacePool::destroyPlatformSync):
* WebKitSupport/SurfacePool.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoplugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct...
jochen@chromium.org [Sat, 16 Mar 2013 00:20:08 +0000 (00:20 +0000)]
plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
https://bugs.webkit.org/show_bug.cgi?id=112478

Reviewed by Tony Chang.

There is nothing that ensures that the log messages from the plugin
come in before the layout test finished loading.

Tools:

* DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
(PassDifferentNPPStruct::NPP_SetWindow):
* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(NPP_SetWindow):

LayoutTests:

* platform/mac-wk2/plugins/netscape-plugin-setwindow-size-2-expected.txt: Removed.
* plugins/netscape-plugin-setwindow-size-2.html:
* plugins/netscape-plugin-setwindow-size.html:
* plugins/pass-different-npp-struct.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMark some more sputnik tests as slow in debug.
simon.fraser@apple.com [Fri, 15 Mar 2013 23:52:18 +0000 (23:52 +0000)]
Mark some more sputnik tests as slow in debug.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago Reduce amount of platform specific code in MessagePortChannel
ap@apple.com [Fri, 15 Mar 2013 23:40:32 +0000 (23:40 +0000)]
    Reduce amount of platform specific code in MessagePortChannel
        https://bugs.webkit.org/show_bug.cgi?id=112469

        Reviewed by Sam Weinig.

        * dom/MessagePortChannel.h: Ifdefed out an unused channel() function, except for
        Chromium, where it is used. We certainly don't want to expose this implementation
        detail as a public function.

        * dom/default/PlatformMessagePortChannel.h: Removed functions that are no longer
        delegated. Made class contents all public, as it's now basically a data storage
        for MessagePortChannel.

        * dom/default/PlatformMessagePortChannel.cpp:
        (WebCore::MessagePortChannel::createChannel):
        (WebCore::MessagePortChannel::~MessagePortChannel):
        (WebCore::MessagePortChannel::entangleIfOpen):
        (WebCore::MessagePortChannel::disentangle):
        (WebCore::MessagePortChannel::postMessageToRemote):
        (WebCore::MessagePortChannel::tryGetMessageFromRemote):
        (WebCore::MessagePortChannel::close):
        (WebCore::MessagePortChannel::isConnectedTo):
        (WebCore::MessagePortChannel::hasPendingActivity):
        (WebCore::MessagePortChannel::locallyEntangledPort):
        (WebCore::PlatformMessagePortChannel::PlatformMessagePortChannel):
        (WebCore::PlatformMessagePortChannel::entangledChannel):
        Moved code from PlatformMessagePortChannel to MessagePortChannel. Added some
        FIXMEs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoNew baseline for this test on Lion.
simon.fraser@apple.com [Fri, 15 Mar 2013 23:36:00 +0000 (23:36 +0000)]
New baseline for this test on Lion.

* platform/mac-lion/platform/mac/fast/text/vertical-no-sideways-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDisable suppressesIncrementalRendering for the Web Inspector.
timothy@apple.com [Fri, 15 Mar 2013 23:30:13 +0000 (23:30 +0000)]
Disable suppressesIncrementalRendering for the Web Inspector.

This ends up causing the Inspector to show blank for a couple seconds before
it does its first paint. During that time the bare window chrome is showing
when the Inspector's background and other simple elements count be painting.
This causes the Inspector to look like it is loading slower than reality.

Source/WebKit/mac:

https://bugs.webkit.org/show_bug.cgi?id=112300
rdar://problem/13412219

Reviewed by Geoff Garen.

* WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController init]): Disable suppressesIncrementalRendering.

Source/WebKit2:

https://bugs.webkit.org/show_bug.cgi?id=112300
rdar://problem/13412219

Reviewed by Geoff Garen.

* UIProcess/WebInspectorProxy.cpp:
(WebKit::createInspectorPageGroup): Disable suppressesIncrementalRendering.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Expose the compositing thread layer's draw rectangle to aid hit testing
anilsson@rim.com [Fri, 15 Mar 2013 23:30:03 +0000 (23:30 +0000)]
[BlackBerry] Expose the compositing thread layer's draw rectangle to aid hit testing
https://bugs.webkit.org/show_bug.cgi?id=112255

Reviewed by Rob Buis.

PR 308284.
Reviewed internally by Yongxin Dai.

Source/WebCore:

Add a getter for the layer renderer of a compositing thread layer.

No change in behavior, no new tests.

* platform/graphics/blackberry/LayerCompositingThread.h:
(WebCore::LayerCompositingThread::layerRenderer):

Source/WebKit/blackberry:

The cached draw rectangle is useful for hit testing. Add a getter for
this compositing thread layer property to the public WebOverlay API.
We name this getter using terminology familiar from the
ViewportAccessor interface, to clarify which coordinate system the
getter uses (pixel coordinates relative to the viewport).

Note that WebKit-thread flavor of WebOverlay is not currently used by
any API client and is marked obsolete. It is used internally in WebKit,
but for that case using GraphicsLayer directly works well. This will
allow the complexity of WebOverlay to be significantly reduced in the
future, by removing the WebKit-thread flavor entirely.

* Api/WebOverlay.cpp:
(BlackBerry::WebKit::WebOverlay::pixelViewportRect):
(WebKit):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::pixelViewportRect):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::pixelViewportRect):
* Api/WebOverlay.h:
(WebKit):
* Api/WebOverlay_p.h:
(WebOverlayPrivate):
(WebOverlayPrivateWebKitThread):
(WebOverlayPrivateCompositingThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDelay creating the Inspector window so we don't cause a CoreIPC deadlock.
timothy@apple.com [Fri, 15 Mar 2013 23:29:58 +0000 (23:29 +0000)]
Delay creating the Inspector window so we don't cause a CoreIPC deadlock.

Other changes include:
* Create the Inspector WKView at the correct size so it does not need to
  resize later when added to the window.
* Update the minimum and initial window sizes to better match the new UI.
* Store the Inspector window frame in WebKit preferences so each page group
  can have different saved window frames. Handy for inspecting the Inspector.

https://bugs.webkit.org/show_bug.cgi?id=112300
rdar://problem/13412219

Reviewed by Geoff Garen.

* Shared/WebPreferencesStore.cpp:
(WebKit::defaultValueForKey):
Added FOR_EACH_WEBKIT_STRING_PREFERENCE_NOT_IN_WEBCORE.

* Shared/WebPreferencesStore.h:
(FOR_EACH_WEBKIT_STRING_PREFERENCE_NOT_IN_WEBCORE):
Added. Needed to keep WebPage::updatePreferences for trying to set WebCore::Settings.

* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::minimumWindowWidth):
(WebKit::WebInspectorProxy::initialWindowWidth):
Bumped the values to work better with the new UI.

* UIProcess/WebInspectorProxy.h:
(WebKit::WebInspectorProxy::windowFrameDidChange):
Added.

* UIProcess/mac/WebInspectorProxyMac.mm:
(-[WKWebInspectorProxyObjCAdapter windowDidMove:]):
(-[WKWebInspectorProxyObjCAdapter windowDidResize:]):
Call WebInspectorProxy::windowFrameDidChange.

(WebKit::WebInspectorProxy::createInspectorWindow):
Use the preferences for the page group to get the window frame.

(WebKit::WebInspectorProxy::platformCreateInspectorPage):
Stop calling platformAttach or createInspectorWindow, do it in platformOpen.

(WebKit::WebInspectorProxy::platformOpen):
Call platformAttach or createInspectorWindow here instead.

(WebKit::WebInspectorProxy::windowFrameDidChange):
Added. Store the frame in the page group's preferences.

(WebKit::WebInspectorProxy::platformAttach):
(WebKit::WebInspectorProxy::platformDetach):
Remove code that called setHidden:. We don't need to do that anymore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoConvert <select> to new-flexbox
commit-queue@webkit.org [Fri, 15 Mar 2013 23:14:55 +0000 (23:14 +0000)]
Convert <select> to new-flexbox
https://bugs.webkit.org/show_bug.cgi?id=112395

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-15
Reviewed by Ojan Vafai.

Covered by existing tests.

* css/html.css:
(select):
(select[size][multiple]):
(select[size="1"]):
Use new-style flexbox properties.
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::RenderMenuList):
(WebCore::RenderMenuList::createInnerBlock):
(WebCore::RenderMenuList::adjustInnerStyle):
(WebCore::RenderMenuList::removeChild):
RenderDeprecatedFlexibleBox -> RenderFlexibleBox, and use the
new-style flexbox properties. Use margin:auto for centering to get
the old safe-centering behavior.
* rendering/RenderMenuList.h:
(RenderMenuList):
Inherit from RenderFlexibleBox. Override baseline methods to call the
RenderBlock methods

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION (r145820): Stop over-retaining CFDataRefs in SharedBuffer::maybeTransferPl...
aestes@apple.com [Fri, 15 Mar 2013 23:11:20 +0000 (23:11 +0000)]
REGRESSION (r145820): Stop over-retaining CFDataRefs in SharedBuffer::maybeTransferPlatformData()
https://bugs.webkit.org/show_bug.cgi?id=112474

Reviewed by Simon Fraser.

Transfer ownership of m_cfData to the local variable rather than leaking a reference.

* platform/cf/SharedBufferCF.cpp:
(WebCore::SharedBuffer::maybeTransferPlatformData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145958 268f45cc-cd09-0410-ab3c-d52691b4dbfc