WebKit-https.git
6 years ago[GTK] [CMake] JavaScriptCore crashes in JSC::eval
mrobinson@webkit.org [Fri, 14 Feb 2014 03:35:13 +0000 (03:35 +0000)]
[GTK] [CMake] JavaScriptCore crashes in JSC::eval
https://bugs.webkit.org/show_bug.cgi?id=128434

Extend a fix for EFL to all ports that use GCC. Also include further fixes
that were applied only to the autotools build.

Reviewed by Gyuyoung Kim.

* Source/cmake/OptionsCommon.cmake: Add -fno-omit-frame-pointer to all ports as well
as -fno-tree-dce, which is necessary for GTK+.
* Source/cmake/OptionsEfl.cmake: The GCC flag additions are now in the common options file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoThe JSContainerConvertor and ObjcContainerConvertor need to protect JSValueRefs....
mark.lam@apple.com [Fri, 14 Feb 2014 02:42:10 +0000 (02:42 +0000)]
The JSContainerConvertor and ObjcContainerConvertor need to protect JSValueRefs. Part 2.
<https://webkit.org/b/128764>

Reviewed by Mark Hahnenberg.

toJS() is the wrong cast function to use. We need to use toJSForGC() instead.
Also we need to acquire the JSLock to prevent concurrent accesses to the
Strong handle list.

* API/JSValue.mm:
(JSContainerConvertor::add):
(containerValueToObject):
(ObjcContainerConvertor::add):
(objectToValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoJSManagedValue::dealloc modifies NSMapTable while iterating it
mhahnenberg@apple.com [Fri, 14 Feb 2014 02:36:44 +0000 (02:36 +0000)]
JSManagedValue::dealloc modifies NSMapTable while iterating it
https://bugs.webkit.org/show_bug.cgi?id=128713

Reviewed by Geoffrey Garen.

Having to write a test for this revealed a bug in how addManagedReference:withOwner:
actually notifies JSManagedValues of new owners.

* API/JSManagedValue.mm:
(-[JSManagedValue dealloc]):
* API/JSVirtualMachine.mm:
(-[JSVirtualMachine addManagedReference:withOwner:]):
(-[JSVirtualMachine removeManagedReference:withOwner:]):
* API/tests/testapi.mm:
(testObjectiveCAPI):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, fix build.
fpizlo@apple.com [Fri, 14 Feb 2014 02:32:02 +0000 (02:32 +0000)]
Unreviewed, fix build.

* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileGetMyArgumentsLength):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Windows] Unreviewed gardening of some timing out tests.
roger_fong@apple.com [Fri, 14 Feb 2014 02:25:28 +0000 (02:25 +0000)]
[Windows] Unreviewed gardening of some timing out tests.
https://bugs.webkit.org/show_bug.cgi?id=128789.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSpeculative Release build fix after r164077.
rniwa@webkit.org [Fri, 14 Feb 2014 02:04:51 +0000 (02:04 +0000)]
Speculative Release build fix after r164077.

* API/JSValue.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove position:sticky runtime flag
mmaxfield@apple.com [Fri, 14 Feb 2014 01:59:29 +0000 (01:59 +0000)]
Remove position:sticky runtime flag
https://bugs.webkit.org/show_bug.cgi?id=128774

Reviewed by Simon Fraser.

Rollout of r128663

No new tests are necessary because there is no behavior change.

* css/CSSParser.cpp:
(WebCore::CSSParserContext::CSSParserContext):
(WebCore::operator==):
(WebCore::isValidKeywordPropertyAndValue):
* css/CSSParserMode.h:
* dom/Document.cpp:
* dom/Document.h:
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd -[WKWebView stopLoading:]
andersca@apple.com [Fri, 14 Feb 2014 01:53:43 +0000 (01:53 +0000)]
Add -[WKWebView stopLoading:]
https://bugs.webkit.org/show_bug.cgi?id=128784

Reviewed by Dan Bernstein.

* UIProcess/API/Cocoa/WKWebView.h:
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView stopLoading:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDumpRenderTree fails to build: Perl support module building for OS X but linking...
dfarler@apple.com [Fri, 14 Feb 2014 01:49:24 +0000 (01:49 +0000)]
DumpRenderTree fails to build: Perl support module building for OS X but linking for the simulator
https://bugs.webkit.org/show_bug.cgi?id=128780

Reviewed by Simon Fraser.

* DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL:
Use `xcrun -find clang` instead of `xcrun --sdk $ENV{SDKROOT} -find clang,
which will pick up SDKROOT=iphonesimulator from building the Xcode aggregate target.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r164073 and r164080.
rniwa@webkit.org [Fri, 14 Feb 2014 01:44:07 +0000 (01:44 +0000)]
Unreviewed, rolling out r164073 and r164080.
http://trac.webkit.org/changeset/164073
http://trac.webkit.org/changeset/164080
https://bugs.webkit.org/show_bug.cgi?id=128781

Broke Mac builds (Requested by rniwa on #webkit).

Patch by Commit Queue <commit-queue@webkit.org> on 2014-02-13

Tools:

* DumpRenderTree/mac/EventSendingController.mm:
(+[EventSendingController isSelectorExcludedFromWebScript:]):
(+[EventSendingController webScriptNameForSelector:]):
* WebKitTestRunner/EventSenderProxy.h:
* WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
* WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
* WebKitTestRunner/InjectedBundle/EventSendingController.h:
* WebKitTestRunner/InjectedBundle/ios/EventSenderProxyIOS.mm:
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::didReceiveMessageFromInjectedBundle):
(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
* WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
* WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
* WebKitTestRunner/mac/EventSenderProxy.mm:

LayoutTests:

* platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-div-expected.txt: Removed.
* platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-div-with-handler-expected.txt: Removed.
* platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-div-with-handler.html: Removed.
* platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-div.html: Removed.
* platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-mainframe-expected.txt: Removed.
* platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-mainframe-with-handler-expected.txt: Removed.
* platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-mainframe-with-handler.html: Removed.
* platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-mainframe.html: Removed.
* platform/mac-wk2/tiled-drawing/fast-scroll-iframe-latched-iframe-expected.txt: Removed.
* platform/mac-wk2/tiled-drawing/fast-scroll-iframe-latched-iframe-with-handler-expected.txt: Removed.
* platform/mac-wk2/tiled-drawing/fast-scroll-iframe-latched-iframe-with-handler.html: Removed.
* platform/mac-wk2/tiled-drawing/fast-scroll-iframe-latched-iframe.html: Removed.
* platform/mac-wk2/tiled-drawing/fast-scroll-iframe-latched-mainframe-expected.txt: Removed.
* platform/mac-wk2/tiled-drawing/fast-scroll-iframe-latched-mainframe-with-handler-expected.txt: Removed.
* platform/mac-wk2/tiled-drawing/fast-scroll-iframe-latched-mainframe-with-handler.html: Removed.
* platform/mac-wk2/tiled-drawing/fast-scroll-iframe-latched-mainframe.html: Removed.
* platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-mainframe-expected.txt: Removed.
* platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-mainframe-with-handler-expected.txt: Removed.
* platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-mainframe-with-handler.html: Removed.
* platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-mainframe.html: Removed.
* platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-select-expected.txt: Removed.
* platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-select-with-handler-expected.txt: Removed.
* platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-select-with-handler.html: Removed.
* platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-select.html: Removed.
* platform/mac/fast/scrolling/scroll-div-latched-div-expected.txt: Removed.
* platform/mac/fast/scrolling/scroll-div-latched-div.html: Removed.
* platform/mac/fast/scrolling/scroll-div-latched-mainframe-expected.txt: Removed.
* platform/mac/fast/scrolling/scroll-div-latched-mainframe.html: Removed.
* platform/mac/fast/scrolling/scroll-iframe-latched-iframe-expected.txt: Removed.
* platform/mac/fast/scrolling/scroll-iframe-latched-iframe.html: Removed.
* platform/mac/fast/scrolling/scroll-iframe-latched-mainframe-expected.txt: Removed.
* platform/mac/fast/scrolling/scroll-iframe-latched-mainframe.html: Removed.
* platform/mac/fast/scrolling/scroll-select-latched-mainframe-expected.txt: Removed.
* platform/mac/fast/scrolling/scroll-select-latched-mainframe.html: Removed.
* platform/mac/fast/scrolling/scroll-select-latched-select-expected.txt: Removed.
* platform/mac/fast/scrolling/scroll-select-latched-select.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed build fix for Mountain Lion.
bfulgham@apple.com [Fri, 14 Feb 2014 01:30:10 +0000 (01:30 +0000)]
Unreviewed build fix for Mountain Lion.

* DumpRenderTree/mac/EventSendingController.mm: Provide definition
for kCGScrollWheelEventScrollPhase if it isn't found in the
system headers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd -[WKWebView activeURL]
andersca@apple.com [Fri, 14 Feb 2014 01:24:09 +0000 (01:24 +0000)]
Add -[WKWebView activeURL]
https://bugs.webkit.org/show_bug.cgi?id=128777

Reviewed by Dan Bernstein.

* UIProcess/API/Cocoa/WKWebView.h:
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView activeURL]):
* UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::willChangeActiveURL):
(WebKit::NavigationState::didChangeActiveURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Shapes] Add performance test for complex polygon with shape-margin
zoltan@webkit.org [Fri, 14 Feb 2014 01:17:14 +0000 (01:17 +0000)]
[CSS Shapes] Add performance test for complex polygon with shape-margin
https://bugs.webkit.org/show_bug.cgi?id=128769

Reviewed by Ryosuke Niwa.

This patch modifies the logic of createShapeOutsideTest to accept multiple
CSS properties from the test. The patch adds performance test for complex
polygon shape (self intersecting at multiple places) case, moreover we
apply shape-margin on the polygon also.

* Layout/Shapes/ShapeOutsideContentBox.html:
* Layout/Shapes/ShapeOutsideInset.html:
* Layout/Shapes/ShapeOutsidePolygonWithMargin.html: Added.
* Layout/Shapes/ShapeOutsideRaster.html:
* Layout/Shapes/ShapeOutsideSimplePolygon.html:
* Layout/Shapes/resources/shapes.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoThe JSContainerConvertor and ObjcContainerConvertor need to protect JSValueRefs.
mark.lam@apple.com [Fri, 14 Feb 2014 01:06:53 +0000 (01:06 +0000)]
The JSContainerConvertor and ObjcContainerConvertor need to protect JSValueRefs.
<https://webkit.org/b/128764>

Reviewed by Mark Hahnenberg.

Added a vector of Strong<Unknown> references in the 2 containers, and append
the newly created JSValues to those vectors. This will keep all those JS objects
alive for the duration of the conversion.

* API/JSValue.mm:
(JSContainerConvertor::add):
(ObjcContainerConvertor::add):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK][CMake] Generate GObject DOM bindings .symbols files
gns@gnome.org [Fri, 14 Feb 2014 00:35:24 +0000 (00:35 +0000)]
[GTK][CMake] Generate GObject DOM bindings .symbols files
https://bugs.webkit.org/show_bug.cgi?id=126210

Reviewed by Martin Robinson.

.:

* Source/PlatformGTK.cmake: add checking DOM bindings API as a dependency
for documentation generation.

Source/WebCore:

No new tests. Build change only.

* CMakeLists.txt: list Quota module files and IDLs even if the feature
is disabled, for GTK, since we rely on that for our DOM bindings.
* PlatformGTK.cmake: add a new target to check for DOM symbols API by
running the new python script.
* bindings/gobject/GNUmakefile.am: call the new python script instead
of using a custom rule.

Tools:

* gtk/check-gdom-symbols: Added. Checks symbols compatibility.
(should_update_symbols_file):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agotext-decoration-skip: ink skips randomly when using SVG fonts
mmaxfield@apple.com [Fri, 14 Feb 2014 00:30:15 +0000 (00:30 +0000)]
text-decoration-skip: ink skips randomly when using SVG fonts
https://bugs.webkit.org/show_bug.cgi?id=128709

Reviewed by Simon Fraser.

Source/WebCore:

This patch simply disables skipping underlines being used with SVG fonts.
It's a stopgap until we can support skipping properly with SVG fonts.

Test: svg/custom/svg-fonts-skip-ink.html

* platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::FontPlatformData::ctFont):
* platform/graphics/mac/FontMac.mm:
(WebCore::Font::dashesForIntersectionsWithRect):

LayoutTests:

This text checks that some text without descenders in an SVG font renders the same with and
without text-decoration-skip: ink.

* svg/custom/svg-fonts-skip-ink-expected.html: Added.
* svg/custom/svg-fonts-skip-ink.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdded GetMyArgumentsLength to FTL
commit-queue@webkit.org [Fri, 14 Feb 2014 00:22:45 +0000 (00:22 +0000)]
Added GetMyArgumentsLength to FTL
https://bugs.webkit.org/show_bug.cgi?id=128758

Patch by Matthew Mirman <mmirman@apple.com> on 2014-02-13
Reviewed by Filip Pizlo.

* ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileGetMyArgumentsLength):
* tests/stress/ftl-getmyargumentslength.js: Added.
(foo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCreate some latched scrolling tests.
bfulgham@apple.com [Fri, 14 Feb 2014 00:22:36 +0000 (00:22 +0000)]
Create some latched scrolling tests.
https://bugs.webkit.org/show_bug.cgi?id=127606
<rdar://problem/15911348>

Reviewed by Simon Fraser.

Tools:

* DumpRenderTree/mac/EventSendingController.mm:
(+[EventSendingController isSelectorExcludedFromWebScript:]): Update to recognize
the new "mouseScrollByX:andY:withWheel:andMomentumPhases:" selector.
(+[EventSendingController webScriptNameForSelector:]): Ditto.
(-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Implement
the new wheel event sender.
* WebKitTestRunner/EventSenderProxy.h:
* WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Add declaration
of new mouseScrollByWithWheelAndMomentumPhases method.
* WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases): Added
* WebKitTestRunner/InjectedBundle/EventSendingController.h:
* WebKitTestRunner/InjectedBundle/ios/EventSenderProxyIOS.mm:
(WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Add stub for iOS.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::didReceiveMessageFromInjectedBundle): Handle the new
mouseScrollByWithWheelAndMomentumPhases message.
(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle): Handle the
new mouseScrollByWithWheelAndMomentumPhases.
* WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
(WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Provide stub that
relays to the standard mouse wheel handler.
* WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
(WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
* WebKitTestRunner/mac/EventSenderProxy.mm:
(WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Provide implementation
of mouse wheel gesture method.

LayoutTests:

Add a series of tests to cover desired behavior with wheel events (including momentum).
This behavior is specific to the Mac platform, so is limited to the platform/mac and
platform/mac-wk2 directories.

* platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-div-expected.txt: Added.
* platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-div-with-handler-expected.txt: Added.
* platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-div-with-handler.html: Added.
* platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-div.html: Added.
* platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-mainframe-expected.txt: Added.
* platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-mainframe-with-handler-expected.txt: Added.
* platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-mainframe-with-handler.html: Added.
* platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-mainframe.html: Added.
* platform/mac-wk2/tiled-drawing/fast-scroll-iframe-latched-iframe-expected.txt: Added.
* platform/mac-wk2/tiled-drawing/fast-scroll-iframe-latched-iframe-with-handler-expected.txt: Added.
* platform/mac-wk2/tiled-drawing/fast-scroll-iframe-latched-iframe-with-handler.html: Added.
* platform/mac-wk2/tiled-drawing/fast-scroll-iframe-latched-iframe.html: Added.
* platform/mac-wk2/tiled-drawing/fast-scroll-iframe-latched-mainframe-expected.txt: Added.
* platform/mac-wk2/tiled-drawing/fast-scroll-iframe-latched-mainframe-with-handler-expected.txt: Added.
* platform/mac-wk2/tiled-drawing/fast-scroll-iframe-latched-mainframe-with-handler.html: Added.
* platform/mac-wk2/tiled-drawing/fast-scroll-iframe-latched-mainframe.html: Added.
* platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-mainframe-expected.txt: Added.
* platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-mainframe-with-handler-expected.txt: Added.
* platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-mainframe-with-handler.html: Added.
* platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-mainframe.html: Added.
* platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-select-expected.txt: Added.
* platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-select-with-handler-expected.txt: Added.
* platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-select-with-handler.html: Added.
* platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-select.html: Added.
* platform/mac/fast/scrolling: Added.
* platform/mac/fast/scrolling/scroll-div-latched-div-expected.txt: Added.
* platform/mac/fast/scrolling/scroll-div-latched-div.html: Added.
* platform/mac/fast/scrolling/scroll-div-latched-mainframe-expected.txt: Added.
* platform/mac/fast/scrolling/scroll-div-latched-mainframe.html: Added.
* platform/mac/fast/scrolling/scroll-iframe-latched-iframe-expected.txt: Added.
* platform/mac/fast/scrolling/scroll-iframe-latched-iframe.html: Added.
* platform/mac/fast/scrolling/scroll-iframe-latched-mainframe-expected.txt: Added.
* platform/mac/fast/scrolling/scroll-iframe-latched-mainframe.html: Added.
* platform/mac/fast/scrolling/scroll-select-latched-mainframe-expected.txt: Added.
* platform/mac/fast/scrolling/scroll-select-latched-mainframe.html: Added.
* platform/mac/fast/scrolling/scroll-select-latched-select-expected.txt: Added.
* platform/mac/fast/scrolling/scroll-select-latched-select.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix the iOS build after <http://trac.webkit.org/changeset/164064
dbates@webkit.org [Fri, 14 Feb 2014 00:22:15 +0000 (00:22 +0000)]
Fix the iOS build after <trac.webkit.org/changeset/164064

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, roll out http://trac.webkit.org/changeset/164066.
fpizlo@apple.com [Thu, 13 Feb 2014 23:57:53 +0000 (23:57 +0000)]
Unreviewed, roll out trac.webkit.org/changeset/164066.

It broke tests and it was just plain wrong.

* bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFromLLInt):
(JSC::GetByIdStatus::computeForStubInfo):
* runtime/Structure.h:
(JSC::Structure::takesSlowPathInDFGForImpureProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed build fix.
ryuan.choi@samsung.com [Thu, 13 Feb 2014 23:41:14 +0000 (23:41 +0000)]
Unreviewed build fix.

Fixed typo.

* dfg/DFGIntegerCheckCombiningPhase.cpp:
(JSC::DFG::IntegerCheckCombiningPhase::run):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoChange FTL stack check to use VM's stackLimit
msaboff@apple.com [Thu, 13 Feb 2014 23:35:08 +0000 (23:35 +0000)]
Change FTL stack check to use VM's stackLimit
https://bugs.webkit.org/show_bug.cgi?id=128561

Reviewed by Filip Pizlo.

Changes FTL function entry to check the call frame register against the FTL
specific stack limit (VM::m_ftlStackLimit) and throw an exception if the
stack limit has been exceeded.  Updated the exception handling code to have
a second entry that will unroll the current frame to the caller, since that
is where the exception should be processed.

* ftl/FTLCompile.cpp:
(JSC::FTL::fixFunctionBasedOnStackMaps):
* ftl/FTLIntrinsicRepository.h:
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::lower):
* ftl/FTLState.h:
* runtime/VM.h:
(JSC::VM::addressOfFTLStackLimit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix the ARM build when HAVE_ARM_NEON_INTRINSICS is enabled
dbates@webkit.org [Thu, 13 Feb 2014 23:34:35 +0000 (23:34 +0000)]
Fix the ARM build when HAVE_ARM_NEON_INTRINSICS is enabled

Add !HAVE(ARM_NEON_INTRINSICS)-guard around file-level inline function arithmeticSoftware to
avoid an unused function compiler warning when building with ARM Neon intrinsics.

* platform/graphics/filters/FEComposite.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd -[WKWebView goToBackForwardListItem:]
andersca@apple.com [Thu, 13 Feb 2014 23:33:34 +0000 (23:33 +0000)]
Add -[WKWebView goToBackForwardListItem:]
https://bugs.webkit.org/show_bug.cgi?id=128773

Reviewed by Andreas Kling.

* UIProcess/API/Cocoa/WKWebView.h:
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView goToBackForwardListItem:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoGetByIdStatus shouldn't call takesSlowPathInDFGForImpureProperty() for self accesses...
fpizlo@apple.com [Thu, 13 Feb 2014 23:31:20 +0000 (23:31 +0000)]
GetByIdStatus shouldn't call takesSlowPathInDFGForImpureProperty() for self accesses, and calling that method should never assert about anything
https://bugs.webkit.org/show_bug.cgi?id=128772

Reviewed by Mark Hahnenberg.

* bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFromLLInt):
(JSC::GetByIdStatus::computeForStubInfo):
* runtime/Structure.h:
(JSC::Structure::takesSlowPathInDFGForImpureProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Shapes] Add performance test for raster shape
zoltan@webkit.org [Thu, 13 Feb 2014 23:28:50 +0000 (23:28 +0000)]
[CSS Shapes] Add performance test for raster shape
https://bugs.webkit.org/show_bug.cgi?id=128746

Reviewed by Ryosuke Niwa.

This patch adds performance testing for image valued shape-outside.
The test is skipped by default for now.

* Layout/Shapes/ShapeOutsideRaster.html: Added.
* Layout/Shapes/resources/shape.gif: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[iOS] Disable HAVE_ARM_NEON_INTRINSICS
dbates@webkit.org [Thu, 13 Feb 2014 23:17:10 +0000 (23:17 +0000)]
[iOS] Disable HAVE_ARM_NEON_INTRINSICS

For now, disable HAVE_ARM_NEON_INTRINSICS when building for iOS. We want
to audit the applicable code before we enable this define.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd some RELEASE_ASSERTs to catch JSLock bugs earlier
mhahnenberg@apple.com [Thu, 13 Feb 2014 23:07:12 +0000 (23:07 +0000)]
Add some RELEASE_ASSERTs to catch JSLock bugs earlier
https://bugs.webkit.org/show_bug.cgi?id=128762

Reviewed by Mark Lam.

* interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
* runtime/JSLock.cpp:
(JSC::JSLock::DropAllLocks::DropAllLocks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoIDB: Three tests crash the DatabaseProcess under ~KeyedDecoder
beidson@apple.com [Thu, 13 Feb 2014 23:04:30 +0000 (23:04 +0000)]
IDB: Three tests crash the DatabaseProcess under ~KeyedDecoder
https://bugs.webkit.org/show_bug.cgi?id=128763

Reviewed by Anders Carlsson.

Source/WebCore:

No new tests (Covered by three existing tests)

* platform/KeyedCoding.h:
(WebCore::KeyedEncoder::encodeObjects): If the array is empty we still have to begin() and end() it.

LayoutTests:

* platform/mac-wk2/TestExpectations: One test passes, one passes with expectation changes,
  and the third is now a text failure.

* storage/indexeddb/key-type-array-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[css3-text] Support -webkit-text-decoration-skip: objects
commit-queue@webkit.org [Thu, 13 Feb 2014 23:02:31 +0000 (23:02 +0000)]
[css3-text] Support -webkit-text-decoration-skip: objects
https://bugs.webkit.org/show_bug.cgi?id=128723

Patch by Yuki Sekiguchi <yuki.sekiguchi@access-company.com> on 2014-02-13
Reviewed by Dean Jackson.

Source/WebCore:

Implemented 'objects' value of text-decoration-skip.
http://www.w3.org/TR/2013/CR-css-text-decor-3-20130801/#text-decoration-skip

This is initial value and same behavior without
ENABLE_CSS3_TEXT_DECORATION_SKIP_INK flag. Threfore, this patch only
added parser code and constant for 'objects'.

Changed the initial value of text-decoration-skip.

The current implementation parses 'none', but the rendering code is
not match the spec, so this patch added FIXME to the rendering code.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::renderTextDecorationSkipFlagsToCSSValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseTextDecorationSkip):
* css/CSSValueKeywords.in:
* css/DeprecatedStyleBuilder.cpp:
(WebCore::valueToDecorationSkip):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintDecoration):
* rendering/style/RenderStyle.h:
* rendering/style/RenderStyleConstants.h:

LayoutTests:

Added 'objects' value to the current test case.
Added getComputedStyle() test to test renderTextDecorationSkipFlagsToCSSValue() code.

* fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip-expected.txt:
* fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix ARM NEON build following <http://trac.webkit.org/changeset/164058>
dbates@webkit.org [Thu, 13 Feb 2014 22:59:40 +0000 (22:59 +0000)]
Fix ARM NEON build following <trac.webkit.org/changeset/164058>
(https://bugs.webkit.org/show_bug.cgi?id=128767)

I inadvertently didn't include header NEONHelpers.h, which defines WebCore::loadRGBA8AsFloat().

* platform/graphics/cpu/arm/filters/FECompositeArithmeticNEON.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoHoist and combine array bounds checks
fpizlo@apple.com [Thu, 13 Feb 2014 22:46:51 +0000 (22:46 +0000)]
Hoist and combine array bounds checks
https://bugs.webkit.org/show_bug.cgi?id=125433

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

This adds a phase for reasoning about overflow checks and array bounds checks. It's
block-local, and removes both overflow checks and bounds checks in one go.

This also improves reasoning about commutative operations, and CSE between
CheckOverflow and Unchecked arithmetic.

This strangely uncovered a DFG backend bug where we were trying to extract an int32
from a constant even when that constant was just simply a number. I fixed that bug.

* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
* dfg/DFGAbstractValue.cpp:
(JSC::DFG::AbstractValue::set):
* dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::run):
* dfg/DFGArithMode.h:
(JSC::DFG::subsumes):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleIntrinsic):
* dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::pureCSE):
(JSC::DFG::CSEPhase::int32ToDoubleCSE):
(JSC::DFG::CSEPhase::performNodeCSE):
* dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
* dfg/DFGEdge.cpp:
(JSC::DFG::Edge::dump):
* dfg/DFGEdge.h:
(JSC::DFG::Edge::sanitized):
(JSC::DFG::Edge::hash):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::valueOfInt32Constant):
* dfg/DFGInsertionSet.h:
(JSC::DFG::InsertionSet::insertConstant):
* dfg/DFGIntegerCheckCombiningPhase.cpp: Added.
(JSC::DFG::IntegerCheckCombiningPhase::IntegerCheckCombiningPhase):
(JSC::DFG::IntegerCheckCombiningPhase::run):
(JSC::DFG::IntegerCheckCombiningPhase::handleBlock):
(JSC::DFG::IntegerCheckCombiningPhase::rangeKeyAndAddend):
(JSC::DFG::IntegerCheckCombiningPhase::isValid):
(JSC::DFG::IntegerCheckCombiningPhase::insertAdd):
(JSC::DFG::IntegerCheckCombiningPhase::insertMustAdd):
(JSC::DFG::performIntegerCheckCombining):
* dfg/DFGIntegerCheckCombiningPhase.h: Added.
* dfg/DFGNode.h:
(JSC::DFG::Node::willHaveCodeGenOrOSR):
* dfg/DFGNodeType.h:
* dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThreadImpl):
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
* dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileAdd):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGStrengthReductionPhase.cpp:
(JSC::DFG::StrengthReductionPhase::handleNode):
(JSC::DFG::StrengthReductionPhase::handleCommutativity):
* dfg/DFGTypeCheckHoistingPhase.cpp:
(JSC::DFG::TypeCheckHoistingPhase::identifyRedundantStructureChecks):
(JSC::DFG::TypeCheckHoistingPhase::identifyRedundantArrayChecks):
* ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
* jsc.cpp:
(GlobalObject::finishCreation):
(functionFalse):
* runtime/Identifier.h:
* runtime/Intrinsic.h:
* runtime/JSObject.h:
* tests/stress/get-by-id-untyped.js: Added.
(foo):
* tests/stress/inverted-additive-subsumption.js: Added.
(foo):
* tests/stress/redundant-add-overflow-checks.js: Added.
(foo):
* tests/stress/redundant-array-bounds-checks-addition-skip-first.js: Added.
(foo):
(arraycmp):
* tests/stress/redundant-array-bounds-checks-addition.js: Added.
(foo):
(arraycmp):
* tests/stress/redundant-array-bounds-checks-unchecked-addition.js: Added.
(foo):
(arraycmp):
* tests/stress/redundant-array-bounds-checks.js: Added.
(foo):
(arraycmp):
* tests/stress/tricky-array-bounds-checks.js: Added.
(foo):
(arraycmp):

Source/WTF:

Reviewed by Mark Hahnenberg.

* GNUmakefile.list.am:
* WTF.vcxproj/WTF.vcxproj:
* WTF.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
* wtf/HashMethod.h: Added.
(WTF::HashMethod::operator()):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWrite FEComposite::computeArithmeticPixelsNeon() in terms of loadRGBA8AsFloat()
dbates@webkit.org [Thu, 13 Feb 2014 22:45:42 +0000 (22:45 +0000)]
Write FEComposite::computeArithmeticPixelsNeon() in terms of loadRGBA8AsFloat()
https://bugs.webkit.org/show_bug.cgi?id=128767

Reviewed by Dean Jackson.

This patch was inspired by Gabor Rapcsanyi's work in <https://bugs.webkit.org/show_bug.cgi?id=90669>.

Currently we duplicate code in FEComposite::computeArithmeticPixelsNeon() to read pixel data.
Instead we should use the convenience function WebCore::loadRGBA8AsFloat. This also resolves
an uninitialized variable compiler warning in the existing code.

* platform/graphics/cpu/arm/filters/FECompositeArithmeticNEON.h:
(WebCore::FEComposite::computeArithmeticPixelsNeon):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFTL should be OK with __compact_unwind in a data section
fpizlo@apple.com [Thu, 13 Feb 2014 22:34:18 +0000 (22:34 +0000)]
FTL should be OK with __compact_unwind in a data section
https://bugs.webkit.org/show_bug.cgi?id=128756

Reviewed by Mark Hahnenberg.

* ftl/FTLCompile.cpp:
(JSC::FTL::mmAllocateCodeSection):
(JSC::FTL::mmAllocateDataSection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. changing my email address.
graouts@webkit.org [Thu, 13 Feb 2014 22:18:03 +0000 (22:18 +0000)]
Unreviewed. changing my email address.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAttempt to fix LevelDB builds.
timothy@apple.com [Thu, 13 Feb 2014 22:13:42 +0000 (22:13 +0000)]
Attempt to fix LevelDB builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMake WKWebViewConfigurationPrivate.h private
andersca@apple.com [Thu, 13 Feb 2014 22:13:42 +0000 (22:13 +0000)]
Make WKWebViewConfigurationPrivate.h private
https://bugs.webkit.org/show_bug.cgi?id=128761

Reviewed by Tim Horton.

* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDuring a copy, position:fixed gets converted to position:absolute even if only part...
mmaxfield@apple.com [Thu, 13 Feb 2014 21:55:29 +0000 (21:55 +0000)]
During a copy, position:fixed gets converted to position:absolute even if only part of the document is selected
https://bugs.webkit.org/show_bug.cgi?id=128688

Reviewed by Ryosuke Niwa.

Source/WebCore:

Adds a field, m_needsPositionStyleConversion, to StyledMarkupAccumulator.

Also, renames the ConvertPositionStyleOnCopy setting to ShouldConvertPositionStyleOnCopy

Test: editing/pasteboard/copy-paste-doesnt-convert-sticky-and-fixed-during-partial-copy.html

* editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::StyledMarkupAccumulator):
(WebCore::StyledMarkupAccumulator::appendElement):
(WebCore::createMarkupInternal):
* page/Settings.in:
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setShouldConvertPositionStyleOnCopy):
* testing/InternalSettings.h:
* testing/InternalSettings.idl:

Source/WebKit/mac:

Renames the ConvertPositionStyleOnCopy setting to ShouldConvertPositionStyleOnCopy

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(-[WebPreferences shouldConvertPositionStyleOnCopy]):
(-[WebPreferences setShouldConvertPositionStyleOnCopy:]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):

Source/WebKit2:

Renames the ConvertPositionStyleOnCopy setting to ShouldConvertPositionStyleOnCopy

* Shared/WebPreferencesStore.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetShouldConvertPositionStyleOnCopy):
(WKPreferencesGetShouldConvertPositionStyleOnCopy):
* UIProcess/API/C/WKPreferencesPrivate.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):

LayoutTests:

Performs a copy of the contents of a particular div, rather than the entire body. Makes sure that
no position:fixed -> position:absolute conversion occurs.

* editing/pasteboard/copy-paste-converts-sticky-and-fixed-expected.txt:
* editing/pasteboard/copy-paste-converts-sticky-and-fixed.html:
* editing/pasteboard/copy-paste-doesnt-convert-sticky-and-fixed-during-partial-copy-expected.txt: Added.
* editing/pasteboard/copy-paste-doesnt-convert-sticky-and-fixed-during-partial-copy.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: DataGrid should support editing tables with arbitrary columns
bburg@apple.com [Thu, 13 Feb 2014 21:38:05 +0000 (21:38 +0000)]
Web Inspector: DataGrid should support editing tables with arbitrary columns
https://bugs.webkit.org/show_bug.cgi?id=128619

Reviewed by Timothy Hatcher.

The data grid editing code should work with any columns, but was previously
hardcoded with the column identifiers used by DOMStorageView. This patch
makes the editing code work with any column identifiers. It also fixes some
bugs in previous/next navigation during data entry.

* UserInterface/DOMStorageContentView.css: Highlight missing keys and values.
(.content-view.dom-storage > .data-grid tr.missing-value td.value-column):
(.content-view.dom-storage > .data-grid:focus tr.selected.missing-value td.value-column):

* UserInterface/DOMStorageContentView.js: Don't blow away the entire table
whenever the backend notifies us of an update to the storage object. This
caused the editing state to be destroyed when values were entered interactively.

(WebInspector.DOMStorageContentView.prototype.reset): Inline the callback
passed to DOMStorageObject.getEntries().
(WebInspector.DOMStorageContentView.prototype.itemsCleared):
(WebInspector.DOMStorageContentView.prototype.itemAdded): Request a sort
of the table rows after backend tells us about item additions or updates.

(WebInspector.DOMStorageContentView.prototype.itemUpdated): Request a sort
of the table rows after backend tells us about item additions or updates.

(WebInspector.DOMStorageContentView.prototype._sortDataGrid): Use DataGrid's
built-in sorting function.

(WebInspector.DOMStorageContentView.prototype._deleteCallback):
(WebInspector.DOMStorageContentView.prototype._editingCallback): Don't force
recreation of the entire table whenever editing finishes. Perform most
of the error checking and editing logic here, including when to insert a
new placeholder row, and when to commit the entered values to DOM storage.

* UserInterface/DOMStorageObject.js: Keep track of the DOM storage entries
in the model so we can detect duplicate entries. Remove unused `id` arguments.

(WebInspector.DOMStorageObject):
(WebInspector.DOMStorageObject.prototype.get entries):
(WebInspector.DOMStorageObject.prototype.itemsCleared):
(WebInspector.DOMStorageObject.prototype.itemRemoved):
(WebInspector.DOMStorageObject.prototype.set this):
(WebInspector.DOMStorageObject.prototype.itemAdded):
(WebInspector.DOMStorageObject.prototype.set var):
(WebInspector.DOMStorageObject.prototype.itemUpdated):

* UserInterface/DataGrid.js:
(.sortDataGrid):
(WebInspector.DataGrid.createSortableDataGrid): Use the built-in DataGrid
sortNodes() implementation.
(WebInspector.DataGrid.prototype._startEditingNodeAtColumnIndex): Renamed
from _startEditingColumnOfDataGridNode. It's easier to understand the navigation
code when presented in terms of adjusting column indexes rather than identifiers.

(WebInspector.DataGrid.prototype._startEditing):
(WebInspector.DataGrid.prototype.determineNextCell): Added. Decides which
column and row to edit next and whether the table can be sorted before the
next cell edit begins.

(WebInspector.DataGrid.prototype.moveToNextCell): Added. Wrapper method for
the above which handles sorting and beginning the next cell edit.

(WebInspector.DataGrid.prototype._editingCommitted): Use better helper methods.
(WebInspector.DataGrid.prototype._editingCancelled): Add an assert.
(WebInspector.DataGrid.prototype.get sortColumnIdentifier): Shorten.
(WebInspector.DataGrid.prototype.addPlaceholderNode):
(WebInspector.DataGrid.prototype.removeChild):
(WebInspector.DataGrid.prototype.):
(WebInspector.DataGrid.prototype.sortNodes): Remove unecessary copying
of all nodes into a separate array. Defer sorting if the user is in the
middle of editing a cell. Make placeholder nodes always sort to the bottom
regardless of the sort column identifier and sort direction.

(WebInspector.DataGridNode.prototype._attach):
(WebInspector.PlaceholderDataGridNode): Renamed from CreationDataGridNode.
(WebInspector.PlaceholderDataGridNode.prototype.makeNormal):

* UserInterface/StorageManager.js: Don't pass unused id argument.
(WebInspector.StorageManager.prototype.itemRemoved):
(WebInspector.StorageManager.prototype.itemAdded):
(WebInspector.StorageManager.prototype.itemUpdated):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoEnable inspection of recently used IndexedDB databases.
timothy@apple.com [Thu, 13 Feb 2014 21:37:59 +0000 (21:37 +0000)]
Enable inspection of recently used IndexedDB databases.

https://bugs.webkit.org/show_bug.cgi?id=128687

Reviewed by Brady Eidson & Joseph Pecoraro.

Source/WebCore:

* Modules/indexeddb/IDBFactory.cpp:
(WebCore::IDBFactory::getDatabaseNames):
* Modules/indexeddb/IDBFactoryBackendInterface.h:
* Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:
(WebCore::IDBFactoryBackendLevelDB::getDatabaseNames):
* Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h:
Fix up the arguments passed to getDatabaseNames.

* WebCore.xcodeproj/project.pbxproj:
Make DOMStringList.h private so WebKit2 can use it.

* inspector/InspectorIndexedDBAgent.cpp:
Modernize the loops and remove some PLATFORM(COCOA) ifdefs to
compile the code.

* inspector/protocol/IndexedDB.json: Use number for version to
allow larger values instead of clamping to int.

Source/WebKit2:

* WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:
(WebKit::sharedRecentDatabaseNameMap):
(WebKit::combinedSecurityOriginIdentifier):
(WebKit::WebIDBFactoryBackend::WebIDBFactoryBackend):
(WebKit::WebIDBFactoryBackend::getDatabaseNames):
(WebKit::WebIDBFactoryBackend::open):
(WebKit::WebIDBFactoryBackend::deleteDatabase):
Keep track of recently used database names per security-origin pair.
Implement getDatabaseNames to return the recently used names.

* WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h:
Fix up the arguments passed to getDatabaseNames.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix build.
andersca@apple.com [Thu, 13 Feb 2014 21:26:01 +0000 (21:26 +0000)]
Fix build.

* UIProcess/API/Cocoa/WKWebView.mm:
(layoutMilestones):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd rendering progress events SPI
andersca@apple.com [Thu, 13 Feb 2014 21:14:05 +0000 (21:14 +0000)]
Add rendering progress events SPI
https://bugs.webkit.org/show_bug.cgi?id=128752

Reviewed by Dan Bernstein.

* UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h.
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _observedRenderingProgressEvents]):
(layoutMilestones):
(-[WKWebView _setObservedRenderingProgressEvents:]):
* UIProcess/API/Cocoa/WKWebViewPrivate.h:
(NS_OPTIONS):
* UIProcess/Cocoa/NavigationState.h:
* UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::setNavigationDelegate):
(WebKit::renderingProgressEvents):
(WebKit::NavigationState::LoaderClient::didLayout):
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: long script names should be have text-overflow:ellipsis in probe detai...
bburg@apple.com [Thu, 13 Feb 2014 20:46:48 +0000 (20:46 +0000)]
Web Inspector: long script names should be have text-overflow:ellipsis in probe details sidebar
https://bugs.webkit.org/show_bug.cgi?id=128550

Reviewed by Timothy Hatcher.

Make the link element 'display: block', place it after the floated icons,
and set the appropriate CSS overflow properties.

* UserInterface/ProbeDetailsSidebarPanel.css:
(.details-section.probe-set .options > a.go-to-link):
* UserInterface/ProbeSetDetailsSection.js:
(WebInspector.ProbeSetDetailsSection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCopying (createMarkup) wrapping text results in space between wrapped lines stripped.
commit-queue@webkit.org [Thu, 13 Feb 2014 20:45:35 +0000 (20:45 +0000)]
Copying (createMarkup) wrapping text results in space between wrapped lines stripped.
https://bugs.webkit.org/show_bug.cgi?id=63233

Source/WebCore:

The problem is StyledMarkupAccumulator uses renderedText and the space at
the end of the text has been stripped when the tag after the text was wrapped.

Patch by Chang Shu <cshu@webkit.org> on 2014-02-13
Reviewed by Ryosuke Niwa.

Test: editing/pasteboard/copy-text-with-wrapped-tag.html

* editing/TextIterator.cpp:
(WebCore::TextIterator::TextIterator):
(WebCore::TextIterator::handleTextBox):
* editing/TextIterator.h:
Check the special case when the iterator runs over a range that is followed by a non-text box.
In this case, the possible last space has been collapsed and needs to be restored.
* editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::renderedText):
Check if the range is followed by more nodes and pass this information to the constructed TextIterator.

LayoutTests:

Patch by Chang Shu <cshu@webkit.org> on 2014-02-13
Reviewed by Ryosuke Niwa.

The problem is StyledMarkupAccumulator uses renderedText and the space at
the end of the text has been stripped when the tag after the text was wrapped.

* editing/pasteboard/copy-text-with-wrapped-tag-expected.txt: Added.
* editing/pasteboard/copy-text-with-wrapped-tag.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoGaps for text-decoration-skip: ink are calculated assuming the glyph orientation...
mmaxfield@apple.com [Thu, 13 Feb 2014 20:31:36 +0000 (20:31 +0000)]
Gaps for text-decoration-skip: ink are calculated assuming the glyph orientation is the same as the run orientation
https://bugs.webkit.org/show_bug.cgi?id=128718

Reviewed by Darin Adler.

Source/WebCore:

This is a stop-gap patch to make underlines in CJK text not look terrible. A long-term fix is to refactor
showGlyphsWithAdvances to move rotation logic into a common place that the text-decoration-skip: ink code
can use.

Test: fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-orientation-upright.html

* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintDecoration):

LayoutTests:

This test draws text that has descenders that would be skipped over if the glyph orientation was the same
as the run orientation. However, it uses text-orientation: upright to make those two orientations not equal.
It then compares this to no skipping at all.

* fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-orientation-upright-expected.html: Added.
* fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-orientation-upright.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Mac] Add a WebKit1 SPI to get WebCrypto master key from a client
ap@apple.com [Thu, 13 Feb 2014 19:32:32 +0000 (19:32 +0000)]
[Mac] Add a WebKit1 SPI to get WebCrypto master key from a client
https://bugs.webkit.org/show_bug.cgi?id=128725

Reviewed by Anders Carlsson.

Source/WebKit/mac:

* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::wrapCryptoKey):
(WebChromeClient::unwrapCryptoKey):
* WebView/WebUIDelegatePrivate.h:
Looks like UIDelegate is the closest we have to a reasonable place.

Tools:

* DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webCryptoMasterKeyForWebView:]):
Use the SPI to specify a key.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoIDB: TestExpectations cleanup
beidson@apple.com [Thu, 13 Feb 2014 18:56:16 +0000 (18:56 +0000)]
IDB: TestExpectations cleanup

Unreviewed.

* platform/mac-wk2/TestExpectations: More tests pass than fail, so only list failures.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoIDB: TestExpectations batch - HTTP tests
beidson@apple.com [Thu, 13 Feb 2014 18:52:26 +0000 (18:52 +0000)]
IDB: TestExpectations batch - HTTP tests

Unreviewed.

* http/tests/security/cross-origin-indexeddb-allowed-expected.txt:
* http/tests/security/cross-origin-indexeddb-expected.txt:
* http/tests/security/resources/cross-origin-iframe-for-indexeddb.html:

* platform/mac-wk2/TestExpectations: Two of the http tests are worker tests. They remain skipped.
  The other three pass with test updates.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCStack Branch: VM::currentReturnThunkPC appears to be unused and should be removed
msaboff@apple.com [Thu, 13 Feb 2014 18:45:09 +0000 (18:45 +0000)]
CStack Branch: VM::currentReturnThunkPC appears to be unused and should be removed
https://bugs.webkit.org/show_bug.cgi?id=127205

Reviewed by Geoffrey Garen.

Removed ununsed references to VM::currentReturnThunkPC.

* jit/ThunkGenerators.cpp:
(JSC::arityFixup):
* runtime/VM.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoInsertIntoTextNodeCommand should get Settings from the Frame.
akling@apple.com [Thu, 13 Feb 2014 18:39:13 +0000 (18:39 +0000)]
InsertIntoTextNodeCommand should get Settings from the Frame.
<https://webkit.org/b/128678>

EditCommands have a frame() accessor that returns a reference,
so there's no need to go through Document.

Reviewed by Anders Carlsson.

* editing/InsertIntoTextNodeCommand.cpp:
(WebCore::InsertIntoTextNodeCommand::doApply):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoiOS build fix.
mitz@apple.com [Thu, 13 Feb 2014 18:36:11 +0000 (18:36 +0000)]
iOS build fix.

* WebView/WebView.mm:
(+[WebView registerForMemoryNotifications]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDocument should be constructable
commit-queue@webkit.org [Thu, 13 Feb 2014 18:31:45 +0000 (18:31 +0000)]
Document should be constructable
https://bugs.webkit.org/show_bug.cgi?id=115643

Patch by László Langó <llango.u-szeged@partner.samsung.com> on 2014-02-13
Reviewed by Darin Adler.

Source/WebCore:

http://www.w3.org/TR/2014/WD-dom-20140204/#interface-document
Make Document constructable so that one can do "new Document"
instead of "document.implementation.createHTMLDocument('')".

Test: fast/dom/Document/document-constructor.html

* dom/Document.cpp:
(WebCore::Document::create):
(WebCore::Document::origin):
* dom/Document.h:
* dom/Document.idl:

LayoutTests:

* fast/dom/Document/document-constructor-expected.txt: Added.
* fast/dom/Document/document-constructor.html: Added.
* fast/dom/dom-constructors-expected.txt:
* fast/dom/dom-constructors.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Grid Layout] Rename named areas property
commit-queue@webkit.org [Thu, 13 Feb 2014 18:07:05 +0000 (18:07 +0000)]
[CSS Grid Layout] Rename named areas property
https://bugs.webkit.org/show_bug.cgi?id=127990

Patch by Javier Fernandez <jfernandez@igalia.com> on 2014-02-13
Reviewed by Sergio Villar Senin.

From Blink r165891 by <rego@igalia.com>

The property 'grid-template' has been renamed to 'grid-template-areas'
in the last two versions of the spec.

Source/WebCore:

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
* css/CSSGridTemplateAreasValue.cpp: Renamed from Source/WebCore/css/CSSGridTemplateValue.cpp.
(WebCore::CSSGridTemplateAreasValue::CSSGridTemplateAreasValue):
(WebCore::stringForPosition):
(WebCore::CSSGridTemplateAreasValue::customCSSText):
* css/CSSGridTemplateAreasValue.h: Renamed from Source/WebCore/css/CSSGridTemplateValue.h.
(WebCore::CSSGridTemplateAreasValue::create):
(WebCore::CSSGridTemplateAreasValue::~CSSGridTemplateAreasValue):
(WebCore::CSSGridTemplateAreasValue::gridAreaMap):
(WebCore::CSSGridTemplateAreasValue::rowCount):
(WebCore::CSSGridTemplateAreasValue::columnCount):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseGridTemplateAreas):
* css/CSSParser.h:
* css/CSSPropertyNames.in:
* css/CSSValue.cpp:
(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
* css/CSSValue.h:
(WebCore::CSSValue::isGridTemplateAreasValue):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):

Source/WebInspectorUI:

* Tools/PrettyPrinting/css.js:
* UserInterface/External/CodeMirror/css.js:

LayoutTests:

* fast/css-grid-layout/grid-item-area-get-set.html:
* fast/css-grid-layout/grid-item-column-row-get-set.html:
* fast/css-grid-layout/grid-item-end-after-get-set.html:
* fast/css-grid-layout/grid-item-named-grid-area-resolution.html:
* fast/css-grid-layout/grid-item-start-before-get-set.html:
* fast/css-grid-layout/grid-template-get-set-expected.txt:
* fast/css-grid-layout/grid-template-get-set.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove the last remnants of Maemo support
commit-queue@webkit.org [Thu, 13 Feb 2014 18:06:12 +0000 (18:06 +0000)]
Remove the last remnants of Maemo support
https://bugs.webkit.org/show_bug.cgi?id=85238

Patch by Adrian Bunk <bunk@stusta.de> on 2014-02-13
Reviewed by Ryosuke Niwa.

* plugins/npapi.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoIDB: TestExpectations batch - "transaction-abort.html to versionchangerequest-actived...
beidson@apple.com [Thu, 13 Feb 2014 18:05:11 +0000 (18:05 +0000)]
IDB: TestExpectations batch - "transaction-abort.html to versionchangerequest-activedomobject.html”

Unreviewed.

* platform/mac-wk2/TestExpectations:
* storage/indexeddb/transaction-active-flag-expected.txt:
* storage/indexeddb/transaction-after-close-expected.txt:
* storage/indexeddb/transaction-read-only-expected.txt:
* storage/indexeddb/transaction-storeNames-required-expected.txt:
* storage/indexeddb/version-change-abort-expected.txt:
* storage/indexeddb/version-change-exclusive-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCode cleanup: remove gcc<4.7 guards.
commit-queue@webkit.org [Thu, 13 Feb 2014 18:00:47 +0000 (18:00 +0000)]
Code cleanup: remove gcc<4.7 guards.
https://bugs.webkit.org/show_bug.cgi?id=128729

Patch by Tamas Gergely <tgergely.u-szeged@partner.samsung.com> on 2014-02-13
Reviewed by Anders Carlsson.

Remove GCC_VERSION_AT_LEAST guards when it checks for pre-4.7 versions,
as WK does not compile with earlier gcc versions.

Source/JavaScriptCore:

* assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::cacheFlush):
* interpreter/StackVisitor.cpp:
(JSC::printif):

Source/WTF:

* wtf/Assertions.cpp:
* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDisable XPC for plug-ins that need executable heap
andersca@apple.com [Thu, 13 Feb 2014 17:30:18 +0000 (17:30 +0000)]
Disable XPC for plug-ins that need executable heap
https://bugs.webkit.org/show_bug.cgi?id=128744
<rdar://problem/15962958>

Reviewed by Dan Bernstein.

When switching to XPC for plug-ins, we accidentally broke the "feature"
where plug-ins can ask for the heap to be executable.

This breaks Silverlight, so just disable XPC for any plug-ins that need this.
<rdar://problem/16059483> tracks fixing this in the XPC service.

* UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::pluginNeedsExecutableHeap):
Only return true for 32-bit plug-ins, since we don't know any 64-bit plug-ins
that require this feature.

(WebKit::PluginProcessProxy::platformGetLaunchOptions):
Set launchOptions.useXPC to false if launchOptions.executableHeap is true.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION: fast/workers/use-machine-stack.html hits Heap::isMarked(cell) assertion
ap@apple.com [Thu, 13 Feb 2014 17:24:32 +0000 (17:24 +0000)]
REGRESSION: fast/workers/use-machine-stack.html hits Heap::isMarked(cell) assertion
https://bugs.webkit.org/show_bug.cgi?id=128745

* TestExpectations: Marked as flakily asserting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Add or remove expectations for some media layout tests
commit-queue@webkit.org [Thu, 13 Feb 2014 16:22:42 +0000 (16:22 +0000)]
[EFL] Add or remove expectations for some media layout tests
https://bugs.webkit.org/show_bug.cgi?id=128535

Unreviewed EFL layout tests gardening

Patch by Andrzej Badowski <a.badowski@samsung.com> on 2014-02-13

* platform/efl/TestExpectations:
* platform/efl-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WK1] Do not include libsoup header in the public headers
ryuan.choi@samsung.com [Thu, 13 Feb 2014 13:25:27 +0000 (13:25 +0000)]
[EFL][WK1] Do not include libsoup header in the public headers
https://bugs.webkit.org/show_bug.cgi?id=128701

Reviewed by Gyuyoung Kim.

Although ewebkit used libsoup internally, it's not good for EFL developers
to use it.
Instead, we should provide some wrapper APIs like ewk_network_proxy_uri_set
for future changes.

* ewk/ewk_network.cpp: Removed soup related header,APIs and comments.
(ewk_network_tls_ca_certificates_path_set):
* ewk/ewk_network.h: Ditto.
* ewk/ewk_view.cpp: Ditto.
* ewk/ewk_view.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed GTK gardening.
changseok.oh@collabora.com [Thu, 13 Feb 2014 13:20:20 +0000 (13:20 +0000)]
Unreviewed GTK gardening.

Removed unexpected pass tests from TextExpections

* platform/gtk-wk2/TestExpectations:
* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSupport ANGLE_instanced_arrays for GLES backend.
changseok.oh@collabora.com [Thu, 13 Feb 2014 12:58:54 +0000 (12:58 +0000)]
Support ANGLE_instanced_arrays for GLES backend.
https://bugs.webkit.org/show_bug.cgi?id=128579

Reviewed by Dean Jackson.

Add some APIs to Extensions3D to support ANGLE_instanced_arrays for GLES backend.
At the same time, drawArraysInstanced, drawElementsInstanced and vertexAttribDivisor
are moved from GC3DOpenGL.cpp to GC3DOpenGLCommon.cpp since they could be shareable
through Extensions3D.

Covered by fast/canvas/webgl/angle-instanced-arrays.html

* platform/graphics/Extensions3D.h:
* platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::drawArraysInstanced):
(WebCore::Extensions3DOpenGL::drawElementsInstanced):
(WebCore::Extensions3DOpenGL::vertexAttribDivisor):
* platform/graphics/opengl/Extensions3DOpenGL.h:
* platform/graphics/opengl/Extensions3DOpenGLES.cpp:
(WebCore::Extensions3DOpenGLES::Extensions3DOpenGLES):
(WebCore::Extensions3DOpenGLES::drawArraysInstanced):
(WebCore::Extensions3DOpenGLES::drawElementsInstanced):
(WebCore::Extensions3DOpenGLES::vertexAttribDivisor):
(WebCore::Extensions3DOpenGLES::supportsExtension):
* platform/graphics/opengl/Extensions3DOpenGLES.h:
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::drawArraysInstanced):
(WebCore::GraphicsContext3D::drawElementsInstanced):
(WebCore::GraphicsContext3D::vertexAttribDivisor):
* platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed EFL gardening
m.pakula@samsung.com [Thu, 13 Feb 2014 12:35:44 +0000 (12:35 +0000)]
Unreviewed EFL gardening

Add test expectations for failing tests.

* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:
* platform/efl/mathml/presentation/mspace-children-expected.txt: Added EFL expectation after r163626.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] MEDIA_CONTROLS_SCRIPT support
calvaris@igalia.com [Thu, 13 Feb 2014 11:28:34 +0000 (11:28 +0000)]
[GTK] MEDIA_CONTROLS_SCRIPT support
https://bugs.webkit.org/show_bug.cgi?id=123097

Reviewed by Jer Noble.

.:

Part of the Autotools and CMake structure to build the media
controls script.

* Source/autotools/SetupWebKitFeatures.m4: Activated the media
controls script by default.
* Source/cmake/OptionsGTK.cmake: Activated the media controls
script by default.
* Source/cmake/WebKitFeatures.cmake: Created the option to
activate the controls script.
* Source/cmakeconfig.h.cmake: Created the define template the the
media controls script.

Source/WebCore:

WebKitGTK+ multimedia controls are now managed from Javascript
code. Apple controls are kept as common code and GTK+ ones are
subclassed for the specific behavior.

Both CMake and Autotools build support is provided.

* CMakeLists.txt: Added support to build the media controls
script and their associated files.
* GNUmakefile.am: Added support to generate the C++ code from the
Javascript.
* GNUmakefile.list.am: Added the media controls script associated
files.
* Modules/mediacontrols/MediaControlsHost.cpp:
* Modules/mediacontrols/MediaControlsHost.h:
* Modules/mediacontrols/MediaControlsHost.idl:
(WebCore::MediaControlsHost::supportsFullscreen): Added attribute
to know if the element supports fullscreen.
* Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.handleWrapperMouseMove):
(Controller.prototype.handleWrapperMouseOut):
(Controller.prototype.updatePlaying): Use clear and
resetHideControlsTimer.
(Controller.prototype.clearHideControlsTimer): Added.
(Controller.prototype.resetHideControlsTimer): Added.
* Modules/mediacontrols/mediaControlsGtk.js: Added.
(createControls): Calls ControllerGtk.
(ControllerGtk): Calls the superclass.
(contains): Defines a function to know if an object is contained
in an array.
(ControllerGtk.prototype.inheritFrom): Copies the method of the
superclass that are not reimplemented in the subclass.
(ControllerGtk.prototype.createControls): Calls the superclass and
create the remaining needed elements.
(ControllerGtk.prototype.configureInlineControls): Configures the
controls.
(ControllerGtk.prototype.setStatusHidden): Redefined empty.
(ControllerGtk.prototype.updateTime): Writes the duration and
current position. As it was so far, current time also includes
duration. If current time is bigger than 0 we show that.
(ControllerGtk.prototype.showCurrentTime): Shows current time and
hides duration label (that is included in current time).
(ControllerGtk.prototype.handlePlay): Calls the superclass and
force showing the current time.
(ControllerGtk.prototype.handleTimeUpdate): Always update the
time.
(ControllerGtk.prototype.handleMuteButtonMouseOver): Shows the
volume slider.
(ControllerGtk.prototype.handleVolumeBoxMouseOut): Hides the
volume slider.
(ControllerGtk.prototype.addControls): Adds the enclosure instead
of the panel directly. Panel is, of course, part of the enclosure.
(ControllerGtk.prototype.updateReadyState): Shows the fullscreen
button only if fullscreen is supported. Sets the volume in up or
down mode depending on its position in the document. Updates the
volume.
(ControllerGtk.prototype.setControlsType): Creates the controls it
they were not created before. Unlike Apple ones, WebKitGTK+
fullscreen and inline controls are the same.
(ControllerGtk.prototype.updatePlaying): Calls the superclass and
shows the controls if not playing.
(ControllerGtk.prototype.handleCaptionButtonClicked): Redefined
empty. To be coherent with volume, that also shows a popup, this
is handled with mouseover instead of click.
(ControllerGtk.prototype.buildCaptionMenu): Calls the superclass
to build the menu, sets some listeners, centers the popup with the
captions button, keeps the current height and sets the style to 0,
which is needed to animate it.
(ControllerGtk.prototype.destroyCaptionMenu): Hides the caption menu.
(ControllerGtk.prototype.showCaptionMenu): Resets the height to
its original. We don't animate it with CSS because we would need
to specify a height in the style and we don't know it in advance.
(ControllerGtk.prototype.hideCaptionMenu): Sets height to 0.
(ControllerGtk.prototype.captionMenuTransitionEnd): When the
captions menu transtition ends, it is destroyed.
(ControllerGtk.prototype.handleCaptionButtonMouseOver): Creates
the caption menu and shows it.
(ControllerGtk.prototype.handleCaptionButtonMouseOut): Hides the
captions menu.
(ControllerGtk.prototype.handleCaptionMouseOut): Hides the
captions menu.
* PlatformGTK.cmake: Added WebCore to the target link libraries
and initialized the variables needed at CMakelists.txt
* css/mediaControlsGtk.css:
(audio::-webkit-media-controls-panel)
(video::-webkit-media-controls-panel): Added transtion based on opacity.
(video::-webkit-media-controls-panel): Set video opacity to 0.
(video::-webkit-media-controls-panel.paused): Set video opacity to 1.
(audio::-webkit-media-controls-panel div.mute-box): Set the same
style as the mute button to preserve the layout.
(audio::-webkit-media-controls-panel div.mute-box.hidden): Sets
the display to none.
(audio::-webkit-media-controls-mute-button)
(video::-webkit-media-controls-mute-button): Removed the outline
and the margin that is managed by the mute box now.
(audio::-webkit-media-controls-play-button)
(video::-webkit-media-controls-play-button): Removed the outline.
(audio::-webkit-media-controls-time-remaining-display)
(video::-webkit-media-controls-time-remaining-display): Removed
the display.
(audio::-webkit-media-controls-current-time-display)
(video::-webkit-media-controls-current-time-display): Added the
display block.
(video::-webkit-media-controls-time-remaining-display): Set
display none.
(video::-webkit-media-controls-time-remaining-display.show): Set
display block.
(video::-webkit-media-controls-time-remaining-display.hidden): Set
display none.
(audio::-webkit-media-controls-timeline)
(video::-webkit-media-controls-timeline): Removed outline.
(audio::-webkit-media-controls-volume-slider-container)
(video::-webkit-media-controls-volume-slider-container): Set
overflow hidden and set a transition by height.
(video::-webkit-media-controls-volume-slider-container.hidden):
Set height 0.
(video::-webkit-media-controls-volume-slider-container.down): Set
bottom to be below the panel. Changed the border radius and
transition accordingly.
(video::-webkit-media-controls-panel .hidden.down): Sets default
bottom as 0.
(audio::-webkit-media-controls-volume-slider)
(video::-webkit-media-controls-volume-slider): Removed the outline.
(audio::-webkit-media-controls-toggle-closed-captions-button)
(video::-webkit-media-controls-toggle-closed-captions-button):
Removed the background that is painted from C++ and removed the
outline.
(video::-webkit-media-controls-closed-captions-container):
(video::-webkit-media-controls-closed-captions-container h3):
(video::-webkit-media-controls-closed-captions-container ul):
(video::-webkit-media-controls-closed-captions-container li):
(video::-webkit-media-controls-closed-captions-container li.selected): Changed
the style to make it more coherent with the rest of the controls.
(audio::-webkit-media-controls-fullscreen-button)
(video::-webkit-media-controls-fullscreen-button): Removed the outline.
(audio::-webkit-media-controls-panel button.hidden): Sets the
display to none.
* html/HTMLMediaElement.cpp: UserAgentScripts.h is not needed here
and build cmake build would need for changes to get this compiled.
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::nodeHasPseudo): Added. Checks if a node has a certain
pseudo.
(WebCore::nodeHasClass): Added. Checks if a node has a certain
class.
(WebCore::supportsFocus): Removed some element types as outline is
now handled in CSS.
(WebCore::RenderThemeGtk::paintMediaPlayButton): Checks if the
play button has the class paused to show the play icon instead of
the pause one.
(WebCore::RenderThemeGtk::paintMediaToggleClosedCaptionsButton):
Added. Paints the captions icon.
(WebCore::RenderThemeGtk::mediaControlsScript): Added. Loads the
bundled scripts.
* platform/gtk/RenderThemeGtk.h: Added the mediaControlsScript
method and declared the redefinition of the method to play the
captions icon.

LayoutTests:

Tests infrastructure for the media controls script.

* media/click-volume-bar-not-pausing.html:
* media/media-volume-slider-rendered-normal.html:
* media/video-controls-captions-trackmenu-hide-on-click-outside.html:
* media/video-volume-slider.html: Fixed.
* platform/gtk-wk2/TestExpectations: Tests flagged.
* platform/gtk/TestExpectations: Changed tests flags.
* platform/gtk/accessibility/media-element-expected.txt:
* platform/gtk/fast/hidpi/video-controls-in-hidpi-expected.txt:
* platform/gtk/fast/layers/video-layer-expected.txt: Rebaseline.
* platform/gtk/fullscreen/video-controls-override-expected.txt: Added.
* platform/gtk/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
* platform/gtk/media/audio-controls-rendering-expected.png:
* platform/gtk/media/audio-controls-rendering-expected.txt:
* platform/gtk/media/audio-repaint-expected.txt:
* platform/gtk/media/controls-after-reload-expected.png:
* platform/gtk/media/controls-after-reload-expected.txt:
* platform/gtk/media/controls-strict-expected.png:
* platform/gtk/media/controls-strict-expected.txt:
* platform/gtk/media/controls-styling-strict-expected.png:
* platform/gtk/media/controls-styling-strict-expected.txt:
* platform/gtk/media/controls-without-preload-expected.png:
* platform/gtk/media/controls-without-preload-expected.txt:
* platform/gtk/media/video-controls-rendering-expected.png:
* platform/gtk/media/video-controls-rendering-expected.txt:
* platform/gtk/media/video-display-toggle-expected.png:
* platform/gtk/media/video-display-toggle-expected.txt:
* platform/gtk/media/video-empty-source-expected.txt:
* platform/gtk/media/video-no-audio-expected.png:
* platform/gtk/media/video-no-audio-expected.txt:
* platform/gtk/media/video-volume-slider-expected.png:
* platform/gtk/media/video-volume-slider-expected.txt:
* platform/gtk/media/video-zoom-controls-expected.png:
* platform/gtk/media/video-zoom-controls-expected.txt:
Rebaseline.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Moved myself to the list of reviewers.
svillar@igalia.com [Thu, 13 Feb 2014 08:42:21 +0000 (08:42 +0000)]
Unreviewed. Moved myself to the list of reviewers.

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoVersioning.
bshafiei@apple.com [Thu, 13 Feb 2014 08:39:06 +0000 (08:39 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSpeculative build fix after r163998.
timothy_horton@apple.com [Thu, 13 Feb 2014 08:36:55 +0000 (08:36 +0000)]
Speculative build fix after r163998.

* DumpRenderTree/ios/PerlSupport/Makefile:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoIDB: TestExpectations batch - "odd-strings.html to structured-clone.html”
beidson@apple.com [Thu, 13 Feb 2014 06:52:27 +0000 (06:52 +0000)]
IDB: TestExpectations batch - "odd-strings.html to structured-clone.html”

Unreviewed.

* platform/mac-wk2/TestExpectations:
* storage/indexeddb/open-cursor-expected.txt:
* storage/indexeddb/removed-expected.txt:
* storage/indexeddb/request-result-cache-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoNo need to save reservedZoneSize when dropping the JSLock.
mark.lam@apple.com [Thu, 13 Feb 2014 06:50:09 +0000 (06:50 +0000)]
No need to save reservedZoneSize when dropping the JSLock.
<https://webkit.org/b/128719>

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

The reservedZoneSize does not change due to the VM being run on a different
thread. Hence, there is no need to save and restore its value. Instead of
calling updateReservedZoneSize() to update the stack limit, we now call
setStackPointerAtVMEntry() to do the job. setStackPointerAtVMEntry()
will update the stackPointerAtVMEntry and delegate to updateStackLimit() to
update the stack limit based on the new stackPointerAtVMEntry.

* runtime/ErrorHandlingScope.cpp:
(JSC::ErrorHandlingScope::ErrorHandlingScope):
(JSC::ErrorHandlingScope::~ErrorHandlingScope):
- Previously, we initialize stackPointerAtVMEntry in VMEntryScope. This
  means that the stackPointerAtVMEntry may not be initialize when we
  instantiate the ErrorHandlingScope. And so, we needed to initialize the
  stackPointerAtVMEntry in the ErrorHandlingScope constructor if it's not
  already initialized.

  Now that we initialize the stackPointerAtVMEntry when we lock the VM JSLock,
  we are guaranteed that it will be initialized by the time we instantiate
  the ErrorHandlingScope. Hence, we can change the ErrorHandlingScope code
  to just assert that the stackPointerAtVMEntry is initialized instead.

* runtime/InitializeThreading.cpp:
(JSC::initializeThreading):
- We no longer need to save the reservedZoneSize. Remove the related code.

* runtime/JSLock.cpp:
(JSC::JSLock::lock):
- When we grab the JSLock mutex for the first time, there is no reason why
  the stackPointerAtVMEntry should be initialized. By definition, grabbing
  the lock for the first time equates to entering the VM for the first time.
  Hence, we can just assert that stackPointerAtVMEntry is uninitialized,
  and initialize it unconditionally.

  The only exception to this is if we're locking to regrab the JSLock in
  grabAllLocks(), but grabAllLocks() will take care of restoring the
  stackPointerAtVMEntry in that case after lock() returns. stackPointerAtVMEntry
  should still be 0 when we've just locked the JSLock. So, the above assertion
  always holds true.

  Note: VM::setStackPointerAtVMEntry() will take care of calling
  VM::updateStackLimit() based on the new stackPointerAtVMEntry.

- There is no need to save the reservedZoneSize. The reservedZoneSize is
  set to Options::reservedZoneSize() when the VM is initialized. Thereafter,
  the ErrorHandlingScope will change it to Options::errorModeReservedZoneSize()
  when we're handling an error, and it will restore it afterwards. There is
  no other reason we should be changing the reservedZoneSize. Hence, we can
  remove the unnecessary code to save it here.

(JSC::JSLock::unlock):
- Similarly, when the lockCount reaches 0 in unlock(), it is synonymous with
  exiting the VM. Hence, we should just clear the stackPointerAtVMEntry and
  update the stackLimit. Exiting the VM should have no effect on the VM
  reservedZoneSize. Hence, we can remove the unnecessary code to "restore" it.

(JSC::JSLock::dropAllLocks):
- When dropping locks, we do not need to save the reservedZoneSize because
  the reservedZoneSize should remain the same regardless of which thread
  we are executing JS on. Hence, we can remove the unnecessary code to save
  the reservedZoneSize here.

(JSC::JSLock::grabAllLocks):
- When re-grabbing locks, restoring the stackPointerAtVMEntry via
  VM::setStackPointerAtVMEntry() will take care of updating the stack limit.
  As explained above, there's no need to save the reservedZoneSize. Hence,
  there's no need to "restore" it here.

* runtime/VM.cpp:
(JSC::VM::VM):
(JSC::VM::setStackPointerAtVMEntry):
- Sets the stackPointerAtVMEntry and delegates to updateStackLimit() to update
  the stack limit based on the new stackPointerAtVMEntry.
(JSC::VM::updateStackLimit):
* runtime/VM.h:
(JSC::VM::stackPointerAtVMEntry):
- Renamed stackPointerAtVMEntry to m_stackPointerAtVMEntry and made it private.
  Added a stackPointerAtVMEntry() function to read the value.

Source/WTF:

* wtf/WTFThreadData.cpp:
(WTF::WTFThreadData::WTFThreadData):
* wtf/WTFThreadData.h:
- removed unnneeded m_savedReservedZoneSize.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAnother Windows test expectations update.
rniwa@webkit.org [Thu, 13 Feb 2014 06:40:35 +0000 (06:40 +0000)]
Another Windows test expectations update.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoIDB: TestExpectations batch - "key-generator.html to objectStore-required-arguments...
beidson@apple.com [Thu, 13 Feb 2014 06:31:26 +0000 (06:31 +0000)]
IDB: TestExpectations batch - "key-generator.html to objectStore-required-arguments.html"

Unreviewed.

* platform/mac-wk2/TestExpectations:
* storage/indexeddb/keypath-arrays-expected.txt:
* storage/indexeddb/keypath-basics-expected.txt:
* storage/indexeddb/keypath-edges-expected.txt:
* storage/indexeddb/keyrange-expected.txt:
* storage/indexeddb/keyrange-required-arguments-expected.txt:
* storage/indexeddb/object-lookups-in-versionchange-expected.txt:
* storage/indexeddb/objectStore-required-arguments-expected.txt:
* storage/indexeddb/objectstore-count-expected.txt:
* storage/indexeddb/objectstore-cursor-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoReturn immediately from DestroyPlugin IPC call
antti@apple.com [Thu, 13 Feb 2014 06:04:36 +0000 (06:04 +0000)]
Return immediately from DestroyPlugin IPC call
https://bugs.webkit.org/show_bug.cgi?id=128712

Reviewed by Anders Carlsson.

In some cases we spend a lot of time waiting for synchronous IPC for plugin termination to complete. Reduce
the delay by returning from IPC immediately when the plugin process receives it. Just using asynchrounous
IPC might introduce undesirable arbitrary delay between the IPC call returning and the destruction actually
starting.

* PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::destroyPlugin):
* PluginProcess/WebProcessConnection.h:
* PluginProcess/WebProcessConnection.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoIDB: TestExpectations batch - "error-causes-abort-by-default.html to invalid-keys...
beidson@apple.com [Thu, 13 Feb 2014 05:52:35 +0000 (05:52 +0000)]
IDB: TestExpectations batch - "error-causes-abort-by-default.html to invalid-keys.html"

Unreviewed.

* platform/mac-wk2/TestExpectations:
* storage/indexeddb/exception-in-event-aborts-expected.txt:
* storage/indexeddb/index-count-expected.txt:
* storage/indexeddb/index-get-key-argument-required-expected.txt:
* storage/indexeddb/intversion-bad-parameters-expected.txt:
* storage/indexeddb/intversion-close-in-oncomplete-expected.txt:
* storage/indexeddb/intversion-close-in-upgradeneeded-expected.txt:
* storage/indexeddb/invalid-keys-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate test expectations for Windows.
rniwa@webkit.org [Thu, 13 Feb 2014 05:39:07 +0000 (05:39 +0000)]
Update test expectations for Windows.

* TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoIDB: TestExpectations batch - "data-corruption.html to duplicates.html"
beidson@apple.com [Thu, 13 Feb 2014 05:29:44 +0000 (05:29 +0000)]
IDB: TestExpectations batch - "data-corruption.html to duplicates.html"
https://bugs.webkit.org/show_bug.cgi?id=128711

Reviewed by Alexey Proskuryakov.

* platform/mac-wk2/TestExpectations:
* storage/indexeddb/database-basics-expected.txt:
* storage/indexeddb/database-name-undefined-expected.txt:
* storage/indexeddb/deleteIndex-bug110792-expected.txt:
* storage/indexeddb/deleteObjectStore-name-argument-required-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoIDB: TestExpectations batch - "cursor-added-bug.html to cursor-value.html"
beidson@apple.com [Thu, 13 Feb 2014 04:47:25 +0000 (04:47 +0000)]
IDB: TestExpectations batch - "cursor-added-bug.html to cursor-value.html"
https://bugs.webkit.org/show_bug.cgi?id=128706

Reviewed by Alexey Proskuryakov.

* platform/mac-wk2/TestExpectations:
* storage/indexeddb/cursor-continue-dir-expected.txt:
* storage/indexeddb/cursor-continue-expected.txt:
* storage/indexeddb/cursor-finished-expected.txt:
* storage/indexeddb/cursor-update-value-argument-required-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoPass the related page in the WebPageConfiguration struct
andersca@apple.com [Thu, 13 Feb 2014 04:43:24 +0000 (04:43 +0000)]
Pass the related page in the WebPageConfiguration struct
https://bugs.webkit.org/show_bug.cgi?id=128714

Reviewed by Darin Adler.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]):
* UIProcess/API/ios/WKContentView.h:
* UIProcess/API/ios/WKContentView.mm:
(-[WKContentView initWithFrame:context:WebKit::configuration:WebKit::]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDelayedReleaseScope in MarkedAllocator::tryAllocateHelper is wrong
mhahnenberg@apple.com [Thu, 13 Feb 2014 04:24:41 +0000 (04:24 +0000)]
DelayedReleaseScope in MarkedAllocator::tryAllocateHelper is wrong
https://bugs.webkit.org/show_bug.cgi?id=128641

Reviewed by Michael Saboff.

We were improperly handling the case where the DelayedReleaseScope
in tryAllocateHelper would cause us to drop the API lock, allowing
another thread to sneak in and allocate a new block after we had already
concluded that there were no more blocks to allocate out of.

The fix is to call tryAllocateHelper in a loop until we know for sure
that this did not happen.

There was also a race condition with the DelayedReleaseScope in addBlock.
We would add the block to the MarkedBlock's list, sweep it, and then return,
causing us to drop the API lock momentarily. Another thread could then
grab the lock, and allocate out of the new block to the point where the
free list was empty. Then we would return to the original thread, who thinks
it's impossible to not allocate successfully at this point.
Instead we should just let tryAllocate do all the hard work with correctly
sweeping and getting a valid result.

There was another race condition in didFinishIterating. We would call resumeAllocating,
which would create a DelayedReleaseScope. The DelayedReleaseScope would then release
API lock before we set m_isIterating back to false, which would potentially confuse
other threads.

* heap/MarkedAllocator.cpp:
(JSC::MarkedAllocator::tryAllocateHelper):
(JSC::MarkedAllocator::tryPopFreeList):
(JSC::MarkedAllocator::tryAllocate):
(JSC::MarkedAllocator::addBlock):
* heap/MarkedAllocator.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDon't crash when SerializedScriptValue deserialization fails
ap@apple.com [Thu, 13 Feb 2014 04:05:10 +0000 (04:05 +0000)]
Don't crash when SerializedScriptValue deserialization fails
https://bugs.webkit.org/show_bug.cgi?id=128657

Reviewed by Oliver Hunt.

Source/WebCore:

Test: crypto/subtle/postMessage-worker.html

* bindings/js/JSMessageEventCustom.cpp: (WebCore::JSMessageEvent::data): Added a FIXME.

* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneBase::fail): Don't assert on failure.
(WebCore::SerializedScriptValue::deserialize): Never return a null JSValue, these
are not allowed.

LayoutTests:

* crypto/subtle/postMessage-worker-expected.txt:
* crypto/subtle/resources/postMessage-worker.js:
* platform/mac/TestExpectations:
Unskip the test, and land (unimportant) failure results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Replay: capture and replay nondeterminism of Date.now() and Math.random()
bburg@apple.com [Thu, 13 Feb 2014 03:34:33 +0000 (03:34 +0000)]
Web Replay: capture and replay nondeterminism of Date.now() and Math.random()
https://bugs.webkit.org/show_bug.cgi?id=128633

Reviewed by Filip Pizlo.

Upstream the only two sources of script-visible nondeterminism in JavaScriptCore.

The random seed for WeakRandom is memoized when the owning JSGlobalObject is
constructed. It is deterministically initialized during replay before any
scripts execute with the global object.

The implementations of `Date.now()` and `new Date()` eventually obtain the
current time from jsCurrentTime(). When capturing, we save return values of
jsCurrentTime() into the recording. When replaying, we use memoized values from
the recording instead of obtaining values from the platform-specific currentTime()
implementation. No other code calls jsCurrentTime().

* DerivedSources.make: Add rules to make JSReplayInputs.h from JSInputs.json.
* JavaScriptCore.xcodeproj/project.pbxproj:
* replay/JSInputs.json: Added. Includes specifications for replay inputs
"GetCurrentTime" and "SetRandomSeed". Tests will be added for both input
cases once sufficient replay machinery has been added.

* replay/NondeterministicInput.h: NondeterministicInput should not have
been marked 'final'.

* runtime/DateConstructor.cpp:
(JSC::deterministicCurrentTime): Added. Load or store the current time depending
on what kind of InputCursor is attached to the JSGlobalObject.

(JSC::constructDate): Use deterministicCurrentTime().
(JSC::dateNow): Use deterministicCurrentTime().
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::setInputCursor): When setting a non-empty input cursor,
immediately store or load the "SetRandomSeed" input and initialize WeakRandom's
random seed with it. The input cursor (and thus random seed) must be set before
any scripts are evaluated with this JSGlobalObject.

* runtime/WeakRandom.h:
(JSC::WeakRandom::WeakRandom): Add JSGlobalObject as a friend class.
(JSC::WeakRandom::initializeSeed): Extract the seed initialization into a
separate method so it can be called outside of the JSGlobalObject constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Shapes] Rename shapeSize and others to make ShapeInfo and friends easier to...
bjonesbe@adobe.com [Thu, 13 Feb 2014 03:02:53 +0000 (03:02 +0000)]
[CSS Shapes] Rename shapeSize and others to make ShapeInfo and friends easier to understand
https://bugs.webkit.org/show_bug.cgi?id=128685

Reviewed by Alexandru Chiculita.

The ShapeInfo hierarchy has grown organically as the spec has changed,
and the naming has become very stale and confusing. The spec is now in
Last Call, so it seems like a good time to take a stab towards better
naming that matches the spec terminology and is also more consistent
in general.

No new tests, no behavior change.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::imageChanged): Use new names.
(WebCore::RenderBlock::updateShapeInsideInfoAfterStyleChange): Ditto.
(WebCore::shapeInfoRequiresRelayout): Ditto.
(WebCore::RenderBlock::computeShapeSize): Ditto.
(WebCore::RenderBlock::updateShapesAfterBlockLayout): Ditto.
* rendering/RenderBlock.h:
(WebCore::RenderBlock::logicalSizeForChild): This method makes it much
    cleaner to set the reference box size.
* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::positionNewFloats): Use new names.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::updateShapeOutsideInfoAfterStyleChange): Ditto.
(WebCore::RenderBox::imageChanged): Ditto.
* rendering/shapes/ShapeInfo.cpp:
(WebCore::getShapeImageMarginRect): Rename variables.
(WebCore::ShapeInfo<RenderType>::computedShape): More renames.
* rendering/shapes/ShapeInfo.h:
(WebCore::ShapeInfo::setReferenceBoxLogicalSize): Renamed from
    setShapeSize.
(WebCore::ShapeInfo::logicalLineTop): Use new names.
(WebCore::ShapeInfo::logicalLineBottom): Ditto.
(WebCore::ShapeInfo::shapeContainingBlockLogicalHeight): Ditto.
(WebCore::ShapeInfo::markShapeAsDirty): Renamed from dirtyShapeSize.
(WebCore::ShapeInfo::isShapeDirty): Renamed from shapeSizeDirty.
(WebCore::ShapeInfo::referenceBoxLogicalSize): Renamed from shapeSize.
(WebCore::ShapeInfo::logicalTopOffset): Use new names.
(WebCore::ShapeInfo::logicalLeftOffset): Ditto.
* rendering/shapes/ShapeInsideInfo.cpp:
(WebCore::ShapeInsideInfo::updateSegmentsForLine): Ditto.
(WebCore::ShapeInsideInfo::adjustLogicalLineTop): Ditto.
(WebCore::ShapeInsideInfo::computeFirstFitPositionForFloat): Ditto.
* rendering/shapes/ShapeInsideInfo.h:
* rendering/shapes/ShapeOutsideInfo.cpp:
(WebCore::ShapeOutsideInfo::updateDeltasForContainingBlockLine): Ditto.
* rendering/shapes/ShapeOutsideInfo.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd relatedWebView property to WKWebViewConfiguration
andersca@apple.com [Thu, 13 Feb 2014 01:54:27 +0000 (01:54 +0000)]
Add relatedWebView property to WKWebViewConfiguration
https://bugs.webkit.org/show_bug.cgi?id=128707

Reviewed by Dan Bernstein.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]):
* UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration relatedWebView]):
(-[WKWebViewConfiguration setRelatedWebView:]):
* UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm.
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION: Crashing/Broken Tests Due To Unexpected 8-bit Character Data
bfulgham@apple.com [Thu, 13 Feb 2014 01:27:28 +0000 (01:27 +0000)]
REGRESSION: Crashing/Broken Tests Due To Unexpected 8-bit Character Data
https://bugs.webkit.org/show_bug.cgi?id=128698

Reviewed by Tim Horton.

* platform/graphics/win/UniscribeController.cpp:
(WebCore::UniscribeController::advance): Make 16-bit copy when needed.
(WebCore::UniscribeController::shapeAndPlaceItem): Handle 8-bit case when checking
for word boundaries.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoIDB: TestExpectations batch - "aborted-versionchange-closes.html to createObjectStore...
beidson@apple.com [Thu, 13 Feb 2014 01:06:58 +0000 (01:06 +0000)]
IDB: TestExpectations batch - "aborted-versionchange-closes.html to createObjectStore-null-name.html"
https://bugs.webkit.org/show_bug.cgi?id=128703

Reviewed by Alexey Proskuryakov.

* platform/mac-wk2/TestExpectations:
* storage/indexeddb/aborted-versionchange-closes-expected.txt:
* storage/indexeddb/basics-expected.txt:
* storage/indexeddb/clone-exception-expected.txt:
* storage/indexeddb/create-and-remove-object-store-expected.txt:
* storage/indexeddb/createObjectStore-name-argument-required-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WK2] Add a C API to get WebCrypto master key from a client
ap@apple.com [Thu, 13 Feb 2014 00:39:21 +0000 (00:39 +0000)]
[WK2] Add a C API to get WebCrypto master key from a client
https://bugs.webkit.org/show_bug.cgi?id=128702

Reviewed by Anders Carlsson.

Source/WebKit2:

Added a new version of WKContextClient, with a function that returns the key.

* UIProcess/API/C/WKContext.h:
* UIProcess/WebContextClient.cpp:
(WebKit::WebContextClient::copyWebCryptoMasterKey):
* UIProcess/WebContextClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::wrapCryptoKey):
(WebKit::WebPageProxy::unwrapCryptoKey):
* UIProcess/mac/WebPageProxyMac.mm:

Tools:

* WebKitTestRunner/TestController.cpp:
(WTR::copyWebCryptoMasterKey):
(WTR::TestController::initialize):
Return a hardcoded key.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpstream iOS old-run-webkit-tests for use with DumpRenderTree in the iOS Simulator
dfarler@apple.com [Thu, 13 Feb 2014 00:38:25 +0000 (00:38 +0000)]
Upstream iOS old-run-webkit-tests for use with DumpRenderTree in the iOS Simulator
https://bugs.webkit.org/show_bug.cgi?id=127694

Reviewed by Simon Fraser.

This is a short-term effort to get layout tests working in the iOS simulator again.

* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
Pass PLATFORM_NAME to the makefile.
* DumpRenderTree/ios/PerlSupport/Makefile:
Cleanup.
* Scripts/old-run-webkit-tests:
Added functions and some exceptions for the simulator.
(installAndLaunchDumpRenderTreeAppUsingNotification):
(openIPhoneSimulator):
(quitDumpRenderTreeAppUsingNotification):
(quitIPhoneSimulator):
(simulatorSessionUUID):
(openDiffTool):
(buildDumpTool):
(openDumpTool):
(closeDumpTool):
(dumpToolDidCrash):
(expectedDirectoryForTest):
(buildPlatformResultHierarchy):
* Scripts/webkitdirs.pm:
Support functions for old-run-webkit-tests.
(determineIPhoneSimulatorVersion):
(iPhoneSimulatorVersion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd destinationFrame property to WKNavigationAction
andersca@apple.com [Thu, 13 Feb 2014 00:17:49 +0000 (00:17 +0000)]
Add destinationFrame property to WKNavigationAction
https://bugs.webkit.org/show_bug.cgi?id=128700

Reviewed by Tim Horton.

* UIProcess/API/Cocoa/WKNavigationAction.h:
* UIProcess/API/Cocoa/WKNavigationAction.mm:
(-[WKNavigationAction destinationFrame]):
(-[WKNavigationAction setDestinationFrame:]):
* UIProcess/API/Cocoa/WKNavigationActionInternal.h:
* UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::PolicyClient::decidePolicyForNavigationAction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoForward declare WKNavigation in WKNavigationDelegate.h
andersca@apple.com [Wed, 12 Feb 2014 23:57:08 +0000 (23:57 +0000)]
Forward declare WKNavigation in WKNavigationDelegate.h
https://bugs.webkit.org/show_bug.cgi?id=128699

Reviewed by Tim Horton.

* UIProcess/API/Cocoa/WKNavigationDelegate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDocument::childrenChanged does not necessarily have a page
benjamin@webkit.org [Wed, 12 Feb 2014 23:14:43 +0000 (23:14 +0000)]
Document::childrenChanged does not necessarily have a page

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-02-12
Rubber stamped by Enrica Casucci.

* dom/Document.cpp:
(WebCore::Document::childrenChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoExpose scrollView on the WKWebView
andersca@apple.com [Wed, 12 Feb 2014 23:13:49 +0000 (23:13 +0000)]
Expose scrollView on the WKWebView
https://bugs.webkit.org/show_bug.cgi?id=128697

Reviewed by Dan Bernstein.

* UIProcess/API/Cocoa/WKWebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd a missing ": " between the URL and exception in STDOUT logs.
timothy@apple.com [Wed, 12 Feb 2014 23:09:28 +0000 (23:09 +0000)]
Add a missing ": " between the URL and exception in STDOUT logs.

https://bugs.webkit.org/show_bug.cgi?id=128689

Reviewed by Joseph Pecoraro.

* page/PageConsole.cpp:
(WebCore::PageConsole::addMessage): Print ": " after calling
printSourceURLAndPosition now that it does not print it for us.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBetter iOS build fix.
andersca@apple.com [Wed, 12 Feb 2014 22:56:27 +0000 (22:56 +0000)]
Better iOS build fix.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::wrapCryptoKey):
(WebKit::WebPageProxy::unwrapCryptoKey):
Make these functions cross platform.

* UIProcess/mac/WebPageProxyMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBasic framework for a modern jsc CLI
mhahnenberg@apple.com [Wed, 12 Feb 2014 22:54:26 +0000 (22:54 +0000)]
Basic framework for a modern jsc CLI
https://bugs.webkit.org/show_bug.cgi?id=127435

Rubber stamped by Geoffrey Garen.

* Scripts/build-jsc:
* jsc-cli: Added.
* jsc-cli/jsc-cli: Added.
* jsc-cli/jsc-cli.xcodeproj: Added.
* jsc-cli/jsc-cli.xcodeproj/project.pbxproj: Added.
* jsc-cli/jsc-cli/CLIInstance.h: Added.
* jsc-cli/jsc-cli/CLIInstance.m: Added.
(-[CLIInstance init]):
(-[CLIInstance loadFile:]):
(-[CLIInstance run]):
* jsc-cli/jsc-cli/JSModule.h: Added.
* jsc-cli/jsc-cli/JSModule.m: Added.
(coreModules):
(isCoreModule):
(classForModule):
(coreModuleFullPath):
(resolveModuleAsFile):
(resolveModuleAsDirectory):
(nodeModulePaths):
(resolveAsNodeModule):
(+[JSModule resolve:atPath:]):
(globalModuleCache):
(isCached):
(cachedModule):
(cacheModule):
(+[JSModule require:atPath:]):
(+[JSModule require:atPath:inContext:]):
(-[JSModule platformObjectInContext:]):
(-[JSModule initWithId:filename:context:]):
(-[JSModule dealloc]):
(-[JSModule didStartLoading]):
(-[JSModule didFinishLoading]):
(-[JSModule require:]):
(-[JSModule exports]):
* jsc-cli/jsc-cli/JSRunLoopThread.h: Added.
* jsc-cli/jsc-cli/JSRunLoopThread.m: Added.
(jsThreadMain):
(+[JSRunLoopThread threadMain]):
(-[JSRunLoopThread initWithFiles:andContext:]):
(-[JSRunLoopThread startRunLoop]):
(-[JSRunLoopThread start]):
(-[JSRunLoopThread join]):
(-[JSRunLoopThread didReceiveInput:]):
(-[JSRunLoopThread performCallback:withError:]):
(-[JSRunLoopThread performCallback:withArguments:]):
(-[JSRunLoopThread didFinishRunLoopInitialization]):
* jsc-cli/jsc-cli/ReadEvalPrintLoop.h: Added.
* jsc-cli/jsc-cli/ReadEvalPrintLoop.m: Added.
(-[ReadEvalPrintLoop initWithJSThread:]):
(prompt):
(escapeStringForOutput):
(-[ReadEvalPrintLoop processNextInput]):
(-[ReadEvalPrintLoop run]):
* jsc-cli/jsc-cli/RunLoopThread.h: Added.
* jsc-cli/jsc-cli/RunLoopThread.m: Added.
(+[RunLoopThread threadMain]):
(-[RunLoopThread init]):
(-[RunLoopThread dealloc]):
(-[RunLoopThread didFinishRunLoopInitialization]):
(-[RunLoopThread start]):
(-[RunLoopThread join]):
* jsc-cli/jsc-cli/ScriptInputSource.h: Added.
* jsc-cli/jsc-cli/ScriptInputSource.m: Added.
(scriptInputSourceScheduleRoutine):
(scriptInputSourcePerformRoutine):
(scriptInputSourceCancelRoutine):
(-[ScriptInputSource initWithContext:]):
(-[ScriptInputSource dealloc]):
(-[ScriptInputSource addToCurrentRunLoop]):
(-[ScriptInputSource removeFromRemoteRunLoop]):
(-[ScriptInputSource didReceiveScript:]):
(-[ScriptInputSource didReceiveSignal]):
(-[ScriptInputSource runScriptRemotely:]):
(-[ScriptInputSource finishAsyncCallback:withResult:]):
* jsc-cli/jsc-cli/main.m: Added.
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoOne more build fix after r163979.
rniwa@webkit.org [Wed, 12 Feb 2014 22:44:14 +0000 (22:44 +0000)]
One more build fix after r163979.

* Scripts/webkitpy/port/mac_unittest.py:
(test_baseline_search_path):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWK2: coordinate mapping for frames does not work when the page is scrolled.
enrica@apple.com [Wed, 12 Feb 2014 22:37:20 +0000 (22:37 +0000)]
WK2: coordinate mapping for frames does not work when the page is scrolled.
https://bugs.webkit.org/show_bug.cgi?id=128690
<rdar://problem/16042925>

Reviewed by Simon Fraser.

We should not apply the scroll offset when using delegate scrolling.

* platform/ScrollView.cpp:
(WebCore::ScrollView::rootViewToContents):
(WebCore::ScrollView::contentsToRootView):
(WebCore::ScrollView::rootViewToTotalContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Cleanup JavaScriptCore/inspector
commit-queue@webkit.org [Wed, 12 Feb 2014 22:36:56 +0000 (22:36 +0000)]
Web Inspector: Cleanup JavaScriptCore/inspector
https://bugs.webkit.org/show_bug.cgi?id=128662

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-02-12
Reviewed by Timothy Hatcher.

Now that the code has settled, do a cleanup pass.

* inspector/ContentSearchUtilities.cpp:
* inspector/InspectorValues.cpp:
(Inspector::InspectorValue::asObject):
(Inspector::InspectorValue::asArray):
(Inspector::InspectorValue::parseJSON):
(Inspector::InspectorObjectBase::getObject):
(Inspector::InspectorObjectBase::getArray):
(Inspector::InspectorObjectBase::get):
* inspector/ScriptCallStackFactory.cpp:
* inspector/ScriptDebugServer.cpp:
* inspector/agents/JSGlobalObjectConsoleAgent.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Rename PageInjectedScript* to WebInjectedScript*
commit-queue@webkit.org [Wed, 12 Feb 2014 22:36:24 +0000 (22:36 +0000)]
Web Inspector: Rename PageInjectedScript* to WebInjectedScript*
https://bugs.webkit.org/show_bug.cgi?id=128660

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-02-12
Reviewed by Timothy Hatcher.

Rename the files update build systems and users.

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* inspector/CommandLineAPIModule.cpp:
(WebCore::CommandLineAPIModule::host):
* inspector/InspectorAllInOne.cpp:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
* inspector/InspectorController.h:
* inspector/InspectorHeapProfilerAgent.cpp:
(WebCore::InspectorHeapProfilerAgent::InspectorHeapProfilerAgent):
* inspector/InspectorHeapProfilerAgent.h:
* inspector/InspectorProfilerAgent.cpp:
(WebCore::PageProfilerAgent::PageProfilerAgent):
(WebCore::InspectorProfilerAgent::create):
(WebCore::WorkerProfilerAgent::WorkerProfilerAgent):
(WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
* inspector/InspectorProfilerAgent.h:
* inspector/PageConsoleAgent.cpp:
(WebCore::PageConsoleAgent::PageConsoleAgent):
(WebCore::PageConsoleAgent::addInspectedNode):
* inspector/PageConsoleAgent.h:
* inspector/WebConsoleAgent.cpp:
(WebCore::WebConsoleAgent::WebConsoleAgent):
(WebCore::WebConsoleAgent::frameWindowDiscarded):
(WebCore::WebConsoleAgent::addInspectedHeapObject):
* inspector/WebConsoleAgent.h:
* inspector/WebInjectedScriptHost.cpp: Renamed from Source/WebCore/inspector/PageInjectedScriptHost.cpp.
(WebCore::WebInjectedScriptHost::type):
(WebCore::WebInjectedScriptHost::isHTMLAllCollection):
* inspector/WebInjectedScriptHost.h: Renamed from Source/WebCore/inspector/PageInjectedScriptHost.h.
* inspector/WebInjectedScriptManager.cpp: Renamed from Source/WebCore/inspector/PageInjectedScriptManager.cpp.
(WebCore::WebInjectedScriptManager::WebInjectedScriptManager):
(WebCore::WebInjectedScriptManager::disconnect):
(WebCore::WebInjectedScriptManager::didCreateInjectedScript):
(WebCore::WebInjectedScriptManager::discardInjectedScriptsFor):
* inspector/WebInjectedScriptManager.h: Renamed from Source/WebCore/inspector/PageInjectedScriptManager.h.
* inspector/WorkerConsoleAgent.cpp:
(WebCore::WorkerConsoleAgent::WorkerConsoleAgent):
* inspector/WorkerConsoleAgent.h:
* inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::WorkerInspectorController):
* inspector/WorkerInspectorController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix the iOS build after r163976
aestes@apple.com [Wed, 12 Feb 2014 22:32:38 +0000 (22:32 +0000)]
Fix the iOS build after r163976

Moved WebPageProxy::{wrap,unwrap}CryptoKey() to a new file built by
both Mac and iOS.

* UIProcess/Cocoa/WebPageProxyCocoa.mm: Added.
(WebKit::WebPageProxy::wrapCryptoKey):
(WebKit::WebPageProxy::unwrapCryptoKey):
* UIProcess/mac/WebPageProxyMac.mm:
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Regions] Fix layout of floated nested region
stavila@adobe.com [Wed, 12 Feb 2014 22:16:56 +0000 (22:16 +0000)]
[CSS Regions] Fix layout of floated nested region
https://bugs.webkit.org/show_bug.cgi?id=128367

Reviewed by Mihnea Ovidenie.

Added test for the correct layout of nested, floating regions.

* fast/regions/nested-floated-region-expected.html: Added.
* fast/regions/nested-floated-region.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed iOS Build fix after r163975.
bfulgham@apple.com [Wed, 12 Feb 2014 22:07:04 +0000 (22:07 +0000)]
Unreviewed iOS Build fix after r163975.

* page/EventHandler.cpp: Use wheel event stubs if !PLATFORM(MAC) || PLATFORM(IOS).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163984 268f45cc-cd09-0410-ab3c-d52691b4dbfc