WebKit-https.git
7 years agoUnreviewed, rolling out r141319.
commit-queue@webkit.org [Fri, 1 Feb 2013 14:17:49 +0000 (14:17 +0000)]
Unreviewed, rolling out r141319.
http://trac.webkit.org/changeset/141319
https://bugs.webkit.org/show_bug.cgi?id=108629

This patch is causing the UIProcess to hang on GTK port when
loading plugins (Requested by chris-qBT_laptop on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-01

* UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:
(WebKit::PluginProcessProxy::scanPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix for WinCE after r137709
paroga@webkit.org [Fri, 1 Feb 2013 14:12:51 +0000 (14:12 +0000)]
Build fix for WinCE after r137709
https://bugs.webkit.org/show_bug.cgi?id=105767

Do not pass functions as const references to
templated arguments to make the compiler happy.

* wtf/StdLibExtras.h:
(WTF::binarySearch):
(WTF::tryBinarySearch):
(WTF::approximateBinarySearch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK][WK2] MiniBrowser fullscreen signals support
commit-queue@webkit.org [Fri, 1 Feb 2013 14:11:18 +0000 (14:11 +0000)]
[GTK][WK2] MiniBrowser fullscreen signals support
https://bugs.webkit.org/show_bug.cgi?id=108005

Patch by Manuel Rego Casasnovas <rego@igalia.com> on 2013-02-01
Reviewed by Carlos Garcia Campos.

Shows a label for 2 seconds using overlay (if GTK >= 3.2.0) and hides
the toolbar when entering fullscreen. When leaving fullscreen the
label is hidden (if it's not hidden yet) and the toolbar is shown again.

* MiniBrowser/gtk/BrowserWindow.c:
(_BrowserWindow):
(fullScreenMessageTimeoutCallback):
(webViewEnterFullScreen):
(webViewLeaveFullScreen):
(browserWindowFinalize):
(browserWindowConstructed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening.
sudarsana.nagineni@linux.intel.com [Fri, 1 Feb 2013 13:42:25 +0000 (13:42 +0000)]
Unreviewed EFL gardening.

Skip some failing tests on EFL bots after r141459 and r141310.

* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:
* platform/efl/fast/js/global-constructors-expected.txt: Revert change from r141573.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] EwkContext should be based on C WK2 API
mikhail.pozdnyakov@intel.com [Fri, 1 Feb 2013 13:08:17 +0000 (13:08 +0000)]
[EFL][WK2] EwkContext should be based on C WK2 API
https://bugs.webkit.org/show_bug.cgi?id=107666

Reviewed by Andreas Kling.

EwkContext should be based on C WK2 API so that API layering is not violated.

* UIProcess/API/efl/EwkView.cpp:
(EwkView::EwkView):
* UIProcess/API/efl/ewk_context.cpp:
(EwkContext::EwkContext):
(EwkContext::create):
(EwkContext::cookieManager):
(EwkContext::ensureFaviconDatabase):
(EwkContext::setFaviconDatabaseDirectoryPath):
(EwkContext::addVisitedLink):
(EwkContext::setCacheModel):
(EwkContext::cacheModel):
(EwkContext::setAdditionalPluginPath):
(EwkContext::clearResourceCache):
* UIProcess/API/efl/ewk_context_private.h:
(EwkContext):
* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_base_add):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix hanging deleteQWebViewTwice test
hausmann@webkit.org [Fri, 1 Feb 2013 13:00:32 +0000 (13:00 +0000)]
[Qt] Fix hanging deleteQWebViewTwice test

Reviewed by Allan Sandfeld Jensen.

Don't use QCoreApplication::instance()->exec(), because in case of a bug
that never finishes. Instead use waitForSignal() which has the concept of
a timeout.

* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::deleteQWebViewTwice):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Use C API inside ewk_auth_request
christophe.dumez@intel.com [Fri, 1 Feb 2013 12:56:17 +0000 (12:56 +0000)]
[EFL][WK2] Use C API inside ewk_auth_request
https://bugs.webkit.org/show_bug.cgi?id=107806

Reviewed by Andreas Kling.

Use C API inside ewk_auth_request instead of accessing C++ internal
classes directly, to avoid violating layering.

* UIProcess/API/efl/ewk_auth_request.cpp:
(EwkAuthRequest::EwkAuthRequest):
(EwkAuthRequest::suggestedUsername):
(EwkAuthRequest::realm):
(EwkAuthRequest::host):
(EwkAuthRequest::continueWithoutCredential):
(EwkAuthRequest::authenticate):
(EwkAuthRequest::isRetrying):
(ewk_auth_request_authenticate):
* UIProcess/API/efl/ewk_auth_request_private.h:
(EwkAuthRequest::create):
(EwkAuthRequest):
* UIProcess/efl/PageLoadClientEfl.cpp:
(WebKit::PageLoadClientEfl::didReceiveAuthenticationChallengeInFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Gtk][WK2] Fix build after recent WebKit2 changes
hausmann@webkit.org [Fri, 1 Feb 2013 12:54:33 +0000 (12:54 +0000)]
[Gtk][WK2] Fix build after recent WebKit2 changes
https://bugs.webkit.org/show_bug.cgi?id=108588

Patch by Seulgi Kim <seulgikim@company100.net> on 2013-02-01
Reviewed by Andreas Kling.

Don't remove WorkQueue during execution.
Following the logic on https://bugs.webkit.org/show_bug.cgi?id=108544

* Platform/gtk/WorkQueueGtk.cpp:
(WorkQueue::EventSource::~EventSource):
(WorkQueue::EventSource::executeEventSource):
(WorkQueue::dispatch):
(WorkQueue::dispatchAfterDelay):
(WorkQueue::dispatchOnTermination):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Follow up to r141260: fixing renamed style.
pfeldman@chromium.org [Fri, 1 Feb 2013 12:23:56 +0000 (12:23 +0000)]
Web Inspector: Follow up to r141260: fixing renamed style.
Not reviewed.

* inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.FilteredItemSelectionDialog.prototype._createItemElement):
(WebInspector.FilteredItemSelectionDialog.prototype._onClick):
(WebInspector.FilteredItemSelectionDialog.prototype._onMouseMove):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEnable unprefixed CSS transitions by default.
alexis@webkit.org [Fri, 1 Feb 2013 12:16:51 +0000 (12:16 +0000)]
Enable unprefixed CSS transitions by default.
https://bugs.webkit.org/show_bug.cgi?id=108216

Reviewed by Dean Jackson.

.:

Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations.

* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations.

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations. Remove the
various #ifdefs and conditional generations.

* Configurations/FeatureDefines.xcconfig:
* DerivedSources.cpp:
* GNUmakefile.features.am.in:
* css/CSSPropertyNames.in:
* dom/EventNames.in:
* dom/TransitionEvent.cpp:
* dom/TransitionEvent.h:
* dom/TransitionEvent.idl:
* page/DOMWindow.idl:
* page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::fireEventsAndUpdateStyle):

Source/WebKit/chromium:

Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations.

* features.gypi:

Source/WebKit/mac:

Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations.

* Configurations/FeatureDefines.xcconfig:

Tools:

Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations.

* Scripts/webkitperl/FeatureList.pm:
* qmake/mkspecs/features/features.pri:

WebKitLibraries:

Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations.

* win/tools/vsprops/FeatureDefines.vsprops:
* win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

Unskip the tests by default as now unprefixed CSS Transitions are
enabled by default.

* fast/events/event-creation-expected.txt:
* fast/events/event-creation.html: Add the test that was commented out
before.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r141548.
haraken@chromium.org [Fri, 1 Feb 2013 11:49:35 +0000 (11:49 +0000)]
Unreviewed, rolling out r141548.
http://trac.webkit.org/changeset/141548
https://bugs.webkit.org/show_bug.cgi?id=108579

userscript-plugin-document.html is flaky

* bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::setWrapperInObject):
* bindings/v8/V8GCController.cpp:
(WebCore):
(WebCore::gcTree):
(WebCore::V8GCController::didCreateWrapperForNode):
(WebCore::V8GCController::gcPrologue):
(WebCore::V8GCController::minorGCPrologue):
(WebCore::V8GCController::majorGCPrologue):
* bindings/v8/V8GCController.h:
(V8GCController):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening. Skipped some failing tests.
kadam@inf.u-szeged.hu [Fri, 1 Feb 2013 11:39:56 +0000 (11:39 +0000)]
[Qt] Unreviewed gardening. Skipped some failing tests.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Skip hanging WebGL software fallback tests
hausmann@webkit.org [Fri, 1 Feb 2013 11:27:47 +0000 (11:27 +0000)]
[Qt] Skip hanging WebGL software fallback tests

Reviewed by Allan Sandfeld Jensen.

See also https://bugs.webkit.org/show_bug.cgi?id=105820.

* tests/qgraphicswebview/tst_qgraphicswebview.cpp:
(tst_QGraphicsWebView::webglSoftwareFallbackVerticalOrientation):
(tst_QGraphicsWebView::webglSoftwareFallbackHorizontalOrientation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: fix jscompiler warnings
aandrey@chromium.org [Fri, 1 Feb 2013 11:26:17 +0000 (11:26 +0000)]
Web Inspector: fix jscompiler warnings
https://bugs.webkit.org/show_bug.cgi?id=108604

Reviewed by Pavel Feldman.

* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleGroup.prototype.addMessage):
* inspector/front-end/ContextMenu.js:
(WebInspector.ContextSubMenuItem):
* inspector/front-end/ImageView.js:
(WebInspector.ImageView.prototype._copyImageURL):
(WebInspector.ImageView.prototype._openInNewTab):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._clearBrowserCache):
(WebInspector.NetworkLogView.prototype._clearBrowserCookies):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.IDBDatabaseTreeElement.prototype._refreshIndexedDB):
* inspector/front-end/ScriptsNavigator.js:
(WebInspector.SnippetsNavigatorView.prototype._handleEvaluateSnippet):
(WebInspector.SnippetsNavigatorView.prototype._handleRenameSnippet):
(WebInspector.SnippetsNavigatorView.prototype._handleRemoveSnippet):
(WebInspector.SnippetsNavigatorView.prototype._handleCreateSnippet):
* inspector/front-end/Toolbar.js:
(WebInspector.Toolbar.prototype._isDockedToBottom):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening.
sudarsana.nagineni@linux.intel.com [Fri, 1 Feb 2013 11:22:04 +0000 (11:22 +0000)]
Unreviewed EFL gardening.

Update platform expectations for failing tests after the
WEB_INTENTS flag turned off for EFL port in r141439

* platform/efl/fast/images/crossfade-client-not-removed-crash-expected.txt: Removed.
* platform/efl/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening.
sudarsana.nagineni@linux.intel.com [Fri, 1 Feb 2013 11:00:58 +0000 (11:00 +0000)]
Unreviewed EFL gardening.

Renamed inspector/editor/text-editor-ctrl-movements.html to
inspector/editor/text-editor-word-jumps.html after r141399.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCoordinated Graphics : Sort Target.pri and class declarations in alphabetical order.
commit-queue@webkit.org [Fri, 1 Feb 2013 10:51:59 +0000 (10:51 +0000)]
Coordinated Graphics : Sort Target.pri and class declarations in alphabetical order.
https://bugs.webkit.org/show_bug.cgi?id=108590

Patch by Jae Hyun Park <jae.park@company100.net> on 2013-02-01
Reviewed by Noam Rosenthal.

Source/WebCore:

Sort CoordinatedGraphics files in Target.pri in alphabetical order.

No new tests. No change in behavior.

* Target.pri:

Source/WebKit2:

Sort class declarations in alphabetical order.

* Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Native Memory Instrumentation: provide edge names to class members...
loislo@chromium.org [Fri, 1 Feb 2013 10:42:37 +0000 (10:42 +0000)]
Web Inspector: Native Memory Instrumentation: provide edge names to class members in all WebCore instrumented classes.
https://bugs.webkit.org/show_bug.cgi?id=107369

Reviewed by Yury Semikhatsky.

It is almost mechanical change generated by a script.
Late I'll implement name to edge name consistency check in clang plugin.

* Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::reportMemoryUsage):
* Modules/webaudio/AudioNode.cpp:
(WebCore::AudioNode::reportMemoryUsage):
* bindings/js/ScriptWrappable.h:
(WebCore::ScriptWrappable::reportMemoryUsage):
* bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::reportMemoryUsage):
* bindings/v8/DOMWrapperMap.h:
(WebCore::DOMWrapperMap::reportMemoryUsage):
* bindings/v8/V8PerIsolateData.cpp:
(WebCore::V8PerIsolateData::reportMemoryUsage):
* bindings/v8/V8ValueCache.cpp:
(WebCore::StringCache::reportMemoryUsage):
* css/CSSBorderImageSliceValue.cpp:
(WebCore::CSSBorderImageSliceValue::reportDescendantMemoryUsage):
* css/CSSCalculationValue.cpp:
* css/CSSCanvasValue.cpp:
(WebCore::CSSCanvasValue::reportDescendantMemoryUsage):
* css/CSSCharsetRule.cpp:
(WebCore::CSSCharsetRule::reportMemoryUsage):
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::reportMemoryUsage):
* css/CSSCrossfadeValue.cpp:
(WebCore::CSSCrossfadeValue::reportDescendantMemoryUsage):
* css/CSSCursorImageValue.cpp:
(WebCore::CSSCursorImageValue::reportDescendantMemoryUsage):
* css/CSSFontFaceRule.cpp:
(WebCore::CSSFontFaceRule::reportMemoryUsage):
* css/CSSFontFaceSrcValue.cpp:
(WebCore::CSSFontFaceSrcValue::reportDescendantMemoryUsage):
* css/CSSFunctionValue.cpp:
(WebCore::CSSFunctionValue::reportDescendantMemoryUsage):
* css/CSSGradientValue.cpp:
(WebCore::CSSGradientColorStop::reportMemoryUsage):
(WebCore::CSSGradientValue::reportBaseClassMemoryUsage):
(WebCore::CSSLinearGradientValue::reportDescendantMemoryUsage):
(WebCore::CSSRadialGradientValue::reportDescendantMemoryUsage):
* css/CSSGroupingRule.cpp:
(WebCore::CSSGroupingRule::reportMemoryUsage):
* css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::reportBaseClassMemoryUsage):
* css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::reportDescendantMemoryUsage):
(WebCore::CSSImageSetValue::ImageWithScale::reportMemoryUsage):
* css/CSSImageValue.cpp:
(WebCore::CSSImageValue::reportDescendantMemoryUsage):
* css/CSSImportRule.cpp:
(WebCore::CSSImportRule::reportMemoryUsage):
* css/CSSMediaRule.cpp:
(WebCore::CSSMediaRule::reportMemoryUsage):
* css/CSSPageRule.cpp:
(WebCore::CSSPageRule::reportMemoryUsage):
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::reportDescendantMemoryUsage):
* css/CSSProperty.cpp:
(WebCore::CSSProperty::reportMemoryUsage):
* css/CSSReflectValue.cpp:
(WebCore::CSSReflectValue::reportDescendantMemoryUsage):
* css/CSSRule.cpp:
(WebCore::CSSRule::reportMemoryUsage):
* css/CSSRuleList.cpp:
(WebCore::StaticCSSRuleList::reportMemoryUsage):
* css/CSSRuleList.h:
* css/CSSSelectorList.cpp:
(WebCore::CSSSelectorList::reportMemoryUsage):
* css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::reportMemoryUsage):
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::reportMemoryUsage):
* css/CSSValue.cpp:
(WebCore::TextCloneCSSValue::reportDescendantMemoryUsage):
* css/CSSValueList.cpp:
(WebCore::CSSValueList::reportDescendantMemoryUsage):
* css/CSSVariableValue.h:
(WebCore::CSSVariableValue::reportDescendantMemoryUsage):
* css/FontFeatureValue.cpp:
(WebCore::FontFeatureValue::reportDescendantMemoryUsage):
* css/FontValue.cpp:
(WebCore::FontValue::reportDescendantMemoryUsage):
* css/MediaList.cpp:
(WebCore::MediaQuerySet::reportMemoryUsage):
(WebCore::MediaList::reportMemoryUsage):
* css/MediaQuery.cpp:
(WebCore::MediaQuery::reportMemoryUsage):
* css/MediaQueryExp.cpp:
(WebCore::MediaQueryExp::reportMemoryUsage):
* css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::reportMemoryUsage):
(WebCore::StyleRuleCSSStyleDeclaration::reportMemoryUsage):
(WebCore::InlineCSSStyleDeclaration::reportMemoryUsage):
* css/RuleFeature.cpp:
(WebCore::RuleFeatureSet::reportMemoryUsage):
* css/RuleSet.cpp:
(WebCore::RuleData::reportMemoryUsage):
(WebCore::RuleSet::reportMemoryUsage):
(WebCore::RuleSet::RuleSetSelectorPair::reportMemoryUsage):
* css/ShadowValue.cpp:
(WebCore::ShadowValue::reportDescendantMemoryUsage):
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::reportMemoryUsage):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::MatchedProperties::reportMemoryUsage):
(WebCore::StyleResolver::MatchedPropertiesCacheItem::reportMemoryUsage):
(WebCore::MediaQueryResult::reportMemoryUsage):
(WebCore::StyleResolver::reportMemoryUsage):
* css/StyleRule.cpp:
(WebCore::StyleRule::reportDescendantMemoryUsage):
(WebCore::StyleRulePage::reportDescendantMemoryUsage):
(WebCore::StyleRuleFontFace::reportDescendantMemoryUsage):
(WebCore::StyleRuleGroup::reportDescendantMemoryUsage):
(WebCore::StyleRuleMedia::reportDescendantMemoryUsage):
(WebCore::StyleRuleRegion::reportDescendantMemoryUsage):
(WebCore::StyleRuleViewport::reportDescendantMemoryUsage):
* css/StyleRuleImport.cpp:
(WebCore::StyleRuleImport::reportDescendantMemoryUsage):
* css/StyleScopeResolver.cpp:
(WebCore::StyleScopeResolver::reportMemoryUsage):
* css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::reportMemoryUsage):
* css/WebKitCSSKeyframeRule.cpp:
(WebCore::StyleKeyframe::reportMemoryUsage):
(WebCore::WebKitCSSKeyframeRule::reportMemoryUsage):
* css/WebKitCSSKeyframesRule.cpp:
(WebCore::StyleRuleKeyframes::reportDescendantMemoryUsage):
(WebCore::WebKitCSSKeyframesRule::reportMemoryUsage):
* css/WebKitCSSSVGDocumentValue.cpp:
(WebCore::WebKitCSSSVGDocumentValue::reportDescendantMemoryUsage):
* css/WebKitCSSShaderValue.cpp:
(WebCore::WebKitCSSShaderValue::reportDescendantMemoryUsage):
* css/WebKitCSSViewportRule.cpp:
(WebCore::WebKitCSSViewportRule::reportMemoryUsage):
* dom/Attribute.h:
(WebCore::Attribute::reportMemoryUsage):
* dom/CharacterData.cpp:
(WebCore::CharacterData::reportMemoryUsage):
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::reportMemoryUsage):
* dom/ContainerNode.h:
(ContainerNode):
* dom/Document.cpp:
(WebCore::Document::reportMemoryUsage):
* dom/DocumentEventQueue.cpp:
(WebCore::DocumentEventQueue::reportMemoryUsage):
* dom/DocumentOrderedMap.cpp:
(WebCore::DocumentOrderedMap::reportMemoryUsage):
* dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::reportMemoryUsage):
* dom/Element.cpp:
(WebCore::Element::reportMemoryUsage):
* dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::reportMemoryUsage):
* dom/ElementRareData.cpp:
(WebCore::ElementRareData::reportMemoryUsage):
* dom/ElementShadow.cpp:
(WebCore::ElementShadow::reportMemoryUsage):
* dom/Event.cpp:
(WebCore::Event::reportMemoryUsage):
* dom/LiveNodeList.cpp:
(WebCore::LiveNodeListBase::reportMemoryUsage):
* dom/Node.cpp:
(WebCore::Node::reportMemoryUsage):
* dom/NodeRareData.cpp:
(WebCore::NodeListsNodeData::reportMemoryUsage):
(WebCore::NodeRareData::reportMemoryUsage):
* dom/QualifiedName.cpp:
(WebCore::QualifiedName::reportMemoryUsage):
(WebCore::QualifiedName::QualifiedNameImpl::reportMemoryUsage):
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::reportMemoryUsage):
* dom/SecurityContext.cpp:
(WebCore::SecurityContext::reportMemoryUsage):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::reportMemoryUsage):
* dom/TreeScope.cpp:
(WebCore::TreeScope::reportMemoryUsage):
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::reportMemoryUsage):
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::reportMemoryUsage):
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::reportMemoryUsage):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::reportMemoryUsage):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::reportMemoryUsage):
* html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::reportMemoryUsage):
* inspector/HeapGraphSerializer.cpp:
(WebCore::HeapGraphSerializer::HeapGraphSerializer):
(WebCore::HeapGraphSerializer::reportNode):
(WebCore::HeapGraphSerializer::reportMemoryUsage):
* inspector/HeapGraphSerializer.h:
(HeapGraphSerializer):
* inspector/InspectorBaseAgent.cpp:
(WebCore::InspectorBaseAgentInterface::reportMemoryUsage):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::reportMemoryUsage):
* inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::reportMemoryUsage):
* inspector/InspectorDOMStorageResource.cpp:
(WebCore::InspectorDOMStorageResource::reportMemoryUsage):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::reportMemoryUsage):
(WebCore::ScriptDebugListener::Script::reportMemoryUsage):
* inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::reportMemoryUsage):
* inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::reportMemoryUsage):
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::reportMemoryUsage):
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::reportMemoryUsage):
* inspector/MemoryInstrumentationImpl.cpp:
(WebCore::MemoryInstrumentationClientImpl::reportMemoryUsage):
(WebCore::MemoryInstrumentationImpl::reportMemoryUsage):
* inspector/NetworkResourcesData.cpp:
(WebCore::XHRReplayData::reportMemoryUsage):
(WebCore::NetworkResourcesData::ResourceData::reportMemoryUsage):
(WebCore::NetworkResourcesData::reportMemoryUsage):
* loader/CachedMetadata.cpp:
(WebCore::CachedMetadata::reportMemoryUsage):
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::reportMemoryUsage):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::reportMemoryUsage):
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::reportMemoryUsage):
* loader/Prerenderer.cpp:
(WebCore::Prerenderer::reportMemoryUsage):
* loader/ResourceBuffer.cpp:
(WebCore::ResourceBuffer::reportMemoryUsage):
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::reportMemoryUsage):
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::reportMemoryUsage):
* loader/SubstituteData.cpp:
(WebCore::SubstituteData::reportMemoryUsage):
* loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::reportMemoryUsage):
* loader/cache/CachedFont.cpp:
(WebCore::CachedFont::reportMemoryUsage):
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::reportMemoryUsage):
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::reportMemoryUsage):
* loader/cache/CachedResourceHandle.cpp:
(WebCore::CachedResourceHandleBase::reportMemoryUsage):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::reportMemoryUsage):
* loader/cache/CachedSVGDocument.cpp:
(WebCore::CachedSVGDocument::reportMemoryUsage):
* loader/cache/CachedScript.cpp:
(WebCore::CachedScript::reportMemoryUsage):
* loader/cache/CachedShader.cpp:
(WebCore::CachedShader::reportMemoryUsage):
* loader/cache/CachedXSLStyleSheet.cpp:
(WebCore::CachedXSLStyleSheet::reportMemoryUsage):
* loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::reportMemoryUsage):
* page/DOMTimer.cpp:
(WebCore::DOMTimer::reportMemoryUsage):
* page/Frame.cpp:
(WebCore::Frame::reportMemoryUsage):
* page/Page.cpp:
(WebCore::Page::reportMemoryUsage):
* platform/KURL.cpp:
(WebCore::KURL::reportMemoryUsage):
* platform/KURLGoogle.cpp:
(WebCore::KURLGooglePrivate::reportMemoryUsage):
* platform/KURLWTFURLImpl.h:
(WebCore::KURLWTFURLImpl::reportMemoryUsage):
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::reportMemoryUsage):
* platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::reportMemoryUsage):
* platform/audio/AudioArray.h:
(WebCore::AudioArray::reportMemoryUsage):
* platform/audio/FFTFrame.cpp:
(WebCore::FFTFrame::reportMemoryUsage):
* platform/audio/HRTFDatabase.cpp:
(WebCore::HRTFDatabase::reportMemoryUsage):
* platform/audio/HRTFDatabaseLoader.cpp:
(WebCore::HRTFDatabaseLoader::reportMemoryUsage):
* platform/audio/HRTFElevation.cpp:
(WebCore::HRTFElevation::reportMemoryUsage):
* platform/audio/HRTFKernel.cpp:
(WebCore::HRTFKernel::reportMemoryUsage):
* platform/audio/ffmpeg/FFTFrameFFMPEG.cpp:
(reportMemoryUsage):
* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::reportMemoryUsage):
(WebCore::FrameData::reportMemoryUsage):
* platform/graphics/CrossfadeGeneratedImage.cpp:
(WebCore::CrossfadeGeneratedImage::reportMemoryUsage):
* platform/graphics/GeneratorGeneratedImage.cpp:
(WebCore::GeneratorGeneratedImage::reportMemoryUsage):
* platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::reportMemoryUsage):
* platform/graphics/ImageBuffer.cpp:
(WebCore::ImageBuffer::reportMemoryUsage):
* platform/graphics/ImageSource.cpp:
(WebCore::ImageSource::reportMemoryUsage):
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::reportMemoryUsage):
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBufferData::reportMemoryUsage):
* platform/graphics/skia/MemoryInstrumentationSkia.cpp:
(reportMemoryUsage):
* platform/graphics/skia/NativeImageSkia.cpp:
(WebCore::NativeImageSkia::reportMemoryUsage):
* platform/image-decoders/ImageDecoder.cpp:
(WebCore::ImageFrame::reportMemoryUsage):
(WebCore):
(WebCore::ImageDecoder::reportMemoryUsage):
* platform/image-decoders/skia/ImageDecoderSkia.cpp:
(WebCore::ImageFrame::reportMemoryUsage):
* platform/network/FormData.cpp:
(WebCore::FormData::reportMemoryUsage):
(WebCore::FormDataElement::reportMemoryUsage):
* platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::reportMemoryUsageBase):
* platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::reportMemoryUsage):
* platform/network/chromium/ResourceRequest.cpp:
(WebCore::ResourceRequest::reportMemoryUsage):
* rendering/InlineBox.cpp:
(WebCore::InlineBox::reportMemoryUsage):
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::reportMemoryUsage):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::reportMemoryUsage):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::reportMemoryUsage):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::reportMemoryUsage):
* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::reportMemoryUsage):
(WebCore::RenderFrameSet::GridAxis::reportMemoryUsage):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::reportMemoryUsage):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::reportMemoryUsage):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::reportMemoryUsage):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::reportMemoryUsage):
* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::reportMemoryUsage):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::reportMemoryUsage):
* rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::reportMemoryUsage):
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::reportMemoryUsage):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::reportMemoryUsage):
(WebCore::RenderTableSection::RowStruct::reportMemoryUsage):
(WebCore::RenderTableSection::CellStruct::reportMemoryUsage):
* rendering/RenderText.cpp:
(WebCore::RenderText::reportMemoryUsage):
* rendering/RenderView.cpp:
(WebCore::RenderView::reportMemoryUsage):
* rendering/style/DataRef.h:
(WebCore::DataRef::reportMemoryUsage):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::reportMemoryUsage):
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::reportMemoryUsage):
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::reportMemoryUsage):
* svg/SVGPaint.cpp:
(WebCore::SVGPaint::reportDescendantMemoryUsage):
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::reportMemoryUsage):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::reportMemoryUsage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] visibility of embedded widget
pierre.rossi@gmail.com [Fri, 1 Feb 2013 10:40:18 +0000 (10:40 +0000)]
[Qt] visibility of embedded widget
https://bugs.webkit.org/show_bug.cgi?id=108327

Rubber-stamped by Simon Hausmann.

In overriding Widget::hide in QtPluginWidget, we forgot to call the
parent implementation, which as it turns, out does sensible stuff.

* WebCoreSupport/FrameLoaderClientQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Regions] Convert fast/regions/region-overflow-auto-overflow* to reftests
mihnea@adobe.com [Fri, 1 Feb 2013 10:37:50 +0000 (10:37 +0000)]
[CSS Regions] Convert fast/regions/region-overflow-auto-overflow* to reftests
https://bugs.webkit.org/show_bug.cgi?id=108333

Reviewed by Tony Chang.

Add reftests, cleanup existing tests.

* fast/regions/region-overflow-auto-overflow-hidden-expected.html: Added.
* fast/regions/region-overflow-auto-overflow-hidden.html:
* fast/regions/region-overflow-auto-overflow-visible-expected.html: Added.
* fast/regions/region-overflow-auto-overflow-visible.html:
* platform/chromium-linux-x86/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
* platform/chromium-linux-x86/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
* platform/chromium-linux/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
* platform/chromium-linux/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
* platform/chromium-linux/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
* platform/chromium-linux/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
* platform/chromium-mac/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
* platform/chromium-mac/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
* platform/chromium/TestExpectations:
* platform/chromium/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
* platform/chromium/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
* platform/efl/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
* platform/efl/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
* platform/efl/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
* platform/efl/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
* platform/gtk/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
* platform/gtk/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
* platform/gtk/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
* platform/gtk/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
* platform/mac-snowleopard/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
* platform/mac-snowleopard/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
* platform/mac-snowleopard/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
* platform/mac-snowleopard/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
* platform/mac/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
* platform/mac/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
* platform/qt/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
* platform/qt/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
* platform/qt/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
* platform/qt/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] visibility of embedded widget
pierre.rossi@gmail.com [Fri, 1 Feb 2013 10:35:31 +0000 (10:35 +0000)]
[Qt] visibility of embedded widget
https://bugs.webkit.org/show_bug.cgi?id=108327

Rubber-stamped by Simon Hausmann.

In overriding Widget::show in QtPluginWidget, we forgot to call the
parent implementation, which as it turns, out does sensible stuff.

* WebCoreSupport/FrameLoaderClientQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK][GStreamer] FullscreenVideoControllerGtk implementation
philn@webkit.org [Fri, 1 Feb 2013 10:25:16 +0000 (10:25 +0000)]
[GTK][GStreamer] FullscreenVideoControllerGtk implementation
https://bugs.webkit.org/show_bug.cgi?id=107398

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

NATIVE_FULLSCREEN_VIDEO support for the GTK port. The previous
FullscreenVideoController implementation was refactored as a
sub-class of FullscreenVideoControllerGStreamer and hooked in the
MediaPlayerPrivateGStreamer backend.

* GNUmakefile.list.am:
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
* platform/graphics/gtk/FullscreenVideoControllerGtk.cpp: Renamed from Source/WebKit/gtk/WebCoreSupport/FullscreenVideoController.cpp.
* platform/graphics/gtk/FullscreenVideoControllerGtk.h: Renamed from Source/WebKit/gtk/WebCoreSupport/FullscreenVideoController.h.

Source/WebKit/gtk:

Remove the FullscreenVideoController as it moved to
FullscreenVideoControllerGStreamer and its Gtk subclass in
WebCore. Hook in NATIVE_FULLSCREEN_VIDEO in the ChromeClient in
the two possible scenarios, wether FULLSCREEN_API is enabled or not.

* GNUmakefile.am: Remove FullscreenVideoController.
* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit):
(WebKit::ChromeClient::enterFullscreenForNode): Hook
NATIVE_FULLSCREEN_VIDEO support.
(WebKit::ChromeClient::exitFullscreenForNode): Ditto
(WebKit::ChromeClient::enterFullScreenForElement): Ditto
(WebKit::ChromeClient::exitFullScreenForElement): Ditto
* WebCoreSupport/ChromeClientGtk.h:
(ChromeClient):
* WebCoreSupport/FullscreenVideoController.cpp: Removed.
* WebCoreSupport/FullscreenVideoController.h: Removed.
* webkit/webkitwebview.cpp: Remove FullscreenVideoController support.
* webkit/webkitwebviewprivate.h: Ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: fix cursor location in Source Frame
commit-queue@webkit.org [Fri, 1 Feb 2013 10:11:24 +0000 (10:11 +0000)]
Web Inspector: fix cursor location in Source Frame
https://bugs.webkit.org/show_bug.cgi?id=108592

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-01
Reviewed by Pavel Feldman.

Normalize range before computing amount of lines in
_updateSourcePosition.

No new tests.

* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._updateSourcePosition): Normalize text range.
* inspector/front-end/inspector.css: Slightly bigger left padding for the text.
(.source-frame-position):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed build fix after r141553.
haraken@chromium.org [Fri, 1 Feb 2013 10:09:47 +0000 (10:09 +0000)]
Unreviewed build fix after r141553.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateImplementation):
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::V8Float64Array::HasInstance):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::V8TestActiveDOMObject::HasInstance):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::HasInstance):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::HasInstance):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::V8TestEventTarget::HasInstance):
* bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::V8TestException::HasInstance):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::HasInstance):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::HasInstance):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructor::HasInstance):
* bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::HasInstance):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::HasInstance):
* bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore::V8TestOverloadedConstructors::HasInstance):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::HasInstance):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Sources panel navigator reveal and expand fixes.
vsevik@chromium.org [Fri, 1 Feb 2013 10:07:25 +0000 (10:07 +0000)]
Web Inspector: Sources panel navigator reveal and expand fixes.
https://bugs.webkit.org/show_bug.cgi?id=108584

Reviewed by Pavel Feldman.

Navigator folders are not expanded by default anymore.
Made domain folder expanded for inspected page main frame domain.
UISourceCodes are now added to navigator before editor container
so that they could be revealed if editor container decides to show them.

* inspector/front-end/NavigatorView.js:
(WebInspector.BaseNavigatorTreeElement.prototype.onattach):
(WebInspector.NavigatorFolderTreeElement.prototype.onattach):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._addUISourceCode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] MiniBrowser segfaults on loading google.com
hausmann@webkit.org [Fri, 1 Feb 2013 10:06:06 +0000 (10:06 +0000)]
[EFL][WK2] MiniBrowser segfaults on loading google.com
https://bugs.webkit.org/show_bug.cgi?id=108597

Patch by Gwang Yoon Hwang <ryumiel@company100.net> on 2013-02-01
Reviewed by Andreas Kling.

* Platform/CoreIPC/unix/ConnectionUnix.cpp:
(CoreIPC::Connection::processMessage):
oolMessageBody should be properly initialized before it is used.

This patch also adds omitted break statement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Canvas] drop trace log in the backend when deleting profile in frontend
aandrey@chromium.org [Fri, 1 Feb 2013 09:52:10 +0000 (09:52 +0000)]
Web Inspector: [Canvas] drop trace log in the backend when deleting profile in frontend
https://bugs.webkit.org/show_bug.cgi?id=108591

Reviewed by Pavel Feldman.

Send a dropTraceLog command to the backend when deleting a profile header from the sidebar.
Before we were sending the command only upon deleting an existing view of a profile, so we  would not
sent the command if the view was not created or if a profile header was removed via context menu (the ondelete() method).
Drive-by: fixed an odd formatting of property functions.
* inspector/front-end/CanvasProfileView.js:
(WebInspector.CanvasProfileView.prototype.dispose):
(WebInspector.CanvasProfileHeader.prototype.reset):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfileHeader.prototype.reset):
(WebInspector.ProfileHeader.prototype.load):
(WebInspector.ProfileHeader.prototype.canSaveToFile):
(WebInspector.ProfileHeader.prototype.saveToFile):
(WebInspector.ProfileHeader.prototype.loadFromFile):
(WebInspector.ProfileHeader.prototype.fromFile):
(WebInspector.ProfilesPanel):
(WebInspector.ProfilesPanel.prototype._reset):
(WebInspector.ProfilesPanel.prototype._removeProfileHeader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAX: when aria-activedescendant is used with a ComboBox role, focus should not be...
cfleizach@apple.com [Fri, 1 Feb 2013 09:32:54 +0000 (09:32 +0000)]
AX: when aria-activedescendant is used with a ComboBox role, focus should not be changed
https://bugs.webkit.org/show_bug.cgi?id=108596

Reviewed by Ryosuke Niwa.

Source/WebCore:

Normally, an aria-activedescendant change causes a focus change to be triggered.
However, when used in conjunction with a combo box, this causes problems for screen readers.
Namely, the user expects focus to remain in the text field so that the user can keep typing.
If focus moves to an item in the combobox list, it is not possible to keep typing.

The solution is to not trigger a focus change in this case and instead use a selected children change notification.

Test: platform/mac/accessibility/combobox-activedescendant-notifications.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::shouldNotifyActiveDescendant):
(WebCore::AccessibilityRenderObject::shouldFocusActiveDescendant):
(WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
* accessibility/AccessibilityRenderObject.h:
(AccessibilityRenderObject):
* accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postPlatformNotification):

LayoutTests:

* platform/mac/accessibility/combobox-activedescendant-notifications-expected.txt: Added.
* platform/mac/accessibility/combobox-activedescendant-notifications.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: [Mac] REGRESSION(r140974): accessibility/lists.html fails on Lion=
cfleizach@apple.com [Fri, 1 Feb 2013 09:17:02 +0000 (09:17 +0000)]
Source/WebCore: [Mac] REGRESSION(r140974): accessibility/lists.html fails on Lion=
https://bugs.webkit.org/show_bug.cgi?id=108291

Reviewed by Ryosuke Niwa.

This accounts for differences in what AppKit gives for accessibility role descriptions between platforms
when the subrole is not recognized, and standardizes it for WebKit.

Unskip a failing Lion test

* accessibility/mac/WebAccessibilityObjectWrapper.mm:
(-[WebAccessibilityObjectWrapper roleDescription]):

LayoutTests: [Mac] REGRESSION(r140974): accessibility/lists.html fails on Lion
https://bugs.webkit.org/show_bug.cgi?id=108291

Reviewed by Ryosuke Niwa.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Replace localeCompare in NavigatorView with compareTo.
vsevik@chromium.org [Fri, 1 Feb 2013 09:06:29 +0000 (09:06 +0000)]
Web Inspector: Replace localeCompare in NavigatorView with compareTo.
https://bugs.webkit.org/show_bug.cgi?id=108585

Reviewed by Pavel Feldman.

Replaced String.prototype.localeCompare with String.prototype.compareTo
in NavigatorView to improve performance.

* inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorTreeOutline._treeElementsCompare):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: File system pending requests list is not cleared after processing.
vsevik@chromium.org [Fri, 1 Feb 2013 08:57:15 +0000 (08:57 +0000)]
Web Inspector: File system pending requests list is not cleared after processing.
https://bugs.webkit.org/show_bug.cgi?id=108573

Reviewed by Pavel Feldman.

* inspector/front-end/IsolatedFileSystemModel.js:
(WebInspector.IsolatedFileSystemModel.prototype._processPendingFileSystemRequests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDubious cast from HTMLCollection to HTMLAllCollection
tsepez@chromium.org [Fri, 1 Feb 2013 08:52:01 +0000 (08:52 +0000)]
Dubious cast from HTMLCollection to HTMLAllCollection
https://bugs.webkit.org/show_bug.cgi?id=108538

Reviewed by Adam Barth.

Patch is tested by enabling V8 binding integrity on HTMLAllCollection and
running the existing tests without introducing new crashes.

* dom/Document.cpp:
(WebCore::Document::all):
Pass correct type to template.

* html/HTMLAllCollection.cpp:
(WebCore::HTMLAllCollection::create):
(WebCore::HTMLAllCollection::HTMLAllCollection):
* html/HTMLAllCollection.h:
(HTMLAllCollection):
Make create() method arguments compatible with template above.

* html/HTMLAllCollection.idl:
Enable binding integrity.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Add support for handling modal dialogs
commit-queue@webkit.org [Fri, 1 Feb 2013 08:50:19 +0000 (08:50 +0000)]
Web Inspector: Add support for handling modal dialogs
https://bugs.webkit.org/show_bug.cgi?id=107883

Patch by Ken Kania <kkania@chromium.org> on 2013-02-01
Reviewed by Pavel Feldman.

Introduce support for being notified when a JavaScript modal dialog
is opening and closing, as well as a new command for accepting or
dismissing the dialog.

Source/WebCore:

Test: inspector-protocol/page/willRunJavaScriptDialog.html

* inspector/Inspector.json:
* inspector/InspectorClient.h:
(WebCore::InspectorClient::handleJavaScriptDialog):
(InspectorClient):
* inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::willRunJavaScriptDialogImpl):
(WebCore::InspectorInstrumentation::didRunJavaScriptDialogImpl):
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willRunJavaScriptDialog):
(WebCore):
(WebCore::InspectorInstrumentation::didRunJavaScriptDialog):
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::willRunJavaScriptDialog):
(WebCore):
(WebCore::InspectorPageAgent::didRunJavaScriptDialog):
(WebCore::InspectorPageAgent::handleJavaScriptDialog):
* inspector/InspectorPageAgent.h:
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.PageDispatcher.prototype.frameStartedLoading):
(WebInspector.PageDispatcher.prototype.frameStoppedLoading):
(WebInspector.PageDispatcher.prototype.frameScheduledNavigation):
(WebInspector.PageDispatcher.prototype.frameClearedScheduledNavigation):
(WebInspector.PageDispatcher.prototype.javascriptDialogOpening):
(WebInspector.PageDispatcher.prototype.javascriptDialogClosed):
* page/Chrome.cpp:
(WebCore::Chrome::runBeforeUnloadConfirmPanel):
(WebCore::Chrome::runJavaScriptAlert):
(WebCore::Chrome::runJavaScriptConfirm):
(WebCore::Chrome::runJavaScriptPrompt):

Source/WebKit/chromium:

* public/WebDevToolsAgent.h:
* src/InspectorClientImpl.cpp:
(WebKit::InspectorClientImpl::handleJavaScriptDialog):
(WebKit):
* src/InspectorClientImpl.h:
(InspectorClientImpl):
* src/WebDevToolsAgentImpl.cpp:
(BrowserDataHintStringValues):
(WebKit::WebDevToolsAgentImpl::captureScreenshot):
(WebKit::WebDevToolsAgentImpl::handleJavaScriptDialog):
(WebKit):
(WebKit::browserHintToString):
(WebKit::browserHintFromString):
(WebKit::WebDevToolsAgent::patchWithBrowserData):
* src/WebDevToolsAgentImpl.h:
(WebDevToolsAgentImpl):

LayoutTests:

* inspector-protocol/page/javascriptDialogEvents-expected.txt: Added.
* inspector-protocol/page/javascriptDialogEvents.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTouch disambiguation blacklist is not being queried properly
commit-queue@webkit.org [Fri, 1 Feb 2013 08:48:05 +0000 (08:48 +0000)]
Touch disambiguation blacklist is not being queried properly
https://bugs.webkit.org/show_bug.cgi?id=108222

Patch by Dan Alcantara <dfalcantara@chromium.org> on 2013-02-01
Reviewed by Adam Barth.

TEST=WebFrameTest::DisambiguationPopupBlacklist

Source/WebCore:

Fix the blacklist so that we check it for the right nodes.
Add a chromium test to check that the blacklist is being built and used
correctly.  Also update the other DisambiguationPopup tests to
use the new page scale method.

* page/TouchDisambiguation.cpp:
(WebCore::findGoodTouchTargets):

Source/WebKit/chromium:

Fix the blacklist so that we check it for the right nodes.
Add a test to check that the blacklist is being built and used
correctly.  Also update the other DisambiguationPopup tests to
use the new page scale method.

* tests/WebFrameTest.cpp:
* tests/data/disambiguation_popup_blacklist.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Add a temporary optional Isolate parameter to HasInstance()
haraken@chromium.org [Fri, 1 Feb 2013 08:45:57 +0000 (08:45 +0000)]
[V8] Add a temporary optional Isolate parameter to HasInstance()
https://bugs.webkit.org/show_bug.cgi?id=108567

Reviewed by Adam Barth.

The optional Isolate parameter will be removed once all call sites have an Isolate.
It will require several patches.

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateNormalAttrSetter):
(GenerateParametersCheckExpression):
(GenerateParametersCheck):
(GenerateImplementation):
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::V8Float64Array::HasInstance):
* bindings/scripts/test/V8/V8Float64Array.h:
(V8Float64Array):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::V8TestActiveDOMObject::HasInstance):
* bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(V8TestActiveDOMObject):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::HasInstance):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(V8TestCustomNamedGetter):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::HasInstance):
* bindings/scripts/test/V8/V8TestEventConstructor.h:
(V8TestEventConstructor):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::V8TestEventTarget::HasInstance):
* bindings/scripts/test/V8/V8TestEventTarget.h:
(V8TestEventTarget):
* bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::V8TestException::HasInstance):
* bindings/scripts/test/V8/V8TestException.h:
(V8TestException):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::HasInstance):
* bindings/scripts/test/V8/V8TestInterface.h:
(V8TestInterface):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::HasInstance):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(V8TestMediaQueryListListener):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructor::HasInstance):
* bindings/scripts/test/V8/V8TestNamedConstructor.h:
(V8TestNamedConstructor):
* bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::HasInstance):
* bindings/scripts/test/V8/V8TestNode.h:
(V8TestNode):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::overloadedMethodCallback):
(WebCore::TestObjV8Internal::variadicNodeMethodCallback):
(WebCore::V8TestObj::HasInstance):
* bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):
* bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore::V8TestOverloadedConstructors::constructorCallback):
(WebCore::V8TestOverloadedConstructors::HasInstance):
* bindings/scripts/test/V8/V8TestOverloadedConstructors.h:
(V8TestOverloadedConstructors):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::HasInstance):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(V8TestSerializedScriptValueInterface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed, marking table-section-overflow-clip-crash.html failed.
morrita@google.com [Fri, 1 Feb 2013 08:44:31 +0000 (08:44 +0000)]
[Chromium] Unreviewed, marking table-section-overflow-clip-crash.html failed.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CPP,GObject,ObjC] Add 'static' skip to CodeGenerator{CPP,GObject,ObjC}.pm
commit-queue@webkit.org [Fri, 1 Feb 2013 08:44:24 +0000 (08:44 +0000)]
[CPP,GObject,ObjC] Add 'static' skip to CodeGenerator{CPP,GObject,ObjC}.pm
https://bugs.webkit.org/show_bug.cgi?id=108578

Patch by Nils Barth <nbarth@google.com> on 2013-02-01
Reviewed by Kentaro Hara.

Since CPP/GObject/ObjC code generators (CodeGenerator{CPP,GObject,ObjC}.pm)
do not support static attributes, add test to skip these.
This lets us remove #if macro from static in test files and not need
these in future.

Test: bindings/scripts/test/TestObj.idl (run-bindings-test)
Test: bindings/scripts/test/TestSupplemental.idl (run-bindings-test)

* bindings/scripts/CodeGeneratorCPP.pm:
(SkipAttribute):
* bindings/scripts/CodeGeneratorGObject.pm:
(SkipAttribute):
* bindings/scripts/CodeGeneratorObjC.pm:
(SkipAttribute):
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/TestSupplemental.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] only show checkboxes for FPS meter and continuous painting when compositin...
commit-queue@webkit.org [Fri, 1 Feb 2013 08:37:10 +0000 (08:37 +0000)]
[chromium] only show checkboxes for FPS meter and continuous painting when compositing mode is forced
https://bugs.webkit.org/show_bug.cgi?id=108236

Patch by Eberhard Graether <egraether@google.com> on 2013-02-01
Reviewed by Pavel Feldman.

This change hides the checkboxes for FPS meter and continuous painting if compositing mode is not forced.
This way the checkboxes only show up for users that can make use of these features.

* src/InspectorClientImpl.cpp:
(WebKit::InspectorClientImpl::canShowFPSCounter):
(WebKit::InspectorClientImpl::canContinuouslyPaint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rebaselining a result.
morrita@google.com [Fri, 1 Feb 2013 08:30:09 +0000 (08:30 +0000)]
Unreviewed, rebaselining a result.

* platform/chromium/fast/js/kde/inbuilt_function_tostring-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Remove V8GCController::m_edenNodes
haraken@chromium.org [Fri, 1 Feb 2013 08:27:10 +0000 (08:27 +0000)]
[V8] Remove V8GCController::m_edenNodes
https://bugs.webkit.org/show_bug.cgi?id=108579

Reviewed by Adam Barth.

Currently V8GCController::m_edenNodes stores a list of nodes whose
wrappers have been created since the latest GC. The reason why we
needed m_edenNodes is that there was no way to know a list of wrappers
in the new space of V8. By using m_edenNodes, we had been approximating
'wrappers in the new space' by 'wrappers that have been created since
the latest GC'.

Now V8 provides VisitHandlesForPartialDependence(), with which WebKit
can know a list of wrappers in the new space. By using the API, we can
remove V8GCController::m_edenNodes. The benefit is that (1) we no longer
need to keep m_edenNodes and that (2) it enables more precise minor
DOM GC (Remember that m_edenNodes was just an approximation).

Performance benchmark: https://bugs.webkit.org/attachment.cgi?id=185940
The benchmark runs 300 iterations, each of which creates 100000 elements.
The benchmark measures average, min, median, max and stdev of execution times
of the 300 iterations. This will tell us the worst-case overhead of this change.

Before:
  mean=59.91ms, min=39ms, median=42ms, max=258ms, stdev=47.48ms

After:
  mean=58.75ms, min=35ms, median=41ms, max=250ms, stdev=47.32ms

As shown above, I couldn't observe any performance regression.

No tests. No change in behavior.

* bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::setWrapperInObject):
* bindings/v8/V8GCController.cpp:
(WebCore::gcTree):
(WebCore):
(MinorGCWrapperVisitor):
(WebCore::MinorGCWrapperVisitor::notifyFinished):
(WebCore::V8GCController::gcPrologue):
(WebCore::V8GCController::minorGCPrologue):
(WebCore::V8GCController::majorGCPrologue):
* bindings/v8/V8GCController.h:
(V8GCController):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Use String.prototype.startsWith instead of String.prototype.indexOf...
vsevik@chromium.org [Fri, 1 Feb 2013 08:19:35 +0000 (08:19 +0000)]
Web Inspector: Use String.prototype.startsWith instead of String.prototype.indexOf when possible
https://bugs.webkit.org/show_bug.cgi?id=108575

Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/front-end/FileMapping.js:
(WebInspector.FileMapping.prototype._entryMatchesURL):
(WebInspector.FileMapping.prototype.urlForURI):
* inspector/front-end/FileSystemMapping.js:
(get WebInspector.FileSystemMappingImpl.prototype.fileForURI):
(get WebInspector.FileSystemMappingImpl.prototype.uriForPath):

LayoutTests:

* http/tests/inspector/console-cd-completions.html:
* http/tests/inspector/console-cd.html:
* http/tests/inspector/indexeddb/indexeddb-test.js:
(initialize_IndexedDBTest.InspectorTest._installIndexedDBSniffer.consoleMessageOverride):
(initialize_IndexedDBTest.InspectorTest._installIndexedDBSniffer):
* inspector/network-status-non-http.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Add MessageFlags.h in Target.pri
commit-queue@webkit.org [Fri, 1 Feb 2013 08:02:07 +0000 (08:02 +0000)]
[Qt] Add MessageFlags.h in Target.pri
https://bugs.webkit.org/show_bug.cgi?id=108583

Patch by Jae Hyun Park <jae.park@company100.net> on 2013-01-31
Reviewed by Kentaro Hara.

Since MessageDecoder and MessageEncoder include MessageFlags.h, it
should be included in Target.pri.

* Target.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEditor::m_compositionNode not updated on HTMLInputElement::setValue()
commit-queue@webkit.org [Fri, 1 Feb 2013 07:43:13 +0000 (07:43 +0000)]
Editor::m_compositionNode not updated on HTMLInputElement::setValue()
https://bugs.webkit.org/show_bug.cgi?id=107737

Patch by Aurimas Liutikas <aurimas@chromium.org> on 2013-01-31
Reviewed by Ryosuke Niwa.

Source/WebCore:

Chromium has a bug where the IME composition did not get cancelled on JavaScript changes
to the focused editing field. Most of other WebKit ports were already doing this check
in their EditorClient::respondToChangedSelection. I took that logic and moved it to the
Editor so every port and use the same code.

An existing test editing/input/setting-input-value-cancel-ime-composition.html covers this change.
This test used to have an expectation to fail on Chromium and after this patch it will start passing.

* editing/Editor.cpp:
(WebCore::Editor::cancelCompositionIfSelectionIsInvalid):
    Adding a call that can be used by any the port to cancel the composition if it's no longer valid.
(WebCore):
* editing/Editor.h:
(Editor):

Source/WebKit/chromium:

* public/WebViewClient.h:
(WebKit::WebViewClient::didCancelCompositionOnSelectionChange):
    Adding a callback to let the WebViewClient know that the composition has been cancelled.
* src/EditorClientImpl.cpp:
(WebKit::EditorClientImpl::respondToChangedSelection):
    Adding a call composition if it is no longer valid.

Source/WebKit/efl:

* WebCoreSupport/EditorClientEfl.cpp:
(WebCore::EditorClientEfl::respondToChangedSelection):
    Adding a call to the newly refactored method.

Source/WebKit/gtk:

* WebCoreSupport/EditorClientGtk.cpp:
(WebKit::EditorClient::respondToChangedSelection):
    Adding a call to the newly refactored Editor method.

Source/WebKit/mac:

* WebView/WebHTMLView.mm:
(-[WebHTMLView _updateSelectionForInputManager]):

Source/WebKit/win:

* WebView.cpp:
(WebView::updateSelectionForIME):
    Adding a call to the newly refactored method.

LayoutTests:

* platform/chromium/TestExpectations: Removed fail expectation for the editing/input/setting-input-value-cancel-ime-composition.html since this patch fixes the bug https://bugs.webkit.org/show_bug.cgi?id=55560

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDFG::CFGSimplificationPhase::keepOperandAlive() conflates liveness and availability
fpizlo@apple.com [Fri, 1 Feb 2013 07:40:31 +0000 (07:40 +0000)]
DFG::CFGSimplificationPhase::keepOperandAlive() conflates liveness and availability
https://bugs.webkit.org/show_bug.cgi?id=108580

Reviewed by Oliver Hunt.

This is a harmless bug in that it only results in us keeping a bit too many things
for OSR.  But it's worth fixing so that the code is consistent.

keepOperandAlive() is called when block A has a branch to blocks B and C, but the
A->B edge is proven to never be taken and we want to optimize the code to have A
unconditionally jump to C.  In that case, for the purposes of OSR, we need to
preserve the knowledge that the state that B expected to be live incoming from A
ought still to be live up to the point of where the A->B,C branch used to be.  The
way we keep things alive is by using the variablesAtTail of A (i.e., we use the
knowledge of in what manner A made state available to B and C).  The way we choose
which state should be kept alive ought to be chosen by the variablesAtHead of B
(i.e. the things B says it needs from its predecessors, including A), except that
keepOperandAlive() was previously just using variablesAtTail of A for this
purpose.

The fix is to have keepOperandAlive() use both liveness and availability in its
logic. It should use liveness (i.e. B->variablesAtHead) to decide what to keep
alive, and it should use availability (i.e. A->variablesAtTail) to decide how to
keep it alive.

This might be a microscopic win on some programs, but it's mainly intended to be
a code clean-up so that I don't end up scratching my head in confusion the next
time I look at this code.

* dfg/DFGCFGSimplificationPhase.cpp:
(JSC::DFG::CFGSimplificationPhase::keepOperandAlive):
(JSC::DFG::CFGSimplificationPhase::jettisonBlock):
(JSC::DFG::CFGSimplificationPhase::mergeBlocks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCoordinated Graphics : Move CoordinatedGraphics related files to WebCore
commit-queue@webkit.org [Fri, 1 Feb 2013 07:32:26 +0000 (07:32 +0000)]
Coordinated Graphics : Move CoordinatedGraphics related files to WebCore
https://bugs.webkit.org/show_bug.cgi?id=108149

Patch by Jae Hyun Park <jae.park@company100.net> on 2013-01-31
Reviewed by Noam Rosenthal.

This patch moves Coordinated Graphics related code to WebCore. To
implement Threaded Coordinated Graphics, most of Coordianted Graphics
code should be shared. Therefore, they should reside in WebCore instead of
WebKit2.

When moving to WebCore, two renamings have been done.

1. Rename LayerTreeRenderer to CoordinatedGraphicsScene.

2. Rename WebCustomFilterProgram and WebCustomFilterOperation to
CoordinatedCustomFilterProgram and CoordinatedCustomFilterOperation,
respectively.

No new tests, covered by existing tests.

Source/WebCore:

* CMakeLists.txt:
* Target.pri:
* platform/graphics/texmap/GraphicsLayerTextureMapper.h:
* platform/graphics/texmap/coordinated/AreaAllocator.cpp: Renamed from Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/AreaAllocator.cpp.
* platform/graphics/texmap/coordinated/AreaAllocator.h: Renamed from Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/AreaAllocator.h.
* platform/graphics/texmap/coordinated/CoordinatedBackingStore.cpp: Renamed from Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp.
* platform/graphics/texmap/coordinated/CoordinatedBackingStore.h: Renamed from Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedBackingStore.h.
* platform/graphics/texmap/coordinated/CoordinatedCustomFilterOperation.h: Renamed from Source/WebKit2/Shared/CoordinatedGraphics/WebCustomFilterOperation.h.
* platform/graphics/texmap/coordinated/CoordinatedCustomFilterProgram.h: Renamed from Source/WebKit2/Shared/CoordinatedGraphics/WebCustomFilterProgram.h.
* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp: Renamed from Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp.
* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h: Renamed from Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h.
* platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp: Renamed from Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp.
* platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h: Renamed from Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeRenderer.h.
* platform/graphics/texmap/coordinated/CoordinatedImageBacking.cpp: Renamed from Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedImageBacking.cpp.
* platform/graphics/texmap/coordinated/CoordinatedImageBacking.h: Renamed from Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedImageBacking.h.
* platform/graphics/texmap/coordinated/CoordinatedLayerInfo.h: Renamed from Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedLayerInfo.h.
* platform/graphics/texmap/coordinated/CoordinatedSurface.cpp: Renamed from Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedSurface.cpp.
* platform/graphics/texmap/coordinated/CoordinatedSurface.h: Renamed from Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedSurface.h.
* platform/graphics/texmap/coordinated/CoordinatedTile.cpp: Renamed from Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedTile.cpp.
* platform/graphics/texmap/coordinated/CoordinatedTile.h: Renamed from Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedTile.h.
* platform/graphics/texmap/coordinated/SurfaceUpdateInfo.h: Renamed from Source/WebKit2/Shared/CoordinatedGraphics/SurfaceUpdateInfo.h.
* platform/graphics/texmap/coordinated/UpdateAtlas.cpp: Renamed from Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.cpp.
* platform/graphics/texmap/coordinated/UpdateAtlas.h: Renamed from Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.h.

Source/WebKit2:

* CMakeLists.txt:
* Scripts/webkit2/messages.py:
* Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
* Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h:
* Shared/CoordinatedGraphics/WebCoordinatedSurface.h:
* Target.pri:
* UIProcess/API/efl/EwkView.cpp:
* UIProcess/API/efl/EwkView.h:
* UIProcess/API/qt/qquickwebpage.cpp:
* UIProcess/API/qt/raw/qrawwebview.cpp:
* UIProcess/API/qt/raw/qrawwebview_p.h:
* UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:
* UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
* UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.messages.in:
* UIProcess/efl/PageClientBase.cpp:
* UIProcess/efl/PageViewportControllerClientEfl.cpp:
* UIProcess/qt/QtWebPageSGNode.cpp:
* UIProcess/qt/QtWebPageSGNode.h:
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Add support for text decoration "wavy" style
commit-queue@webkit.org [Fri, 1 Feb 2013 07:26:02 +0000 (07:26 +0000)]
[Qt] Add support for text decoration "wavy" style
https://bugs.webkit.org/show_bug.cgi?id=93507

Patch by Lamarque V. Souza <Lamarque.Souza@basyskom.com> on 2013-01-31
Reviewed by Simon Hausmann.

Source/WebCore:

Add support for text decoration "wavy" style for Qt platform.

* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::toQPenStyle):
Remove FIXME comments obsoleted by this patch.
(WebCore::GraphicsContext::drawLine):
Implement wavy style line tracer.

LayoutTests:

Add pixel-test expected results for CSS3 text decoration tests for Qt port.

* platform/qt-5.0-wk1/fast/css3-text/css3-text-decoration/repaint/repaint-text-decoration-style-expected.png: Added.
* platform/qt-5.0-wk1/fast/css3-text/css3-text-decoration/text-decoration-style-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CPP,GObject,ObjC] Add 'enum' skip to CodeGenerator{CPP,GObject,ObjC}.pm
commit-queue@webkit.org [Fri, 1 Feb 2013 07:07:33 +0000 (07:07 +0000)]
[CPP,GObject,ObjC] Add 'enum' skip to CodeGenerator{CPP,GObject,ObjC}.pm
https://bugs.webkit.org/show_bug.cgi?id=108565

Patch by Nils Barth <nbarth@google.com> on 2013-01-31
Reviewed by Kentaro Hara.

Since legacy code generators (CodeGenerator{CPP,GObject,ObjC}.pm)
do not support enumerations, add test to skip attributes of enum type.
This lets us remove #if macro from enum in test file and not need
these in future.
Also minor associated code cleaning:
  auxiliary variable: $type = $attribute->signature->type.

Test: bindings/scripts/test/TestObj.idl (run-bindings-test)

* bindings/scripts/CodeGeneratorCPP.pm:
(SkipAttribute):
* bindings/scripts/CodeGeneratorGObject.pm:
(SkipAttribute):
* bindings/scripts/CodeGeneratorObjC.pm:
(SkipAttribute):
* bindings/scripts/test/TestObj.idl: remove #if macro

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] WebViewTest.SetCompositionFromExistingText failing after r141479
commit-queue@webkit.org [Fri, 1 Feb 2013 06:56:01 +0000 (06:56 +0000)]
[Chromium] WebViewTest.SetCompositionFromExistingText failing after r141479
https://bugs.webkit.org/show_bug.cgi?id=108543

Patch by Aurimas Liutikas <aurimas@chromium.org> on 2013-01-31
Reviewed by Ryosuke Niwa.

Fixing a bug that was uncovered after fixing http://trac.webkit.org/changeset/141479

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setCompositionFromExistingText):
* tests/WebViewTest.cpp:
    Re-enabling the test

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Native Memory Instrumentation: replace nodeName argument with className
loislo@chromium.org [Fri, 1 Feb 2013 06:52:09 +0000 (06:52 +0000)]
Web Inspector: Native Memory Instrumentation: replace nodeName argument with className
https://bugs.webkit.org/show_bug.cgi?id=107278

Reviewed by Yury Semikhatsky.

I replaced nodeName with className because we newer report node name for private and raw buffers
but need to report their class names.

* wtf/MemoryInstrumentation.cpp:
(WTF::MemoryInstrumentation::reportLinkToBuffer):
(WTF::MemoryClassInfo::addRawBuffer):
(WTF::MemoryClassInfo::addPrivateBuffer):
* wtf/MemoryInstrumentation.h:
(WTF::MemoryInstrumentation::addRawBuffer):
(MemoryClassInfo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, followup fix for r141535.
morrita@google.com [Fri, 1 Feb 2013 06:36:02 +0000 (06:36 +0000)]
Unreviewed, followup fix for r141535.

* tests/WebFrameTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled Chromium DEPS to r180023. Requested by
commit-queue@webkit.org [Fri, 1 Feb 2013 06:28:28 +0000 (06:28 +0000)]
Unreviewed.  Rolled Chromium DEPS to r180023.  Requested by
thakis_ via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-31

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r141192): Crash beneath cti_op_get_by_id_generic @ discussions.apple.com
ggaren@apple.com [Fri, 1 Feb 2013 05:54:04 +0000 (05:54 +0000)]
REGRESSION (r141192): Crash beneath cti_op_get_by_id_generic @ discussions.apple.com
https://bugs.webkit.org/show_bug.cgi?id=108576

Reviewed by Filip Pizlo.

This was a long-standing bug. The DFG would destructively reuse a register
in op_convert_this, but:

    * The bug only presented during speculation failure for type Other

    * The bug presented by removing the low bits of a pointer, which
    used to be harmless, since all objects were so aligned anyway.

* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile): Don't reuse our this register as
our scratch register. The whole point of our scratch register is to
avoid destructively modifying our this register. I'm pretty sure this
was a copy-paste error.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, disabling failing test.
morrita@google.com [Fri, 1 Feb 2013 05:37:58 +0000 (05:37 +0000)]
Unreviewed, disabling failing test.

* tests/WebFrameTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoProvide a sensible default architecture when building on iOS SDKs
commit-queue@webkit.org [Fri, 1 Feb 2013 05:01:35 +0000 (05:01 +0000)]
Provide a sensible default architecture when building on iOS SDKs
https://bugs.webkit.org/show_bug.cgi?id=108395

Patch by David Farler <dfarler@apple.com> on 2013-01-31
Reviewed by Anders Carlsson.

* Scripts/webkitdirs.pm:
(determineArchitecture): Anchor SDK regex matches at the beginning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRefactoring: Remove the default argument value for Node::setFocus
tkent@chromium.org [Fri, 1 Feb 2013 04:25:42 +0000 (04:25 +0000)]
Refactoring: Remove the default argument value for Node::setFocus
https://bugs.webkit.org/show_bug.cgi?id=108554

Reviewed by Kentaro Hara.

There is no code to use the default argument.
No new tests. Just a refactoring.

* dom/Node.h: Remove default argument value for setFocus.
* dom/ContainerNode.h:
(ContainerNode): Ditto.
* html/HTMLAreaElement.h:
(HTMLAreaElement): Add OVERRIDE to setFocus.
* html/HTMLFrameElementBase.h:
(HTMLFrameElementBase): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed, rebaselining expectations.
morrita@google.com [Fri, 1 Feb 2013 04:20:01 +0000 (04:20 +0000)]
[Chromium] Unreviewed, rebaselining expectations.

* platform/chromium-mac/platform/chromium/rubberbanding/event-overhang-e-expected.txt: Added.
* platform/chromium-mac/platform/chromium/rubberbanding/event-overhang-n-expected.txt: Added.
* platform/chromium-mac/platform/chromium/rubberbanding/event-overhang-s-expected.txt: Added.
* platform/chromium-mac/platform/chromium/rubberbanding/event-overhang-w-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Track] Closed Caption button shouldn't be visible if all the track resources have...
vcarbune@chromium.org [Fri, 1 Feb 2013 04:03:04 +0000 (04:03 +0000)]
[Track] Closed Caption button shouldn't be visible if all the track resources have failed loading
https://bugs.webkit.org/show_bug.cgi?id=106285

Reviewed by Eric Carlson.

Source/WebCore:

Updated existing test cases.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::textTracksAreReady): Checked whether there are tracks not loaded
when the algorithm began.
(WebCore::HTMLMediaElement::textTrackReadyStateChanged): If the ready state changed to
FailedToLoad the media controls should check whether there are other caption tracks
and hide the button if not.
(WebCore::HTMLMediaElement::didAddTrack): Added trigger to closedCaptionsTrackChanged.
(WebCore::HTMLMediaElement::hasClosedCaptions): Updated check to skip tracks that
failed to load.
* html/shadow/MediaControls.cpp:
(WebCore::MediaControls::reset): Used the newly added method.
(WebCore::MediaControls::refreshClosedCaptionsButtonVisibility): Added container method for
default behaviour for refreshing the visibility of the caption button.
(WebCore::MediaControls::closedCaptionTracksChanged): Used the newly added method.
(WebCore):
* html/shadow/MediaControls.h:
(MediaControls):

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::textTracksAreReady):
(WebCore::HTMLMediaElement::textTrackReadyStateChanged):
(WebCore::HTMLMediaElement::setReadyState):
(WebCore::HTMLMediaElement::didAddTrack):
(WebCore::HTMLMediaElement::hasClosedCaptions):
* html/shadow/MediaControls.cpp:
(WebCore::MediaControls::reset):
(WebCore::MediaControls::refreshClosedCaptionsButtonVisibility):
(WebCore::MediaControls::closedCaptionTracksChanged):
(WebCore):
* html/shadow/MediaControls.h:
(MediaControls):

LayoutTests:

Updated tests to include improved behavior.

* media/video-controls-captions-expected.txt: Updated.
* media/video-controls-captions.html: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agobuildbot should not rely on webkitpy
rniwa@webkit.org [Fri, 1 Feb 2013 04:01:57 +0000 (04:01 +0000)]
buildbot should not rely on webkitpy
https://bugs.webkit.org/show_bug.cgi?id=107379

Reviewed by Eric Seidel.

Move all Python files used in buildbot configuration into BuildSlaveSupport directory.
Once this patch is landed, we can stop restarting the master on webkitpy changes.

* BuildSlaveSupport/build.webkit.org-config/committer_auth.py:
* BuildSlaveSupport/build.webkit.org-config/htdigestparser.py: Copied from Tools/Scripts/webkitpy/common/net/htdigestparser.py.
* BuildSlaveSupport/build.webkit.org-config/htdigestparser_unittest.py: Copied from Tools/Scripts/webkitpy/common/net/htdigestparser_unittest.py.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
* BuildSlaveSupport/build.webkit.org-config/wkbuild.py: Copied from Tools/Scripts/webkitpy/common/config/build.py.
* BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py: Copied from Tools/Scripts/webkitpy/common/config/build_unittest.py.
(ShouldBuildTest.test_should_build):
* Scripts/webkitpy/common/config/build.py: Removed.
* Scripts/webkitpy/common/config/build_unittest.py: Removed.
* Scripts/webkitpy/common/net/htdigestparser.py: Removed.
* Scripts/webkitpy/common/net/htdigestparser_unittest.py: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r140231): media track layout tests crashing
commit-queue@webkit.org [Fri, 1 Feb 2013 03:57:37 +0000 (03:57 +0000)]
REGRESSION(r140231): media track layout tests crashing
https://bugs.webkit.org/show_bug.cgi?id=107579

Patch by Dima Gorbik <dgorbik@apple.com> on 2013-01-31
Reviewed by Eric Carlson.

Source/WebCore:

We were using non-standard element names with HTMLElement, which made v8 try to cast
WebVTTElements to HTMLUnknownElements which was not possible. Subclassing Element instead
of HTMLElement, though this requires building HTMLElements from WebVTTElements for creating
a DOM tree. The code has been refactored to move WebVTT node type to QuialifiedName mappings
inside the WebVTTElement class. All WebVTTElements in the shadow dom tree now are in the
namespace defined by 'NullAtom'. This prevents regular styles from being applied to <b>, <i>
and similar tags. Those have to be styled separately without reusing existing QualifiedNames
and their styles. https://bugs.webkit.org/show_bug.cgi?id=107214

Unskipping tests to cover this.

* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRules):
(WebCore::StyleResolver::canShareStyleWithElement):
* html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::copyWebVTTNodeToDOMTree):
(WebCore::TextTrackCue::getCueAsHTML):
(WebCore::TextTrackCue::createCueRenderingTree):
(WebCore::TextTrackCue::markFutureAndPastNodes):
* html/track/TextTrackCue.h:
(WebCore::TextTrackCue::cueShadowPseudoId):
* html/track/WebVTTElement.cpp:
(WebCore::nodeTypeToTagName): get a QualifiedName to use in the shadow DOM tree.
(WebCore::WebVTTElement::WebVTTElement):
(WebCore::WebVTTElement::create):
(WebCore::WebVTTElement::cloneElementWithoutAttributesAndChildren):
(WebCore::WebVTTElement::createEquivalentHTMLElement): create an HTMLElement to use in the DOM tree.
* html/track/WebVTTElement.h:
(WebCore::WebVTTElement::setWebVTTNodeType):
(WebCore::WebVTTElement::webVTTNodeType):
(WebCore::WebVTTElement::isPastNode):
(WebCore::WebVTTElement::setIsPastNode):
(WebCore::WebVTTElement::voiceAttributeName):
* html/track/WebVTTParser.cpp:
(WebCore::tokenToNodeType): determine a WebVTT node type for the token.
(WebCore::WebVTTParser::constructTreeFromToken):

LayoutTests:

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Another attempt to fix build after recent WebKit2 changes
rafael.lobo@openbossa.org [Fri, 1 Feb 2013 03:52:13 +0000 (03:52 +0000)]
[Qt][WK2] Another attempt to fix build after recent WebKit2 changes
https://bugs.webkit.org/show_bug.cgi?id=108548

Reviewed by Anders Carlsson.

* Platform/CoreIPC/unix/ConnectionUnix.cpp:
(CoreIPC::Connection::platformInvalidate):
(CoreIPC::Connection::processMessage): Change Deque to Vector and do similar
logic as on patch for https://bugs.webkit.org/show_bug.cgi?id=108517
(CoreIPC::Connection::open):
(CoreIPC::Connection::setShouldCloseConnectionOnProcessTermination):
* Platform/qt/WorkQueueQt.cpp: Reflect changes on Qt WorkQueue to increase ref
count when the execution is started and decrease it when the work item is deleted,
following the logic on https://bugs.webkit.org/show_bug.cgi?id=108544
(WorkQueue::WorkItemQt::~WorkItemQt):
(WorkQueue::WorkItemQt::execute):
(WorkQueue::dispatch):
(WorkQueue::dispatchAfterDelay):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::getPluginPath): This function was moved from WebProcessProxy but
mac specific code was not protected properly: https://bugs.webkit.org/show_bug.cgi?id=108407

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed, marking a failing test.
morrita@google.com [Fri, 1 Feb 2013 03:51:12 +0000 (03:51 +0000)]
[Chromium] Unreviewed, marking a failing test.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r141479.
commit-queue@webkit.org [Fri, 1 Feb 2013 03:20:48 +0000 (03:20 +0000)]
Unreviewed, rolling out r141479.
http://trac.webkit.org/changeset/141479
https://bugs.webkit.org/show_bug.cgi?id=108564

breaks chromium test (Requested by morrita on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-31

Source/WebCore:

* editing/Editor.cpp:
* editing/Editor.h:
(Editor):

Source/WebKit/chromium:

* public/WebViewClient.h:
* src/EditorClientImpl.cpp:
(WebKit::EditorClientImpl::respondToChangedSelection):

Source/WebKit/efl:

* WebCoreSupport/EditorClientEfl.cpp:
(WebCore::EditorClientEfl::respondToChangedSelection):

Source/WebKit/gtk:

* WebCoreSupport/EditorClientGtk.cpp:
(WebKit::EditorClient::respondToChangedSelection):

Source/WebKit/mac:

* WebView/WebHTMLView.mm:
(-[WebHTMLView _updateSelectionForInputManager]):

Source/WebKit/win:

* WebView.cpp:
(WebView::updateSelectionForIME):

LayoutTests:

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRename from parentOrHost* to parentOrShadowHost* in Node.h.
commit-queue@webkit.org [Fri, 1 Feb 2013 03:17:19 +0000 (03:17 +0000)]
Rename from parentOrHost* to parentOrShadowHost* in Node.h.
https://bugs.webkit.org/show_bug.cgi?id=108308

Source/WebCore:

Patch by Changhun Kang <temoochin@company100.net> on 2013-01-31
Reviewed by Dimitri Glazkov.

No new tests. No change in behavior.

Source/WebKit2:

Patch by Changhun Kang <temoochin@company100.net> on 2013-01-31
Reviewed by Dimitri Glazkov.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: remove old transaction backend bootstrap code
alecflett@chromium.org [Fri, 1 Feb 2013 03:01:27 +0000 (03:01 +0000)]
IndexedDB: remove old transaction backend bootstrap code
https://bugs.webkit.org/show_bug.cgi?id=103923

Reviewed by Dimitri Glazkov.

Source/WebCore:

Finally remove all leftover code from the IndexedDB "giant
async refactor of 2012." This includes removal of all
IDBTransaction* interfaces that were shared between
the frontend and backend and a few straggling methods
like onUpgradeNeeded and onSuccess that were left from
the last stage of refactoring.

* Modules/indexeddb/IDBCallbacks.h:
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
* Modules/indexeddb/IDBDatabaseBackendImpl.h:
(WebCore):
(WebCore::IDBDatabaseBackendImpl::metadata):
(IDBDatabaseBackendImpl):
* Modules/indexeddb/IDBDatabaseBackendInterface.h:
(WebCore):
(IDBDatabaseBackendInterface):
* Modules/indexeddb/IDBObjectStoreBackendImpl.h:
(WebCore):
* Modules/indexeddb/IDBTransaction.h:
(WebCore):
(IDBTransaction):
* Modules/indexeddb/IDBTransactionBackendImpl.h:
(WebCore):
(IDBTransactionBackendImpl):
* Modules/indexeddb/IDBTransactionBackendInterface.h: Removed.
* Modules/indexeddb/IDBTransactionCallbacks.h: Removed.
* Modules/indexeddb/IDBTransactionCoordinator.h:
(WebCore):
* Target.pri:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:

Source/WebKit/chromium:

Remove all deprecated WebKit APIs from
the IDB backend.

* WebKit.gyp:
* public/WebIDBCallbacks.h:
(WebKit):
* public/WebIDBDatabase.h:
(WebKit):
* public/WebIDBTransaction.h: Removed.
* public/WebIDBTransactionCallbacks.h: Removed.
* src/AssertMatchingEnums.cpp:
* src/IDBCallbacksProxy.cpp:
* src/IDBDatabaseBackendProxy.cpp:
* src/IDBDatabaseBackendProxy.h:
(IDBDatabaseBackendProxy):
* src/IDBTransactionBackendProxy.cpp: Removed.
* src/IDBTransactionBackendProxy.h: Removed.
* src/IDBTransactionCallbacksProxy.cpp: Removed.
* src/IDBTransactionCallbacksProxy.h: Removed.
* src/WebIDBCallbacksImpl.cpp:
* src/WebIDBDatabaseImpl.cpp:
(WebKit):
* src/WebIDBDatabaseImpl.h:
(WebKit):
(WebIDBDatabaseImpl):
* src/WebIDBTransactionCallbacksImpl.cpp: Removed.
* src/WebIDBTransactionCallbacksImpl.h: Removed.
* src/WebIDBTransactionImpl.cpp: Removed.
* src/WebIDBTransactionImpl.h: Removed.
* tests/IDBAbortOnCorruptTest.cpp:
* tests/IDBDatabaseBackendTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r141349.
commit-queue@webkit.org [Fri, 1 Feb 2013 02:44:35 +0000 (02:44 +0000)]
Unreviewed, rolling out r141349.
http://trac.webkit.org/changeset/141349
https://bugs.webkit.org/show_bug.cgi?id=108422

"yet another windows ews fix needed" (Requested by lforschler
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-31

* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(WinEWS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Windows build fix.
roger_fong@apple.com [Fri, 1 Feb 2013 02:42:37 +0000 (02:42 +0000)]
Unreviewed. Windows build fix.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse TouchEvent.targetTouches rather than TouchEvent.touches since the order of Touche...
hayato@chromium.org [Fri, 1 Feb 2013 02:41:27 +0000 (02:41 +0000)]
Use TouchEvent.targetTouches rather than TouchEvent.touches since the order of Touches in TouchList is not guaranteed.
https://bugs.webkit.org/show_bug.cgi?id=108426

Reviewed by Dimitri Glazkov.

Neat fix for LayoutTest in http://trac.webkit.org/changeset/141054.

In this LayoutTest context, the length of touchEvent.touches is 2.
The Touch order in TouchList is not guaranteed. Therefore
touchEvent.touches[0] can be another touch.  Rather, we should use
touchEvent.targetTouches here since its length is 1 in this context.

* fast/dom/shadow/touch-event.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebKit/chromium: [Chromium] Select multi-word misspelling on context click
commit-queue@webkit.org [Fri, 1 Feb 2013 02:05:18 +0000 (02:05 +0000)]
Source/WebKit/chromium: [Chromium] Select multi-word misspelling on context click
https://bugs.webkit.org/show_bug.cgi?id=108509

Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-01-31
Reviewed by Tony Chang.

* src/ContextMenuClientImpl.cpp:
(WebKit):
(WebKit::selectMisspellingAsync): Added utility function to get the misspelling for asynchronous spellcheck.
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): Select multi-word misspelling on context click.

Tools: [Chromium] Suggest 'uppercase' for multi-word misspelling 'upper case'
https://bugs.webkit.org/show_bug.cgi?id=108509

Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-01-31
Reviewed by Tony Chang.

* DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
(append): Added utility function to append WebString to WebVector.
(MockSpellCheck::fillSuggestionList): Suggest 'uppercase' for misspelling 'upper case'.

LayoutTests: [Chromium] Expect spellcheck to select multi-word misspelling on context click
https://bugs.webkit.org/show_bug.cgi?id=108509

Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-01-31
Reviewed by Tony Chang.

* editing/spelling/spelling-exactly-selected-multiple-words.html: Check spelling suggestion for multi-word misspelling.
* editing/spelling/spelling-should-select-multiple-words.html: Check spelling suggestion for multi-word misspelling.
* editing/spelling/spelling-exactly-selected-multiple-words-expected.txt:
* editing/spelling/spelling-should-select-multiple-words-expected.txt:
* platform/chromium/TestExpectations: Expect spellcheck to select multi-word misspelling on context click

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r141502.
haraken@chromium.org [Fri, 1 Feb 2013 01:57:36 +0000 (01:57 +0000)]
Unreviewed, rolling out r141502.
http://trac.webkit.org/changeset/141502
https://bugs.webkit.org/show_bug.cgi?id=108441

Hit assert in SVGElementInstance

* bindings/scripts/CodeGeneratorV8.pm:
(GetInternalFields):
* dom/EventTarget.idl:
* svg/SVGElementInstance.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAssert that computePreferredLogicalWidths never calls setNeedsLayout
ojan@chromium.org [Fri, 1 Feb 2013 01:48:20 +0000 (01:48 +0000)]
Assert that computePreferredLogicalWidths never calls setNeedsLayout
https://bugs.webkit.org/show_bug.cgi?id=108539

Reviewed by Tony Chang.

computePreferredLogicalWidths should only set m_minPreferredLogicalWidth
and m_maxPreferredLogicalWidth. It shouldn't have other side-effects.
This is take 2 after this was rolled out because it was missing the guards
in RenderCounter/RenderQuote.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::minPreferredLogicalWidth):
(WebCore::RenderBox::maxPreferredLogicalWidth):
* rendering/RenderCounter.cpp:
(WebCore::RenderCounter::computePreferredLogicalWidths):
* rendering/RenderQuote.cpp:
(WebCore::RenderQuote::computePreferredLogicalWidths):
* rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::computePreferredLogicalWidths):
* rendering/mathml/RenderMathMLRoot.cpp:
(WebCore::RenderMathMLRoot::computePreferredLogicalWidths):
* rendering/mathml/RenderMathMLRow.cpp:
(WebCore::RenderMathMLRow::computePreferredLogicalWidths):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse ASSERT_WITH_SECURITY_IMPLICATION to catch bad casts in DOM
inferno@chromium.org [Fri, 1 Feb 2013 01:39:31 +0000 (01:39 +0000)]
Use ASSERT_WITH_SECURITY_IMPLICATION to catch bad casts in DOM
https://bugs.webkit.org/show_bug.cgi?id=108490

Reviewed by Eric Seidel.

* dom/ContainerNode.h:
(WebCore::toContainerNode):
* dom/Element.h:
(WebCore::toElement):
* dom/ShadowRoot.h:
(WebCore::toShadowRoot):
* dom/Text.h:
(WebCore::toText):
* html/HTMLElement.h:
(HTMLElement):
(WebCore::toHTMLElement):
* html/HTMLFrameOwnerElement.h:
(WebCore::toFrameOwnerElement):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::hasMediaControls):
* html/HTMLTemplateElement.cpp:
(WebCore::toHTMLTemplateElement):
* html/HTMLUnknownElement.h:
(WebCore::toHTMLUnknownElement):
* html/shadow/InsertionPoint.h:
(WebCore::toInsertionPoint):
* html/shadow/MediaControlElementTypes.cpp:
(WebCore::mediaControlElementType):
* html/shadow/MediaControls.h:
(WebCore::toMediaControls):
* html/shadow/SliderThumbElement.h:
(WebCore::toSliderThumbElement):
* html/shadow/TextControlInnerElements.h:
(WebCore::toInputFieldSpeechButtonElement):
* html/shadow/TextFieldDecorationElement.h:
(WebCore::toTextFieldDecorationElement):
* html/track/WebVTTElement.h:
(WebCore::toWebVTTElement):
* mathml/MathMLElement.h:
(WebCore::toMathMLElement):
* page/scrolling/ScrollingStateFixedNode.h:
(WebCore::toScrollingStateFixedNode):
* page/scrolling/ScrollingStateScrollingNode.h:
(WebCore::toScrollingStateScrollingNode):
* page/scrolling/ScrollingStateStickyNode.h:
(WebCore::toScrollingStateStickyNode):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::resize):
* rendering/svg/SVGResources.cpp:
(WebCore::registerPendingResource):
(WebCore::SVGResources::buildCachedResources):
* svg/SVGElement.h:
(WebCore::toSVGElement):
* svg/SVGStyledElement.h:
(WebCore::toSVGStyledElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoProvide a sensible default architecture when building on iOS SDKs
commit-queue@webkit.org [Fri, 1 Feb 2013 01:34:04 +0000 (01:34 +0000)]
Provide a sensible default architecture when building on iOS SDKs
https://bugs.webkit.org/show_bug.cgi?id=108395

Patch by David Farler <dfarler@apple.com> on 2013-01-31
Reviewed by Joseph Pecoraro.

* Scripts/webkitdirs.pm:
(determineArchitecture):
Check for iphoneos and iphonesimulator SDKs for a default arch.
(determineXcodeSDK): Added.
(xcodeSDK): Added.
(XcodeOptions): Add ARCHS= if defined.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix rubber-band effect on non-scrollable pages
commit-queue@webkit.org [Fri, 1 Feb 2013 01:32:10 +0000 (01:32 +0000)]
Fix rubber-band effect on non-scrollable pages
https://bugs.webkit.org/show_bug.cgi?id=107611

Source/WebCore:

Patch by Christopher Cameron <ccameron@chromium.org> on 2013-01-31
Reviewed by Antonio Gomes.

Handle a FrameView's wheel event even if it is not scrollable
because Chrome relies on handling these wheel events for the
over-scroll rubber-band effect.

This had been removed in r138378
[EFL][WK2] Never create WebCore scrollbars for EFL/WK2
by kenneth@chromium.org

Tests: platform/chromium/rubberbanding/wheelevent-overhang-e.html
       platform/chromium/rubberbanding/wheelevent-overhang-n.html
       platform/chromium/rubberbanding/wheelevent-overhang-s.html
       platform/chromium/rubberbanding/wheelevent-overhang-w.html

* page/FrameView.cpp:
(WebCore::FrameView::wheelEvent):

Tools:

Add mouseWheelBegin function to EventSender to allow
event-based rubber-banding tests.

Patch by Christopher Cameron <ccameron@chromium.org> on 2013-01-31
Reviewed by Antonio Gomes.

* DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
(WebTestRunner):
(WebTestRunner::EventSender::EventSender):
(WebTestRunner::EventSender::mouseDragBegin):
* DumpRenderTree/chromium/TestRunner/src/EventSender.h:
(EventSender):

LayoutTests:

Patch by Christopher Cameron <ccameron@chromium.org> on 2013-01-31
Reviewed by Antonio Gomes.

* platform/chromium/rubberbanding/event-overhang-e-expected.png: Added.
* platform/chromium/rubberbanding/event-overhang-e-expected.txt: Added.
* platform/chromium/rubberbanding/event-overhang-e.html: Added.
* platform/chromium/rubberbanding/event-overhang-n-expected.png: Added.
* platform/chromium/rubberbanding/event-overhang-n-expected.txt: Added.
* platform/chromium/rubberbanding/event-overhang-n.html: Added.
* platform/chromium/rubberbanding/event-overhang-s-expected.png: Added.
* platform/chromium/rubberbanding/event-overhang-s-expected.txt: Added.
* platform/chromium/rubberbanding/event-overhang-s.html: Added.
* platform/chromium/rubberbanding/event-overhang-w-expected.png: Added.
* platform/chromium/rubberbanding/event-overhang-w-expected.txt: Added.
* platform/chromium/rubberbanding/event-overhang-w.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMac: Editor::baseWritingDirectionForSelectionStart should return WritingDirection...
enrica@apple.com [Fri, 1 Feb 2013 01:25:28 +0000 (01:25 +0000)]
Mac: Editor::baseWritingDirectionForSelectionStart should return WritingDirection instead of NSWritingDirection.
https://bugs.webkit.org/show_bug.cgi?id=108519.

Reviewed by Sam Weinig.

Source/WebCore:

No new tests, no change in behavior.

There is no need to use AppKit types here.
baseWritingDirectionForSelectionStart now returns WritingDirection and
WebHTMLView toggleWritingDirection has been modified accordingly.

* editing/Editor.h:
* editing/mac/EditorMac.mm:
(WebCore::Editor::baseWritingDirectionForSelectionStart):

Source/WebKit/mac:

There is no need to use AppKit types here.
baseWritingDirectionForSelectionStart now returns WritingDirection and
WebHTMLView toggleWritingDirection has been modified accordingly.

* WebView/WebHTMLView.mm:
(-[WebHTMLView toggleBaseWritingDirection:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Notify the WebWidget when the WebViewHost is about to tear down compositin...
commit-queue@webkit.org [Fri, 1 Feb 2013 01:23:47 +0000 (01:23 +0000)]
[chromium] Notify the WebWidget when the WebViewHost is about to tear down compositing support
https://bugs.webkit.org/show_bug.cgi?id=108518

Patch by James Robinson <jamesr@chromium.org> on 2013-01-31
Reviewed by Adrienne Walker.

* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::shutdown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Pass an Isolate to GetTemplate() in CodeGeneratorV8.pm
haraken@chromium.org [Fri, 1 Feb 2013 01:21:56 +0000 (01:21 +0000)]
[V8] Pass an Isolate to GetTemplate() in CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=108445

Reviewed by Adam Barth.

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateDomainSafeFunctionGetter):
(GenerateDomainSafeFunctionSetter):
(GenerateNormalAttrGetter):
(GenerateNamedConstructorCallback):
(GenerateImplementation):
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::ConfigureV8Float64ArrayTemplate):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetter):
(WebCore::TestActiveDOMObjectV8Internal::TestActiveDOMObjectDomainSafeFunctionSetter):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructorConstructor::GetTemplate):
* bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::ConfigureV8TestNodeTemplate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoStorageManager should be ref-counted
andersca@apple.com [Fri, 1 Feb 2013 01:16:02 +0000 (01:16 +0000)]
StorageManager should be ref-counted
https://bugs.webkit.org/show_bug.cgi?id=108553

Reviewed by Beth Dakin.

It's likely we'd want to have the storage manager outlive its context at times, so make it
reference counted.

* UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::create):
(WebKit):
* UIProcess/Storage/StorageManager.h:
(StorageManager):
* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
* UIProcess/WebContext.h:
(WebContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Clean up Dictionary::get() by removing redundant FindInstanceInPrototypeChain()
haraken@chromium.org [Fri, 1 Feb 2013 01:12:22 +0000 (01:12 +0000)]
[V8] Clean up Dictionary::get() by removing redundant FindInstanceInPrototypeChain()
https://bugs.webkit.org/show_bug.cgi?id=108443

Reviewed by Adam Barth.

In Dictionary::get(), wrapper->FindInstanceInPrototypeChain(V8XXX::GetTemplate())
is unnecessary for DOM wrappers other than DOMWindow. For wrappers other than
DOMWindow, we can simply use V8XXX::HasInstance(wrapper).

Tests: fast/events/constructors/*

* bindings/v8/Dictionary.cpp:
(WebCore::Dictionary::get):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r141136): Apple's internal PLT test suite doesn't finish
jberlin@webkit.org [Fri, 1 Feb 2013 01:10:11 +0000 (01:10 +0000)]
REGRESSION(r141136): Apple's internal PLT test suite doesn't finish
https://bugs.webkit.org/show_bug.cgi?id=108380

Mark another test whose results depend on main resource caching being enabled as failing until
main resource caching can be re-enabled on mac.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLand failing baselines for Lion after r141333. Unreviewed.
timothy_horton@apple.com [Fri, 1 Feb 2013 00:52:37 +0000 (00:52 +0000)]
Land failing baselines for Lion after r141333. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=108523

* platform/mac-lion/fast/canvas/canvas-composite-alpha-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Grid Layout] Support implicit rows and columns
jchaffraix@webkit.org [Fri, 1 Feb 2013 00:48:05 +0000 (00:48 +0000)]
[CSS Grid Layout] Support implicit rows and columns
https://bugs.webkit.org/show_bug.cgi?id=103573

Reviewed by Ojan Vafai.

Source/WebCore:

Tests: fast/css-grid-layout/implicit-columns-auto-resolution.html
       fast/css-grid-layout/implicit-rows-auto-resolution.html

This change makes us properly initialize our GridTrack vectors's size
so that we can safely query any items during layout.

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::gridTrackSize):
Added this helper function to return the track size from the grid
element's columns' / rows' definitions or the default value.

(WebCore::RenderGrid::maximumIndexInDirection):
Added this helper function to get the maximum index in a direction
taking grid item's implicit indexes into account.

(WebCore::RenderGrid::computedUsedBreadthOfGridTracks):
Changed the funtion to not append the new tracks as we are properly
sized now.

(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
(WebCore::RenderGrid::tracksAreWiderThanMinTrackBreadth):
Updated these functions to use the new helper functions.

(WebCore::RenderGrid::layoutGridItems):
Changed this function to size both vectors when initializing them.
Also removed an unneeded bounds check as it shouldn't be needed anymore.

* rendering/RenderGrid.h:
Added the new helper functions.

* rendering/style/GridTrackSize.h:
(WebCore::GridTrackSize::GridTrackSize):
Added a constructor taking a LengthType.

LayoutTests:

* fast/css-grid-layout/implicit-columns-auto-resolution-expected.txt: Added.
* fast/css-grid-layout/implicit-columns-auto-resolution.html: Added.
* fast/css-grid-layout/implicit-rows-auto-resolution-expected.txt: Added.
* fast/css-grid-layout/implicit-rows-auto-resolution.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRolling out r141407 because it is causing crashes under
jberlin@webkit.org [Fri, 1 Feb 2013 00:37:38 +0000 (00:37 +0000)]
Rolling out r141407 because it is causing crashes under
WTF::TCMalloc_Central_FreeList::FetchFromSpans() in Release builds.

Source/JavaScriptCore:

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):

Source/WTF:

* wtf/Deque.h:
(WTF::::expandCapacity):
* wtf/FastMalloc.cpp:
* wtf/FastMalloc.h:
(WTF):
* wtf/Vector.h:
(WTF::VectorBufferBase::allocateBuffer):
(WTF::VectorBufferBase::tryAllocateBuffer):
(WTF::VectorBufferBase::reallocateBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] fast/css/relative-positioned-block-crash.html is intermittently crashing
commit-queue@webkit.org [Fri, 1 Feb 2013 00:37:22 +0000 (00:37 +0000)]
[GTK] fast/css/relative-positioned-block-crash.html is intermittently crashing
https://bugs.webkit.org/show_bug.cgi?id=108200

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2013-01-31
Reviewed by Martin Robinson.

Source/WebCore:

Getting the Position of a PseudoElement now triggers an assertion.
This can occur when clicking on empty space in a render block.
Looking to the unignored parent's node (and passing that accessible
object on in a signal to Assistive Technologies) seems like the most
reasonable thing to do here.

No new tests; instead skipping two tests that were crashing as a result.

* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(objectFocusedAndCaretOffsetUnignored):

LayoutTests:

Unskip two crashing tests having fixed the underlying bug.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Simplify CodeGeneratorV8.pm by using InheritsExtendedAttribute("EventTarget")
haraken@chromium.org [Fri, 1 Feb 2013 00:25:43 +0000 (00:25 +0000)]
[V8] Simplify CodeGeneratorV8.pm by using InheritsExtendedAttribute("EventTarget")
https://bugs.webkit.org/show_bug.cgi?id=108441

Reviewed by Adam Barth.

A complicated condition in GetInternalFields() can be simplified
by using InheritsExtendedAttribute("EventTarget").

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GetInternalFields):
* dom/EventTarget.idl: Added [EventTarget] which should have been added.
* svg/SVGElementInstance.idl: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline after r141459.
ojan@chromium.org [Thu, 31 Jan 2013 23:59:29 +0000 (23:59 +0000)]
Rebaseline after r141459.

* fast/multicol/shrink-to-column-height-for-pagination-expected.png: Renamed from LayoutTests/platform/efl/fast/multicol/shrink-to-column-height-for-pagination-expected.png.
* fast/multicol/shrink-to-column-height-for-pagination-expected.txt: Renamed from LayoutTests/platform/chromium/fast/multicol/shrink-to-column-height-for-pagination-expected.txt.
* platform/efl/fast/multicol/shrink-to-column-height-for-pagination-expected.txt:
* platform/gtk/fast/multicol/shrink-to-column-height-for-pagination-expected.png: Removed.
* platform/gtk/fast/multicol/shrink-to-column-height-for-pagination-expected.txt:
* platform/qt/fast/multicol/shrink-to-column-height-for-pagination-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: Quadratic and bezier curves with coincident endpoints rendered incorr...
commit-queue@webkit.org [Thu, 31 Jan 2013 23:51:58 +0000 (23:51 +0000)]
Source/WebCore: Quadratic and bezier curves with coincident endpoints rendered incorrectly
https://bugs.webkit.org/show_bug.cgi?id=105650

Patch by Youenn Fablet <youennf@gmail.com> on 2013-01-31
Reviewed by Kenneth Russell.

Tests: fast/canvas/canvas-bezier-same-endpoint.html
       fast/canvas/canvas-quadratic-same-endpoint.html

* html/canvas/CanvasPathMethods.cpp:
(WebCore::CanvasPathMethods::quadraticCurveTo):
(WebCore::CanvasPathMethods::bezierCurveTo):

LayoutTests: Quadratic and bezier curves with coincident endpoints rendered incorrectly
https://bugs.webkit.org/show_bug.cgi?id=105650
Modified TestExpectations for Mac, efl and Qt platforms as quadratic curves
may not be rendered correctly
(see https://bugs.webkit.org/show_bug.cgi?id=107118)

Patch by Youenn Fablet <youennf@gmail.com> on 2013-01-31
Reviewed by Kenneth Russell.

* fast/canvas/canvas-bezier-same-endpoint-expected.txt: Added.
* fast/canvas/canvas-bezier-same-endpoint.html: Added.
* fast/canvas/canvas-quadratic-same-endpoint-expected.txt: Added.
* fast/canvas/canvas-quadratic-same-endpoint.html: Added.
* platform/efl/TestExpectations: Skipped quad test
* platform/mac/TestExpectations: Skipped quad test
* platform/qt/TestExpectations: Skipped quad test

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAbstraction for hiding enum class.
mark.lam@apple.com [Thu, 31 Jan 2013 23:49:26 +0000 (23:49 +0000)]
Abstraction for hiding enum class.
https://bugs.webkit.org/show_bug.cgi?id=108533

Reviewed by Anders Carlsson.

../WebCore:

No new tests.

* Modules/webdatabase/DatabaseError.h:
(WebCore::ENUM_CLASS_BEGIN):

../WTF:

* wtf/Compiler.h:
* wtf/EnumClass.h: Copied from Source/WTF/wtf/TypeSafeEnum.h.
(WTF::EnumClass::EnumClass):
(WTF::EnumClass::operator==):
(WTF::EnumClass::operator!=):
(WTF::EnumClass::operator<):
(WTF::EnumClass::operator<=):
(WTF::EnumClass::operator>):
(WTF::EnumClass::operator>=):
* wtf/TypeSafeEnum.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Gtk] drag and drop has black background without composition
commit-queue@webkit.org [Thu, 31 Jan 2013 23:46:03 +0000 (23:46 +0000)]
[Gtk] drag and drop has black background without composition
https://bugs.webkit.org/show_bug.cgi?id=108376

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-01-31
Reviewed by Martin Robinson.

Use gtk_drag_set_icon_surface (or gtk_drag_set_icon_pixbuf) when the
screen is not composited. That way, drag window will be decomposited
and rendered transparent with Xshape.

To determine which parts of the window must be transparent, gtk checks
if a pixel is more than 50% opaque. With dissolveDragImageToFraction,
all pixels are made 25% transparent. With antialiasing, opacity goes
below the threshold for some pixels, which makes the resulting image
messy. So, we need to skip dissolveDragImageToFraction when we use
gtk_drag_set_icon_surface.

* platform/gtk/DragIcon.cpp:
(WebCore::DragIcon::DragIcon):
(WebCore::DragIcon::~DragIcon):
(WebCore::DragIcon::setImage):
(WebCore::DragIcon::useForDrag):
* platform/gtk/DragIcon.h:
(DragIcon):
* platform/gtk/DragImageGtk.cpp:
(WebCore::dissolveDragImageToFraction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWorkQueue should be a ref-counted class
andersca@apple.com [Thu, 31 Jan 2013 23:43:21 +0000 (23:43 +0000)]
WorkQueue should be a ref-counted class
https://bugs.webkit.org/show_bug.cgi?id=108544

Reviewed by Sam Weinig.

Make WorkQueue a ref-counted class that's implicitly ref()'d when dispatching a function to it, and then
implicitly deref()'d when the function is done executing. This matches the behavior of dispatch queues,
and ensures that the WorkQueue object won't go away while dispatched functions are running.

* Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::Connection):
(CoreIPC::Connection::~Connection):
(CoreIPC::Connection::addQueueClient):
(CoreIPC::Connection::removeQueueClient):
(CoreIPC::Connection::invalidate):
(CoreIPC::Connection::sendMessage):
(CoreIPC::Connection::postConnectionDidCloseOnConnectionWorkQueue):
(CoreIPC::Connection::connectionDidClose):
* Platform/CoreIPC/Connection.h:
(Connection):
* Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::createDataAvailableSource):
(CoreIPC::Connection::open):
(CoreIPC::Connection::initializeDeadNameSource):
* Platform/WorkQueue.cpp:
(WorkQueue::create):
(WorkQueue::WorkQueue):
(WorkQueue::~WorkQueue):
* Platform/WorkQueue.h:
(WorkQueue):
* Platform/mac/WorkQueueMac.cpp:
(WorkQueue::dispatch):
(WorkQueue::dispatchAfterDelay):
* Shared/ChildProcess.cpp:
(WebKit::didCloseOnConnectionWorkQueue):
* UIProcess/Launcher/ProcessLauncher.cpp:
(WebKit::processLauncherWorkQueue):
(WebKit::ProcessLauncher::ProcessLauncher):
* UIProcess/WebProcessProxy.cpp:
(WebKit::pluginWorkQueue):
(WebKit::WebProcessProxy::getPlugins):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening.
fmalita@chromium.org [Thu, 31 Jan 2013 23:38:04 +0000 (23:38 +0000)]
[Chromium] Unreviewed gardening.

WebViewTest.SetCompositionFromExistingText failing after r141479.

* tests/WebViewTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Fix build after removal of MessageID.h
rafael.lobo@openbossa.org [Thu, 31 Jan 2013 23:26:01 +0000 (23:26 +0000)]
[Qt][WK2] Fix build after removal of MessageID.h
https://bugs.webkit.org/show_bug.cgi?id=108534

Reviewed by Anders Carlsson.

* Platform/CoreIPC/unix/ConnectionUnix.cpp:
(CoreIPC::MessageInfo::MessageInfo):
(CoreIPC::MessageInfo::setMessageBodyIsOutOfLine):
(CoreIPC::MessageInfo::isMessageBodyIsOutOfLine):
(MessageInfo):
(CoreIPC::Connection::processMessage):
(CoreIPC::Connection::sendOutgoingMessage):
* Target.pri:
* UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
* UIProcess/DrawingAreaProxy.cpp:
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
* WebProcess/soup/WebSoupRequestManager.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBegin to make XSSAuditor thread aware
tonyg@chromium.org [Thu, 31 Jan 2013 23:18:35 +0000 (23:18 +0000)]
Begin to make XSSAuditor thread aware
https://bugs.webkit.org/show_bug.cgi?id=108394

Reviewed by Adam Barth.

This patch moves the parts of filterToken() that depend on Frame, Document, etc. to a delegate class.
The new didBlockScript delegate method is invoked with the resulting DidBlockScriptRequest which will
be owned by the CompactHTMLToken in the threaded case.

This is just the first step as there is more to do to make XSSAuditor thread safe.

No new tests because covered by existing tests.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* html/parser/BackgroundHTMLParser.cpp:
(WebCore::BackgroundHTMLParser::pumpTokenizer):
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::HTMLDocumentParser):
(WebCore::HTMLDocumentParser::processTokensFromBackgroundParser):
(WebCore::HTMLDocumentParser::pumpTokenizer):
* html/parser/HTMLDocumentParser.h:
(HTMLDocumentParser):
* html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::filterToken):
* html/parser/XSSAuditor.h:
(WebCore):
(XSSAuditor):
* html/parser/XSSAuditorDelegate.cpp: Added.
(WebCore):
(WebCore::XSSAuditorDelegate::XSSAuditorDelegate):
(WebCore::XSSAuditorDelegate::didBlockScript):
* html/parser/XSSAuditorDelegate.h: Added.
(WebCore):
(DidBlockScriptRequest):
(WebCore::DidBlockScriptRequest::create):
(WebCore::DidBlockScriptRequest::DidBlockScriptRequest):
(XSSAuditorDelegate):

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* html/parser/BackgroundHTMLParser.cpp:
(WebCore::BackgroundHTMLParser::pumpTokenizer):
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::HTMLDocumentParser):
(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::pumpTokenizer):
* html/parser/HTMLDocumentParser.h:
(HTMLDocumentParser):
* html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::XSSAuditor):
(WebCore::XSSAuditor::filterToken):
* html/parser/XSSAuditor.h:
(WebCore):
(XSSAuditor):
* html/parser/XSSAuditorDelegate.cpp: Added.
(WebCore):
(WebCore::XSSAuditorDelegate::XSSAuditorDelegate):
(WebCore::XSSAuditorDelegate::didBlockScript):
* html/parser/XSSAuditorDelegate.h: Added.
(WebCore):
(DidBlockScriptRequest):
(WebCore::DidBlockScriptRequest::create):
(WebCore::DidBlockScriptRequest::DidBlockScriptRequest):
(XSSAuditorDelegate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAssertion failure in WebResourceLoadScheduler::remove when loading .webarchives
beidson@apple.com [Thu, 31 Jan 2013 23:13:16 +0000 (23:13 +0000)]
Assertion failure in WebResourceLoadScheduler::remove when loading .webarchives
<rdar://problem/12888145> and https://bugs.webkit.org/show_bug.cgi?id=108520

Reviewed by Alexey Proskuryakov.

* WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::WebResourceLoadScheduler::scheduleLoad): Even if it isn't to be scheduled with the
  NetworkProcess, still add this ResourceLoader to the scheduler's records.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCSS3's vh attribute is not adjusting while browser resizes
commit-queue@webkit.org [Thu, 31 Jan 2013 23:12:05 +0000 (23:12 +0000)]
CSS3's vh attribute is not adjusting while browser resizes
https://bugs.webkit.org/show_bug.cgi?id=86418

Patch by Uday Kiran <udaykiran@motorola.com> on 2013-01-31
Reviewed by Antti Koivisto.

Source/WebCore:

Elements with viewport percentage units needs layout whenever
viewport size changes. Check for viewport percentage unit
was missing for height.

Test: css3/viewport-percentage-lengths/vh-resize.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateBlockChildDirtyBitsBeforeLayout):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::hasViewportPercentageLogicalHeight): Check if style
is specified in viewport percentage units.
(WebCore):
* rendering/RenderBox.h:
(RenderBox):
* rendering/RenderView.cpp:
(WebCore::RenderView::layout): Elements with viewport percentage units
needs relayout when viewport size changes.

LayoutTests:

Added test to check element with vh units gets resized when
viewport height is increased or decreased.

* css3/viewport-percentage-lengths/vh-resize-expected.html: Added.
* css3/viewport-percentage-lengths/vh-resize.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDumpRenderTree should put NSSound calls inside USE(APPKIT)
psolanki@apple.com [Thu, 31 Jan 2013 22:56:47 +0000 (22:56 +0000)]
DumpRenderTree should put NSSound calls inside USE(APPKIT)
https://bugs.webkit.org/show_bug.cgi?id=108499

Reviewed by Andy Estes.

* DumpRenderTree/mac/DumpRenderTree.mm:
(dumpRenderTree):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoObjective-C API: JSContext exception property causes reference cycle
mhahnenberg@apple.com [Thu, 31 Jan 2013 22:33:55 +0000 (22:33 +0000)]
Objective-C API: JSContext exception property causes reference cycle
https://bugs.webkit.org/show_bug.cgi?id=107778

Reviewed by Darin Adler.

JSContext has a (retain) JSValue * exception property which, when non-null, creates a
reference cycle (since the JSValue * holds a strong reference back to the JSContext *).

* API/JSContext.mm: Instead of JSValue *, we now use a plain JSValueRef, which eliminates the reference cycle.
(-[JSContext initWithVirtualMachine:]):
(-[JSContext setException:]):
(-[JSContext exception]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTextAutosizing: refactor the cluster related method parameters into a single struct.
commit-queue@webkit.org [Thu, 31 Jan 2013 22:31:45 +0000 (22:31 +0000)]
TextAutosizing: refactor the cluster related method parameters into a single struct.
https://bugs.webkit.org/show_bug.cgi?id=108384

This anticipates adding more cluster related information in the following patches.

Patch by Anton Vayvod <avayvod@chromium.org> on 2013-01-31
Reviewed by Kenneth Rohde Christiansen.

Just a refactoring so no new tests.

* rendering/TextAutosizer.cpp: define the new struct and pass it to every method instead of
a cluster and its descendant block containing all text.
* rendering/TextAutosizer.h: change method prototypes to receive the new struct
as a parameter defining an autosizing cluster.

* rendering/TextAutosizer.cpp:
(WebCore::TextAutosizingClusterInfo::TextAutosizingClusterInfo):
(TextAutosizingClusterInfo):
(WebCore):
(WebCore::TextAutosizer::processSubtree):
(WebCore::TextAutosizer::processCluster):
(WebCore::TextAutosizer::processContainer):
(WebCore::TextAutosizer::isAutosizingCluster):
(WebCore::TextAutosizer::clusterShouldBeAutosized):
(WebCore::TextAutosizer::measureDescendantTextWidth):
* rendering/TextAutosizer.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed trivial Unix build fix.
hausmann@webkit.org [Thu, 31 Jan 2013 22:28:41 +0000 (22:28 +0000)]
Unreviewed trivial Unix build fix.

Use Vector<> instead of Deque<> when iterating
over m_attachments in the USE(UNIX_DOMAIN_SOCKETS)
case.

* Platform/CoreIPC/ArgumentDecoder.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline after r141459.
jberlin@webkit.org [Thu, 31 Jan 2013 22:23:43 +0000 (22:23 +0000)]
Rebaseline after r141459.

* platform/mac/fast/multicol/shrink-to-column-height-for-pagination-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd a call to the page UI client to determine if a plug-in should load
bweinstein@apple.com [Thu, 31 Jan 2013 22:17:52 +0000 (22:17 +0000)]
Add a call to the page UI client to determine if a plug-in should load
https://bugs.webkit.org/show_bug.cgi?id=108407
<rdar://problem/13066332>

Source/WebKit2:

Reviewed by Anders Carlsson.

This patch adds a client call to the WKPageUIClient to be called to determine
whether or not a plug-in should load.

* UIProcess/API/C/WKPage.h: Add shouldLoadPlugin.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::getPluginPath): Moved from WebProcessProxy, and added a call to
    m_uiClient.shouldInstantiatePlugin.
* UIProcess/WebPageProxy.h:
* UIProcss/WebPageProxy.messages.in: Moved GetPluginPath from WebProcessProxy to WebPageProxy.
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::getPluginPath): Moved to WebPageProxy.
* UIProcess/WebProcessProxy.h:
* UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::shouldInstantiatePlugin): Return that we should load the plug-in if
    the client function isn't defined, and call the function if it is.
* UIProcess/WebUIClient.h:
* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformCreateInspectorPage): Add an entry for the new
    client function.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin): Send the message to the WebPageProxy, not the WebProcessProxy.
(WebKit::WebPage::canPluginHandleResponse): Made a member function, so it can call sendSync, and
    send the message to the WebPageProxy, not the WebProcessProxy.
* WebProcess/WebPage/WebPage.h:

Tools:

Add entries for the new function in the necessary structs.

Reviewed by Anders Carlsson.

* MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController awakeFromNib]):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::createOtherPage):
(WTR::TestController::createWebViewWithOptions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141486 268f45cc-cd09-0410-ab3c-d52691b4dbfc