WebKit-https.git
9 years agoUnrreviewed.
ossy@webkit.org [Wed, 1 Dec 2010 17:04:29 +0000 (17:04 +0000)]
Unrreviewed.

[Qt] Add focus ring outline color support
https://bugs.webkit.org/show_bug.cgi?id=50325

Focus ring outline color is unsupported now.
Add failing tests to the Skipped list until fix.

* platform/qt/Skipped:
 - fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map.html added
 - fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map.html added
 - fast/images/imagemap-focus-ring-outline-color.html added

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-01 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Wed, 1 Dec 2010 16:49:35 +0000 (16:49 +0000)]
2010-12-01  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Roben.

        [WINCE] Add WinCELauncher
        https://bugs.webkit.org/show_bug.cgi?id=50217

        * WinCELauncher/main.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-01 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 1 Dec 2010 16:46:39 +0000 (16:46 +0000)]
2010-12-01  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [Gtk] Open menulists should support typeahead find
        https://bugs.webkit.org/show_bug.cgi?id=27443

        Added a GTK+-specific layout test to track typeahead find state.

        * platform/gtk/fast/forms/menulist-typeahead-find-expected.txt: Added.
        * platform/gtk/fast/forms/menulist-typeahead-find.html: Added.
2010-12-01  Apelete Seketeli  <apelete@seketeli.org> and Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [Gtk] Open menulists should support typeahead find
        https://bugs.webkit.org/show_bug.cgi?id=27443

        Added typeahead find support for open GTK+ menulists.

        Test: platform/gtk/fast/forms/menulist-typeahead-find.html

        * platform/gtk/PopupMenuGtk.cpp:
        (WebCore::PopupMenuGtk::PopupMenuGtk): Initialize new members.
        (WebCore::PopupMenuGtk::show): Track currently selected menu item
        via a signal handler.
        (WebCore::PopupMenuGtk::typeAheadFind): Added.
        (WebCore::PopupMenuGtk::menuUnmapped): Reset typeahead find state
        when menu is unmapped.
        (WebCore::PopupMenuGtk::resetTypeAheadFindState): Added.
        (WebCore::PopupMenuGtk::selectItemCallback): Added.
        (WebCore::PopupMenuGtk::keyPressEventCallback): Added.
        * platform/gtk/PopupMenuGtk.h: Added new members to track typeahead
        find state.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-01 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 1 Dec 2010 16:36:29 +0000 (16:36 +0000)]
2010-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Xan Lopez.

        Split DECLARE_ANIMATED_PROPERTY* in DECLARE/DEFINE parts for SVGAnimatedNumber
        https://bugs.webkit.org/show_bug.cgi?id=50323

        Continuing the work on bug 42025: Introduce DECLARE_ANIMATED_NUMBER / DEFINE_ANIMATED_NUMBER.
        The animated property declaration lives in the header, the definition in the cpp file, to avoid the dependency on SVGNames.h in all headers.

        No functional changes, thus no new tests.

        * svg/SVGAnimatedNumber.h:
        * svg/SVGComponentTransferFunctionElement.cpp:
        * svg/SVGComponentTransferFunctionElement.h:
        * svg/SVGFECompositeElement.cpp:
        * svg/SVGFECompositeElement.h:
        * svg/SVGFEConvolveMatrixElement.cpp:
        * svg/SVGFEConvolveMatrixElement.h:
        * svg/SVGFEDiffuseLightingElement.cpp:
        * svg/SVGFEDiffuseLightingElement.h:
        * svg/SVGFEDisplacementMapElement.cpp:
        * svg/SVGFEDisplacementMapElement.h:
        * svg/SVGFEGaussianBlurElement.cpp:
        * svg/SVGFEGaussianBlurElement.h:
        * svg/SVGFELightElement.cpp:
        * svg/SVGFELightElement.h:
        * svg/SVGFEMorphologyElement.cpp:
        * svg/SVGFEMorphologyElement.h:
        * svg/SVGFEOffsetElement.cpp:
        * svg/SVGFEOffsetElement.h:
        * svg/SVGFESpecularLightingElement.cpp:
        * svg/SVGFESpecularLightingElement.h:
        * svg/SVGFETurbulenceElement.cpp:
        * svg/SVGFETurbulenceElement.h:
        * svg/SVGPathElement.cpp:
        * svg/SVGPathElement.h:
        * svg/SVGStopElement.cpp:
        * svg/SVGStopElement.h:
        (WebCore::SVGStopElement::isGradientStop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-01 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 1 Dec 2010 16:15:17 +0000 (16:15 +0000)]
2010-12-01  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        Sliders are not transformed after r50188
        https://bugs.webkit.org/show_bug.cgi?id=50317

        Need to call updateLayerTransform during slider layout, as sliders
        may be transformed.

        No new tests. This patch should make fast/forms/slider-transformed.html
        pass on the GTK+ bots.

        * rendering/RenderSlider.cpp:
        (WebCore::RenderSlider::layout): Call updateLayerTransform here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-01 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 1 Dec 2010 16:13:28 +0000 (16:13 +0000)]
2010-12-01  Martin Robinson  <mrobinson@igalia.com>

        Skip failing tests for text height on GTK
        https://bugs.webkit.org/show_bug.cgi?id=50314

        * platform/gtk/Skipped: Skip failing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 1 Dec 2010 15:52:26 +0000 (15:52 +0000)]
2010-11-30  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: do not make helpScreen.css lazily loaded.
        https://bugs.webkit.org/show_bug.cgi?id=50304

        * inspector/front-end/HelpScreen.js:
        (WebInspector.HelpScreen):
        (WebInspector.HelpScreen.prototype._onBlur):
        * inspector/front-end/inspector.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-01 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 1 Dec 2010 15:41:53 +0000 (15:41 +0000)]
2010-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Xan Lopez.

        Split DECLARE_ANIMATED_PROPERTY* in DECLARE/DEFINE parts for SVGLengthList/SVGNumberList/SVGTransformList
        https://bugs.webkit.org/show_bug.cgi?id=50322

        Continuing the work on bug 42025: Introduce DECLARE_ANIMATED_(LENGTH|NUMBER|TRANSFORM)_LIST / DEFINE_ANIMATED_(LENGTH|NUMBER|TRANSFORM).
        The animated property declaration lives in the header, the definition in the cpp file, to avoid the dependency on SVGNames.h in all headers.

        No functional changes, thus no new tests.

        * svg/SVGAnimatedLengthList.h:
        * svg/SVGAnimatedNumberList.h:
        * svg/SVGAnimatedTransformList.h:
        * svg/SVGComponentTransferFunctionElement.cpp:
        * svg/SVGComponentTransferFunctionElement.h:
        * svg/SVGFEColorMatrixElement.cpp:
        * svg/SVGFEColorMatrixElement.h:
        * svg/SVGFEConvolveMatrixElement.cpp:
        * svg/SVGFEConvolveMatrixElement.h:
        * svg/SVGGradientElement.cpp:
        * svg/SVGGradientElement.h:
        (WebCore::SVGGradientElement::needsPendingResourceHandling):
        * svg/SVGPatternElement.cpp:
        * svg/SVGPatternElement.h:
        * svg/SVGPolygonElement.cpp:
        * svg/SVGPolylineElement.cpp:
        * svg/SVGStyledTransformableElement.cpp:
        * svg/SVGStyledTransformableElement.h:
        * svg/SVGTextElement.cpp:
        (WebCore::SVGTextElement::SVGTextElement):
        * svg/SVGTextElement.h:
        (WebCore::SVGTextElement::localCoordinateSpaceTransform):
        * svg/SVGTextPositioningElement.cpp:
        * svg/SVGTextPositioningElement.h:
        * svg/properties/SVGAnimatedPropertyMacros.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-01 Chang Shu <chang.shu@nokia.com>
chang.shu@nokia.com [Wed, 1 Dec 2010 15:32:13 +0000 (15:32 +0000)]
2010-12-01  Chang Shu  <chang.shu@nokia.com>

        Reviewed by Laszlo Gombos.

        Move orientation event test case to a better place.
        https://bugs.webkit.org/show_bug.cgi?id=32492

        * fast/dom/DeviceOrientation/create-event-orientationchange-expected.txt: Removed.
        * fast/dom/DeviceOrientation/create-event-orientationchange.html: Removed.
        * fast/dom/DeviceOrientation/script-tests/create-event-orientationchange.js: Removed.
        * fast/dom/Orientation: Added.
        * fast/dom/Orientation/create-event-orientationchange-expected.txt: Copied from LayoutTests/fast/dom/DeviceOrientation/create-event-orientationchange-expected.txt.
        * fast/dom/Orientation/create-event-orientationchange.html: Copied from LayoutTests/fast/dom/DeviceOrientation/create-event-orientationchange.html.
        * fast/dom/Orientation/script-tests: Added.
        * fast/dom/Orientation/script-tests/create-event-orientationchange.js: Copied from LayoutTests/fast/dom/DeviceOrientation/script-tests/create-event-orientationchange.js.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-01 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Wed, 1 Dec 2010 14:14:19 +0000 (14:14 +0000)]
2010-12-01  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: name-only property appears in style declaration but not in the Styles pane
        https://bugs.webkit.org/show_bug.cgi?id=49663

        Check that at least one property has been parsed from the user input.

        WebCore:
        * inspector/InspectorStyleSheet.cpp:
        (WebCore::InspectorStyle::setPropertyText):

        LayoutTests:
        * inspector/styles-new-API.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-01 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Wed, 1 Dec 2010 13:29:50 +0000 (13:29 +0000)]
2010-12-01  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: disable cookies tab in network resource view by default, enable for chromium
        https://bugs.webkit.org/show_bug.cgi?id=50249

        * inspector/front-end/NetworkItemView.js:
        (WebInspector.NetworkItemView):
        (WebInspector.NetworkItemView.prototype.resize):
        * inspector/front-end/Settings.js:
2010-12-01  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: disable cookies tab in network resource view by default, enable for chromium
        https://bugs.webkit.org/show_bug.cgi?id=50249

        * src/js/DevTools.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-01 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 1 Dec 2010 12:17:12 +0000 (12:17 +0000)]
2010-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Xan Lopez.

        Split DECLARE_ANIMATED_PROPERTY* in DECLARE/DEFINE parts for SVGLength
        https://bugs.webkit.org/show_bug.cgi?id=50316

        Introduce DECLARE_ANIMATED_LENGTH / DEFINE_ANIMATED_LENGTH, splitting up the original DECLARE_ANIMATED_PROPERTY_NEW macro
        in a part that goes in the .cpp file and another that remains in the header. This avoids having to include SVGNames.h
        in all SVG*Element files.

        No functional changes, thus no new tests.

        * svg/SVGAnimatedLength.h:
        * svg/SVGCircleElement.cpp:
        * svg/SVGCircleElement.h:
        (WebCore::SVGCircleElement::isValid):
        * svg/SVGCursorElement.cpp:
        * svg/SVGCursorElement.h:
        (WebCore::SVGCursorElement::isValid):
        * svg/SVGEllipseElement.cpp:
        * svg/SVGEllipseElement.h:
        (WebCore::SVGEllipseElement::isValid):
        * svg/SVGFilterElement.cpp:
        * svg/SVGFilterElement.h:
        * svg/SVGFilterPrimitiveStandardAttributes.cpp:
        * svg/SVGFilterPrimitiveStandardAttributes.h:
        * svg/SVGForeignObjectElement.cpp:
        (WebCore::SVGForeignObjectElement::SVGForeignObjectElement):
        * svg/SVGForeignObjectElement.h:
        (WebCore::SVGForeignObjectElement::isValid):
        * svg/SVGImageElement.cpp:
        * svg/SVGImageElement.h:
        (WebCore::SVGImageElement::isValid):
        * svg/SVGLineElement.cpp:
        * svg/SVGLineElement.h:
        (WebCore::SVGLineElement::isValid):
        (WebCore::SVGLineElement::supportsMarkers):
        * svg/SVGLinearGradientElement.cpp:
        * svg/SVGLinearGradientElement.h:
        * svg/SVGMarkerElement.cpp:
        (WebCore::SVGMarkerElement::SVGMarkerElement):
        * svg/SVGMarkerElement.h:
        * svg/SVGMaskElement.cpp:
        * svg/SVGMaskElement.h:
        (WebCore::SVGMaskElement::isValid):
        (WebCore::SVGMaskElement::needsPendingResourceHandling):
        * svg/SVGPatternElement.cpp:
        * svg/SVGPatternElement.h:
        (WebCore::SVGPatternElement::isValid):
        (WebCore::SVGPatternElement::needsPendingResourceHandling):
        * svg/SVGRadialGradientElement.cpp:
        * svg/SVGRadialGradientElement.h:
        * svg/SVGRectElement.cpp:
        * svg/SVGRectElement.h:
        (WebCore::SVGRectElement::isValid):
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::SVGSVGElement):
        * svg/SVGSVGElement.h:
        (WebCore::SVGSVGElement::isValid):
        (WebCore::SVGSVGElement::setContainerSize):
        (WebCore::SVGSVGElement::containerSize):
        (WebCore::SVGSVGElement::hasSetContainerSize):
        (WebCore::SVGSVGElement::currentTranslate):
        (WebCore::SVGSVGElement::timeContainer):
        (WebCore::SVGSVGElement::isSVG):
        (WebCore::SVGSVGElement::rendererIsNeeded):
        * svg/SVGTextContentElement.cpp:
        * svg/SVGTextContentElement.h:
        (WebCore::SVGTextContentElement::isValid):
        (WebCore::SVGTextContentElement::isTextContent):
        * svg/SVGTextPathElement.cpp:
        * svg/SVGTextPathElement.h:
        * svg/SVGTextPositioningElement.h:
        * svg/SVGUseElement.cpp:
        * svg/SVGUseElement.h:
        (WebCore::SVGUseElement::isValid):
        (WebCore::SVGUseElement::setUpdatesBlocked):
        (WebCore::SVGUseElement::isPendingResource):
        * svg/properties/SVGAnimatedPropertyMacros.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-01 Anton D'Auria <adauria@apple.com>
commit-queue@webkit.org [Wed, 1 Dec 2010 12:03:53 +0000 (12:03 +0000)]
2010-12-01  Anton D'Auria  <adauria@apple.com>

        Reviewed by Kevin Decker.

        Private browsing denies read access to local and session storage,
        so updating expected test results.

        https://bugs.webkit.org/show_bug.cgi?id=49329

        * storage/domstorage/localstorage/private-browsing-affects-storage-expected.txt:
        * storage/domstorage/sessionstorage/private-browsing-affects-storage-expected.txt:
2010-12-01  Anton D'Auria  <adauria@apple.com>

        Reviewed by Kevin Decker.

        Deny access to local and session storage in private browsing mode.
        https://bugs.webkit.org/show_bug.cgi?id=49329

        * storage/Storage.cpp:
        (WebCore::Storage::length):
        (WebCore::Storage::key):
        (WebCore::Storage::getItem):
        (WebCore::Storage::contains):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-01 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Wed, 1 Dec 2010 11:41:04 +0000 (11:41 +0000)]
2010-12-01  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        Volume control not correctly initialized
        https://bugs.webkit.org/show_bug.cgi?id=36299

        Replaced the mute/volume Timers with g_timeouts which are (for
        now, at least) more reliable than Timers for one-shot-fire-now
        actions.

        Test: media/video-volume.html

        * platform/graphics/MediaPlayer.cpp:
        (WebCore::MediaPlayer::~MediaPlayer): Reset the raw pointers to 0
        when destructing the player.
        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::mediaPlayerPrivateVolumeChangeTimeoutCallback):
        (WebCore::mediaPlayerPrivateMuteChangeTimeoutCallback):
        (WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
        (WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVolumeChange):
        (WebCore::MediaPlayerPrivateGStreamer::volumeChanged):
        (WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfMute):
        (WebCore::MediaPlayerPrivateGStreamer::muteChanged):
        (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin): Set
        playbin2 volume/mute base on MediaPlayer related values.
        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-01 Hayato Ito <hayato@chromium.org>
hayato@chromium.org [Wed, 1 Dec 2010 11:32:32 +0000 (11:32 +0000)]
2010-12-01  Hayato Ito  <hayato@chromium.org>

        Unreviewed trivial fix.

        Removed fast/regex/{test1,test4}.html because they were removed from tree by r72990

        * platform/chromium/test_expectations.txt:
        * platform/gtk/Skipped:
        * platform/mac-wk2/Skipped:
        * platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-01 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Wed, 1 Dec 2010 10:47:20 +0000 (10:47 +0000)]
2010-12-01  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Andreas Kling.

        Cleanup main CMakeLists.txt after r72664, r72672 and r72667
        https://bugs.webkit.org/show_bug.cgi?id=50232

        * CMakeLists.txt: Removed obsolete dependencies.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-01 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 1 Dec 2010 08:57:20 +0000 (08:57 +0000)]
2010-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Cleanup SVGPropertyTraits
        https://bugs.webkit.org/show_bug.cgi?id=50229

        Move all template specializations for non-POD types (eg. SVGLength, SVGLengthList, etc.) from SVGPropertyTraits
        into the right SVG* classes, to avoid having to include a dozen SVG*.h files in SVGPropertyTraits.h, which is
        included by all DOM/JS/V8 binding files and SVGElement.h.

        No new functionality, thus no new tests.

        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/scripts/CodeGenerator.pm:
        * bindings/scripts/CodeGeneratorObjC.pm:
        * bindings/scripts/CodeGeneratorV8.pm:
        * svg/SVGAngle.h:
        * svg/SVGLength.h:
        * svg/SVGLengthList.h:
        * svg/SVGMarkerElement.h:
        * svg/SVGNumberList.h:
        * svg/SVGPatternElement.h:
        * svg/SVGPointList.h:
        * svg/SVGPreserveAspectRatio.h:
        * svg/SVGRect.h: Added.
        * svg/SVGSVGElement.h:
        * svg/SVGStringList.h:
        * svg/SVGSymbolElement.h:
        * svg/SVGTransformList.h:
        * svg/SVGViewElement.h:
        * svg/SVGViewSpec.h:
        * svg/properties/SVGListProperty.h:
        * svg/properties/SVGPropertyTraits.h:
        * svg/properties/SVGTransformListPropertyTearOff.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed trivial fix.
ossy@webkit.org [Wed, 1 Dec 2010 08:13:15 +0000 (08:13 +0000)]
Unreviewed trivial fix.

* platform/qt/Skipped:
 - editing/selection/5109817.html: removed, because it was removed from tree by r73009
 - fast/regex/test1.html: removed, because it was removed from tree by r72990
 - fast/regex/test4.html: removed, because it was removed from tree by r72990

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Avi Drissman <avi@google.com>
commit-queue@webkit.org [Wed, 1 Dec 2010 05:37:32 +0000 (05:37 +0000)]
2010-11-30  Avi Drissman  <avi@google.com>

        Reviewed by Darin Adler.

        Add preference to not select when right-clicked
        https://bugs.webkit.org/show_bug.cgi?id=23351

        Removed 5109817 because it is entirely superseded by
        context-menu-text-selection; updated 5354455-1 to explicitly set the
        editing behavior and test all three platforms.

        * editing/selection/5109817.html: Removed.
        * editing/selection/5354455-1-expected.txt: Added.
        * editing/selection/5354455-1.html:
        * platform/chromium-win/editing/selection/5109817-expected.txt: Removed.
        * platform/chromium-win/editing/selection/5354455-1-expected.txt: Removed.
        * platform/gtk/editing/selection/5109817-expected.txt: Removed.
        * platform/gtk/editing/selection/5354455-1-expected.txt: Removed.
        * platform/mac-leopard/editing/selection/5109817-expected.checksum: Removed.
        * platform/mac-leopard/editing/selection/5109817-expected.png: Removed.
        * platform/mac/editing/selection/5109817-expected.checksum: Removed.
        * platform/mac/editing/selection/5109817-expected.png: Removed.
        * platform/mac/editing/selection/5109817-expected.txt: Removed.
        * platform/mac/editing/selection/5354455-1-expected.txt: Removed.
        * platform/win/editing/selection/5109817-expected.checksum: Removed.
        * platform/win/editing/selection/5109817-expected.png: Removed.
        * platform/win/editing/selection/5109817-expected.txt: Removed.
        * platform/win/editing/selection/5354455-1-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRefactor HTMLInputElement: Move a part of HTMLInputElement::
tkent@chromium.org [Wed, 1 Dec 2010 04:36:46 +0000 (04:36 +0000)]
Refactor HTMLInputElement: Move a part of HTMLInputElement::
defaultEventHandler() to InputTypes
https://bugs.webkit.org/show_bug.cgi?id=50097

Reviewed by Darin Adler.

Move all of keyboard-related event handling to InputType.

No new tests because this should not change any behavior.

* html/BaseButtonInputType.cpp:
(WebCore::BaseButtonInputType::handleKeydownEvent):
(WebCore::BaseButtonInputType::handleKeypressEvent):
(WebCore::BaseButtonInputType::handleKeyupEvent):
* html/BaseButtonInputType.h:
* html/BaseCheckableInputType.cpp:
(WebCore::BaseCheckableInputType::handleKeydownEvent):
(WebCore::BaseCheckableInputType::handleKeypressEvent):
* html/BaseCheckableInputType.h:
* html/CheckboxInputType.cpp:
(WebCore::CheckboxInputType::handleKeyupEvent):
* html/CheckboxInputType.h:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::defaultEventHandler):
 We remove !implicitSubmission check for callBaseClassEarly because
 implicitSubmission can not be true for keydown event and keypress
 event at this point.
* html/InputType.cpp:
(WebCore::InputType::shouldSubmitImplicitly):
 Returns true for a keypress event with "\r". Note that we don't overload
 this function for BUTTON, FILE, IMAGE, RESET, and SUBMIT because a
 keypress event with "\r" for these types returns from HTMLInputElement::defaultEventHandler()
 before implicit submission checking.
(WebCore::InputType::handleKeypressEvent):
(WebCore::InputType::handleKeyupEvent):
* html/InputType.h:
* html/RadioInputType.cpp:
(WebCore::RadioInputType::handleKeydownEvent):
(WebCore::RadioInputType::handleKeyupEvent):
* html/RadioInputType.h:
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::shouldSubmitImplicitly):
* html/TextFieldInputType.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Benjamin Poulain <benjamin.poulain@nokia.com>
benjamin.poulain@nokia.com [Wed, 1 Dec 2010 04:18:47 +0000 (04:18 +0000)]
2010-11-30  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Implement layoutTestController.findString
        https://bugs.webkit.org/show_bug.cgi?id=50236

        Add support for the new advanced findString().

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::findString):
        * WebCoreSupport/DumpRenderTreeSupportQt.h:
2010-11-30  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Implement layoutTestController.findString
        https://bugs.webkit.org/show_bug.cgi?id=50236

        Add the missing function to the LayoutTestController.

        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::findString):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>
commit-queue@webkit.org [Wed, 1 Dec 2010 03:59:53 +0000 (03:59 +0000)]
2010-11-30  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>

        Reviewed by Martin Robinson.

        [GTK] Fix wrong type in assert return value
        https://bugs.webkit.org/show_bug.cgi?id=50208

        Use appropriate return type in different g_return_val_if_fail(). This
        removes some compiler warning.

        * webkit/webkitwebdatasource.cpp:
        (webkit_web_data_source_is_loading):
        * webkit/webkitwebframe.cpp:
        (webkit_web_frame_page_number_for_element_by_id):
        (webkit_web_frame_number_of_pages):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Rob Buis <rwlbuis@gmail.com>
commit-queue@webkit.org [Wed, 1 Dec 2010 03:38:33 +0000 (03:38 +0000)]
2010-11-30  Rob Buis  <rwlbuis@gmail.com>

        Reviewed by Xan Lopez.

        [gtk] SVGLineElement-dom-requiredFeatures.html and
        SVGLineElement-svgdom-requiredFeatures.html failing in the bots
        https://bugs.webkit.org/show_bug.cgi?id=49529

        Replaced fill with stroke and increased the line size. This fixes
        the problem clicking the element.

        * platform/gtk/Skipped:
        * svg/dynamic-updates/script-tests/SVGLineElement-dom-requiredFeatures.js:
        * svg/dynamic-updates/script-tests/SVGLineElement-svgdom-requiredFeatures.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 1 Dec 2010 03:19:32 +0000 (03:19 +0000)]
2010-11-30  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed speculative build fix for Windows.

        * UIProcess/win/WebView.cpp:
        (WebKit::WebView::pageDidEnterAcceleratedCompositing):
        (WebKit::WebView::pageDidLeaveAcceleratedCompositing):
        (WebKit::WebView::switchToDrawingAreaTypeIfNecessary):
        * UIProcess/win/WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Wed, 1 Dec 2010 03:19:14 +0000 (03:19 +0000)]
2010-11-30  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Andreas Kling.

        Move CSS generator logic into main CMakeLists.txt file
        https://bugs.webkit.org/show_bug.cgi?id=50230

        * CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 1 Dec 2010 03:12:25 +0000 (03:12 +0000)]
2010-11-30  Ojan Vafai  <ojan@chromium.org>

        Revert r72876. It caused a ~30% perf regression in chromium's bloat-http test
        https://bugs.webkit.org/show_bug.cgi?id=50288

        2010-11-29 Adam Barth <abarth@webkit.org (:abarth) (r)>
        Reviewed by Darin Adler.
        Introduce the notion of a "display-isolated" URL scheme for use by Chrome-internal URLs
        https://bugs.webkit.org/show_bug.cgi?id=50182
        A display-isolated URL can only be displayed (e.g., put in an iframe,
        hyperlinked to) by documents from that scheme. In a sense, this is a
        generalization of some of the protections we give file URLs, but
        instead of lumping them all together into one "local" bucket, this
        patch creates a separate bucket for each scheme.
        For a while, I tried using a separate bucket for each origin. That
        would have played nicely with what Blob URLs are trying to do, but some
        "chrome" URL pages rely on being able to display other chrome URL
        pages, even in different origins. For example, the New Tab Page shows
        thumbnails from the "thumbnail" host.
        This patch also removes a bunch of unused code. I've also propagated
        the "deprecated" status of deprecatedCanDisplay to
        deprecatedShouldTreatURLAsLocal because that method has no other
        callers and is really asking for uppercase/lowercase bugs. I dream of
        someday removing these functions.
        page/SecurityOrigin.cpp:
        (WebCore::SecurityOrigin::canDisplay):
        (WebCore::SecurityOrigin::deprecatedCanDisplay):
        platform/SchemeRegistry.cpp:
        (WebCore::displayIsolatedURLSchemes):
        (WebCore::SchemeRegistry::registerURLSchemeAsLocal):
        (WebCore::SchemeRegistry::deprecatedShouldTreatURLAsLocal):
        (WebCore::SchemeRegistry::shouldTreatURLSchemeAsLocal):
        (WebCore::SchemeRegistry::registerURLSchemeAsDisplayIsolated):
        (WebCore::SchemeRegistry::shouldTreatURLSchemeAsDisplayIsolated):
        platform/SchemeRegistry.h:
        2010-11-29 Adam Barth <abarth@webkit.org (:abarth) (r)>
        Reviewed by Darin Adler.
        Introduce the notion of a "display-isolated" URL scheme for use by Chrome-internal URLs
         https://bugs.webkit.org/show_bug.cgi?id=50182
        This patch adds a Chromium API for registering schemes as
        display-isolated. In a subsequent patch, I'll change the "chrome"
        scheme in Chrome to be display isolated instead of local. That will
        prevent file URLs from linking to chrome URLs.
        public/WebSecurityPolicy.h:
        src/WebSecurityPolicy.cpp:
        (WebKit::WebSecurityPolicy::registerURLSchemeAsDisplayIsolated):

        * page/SecurityOrigin.cpp:
        (WebCore::SecurityOrigin::canDisplay):
        (WebCore::SecurityOrigin::deprecatedCanDisplay):
        * platform/SchemeRegistry.cpp:
        (WebCore::SchemeRegistry::registerURLSchemeAsLocal):
        (WebCore::SchemeRegistry::removeURLSchemeRegisteredAsLocal):
        (WebCore::SchemeRegistry::localURLSchemes):
        (WebCore::SchemeRegistry::shouldTreatURLAsLocal):
        (WebCore::SchemeRegistry::shouldTreatURLSchemeAsLocal):
        * platform/SchemeRegistry.h:
2010-11-30  Ojan Vafai  <ojan@chromium.org>

        Revert r72876. It caused a ~30% perf regression in chromium's bloat-http test
        https://bugs.webkit.org/show_bug.cgi?id=50288

        2010-11-29 Adam Barth <abarth@webkit.org (:abarth) (r)>
        Reviewed by Darin Adler.
        Introduce the notion of a "display-isolated" URL scheme for use by Chrome-internal URLs
        https://bugs.webkit.org/show_bug.cgi?id=50182
        A display-isolated URL can only be displayed (e.g., put in an iframe,
        hyperlinked to) by documents from that scheme. In a sense, this is a
        generalization of some of the protections we give file URLs, but
        instead of lumping them all together into one "local" bucket, this
        patch creates a separate bucket for each scheme.
        For a while, I tried using a separate bucket for each origin. That
        would have played nicely with what Blob URLs are trying to do, but some
        "chrome" URL pages rely on being able to display other chrome URL
        pages, even in different origins. For example, the New Tab Page shows
        thumbnails from the "thumbnail" host.
        This patch also removes a bunch of unused code. I've also propagated
        the "deprecated" status of deprecatedCanDisplay to
        deprecatedShouldTreatURLAsLocal because that method has no other
        callers and is really asking for uppercase/lowercase bugs. I dream of
        someday removing these functions.
        2010-11-29 Adam Barth <abarth@webkit.org (:abarth) (r)>
        Reviewed by Darin Adler.
        Introduce the notion of a "display-isolated" URL scheme for use by Chrome-internal URLs
         https://bugs.webkit.org/show_bug.cgi?id=50182
        This patch adds a Chromium API for registering schemes as
        display-isolated. In a subsequent patch, I'll change the "chrome"
        scheme in Chrome to be display isolated instead of local. That will
        prevent file URLs from linking to chrome URLs.

        * public/WebSecurityPolicy.h:
        * src/WebSecurityPolicy.cpp:
2010-11-30  Ojan Vafai  <ojan@chromium.org>

        Revert r72876. It caused a ~30% perf regression in chromium's bloat-http test
        https://bugs.webkit.org/show_bug.cgi?id=50288

        2010-11-29 Adam Barth <abarth@webkit.org (:abarth) (r)>
        Reviewed by Darin Adler.
        Introduce the notion of a "display-isolated" URL scheme for use by Chrome-internal URLs
        https://bugs.webkit.org/show_bug.cgi?id=50182
        A display-isolated URL can only be displayed (e.g., put in an iframe,
        hyperlinked to) by documents from that scheme. In a sense, this is a
        generalization of some of the protections we give file URLs, but
        instead of lumping them all together into one "local" bucket, this
        patch creates a separate bucket for each scheme.
        For a while, I tried using a separate bucket for each origin. That
        would have played nicely with what Blob URLs are trying to do, but some
        "chrome" URL pages rely on being able to display other chrome URL
        pages, even in different origins. For example, the New Tab Page shows
        thumbnails from the "thumbnail" host.
        This patch also removes a bunch of unused code. I've also propagated
        the "deprecated" status of deprecatedCanDisplay to
        deprecatedShouldTreatURLAsLocal because that method has no other
        callers and is really asking for uppercase/lowercase bugs. I dream of
        someday removing these functions.
        2010-11-29 Adam Barth <abarth@webkit.org (:abarth) (r)>
        Reviewed by Darin Adler.
        Introduce the notion of a "display-isolated" URL scheme for use by Chrome-internal URLs
         https://bugs.webkit.org/show_bug.cgi?id=50182
        This patch adds a Chromium API for registering schemes as
        display-isolated. In a subsequent patch, I'll change the "chrome"
        scheme in Chrome to be display isolated instead of local. That will
        prevent file URLs from linking to chrome URLs.

        * Api/qwebsecurityorigin.cpp:
        (QWebSecurityOrigin::localSchemes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 1 Dec 2010 03:00:24 +0000 (03:00 +0000)]
2010-11-30  Ojan Vafai  <ojan@chromium.org>

        [chromium] Update inaccurate test expectation and mark fast/regex/pcre-test-1.html as
        timing out after http://trac.webkit.org/changeset/72990/.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKit duplicates AXValue and AXDescription on abbr
cfleizach@apple.com [Wed, 1 Dec 2010 02:51:51 +0000 (02:51 +0000)]
WebKit duplicates AXValue and AXDescription on abbr
https://bugs.webkit.org/show_bug.cgi?id=50260

Reviewed by Beth Dakin.

WebCore:

stringValue() and accessibilityDescription() were returning the same value for static text with
an aria-label. Static text elements should not have an accessibility description, they
should only have a stringValue.

Test: platform/mac/accessibility/static-text-with-aria-label.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::ariaAccessibilityDescription):
(WebCore::AccessibilityRenderObject::accessibilityDescription):
(WebCore::AccessibilityRenderObject::text):
* accessibility/AccessibilityRenderObject.h:

LayoutTests:

* platform/mac/accessibility/static-text-with-aria-label-expected.txt: Added.
* platform/mac/accessibility/static-text-with-aria-label.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJavaScriptCore: Fixed review comments following bug #48101.
barraclough@apple.com [Wed, 1 Dec 2010 02:46:28 +0000 (02:46 +0000)]
JavaScriptCore: Fixed review comments following bug #48101.
Mostly typos, plus gave quantifyInfinite a symbolic name.

Reviewed by Darin Adler.

* yarr/RegexCompiler.cpp:
(JSC::Yarr::RegexPatternConstructor::quantifyAtom):
(JSC::Yarr::RegexPatternConstructor::checkForTerminalParentheses):
* yarr/RegexInterpreter.cpp:
(JSC::Yarr::Interpreter::backtrackParenthesesOnceEnd):
(JSC::Yarr::Interpreter::matchParenthesesTerminalBegin):
(JSC::Yarr::Interpreter::backtrackParenthesesTerminalBegin):
(JSC::Yarr::Interpreter::backtrackParenthesesTerminalEnd):
* yarr/RegexJIT.cpp:
(JSC::Yarr::RegexGenerator::generatePatternCharacterGreedy):
(JSC::Yarr::RegexGenerator::generatePatternCharacterNonGreedy):
(JSC::Yarr::RegexGenerator::generateCharacterClassGreedy):
* yarr/RegexParser.h:
(JSC::Yarr::Parser::parseTokens):
(JSC::Yarr::parse):

LayoutTests: Ooops, file checked in with incorrect properties.

Reviewed by Darin Adler.

* fast/regex/script-tests/repeat-match-waldemar.js: Removed property svn:executable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Qt build.
andersca@apple.com [Wed, 1 Dec 2010 02:20:09 +0000 (02:20 +0000)]
Fix Qt build.

* UIProcess/API/qt/qgraphicswkview.cpp:
(QGraphicsWKView::takeSnapshot):
(QGraphicsWKViewPrivate::commitScale):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 1 Dec 2010 02:19:41 +0000 (02:19 +0000)]
2010-11-30  Martin Robinson  <mrobinson@igalia.com>

        Rebaseline a GTK+ test.

        * platform/gtk/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Added.
        This platform-specific result is needed because of bug #50303.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChange DrawingArea and DrawingAreaProxy to not inherit from DrawingAreaBase
andersca@apple.com [Wed, 1 Dec 2010 02:11:50 +0000 (02:11 +0000)]
Change DrawingArea and DrawingAreaProxy to not inherit from DrawingAreaBase
https://bugs.webkit.org/show_bug.cgi?id=50300

Reviewed by Sam Weinig.

* UIProcess/API/mac/WKView.mm:
(-[WKView _switchToDrawingAreaTypeIfNecessary:DrawingAreaBase::]):
(-[WKView _pageDidEnterAcceleratedCompositing]):
(-[WKView _pageDidLeaveAcceleratedCompositing]):
* UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:
(WebKit::ChunkedUpdateDrawingAreaProxy::ChunkedUpdateDrawingAreaProxy):
* UIProcess/DrawingAreaProxy.cpp:
(WebKit::DrawingAreaProxy::DrawingAreaProxy):
(WebKit::DrawingAreaProxy::nextDrawingAreaID):
* UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::info):
* UIProcess/LayerBackedDrawingAreaProxy.cpp:
(WebKit::LayerBackedDrawingAreaProxy::LayerBackedDrawingAreaProxy):
* WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:
(WebKit::ChunkedUpdateDrawingArea::ChunkedUpdateDrawingArea):
(WebKit::ChunkedUpdateDrawingArea::didReceiveMessage):
* WebProcess/WebPage/ChunkedUpdateDrawingArea.h:
* WebProcess/WebPage/DrawingArea.cpp:
(WebKit::DrawingArea::create):
(WebKit::DrawingArea::DrawingArea):
* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::info):
* WebProcess/WebPage/LayerBackedDrawingArea.cpp:
(WebKit::LayerBackedDrawingArea::LayerBackedDrawingArea):
(WebKit::LayerBackedDrawingArea::didReceiveMessage):
* WebProcess/WebPage/LayerBackedDrawingArea.h:
* WebProcess/WebPage/TiledDrawingArea.cpp:
(WebKit::TiledDrawingArea::TiledDrawingArea):
* WebProcess/WebPage/TiledDrawingArea.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::changeAcceleratedCompositingMode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 1 Dec 2010 02:09:33 +0000 (02:09 +0000)]
2010-11-30  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        [HTML5] Rename member variables of HTMLScriptElement
        https://bugs.webkit.org/show_bug.cgi?id=49705

        Renamed m_wasCreatedByParser to m_wasInsertedByParser, m_requested to m_isExternalScript,
        m_isEvaluated to m_wasAlreadyStarted, and m_firedLoad to m_haveFiredLoad.

        Also made ScriptElement's haveFiredLoadEvent and removed HTMLScriptElement's haveFiredLoadEvent.
        This effectively adds the same function to SVGScriptElement, which isn't currently used anywhere.

        No new tests are added since this is a refactoring.

        * dom/ScriptElement.cpp:
        (WebCore::ScriptElement::ScriptElement):
        (WebCore::ScriptElement::insertedIntoDocument):
        (WebCore::ScriptElement::childrenChanged):
        (WebCore::ScriptElement::finishParsingChildren):
        (WebCore::ScriptElement::requestScript):
        (WebCore::ScriptElement::evaluateScript):
        (WebCore::ScriptElement::executeScript):
        (WebCore::ScriptElement::ignoresLoadRequest):
        * dom/ScriptElement.h:
        (WebCore::ScriptElement::haveFiredLoadEvent):
        (WebCore::ScriptElement::setHaveFiredLoadEvent):
        (WebCore::ScriptElement::wasInsertedByParser):
        (WebCore::ScriptElement::wasAlreadyStarted):
        * html/HTMLScriptElement.cpp:
        (WebCore::HTMLScriptElement::HTMLScriptElement):
        (WebCore::HTMLScriptElement::create):
        (WebCore::HTMLScriptElement::cloneElementWithoutAttributesAndChildren):
        * html/HTMLScriptElement.h:
        * svg/SVGScriptElement.cpp:
        (WebCore::SVGScriptElement::SVGScriptElement):
        (WebCore::SVGScriptElement::create):
        (WebCore::SVGScriptElement::svgAttributeChanged):
        (WebCore::SVGScriptElement::insertedIntoDocument):
        (WebCore::SVGScriptElement::dispatchLoadEvent):
        (WebCore::SVGScriptElement::cloneElementWithoutAttributesAndChildren):
        * svg/SVGScriptElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoVersioning.
mrowe@apple.com [Wed, 1 Dec 2010 02:00:21 +0000 (02:00 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRolled back most of the FileReaderLoader changes to fix 32-bit builds.
darin@apple.com [Wed, 1 Dec 2010 01:53:21 +0000 (01:53 +0000)]
Rolled back most of the FileReaderLoader changes to fix 32-bit builds.

* fileapi/FileReaderLoader.cpp: Changed types back to unsigned from unsigned long long
* fileapi/FileReaderLoader.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoLayoutTests/fast/regex currently contains a number of test cases ported from PCRE...
barraclough@apple.com [Wed, 1 Dec 2010 01:52:26 +0000 (01:52 +0000)]
LayoutTests/fast/regex currently contains a number of test cases ported from PCRE's test suites.
There are two key problems with these tests:
  * They use their own harness, and cannot be run from jsc without building all of WebKit.
  * They expect PCRE expression syntax, including extended syntax, backwards assertions, etc.

Rubber stamped by Oliver Hunt.

Rewrite all tests to comply to ECMA compatible syntax
(ish - we support octal escapes), and use the normal 'shouldBe' test style.

* fast/js/resources/standalone-pre.js:
(areArraysEqual):
    Fixed bug, where expected is an array we call areArraysEqual,
    this should first check that actual is an array.

* fast/regex/pcre-test-1-expected.txt: Added.
* fast/regex/pcre-test-1.html: Added.
* fast/regex/pcre-test-4-expected.txt: Added.
* fast/regex/pcre-test-4.html: Added.
* fast/regex/script-tests/pcre-test-1.js: Added.
* fast/regex/script-tests/pcre-test-4.js: Added.
    Added new version of PCRE tests.

* fast/regex/pcre-test-runner.js: Removed.
* fast/regex/test1-expected.txt: Removed.
* fast/regex/test1.html: Removed.
* fast/regex/test4-expected.txt: Removed.
* fast/regex/test4.html: Removed.
* fast/regex/testinput1: Removed.
* fast/regex/testinput4: Removed.
* fast/regex/testoutput1: Removed.
* fast/regex/testoutput4: Removed.
    Removed old version of PCRE tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoText search should treat all matches as word-start matches when the target begins...
mitz@apple.com [Wed, 1 Dec 2010 01:48:07 +0000 (01:48 +0000)]
Text search should treat all matches as word-start matches when the target begins with a separator character
https://bugs.webkit.org/show_bug.cgi?id=50302

Reviewed by Darin Adler.

WebCore:

* editing/TextIterator.cpp:
(WebCore::SearchBuffer::SearchBuffer): Disable the AtWordStarts option if it was specified and
the target string begins with one of the "separator" characters.

LayoutTests:

* editing/text-iterator/findString.html:
* editing/text-iterator/findString-expected.txt:
* platform/mac-leopard/editing/text-iterator: Removed.
* platform/mac-leopard/editing/text-iterator/findString-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 1 Dec 2010 01:42:33 +0000 (01:42 +0000)]
2010-11-30  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Dave Hyatt.

        Web Inspector: [CRASH] on "Revert to this revision" of style with import.
        https://bugs.webkit.org/show_bug.cgi?id=50256

        Rolled back one line from http://trac.webkit.org/changeset/36904 as agreed with
        David.

        * css/CSSImportRule.cpp:
        (WebCore::CSSImportRule::insertedIntoParent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 1 Dec 2010 01:36:11 +0000 (01:36 +0000)]
2010-11-30  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] fillRect shadow has incorrect behavior when using ctx.scale(x,y)
        https://bugs.webkit.org/show_bug.cgi?id=50283

        Add platform exceptions for these tests. While this change fixes most issues
        with them there are still bugs with our shadow code which prevents a total
        pass.

        * platform/gtk/fast/canvas/canvas-scale-fillPath-shadow-expected.txt: Added.
        * platform/gtk/fast/canvas/canvas-scale-fillRect-shadow-expected.txt: Added.
2010-11-30  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] fillRect shadow has incorrect behavior when using ctx.scale(x,y)
        https://bugs.webkit.org/show_bug.cgi?id=50283

        Adjust the mask rectangle for Cairo shadows, so that the origin
        is not affected by the scale of the transformation matrix.

        * platform/graphics/ContextShadow.h: Make this Qt-only member global.
        * platform/graphics/cairo/ContextShadowCairo.cpp:
        (WebCore::ContextShadow::beginShadowLayer): Save the original layer area.
        (WebCore::ContextShadow::endShadowLayer): If the target context has a scale
        transform, make sure not to scale the blur distance when blitting the shadow.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 1 Dec 2010 01:27:45 +0000 (01:27 +0000)]
2010-11-30  Darin Adler  <darin@apple.com>

        Reviewed by Alexey Proskuryakov.

        Make ProgressEvent 64-bit instead of 32-bit
        https://bugs.webkit.org/show_bug.cgi?id=50289

        * dom/ProgressEvent.cpp:
        (WebCore::ProgressEvent::ProgressEvent): Changed arguments to unsigned long long.
        (WebCore::ProgressEvent::initProgressEvent): Ditto.

        * dom/ProgressEvent.h: Fixed formatting. Changed types to unsigned long long.
        Made isProgressEvent override private.

        * dom/ProgressEvent.idl: Tweaked formatting and changed types to unsigned long long.

        * fileapi/FileReader.cpp: Removed unneeded includes.
        Used static on const so we'd get an error if the same constant was in a header.
        (WebCore::FileReader::didReceiveData): Removed unneeded WTF prefix.
        (WebCore::FileReader::fireEvent): Got rid of local variables that would narrow
        bytes loaded and total bytes to 32-bit.

        * fileapi/FileReaderLoader.cpp:
        (WebCore::FileReaderLoader::didReceiveResponse): Restructured code a bit and
        added comments. Also added handling for when ArrayBuffer::create returns 0.
        (WebCore::FileReaderLoader::didReceiveData): Fixed handling of case where more
        data arrives than is expected so it won't overrun the buffer. Also broke an
        assertion into two and improved a comment.

        * fileapi/FileReaderLoader.h: Changed bytesLoaded and totalBytes to unsigned long long.

        * fileapi/FileWriter.cpp:
        (WebCore::FileWriter::fireEvent): Removed narrowing casts in call to
        ProgressEvent::create.

        * html/canvas/ArrayBuffer.cpp:
        (WebCore::ArrayBuffer::tryAllocate): Added a comment because the code here seems wrong.

        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::didSendData): Removed narrowing casts in call to
        XMLHttpRequestProgressEvent::create.
        (WebCore::XMLHttpRequest::didReceiveData): Removed narrowing casts in call to
        dispatchProgressEvent.

        * xml/XMLHttpRequestProgressEvent.h: Fixed formatting. Changed types to unsigned long long.
        Made isXMLHttpRequestProgressEvent override private.

        * xml/XMLHttpRequestProgressEvent.idl: Tweaked formatting and changed types to unsigned long long.

        * xml/XMLHttpRequestProgressEventThrottle.cpp:
        (WebCore::XMLHttpRequestProgressEventThrottle::dispatchProgressEvent): Changed types to
        unsigned long long.

        * xml/XMLHttpRequestProgressEventThrottle.h: Changed types to unsigned long long.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Wed, 1 Dec 2010 01:11:45 +0000 (01:11 +0000)]
2010-11-30  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Darin Adler.

        WTF project missing build-stopping code from its pre-build event
        https://bugs.webkit.org/show_bug.cgi?id=50281

        * JavaScriptCore.vcproj/WTF/WTFPreBuild.cmd:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 1 Dec 2010 00:59:03 +0000 (00:59 +0000)]
2010-11-30  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Sam Weinig.

        Context menus broken after WebKit2 goes into accelerated composting mode.
        https://bugs.webkit.org/show_bug.cgi?id=50296

        Override hitTest: on the WKView to exclude the child layer-backed view from
        hit testing, so that context menus work.

        * UIProcess/API/mac/WKView.mm:
        (-[WKView hitTest:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix.
mrowe@apple.com [Wed, 1 Dec 2010 00:56:49 +0000 (00:56 +0000)]
Build fix.

Reviewed by Sam Weinig.

* Configurations/BaseTarget.xcconfig: Don't run Copy Files and Run Script build phases
during installhdrs. It's not necessary, and it results in Xcode attempting to copy the
plug-in shim dylib when it has not yet been built.
* WebKit2.xcodeproj/project.pbxproj: Stop copying the .xcconfig file in to the application
wrapper.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix build.
andersca@apple.com [Wed, 1 Dec 2010 00:53:31 +0000 (00:53 +0000)]
Fix build.

* Scripts/webkit2/messages.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Wed, 1 Dec 2010 00:40:17 +0000 (00:40 +0000)]
2010-11-30  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Darin Adler.

        Cleanup UTF8.cpp
        https://bugs.webkit.org/show_bug.cgi?id=49581

        Use macros and functions instead of range values directly.

        * wtf/unicode/UTF8.cpp:
        (WTF::Unicode::inlineUTF8SequenceLength):
        (WTF::Unicode::UTF8SequenceLength):
        (WTF::Unicode::convertUTF16ToUTF8):
        (WTF::Unicode::readUTF8Sequence):
        (WTF::Unicode::convertUTF8ToUTF16):
        * wtf/unicode/UnicodeMacrosFromICU.h: Added U_IS_SUPPLEMENTARY macro.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRename DrawingAreaBase.h to DrawingAreaInfo.h.
andersca@apple.com [Wed, 1 Dec 2010 00:37:28 +0000 (00:37 +0000)]
Rename DrawingAreaBase.h to DrawingAreaInfo.h.

Reviewed by Sam Weinig.

* Shared/DrawingAreaInfo.h: Renamed from WebKit2/Shared/DrawingAreaBase.h.
(WebKit::DrawingAreaBase::DrawingAreaInfo::DrawingAreaInfo):
(WebKit::DrawingAreaBase::~DrawingAreaBase):
(WebKit::DrawingAreaBase::info):
(WebKit::DrawingAreaBase::DrawingAreaBase):
* Shared/WebPageCreationParameters.h:
* UIProcess/DrawingAreaProxy.h:
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebPage/DrawingArea.h:
* win/WebKit2.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 1 Dec 2010 00:32:06 +0000 (00:32 +0000)]
2010-11-30  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Ojan Vafai.

        REGRESSION(r72861): editing/selection/click-left-of-rtl-wrapping-text.html and
        modify-up-on-rtl-wrapping-text.html fail on all but Mac platform
        https://bugs.webkit.org/show_bug.cgi?id=50204

        Fixed the tests. Instead of using "ex" to specify the width of the container div,
        the tests now auto-detect the correct width by comparing the computed height to
        the expected height deduced from the height of one line and the expected number of lines.

        * editing/selection/click-left-of-rtl-wrapping-text-expected.txt:
        * editing/selection/click-left-of-rtl-wrapping-text.html:
        * editing/selection/modify-up-on-rtl-wrapping-text.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoProgress and meter elements should take a form in their constructor like any other...
yael.aharon@nokia.com [Wed, 1 Dec 2010 00:13:33 +0000 (00:13 +0000)]
Progress and meter elements should take a form in their constructor like any other form control.
https://bugs.webkit.org/show_bug.cgi?id=50195

Reviewed by Darin Adler.

WebCore:

Tests: fast/dom/HTMLMeterElement/meter-element-form.html
       fast/dom/HTMLProgressElement/progress-element-form.html

* html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::HTMLMeterElement):
(WebCore::HTMLMeterElement::create):
* html/HTMLMeterElement.h:
* html/HTMLProgressElement.h:
* html/HTMLTagNames.in:

LayoutTests:

* fast/dom/HTMLMeterElement/meter-element-form-expected.txt: Added.
* fast/dom/HTMLMeterElement/meter-element-form.html: Added.
* fast/dom/HTMLProgressElement/progress-element-form-expected.txt: Added.
* fast/dom/HTMLProgressElement/progress-element-form.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 1 Dec 2010 00:01:42 +0000 (00:01 +0000)]
2010-11-30  Tony Chang  <tony@chromium.org>

        Unreviewed, remove dupe expectation for chromium win drt.

        * platform/chromium/drt_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 30 Nov 2010 23:55:46 +0000 (23:55 +0000)]
2010-11-30  Tony Chang  <tony@chromium.org>

        Reviewed by Adam Barth.

        [chromium] fix get-int-identifier-special-values.html using TestNetscapePlugIn
        https://bugs.webkit.org/show_bug.cgi?id=49036

        No new tests: Covered by plugins/npruntime/get-int-identifier-special-values.html

        In http://codereview.chromium.org/11574, the forked chromium test
        plugin changed how it testGetIntIdentifier to work around a change
        caused by a silverlight specific plugin fix:
        http://codereview.chromium.org/11569/diff/1/2

        It's not clear to me that this change is needed anymore since
        silverlight has had multiple releases, testing without this patch
        works on a test windows build, and safari win seems to run silverlight
        without this either.  Since there's no test for this behavior, I'm
        rolling it out so we can match the upstream test.

        * bindings/v8/V8NPUtils.cpp:
        (WebCore::convertV8ObjectToNPVariant):
2010-11-30  Tony Chang  <tony@chromium.org>

        Reviewed by Adam Barth.

        [chromium] fix get-int-identifier-special-values.html using TestNetscapePlugIn
        https://bugs.webkit.org/show_bug.cgi?id=49036

        * DumpRenderTree/chromium/LayoutTestController.cpp: Use IsNumber instead of IsInt32
            for CppVariants.
        (LayoutTestController::cppVariantToBool):
        (LayoutTestController::cppVariantToInt32):
        (LayoutTestController::setDatabaseQuota):
        (LayoutTestController::evaluateInWebInspector):
        (LayoutTestController::setMockGeolocationError):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix build.
andersca@apple.com [Tue, 30 Nov 2010 23:48:07 +0000 (23:48 +0000)]
Fix build.

* PluginProcess/mac/PluginProcessShim.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a simple shim function for Debugger().
andersca@apple.com [Tue, 30 Nov 2010 23:44:16 +0000 (23:44 +0000)]
Add a simple shim function for Debugger().
https://bugs.webkit.org/show_bug.cgi?id=50268

Reviewed by Dan Bernstein.

* PluginProcess/PluginProcess.h:
* PluginProcess/mac/PluginProcessMac.mm:
(WebKit::initShouldCallRealDebugger):
We only want to call the real Debugger() function when USERBREAK is set.

(WebKit::shouldCallRealDebugger):
Return whether USERBREAK is set.

(WebKit::PluginProcess::initializeShim):
Initialize the shim.

* PluginProcess/mac/PluginProcessMainMac.mm:
(WebKit::PluginProcessMain):
Call PluginProcess::initializeShim.

* PluginProcess/mac/PluginProcessShim.cpp:
(WebKit::WebKitPluginProcessShimInitialize):
This now takes a struct of callbacks.

(WebKit::shimDebugger):
Call the shouldCallDebugger function. If it returns true, the real Debugger() function should be called.

* PluginProcess/mac/PluginProcessShim.h:
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 30 Nov 2010 23:31:52 +0000 (23:31 +0000)]
2010-11-30  Tony Chang  <tony@chromium.org>

        Unreviewed, try to green the chromium win DRT bot.

        * platform/chromium/drt_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 30 Nov 2010 23:27:36 +0000 (23:27 +0000)]
2010-11-30  Ojan Vafai  <ojan@chromium.org>

        [chromium] Mark failing tests after http://trac.webkit.org/changeset/72962/
        to green the chromium tree.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Chris Guillory <chris.guillory@google.com>
inferno@chromium.org [Tue, 30 Nov 2010 23:21:15 +0000 (23:21 +0000)]
2010-11-30  Chris Guillory  <chris.guillory@google.com>

        Reviewed by Chris Fleizach.

        Computing style on a stale node while sending pending accessibility notification.
        https://bugs.webkit.org/show_bug.cgi?id=50162

        Retain node pointer members of AccessibilityImageMapLink.

        Test: accessibility/image-map-title-causes-crash.html

        * accessibility/AccessibilityImageMapLink.cpp:
        (WebCore::AccessibilityImageMapLink::parentObject):
        (WebCore::AccessibilityImageMapLink::anchorElement):
        (WebCore::AccessibilityImageMapLink::url):
        (WebCore::AccessibilityImageMapLink::elementRect):
        * accessibility/AccessibilityImageMapLink.h:
        (WebCore::AccessibilityImageMapLink::areaElement):
        (WebCore::AccessibilityImageMapLink::mapElement):
        (WebCore::AccessibilityImageMapLink::node):
        * dom/Document.cpp:
        (WebCore::Document::clearAXObjectCache):
2010-11-30  Chris Guillory  <chris.guillory@google.com>

        Reviewed by Chris Fleizach.

        Computing style on a stale node while sending pending accessibility notification.
        https://bugs.webkit.org/show_bug.cgi?id=50162

        * accessibility/image-map-title-causes-crash-expected.txt: Added.
        * accessibility/image-map-title-causes-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 James Robinson <jamesr@chromium.org>
jamesr@google.com [Tue, 30 Nov 2010 23:17:48 +0000 (23:17 +0000)]
2010-11-30  James Robinson  <jamesr@chromium.org>

        Reviewed by Tony Chang.

        Build fix - add parens in foo || bar && baz to make gcc happy
        https://bugs.webkit.org/show_bug.cgi?id=50276

        gcc 4.4 warns that statements of the form "foo || bar && baz".  It wants
        parens around the "bar && baz" part to make it clear which way the logical
        operators bind.

        * editing/TextIterator.cpp:
        (WebCore::SearchBuffer::search):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFixed a crash seen when using a PageAllocation to store itself.
ggaren@apple.com [Tue, 30 Nov 2010 22:57:02 +0000 (22:57 +0000)]
Fixed a crash seen when using a PageAllocation to store itself.

Reviewed by Gavin Barraclough.

* wtf/PageAllocation.h:
(WTF::PageAllocation::systemDeallocate): Zero out m_base before unmapping
it, in case unmapping m_base unmaps the PageAllocation.

* wtf/BumpPointerAllocator.h:
(WTF::BumpPointerPool::destroy): Now this work-around isn't needed!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 30 Nov 2010 22:50:12 +0000 (22:50 +0000)]
2010-11-30  Eric Seidel  <eric@webkit.org>

        Reviewed by Tony Chang.

        update-webkit should call git fetch before git svn rebase
        https://bugs.webkit.org/show_bug.cgi?id=50273

        After discussion on webkit-dev, we've decided to move the "default"
        git setup to pulling updates from git.webkit.org in preference
        to rebuilding the local svn index using git svn fetch every time.

        This change should have no effect on people using the "old" git setup
        and should dramatically increase the speed of updates for those using
        the "new" git setup along with update-webkit.  I'm about to move the
        EWS and other queues over to this setup once this lands.

        * Scripts/update-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 James Robinson <jamesr@chromium.org>
jamesr@google.com [Tue, 30 Nov 2010 22:30:09 +0000 (22:30 +0000)]
2010-11-30  James Robinson  <jamesr@chromium.org>

        Reviewed by Dimitri Glazkov.

        [chromium] Update yasm entry in DEPS to match downstream
        https://bugs.webkit.org/show_bug.cgi?id=50274

        http://src.chromium.org/viewvc/chrome?view=rev&revision=67540 changed the downstream DEPS rule
        for yasm to pull unconditionally rather than pulling in each deps_os.  This changes the WebKit
        chromium DEPS to match.

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 30 Nov 2010 22:18:54 +0000 (22:18 +0000)]
2010-11-30  Ojan Vafai  <ojan@chromium.org>

        [chromium] Add new expected result after http://trac.webkit.org/changeset/72689
        and update test expectations to match the builders and pull the appropriate bits
        from the downstream expectations file.

        * platform/chromium-mac/fast/repaint/block-layout-inline-children-replaced-expected.checksum:
        * platform/chromium-mac/fast/repaint/block-layout-inline-children-replaced-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Tue, 30 Nov 2010 22:07:13 +0000 (22:07 +0000)]
2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Xan Lopez.

        GTK: AX: implement press in DRT
        https://bugs.webkit.org/show_bug.cgi?id=36146

        Unskipped test accessibility/label-element-press.html.

        * platform/gtk/Skipped: Unskip passing test.
2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Xan Lopez.

        GTK: AX: implement press in DRT
        https://bugs.webkit.org/show_bug.cgi?id=36146

        Implement AccessibilityUIElement::press() for GTK.

        * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
        (AccessibilityUIElement::press): Implemented.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Tue, 30 Nov 2010 21:57:16 +0000 (21:57 +0000)]
2010-11-30  Daniel Bates  <dbates@rim.com>

        Reviewed by David Hyatt.

        Focused <area> should use CSS properties of <area> instead of associated <img>
        https://bugs.webkit.org/show_bug.cgi?id=49888

        Fixes an issue where the CSS properties of an <area> were not used when
        the <area> was focused.

        Currently, when focusing an <area> (say by pressing option + tab in Mac
        Safari) we use the CSS style information for the <img> associated with
        the <area>. Instead, we should use the CSS style information for the
        focused <area>. In particular, this will make the us honor the outline-
        color property of a focused <area> when drawing its focus ring.

        Tests: fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map.html
               fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map.html
               fast/images/imagemap-focus-ring-outline-color.html

        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::paintFocusRing): Use the style information of
        the focused <area> when drawing the focus ring for it.
2010-11-30  Daniel Bates  <dbates@rim.com>

        Reviewed by David Hyatt.

        Focused <area> should use CSS properties of <area> instead of associated <img>
        https://bugs.webkit.org/show_bug.cgi?id=49888

        Updated the test result for test fast/images/imagemap-focus-ring.html. Added
        test to verify that the color of the focus ring for a focused <area> is
        the outline-color specified by the :focus pseudo-class .

        Also, added tests to ensure that outline-color is not inherited (by default) as per
        section 18.4 of the CSS 2.1 spec <http://www.w3.org/TR/CSS2/ui.html#dynamic-outlines>,
        unless explicitly inherited.

        * fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map.html: Added.
        * fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map.html: Added.
        * fast/images/imagemap-focus-ring-outline-color.html: Added.
        * platform/mac/fast/images/imagemap-focus-ring-expected.checksum: Updated result.
        * platform/mac/fast/images/imagemap-focus-ring-expected.png: Ditto.
        * platform/mac/fast/images/imagemap-focus-ring-outline-color-expected.checksum: Added.
        * platform/mac/fast/images/imagemap-focus-ring-outline-color-expected.png: Added.
        * platform/mac/fast/images/imagemap-focus-ring-outline-color-expected.txt: Added.
        * platform/mac/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.checksum: Added.
        * platform/mac/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.png: Added.
        * platform/mac/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.txt: Added.
        * platform/mac/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.checksum: Added.
        * platform/mac/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.png: Added.
        * platform/mac/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 30 Nov 2010 21:56:03 +0000 (21:56 +0000)]
2010-11-30  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Darin Adler.

        m_hasNonEnumerableProperties is never initialized in Structure
        https://bugs.webkit.org/show_bug.cgi?id=50266

        * runtime/Structure.cpp:
        (JSC::Structure::Structure): initialize member variable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 30 Nov 2010 21:49:25 +0000 (21:49 +0000)]
2010-11-30  Tony Chang  <tony@chromium.org>

        Reviewed by James Robinson.

        [chromium] enable WebCore compiler warnings on Linux take 3
        https://bugs.webkit.org/show_bug.cgi?id=50258

        * WebCore.gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 30 Nov 2010 21:38:55 +0000 (21:38 +0000)]
2010-11-30  Ojan Vafai  <ojan@chromium.org>

        [chromium] Update expectations to de-orange the builders.

        * platform/chromium-gpu/test_expectations.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Tue, 30 Nov 2010 21:16:14 +0000 (21:16 +0000)]
2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Chris Fleizach.

        [GTK] Implement ROLE_COMBO_BOX
        https://bugs.webkit.org/show_bug.cgi?id=25678

        Implement the remaining bits for combo boxes.

        This patch finishes the implementation, from the point of view of
        the Atk library, of those objects exposed to ATK as combo boxes,
        and their related elements (menus and menu items). It therefore
        implements the proper interfaces for each type of object related
        to combo boxes (AtkSelection for the combo box, AtkText for every
        menu item and AtkAction for the combo box, the menu and the menu
        items), takes care of emitting the proper signals when focus or a
        given a selection changes and adds a new unit test to check all
        this new stuff.

        Make possible to ask an AccessibleMenuListOption for a sensible
        string representation, so far only available through the private
        and MSAA related method nameForMSAA. Just moved the implementation
        of that method to an overriden version of stringValue(), which is
        platform independent, and called that from nameForMSAA().

        * accessibility/AccessibilityMenuListOption.h:
        * accessibility/AccessibilityMenuListOption.cpp:
        (WebCore::AccessibilityMenuListOption::nameForMSAA): Just call to
        stringValue(), which holds from now on that used to be here.
        (WebCore::AccessibilityMenuListOption::stringValue): New, override
        of AccessibilityObject::stringValue() to return a proper string.

        Emit the missing signals when a selection is made.

        * accessibility/gtk/AXObjectCacheAtk.cpp:
        (WebCore::AXObjectCache::postPlatformNotification): Emit the usual
        'focus' signals when a selection is made over the combo box.

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (setAtkStateSetFromCoreObject): Ensure the EXPANDABLE and EXPANDED
        Atk states are added to the state set when needed.
        (listObjectForSelection): New, returns the proper list object (the
        one holding the list of available options as its children) for an
        specific AtkObject implementing AtkSelection. This is needed
        because sometimes the selectable options are not directly children
        of the AtkSelection object (i.e. a combo box has a 'menu' object
        as its only child of it, holding the list of options as children).
        (optionFromList): Use listObjectForSelection() to get the actual
        object holding the list of children as the available options.
        (optionFromSelection): Add support for combo boxes.
        (webkit_accessible_selection_add_selection): Ditto.
        (webkit_accessible_selection_clear_selection): Ditto.
        (webkit_accessible_selection_get_selection_count): Ditto.
        (webkit_accessible_selection_is_child_selected): Ditto.
        (webkit_accessible_selection_remove_selection): Ditto.
        (webkit_accessible_text_get_text): Makes sure stringValue() is
        considered to get the result substring when it was already
        considered when checking the maximum text length for the object.
        (getInterfaceMaskFromObject): Make sure the AtkSelection interface
        is implemented for the combo boxes, that the AtkText is
        implemented for the menu items and that the AtkAction interface is
        now implemented for every object (WebCore will decide what to do).

        Avoid a segfault crash when using this from unit tests.

        * platform/gtk/PopupMenuGtk.cpp:
        (WebCore::PopupMenuGtk::show): Make sure we got a valid GdkWindow
        before calling gdk_window_get_origin() over it.
2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Chris Fleizach.

        [GTK] Implement ROLE_COMBO_BOX
        https://bugs.webkit.org/show_bug.cgi?id=25678

        New test to check the implementation of the combo boxes.

        * tests/testatk.c:
        (testWebkitAtkComboBox): New test, checking that the roles and the
        implemented interfaces for a combo box and its descendants work.
        (main): Added the new unit test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPass the plug-in process shim in DYLD_INSERT_LIBRARIES when launching the plug-in...
andersca@apple.com [Tue, 30 Nov 2010 21:05:47 +0000 (21:05 +0000)]
Pass the plug-in process shim in DYLD_INSERT_LIBRARIES when launching the plug-in process
https://bugs.webkit.org/show_bug.cgi?id=50262

Reviewed by Sam Weinig.

* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
Add an EnvironmentVariables class that allows for easy modification of the environment variables
passed to posix_spawn.

(WebKit::ProcessLauncher::launchProcess):
When spawning the plug-in process, insert the plug-in process shim.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Tue, 30 Nov 2010 20:59:00 +0000 (20:59 +0000)]
2010-11-30  Andreas Kling  <kling@webkit.org>

        Reviewed by Tor Arne Vestbø.

        [Qt] GraphicsContext: Avoid unnecessarily copying the painter's QTransform

        Stash the transform in a const reference (QPainter::transform() returns one)
        instead of making a copy in the shadow drawing parts of fillPath, strokePath and fillRect.

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::strokePath):
        (WebCore::GraphicsContext::fillRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd plug-in process shim
andersca@apple.com [Tue, 30 Nov 2010 20:53:08 +0000 (20:53 +0000)]
Add plug-in process shim
https://bugs.webkit.org/show_bug.cgi?id=50261

Reviewed by Sam Weinig.

* Configurations/PluginProcessShim.xcconfig: Added.
* PluginProcess/mac/PluginProcessShim.cpp: Added.
(PluginProcessShimInitialize):
* PluginProcess/mac/PluginProcessShim.h: Added.
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-29 Vangelis Kokkevis <vangelis@chromium.org>
vangelis@chromium.org [Tue, 30 Nov 2010 20:41:59 +0000 (20:41 +0000)]
2010-11-29  Vangelis Kokkevis  <vangelis@chromium.org>

        Reviewed by Simon Fraser.

        Provide more fine grained control to ports over when to turn on accelerated
        compositing.
        https://bugs.webkit.org/show_bug.cgi?id=49998

        As part of this change, the old hasAcceleratedCompositing method on the ChromeClient
        has now been replaced by allowedCompositingTriggers which returns a bitfield of
        all the features which can trigger the compositor.

        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::allowedCompositingTriggers):
        * src/ChromeClientImpl.h:
2010-11-29  Vangelis Kokkevis  <vangelis@chromium.org>

        Reviewed by Simon Fraser.

        Provide more fine grained control to ports over when to turn on accelerated
        compositing.
        https://bugs.webkit.org/show_bug.cgi?id=49998

        As part of this change, the old hasAcceleratedCompositing method on the ChromeClient
        has now been replaced by allowedCompositingTriggers which returns a bitfield of
        all the features which can trigger the compositor.

        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::allowedCompositingTriggers):
        * WebCoreSupport/ChromeClientQt.h:
2010-11-30  Vangelis Kokkevis  <vangelis@chromium.org>

        Reviewed by Simon Fraser.

        Provide more fine grained control to ports over when to turn on
        accelerated compositing.
        https://bugs.webkit.org/show_bug.cgi?id=49998

        The RenderLayerCompositor now checks with the chrome client whether
        3d transforms, video, plugins, canvas and animation require
        switching over to the composited path. Layers that overlap composited
        content will still turn into composited layers regardless of the
        setting.

        * css/MediaQueryEvaluator.cpp:
        (WebCore::transform_3dMediaFeatureEval):
        * page/ChromeClient.h:
        (WebCore::ChromeClient::allowedCompositingTriggers):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::canRender3DTransforms):
        (WebCore::RenderLayer::updateTransform):
        (WebCore::RenderLayer::currentTransform):
        * rendering/RenderLayer.h:
        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::updateLayerTransform):
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::RenderLayerCompositor):
        (WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags):
        (WebCore::RenderLayerCompositor::canRender3DTransforms):
        (WebCore::RenderLayerCompositor::requiresCompositingLayer):
        (WebCore::RenderLayerCompositor::requiresCompositingForTransform):
        (WebCore::RenderLayerCompositor::requiresCompositingForVideo):
        (WebCore::RenderLayerCompositor::requiresCompositingForCanvas):
        (WebCore::RenderLayerCompositor::requiresCompositingForPlugin):
        (WebCore::RenderLayerCompositor::requiresCompositingForAnimation):
        * rendering/RenderLayerCompositor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Tue, 30 Nov 2010 20:35:49 +0000 (20:35 +0000)]
2010-11-30  Daniel Bates  <dbates@rim.com>

        Reviewed by Alexey Proskuryakov.

        Change and focus events happen in different order if using tab vs. clicking
        https://bugs.webkit.org/show_bug.cgi?id=6181

        Tests to ensure adherence to section 7.4.2 of the HTML5 spec.
        <http://www.w3.org/TR/html5/editing.html#focus-management> with respect to
        focusing on an <input>, modifying its contents, and defocusing it either by
        pressing the tab key or clicking on another element.

        * fast/events/check-defocus-event-order-when-triggered-by-mouse-click-expected.txt: Added.
        * fast/events/check-defocus-event-order-when-triggered-by-mouse-click.html: Added.
        * fast/events/check-defocus-event-order-when-triggered-by-tab-expected.txt: Added.
        * fast/events/check-defocus-event-order-when-triggered-by-tab.html: Added.
        * fast/events/resources/record-events.js: Added.
        (registerElementsAndEventsToRecord):
        (beginRecordingEvents.callback):
        (beginRecordingEvents):
        (endRecordingEvents.callback):
        (endRecordingEvents):
        (_processEachRegisteredElement):
        (_recordEvent):
        (checkThatEventsFiredInOrder.eventTarget):
        (checkThatEventsFiredInOrder.elementIdOrTagName):
        (checkThatEventsFiredInOrder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Tue, 30 Nov 2010 20:27:06 +0000 (20:27 +0000)]
2010-11-30  Xiaomei Ji  <xji@chromium.org>

        Reviewed by David Hyatt.

        Scroll position might not be exactly the same after page ZoomIn and ZoomOut, for example, they are not exactly the same in Windows platform.
        Change to test that the scroll position before and after ZoomIn/Out are close enough.
        Rebaseline horizontal-scrollbar-when-dir-change in Win7.

        * fast/dom/horizontal-scrollbar-in-rtl.html:
        * platform/win/fast/dom/horizontal-scrollbar-when-dir-change-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 30 Nov 2010 20:18:30 +0000 (20:18 +0000)]
2010-11-30 Xan Lopez <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Plug leak in SoupCache
        https://bugs.webkit.org/show_bug.cgi?id=50142

        Free the cache file contents when we don't need them anymore.

        * platform/network/soup/cache/webkit/soup-cache.c:
        (webkit_soup_cache_load):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix the Windows build by copying WKFindOptions.h into WebKitOutputDir with the other...
bweinstein@apple.com [Tue, 30 Nov 2010 20:02:08 +0000 (20:02 +0000)]
Fix the Windows build by copying WKFindOptions.h into WebKitOutputDir with the other headers.

* win/WebKit2Generated.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 30 Nov 2010 20:00:37 +0000 (20:00 +0000)]
2010-11-30  Ojan Vafai  <ojan@chromium.org>

        [chromium] New expected result after http://trac.webkit.org/changeset/72926/.
        That patch unintentionally fixed a bug where the skia codepath was drawing paths twice.
        The new results better match the platform/mac results (borders are grey instead of black).

        * platform/chromium-linux/svg/W3C-SVG-1.1/coords-units-01-b-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/coords-units-01-b-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1/painting-render-01-b-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/painting-render-01-b-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.png:
        * platform/chromium-linux/svg/batik/paints/patternPreserveAspectRatioA-expected.checksum: Added.
        * platform/chromium-linux/svg/batik/paints/patternPreserveAspectRatioA-expected.png: Added.
        * platform/chromium-linux/svg/batik/paints/patternRegionA-expected.checksum:
        * platform/chromium-linux/svg/batik/paints/patternRegionA-expected.png:
        * platform/chromium-linux/svg/batik/paints/patternRegions-expected.checksum:
        * platform/chromium-linux/svg/batik/paints/patternRegions-expected.png:
        * platform/chromium-linux/svg/batik/paints/patternRegions-positioned-objects-expected.checksum:
        * platform/chromium-linux/svg/batik/paints/patternRegions-positioned-objects-expected.png:
        * platform/chromium-linux/svg/custom/pattern-incorrect-tiling-expected.checksum:
        * platform/chromium-linux/svg/custom/pattern-incorrect-tiling-expected.png:
        * platform/chromium-linux/svg/custom/recursive-gradient-expected.checksum:
        * platform/chromium-linux/svg/custom/recursive-gradient-expected.png:
        * platform/chromium-linux/svg/custom/relative-sized-content-with-resources-expected.checksum:
        * platform/chromium-linux/svg/custom/relative-sized-content-with-resources-expected.png:
        * platform/chromium-linux/svg/transforms/text-with-pattern-inside-transformed-html-expected.checksum:
        * platform/chromium-linux/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
        * platform/chromium-linux/svg/transforms/text-with-pattern-with-svg-transform-expected.checksum:
        * platform/chromium-linux/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/coords-units-01-b-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/coords-units-01-b-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/painting-render-01-b-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/painting-render-01-b-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.png:
        * platform/chromium-win/svg/batik/paints/patternPreserveAspectRatioA-expected.checksum:
        * platform/chromium-win/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
        * platform/chromium-win/svg/batik/paints/patternRegionA-expected.checksum:
        * platform/chromium-win/svg/batik/paints/patternRegionA-expected.png:
        * platform/chromium-win/svg/batik/paints/patternRegions-expected.checksum:
        * platform/chromium-win/svg/batik/paints/patternRegions-expected.png:
        * platform/chromium-win/svg/batik/paints/patternRegions-positioned-objects-expected.checksum:
        * platform/chromium-win/svg/batik/paints/patternRegions-positioned-objects-expected.png:
        * platform/chromium-win/svg/custom/pattern-incorrect-tiling-expected.checksum:
        * platform/chromium-win/svg/custom/pattern-incorrect-tiling-expected.png:
        * platform/chromium-win/svg/custom/pattern-y-offset-expected.checksum:
        * platform/chromium-win/svg/custom/pattern-y-offset-expected.png:
        * platform/chromium-win/svg/custom/recursive-gradient-expected.checksum:
        * platform/chromium-win/svg/custom/recursive-gradient-expected.png:
        * platform/chromium-win/svg/custom/relative-sized-content-with-resources-expected.checksum:
        * platform/chromium-win/svg/custom/relative-sized-content-with-resources-expected.png:
        * platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.checksum:
        * platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
        * platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.checksum:
        * platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Andras Becsi <abecsi@webkit.org>
abecsi@webkit.org [Tue, 30 Nov 2010 19:57:02 +0000 (19:57 +0000)]
2010-11-30  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Csaba Osztrogonác.

        [Qt][V8] Make QtWebKit with V8 build on Linux.
        https://bugs.webkit.org/show_bug.cgi?id=50244

        No new tests needed.

        * WebCore.pri: add missing idl file
        * WebCore.pro: enable Linux build
        * bindings/scripts/CodeGeneratorV8.pm: add missing headers
        * bindings/v8/ScriptControllerQt.cpp: fix instantiation
        (WebCore::ScriptController::qtScriptEngine):
        * bindings/v8/V8GCController.cpp: fix guard
        (WebCore::V8GCController::checkMemoryUsage):
        * inspector/CodeGeneratorInspector.pm: add missing header
        * loader/ResourceLoadScheduler.cpp: ditto
        * loader/cache/MemoryCache.cpp: ditto
        * loader/loader.cpp: ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=50183
hyatt@apple.com [Tue, 30 Nov 2010 19:48:39 +0000 (19:48 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=50183

Reviewed by Simon Fraser.

Code got commented out by accident during render tree refactoring last year.  Put the code back in, since
it hurts performance to have that line commented out.

In order to put this code back in, I had to fix some bugs with preferred width computations and
overflow: scroll.  Make the pref widths computation create the scrollbar if it doesn't exist yet.

Make sure the scrollbar size is included prior to checking for defined width/min-width/max-width values.  Otherwise
the scrollbar inflates the width beyond the fixed size that was specified.

For table cells, there is an additional wrinkle.  Make sure not to include the scrollbar size as part of the minimum
intrinsic width so that we don't incorrectly grow.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutPositionedObjects):
(WebCore::RenderBlock::computePreferredLogicalWidths):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computePreferredLogicalWidths):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry to fix the Windows build.
mitz@apple.com [Tue, 30 Nov 2010 19:44:36 +0000 (19:44 +0000)]
Try to fix the Windows build.

* win/WebKit2.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed.
hclam@chromium.org [Tue, 30 Nov 2010 19:35:56 +0000 (19:35 +0000)]
Not reviewed.

Submitted for Kenji Imasaki <imasaki@chromium.org>.

Update test expectations for Chromium to enable expectation analyzer for video.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Vitaly Repeshko <vitalyr@chromium.org>
vitalyr@chromium.org [Tue, 30 Nov 2010 19:35:39 +0000 (19:35 +0000)]
2010-11-30  Vitaly Repeshko  <vitalyr@chromium.org>

        Unreviewed.

        Attempt to fix windows debug chromium build.

        * html/TimeInputType.cpp: Added include providing isfinite.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdded Leopard-specific results for editing/text-iterator/findString.html. In the...
mitz@apple.com [Tue, 30 Nov 2010 19:33:56 +0000 (19:33 +0000)]
Added Leopard-specific results for editing/text-iterator/findString.html. In the Leopard version
of ICU, the full stop character is a word separator, so an at-word-starts search for "org" in
"webkit.org" matches.

* platform/mac-leopard/editing/text-iterator: Added.
* platform/mac-leopard/editing/text-iterator/findString-expected.txt: Copied from LayoutTests/editing/text-iterator/findString-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Vitaly Repeshko <vitalyr@chromium.org>
vitalyr@chromium.org [Tue, 30 Nov 2010 19:31:30 +0000 (19:31 +0000)]
2010-11-30  Vitaly Repeshko  <vitalyr@chromium.org>

        Unreviewed.

        [chromium] Updating test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 30 Nov 2010 19:31:15 +0000 (19:31 +0000)]
2010-11-30  Darin Adler  <darin@apple.com>

        Reviewed by Jon Honeycutt.

        DOM binding code generator scripts import unused File::stat Perl module
        https://bugs.webkit.org/show_bug.cgi?id=50250

        * bindings/scripts/CodeGeneratorCPP.pm: Removed "using File::stat".
        * bindings/scripts/CodeGeneratorJS.pm: Ditto.
        * bindings/scripts/CodeGeneratorObjC.pm: Ditto.
        * bindings/scripts/CodeGeneratorV8.pm: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-29 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Tue, 30 Nov 2010 19:27:41 +0000 (19:27 +0000)]
2010-11-29  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Tony Chang.

        config.webkit_base_dir returns a path with a trailing slash
        https://bugs.webkit.org/show_bug.cgi?id=50197

        config.webkit_base_dir() should return a path without a trailing slash,
        like all the other methods that return paths.

        Undoes MockFileSytem changes by r72640, since they're no longer
        necessary for GetBaselinesTest to pass.

        * Scripts/webkitpy/common/system/filesystem_mock.py:
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/config.py:
        * Scripts/webkitpy/layout_tests/port/config_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Tue, 30 Nov 2010 19:23:38 +0000 (19:23 +0000)]
2010-11-30  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Tony Chang.

        Rebaseline server: baseline display tweaks
        https://bugs.webkit.org/show_bug.cgi?id=50207

        Determine which baselines were used when running the tests and higlight
        them in the UI. Sort platform names alphabetically.

        Also makes the server URL be launched in the user's browser
        automatically.

        * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
        * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
        * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
        * Scripts/webkitpy/tool/commands/rebaselineserver.py:
        * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 30 Nov 2010 19:16:56 +0000 (19:16 +0000)]
2010-11-30  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: implement "Revert to this revision" in resources panel.
        https://bugs.webkit.org/show_bug.cgi?id=50107

        * inspector/Inspector.idl:
        * inspector/InspectorCSSAgent.cpp:
        (WebCore::InspectorCSSAgent::setStyleSheetText2):
        * inspector/InspectorCSSAgent.h:
        * inspector/InspectorStyleSheet.cpp:
        (WebCore::InspectorStyleSheet::reparseStyleSheet):
        * inspector/front-end/CSSStyleModel.js:
        (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback):
        (WebInspector.CSSStyleModel.prototype._styleSheetChanged):
        (WebInspector.CSSStyleModel.prototype._onRevert):
        * inspector/front-end/Resource.js:
        (WebInspector.Resource.prototype.get contentTimestamp):
        (WebInspector.Resource.prototype.setInitialContent):
        (WebInspector.Resource.prototype.isLocallyModified):
        (WebInspector.Resource.prototype.setContent.else.finished):
        (WebInspector.Resource.prototype.setContent):
        (WebInspector.Resource.prototype.revertToThis.callback):
        (WebInspector.Resource.prototype.revertToThis):
        (WebInspector.Resource.prototype.get baseRevision):
        (WebInspector.Resource.prototype._innerRequestContent):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype._showResourceView):
        (WebInspector.FrameResourceTreeElement.prototype._contentChanged):
        (WebInspector.ResourceRevisionTreeElement):
        (WebInspector.ResourceRevisionTreeElement.prototype.onattach):
        (WebInspector.ResourceRevisionTreeElement.prototype._ondragstart):
        (WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.editScriptSource.mycallback):
        (WebInspector.ScriptsPanel.prototype.editScriptSource):
        * inspector/front-end/SourceView.js:
        (WebInspector.SourceView.prototype._editLine):
        (WebInspector.SourceView.prototype._editLineComplete):
        (WebInspector.SourceView.prototype._revertEditLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKit2: Injected bundle support for <rdar://problem/8710645> WebKitTestRunner needs...
mitz@apple.com [Tue, 30 Nov 2010 19:14:56 +0000 (19:14 +0000)]
WebKit2: Injected bundle support for <rdar://problem/8710645> WebKitTestRunner needs layoutTestController.findString
https://bugs.webkit.org/show_bug.cgi?id=50238

Reviewed by Anders Carlsson.

* Shared/API/c/WKFindOptions.h: Added. Moved the definition of WKFindOptions here from WKPage.h.
* Shared/API/c/WKSharedAPICast.h:
(WebKit::toFindOptions): Moved from WKAPICast.h.
* UIProcess/API/C/WKAPICast.h:
* UIProcess/API/C/WKPage.h:
* WebKit2.xcodeproj/project.pbxproj: Added WKFindOptions.h.
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageFindString): Added.
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::findStringFromInjectedBundle): Added.
* WebProcess/WebPage/WebPage.h:

WebKitTools: <rdar://problem/8710645> WebKitTestRunner needs layoutTestController.findString
https://bugs.webkit.org/show_bug.cgi?id=50238

Reviewed by Anders Carlsson.

* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::findString): Added.
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:

LayoutTests: <rdar://problem/8710645> WebKitTestRunner needs layoutTestController.findString
https://bugs.webkit.org/show_bug.cgi?id=50238

Reviewed by Anders Carlsson.

* platform/mac-wk2/Skipped: Removed editing/text-iterator/findString.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoClean up WebCore.vcproj's bindings filter
aroben@apple.com [Tue, 30 Nov 2010 19:02:32 +0000 (19:02 +0000)]
Clean up WebCore.vcproj's bindings filter

I added files that we compile (via an all-in-one file) but weren't in
the .vcproj, removed files that no longer exist, and added the scripts
we use.

Fixes <http://webkit.org/b/50248> WebCore.vcproj's bindings filter is
out-of-date

Reviewed by Darin Adler.

* WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove JSIDB* files to the DerivedSources filter
aroben@apple.com [Tue, 30 Nov 2010 18:35:32 +0000 (18:35 +0000)]
Move JSIDB* files to the DerivedSources filter

This correctly reflects their location on disk. (They were formerly
listed under bindings/js.)

* WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Tue, 30 Nov 2010 18:31:16 +0000 (18:31 +0000)]
2010-11-30  Xiaomei Ji  <xji@chromium.org>

        Reviewed by David Hyatt.

        Remove clampNegativeToZero in adjustScrollPositionWithinRange.
        https://bugs.webkit.org/show_bug.cgi?id=50203

        * platform/ScrollView.cpp:
        (WebCore::ScrollView::adjustScrollPositionWithinRange):
2010-11-30  Xiaomei Ji  <xji@chromium.org>

        Reviewed by David Hyatt.

        Unskip fast/dom/horizontal-scrollbar-in-rtl.html and fast/dom/horizontal-scrollbar-when-dir-change.html in Chromium and Win7.
        Rebaseline after r72852.
        https://bugs.webkit.org/show_bug.cgi?id=50203

        * platform/chromium/test_expectations.txt:
        * platform/win/Skipped:
        * platform/win/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Added.
        * platform/win/fast/dom/horizontal-scrollbar-when-dir-change-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry to fix timing-out tests on WebKit2 by skipping an earlier test
aroben@apple.com [Tue, 30 Nov 2010 18:20:53 +0000 (18:20 +0000)]
Try to fix timing-out tests on WebKit2 by skipping an earlier test

I'll file a bug if this fixes the problem.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove duplicate files from WebCore.vcproj
aroben@apple.com [Tue, 30 Nov 2010 18:20:47 +0000 (18:20 +0000)]
Remove duplicate files from WebCore.vcproj

Rubber-stamped by Steve Falkenburg.

* WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoLet VS do its thang with WebCore.vcproj
aroben@apple.com [Tue, 30 Nov 2010 18:20:12 +0000 (18:20 +0000)]
Let VS do its thang with WebCore.vcproj

I just removed and readded AnimationBase.cpp.

Rubber-stamped by Steve Falkenburg.

* WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Tue, 30 Nov 2010 18:17:19 +0000 (18:17 +0000)]
2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Chris Fleizach.

        ASSERT failing for combo boxes when selection changes
        https://bugs.webkit.org/show_bug.cgi?id=50062

        * fast/forms/select-option-accesskey-crash-expected.txt: Added.
        * fast/forms/select-option-accesskey-crash.html: Added
2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Chris Fleizach.

        ASSERT failing for combo boxes when selection changes
        https://bugs.webkit.org/show_bug.cgi?id=50062

        Don't call listBoxOnChange for elements using menu lists.

        Test: fast/forms/select-option-accesskey-crash.html

        * dom/SelectElement.cpp:
        (WebCore::SelectElement::accessKeySetSelectedIndex): Extra check
        to decide whether to call menuListOnChange() or listBoxOnChange()
        instead of always calling listBoxOnChange().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Tue, 30 Nov 2010 18:13:59 +0000 (18:13 +0000)]
2010-11-30  Andreas Kling  <kling@webkit.org>

        Reviewed by Dirk Schulze.

        GraphicsContext: Remove "current path" and have strokePath, fillPath and clipPath take a Path argument.
        https://bugs.webkit.org/show_bug.cgi?id=48516

        No new tests, this is refactoring only.

        fillPath() -> fillPath(const Path&)
        strokePath() -> strokePath(const Path&)
        clipPath(WindRule) -> clipPath(const Path&, WindRule)

        drawPath() was only used by CG, so made it PLATFORM(CG) specific.

        The Qt, CG and Cairo implementations are best-effort.
        For the rest, I've put beginPath/addPath and FIXMEs in the three affected methods.

        * WebCore.exp.in:
        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::fill):
        (WebCore::CanvasRenderingContext2D::stroke):
        * inspector/InspectorController.cpp:
        (WebCore::drawOutlinedQuad):
        * mathml/RenderMathMLRoot.cpp:
        (WebCore::RenderMathMLRoot::paint):
        * mathml/RenderMathMLSquareRoot.cpp:
        (WebCore::RenderMathMLSquareRoot::paint):
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/GraphicsContextPrivate.h:
        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::strokePath):
        (WebCore::GraphicsContext::clipPath):
        * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::drawEllipse):
        (WebCore::addConvexPolygonToPath):
        (WebCore::GraphicsContext::drawConvexPolygon):
        (WebCore::GraphicsContext::clipConvexPolygon):
        (WebCore::GraphicsContext::drawPath):
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::strokePath):
        (WebCore::GraphicsContext::fillRoundedRect):
        (WebCore::GraphicsContext::clipPath):
        * platform/graphics/haiku/GraphicsContextHaiku.cpp:
        (WebCore::GraphicsContext::strokePath):
        (WebCore::GraphicsContext::fillPath):
        * platform/graphics/openvg/GraphicsContextOpenVG.cpp:
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::strokePath):
        (WebCore::GraphicsContext::clipPath):
        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::restorePlatformState):
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::strokePath):
        (WebCore::GraphicsContext::clipPath):
        (WebCore::GraphicsContext::strokeRect):
        (WebCore::GraphicsContext::translate):
        (WebCore::GraphicsContext::rotate):
        (WebCore::GraphicsContext::scale):
        (WebCore::GraphicsContext::concatCTM):
        * platform/graphics/skia/GraphicsContextSkia.cpp:
        (WebCore::GraphicsContext::clipPath):
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::strokePath):
        * platform/graphics/wince/GraphicsContextWinCE.cpp:
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::strokePath):
        (WebCore::GraphicsContext::clipPath):
        * platform/graphics/wx/GraphicsContextWx.cpp:
        (WebCore::GraphicsContext::clipPath):
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::strokePath):
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintBorder):
        (WebCore::RenderBoxModelObject::paintBoxShadow):
        * rendering/RenderEmbeddedObject.cpp:
        (WebCore::RenderEmbeddedObject::paintReplaced):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::drawBoxSideFromPath):
        * rendering/RenderSVGResource.h:
        (WebCore::RenderSVGResource::postApplyResource):
        * rendering/RenderSVGResourceClipper.cpp:
        (WebCore::RenderSVGResourceClipper::pathOnlyClipping):
        * rendering/RenderSVGResourceFilter.cpp:
        (WebCore::RenderSVGResourceFilter::postApplyResource):
        * rendering/RenderSVGResourceFilter.h:
        * rendering/RenderSVGResourceGradient.cpp:
        (WebCore::RenderSVGResourceGradient::applyResource):
        * rendering/RenderSVGResourceGradient.h:
        * rendering/RenderSVGResourcePattern.cpp:
        (WebCore::RenderSVGResourcePattern::postApplyResource):
        * rendering/RenderSVGResourcePattern.h:
        * rendering/RenderSVGResourceSolidColor.cpp:
        (WebCore::RenderSVGResourceSolidColor::postApplyResource):
        * rendering/RenderSVGResourceSolidColor.h:
        * rendering/SVGRenderSupport.cpp:
        (WebCore::SVGRenderSupport::finishRenderSVGContent):
        * rendering/svg/RenderSVGPath.cpp:
        (WebCore::RenderSVGPath::fillAndStrokePath):
        * rendering/svg/SVGInlineTextBox.cpp:
        (WebCore::SVGInlineTextBox::releasePaintingResource):
        (WebCore::SVGInlineTextBox::restoreGraphicsContextAfterTextPainting):
        (WebCore::SVGInlineTextBox::paintDecorationWithStyle):
        * rendering/svg/SVGInlineTextBox.h:
        * svg/SVGFont.cpp:
        (WebCore::Font::drawTextUsingSVGFont):
2010-11-30  Andreas Kling  <kling@webkit.org>

        Reviewed by Dirk Schulze.

        GraphicsContext: Remove "current path" and have strokePath, fillPath and clipPath take a Path argument
        https://bugs.webkit.org/show_bug.cgi?id=48516

        * UIProcess/FindIndicator.cpp:
        (WebKit::FindIndicator::draw):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Satish Sampath <satish@chromium.org>
satish@chromium.org [Tue, 30 Nov 2010 18:00:50 +0000 (18:00 +0000)]
2010-11-30  Satish Sampath  <satish@chromium.org>

        Unreviewed, updating a speech input pixel test expectations with new baselines.

        * platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.checksum:
        * platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.png:
        * platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.txt:
        * platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.checksum:
        * platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.png:
        * platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.txt:
        * platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.checksum:
        * platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.png:
        * platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Reviewed by Darin Adler and Geoff Garen.
ap@apple.com [Tue, 30 Nov 2010 17:54:26 +0000 (17:54 +0000)]
    Reviewed by Darin Adler and Geoff Garen.

        https://bugs.webkit.org/show_bug.cgi?id=44152
        <rdar://problem/8324423> CSSOM should match DOM in discarding wrapper-less parents.

        We have existing behaviors where parent objects in detached subtrees are not preserved:
        - if a root of a node tree doesn't have a wrapper, it's immediately destroyed, making
        its children parentNode attribute null;
        - relationship between a <style> or <link> node and its stylesheet is immediately broken
        when the node is removed from document (in this case, regardless of wrapper existence).

        Both match Firefox. For consistency, CSSOM should do the same. In fact, it already partially
        does - CSSRule.parentRule gets zeroed out when the parent rule is destroyed.

        Tests: fast/dom/StyleSheet/detached-parent-rule-without-wrapper.html
               fast/dom/StyleSheet/detached-stylesheet-without-wrapper.html

        * css/StyleSheet.cpp: (WebCore::StyleSheet::~StyleSheet): Clear out child rule parent.

        * svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::insertedIntoDocument): Keep
        the new assertion from firing. This function was adding a rule to style sheet, without
        telling the rule about it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Tue, 30 Nov 2010 17:53:14 +0000 (17:53 +0000)]
2010-11-30  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam Roben.

        All projects on Windows should use cmd files for build events
        https://bugs.webkit.org/show_bug.cgi?id=50213

        * WebKit.vcproj/InterfacesCommon.vsprops:
        * WebKit.vcproj/InterfacesPostBuild.cmd: Added.
        * WebKit.vcproj/InterfacesPreBuild.cmd: Added.
        * WebKit.vcproj/WebKitGUIDCommon.vsprops:
        * WebKit.vcproj/WebKitGUIDPostBuild.cmd: Added.
        * WebKit.vcproj/WebKitGUIDPreBuild.cmd: Added.
        * WebKit.vcproj/WebKitLibCommon.vsprops:
        * WebKit.vcproj/WebKitLibPostBuild.cmd: Added.
        * WebKit.vcproj/WebKitLibPreBuild.cmd: Added.
2010-11-30  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam Roben.

        All projects on Windows should use cmd files for build events
        https://bugs.webkit.org/show_bug.cgi?id=50213

        * WebCore.vcproj/QTMovieWinCommon.vsprops:
        * WebCore.vcproj/QTMovieWinPostBuild.cmd: Added.
        * WebCore.vcproj/QTMovieWinPreBuild.cmd: Added.
        * WebCore.vcproj/WebCoreCommon.vsprops:
        * WebCore.vcproj/WebCorePostBuild.cmd: Added.
        * WebCore.vcproj/WebCorePreBuild.cmd: Added.
2010-11-30  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam Roben.

        All projects on Windows should use cmd files for build events
        https://bugs.webkit.org/show_bug.cgi?id=50213

        * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
        * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Added.
        * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Added.
        * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
        * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Added.
        * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Added.
        * DumpRenderTree/win/ImageDiffCommon.vsprops:
        * DumpRenderTree/win/ImageDiffPostBuild.cmd: Added.
        * DumpRenderTree/win/ImageDiffPreBuild.cmd: Added.
        * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops:
        * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
        * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops:
        * MiniBrowser/MiniBrowserPostBuild.cmd: Added.
        * MiniBrowser/MiniBrowserPreBuild.cmd: Added.
        * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
        * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Added.
        * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Added.
        * WebKitAPITest/WebKitAPITestCommon.vsprops:
        * WebKitAPITest/WebKitAPITestPostBuild.cmd: Added.
        * WebKitAPITest/WebKitAPITestPreBuild.cmd: Added.
        * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
        * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
        * WebKitTestRunner/win/InjectedBundlePostBuild.cmd: Added.
        * WebKitTestRunner/win/InjectedBundlePreBuild.cmd: Added.
        * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd: Added.
        * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd: Added.
        * WinLauncher/WinLauncherCommon.vsprops:
        * WinLauncher/WinLauncherPostBuild.cmd: Added.
        * WinLauncher/WinLauncherPreBuild.cmd: Added.
2010-11-30  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam Roben.

        All projects on Windows should use cmd files for build events
        https://bugs.webkit.org/show_bug.cgi?id=50213

        * win/WebKit2Common.vsprops:
        * win/WebKit2WebProcessCommon.vsprops:
        * win/WebKit2WebProcessPostBuild.cmd: Added.
        * win/WebKit2WebProcessPreBuild.cmd: Added.
        * win/WebKitPostBuild.cmd: Added.
        * win/WebKitPreBuild.cmd: Added.
        * win/WebKitPreLink.cmd: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 30 Nov 2010 17:48:01 +0000 (17:48 +0000)]
2010-11-30  Ojan Vafai  <ojan@chromium.org>

        [chromium] Rebaselines. Details below.

        * platform/chromium-linux/fast/overflow/overflow-update-transform-expected.checksum: Added.
        * platform/chromium-linux/fast/overflow/overflow-update-transform-expected.png: Added.
        Just scrollbar pixel differences.

        * platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-30-t-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
        * platform/chromium-linux/svg/carto.net/selectionlist-expected.checksum:
        * platform/chromium-linux/svg/carto.net/selectionlist-expected.png:
        * platform/chromium-linux/svg/custom/image-small-width-height-expected.checksum:
        * platform/chromium-linux/svg/custom/image-small-width-height-expected.png:
        https://bugs.webkit.org/show_bug.cgi?id=50206

        * platform/chromium-mac/fast/block/basic/truncation-rtl-expected.checksum:
        * platform/chromium-mac/fast/block/basic/truncation-rtl-expected.png:
        * platform/chromium-mac/fast/block/basic/truncation-rtl-expected.txt: Added.
        Completes http://trac.webkit.org/changeset/72875/

        * platform/chromium-win/fast/overflow/overflow-update-transform-expected.checksum: Added.
        * platform/chromium-win/fast/overflow/overflow-update-transform-expected.png: Added.
        Just scrollbar pixel differences.

        * platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-30-t-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
        * platform/chromium-win/svg/carto.net/selectionlist-expected.checksum:
        * platform/chromium-win/svg/carto.net/selectionlist-expected.png:
        * platform/chromium-win/svg/custom/image-small-width-height-expected.checksum:
        * platform/chromium-win/svg/custom/image-small-width-height-expected.png:
        https://bugs.webkit.org/show_bug.cgi?id=50206

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Vitaly Repeshko <vitalyr@chromium.org>
vitalyr@chromium.org [Tue, 30 Nov 2010 17:18:18 +0000 (17:18 +0000)]
2010-11-30  Vitaly Repeshko  <vitalyr@chromium.org>

        Unreviewed.

        [chromium] Updating test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72920 268f45cc-cd09-0410-ab3c-d52691b4dbfc