WebKit-https.git
7 years ago.: If select element in Windows is off screen horizontally,
commit-queue@webkit.org [Tue, 24 Jul 2012 00:48:06 +0000 (00:48 +0000)]
.: If select element in Windows is off screen horizontally,
menu is either inappropriately resized or positioned offscreen.
https://bugs.webkit.org/show_bug.cgi?id=91913
<rdar://problem/7611229>

Patch by Roger Fong <roger_fong@apple.com> on 2012-07-23
Reviewed by Tim Horton.

Add a manual test to verify that popup menus render in the correct place.

* ManualTests/win/select-menu-off-screen.html: Added.

Source/WebCore: On Windows, if select element is off screen horizontally,
menu is either inappropriately resized or positioned offscreen.
https://bugs.webkit.org/show_bug.cgi?id=91913
<rdar://problem/7611229>

Patch by Roger Fong <roger_fong@apple.com> on 2012-07-23
Reviewed by Tim Horton.

If the select element is positioned off the edge of the screen to the left,
the menu is resized. It should not be resized, just shifted to remain on the screen.
If the select element is positioned off the edge of the screen to the right,
the menu goes off screen instead of being shifted over to appear on screen.
This problem only occurs on Windows.

Test: ManualTests/win/select-menu-off-screen.html

* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::calculatePositionAndSize):
Modified final horizontal position calculation code to position
popup menu on screen if it would otherwise go off.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFixed crash in webkitAddKey() when key parameter is null.
commit-queue@webkit.org [Tue, 24 Jul 2012 00:37:36 +0000 (00:37 +0000)]
Fixed crash in webkitAddKey() when key parameter is null.
https://bugs.webkit.org/show_bug.cgi?id=85444

Patch by David Dorwin <ddorwin@chromium.org> on 2012-07-23
Reviewed by Kentaro Hara.

Reference: Step 1 of http://dvcs.w3.org/hg/html-media/raw-file/5f76a0b43836/encrypted-media/encrypted-media.html#dom-addkey

Source/WebCore:

Tests: media/encrypted-media/encrypted-media-syntax.html

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::webkitAddKey):

LayoutTests:

* media/encrypted-media/encrypted-media-syntax-expected.txt:
* media/encrypted-media/encrypted-media-syntax.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttp/tests/multipart/policy-ignore-crash.php is failing on Chromium
tony@chromium.org [Tue, 24 Jul 2012 00:36:21 +0000 (00:36 +0000)]
http/tests/multipart/policy-ignore-crash.php is failing on Chromium
https://bugs.webkit.org/show_bug.cgi?id=92046

Reviewed by Adam Barth.

Chromium's network layer now shows most text/* mime types. This test was using text/random to
try to trigger a crash when multipart content switch from a text type to a non-text type.
Change the test to use a text type that we don't render.

* http/tests/multipart/policy-ignore-crash.php: Use text/rtf instead of text/random.
* platform/chromium/TestExpectations: Test should be passing again.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoA FocusScope for a distributed node should not be its TreeScope.
hayato@chromium.org [Tue, 24 Jul 2012 00:12:13 +0000 (00:12 +0000)]
A FocusScope for a distributed node should not be its TreeScope.
https://bugs.webkit.org/show_bug.cgi?id=91829

Reviewed by Dimitri Glazkov.

Source/WebCore:

Current implementation of FocusScope::focusScopeOf(Node*) returns
the given node's treeScope().  That does not apply if the node is
a distributed node.  We should calculate a FocusScope for a
distributed node by traversing ancestor nodes in Composed Shadow
Tree.

Test: fast/dom/shadow/focus-navigation-with-distributed-nodes.html

* page/FocusController.cpp:
(WebCore::FocusScope::focusScopeOf):

LayoutTests:

* fast/dom/shadow/focus-navigation-with-distributed-nodes-expected.txt: Added.
* fast/dom/shadow/focus-navigation-with-distributed-nodes.html: Added.
* fast/dom/shadow/resources/shadow-dom.js:
(shouldNavigateFocus):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNull-pointer crash when parsing border-image
commit-queue@webkit.org [Tue, 24 Jul 2012 00:06:23 +0000 (00:06 +0000)]
Null-pointer crash when parsing border-image
https://bugs.webkit.org/show_bug.cgi?id=91963

Patch by Douglas Stockwell <dstockwell@google.com> on 2012-07-23
Reviewed by Darin Adler.

Source/WebCore:

Test: fast/css/border-image-fill-crash.html

* css/CSSParser.cpp:
(WebCore::CSSParser::parseBorderImageRepeat): Handle the case where
parseBorderImageRepeat is called when the value list is empty.

LayoutTests:

* fast/css/border-image-fill-crash-expected.txt: Added.
* fast/css/border-image-fill-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Exclusions] SVG shape errors should invalidate exclusion shapes
commit-queue@webkit.org [Mon, 23 Jul 2012 23:56:38 +0000 (23:56 +0000)]
[CSS Exclusions] SVG shape errors should invalidate exclusion shapes
https://bugs.webkit.org/show_bug.cgi?id=91761

Patch by Bem Jones-Bey <bjonesbe@adobe.com> on 2012-07-23
Reviewed by Andreas Kling.

Source/WebCore:

CSS exclusion shapes that are specified with negative radiuses or
height/width are now considered invalid and ignored.

Tests added to
LayoutTests/fast/exclusions/parsing-wrap-shape-lengths.html

* css/CSSParser.cpp:
(WebCore::CSSParser::parseExclusionShapeRectangle):
(WebCore::CSSParser::parseExclusionShapeCircle):
(WebCore::CSSParser::parseExclusionShapeEllipse):

LayoutTests:

Test that negative heights. widths, and radiuses are ignored.

* fast/exclusions/parsing-wrap-shape-lengths-expected.txt:
* fast/exclusions/parsing-wrap-shape-lengths.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] css3/selectors3 rebaseline after new test fonts
caio.oliveira@openbossa.org [Mon, 23 Jul 2012 23:46:01 +0000 (23:46 +0000)]
[Qt] css3/selectors3 rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92038

Reviewed by Alexis Menard.

* platform/qt-5.0-wk1/Skipped:
* platform/qt-5.0-wk2/Skipped: These tests are failing because of <input> default size in
WK2, which is different than the expected results generated from WK1. Moved them to
appropriate block in skipped list.
* platform/qt-5.0/Skipped:
* platform/qt/css3/selectors3/html/css3-modsel-21c-expected.png:
* platform/qt/css3/selectors3/html/css3-modsel-21c-expected.txt:
* platform/qt/css3/selectors3/xhtml/css3-modsel-21c-expected.png:
* platform/qt/css3/selectors3/xhtml/css3-modsel-21c-expected.txt:
* platform/qt/css3/selectors3/xml/css3-modsel-148-expected.png:
* platform/qt/css3/selectors3/xml/css3-modsel-148-expected.txt:
* platform/qt/css3/selectors3/xml/css3-modsel-21c-expected.png:
* platform/qt/css3/selectors3/xml/css3-modsel-21c-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening. Land pixel results for fast/frames/valid.html on chromium mac...
tony@chromium.org [Mon, 23 Jul 2012 23:40:21 +0000 (23:40 +0000)]
Unreviewed gardening. Land pixel results for fast/frames/valid.html on chromium mac snowleopard.

* fast/frames/valid-expected.txt: Renamed from LayoutTests/platform/efl/fast/frames/valid-expected.txt.
* platform/chromium-mac-snowleopard/fast/frames/valid-expected.png: Added.
* platform/chromium/TestExpectations:
* platform/gtk/fast/frames/valid-expected.txt: Removed.
* platform/mac/fast/frames/valid-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Implement scrollbar theme for Android
commit-queue@webkit.org [Mon, 23 Jul 2012 23:38:54 +0000 (23:38 +0000)]
[chromium] Implement scrollbar theme for Android
https://bugs.webkit.org/show_bug.cgi?id=91674

Patch by Tien-Ren Chen <trchen@chromium.org> on 2012-07-23
Reviewed by Adam Barth.

Previously the scrollbar for Android was implemented as an extra
drawing pass in the compositor. Now we switch to use the standard
ScrollbarTheme mechanism.

No new tests. We use mock scrollbars during layout test to share
pixel results with Linux.

* platform/chromium/ScrollbarThemeChromiumAndroid.cpp:
(WebCore::ScrollbarThemeChromiumAndroid::scrollbarThickness):
(WebCore::ScrollbarThemeChromiumAndroid::thumbPosition):
(WebCore::ScrollbarThemeChromiumAndroid::thumbLength):
(WebCore::ScrollbarThemeChromiumAndroid::backButtonRect):
(WebCore::ScrollbarThemeChromiumAndroid::forwardButtonRect):
(WebCore::ScrollbarThemeChromiumAndroid::trackRect):
(WebCore):
(WebCore::ScrollbarThemeChromiumAndroid::paintThumb):
(WebCore::ScrollbarThemeChromiumAndroid::paintScrollbarBackground):
* platform/chromium/ScrollbarThemeChromiumAndroid.h:
(WebCore::ScrollbarThemeChromiumAndroid::usesOverlayScrollbars):
(ScrollbarThemeChromiumAndroid):
(WebCore::ScrollbarThemeChromiumAndroid::hasButtons):
(WebCore::ScrollbarThemeChromiumAndroid::hasThumb):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium expectations change to mark test as slow: fast/forms/select-set...
atwilson@chromium.org [Mon, 23 Jul 2012 23:37:10 +0000 (23:37 +0000)]
Unreviewed chromium expectations change to mark test as slow: fast/forms/select-set-length-with-mutation-remove.html.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate website for new hardware.
wsiegrist@apple.com [Mon, 23 Jul 2012 23:33:51 +0000 (23:33 +0000)]
Update website for new hardware.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse the original token to create an element in "reconstruct the active formatting...
kseo@webkit.org [Mon, 23 Jul 2012 23:15:50 +0000 (23:15 +0000)]
Use the original token to create an element in "reconstruct the active formatting elements" and "call the adoption agency"
https://bugs.webkit.org/show_bug.cgi?id=91703

Reviewed by Adam Barth.

Source/WebCore:

The current WebKit HTML5 parser implementation does not hold the original token
in the stack of open elements and the active formatting elements. This is
problematic because the original token is used to create an element in
"reconstruct the active formatting elements" and "call the adoption agency".

As a workaround, WebKit uses the saved element instead of the original token
to create an element. But this causes us to fail examples like this:
<b id="1"><p><script>document.getElementById("1").id = "2"</script></p>TEXT</b>
reconstructTheActiveFormattingElements calls this method to open a second <b>
tag to wrap TEXT, it will have id "2", even though the HTML5 spec implies it
should be "1".

Created a ref-counted container class, HTMLStackItem to hold the original token
and the namespace URI as well as the element. Changed HTMLElementStack and
HTMLFormattingElementList to use HTMLStackItem.
Changed HTMLConstructionSite::reconstructTheActiveFormattingElements and
HTMLTreeBuilder::callTheAdoptionAgency to create an element from the saved token
instead of the saved element.

Updated test expectation for html5lib/runner-expected.txt
because now resources/scripted/adoption01.dat passes.

* html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML):
(WebCore::HTMLConstructionSite::insertHTMLHeadElement):
(WebCore::HTMLConstructionSite::insertHTMLBodyElement):
(WebCore::HTMLConstructionSite::insertHTMLFormElement):
(WebCore::HTMLConstructionSite::insertHTMLElement):
(WebCore::HTMLConstructionSite::insertFormattingElement):
(WebCore::HTMLConstructionSite::insertScriptElement):
(WebCore::HTMLConstructionSite::insertForeignElement):
(WebCore::HTMLConstructionSite::createElementFromSavedToken):
(WebCore::HTMLConstructionSite::reconstructTheActiveFormattingElements):
* html/parser/HTMLConstructionSite.h:
(HTMLConstructionSite):
(WebCore::HTMLConstructionSite::currentElementRecord):
* html/parser/HTMLElementStack.cpp:
(WebCore::HTMLElementStack::ElementRecord::ElementRecord):
(WebCore::HTMLElementStack::ElementRecord::replaceElement):
(WebCore::HTMLElementStack::pushRootNode):
(WebCore::HTMLElementStack::pushHTMLHtmlElement):
(WebCore::HTMLElementStack::pushRootNodeCommon):
(WebCore::HTMLElementStack::pushHTMLHeadElement):
(WebCore::HTMLElementStack::pushHTMLBodyElement):
(WebCore::HTMLElementStack::push):
(WebCore::HTMLElementStack::insertAbove):
(WebCore::HTMLElementStack::pushCommon):
* html/parser/HTMLElementStack.h:
(WebCore::HTMLElementStack::ElementRecord::element):
(WebCore::HTMLElementStack::ElementRecord::node):
(WebCore::HTMLElementStack::ElementRecord::stackItem):
(ElementRecord):
(HTMLElementStack):
* html/parser/HTMLFormattingElementList.cpp:
(WebCore::HTMLFormattingElementList::swapTo):
(WebCore::HTMLFormattingElementList::append):
* html/parser/HTMLFormattingElementList.h:
(WebCore::HTMLFormattingElementList::Entry::Entry):
(WebCore::HTMLFormattingElementList::Entry::isMarker):
(WebCore::HTMLFormattingElementList::Entry::stackItem):
(WebCore::HTMLFormattingElementList::Entry::element):
(WebCore::HTMLFormattingElementList::Entry::replaceElement):
(WebCore::HTMLFormattingElementList::Entry::operator==):
(WebCore::HTMLFormattingElementList::Entry::operator!=):
(Entry):
(HTMLFormattingElementList):
* html/parser/HTMLStackItem.h: Added.
(WebCore):
(HTMLStackItem):
(WebCore::HTMLStackItem::create):
(WebCore::HTMLStackItem::element):
(WebCore::HTMLStackItem::node):
(WebCore::HTMLStackItem::token):
(WebCore::HTMLStackItem::namespaceURI):
(WebCore::HTMLStackItem::HTMLStackItem):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):

LayoutTests:

Updated test expectation for html5lib/runner-expected.txt
because now resources/scripted/adoption01.dat passes.

* html5lib/runner-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Fix unit tests in debug mode after r123375
shawnsingh@chromium.org [Mon, 23 Jul 2012 23:06:13 +0000 (23:06 +0000)]
[chromium] Fix unit tests in debug mode after r123375
https://bugs.webkit.org/show_bug.cgi?id=92030

Reviewed by Adrienne Walker.

Fixed two unit tests that were causing debug assertions because
they gave calcDrawTransforms an empty sized root layer.

* tests/CCLayerTreeHostCommonTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] svg/{in-html,overflow,repaint,wicd} needs update after new testfonts
rafael.lobo@openbossa.org [Mon, 23 Jul 2012 22:57:31 +0000 (22:57 +0000)]
[Qt] svg/{in-html,overflow,repaint,wicd} needs update after new testfonts
https://bugs.webkit.org/show_bug.cgi?id=92023

Unreviewed gardening.

* platform/qt-5.0/Skipped:
* platform/qt-5.0/svg/wicd/test-rightsizing-b-expected.png: Removed.
* platform/qt-5.0/svg/wicd/test-rightsizing-b-expected.txt: Removed.
* platform/qt/Skipped:
* platform/qt/svg/in-html/by-reference-expected.txt:
* platform/qt/svg/in-html/circle-expected.png:
* platform/qt/svg/in-html/circle-expected.txt:
* platform/qt/svg/overflow/overflow-on-foreignObject-expected.png:
* platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.txt:
* platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.txt:
* platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.txt:
* platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.txt:
* platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.txt:
* platform/qt/svg/repaint/inner-svg-change-viewBox-contract-expected.png: Copied from LayoutTests/platform/qt/svg/overflow/overflow-on-foreignObject-expected.png.
* platform/qt/svg/repaint/inner-svg-change-viewBox-contract-expected.txt: Added.
* platform/qt/svg/repaint/inner-svg-change-viewBox-expected.png: Added.
* platform/qt/svg/repaint/inner-svg-change-viewBox-expected.txt: Added.
* platform/qt/svg/repaint/inner-svg-change-viewPort-relative-expected.txt:
* platform/qt/svg/repaint/mask-clip-target-transform-expected.png: Added.
* platform/qt/svg/repaint/text-mask-update-expected.png: Copied from LayoutTests/platform/qt/svg/overflow/overflow-on-foreignObject-expected.png.
* platform/qt/svg/repaint/text-mask-update-expected.txt: Added.
* platform/qt/svg/wicd/rightsizing-grid-expected.png:
* platform/qt/svg/wicd/rightsizing-grid-expected.txt:
* platform/qt/svg/wicd/sizing-flakiness-expected.txt:
* platform/qt/svg/wicd/test-rightsizing-a-expected.png:
* platform/qt/svg/wicd/test-rightsizing-a-expected.txt:
* platform/qt/svg/wicd/test-rightsizing-b-expected.png:
* platform/qt/svg/wicd/test-rightsizing-b-expected.txt:
* platform/qt/svg/wicd/test-scalable-background-image1-expected.png:
* platform/qt/svg/wicd/test-scalable-background-image1-expected.txt:
* platform/qt/svg/wicd/test-scalable-background-image2-expected.png:
* platform/qt/svg/wicd/test-scalable-background-image2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoReport the extra memory used by immutable StylePropertySet objects.
kling@webkit.org [Mon, 23 Jul 2012 22:56:30 +0000 (22:56 +0000)]
Report the extra memory used by immutable StylePropertySet objects.
<http://webkit.org/b/92032>

Reviewed by Anders Carlsson.

Add an optional parameter to the MemoryClassInfo constructor for passing in additional base object
size on top of sizeof(T).

Use this in StylePropertySet::reportMemoryUsage() to properly account for the CSSProperty array
tacked onto the end of the object when m_isMutable == false.

* css/StylePropertySet.h:
(WebCore::StylePropertySet::reportMemoryUsage):
* dom/MemoryInstrumentation.h:
(WebCore::MemoryObjectInfo::reportObjectInfo):
(WebCore::MemoryClassInfo::MemoryClassInfo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix WebGL texSubImage2D for cube maps
commit-queue@webkit.org [Mon, 23 Jul 2012 22:53:25 +0000 (22:53 +0000)]
Fix WebGL texSubImage2D for cube maps
https://bugs.webkit.org/show_bug.cgi?id=91927

Patch by Gregg Tavares <gman@google.com> on 2012-07-23
Reviewed by Kenneth Russell.

Source/WebCore:

Fixes texSubImage2D so any size rectangle can be passed in
for cube maps.

Test: fast/canvas/webgl/tex-sub-image-cube-maps.html

* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::copyTexImage2D):
(WebCore::WebGLRenderingContext::texImage2DBase):
(WebCore::WebGLRenderingContext::texSubImage2DBase):
(WebCore::WebGLRenderingContext::validateTexFuncParameters):
* html/canvas/WebGLRenderingContext.h:
(WebGLRenderingContext):

LayoutTests:

Tests for WebGL texSubImage2D for cube maps.

* fast/canvas/webgl/tex-sub-image-cube-maps-expected.txt: Added.
* fast/canvas/webgl/tex-sub-image-cube-maps.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDFG is too aggressive in performing the specific value optimization on loads
fpizlo@apple.com [Mon, 23 Jul 2012 22:46:14 +0000 (22:46 +0000)]
DFG is too aggressive in performing the specific value optimization on loads
https://bugs.webkit.org/show_bug.cgi?id=92034

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

This ensures that we don't do optimizations based on a structure having a specific
value, if there is no way to detect that the value is despecified. This is the
case for dictionaries, since despecifying a value in a dictionary does not lead to
a transition and so cannot be caught by either structure checks or structure
transition watchpoints.

* bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFromLLInt):
(JSC::GetByIdStatus::computeForChain):
(JSC::GetByIdStatus::computeFor):
* bytecode/ResolveGlobalStatus.cpp:
(JSC::computeForStructure):

LayoutTests:

* fast/js/dfg-resolve-global-polymorphic-non-dictionary-expected.txt: Added.
* fast/js/dfg-resolve-global-polymorphic-non-dictionary.html: Added.
* fast/js/dfg-resolve-global-specific-dictionary-expected.txt: Added.
* fast/js/dfg-resolve-global-specific-dictionary.html: Added.
* fast/js/script-tests/dfg-resolve-global-polymorphic-non-dictionary.js: Added.
(description.foo):
* fast/js/script-tests/dfg-resolve-global-specific-dictionary.js: Added.
(description.foo):
(x):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r123169): It made fast/js/dfg-inline-arguments-use-from-uninlined-code...
fpizlo@apple.com [Mon, 23 Jul 2012 22:38:30 +0000 (22:38 +0000)]
REGRESSION(r123169): It made fast/js/dfg-inline-arguments-use-from-uninlined-code.html fail on 32 bit platforms
https://bugs.webkit.org/show_bug.cgi?id=92002

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

In the process of changing the nature of local variable typing, I forgot to modify one of the places where
we glue the DFG's notion of variable prediction to the runtime's notion of variable tagging.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):

LayoutTests:

Unskip test that this change fixes, as requested by Ossy.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r123387.
commit-queue@webkit.org [Mon, 23 Jul 2012 22:36:43 +0000 (22:36 +0000)]
Unreviewed, rolling out r123387.
http://trac.webkit.org/changeset/123387
https://bugs.webkit.org/show_bug.cgi?id=92036

Broke chromium win build (Requested by tony^work on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-23

* WebCore.gyp/WebCore.gyp:
* WebCore.gyp/scripts/rule_bison.py:
* bindings/scripts/preprocessor.pm:
(applyPreprocessor):
* make-hash-tools.pl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Move about: URL handling out of WebCore
commit-queue@webkit.org [Mon, 23 Jul 2012 22:34:11 +0000 (22:34 +0000)]
[BlackBerry] Move about: URL handling out of WebCore
https://bugs.webkit.org/show_bug.cgi?id=91541

Patch by Yong Li <yoli@rim.com> on 2012-07-23
Reviewed by Rob Buis.

PR# 181304.
Move about: URL handling to the right place (FrameLoaderClientBlackBerry::createDocumentLoader), so
reload and history navigation can work.
Other changes: Remove about:version which makes little sense. Make about:memory partially visible.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::load): Remove the call to loadAbout()
* Api/WebPage_p.h: Remove loadAbout()
(WebPagePrivate):
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::createDocumentLoader): Construct about: data here.
* WebKitSupport/AboutData.cpp:
(BlackBerry::WebKit::numberToHTMLTr): Make it static
(BlackBerry::WebKit::configPage): Make it static
(BlackBerry::WebKit::memoryPage): Make it static
(BlackBerry::WebKit::cachePage):
(BlackBerry::WebKit::buildPage):
(BlackBerry::WebKit::creditsPage):
(BlackBerry::WebKit::cookiePage):
(BlackBerry::WebKit::aboutData): The only export function that returns HTML source for a given about: URL.
(WebKit):
* WebKitSupport/AboutData.h:
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r123360.
dpranke@chromium.org [Mon, 23 Jul 2012 22:09:51 +0000 (22:09 +0000)]
Unreviewed, rolling out r123360.
http://trac.webkit.org/changeset/123360
https://bugs.webkit.org/show_bug.cgi?id=91890

broke the chromium bots

* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort._static_build_path):
(ChromiumPort.default_results_directory):
(ChromiumPort._build_path):
(ChromiumPort._path_to_image_diff):
* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort._build_path):
(ChromiumAndroidPort._path_to_driver):
(ChromiumAndroidPort._path_to_forwarder):
(ChromiumAndroidPort._push_executable):
(ChromiumAndroidPort._push_fonts):
* Scripts/webkitpy/layout_tests/port/chromium_linux.py:
(ChromiumLinuxPort._determine_driver_path_statically):
(ChromiumLinuxPort._modules_to_search_for_symbols):
(ChromiumLinuxPort._path_to_driver):
* Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
(ChromiumLinuxPortTest.test_build_path):
* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
(ChromiumMacPort._modules_to_search_for_symbols):
(ChromiumMacPort._path_to_driver):
(ChromiumMacPort._path_to_helper):
* Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
(ChromiumMacPortTest.test_build_path):
* Scripts/webkitpy/layout_tests/port/chromium_win.py:
(ChromiumWinPort._path_to_driver):
(ChromiumWinPort._path_to_helper):
(ChromiumWinPort._path_to_image_diff):
* Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
(ChromiumWinTest.test_build_path):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRef-count AtomicHTMLToken
kseo@webkit.org [Mon, 23 Jul 2012 22:02:09 +0000 (22:02 +0000)]
Ref-count AtomicHTMLToken
https://bugs.webkit.org/show_bug.cgi?id=91981

Reviewed by Adam Barth.

Ref-count AtomicHTMLToken to avoid copying AtomicHTMLToken in Bug 91703.

No new tests - no functional changes.

* html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML):
(WebCore::HTMLConstructionSite::mergeAttributesFromTokenIntoElement):
(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagInBody):
(WebCore::HTMLConstructionSite::insertHTMLBodyStartTagInBody):
(WebCore::HTMLConstructionSite::insertDoctype):
(WebCore::HTMLConstructionSite::insertComment):
(WebCore::HTMLConstructionSite::insertCommentOnDocument):
(WebCore::HTMLConstructionSite::insertCommentOnHTMLHtmlElement):
(WebCore::HTMLConstructionSite::insertHTMLHeadElement):
(WebCore::HTMLConstructionSite::insertHTMLBodyElement):
(WebCore::HTMLConstructionSite::insertHTMLFormElement):
(WebCore::HTMLConstructionSite::insertHTMLElement):
(WebCore::HTMLConstructionSite::insertSelfClosingHTMLElement):
(WebCore::HTMLConstructionSite::insertFormattingElement):
(WebCore::HTMLConstructionSite::insertScriptElement):
(WebCore::HTMLConstructionSite::insertForeignElement):
(WebCore::HTMLConstructionSite::createElement):
(WebCore::HTMLConstructionSite::createHTMLElement):
(WebCore::HTMLConstructionSite::createHTMLElementFromSavedElement):
* html/parser/HTMLConstructionSite.h:
(HTMLConstructionSite):
* html/parser/HTMLToken.h:
(WebCore::AtomicHTMLToken::create):
(AtomicHTMLToken):
(WebCore::AtomicHTMLToken::AtomicHTMLToken):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::ExternalCharacterTokenBuffer):
(WebCore::HTMLTreeBuilder::constructTreeFromToken):
(WebCore::HTMLTreeBuilder::constructTreeFromAtomicToken):
(WebCore::HTMLTreeBuilder::processToken):
(WebCore::HTMLTreeBuilder::processDoctypeToken):
(WebCore::HTMLTreeBuilder::processFakeStartTag):
(WebCore::HTMLTreeBuilder::processFakeEndTag):
(WebCore::HTMLTreeBuilder::processFakePEndTagIfPInButtonScope):
(WebCore::HTMLTreeBuilder::attributesForIsindexInput):
(WebCore::HTMLTreeBuilder::processIsindexStartTagForInBody):
(WebCore):
(WebCore::HTMLTreeBuilder::processCloseWhenNestedTag):
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processStartTagForInTable):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processHtmlStartTagForInBody):
(WebCore::HTMLTreeBuilder::processBodyEndTagForInBody):
(WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
(WebCore::HTMLTreeBuilder::processEndTagForInTableBody):
(WebCore::HTMLTreeBuilder::processEndTagForInRow):
(WebCore::HTMLTreeBuilder::processEndTagForInCell):
(WebCore::HTMLTreeBuilder::processEndTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTagForInTable):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processComment):
(WebCore::HTMLTreeBuilder::processCharacter):
(WebCore::HTMLTreeBuilder::processEndOfFile):
(WebCore::HTMLTreeBuilder::defaultForBeforeHTML):
(WebCore::HTMLTreeBuilder::defaultForBeforeHead):
(WebCore::HTMLTreeBuilder::defaultForInHead):
(WebCore::HTMLTreeBuilder::defaultForInHeadNoscript):
(WebCore::HTMLTreeBuilder::defaultForAfterHead):
(WebCore::HTMLTreeBuilder::processStartTagForInHead):
(WebCore::HTMLTreeBuilder::processGenericRCDATAStartTag):
(WebCore::HTMLTreeBuilder::processGenericRawTextStartTag):
(WebCore::HTMLTreeBuilder::processScriptStartTag):
(WebCore::HTMLTreeBuilder::shouldProcessTokenInForeignContent):
(WebCore::HTMLTreeBuilder::processTokenInForeignContent):
(WebCore::HTMLTreeBuilder::parseError):
* html/parser/HTMLTreeBuilder.h:
(HTMLTreeBuilder):
* html/parser/TextDocumentParser.cpp:
(WebCore::TextDocumentParser::insertFakePreElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMore unreviewed chromium expectation changes to mark tests as failing/slow.
atwilson@chromium.org [Mon, 23 Jul 2012 21:54:30 +0000 (21:54 +0000)]
More unreviewed chromium expectation changes to mark tests as failing/slow.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse native (non-cygwin) binaries for perl, gperf, and bison in Chromium
tony@chromium.org [Mon, 23 Jul 2012 21:52:00 +0000 (21:52 +0000)]
Use native (non-cygwin) binaries for perl, gperf, and bison in Chromium
https://bugs.webkit.org/show_bug.cgi?id=91667

Patch by Scott Graham <scottmg@google.com> on 2012-07-23
Reviewed by Tony Chang.

Using native tools instead of cygwin version improves build time
performance by roughly 50% (on top of previous cl-instead-of-gcc
change).

Also, use - instead of / for cl flags because a layer of project
generator converts them to \ otherwise, which causes the preprocessing
to fail (very slowly because of the cygwin-loop with a sleep 1).

No new tests.

* WebCore.gyp/WebCore.gyp:
* WebCore.gyp/scripts/rule_bison.py:
* bindings/scripts/preprocessor.pm:
(applyPreprocessor):
* make-hash-tools.pl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMediaController.currentTime should be kept stable during script execution.
jer.noble@apple.com [Mon, 23 Jul 2012 21:39:19 +0000 (21:39 +0000)]
MediaController.currentTime should be kept stable during script execution.
https://bugs.webkit.org/show_bug.cgi?id=88555

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/media-controller-time-constant.html

To keep MediaController.currentTime stable, add a new m_position variable and
a new m_clearPositionTimer timer.  Both must be mutable variables as they will
be updated from within const functions.  Calls to currentTime() will result in
stable values until the next runloop iteration.

* html/MediaController.cpp:
(MediaController::MediaController):
(MediaController::currentTime):
(MediaController::setCurrentTime):
(MediaController::clearPositionTimerFired):
* html/MediaController.h:

LayoutTests:

* media/media-controller-time-constant-expected.txt: Added.
* media/media-controller-time-constant.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDestroy CSS decoded data more eagerly once they become dead caches.
kseo@webkit.org [Mon, 23 Jul 2012 21:38:06 +0000 (21:38 +0000)]
Destroy CSS decoded data more eagerly once they become dead caches.
https://bugs.webkit.org/show_bug.cgi?id=91733

Patch by Huang Dongsung <luxtella@company100.net> on 2012-07-23
Reviewed by Geoffrey Garen.

Internal review by Kwang Yul Seo.

There are three CachedResources with decoded data: CachedImage, CachedScript
and CachedCSSStyleSheet. In the cases of CachedImage and CachedScript, we
eagerly destroy the decoded data using Timer in CacehdResource::allClientsRemoved().
We must apply the same policy here in CachedCSSStyleSheet because priority
inversion can occur. For example, we can't destroy the decoded data of CachedImages
when they are referenced by CachedCSSStyleSheet as background, mask or border
images.

No new tests - no new testable functionality.

* loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
(WebCore::CachedCSSStyleSheet::didAddClient):
(WebCore::CachedCSSStyleSheet::allClientsRemoved):
(WebCore::CachedCSSStyleSheet::destroyDecodedData):
(WebCore):
(WebCore::CachedCSSStyleSheet::decodedDataDeletionTimerFired):
* loader/cache/CachedCSSStyleSheet.h:
(CachedCSSStyleSheet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] TestInterfaces should be responsible for owning and binding AccessibilityC...
abarth@webkit.org [Mon, 23 Jul 2012 21:24:22 +0000 (21:24 +0000)]
[Chromium] TestInterfaces should be responsible for owning and binding AccessibilityController and TextInputController
https://bugs.webkit.org/show_bug.cgi?id=91459

Reviewed by Ryosuke Niwa.

Rather than having TestShell own and bind each of these JavaScript APIs
individually, TestShell should delegate that work to TestInterfaces.
This patch moves AccessibilityController and TextInputController to be
the responsibility of TestInterfaces.

* DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:
(TestInterfaces::TestInterfaces):
(TestInterfaces::~TestInterfaces):
(TestInterfaces::setWebView):
(TestInterfaces::bindTo):
(TestInterfaces::resetAll):
* DumpRenderTree/chromium/TestRunner/TestInterfaces.h:
(WebKit):
(TestInterfaces):
(TestInterfaces::accessibilityController):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):
(TestShell::createMainWindow):
(TestShell::~TestShell):
(TestShell::resetTestController):
(TestShell::bindJSObjectsToWindow):
* DumpRenderTree/chromium/TestShell.h:
(TestShell::accessibilityController):
(TestShell):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] dom/xhtml/level3/core rebaseline after new test fonts
caio.oliveira@openbossa.org [Mon, 23 Jul 2012 21:23:29 +0000 (21:23 +0000)]
[Qt] dom/xhtml/level3/core rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92028

Unreviewed.

* platform/qt-5.0/Skipped:
* platform/qt/dom/xhtml/level3/core/documentgetinputencoding03-expected.txt:
* platform/qt/dom/xhtml/level3/core/entitygetinputencoding02-expected.txt:
* platform/qt/dom/xhtml/level3/core/entitygetxmlversion02-expected.txt:
* platform/qt/dom/xhtml/level3/core/nodegetbaseuri05-expected.txt:
* platform/qt/dom/xhtml/level3/core/nodegetbaseuri07-expected.txt:
* platform/qt/dom/xhtml/level3/core/nodegetbaseuri09-expected.txt:
* platform/qt/dom/xhtml/level3/core/nodegetbaseuri10-expected.txt:
* platform/qt/dom/xhtml/level3/core/nodegetbaseuri11-expected.txt:
* platform/qt/dom/xhtml/level3/core/nodegetbaseuri15-expected.txt:
* platform/qt/dom/xhtml/level3/core/nodegetbaseuri17-expected.txt:
* platform/qt/dom/xhtml/level3/core/nodegetbaseuri18-expected.txt:
* platform/qt/dom/xhtml/level3/core/nodelookupnamespaceuri01-expected.txt:
* platform/qt/dom/xhtml/level3/core/nodelookupprefix19-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonrwt swallows early exceptions
kbalazs@webkit.org [Mon, 23 Jul 2012 21:21:25 +0000 (21:21 +0000)]
nrwt swallows early exceptions
https://bugs.webkit.org/show_bug.cgi?id=91884

Reviewed by Dirk Pranke.

Put everything in a try block so we won't miss any error.

* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(run):
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPart 2 of: Implement sticky positioning
simon.fraser@apple.com [Mon, 23 Jul 2012 21:03:45 +0000 (21:03 +0000)]
Part 2 of: Implement sticky positioning
https://bugs.webkit.org/show_bug.cgi?id=90046

Reviewed by Ojan Vafai.

Source/JavaScriptCore:

Turn on ENABLE_CSS_STICKY_POSITION.

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Turn on ENABLE_CSS_STICKY_POSITION. Add support for parsing the new '-webkit-sticky'
value for position, returning it from getComputedStyle(), and storing it in RenderStyle.

Test: fast/css/sticky/parsing-position-sticky.html

* Configurations/FeatureDefines.xcconfig:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::getPositionOffsetValue):
* css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EPosition):
* css/CSSValueKeywords.in:
* rendering/style/RenderStyle.h:
* rendering/style/RenderStyleConstants.h:

Source/WebKit/chromium:

Turn on ENABLE_CSS_STICKY_POSITION.

* features.gypi:

Source/WebKit/mac:

Turn on ENABLE_CSS_STICKY_POSITION.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Turn on ENABLE_CSS_STICKY_POSITION.

* Configurations/FeatureDefines.xcconfig:

LayoutTests:

Test for parsing and returning fro getComputedStyle() the new
-webkit-sticky value for position.

* fast/css/sticky/parsing-position-sticky-expected.txt: Added.
* fast/css/sticky/parsing-position-sticky.html: Added.
* fast/css/sticky/resources/parsing-position-sticky.js: Added.
(test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium expectations change to mark media/media-fragments/TC0010-TC0019...
atwilson@chromium.org [Mon, 23 Jul 2012 21:03:15 +0000 (21:03 +0000)]
Unreviewed chromium expectations change to mark media/media-fragments/TC0010-TC0019.html as flaky/crashy.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash when setting empty class name on a new element
schenney@chromium.org [Mon, 23 Jul 2012 20:57:13 +0000 (20:57 +0000)]
Crash when setting empty class name on a new element
https://bugs.webkit.org/show_bug.cgi?id=92024

Reviewed by Andreas Kling.

Source/WebCore:

Add a check for null attributeData() when setting the className to an
empty string on a newly created element. New SVG elements have null
attributeData() on baseVal upon creation.

Test: svg/custom/empty-className-baseVal-crash.html

* dom/StyledElement.cpp:
(WebCore::StyledElement::classAttributeChanged): Add check for null attributeData()

LayoutTests:

Add a check for null attributeData() when setting the className to an
empty string on a newly created element.

* svg/custom/empty-className-baseVal-crash-expected.txt: Added.
* svg/custom/empty-className-baseVal-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove JSC::parseDate() from DateConversion to JSDateMath
paroga@webkit.org [Mon, 23 Jul 2012 20:53:35 +0000 (20:53 +0000)]
Move JSC::parseDate() from DateConversion to JSDateMath
https://bugs.webkit.org/show_bug.cgi?id=91982

Reviewed by Geoffrey Garen.

Moveing this function into the other files removes the dependency
on JSC spcific classes in DateConversion.{cpp|h}.

* runtime/DateConversion.cpp:
* runtime/DateConversion.h:
(JSC):
* runtime/JSDateMath.cpp:
(JSC::parseDate):
(JSC):
* runtime/JSDateMath.h:
(JSC):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Refactor CCLayerTreeHostCommon: clean up clipRect and drawableContentRect...
shawnsingh@chromium.org [Mon, 23 Jul 2012 20:46:11 +0000 (20:46 +0000)]
[chromium] Refactor CCLayerTreeHostCommon: clean up clipRect and drawableContentRect design
https://bugs.webkit.org/show_bug.cgi?id=80622

Reviewed by Adrienne Walker.

Source/WebCore:

clipRect(), usesLayerClipping(), and drawableContentRect() have been
very confusing in CCLayerTreeHostCommon for a while. This patch
refactors it so that (1) clipping is only done locally in
calcDrawTransforms, and (2) the layer's drawableContentRect value
is now meaningful value outside of calcDrawTransforms.
Additionally, the layer is now always clipped to the root
surface's contentBounds (which are set to the viewport bounds).
This refactor not only makes calcDrawTransforms far more readable and intuitive, but
this patch enables more upcoming beneficial refactors, including
the pending refactor in https://bugs.webkit.org/show_bug.cgi?id=88953.

Tests are also significantly updated to keep up with this refactoring change.

* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
* platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
Removed m_usesLayerClipping and m_clipRect and associated accessors.

* platform/graphics/chromium/RenderSurfaceChromium.h:
(RenderSurfaceChromium):
Updated comment

* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
Removed m_usesLayerClipping and m_clipRect and associated accessors.

* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::updateLayers):
removed setClipRect code that no longer applies

* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::calculateLayerScissorRect):
scissor rect is now a little bit tighter, the intersection between damage and layer's new drawableContentRect.

(WebCore::calculateSurfaceScissorRect):
scissor rect is now a little bit tighter, except when filters are involved.

(WebCore::layerClipsSubtree):
new helper function

(WebCore):
(WebCore::calculateVisibleContentRect):
(WebCore::subtreeShouldRenderToSeparateSurface):
(WebCore::calculateDrawTransformsInternal):
   - added drawableContentRectOfSubtree to the function args, it is valid only after recursion returns,
   - added clipRectFromAncestor and bool ancestorClipsSubtree to function args, this replaces the layer's clipRect and usesLayerClipping.
   - removed the boolean return value, which was redundant with drawableContentRectOfSubtree.
   - replaced all the "setDrawableContentRect" logic with more intuitive, clear logic.
   - now, layer's drawableContentRect represents the clipped bounds of the layer expressed in the target surface space.

(WebCore::CCLayerTreeHostCommon::calculateDrawTransforms):
(WebCore::pointIsClippedBySurfaceOrClipRect):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::::layerScissorRectInTargetSurface):
Updated this accessor.  It could be removed in the future, but not appropriate for this patch.

* platform/graphics/chromium/cc/CCRenderSurface.h:

Source/WebKit/chromium:

Many tests needed to be updated because the semantics of the layer tree have changed:
  - a few tests that were no longer applicable were removed.
  - many tests needed to have fixed initialization, properly
    setting surface contentRect and rootLayer bounds.
  - because clipRect and usesLayerClipping no longer exists, those places in code had to be removed/changed
  - the scissorRect tests needed to have updated expectations
    because after this patch, the rootLayer Surface now clips
    to its contentBounds.
  - the clipRect tests were changed to test the layer's new semantics for the drawableContentRect instead.

* tests/CCLayerImplTest.cpp:
(WebCore::TEST):
* tests/CCLayerIteratorTest.cpp:
* tests/CCLayerTreeHostCommonTest.cpp:
* tests/CCLayerTreeHostImplTest.cpp:
* tests/CCLayerTreeHostTest.cpp:
* tests/CCOcclusionTrackerTest.cpp:
(WebKitTests::CCOcclusionTrackerTest::calcDrawEtc):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity1OnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity0OnMainThread::runMyTest):
* tests/LayerChromiumTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] WebKitTestRunner needs to print information about Web intents
commit-queue@webkit.org [Mon, 23 Jul 2012 20:37:39 +0000 (20:37 +0000)]
[WK2] WebKitTestRunner needs to print information about Web intents
https://bugs.webkit.org/show_bug.cgi?id=90873

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-23
Reviewed by Anders Carlsson.

Source/WebKit2:

Add Bundle API for Web Intents. This is needed by the WebKitTestRunner
to print information about the new intent requests and the intent
service registrations.

* CMakeLists.txt: Move WebIntentData and WebIntentServiceInfo from
UIProcess/ to Shared/.
* GNUmakefile.list.am: Move WebIntentData and WebIntentServiceInfo from
UIProcess/ to Shared/.
* Shared/APIClientTraits.h:
* Shared/WebIntentData.cpp: Renamed from Source/WebKit2/UIProcess/WebIntentData.cpp.
(WebKit):
(WebKit::WebIntentData::WebIntentData):
(WebKit::WebIntentData::data):
(WebKit::WebIntentData::suggestions):
(WebKit::WebIntentData::extra):
(WebKit::WebIntentData::extras):
* Shared/WebIntentData.h: Renamed from Source/WebKit2/UIProcess/WebIntentData.h.
(WebKit):
(WebIntentData):
(WebKit::WebIntentData::create):
(WebKit::WebIntentData::~WebIntentData):
(WebKit::WebIntentData::action):
(WebKit::WebIntentData::payloadType):
(WebKit::WebIntentData::service):
(WebKit::WebIntentData::store):
(WebKit::WebIntentData::type):
* Shared/WebIntentServiceInfo.cpp: Renamed from Source/WebKit2/UIProcess/WebIntentServiceInfo.cpp.
(WebKit):
(WebKit::WebIntentServiceInfo::WebIntentServiceInfo):
* Shared/WebIntentServiceInfo.h: Renamed from Source/WebKit2/UIProcess/WebIntentServiceInfo.h.
(WebKit):
(WebIntentServiceInfo):
(WebKit::WebIntentServiceInfo::create):
(WebKit::WebIntentServiceInfo::~WebIntentServiceInfo):
(WebKit::WebIntentServiceInfo::action):
(WebKit::WebIntentServiceInfo::payloadType):
(WebKit::WebIntentServiceInfo::href):
(WebKit::WebIntentServiceInfo::title):
(WebKit::WebIntentServiceInfo::disposition):
(WebKit::WebIntentServiceInfo::type):
* Target.pri: Move WebIntentData and WebIntentServiceInfo from
UIProcess/ to Shared/.
* UIProcess/API/C/WKPage.h:
* UIProcess/API/efl/ewk_view_loader_client.cpp:
(didReceiveIntentForFrame):
(registerIntentServiceForFrame):
* UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::didReceiveIntentForFrame):
(WebKit::WebLoaderClient::registerIntentServiceForFrame):
* UIProcess/WebLoaderClient.h:
(WebLoaderClient):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::registerIntentServiceForFrame):
(WebKit::WebPageProxy::didReceiveIntentForFrame):
* UIProcess/WebPageProxy.h:
(WebPageProxy):
* UIProcess/WebPageProxy.messages.in:
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit):
(WebKit::InjectedBundlePageLoaderClient::didReceiveIntentForFrame):
(WebKit::InjectedBundlePageLoaderClient::registerIntentServiceForFrame):
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
(WebKit):
(InjectedBundlePageLoaderClient):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchIntent):
(WebKit::WebFrameLoaderClient::registerIntentService):
* WebProcess/qt/QtBuiltinBundlePage.cpp:
(WebKit::QtBuiltinBundlePage::QtBuiltinBundlePage):

Tools:

Print out information about new intents requests and intent
services registrations in WebKitTestRunner. This is expected
by tests under webintents/*.

* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::didReceiveIntentForFrame):
(WTR):
(WTR::InjectedBundlePage::registerIntentServiceForFrame):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
(InjectedBundlePage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] tables/mozilla_expected_failures rebaseline after new test fonts
caio.oliveira@openbossa.org [Mon, 23 Jul 2012 20:32:16 +0000 (20:32 +0000)]
[Qt] tables/mozilla_expected_failures rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92013

Unreviewed.

* platform/qt-5.0/Skipped:
* platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_td_align_right-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Add unit tests for Ewk_Cookie_Manager
commit-queue@webkit.org [Mon, 23 Jul 2012 20:26:00 +0000 (20:26 +0000)]
[EFL][WK2] Add unit tests for Ewk_Cookie_Manager
https://bugs.webkit.org/show_bug.cgi?id=91639

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-23
Reviewed by Antonio Gomes.

Add unit tests for Ewk_Cookie_Manager.

* PlatformEfl.cmake:
* UIProcess/API/efl/ewk_cookie_manager.h: Fix "accept policy" documentation
to indicate that only cookies set by the main document are accepted by default.
* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestServer.cpp: Added.
(EWK2UnitTestServer::EWK2UnitTestServer): Add HTTP server similar to the one
used by GTK port unit tests.
(EWK2UnitTestServer::~EWK2UnitTestServer):
(EWK2UnitTestServer::run):
(EWK2UnitTestServer::getURIForPath):
* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestServer.h: Added.
(EWK2UnitTestServer):
(EWK2UnitTestServer::baseURI):
* UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp: Added.
(serverCallback):
(getAcceptPolicyCallback):
(getAcceptPolicy):
(getHostnamesWithCookiesCallback):
(getHostnamesWithCookies):
(freeHostNames):
(countHostnamesWithCookies):
(TEST_F):
(cleanUpCookieFiles):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix if NOMINMAX is defined by the build system.
paroga@webkit.org [Mon, 23 Jul 2012 20:23:47 +0000 (20:23 +0000)]
Build fix if NOMINMAX is defined by the build system.

* COMEnumVariant.h: Added #ifndef NOMINMAX around #define NOMINMAX.
* COMPropertyBag.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Fix build on Ubuntu Precise.
dcheng@chromium.org [Mon, 23 Jul 2012 20:22:29 +0000 (20:22 +0000)]
[chromium] Fix build on Ubuntu Precise.
https://bugs.webkit.org/show_bug.cgi?id=92021

Reviewed by Adrienne Walker.

Remove an array that's written but never read.

* tests/CCResourceProviderTest.cpp:
(WebKit::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CMAKE] Added missing RenderLayerFilterInfo.cpp to build system.
paroga@webkit.org [Mon, 23 Jul 2012 20:16:27 +0000 (20:16 +0000)]
[CMAKE] Added missing RenderLayerFilterInfo.cpp to build system.

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] tables/mozilla_expected_failures/bugs rebaseline after new test fonts
atwilson@chromium.org [Mon, 23 Jul 2012 20:06:19 +0000 (20:06 +0000)]
[Qt] tables/mozilla_expected_failures/bugs rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92017

Patch by Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org> on 2012-07-23
Reviewed by Alexis Menard.

* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0/Skipped:
* platform/qt/tables/mozilla_expected_failures/bugs/bug128876-expected.png: Added.
* platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.png: Added.
* platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
* platform/qt/tables/mozilla_expected_failures/bugs/bug3166-6-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug3166-7-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug3166-8-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug3166-9-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] tables/mozilla_expected_failures/bugs rebaseline after new test fonts
caio.oliveira@openbossa.org [Mon, 23 Jul 2012 20:01:31 +0000 (20:01 +0000)]
[Qt] tables/mozilla_expected_failures/bugs rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92017

Reviewed by Alexis Menard.

* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0/Skipped:
* platform/qt/tables/mozilla_expected_failures/bugs/bug128876-expected.png: Added.
* platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.png: Added.
* platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
* platform/qt/tables/mozilla_expected_failures/bugs/bug3166-6-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug3166-7-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug3166-8-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug3166-9-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] svg/zoom needs update after new testfonts
rafael.lobo@openbossa.org [Mon, 23 Jul 2012 19:54:49 +0000 (19:54 +0000)]
[Qt] svg/zoom needs update after new testfonts
https://bugs.webkit.org/show_bug.cgi?id=92007

Reviewed by Alexis Menard.

* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0/Skipped:
* platform/qt-5.0/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Removed.
* platform/qt-5.0/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Removed.
* platform/qt/Skipped:
* platform/qt/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.png: Added.
* platform/qt/svg/zoom/page/absolute-sized-document-scrollbars-expected.png: Added.
* platform/qt/svg/zoom/page/zoom-background-image-tiled-expected.txt: Added.
* platform/qt/svg/zoom/page/zoom-background-images-expected.png:
* platform/qt/svg/zoom/page/zoom-background-images-expected.txt:
* platform/qt/svg/zoom/page/zoom-foreign-content-expected.txt: Added.
* platform/qt/svg/zoom/page/zoom-foreignObject-expected.png:
* platform/qt/svg/zoom/page/zoom-foreignObject-expected.txt:
* platform/qt/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
* platform/qt/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
* platform/qt/svg/zoom/page/zoom-hixie-rendering-model-004-expected.png:
* platform/qt/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt:
* platform/qt/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
* platform/qt/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
* platform/qt/svg/zoom/page/zoom-mask-with-percentages-expected.png:
* platform/qt/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
* platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
* platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
* platform/qt/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt:
* platform/qt/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt:
* platform/qt/svg/zoom/page/zoom-svg-float-border-padding-expected.png: Added.
* platform/qt/svg/zoom/page/zoom-svg-float-border-padding-expected.txt:
* platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
* platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
* platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
* platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
* platform/qt/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
* platform/qt/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png:
* platform/qt/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt:
* platform/qt/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
* platform/qt/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt:
* platform/qt/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
* platform/qt/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
* platform/qt/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.png: Added.
* platform/qt/svg/zoom/text/absolute-sized-document-scrollbars-expected.png: Added.
* platform/qt/svg/zoom/text/relative-sized-document-scrollbars-expected.png: Added.
* platform/qt/svg/zoom/text/zoom-foreignObject-expected.png:
* platform/qt/svg/zoom/text/zoom-foreignObject-expected.txt:
* platform/qt/svg/zoom/text/zoom-hixie-mixed-008-expected.png:
* platform/qt/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
* platform/qt/svg/zoom/text/zoom-hixie-mixed-009-expected.png:
* platform/qt/svg/zoom/text/zoom-hixie-mixed-009-expected.txt:
* platform/qt/svg/zoom/text/zoom-hixie-rendering-model-004-expected.png:
* platform/qt/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt:
* platform/qt/svg/zoom/text/zoom-svg-float-border-padding-expected.png:
* platform/qt/svg/zoom/text/zoom-svg-float-border-padding-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium expectations change to ignore DEBUG failures for policy-ignore...
atwilson@chromium.org [Mon, 23 Jul 2012 19:49:17 +0000 (19:49 +0000)]
Unreviewed chromium expectations change to ignore DEBUG failures for policy-ignore-crash.php.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r123362.
caio.oliveira@openbossa.org [Mon, 23 Jul 2012 19:44:07 +0000 (19:44 +0000)]
Unreviewed, rolling out r123362.
http://trac.webkit.org/changeset/123362
https://bugs.webkit.org/show_bug.cgi?id=92020

uploaded wrong expectations :( bad caio (Requested by cmarcelo
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-23

* platform/gtk/tables/mozilla_expected_failures/bugs/bug128876-expected.png:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug23847-expected.png:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug23847-expected.txt: Removed.
* platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-6-expected.png:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-7-expected.png:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-8-expected.png:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-9-expected.png:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0/Skipped:
* platform/qt/tables/mozilla_expected_failures/bugs/bug128876-expected.png: Removed.
* platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.png: Removed.
* platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
* platform/qt/tables/mozilla_expected_failures/bugs/bug3166-6-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug3166-7-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug3166-8-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug3166-9-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium expectations change to mark inline-plaintext-relayout-with-leadin...
atwilson@chromium.org [Mon, 23 Jul 2012 19:38:58 +0000 (19:38 +0000)]
Unreviewed chromium expectations change to mark inline-plaintext-relayout-with-leading-neutrals.html flaky.
https://bugs.webkit.org/show_bug.cgi?id=92019

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] tables/mozilla_expected_failures/bugs rebaseline after new test fonts
caio.oliveira@openbossa.org [Mon, 23 Jul 2012 19:32:53 +0000 (19:32 +0000)]
[Qt] tables/mozilla_expected_failures/bugs rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92017

Reviewed by Alexis Menard.

* platform/gtk/tables/mozilla_expected_failures/bugs/bug128876-expected.png:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug23847-expected.png:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug23847-expected.txt: Copied from LayoutTests/platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.txt.
* platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-6-expected.png:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-7-expected.png:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-8-expected.png:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-9-expected.png:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0/Skipped:
* platform/qt/tables/mozilla_expected_failures/bugs/bug128876-expected.png: Added.
* platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.png: Added.
* platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
* platform/qt/tables/mozilla_expected_failures/bugs/bug3166-6-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug3166-7-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug3166-8-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug3166-9-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd WebTextInputType enum values for text areas and
japhet@chromium.org [Mon, 23 Jul 2012 19:31:38 +0000 (19:31 +0000)]
Add WebTextInputType enum values for text areas and
content-editable.
https://bugs.webkit.org/show_bug.cgi?id=91654

Reviewed by Adam Barth.

No new tests, no behavior change without corresponding chromium.org changes.

* public/WebTextInputType.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::textInputType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonrwt: never finds binaries in the 'out' dir on chromium win
dpranke@chromium.org [Mon, 23 Jul 2012 19:26:45 +0000 (19:26 +0000)]
nrwt: never finds binaries in the 'out' dir on chromium win
https://bugs.webkit.org/show_bug.cgi?id=91890

Reviewed by Tony Chang.

We were figuring out which directory look in for binaries by
testing for the base directory (the directory above
Debug/Release). In chromium-win's case, we look in src/build,
which always exists because there are checked-in files in it,
which means we'd always pick that directory over src/out. All of
the other ports' build_path() implementation was including
Debug/Release. If we matched that, we wouldn't have a problem,
so this change fixes that and updates all of the callers of the
chromium ports' implementation to not pass configuration as part
of the path to look up; we still need to pass configuration in
some cases (to test if the build is out of date between debug
and release) so the implementation gets slightly more
complicated.

* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort._static_build_path):
(ChromiumPort.default_results_directory):
(ChromiumPort._build_path):
(ChromiumPort._path_to_image_diff):
* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort._build_path):
(ChromiumAndroidPort._path_to_driver):
(ChromiumAndroidPort._path_to_forwarder):
(ChromiumAndroidPort._push_executable):
(ChromiumAndroidPort._push_fonts):
* Scripts/webkitpy/layout_tests/port/chromium_linux.py:
(ChromiumLinuxPort._determine_driver_path_statically):
(ChromiumLinuxPort._modules_to_search_for_symbols):
(ChromiumLinuxPort._path_to_driver):
* Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
(ChromiumLinuxPortTest.test_build_path):
* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
(ChromiumMacPort._modules_to_search_for_symbols):
(ChromiumMacPort._path_to_driver):
(ChromiumMacPort._path_to_helper):
* Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
(ChromiumMacPortTest.test_build_path):
* Scripts/webkitpy/layout_tests/port/chromium_win.py:
(ChromiumWinPort._path_to_driver):
(ChromiumWinPort._path_to_helper):
(ChromiumWinPort._path_to_image_diff):
* Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
(ChromiumWinTest.test_build_path):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r123281): childNodes sometimes returns wrong nodes
rniwa@webkit.org [Mon, 23 Jul 2012 19:26:35 +0000 (19:26 +0000)]
REGRESSION(r123281): childNodes sometimes returns wrong nodes
https://bugs.webkit.org/show_bug.cgi?id=92014

Reviewed by Anders Carlsson.

Source/WebCore:

The bug was caused by a typo in itemBeforeOrAfter. Namely, it should have been calling firstNode as
firstNode(forward, rootNode(), shouldOnlyIncludeDirectChildren()),
NOT firstNode(forward, rootNode(), previous)
as evident from the argument list of the function.

Test: fast/dom/NodeList/childNodes-reverse-iteration.html

* html/HTMLCollection.cpp:
(WebCore::DynamicNodeListCacheBase::itemBeforeOrAfter):

LayoutTests:

Added an integration regression test that caught this bug.

* fast/dom/NodeList/childNodes-reverse-iteration-expected.txt: Added.
* fast/dom/NodeList/childNodes-reverse-iteration.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] animations needs rebaseline after new test fonts
commit-queue@webkit.org [Mon, 23 Jul 2012 18:58:00 +0000 (18:58 +0000)]
[Qt] animations needs rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=91997

Patch by Luciano Wolf <luciano.wolf@openbossa.org> on 2012-07-23
Reviewed by Noam Rosenthal.

Updating skipped tests inside animations directory.

* platform/qt-5.0/Skipped:
* platform/qt/animations/3d/change-transform-in-end-event-expected.txt: Added.
* platform/qt/animations/3d/state-at-end-event-transform-expected.txt:
* platform/qt/animations/additive-transform-animations-expected.txt:
* platform/qt/animations/cross-fade-background-image-expected.txt:
* platform/qt/animations/cross-fade-border-image-source-expected.txt:
* platform/qt/animations/cross-fade-list-style-image-expected.txt:
* platform/qt/animations/cross-fade-webkit-mask-box-image-expected.txt:
* platform/qt/animations/cross-fade-webkit-mask-image-expected.txt:
* platform/qt/animations/missing-values-first-keyframe-expected.txt:
* platform/qt/animations/missing-values-last-keyframe-expected.txt:
* platform/qt/animations/state-at-end-event-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChrome/Skia: PDF print output does not have clickable links.
commit-queue@webkit.org [Mon, 23 Jul 2012 18:48:42 +0000 (18:48 +0000)]
Chrome/Skia: PDF print output does not have clickable links.
https://bugs.webkit.org/show_bug.cgi?id=91171

Patch by Steve VanDeBogart <vandebo@chromium.org> on 2012-07-23
Reviewed by Stephen White.

Connect GraphicsContext::setURLForRect to Skia's new API for annotations.

Printing is not generally testable.

* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::setURLForRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Enable touch slider when touch events are enabled
pierre.rossi@gmail.com [Mon, 23 Jul 2012 18:45:51 +0000 (18:45 +0000)]
[Qt] Enable touch slider when touch events are enabled
https://bugs.webkit.org/show_bug.cgi?id=91013

Reviewed by Antonio Gomes.

Take advantage of the logic introduced in r122286.

* Target.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnify numTouchEventHandlersChanged and needTouchEvents in the chrome client
pierre.rossi@gmail.com [Mon, 23 Jul 2012 18:31:14 +0000 (18:31 +0000)]
Unify numTouchEventHandlersChanged and needTouchEvents in the chrome client
https://bugs.webkit.org/show_bug.cgi?id=91006

Reviewed by Ryosuke Niwa.

Source/WebCore:

The rationale here is that the client doesn't need to know about the touch
event handler count. needTouchEvents was already used for that purpose.

Test: fast/events/touch/touch-handler-count.html

* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::didAddTouchEventHandler): Only notify the client if needed.
(WebCore::Document::didRemoveTouchEventHandler): Ditto. Also unset the TOUCH_LISTENER
flag for the document if we reach a count of zero. The rationale being that
hasListenerType() is relied upon in other places in combination with TOUCH_LISTENER for
the same purpose.
* dom/Document.h:
(Document):
(WebCore::Document::touchEventHandlerCount):
* loader/EmptyClients.h:
* page/ChromeClient.h:
(ChromeClient):
* page/Frame.cpp: Removed notifyChromeClientTouchEventHandlerCountChanged.
(WebCore::Frame::setDocument): call needsTouchEvents directly.
* page/Frame.h: Ditto.
(Frame):
* testing/Internals.cpp:
(WebCore::Internals::hasTouchEventListener): expose Document::hasListenerType indirectly
for additional testing.
(WebCore):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:

Source/WebKit/blackberry:

Removed numTouchEventHandlersChanged stub.

* WebCoreSupport/ChromeClientBlackBerry.h:

Source/WebKit/chromium:

Rename the functions to follow a more boolean logic.

* public/WebViewClient.h:
(WebKit::WebViewClient::hasTouchEventHandlers):
* src/ChromeClientImpl.cpp:
(WebKit):
(WebKit::ChromeClientImpl::needTouchEvents):
* src/ChromeClientImpl.h:
(ChromeClientImpl):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::hasTouchEventHandlers):
* src/WebViewImpl.h:
(WebViewImpl):

Source/WebKit/efl:

Removed numTouchEventHandlersChanged stub.

* WebCoreSupport/ChromeClientEfl.h:

Source/WebKit/gtk:

Remove numTouchEventHandlersChanged stub.

* WebCoreSupport/ChromeClientGtk.h:

Source/WebKit/mac:

Remove numTouchEventHandlersChanged stub.

* WebCoreSupport/WebChromeClient.h:

Source/WebKit/qt:

Remove numTouchEventHandlersChanged stub.

* WebCoreSupport/ChromeClientQt.h:

Source/WebKit/win:

Remove numTouchEventHandlersChanged stub.

* WebCoreSupport/WebChromeClient.h:

Source/WebKit/wince:

Remove numTouchEventHandlersChanged stub.

* WebCoreSupport/ChromeClientWinCE.h:

Source/WebKit/wx:

Remove numTouchEventHandlersChanged stub.

* WebKitSupport/ChromeClientWx.h:

Source/WebKit2:

Remove numTouchEventHandlersChanged stub.

* WebProcess/WebCoreSupport/WebChromeClient.h:
(WebChromeClient):

LayoutTests:

Extend the touch-handler-count test to also cover the hasListenerType logic.

* fast/events/touch/touch-handler-count-expected.txt:
* fast/events/touch/touch-handler-count.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] RenderThemeQtMobile highlight colors are not being used
caio.oliveira@openbossa.org [Mon, 23 Jul 2012 18:23:58 +0000 (18:23 +0000)]
[Qt] RenderThemeQtMobile highlight colors are not being used
https://bugs.webkit.org/show_bug.cgi?id=92004

Reviewed by Noam Rosenthal.

Source/WebCore:

The issue here is that setPaletteFromPageClientIfExists() is being used as a
virtual function, but it isn't, so when platformActiveSelectionBackgroundColor()
runs, it doesn't pick the right palette.

Besides fixing this virtual behavior, the patch changes the structure a bit,
because setPaletteFromPageClientIfExists() was being "overriden" in mobile theme
to set the palette, which isn't exactly what the function name says.

* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeQt::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeQt::platformActiveSelectionForegroundColor):
(WebCore::RenderThemeQt::platformInactiveSelectionForegroundColor):
(WebCore::RenderThemeQt::platformFocusRingColor):
(WebCore::RenderThemeQt::systemColor):
(WebCore::RenderThemeQt::getMediaControlForegroundColor):
(WebCore::RenderThemeQt::paintMediaVolumeSliderTrack):
Use the virtual colorPalette() to get the palette.

(WebCore::RenderThemeQt::colorPalette):
(WebCore): Removed the code for getting the page client from here since it is
used only by the QStyle variant.

* platform/qt/RenderThemeQt.h:
(RenderThemeQt):
* platform/qt/RenderThemeQtMobile.cpp:
(WebCore::RenderThemeQtMobile::colorPalette):
(WebCore):
* platform/qt/RenderThemeQtMobile.h:
(RenderThemeQtMobile):

Source/WebKit/qt:

* WebCoreSupport/RenderThemeQStyle.cpp:
(WebCore::RenderThemeQStyle::setPaletteFromPageClientIfExists): Moved here since
it's used only by RenderThemeQStyle. Remove unnecessary check for m_page->chrome().
(WebCore):
(WebCore::RenderThemeQStyle::colorPalette):
* WebCoreSupport/RenderThemeQStyle.h:
(RenderThemeQStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium expectations change to mark fast/frames/frameset-frameborder...
atwilson@chromium.org [Mon, 23 Jul 2012 18:17:17 +0000 (18:17 +0000)]
Unreviewed chromium expectations change to mark fast/frames/frameset-frameborder-boolean-values.html as slow on snowleopard.
https://bugs.webkit.org/show_bug.cgi?id=24182

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium change to mark sandboxed-iframe-navigation-parent.html as slow...
atwilson@chromium.org [Mon, 23 Jul 2012 18:06:26 +0000 (18:06 +0000)]
Unreviewed chromium change to mark sandboxed-iframe-navigation-parent.html as slow on Windows.
https://bugs.webkit.org/show_bug.cgi?id=24182

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPart 1 of: Implement sticky positioning
simon.fraser@apple.com [Mon, 23 Jul 2012 17:45:43 +0000 (17:45 +0000)]
Part 1 of: Implement sticky positioning
https://bugs.webkit.org/show_bug.cgi?id=90046

Reviewed by Ojan Vafai.

Add ENABLE_CSS_STICKY_POSITION, defaulting to off initially.

Sort the ENABLE_CSS lines in the file.

* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:

Source/JavaScriptCore: Part 1 of: Implement sticky positioning
https://bugs.webkit.org/show_bug.cgi?id=90046

Reviewed by Ojan Vafai.

Add ENABLE_CSS_STICKY_POSITION, defaulting to off initially.

Sort the ENABLE_CSS lines in the file. Make sure all the flags
are in FEATURE_DEFINES.

* Configurations/FeatureDefines.xcconfig:

Source/WebCore: Part 1 of: Implement sticky positioning
https://bugs.webkit.org/show_bug.cgi?id=90046

Reviewed by Ojan Vafai.

Add ENABLE_CSS_STICKY_POSITION, defaulting to off initially.

Sort the ENABLE_CSS lines in the file. Make sure all the flags
are in FEATURE_DEFINES.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/chromium: Implement sticky positioning
https://bugs.webkit.org/show_bug.cgi?id=90046

Reviewed by Ojan Vafai.

Add ENABLE_CSS_STICKY_POSITION, defaulting to off initially.

* features.gypi:

Source/WebKit/mac: Part 1 of: Implement sticky positioning
https://bugs.webkit.org/show_bug.cgi?id=90046

Reviewed by Ojan Vafai.

Add ENABLE_CSS_STICKY_POSITION, defaulting to off initially.

Sort the ENABLE_CSS lines in the file. Make sure all the flags
are in FEATURE_DEFINES.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2: Part 1 of: Implement sticky positioning
https://bugs.webkit.org/show_bug.cgi?id=90046

Reviewed by Ojan Vafai.

Add ENABLE_CSS_STICKY_POSITION, defaulting to off initially.

Sort the ENABLE_CSS lines in the file. Make sure all the flags
are in FEATURE_DEFINES.

* Configurations/FeatureDefines.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium expectations change after r123302.
atwilson@chromium.org [Mon, 23 Jul 2012 17:44:12 +0000 (17:44 +0000)]
Unreviewed chromium expectations change after r123302.
https://bugs.webkit.org/show_bug.cgi?id-91806

* platform/chromium-win/fast/forms/number/number-appearance-rtl-expected.png:
* platform/chromium-win/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png:
* platform/chromium-win/fast/forms/number/number-appearance-spinbutton-layer-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium expectations change to ignore failures for policy-ignore-crash...
atwilson@chromium.org [Mon, 23 Jul 2012 17:27:54 +0000 (17:27 +0000)]
Unreviewed chromium expectations change to ignore failures for policy-ignore-crash.php.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSkip http/tests/pointer-lock on ports that do not support pointer lock.
scheib@chromium.org [Mon, 23 Jul 2012 16:25:04 +0000 (16:25 +0000)]
Skip http/tests/pointer-lock on ports that do not support pointer lock.

Unreviewed.

* platform/efl/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r123339.
philn@webkit.org [Mon, 23 Jul 2012 16:25:01 +0000 (16:25 +0000)]
Unreviewed, rolling out r123339.
http://trac.webkit.org/changeset/123339
https://bugs.webkit.org/show_bug.cgi?id=92006

massive media tests failure (Requested by philn on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-23

Source/WebCore:

* platform/graphics/gstreamer/GRefPtrGStreamer.cpp:
(WTF::adoptGRef):
* platform/graphics/gstreamer/GStreamerVersioning.cpp:
(setGstElementClassMetadata):
* platform/graphics/gstreamer/GStreamerVersioning.h:

Tools:

* Scripts/webkitdirs.pm:
(buildAutotoolsProject):
* gtk/jhbuild.modules:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] MediaStream API: Clean up the MockWebKitPlatformSupport object at shutdown
tommyw@google.com [Mon, 23 Jul 2012 16:15:25 +0000 (16:15 +0000)]
[chromium] MediaStream API: Clean up the MockWebKitPlatformSupport object at shutdown
https://bugs.webkit.org/show_bug.cgi?id=91857

Reviewed by Adam Barth.

Source/Platform:

Made Platforms destructor virtual.

* chromium/public/Platform.h:
(WebKit::Platform::~Platform):

Tools:

Made a few changes so that the destructor could be called at shutdown.

* DumpRenderTree/chromium/DumpRenderTree.cpp:
(WebKitSupportTestEnvironment::WebKitSupportTestEnvironment):
(WebKitSupportTestEnvironment):
* DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
(MockWebKitPlatformSupport::create):
* DumpRenderTree/chromium/MockWebKitPlatformSupport.h:
(MockWebKitPlatformSupport):
(MockWebKitPlatformSupport::~MockWebKitPlatformSupport):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Merge createThreadInternal implementations
rwlbuis@webkit.org [Mon, 23 Jul 2012 15:59:12 +0000 (15:59 +0000)]
[BlackBerry] Merge createThreadInternal implementations
https://bugs.webkit.org/show_bug.cgi?id=91899

Reviewed by Yong Li.

PR 111675

Remove our implementation since the default thread stack size on QNX is fine.

* wtf/ThreadingPthreads.cpp:
(WTF::createThreadInternal):
(WTF::initializeCurrentThreadInternal): make sure we set the thread name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowebkitFullscreenElement, webkitCurrentFullScreenElement, webkitPointerLockElement...
scheib@chromium.org [Mon, 23 Jul 2012 15:50:29 +0000 (15:50 +0000)]
webkitFullscreenElement, webkitCurrentFullScreenElement, webkitPointerLockElement block cross origin access.
https://bugs.webkit.org/show_bug.cgi?id=91892

Reviewed by Adam Barth.

Source/WebCore:

PointerLockElement only returned when requested from the document that owns it.

Tests: http/tests/fullscreen/fullscreenelement-different-origin.html
       http/tests/fullscreen/fullscreenelement-same-origin.html
       http/tests/pointer-lock/pointerlockelement-different-origin.html
       http/tests/pointer-lock/pointerlockelement-same-origin.html

* dom/Document.cpp:
(WebCore::Document::webkitPointerLockElement):

LayoutTests:

Tests verifying the behavior of accessing
webkitFullscreenElement, webkitCurrentFullScreenElement, webkitPointerLockElement
from different origins.

* http/tests/fullscreen/fullscreenelement-different-origin-expected.txt: Added.
* http/tests/fullscreen/fullscreenelement-different-origin.html: Added.
* http/tests/fullscreen/fullscreenelement-same-origin-expected.txt: Added.
* http/tests/fullscreen/fullscreenelement-same-origin.html: Added.
* http/tests/pointer-lock/pointerlockelement-different-origin-expected.txt: Added.
* http/tests/pointer-lock/pointerlockelement-different-origin.html: Added.
* http/tests/pointer-lock/pointerlockelement-same-origin-expected.txt: Added.
* http/tests/pointer-lock/pointerlockelement-same-origin.html: Added.
* http/tests/resources/pointer-lock/iframe-common.js: Added.
(thisFileName):
(window.onmessage):
* http/tests/resources/pointer-lock/inner-iframe.html: Added.
* http/tests/resources/pointer-lock/pointer-lock-test-harness.js:
(runOnKeyPress.keypressHandler):
* pointer-lock/locked-element-iframe-removed-from-dom-expected.txt:
* pointer-lock/locked-element-iframe-removed-from-dom.html:
* pointer-lock/locked-element-removed-from-dom-expected.txt:
* pointer-lock/locked-element-removed-from-dom.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Implement GCActivityCallback with platform timer
commit-queue@webkit.org [Mon, 23 Jul 2012 15:49:29 +0000 (15:49 +0000)]
[BlackBerry] Implement GCActivityCallback with platform timer
https://bugs.webkit.org/show_bug.cgi?id=90175

Patch by Yong Li <yoli@rim.com> on 2012-07-23
Reviewed by Rob Buis.

Use JSLock when performing GC to avoid assertions.

* runtime/GCActivityCallbackBlackBerry.cpp:
(JSC::DefaultGCActivityCallback::doWork):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Add request manager client
commit-queue@webkit.org [Mon, 23 Jul 2012 15:49:04 +0000 (15:49 +0000)]
[EFL][WK2] Add request manager client
https://bugs.webkit.org/show_bug.cgi?id=91193

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-23
Reviewed by Kenneth Rohde Christiansen.

Add a URL request manager client and attach it
to the Ewk_Context.

The client application can now register a URL scheme
via the Ewk_Context API and provide a callback handler
that will get called whenever a URL request with this
scheme is made.

A new Ewk_Url_Scheme_Request type is introduced to
provide information about the request to the client
and to allow the client to finish it by setting its
contents.

* PlatformEfl.cmake:
* UIProcess/API/efl/EWebKit2.h:
* UIProcess/API/efl/ewk_context.cpp:
(_Ewk_Url_Scheme_Handler):
(_Ewk_Url_Scheme_Handler::_Ewk_Url_Scheme_Handler):
(_Ewk_Context):
(_Ewk_Context::_Ewk_Context):
(ewk_context_request_manager_get):
(ewk_context_url_scheme_request_received):
(createDefaultEwkContext):
(ewk_context_uri_scheme_register):
* UIProcess/API/efl/ewk_context.h:
* UIProcess/API/efl/ewk_context_private.h:
* UIProcess/API/efl/ewk_context_request_manager_client.cpp: Added.
(toEwkContext):
(didReceiveURIRequest):
(ewk_context_request_manager_client_attach):
* UIProcess/API/efl/ewk_context_request_manager_client_private.h: Added.
* UIProcess/API/efl/ewk_url_scheme_request.cpp: Added.
(_Ewk_Url_Scheme_Request):
(_Ewk_Url_Scheme_Request::_Ewk_Url_Scheme_Request):
(_Ewk_Url_Scheme_Request::~_Ewk_Url_Scheme_Request):
(ewk_url_scheme_request_ref):
(ewk_url_scheme_request_unref):
(ewk_url_scheme_request_scheme_get):
(ewk_url_scheme_request_url_get):
(ewk_url_scheme_request_path_get):
(ewk_url_scheme_request_id_get):
(ewk_url_scheme_request_finish):
(ewk_url_scheme_request_new):
* UIProcess/API/efl/ewk_url_scheme_request.h: Added.
* UIProcess/API/efl/ewk_url_scheme_request_private.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening, adding the WONTFIX modifier to a few more tests,
zandobersek@gmail.com [Mon, 23 Jul 2012 15:39:50 +0000 (15:39 +0000)]
Unreviewed GTK gardening, adding the WONTFIX modifier to a few more tests,
moving them to the top of the expected failures section.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK][jhbuild] Switch to GStreamer 0.11 build
philn@webkit.org [Mon, 23 Jul 2012 15:39:36 +0000 (15:39 +0000)]
[GTK][jhbuild] Switch to GStreamer 0.11 build
https://bugs.webkit.org/show_bug.cgi?id=91727

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Add a new function to encapsulate the GStreamer API removal of
GST_OBJECT_IS_FLOATING in the upcoming 1.0 release. Use of this
macro can now be replaced by calling the g_object_is_floating
function.

* platform/graphics/gstreamer/GRefPtrGStreamer.cpp:
(WTF::adoptGRef):
* platform/graphics/gstreamer/GStreamerVersioning.cpp:
(gstObjectIsFloating):
* platform/graphics/gstreamer/GStreamerVersioning.h:

Tools:

Switch build-webkit --gtk to GStreamer 0.11 support and build the
necessary GStreamer git modules from JHBuild.

* Scripts/webkitdirs.pm:
(buildAutotoolsProject): Build WebKit with GStreamer 0.11 support.
* gtk/jhbuild.modules: GStreamer build support.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening. Skip the failing tests.
kkristof@inf.u-szeged.hu [Mon, 23 Jul 2012 15:01:14 +0000 (15:01 +0000)]
[Qt] Unreviewed gardening. Skip the failing tests.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] DumpRenderTree does not use 'monospace' font when directed
ossy@webkit.org [Mon, 23 Jul 2012 14:17:23 +0000 (14:17 +0000)]
[Qt] DumpRenderTree does not use 'monospace' font when directed
https://bugs.webkit.org/show_bug.cgi?id=85203

Unreviewed gardening.

* platform/qt-4.8/Skipped: Unskip now passing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] editing/inserting/multiple-lines-selected.html fails
caio.oliveira@openbossa.org [Mon, 23 Jul 2012 14:15:38 +0000 (14:15 +0000)]
[Qt] editing/inserting/multiple-lines-selected.html fails
https://bugs.webkit.org/show_bug.cgi?id=91993

Reviewed by Simon Hausmann.

Removing wrong expected results, adding it to the skipped list.

* platform/qt-5.0/Skipped:
* platform/qt/editing/inserting/multiple-lines-selected-expected.png: Removed.
* platform/qt/editing/inserting/multiple-lines-selected-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] editing/inserting rebaseline after new test fonts
caio.oliveira@openbossa.org [Mon, 23 Jul 2012 13:53:07 +0000 (13:53 +0000)]
[Qt] editing/inserting rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=91985

Unreviewed.

* platform/qt-5.0-wk1/Skipped:
* platform/qt-5.0-wk1/editing/inserting/4960120-1-expected.png: Removed.
* platform/qt-5.0-wk1/editing/inserting/4960120-1-expected.txt: Removed.
* platform/qt-5.0-wk1/editing/inserting/before-after-input-element-expected.png: Removed.
* platform/qt-5.0-wk1/editing/inserting/before-after-input-element-expected.txt: Removed.
* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0/Skipped:
* platform/qt-5.0/editing/inserting/5549929-2-expected.txt: Removed.
* platform/qt-5.0/editing/inserting/5549929-3-expected.txt: Removed.
* platform/qt-5.0/editing/inserting/insert-br-at-tabspan-001-expected.txt: Removed.
* platform/qt-5.0/editing/inserting/insert-br-at-tabspan-002-expected.txt: Removed.
* platform/qt-5.0/editing/inserting/insert-br-at-tabspan-003-expected.txt: Removed.
* platform/qt-5.0/editing/inserting/insert-tab-001-expected.txt: Removed.
* platform/qt-5.0/editing/inserting/insert-tab-002-expected.txt: Removed.
* platform/qt-5.0/editing/inserting/insert-tab-004-expected.txt: Removed.
* platform/qt-5.0/editing/inserting/insert-text-at-tabspan-001-expected.txt: Removed.
* platform/qt-5.0/editing/inserting/insert-text-at-tabspan-002-expected.txt: Removed.
* platform/qt-5.0/editing/inserting/insert-text-at-tabspan-003-expected.txt: Removed.
* platform/qt/editing/inserting/4960120-1-expected.png:
* platform/qt/editing/inserting/before-after-input-element-expected.png:
* platform/qt/editing/inserting/insert-3654864-fix-expected.txt:
* platform/qt/editing/inserting/insert-3851164-fix-expected.txt:
* platform/qt/editing/inserting/insert-div-009-expected.png: Added.
* platform/qt/editing/inserting/insert-div-009-expected.txt:
* platform/qt/editing/inserting/insert-div-010-expected.png: Added.
* platform/qt/editing/inserting/insert-div-010-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] media/controls-styling.html is failing
commit-queue@webkit.org [Mon, 23 Jul 2012 13:30:54 +0000 (13:30 +0000)]
[EFL] media/controls-styling.html is failing
https://bugs.webkit.org/show_bug.cgi?id=91984

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-23
Reviewed by Eric Carlson.

Source/WebCore:

Make sure that the CSS properties letter-spacing, word-spacing,
line-height, text-transform, text-indent, text-shadow,
text-decoration and color do not affect the media element controls,
that display text.

No new tests. Already tested by media/controls-styling.html and
media/controls-styling-strict.html

* css/mediaControlsEfl.css:
(audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):

LayoutTests:

Rebaseline media controls styling tests now that the
EFL port properly ensures that overriding CSS
properties won't affect the media controls.

* platform/efl/media/controls-styling-expected.png:
* platform/efl/media/controls-styling-expected.txt:
* platform/efl/media/controls-styling-strict-expected.png:
* platform/efl/media/controls-styling-strict-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] fast/layers/video-layer.html needs rebasing after r123320
commit-queue@webkit.org [Mon, 23 Jul 2012 12:15:58 +0000 (12:15 +0000)]
[EFL] fast/layers/video-layer.html needs rebasing after r123320
https://bugs.webkit.org/show_bug.cgi?id=91978

Unreviewed EFL gardening, regenerate baseline for
fast/layers/video-layer.html after r123320.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-23

* platform/efl/fast/layers/video-layer-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening.
kkristof@inf.u-szeged.hu [Mon, 23 Jul 2012 11:44:28 +0000 (11:44 +0000)]
[Qt] Unreviewed gardening.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] ProcessExecutablePath is required
commit-queue@webkit.org [Mon, 23 Jul 2012 11:37:26 +0000 (11:37 +0000)]
[EFL][WK2] ProcessExecutablePath is required
https://bugs.webkit.org/show_bug.cgi?id=89719

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-07-23
Reviewed by Kenneth Rohde Christiansen.

Added executablePathOfWebProcess and executablePathOfPluginProcess.
It's used for getting the location of WebProcess and PluginProcess.

* PlatformEfl.cmake: Added LIBEXECDIR definition
* Shared/efl/ProcessExecutablePathEfl.cpp: Added.
(WebKit):
(WebKit::findWebKitProcess):
(WebKit::executablePathOfWebProcess): Get the absolute path of WebProcess
(WebKit::executablePathOfPluginProcess): Get the absolute path of PluginProcess
* UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:
(WebKit::ProcessLauncher::launchProcess): Modified to use above routines

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Fix make distcheck.
carlosgc@webkit.org [Mon, 23 Jul 2012 11:27:34 +0000 (11:27 +0000)]
Unreviewed. Fix make distcheck.

* GNUmakefile.list.am: Add missing header files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoReplace some instances of shadowAncestorNode() with shadowHost()
tkent@chromium.org [Mon, 23 Jul 2012 11:19:43 +0000 (11:19 +0000)]
Replace some instances of shadowAncestorNode() with shadowHost()
https://bugs.webkit.org/show_bug.cgi?id=91966

Reviewed by Hajime Morita.

shadowAncestorNode() is deprecated. We should use shadowHost().
No new tests. This doesn't change any behavior.

* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkSelector):
* dom/TreeScope.cpp:
(WebCore::listTreeScopes):
* html/HTMLSummaryElement.cpp:
(WebCore::isClickableControl):
* html/shadow/DetailsMarkerControl.cpp:
(WebCore::DetailsMarkerControl::summaryElement):
* html/shadow/MeterShadowElement.cpp:
(WebCore::MeterShadowElement::meterElement):
* html/shadow/ProgressShadowElement.cpp:
(WebCore::ProgressShadowElement::progressElement):
* html/shadow/SliderThumbElement.cpp:
(WebCore::RenderSliderThumb::layout):
(WebCore::RenderSliderContainer::layout):
(WebCore::SliderThumbElement::hostInput):
(WebCore::TrackLimiterElement::shadowPseudoId):
(WebCore::SliderContainerElement::shadowPseudoId):
* html/shadow/TextControlInnerElements.cpp:
(WebCore::TextControlInnerElement::customStyleForRenderer):
(WebCore::TextControlInnerTextElement::defaultEventHandler):
(WebCore::TextControlInnerTextElement::createRenderer):
(WebCore::TextControlInnerTextElement::customStyleForRenderer):
(WebCore::SearchFieldResultsButtonElement::shadowPseudoId):
(WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
(WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
(WebCore::SpinButtonElement::defaultEventHandler):
(WebCore::SpinButtonElement::step):
(WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
(WebCore::InputFieldSpeechButtonElement::setState):
(WebCore::InputFieldSpeechButtonElement::setRecognitionResult):
(WebCore::InputFieldSpeechButtonElement::startSpeechInput):
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlInnerBlock::positionForPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] REGRESSION r122966: Crash when closing tab with Web Inspector open in WebKit...
pfeldman@chromium.org [Mon, 23 Jul 2012 11:18:20 +0000 (11:18 +0000)]
[WK2] REGRESSION r122966: Crash when closing tab with Web Inspector open in WebKit::PageOverlay
https://bugs.webkit.org/show_bug.cgi?id=91782

Reviewed by Yury Semikhatsky.

hideHighlight was never called once user hovered over a node.

* inspector/DOMNodeHighlighter.cpp:
(WebCore::InspectorOverlay::update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] new test introduced in r123205 fails on Qt
commit-queue@webkit.org [Mon, 23 Jul 2012 11:07:58 +0000 (11:07 +0000)]
[Qt] new test introduced in r123205 fails on Qt
https://bugs.webkit.org/show_bug.cgi?id=91967

Patch by Andrei Poenaru <poenaru@adobe.com> on 2012-07-23
Reviewed by Kenneth Rohde Christiansen.

Skipped WebInspector test that needs CSS Regions enabled.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Build fix for the Windows builder following r123311
peter@chromium.org [Mon, 23 Jul 2012 10:54:17 +0000 (10:54 +0000)]
[Chromium] Build fix for the Windows builder following r123311
https://bugs.webkit.org/show_bug.cgi?id=91979

Unreviewed build fix.

Changeset r123311 moved the TextCodecWinCE.{cpp,h} files to the Windows
directory. Update Chromium's references to these files to fix the build.

* WebCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Buildfix for fixing gclient on the Chromium Windows bot
peter@chromium.org [Mon, 23 Jul 2012 10:36:19 +0000 (10:36 +0000)]
[Chromium] Buildfix for fixing gclient on the Chromium Windows bot
https://bugs.webkit.org/show_bug.cgi?id=91977

Unreviewed build fix.

Add the tools/isolate directory to the Windows checkout as these files
currently are missing during gyp generation. maruel introduced the need
for these in this isolate refactoring, specifically this Chromium CL:
http://src.chromium.org/viewvc/chrome?view=rev&revision=147689

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WINCE] Define NOMINMAX in the build system instead of Platform.h
paroga@webkit.org [Mon, 23 Jul 2012 10:05:19 +0000 (10:05 +0000)]
[WINCE] Define NOMINMAX in the build system instead of Platform.h
https://bugs.webkit.org/show_bug.cgi?id=91938

Reviewed by Ryosuke Niwa.

.:

Define it in OptionsWindows.cmake, since NOMINMAX
should to be defined for all windows ports.

* Source/cmake/OptionsWinCE.cmake:
* Source/cmake/OptionsWindows.cmake:

Source/WTF:

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WIN] Remove ICU dependencies from UniscribeController
paroga@webkit.org [Mon, 23 Jul 2012 09:58:34 +0000 (09:58 +0000)]
[WIN] Remove ICU dependencies from UniscribeController
https://bugs.webkit.org/show_bug.cgi?id=91921

Reviewed by Ryosuke Niwa.

Replace ICU specific functions and macros with the corresponding code from WTF::Unicode.
This allows us to use UniscribeController with an other Unicode implementation too.

* platform/graphics/win/UniscribeController.cpp:
(WebCore::UniscribeController::advance):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix for Windows after r123317.
paroga@webkit.org [Mon, 23 Jul 2012 09:47:59 +0000 (09:47 +0000)]
Build fix for Windows after r123317.

* wtf/DateMath.cpp: Added missing header include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Mon, 23 Jul 2012 09:47:18 +0000 (09:47 +0000)]
Unreviewed GTK gardening.

Marking more svg/W3C-SVG-1.1/animate-elem-* tests as flaky.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] media/controls-styling-strict.html is failing
commit-queue@webkit.org [Mon, 23 Jul 2012 09:23:14 +0000 (09:23 +0000)]
[EFL] media/controls-styling-strict.html is failing
https://bugs.webkit.org/show_bug.cgi?id=91960

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-23
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Use "display: -webkit-box;" instead of inline-block
for current-time control. This is needed because
inline-block behaves differently in strict mode.

No new test, already tested by media/controls-styling-strict.html

* css/mediaControlsEfl.css:
(audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):

LayoutTests:

Update test expectations for media tests now that
we use "display: -webkit-box;" for the current-time
control.

* platform/efl/media/audio-controls-rendering-expected.txt:
* platform/efl/media/audio-repaint-expected.png:
* platform/efl/media/audio-repaint-expected.txt:
* platform/efl/media/controls-layout-direction-expected.png:
* platform/efl/media/controls-strict-expected.png:
* platform/efl/media/controls-strict-expected.txt:
* platform/efl/media/controls-styling-expected.txt:
* platform/efl/media/controls-styling-strict-expected.png: Added.
* platform/efl/media/controls-styling-strict-expected.txt: Added.
* platform/efl/media/media-controls-clone-expected.png:
* platform/efl/media/media-controls-clone-expected.txt:
* platform/efl/media/video-aspect-ratio-expected.png:
* platform/efl/media/video-layer-crash-expected.png:
* platform/efl/media/video-transformed-expected.png:
* platform/efl/media/video-zoom-controls-expected.png:
* platform/efl/media/video-zoom-controls-expected.txt:
* platform/efl/media/video-zoom-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Fix GTK+ build with ENABLE_DATALIST_ELEMENT.
carlosgc@webkit.org [Mon, 23 Jul 2012 08:43:11 +0000 (08:43 +0000)]
Unreviewed. Fix GTK+ build with ENABLE_DATALIST_ELEMENT.

Add an implementation for virtual pure methods sliderTickSize()
and sliderTickOffsetFromTrackCenter() when HTML5 datalist element
is enabled.

* platform/gtk/RenderThemeGtk.cpp:
(WebCore):
(WebCore::RenderThemeGtk::sliderTickSize):
(WebCore::RenderThemeGtk::sliderTickOffsetFromTrackCenter):
* platform/gtk/RenderThemeGtk.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Skip http/tests/inspector-enabled/injected-script-discard.html
commit-queue@webkit.org [Mon, 23 Jul 2012 08:36:40 +0000 (08:36 +0000)]
[EFL] Skip http/tests/inspector-enabled/injected-script-discard.html
https://bugs.webkit.org/show_bug.cgi?id=91959

Unreviewed EFL gardening. Skip flaky Web Inspector test case.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-23

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WIN] Use GetTimeZoneInformation() for calculateUTCOffset()
paroga@webkit.org [Mon, 23 Jul 2012 08:34:19 +0000 (08:34 +0000)]
[WIN] Use GetTimeZoneInformation() for calculateUTCOffset()
https://bugs.webkit.org/show_bug.cgi?id=91935

Reviewed by Ryosuke Niwa.

GetTimeZoneInformation() returns the offset directly. Using it
avoids unnecessary calculations and remove dependencies on
other time related function, which do not exist on WinCE.

* wtf/DateMath.cpp:
(WTF::calculateUTCOffset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebKit2 needs layoutTestController.setAlwaysAcceptCookies
commit-queue@webkit.org [Mon, 23 Jul 2012 08:33:26 +0000 (08:33 +0000)]
WebKit2 needs layoutTestController.setAlwaysAcceptCookies
https://bugs.webkit.org/show_bug.cgi?id=42778

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-23
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Add setAlwaysAcceptCookies() method to InjectedBundle
so that we can use it in LayoutTestController.
The method uses WebCookieManager::setHTTPCookieAcceptPolicy()
internally.

* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleSetAlwaysAcceptCookies):
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setAlwaysAcceptCookies):
(WebKit):
* WebProcess/InjectedBundle/InjectedBundle.h:
(InjectedBundle):

Tools:

Add support for layoutTestController.setAlwaysAcceptCookies()
since it is required by some tests.

* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::setAlwaysAcceptCookies):
(WTR):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(LayoutTestController):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] SQL Database cannot be disabled at build time
commit-queue@webkit.org [Mon, 23 Jul 2012 08:30:11 +0000 (08:30 +0000)]
[WK2] SQL Database cannot be disabled at build time
https://bugs.webkit.org/show_bug.cgi?id=91837

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-23
Reviewed by Kenneth Rohde Christiansen.

WebKit2 had no #ifdefs for SQL Database. This patch adds these
statments and it can now be disabled at build time.

* Shared/OriginAndDatabases.cpp:
* Shared/OriginAndDatabases.h:
* Shared/WebCoreArgumentCoders.cpp:
(CoreIPC):
* UIProcess/API/C/WKContext.cpp:
(WKContextGetDatabaseManager):
* UIProcess/API/C/WKDatabaseManager.cpp:
(WKDatabaseManagerGetTypeID):
(WKDatabaseManagerGetOriginKey):
(WKDatabaseManagerGetOriginQuotaKey):
(WKDatabaseManagerGetOriginUsageKey):
(WKDatabaseManagerGetDatabaseDetailsKey):
(WKDatabaseManagerGetDatabaseDetailsNameKey):
(WKDatabaseManagerGetDatabaseDetailsDisplayNameKey):
(WKDatabaseManagerGetDatabaseDetailsExpectedUsageKey):
(WKDatabaseManagerGetDatabaseDetailsCurrentUsageKey):
(WKDatabaseManagerSetClient):
(WKDatabaseManagerGetDatabasesByOrigin):
(callGetDatabasesByOriginBlockAndDispose):
(WKDatabaseManagerGetDatabasesByOrigin_b):
(WKDatabaseManagerGetDatabaseOrigins):
(callGetDatabaseOriginsBlockBlockAndDispose):
(WKDatabaseManagerGetDatabaseOrigins_b):
(WKDatabaseManagerDeleteDatabasesWithNameForOrigin):
(WKDatabaseManagerDeleteDatabasesForOrigin):
(WKDatabaseManagerDeleteAllDatabases):
(WKDatabaseManagerSetQuotaForOrigin):
* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
(WebKit::WebContext::shouldTerminate):
(WebKit::WebContext::disconnectProcess):
(WebKit::WebContext::didReceiveMessage):
* UIProcess/WebContext.h:
(WebContext):
* UIProcess/WebDatabaseManagerProxy.cpp:
* UIProcess/WebDatabaseManagerProxy.h:
* UIProcess/WebDatabaseManagerProxy.messages.in:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::clearAllDatabases):
(WebKit::InjectedBundle::setDatabaseQuota):
* WebProcess/WebCoreSupport/WebDatabaseManager.cpp:
* WebProcess/WebCoreSupport/WebDatabaseManager.h:
* WebProcess/WebCoreSupport/WebDatabaseManager.messages.in:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didReceiveMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoReplace getCurrentLocalTime() with GetLocalTime() in LocaleWin.cpp
paroga@webkit.org [Mon, 23 Jul 2012 08:24:22 +0000 (08:24 +0000)]
Replace getCurrentLocalTime() with GetLocalTime() in LocaleWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=91937

Reviewed by Ryosuke Niwa.

The windows function returns the required year directly and
removes one additonal dependecy on getCurrentLocalTime().

* platform/text/LocaleWin.cpp:
(WebCore::LocaleWin::LocaleWin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Drag and drop should not be started on right mouse click.
vsevik@chromium.org [Mon, 23 Jul 2012 08:18:54 +0000 (08:18 +0000)]
Web Inspector: Drag and drop should not be started on right mouse click.
https://bugs.webkit.org/show_bug.cgi?id=91728

Reviewed by Pavel Feldman.

Introduced WebInspector.installDragHandle method to control drag and drop support, checking whichg mouse button is pressed.
Simplified WebInspector._elementDragStart, removed "element" parameter.
Simplified tab moving support in TabbedPane, removed "mousemove" handler.
Removed while loop determining which element was dragged in TimelineOverviewPane, each drag support is now installed independently.
Drive-by: fixed TimelineOverviewPane window moving on resources-dividers-label-bar drang-and-drop.
Drive-by: fixed CSSStyleModel compilation.
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync):
* inspector/front-end/DataGrid.js:
(WebInspector.DataGrid.prototype._positionResizers):
(WebInspector.DataGrid.prototype._startResizerDragging):
(WebInspector.DataGrid.prototype._endResizerDragging):
* inspector/front-end/Drawer.js:
(WebInspector.Drawer):
(WebInspector.Drawer.prototype._animationDuration):
(WebInspector.Drawer.prototype._startStatusBarDragging):
(WebInspector.Drawer.prototype._endStatusBarDragging):
* inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.prototype._startRetainersHeaderDragging):
(WebInspector.HeapSnapshotView.prototype._endRetainersHeaderDragging):
* inspector/front-end/SidebarOverlay.js:
(WebInspector.SidebarOverlay.prototype.set _startResizerDragging):
(WebInspector.SidebarOverlay.prototype._endResizerDragging):
(WebInspector.SidebarOverlay.prototype._installResizer):
* inspector/front-end/Spectrum.js:
* inspector/front-end/SplitView.js:
(WebInspector.SplitView.prototype._startResizerDragging):
(WebInspector.SplitView.prototype._endResizerDragging):
(WebInspector.SplitView.prototype.installResizer):
* inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPaneTab.prototype._createTabElement):
(WebInspector.TabbedPaneTab.prototype._tabMouseDown):
(WebInspector.TabbedPaneTab.prototype._startTabDragging):
(WebInspector.TabbedPaneTab.prototype._endTabDragging):
* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewWindow):
(WebInspector.TimelineOverviewWindow.prototype._leftResizeElementDragging):
(WebInspector.TimelineOverviewWindow.prototype._rightResizeElementDragging):
(WebInspector.TimelineOverviewWindow.prototype._startWindowSelectorDragging):
(WebInspector.TimelineOverviewWindow.prototype._endWindowSelectorDragging):
(WebInspector.TimelineOverviewWindow.prototype._startWindowDragging):
(WebInspector.TimelineOverviewWindow.prototype._windowDragging):
(WebInspector.TimelineOverviewWindow.prototype._endWindowDragging):
(WebInspector.TimelineOverviewWindow.prototype._moveWindow):
(WebInspector.TimelineOverviewWindow.prototype._onMouseWheel):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._startSplitterDragging):
(WebInspector.TimelinePanel.prototype._endSplitterDragging):
* inspector/front-end/Toolbar.js:
(WebInspector.Toolbar):
(WebInspector.Toolbar.prototype._toolbarDragStart):
(WebInspector.Toolbar.prototype._toolbarDragEnd):
* inspector/front-end/UIUtils.js:
(WebInspector.installDragHandle):
(WebInspector._elementDragStart):
(WebInspector._elementDragEnd):
* inspector/front-end/timelinePanel.css:
(#timeline-overview-grid .resources-dividers-label-bar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoComposedShadowTreeWalker should skip an empty insertion points.
hayato@chromium.org [Mon, 23 Jul 2012 08:08:36 +0000 (08:08 +0000)]
ComposedShadowTreeWalker should skip an empty insertion points.
https://bugs.webkit.org/show_bug.cgi?id=91826

Reviewed by Hajime Morita.

Source/WebCore:

ComposedShadowTreeWalker wrongly returns 'null' if it encounters
an insertion point into where no nodes are distributed.  We should
skip such an insertion point and continue walking using the next
possible node, which might be a next sibling or a next distributed
node, and resolve the next node recursively.

Test: fast/dom/shadow/composed-shadow-tree-walker.html

* dom/ComposedShadowTreeWalker.cpp:
(WebCore::ComposedShadowTreeWalker::traverseLightChildren):
(WebCore):
(WebCore::ComposedShadowTreeWalker::traverseSiblings):
(WebCore::ComposedShadowTreeWalker::traverseNode):
(WebCore::ComposedShadowTreeWalker::traverseDistributedeNodes):
(WebCore::ComposedShadowTreeWalker::traverseSiblingOrBackToInsertionPoint):
(WebCore::ComposedShadowTreeWalker::traverseSiblingInCurrentTree):
(WebCore::ComposedShadowTreeWalker::traverseBackToYoungerShadowRoot):
* dom/ComposedShadowTreeWalker.h:
(ComposedShadowTreeWalker):

LayoutTests:

* fast/dom/shadow/composed-shadow-tree-walker-expected.txt:
* fast/dom/shadow/composed-shadow-tree-walker.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRename TextCodecWinCE to TextCodecWin
paroga@webkit.org [Mon, 23 Jul 2012 08:06:07 +0000 (08:06 +0000)]
Rename TextCodecWinCE to TextCodecWin
https://bugs.webkit.org/show_bug.cgi?id=91947

Reviewed by Ryosuke Niwa.

Since TextCodecWinCE is used by other (non-upstreamed) windows ports too,
TextCodecWin is a better name for the implementation.
Also remove the dependency on WinCE FontCache to make it more usable.

* PlatformWinCE.cmake:
* platform/text/TextEncodingRegistry.cpp:
(WebCore::extendTextCodecMaps):
* platform/text/win/TextCodecWin.cpp: Renamed from Source/WebCore/platform/text/wince/TextCodecWinCE.cpp.
* platform/text/win/TextCodecWin.h: Renamed from Source/WebCore/platform/text/wince/TextCodecWinCE.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening. Skip the new failing tests.
kkristof@inf.u-szeged.hu [Mon, 23 Jul 2012 08:00:34 +0000 (08:00 +0000)]
[Qt] Unreviewed gardening. Skip the new failing tests.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImprove AudioChannelSplitter test
commit-queue@webkit.org [Mon, 23 Jul 2012 07:53:19 +0000 (07:53 +0000)]
Improve AudioChannelSplitter test
https://bugs.webkit.org/show_bug.cgi?id=91962

Patch by Li Yin <li.yin@intel.com> on 2012-07-23
Reviewed by Kentaro Hara.

Spec: https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#AudioChannelSplitter-section
The numberOfOutputs parameter determines the number of outputs.
Values of up to 32 must be supported. If not specified, then 6 will be used.

* webaudio/audiochannelsplitter-expected.txt:
* webaudio/audiochannelsplitter.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] CodeGeneratorV8.pm should support static attributes
haraken@chromium.org [Mon, 23 Jul 2012 04:55:58 +0000 (04:55 +0000)]
[V8] CodeGeneratorV8.pm should support static attributes
https://bugs.webkit.org/show_bug.cgi?id=91764

Reviewed by Adam Barth.

CodeGeneratorJS.pm already supports static attributes.
CodeGeneratorV8.pm should also support them.

Tests: bindings/scripts/test/TestObj.idl
       bindings/scripts/test/TestSupplemental.idl

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):

* bindings/scripts/test/TestObj.idl: Added defined(TESTING_V8).
* bindings/scripts/test/TestSupplemental.idl: Added test cases for static attributes in supplemental IDL files.

* bindings/scripts/test/JS/JSTestInterface.cpp: Updated run-bindings-tests results.
(WebCore):
(WebCore::jsTestInterfaceConstructorSupplementalStaticReadOnlyAttr):
The generated code is wrong since CodeGeneratorJS.pm does not support static attributes for
supplemental IDL files. I will fix it in a follow-up patch.
(WebCore::jsTestInterfaceConstructorSupplementalStaticAttr):
(WebCore::setJSTestInterfaceConstructorSupplementalStaticAttr):
* bindings/scripts/test/JS/JSTestInterface.h:
(WebCore):
* bindings/scripts/test/V8/V8TestInterface.cpp: Updated run-bindings-tests results.
(WebCore::TestInterfaceV8Internal::supplementalStaticReadOnlyAttrAttrGetter):
(TestInterfaceV8Internal):
(WebCore::TestInterfaceV8Internal::supplementalStaticAttrAttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalStaticAttrAttrSetter):
(WebCore):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::staticReadOnlyIntAttrAttrGetter):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::staticStringAttrAttrGetter):
(WebCore::TestObjV8Internal::staticStringAttrAttrSetter):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123308 268f45cc-cd09-0410-ab3c-d52691b4dbfc