WebKit-https.git
7 years agoWeb Inspector: Create JavaScriptSources based on network resources.
vsevik@chromium.org [Mon, 3 Sep 2012 16:34:08 +0000 (16:34 +0000)]
Web Inspector: Create JavaScriptSources based on network resources.
https://bugs.webkit.org/show_bug.cgi?id=95352

Reviewed by Pavel Feldman.

Source/WebCore:

Introduced NetworkUISourceCodeProvider that is listening for ResourceTreeModel and creates UISourceCodes for them.
RawSourceCode does not create uiSourceCodes based on resource anymore (this is done by NetworkUISourceCodeProvider instead).
Moved script <-> uiSourceCode binding logic from RawSourceCode to ResourceScriptMapping.
Removed rawSourceCode as it was not needed anymore.

Tests: inspector/debugger/network-uisourcecode-provider.html
       inspector/debugger/resource-script-mapping.html

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/CompilerScriptMapping.js:
* inspector/front-end/JavaScriptSource.js:
(WebInspector.JavaScriptSource):
* inspector/front-end/NetworkUISourceCodeProvider.js: Renamed from Source/WebCore/inspector/front-end/StylesUISourceCodeProvider.js.
(WebInspector.NetworkUISourceCodeProvider):
(WebInspector.NetworkUISourceCodeProvider.prototype._populate):
(WebInspector.NetworkUISourceCodeProvider.prototype._styleResourceAdded):
(WebInspector.NetworkUISourceCodeProvider.prototype._scriptResourceAdded.resourceFinished):
(WebInspector.NetworkUISourceCodeProvider.prototype._scriptResourceAdded):
(WebInspector.NetworkUISourceCodeProvider.prototype._addJavaScriptSource):
(WebInspector.NetworkUISourceCodeProvider.prototype._addUISourceCode):
(WebInspector.NetworkUISourceCodeProvider.prototype._resourceAdded):
(WebInspector.NetworkUISourceCodeProvider.prototype._reset):
* inspector/front-end/RawSourceCode.js:
* inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping):
(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.ResourceScriptMapping.prototype._bindUISourceCodeToScripts):
(WebInspector.ResourceScriptMapping.prototype._scriptsForSourceURL):
(WebInspector.ResourceScriptMapping.prototype._addOrReplaceTemporaryUISourceCode.get var):
(WebInspector.ResourceScriptMapping.prototype._addOrReplaceTemporaryUISourceCode):
(WebInspector.ResourceScriptMapping.prototype.get _uiSourceCodeReplaced):
(WebInspector.ResourceScriptMapping.prototype._reset):
* inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):
(WebInspector.SnippetJavaScriptSource):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.uiLocationToRawLocation):
(WebInspector.UISourceCode.prototype.setSourceMapping):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:

LayoutTests:

Removed raw-source-code.html test as RawSourceCode was removed by this patch.
Added resource-script-mapping.html to test script <-> uiSourceCode binding behavior.
Added network-uisourcecode-provider.html to test uiSourceCode creation behavior.
Updated dynamic-script-tag.html to better match expected behavior.

* http/tests/inspector/network/network-request-revision-content.html:
* http/tests/inspector/workspace-test.js: Added.
(initialize_WorkspaceTest.InspectorTest.createWorkspace):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeReplacedEvent.uiSourceCodeReplaced):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeReplacedEvent):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeAddedEvent.uiSourceCodeAdded):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeAddedEvent):
(initialize_WorkspaceTest.InspectorTest.addMockUISourceCodeToWorkspace):
(initialize_WorkspaceTest.InspectorTest._defaultUISourceCodeProviderEventHandler):
(initialize_WorkspaceTest.InspectorTest.dumpUISourceCode.didRequestContent):
(initialize_WorkspaceTest.InspectorTest.dumpUISourceCode):
(initialize_WorkspaceTest):
* inspector/debugger/breakpoint-manager.html:
* inspector/debugger/dynamic-script-tag-expected.txt:
* inspector/debugger/dynamic-script-tag.html:
* inspector/debugger/network-uisourcecode-provider-expected.txt: Added.
* inspector/debugger/network-uisourcecode-provider.html: Added.
* inspector/debugger/raw-source-code-expected.txt: Removed.
* inspector/debugger/raw-source-code.html: Removed.
* inspector/debugger/resource-script-mapping-expected.txt: Added.
* inspector/debugger/resource-script-mapping.html: Added.
* inspector/debugger/scripts-panel.html:
* inspector/debugger/source-frame-count.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [WebGL] Make the injected __resourceObject property non-enumerable
commit-queue@webkit.org [Mon, 3 Sep 2012 16:09:54 +0000 (16:09 +0000)]
Web Inspector: [WebGL] Make the injected __resourceObject property non-enumerable
https://bugs.webkit.org/show_bug.cgi?id=95682

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-09-03
Reviewed by Pavel Feldman.

Make the injected auxiliary property __resourceObject non-enumerable to hide it from for..in iterations.
Ideally this property should be completely hidden from the user's code.
Drive-by: Fix couple of small FIXME's.
* inspector/InjectedScriptWebGLModuleSource.js:
(.):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMediaStream API: Add Ice-related functionality to RTCPeerConnection
tommyw@google.com [Mon, 3 Sep 2012 16:08:07 +0000 (16:08 +0000)]
MediaStream API: Add Ice-related functionality to RTCPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=95565

Reviewed by Adam Barth.

Source/Platform:

* Platform.gypi:
* chromium/public/WebRTCICECandidateDescriptor.h: Copied from Source/Platform/chromium/public/WebRTCPeerConnectionHandlerClient.h.
(WebCore):
(WebKit):
(WebRTCICECandidateDescriptor):
(WebKit::WebRTCICECandidateDescriptor::WebRTCICECandidateDescriptor):
(WebKit::WebRTCICECandidateDescriptor::~WebRTCICECandidateDescriptor):
(WebKit::WebRTCICECandidateDescriptor::operator=):
(WebKit::WebRTCICECandidateDescriptor::isNull):
* chromium/public/WebRTCPeerConnectionHandler.h:
(WebKit):
(WebRTCPeerConnectionHandler):
* chromium/public/WebRTCPeerConnectionHandlerClient.h:
(WebKit):
(WebRTCPeerConnectionHandlerClient):

Source/WebCore:

Adds all Ice-related functionality to RTCPeerConnection, including
events, callbacks and methods.

Test: fast/mediastream/RTCPeerConnection-ice.html

* CMakeLists.txt:
* GNUmakefile.list.am:
* Modules/mediastream/RTCIceCandidateEvent.cpp: Added.
(WebCore):
(WebCore::RTCIceCandidateEvent::create):
(WebCore::RTCIceCandidateEvent::RTCIceCandidateEvent):
(WebCore::RTCIceCandidateEvent::~RTCIceCandidateEvent):
(WebCore::RTCIceCandidateEvent::candidate):
(WebCore::RTCIceCandidateEvent::interfaceName):
* Modules/mediastream/RTCIceCandidateEvent.h: Added.
(WebCore):
(RTCIceCandidateEvent):
* Modules/mediastream/RTCIceCandidateEvent.idl: Added.
* Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::RTCPeerConnection):
(WebCore::RTCPeerConnection::updateIce):
(WebCore):
(WebCore::RTCPeerConnection::addIceCandidate):
(WebCore::RTCPeerConnection::iceState):
(WebCore::RTCPeerConnection::close):
(WebCore::RTCPeerConnection::didGenerateIceCandidate):
(WebCore::RTCPeerConnection::didChangeIceState):
(WebCore::RTCPeerConnection::stop):
(WebCore::RTCPeerConnection::changeIceState):
* Modules/mediastream/RTCPeerConnection.h:
(RTCPeerConnection):
* Modules/mediastream/RTCPeerConnection.idl:
* WebCore.gypi:
* dom/EventNames.h:
(WebCore):
* dom/EventNames.in:
* platform/chromium/support/WebRTCICECandidateDescriptor.cpp: Copied from Source/WebCore/platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp.
(WebKit):
(WebKit::WebRTCICECandidateDescriptor::WebRTCICECandidateDescriptor):
(WebKit::WebRTCICECandidateDescriptor::assign):
(WebKit::WebRTCICECandidateDescriptor::reset):
(WebKit::WebRTCICECandidateDescriptor::initialize):
(WebKit::WebRTCICECandidateDescriptor::operator PassRefPtr<WebCore::RTCIceCandidateDescriptor>):
(WebKit::WebRTCICECandidateDescriptor::candidate):
(WebKit::WebRTCICECandidateDescriptor::sdpMid):
(WebKit::WebRTCICECandidateDescriptor::sdpMLineIndex):
* platform/mediastream/RTCIceCandidateDescriptor.h:
(WebCore::RTCIceCandidateDescriptor::candidate):
(WebCore::RTCIceCandidateDescriptor::sdpMid):
(WebCore::RTCIceCandidateDescriptor::sdpMLineIndex):
* platform/mediastream/RTCPeerConnectionHandler.h:
(WebCore):
(RTCPeerConnectionHandler):
* platform/mediastream/RTCPeerConnectionHandlerClient.h:
(WebCore):
(RTCPeerConnectionHandlerClient):
* platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:
(WebCore::RTCPeerConnectionHandlerChromium::updateIce):
(WebCore):
(WebCore::RTCPeerConnectionHandlerChromium::addIceCandidate):
(WebCore::RTCPeerConnectionHandlerChromium::didGenerateICECandidate):
(WebCore::RTCPeerConnectionHandlerChromium::didChangeICEState):
* platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:
(WebKit):
(RTCPeerConnectionHandlerChromium):

Source/WebKit/chromium:

* src/AssertMatchingEnums.cpp:

Tools:

* DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
(MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
(MockWebRTCPeerConnectionHandler::updateICE):
(MockWebRTCPeerConnectionHandler::addICECandidate):
* DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
(MockWebRTCPeerConnectionHandler):

LayoutTests:

* fast/mediastream/RTCPeerConnection-ice-expected.txt: Added.
* fast/mediastream/RTCPeerConnection-ice.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed build fix after r127421
allan.jensen@nokia.com [Mon, 3 Sep 2012 14:57:20 +0000 (14:57 +0000)]
Unreviewed build fix after r127421

* rendering/HitTestResult.cpp:
(WebCore::HitTestLocation::HitTestLocation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Add ewk_settings.
commit-queue@webkit.org [Mon, 3 Sep 2012 14:48:45 +0000 (14:48 +0000)]
[EFL][WK2] Add ewk_settings.
https://bugs.webkit.org/show_bug.cgi?id=91206

Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2012-09-03
Reviewed by Gyuyoung Kim.

Add the ewk_settings which wraps the WKPreferencesRef.
The ewk_settings will be created by the ewk_view and it will be
destroyed when the ewk_view is destroyed. I make each view to have
its own group to make one ewk_settings sets preferences only for
one ewk_view.
The application can get the ewk_settings from ewk_view using
ewk_view_settings_get() API.

* UIProcess/API/efl/EWebKit2.h:
* UIProcess/API/efl/ewk_settings.cpp: Added.
(ewk_settings_enable_scripts_set):
(ewk_settings_enable_scripts_get):
(ewk_settings_auto_load_images_set):
(ewk_settings_auto_load_images_get):
* UIProcess/API/efl/ewk_settings.h: Added.
* UIProcess/API/efl/ewk_settings_private.h: Added.
(_Ewk_Settings):
(_Ewk_Settings::_Ewk_Settings):
* UIProcess/API/efl/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_initialize):
(ewk_view_settings_get):
* UIProcess/API/efl/ewk_view.h:
* UIProcess/API/efl/tests/test_ewk2_settings.cpp: Added.
(TEST_F):
* UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove AllowShadowContent flag to HitTestRequest
allan.jensen@nokia.com [Mon, 3 Sep 2012 14:41:42 +0000 (14:41 +0000)]
Move AllowShadowContent flag to HitTestRequest
https://bugs.webkit.org/show_bug.cgi?id=95685

Reviewed by Antonio Gomes.

Moves the flag and updates the interface for HitTestResult::addNodeToRectBasedTestResult so that
it can read the flag from HitTestRequest instead of from HitTestResult.

No change in functionality. No new tests.

* dom/Document.cpp:
(WebCore::Document::nodesFromRect):
* page/EventHandler.cpp:
(WebCore::EventHandler::hitTestResultAtPoint):
* rendering/HitTestRequest.h:
* rendering/HitTestResult.cpp:
(WebCore::HitTestLocation::HitTestLocation):
(WebCore::HitTestResult::HitTestResult):
(WebCore::HitTestResult::operator=):
(WebCore::HitTestResult::addNodeToRectBasedTestResult):
* rendering/HitTestResult.h:
(HitTestLocation):
(HitTestResult):
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::nodeAtPoint):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::nodeAtPoint):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::nodeAtPoint):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::nodeAtPoint):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::nodeAtPoint):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::hitTestList):
* rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::nodeAtPoint):
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::nodeAtPoint):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::nodeAtPoint):
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::nodeAtPoint):
* rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::nodeAtPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWheel-events fails temporarily after reload
allan.jensen@nokia.com [Mon, 3 Sep 2012 14:15:03 +0000 (14:15 +0000)]
Wheel-events fails temporarily after reload
https://bugs.webkit.org/show_bug.cgi?id=94934

Reviewed by Kenneth Rohde Christiansen.

Set fixed visible content rect using visibleContentBounds instead of WebPage::size. Otherwise the
content rect will be incorrectly set to the entire document size, when resizesToContents is active.

Test: UIProcess/API/qt/tests/qmltests/WebView/tst_wheelEventHandling.qml

* UIProcess/API/qt/tests/qmltests/WebView/tst_wheelEventHandling.qml:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Use WebKitVersion.h to get version information
commit-queue@webkit.org [Mon, 3 Sep 2012 14:01:17 +0000 (14:01 +0000)]
[EFL] Use WebKitVersion.h to get version information
https://bugs.webkit.org/show_bug.cgi?id=95669

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-09-03
Reviewed by Gyuyoung Kim.

.:

WEBKIT_USER_AGENT_MAJOR_VERSION and WEBKIT_USER_AGENT_MINOR_VERSION
are defined as constant in the OptionsEfl.cmake. But we do not need
to define these here but can use the defined constant in WebKitVersion.h.

WebKitVersion.h is already generated with the version information
from the Source/WebCore/Configurations/Version.xcconfig.

* Source/cmake/OptionsEfl.cmake: Do not set WEBKIT_USER_AGENT_* variables.
* Source/cmakeconfig.h.cmake: Remove WEBKIT_USER_AGENT_* definitions
as no more port uses.

Source/WebKit/efl:

Use WEBKIT_MAJOR_VERSION and WEBKIT_MINOR_VERSION
in the WebKitVersion.h

Relocate the StorageTracker.h to keep the sorted order.

* ewk/ewk_settings.cpp:
(ewk_settings_default_user_agent_get):

Source/WebKit2:

Use WEBKIT_MAJOR_VERSION and WEBKIT_MINOR_VERSION
in the WebKitVersion.h

* UIProcess/efl/WebPageProxyEfl.cpp:
(WebKit::WebPageProxy::standardUserAgent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Unhide hidden characters
apavlov@chromium.org [Mon, 3 Sep 2012 13:22:42 +0000 (13:22 +0000)]
Web Inspector: Unhide hidden characters
https://bugs.webkit.org/show_bug.cgi?id=93888

Reviewed by Pavel Feldman.

Source/WebCore:

Certain invisible characters will be rendered as HTML entity references in the DOM tree to make them visible to the user.

* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._startEditingTextNode):

LayoutTests:

* inspector/elements/elements-panel-structure-expected.txt:
* inspector/elements/elements-panel-structure.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: rename JavaScriptContextManager to RuntimeModel for consistency.
pfeldman@chromium.org [Mon, 3 Sep 2012 13:20:02 +0000 (13:20 +0000)]
Web Inspector: rename JavaScriptContextManager to RuntimeModel for consistency.
https://bugs.webkit.org/show_bug.cgi?id=95677

Reviewed by Yury Semikhatsky.

- renamed the file and the usages
- renamed isolatedContextCreated to executionContextCreated for consistency.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/Inspector.json:
* inspector/PageRuntimeAgent.cpp:
(WebCore::PageRuntimeAgent::notifyContextCreated):
* inspector/compile-front-end.py:
* inspector/front-end/RuntimeModel.js: Renamed from Source/WebCore/inspector/front-end/JavaScriptContextManager.js.
(WebInspector.RuntimeModel):
(WebInspector.RuntimeModel.prototype._frameAdded):
(WebInspector.RuntimeModel.prototype._frameDetached):
(WebInspector.RuntimeModel.prototype._executionContextCreated):
(WebInspector.RuntimeDispatcher):
(WebInspector.RuntimeDispatcher.prototype.executionContextCreated):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Unreviewed gardening.
dominik.rottsches@intel.com [Mon, 3 Sep 2012 10:26:24 +0000 (10:26 +0000)]
[EFL] Unreviewed gardening.

Unskipping message-port-close.html after bug 85811 was resolved.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: use linkifyResourceAsNode, not linkifyLocation when linkifying resourc...
caseq@chromium.org [Mon, 3 Sep 2012 09:56:55 +0000 (09:56 +0000)]
Web Inspector: use linkifyResourceAsNode, not linkifyLocation when linkifying resources in Timeline
https://bugs.webkit.org/show_bug.cgi?id=95540

Reviewed by Pavel Feldman.

Linkify recource details using WebInspector.linkifyResourceAsNode(), so these bypass linkifier. Also
fix closure compiler warning.

* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.Record.prototype._generatePopupContentWithImagePreview):
(WebInspector.TimelinePresentationModel.Record.prototype._linkifyLocation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: fixed front-end compilation warnings.
pfeldman@chromium.org [Mon, 3 Sep 2012 09:45:46 +0000 (09:45 +0000)]
Web Inspector: fixed front-end compilation warnings.
Not reviewed.

* inspector/front-end/FilteredItemSelectionDialog.js:
* inspector/front-end/HeapSnapshotView.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: paint grid on top of box highlight.
pfeldman@chromium.org [Mon, 3 Sep 2012 09:42:20 +0000 (09:42 +0000)]
Web Inspector: paint grid on top of box highlight.
https://bugs.webkit.org/show_bug.cgi?id=95676

Reviewed by Alexander Pavlov.

Otherwise, ruler numbers are not visible when selecting body.

* inspector/InspectorOverlayPage.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: get rid of context execution id fallback.
pfeldman@chromium.org [Mon, 3 Sep 2012 08:54:43 +0000 (08:54 +0000)]
Web Inspector: get rid of context execution id fallback.
https://bugs.webkit.org/show_bug.cgi?id=95567

Reviewed by Yury Semikhatsky.

Source/WebCore:

We now assign execution context id upon changes in the UI.

* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.get statusBarItems):
(WebInspector.ConsoleView.prototype._contextAdded):
(WebInspector.ConsoleView.prototype._addContextList):
(WebInspector.ConsoleView.prototype._contextListRemoved):
(WebInspector.ConsoleView.prototype._updateExecutionContextSelector):
(WebInspector.ConsoleView.prototype._appendExecutionContextOption):
(WebInspector.ConsoleView.prototype._executionContextChanged):
(WebInspector.ConsoleView.prototype._contextListUpdated):
(WebInspector.ConsoleView.prototype._addedExecutionContext):
(WebInspector.ConsoleView.prototype.evalInInspectedWindow.evalCallback):
(WebInspector.ConsoleView.prototype.evalInInspectedWindow):
(WebInspector.ConsoleView.prototype._enterKeyPressed):
* inspector/front-end/JavaScriptContextManager.js:
(WebInspector.JavaScriptContextManager):
(WebInspector.JavaScriptContextManager.prototype.contextLists):
(WebInspector.JavaScriptContextManager.prototype.contextByFrameAndSecurityOrigin):
(WebInspector.JavaScriptContextManager.prototype._frameAdded):
(WebInspector.JavaScriptContextManager.prototype._frameNavigated):
(WebInspector.JavaScriptContextManager.prototype._frameDetached):
(WebInspector.JavaScriptContextManager.prototype.isolatedContextCreated):
(WebInspector.FrameExecutionContextList):
(WebInspector.FrameExecutionContextList.prototype._frameNavigated):
(WebInspector.FrameExecutionContextList.prototype._addExecutionContext):
(WebInspector.FrameExecutionContextList.prototype.executionContexts):
(WebInspector.FrameExecutionContextList.prototype.contextBySecurityOrigin):

LayoutTests:

* http/tests/inspector/console-cd-completions.html:
* http/tests/inspector/console-cd.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Fix resizing issues related to URL bar in Minibrowser / EWebLauncher
commit-queue@webkit.org [Mon, 3 Sep 2012 08:50:35 +0000 (08:50 +0000)]
[EFL] Fix resizing issues related to URL bar in Minibrowser / EWebLauncher
https://bugs.webkit.org/show_bug.cgi?id=95670

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-03
Reviewed by Kenneth Rohde Christiansen.

Fix layout issues related to the URL bar in Minibrowser
and EWebLauncher when the window is resized.

The URL bar was not resized accordingly and the Web
page was moved behing the URL bar, hiding part of it.

* EWebLauncher/main.c:
(on_ecore_evas_resize):
(closeWindow):
* EWebLauncher/url_bar.c:
(url_bar_width_set):
(url_bar_add):
* EWebLauncher/url_bar.h:
* MiniBrowser/efl/main.c:
(on_ecore_evas_resize):
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed rebaseline for bug 94287.
yosin@chromium.org [Mon, 3 Sep 2012 08:39:57 +0000 (08:39 +0000)]
Unreviewed rebaseline for bug 94287.
Update Chromium-Mac and Chromium-Win images for multiple field time input UI.

* platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png: Added.
* platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Added.
* platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Added.
* platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png: Added.
* platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.txt: Added.
* platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png: Added.
* platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt: Added.
* platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Added.
* platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Added.
* platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png: Added.
* platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.txt: Added.
* platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png: Added.
* platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Mark http/tests/incremental/slow-utf8-text.pl as flaky
commit-queue@webkit.org [Mon, 3 Sep 2012 08:35:09 +0000 (08:35 +0000)]
[EFL] Mark http/tests/incremental/slow-utf8-text.pl as flaky
https://bugs.webkit.org/show_bug.cgi?id=95673

Unreviewed EFL gardening.

Mark http/tests/incremental/slow-utf8-text.pl as flaky
as it does not always time out.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-03

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Build fix for ENABLE(CLASSIC_INTERPRETER) after r127393.
paroga@webkit.org [Mon, 3 Sep 2012 08:34:22 +0000 (08:34 +0000)]
Unreviewed. Build fix for ENABLE(CLASSIC_INTERPRETER) after r127393.

* interpreter/Interpreter.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r127406.
yosin@chromium.org [Mon, 3 Sep 2012 08:30:15 +0000 (08:30 +0000)]
Unreviewed, rolling out r127406.
http://trac.webkit.org/changeset/127406
https://bugs.webkit.org/show_bug.cgi?id=95674

Expectation images are missing (Requested by yosin1 on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-03

* platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Removed.
* platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Removed.
* platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Removed.
* platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Removed.
* platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Removed.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed rebaseline for bug 94287.
yosin@chromium.org [Mon, 3 Sep 2012 08:22:40 +0000 (08:22 +0000)]
Unreviewed rebaseline for bug 94287.
Update Chromium-Mac and Chromium-Win images for multiple field time input UI.

* platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Added.
* platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Added.
* platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Added.
* platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Added.
* platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Skip EWK2UnitTestBase.ewk_cookie_manager_permanent_storage API test
commit-queue@webkit.org [Mon, 3 Sep 2012 08:18:09 +0000 (08:18 +0000)]
[EFL][WK2] Skip EWK2UnitTestBase.ewk_cookie_manager_permanent_storage API test
https://bugs.webkit.org/show_bug.cgi?id=95671

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-03
Reviewed by Kenneth Rohde Christiansen.

Skip EWK2UnitTestBase.ewk_cookie_manager_permanent_storage
API test since it is flaky on the bots.

* UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK][EFL] 'dictIter' iterator is not initialized for an inner loop
g.czajkowski@samsung.com [Mon, 3 Sep 2012 08:16:16 +0000 (08:16 +0000)]
[GTK][EFL] 'dictIter' iterator is not initialized for an inner loop
https://bugs.webkit.org/show_bug.cgi?id=95436

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

The 'checkSpellingOfString' method assumes that the given string is concatenation of words.
To properly handle spellchecking of each word we need to iterate over the all available
dictionaries ('dictIter').

To allow spellchecking for multiple words, 'dictIter' should be initialized at the beginning
of vector while spellchecking of the word. This ensures performing of spelling for word based on
at least one dictionary.

* platform/text/enchant/TextCheckerEnchant.cpp:
(TextCheckerEnchant::checkSpellingOfString): Moved initialization of 'dictIter' to an inner loop.

LayoutTests:

'checkSpellingOfString' from the TextCheckerEnchant class can not mark multiplie words that are misspelled.
It's possible to mark misspeled string only by defining its location and length.

* platform/gtk/TestExpectations: Added spelling-backspace-between-lines.html to TestExpectations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Mark several inspector test as flaky
commit-queue@webkit.org [Mon, 3 Sep 2012 08:14:40 +0000 (08:14 +0000)]
[EFL][WK2] Mark several inspector test as flaky
https://bugs.webkit.org/show_bug.cgi?id=95667

Unreviewed EFL gardening.

Mark several inspector test cases as flaky on
WebKit2 EFL.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-03

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Update TestExpectations for 2 fast/block tests
commit-queue@webkit.org [Mon, 3 Sep 2012 07:35:19 +0000 (07:35 +0000)]
[EFL] Update TestExpectations for 2 fast/block tests
https://bugs.webkit.org/show_bug.cgi?id=95666

Unreviewed EFL gardening.

Update TestExpectations for 2 fast/block tests to
indicate that we expect TEXT only diff on the bot
since we don't run pixel tests.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-03

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWK2: Build failure on SnowLeopard after r127384
bashi@chromium.org [Mon, 3 Sep 2012 06:57:40 +0000 (06:57 +0000)]
WK2: Build failure on SnowLeopard after r127384
https://bugs.webkit.org/show_bug.cgi?id=95665

Reviewed by Dan Bernstein.

Add SandboxExtension::consumePermanently(const Handle&) for !ENABLE(WEB_PROCESS_SANDBOX) to fix link error.

* Shared/SandboxExtension.h:
(WebKit::SandboxExtension::consumePermanently):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Forms] Empty visible value of AM/PM field of multiple fields time input UI should...
yosin@chromium.org [Mon, 3 Sep 2012 06:03:32 +0000 (06:03 +0000)]
[Forms] Empty visible value of AM/PM field of multiple fields time input UI should display variable number of "-" based on maximum number of labels
https://bugs.webkit.org/show_bug.cgi?id=95660

Reviewed by Kent Tamura.

This patch changes visible empty value of AM/PM field in multiple
fields time input UI to "-", "--", "---", and so on based on maximum
length of AM/PM labels. In current implementation, it is always "--"
regardless locale, although on Arabic, AM/PM are represented in one
character.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

No new tests. Once multiple field time input UI uses "lang" HTML
attribute to take time format, we can write a test for this patch.

* html/shadow/DateTimeSymbolicFieldElement.cpp:
(makeVisibleEmptyValue): Build visible empty value from maximum length
of labels.
(WebCore::DateTimeSymbolicFieldElement::visibleEmptyValue): Changed to
use m_visibleEmptyValue.
* html/shadow/DateTimeSymbolicFieldElement.h:
(WebCore::DateTimeSymbolicFieldElement): Added new member variable
m_visibleEmptyValue to hold visible empty value.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed test expectation update after r127398
bashi@chromium.org [Mon, 3 Sep 2012 05:51:42 +0000 (05:51 +0000)]
[Chromium] Unreviewed test expectation update after r127398

* platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png:
* platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
* platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png:
* platform/chromium-win-xp/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Forms] AM/PM field of multiple fields time input UI should be fixed width
yosin@chromium.org [Mon, 3 Sep 2012 04:03:19 +0000 (04:03 +0000)]
[Forms] AM/PM field of multiple fields time input UI should be fixed width
https://bugs.webkit.org/show_bug.cgi?id=95542

Reviewed by Kent Tamura.

This patch changes width of AM/PM field of multiple field time input
UI fixed as maximum width of labels or "--".

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

No new tests. Once multiple field time input UI uses "lang" HTML
attribute to take time format, we can write a test for this patch.

* css/html.css:
(input::-webkit-datetime-edit-ampm-field): Added "display" property to "inline-block" for setting width.
Added "text-align" property to "center".
* html/shadow/DateTimeSymbolicFieldElement.cpp:
(WebCore::DateTimeSymbolicFieldElement::DateTimeSymbolicFieldElement): Changed to call setHasCustomCallback().
(WebCore::DateTimeSymbolicFieldElement::customStyleForRenderer): Added for setting field with from maximum width of labels.
* html/shadow/DateTimeSymbolicFieldElement.h:
(WebCore::DateTimeSymbolicFieldElement::visibleEmptyValue): Added for using visible empty value in customStyleForRenderer() and visibleValue().
(WebCore::DateTimeSymbolicFieldElement::visibleValue): Changed to call visibleEmptyValue() instead of using literal "--".
(DateTimeSymbolicFieldElement): Added a declaration of customStyleForRenderer().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Keep activePopupMenu to call valueChangedForPopupMenu() outside showPopupM...
ryuan.choi@samsung.com [Mon, 3 Sep 2012 02:04:14 +0000 (02:04 +0000)]
[EFL][WK2] Keep activePopupMenu to call valueChangedForPopupMenu() outside showPopupMenu()
https://bugs.webkit.org/show_bug.cgi?id=95355

Reviewed by Gyuyoung Kim.

Efl does not have a proper way to support nested loop so that applications
may change value after showPopupMenu() is finished.

* UIProcess/API/efl/tests/test_ewk2_view.cpp: Improved test case to cover this bug.
(selectItemAfterDelayed):
(showPopupMenu):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showPopupMenu):
Guard with !PLATFORM(EFL) to keep the activePopupMenu valid to call valueChangedForPopupMenu
outside showPopupMenu().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Tests] fast/forms/time-multiple-fields/time-multiple-fields-appearance-*.html should...
yosin@chromium.org [Mon, 3 Sep 2012 01:05:03 +0000 (01:05 +0000)]
[Tests] fast/forms/time-multiple-fields/time-multiple-fields-appearance-*.html should dump text instead of render tree
https://bugs.webkit.org/show_bug.cgi?id=95545

Reviewed by Kent Tamura.

This patch changes test expectations to text output and pixel images
instead of structure of render tree and pixel images for multiple
fields time input UI. This patch helps us to avoid rebaseline when
we change DOM structure but keep appearance.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

* fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.txt: Added.
* fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic.html: Changed to call testRunner.dumpAsText().
* fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Added.
* fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly.html: Changed to call testRunner.dumpAsText().
* fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.txt: Added.
* fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes.html: Changed to call testRunner.dumpAsText().
* fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.txt: Added.
* fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements.html: Changed to call testRunner.dumpAsText().
* fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt: Added.
* fast/forms/time-multiple-fields/time-multiple-fields-appearance-style.html: Changed to call testRunner.dumpAsText().
* platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.txt: Removed.
* platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Removed.
* platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.txt: Removed.
* platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
* platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt: Removed.
* platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.txt: Removed.
* platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
* platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.txt: Removed.
* platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed test expectation update after r127362
bashi@chromium.org [Mon, 3 Sep 2012 00:24:56 +0000 (00:24 +0000)]
Unreviewed test expectation update after r127362

* platform/chromium/TestExpectations: Moved
fast/notifications/notifications-event-listener-crash.html to
http/tests/notifications.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFixed failures seen on Linux bots.
ggaren@apple.com [Sun, 2 Sep 2012 23:45:19 +0000 (23:45 +0000)]
Fixed failures seen on Linux bots.

* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_push_with_scope):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_push_with_scope):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* jit/JITStubs.h: push_*_scope doesn't have a destination operand anymore.
Accordingly, update these places in the baseline JIT, which I missed in my last patch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRefactored scope chain opcodes to support optimization for named function expressions
ggaren@apple.com [Sun, 2 Sep 2012 21:27:23 +0000 (21:27 +0000)]
Refactored scope chain opcodes to support optimization for named function expressions
https://bugs.webkit.org/show_bug.cgi?id=95658

Reviewed by Sam Weinig.

Renamed
    push_scope => push_with_scope
    push_new_scope => push_name_scope
to clarify the difference between them.

Changed push_with_scope and push_name_scope not to save the new scope in
a temporary register, since doing so made optimization harder.

(The old behavior was a hold-over from when the scope chain wasn't
a GC object, and wouldn't be marked otherwise. Now, the scope chain is
marked because it is a GC object pointed to by the call frame.)

Changed push_name_scope to accept an operand specifying the attributes
for the named property, instead of assuming DontDelete, because a named
function expression needs ReadOnly|DontDelete.

* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::highestUsedRegister): Removed this function,
which used to be related to preserving saved scope object temporaries,
because it had no callers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImprove the way we use convertedSpaceString() in convertHTMLTextToInterchangeFormat()
benjamin@webkit.org [Sun, 2 Sep 2012 20:26:26 +0000 (20:26 +0000)]
Improve the way we use convertedSpaceString() in convertHTMLTextToInterchangeFormat()
https://bugs.webkit.org/show_bug.cgi?id=95301

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-02
Reviewed by Darin Adler.

The static string convertedSpaceString() had a couple of annoying side effects:
-The string was 16bits due to noBreakSpace, which forced any input to be converted to 16bits.
-The string was kept in the heap for no particular reason.

This patch redefines convertedSpaceString as a constant literal so that we can use it efficiently.

The patch also make the binary a tiny bit smaller (700 bytes).

* editing/HTMLInterchange.cpp:
(WebCore::convertHTMLTextToInterchangeFormat):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild is broken when SVG is disabled.
commit-queue@webkit.org [Sun, 2 Sep 2012 18:57:20 +0000 (18:57 +0000)]
Build is broken when SVG is disabled.
https://bugs.webkit.org/show_bug.cgi?id=95653

Patch by Mike West <mkwst@chromium.org> on 2012-09-02
Reviewed by Dirk Schulze.

Adding CSSPropertyWebkitClipPath to the massive switch statement in StyleResolver.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Add missing semicolon at the end of some lines.
commit-queue@webkit.org [Sun, 2 Sep 2012 17:43:52 +0000 (17:43 +0000)]
[EFL] Add missing semicolon at the end of some lines.
https://bugs.webkit.org/show_bug.cgi?id=95640

Patch by Byungwoo Lee <bw80.lee@gmail.com> on 2012-09-02
Reviewed by Gyuyoung Kim.

EWK_VIEW_PRIV_GET_OR_RETURN macro and other related macro can be used
without semicolon, because it ends with a semicolon or complete block.
This can make a human mistake about missing semicolon.

Fixed the macros to require semicolon, and added missing semicolons.

* UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_smart_focus_in):
(_ewk_view_smart_focus_out):
(_ewk_view_smart_mouse_wheel):
(_ewk_view_smart_mouse_down):
(_ewk_view_smart_mouse_up):
(_ewk_view_smart_mouse_move):
(_ewk_view_smart_key_down):
(_ewk_view_smart_key_up):
(_ewk_view_initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofast/html/marquee-alternate.html is flaky
commit-queue@webkit.org [Sun, 2 Sep 2012 17:09:26 +0000 (17:09 +0000)]
fast/html/marquee-alternate.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=94130

Patch by Jessie Berlin <jberlin@apple.com> on 2012-09-02
Reviewed by Simon Fraser.

Disable the test because it is flakey on so many platforms. Remove it from the Skipped and
TestExpectations files so that run-webkit-tests doesn't go looking for it.

* fast/html/marquee-alternate.html-disabled: Renamed from LayoutTests/fast/html/marquee-alternate.html.
* platform/chromium/TestExpectations:
* platform/efl/Skipped:
* platform/qt-arm/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRepaints should not be deferred after initial page load is complete
antti@apple.com [Sun, 2 Sep 2012 10:34:26 +0000 (10:34 +0000)]
Repaints should not be deferred after initial page load is complete
https://bugs.webkit.org/show_bug.cgi?id=95480

Reviewed by Simon Fraser

Any dynamically triggered resource loading currently sends us back to deferred paint mode, making animation choppy.
This is not the intention of this code.

This patch adds an additional condition that prevents page from re-entering deferred repaint mode after the initial
load has completed. It also cleans up the code slightly.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkCompleted):

    Add additional call to checkStopDelayingDeferredRepaints() after a frame load completes as the
    new condition in shouldUseLoadTimeDeferredRepaintDelay() looks for this change too.

* page/FrameView.cpp:
(WebCore):

    Reduced the normal delay from 25ms to 16ms to not interfere with full framerate animation.

(WebCore::FrameView::syncCompositingStateForThisFrame):
(WebCore::FrameView::checkFlushDeferredRepaintsAfterLoadComplete):

    Ensure the repaint delay is reset after load completes even if we don't currently need a repaint.

(WebCore::FrameView::flushDeferredRepaints):

    We had to identical functions, flushDeferredRepaints() and stopDelayingDeferredRepaints(). Remove
    the latter.

(WebCore::FrameView::shouldUseLoadTimeDeferredRepaintDelay):

    Factor the test for using load time repaint timings to a functions. The test for
    initial page load having completed is new.

(WebCore::FrameView::updateDeferredRepaintDelay):
(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive):
(WebCore::FrameView::setRepaintThrottlingDeferredRepaintDelay):
* page/FrameView.h:
(FrameView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDon't create access error strings if there is no access error
fpizlo@apple.com [Sun, 2 Sep 2012 08:34:17 +0000 (08:34 +0000)]
Don't create access error strings if there is no access error
https://bugs.webkit.org/show_bug.cgi?id=95652

Reviewed by Adam Barth.

This undoes the 50% performance regression in pdfjs caused by
http://trac.webkit.org/changeset/126165

No new tests because behavior is unchanged.

* bindings/js/JSDOMBinding.cpp:
(WebCore::shouldAllowAccessToFrame):
(WebCore::shouldAllowAccessToDOMWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove unused member variable from WebProcess.
weinig@apple.com [Sun, 2 Sep 2012 05:51:56 +0000 (05:51 +0000)]
Remove unused member variable from WebProcess.

Rubber-stamped by Dan Bernstein.

* WebProcess/WebProcess.h:
(WebProcess):
Remove m_applicationCachePathExtension.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Refactoring the DumpRenderTreeSupportEfl
commit-queue@webkit.org [Sun, 2 Sep 2012 04:31:52 +0000 (04:31 +0000)]
[EFL] Refactoring the DumpRenderTreeSupportEfl
https://bugs.webkit.org/show_bug.cgi?id=95544

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-09-01
Reviewed by Gyuyoung Kim.

There are lots of repeated codes for getting the WebCore::Frame
and WebCore::Page. To reduce these duplications, simple macros
are added.

No new tests, just refactoring.

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::activeAnimationsCount):
(DumpRenderTreeSupportEfl::callShouldCloseOnWebView):
(DumpRenderTreeSupportEfl::clearFrameName):
(DumpRenderTreeSupportEfl::clearOpener):
(DumpRenderTreeSupportEfl::elementDoesAutoCompleteForElementWithId):
(DumpRenderTreeSupportEfl::frameChildren):
(DumpRenderTreeSupportEfl::frameParent):
(DumpRenderTreeSupportEfl::layoutFrame):
(DumpRenderTreeSupportEfl::numberOfPages):
(DumpRenderTreeSupportEfl::pageSizeAndMarginsInPixels):
(DumpRenderTreeSupportEfl::pageProperty):
(DumpRenderTreeSupportEfl::pauseAnimation):
(DumpRenderTreeSupportEfl::pauseTransition):
(DumpRenderTreeSupportEfl::pendingUnloadEventCount):
(DumpRenderTreeSupportEfl::renderTreeDump):
(DumpRenderTreeSupportEfl::responseMimeType):
(DumpRenderTreeSupportEfl::selectionRectangle):
(DumpRenderTreeSupportEfl::suitableDRTFrameName):
(DumpRenderTreeSupportEfl::setDefersLoading):
(DumpRenderTreeSupportEfl::setLoadsSiteIconsIgnoringImageLoadingSetting):
(DumpRenderTreeSupportEfl::addUserScript):
(DumpRenderTreeSupportEfl::clearUserScripts):
(DumpRenderTreeSupportEfl::addUserStyleSheet):
(DumpRenderTreeSupportEfl::clearUserStyleSheets):
(DumpRenderTreeSupportEfl::executeCoreCommandByName):
(DumpRenderTreeSupportEfl::findString):
(DumpRenderTreeSupportEfl::setCSSGridLayoutEnabled):
(DumpRenderTreeSupportEfl::isCommandEnabled):
(DumpRenderTreeSupportEfl::setSmartInsertDeleteEnabled):
(DumpRenderTreeSupportEfl::setSelectTrailingWhitespaceEnabled):
(DumpRenderTreeSupportEfl::evaluateInWebInspector):
(DumpRenderTreeSupportEfl::evaluateScriptInIsolatedWorld):
(DumpRenderTreeSupportEfl::globalContextRefForFrame):
(DumpRenderTreeSupportEfl::setInteractiveFormValidationEnabled):
(DumpRenderTreeSupportEfl::setValidationMessageTimerMagnification):
(DumpRenderTreeSupportEfl::setAuthorAndUserStylesEnabled):
(DumpRenderTreeSupportEfl::setComposition):
(DumpRenderTreeSupportEfl::hasComposition):
(DumpRenderTreeSupportEfl::compositionRange):
(DumpRenderTreeSupportEfl::confirmComposition):
(DumpRenderTreeSupportEfl::firstRectForCharacterRange):
(DumpRenderTreeSupportEfl::selectedRange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse dynamic sandbox extension rather than sandbox parameters for paths provided by...
weinig@apple.com [Sun, 2 Sep 2012 03:08:00 +0000 (03:08 +0000)]
Use dynamic sandbox extension rather than sandbox parameters for paths provided by the UIProcess
https://bugs.webkit.org/show_bug.cgi?id=95651

Reviewed by Dan Bernstein.

This is the first step to not relying on the initialization message to initialize
the sandbox.

* Shared/SandboxExtension.h:
(SandboxExtension):
* Shared/mac/SandboxExtensionMac.mm:
(WebKit::SandboxExtension::consumePermanently):
Add static version of SandboxExtension::consumePermanently which takes a
SandboxExtension::Handle. There is no reason to create a SandboxExtension
just to consume it forever.

* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
(WebProcessCreationParameters):
Add SandboxExtension::Handles for paths we need access to, and remove
webInspectorBaseDirectory, which is unused.

* UIProcess/WebContext.cpp:
(WebKit::WebContext::createNewWebProcess):
* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformInitializeWebProcess):
Create SandboxExtension::Handles for paths we need access to, and move
getting the presenterApplicationPid to platformInitializeWebProcess, since
it is Mac only.

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
Move setting the presenterApplicationPid to platformInitializeWebProcess.

* WebProcess/mac/WebProcessMac.mm:
(WebKit::initializeSandbox):
(WebKit::WebProcess::platformInitializeWebProcess):
Replace the use of sandbox parameters for opening access for necessary paths
with permanent consumption of sandbox extensions.

* WebProcess/com.apple.WebProcess.sb.in:
Remove sandbox rules that are now handled via extensions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse -webkit-clip-path shapes to clip SVG elements
krit@webkit.org [Sun, 2 Sep 2012 00:15:33 +0000 (00:15 +0000)]
Use -webkit-clip-path shapes to clip SVG elements
https://bugs.webkit.org/show_bug.cgi?id=95620

Reviewed by Rob Buis.

Source/WebCore:

This patch adds a path segment for a BasicShape to a given Path object. This
path and it's wind rule are used to clip the context of the SVG element.

Tests: svg/clip-path/clip-path-shape-circle-1-expected.svg
       svg/clip-path/clip-path-shape-circle-1.svg
       svg/clip-path/clip-path-shape-circle-2-expected.svg
       svg/clip-path/clip-path-shape-circle-2.svg
       svg/clip-path/clip-path-shape-ellipse-1-expected.svg
       svg/clip-path/clip-path-shape-ellipse-1.svg
       svg/clip-path/clip-path-shape-ellipse-2-expected.svg
       svg/clip-path/clip-path-shape-ellipse-2.svg
       svg/clip-path/clip-path-shape-polygon-1-expected.svg
       svg/clip-path/clip-path-shape-polygon-1.svg
       svg/clip-path/clip-path-shape-polygon-2-expected.svg
       svg/clip-path/clip-path-shape-polygon-2.svg
       svg/clip-path/clip-path-shape-polygon-3-expected.svg
       svg/clip-path/clip-path-shape-polygon-3.svg
       svg/clip-path/clip-path-shape-rounded-rect-1-expected.svg
       svg/clip-path/clip-path-shape-rounded-rect-1.svg
       svg/clip-path/clip-path-shape-rounded-rect-2-expected.svg
       svg/clip-path/clip-path-shape-rounded-rect-2.svg

* rendering/style/BasicShapes.cpp: Added helper functions that apply path segments to a given path.
(WebCore::BasicShapeRectangle::path):
(WebCore::BasicShapeCircle::path):
(WebCore::BasicShapeEllipse::path):
(WebCore::BasicShapePolygon::path):
* rendering/style/BasicShapes.h: Make BasicShape virtualized again, since new virtual functions were added.
(WebCore::BasicShape::~BasicShape):
(BasicShape):
(WebCore::BasicShape::windRule): Will return the wind rule of the shape - nonzero by default.
(WebCore::BasicShape::BasicShape):
(BasicShapeRectangle):
(WebCore::BasicShapeRectangle::type): Removed member variable and return type per inheriting class directly.
(WebCore::BasicShapeRectangle::BasicShapeRectangle):
(BasicShapeCircle):
(WebCore::BasicShapeCircle::type): Ditto.
(WebCore::BasicShapeCircle::BasicShapeCircle):
(BasicShapeEllipse):
(WebCore::BasicShapeEllipse::type): Ditto.
(WebCore::BasicShapeEllipse::BasicShapeEllipse):
(BasicShapePolygon):
(WebCore::BasicShapePolygon::windRule):
(WebCore::BasicShapePolygon::type): Ditto.
(WebCore::BasicShapePolygon::BasicShapePolygon):
* rendering/svg/SVGRenderingContext.cpp: If -webkit-clip-path was defined, clip the context to the shape.
Right now -webkit-clip-path overrides clip-path, so that people don't use both at the same time. Current
clip-path property will be replaced, once -webkit-clip-path gets unprefixed.
(WebCore::SVGRenderingContext::prepareToRenderSVGContent):

LayoutTests:

New tests to check behavior of -webkit-clip-path on SVG elements.

* svg/clip-path/clip-path-shape-circle-1-expected.svg: Added.
* svg/clip-path/clip-path-shape-circle-1.svg: Added.
* svg/clip-path/clip-path-shape-circle-2-expected.svg: Added.
* svg/clip-path/clip-path-shape-circle-2.svg: Added.
* svg/clip-path/clip-path-shape-ellipse-1-expected.svg: Added.
* svg/clip-path/clip-path-shape-ellipse-1.svg: Added.
* svg/clip-path/clip-path-shape-ellipse-2-expected.svg: Added.
* svg/clip-path/clip-path-shape-ellipse-2.svg: Added.
* svg/clip-path/clip-path-shape-polygon-1-expected.svg: Added.
* svg/clip-path/clip-path-shape-polygon-1.svg: Added.
* svg/clip-path/clip-path-shape-polygon-2-expected.svg: Added.
* svg/clip-path/clip-path-shape-polygon-2.svg: Added.
* svg/clip-path/clip-path-shape-polygon-3-expected.svg: Added.
* svg/clip-path/clip-path-shape-polygon-3.svg: Added.
* svg/clip-path/clip-path-shape-rounded-rect-1-expected.svg: Added.
* svg/clip-path/clip-path-shape-rounded-rect-1.svg: Added.
* svg/clip-path/clip-path-shape-rounded-rect-2-expected.svg: Added.
* svg/clip-path/clip-path-shape-rounded-rect-2.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium-Android] Remove hard-coded skipped directories in chromium_android.py
wangxianzhu@chromium.org [Sat, 1 Sep 2012 20:29:32 +0000 (20:29 +0000)]
[Chromium-Android] Remove hard-coded skipped directories in chromium_android.py
https://bugs.webkit.org/show_bug.cgi?id=95605

Reviewed by Dirk Pranke.

Tools:

Now skipping rules are put in LayoutTests/platform/chromium-android/TestExpectations.

* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.check_sys_deps):
(ChromiumAndroidPort.expectations_files):
(ChromiumAndroidPort.clean_up_test_run):

LayoutTests:

Moved the skipping rules for ANDROID into platform/chromium-android/TestExpectations.

* platform/chromium/TestExpectations:
* platform/chromium/test_expectations_android.txt: Removed.
* platform/chromium-android/TestExpectations: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRegression(r126763): Heap-use-after-free in WebCore::nextBreakablePosition
commit-queue@webkit.org [Sat, 1 Sep 2012 19:46:16 +0000 (19:46 +0000)]
Regression(r126763): Heap-use-after-free in WebCore::nextBreakablePosition
https://bugs.webkit.org/show_bug.cgi?id=95229

Patch by Ned Holbrook <nholbrook@apple.com> on 2012-09-01
Reviewed by Dan Bernstein.

Source/WebCore:

TextLayout and LazyLineBreakIterator cache a RenderText's string during line breaking but RenderCounter
and RenderQuote can replace that string during preferred width calculation. This patch adds a non-virtual member
function to RenderText named updateTextIfNeeded() that triggers immediate string replacement by calling
the new virtual updateText() if necessary, which in turn calls computePreferredLogicalWidths(). In this way
RenderBlock::LineBreaker::nextLineBreak() can ensure a RenderText's string is current before caching it.

Test: fast/css/content/content-quotes-crash.html

* rendering/RenderBlockLineLayout.cpp:
(WebCore::dirtyLineBoxesForRenderer): Drive-by: replace existing code with the equivalent updateTextIfNeeded().
(WebCore::RenderBlock::LineBreaker::nextLineBreak): Use updateTextIfNeeded() prior to caching RenderText string.
* rendering/RenderCounter.cpp:
(WebCore::RenderCounter::updateText): Call computePreferredLogicalWidths().
(WebCore):
* rendering/RenderCounter.h:
(RenderCounter):
* rendering/RenderQuote.cpp:
(WebCore::RenderQuote::updateText): Call computePreferredLogicalWidths().
(WebCore):
* rendering/RenderQuote.h:
(RenderQuote):
* rendering/RenderText.h:
(WebCore::RenderText::updateTextIfNeeded): Only call virtual updateText() if necessary.
(RenderText):
(WebCore::RenderText::updateText): Add no-op default implementation for new virtual member function.

LayoutTests:

Ensure line breaking doesn't crash due to text of RenderText being changed.

* fast/css/content/content-quotes-crash-expected.txt: Added.
* fast/css/content/content-quotes-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofast/events/message-port-clone.html hits ASSERT in Debug (usually in later tests)
commit-queue@webkit.org [Sat, 1 Sep 2012 19:42:46 +0000 (19:42 +0000)]
fast/events/message-port-clone.html hits ASSERT in Debug (usually in later tests)
https://bugs.webkit.org/show_bug.cgi?id=85811

Patch by Li Yin <li.yin@intel.com> on 2012-09-01
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

When MessagePort invoked close function, the close status is needed to set,
regardless of whether the port is cloned or not.

Tests: fast/events/message-port-clone.html
       fast/events/message-port-close.html

* dom/MessagePort.cpp:
(WebCore::MessagePort::close): Must set m_closed to be true.

LayoutTests:

* platform/gtk/TestExpectations:
* platform/mac/Skipped:
* platform/qt-4.8/TestExpectations:
* platform/qt-mac/TestExpectations:
* platform/qt/TestExpectations:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium-Android] Upstream layout test expectations (Part 4)
wangxianzhu@chromium.org [Sat, 1 Sep 2012 19:26:50 +0000 (19:26 +0000)]
[Chromium-Android] Upstream layout test expectations (Part 4)
https://bugs.webkit.org/show_bug.cgi?id=95594

Reviewed by Adam Barth.

Remove a font boosting test which has been removed in downstream.
Update canvas test expectations.
Rebaselined one canvas test (only one space diff).

* platform/chromium-android/fast/canvas/fallback-content-expected.txt: Added.
* platform/chromium-android/fast/font-boosting/various-tricky-cases-expected.txt: Removed.
* platform/chromium-android/fast/font-boosting/various-tricky-cases.html: Removed.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium buildfix when use_libcc_for_compositor=1
jamesr@google.com [Sat, 1 Sep 2012 19:06:10 +0000 (19:06 +0000)]
Unreviewed chromium buildfix when use_libcc_for_compositor=1

This gyp target was renamed downstream.

* WebKit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Gtk] accessibility/replaced-objects-in-anonymous-blocks layout test failure
commit-queue@webkit.org [Sat, 1 Sep 2012 18:16:19 +0000 (18:16 +0000)]
[Gtk] accessibility/replaced-objects-in-anonymous-blocks layout test failure
https://bugs.webkit.org/show_bug.cgi?id=95643

Unreviewed GTK gardening, rebaselining an accessibility test.

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-09-01

* platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt: Corrected.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-09-01 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Sat, 1 Sep 2012 17:49:29 +0000 (17:49 +0000)]
2012-09-01  Geoffrey Garen  <ggaren@apple.com>

        Rolled back out a piece of <http://trac.webkit.org/changeset/127293>
        because it broke inspector tests on Windows.

            Shrink activation objects by half
            https://bugs.webkit.org/show_bug.cgi?id=95591

            Reviewed by Sam Weinig.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoShare inline style between cloned Nodes (copy on write.)
kling@webkit.org [Sat, 1 Sep 2012 17:47:39 +0000 (17:47 +0000)]
Share inline style between cloned Nodes (copy on write.)
<http://webkit.org/b/95451>

Reviewed by Antti Koivisto.

When cloning a Node, use an immutable StylePropertySet for the new Node's inline style.
If the old Node already had an immutable inline style, we now reuse that, avoiding a copy.
Copying is deferred until mutation (either via CSSOM or setting of the style attribute.)

* dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::cloneDataFrom):
* css/StylePropertySet.h:
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::immutableCopyIfNeeded):

    Added. Simply returns 'this' if the object is already immutable, otherwise creates a new one.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLLInt C loop backend.
commit-queue@webkit.org [Sat, 1 Sep 2012 17:36:51 +0000 (17:36 +0000)]
LLInt C loop backend.
https://bugs.webkit.org/show_bug.cgi?id=91052.

Patch by Mark Lam <mark.lam@apple.com> on 2012-09-01
Reviewed by Filip Pizlo.

Source/JavaScriptCore:

* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
(JSC::CodeBlock::bytecodeOffset):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC):
* interpreter/Interpreter.h:
* jit/JITStubs.h:
(JITStackFrame):
(JSC):
* llint/LLIntCLoop.cpp: Added.
(JSC):
(LLInt):
(JSC::LLInt::CLoop::initialize):
(JSC::LLInt::CLoop::catchRoutineFor):
(JSC::LLInt::CLoop::hostCodeEntryFor):
(JSC::LLInt::CLoop::jsCodeEntryWithArityCheckFor):
(JSC::LLInt::CLoop::jsCodeEntryFor):
* llint/LLIntCLoop.h: Added.
(JSC):
(LLInt):
(CLoop):
* llint/LLIntData.cpp:
(JSC::LLInt::initialize):
* llint/LLIntData.h:
(JSC):
* llint/LLIntOfflineAsmConfig.h:
* llint/LLIntOpcode.h:
* llint/LLIntThunks.cpp:
(LLInt):
* llint/LowLevelInterpreter.asm:
* llint/LowLevelInterpreter.cpp:
(LLInt):
(JSC::LLInt::Ints2Double):
(JSC):
(JSC::CLoop::execute):
* llint/LowLevelInterpreter.h:
(JSC):
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:
* offlineasm/asm.rb:
* offlineasm/backends.rb:
* offlineasm/cloop.rb: Added.
* offlineasm/instructions.rb:
* runtime/Executable.h:
(ExecutableBase):
(JSC::ExecutableBase::hostCodeEntryFor):
(JSC::ExecutableBase::jsCodeEntryFor):
(JSC::ExecutableBase::jsCodeWithArityCheckEntryFor):
(JSC::ExecutableBase::catchRoutineFor):
(NativeExecutable):
* runtime/JSValue.h:
(JSC):
(LLInt):
(JSValue):
* runtime/JSValueInlineMethods.h:
(JSC):
(JSC::JSValue::JSValue):
* runtime/Options.cpp:
(JSC::Options::initialize):

Source/WTF:

Added configs for the llint C loop backend.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago Rolled back in a piece of <http://trac.webkit.org/changeset/127293>.
ggaren@apple.com [Sat, 1 Sep 2012 17:22:02 +0000 (17:22 +0000)]
    Rolled back in a piece of <trac.webkit.org/changeset/127293>.

            Shrink activation objects by half
            https://bugs.webkit.org/show_bug.cgi?id=95591

            Reviewed by Sam Weinig.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdded #include <JavaScriptCore/Identifier.h>.
commit-queue@webkit.org [Sat, 1 Sep 2012 16:14:12 +0000 (16:14 +0000)]
Added #include <JavaScriptCore/Identifier.h>.
https://bugs.webkit.org/show_bug.cgi?id=95641.

Patch by Mark Lam <mark.lam@apple.com> on 2012-09-01
Reviewed by Dan Bernstein.

The code references JSC::Indentifier but was previously depending on
someone else to #include it. This results in build problems when
building for the llint C loop configuration.

* Plugins/Hosted/NetscapePluginInstanceProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix the --minimal build after r127327
krit@webkit.org [Sat, 1 Sep 2012 14:42:57 +0000 (14:42 +0000)]
[Qt] Fix the --minimal build after r127327
https://bugs.webkit.org/show_bug.cgi?id=95639

Unreviewed attempt to fix Qt minimal build.

* css/StyleBuilder.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Gtk] No accessible caret-moved events found in certain content
commit-queue@webkit.org [Sat, 1 Sep 2012 10:51:25 +0000 (10:51 +0000)]
[Gtk] No accessible caret-moved events found in certain content
https://bugs.webkit.org/show_bug.cgi?id=72811

Part of the bug was due to expected accessible objects of DivRole
and ParagraphRole being ignored, in favor of including child blocks.

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-09-01
Reviewed by Chris Fleizach.

Source/WebCore:

Test: platform/gtk/accessibility/spans-paragraphs-and-divs.html

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::firstAnonymousBlockChild):
(WebCore):
* accessibility/AccessibilityObject.h:
(AccessibilityObject):
New method to return the first child which is an anonymous block.
* accessibility/gtk/AccessibilityObjectAtk.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
Include paragraphs and divs which contain a non-nested anonymous block.

LayoutTests:

Added new test to verify that paragraphs and divs which contain anonymous
blocks are included in the accessible object hierarchy and have the correct
number of children with the expected role.

* platform/gtk/accessibility/spans-paragraphs-and-divs-expected.txt: Added.
* platform/gtk/accessibility/spans-paragraphs-and-divs.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening, rebaselining an accessibility test.
zandobersek@gmail.com [Sat, 1 Sep 2012 10:47:16 +0000 (10:47 +0000)]
Unreviewed GTK gardening, rebaselining an accessibility test.

* platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Gtk] No accessible caret-moved events found in certain content
zandobersek@gmail.com [Sat, 1 Sep 2012 08:53:50 +0000 (08:53 +0000)]
[Gtk] No accessible caret-moved events found in certain content
https://bugs.webkit.org/show_bug.cgi?id=72811

Part of the bug was due to extraneous accessible objects resulting
from unignored inline and block spans.

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-09-01
Reviewed by Chris Fleizach.

Source/WebCore:

Test: platform/gtk/accessibility/spans.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored): Ignore objects that have spanTag tag name.
* accessibility/gtk/AccessibilityObjectAtk.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject): Ignore most anonymous blocks.
* accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:
(roleIsTextType): Add ListItem to the roles which should implement AtkText.

LayoutTests:

Added new test, updated the results of one test to reflect the fix,
corrected a test with a mismatched element tag.

* platform/gtk/accessibility/aria-roles-unignored-expected.txt: Corrected results having fixed tag.
* platform/gtk/accessibility/aria-roles-unignored.html: Fixed mismatched element tag.
* platform/gtk/accessibility/media-element-expected.txt: Updated to reflect removal of extraneous object.
* platform/gtk/accessibility/spans-expected.txt: Added.
* platform/gtk/accessibility/spans.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Gtk] Incorrect/unexpected characters in the text of certain accessibles
zandobersek@gmail.com [Sat, 1 Sep 2012 08:43:04 +0000 (08:43 +0000)]
[Gtk] Incorrect/unexpected characters in the text of certain accessibles
https://bugs.webkit.org/show_bug.cgi?id=95180

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-09-01
Reviewed by Chris Fleizach.

Source/WebCore:

The bug was caused by failing to properly handle anonymous block text
which had object replacement characters (multibyte) in it. Calculating
the string length based on the UTF-8 string meant that we were returning
more characters than were there and in danger of splitting a multibyte
character.

Tests: platform/gtk/accessibility/entry-and-password.html
       platform/gtk/accessibility/replaced-objects-in-anonymous-blocks.html

* accessibility/gtk/WebKitAccessibleInterfaceText.cpp:
(webkitAccessibleTextGetText): Convert the text returned by textForObject()
to Unicode before calculating its length.

Source/WebKit/gtk:

Corrected a unit test in which the expected accessible text was wrong as
a result of this bug. In particular, the AtkText inserted into an empty
text field is expected to be the same text atk_text_get_text() returns.
That was not happening -- and presumably not noticed as a result of the
hard to read textual representation of the multibyte password field
bullets.

* tests/testatk.c:
(testWebkitAtkTextChangedNotifications): Corrected the test and added a
comment so that one knows what the multibyte character is.

Tools:

The bug that was fixed stood in the way of fully implementing stringValue().
Testing that the bug is fixed requires stringValue() to be fully implemented
and object replacement characters to be printable.

* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(replaceCharactersForResults): New method which turns object replacement
characters into "<obj>" so that the characters can be properly shown in
Layout Test results. Also turns "\n" into "<\\n>" so that printing the
accessible text of a single object in the accessible tree doesn't mess up
the readibility of the results.
(AccessibilityUIElement::stringValue): Remove the code that immediately
returned upon encountering an object of ATK_ROLE_PANEL and call the new
replaceCharactersForResults() prior to returning the accessible string
value.

LayoutTests:

Two new layout tests, plus one updated one.

* platform/gtk/accessibility/deleting-iframe-destroys-axcache-expected.txt: Indicated replaced objects.
* platform/gtk/accessibility/entry-and-password-expected.txt: Added.
* platform/gtk/accessibility/entry-and-password.html: Added.
* platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt: Added.
* platform/gtk/accessibility/replaced-objects-in-anonymous-blocks.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove all-but-one use of WTF::String::operator+= from WebCore
abarth@webkit.org [Sat, 1 Sep 2012 08:20:01 +0000 (08:20 +0000)]
Remove all-but-one use of WTF::String::operator+= from WebCore
https://bugs.webkit.org/show_bug.cgi?id=95508

Reviewed by Benjamin Poulain.

This patch removes all the uses of WTF::String::operator+= from
WebCore, except those in WorkerScriptLoader (which need a more delicate
patch). There were actually a handful of legitimate use cases for += in
this group. I've replaced them with calls to String::append rather than
+= so that we can remove += and encourage most contributors to use
more efficient string idioms.

(There are likely some more uses in WebCore hiding in port-specific
code---this patch covers only those call sites found when compiling the
chromium-mac port.)

* inspector/InspectorStyleTextEditor.cpp:
(WebCore::InspectorStyleTextEditor::insertProperty):
    - This complicated function looks really inefficient, but I didn't
      have the heart to rewrite it.
* inspector/NetworkResourcesData.cpp:
(WebCore::NetworkResourcesData::ResourceData::decodeDataToContent):
* loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::sheetText):
(WebCore::CachedCSSStyleSheet::data):
* loader/cache/CachedFont.cpp:
(WebCore::CachedFont::ensureSVGFontData):
* loader/cache/CachedScript.cpp:
(WebCore::CachedScript::script):
* loader/cache/CachedXSLStyleSheet.cpp:
(WebCore::CachedXSLStyleSheet::data):
    - This decoder/flush pattern can probably be improved by combining
      the decode and flush operations, but I didn't do that in this
      patch.
* page/FrameTree.cpp:
(WebCore::FrameTree::uniqueChildName):
    - I found this code very amusing. It's worried enough about
      efficiency to give a big speech about why snprintf is safe, but
      then it implicitly performs a large number of mallocs and memcpy
      operations.
* page/Page.cpp:
(WebCore::Page::userStyleSheet):
* platform/chromium/support/WebHTTPLoadInfo.cpp:
(WebKit::addHeader):
* platform/chromium/support/WebURLResponse.cpp:
(WebKit::WebURLResponse::addHTTPHeaderField):
    - This header-appending idiom looks like a reasonable use case for
      String::append.
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::send):
(WebCore::XMLHttpRequest::setRequestHeaderInternal):
* xml/XPathFunctions.cpp:
(WebCore::XPath::FunTranslate::evaluate):
    - Fixes 6 year old FIXME.
* xml/parser/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::append):
* xml/parser/XMLDocumentParser.h:
(XMLDocumentParser):
* xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::doEnd):
* xml/parser/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::doEnd):
    - Changed m_originalSourceForTransform to a SegmentedString so that
      we don't need to malloc and copy the entire document every time
      we get more data from the network.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMediaStream API: Add MediaStream management to RTCPeerConnection
tommyw@google.com [Sat, 1 Sep 2012 07:54:31 +0000 (07:54 +0000)]
MediaStream API: Add MediaStream management to RTCPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=95543

Reviewed by Adam Barth.

Source/Platform:

* chromium/public/WebMediaStreamCenter.h:
(WebMediaStreamCenter):
* chromium/public/WebRTCPeerConnectionHandler.h:
(WebKit):
(WebRTCPeerConnectionHandler):
* chromium/public/WebRTCPeerConnectionHandlerClient.h:
(WebKit):
(WebRTCPeerConnectionHandlerClient):

Source/WebCore:

This includes addStream/removeStream to RTCPeerConnection,
as well as didAddRemoteStream/didRemoveRemoteStream to RTCPeerConnectionHandlerClient.

Test: fast/mediastream/RTCPeerConnection-AddRemoveStream.html

* Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::parseConfiguration):
(WebCore::RTCPeerConnection::RTCPeerConnection):
(WebCore::RTCPeerConnection::addStream):
(WebCore):
(WebCore::RTCPeerConnection::removeStream):
(WebCore::RTCPeerConnection::localStreams):
(WebCore::RTCPeerConnection::remoteStreams):
(WebCore::RTCPeerConnection::didAddRemoteStream):
(WebCore::RTCPeerConnection::didRemoveRemoteStream):
* Modules/mediastream/RTCPeerConnection.h:
(RTCPeerConnection):
* Modules/mediastream/RTCPeerConnection.idl:
* bindings/js/Dictionary.cpp:
(WebCore::Dictionary::getOwnPropertiesAsStringHashMap):
(WebCore::Dictionary::getOwnPropertyNames):
* bindings/v8/Dictionary.cpp:
(WebCore::Dictionary::getOwnPropertiesAsStringHashMap):
(WebCore::Dictionary::getOwnPropertyNames):
* bindings/v8/Dictionary.h:
(Dictionary):
* platform/mediastream/RTCPeerConnectionHandler.cpp:
(RTCPeerConnectionHandlerDummy):
(WebCore::RTCPeerConnectionHandlerDummy::addStream):
(WebCore):
(WebCore::RTCPeerConnectionHandlerDummy::removeStream):
* platform/mediastream/RTCPeerConnectionHandler.h:
(RTCPeerConnectionHandler):
* platform/mediastream/RTCPeerConnectionHandlerClient.h:
(WebCore):
(RTCPeerConnectionHandlerClient):
* platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:
(WebCore::RTCPeerConnectionHandlerChromium::addStream):
(WebCore):
(WebCore::RTCPeerConnectionHandlerChromium::removeStream):
(WebCore::RTCPeerConnectionHandlerChromium::didAddRemoteStream):
(WebCore::RTCPeerConnectionHandlerChromium::didRemoveRemoteStream):
* platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:
(WebKit):
(RTCPeerConnectionHandlerChromium):

Source/WebKit/chromium:

* src/AssertMatchingEnums.cpp:

Tools:

Extending MockWebRTCPeerConnectionHandler to handle addStream/removeStream.

* DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
(MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
(MockWebRTCPeerConnectionHandler::addStream):
(MockWebRTCPeerConnectionHandler::removeStream):
* DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
(MockWebRTCPeerConnectionHandler):

LayoutTests:

* fast/mediastream/RTCPeerConnection-AddRemoveStream-expected.txt: Added.
* fast/mediastream/RTCPeerConnection-AddRemoveStream.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Tests] Add a test for all notification events
jonlee@apple.com [Sat, 1 Sep 2012 07:49:07 +0000 (07:49 +0000)]
[Tests] Add a test for all notification events
https://bugs.webkit.org/show_bug.cgi?id=95609
<rdar://problem/12218309>

Reviewed by Jessie Berlin.

This test tests for the onshow, onclick, and onclose events. onerror is called only if the
origin did not have permission to show the notification, and that is covered in
http/tests/notifications/{legacy,}/show.html.

* http/tests/notifications/events-expected.txt: Added.
* http/tests/notifications/events.html: Added.
* http/tests/notifications/legacy/events-expected.txt: Added.
* http/tests/notifications/legacy/events.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-09-01 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Sat, 1 Sep 2012 07:45:01 +0000 (07:45 +0000)]
2012-09-01  Geoffrey Garen  <ggaren@apple.com>

        Rolled back in a piece of <http://trac.webkit.org/changeset/127293>.

            Shrink activation objects by half
            https://bugs.webkit.org/show_bug.cgi?id=95591

            Reviewed by Sam Weinig.

        * runtime/JSActivation.cpp:
        (JSC::JSActivation::JSActivation):
        * runtime/JSGlobalObject.cpp:
        (JSC::JSGlobalObject::JSGlobalObject):
        (JSC::JSGlobalObject::setGlobalThis):
        (JSC):
        (JSC::JSGlobalObject::visitChildren):
        * runtime/JSGlobalObject.h:
        (JSGlobalObject):
        (JSC::JSScope::globalThis):
        (JSC):
        (JSC::JSGlobalObject::globalThis):
        * runtime/JSNameScope.h:
        (JSC::JSNameScope::JSNameScope):
        * runtime/JSScope.cpp:
        (JSC::JSScope::visitChildren):
        * runtime/JSScope.h:
        (JSScope):
        (JSC::JSScope::JSScope):
        (JSC::JSScope::globalObject):
        (JSC::JSScope::globalData):
        * runtime/JSSegmentedVariableObject.h:
        (JSC::JSSegmentedVariableObject::JSSegmentedVariableObject):
        * runtime/JSSymbolTableObject.h:
        (JSC::JSSymbolTableObject::JSSymbolTableObject):
        * runtime/JSVariableObject.h:
        (JSC::JSVariableObject::JSVariableObject):
        * runtime/JSWithScope.h:
        (JSC::JSWithScope::JSWithScope):
        * runtime/StrictEvalActivation.cpp:
        (JSC::StrictEvalActivation::StrictEvalActivation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Tests] Move fast/notifications/notifications-event-listener-crash.html to http/tests...
jonlee@apple.com [Sat, 1 Sep 2012 07:38:12 +0000 (07:38 +0000)]
[Tests] Move fast/notifications/notifications-event-listener-crash.html to http/tests/notifications
https://bugs.webkit.org/show_bug.cgi?id=95535
<rdar://problem/12213781>

Reviewed by Jessie Berlin.

This test is among a few that are being migrated from fast/notifications to http/tests/notifications because of permissions.
Since most notifications tests will involve permissions, it is easier to have all of them consolidated in the same directory.

This test has been slightly modified to take advantage of the new testRunner notifications API. The test itself also does not
need to be protected within the window.testRunner check since it does not use that object.

* fast/notifications/notifications-event-listener-crash-expected.txt: Removed.
* fast/notifications/notifications-event-listener-crash.html: Removed.
* http/tests/notifications/event-listener-crash-expected.txt: Added.
* http/tests/notifications/event-listener-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTouch a file so that Chromium-win bots correctly re-build for OPENTYPE_VERTICAL
tkent@chromium.org [Sat, 1 Sep 2012 07:29:56 +0000 (07:29 +0000)]
Touch a file so that Chromium-win bots correctly re-build for OPENTYPE_VERTICAL
https://bugs.webkit.org/show_bug.cgi?id=51450

* platform/graphics/opentype/OpenTypeVerticalData.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-09-01 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Sat, 1 Sep 2012 07:15:24 +0000 (07:15 +0000)]
2012-09-01  Geoffrey Garen  <ggaren@apple.com>

        Rolled back out a piece of <http://trac.webkit.org/changeset/127293>
        because it broke Window inspector tests.

            Shrink activation objects by half
            https://bugs.webkit.org/show_bug.cgi?id=95591

            Reviewed by Sam Weinig.

        * runtime/JSActivation.h:
        (JSActivation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Text expectation update
tkent@chromium.org [Sat, 1 Sep 2012 05:38:03 +0000 (05:38 +0000)]
[Chromium] Text expectation update
https://bugs.webkit.org/show_bug.cgi?id=51450

* platform/chromium/TestExpectations:
Fix incorrect entry for track-cue-rendering-vertical.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Test expectation update.
tkent@chromium.org [Sat, 1 Sep 2012 05:31:46 +0000 (05:31 +0000)]
[Chromium] Test expectation update.
https://bugs.webkit.org/show_bug.cgi?id=51450

* platform/chromium/TestExpectations:
- r127354 wrongly removed failure expectation for MAC.
- Also, fix expectation of vertical-font-fallback.html on WIN.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix 6 broken SVG animation tests
pdr@google.com [Sat, 1 Sep 2012 04:31:45 +0000 (04:31 +0000)]
Fix 6 broken SVG animation tests

Unreviewed test update.

Six SVG animation tests were marked as TIMEOUT because they never ran. Each
of these tests required a click event to start and the event was not being fired.
This patch updates these tests to correctly start, fixing 6 TIMEOUTS.

* platform/chromium/TestExpectations:
* svg/animations/script-tests/animate-path-animation-qQ-tT-inverse.js:
* svg/animations/script-tests/animate-path-nested-transforms.js:
* svg/animations/script-tests/svgnumberoptionalnumber-animation-1.js:
* svg/animations/script-tests/svgnumberoptionalnumber-animation-2.js:
* svg/animations/script-tests/svgnumberoptionalnumber-animation-3.js:
* svg/animations/script-tests/svgnumberoptionalnumber-animation-4.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed, test expectation update
tkent@chromium.org [Sat, 1 Sep 2012 04:24:04 +0000 (04:24 +0000)]
[Chromium] Unreviewed, test expectation update

* platform/chromium/TestExpectations:
 - Skip removing-underline-after-accepting-autocorrection-using-punctuation.html. Chromium doesn't support autocorrection yet.
 - Remove ANDROID entry for http/tests/notifications

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTouch some files so that Chromium-win bots correctly re-build
tkent@chromium.org [Sat, 1 Sep 2012 04:13:15 +0000 (04:13 +0000)]
Touch some files so that Chromium-win bots correctly re-build
files for OPENTYPE_VERTICAL.
https://bugs.webkit.org/show_bug.cgi?id=51450

* platform/graphics/FontCache.h:
* platform/graphics/SimpleFontData.h:
* platform/graphics/opentype/OpenTypeTypes.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGlyphs in vertical text tests are rotated 90 degrees clockwise on Chromium Windows
tkent@chromium.org [Sat, 1 Sep 2012 04:06:02 +0000 (04:06 +0000)]
Glyphs in vertical text tests are rotated 90 degrees clockwise on Chromium Windows
https://bugs.webkit.org/show_bug.cgi?id=51450

Patch by Koji Ishii <kojiishi@gmail.com> on 2012-08-31
Reviewed by Tony Chang.

When writing-mode is vertical-*, Chromium Win does not render glyphs correctly.
http://dev.w3.org/csswg/css3-writing-modes/#writing-mode
Glyphs are now drawn in the correct orientation, regardless of the leading '@' in the font name,
and vertical alternate glyphs (OpenType 'vert' feature) is not enabled.
CJK characters drawn at wrong baseline position is also fixed.
In addition, fontMetrics().unitsPerEm() and SimpleFontData::platformBoundsForGlyph() were empty
in Chromium Win but they were implemented because they were needed to draw vertical flow correctly.

Note that this patch does not address issues in vertical flow for complex code path.
The issue is under discussion with Google people and it will not be fixed in short term.

Source/WebKit/chromium:

Existing tests in fast/writing-mode/* are enabled in LayoutTests/platform/chromium/TestExpectations.

* features.gypi: ENABLE_OPENTYPE_VERTICAL=1.

LayoutTests:

* fast/text/international/text-spliced-font.html: Added "MS Gothic" to the font list so that Japanese font is chosen on Windows.
* fast/writing-mode/border-vertical-lr.html: Ditto.
* fast/writing-mode/japanese-lr-selection.html: Ditto.
* fast/writing-mode/japanese-lr-text.html: Ditto.
* fast/writing-mode/japanese-rl-selection.html: Ditto.
* fast/writing-mode/japanese-rl-text.html: Ditto.
* platform/chromium/TestExpectations: writing-mode and vertical tests are separated to rebase later.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild warning : -Wformat on WebMemorySampler.cpp.
commit-queue@webkit.org [Sat, 1 Sep 2012 03:46:00 +0000 (03:46 +0000)]
Build warning : -Wformat on WebMemorySampler.cpp.
https://bugs.webkit.org/show_bug.cgi?id=95550

Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-08-31
Reviewed by Darin Adler.

Fix build warning.
Use String::number instead of String::format.

* Shared/WebMemorySampler.cpp:
(WebKit::WebMemorySampler::appendCurrentMemoryUsageToFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago-webkit-flex: 0 in inspector.css is confusing
commit-queue@webkit.org [Sat, 1 Sep 2012 03:08:43 +0000 (03:08 +0000)]
-webkit-flex: 0 in inspector.css is confusing
https://bugs.webkit.org/show_bug.cgi?id=95568

Patch by Chris Hutten-Czapski <chutten@rim.com> on 2012-08-31
Reviewed by Tony Chang.

The initial value of -webkit-flex results in the same layout as
-webkit-flex: 0; but does not depend on the new initial value of auto
for min-width.

This increases the support for the new Web Inspector style to renderers
built before rev 122264 but after 117385.

No new tests (has no effect except to out-of-date renderers)

* inspector/front-end/inspector.css:
(.status-bar-item):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, attempt to fix Windows, take two.
fpizlo@apple.com [Sat, 1 Sep 2012 02:14:23 +0000 (02:14 +0000)]
Unreviewed, attempt to fix Windows, take two.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, attempt to fix Windows.
fpizlo@apple.com [Sat, 1 Sep 2012 01:51:45 +0000 (01:51 +0000)]
Unreviewed, attempt to fix Windows.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoJSArray::putDirectIndex should by default behave like JSObject::putDirect
fpizlo@apple.com [Sat, 1 Sep 2012 01:50:13 +0000 (01:50 +0000)]
JSArray::putDirectIndex should by default behave like JSObject::putDirect
https://bugs.webkit.org/show_bug.cgi?id=95630

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* jsc.cpp:
(GlobalObject::finishCreation):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
* runtime/JSArray.cpp:
(JSC::SparseArrayValueMap::putDirect):
(JSC::JSArray::defineOwnNumericProperty):
(JSC::JSArray::putDirectIndexBeyondVectorLength):
* runtime/JSArray.h:
(SparseArrayValueMap):
(JSArray):
(JSC::JSArray::putDirectIndex):
* runtime/JSONObject.cpp:
(JSC::Walker::walk):
* runtime/RegExpMatchesArray.cpp:
(JSC::RegExpMatchesArray::reifyAllProperties):
(JSC::RegExpMatchesArray::reifyMatchProperty):
* runtime/StringPrototype.cpp:
(JSC::splitStringByOneCharacterImpl):
(JSC::stringProtoFuncSplit):

Source/WebCore:

No new tests because no change in behavior.

* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneDeserializer::putProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRolled back in a piece of <http://trac.webkit.org/changeset/127293>.
ggaren@apple.com [Sat, 1 Sep 2012 01:39:51 +0000 (01:39 +0000)]
Rolled back in a piece of <trac.webkit.org/changeset/127293>.

    Shrink activation objects by half
    https://bugs.webkit.org/show_bug.cgi?id=95591

    Reviewed by Sam Weinig.

* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:
(JSGlobalData):
* runtime/JSNameScope.h:
(JSC::JSNameScope::JSNameScope):
* runtime/JSWithScope.h:
(JSC::JSWithScope::JSWithScope):
* runtime/StrictEvalActivation.cpp:
(JSC::StrictEvalActivation::StrictEvalActivation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: fast/loader/document-destruction-within-unload.html causes assertion...
japhet@chromium.org [Sat, 1 Sep 2012 01:09:02 +0000 (01:09 +0000)]
Source/WebCore: fast/loader/document-destruction-within-unload.html causes assertion failures on mac and qt.
https://bugs.webkit.org/show_bug.cgi?id=66783

Reviewed by Darin Adler.

This was a not-quite-regression from trac.webkit.org/changeset/93521, in that we hit asserts
in a case where we previously were use-after-freeing. Tweak how we handle cases where a Document
is cleared from within an unload handler.

No new tests, fixing fast/loader/document-destruction-within-unload.html on mac and qt.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::setDocumentLoader): Instead of trying to reattach a partially removed
    DocumentLoader if it is detached before being fully added, leave the old one in place, completed.
(WebCore::FrameLoader::transitionToCommitted):

LayoutTests: Unskip fast/loader/document-destruction-within-unload.html
on mac and qt.
https://bugs.webkit.org/show_bug.cgi?id=66783

Reviewed by Darin Adler.

* platform/mac/Skipped:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake computeBlockDirectionMargins const
tony@chromium.org [Sat, 1 Sep 2012 01:00:10 +0000 (01:00 +0000)]
Make computeBlockDirectionMargins const
https://bugs.webkit.org/show_bug.cgi?id=95595

Reviewed by Ojan Vafai.

This is a step in making computeLogicalHeight const.
Refactor RenderBox::computeBlockDirectionMargins and make it const.
Add a helper method computeAndSetBlockDirectionMargins for the callers outside of
computeLogicalHeight that are calling this.

No new tests, this is already covered by tests in fast/writing-mode and fast/multicol.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::marginBeforeEstimateForChild): Switch to computeAndSetBlockDirectionMargins
(WebCore::RenderBlock::layoutBlockChild): Switch to computeAndSetBlockDirectionMargins
(WebCore::RenderBlock::insertFloatingObject): Switch to computeAndSetBlockDirectionMargins
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalHeight): Use const version and fill in a MarginValues struct (to be merged in the next patch).
(WebCore::RenderBox::computeBlockDirectionMargins): Pass in out params.
(WebCore):
(WebCore::RenderBox::computeAndSetBlockDirectionMargins): Does the same as the old computeBlockDirectionMargins.
* rendering/RenderBox.h:
(RenderBox):
* rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox): Switch to computeAndSetBlockDirectionMargins
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox): Switch to computeAndSetBlockDirectionMargins
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::layout): Switch to computeAndSetBlockDirectionMargins

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRolled back in a piece of <http://trac.webkit.org/changeset/127293>.
ggaren@apple.com [Sat, 1 Sep 2012 00:46:58 +0000 (00:46 +0000)]
Rolled back in a piece of <trac.webkit.org/changeset/127293>.

    Shrink activation objects by half
    https://bugs.webkit.org/show_bug.cgi?id=95591

    Reviewed by Sam Weinig.

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_resolve_global_dynamic):
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:
* runtime/JSActivation.cpp:
(JSC::JSActivation::JSActivation):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:
(JSGlobalData):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::visitChildren):
* runtime/JSGlobalObject.h:
(JSGlobalObject):
(JSC::JSGlobalObject::withScopeStructure):
(JSC::JSGlobalObject::strictEvalActivationStructure):
(JSC::JSGlobalObject::activationStructure):
(JSC::JSGlobalObject::nameScopeStructure):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. CSS_VARIABLES are not enabled on Windows. Adding Windows specific results.
roger_fong@apple.com [Sat, 1 Sep 2012 00:40:57 +0000 (00:40 +0000)]
Unreviewed. CSS_VARIABLES are not enabled on Windows. Adding Windows specific results.

* platform/win/fast/css/variables: Added.
* platform/win/fast/css/variables/build-supports-variables-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove use of ClassInfo in SpeculativeJIT::emitBranch
mhahnenberg@apple.com [Sat, 1 Sep 2012 00:38:37 +0000 (00:38 +0000)]
Remove use of ClassInfo in SpeculativeJIT::emitBranch
https://bugs.webkit.org/show_bug.cgi?id=95623

Reviewed by Filip Pizlo.

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitNonStringCellOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitNonStringCellOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Make link highlighter use same node selection criteria as Chromium for...
wjmaclean@chromium.org [Sat, 1 Sep 2012 00:33:12 +0000 (00:33 +0000)]
[chromium] Make link highlighter use same node selection criteria as Chromium for Android.
https://bugs.webkit.org/show_bug.cgi?id=95371

Reviewed by James Robinson.

This CL brings the selection criteria for link highlight targets into alignment with Chromium for Android.

Source/WebKit/chromium:

* src/WebViewImpl.cpp:
(WebKit::highlightConditions):
(WebKit::WebViewImpl::bestTouchLinkNode):
* tests/data/test_touch_link_highlight.html:

LayoutTests:

* platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-ZIndex.html: Copied from LayoutTests/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-background.html.
* platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-background.html:
* platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-body.html: Copied from LayoutTests/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-background.html.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-ZIndex-expected.png: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-ZIndex-expected.txt: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-body-expected.png: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-body-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Adding expected failing results for some fast/css(3) tests.
roger_fong@apple.com [Sat, 1 Sep 2012 00:30:10 +0000 (00:30 +0000)]
Unreviewed. Adding expected failing results for some fast/css(3) tests.
https://bugs.webkit.org/show_bug.cgi?id=95627.

* platform/win/fast/css/image-resolution: Added.
* platform/win/fast/css/image-resolution/image-resolution-expected.txt: Added.
* platform/win/fast/css/image-set-setting-expected.txt: Added.
* platform/win/fast/css/parse-border-image-repeat-null-crash-expected.txt: Added.
* platform/win/fast/css3-text-decoration: Added.
* platform/win/fast/css3-text-decoration/getComputedStyle: Added.
* platform/win/fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt: Added.
* platform/win/fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Consolidate geometry unit testing functions for cc
jamesr@google.com [Sat, 1 Sep 2012 00:20:52 +0000 (00:20 +0000)]
[chromium] Consolidate geometry unit testing functions for cc
https://bugs.webkit.org/show_bug.cgi?id=95526

Reviewed by Julien Chaffraix.

This consolidates geometry equality (rects, matrices) in CCGeometryUtils and removes a few duplicate macros for
testing rect equality.

* WebKit.gypi:
* tests/CCDamageTrackerTest.cpp:
(WebKitTests::TEST_F):
* tests/CCGeometryTestUtils.cpp: Added.
(WebKitTests):
(WebKitTests::ExpectTransformationMatrixEq):
* tests/CCGeometryTestUtils.h: Renamed from Source/WebKit/chromium/tests/CCLayerTreeTestCommon.h.
(WebKit):
(WebKitTests):
* tests/CCLayerTreeHostTest.cpp:
* tests/CCMathUtilTest.cpp:
(WebKit::TEST):
* tests/TiledLayerChromiumTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMark some indexeddb tests as SLOW. They consistently time out for me
ojan@chromium.org [Sat, 1 Sep 2012 00:12:40 +0000 (00:12 +0000)]
Mark some indexeddb tests as SLOW. They consistently time out for me
when I run with --fully-parallel.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRolled back in a piece of <http://trac.webkit.org/changeset/127293>.
ggaren@apple.com [Sat, 1 Sep 2012 00:08:18 +0000 (00:08 +0000)]
Rolled back in a piece of <trac.webkit.org/changeset/127293>.

    Shrink activation objects by half
    https://bugs.webkit.org/show_bug.cgi?id=95591

    Reviewed by Sam Weinig.

* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::MarkedBlock):
* heap/MarkedBlock.h:
(MarkedBlock):
(JSC::MarkedBlock::globalData):
(JSC):
* heap/WeakSet.cpp:
(JSC::WeakSet::addAllocator):
* heap/WeakSet.h:
(WeakSet):
(JSC::WeakSet::WeakSet):
(JSC::WeakSet::globalData):
* runtime/JSGlobalData.h:
(JSC::WeakSet::heap):
(JSC):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago [WK2] Use initial process in multi-process mode, too
ap@apple.com [Fri, 31 Aug 2012 23:49:17 +0000 (23:49 +0000)]
    [WK2] Use initial process in multi-process mode, too
        https://bugs.webkit.org/show_bug.cgi?id=95612

        Reviewed by Sam Weinig.

        * UIProcess/WebContext.cpp:
        (WebKit::WebContext::WebContext):
        (WebKit::WebContext::warmInitialProcess):
        (WebKit::WebContext::disconnectProcess):
        (WebKit::WebContext::createWebPage):
        * UIProcess/WebContext.h:
        Added a boolean telling whether the last (normally, the only) process in m_processes
        is available for use in a new page.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Clean up Web*Layer initialization paths
jamesr@google.com [Fri, 31 Aug 2012 23:46:52 +0000 (23:46 +0000)]
[chromium] Clean up Web*Layer initialization paths
https://bugs.webkit.org/show_bug.cgi?id=95523

Reviewed by Darin Fisher.

Constructing a Web*LayerImpl (or other compositor type) wrapper shouldn't require knowledge of the underyling
implementation. Also normalizes naming conventions in these files.

* src/WebAnimationImpl.cpp:
(WebKit::WebAnimation::create):
(WebKit::WebAnimationImpl::WebAnimationImpl):
* src/WebAnimationImpl.h:
(WebAnimationImpl):
* src/WebContentLayerImpl.cpp:
(WebKit::WebContentLayerImpl::WebContentLayerImpl):
(WebKit::WebContentLayerImpl::~WebContentLayerImpl):
(WebKit::WebContentLayerImpl::layer):
(WebKit::WebContentLayerImpl::setDoubleSided):
(WebKit::WebContentLayerImpl::setContentsScale):
(WebKit::WebContentLayerImpl::setUseLCDText):
(WebKit::WebContentLayerImpl::setDrawCheckerboardForMissingTiles):
* src/WebContentLayerImpl.h:
(WebContentLayerImpl):
* src/WebFloatAnimationCurveImpl.cpp:
(WebKit::WebFloatAnimationCurve::create):
(WebKit::WebFloatAnimationCurveImpl::WebFloatAnimationCurveImpl):
* src/WebFloatAnimationCurveImpl.h:
(WebFloatAnimationCurveImpl):
* src/WebIOSurfaceLayerImpl.cpp:
(WebKit::WebIOSurfaceLayer::create):
(WebKit::WebIOSurfaceLayerImpl::WebIOSurfaceLayerImpl):
* src/WebIOSurfaceLayerImpl.h:
(WebIOSurfaceLayerImpl):
* src/WebImageLayerImpl.cpp:
(WebKit::WebImageLayer::create):
(WebKit::WebImageLayerImpl::WebImageLayerImpl):
* src/WebImageLayerImpl.h:
(WebImageLayerImpl):
* src/WebLayerImpl.cpp:
(WebKit::WebLayer::create):
(WebKit):
(WebKit::WebLayerImpl::WebLayerImpl):
* src/WebLayerImpl.h:
(WebLayerImpl):
* src/WebScrollbarLayerImpl.cpp:
(WebKit::WebScrollbarLayer::create):
(WebKit::WebScrollbarLayerImpl::WebScrollbarLayerImpl):
* src/WebScrollbarLayerImpl.h:
(WebScrollbarLayerImpl):
* src/WebSolidColorLayerImpl.cpp:
(WebKit::WebSolidColorLayer::create):
(WebKit::WebSolidColorLayerImpl::WebSolidColorLayerImpl):
* src/WebSolidColorLayerImpl.h:
(WebSolidColorLayerImpl):
* src/WebTransformAnimationCurveImpl.cpp:
(WebKit::WebTransformAnimationCurve::create):
(WebKit::WebTransformAnimationCurveImpl::WebTransformAnimationCurveImpl):
* src/WebTransformAnimationCurveImpl.h:
(WebTransformAnimationCurveImpl):
* src/WebVideoLayerImpl.cpp:
(WebKit::WebVideoLayer::create):
(WebKit::WebVideoLayerImpl::WebVideoLayerImpl):
* src/WebVideoLayerImpl.h:
(WebVideoLayerImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r127309.
commit-queue@webkit.org [Fri, 31 Aug 2012 23:42:35 +0000 (23:42 +0000)]
Unreviewed, rolling out r127309.
http://trac.webkit.org/changeset/127309
https://bugs.webkit.org/show_bug.cgi?id=95624

The Windows tests weren't actually fixed. (Requested by
mhahnenberg on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-31

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago [WK2] WebProcesses should not wait 60 seconds to close in multi-process mode
ap@apple.com [Fri, 31 Aug 2012 23:27:27 +0000 (23:27 +0000)]
    [WK2] WebProcesses should not wait 60 seconds to close in multi-process mode
        https://bugs.webkit.org/show_bug.cgi?id=95616

        Reviewed by Darin Adler.

        * Shared/ChildProcess.cpp: (WebKit::ChildProcess::ChildProcess):
        * Shared/ChildProcess.h: (WebKit::ChildProcess::setTerminationTimeout):
        Expose a setter for timeout instead of taking it at construction time. If a derived
        class doesn't call the setter, default to 0.

        * PluginProcess/PluginProcess.cpp:
        (WebKit::PluginProcess::PluginProcess):
        (WebKit::PluginProcess::initializePluginProcess):
        Use timeout from initialization message.

        * WebProcess/WebProcess.cpp:
        (WebKit::WebProcess::WebProcess):
        (WebKit::WebProcess::initializeWebProcess):
        Ditto.

        * Shared/Plugins/PluginProcessCreationParameters.cpp:
        (WebKit::PluginProcessCreationParameters::encode):
        (WebKit::PluginProcessCreationParameters::decode):
        * Shared/Plugins/PluginProcessCreationParameters.h:
        * Shared/WebProcessCreationParameters.cpp:
        (WebKit::WebProcessCreationParameters::encode):
        (WebKit::WebProcessCreationParameters::decode):
        * Shared/WebProcessCreationParameters.h:
        Funnel timeout across process boundary.

        * UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::didFinishLaunching):
        Pass timeout as initialization message after launch.

        * UIProcess/WebContext.cpp:
        (WebKit::WebContext::createNewWebProcess): Pass timeout as initialization message
        (unlike plugin process proxy, web process proxy doesn't wait, and relies on the message
        being queued).
        (WebKit::WebContext::disconnectProcess): Skip invalidating global managers when
        one process quits. We still need to do something, but running this code would just
        result in assertion failures any time a page was closed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRefactor LLInt and supporting code in preparation for the C Loop backend.
commit-queue@webkit.org [Fri, 31 Aug 2012 23:25:28 +0000 (23:25 +0000)]
Refactor LLInt and supporting code in preparation for the C Loop backend.
https://bugs.webkit.org/show_bug.cgi?id=95531.

Patch by Mark Lam <mark.lam@apple.com> on 2012-08-31
Reviewed by Filip Pizlo.

* bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFromLLInt):
* bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFromLLInt):
* jit/JITExceptions.cpp:
(JSC::genericThrow): Use ExecutableBase::catchRoutineFor() to fetch
    fetch the catch routine for a thrown exception.  This will allow
    us to redefine that for the C loop later, and still keep this
    code readable.
* llint/LLIntOfflineAsmConfig.h: Moved ASM macros to
    LowLevelInterpreter.cpp which is the only place they are used. This
    will make it more convenient to redefine them for the C loop later.
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::setUpCall): Use ExecutableBase's hostCodeEntry()
    jsCodeEntryFor(), and jsCodeWithArityCheckEntryFor() for computing
    the entry points to functions being called.
* llint/LLIntSlowPaths.h:
(SlowPathReturnType):
(JSC::LLInt::encodeResult):
(LLInt):
(JSC::LLInt::decodeResult): Added.  Needed by LLInt C Loop later.
* llint/LowLevelInterpreter.asm:
* llint/LowLevelInterpreter.cpp:
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:
* offlineasm/asm.rb: Disambiguate between opcodes and other labels.
* offlineasm/config.rb:
* runtime/Executable.h:
(JSC::ExecutableBase::hostCodeEntryFor): Added.
(ExecutableBase):
(JSC::ExecutableBase::jsCodeEntryFor): Added.
(JSC::ExecutableBase::jsCodeWithArityCheckEntryFor): Added.
(JSC::ExecutableBase::catchRoutineFor): Added.
* runtime/JSValueInlineMethods.h:
(JSC):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Lion] css3/filters/composited-during-animation-layertree.html produces empty results
jberlin@webkit.org [Fri, 31 Aug 2012 23:16:39 +0000 (23:16 +0000)]
[Lion] css3/filters/composited-during-animation-layertree.html produces empty results
https://bugs.webkit.org/show_bug.cgi?id=95622

Move the empty results to mac-lion and add the ML results to mac to get the bots greener.

* platform/mac-lion/css3/filters/composited-during-animation-layertree-expected.txt: Copied from LayoutTests/platform/mac/css3/filters/composited-during-animation-layertree-expected.txt.
* platform/mac/css3/filters/composited-during-animation-layertree-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Getting rid of Windows specific results because CSS3 flexbox has been...
roger_fong@apple.com [Fri, 31 Aug 2012 23:08:00 +0000 (23:08 +0000)]
Unreviewed. Getting rid of Windows specific results because CSS3 flexbox has been re-enabled here: https://bugs.webkit.org/show_bug.cgi?id=95382

* platform/win/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
* platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Mountain Lion] platform/mac/editing/spelling/removing-underline-after-accepting...
jberlin@webkit.org [Fri, 31 Aug 2012 23:00:17 +0000 (23:00 +0000)]
[Mountain Lion] platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation.html failing.
https://bugs.webkit.org/show_bug.cgi?id=95477

Add Mountain Lion expected (failing?) results and move the ones previously in mac to mac-lion to get the bots greener.

* platform/mac-lion/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation-expected.png: Renamed from LayoutTests/platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation-expected.png.
* platform/mac-lion/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation-expected.txt: Copied from LayoutTests/platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation-expected.txt.
* platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed update of fast/js/function-constructor-this-value.html expectations on...
pdr@google.com [Fri, 31 Aug 2012 22:56:22 +0000 (22:56 +0000)]
Unreviewed update of fast/js/function-constructor-this-value.html expectations on Chromium
https://bugs.webkit.org/show_bug.cgi?id=95617

This test was added in r127323 but fails on Chromium ports.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Assert on ChromeClientGtk::scroll with delta (0, -1).
commit-queue@webkit.org [Fri, 31 Aug 2012 22:51:58 +0000 (22:51 +0000)]
[GTK] Assert on ChromeClientGtk::scroll with delta (0, -1).
https://bugs.webkit.org/show_bug.cgi?id=95590

Change the assert to avoid hitting when the delta does not have any
value > 0.

Patch by José Dapena Paz <jdapena@igalia.com> on 2012-08-31
Reviewed by Martin Robinson.

* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::scroll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIntroduce new CSS property for clip-path
krit@webkit.org [Fri, 31 Aug 2012 22:29:48 +0000 (22:29 +0000)]
Introduce new CSS property for clip-path
https://bugs.webkit.org/show_bug.cgi?id=95474

Reviewed by Tim Horton.

Source/WebCore:

This path introduces the new, prefixed CSS property 'clip-path' from the
CSS Masking specification. In a first step the property just accepts
'none' and the the basic shapes from CSS Exclusion. Later it will also be
possible to reference SVG 'clipPath' elements - like Firefox already does.
To enable the parsing of the shapes, the exclusion compiler flags
around the shape parser were removed.

http://dvcs.w3.org/hg/FXTF/raw-file/tip/masking/index.html

Test: fast/masking/parsing-clip-path-shape.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Return CSSValue for CSSPropertyWebkitClipPath.
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue): Add CSSPropertyWebkitClipPath.
(WebCore::CSSParser::parseBasicShape): Modify parser function to accept CSSPropertyWebkitClipPath as well.
* css/CSSParser.h:
* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
* css/CSSPropertyNames.in: Added property name -webkit-clip-path.
* css/StyleBuilder.cpp:
(ApplyPropertyClipPath): New property applier just for -webkit-clip-path.
(WebCore::ApplyPropertyClipPath::setValue):
(WebCore::ApplyPropertyClipPath::applyValue):
(WebCore::ApplyPropertyClipPath::createHandler):
(WebCore::StyleBuilder::StyleBuilder):
* rendering/style/RenderStyle.cpp: Repaint if there is a difference between two BasicShapes.
(WebCore::RenderStyle::diff):
* rendering/style/RenderStyle.h:
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
(WebCore::StyleRareNonInheritedData::reportMemoryUsage):
* rendering/style/StyleRareNonInheritedData.h: Add new member variable for clip shape.
(StyleRareNonInheritedData):

LayoutTests:

Test parsing behavior of basic shapes on new introduced '-webkit-clip-path' CSS property.

* fast/masking/parsing-clip-path-shape-expected.txt: Added.
* fast/masking/parsing-clip-path-shape.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127327 268f45cc-cd09-0410-ab3c-d52691b4dbfc