WebKit-https.git
10 years ago2009-11-03 Yuzo Fujishima <yuzo@google.com>
ukai@chromium.org [Wed, 4 Nov 2009 07:50:08 +0000 (07:50 +0000)]
2009-11-03  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by David Levin.

        Start/Stop Web Socket and Web Socket Secure servers for layout tests.
        https://bugs.webkit.org/show_bug.cgi?id=27491

        The test path determination logic is changed to handle websocket and websocket/ssl cases.
        The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.

        Functions to start or stop Web Socket servers are added.

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed build fix for WebInspector with Qt build.
hausmann@webkit.org [Wed, 4 Nov 2009 06:09:04 +0000 (06:09 +0000)]
Unreviewed build fix for WebInspector with Qt build.

Patch by Simon Hausmann <hausmann@webkit.org> on 2009-11-03
Simply re-generate the Qt resource file by running
WebKitTools/Scripts/generate-qt-inspector-resource

* inspector/front-end/WebKit.qrc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago(on IRC)
rolandsteiner@chromium.org [Wed, 4 Nov 2009 05:52:39 +0000 (05:52 +0000)]
(on IRC)

Reviewed by Mark Rowe.

add ruby layout tests to the Skipped list on mac, since they somehow cause
http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html to fail.

no new tests.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSet the MIME type for all PNG files in this directory.
darin@apple.com [Wed, 4 Nov 2009 04:29:09 +0000 (04:29 +0000)]
Set the MIME type for all PNG files in this directory.

WebKitSite:

Patch by Darin Adler <darin@apple.com> on 2009-11-03
* blog-files/3d-transforms/mighty-cubes.png: Added property svn:mime-type.
* blog-files/3d-transforms/poster-circle.png: Added property svn:mime-type.
* blog-files/InspectorDatabaseBrowser.png: Modified property svn:mime-type.
* blog-files/acid3-100.png: Modified property svn:mime-type.
* blog-files/acid3-full-rendering-pass.png: Modified property svn:mime-type.
* blog-files/acid3-rendering-reference.png: Modified property svn:mime-type.
* blog-files/acid3-screenshot.png: Modified property svn:mime-type.
* blog-files/acid3-timing-screenshot.png: Modified property svn:mime-type.
* blog-files/acid3-timing.png: Modified property svn:mime-type.
* blog-files/bounce.png: Added property svn:mime-type.
* blog-files/gebcnwebkitonly.png: Modified property svn:mime-type.
* blog-files/inspector-closure-scope.png: Added property svn:mime-type.
* blog-files/inspector-console-autocomplete.png: Added property svn:mime-type.
* blog-files/inspector-databases-panel-query-view.png: Added property svn:mime-type.
* blog-files/inspector-databases-panel.png: Added property svn:mime-type.
* blog-files/inspector-disabling-properties.png: Added property svn:mime-type.
* blog-files/inspector-elements-panel.png: Added property svn:mime-type.
* blog-files/inspector-event-scope.png: Added property svn:mime-type.
* blog-files/inspector-profiles-panel.png: Added property svn:mime-type.
* blog-files/inspector-resources-panel.png: Added property svn:mime-type.
* blog-files/inspector-scripts-panel.png: Added property svn:mime-type.
* blog-files/inspector-searching-elements.png: Added property svn:mime-type.
* blog-files/inspector-searching-profiles.png: Added property svn:mime-type.
* blog-files/inspector-status-bar-with-errors.png: Added property svn:mime-type.
* blog-files/inspector-toolbar.png: Added property svn:mime-type.
* blog-files/inspector-with-scope.png: Added property svn:mime-type.
* blog-files/inspector/breakpoints.png: Added property svn:mime-type.
* blog-files/inspector/colors.png: Added property svn:mime-type.
* blog-files/inspector/cookies.png: Added property svn:mime-type.
* blog-files/inspector/css_selectors.png: Added property svn:mime-type.
* blog-files/inspector/css_syntax_highlight.png: Added property svn:mime-type.
* blog-files/inspector/dom_storage.png: Added property svn:mime-type.
* blog-files/inspector/edit_attributes.png: Added property svn:mime-type.
* blog-files/inspector/enable.png: Added property svn:mime-type.
* blog-files/inspector/event_listeners.png: Added property svn:mime-type.
* blog-files/inspector/form_data.png: Added property svn:mime-type.
* blog-files/inspector/inline_highlight.png: Added property svn:mime-type.
* blog-files/inspector/inorder.png: Added property svn:mime-type.
* blog-files/inspector/inspect_inspector.png: Added property svn:mime-type.
* blog-files/inspector/inspect_inspector_small.png: Added property svn:mime-type.
* blog-files/inspector/load_lines.png: Added property svn:mime-type.
* blog-files/inspector/nodelist.png: Added property svn:mime-type.
* blog-files/inspector/scope_bar.png: Added property svn:mime-type.
* blog-files/inspector/watched_expression.png: Added property svn:mime-type.
* blog-files/kate-circle.png: Modified property svn:mime-type.
* blog-files/kate-gradient-rounded.png: Modified property svn:mime-type.
* blog-files/kate-gradient.png: Modified property svn:mime-type.
* blog-files/kate-reflected.png: Modified property svn:mime-type.
* blog-files/kate-vignette-mask.png: Modified property svn:mime-type.
* blog-files/kate.png: Modified property svn:mime-type.
* blog-files/leaves/images/apple-touch-icon.png: Added property svn:mime-type.
* blog-files/leaves/images/realLeaf1.png: Added property svn:mime-type.
* blog-files/leaves/images/realLeaf2.png: Added property svn:mime-type.
* blog-files/leaves/images/realLeaf3.png: Added property svn:mime-type.
* blog-files/leaves/images/realLeaf4.png: Added property svn:mime-type.
* blog-files/leaves/images/textBackground.png: Added property svn:mime-type.
* blog-files/maskspeedracer.png: Modified property svn:mime-type.
* blog-files/pulse.png: Added property svn:mime-type.
* blog-files/scrollbarpicture.png: Modified property svn:mime-type.
* blog-files/sfx-perf.png: Modified property svn:mime-type.
* blog-files/squirrelfish-webkit-graph.png: Modified property svn:mime-type.
* blog-files/squirrelfish.png: Modified property svn:mime-type.
* blog-files/vignette-mask.png: Modified property svn:mime-type.
* blog-files/webgl/resources/mars500x250.png: Modified property svn:mime-type.
* blog-files/wsj-nopreload.png: Modified property svn:mime-type.
* blog-files/wsj-preload.png: Modified property svn:mime-type.
* blog-files/wsj-vs.png: Modified property svn:mime-type.
* blog/wp-admin/images/align-center.png: Added property svn:mime-type.
* blog/wp-admin/images/align-left.png: Added property svn:mime-type.
* blog/wp-admin/images/align-none.png: Added property svn:mime-type.
* blog/wp-admin/images/align-right.png: Added property svn:mime-type.
* blog/wp-admin/images/archive-link.png: Added property svn:mime-type.
* blog/wp-admin/images/blue-grad.png: Added property svn:mime-type.
* blog/wp-admin/images/button-grad-active-vs.png: Added property svn:mime-type.
* blog/wp-admin/images/button-grad-active.png: Added property svn:mime-type.
* blog/wp-admin/images/button-grad-vs.png: Added property svn:mime-type.
* blog/wp-admin/images/button-grad.png: Added property svn:mime-type.
* blog/wp-admin/images/comment-grey-bubble.png: Added property svn:mime-type.
* blog/wp-admin/images/fade-butt.png: Modified property svn:mime-type.
* blog/wp-admin/images/fav-top.png: Added property svn:mime-type.
* blog/wp-admin/images/fav-vs.png: Added property svn:mime-type.
* blog/wp-admin/images/fav.png: Added property svn:mime-type.
* blog/wp-admin/images/generic.png: Added property svn:mime-type.
* blog/wp-admin/images/gray-grad.png: Added property svn:mime-type.
* blog/wp-admin/images/icons32-vs.png: Added property svn:mime-type.
* blog/wp-admin/images/icons32.png: Added property svn:mime-type.
* blog/wp-admin/images/list-vs.png: Added property svn:mime-type.
* blog/wp-admin/images/list.png: Added property svn:mime-type.
* blog/wp-admin/images/logo-ghost.png: Added property svn:mime-type.
* blog/wp-admin/images/marker.png: Added property svn:mime-type.
* blog/wp-admin/images/mask.png: Added property svn:mime-type.
* blog/wp-admin/images/menu-vs.png: Added property svn:mime-type.
* blog/wp-admin/images/menu.png: Added property svn:mime-type.
* blog/wp-admin/images/no.png: Added property svn:mime-type.
* blog/wp-admin/images/se.png: Added property svn:mime-type.
* blog/wp-admin/images/wheel.png: Added property svn:mime-type.
* blog/wp-admin/images/white-grad-active.png: Added property svn:mime-type.
* blog/wp-admin/images/white-grad.png: Added property svn:mime-type.
* blog/wp-admin/images/wordpress-logo.png: Modified property svn:mime-type.
* blog/wp-admin/images/yes.png: Added property svn:mime-type.
* blog/wp-content/Picture9.png: Modified property svn:mime-type.
* blog/wp-content/chucknorris.png: Modified property svn:mime-type.
* blog/wp-content/databaseexample.png: Modified property svn:mime-type.
* blog/wp-content/drosera.png: Modified property svn:mime-type.
* blog/wp-content/hitlist.png: Modified property svn:mime-type.
* blog/wp-content/rotate.png: Modified property svn:mime-type.
* blog/wp-content/svgtext.png: Modified property svn:mime-type.
* blog/wp-content/svgtextmini.png: Modified property svn:mime-type.
* blog/wp-content/svgtextmini_01.png: Modified property svn:mime-type.
* blog/wp-content/themes/classic/screenshot.png: Modified property svn:mime-type.
* blog/wp-content/themes/default/screenshot.png: Modified property svn:mime-type.
* blog/wp-content/uploads/2007/06/newinspector.png: Modified property svn:mime-type.
* blog/wp-content/webInspector.png: Modified property svn:mime-type.
* blog/wp-includes/images/crystal/archive.png: Added property svn:mime-type.
* blog/wp-includes/images/crystal/audio.png: Added property svn:mime-type.
* blog/wp-includes/images/crystal/code.png: Added property svn:mime-type.
* blog/wp-includes/images/crystal/default.png: Added property svn:mime-type.
* blog/wp-includes/images/crystal/document.png: Added property svn:mime-type.
* blog/wp-includes/images/crystal/interactive.png: Added property svn:mime-type.
* blog/wp-includes/images/crystal/spreadsheet.png: Added property svn:mime-type.
* blog/wp-includes/images/crystal/text.png: Added property svn:mime-type.
* blog/wp-includes/images/crystal/video.png: Added property svn:mime-type.
* blog/wp-includes/images/rss.png: Modified property svn:mime-type.
* blog/wp-includes/images/upload.png: Added property svn:mime-type.
* blog/wp-includes/images/wlw/wp-comments.png: Added property svn:mime-type.
* blog/wp-includes/images/wlw/wp-icon.png: Added property svn:mime-type.
* blog/wp-includes/images/wlw/wp-watermark.png: Added property svn:mime-type.
* blog/wp-includes/js/codepress/images/line-numbers.png: Added property svn:mime-type.
* blog/wp-includes/js/thickbox/macFFBgHack.png: Added property svn:mime-type.
* blog/wp-includes/js/thickbox/tb-close.png: Added property svn:mime-type.
* blog/wp-includes/js/tinymce/plugins/wpeditimage/img/delete.png: Added property svn:mime-type.
* blog/wp-includes/js/tinymce/plugins/wpeditimage/img/image.png: Added property svn:mime-type.
* blog/wp-includes/js/tinymce/plugins/wpgallery/img/delete.png: Added property svn:mime-type.
* blog/wp-includes/js/tinymce/plugins/wpgallery/img/edit.png: Added property svn:mime-type.
* blog/wp-includes/js/tinymce/plugins/wpgallery/img/gallery.png: Added property svn:mime-type.
* blog/wp-includes/js/tinymce/themes/advanced/img/gotmoxie.png: Added property svn:mime-type.
* blog/wp-includes/js/tinymce/themes/advanced/img/sflogo.png: Added property svn:mime-type.
* blog/wp-includes/js/tinymce/themes/advanced/skins/default/img/buttons.png: Added property svn:mime-type.
* blog/wp-includes/js/tinymce/themes/advanced/skins/o2k7/img/button_bg.png: Added property svn:mime-type.
* blog/wp-includes/js/tinymce/themes/advanced/skins/o2k7/img/button_bg_black.png: Added property svn:mime-type.
* blog/wp-includes/js/tinymce/themes/advanced/skins/o2k7/img/button_bg_silver.png: Added property svn:mime-type.
* blog/wp-includes/js/tinymce/themes/advanced/skins/wp_theme/img/butt2.png: Added property svn:mime-type.
* blog/wp-includes/js/tinymce/themes/advanced/skins/wp_theme/img/button_bg.png: Added property svn:mime-type.
* demos/calendar/Images/AirPort4.png: Modified property svn:mime-type.
* demos/calendar/Images/AirPortError.png: Modified property svn:mime-type.
* demos/calendar/Images/disclosureTriangleSmallDown.png: Modified property svn:mime-type.
* demos/calendar/Images/disclosureTriangleSmallRight.png: Modified property svn:mime-type.
* demos/calendar/Images/statusbarBackground.png: Modified property svn:mime-type.
* demos/calendar/Images/statusbarResizerVertical.png: Modified property svn:mime-type.
* demos/editingToolbar/FancyToolbarImages/button.png: Modified property svn:mime-type.
* demos/editingToolbar/FancyToolbarImages/buttonLeft.png: Modified property svn:mime-type.
* demos/editingToolbar/FancyToolbarImages/buttonMiddle.png: Modified property svn:mime-type.
* demos/editingToolbar/FancyToolbarImages/buttonPressed.png: Modified property svn:mime-type.
* demos/editingToolbar/FancyToolbarImages/buttonPressedLeft.png: Modified property svn:mime-type.
* demos/editingToolbar/FancyToolbarImages/buttonPressedMiddle.png: Modified property svn:mime-type.
* demos/editingToolbar/FancyToolbarImages/buttonPressedRight.png: Modified property svn:mime-type.
* demos/editingToolbar/FancyToolbarImages/buttonRight.png: Modified property svn:mime-type.
* demos/editingToolbar/FancyToolbarImages/camera.png: Modified property svn:mime-type.
* demos/editingToolbar/FancyToolbarImages/link.png: Modified property svn:mime-type.
* demos/editingToolbar/FancyToolbarImages/textAlign.png: Modified property svn:mime-type.
* demos/editingToolbar/FancyToolbarImages/toolbarOutline.png: Modified property svn:mime-type.
* demos/editingToolbar/FancyToolbarImages/toolbarOutlineBottom.png: Modified property svn:mime-type.
* demos/editingToolbar/FancyToolbarImages/toolbarOutlineBottomLeft.png: Modified property svn:mime-type.
* demos/editingToolbar/FancyToolbarImages/toolbarOutlineBottomRight.png: Modified property svn:mime-type.
* demos/editingToolbar/FancyToolbarImages/toolbarOutlineLeft.png: Modified property svn:mime-type.
* demos/editingToolbar/FancyToolbarImages/toolbarOutlineRight.png: Modified property svn:mime-type.
* demos/editingToolbar/FancyToolbarImages/toolbarOutlineTop.png: Modified property svn:mime-type.
* demos/editingToolbar/FancyToolbarImages/toolbarOutlineTopLeft.png: Modified property svn:mime-type.
* demos/editingToolbar/FancyToolbarImages/toolbarOutlineTopRight.png: Modified property svn:mime-type.
* demos/editingToolbar/images/safari.png: Modified property svn:mime-type.
* demos/sticky-notes/deleteButton.png: Added property svn:mime-type.
* demos/sticky-notes/deleteButtonPressed.png: Added property svn:mime-type.
* demos/transitions-and-transforms/Horsehead.png: Modified property svn:mime-type.
* demos/transitions-and-transforms/Spaces.png: Modified property svn:mime-type.
* demos/transitions-and-transforms/Stacks.png: Modified property svn:mime-type.
* images/DroseraPic.png: Modified property svn:mime-type.
* misc/drosera/drosera.png: Modified property svn:mime-type.
* perf/slickspeed/logo.png: Modified property svn:mime-type.

WebKitSite/specs/CSSVisualEffects:

Patch by Darin Adler <darin@apple.com> on 2009-11-03
* css3-2d-transforms/compound_transform.png: Modified property svn:mime-type.
* css3-2d-transforms/transform1.png: Modified property svn:mime-type.
* css3-2d-transforms/transform2.png: Modified property svn:mime-type.
* css3-3d-transforms/compound_transform.png: Modified property svn:mime-type.
* css3-3d-transforms/transform1.png: Modified property svn:mime-type.
* css3-3d-transforms/transform2.png: Modified property svn:mime-type.
* css3-animations/animation1.png: Modified property svn:mime-type.
* css3-animations/sandwich.png: Modified property svn:mime-type.
* css3-transitions/TimingFunction.png: Modified property svn:mime-type.
* css3-transitions/transition1.png: Modified property svn:mime-type.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: [Qt] Handle fonts like the other ports
hausmann@webkit.org [Wed, 4 Nov 2009 03:37:32 +0000 (03:37 +0000)]
WebCore: [Qt] Handle fonts like the other ports

Patch by Benjamin Poulain <benjamin.poulain@nokia.com> on 2009-11-02
Reviewed by Simon Hausmann.

Remove FontFallbackListQt and rely on the common FontFallbackList
to handle the fonts. FontCache and FontPlatformData have been
updated to work with the common FontFallbackList.

In the previous implementation, FontPlatformDataCacheKey
was a clone of FontPlatformData with the hashing
capabilities added in order to use it as a key in the cache's
hashmap. FontPlatformData has been modified to handle the hashing
function directly so the data are not copied twice in memory.

FontFallbackList::fontDataAt() from FontFallbackListQt was a copy of
code from FontCache::getFontData() and FontFallbackList::fontDataAt().
The behavior is similar except currFamily->family().length() was
not tested and the fallback fonts selector were not used.

https://bugs.webkit.org/show_bug.cgi?id=29856

Test: svg/text/text-font-invalid.html

* WebCore.pro:
* platform/graphics/qt/FontCacheQt.cpp:
(WebCore::FontCache::platformInit):
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
(WebCore::FontCache::getTraitsInFamily):
(WebCore::FontCache::createFontPlatformData):
* platform/graphics/qt/FontFallbackListQt.cpp:
Removed. We now use the implementation from FontFallbackList.cpp
* platform/graphics/qt/FontPlatformData.h:
Add hashing capabilities to be able to use the data with the FontCache.
This was previously done in FontCacheQt.cpp
(WebCore::FontPlatformData::FontPlatformData):
Added a boolean to identify deleted value in the hash table.
(WebCore::FontPlatformData::isHashTableDeletedValue):
(WebCore::FontPlatformData::hash):
(WebCore::FontPlatformData::operator==):
* platform/graphics/qt/FontPlatformDataQt.cpp:
(WebCore::FontPlatformData::FontPlatformData):

LayoutTests: Add a new test to reproduce 29856. The bug only happen
when the SVG file is used as an image.
https://bugs.webkit.org/show_bug.cgi?id=29856

Patch by Benjamin Poulain <benjamin.poulain@nokia.com> on 2009-11-02
Reviewed by Simon Hausmann.

* svg/text/text-font-invalid-expected.txt: Added.
* svg/text/resources/text-font-invalid.svg: Added.
* svg/text/text-font-invalid.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBug 28420 - Implement HTML5 <ruby> rendering
rolandsteiner@chromium.org [Wed, 4 Nov 2009 03:26:29 +0000 (03:26 +0000)]
Bug 28420 -  Implement HTML5 <ruby> rendering
(https://bugs.webkit.org/show_bug.cgi?id=28420)

Reviewed by Dave Hyatt.

First rudimentary implementation of HTML5 ruby rendering support - layout tests.

New layout tests: basic rendering:
* fast/ruby/ruby-empty-rt.html: Added.
* fast/ruby/ruby-length.html: Added.
* fast/ruby/ruby-run-break.html: Added.
* fast/ruby/ruby-runs-spans.html: Added.
* fast/ruby/ruby-runs.html: Added.
* fast/ruby/ruby-simple-rp.html: Added.
* fast/ruby/ruby-simple.html: Added.
* fast/ruby/ruby-trailing.html: Added.

New layout tests: DOM manipulation within <ruby>
* fast/ruby/rubyDOM-insert-rt.html: Added.
* fast/ruby/rubyDOM-insert-text1.html: Added.
* fast/ruby/rubyDOM-insert-text2.html: Added.
* fast/ruby/rubyDOM-insert-text3.html: Added.
* fast/ruby/rubyDOM-remove-rt1.html: Added.
* fast/ruby/rubyDOM-remove-rt2.html: Added.
* fast/ruby/rubyDOM-remove-text1.html: Added.
* fast/ruby/rubyDOM-remove-text2.html: Added.

New layout tests results:
* platform/mac/fast/ruby: Added.
* platform/mac/fast/ruby/ruby-empty-rt-expected.checksum: Added.
* platform/mac/fast/ruby/ruby-empty-rt-expected.png: Added.
* platform/mac/fast/ruby/ruby-empty-rt-expected.txt: Added.
* platform/mac/fast/ruby/ruby-length-expected.checksum: Added.
* platform/mac/fast/ruby/ruby-length-expected.png: Added.
* platform/mac/fast/ruby/ruby-length-expected.txt: Added.
* platform/mac/fast/ruby/ruby-run-break-expected.checksum: Added.
* platform/mac/fast/ruby/ruby-run-break-expected.png: Added.
* platform/mac/fast/ruby/ruby-run-break-expected.txt: Added.
* platform/mac/fast/ruby/ruby-runs-expected.checksum: Added.
* platform/mac/fast/ruby/ruby-runs-expected.png: Added.
* platform/mac/fast/ruby/ruby-runs-expected.txt: Added.
* platform/mac/fast/ruby/ruby-runs-spans-expected.checksum: Added.
* platform/mac/fast/ruby/ruby-runs-spans-expected.png: Added.
* platform/mac/fast/ruby/ruby-runs-spans-expected.txt: Added.
* platform/mac/fast/ruby/ruby-simple-expected.checksum: Added.
* platform/mac/fast/ruby/ruby-simple-expected.png: Added.
* platform/mac/fast/ruby/ruby-simple-expected.txt: Added.
* platform/mac/fast/ruby/ruby-simple-rp-expected.checksum: Added.
* platform/mac/fast/ruby/ruby-simple-rp-expected.png: Added.
* platform/mac/fast/ruby/ruby-simple-rp-expected.txt: Added.
* platform/mac/fast/ruby/ruby-trailing-expected.checksum: Added.
* platform/mac/fast/ruby/ruby-trailing-expected.png: Added.
* platform/mac/fast/ruby/ruby-trailing-expected.txt: Added.
* platform/mac/fast/ruby/rubyDOM-insert-rt-expected.checksum: Added.
* platform/mac/fast/ruby/rubyDOM-insert-rt-expected.png: Added.
* platform/mac/fast/ruby/rubyDOM-insert-rt-expected.txt: Added.
* platform/mac/fast/ruby/rubyDOM-insert-text1-expected.checksum: Added.
* platform/mac/fast/ruby/rubyDOM-insert-text1-expected.png: Added.
* platform/mac/fast/ruby/rubyDOM-insert-text1-expected.txt: Added.
* platform/mac/fast/ruby/rubyDOM-insert-text2-expected.checksum: Added.
* platform/mac/fast/ruby/rubyDOM-insert-text2-expected.png: Added.
* platform/mac/fast/ruby/rubyDOM-insert-text2-expected.txt: Added.
* platform/mac/fast/ruby/rubyDOM-insert-text3-expected.checksum: Added.
* platform/mac/fast/ruby/rubyDOM-insert-text3-expected.png: Added.
* platform/mac/fast/ruby/rubyDOM-insert-text3-expected.txt: Added.
* platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.checksum: Added.
* platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.png: Added.
* platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.txt: Added.
* platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.checksum: Added.
* platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.png: Added.
* platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.txt: Added.
* platform/mac/fast/ruby/rubyDOM-remove-text1-expected.checksum: Added.
* platform/mac/fast/ruby/rubyDOM-remove-text1-expected.png: Added.
* platform/mac/fast/ruby/rubyDOM-remove-text1-expected.txt: Added.
* platform/mac/fast/ruby/rubyDOM-remove-text2-expected.checksum: Added.
* platform/mac/fast/ruby/rubyDOM-remove-text2-expected.png: Added.
* platform/mac/fast/ruby/rubyDOM-remove-text2-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-11-03 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Wed, 4 Nov 2009 02:09:49 +0000 (02:09 +0000)]
2009-11-03  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Timothy Hatcher.

        Adding images for an upcoming blog post.

        * blog-files/inspector/breakpoints.png: Added.
        * blog-files/inspector/colors.png: Added.
        * blog-files/inspector/cookies.png: Added.
        * blog-files/inspector/css_selectors.png: Added.
        * blog-files/inspector/css_syntax_highlight.png: Added.
        * blog-files/inspector/dom_storage.png: Added.
        * blog-files/inspector/edit_attributes.png: Added.
        * blog-files/inspector/enable.png: Added.
        * blog-files/inspector/event_listeners.png: Added.
        * blog-files/inspector/form_data.png: Added.
        * blog-files/inspector/inline_highlight.png: Added.
        * blog-files/inspector/inorder.png: Added.
        * blog-files/inspector/inspect_inspector.png: Added.
        * blog-files/inspector/inspect_inspector_small.png: Added.
        * blog-files/inspector/load_lines.png: Added.
        * blog-files/inspector/nodelist.png: Added.
        * blog-files/inspector/scope_bar.png: Added.
        * blog-files/inspector/watched_expression.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoLeopard build fix
mitz@apple.com [Wed, 4 Nov 2009 01:34:05 +0000 (01:34 +0000)]
Leopard build fix

* platform/network/mac/AuthenticationMac.mm:
(WebCore::mac):
(WebCore::core):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-11-03 Kenneth Russell <kbr@google.com>
oliver@apple.com [Wed, 4 Nov 2009 01:25:52 +0000 (01:25 +0000)]
2009-11-03  Kenneth Russell  <kbr@google.com>

        Reviewed by Oliver Hunt.

        Add overridePreference call to all WebGL layout tests
        https://bugs.webkit.org/show_bug.cgi?id=31088

        * fast/canvas/webgl/array-unit-tests.html:
        * fast/canvas/webgl/getActiveTest.html:
        * fast/canvas/webgl/gl-get-calls.html:
        * fast/canvas/webgl/incorrect-context-object-behaviour.html:
        * fast/canvas/webgl/null-object-behaviour.html:
        * fast/canvas/webgl/resources/shader-test.js: Removed.
        * fast/canvas/webgl/resources/webgl-test.js: Copied from LayoutTests/fast/canvas/webgl/resources/shader-test.js.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebActionModifierFlagsKey should return an unsigned, because
bweinstein@apple.com [Wed, 4 Nov 2009 01:11:31 +0000 (01:11 +0000)]
WebActionModifierFlagsKey should return an unsigned, because
flags imply a bitmask, and that is what other classes expect from
it.

Reviewed by Steve Falkenburg.

* WebActionPropertyBag.cpp:
(WebActionPropertyBag::Read):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix an assertion failure in core(NSURLProtectionSpace *) by handling NTLM
mitz@apple.com [Wed, 4 Nov 2009 01:02:59 +0000 (01:02 +0000)]
Fix an assertion failure in core(NSURLProtectionSpace *) by handling NTLM
authentication in AuthenticationMac

Reviewed by Alexey Proskuryakov.

* platform/network/mac/AuthenticationMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-11-03 Eric Z. Ayers <zundel@google.com>
eric@webkit.org [Wed, 4 Nov 2009 00:00:17 +0000 (00:00 +0000)]
2009-11-03  Eric Z. Ayers  <zundel@google.com>

        Reviewed by Timothy Hatcher.

        Adds a test for turning on the timeline profiler.  This caused
        a crash because profiling was enabled in the middle of processing
        an event.

        https://bugs.webkit.org/show_bug.cgi?id=31080

        * inspector/timeline-trivial-expected.txt: Added.
        * inspector/timeline-trivial.html: Added.
2009-11-03  Eric Z. Ayers  <zundel@google.com>

        Reviewed by Timothy Hatcher.

        Fixes a problem where the timeline instrumentation crashes if
        timeline profiling is enabled or disabled in the middle of an
        event dispatch.

        https://bugs.webkit.org/show_bug.cgi?id=31080

        Test: inspector/timeline-trivial.html

        * bindings/js/ScriptController.cpp:
        (WebCore::ScriptController::evaluateInWorld):
        (WebCore::ScriptController::processingUserGestureEvent):
        * inspector/InspectorTimelineAgent.cpp:
        (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
        * page/DOMTimer.cpp:
        (WebCore::DOMTimer::fired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-11-03 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 3 Nov 2009 23:34:08 +0000 (23:34 +0000)]
2009-11-03  Eric Seidel  <eric@webkit.org>

        No review, just changing wording of log message.

        Change log string to say "failed" instead of "rejected"
        when a commit fails due to an out of date checkout.
        This makes grepping the commit-queue log for rejected patches easier.

        * Scripts/bugzilla-tool:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-11-03 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 3 Nov 2009 22:14:51 +0000 (22:14 +0000)]
2009-11-03  Eric Seidel  <eric@webkit.org>

        No review, adding commonly known committers missing from the file.

        * Scripts/modules/committers.py: Add committers found by looking at SVN records.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAllow a frame to go back to copy-on-scroll when it ceases being overlapped
mitz@apple.com [Tue, 3 Nov 2009 22:07:32 +0000 (22:07 +0000)]
Allow a frame to go back to copy-on-scroll when it ceases being overlapped

Reviewed by Dave Hyatt.

The code was not testing slow-scrolling frames for overlappedness, thinking the answer
would not matter. That is not the case if the only reason for the slow-scrolling is
being overlapped.

* page/FrameView.cpp:
(WebCore::FrameView::useSlowRepaintsIfNotOverlapped): Added. Returns whether there is any
reason besides being overlapped that the frame would need to fully repaint on scroll.
* page/FrameView.h:
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::paint): Use useSlowRepaintsIfNotOverlapped().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-11-03 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 3 Nov 2009 22:04:54 +0000 (22:04 +0000)]
2009-11-03  Eric Seidel  <eric@webkit.org>

        No review, just sort-order cleanup.

        * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTouch WebKit.idl to try and fix Windows nightlies.
bweinstein@apple.com [Tue, 3 Nov 2009 22:04:13 +0000 (22:04 +0000)]
Touch WebKit.idl to try and fix Windows nightlies.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNot reviewed, Qt build fix.
dimich@chromium.org [Tue, 3 Nov 2009 21:39:59 +0000 (21:39 +0000)]
Not reviewed, Qt build fix.

Need to use right capitalization for include file.

* page/Navigator.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-11-03 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 3 Nov 2009 21:34:47 +0000 (21:34 +0000)]
2009-11-03  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Migrate from top bar filters to check boxes in Timeline.

        https://bugs.webkit.org/show_bug.cgi?id=31081

        * inspector/front-end/AbstractTimelinePanel.js:
        (WebInspector.AbstractTimelinePanel.prototype.showCategory):
        (WebInspector.AbstractTimelinePanel.prototype.hideCategory):
        (WebInspector.AbstractTimelinePanel.prototype.filter):
        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel):
        (WebInspector.TimelineCategoryTreeElement.prototype.onattach):
        (WebInspector.TimelineCategoryTreeElement.prototype._onCheckboxClick):
        (WebInspector.TimelineCategoryGraph.prototype.clearChunks):
        (WebInspector.TimelineCategoryGraph.prototype.set dimmed):
        * inspector/front-end/inspector.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-11-03 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 3 Nov 2009 21:30:51 +0000 (21:30 +0000)]
2009-11-03  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: clear overview on Clear action and panel reset.

        https://bugs.webkit.org/show_bug.cgi?id=31078

        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel.prototype._getRecordDetails):
        (WebInspector.TimelinePanel.prototype.reset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-11-03 Yaar Schnitman <yaar@chromium.org>
eric@webkit.org [Tue, 3 Nov 2009 21:24:45 +0000 (21:24 +0000)]
2009-11-03  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Dimitri Glazkov.

        Imported action and rules python files that WebCore.gyp depends on.
        These files used to live in chromium.org and deal mostly with auto-generation
        of code by wrapping existing webkit perl scripts.

        https://bugs.webkit.org/show_bug.cgi?id=31071

        * WebCore.gyp/WebCore.gyp: Fixed paths in actions and rules.
        * WebCore.gyp/scripts/action_csspropertynames.py: Added.
        * WebCore.gyp/scripts/action_cssvaluekeywords.py: Added.
        * WebCore.gyp/scripts/action_makenames.py: Added.
        * WebCore.gyp/scripts/action_maketokenizer.py: Added.
        * WebCore.gyp/scripts/action_useragentstylesheets.py: Added.
        * WebCore.gyp/scripts/rule_binding.py: Added.
        * WebCore.gyp/scripts/rule_bison.py: Added.
        * WebCore.gyp/scripts/rule_gperf.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Implement window.navigator.registerProtocolHandler in webkit,
dimich@chromium.org [Tue, 3 Nov 2009 21:12:24 +0000 (21:12 +0000)]
WebCore: Implement window.navigator.registerProtocolHandler in webkit,
https://bugs.webkit.org/b/29651

Patch by Bradley Green <brg@chromium.org> on 2009-11-03
Reviewed by Dmitry Titov.

Also implemented its sister API window.navigator.registerContentHandler.

These methods are as described in the HTML5 specification which can be
found here,
http://dev.w3.org/html5/spec/Overview.html#dom-navigator-registerprotocolhandler
http://dev.w3.org/html5/spec/Overview.html#dom-navigator-registercontenthandler

As specified in the document, the behavior of the browser is determined
by the current registered handler.  The state of a registered handler
can change at any time, with the user clearing a registered handler,
registering a different page as handler, or deferring the hander to the
OS.  If webkit was to track the state of the currently registered
handlers, it would need more APIs and complexity to keep in sync with
user actions reported to webkit from the UA.  For simplicity, the state
of protocol handlers should be kept isolated from webkit and webkit only
notifies the UA that a page has made the call.  The UA is then
responsible for correctly handling the registerProtocolHandler call and
the redirects which result from registration.

We do however follow the specification in insuring that the reserved
schemes and mimeTypes are not passed to the UA as custom handler
registration tests.  We also insure that the "%s" token is present as
required by the specification.

Updated test expectations for window.clientInformation and navigator
objects.

Tests: fast/dom/registerContentHandler.html
       fast/dom/registerProtocolHandler.html

* page/Chrome.cpp:
(WebCore::Chrome::registerProtocolHandler):
(WebCore::Chrome::registerContentHandler):
* page/Chrome.h:
* page/ChromeClient.h:
(WebCore::ChromeClient::registerProtocolHandler):
(WebCore::ChromeClient::registerContentHandler):
* page/Navigator.cpp:
(WebCore::verifyCustomHandlerURL):
(WebCore::verifyProtocolHandlerScheme):
(WebCore::Navigator::registerProtocolHandler):
(WebCore::verifyProtocolHandlerMimeType):
(WebCore::Navigator::registerContentHandler):
* page/Navigator.h:
* page/Navigator.idl:

LayoutTests: Updating test expectations for implementation of
window.navigator.registerProtocolHandler and
window.navigator.registerContentHandler.

Patch by Bradley Green <brg@chromium.org> on 2009-11-03
Reviewed by Dmitry Titov.

There is a default implimentation for these APIs, hence all platforms
with the navigator-detached-no-crash-expect and
window-properties-expected tests needed to be updated.  While
isolatedWorlds has a window-properties-expected test, it has no window
object and hence does not need to be updaetd.

We add two fast/dom tests to insure that the proper exceptions are
thrown when bad syntax or security violations are made by calling the
methods.

* fast/dom/Window/window-properties-expected.txt:
* fast/dom/navigator-detached-no-crash-expected.txt:
* fast/dom/navigator-detached-no-crash.html:
* fast/dom/registerContentHandler-expected.txt: Added.
* fast/dom/registerContentHandler.html: Added.
* fast/dom/registerProtocolHandler-expected.txt: Added.
* fast/dom/registerProtocolHandler.html: Added.
* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/gtk/fast/dom/navigator-detached-no-crash-expected.txt:
* platform/mac-leopard/fast/dom/navigator-detached-no-crash-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=31079 - Remove #include "Page.h" from Document.h
beidson@apple.com [Tue, 3 Nov 2009 21:06:09 +0000 (21:06 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=31079 - Remove #include "Page.h" from Document.h

Reviewed by Darin Adler.

No new tests. (No change in functionality)

* dom/Document.cpp:
(WebCore::Document::inspectorTimelineAgent): Moved from Document.h
* dom/Document.h:

Include "Page.h" directly:
* html/HTMLVideoElement.cpp:
* loader/RedirectScheduler.cpp:
* page/History.cpp:
* rendering/MediaControlElements.cpp:
* storage/StorageAreaImpl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago(Unreviewed).
senorblanco@chromium.org [Tue, 3 Nov 2009 20:59:44 +0000 (20:59 +0000)]
(Unreviewed).

Add myself to committers.py.

* Scripts/modules/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoReviewed by Kevin Ollviier.
kevino@webkit.org [Tue, 3 Nov 2009 20:04:14 +0000 (20:04 +0000)]
Reviewed by Kevin Ollviier.

Add packaging scripts for Debian-based Linux distros.

https://bugs.webkit.org/show_bug.cgi?id=31075

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-11-03 Keishi Hattori <casey.hattori@gmail.com>
eric@webkit.org [Tue, 3 Nov 2009 19:38:01 +0000 (19:38 +0000)]
2009-11-03  Keishi Hattori  <casey.hattori@gmail.com>

        Reviewed by Timothy Hatcher.

        Web Inspector: hover over JS "things" in source and see their values
        https://bugs.webkit.org/show_bug.cgi?id=30913

        * inspector/front-end/SourceFrame.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-11-03 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 3 Nov 2009 19:24:56 +0000 (19:24 +0000)]
2009-11-03  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: update timeline content boundaries on timer.

        https://bugs.webkit.org/show_bug.cgi?id=31072

        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel.prototype.refresh):
        (WebInspector.TimelinePanel.prototype._setWindowPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: https://bugs.webkit.org/show_bug.cgi?id=31070
mitz@apple.com [Tue, 3 Nov 2009 19:07:48 +0000 (19:07 +0000)]
WebCore: https://bugs.webkit.org/show_bug.cgi?id=31070
Fix <rdar://problem/7194735> Crashes at RenderText::RenderText()
Fix <rdar://problem/6937089> Crashes at RenderWidget::destroy()

Reviewed by Anders Carlsson and Beth Dakin.

Tests: plugins/attach-during-destroy.html
       plugins/destroy-reentry.html

These crashes were caused by plug-in code running during detach(),
causing re-entry into RenderWidget::destroy() in one case and a call
into attach() in the other. The fix is to prevent plug-in code from
being called at certain unsafe times (during attach(), detach(), and
recalcStyle()) by deferring changes to the widget hierarchy.

* dom/Document.cpp:
(WebCore::Document::recalcStyle): Suspend widget hierarchy updates
    during style recalculation.

* dom/Element.cpp:
(WebCore::Element::attach): Suspend widget hierarchy updates during
    attach().
(WebCore::Element::detach): Suspend widget hierarchy updates during
    detach().

* rendering/RenderWidget.cpp:
(WebCore::widgetNewParentMap): Returns a static map of pending changes
    to the widget hierarchy.
(WebCore::RenderWidget::suspendWidgetHierarchyUpdates): Increments the
    suspend count.
(WebCore::RenderWidget::resumeWidgetHierarchyUpdates): Decrements the
    suspend count. If the count is going to be zero, updates the widget
    hierarchy by executing the pending changes stored in the map.
(WebCore::moveWidgetToParentSoon): Updates the widget hierarchy
    immediately or makes or updates an entry in the map, depending on
    whether updates are suspended.
(WebCore::RenderWidget::destroy): Removed earlier bandaid fix for
    <rdar://problem/6937089>.
(WebCore::RenderWidget::setWidgetGeometry): Assert that widget updates
    are not suspended, because this function updates the widget’s
    bounds, which can result in arbitrary native and JavaScript code
    execution. I think this assertion is true thanks to some deferred-
    update mechanisms that have already been deployed in other places
    in the code.
(WebCore::RenderWidget::setWidget): Call moveWidgetToParentSoon instead
    of changing the widget hierarchy directly.
* rendering/RenderWidget.h: Declared suspendWidgetHierarchyUpdates()
    and resumeWidgetHierarchyUpdates().

WebKitTools: https://bugs.webkit.org/show_bug.cgi?id=31070

Reviewed by Anders Carlsson and Beth Dakin.

Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
destroyed, it executes the value of the 'ondestroy' parameter as a
script.

* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
(pluginAllocate): Initialize onDestroy.
* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
onDestroy.
* DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
(NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
specified.
(NPP_Destroy): Execute the value of 'ondestroy' as a script.

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=31070
Test for <rdar://problem/7194735> Crashes at RenderText::RenderText()
Test for <rdar://problem/6937089> Crashes at RenderWidget::destroy()

Reviewed by Anders Carlsson and Beth Dakin.

* plugins/attach-during-destroy-expected.txt: Added.
* plugins/attach-during-destroy.html: Added.
* plugins/destroy-reentry-expected.txt: Added.
* plugins/destroy-reentry.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-11-03 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 3 Nov 2009 19:06:02 +0000 (19:06 +0000)]
2009-11-03  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: only show timeline records that contribute
        to the current window.

        https://bugs.webkit.org/show_bug.cgi?id=31069

        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel.prototype.refresh):
        (WebInspector.TimelineGraph):
        (WebInspector.TimelineGraph.prototype.refresh):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-11-03 Patrick Mueller <Patrick_Mueller@us.ibm.com>
eric@webkit.org [Tue, 3 Nov 2009 18:45:17 +0000 (18:45 +0000)]
2009-11-03  Patrick Mueller  <Patrick_Mueller@us.ibm.com>

        Reviewed by Timothy Hatcher.

        Watch expression editor should stay open after Add button was clicked
        https://bugs.webkit.org/show_bug.cgi?id=31049

        No new tests, was a regression, use existing manual test.

        * inspector/front-end/WatchExpressionsSidebarPane.js:
        (WebInspector.WatchExpressionsSection.prototype.update):
        (WebInspector.WatchExpressionsSection.prototype.addExpression):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-11-03 Evan Martin <evan@chromium.org>
eric@webkit.org [Tue, 3 Nov 2009 18:37:39 +0000 (18:37 +0000)]
2009-11-03  Evan Martin  <evan@chromium.org>

        Reviewed by Darin Adler.

        A test that reproduces a hard-to-trigger memory corruption in the
        CSS lexer.

        https://bugs.webkit.org/show_bug.cgi?id=30827

        * fast/css/end-of-buffer-crash.html: Added.
2009-11-03  Evan Martin  <evan@chromium.org>

        Reviewed by Darin Adler.

        Fix an off-by-one in the CSS lexer that causes memory corruption in
        hard-to-trigger circumstances.

        https://bugs.webkit.org/show_bug.cgi?id=30827

        Test: fast/css/end-of-buffer-crash.html

        * css/maketokenizer: Add comments, fix off-by-one.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCrash due to double-destroy related to CSS run-in property
darin@apple.com [Tue, 3 Nov 2009 18:23:53 +0000 (18:23 +0000)]
Crash due to double-destroy related to CSS run-in property
https://bugs.webkit.org/show_bug.cgi?id=31034
rdar://problem/7328458

Patch by Darin Adler <darin@apple.com> on 2009-11-02
Reviewed by Dan Bernstein.

WebCore:

Test: fast/css/run-in-crash.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::destroy): Reorder destruction so the
continuation is destroyed after anonymous children. See comment
in the code for more details of why this is right.
* rendering/RenderInline.cpp:
(WebCore::RenderInline::destroy): Ditto.

LayoutTests:

* fast/css/run-in-crash-expected.txt: Added.
* fast/css/run-in-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-11-03 Alexander Pavlov <apavlov@chromium.org>
eric@webkit.org [Tue, 3 Nov 2009 18:22:12 +0000 (18:22 +0000)]
2009-11-03  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Fix exception in ElementsPanel.js when moving pointer out of crumbs and window

        There might be no new node under mouse if the pointer is moved out of the window
        in which case we get an exception.
        https://bugs.webkit.org/show_bug.cgi?id=31061

        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel.prototype._mouseMovedOutOfCrumbs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAllow custom memory allocation control for the dom directory of WebCore
zoltan@webkit.org [Tue, 3 Nov 2009 18:09:59 +0000 (18:09 +0000)]
Allow custom memory allocation control for the dom directory of WebCore
https://bugs.webkit.org/show_bug.cgi?id=31053

Reviewed by Darin Adler.

Inherits the following classes from Noncopyable because these are
instantiated by 'new' and these are no need to be copyable:

class EventNames - 'new' call: WebCore/platform/ThreadGlobalData.cpp:73
struct PerformTaskContext - 'new' call: WebCore/dom/Document.cpp:4581
class EventData - 'new' call: WebCore/dom/MessagePortChannel.cpp:38
struct NodeListsNodeData - 'new' call: WebCore/dom/NodeRareData.h:51
struct EventTargetData - 'new' call: WebCore/dom/NodeRareData.h:100
class NodeRareData - 'new' call: WebCore/dom/Node.cpp:552

Inherits QualifiedName class from FastAllocBase because it is
instantiated by 'new' in WebCore/editing/markup.cpp:319

* dom/Document.cpp:
* dom/EventNames.h:
* dom/EventTarget.h:
* dom/MessagePortChannel.h:
* dom/NodeRareData.h:
* dom/QualifiedName.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-11-03 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 3 Nov 2009 17:59:54 +0000 (17:59 +0000)]
2009-11-03  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Implement timeline summary panel.

        https://bugs.webkit.org/show_bug.cgi?id=31064

        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel.prototype._createOverview):
        (WebInspector.TimelinePanel.prototype.refresh):
        (WebInspector.TimelineCategoryGraph):
        (WebInspector.TimelineCategoryGraph.prototype.get graphElement):
        (WebInspector.TimelineCategoryGraph.prototype.addChunk):
        (WebInspector.TimelineCategoryGraph.prototype.clearChunks):
        (WebInspector.TimelineGraph.prototype.refresh):
        * inspector/front-end/inspector.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-11-03 Alexander Pavlov <apavlov@chromium.org>
eric@webkit.org [Tue, 3 Nov 2009 17:56:05 +0000 (17:56 +0000)]
2009-11-03  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Timothy Hatcher.

        Toggle off 'Search for node' when the Inspector window is closing

        Searching for node should be toggled off when the Inspector window is closed,
        in a platform-independent manner.
        https://bugs.webkit.org/show_bug.cgi?id=31059

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::setWindowVisible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-11-03 Victor Wang <victorw@chromium.org>
japhet@chromium.org [Tue, 3 Nov 2009 17:49:22 +0000 (17:49 +0000)]
2009-11-03  Victor Wang  <victorw@chromium.org>

        Reviewed by Eric Seidel.

        "http://trac.webkit.org/changeset/50315" makes links mouse
        focusable only on GTK and QT, so win has same behavior as mac now
        Remove the win specific expected results for tests failed
        due to the patch.

        https://bugs.webkit.org/show_bug.cgi?id=30968

        * platform/win/fast/events/click-focus-anchor-expected.txt: Removed.
        * platform/win/fast/inline: Removed.
        * platform/win/fast/inline/dirtyLinesForInline-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-11-03 Mikhail Naganov <mnaganov@chromium.org>
eric@webkit.org [Tue, 3 Nov 2009 17:47:39 +0000 (17:47 +0000)]
2009-11-03  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Timothy Hatcher.

        Prepare for heap profiles upstreaming:
        - pass profile type id from InspectorController;
        - this makes WebInspector.CPUProfile redundant---removed;
        - support multiple profile types when populating profiles.

        https://bugs.webkit.org/show_bug.cgi?id=31052

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::createProfileHeader):
        * inspector/front-end/ProfileView.js:
        (WebInspector.CPUProfileView.profileCallback):
        (WebInspector.CPUProfileView):
        (WebInspector.CPUProfileView.prototype._sortData):
        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype.addProfileHeader):
        * inspector/front-end/inspector.js:
        (WebInspector.addProfileHeader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-11-03 Dan Kegel <dank@chromium.org>
darin@chromium.org [Tue, 3 Nov 2009 17:26:31 +0000 (17:26 +0000)]
2009-11-03  Dan Kegel  <dank@chromium.org>

        Reviewed by Dimitri Glazkov.

        UMR in WebCore::AccessibilityRenderObject::children(); m_childrenDirty uninitialized in constructor
        https://bugs.webkit.org/show_bug.cgi?id=31063

        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::AccessibilityRenderObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-11-03 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 3 Nov 2009 17:06:01 +0000 (17:06 +0000)]
2009-11-03  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Implement Timeline Window, wire it to the bottom timeline.

        https://bugs.webkit.org/show_bug.cgi?id=31056

        * English.lproj/localizedStrings.js:
        * inspector/front-end/AbstractTimelinePanel.js:
        (WebInspector.AbstractTimelinePanel.prototype.get items):
        (WebInspector.AbstractTimelinePanel.prototype.createInterface):
        (WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded):
        (WebInspector.AbstractTimelinePanel.prototype._updateDividersLabelBarPosition):
        (WebInspector.AbstractTimelinePanel.prototype.invalidateAllItems):
        (WebInspector.AbstractTimelinePanel.prototype.refresh):
        (WebInspector.AbstractTimelinePanel.prototype.adjustScrollPosition):
        (WebInspector.AbstractTimelinePanel.prototype.addExtraDivider):
        (WebInspector.TimelineGrid):
        (WebInspector.TimelineGrid.prototype.get itemsGraphsElement):
        (WebInspector.TimelineGrid.prototype.updateDividers):
        (WebInspector.TimelineGrid.prototype.addExtraDivider):
        (WebInspector.TimelineGrid.prototype.setScrollAndDividerTop):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel):
        (WebInspector.ResourcesPanel.prototype.updateGraphDividersIfNeeded):
        (WebInspector.ResourcesPanel.prototype.get _resources):
        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel):
        (WebInspector.TimelinePanel.prototype.get categories):
        (WebInspector.TimelinePanel.prototype._formatRecord):
        (WebInspector.TimelinePanel.prototype.reset):
        (WebInspector.TimelinePanel.prototype._createOverview):
        (WebInspector.TimelinePanel.prototype.setSidebarWidth):
        (WebInspector.TimelinePanel.prototype.updateMainViewWidth):
        (WebInspector.TimelinePanel.prototype.updateGraphDividersIfNeeded):
        (WebInspector.TimelinePanel.prototype.refresh):
        (WebInspector.TimelinePanel.prototype._resizeWindow):
        (WebInspector.TimelinePanel.prototype._windowResizeDragging):
        (WebInspector.TimelinePanel.prototype._dragWindow):
        (WebInspector.TimelinePanel.prototype._windowDragging):
        (WebInspector.TimelinePanel.prototype._resizeWindowLeft):
        (WebInspector.TimelinePanel.prototype._resizeWindowRight):
        (WebInspector.TimelinePanel.prototype._setWindowPosition):
        (WebInspector.TimelinePanel.prototype._endWindowDragging):
        (WebInspector.TimelineCategoryTreeElement):
        (WebInspector.TimelineCategoryTreeElement.prototype.onattach):
        (WebInspector.TimelineCalculator.prototype.computeBarGraphPercentages):
        (WebInspector.TimelineCalculator.prototype.get minimumBoundary):
        (WebInspector.TimelineCalculator.prototype.get maximumBoundary):
        (WebInspector.TimelineCalculator.prototype.reset):
        (WebInspector.TimelineCalculator.prototype.updateBoundaries):
        (WebInspector.TimelineCalculator.prototype.formatValue):
        * inspector/front-end/inspector.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Fix build of unit-test after r50454.
hausmann@webkit.org [Tue, 3 Nov 2009 16:13:58 +0000 (16:13 +0000)]
[Qt] Fix build of unit-test after r50454.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-11-03
Reviewed by Simon Hausmann.

* tests/qwebpage/tst_qwebpage.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake QWebPluginDatabase private API for now.
hausmann@webkit.org [Tue, 3 Nov 2009 15:54:42 +0000 (15:54 +0000)]
Make QWebPluginDatabase private API for now.

Patch by Simon Hausmann <hausmann@webkit.org> on 2009-11-03
Reviewed by Tor Arne Vestbø.

https://bugs.webkit.org/show_bug.cgi?id=30775

WebCore:

* WebCore.pro:

WebKit/qt:

* Api/headers.pri:
* Api/qwebplugindatabase.cpp:
* Api/qwebplugindatabase_p.h: Renamed from WebKit/qt/Api/qwebplugindatabase.h.
* Api/qwebsettings.cpp:
* Api/qwebsettings.h:
* QtLauncher/main.cpp:
(MainWindow::setupUI):
* tests/tests.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Tor Arne Vestbø.
hausmann@webkit.org [Tue, 3 Nov 2009 15:06:59 +0000 (15:06 +0000)]
Rubber-stamped by Tor Arne Vestbø.

Patch by Simon Hausmann <hausmann@webkit.org> on 2009-11-03
Oops, also remove the API docs of the removed networkRequestStarted() signal.

* Api/qwebpage.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Extended the conversion of the WebCore ResourceRequest to the
hausmann@webkit.org [Tue, 3 Nov 2009 14:50:55 +0000 (14:50 +0000)]
WebCore: Extended the conversion of the WebCore ResourceRequest to the
QNetworkRequest with a mandatory originating object argument,
which is meant to be the QWebFrame the request belongs to.

Patch by Simon Hausmann <hausmann@webkit.org> on 2009-11-03
Reviewed by Tor Arne Vestbø.

https://bugs.webkit.org/show_bug.cgi?id=29975

* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::start):
* platform/network/qt/ResourceRequest.h:
* platform/network/qt/ResourceRequestQt.cpp:
(WebCore::ResourceRequest::toNetworkRequest):

WebKit/qt: Replace the QWebPage::networkRequestStarted() signal with the originatingObject
property set to the QWebFrame that belongs to the request.

Patch by Simon Hausmann <hausmann@webkit.org> on 2009-11-03
Reviewed by Tor Arne Vestbø.

https://bugs.webkit.org/show_bug.cgi?id=29975

* Api/qwebpage.h:
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNewWindowAction):
(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
(WebCore::FrameLoaderClientQt::startDownload):
* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::loadFinished):
(TestNetworkManager::createRequest):
(tst_QWebPage::originatingObjectInNetworkRequests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-11-03 Keishi Hattori <casey.hattori@gmail.com>
eric@webkit.org [Tue, 3 Nov 2009 14:48:25 +0000 (14:48 +0000)]
2009-11-03  Keishi Hattori  <casey.hattori@gmail.com>

        Reviewed by Pavel Feldman.

        Web Inspector: monitorEvent should be monitorEvents
        https://bugs.webkit.org/show_bug.cgi?id=31042

        * inspector/front-end/InjectedScript.js:
        (InjectedScript._ensureCommandLineAPIInstalled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Windows CE build fix
vestbo@webkit.org [Tue, 3 Nov 2009 13:04:25 +0000 (13:04 +0000)]
[Qt] Windows CE build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd files to skiplist depend on phonon support,
ossy@webkit.org [Tue, 3 Nov 2009 12:32:38 +0000 (12:32 +0000)]
Add files to skiplist depend on phonon support,
which is disabled on the Qt buildbot for now.

Patch by Csaba Osztrogonác <ossy@webkit.org> on 2009-11-03
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Tor Arne Vestbø.
ossy@webkit.org [Tue, 3 Nov 2009 12:12:55 +0000 (12:12 +0000)]
Rubber-stamped by Tor Arne Vestbø.

Patch by Csaba Osztrogonác <ossy@webkit.org> on 2009-11-03
Remove now passing tests from skiplist.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Build fix for Windows CE
vestbo@webkit.org [Tue, 3 Nov 2009 11:56:24 +0000 (11:56 +0000)]
[Qt] Build fix for Windows CE

Rubber-stamped by Antti Koivisto.

* plugins/PluginDatabase.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Build fix for Mac OS X when building as framework
vestbo@webkit.org [Tue, 3 Nov 2009 11:50:57 +0000 (11:50 +0000)]
[Qt] Build fix for Mac OS X when building as framework

WTFReportAssertionFailure is not exported, so building DRT in debug
mode against QtWebKit built as a framework failes to link.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPut test into skiplist added in r50411 because
ossy@webkit.org [Tue, 3 Nov 2009 10:40:13 +0000 (10:40 +0000)]
Put test into skiplist added in r50411 because
layoutTestController.showWebInspector() is unimplemented now.

Patch by Csaba Osztrogonác <ossy@webkit.org> on 2009-11-03
* platform/qt/Skipped: inspector/css-syntax-highlight.html added

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-11-02 Chris Fleizach <cfleizach@apple.com>
eric@webkit.org [Tue, 3 Nov 2009 10:00:20 +0000 (10:00 +0000)]
2009-11-02  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by David Levin.

        fix accessibility webkit-style-check errors
        https://bugs.webkit.org/show_bug.cgi?id=29672

        * accessibility/AXObjectCache.cpp:
        (WebCore::AXObjectCache::getOrCreate):
        (WebCore::AXObjectCache::remove):
        (WebCore::AXObjectCache::platformGenerateAXID):
        (WebCore::AXObjectCache::removeAXID):
        * accessibility/AXObjectCache.h:
        (WebCore::AXObjectCache::enableAccessibility):
        (WebCore::AXObjectCache::enableEnhancedUserInterfaceAccessibility):
        (WebCore::AXObjectCache::accessibilityEnabled):
        (WebCore::AXObjectCache::accessibilityEnhancedUserInterfaceEnabled):
        (WebCore::AXObjectCache::isIDinUse):
        (WebCore::AXObjectCache::objectFromAXID):
        (WebCore::AXObjectCache::):
        (WebCore::AXObjectCache::handleActiveDescendantChanged):
        (WebCore::AXObjectCache::handleAriaRoleChanged):
        (WebCore::AXObjectCache::detachWrapper):
        (WebCore::AXObjectCache::attachWrapper):
        (WebCore::AXObjectCache::selectedChildrenChanged):
        (WebCore::AXObjectCache::postNotification):
        (WebCore::AXObjectCache::postPlatformNotification):
        (WebCore::AXObjectCache::handleFocusedUIElementChanged):
        (WebCore::AXObjectCache::handleScrolledToAnchor):
        * accessibility/AccessibilityARIAGrid.cpp:
        (WebCore::AccessibilityARIAGrid::cellForColumnAndRow):
        * accessibility/AccessibilityAllInOne.cpp:
        * accessibility/AccessibilityImageMapLink.cpp:
        * accessibility/AccessibilityList.h:
        (WebCore::AccessibilityList::isList):
        * accessibility/AccessibilityListBox.cpp:
        * accessibility/AccessibilityListBox.h:
        (WebCore::AccessibilityListBox::isListBox):
        * accessibility/AccessibilityListBoxOption.cpp:
        * accessibility/AccessibilityListBoxOption.h:
        (WebCore::AccessibilityListBoxOption::isListBoxOption):
        * accessibility/AccessibilityMediaControls.h:
        (WebCore::AccessibilityMediaControl::~AccessibilityMediaControl):
        (WebCore::AccessibilityMediaTimeline::~AccessibilityMediaTimeline):
        (WebCore::AccessibilityMediaTimeline::isMediaTimeline):
        (WebCore::AccessibilityMediaControlsContainer::~AccessibilityMediaControlsContainer):
        (WebCore::AccessibilityMediaControlsContainer::roleValue):
        (WebCore::AccessibilityMediaControlsContainer::accessibilityIsIgnored):
        (WebCore::AccessibilityMediaTimeDisplay::~AccessibilityMediaTimeDisplay):
        (WebCore::AccessibilityMediaTimeDisplay::roleValue):
        * accessibility/AccessibilityObject.cpp:
        (WebCore::AccessibilityObject::parentObjectUnignored):
        (WebCore::AccessibilityObject::rightLineVisiblePositionRange):
        (WebCore::replacedNodeNeedsCharacter):
        (WebCore::AccessibilityObject::stringForVisiblePositionRange):
        (WebCore::AccessibilityObject::lengthForVisiblePositionRange):
        (WebCore::AccessibilityObject::actionVerb):
        * accessibility/AccessibilityObject.h:
        (WebCore::PlainTextRange::isNull):
        (WebCore::AccessibilityObject::isAccessibilityRenderObject):
        (WebCore::AccessibilityObject::isAnchor):
        (WebCore::AccessibilityObject::isAttachment):
        (WebCore::AccessibilityObject::isHeading):
        (WebCore::AccessibilityObject::isLink):
        (WebCore::AccessibilityObject::isImage):
        (WebCore::AccessibilityObject::isNativeImage):
        (WebCore::AccessibilityObject::isImageButton):
        (WebCore::AccessibilityObject::isPasswordField):
        (WebCore::AccessibilityObject::isTextControl):
        (WebCore::AccessibilityObject::isNativeTextControl):
        (WebCore::AccessibilityObject::isWebArea):
        (WebCore::AccessibilityObject::isCheckboxOrRadio):
        (WebCore::AccessibilityObject::isListBox):
        (WebCore::AccessibilityObject::isFileUploadButton):
        (WebCore::AccessibilityObject::isProgressIndicator):
        (WebCore::AccessibilityObject::isSlider):
        (WebCore::AccessibilityObject::isControl):
        (WebCore::AccessibilityObject::isList):
        (WebCore::AccessibilityObject::isDataTable):
        (WebCore::AccessibilityObject::isTableRow):
        (WebCore::AccessibilityObject::isTableColumn):
        (WebCore::AccessibilityObject::isTableCell):
        (WebCore::AccessibilityObject::isFieldset):
        (WebCore::AccessibilityObject::isGroup):
        (WebCore::AccessibilityObject::isChecked):
        (WebCore::AccessibilityObject::isEnabled):
        (WebCore::AccessibilityObject::isSelected):
        (WebCore::AccessibilityObject::isFocused):
        (WebCore::AccessibilityObject::isHovered):
        (WebCore::AccessibilityObject::isIndeterminate):
        (WebCore::AccessibilityObject::isLoaded):
        (WebCore::AccessibilityObject::isMultiSelect):
        (WebCore::AccessibilityObject::isOffScreen):
        (WebCore::AccessibilityObject::isPressed):
        (WebCore::AccessibilityObject::isReadOnly):
        (WebCore::AccessibilityObject::isVisited):
        (WebCore::AccessibilityObject::isRequired):
        (WebCore::AccessibilityObject::canSetFocusAttribute):
        (WebCore::AccessibilityObject::canSetTextRangeAttributes):
        (WebCore::AccessibilityObject::canSetValueAttribute):
        (WebCore::AccessibilityObject::hasIntValue):
        (WebCore::AccessibilityObject::accessibilityShouldUseUniqueId):
        (WebCore::AccessibilityObject::accessibilityIsIgnored):
        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::parentObjectIfExists):
        (WebCore::AccessibilityRenderObject::parentObject):
        (WebCore::AccessibilityRenderObject::isMenuRelated):
        (WebCore::AccessibilityRenderObject::accessibilityDescription):
        (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
        (WebCore::AccessibilityRenderObject::isFocused):
        (WebCore::AccessibilityRenderObject::visiblePositionRangeForLine):
        (WebCore::AccessibilityRenderObject::setSelectedVisiblePositionRange):
        (WebCore::AccessibilityRenderObject::doAXRangeForLine):
        (WebCore::AccessibilityRenderObject::doAXStringForRange):
        (WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest):
        (WebCore::AccessibilityRenderObject::determineAriaRoleAttribute):
        (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
        (WebCore::AccessibilityRenderObject::isPresentationalChildOfAriaRole):
        (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
        (WebCore::AccessibilityRenderObject::canHaveChildren):
        (WebCore::AccessibilityRenderObject::actionVerb):
        (WebCore::shouldReturnTagNameAsRoleForMSAA):
        * accessibility/AccessibilityRenderObject.h:
        (WebCore::AccessibilityRenderObject::isAccessibilityRenderObject):
        * accessibility/AccessibilitySlider.cpp:
        (WebCore::AccessibilitySlider::orientation):
        * accessibility/AccessibilitySlider.h:
        (WebCore::AccessibilitySlider::~AccessibilitySlider):
        (WebCore::AccessibilitySlider::roleValue):
        (WebCore::AccessibilitySlider::accessibilityIsIgnored):
        (WebCore::AccessibilitySlider::isSlider):
        (WebCore::AccessibilitySlider::canSetValueAttribute):
        (WebCore::AccessibilitySliderThumb::~AccessibilitySliderThumb):
        (WebCore::AccessibilitySliderThumb::roleValue):
        (WebCore::AccessibilitySliderThumb::accessibilityIsIgnored):
        (WebCore::AccessibilitySliderThumb::setParentObject):
        (WebCore::AccessibilitySliderThumb::parentObject):
        * accessibility/AccessibilityTable.cpp:
        (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
        * accessibility/AccessibilityTableColumn.cpp:
        * accessibility/AccessibilityTableHeaderContainer.cpp:
        (WebCore::AccessibilityTableHeaderContainer::addChildren):
        * accessibility/AccessibilityTableRow.cpp:
        * accessibility/mac/AccessibilityObjectWrapper.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-11-02 Joanmarie Diggs <joanmarie.diggs@gmail.com>
eric@webkit.org [Tue, 3 Nov 2009 07:51:02 +0000 (07:51 +0000)]
2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>

        Reviewed by Xan Lopez.

        https://bugs.webkit.org/show_bug.cgi?id=31035
        [GTK] some accessibility tests hitting assertion in debug builds

        Get the correct Gtk+ object before attempting to turn it into an AtkObject.

        * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
        (AccessibilityController::rootElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agofix accessibility webkit-style-check errors
cfleizach@apple.com [Tue, 3 Nov 2009 07:01:20 +0000 (07:01 +0000)]
fix accessibility webkit-style-check errors
https://bugs.webkit.org/show_bug.cgi?id=29672

Reviewed by David Levin.

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::getOrCreate):
(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::platformGenerateAXID):
(WebCore::AXObjectCache::removeAXID):
* accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::enableAccessibility):
(WebCore::AXObjectCache::enableEnhancedUserInterfaceAccessibility):
(WebCore::AXObjectCache::accessibilityEnabled):
(WebCore::AXObjectCache::accessibilityEnhancedUserInterfaceEnabled):
(WebCore::AXObjectCache::isIDinUse):
(WebCore::AXObjectCache::objectFromAXID):
(WebCore::AXObjectCache::):
(WebCore::AXObjectCache::handleActiveDescendantChanged):
(WebCore::AXObjectCache::handleAriaRoleChanged):
(WebCore::AXObjectCache::detachWrapper):
(WebCore::AXObjectCache::attachWrapper):
(WebCore::AXObjectCache::selectedChildrenChanged):
(WebCore::AXObjectCache::postNotification):
(WebCore::AXObjectCache::postPlatformNotification):
(WebCore::AXObjectCache::handleFocusedUIElementChanged):
(WebCore::AXObjectCache::handleScrolledToAnchor):
* accessibility/AccessibilityARIAGrid.cpp:
(WebCore::AccessibilityARIAGrid::cellForColumnAndRow):
* accessibility/AccessibilityAllInOne.cpp:
* accessibility/AccessibilityImageMapLink.cpp:
* accessibility/AccessibilityList.h:
(WebCore::AccessibilityList::isList):
* accessibility/AccessibilityListBox.cpp:
* accessibility/AccessibilityListBox.h:
(WebCore::AccessibilityListBox::isListBox):
* accessibility/AccessibilityListBoxOption.cpp:
* accessibility/AccessibilityListBoxOption.h:
(WebCore::AccessibilityListBoxOption::isListBoxOption):
* accessibility/AccessibilityMediaControls.h:
(WebCore::AccessibilityMediaControl::~AccessibilityMediaControl):
(WebCore::AccessibilityMediaTimeline::~AccessibilityMediaTimeline):
(WebCore::AccessibilityMediaTimeline::isMediaTimeline):
(WebCore::AccessibilityMediaControlsContainer::~AccessibilityMediaControlsContainer):
(WebCore::AccessibilityMediaControlsContainer::roleValue):
(WebCore::AccessibilityMediaControlsContainer::accessibilityIsIgnored):
(WebCore::AccessibilityMediaTimeDisplay::~AccessibilityMediaTimeDisplay):
(WebCore::AccessibilityMediaTimeDisplay::roleValue):
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::parentObjectUnignored):
(WebCore::AccessibilityObject::rightLineVisiblePositionRange):
(WebCore::replacedNodeNeedsCharacter):
(WebCore::AccessibilityObject::stringForVisiblePositionRange):
(WebCore::AccessibilityObject::lengthForVisiblePositionRange):
(WebCore::AccessibilityObject::actionVerb):
* accessibility/AccessibilityObject.h:
(WebCore::PlainTextRange::isNull):
(WebCore::AccessibilityObject::isAccessibilityRenderObject):
(WebCore::AccessibilityObject::isAnchor):
(WebCore::AccessibilityObject::isAttachment):
(WebCore::AccessibilityObject::isHeading):
(WebCore::AccessibilityObject::isLink):
(WebCore::AccessibilityObject::isImage):
(WebCore::AccessibilityObject::isNativeImage):
(WebCore::AccessibilityObject::isImageButton):
(WebCore::AccessibilityObject::isPasswordField):
(WebCore::AccessibilityObject::isTextControl):
(WebCore::AccessibilityObject::isNativeTextControl):
(WebCore::AccessibilityObject::isWebArea):
(WebCore::AccessibilityObject::isCheckboxOrRadio):
(WebCore::AccessibilityObject::isListBox):
(WebCore::AccessibilityObject::isFileUploadButton):
(WebCore::AccessibilityObject::isProgressIndicator):
(WebCore::AccessibilityObject::isSlider):
(WebCore::AccessibilityObject::isControl):
(WebCore::AccessibilityObject::isList):
(WebCore::AccessibilityObject::isDataTable):
(WebCore::AccessibilityObject::isTableRow):
(WebCore::AccessibilityObject::isTableColumn):
(WebCore::AccessibilityObject::isTableCell):
(WebCore::AccessibilityObject::isFieldset):
(WebCore::AccessibilityObject::isGroup):
(WebCore::AccessibilityObject::isChecked):
(WebCore::AccessibilityObject::isEnabled):
(WebCore::AccessibilityObject::isSelected):
(WebCore::AccessibilityObject::isFocused):
(WebCore::AccessibilityObject::isHovered):
(WebCore::AccessibilityObject::isIndeterminate):
(WebCore::AccessibilityObject::isLoaded):
(WebCore::AccessibilityObject::isMultiSelect):
(WebCore::AccessibilityObject::isOffScreen):
(WebCore::AccessibilityObject::isPressed):
(WebCore::AccessibilityObject::isReadOnly):
(WebCore::AccessibilityObject::isVisited):
(WebCore::AccessibilityObject::isRequired):
(WebCore::AccessibilityObject::canSetFocusAttribute):
(WebCore::AccessibilityObject::canSetTextRangeAttributes):
(WebCore::AccessibilityObject::canSetValueAttribute):
(WebCore::AccessibilityObject::hasIntValue):
(WebCore::AccessibilityObject::accessibilityShouldUseUniqueId):
(WebCore::AccessibilityObject::accessibilityIsIgnored):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::parentObjectIfExists):
(WebCore::AccessibilityRenderObject::parentObject):
(WebCore::AccessibilityRenderObject::isMenuRelated):
(WebCore::AccessibilityRenderObject::accessibilityDescription):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::isFocused):
(WebCore::AccessibilityRenderObject::visiblePositionRangeForLine):
(WebCore::AccessibilityRenderObject::setSelectedVisiblePositionRange):
(WebCore::AccessibilityRenderObject::doAXRangeForLine):
(WebCore::AccessibilityRenderObject::doAXStringForRange):
(WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest):
(WebCore::AccessibilityRenderObject::determineAriaRoleAttribute):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
(WebCore::AccessibilityRenderObject::isPresentationalChildOfAriaRole):
(WebCore::AccessibilityRenderObject::canSetFocusAttribute):
(WebCore::AccessibilityRenderObject::canHaveChildren):
(WebCore::AccessibilityRenderObject::actionVerb):
(WebCore::shouldReturnTagNameAsRoleForMSAA):
* accessibility/AccessibilityRenderObject.h:
(WebCore::AccessibilityRenderObject::isAccessibilityRenderObject):
* accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySlider::orientation):
* accessibility/AccessibilitySlider.h:
(WebCore::AccessibilitySlider::~AccessibilitySlider):
(WebCore::AccessibilitySlider::roleValue):
(WebCore::AccessibilitySlider::accessibilityIsIgnored):
(WebCore::AccessibilitySlider::isSlider):
(WebCore::AccessibilitySlider::canSetValueAttribute):
(WebCore::AccessibilitySliderThumb::~AccessibilitySliderThumb):
(WebCore::AccessibilitySliderThumb::roleValue):
(WebCore::AccessibilitySliderThumb::accessibilityIsIgnored):
(WebCore::AccessibilitySliderThumb::setParentObject):
(WebCore::AccessibilitySliderThumb::parentObject):
* accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
* accessibility/AccessibilityTableColumn.cpp:
* accessibility/AccessibilityTableHeaderContainer.cpp:
(WebCore::AccessibilityTableHeaderContainer::addChildren):
* accessibility/AccessibilityTableRow.cpp:
* accessibility/mac/AccessibilityObjectWrapper.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION (r48573): JSC may incorrectly cache chain lookups with a dictionary at...
oliver@apple.com [Tue, 3 Nov 2009 06:49:42 +0000 (06:49 +0000)]
REGRESSION (r48573): JSC may incorrectly cache chain lookups with a dictionary at the head of the chain
https://bugs.webkit.org/show_bug.cgi?id=31045

Reviewed by Gavin Barraclough.

Add guards to prevent caching of prototype chain lookups with dictionaries at the
head of the chain.  Also add a few tighter assertions to cached prototype lookups
to catch this in future.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-11-02 Darin Fisher <darin@chromium.org>
darin@chromium.org [Tue, 3 Nov 2009 05:51:59 +0000 (05:51 +0000)]
2009-11-02  Darin Fisher  <darin@chromium.org>

        Fixing JSC build bustage.

        * bindings/js/ScriptController.cpp: Added missing #include

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-30 Darin Fisher <darin@chromium.org>
darin@chromium.org [Tue, 3 Nov 2009 05:47:16 +0000 (05:47 +0000)]
2009-10-30  Darin Fisher  <darin@chromium.org>

        Reviewed by Adam Barth.

        Give the FrameLoaderClient the ability to override Settings::isJavaScriptEnabled.
        https://bugs.webkit.org/show_bug.cgi?id=30967

        * bindings/js/ScriptController.cpp:
        (WebCore::ScriptController::isEnabled):
        * bindings/v8/ScriptController.cpp:
        (WebCore::ScriptController::isEnabled):
        * bindings/v8/V8Proxy.cpp: Move implementation of isEnabled to ScriptController
        * bindings/v8/V8Proxy.h: Ditto
        * loader/FrameLoaderClient.h:
        (WebCore::FrameLoaderClient::allowJavaScript):
        * platform/chromium/ChromiumBridge.h: Delete uiResourceProtocol function

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubberstamped by Mark Rowe.
beidson@apple.com [Tue, 3 Nov 2009 04:40:26 +0000 (04:40 +0000)]
Rubberstamped by Mark Rowe.

Fix a typo in Mark's last commit.

* loader/archive/ArchiveFactory.cpp:
(WebCore::archiveMIMETypes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRe-enable support for web archives on Windows. It was mistakenly disabled in r50438.
mrowe@apple.com [Tue, 3 Nov 2009 04:00:55 +0000 (04:00 +0000)]
Re-enable support for web archives on Windows.  It was mistakenly disabled in r50438.

Rubber-stamped by Brady Eidson.

* loader/archive/ArchiveFactory.cpp:
(WebCore::archiveMIMETypes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-11-02 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Tue, 3 Nov 2009 03:24:22 +0000 (03:24 +0000)]
2009-11-02  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Darin Adler.

        PLATFORM(CF) should be set when building for Qt on Darwin
        https://bugs.webkit.org/show_bug.cgi?id=23671

        * wtf/Platform.h: Turn on CF support if both QT and DARWIN
        platforms are defined.
2009-11-02  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Darin Adler.

        PLATFORM(CF) should be set when building for Qt on Darwin
        https://bugs.webkit.org/show_bug.cgi?id=23671

        * WebCore.pro: Add SharedBufferCF.cpp and SmartReplaceCF.cpp
        to the Darwin build.
        * loader/archive/ArchiveFactory.cpp: Change the support for
        legacy WebArchive from all CF platforms to Mac and Chromium
        CF platforms.
        (WebCore::archiveMIMETypes):
        * platform/text/AtomicString.h: Remove PLATFORM(QT) &&
        PLATFORM(DARWIN) test as it is redundant now.
        * platform/text/PlatformString.h: Ditto.
        * platform/text/StringImpl.h: Ditto.
        * platform/text/cf/StringCF.cpp: Ditto.
        * platform/text/cf/StringImplCF.cpp: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-11-02 Adam Barth <abarth@webkit.org>
eric@webkit.org [Tue, 3 Nov 2009 02:35:51 +0000 (02:35 +0000)]
2009-11-02  Adam Barth  <abarth@webkit.org>

        Reviewed by David Levin.

        [Chromium] Actually declare getPluginMimeTypeFromExtension in a header.
        https://bugs.webkit.org/show_bug.cgi?id=30985

        Our current code does not conform to our style guide.

        * WebCore.gyp/WebCore.gyp:
        * WebCore.gypi:
        * platform/chromium/MIMETypeRegistryChromium.cpp:
        * plugins/chromium/PluginDataChromium.cpp:
        * plugins/chromium/PluginDataChromium.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix for <rdar://problem/7038305> REGRESSION (Safari 4.0.2 - ToT): After navigating...
adele@apple.com [Tue, 3 Nov 2009 02:07:51 +0000 (02:07 +0000)]
Fix for <rdar://problem/7038305> REGRESSION (Safari 4.0.2 - ToT): After navigating back to a known phishy page, the "Ignore warning" button appears highlighted (along with the "Go Back" button)

Reviewed by Darin Adler.

This bug is timing dependent, and not always reproducible.  I could not think of a way to add a
layout test that would demonstrate the problem and fix.

* platform/mac/ThemeMac.mm:
(WebCore::checkbox): Update style.
(WebCore::paintCheckbox): ditto.
(WebCore::radio): ditto.
(WebCore::paintRadio): ditto.
(WebCore::setupButtonCell): Added convenience method.
(WebCore::button): Use a separate NSButtonCell for defaultButtons and regular buttons.
(WebCore::paintButton): Don't check for the key window here.  Consider that when deciding if the button should have the default style in RenderTheme.
* rendering/RenderTheme.cpp: (WebCore::RenderTheme::isDefault): Only consider a button to be default if the page is active.  This fixes
a problem I noticed where the button would flicker crazily if the page with the default button was in the background.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMinor RenderWidget clean-up in preparation for deferring widget tree
mitz@apple.com [Tue, 3 Nov 2009 01:44:22 +0000 (01:44 +0000)]
Minor RenderWidget clean-up in preparation for deferring widget tree
mutation when it is not safe.

Reviewed by Anders Carlsson.

* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::RenderWidget): Initialize m_refCount to 1
instead of calling ref().
(WebCore::RenderWidget::destroy): Call setWidget(0) instead of
repeating what it does.
(WebCore::RenderWidget::setWidgetGeometry): Now returns a boolean
indicating whether the bounds have changed.
(WebCore::RenderWidget::setWidget): Replaced all-encompassing if
statement with an early return.
(WebCore::RenderWidget::updateWidgetPosition): Call setWidgetGeometry().
* rendering/RenderWidget.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdding Chromium's DatabaseTracker and SQLTransactionClient
dumi@chromium.org [Tue, 3 Nov 2009 01:38:52 +0000 (01:38 +0000)]
Adding Chromium's DatabaseTracker and SQLTransactionClient
implementations.

Patch by Dumitru Daniliuc <dumi@chromium.org> on 2009-11-02
Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=30701

* storage/chromium: Added.
* storage/chromium/DatabaseObserver.h: Added.
* storage/chromium/DatabaseTrackerChromium.cpp: Added.
* storage/chromium/QuotaTracker.cpp: Added.
* storage/chromium/QuotaTracker.h: Added.
* storage/chromium/SQLTransactionClientChromium.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSafari crashes when calling execCommand on formatted html in special case
enrica@apple.com [Tue, 3 Nov 2009 01:06:26 +0000 (01:06 +0000)]
Safari crashes when calling execCommand on formatted html in special case
<rdar://problem/7318656>
https://bugs.webkit.org/show_bug.cgi?id=31023

Reviewed by Adele Peterson and Dan Bernstein.

WebCore:

Test: editing/execCommand/align-in-span.html

* rendering/RenderObject.cpp:
(WebCore::RenderObject::containingBlock): Modified comment on containingBlock returning NULL.
* rendering/RenderText.cpp:
(WebCore::RenderText::setSelectionState): Added check for NULL return from containingBlock,
since it is possible when dealing with orphaned trees.

LayoutTests:

* editing/execCommand/align-in-span-expected.txt: Added.
* editing/execCommand/align-in-span.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Exception checks were being too aggressive
cmarrin@apple.com [Tue, 3 Nov 2009 00:04:29 +0000 (00:04 +0000)]
    Exception checks were being too aggressive
        https://bugs.webkit.org/show_bug.cgi?id=31005

        Several calls in CanvasRenderingContext3D are allowed to
        have a null value passed, which indicated that the
        object is being unbound. Handle this case and the corresponding
        null handling in GraphicsContext3DMac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-11-02 Patrick Mueller <Patrick_Mueller@us.ibm.com>
eric@webkit.org [Mon, 2 Nov 2009 22:53:45 +0000 (22:53 +0000)]
2009-11-02  Patrick Mueller  <Patrick_Mueller@us.ibm.com>

        Reviewed by Timothy Hatcher.

        Each JS execution in console adds extra item into "scripts" combo
        https://bugs.webkit.org/show_bug.cgi?id=30212

        Added manual test

        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
        * manual-tests/inspector/hidden-evals.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-11-02 Estêvão Samuel Procópio <tevaum@gmail.com>
eric@webkit.org [Mon, 2 Nov 2009 22:26:00 +0000 (22:26 +0000)]
2009-11-02  Estêvão Samuel Procópio  <tevaum@gmail.com>

        Reviewed by Gustavo Noronha.

        [Build] make install ignores --prefix option for gobject-introspection.
        https://bugs.webkit.org/show_bug.cgi?id=31025

        Make the build system use the --prefix path also when installing
        gobject-introspection files.

        * configure.ac: use --prefix path in GITDIR and GIRTYPELIBDIR

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-11-02 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Mon, 2 Nov 2009 22:03:38 +0000 (22:03 +0000)]
2009-11-02  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by John Sullivan and Mark Rowe.

        <rdar://problem/7356733> Voiceover does not read correct media controller time values

        Fix localized strings for media controller time values.

        * English.lproj/Localizable.strings:

2009-11-02  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by John Sullivan and Mark Rowe.

        <rdar://problem/7356733> Voiceover does not read correct media controller time values

        * WebCoreSupport/WebViewFactory.mm:
        (-[WebViewFactory localizedMediaTimeDescription:]):

2009-11-02  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by John Sullivan and Mark Rowe.

        <rdar://problem/7356733> Voiceover does not read correct media controller time values

        * WebCoreLocalizedStrings.cpp:
        (WebCore::localizedMediaTimeDescription):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-11-02 Kelly Norton <knorton@google.com>
eric@webkit.org [Mon, 2 Nov 2009 22:02:33 +0000 (22:02 +0000)]
2009-11-02  Kelly Norton  <knorton@google.com>

        Reviewed by Timothy Hatcher.

        Adds a missed case for InspectorTimeline, DOMWindow dispatch of DOM events.
        https://bugs.webkit.org/show_bug.cgi?id=31030

        * dom/Node.cpp:
        (WebCore::eventHasListeners): Checks DOMWindow for listeners.
        (WebCore::Node::dispatchGenericEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove threadsafe refcounting from tasks used with WTF::MessageQueue.
dimich@chromium.org [Mon, 2 Nov 2009 21:31:22 +0000 (21:31 +0000)]
Remove threadsafe refcounting from tasks used with WTF::MessageQueue.
https://bugs.webkit.org/show_bug.cgi?id=30612

Reviewed by David Levin.

JavaScriptCore:

* wtf/MessageQueue.h:
(WTF::MessageQueue::alwaysTruePredicate):
(WTF::MessageQueue::~MessageQueue):
(WTF::MessageQueue::append):
(WTF::MessageQueue::appendAndCheckEmpty):
(WTF::MessageQueue::prepend):
(WTF::MessageQueue::waitForMessage):
(WTF::MessageQueue::waitForMessageFilteredWithTimeout):
(WTF::MessageQueue::tryGetMessage):
(WTF::MessageQueue::removeIf):
The MessageQueue is changed to act as a queue of OwnPtr<DataType>. It takes ownership
of posted tasks and passes it to the new owner (in another thread) when the task is fetched.
All methods have arguments of type PassOwnPtr<DataType> and return the same type.

* wtf/Threading.cpp:
(WTF::createThread):
Superficial change to trigger rebuild of JSC project on Windows,
workaround for https://bugs.webkit.org/show_bug.cgi?id=30890

WebCore:

No new tests since no new functionality. Storage, MessagePorts and Workers tests cover this.

There are a lot of files but most changes are simply replace RefPtr and PassRefPtr with
OwnPtr and PassOwnPtr when dealing with Tasks.

ScriptExecutionContext::Task, DatabaseTask and WorkerRunLoop::Task are no longer
threadsafe refcounted, but simply Noncopyable.

* dom/Document.cpp:
(WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer):
(WebCore::PerformTaskContext::PerformTaskContext):
(WebCore::Document::postTask):
* dom/Document.h:
* dom/ScriptExecutionContext.cpp:
(WebCore::ProcessMessagesSoonTask::create):
* dom/ScriptExecutionContext.h:
* dom/default/PlatformMessagePortChannel.cpp:
(WebCore::PlatformMessagePortChannel::tryGetMessageFromRemote):
* dom/default/PlatformMessagePortChannel.h:
(WebCore::PlatformMessagePortChannel::MessagePortQueue::tryGetMessage):
(WebCore::PlatformMessagePortChannel::MessagePortQueue::appendAndCheckEmpty):
* loader/FrameLoader.cpp:
(WebCore::HashChangeEventTask::create):
* loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::CallCacheListenerTask::create):
* storage/Database.cpp:
(WebCore::Database::openAndVerifyVersion):
(WebCore::Database::markAsDeletedAndClose):
(WebCore::Database::scheduleTransaction):
(WebCore::Database::scheduleTransactionStep):
(WebCore::Database::tableNames):
* storage/DatabaseTask.h:
(WebCore::DatabaseOpenTask::create):
(WebCore::DatabaseCloseTask::create):
(WebCore::DatabaseTransactionTask::create):
(WebCore::DatabaseTableNamesTask::create):
* storage/DatabaseThread.cpp:
(WebCore::DatabaseThread::databaseThread):
(WebCore::DatabaseThread::scheduleTask):
(WebCore::DatabaseThread::scheduleImmediateTask):
(WebCore::SameDatabasePredicate::operator()):
* storage/DatabaseThread.h:
* storage/LocalStorageTask.h:
(WebCore::LocalStorageTask::createImport):
(WebCore::LocalStorageTask::createSync):
(WebCore::LocalStorageTask::createTerminate):
* storage/LocalStorageThread.cpp:
(WebCore::LocalStorageThread::localStorageThread):
* storage/LocalStorageThread.h:
* websockets/WebSocket.cpp:
(WebCore::ProcessWebSocketEventTask::create):
* workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerProxy::postTaskToLoader):
(WebCore::SharedWorkerProxy::postTaskForModeToWorkerContext):
(WebCore::SharedWorkerConnectTask::create):
* workers/GenericWorkerTask.h:
(WebCore::GenericWorkerTask1::create):
(WebCore::GenericWorkerTask2::create):
(WebCore::GenericWorkerTask3::create):
(WebCore::GenericWorkerTask4::create):
(WebCore::GenericWorkerTask5::create):
(WebCore::GenericWorkerTask6::create):
(WebCore::GenericWorkerTask7::create):
(WebCore::GenericWorkerTask8::create):
(WebCore::createCallbackTask):
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::postTask):
* workers/WorkerContext.h:
* workers/WorkerLoaderProxy.h:
* workers/WorkerMessagingProxy.cpp:
(WebCore::MessageWorkerContextTask::create):
(WebCore::MessageWorkerTask::create):
(WebCore::WorkerExceptionTask::create):
(WebCore::WorkerContextDestroyedTask::create):
(WebCore::WorkerTerminateTask::create):
(WebCore::WorkerThreadActivityReportTask::create):
(WebCore::WorkerMessagingProxy::postTaskForModeToWorkerContext):
(WebCore::WorkerMessagingProxy::postTaskToLoader):
(WebCore::WorkerMessagingProxy::workerThreadCreated):
* workers/WorkerMessagingProxy.h:
* workers/WorkerRunLoop.cpp:
(WebCore::ModePredicate::operator()):
(WebCore::WorkerRunLoop::runInMode):
(WebCore::WorkerRunLoop::postTask):
(WebCore::WorkerRunLoop::postTaskForMode):
(WebCore::WorkerRunLoop::Task::create):
(WebCore::WorkerRunLoop::Task::performTask):
(WebCore::WorkerRunLoop::Task::Task):
* workers/WorkerRunLoop.h:
(WebCore::WorkerRunLoop::Task::~Task):
(WebCore::WorkerRunLoop::Task::mode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMade the remaining time display show negative zero at the end of the
mitz@apple.com [Mon, 2 Nov 2009 21:14:00 +0000 (21:14 +0000)]
Made the remaining time display show negative zero at the end of the
video.

Reviewed by Anders Carlsson.

Made other cleanup.

* WebView/WebVideoFullscreenHUDWindowController.h: Reverted the types of
_timeline and _volumeSlider to the more generic NSControl.
* WebView/WebVideoFullscreenHUDWindowController.mm:
(-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]): Cleaned
up style.
(-[WebVideoFullscreenHUDWindowController windowDidLoad]): Added an
assertion that the cast to NSButton * is legal. Removed casts.
(-[WebVideoFullscreenHUDWindowController updateTime]): Use
-setValue:forKey: instead of an NSSlider method.
(timeToString): Changed to support only non-negative values and
simplified.
(-[WebVideoFullscreenHUDWindowController remainingTimeText]): Always
prepend a “-” to the time.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-11-02 Philippe Normand <pnormand@igalia.com>
eric@webkit.org [Mon, 2 Nov 2009 20:14:35 +0000 (20:14 +0000)]
2009-11-02  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Jan Alonzo.

        [GTK] Failing media/video-played-reset.html
        https://bugs.webkit.org/show_bug.cgi?id=30589

        * platform/gtk/Skipped: Unskip fixed test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-11-02 Philippe Normand <pnormand@igalia.com>
eric@webkit.org [Mon, 2 Nov 2009 19:34:17 +0000 (19:34 +0000)]
2009-11-02  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Jan Alonzo.

        [GTK] Failing media/video-played-reset.html
        https://bugs.webkit.org/show_bug.cgi?id=30589

        new m_seekTime attribute to keep track of the seek position

        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivate::currentTime):
        (WebCore::MediaPlayerPrivate::seek):
        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-11-02 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Mon, 2 Nov 2009 19:25:23 +0000 (19:25 +0000)]
2009-11-02  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Jan Alonzo.

        [GTK] Remove Referer when redirecting to non-secure site
        https://bugs.webkit.org/show_bug.cgi?id=31021

        Remove referer from HTTP headers when redirecting to a non-secure
        site.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::restartedCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-11-02 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Mon, 2 Nov 2009 19:10:48 +0000 (19:10 +0000)]
2009-11-02  Xan Lopez  <xlopez@igalia.com>

        Bump version before release (or post-release, depending on your
        point of view) so that we can make applications depending on
        unreleased APIs in WebKit svn fail at configure time when the
        requirements are not met.

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Dan Bernstein.
ap@apple.com [Mon, 2 Nov 2009 19:00:33 +0000 (19:00 +0000)]
    Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=18539
        multipart/form-data not being parsed correctly on server due to '+' in boundary string

        No test - the characters that the boundary is made of are not deterministic.

        * platform/network/FormDataBuilder.cpp: (WebCore::FormDataBuilder::generateUniqueBoundaryString):
        Don't ever put a '+' in boundary string, either. Removed a FIXME to bring '/' back once
        GMail is fixed - I don't think we'll ever want to allow non-alphanumeric characters, as
        they cause problems on many web sites.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-11-02 Andrew Scherkus <scherkus@chromium.org>
eric@webkit.org [Mon, 2 Nov 2009 18:52:57 +0000 (18:52 +0000)]
2009-11-02  Andrew Scherkus  <scherkus@chromium.org>

        Reviewed by Eric Carlson.

        Increase the timeout of media/video-currentTime-set.html from 800ms to 2000ms.

        Also fix call to logResult() as parameters were reversed, resulting in
        printing an error message of "false".

        https://bugs.webkit.org/show_bug.cgi?id=31017

        * media/video-currentTime-set.html: Timeout increased to 2000ms.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Darin Adler.
ap@apple.com [Mon, 2 Nov 2009 18:41:55 +0000 (18:41 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=30969
        A no-prefix XPath node test should not match no-namespace elements in HTML document

        Test: fast/xpath/null-namespace-in-html.html

        * xml/XPathStep.cpp: (WebCore::XPath::nodeMatchesBasicTest): Special case non-HTML elements
        in HTML documents (as these are the ones that can have null namespace).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-11-02 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 2 Nov 2009 18:32:49 +0000 (18:32 +0000)]
2009-11-02  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: [REGRESSION] No timeline marks on resources panel.

        https://bugs.webkit.org/show_bug.cgi?id=31013

        * inspector/front-end/AbstractTimelinePanel.js:
        (WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPossible crash in RenderSlider::layout.
levin@chromium.org [Mon, 2 Nov 2009 18:26:15 +0000 (18:26 +0000)]
Possible crash in RenderSlider::layout.
https://bugs.webkit.org/show_bug.cgi?id=31016

Patch by David Levin <levin@chromium.org> on 2009-11-02
Reviewed by Dan Bernstein.

Fix out of place line of code.

Test: scrollbars/overflow-scrollbar-combinations.html
This crash only seems to repro when WebKit draws the play controls,
so the crash repros in chromium running this test but not WebKit
nightlies which use QuickTime to draw the controls.

* rendering/RenderSlider.cpp:
(WebCore::RenderSlider::layout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-11-02 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
eric@webkit.org [Mon, 2 Nov 2009 18:17:18 +0000 (18:17 +0000)]
2009-11-02  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>

        Reviewed by Tor Arne Vestbø.

        [Qt] Fix Qt build on Windows.
        https://bugs.webkit.org/show_bug.cgi?id=30905

        * WebCore.pro:
        * platform/graphics/BitmapImage.h:
        * platform/graphics/qt/ImageQt.cpp:
        (WebCore::BitmapImage::BitmapImage):
        (WebCore::BitmapImage::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-11-02 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
eric@webkit.org [Mon, 2 Nov 2009 18:09:19 +0000 (18:09 +0000)]
2009-11-02  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>

        Reviewed by Adam Barth.

        QWebView crash fix.

        The QWebView should not crash if the stop() method is called from
        a function triggered by the loadProgress signal.

        A null pointer protection was added in the ProgressTracker::incrementProgress.

        New autotest was created.

        https://bugs.webkit.org/show_bug.cgi?id=29425

        * loader/ProgressTracker.cpp:
        (WebCore::ProgressTracker::incrementProgress):
2009-11-02  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>

        Reviewed by Adam Barth.

        QWebView crash fix.

        The QWebView should not crash if the stop() method is called from
        a function triggered by the loadProgress signal.

        A null pointer protection was added in the ProgressTracker::incrementProgress.

        New autotest was created.

        https://bugs.webkit.org/show_bug.cgi?id=29425

        * tests/qwebview/tst_qwebview.cpp:
        (WebViewCrashTest::WebViewCrashTest):
        (WebViewCrashTest::loading):
        (tst_QWebView::crashTests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-11-02 Mikhail Naganov <mnaganov@chromium.org>
eric@webkit.org [Mon, 2 Nov 2009 18:01:08 +0000 (18:01 +0000)]
2009-11-02  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Fix a leftover from profiles panel generalization.

        https://bugs.webkit.org/show_bug.cgi?id=31010

        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype.get searchableViews):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-11-02 Kai Koehne <kai.koehne@nokia.com>
eric@webkit.org [Mon, 2 Nov 2009 17:53:34 +0000 (17:53 +0000)]
2009-11-02  Kai Koehne  <kai.koehne@nokia.com>

        Reviewed by Holger Freyther.

        Remove implementation of ImageDecocerQt::clearFrameBufferCache.
        The implementation was buggy, and will visually break repeating
        animations anyway.

        https://bugs.webkit.org/show_bug.cgi?id=31009

        * platform/graphics/qt/ImageDecoderQt.cpp:
        (WebCore::ImageDecoderQt::clearFrameBufferCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-11-02 Joanmarie Diggs <joanmarie.diggs@gmail.com>
eric@webkit.org [Mon, 2 Nov 2009 17:35:32 +0000 (17:35 +0000)]
2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>

        Reviewed by Jan Alonzo.

        https://bugs.webkit.org/show_bug.cgi?id=30964
        [Gtk] Implemment AtkDocument

        Provides access to the reported content language.

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (webkit_accessible_document_get_locale):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-11-02 Keishi Hattori <casey.hattori@gmail.com>
eric@webkit.org [Mon, 2 Nov 2009 17:27:50 +0000 (17:27 +0000)]
2009-11-02  Keishi Hattori  <casey.hattori@gmail.com>

        Reviewed by Timothy Hatcher.

        Web Inspector: Rewrite CSSSourceSyntaxHighlighter so it shares more code
        https://bugs.webkit.org/show_bug.cgi?id=30907

        * inspector/css-syntax-highlight-expected.txt: Added.
        * inspector/css-syntax-highlight.html: Added.
        * inspector/javascript-syntax-highlight-expected.txt:
2009-11-02  Keishi Hattori  <casey.hattori@gmail.com>

        Reviewed by Timothy Hatcher.

        Web Inspector: Rewrite CSSSourceSyntaxHighlighter so it shares more code
        https://bugs.webkit.org/show_bug.cgi?id=30907

        Test: inspector/css-syntax-highlight.html

        * inspector/front-end/ElementsTreeOutline.js:
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype.syntaxHighlightCSS):
        (WebInspector.SourceSyntaxHighlighter):
        (WebInspector.SourceSyntaxHighlighter.prototype.process.processChunk):
        (WebInspector.SourceSyntaxHighlighter.prototype.process.moveToNextLine):
        (WebInspector.SourceSyntaxHighlighter.prototype.process):
        (WebInspector.SourceSyntaxHighlighter.prototype.lex):
        (WebInspector.SourceSyntaxHighlighter.prototype.appendNonToken):
        (WebInspector.SourceSyntaxHighlighter.prototype.syntaxHighlightNode):
        (WebInspector.CSSSourceSyntaxHighlighter):
        * inspector/front-end/inspectorSyntaxHighlight.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKit/mac: WebKit part of making the appearance of the full-screen video HUD match
mitz@apple.com [Mon, 2 Nov 2009 17:03:14 +0000 (17:03 +0000)]
WebKit/mac: WebKit part of making the appearance of the full-screen video HUD match
QuickTime Player X’s HUD.

Reviewed by John Sullivan.

* WebView/WebVideoFullscreenHUDWindowController.h: Removed unnecessary
#import statements, cleaned up style, and changed _timeline,
_volumeSlider and _playButton to have more specific types.
* WebView/WebVideoFullscreenHUDWindowController.mm: Updated #import
statements.
(webkit_CGFloor): Added this helper function.
(-[WebVideoFullscreenHUDWindowController init]): Cleaned up style.
(createTimeTextField): Changed to use the bold system font.
(-[WebVideoFullscreenHUDWindowController windowDidLoad]): Changed the
subviews’ metrics and the text fields’ text alignment.
(-[WebVideoFullscreenHUDWindowController updateTime]): Avoid conversion
from double to float.
(stringToTimeTextAttributed): Removed this useless function that
returned an NSAttributedString masquerading as an NSString.
(-[WebVideoFullscreenHUDWindowController remainingTimeText]): Removed
call to stringToTimeTextAttributed().
(-[WebVideoFullscreenHUDWindowController elapsedTimeText]): Ditto.

WebKitLibraries: WebKitSystemInterface part of making the appearance of the full-screen video HUD match
QuickTime Player X’s HUD.

Reviewed by John Sullivan.

* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceSnowLeopard.a:
* libWebKitSystemInterfaceTiger.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSupport ARIA "tab" roles
cfleizach@apple.com [Mon, 2 Nov 2009 16:57:47 +0000 (16:57 +0000)]
Support ARIA "tab" roles
https://bugs.webkit.org/show_bug.cgi?id=30842

Reviewed by Beth Dakin.

WebCore:

Implement support for ARIA "tab", "tabpanel" and "tablist".
As a consequence, we also needed to implement aria-selected
and aria-controls.

Tests: accessibility/aria-controls-with-tabs.html
       accessibility/aria-tab-roles.html

* accessibility/AXObjectCache.cpp:
* accessibility/AccessibilityObject.h:
* accessibility/AccessibilityRenderObject.cpp:
* accessibility/AccessibilityRenderObject.h:
* accessibility/mac/AccessibilityObjectWrapper.mm:
* html/HTMLAttributeNames.in:

WebKit:

Add a localizable string for tab panel.

* English.lproj/Localizable.strings:
* StringsNotToBeLocalized.txt:

WebKit/mac:

* WebCoreSupport/WebViewFactory.mm:
(-[WebViewFactory AXARIAContentGroupText:]):

WebKitTools:

* DumpRenderTree/AccessibilityUIElement.cpp:
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:

LayoutTests:

* accessibility/aria-controls-with-tabs-expected.txt: Added.
* accessibility/aria-controls-with-tabs.html: Added.
* accessibility/aria-tab-roles.html: Added.
* platform/gtk/Skipped:
* platform/mac/accessibility/aria-tab-roles-expected.txt: Added.
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoThis is the WebKit-side change needed to fix canvas.getImageData() for
senorblanco@chromium.org [Mon, 2 Nov 2009 15:27:16 +0000 (15:27 +0000)]
This is the WebKit-side change needed to fix canvas.getImageData() for
Chromium.  The unpremultiply code in Skia assumes that unpremultiplied
values should be rounded, while CG does not.  In addition, the fixed
point inversion used by Skia introduces slight inaccuracies that make
us fail this test.  This change brings Chromium in line with
the CG path.
https://bugs.webkit.org/show_bug.cgi?id=30825

Reviewed by Dmitry Titov.

Covered by LayoutTests/fast/canvas/canvas-getImageData.html

* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::getImageData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-11-01 Kelly Norton <knorton@google.com>
pfeldman@chromium.org [Mon, 2 Nov 2009 09:37:27 +0000 (09:37 +0000)]
2009-11-01  Kelly Norton  <knorton@google.com>

        Reviewed by Timothy Hatcher.

        Adds window event dispatches to InspectorTimelineAgent.
        https://bugs.webkit.org/show_bug.cgi?id=31002

        * English.lproj/localizedStrings.js:
        * dom/Node.cpp: Updated call site to willDispatchEvent and didDispatchEvent.
        (WebCore::Node::dispatchGenericEvent):
        * inspector/InspectorTimelineAgent.cpp:
        (WebCore::InspectorTimelineAgent::willDispatchEvent): Renamed.
        (WebCore::InspectorTimelineAgent::didDispatchEvent): Renamed.
        * inspector/InspectorTimelineAgent.h:
        (WebCore::):
        * inspector/TimelineRecordFactory.cpp:
        (WebCore::TimelineRecordFactory::createEventDispatchRecord): Renamed.
        * inspector/TimelineRecordFactory.h:
        * inspector/front-end/TimelineAgent.js:
        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel.prototype._formatRecord):
        (WebInspector.TimelinePanel.prototype._getRecordDetails):
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::dispatchEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-11-01 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 2 Nov 2009 09:25:29 +0000 (09:25 +0000)]
2009-11-01  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Convert script tag event into a more generic
        script eval event in timeline.

        https://bugs.webkit.org/show_bug.cgi?id=30999

        * bindings/js/ScriptController.cpp:
        (WebCore::ScriptController::evaluateInWorld):
        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::evaluate):
        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::scriptExecution):
        * inspector/InspectorTimelineAgent.cpp:
        (WebCore::InspectorTimelineAgent::willEvaluateScript):
        (WebCore::InspectorTimelineAgent::didEvaluateScript):
        * inspector/InspectorTimelineAgent.h:
        (WebCore::):
        * inspector/TimelineRecordFactory.cpp:
        (WebCore::TimelineRecordFactory::createEvaluateScriptTimelineRecord):
        * inspector/TimelineRecordFactory.h:
        * inspector/front-end/TimelineAgent.js:
        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel.prototype._formatRecord):
        (WebInspector.TimelinePanel.prototype._getRecordDetails):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Mark Rowe.
bweinstein@apple.com [Mon, 2 Nov 2009 06:21:09 +0000 (06:21 +0000)]
Rubber-stamped by Mark Rowe.

Fix for loop to use an size_t instead of unsigned and some spacing
style fixes.

* dom/Node.cpp:
(WebCore::eventHasListeners):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRe-fix the Mac build. Sorry :-(.
bweinstein@apple.com [Mon, 2 Nov 2009 06:03:38 +0000 (06:03 +0000)]
Re-fix the Mac build. Sorry :-(.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChange ssize_t to unsigned to try and fix Windows build.
bweinstein@apple.com [Mon, 2 Nov 2009 05:57:39 +0000 (05:57 +0000)]
Change ssize_t to unsigned to try and fix Windows build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMade the space bar toggle playing state in full-screen video when
mitz@apple.com [Mon, 2 Nov 2009 03:53:23 +0000 (03:53 +0000)]
Made the space bar toggle playing state in full-screen video when
modifier keys are down. Made it do so without highlighting the
Play/Pause button.

Reviewed by Mark Rowe.

* WebView/WebVideoFullscreenHUDWindowController.mm:
(-[WebVideoFullscreenHUDWindowController keyDown:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-11-01 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 2 Nov 2009 03:30:54 +0000 (03:30 +0000)]
2009-11-01  Eric Seidel  <eric@webkit.org>

        Reviewed by David Levin.

        buildbots should use --exit-after-N-failures
        https://bugs.webkit.org/show_bug.cgi?id=30809

        Make the bots exit after 20 failures to prevent never-ending
        test runs where every test spends a minute crashing.

        * BuildSlaveSupport/build.webkit.org-config/master.cfg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-11-01 Kelly Norton <knorton@google.com>
eric@webkit.org [Mon, 2 Nov 2009 03:23:16 +0000 (03:23 +0000)]
2009-11-01  Kelly Norton  <knorton@google.com>

        Reviewed by Timothy Hatcher.

        Does not send DOM dispatches to the InspectorTimelineAgent if there
        are no event listeners.
        https://bugs.webkit.org/show_bug.cgi?id=30995

        * dom/Node.cpp:
        (WebCore::eventHasListeners):
        (WebCore::Node::dispatchGenericEvent):
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::callReadyStateChangeListener):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMade the full-screen video HUD respond to the up and down arrow keys by
mitz@apple.com [Mon, 2 Nov 2009 03:14:51 +0000 (03:14 +0000)]
Made the full-screen video HUD respond to the up and down arrow keys by
increasing and decreasing the volume by 1/10 of the range or, when
combined with the Option key, all the way up or down.

Reviewed by Mark Rowe.

Made the volume buttons in the full-screen video HUD match the behavior
of their equivalents in the QuickTime Player HUD by turning the volume
all the way up or down.

Made the volume slider update immediately when the keyboard or volume
buttons are used to change the volume, rather than at the nearest 1/4
second interval.

Made the elapsed and remaining time displays update immediately when the
play head is dragged across the timeline, rather than at 1/4 second
intervals.

* WebView/WebVideoFullscreenHUDWindowController.mm:
(-[WebVideoFullscreenHUDWindowController keyDown:]): Handle the up and
down arrow keys.
(-[WebVideoFullscreenHUDWindowController windowDidLoad]): Changed the
actions of the volume up and volume down buttons.
(-[WebVideoFullscreenHUDWindowController setCurrentTime:]): Call
-updateTime.
(-[WebVideoFullscreenHUDWindowController setVolumeToZero:]): Added this
action for the volume down button.
(-[WebVideoFullscreenHUDWindowController setVolumeToMaximum:]): Added
this action for the volume up button.
(-[WebVideoFullscreenHUDWindowController decrementVolume]): No longer
and action method.
(-[WebVideoFullscreenHUDWindowController incrementVolume]): Ditto.
(-[WebVideoFullscreenHUDWindowController setVolume:]): Call
-updateVolume.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNo review (build fix).
rolandsteiner@chromium.org [Mon, 2 Nov 2009 02:50:58 +0000 (02:50 +0000)]
No review (build fix).

Add missing files for Ruby implementation to WebCore.vcproj
(Fix build break after 50397)
https://bugs.webkit.org/show_bug.cgi?id=31001

No new tests. (No functional change)

* WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50398 268f45cc-cd09-0410-ab3c-d52691b4dbfc