WebKit-https.git
10 years ago2010-01-14 Yuzo Fujishima <yuzo@google.com>
ukai@chromium.org [Fri, 15 Jan 2010 04:56:47 +0000 (04:56 +0000)]
2010-01-14  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Alexey Proskuryakov.

        Update pywebsocket to 0.4.6
        https://bugs.webkit.org/show_bug.cgi?id=32299
        The newer pywebsocket can handle more simultaneous connections.

        * pywebsocket/mod_pywebsocket/handshake.py:
        * pywebsocket/mod_pywebsocket/standalone.py:
        * pywebsocket/setup.py:
        * pywebsocket/test/test_handshake.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBug 31865 - Re-do ruby layout tests to use only Latin characters
rolandsteiner@chromium.org [Fri, 15 Jan 2010 04:42:30 +0000 (04:42 +0000)]
Bug 31865 - Re-do ruby layout tests to use only Latin characters
(https://bugs.webkit.org/show_bug.cgi?id=31865)

Reviewed by David Levin.

New base-lines for the Windows platform.

* platform/win/fast/ruby/ruby-empty-rt-expected.checksum:
* platform/win/fast/ruby/ruby-empty-rt-expected.png:
* platform/win/fast/ruby/ruby-empty-rt-expected.txt:
* platform/win/fast/ruby/ruby-length-expected.checksum:
* platform/win/fast/ruby/ruby-length-expected.png:
* platform/win/fast/ruby/ruby-length-expected.txt:
* platform/win/fast/ruby/ruby-run-break-expected.checksum:
* platform/win/fast/ruby/ruby-run-break-expected.png:
* platform/win/fast/ruby/ruby-run-break-expected.txt:
* platform/win/fast/ruby/ruby-runs-expected.checksum:
* platform/win/fast/ruby/ruby-runs-expected.png:
* platform/win/fast/ruby/ruby-runs-expected.txt:
* platform/win/fast/ruby/ruby-runs-spans-expected.checksum:
* platform/win/fast/ruby/ruby-runs-spans-expected.png:
* platform/win/fast/ruby/ruby-runs-spans-expected.txt:
* platform/win/fast/ruby/ruby-simple-expected.checksum:
* platform/win/fast/ruby/ruby-simple-expected.png:
* platform/win/fast/ruby/ruby-simple-expected.txt:
* platform/win/fast/ruby/ruby-simple-rp-expected.checksum:
* platform/win/fast/ruby/ruby-simple-rp-expected.png:
* platform/win/fast/ruby/ruby-simple-rp-expected.txt:
* platform/win/fast/ruby/ruby-trailing-expected.checksum:
* platform/win/fast/ruby/ruby-trailing-expected.png:
* platform/win/fast/ruby/ruby-trailing-expected.txt:
* platform/win/fast/ruby/rubyDOM-insert-rt-expected.checksum:
* platform/win/fast/ruby/rubyDOM-insert-rt-expected.png:
* platform/win/fast/ruby/rubyDOM-insert-rt-expected.txt:
* platform/win/fast/ruby/rubyDOM-insert-text1-expected.checksum:
* platform/win/fast/ruby/rubyDOM-insert-text1-expected.png:
* platform/win/fast/ruby/rubyDOM-insert-text1-expected.txt:
* platform/win/fast/ruby/rubyDOM-insert-text2-expected.checksum:
* platform/win/fast/ruby/rubyDOM-insert-text2-expected.png:
* platform/win/fast/ruby/rubyDOM-insert-text2-expected.txt:
* platform/win/fast/ruby/rubyDOM-insert-text3-expected.checksum:
* platform/win/fast/ruby/rubyDOM-insert-text3-expected.png:
* platform/win/fast/ruby/rubyDOM-insert-text3-expected.txt:
* platform/win/fast/ruby/rubyDOM-remove-rt1-expected.checksum:
* platform/win/fast/ruby/rubyDOM-remove-rt1-expected.png:
* platform/win/fast/ruby/rubyDOM-remove-rt1-expected.txt:
* platform/win/fast/ruby/rubyDOM-remove-rt2-expected.checksum:
* platform/win/fast/ruby/rubyDOM-remove-rt2-expected.png:
* platform/win/fast/ruby/rubyDOM-remove-rt2-expected.txt:
* platform/win/fast/ruby/rubyDOM-remove-text1-expected.checksum:
* platform/win/fast/ruby/rubyDOM-remove-text1-expected.png:
* platform/win/fast/ruby/rubyDOM-remove-text1-expected.txt:
* platform/win/fast/ruby/rubyDOM-remove-text2-expected.checksum:
* platform/win/fast/ruby/rubyDOM-remove-text2-expected.png:
* platform/win/fast/ruby/rubyDOM-remove-text2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-14 Norbert Leser <norbert.leser@nokia.com>
eric@webkit.org [Fri, 15 Jan 2010 04:20:37 +0000 (04:20 +0000)]
2010-01-14  Norbert Leser  <norbert.leser@nokia.com>

        Reviewed by Laszlo Gombos.

        Platform Symbian specific:
        Added time-based optimization (-Otime) and increased optimization level to -O3,
        conditionally for RVCT compiler (for ARM), for increasing performance
        (primarily affecting JavaScript execution).
        Default settings are -Ospace and -O2.

        No new tests needed because no new funtionality is introduced,
        only potential regression on existing tests needs to be evaluated.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-14 Marcus Bulach <bulach@chromium.org>
eric@webkit.org [Fri, 15 Jan 2010 02:44:05 +0000 (02:44 +0000)]
2010-01-14  Marcus Bulach  <bulach@chromium.org>

        Reviewed by Dimitri Glazkov.

        Adds WebKit::WebSecurityOrigin::createFromDatabaseIdentifier.
        https://bugs.webkit.org/show_bug.cgi?id=33648

        * public/WebSecurityOrigin.h:
        * src/WebSecurityOrigin.cpp:
        (WebKit::WebSecurityOrigin::createFromDatabaseIdentifier):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-14 Jungshik Shin <jshin@chromium.org>
jshin@chromium.org [Fri, 15 Jan 2010 02:42:16 +0000 (02:42 +0000)]
2010-01-14  Jungshik Shin  <jshin@chromium.org>

        Unreviewed, attempted build fix on chromium.

        Fix a Chromium build failure due to an unused variable in V8 binding.(part 2)

        * bindings/v8/V8Collection.h:
        (WebCore::getNamedPropertyOfCollection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-14 Jungshik Shin <jshin@chromium.org>
jshin@chromium.org [Fri, 15 Jan 2010 02:35:38 +0000 (02:35 +0000)]
2010-01-14  Jungshik Shin  <jshin@chromium.org>

        Unreviewed, attempted build fix on chromium.

        Fix a Chromium build failure due to an unused variable in V8 binding.

        * bindings/v8/V8Collection.h:
        (WebCore::getIndexedPropertyOfCollection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, attempted build fix.
pkasting@chromium.org [Fri, 15 Jan 2010 02:04:50 +0000 (02:04 +0000)]
Unreviewed, attempted build fix.

* platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::haveDecodedRow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-14 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Fri, 15 Jan 2010 01:52:40 +0000 (01:52 +0000)]
2010-01-14  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        animations/change-keyframes.html failed on Tiger Bot
        https://bugs.webkit.org/show_bug.cgi?id=33370

        Increase tolerances. They're still testing the stated goal of the test.

        * animations/change-keyframes.html:
        * transitions/cancel-transition.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSimplify image decoders by making downsampling functions available at
pkasting@chromium.org [Fri, 15 Jan 2010 01:45:23 +0000 (01:45 +0000)]
Simplify image decoders by making downsampling functions available at
all times, allowing much duplicated logic to be collapsed.
https://bugs.webkit.org/show_bug.cgi?id=28751

Reviewed by Adam Barth.

* platform/graphics/ImageSource.cpp:
(WebCore::ImageSource::setData):
* platform/image-decoders/ImageDecoder.cpp:
(WebCore::ImageDecoder::prepareScaleDataIfNecessary):
* platform/image-decoders/ImageDecoder.h:
(WebCore::ImageDecoder::ImageDecoder):
(WebCore::ImageDecoder::scaledSize):
(WebCore::ImageDecoder::setMaxNumPixels):
* platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::sizeNowAvailable):
(WebCore::GIFImageDecoder::initFrameBuffer):
(WebCore::GIFImageDecoder::haveDecodedRow):
(WebCore::GIFImageDecoder::frameComplete):
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::JPEGImageDecoder::setSize):
(WebCore::JPEGImageDecoder::outputScanlines):
* platform/image-decoders/jpeg/JPEGImageDecoder.h:
* platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::PNGImageDecoder::headerAvailable):
(WebCore::PNGImageDecoder::rowAvailable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Remove obsolete CF related files from gyp build.
jianli@chromium.org [Fri, 15 Jan 2010 01:34:56 +0000 (01:34 +0000)]
[chromium] Remove obsolete CF related files from gyp build.
https://bugs.webkit.org/show_bug.cgi?id=33002

Reviewed by Eric Seidel.

* WebCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSkip new test that requires new functionality in
kov@webkit.org [Fri, 15 Jan 2010 01:34:41 +0000 (01:34 +0000)]
Skip new test that requires new functionality in
DRT (layoutTestController.setWillSendRequestReturnsNull).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSkipping test that fails intermitently - fix for the test being
kov@webkit.org [Fri, 15 Jan 2010 01:31:56 +0000 (01:31 +0000)]
Skipping test that fails intermitently - fix for the test being
worked on; see https://bugs.webkit.org/show_bug.cgi?id=33671.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDecoding images to scaled output buffers resulted in garbage for
pkasting@chromium.org [Fri, 15 Jan 2010 01:30:04 +0000 (01:30 +0000)]
Decoding images to scaled output buffers resulted in garbage for
no-alpha PNGs and CMYK JPEGs.
https://bugs.webkit.org/show_bug.cgi?id=33624

Reviewed by Adam Barth.

No layout test since I don't have access to a platform that scales the
output buffers.

* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::convertCMYKToRGBA):
* platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::PNGImageDecoder::rowAvailable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Eric Seidel.
kov@webkit.org [Fri, 15 Jan 2010 01:25:38 +0000 (01:25 +0000)]
    Reviewed by Eric Seidel.

        [GTK] Crashes cleaning clipboard contents, with page cache enabled
        https://bugs.webkit.org/show_bug.cgi?id=32900

        Null-check the focus controller to avoid crashing. Could not find
        a way to reproduce this consistently, thus no test.

        * WebCoreSupport/PasteboardHelperGtk.cpp:
        (WebKit::clearClipboardContentsCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-13 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Fri, 15 Jan 2010 01:24:20 +0000 (01:24 +0000)]
2010-01-13  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        LayoutTests/animations/play-state.html and LayoutTests/animations/3d/transform-origin-vs-functions.html are flaky
        https://bugs.webkit.org/show_bug.cgi?id=33626

        Speculative fixes.

        * animations/3d/transform-origin-vs-functions.html:
        Remove timeout for notifyDone and start measurement at
        webkitAnimationStart instead of body onload.
        * animations/play-state-expected.txt:
        * animations/play-state.html:
        Reduce test time in half, but keep the same tolerance level.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-13 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Fri, 15 Jan 2010 01:22:54 +0000 (01:22 +0000)]
2010-01-13  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        A few more flaky transitions/animations tests
        https://bugs.webkit.org/show_bug.cgi?id=33642

        Attempt to deflake a few more tests. Some of these are second
        attempts. The first attempt made it less flaky, but not 100%.
        Also, for a couple tests, make them shorter. They seemed
        unnecessarily long.

        * animations/change-one-anim-expected.txt:
        * animations/change-one-anim.html:
        * transitions/cancel-transition.html:
        * transitions/mask-transitions.html:
        * transitions/shorthand-border-transitions-expected.txt:
        * transitions/shorthand-border-transitions.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Oliver Hunt.
bweinstein@apple.com [Fri, 15 Jan 2010 01:17:44 +0000 (01:17 +0000)]
Rubber-stamped by Oliver Hunt.

Fix an assertion that was causing test crashes. Filed a bug
about the weirdness that causes this assertion (inconsistencies
between DragOperationMove and DragOperationGeneric).

* dom/Clipboard.cpp:
(WebCore::dragOpFromIEOp):
(WebCore::Clipboard::setDestinationOperation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=33498 REGRESSION:
bdakin@apple.com [Fri, 15 Jan 2010 01:13:18 +0000 (01:13 +0000)]
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=33498 REGRESSION:
svg/css/circle-in-mask-with-shadow.svg failing pixel tests
-and corresponding-
<rdar://problem/7544176>

Reviewed by Sam Weinig.

This change makes repaintRectInLocalCoordinates return a rect that
is -webkit-svg-shadow-aware.

* rendering/RenderPath.cpp:
(WebCore::RenderPath::repaintRectInLocalCoordinates):
* rendering/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):
* rendering/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::repaintRectInLocalCoordinates):
* rendering/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::repaintRectInLocalCoordinates):
* rendering/RenderSVGText.cpp:
(WebCore::RenderSVGText::repaintRectInLocalCoordinates):
* rendering/SVGRenderSupport.cpp:
(WebCore::SVGRenderBase::prepareToRenderSVGContent):
* rendering/style/SVGRenderStyle.cpp:
(WebCore::SVGRenderStyle::inflateForShadow):
* rendering/style/SVGRenderStyle.h:

LayoutTests: Tests for https://bugs.webkit.org/show_bug.cgi?id=33498 REGRESSION:
svg/css/circle-in-mask-with-shadow.svg failing pixel tests
-and corresponding-
<rdar://problem/7544176>

Reviewed by Sam Weinig.

All of these tests just needed to be updated because of small
rounding differences.

* platform/mac/fast/repaint/moving-shadow-on-container-expected.checksum:
* platform/mac/fast/repaint/moving-shadow-on-container-expected.png:
* platform/mac/fast/repaint/moving-shadow-on-container-expected.txt:
* platform/mac/fast/repaint/moving-shadow-on-path-expected.checksum:
* platform/mac/fast/repaint/moving-shadow-on-path-expected.png:
* platform/mac/fast/repaint/moving-shadow-on-path-expected.txt:
* platform/mac/svg/css/arrow-with-shadow-expected.png:
* platform/mac/svg/css/arrow-with-shadow-expected.txt:
* platform/mac/svg/css/circle-in-mask-with-shadow-expected.checksum:
* platform/mac/svg/css/circle-in-mask-with-shadow-expected.png:
* platform/mac/svg/css/circle-in-mask-with-shadow-expected.txt:
* platform/mac/svg/css/clippath-with-shadow-expected.png:
* platform/mac/svg/css/composite-shadow-example-expected.checksum:
* platform/mac/svg/css/composite-shadow-example-expected.png:
* platform/mac/svg/css/composite-shadow-example-expected.txt:
* platform/mac/svg/css/composite-shadow-with-opacity-expected.checksum:
* platform/mac/svg/css/composite-shadow-with-opacity-expected.png:
* platform/mac/svg/css/composite-shadow-with-opacity-expected.txt:
* platform/mac/svg/css/css-box-min-width-expected.checksum:
* platform/mac/svg/css/css-box-min-width-expected.png:
* platform/mac/svg/css/group-with-shadow-expected.txt:
* platform/mac/svg/css/mask-with-shadow-expected.txt:
* platform/mac/svg/css/path-with-shadow-expected.png:
* platform/mac/svg/css/path-with-shadow-expected.txt:
* platform/mac/svg/css/shadow-and-opacity-expected.txt:
* platform/mac/svg/css/shadow-with-large-radius-expected.txt:
* platform/mac/svg/css/shadow-with-negative-offset-expected.txt:
* platform/mac/svg/css/stars-with-shadow-expected.checksum:
* platform/mac/svg/css/stars-with-shadow-expected.png:
* platform/mac/svg/css/stars-with-shadow-expected.txt:
* platform/mac/svg/filters/shadow-on-rect-with-filter-expected.checksum:
* platform/mac/svg/filters/shadow-on-rect-with-filter-expected.png:
* platform/mac/svg/filters/shadow-on-rect-with-filter-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-14 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 15 Jan 2010 00:50:37 +0000 (00:50 +0000)]
2010-01-14  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        REGRESSION(53133): commit-queue no longer rejects patches with invalid committers, instead it hangs
        https://bugs.webkit.org/show_bug.cgi?id=33638

        * Scripts/webkitpy/bugzilla.py:
         - Add Bug.id() to match Attachment.id()
         - Give Bug.reviewed_patches and commit_queued_patches the option to return patches with invalid committers/reviewers.
         - Add back a missing variable to _validate_setter_email found by the new unit tests!
        * Scripts/webkitpy/commands/queries.py:
         - Add FIXMEs about the commands being confusingly named.
        * Scripts/webkitpy/commands/queries_unittest.py:
         - Update results to reflect the newly restructured mock bug cache.
        * Scripts/webkitpy/commands/queues.py:
         - Add a new _validate_patches_in_commit_queue method (this is what fixes the regression).
         - Add a FIXME about eventually sorting the patches into some order.
        * Scripts/webkitpy/commands/queues_unittest.py:
         - Update results now that with the newly restructure mock bug cache we're testing cq+'d patches with an invalid committer.
        * Scripts/webkitpy/commands/upload_unittest.py:
         - Update results to match the newly restructured mock bug cache.
        * Scripts/webkitpy/mock_bugzillatool.py:
         - Restructure fetch_ methods to not use a manual list of ids, but rather use Bug and Attachment classes to make real queries from all of the Bugs.
         - Add a few more attachments and bug dictionaries for use by the tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNot reviewed. Fix reviewer.
zimmermann@webkit.org [Fri, 15 Jan 2010 00:08:14 +0000 (00:08 +0000)]
Not reviewed. Fix reviewer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDrag and Drop source/destination code needs cleanup.
bweinstein@apple.com [Fri, 15 Jan 2010 00:06:18 +0000 (00:06 +0000)]
Drag and Drop source/destination code needs cleanup.
<https://bugs.webkit.org/show_bug.cgi?id=33691>.

Reviewed by Adam Roben.

WebCore:

Cleaned up some Drag and Drop code that deals with getting
source and destination operations, and added some ASSERTS to make
sure we don't get in bad states.

* dom/Clipboard.cpp:
(WebCore::Clipboard::sourceOperation): Make this return the operation itself.
(WebCore::Clipboard::destinationOperation): Ditto.
(WebCore::Clipboard::setSourceOperation): Add an assert to make sure we're valud.
(WebCore::Clipboard::setDestinationOperation): Ditto.
* dom/Clipboard.h:
* page/DragController.cpp:
(WebCore::DragController::tryDHTMLDrag):
* page/EventHandler.cpp:
(WebCore::EventHandler::handleDrag):

WebKit/chromium:

Update to new way of calling sourceOperation.

* src/DragClientImpl.cpp:
(WebKit::DragClientImpl::startDrag):

WebKit/qt:

Update to new way of calling sourceOperation.

* WebCoreSupport/DragClientQt.cpp:
(WebCore::DragClientQt::startDrag):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake the Web Inspector's JavaScript debugger work with isolated worlds.
timothy@apple.com [Thu, 14 Jan 2010 23:38:24 +0000 (23:38 +0000)]
Make the Web Inspector's JavaScript debugger work with isolated worlds.
Console evaluation is not performed in the correct world yet, tracked
by bug http://webkit.org/b/33692.

http://webkit.org/b/33690

Reviewed by Adam Roben.

* bindings/js/ScriptCachedFrameData.cpp:
(WebCore::ScriptCachedFrameData::restore): Attach the debugger to
any window shell, not just for the debugger world.
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::clearWindowShell): Detach the debugger, and
reattach to all window shells, not just for the debugger world.
(WebCore::ScriptController::initScript): Attach the debugger to
any window shell, not just for the debugger world.
(WebCore::ScriptController::attachDebugger): Changed to loop through
all the window shells and call the new overloaded attachDebugger.
(WebCore::ScriptController::attachDebugger): Added. An overload that
takes a window shell to attach the debugger to. Has most of the
logic from the original attachDebugger.
* bindings/js/ScriptController.h: Added the new attachDebugger.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Oliver Hunter.
kov@webkit.org [Thu, 14 Jan 2010 23:08:46 +0000 (23:08 +0000)]
    Reviewed by Oliver Hunter.

        [GTK] couple fixes for signal emissions, and property notifications
        https://bugs.webkit.org/show_bug.cgi?id=33428

        Do not emit signals and property notifications for error
        pages. The notifications are not really useful for anything, you
        can get them back by overriding the error pages, and it avoids a
        number of hacks.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::FrameLoaderClient):
        (WebKit::FrameLoaderClient::dispatchDidFinishLoad):
        (WebKit::FrameLoaderClient::dispatchDidReceiveIcon):
        (WebKit::FrameLoaderClient::dispatchDidStartProvisionalLoad):
        (WebKit::FrameLoaderClient::dispatchDidReceiveTitle):
        (WebKit::FrameLoaderClient::dispatchDidCommitLoad):
        (WebKit::FrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout):
        (WebKit::FrameLoaderClient::dispatchDidFailLoad):
        * WebCoreSupport/FrameLoaderClientGtk.h:
        * tests/testloading.c:
        (load_error_status_changed_cb):
        (test_loading_error):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd missing Radar URLs
aroben@apple.com [Thu, 14 Jan 2010 23:07:32 +0000 (23:07 +0000)]
Add missing Radar URLs

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-14 Adam Roben <aroben@apple.com>
aroben@apple.com [Thu, 14 Jan 2010 23:05:38 +0000 (23:05 +0000)]
2010-01-14  Adam Roben  <aroben@apple.com>

        Add a test that shows onload still fires if a load of a <script src>
        is cancelled by the resource load delegate

        Tests for <http://webkit.org/b/33687> window.onload never fires if
        page contains a <script src=foo> whose load is cancelled by resource
        load delegate returning null from willSendRequest

        Reviewed by Dave Hyatt.

        * fast/loader/onload-willSendRequest-null-for-script-expected.txt: Added.
        * fast/loader/onload-willSendRequest-null-for-script.html: Added.

        * platform/qt/Skipped: Added the new test since Qt doesn't have
        layoutTestController.setWillSendRequestReturnsNull.
2010-01-14  Adam Roben  <aroben@apple.com>

        Make Cache::requestResource return 0 if the resource's load fails
        immediately

        Fixes <http://webkit.org/b/33687> window.onload never fires if page
        contains a <script src=foo> whose load is cancelled by resource load
        delegate returning null from willSendRequest

        Test: fast/loader/onload-willSendRequest-null-for-script.html

        Reviewed by Dave Hyatt.

        * loader/Cache.cpp:
        (WebCore::Cache::requestResource): Moved code to handle immediate load
        failure out of the "cache is disabled" block so that it will run even
        when the cache is enabled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Fix for crash with gradient on table cell. Pass the correct
senorblanco@chromium.org [Thu, 14 Jan 2010 22:35:33 +0000 (22:35 +0000)]
WebCore: Fix for crash with gradient on table cell.  Pass the correct
background object down to
RenderBoxModelObject::paintFillLayerExtended().  This also allowed a
rework of the fix to bug 18445 by passing the correct RenderObject
from RenderBox::paintRootBoxDecorations() down to
RenderBoxModelObject::paintFillLayerExtended().
https://bugs.webkit.org/show_bug.cgi?id=28426

Reviewed by mitz@webkit.org.

Covered by new layout test:  LayoutTests/fast/gradients/crash-on-tr.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintFillLayers):
(WebCore::RenderBox::paintFillLayer):
* rendering/RenderBox.h:
Plumb through the correct background RenderObject.
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
Use the passed-in background RenderObject (if present) when painting background images.  Remove the previous fix for bug 18445.
* rendering/RenderBoxModelObject.h:
Plumb through the correct background RenderObject.
* rendering/RenderTableCell.cpp:
Pass in the correct backgroundObject to paintFillLayers().

(WebCore::RenderTableCell::paintBackgroundsBehindCell):

LayoutTests: New layout test added to exercise fix for bug
http://bugs.webkit.org/show_bug.cgi?id=28426

Reviewed by mitz@webkit.org.

* fast/gradients/crash-on-tr-expected.txt: Added.
* fast/gradients/crash-on-tr.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-14 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Thu, 14 Jan 2010 22:07:58 +0000 (22:07 +0000)]
2010-01-14  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        Standardize the rest of the v8 bindings on toNative() wherever possible.

        https://bugs.webkit.org/show_bug.cgi?id=33677

        * bindings/v8/NPV8Object.cpp:
        (v8ObjectToNPObject): Special case for converting NPObjects, since there aren't genereated bindings for them.
        * bindings/v8/NPV8Object.h:
        * bindings/v8/ScriptController.cpp:
        * bindings/v8/V8Collection.cpp:
        * bindings/v8/V8Collection.h:
        (WebCore::toNativeCollection): Special case for converting V8Collections, since there aren't genereated bindings for them.
        * bindings/v8/V8DOMWindowShell.cpp:
        * bindings/v8/V8DOMWrapper.cpp:
        * bindings/v8/V8DOMWrapper.h:
        * bindings/v8/V8NPObject.cpp:
        * bindings/v8/V8Proxy.cpp:
        * bindings/v8/V8SVGPODTypeWrapper.h:
        * bindings/v8/WorkerContextExecutionProxy.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-14 Evan Stade <estade@chromium.org>
eric@webkit.org [Thu, 14 Jan 2010 21:21:14 +0000 (21:21 +0000)]
2010-01-14  Evan Stade  <estade@chromium.org>

        Reviewed by Eric Seidel.

        Chromium Linux: don't stretch checkboxes
        https://bugs.webkit.org/show_bug.cgi?id=28631

        * fast/css/non-standard-checkbox-size.html: Added.
        * platform/mac/fast/css/non-standard-checkbox-size-expected.checksum: Added.
        * platform/mac/fast/css/non-standard-checkbox-size-expected.png: Added.
        * platform/mac/fast/css/non-standard-checkbox-size-expected.txt: Added.
        * platform/gtk/Skipped: Skipping this new test so I don't break this bot.  Just needs new results.
        * platform/qt/Skipped: ditto
        * platform/win/Skipped: ditto
2010-01-14  Evan Stade  <estade@chromium.org>

        Reviewed by Eric Seidel.

        Chromium Linux: don't stretch checkboxes
        https://bugs.webkit.org/show_bug.cgi?id=28631

        Make the default size for checkboxes/radio buttons also the maximum
        size.

        Based on patch by Adam Langley.

        Test: fast/css/non-standard-checkbox-size.html

        * rendering/RenderThemeChromiumSkia.cpp:
        (WebCore::center):
        (WebCore::RenderThemeChromiumSkia::paintCheckbox):
        (WebCore::RenderThemeChromiumSkia::setCheckboxSize):
        (WebCore::RenderThemeChromiumSkia::paintRadio):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFollow up to <https://bugs.webkit.org/show_bug.cgi?id=33635>.
bweinstein@apple.com [Thu, 14 Jan 2010 21:16:21 +0000 (21:16 +0000)]
Follow up to <https://bugs.webkit.org/show_bug.cgi?id=33635>.

Reviewed by Adam Roben.

Now that dropEffect and effectAllowed are guaranteed to not be
null, change null checks into asserts to make sure we are returning
a proper DragOperation value.

* dom/Clipboard.cpp:
(WebCore::Clipboard::sourceOperation): Change null check to assert.
(WebCore::Clipboard::destinationOperation): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[DnD] effectAllowed and dropEffect can be set to bogus values.
bweinstein@apple.com [Thu, 14 Jan 2010 20:47:53 +0000 (20:47 +0000)]
[DnD] effectAllowed and dropEffect can be set to bogus values.
Fixes <https://bugs.webkit.org/show_bug.cgi?id=33635>.

Reviewed by Oliver Hunt.

WebCore:

Test to make aure dropEffect and effectAllowed are being set to valid values
when they are being set (list of valid values given by HTML5 specification).

Also, drive by change to initialize dropEffect to none (as described in spec).

Test: fast/events/bogus-dropEffect-effectAllowed.html

* dom/Clipboard.cpp:
(WebCore::Clipboard::Clipboard): Initialize m_dropEffect to "none".
(WebCore::Clipboard::setDropEffect): Check if dropEffect is being set to a valid value.
(WebCore::Clipboard::setEffectAllowed): Check if effectAllowed is being set to a valid value.

LayoutTests:

Added a test to check the handling of setting effectAllowed and
dropEffect to bogus values (that it gets ignored), and updated results
to drag-and-drop because it uses a dummy value.

Also, fixed a few tests that broke when the default dropEffect was set to
none to match the spec.

* fast/events/bogus-dropEffect-effectAllowed-expected.txt: Added.
* fast/events/bogus-dropEffect-effectAllowed.html: Added.
* platform/gtk/fast/events/bogus-dropEffect-effectAllowed-expected.txt: Added.
* platform/qt/fast/events/bogus-dropEffect-effectAllowed.html: Added.

* fast/events/drag-and-drop-expected.txt:
* fast/events/drag-and-drop.html:
* editing/pasteboard/script-tests/files-during-page-drags.js:
* editing/pasteboard/get-data-text-plain-drop.html:
* fast/events/resources/drag-in-frames-right.html:
* http/tests/local/resources/send-dragged-file.js:
* http/tests/misc/bubble-drag-events.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd new test from r53277 to the GTK+ Skipped list
aroben@apple.com [Thu, 14 Jan 2010 20:39:32 +0000 (20:39 +0000)]
Add new test from r53277 to the GTK+ Skipped list

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-14 Kent Hansen <kent.hansen@nokia.com>
eric@webkit.org [Thu, 14 Jan 2010 20:13:28 +0000 (20:13 +0000)]
2010-01-14  Kent Hansen  <kent.hansen@nokia.com>

        Reviewed by Darin Adler.

        Infinite recursion in RuntimeObjectImp::getOwnPropertyNames()
        https://bugs.webkit.org/show_bug.cgi?id=33371

        Test that Object.keys works on a plugin object.

        * plugins/netscape-enumerate.html:
2010-01-14  Kent Hansen  <kent.hansen@nokia.com>

        Reviewed by Darin Adler.

        Infinite recursion in RuntimeObjectImp::getOwnPropertyNames()
        https://bugs.webkit.org/show_bug.cgi?id=33371

        RuntimeObjectImp should not reimplement getPropertyNames();
        move the implementation to getOwnPropertyNames().

        * bridge/runtime_object.cpp:
        (JSC::RuntimeObjectImp::getOwnPropertyNames):
        * bridge/runtime_object.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-14 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Thu, 14 Jan 2010 19:57:14 +0000 (19:57 +0000)]
2010-01-14  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Alexey Proskuryakov.

        Add ENABLE(XSLT) guard to TransformSourceLibxslt.cpp
        https://bugs.webkit.org/show_bug.cgi?id=33665

        TransformSource is available only when ENABLE(XSLT) guard is true.

        * dom/TransformSourceLibxslt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix ChangeLog order from r53277
aroben@apple.com [Thu, 14 Jan 2010 19:52:21 +0000 (19:52 +0000)]
Fix ChangeLog order from r53277

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd new tests from r53277 to the Qt Skipped list
aroben@apple.com [Thu, 14 Jan 2010 19:52:12 +0000 (19:52 +0000)]
Add new tests from r53277 to the Qt Skipped list

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] DRT missing setUserStyleSheetLocation and setUserStyleSheetEnabled in LayoutTest...
tonikitoo@webkit.org [Thu, 14 Jan 2010 19:47:55 +0000 (19:47 +0000)]
[Qt] DRT missing setUserStyleSheetLocation and setUserStyleSheetEnabled in LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=33617

Patch by Diego Gonzalez <diego.gonzalez@openbossa.org> on 2010-01-13
Reviewed by Kenneth Christiansen.

WebKitTools:

* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::WebPage::resetSettings):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::setUserStyleSheetLocation):
(LayoutTestController::setUserStyleSheetEnabled):
* DumpRenderTree/qt/LayoutTestControllerQt.h:

LayoutTests:

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTreat all synchronous loads equally in FrameLoader::loadSubframe
aroben@apple.com [Thu, 14 Jan 2010 19:29:51 +0000 (19:29 +0000)]
Treat all synchronous loads equally in FrameLoader::loadSubframe

Only loads of the empty URL or about:blank were being treated as
synchronous loads. But other loads can be synchronous (e.g., when we
receive a null ResourceRequest from requestFromDelegate or when a
policy decision of "ignore" is made). We now treat those loads the
same way we treated empty URLs and about:blank.

Fixes <rdar://problem/7533333> <http://webkit.org/b/33533>
window.onload never fires if page contains an <iframe> with a bad
scheme or whose load is cancelled by returning null from resource load
delegate's willSendRequest

Tests: fast/loader/onload-bad-scheme-for-frame.html
       fast/loader/onload-policy-ignore-for-frame.html
       fast/loader/onload-willSendRequest-null-for-frame.html

Reviewed by Brady Eidson.

WebCore:

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadSubframe):
  - Detect synchronous loads by checking the subframe's loader's
    state, rather than by checking its URL
  - Removed unnecessary call to completed(), since checkCompleted()
    will call completed() if needed (the call to completed() was added
    first and wasn't removed when the call to checkCompleted() was
    added in r8316)
  - Added more comments about the strange thing this function does
    with the subframe's loader

WebKitTools:

Add LayoutTestController API to force
-webView:resource:willSendRequest:: to return null

* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController): Initialize new member.
(setWillSendRequestReturnsNullCallback): Call through to
LayoutTestController.
(LayoutTestController::staticFunctions): Added new function.

* DumpRenderTree/LayoutTestController.h: Added
m_willSendRequestReturnsNull.
(LayoutTestController::willSendRequestReturnsNull):
(LayoutTestController::setWillSendRequestReturnsNull):
Added standard accessors.

* DumpRenderTree/mac/ResourceLoadDelegate.mm:
(-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
* DumpRenderTree/win/ResourceLoadDelegate.cpp:
(ResourceLoadDelegate::willSendRequest):
Return null if LayoutTestController says to.

LayoutTests:

Add tests that show that onload still fires in various situations with
subframes

* fast/loader/onload-bad-scheme-for-frame-expected.txt: Added.
* fast/loader/onload-bad-scheme-for-frame.html: Added.
Tests that onload still fires when a subframe with an unrecognized
scheme is in the page.

* fast/loader/onload-policy-ignore-for-frame-expected.txt: Added.
* fast/loader/onload-policy-ignore-for-frame.html: Added.
Tests that onload still fires when the policy delegate says to ignore
the initial load of a subframe.

* fast/loader/onload-willSendRequest-null-for-frame-expected.txt: Added.
* fast/loader/onload-willSendRequest-null-for-frame.html: Added.
Tests that onload still fires when the resource load delegate returns
null from willSendRequest for the initial load of a subframe.

* http/tests/loading/bad-scheme-subframe-expected.txt: Updated result
to show that we now fire onload for the main frame in this case. (This
is essentially the same as onload-bad-scheme-for-frame.html, but it
still seems useful to have that new, more explicit, test.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMissing fileSystemPath() method in Qt KURL implementation https://bugs.webkit.org...
tonikitoo@webkit.org [Thu, 14 Jan 2010 19:20:27 +0000 (19:20 +0000)]
Missing fileSystemPath() method in Qt KURL implementation https://bugs.webkit.org/show_bug.cgi?id=33614

Patch by Diego Gonzalez <diego.gonzalez@openbossa.org> on 2010-01-14
Reviewed by Kenneth Christiansen.

No new tests.

* platform/qt/KURLQt.cpp:
(WebCore::KURL::fileSystemPath):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agowx fixes after XBM removal and recent changes.
kevino@webkit.org [Thu, 14 Jan 2010 19:10:19 +0000 (19:10 +0000)]
wx fixes after XBM removal and recent changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Brady Eidson.
ap@apple.com [Thu, 14 Jan 2010 19:03:39 +0000 (19:03 +0000)]
    Reviewed by Brady Eidson.

        https://bugs.webkit.org/show_bug.cgi?id=33652
        REGRESSION: Frames stop appearing after browsing for a while

        <rdar://problem/7308312> REGRESSION: iBench gets slower after several runs

        I do not know how not creating renderers for frames could make iBench slower, but it did.

        Test: fast/frames/cached-frame-counter.html

        * history/CachedFrame.cpp:
        (WebCore::CachedFrame::CachedFrame): A frame that's cached is moved away from Page,
        so decrement frame count here.
        (WebCore::CachedFrame::open): Increase frame count when a frame is restored.

        * history/CachedFrame.h: Remove unneeded forward declarations.

        * history/CachedPage.h: Ditto.

        * history/CachedPage.cpp: (WebCore::CachedPage::restore): Assert that page frame count is
        zero prior to restoring a page from b/f cache.

        * page/Page.cpp: (WebCore::Page::checkFrameCountConsistency): A debug-only method to
        check that frame count stored in Page matches the number of frames in frame tree.

        * page/Page.h:
        (WebCore::Page::decrementFrameCount): Assert that frame count is positive.
        (WebCore::Page::frameCount): Call checkFrameCountConsistency().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows build fixes.
sfalken@apple.com [Thu, 14 Jan 2010 18:56:33 +0000 (18:56 +0000)]
Windows build fixes.
Add forward declarations and additional includes of windows.h.

* platform/Cursor.h: Add forward declaration of HCURSOR. Move destructor implementation into cpp.
* platform/graphics/transforms/TransformationMatrix.h: Add forward declaration of XFORM. Remove windows.h include.
* platform/graphics/win/TransformationMatrixWin.cpp: Add include of windows.h.
* platform/win/CursorWin.cpp: Moved destructor of SharedCursor here.
(WebCore::SharedCursor::~SharedCursor): Moved here.
* platform/win/EventLoopWin.cpp: Add include of windows.h.
* platform/win/SystemInfo.cpp: Add include of windows.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRoll out r53270 because it broke 5 layout tests.
bweinstein@apple.com [Thu, 14 Jan 2010 18:47:50 +0000 (18:47 +0000)]
Roll out r53270 because it broke 5 layout tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-14 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Thu, 14 Jan 2010 18:32:13 +0000 (18:32 +0000)]
2010-01-14  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        Switch the custom V8 bindings to use class toNative() functions.

        Refactoring, so no new tests.

        * bindings/v8/custom/V8AbstractWorkerCustom.cpp:
        * bindings/v8/custom/V8AttrCustom.cpp:
        * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
        * bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
        * bindings/v8/custom/V8ClipboardCustom.cpp:
        * bindings/v8/custom/V8CoordinatesCustom.cpp:
        * bindings/v8/custom/V8DOMApplicationCacheCustom.cpp:
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        * bindings/v8/custom/V8DataGridColumnListCustom.cpp:
        * bindings/v8/custom/V8DatabaseCustom.cpp:
        * bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
        * bindings/v8/custom/V8DocumentCustom.cpp:
        * bindings/v8/custom/V8DocumentLocationCustom.cpp:
        * bindings/v8/custom/V8ElementCustom.cpp:
        * bindings/v8/custom/V8EventCustom.cpp:
        * bindings/v8/custom/V8GeolocationCustom.cpp:
        * bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
        * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
        * bindings/v8/custom/V8HTMLCollectionCustom.cpp:
        * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
        * bindings/v8/custom/V8HTMLFormElementCustom.cpp:
        * bindings/v8/custom/V8HTMLFrameElementCustom.cpp:
        * bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:
        * bindings/v8/custom/V8HTMLIFrameElementCustom.cpp:
        * bindings/v8/custom/V8HTMLInputElementCustom.cpp:
        * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
        * bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:
        * bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
        * bindings/v8/custom/V8HistoryCustom.cpp:
        * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
        * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
        * bindings/v8/custom/V8LocationCustom.cpp:
        * bindings/v8/custom/V8MessageEventCustom.cpp:
        * bindings/v8/custom/V8MessagePortCustom.cpp:
        * bindings/v8/custom/V8NamedNodeMapCustom.cpp:
        * bindings/v8/custom/V8NodeCustom.cpp:
        * bindings/v8/custom/V8NodeIteratorCustom.cpp:
        * bindings/v8/custom/V8NodeListCustom.cpp:
        * bindings/v8/custom/V8NotificationCenterCustom.cpp:
        * bindings/v8/custom/V8PopStateEventCustom.cpp:
        * bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
        * bindings/v8/custom/V8SQLTransactionCustom.cpp:
        * bindings/v8/custom/V8SVGElementInstanceCustom.cpp:
        * bindings/v8/custom/V8SVGLengthCustom.cpp:
        * bindings/v8/custom/V8SVGMatrixCustom.cpp:
        * bindings/v8/custom/V8StorageCustom.cpp:
        * bindings/v8/custom/V8StyleSheetListCustom.cpp:
        * bindings/v8/custom/V8TreeWalkerCustom.cpp:
        * bindings/v8/custom/V8WebGLArrayCustom.h:
        * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
        * bindings/v8/custom/V8WebSocketCustom.cpp:
        * bindings/v8/custom/V8WorkerContextCustom.cpp:
        * bindings/v8/custom/V8WorkerCustom.cpp:
        * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
        * bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp:
        * bindings/v8/custom/V8XSLTProcessorCustom.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[DnD] effectAllowed and dropEffect can be set to bogus values.
bweinstein@apple.com [Thu, 14 Jan 2010 18:23:18 +0000 (18:23 +0000)]
[DnD] effectAllowed and dropEffect can be set to bogus values.
Fixes <https://bugs.webkit.org/show_bug.cgi?id=33635>.

Reviewed by Oliver Hunt.

WebCore:

Test to make aure dropEffect and effectAllowed are being set to valid values
when they are being set (list of valid values given by HTML5 specification).

Also, drive by change to initialize dropEffect to none (as described in spec).

Test: fast/events/bogus-dropEffect-effectAllowed.html

* dom/Clipboard.cpp:
(WebCore::Clipboard::Clipboard): Initialize m_dropEffect to "none".
(WebCore::Clipboard::setDropEffect): Check if dropEffect is being set to a valid value.
(WebCore::Clipboard::setEffectAllowed): Check if effectAllowed is being set to a valid value.

LayoutTests:

Added a test to check the handling of setting effectAllowed and
dropEffect to bogus values (that it gets ignored), and updated results
to drag-and-drop because it uses a dummy value.

* fast/events/bogus-dropEffect-effectAllowed-expected.txt: Added.
* fast/events/bogus-dropEffect-effectAllowed.html: Added.
* fast/events/drag-and-drop-expected.txt:
* fast/events/drag-and-drop.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-14 Kent Tamura <tkent@chromium.org>
eric@webkit.org [Thu, 14 Jan 2010 17:38:56 +0000 (17:38 +0000)]
2010-01-14  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Fisher.

        Introduce WebFileChooserParams to convey parameters for
        WebViewClient::runFileChooser(), and add new parameters to it.
        https://bugs.webkit.org/show_bug.cgi?id=32473

        The new parameters are
         - selected file names
         - "accept" attribute value

        * WebKit.gyp: Add WebFileChooserParams.h
        * public/WebFileChooserParams.h: Added.
        * public/WebViewClient.h:
        (WebKit::WebViewClient::runFileChooser):
          Add runFileChooser() with WebFileChooserParams, and mark the old one deprecated.
        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::runOpenPanel):
          Call the new runFileChooser() first, then call the old
          runFileChooser() if the new one failed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix a typo in editing/selection/inactive-selection.html
aroben@apple.com [Thu, 14 Jan 2010 16:09:37 +0000 (16:09 +0000)]
Fix a typo in editing/selection/inactive-selection.html

Fixes <http://webkit.org/b/33676> Exception when opening
editing/selection/inactive-selection.html in a browser

Reviewed by Dan Bernstein.

* editing/selection/inactive-selection.html: Remove a semicolon that
was making the if (window.layoutTestController) test ineffective.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Symbian build fixes.
hausmann@webkit.org [Thu, 14 Jan 2010 15:54:20 +0000 (15:54 +0000)]
[Qt] Symbian build fixes.

Reviewed by Tor Arne Vestbø.

* tests/qwebpage/tst_qwebpage.cpp: Include util.h
* tests/tests.pri: Don't define TESTS_SOURCE_DIR, it doesn't work.
* tests/util.h: Define TESTS_SOURCE_DIR here, just like it's done in Qt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd support for partial building on Symbian.
hausmann@webkit.org [Thu, 14 Jan 2010 14:52:53 +0000 (14:52 +0000)]
Add support for partial building on Symbian.

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2010-01-14
Reviewed by Simon Hausmann.

The build happens in the source directory as out of source builds are
not supported by qmake for Symbian.

Also the actual build isn't started but it is left to the developer
to choose the architecture/configuration.

* Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd support for "detecting" Symbian environments by either
hausmann@webkit.org [Thu, 14 Jan 2010 14:44:42 +0000 (14:44 +0000)]
Add support for "detecting" Symbian environments by either
looking for the EPOCROOT environment variable or via --symbian
being passed on the commandline.

Reviewed by Kenneth Rohde Christiansen.

* Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-14 Martin Robinson <martin.james.robinson@gmail.com>
eric@webkit.org [Thu, 14 Jan 2010 14:21:52 +0000 (14:21 +0000)]
2010-01-14  Martin Robinson  <martin.james.robinson@gmail.com>

        Reviewed by Xan Lopez.

        [GTK] Enable DOM clipboard and drag-and-drop access
        https://bugs.webkit.org/show_bug.cgi?id=30623

        Add DataObjectGtk, a container for pasteboard and drag-and-drop data.

        No new tests, because functionality has not changed.

        * GNUmakefile.am:
        * platform/gtk/DataObjectGtk.cpp: Added.
        (WebCore::DataObjectGtk::text):
        (WebCore::DataObjectGtk::markup):
        (WebCore::DataObjectGtk::setText):
        (WebCore::DataObjectGtk::setMarkup):
        (WebCore::DataObjectGtk::files):
        (WebCore::DataObjectGtk::url):
        (WebCore::DataObjectGtk::urlLabel):
        (WebCore::DataObjectGtk::hasURL):
        (WebCore::DataObjectGtk::clear):
        (WebCore::DataObjectGtk::forClipboard):
        * platform/gtk/DataObjectGtk.h: Added.
        (WebCore::DataObjectGtk::create):
        (WebCore::DataObjectGtk::uriList):
        (WebCore::DataObjectGtk::image):
        (WebCore::DataObjectGtk::setRange):
        (WebCore::DataObjectGtk::setURIList):
        (WebCore::DataObjectGtk::setImage):
        (WebCore::DataObjectGtk::setDragContext):
        (WebCore::DataObjectGtk::hasText):
        (WebCore::DataObjectGtk::hasMarkup):
        (WebCore::DataObjectGtk::hasURIList):
        (WebCore::DataObjectGtk::hasImage):
        (WebCore::DataObjectGtk::dragContext):
2010-01-14  Martin Robinson  <martin.james.robinson@gmail.com>

        Reviewed by Xan Lopez.

        [GTK] Enable DOM clipboard and drag-and-drop access
        https://bugs.webkit.org/show_bug.cgi?id=30623

        Use DataObjectGtk when setting and clearing pasteboard data on
        the GDK_SELECTION_PRIMARY clipboard.

        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::EditorClient::respondToChangedSelection):
        (WebKit::EditorClient::EditorClient):
        * WebCoreSupport/EditorClientGtk.h:
        * WebCoreSupport/PasteboardHelperGtk.cpp:
        (WebKit::fillSelectionData):
        (WebKit::targetListForDataObject):
        (WebKit::getClipboardContentsCallback):
        (WebKit::clearClipboardContentsCallback):
        (WebKit::PasteboardHelperGtk::writeClipboardContents):
        * WebCoreSupport/PasteboardHelperGtk.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-14 Ilya Tikhonovsky <loislo@chromium.org>
eric@webkit.org [Thu, 14 Jan 2010 14:06:13 +0000 (14:06 +0000)]
2010-01-14  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        WebInspector: Scrolling of Timeline Page was broken by fix for bug 33470.
        https://bugs.webkit.org/show_bug.cgi?id=33666

        * inspector/front-end/inspector.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Use a different Makefile names for sources generation and compilation.
jocelyn.turcotte@nokia.com [Thu, 14 Jan 2010 13:19:31 +0000 (13:19 +0000)]
[Qt] Use a different Makefile names for sources generation and compilation.
This prevents Makefile overwriting when running build-webkit twice.

Unreviewed.

* Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Unreviewed fix of builds with the --no-svg switch.
jocelyn.turcotte@nokia.com [Thu, 14 Jan 2010 13:19:00 +0000 (13:19 +0000)]
[Qt] Unreviewed fix of builds with the --no-svg switch.

* WebCore.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Unreviewed build fix on Windows.
jocelyn.turcotte@nokia.com [Thu, 14 Jan 2010 13:18:29 +0000 (13:18 +0000)]
[Qt] Unreviewed build fix on Windows.

* platform/graphics/transforms/TransformationMatrix.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-14 Andreas Kling <andreas.kling@nokia.com>
eric@webkit.org [Thu, 14 Jan 2010 12:15:03 +0000 (12:15 +0000)]
2010-01-14  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Enable scrolling optimization for pages with embedded widgets

        https://bugs.webkit.org/show_bug.cgi?id=33373

        Added a basic manual test for scrolling of embedded QWidgets.

        * manual-tests/qt/qtplugin-scrolling.html: Added.
        * platform/ScrollView.cpp:
        (WebCore::ScrollView::scrollContents):
        (WebCore::ScrollView::setParent):
        * platform/ScrollView.h:
        * platform/qt/ScrollViewQt.cpp:
        (WebCore::ScrollView::platformInit):
        (WebCore::ScrollView::platformAddChild):
        (WebCore::ScrollView::platformRemoveChild):
        * plugins/qt/PluginViewQt.cpp:
        (WebCore::PluginView::updatePluginWidget):
        (WebCore::PluginView::invalidateRect):
2010-01-14  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Add an "alien_QLabel" classId for manual testing of alien widgets.

        https://bugs.webkit.org/show_bug.cgi?id=33373

        * QtLauncher/main.cpp:
        (WebPage::createPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-13 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 14 Jan 2010 12:11:44 +0000 (12:11 +0000)]
2010-01-13  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Failing media/video-seek-past-end-playing.html
        https://bugs.webkit.org/show_bug.cgi?id=33015

        * media/video-seek-past-end-playing.html: Removed the last timer of this test.
        * platform/gtk/Skipped: Unskip test above.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Update Symbian .def symbol export files after private API additions.
hausmann@webkit.org [Thu, 14 Jan 2010 12:11:19 +0000 (12:11 +0000)]
[Qt] Update Symbian .def symbol export files after private API additions.

Reviewed by Kenneth Rohde Christiansen.

* symbian/bwins/QtWebKitu.def:
* symbian/eabi/QtWebKitu.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-14 Alejandro G. Castro <alex@igalia.com>
eric@webkit.org [Thu, 14 Jan 2010 11:56:58 +0000 (11:56 +0000)]
2010-01-14  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Xan Lopez.

        Review the tooltip implementation
        https://bugs.webkit.org/show_bug.cgi?id=32819

        Change the GTK tooltip implementation to avoid the workaround that
        we are currently using. Now we use a new private API to set the
        text and all the tooltip handling is done in the webview widget.

        * WebCoreSupport/ChromeClientGtk.cpp:
        * webkit/webkitprivate.h:
        * webkit/webkitwebview.cpp:
        (webkit_web_view_set_tooltip_text): Added, new private API.
        (webkit_web_view_query_tooltip): Added

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-09 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 14 Jan 2010 11:40:18 +0000 (11:40 +0000)]
2009-12-09  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Xan Lopez.

        [GStreamer] Check return values of gst_element_set_state()
        https://bugs.webkit.org/show_bug.cgi?id=30000

        Check for state change failure when going from READY/NULL to
        PAUSED or PLAYING. Also refactored the common code of play() and
        pause() to a new private method of the player.

        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivate::changePipelineState):
        (WebCore::MediaPlayerPrivate::play):
        (WebCore::MediaPlayerPrivate::pause):
        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMoves general includes before bindings includes in Android build system.
steveblock@google.com [Thu, 14 Jan 2010 11:23:49 +0000 (11:23 +0000)]
Moves general includes before bindings includes in Android build system.
https://bugs.webkit.org/show_bug.cgi?id=33623

Reviewed by David Levin.

This avoids problems with collisions between WebCore/platform/text/StringBuilder.h
and the new JavaScriptCore/runtime/StringBuilder.h. This change puts
JavaScriptCore/runtime and other bindings includes after the WebCore and other
general includes, so that the WebCore StringBuilder.h is picked up when building
WebCore.

* Android.mk: Modified.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-14 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 14 Jan 2010 10:47:59 +0000 (10:47 +0000)]
2010-01-14  Eric Seidel  <eric@webkit.org>

        No review, rolling out r53249.
        http://trac.webkit.org/changeset/53249
        https://bugs.webkit.org/show_bug.cgi?id=33617

        This caused http/tests/security/local-user-CSS-from-
        remote.html to fail on the Qt Release Build Bot.

        * platform/qt/Skipped:
2010-01-14  Eric Seidel  <eric@webkit.org>

        No review, rolling out r53249.
        http://trac.webkit.org/changeset/53249
        https://bugs.webkit.org/show_bug.cgi?id=33617

        This caused http/tests/security/local-user-CSS-from-
        remote.html to fail on the Qt Release Build Bot.

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::WebPage::resetSettings):
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::overridePreference):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-14 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 14 Jan 2010 10:39:10 +0000 (10:39 +0000)]
2010-01-14  Eric Seidel  <eric@webkit.org>

        No review, rolling out r53248.
        http://trac.webkit.org/changeset/53248
        https://bugs.webkit.org/show_bug.cgi?id=32641

        Caused 2 tests to crash on various bots:
        fast/dom/HTMLSelectElement/listbox-select-reset.html and
        fast/forms/listbox-typeahead-scroll.html

        * fast/forms/HTMLOptionElement_selected-expected.txt:
        * fast/forms/HTMLOptionElement_selected.html:
        * fast/forms/HTMLOptionElement_selected2-expected.txt: Removed.
        * fast/forms/HTMLOptionElement_selected2.html: Removed.
        * fast/forms/HTMLOptionElement_selected3-expected.txt: Removed.
        * fast/forms/HTMLOptionElement_selected3.html: Removed.
        * fast/forms/add-remove-option-modification-event-expected.txt:
2010-01-14  Eric Seidel  <eric@webkit.org>

        No review, rolling out r53248.
        http://trac.webkit.org/changeset/53248
        https://bugs.webkit.org/show_bug.cgi?id=32641

        Caused 2 tests to crash on various bots:
        fast/dom/HTMLSelectElement/listbox-select-reset.html and
        fast/forms/listbox-typeahead-scroll.html

        * dom/SelectElement.cpp:
        (WebCore::SelectElement::recalcStyle):
        (WebCore::SelectElement::setRecalcListItems):
        (WebCore::SelectElement::recalcListItems):
        (WebCore::SelectElement::restoreFormControlState):
        (WebCore::SelectElement::reset):
        (WebCore::SelectElement::typeAheadFind):
        * dom/SelectElement.h:
        * html/HTMLOptionElement.cpp:
        (WebCore::HTMLOptionElement::selected):
        (WebCore::HTMLOptionElement::insertedIntoTree):
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::recalcStyle):
        * html/HTMLSelectElement.h:
        * wml/WMLSelectElement.cpp:
        (WebCore::WMLSelectElement::recalcStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-14 Chris Jerdonek <chris.jerdonek@gmail.com>
eric@webkit.org [Thu, 14 Jan 2010 10:19:13 +0000 (10:19 +0000)]
2010-01-14  Chris Jerdonek  <chris.jerdonek@gmail.com>

        Reviewed by Shinichiro Hamaji.

        Moved error() from cpp_style.py to checker.py.

        https://bugs.webkit.org/show_bug.cgi?id=33620

        * Scripts/check-webkit-style:
          - Addressed FIXME to not set global state.

        * Scripts/webkitpy/style/checker.py:
          - Added argument validation to ProcessorOptions constructor.
          - Added should_report_error() to ProcessorOptions class.
          - Removed set_options().
          - Added StyleChecker class.

        * Scripts/webkitpy/style/checker_unittest.py:
          - Added unit test class for ProcessorOptions class.
          - Added unit test to check that parse() strips white space.

        * Scripts/webkitpy/style/cpp_style.py:
          - Removed "filter" and "output_format" methods.
          - Removed should_print_error() and error() functions.
          - Removed default parameter value from process_file().

        * Scripts/webkitpy/style/cpp_style_unittest.py:
          - Removed call to cpp_style._should_print_error().
          - Removed test_filter() and test_filter_appending().

        * Scripts/webkitpy/style/text_style.py:
          - Removed default parameter value from process_file().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-14 Ben Murdoch <benm@google.com>
eric@webkit.org [Thu, 14 Jan 2010 10:03:34 +0000 (10:03 +0000)]
2010-01-14  Ben Murdoch  <benm@google.com>

        Reviewed by Darin Adler.

        [Android] [Qt] The document.createEvent API does not support touch events.
        https://bugs.webkit.org/show_bug.cgi?id=33605

        * fast/events/script-tests/create-touch-event.js: Added. Ensures that document.createEvent("TouchEvent") can create a TouchEvent.
        * fast/events/touch/create-touch-event-expected.txt: Added.
        * fast/events/touch/create-touch-event.html: Added.
2010-01-14  Ben Murdoch  <benm@google.com>

        Reviewed by Darin Adler.

        [Android] [Qt] The document.createEvent API does not support touch events.
        https://bugs.webkit.org/show_bug.cgi?id=33605

        Test: fast/events/touch/create-touch-event.html

        * dom/Document.cpp:
        (WebCore::Document::createEvent): add creation of a TouchEvent when the "TouchEvent" argument is supplied.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-14 Diego Gonzalez <diego.gonzalez@openbossa.org>
eric@webkit.org [Thu, 14 Jan 2010 09:47:23 +0000 (09:47 +0000)]
2010-01-14  Diego Gonzalez  <diego.gonzalez@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] DRT missing setUserStyleSheetLocation and setUserStyleSheetEnabled in LayoutTestController
        https://bugs.webkit.org/show_bug.cgi?id=33617

        * platform/qt/Skipped:
2010-01-14  Diego Gonzalez  <diego.gonzalez@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] DRT missing setUserStyleSheetLocation and setUserStyleSheetEnabled in LayoutTestController
        https://bugs.webkit.org/show_bug.cgi?id=33617

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::WebPage::resetSettings):
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::setUserStyleSheetLocation):
        (LayoutTestController::setUserStyleSheetEnabled):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-14 James Robinson <jamesr@chromium.org>
eric@webkit.org [Thu, 14 Jan 2010 09:31:44 +0000 (09:31 +0000)]
2010-01-14  James Robinson  <jamesr@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Adds tests for the 'selected' attribute of <option>s
        https://bugs.webkit.org/show_bug.cgi?id=32641

        HTMLOptionElement_selected2 checks that the selected attribute is up to date immediately after the <select>
        parsed.  HTMLOptionElement_selected3 does the same, but checks immediately prior to the </select>.

        Also changes the expectation for add-remove-option-modification-event to reflect that we now pass.

        * fast/forms/HTMLOptionElement_selected-expected.txt:
        * fast/forms/HTMLOptionElement_selected.html:
        * fast/forms/HTMLOptionElement_selected2-expected.txt: Added.
        * fast/forms/HTMLOptionElement_selected2.html: Added.
        * fast/forms/HTMLOptionElement_selected3-expected.txt: Added.
        * fast/forms/HTMLOptionElement_selected3.html: Added.
        * fast/forms/add-remove-option-modification-event-expected.txt:
2010-01-14  James Robinson  <jamesr@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Ensures that the 'selected' attribute of an <option> is correct
        https://bugs.webkit.org/show_bug.cgi?id=32641

        Adds a check in OptionElement::selected() that checks if list items need to be recalculated and does so if needed,
        so the attribute is up to date more often.  Also gets rid of most of the recalcStyle() side effects.

         Our behavior now matches Firefox 3.5 and IE8 after the </select> is parsed.

         Tests: fast/forms/HTMLOptionElement_selected2.html
                fast/forms/HTMLOptionElement_selected3.html

        * dom/SelectElement.cpp:
        (WebCore::SelectElement::setOptionsChangedOnRenderer):
        (WebCore::SelectElement::setRecalcListItems):
        (WebCore::SelectElement::recalcListItems):
        (WebCore::SelectElement::restoreFormControlState):
        (WebCore::SelectElement::reset):
        (WebCore::SelectElement::typeAheadFind):
        * dom/SelectElement.h:
        * html/HTMLOptionElement.cpp:
        (WebCore::HTMLOptionElement::selected):
        (WebCore::HTMLOptionElement::insertedIntoTree):
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::recalcStyle):
        (WebCore::HTMLSelectElement::recalcListItemsIfNeeded):
        * html/HTMLSelectElement.h:
        * wml/WMLSelectElement.cpp:
        (WebCore::WMLSelectElement::recalcStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Simon Hausmann.
ossy@webkit.org [Thu, 14 Jan 2010 09:01:51 +0000 (09:01 +0000)]
Rubber-stamped by Simon Hausmann.

[Qt] Add expected files for passing new tests.
Compared to the mac expected files and png files.

* platform/qt/fast/backgrounds/quirks-mode-line-box-backgrounds-expected.txt: Added.
* platform/qt/fast/css/css3-space-in-nth-and-lang-expected.txt: Added.
* platform/qt/svg/custom/marker-opacity-expected.txt: Added.
* platform/qt/svg/custom/relative-sized-content-expected.txt: Added.
* platform/qt/svg/custom/text-xy-updates-SVGList-expected.txt: Added.
* platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt: Added.
* platform/qt/transforms/2d/transform-fixed-container-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Allow custom memory allocation control for TransparencyLayer class
zoltan@webkit.org [Thu, 14 Jan 2010 08:41:13 +0000 (08:41 +0000)]
[Qt] Allow custom memory allocation control for TransparencyLayer class
https://bugs.webkit.org/show_bug.cgi?id=33585

Reviewed by Oliver Hunt.

Inherits the following class from FastAllocBase because it is
instantiated by 'new':

class name              - instantiated at: WebCore/'location'
class TransparencyLayer - platform/graphics/qt/GraphicsContextQt.cpp:906

* platform/graphics/qt/GraphicsContextQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-14 Zoltan Horvath <zoltan@webkit.org>
zoltan@webkit.org [Thu, 14 Jan 2010 08:34:32 +0000 (08:34 +0000)]
2010-01-14  Zoltan Horvath  <zoltan@webkit.org>

        Reviewed by Oliver Hunt.

        [Qt] Allow custom memory allocation control for FontPlatformDataPrivate class
        https://bugs.webkit.org/show_bug.cgi?id=

        Inherits the following class from Noncopyable because it is
        instantiated by 'new' and no need to be copyable:

        class name                    - instantiated at: WebCore/'location'
        class FontPlatformDataPrivate - platform/graphics/qt/FontPlatformData.h:70

        * platform/graphics/qt/FontPlatformData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Xan Lopez.
philn@webkit.org [Thu, 14 Jan 2010 08:33:27 +0000 (08:33 +0000)]
    Reviewed by Xan Lopez.

        [GTK] un-needed seeks
        https://bugs.webkit.org/show_bug.cgi?id=33532

        Avoid un-needed seeks. Don't seek at current playback position and
        don't update the rate if it is already set to target value.

        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
        (WebCore::MediaPlayerPrivate::seek):
        (WebCore::MediaPlayerPrivate::setRate):
        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-14 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 14 Jan 2010 08:21:32 +0000 (08:21 +0000)]
2010-01-14  Eric Seidel  <eric@webkit.org>

        No review.  Tiger build fix after http://trac.webkit.org/changeset/53238.

        Need to implement WebGLContextAttributes
        https://bugs.webkit.org/show_bug.cgi?id=31169

        Fix a build break when ENABLE(3D_CANVAS) is disabled.

        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::getContext): UNUSED_PARAM(attrs) when 3D_CANVAS is disabled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-13 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 14 Jan 2010 07:42:39 +0000 (07:42 +0000)]
2010-01-13  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: use hidden text area for clipboard in order to
        workaround windows setData bug.

        https://bugs.webkit.org/show_bug.cgi?id=33633

        * inspector/front-end/TextEditor.js:
        (WebInspector.TextEditor):
        (WebInspector.TextEditor.prototype._copy):
        * inspector/front-end/inspector.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-13 Mads Ager <ager@chromium.org>
eric@webkit.org [Thu, 14 Jan 2010 07:35:01 +0000 (07:35 +0000)]
2010-01-13  Mads Ager  <ager@chromium.org>

        Reviewed by Dimitri Glazkov.

        [V8] Slow named property lookup on DOMWindow because of missing fast case
        https://bugs.webkit.org/show_bug.cgi?id=33584

        Add fast case checks to V8 named property getter on DOMWindow
        objects.  If the property is not in the DOM there is no reason to
        search the DOM for all occurrences.

        Covered by layout tests.

        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::V8DOMWindow::namedPropertyGetter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/7403736> REGRESSION (r49963,r49965): 8% Dromaeo Core DOM test regression
barraclough@apple.com [Thu, 14 Jan 2010 06:45:27 +0000 (06:45 +0000)]
<rdar://problem/7403736> REGRESSION (r49963,r49965): 8% Dromaeo Core DOM test regression

Reviewed by Oliver Hunt.

Adding isolated worlds support to the JSC bindings introduced a regression due to
additional map lookups.  Add a mechanism to quickly detect that a lookup is for the
'normal' world, and add fast paths to a couple of methods to check the normal world
first.

* bindings/js/JSDOMBinding.cpp:
(WebCore::Document::getWrapperCache):
(WebCore::DOMWrapperWorld::DOMWrapperWorld):
(WebCore::forgetDOMObject):
* bindings/js/JSDOMBinding.h:
(WebCore::DOMWrapperWorld::isNormal):
(WebCore::WebCoreJSClientData::WebCoreJSClientData):
* bindings/js/ScriptController.cpp:
(WebCore::IsolatedWorld::IsolatedWorld):
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::createWrapperCache):
* dom/Document.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-13 Kent Hansen <kent.hansen@nokia.com>
eric@webkit.org [Thu, 14 Jan 2010 06:37:13 +0000 (06:37 +0000)]
2010-01-13  Kent Hansen  <kent.hansen@nokia.com>

        Reviewed by Oliver Hunt.

        JSON.stringify and JSON.parse needlessly process properties in the prototype chain
        https://bugs.webkit.org/show_bug.cgi?id=33053

        * runtime/JSONObject.cpp:
        (JSC::Stringifier::Holder::appendNextProperty):
        (JSC::Walker::walk):
2010-01-13  Kent Hansen  <kent.hansen@nokia.com>

        Reviewed by Oliver Hunt.

        JSON.stringify and JSON.parse needlessly process properties in the prototype chain
        https://bugs.webkit.org/show_bug.cgi?id=33053

        Add tests that verify that properties in the prototype chain are ignored.

        * fast/js/JSON-parse-expected.txt:
        * fast/js/JSON-stringify-expected.txt:
        * fast/js/resources/JSON-parse.js:
        * fast/js/resources/JSON-stringify.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-13 Kenneth Russell <kbr@google.com>
eric@webkit.org [Thu, 14 Jan 2010 05:50:45 +0000 (05:50 +0000)]
2010-01-13  Kenneth Russell  <kbr@google.com>

        Reviewed by Oliver Hunt.

        Need to implement WebGLContextAttributes
        https://bugs.webkit.org/show_bug.cgi?id=31169

        Added the WebGLContextAttributes class and custom JavaScript
        bindings to accept a native object as the second argument to
        getContext("experimental-webgl") per the WebGL specification.
        Added GraphicsContext3D::Attributes struct to isolate DOM and
        graphics layers. Added getContextAttributes() to
        WebGLRenderingContext. Added test case ensuring that context
        attributes can be passed down and returned. Tested in Safari and
        Chromium. The attributes will be hooked up to the creation of the
        OpenGL context in bug 33416.

        * fast/canvas/webgl/context-attributes-expected.txt: Added.
        * fast/canvas/webgl/context-attributes.html: Added.
        * fast/canvas/webgl/resources/webgl-test.js:
        (create3DContext):
2010-01-13  Kenneth Russell  <kbr@google.com>

        Reviewed by Oliver Hunt.

        Need to implement WebGLContextAttributes
        https://bugs.webkit.org/show_bug.cgi?id=31169

        Added the WebGLContextAttributes class and custom JavaScript
        bindings to accept a native object as the second argument to
        getContext("experimental-webgl") per the WebGL specification.
        Added GraphicsContext3D::Attributes struct to isolate DOM and
        graphics layers. Added getContextAttributes() to
        WebGLRenderingContext. Added test case ensuring that context
        attributes can be passed down and returned. Tested in Safari and
        Chromium. The attributes will be hooked up to the creation of the
        OpenGL context in bug 33416.

        Test: fast/canvas/webgl/context-attributes.html

        * DerivedSources.make:
        * WebCore.gypi:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSHTMLCanvasElementCustom.cpp:
        (WebCore::JSHTMLCanvasElement::getContext):
        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/scripts/IDLParser.pm:
        * bindings/v8/DOMData.cpp:
        * bindings/v8/DerivedSourcesAllInOne.cpp:
        * bindings/v8/V8DOMWrapper.cpp:
        * bindings/v8/V8Index.cpp:
        * bindings/v8/V8Index.h:
        * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
        (WebCore::V8HTMLCanvasElement::getContextCallback):
        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::getContext):
        * html/HTMLCanvasElement.h:
        * html/HTMLCanvasElement.idl:
        * html/canvas/CanvasContextAttributes.cpp: Added.
        (WebCore::CanvasContextAttributes::CanvasContextAttributes):
        (WebCore::CanvasContextAttributes::~CanvasContextAttributes):
        * html/canvas/CanvasContextAttributes.h: Added.
        * html/canvas/WebGLContextAttributes.cpp: Added.
        (WebCore::WebGLContextAttributes::create):
        (WebCore::WebGLContextAttributes::WebGLContextAttributes):
        (WebCore::WebGLContextAttributes::~WebGLContextAttributes):
        (WebCore::WebGLContextAttributes::alpha):
        (WebCore::WebGLContextAttributes::setAlpha):
        (WebCore::WebGLContextAttributes::depth):
        (WebCore::WebGLContextAttributes::setDepth):
        (WebCore::WebGLContextAttributes::stencil):
        (WebCore::WebGLContextAttributes::setStencil):
        (WebCore::WebGLContextAttributes::antialias):
        (WebCore::WebGLContextAttributes::setAntialias):
        (WebCore::WebGLContextAttributes::premultipliedAlpha):
        (WebCore::WebGLContextAttributes::setPremultipliedAlpha):
        (WebCore::WebGLContextAttributes::attributes):
        * html/canvas/WebGLContextAttributes.h: Added.
        * html/canvas/WebGLContextAttributes.idl: Added.
        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::create):
        (WebCore::WebGLRenderingContext::getContextAttributes):
        * html/canvas/WebGLRenderingContext.h:
        * html/canvas/WebGLRenderingContext.idl:
        * platform/graphics/GraphicsContext3D.h:
        * platform/graphics/mac/GraphicsContext3DMac.cpp:
        (WebCore::GraphicsContext3D::create):
        (WebCore::GraphicsContext3D::GraphicsContext3D):
        (WebCore::GraphicsContext3D::getContextAttributes):
2010-01-13  Kenneth Russell  <kbr@google.com>

        Reviewed by Oliver Hunt.

        Need to implement WebGLContextAttributes
        https://bugs.webkit.org/show_bug.cgi?id=31169

        Added the WebGLContextAttributes class and custom JavaScript
        bindings to accept a native object as the second argument to
        getContext("experimental-webgl") per the WebGL specification.
        Added GraphicsContext3D::Attributes struct to isolate DOM and
        graphics layers. Added getContextAttributes() to
        WebGLRenderingContext. Added test case ensuring that context
        attributes can be passed down and returned. Tested in Safari and
        Chromium. The attributes will be hooked up to the creation of the
        OpenGL context in bug 33416.

        * src/GraphicsContext3D.cpp:
        (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
        (WebCore::GraphicsContext3DInternal::getContextAttributes):
        (WebCore::GraphicsContext3D::create):
        (WebCore::GraphicsContext3D::GraphicsContext3D):
        (WebCore::GraphicsContext3D::getContextAttributes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-13 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 14 Jan 2010 05:00:23 +0000 (05:00 +0000)]
2010-01-13  Simon Fraser  <simon.fraser@apple.com>

        Fix Windows build.

        * platform/graphics/cg/GraphicsContextCG.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-13 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 14 Jan 2010 04:54:33 +0000 (04:54 +0000)]
2010-01-13  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        Transition followed by animation fails to run the animation sometimes
        https://bugs.webkit.org/show_bug.cgi?id=33563

        If a transition was closely followed by an animation, it was possible for the cleanup
        after the end of the transition to kill the animation.

        Fix this by including the keyframes name (or empty string for transitions) in the labels
        used to identify CAAnimations on layers.

        No test because this was a subtle timing issue that is hard to reproduce in a layout test.

        * platform/graphics/mac/GraphicsLayerCA.h: Some new methods and signature changes.

        * platform/graphics/mac/GraphicsLayerCA.mm:
        (WebCore::animationIdentifier): Pass the keyframes name, since this is included in the identifier string now.
        (WebCore::moveAllAnimationsForProperty): Pass the keyframes name.
        (WebCore::GraphicsLayerCA::moveAnimationsForProperty): Try to move both transition- and animation-related
        CAAnimations, using the list of running animations to get the keyframe names for the latter.

        (WebCore::GraphicsLayerCA::ensureStructuralLayer): moveAnimation renamed to moveAnimationsForProperty
        and takes the keyframes name.

        (WebCore::GraphicsLayerCA::updateLayerAnimations): Pass keyframes name down (or "" for transitions).
        (WebCore::GraphicsLayerCA::setAnimationOnLayer): Pass keyframes name down.
        (WebCore::GraphicsLayerCA::removeAnimationFromLayer): Pass keyframes name down.
        (WebCore::GraphicsLayerCA::pauseAnimationOnLayer): Pass keyframes name down.
        (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): Pass keyframes name down.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-13 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 14 Jan 2010 04:44:31 +0000 (04:44 +0000)]
2010-01-13  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Fix shadow drawing to do the correct computations using the base coordinate space
        https://bugs.webkit.org/show_bug.cgi?id=33629

        Shadows draw using the CGContext base CTM, so we need to convert the shadow offet
        and size from user CTM into into base CTM coordinates, via the matix obtained from wkGetUserToBaseCTM().

        Test: compositing/shadows/shadow-drawing.html

        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::setPlatformShadow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-13 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 14 Jan 2010 04:32:52 +0000 (04:32 +0000)]
2010-01-13  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Update Qt slave result after last SVG commit.

        * platform/qt/svg/css/clippath-with-shadow-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-13 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 14 Jan 2010 04:09:22 +0000 (04:09 +0000)]
2010-01-13  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Oliver Hunt.

        SVGClipPathElement shouldn't resolve style manually
        https://bugs.webkit.org/show_bug.cgi?id=33647

        Build renderers for SVGClipPathElement, so we can query the style from the renderer
        instead of re-resolving style on every clip path resource invalidation.

        * svg/SVGClipPathElement.cpp:
        (WebCore::SVGClipPathElement::createRenderer):
        (WebCore::SVGClipPathElement::canvasResource):
        * svg/SVGClipPathElement.h:
        (WebCore::SVGClipPathElement::isValid):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-13 Kelly Norton <knorton@google.com>
knorton@google.com [Thu, 14 Jan 2010 03:47:59 +0000 (03:47 +0000)]
2010-01-13  Kelly Norton  <knorton@google.com>

        Reviewed by Timothy Hatcher.

        Web Inspector does not update the DOM tree when attributes change.
        https://bugs.webkit.org/show_bug.cgi?id=20162

        * dom/Element.cpp: Moves callbacks to InspectorController directly into setAttribute
        and removeAttribute and removes the existing call sites. This makes it possible to
        see attribute modifications.
        (WebCore::Element::setAttribute):
        (WebCore::Element::dispatchAttrRemovalEvent):
        (WebCore::Element::dispatchAttrAdditionEvent):
        (WebCore::Element::removeAttribute):
        * inspector/front-end/DOMAgent.js:
        (WebInspector.DOMNode.prototype._setAttributesPayload): Clear existing attributes.
        (WebInspector.DOMAgent.prototype._didApplyDomChange): Updated call site and fixed style.
        (WebInspector.DOMAgent.prototype._attributesUpdated): Added.
        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel.prototype._attributesUpdated): Added.
        (WebInspector.ElementsPanel.prototype.updateModifiedNodes): Updated call site.
        * inspector/front-end/ElementsTreeOutline.js: Renamed _updateTitle to updateTitle.
        (WebInspector.ElementsTreeElement.prototype.onattach): Updated updateTitle call site.
        (WebInspector.ElementsTreeElement.prototype._textNodeEditingCommitted): Ditto.
        (WebInspector.ElementsTreeElement.prototype._editingCancelled): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-13 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 14 Jan 2010 03:31:50 +0000 (03:31 +0000)]
2010-01-13  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Remove six old tiger specific results, that are equal to the SL baseline now. Update one result, showing a marginal difference between Tiger/SL.
        This is a follow-up commit for Dirks strokeBoundingBox() fixes -> should turn Tiger slave green again.

        * platform/mac-tiger/svg/W3C-SVG-1.1/animate-elem-06-t-expected.checksum: Removed.
        * platform/mac-tiger/svg/W3C-SVG-1.1/animate-elem-06-t-expected.png: Removed.
        * platform/mac-tiger/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt: Removed.
        * platform/mac-tiger/svg/W3C-SVG-1.1/animate-elem-07-t-expected.checksum: Removed.
        * platform/mac-tiger/svg/W3C-SVG-1.1/animate-elem-07-t-expected.png: Removed.
        * platform/mac-tiger/svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt: Removed.
        * platform/mac-tiger/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
        * platform/mac-tiger/svg/W3C-SVG-1.1/paths-data-01-t-expected.checksum: Removed.
        * platform/mac-tiger/svg/W3C-SVG-1.1/paths-data-01-t-expected.png: Removed.
        * platform/mac-tiger/svg/W3C-SVG-1.1/paths-data-01-t-expected.txt: Removed.
        * platform/mac-tiger/svg/W3C-SVG-1.1/text-path-01-b-expected.checksum: Removed.
        * platform/mac-tiger/svg/W3C-SVG-1.1/text-path-01-b-expected.png: Removed.
        * platform/mac-tiger/svg/W3C-SVG-1.1/text-path-01-b-expected.txt: Removed.
        * platform/mac-tiger/svg/custom/control-points-for-S-and-T-expected.checksum: Removed.
        * platform/mac-tiger/svg/custom/control-points-for-S-and-T-expected.png: Removed.
        * platform/mac-tiger/svg/custom/control-points-for-S-and-T-expected.txt: Removed.
        * platform/mac-tiger/svg/text/text-path-01-b-expected.checksum: Removed.
        * platform/mac-tiger/svg/text/text-path-01-b-expected.png: Removed.
        * platform/mac-tiger/svg/text/text-path-01-b-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-13 Carol Szabo <carol.szabo@nokia.com>
eric@webkit.org [Thu, 14 Jan 2010 03:30:36 +0000 (03:30 +0000)]
2010-01-13  Carol Szabo <carol.szabo@nokia.com>

        Reviewed by Darin Adler.

        CounterNode::nextInPreOrderAfterChildren(stayWithin) does not stay within.
        https://bugs.webkit.org/show_bug.cgi?id=33625

        No new tests because the fix should affect strictly performance.

        * rendering/CounterNode.cpp:
        (WebCore::CounterNode::nextInPreOrderAfterChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-13 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 14 Jan 2010 03:05:30 +0000 (03:05 +0000)]
2010-01-13  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Oliver Hunt.

        Window size changes are not propagated down the render tree
        https://bugs.webkit.org/show_bug.cgi?id=33643

        Test: svg/custom/relative-sized-content.xhtml

        * rendering/RenderSVGContainer.cpp: Fix incorrect markParents=true usage, leading to unnecessary relayouts.
        (WebCore::RenderSVGContainer::layout): Use new layoutChildren() method.
        (WebCore::RenderSVGContainer::paint): Fix indention.
        * rendering/RenderSVGHiddenContainer.cpp: Fix incorrect markParents=true usage.
        (WebCore::RenderSVGHiddenContainer::layout): Use new layoutChildren() helper.
        * rendering/RenderSVGRoot.cpp: Refactor existing code to layout children in SVGRenderSupport::layoutChildren.
        (WebCore::RenderSVGRoot::layout): Make children relayouting depend on width/height changes, if the outermost svg uses relative viewport sizes.
        * rendering/SVGRenderSupport.cpp: Add central place handling child layout, skips relayouting non-relative sized children as benefit.
        (WebCore::SVGRenderBase::layoutChildren): This methods contains the actual changes.
        * rendering/SVGRenderSupport.h:
        * svg/SVGGElement.h: Remove dead code.
        * svg/SVGSVGElement.h: Make hasRelativeValues() public to remove the need for friendship declarations.
        * svg/SVGStyledElement.h: Change default return value for hasRelativeValues() to false, as it was intended.
        (WebCore::SVGStyledElement::hasRelativeValues): Make it public, to be usable from SVGRenderSupport.
        * svg/SVGSymbolElement.h: Remove dead code.
        * svg/SVGUseElement.cpp: Implement hasRelativeValues() - it was simply missing here.
        (WebCore::SVGUseElement::hasRelativeValues):
        * svg/SVGUseElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-13 Adam Barth <abarth@webkit.org>
eric@webkit.org [Thu, 14 Jan 2010 02:57:19 +0000 (02:57 +0000)]
2010-01-13  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Fix CloseBugForLandDiff unittest to actually run
        https://bugs.webkit.org/show_bug.cgi?id=33640

        * Scripts/webkitpy/mock_bugzillatool.py:
        * Scripts/webkitpy/steps/closebugforlanddiff_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-13 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Thu, 14 Jan 2010 02:46:39 +0000 (02:46 +0000)]
2010-01-13  Fumitoshi Ukai  <ukai@chromium.org>

        Unreviewed.

        Enable websocket/tests/workers/worker-simple.html again.

        * platform/mac/Skipped: rm websocket/tests/workers/worker-simple.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-13 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Thu, 14 Jan 2010 02:23:08 +0000 (02:23 +0000)]
2010-01-13  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by David Levin.

        Fix websocket/tests/worker/worker-simple.html crash on Leopard Intel Debug (Tests) builder
        https://bugs.webkit.org/show_bug.cgi?id=33581

        unref m_workerContext when websocket is disconnected, so that avoid
        keeping reference to workerContext longer than worker thread runs.

        * websockets/WorkerThreadableWebSocketChannel.cpp:
        (WebCore::WorkerThreadableWebSocketChannel::Bridge::disconnect):
        (WebCore::WorkerThreadableWebSocketChannel::Bridge::waitForMethodCompletion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
barraclough@apple.com [Thu, 14 Jan 2010 01:56:24 +0000 (01:56 +0000)]
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

Reviewed by NOBODY (buildfix).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Darin Adler.
ap@apple.com [Thu, 14 Jan 2010 01:36:07 +0000 (01:36 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=33641
        Assertion failure in Lexer.cpp if input stream ends while in string escape

        Test: fast/js/end-in-string-escape.html

        * parser/Lexer.cpp: (JSC::Lexer::lex): Bail out quickly on end of stream, not giving the
        assertion a chance to fire.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
barraclough@apple.com [Thu, 14 Jan 2010 01:29:20 +0000 (01:29 +0000)]
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

Reviewed by NOBODY (buildfix).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-13 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 14 Jan 2010 01:28:42 +0000 (01:28 +0000)]
2010-01-13  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/7532544>

        Expose new method on WebKitSystemInterface, WKGetUserToBaseCTM(), which will
        be used for a shadow drawing fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber stamped by Sam Weinig & Darin Adler.
barraclough@apple.com [Thu, 14 Jan 2010 01:20:52 +0000 (01:20 +0000)]
Rubber stamped by Sam Weinig & Darin Adler.

Three quick fixes to UStringImpl.
    - The destroy() method can be switched back to a normal destructor; since we've switched
      the way we protect static strings to be using an odd ref-count the destroy() won't abort.
    - The cost() calculation logic was wrong.  If you have multiple JSStrings wrapping substrings
      of a base string, they would each report the full cost of the base string to the heap.
      Instead we should only be reporting once for the base string.
    - Remove the overloaded new operator calling fastMalloc, replace this with a 'using' to pick
      up the implementation from the parent class.

* JavaScriptCore.exp:
* runtime/UStringImpl.cpp:
(JSC::UStringImpl::~UStringImpl):
* runtime/UStringImpl.h:
(JSC::UStringImpl::cost):
(JSC::UStringImpl::deref):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMSAA: selected, selectable, extended selectable, and multiple
jhoneycutt@apple.com [Thu, 14 Jan 2010 01:16:15 +0000 (01:16 +0000)]
MSAA: selected, selectable, extended selectable, and multiple
selectable states are not reported

https://bugs.webkit.org/show_bug.cgi?id=33574
<rdar://problem/7536826>

Reviewed by Darin Adler.

WebCore:

* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isMultiSelectable):
Use the correct function name - the function name overriden by
and used in AccessiblityRenderObject.

* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(setAtkStateSetFromCoreObject):
Update for function rename.
(webkit_accessible_selection_select_all_selection):
Ditto.

WebKit/chromium:

* public/WebAccessibilityObject.h:
Update for WebCore::AccessibilityObject function rename.

* src/WebAccessibilityObject.cpp:
(WebKit::WebAccessibilityObject::isMultiSelectable):
Ditto.

WebKit/win:

* AccessibleBase.cpp:
(AccessibleBase::get_accState):
Remove the call to isMultiSelect(). Call the correctly-named
isMultiSelectable(), and if it returns true, set both the "extended
selectable" and "multiple selectable" states. Check whether the object
is selected or selectable, and report those states.

WebKitTools:

* DumpRenderTree/AccessibilityUIElement.cpp:
(getIsSelectableCallback):
Return the result of calling isSelectable().
(getIsMultiSelectableCallback):
Return the result of calling isMultiSelectable().
(AccessibilityUIElement::getJSClass):
Add isSelected and isMultiSelectable properties to the JSClass
definition.

* DumpRenderTree/AccessibilityUIElement.h:
Declare isSelectable() and isMultiSelectable().

* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::isSelectable):
Stubbed.
(AccessibilityUIElement::isMultiSelectable):
Stubbed.

* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::isSelectable):
Stubbed.
(AccessibilityUIElement::isMultiSelectable):
Stubbed.

* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(accessibilityState):
Get the object's state, and return it.
(AccessibilityUIElement::isSelected):
Check the object's selected state.
(AccessibilityUIElement::isSelectable):
Check the object's selectable state.
(AccessibilityUIElement::isMultiSelectable):
Check the object's extended/multiple selectable state.

LayoutTests:

* accessibility/selection-states-expected.txt: Added.

* accessibility/selection-states.html: Added.

* platform/gtk/Skipped:
Add new test to skipped list due to stubbed AccessibilityUIElement
functions.

* platform/mac/Skipped:
Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-13 Simon Fraser <simon.fraser@apple.com>
cmarrin@apple.com [Thu, 14 Jan 2010 01:14:17 +0000 (01:14 +0000)]
2010-01-13  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/7532544>

        Expose new method on WebKitSystemInterface, WKGetUserToBaseCTM(), which will
        be used for a shadow drawing fix. Once more, with feeling. On Windows.

        * win/include/WebKitSystemInterface/WebKitSystemInterface.h:
        * win/lib/WebKitSystemInterface.lib:
        * win/lib/WebKitSystemInterface_debug.lib:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMove more of the selection and caret painting code from Frame to SelectionController.
darin@apple.com [Thu, 14 Jan 2010 01:01:12 +0000 (01:01 +0000)]
Move more of the selection and caret painting code from Frame to SelectionController.
https://bugs.webkit.org/show_bug.cgi?id=33619

Reviewed by Dan Bernstein.

WebCore:

Helpful preparation step for a bug fix I am working on.

* editing/SelectionController.cpp:
(WebCore::SelectionController::SelectionController): Initialize new data members.
Note that m_caretVisible starts as true for the drag caret controller to match the
old behavior for painting.
(WebCore::SelectionController::setSelection): Changed to call selectionLayoutChanged
in its new name and location.
(WebCore::SelectionController::paintCaret): Added checks that were formerly done
at the Frame level. Tweaked formatting and changed to use early return as well.
(WebCore::SelectionController::focusedOrActiveStateChanged): Updated for call
moved into this class.
(WebCore::SelectionController::updateAppearance): Moved the
Frame::selectionLayoutChanged function here. Had to rename it because the word
"layout" is usedfor other purposes in this function.
(WebCore::SelectionController::setCaretVisible): Moved here from Frame.
(WebCore::SelectionController::clearCaretRectIfNeeded): Ditto.
(WebCore::SelectionController::caretBlinkTimerFired): Ditto.

* editing/SelectionController.h: Added new functions. Moved conditional function
out of class definition for clarity. Removed unneeded == and != operators.
Removed unneeded use of bit fields.

* page/Frame.cpp: Moved functions to SelectionController.
(WebCore::Frame::Frame): Removed initialization of moved data members.

* page/Frame.h: Removed things moved to SelectionController as well as unneeded
forward declaration of Timer class template.

* page/FrameView.cpp:
(WebCore::FrameView::layout): Updated for new location of function.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintCaret): Ditto.

WebKit/qt:

* Api/qwebpage.cpp:
(QWebPagePrivate::inputMethodEvent): Seems possibly wrong to be directly invoking this
setCaretVisible here, but I updated it to call it in its new location.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-13 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 14 Jan 2010 00:55:17 +0000 (00:55 +0000)]
2010-01-13  Adam Barth  <abarth@webkit.org>

        Unreviewed.  Repeat the below for CloseBugForLandDiff.

        * Scripts/test-webkitpy:
        * Scripts/webkitpy/steps/closebugforlanddiff.py:
        * Scripts/webkitpy/steps/closebugforlanddiff_unittest.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-13 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 14 Jan 2010 00:49:41 +0000 (00:49 +0000)]
2010-01-13  Adam Barth  <abarth@webkit.org>

        Unreviewed.  Turn the mac-ews status bubbles back on now that this bot
        is running again.

        * QueueStatusServer/templates/statusbubble.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-13 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 14 Jan 2010 00:49:00 +0000 (00:49 +0000)]
2010-01-13  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        REGRESSION(53133): webkit-patch land dies if it can't find a bug id.
        https://bugs.webkit.org/show_bug.cgi?id=33634

        Deal with the case of no bug patch object in the state.

        * Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py:
        * Scripts/webkitpy/steps/updatechangelogswithreviewer.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCleaning up quota-tracking.html. Removing trailing whitespaces and
dumi@chromium.org [Thu, 14 Jan 2010 00:20:02 +0000 (00:20 +0000)]
Cleaning up quota-tracking.html. Removing trailing whitespaces and
fixing the errorFunction() to work correctly with both
transaction() and executeSql().

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=33628

* storage/quota-tracking.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53214 268f45cc-cd09-0410-ab3c-d52691b4dbfc