WebKit-https.git
10 years ago2010-05-10 John Gregg <johnnyg@google.com>
johnnyg@google.com [Tue, 11 May 2010 05:06:57 +0000 (05:06 +0000)]
2010-05-10  John Gregg  <johnnyg@google.com>

        [chromium] Final set of baselines and expectations to green up the build.

        * platform/chromium-mac/plugins/geturlnotify-during-document-teardown-expected.txt: Added.
        * platform/chromium-win/plugins/geturlnotify-during-document-teardown-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 John Gregg <johnnyg@google.com>
johnnyg@google.com [Tue, 11 May 2010 04:49:38 +0000 (04:49 +0000)]
2010-05-10  John Gregg  <johnnyg@google.com>

        [chromium] rebaseline SVG test for windows after recent changes.

        * platform/chromium-win/svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-displace-01-f-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-image-01-b-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-offset-01-b-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-tile-01-b-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-tile-01-b-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt:
        * platform/chromium-win/svg/batik/filters/feTile-expected.checksum:
        * platform/chromium-win/svg/batik/filters/feTile-expected.png:
        * platform/chromium-win/svg/batik/filters/feTile-expected.txt:
        * platform/chromium-win/svg/batik/filters/filterRegions-expected.checksum:
        * platform/chromium-win/svg/batik/filters/filterRegions-expected.png:
        * platform/chromium-win/svg/batik/filters/filterRegions-expected.txt:
        * platform/chromium-win/svg/batik/masking/maskRegions-expected.txt:
        * platform/chromium-win/svg/batik/text/textEffect-expected.checksum:
        * platform/chromium-win/svg/batik/text/textEffect-expected.png: Added.
        * platform/chromium-win/svg/batik/text/textEffect-expected.txt:
        * platform/chromium-win/svg/batik/text/textEffect3-expected.checksum:
        * platform/chromium-win/svg/batik/text/textEffect3-expected.png: Added.
        * platform/chromium-win/svg/batik/text/textEffect3-expected.txt:
        * platform/chromium-win/svg/batik/text/textFeatures-expected.txt:
        * platform/chromium-win/svg/batik/text/textProperties-expected.txt:
        * platform/chromium-win/svg/custom/empty-mask-expected.txt:
        * platform/chromium-win/svg/custom/empty-merge-expected.checksum:
        * platform/chromium-win/svg/custom/empty-merge-expected.png:
        * platform/chromium-win/svg/custom/feComponentTransfer-Discrete-expected.checksum:
        * platform/chromium-win/svg/custom/feComponentTransfer-Discrete-expected.png:
        * platform/chromium-win/svg/custom/feComponentTransfer-Discrete-expected.txt:
        * platform/chromium-win/svg/custom/feComponentTransfer-Gamma-expected.checksum:
        * platform/chromium-win/svg/custom/feComponentTransfer-Gamma-expected.png:
        * platform/chromium-win/svg/custom/feComponentTransfer-Gamma-expected.txt:
        * platform/chromium-win/svg/custom/feComponentTransfer-Linear-expected.checksum:
        * platform/chromium-win/svg/custom/feComponentTransfer-Linear-expected.png:
        * platform/chromium-win/svg/custom/feComponentTransfer-Linear-expected.txt:
        * platform/chromium-win/svg/custom/feComponentTransfer-Table-expected.checksum:
        * platform/chromium-win/svg/custom/feComponentTransfer-Table-expected.png:
        * platform/chromium-win/svg/custom/feComponentTransfer-Table-expected.txt:
        * platform/chromium-win/svg/custom/feDisplacementMap-01-expected.checksum:
        * platform/chromium-win/svg/custom/feDisplacementMap-01-expected.png:
        * platform/chromium-win/svg/custom/image-with-transform-clip-filter-expected.checksum:
        * platform/chromium-win/svg/custom/image-with-transform-clip-filter-expected.png:
        * platform/chromium-win/svg/custom/image-with-transform-clip-filter-expected.txt:
        * platform/chromium-win/svg/custom/invalid-css-expected.txt:
        * platform/chromium-win/svg/custom/mask-invalidation-expected.txt:
        * platform/chromium-win/svg/custom/non-opaque-filters-expected.txt:
        * platform/chromium-win/svg/custom/resource-invalidate-on-target-update-expected.checksum:
        * platform/chromium-win/svg/custom/resource-invalidate-on-target-update-expected.png:
        * platform/chromium-win/svg/custom/text-filter-expected.checksum:
        * platform/chromium-win/svg/custom/text-filter-expected.png:
        * platform/chromium-win/svg/custom/text-filter-expected.txt:
        * platform/chromium-win/svg/custom/visibility-override-filter-expected.checksum:
        * platform/chromium-win/svg/custom/visibility-override-filter-expected.png:
        * platform/chromium-win/svg/filters/big-sized-filter-2-expected.checksum:
        * platform/chromium-win/svg/filters/big-sized-filter-2-expected.png:
        * platform/chromium-win/svg/filters/big-sized-filter-expected.checksum:
        * platform/chromium-win/svg/filters/big-sized-filter-expected.png:
        * platform/chromium-win/svg/filters/feColorMatrix-values-expected.checksum:
        * platform/chromium-win/svg/filters/feColorMatrix-values-expected.png:
        * platform/chromium-win/svg/filters/feColorMatrix-values-expected.txt:
        * platform/chromium-win/svg/filters/feComposite-expected.checksum:
        * platform/chromium-win/svg/filters/feComposite-expected.png:
        * platform/chromium-win/svg/filters/feComposite-expected.txt:
        * platform/chromium-win/svg/filters/feGaussianBlur-expected.checksum:
        * platform/chromium-win/svg/filters/feGaussianBlur-expected.png:
        * platform/chromium-win/svg/filters/feMerge-expected.checksum:
        * platform/chromium-win/svg/filters/feMerge-expected.png:
        * platform/chromium-win/svg/filters/feOffset-expected.checksum:
        * platform/chromium-win/svg/filters/feOffset-expected.png:
        * platform/chromium-win/svg/filters/feTile-expected.checksum:
        * platform/chromium-win/svg/filters/feTile-expected.png:
        * platform/chromium-win/svg/filters/filter-on-tspan-expected.checksum:
        * platform/chromium-win/svg/filters/filter-on-tspan-expected.png:
        * platform/chromium-win/svg/filters/filter-on-tspan-expected.txt:
        * platform/chromium-win/svg/filters/shadow-on-filter-expected.checksum:
        * platform/chromium-win/svg/filters/shadow-on-filter-expected.png:
        * platform/chromium-win/svg/filters/sourceAlpha-expected.txt:
        * platform/chromium-win/svg/filters/subRegion-in-userSpace-expected.checksum:
        * platform/chromium-win/svg/filters/subRegion-in-userSpace-expected.png:
        * platform/chromium-win/svg/filters/subRegion-one-effect-expected.checksum:
        * platform/chromium-win/svg/filters/subRegion-one-effect-expected.png:
        * platform/chromium-win/svg/filters/subRegion-two-effects-expected.checksum:
        * platform/chromium-win/svg/filters/subRegion-two-effects-expected.png:
        * platform/chromium-win/svg/text/text-vkern-expected.checksum: Added.
        * platform/chromium-win/svg/text/text-vkern-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, fixing the expectations for Chromium.
dumi@chromium.org [Tue, 11 May 2010 04:12:22 +0000 (04:12 +0000)]
Unreviewed, fixing the expectations for Chromium.

* platform/chromium/http/tests/security/cross-frame-access-call-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix a crash when closing a WebView while the Web Inspector is open.
timothy@apple.com [Tue, 11 May 2010 03:51:02 +0000 (03:51 +0000)]
Fix a crash when closing a WebView while the Web Inspector is open.

<rdar://problem/7966830>

Reviewed by Mark Rowe.

* WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController destroyInspectorView]): Null check Page since it can be null.
* WebView/WebView.mm:
(-[WebView _close]): Null out _private->page before deleting the page, so code called
during destruction don't access a half deleted Page object.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 11 May 2010 03:45:56 +0000 (03:45 +0000)]
2010-05-10  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        [chromium] Build DRT when running build-webkit --chromium
        https://bugs.webkit.org/show_bug.cgi?id=38730

        This allows DRT to use the same .o and .lib files when building
        on Windows.

        * WebKit.gyp: Move DRT.gyp targets into this file.
        * gyp_webkit: DRT.gyp is gone
2010-05-10  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        [chromium] Build DRT when running build-webkit --chromium
        https://bugs.webkit.org/show_bug.cgi?id=38730

        * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Removed.
        * Scripts/build-dumprendertree: This does nothing now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 11 May 2010 03:40:24 +0000 (03:40 +0000)]
2010-05-10  Eric Seidel  <eric@webkit.org>

        Unreviewed, just removing newline from -expected.txt file

        REGRESSION(r59100): "Added test is broken on many platforms." (Requested by eseidel on #webkit).
        https://bugs.webkit.org/show_bug.cgi?id=38881

        Looks like http://trac.webkit.org/changeset/59119
        added an extra newline by mistake.  Removing.

        * plugins/geturlnotify-during-document-teardown-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, fixing Qt's expectations.
dumi@chromium.org [Tue, 11 May 2010 02:54:25 +0000 (02:54 +0000)]
Unreviewed, fixing Qt's expectations.

* platform/qt/http/tests/security/cross-frame-access-call-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove conflict markers from ChangeLog
abarth@webkit.org [Tue, 11 May 2010 02:39:33 +0000 (02:39 +0000)]
Remove conflict markers from ChangeLog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION(r59100): Added test is broken on many platforms.
jhoneycutt@apple.com [Tue, 11 May 2010 02:35:56 +0000 (02:35 +0000)]
REGRESSION(r59100): Added test is broken on many platforms.
https://bugs.webkit.org/show_bug.cgi?id=38881

Reviewed by Eric Seidel.

* platform/mac-snowleopard/Skipped:
Skipped, because we're not logging NPP_Destroy on Snow Leopard.

* platform/qt/Skipped:
Skipped due to lack of support for setCallCloseOnWebViews on
LayoutTestController.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION(r59100): Added test is broken on many platforms.
jhoneycutt@apple.com [Tue, 11 May 2010 02:35:35 +0000 (02:35 +0000)]
REGRESSION(r59100): Added test is broken on many platforms.
https://bugs.webkit.org/show_bug.cgi?id=38881

Reviewed by Eric Seidel.

WebKitTools:

* DumpRenderTree/win/TestNetscapePlugin/main.cpp:
(NPP_Destroy):
Use pluginLog, rather than printf, to match other platforms.

LayoutTests:

* plugins/geturlnotify-during-document-teardown-expected.txt:
Update the expected result.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Cleaning up and fixing the existing JSC DB bindings.
dumi@chromium.org [Tue, 11 May 2010 02:06:11 +0000 (02:06 +0000)]
WebCore: Cleaning up and fixing the existing JSC DB bindings.
https://bugs.webkit.org/show_bug.cgi?id=34994

Reviewed by Brady Eidson.

* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::openDatabase):
* bindings/js/JSDatabaseCustom.cpp:
(WebCore::JSDatabase::changeVersion):
(WebCore::createTransaction):
(WebCore::JSDatabase::transaction):
(WebCore::JSDatabase::readTransaction):
* bindings/js/JSSQLTransactionCustom.cpp:
(WebCore::JSSQLTransaction::executeSql):

LayoutTests: Fixing the expectations for openDatabase() in cross-frame-access-call.html.
Related to changes in patches #6 and #7 at https://bugs.webkit.org/show_bug.cgi?id=34994.

Reviewed by Brady Eidson.

* http/tests/security/cross-frame-access-call-expected.txt:
* http/tests/security/cross-frame-access-call.html:
* platform/chromium-linux/http/tests/security/cross-frame-access-call-expected.txt: Removed.
* platform/chromium-mac/http/tests/security/cross-frame-access-call-expected.txt: Removed.
* platform/chromium-win/http/tests/security/cross-frame-access-call-expected.txt: Removed.
* platform/chromium/http: Added.
* platform/chromium/http/tests: Added.
* platform/chromium/http/tests/security: Added.
* platform/chromium/http/tests/security/cross-frame-access-call-expected.txt: Copied from LayoutTests/platform/chromium-win/http/tests/security/cross-frame-access-call-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 11 May 2010 01:52:33 +0000 (01:52 +0000)]
2010-05-10  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, build fix.

        Fix a build failure caused by assuming the default platform in
        a unit test for new-run-webkit-tests instead of specifying
        --platform test.

        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Tue, 11 May 2010 01:50:38 +0000 (01:50 +0000)]
2010-05-10  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Alexey Proskuryakov.

        WebSocket needs to suspend/resume as Active DOM object.
        https://bugs.webkit.org/show_bug.cgi?id=38171

        Implement suspend()/resume() in WebSocket and WebSocketChannel.
        While WebSocketChannel is suspended, it only adds received data in m_buffer
        or record the handle was closed, and report no event to WebSocket.
        When resumed, it will process buffer or handle closing.
        Since suspend/resume would be called while processing JavaScript event handler (e.g. before/after alert()), WebSocketChannel method that would fire an event need to be reentrant.
        So, WebSocketChannel::processBuffer() call WebSocket to fire an event at most once and skips buffer before the calling,
        so that next call of processBuffer() would process the next frame.

        * websockets/ThreadableWebSocketChannel.h:
        * websockets/ThreadableWebSocketChannelClientWrapper.h:
        (WebCore::ThreadableWebSocketChannelClientWrapper::didConnect):
          Mark channel is opened, and process pending events if not suspended.
        (WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessage):
          Push message back in pending queue, and process pending events if not suspended.
        (WebCore::ThreadableWebSocketChannelClientWrapper::didClose):
          Mark channel is closed, and process pending events if not suspended.
        (WebCore::ThreadableWebSocketChannelClientWrapper::suspend):
          Mark suspended.
        (WebCore::ThreadableWebSocketChannelClientWrapper::resume):
          Unmark suspended, and process pending events.
        (WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
        (WebCore::ThreadableWebSocketChannelClientWrapper::processPendingEvents):
        * websockets/WebSocket.cpp:
        (WebCore::WebSocket::canSuspend):
        (WebCore::WebSocket::suspend):
        (WebCore::WebSocket::resume):
        (WebCore::WebSocket::didClose):
        * websockets/WebSocket.h:
        * websockets/WebSocketChannel.cpp:
        (WebCore::WebSocketChannel::WebSocketChannel):
        (WebCore::WebSocketChannel::connect):
        (WebCore::WebSocketChannel::send):
        (WebCore::WebSocketChannel::bufferedAmount):
        (WebCore::WebSocketChannel::close):
        (WebCore::WebSocketChannel::suspend):
        (WebCore::WebSocketChannel::resume):
         When resumed, it will process buffer and
         handle closing if handle was already closed while suspended.
        (WebCore::WebSocketChannel::didClose):
         If suspended, record unhandled bufferedAmount and set m_closed true, so that closing will be processed when resumed.
        (WebCore::WebSocketChannel::didReceiveData):
         Add received data in buffer and process buffer while it is not suspended.
        (WebCore::WebSocketChannel::processBuffer):
         Process handshake header or one frame message.
         Return true if there are more data to be processed.
         Return false otherwise (e.g. incomplete handshake header or incomplete frame).
        * websockets/WebSocketChannel.h:
        * websockets/WorkerThreadableWebSocketChannel.cpp:
        (WebCore::WorkerThreadableWebSocketChannel::suspend):
        (WebCore::WorkerThreadableWebSocketChannel::resume):
        (WebCore::WorkerThreadableWebSocketChannel::Peer::suspend):
        (WebCore::WorkerThreadableWebSocketChannel::Peer::resume):
        (WebCore::WorkerThreadableWebSocketChannel::mainThreadSuspend):
        (WebCore::WorkerThreadableWebSocketChannel::Bridge::suspend):
        (WebCore::WorkerThreadableWebSocketChannel::mainThreadResume):
        (WebCore::WorkerThreadableWebSocketChannel::Bridge::resume):
        * websockets/WorkerThreadableWebSocketChannel.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 John Gregg <johnnyg@google.com>
johnnyg@google.com [Tue, 11 May 2010 01:45:16 +0000 (01:45 +0000)]
2010-05-10  John Gregg  <johnnyg@google.com>

        [chromium] Fix sort order for expectations after previous change.

        * platform/chromium/fast/dom/prototype-inheritance-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 11 May 2010 01:30:18 +0000 (01:30 +0000)]
2010-05-10  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, build-fix

        new-run-webkit-tests: fix test failure caused by me failing to update
        the expected output. Also, run '--platform test' instead of
        'platform dryrun' since the former is guaranteed to work and the
        latter isn't.

        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoImplement the JSC bindings for the sync DB API.
dumi@chromium.org [Tue, 11 May 2010 01:18:42 +0000 (01:18 +0000)]
Implement the JSC bindings for the sync DB API.
https://bugs.webkit.org/show_bug.cgi?id=34994

Reviewed by Brady Eidson.

* bindings/js/JSDatabaseSyncCustom.cpp:
(WebCore::JSDatabaseSync::changeVersion):
(WebCore::createTransaction):
* bindings/js/JSSQLTransactionSyncCustom.cpp:
(WebCore::JSSQLTransactionSync::executeSql):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 John Gregg <johnnyg@google.com>
johnnyg@google.com [Tue, 11 May 2010 01:07:32 +0000 (01:07 +0000)]
2010-05-10  John Gregg  <johnnyg@google.com>

        [chromium] Unreviewed, test expectation change for Chromium following r59010.

        * platform/chromium/fast/dom/prototype-inheritance-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Dean Jackson <dino@apple.com>
dino@apple.com [Tue, 11 May 2010 00:44:58 +0000 (00:44 +0000)]
2010-05-10  Dean Jackson  <dino@apple.com>

        Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=36566
        The animation-fill-mode property was missing from
        a few places where the animation shorthand is set up.

        Test: animations/animation-shorthand-removed.html

        * css/CSSMutableStyleDeclaration.cpp:
        (WebCore::CSSMutableStyleDeclaration::getPropertyValue): Make sure
        animation-fill-mode is included in the animation shorthand
        * css/CSSPropertyLonghand.cpp:
        (WebCore::initShorthandMap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 John Abd-El-Malek <jam@chromium.org>
jam@chromium.org [Tue, 11 May 2010 00:10:07 +0000 (00:10 +0000)]
2010-05-10  John Abd-El-Malek  <jam@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Add WebKitScrollbar interface to allow Chromium code to reuse the scrollbar code
        https://bugs.webkit.org/show_bug.cgi?id=38854

        * public/WebScrollbar.h: Added.
        (WebKit::WebScrollbar::):
        (WebKit::WebScrollbar::~WebScrollbar):
        * public/WebScrollbarClient.h: Added.
        * public/WebThemeEngine.h:
        * src/AssertMatchingEnums.cpp:
        * src/WebScrollbarImpl.cpp: Added.
        (WebKit::WebScrollbar::create):
        (WebKit::WebScrollbar::defaultThickness):
        (WebKit::WebScrollbarImpl::WebScrollbarImpl):
        (WebKit::WebScrollbarImpl::~WebScrollbarImpl):
        (WebKit::WebScrollbarImpl::setLocation):
        (WebKit::WebScrollbarImpl::value):
        (WebKit::WebScrollbarImpl::setValue):
        (WebKit::WebScrollbarImpl::setDocumentSize):
        (WebKit::WebScrollbarImpl::scroll):
        (WebKit::WebScrollbarImpl::paint):
        (WebKit::WebScrollbarImpl::handleInputEvent):
        (WebKit::WebScrollbarImpl::onMouseDown):
        (WebKit::WebScrollbarImpl::onMouseUp):
        (WebKit::WebScrollbarImpl::onMouseMove):
        (WebKit::WebScrollbarImpl::onMouseLeave):
        (WebKit::WebScrollbarImpl::onMouseWheel):
        (WebKit::WebScrollbarImpl::onKeyDown):
        (WebKit::WebScrollbarImpl::valueChanged):
        (WebKit::WebScrollbarImpl::invalidateScrollbarRect):
        (WebKit::WebScrollbarImpl::isActive):
        (WebKit::WebScrollbarImpl::scrollbarCornerPresent):
        (WebKit::WebScrollbarImpl::getTickmarks):
        * src/WebScrollbarImpl.h: Added.
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::scrollViewWithKeyboard):
        (WebKit::WebViewImpl::mapKeyCodeForScroll):
        * src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=38583
weinig@apple.com [Tue, 11 May 2010 00:08:33 +0000 (00:08 +0000)]
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=38583
<rdar://problem/7948784> Crash in Element::normalizeAttributes.

Reviewed by Darin Adler.

Test: fast/dom/Element/normalize-crash.html

* dom/Element.cpp:
(WebCore::Element::normalizeAttributes): Copy attributes to a vector
before iterating.
* dom/NamedAttrMap.cpp:
(WebCore::NamedNodeMap::copyAttributesToVector): Added.
* dom/NamedAttrMap.h:

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=38583
<rdar://problem/7948784> Crash in Element::normalizeAttributes.

Reviewed by Darin Adler.

* fast/dom/Element/normalize-crash-expected.txt: Added.
* fast/dom/Element/normalize-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 11 May 2010 00:01:21 +0000 (00:01 +0000)]
2010-05-10  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by David Levin.

        new-run-webkit-tests: looks like the unicode conversion broke
        --print-last-failures and --retest-last-failures. Fixing.

        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 11 May 2010 00:00:15 +0000 (00:00 +0000)]
2010-05-10  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by David Levin.

        Re-attempt to fix 38616 - newline handling in new-run-webkit-tests.
        I didn't handle some cases correctly before and the solution was
        confusing. The new patch assumes all calls to the printing module
        don't have newlines, and will append newlines where necessary, just
        like logging does.

        https://bugs.webkit.org/show_bug.cgi?id=38790

        * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
        * Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/printing.py:
        * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 John Gregg <johnnyg@google.com>
johnnyg@google.com [Mon, 10 May 2010 23:58:12 +0000 (23:58 +0000)]
2010-05-10  John Gregg  <johnnyg@google.com>

        [chromium] Unreviewed, svg test rebaselines after r59002 for linux.

        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-displace-01-f-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-image-01-b-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-offset-01-b-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-tile-01-b-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-tile-01-b-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Added.
        * platform/chromium-linux/svg/batik/filters/feTile-expected.checksum:
        * platform/chromium-linux/svg/batik/filters/feTile-expected.png:
        * platform/chromium-linux/svg/batik/filters/feTile-expected.txt: Added.
        * platform/chromium-linux/svg/batik/filters/filterRegions-expected.checksum:
        * platform/chromium-linux/svg/batik/filters/filterRegions-expected.png:
        * platform/chromium-linux/svg/batik/filters/filterRegions-expected.txt: Added.
        * platform/chromium-linux/svg/batik/masking/maskRegions-expected.txt: Added.
        * platform/chromium-linux/svg/batik/text/textEffect-expected.checksum:
        * platform/chromium-linux/svg/batik/text/textEffect-expected.png: Added.
        * platform/chromium-linux/svg/batik/text/textEffect-expected.txt: Added.
        * platform/chromium-linux/svg/batik/text/textEffect3-expected.checksum:
        * platform/chromium-linux/svg/batik/text/textEffect3-expected.png: Added.
        * platform/chromium-linux/svg/batik/text/textEffect3-expected.txt: Added.
        * platform/chromium-linux/svg/batik/text/textFeatures-expected.txt: Added.
        * platform/chromium-linux/svg/batik/text/textProperties-expected.txt: Added.
        * platform/chromium-linux/svg/custom/empty-mask-expected.txt: Added.
        * platform/chromium-linux/svg/custom/empty-merge-expected.checksum:
        * platform/chromium-linux/svg/custom/empty-merge-expected.png:
        * platform/chromium-linux/svg/custom/feComponentTransfer-Discrete-expected.checksum:
        * platform/chromium-linux/svg/custom/feComponentTransfer-Discrete-expected.png:
        * platform/chromium-linux/svg/custom/feComponentTransfer-Discrete-expected.txt: Added.
        * platform/chromium-linux/svg/custom/feComponentTransfer-Gamma-expected.checksum:
        * platform/chromium-linux/svg/custom/feComponentTransfer-Gamma-expected.png:
        * platform/chromium-linux/svg/custom/feComponentTransfer-Gamma-expected.txt: Added.
        * platform/chromium-linux/svg/custom/feComponentTransfer-Linear-expected.checksum:
        * platform/chromium-linux/svg/custom/feComponentTransfer-Linear-expected.png:
        * platform/chromium-linux/svg/custom/feComponentTransfer-Linear-expected.txt: Added.
        * platform/chromium-linux/svg/custom/feComponentTransfer-Table-expected.checksum:
        * platform/chromium-linux/svg/custom/feComponentTransfer-Table-expected.png:
        * platform/chromium-linux/svg/custom/feComponentTransfer-Table-expected.txt: Added.
        * platform/chromium-linux/svg/custom/feDisplacementMap-01-expected.checksum:
        * platform/chromium-linux/svg/custom/image-with-transform-clip-filter-expected.checksum:
        * platform/chromium-linux/svg/custom/image-with-transform-clip-filter-expected.png: Removed.
        * platform/chromium-linux/svg/custom/image-with-transform-clip-filter-expected.txt:
        * platform/chromium-linux/svg/custom/invalid-css-expected.txt: Added.
        * platform/chromium-linux/svg/custom/mask-invalidation-expected.txt: Added.
        * platform/chromium-linux/svg/custom/non-opaque-filters-expected.txt: Added.
        * platform/chromium-linux/svg/custom/text-filter-expected.checksum:
        * platform/chromium-linux/svg/custom/text-filter-expected.png: Removed.
        * platform/chromium-linux/svg/custom/text-filter-expected.txt: Added.
        * platform/chromium-linux/svg/custom/visibility-override-filter-expected.checksum: Added.
        * platform/chromium-linux/svg/filters/big-sized-filter-2-expected.checksum: Added.
        * platform/chromium-linux/svg/filters/big-sized-filter-2-expected.png: Added.
        * platform/chromium-linux/svg/filters/big-sized-filter-expected.checksum: Added.
        * platform/chromium-linux/svg/filters/big-sized-filter-expected.png: Added.
        * platform/chromium-linux/svg/filters/feColorMatrix-values-expected.checksum: Added.
        * platform/chromium-linux/svg/filters/feColorMatrix-values-expected.png: Added.
        * platform/chromium-linux/svg/filters/feColorMatrix-values-expected.txt: Added.
        * platform/chromium-linux/svg/filters/feComposite-expected.checksum:
        * platform/chromium-linux/svg/filters/feComposite-expected.png: Removed.
        * platform/chromium-linux/svg/filters/feComposite-expected.txt: Added.
        * platform/chromium-linux/svg/filters/feGaussianBlur-expected.checksum: Added.
        * platform/chromium-linux/svg/filters/feMerge-expected.checksum: Added.
        * platform/chromium-linux/svg/filters/feMerge-expected.png: Added.
        * platform/chromium-linux/svg/filters/feOffset-expected.checksum: Added.
        * platform/chromium-linux/svg/filters/feTile-expected.checksum: Added.
        * platform/chromium-linux/svg/filters/feTile-expected.png: Added.
        * platform/chromium-linux/svg/filters/filter-on-tspan-expected.checksum:
        * platform/chromium-linux/svg/filters/filter-on-tspan-expected.png: Removed.
        * platform/chromium-linux/svg/filters/filter-on-tspan-expected.txt: Added.
        * platform/chromium-linux/svg/filters/sourceAlpha-expected.txt: Added.
        * platform/chromium-linux/svg/filters/subRegion-in-userSpace-expected.checksum: Added.
        * platform/chromium-linux/svg/filters/subRegion-in-userSpace-expected.png: Added.
        * platform/chromium-linux/svg/filters/subRegion-one-effect-expected.checksum:
        * platform/chromium-linux/svg/filters/subRegion-one-effect-expected.png: Removed.
        * platform/chromium-linux/svg/filters/subRegion-two-effects-expected.checksum:
        * platform/chromium-linux/svg/filters/subRegion-two-effects-expected.png: Removed.
        * platform/chromium-linux/svg/text/text-vkern-expected.checksum: Added.
        * platform/chromium-linux/svg/text/text-vkern-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[V8] Fix V8 code generator script to generate the correct code for
jianli@chromium.org [Mon, 10 May 2010 23:38:18 +0000 (23:38 +0000)]
[V8] Fix V8 code generator script to generate the correct code for
converting ScriptString.
https://bugs.webkit.org/show_bug.cgi?id=38873

Reviewed by Adam Barth.

Updated the bindings test result. Note that the result is also updated
to reflect other script generator changes not introduced by this patch.

* bindings/scripts/CodeGeneratorV8.pm:
* bindings/scripts/test/JS/JSTestCallback.cpp:
(WebCore::JSTestCallback::JSTestCallback):
(WebCore::JSTestCallback::~JSTestCallback):
* bindings/scripts/test/JS/JSTestCallback.h:
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::scriptStringAttrAttrGetter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd test to GTK skipped list.
jhoneycutt@apple.com [Mon, 10 May 2010 23:35:51 +0000 (23:35 +0000)]
Add test to GTK skipped list.

Rubber-stamped by Mark Rowe.

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix the 32-bit WebKit2 build.
mrowe@apple.com [Mon, 10 May 2010 23:14:53 +0000 (23:14 +0000)]
Fix the 32-bit WebKit2 build.

* WebCore.base.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Mon, 10 May 2010 23:02:46 +0000 (23:02 +0000)]
2010-05-10  Kent Tamura  <tkent@chromium.org>

        Reviewed by Adam Barth.

        Make tkent a reviewer
        https://bugs.webkit.org/show_bug.cgi?id=38875

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCrash closing window containing Flash plug-in
jhoneycutt@apple.com [Mon, 10 May 2010 22:56:26 +0000 (22:56 +0000)]
Crash closing window containing Flash plug-in
https://bugs.webkit.org/show_bug.cgi?id=38797
<rdar://problem/7935266>

Reviewed by Eric Seidel.

WebCore:

Test: plugins/geturlnotify-during-document-teardown.html

* plugins/PluginView.cpp:
(WebCore::PluginView::load):
Null check the DocumentLoader; it's possible for this to be null while
the Document is being torn down and before the plug-in is destroyed.

WebKitTools:

* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
(pluginAllocate):
Initialize new member to false.

* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
Added a new member.

* DumpRenderTree/win/TestNetscapePlugin/main.cpp:
(NPP_New):
Check whether the element has the "testGetURLOnDestroy" attribute, and
record that.
(NPP_Destroy):
If "testGetURLOnDestroy" is set, perform a load while destroying the
plug-in.

LayoutTests:

* plugins/geturlnotify-during-document-teardown.html: Added.
* plugins/resources/geturlnotify-on-destroy.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 10 May 2010 22:48:18 +0000 (22:48 +0000)]
2010-05-10  Eric Seidel  <eric@webkit.org>

        Reviewed by David Levin.

        Executive.kill_* do not work with windows python
        https://bugs.webkit.org/show_bug.cgi?id=38872

        http://trac.webkit.org/changeset/57444 is where the original
        breakage occurred.
        http://trac.webkit.org/changeset/58314 is where the regression
        started affecting chromium.

        I have since learned that sys.platform has no "windows" value.
        "win32" is always the value, under 32 or 64 bit windows

        The tests for this code are not run anywhere because
        test-webkitpy does not yet work on "win32".  Mostly due to
        depending on unixisms like "cat" and "yes".

        * Scripts/webkitpy/common/system/executive.py:
        * Scripts/webkitpy/common/system/executive_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Darin Adler.
ap@apple.com [Mon, 10 May 2010 22:13:36 +0000 (22:13 +0000)]
    Reviewed by Darin Adler.

        Based on a patch by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=28697
        <rdar://problem/7946578> WebKit crash on WebCore::Node::nodeIndex()

        It's not OK to call ContainerNode::willRemoveChild() in a loop, because Range code assumes
        that it can adjust start and end position to any node except for the one being removed -
        so these notifications cannot be batched.

        Test: fast/dom/Range/remove-all-children-crash.html

        * dom/ContainerNode.cpp:
        (WebCore::willRemoveChild): Removed unused ExceptionCode.
        (WebCore::willRemoveChildren): New function, used in removeChildren() case.
        (WebCore::ContainerNode::removeChild): ExceptionCode return was always 0, don't bother with it.
        (WebCore::ContainerNode::removeChildren): Call willRemoveChildrenFromNode.
        (WebCore::dispatchChildRemovalEvents): Moved some logic out into willRemoveChildrenFromNode
        and willRemoveChild.

        * dom/Document.cpp:
        (WebCore::Document::nodeChildrenWillBeRemoved): New function, used in removeChildren() case.

        * dom/Document.h:
        (WebCore::Document::nodeChildrenWillBeRemoved): New function, used in removeChildren() case.

        * dom/Range.h:
        * dom/Range.cpp:
        (WebCore::boundaryNodeChildrenWillBeRemoved): New function, used in removeChildren() case.
        (WebCore::Range::nodeChildrenWillBeRemoved): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoImplement the V8 bindings for the sync DB API.
dumi@chromium.org [Mon, 10 May 2010 21:34:40 +0000 (21:34 +0000)]
Implement the V8 bindings for the sync DB API.
https://bugs.webkit.org.show_bug.cgi?id=34994

Reviewed by Adam Barth.

* bindings/v8/custom/V8DatabaseSyncCustom.cpp:
(WebCore::V8DatabaseSync::changeVersionCallback):
(WebCore::createTransaction):
* bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:
(WebCore::V8SQLTransactionSync::executeSqlCallback):
* bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::V8WorkerContextCustom::openDatabaseSyncCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoClean up and fix the existing V8 DB bindings.
dumi@chromium.org [Mon, 10 May 2010 20:46:34 +0000 (20:46 +0000)]
Clean up and fix the existing V8 DB bindings.
https://bugs.webkit.org/show_bug.cgi?id=34994

Reviewed by Adam Barth.

* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::openDatabaseCallback):
* bindings/v8/custom/V8DatabaseCustom.cpp:
(WebCore::V8Database::changeVersionCallback):
(WebCore::createTransaction):
* bindings/v8/custom/V8SQLTransactionCustom.cpp:
(WebCore::V8SQLTransaction::executeSqlCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[wx] Build fix for wx 2.8 after complex text changes.
kevino@webkit.org [Mon, 10 May 2010 20:03:07 +0000 (20:03 +0000)]
[wx] Build fix for wx 2.8 after complex text changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnbreak the world. (Fix Mac builds).
andersca@apple.com [Mon, 10 May 2010 19:59:45 +0000 (19:59 +0000)]
Unbreak the world. (Fix Mac builds).

* Plugins/Hosted/WebKitPluginHostTypes.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-07 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Mon, 10 May 2010 19:53:34 +0000 (19:53 +0000)]
2010-05-07  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Eric Seidel.

        Add a bunch of windows-specific chromium baselines for the different
        versions of windows to update them from a skia change.

        https://bugs.webkit.org/show_bug.cgi?id=38784

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Mon, 10 May 2010 19:47:16 +0000 (19:47 +0000)]
2010-05-10  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Eric Seidel.

        Fix a bug in rebaseline-chromium-webkit-tests where we would crash
        instead of logging an error and exiting if it couldn't find either a
        debug or a release build of the image diff binary.

        https://bugs.webkit.org/show_bug.cgi?id=38692

        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 10 May 2010 19:46:30 +0000 (19:46 +0000)]
2010-05-10  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        new-run-webkit-tests fails when run under sys.platform == "windows" due to undefined signal.SIGKILL
        https://bugs.webkit.org/show_bug.cgi?id=38861

        * Scripts/webkitpy/common/system/executive.py:
        * Scripts/webkitpy/common/system/executive_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 John Gregg <johnnyg@google.com>
johnnyg@google.com [Mon, 10 May 2010 19:36:11 +0000 (19:36 +0000)]
2010-05-10  John Gregg  <johnnyg@google.com>

        [chromium] Try to fix the chromium build after r59085 by
        including MathExtras.h before using isnan().
        https://bugs.webkit.org/show_bug.cgi?id=38860

        * html/canvas/WebGLIntegralTypedArrayBase.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[wx] Build fix for wx trunk after complex text changes.
kevino@webkit.org [Mon, 10 May 2010 18:59:09 +0000 (18:59 +0000)]
[wx] Build fix for wx trunk after complex text changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Tony Gentilcore <tonyg@chromium.org>
eric@webkit.org [Mon, 10 May 2010 18:14:09 +0000 (18:14 +0000)]
2010-05-10  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Adam Barth.

        Provide mechanism to cache metadata for a resource
        https://bugs.webkit.org/show_bug.cgi?id=37874

        No new tests because no new functionality.

        * WebCore.gypi:
        * loader/CachedMetadata.h: Added.
        (WebCore::CachedMetadata::create):
        (WebCore::CachedMetadata::deserialize):
        (WebCore::CachedMetadata::serialize):
        (WebCore::CachedMetadata::~CachedMetadata):
        (WebCore::CachedMetadata::dataTypeID):
        (WebCore::CachedMetadata::data):
        (WebCore::CachedMetadata::size):
        (WebCore::CachedMetadata::readUnsigned):
        (WebCore::CachedMetadata::appendUnsigned):
        (WebCore::CachedMetadata::CachedMetadata):
        * loader/CachedResource.cpp:
        (WebCore::CachedResource::setSerializedCachedMetadata):
        (WebCore::CachedResource::setCachedMetadata):
        (WebCore::CachedResource::cachedMetadata):
        * loader/CachedResource.h:
        * loader/ResourceLoader.h:
        (WebCore::ResourceLoader::didReceiveCachedMetadata):
        * loader/SubresourceLoader.cpp:
        (WebCore::SubresourceLoader::didReceiveCachedMetadata):
        * loader/SubresourceLoader.h:
        * loader/SubresourceLoaderClient.h:
        (WebCore::SubresourceLoaderClient::didReceiveCachedMetadata):
        * loader/loader.cpp:
        (WebCore::Loader::Host::didReceiveCachedMetadata):
        * loader/loader.h:
        * platform/network/ResourceHandle.cpp:
        (WebCore::ResourceHandle::cacheMetadata):
        * platform/network/ResourceHandle.h:
        * platform/network/ResourceHandleClient.h:
        (WebCore::ResourceHandleClient::didReceiveCachedMetadata):
2010-05-10  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Adam Barth.

        Provide mechanism to cache metadata for a resource
        https://bugs.webkit.org/show_bug.cgi?id=37874

        * src/ResourceHandle.cpp:
        (WebCore::ResourceHandle::cacheMetadata):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChange the order of the RendererType enum values, so that old versions of WebKitPlugi...
andersca@apple.com [Mon, 10 May 2010 18:12:14 +0000 (18:12 +0000)]
Change the order of the RendererType enum values, so that old versions of WebKitPluginHost will
use accelerated compositing and not layer backed views.

Reviewed by Simon Fraser.

* Plugins/Hosted/WebKitPluginHostTypes.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-09 Kenneth Russell <kbr@google.com>
kbr@google.com [Mon, 10 May 2010 17:53:21 +0000 (17:53 +0000)]
2010-05-09  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        Refactor WebGLArray types to share more code
        https://bugs.webkit.org/show_bug.cgi?id=37712

        Refactored WebGLArray types for maximal code sharing. Added
        WebGLTypedArrayBase and WebGLIntegralTypedArrayBase template
        superclasses. Changed overridden virtuals to have minimal
        visibility (private instead of public). Fixed const correctness of
        a few methods. There are no changes to the public APIs of the
        WebGLArray classes; the JavaScript bindings are unchanged.

        No new tests; existing tests cover this functionality. Ran all
        WebGL layout tests in Safari and Chromium on Mac OS X.

        * WebCore.gypi:
        * WebCore.xcodeproj/project.pbxproj:
        * html/canvas/WebGLArray.h:
        (WebCore::WebGLArray::buffer):
        (WebCore::WebGLArray::baseAddress):
        (WebCore::WebGLArray::byteOffset):
        * html/canvas/WebGLByteArray.cpp:
        (WebCore::WebGLByteArray::create):
        (WebCore::WebGLByteArray::WebGLByteArray):
        (WebCore::WebGLByteArray::slice):
        * html/canvas/WebGLByteArray.h:
        (WebCore::WebGLByteArray::isByteArray):
        * html/canvas/WebGLFloatArray.cpp:
        (WebCore::WebGLFloatArray::create):
        (WebCore::WebGLFloatArray::WebGLFloatArray):
        (WebCore::WebGLFloatArray::slice):
        * html/canvas/WebGLFloatArray.h:
        (WebCore::WebGLFloatArray::set):
        (WebCore::WebGLFloatArray::item):
        (WebCore::WebGLFloatArray::isFloatArray):
        * html/canvas/WebGLIntArray.cpp:
        (WebCore::WebGLIntArray::create):
        (WebCore::WebGLIntArray::WebGLIntArray):
        (WebCore::WebGLIntArray::slice):
        * html/canvas/WebGLIntArray.h:
        (WebCore::WebGLIntArray::isIntArray):
        * html/canvas/WebGLIntegralTypedArrayBase.h: Added.
        (WebCore::WebGLIntegralTypedArrayBase::set):
        (WebCore::WebGLIntegralTypedArrayBase::item):
        (WebCore::WebGLIntegralTypedArrayBase::WebGLIntegralTypedArrayBase):
        * html/canvas/WebGLShortArray.cpp:
        (WebCore::WebGLShortArray::create):
        (WebCore::WebGLShortArray::WebGLShortArray):
        (WebCore::WebGLShortArray::slice):
        * html/canvas/WebGLShortArray.h:
        (WebCore::WebGLShortArray::isShortArray):
        * html/canvas/WebGLTypedArrayBase.h: Added.
        (WebCore::WebGLTypedArrayBase::data):
        (WebCore::WebGLTypedArrayBase::set):
        (WebCore::WebGLTypedArrayBase::length):
        (WebCore::WebGLTypedArrayBase::WebGLTypedArrayBase):
        (WebCore::WebGLTypedArrayBase::create):
        (WebCore::WebGLTypedArrayBase::sliceImpl):
        (WebCore::WebGLTypedArrayBase::byteLength):
        * html/canvas/WebGLUnsignedByteArray.cpp:
        (WebCore::WebGLUnsignedByteArray::create):
        (WebCore::WebGLUnsignedByteArray::WebGLUnsignedByteArray):
        (WebCore::WebGLUnsignedByteArray::slice):
        * html/canvas/WebGLUnsignedByteArray.h:
        (WebCore::WebGLUnsignedByteArray::isUnsignedByteArray):
        * html/canvas/WebGLUnsignedIntArray.cpp:
        (WebCore::WebGLUnsignedIntArray::create):
        (WebCore::WebGLUnsignedIntArray::WebGLUnsignedIntArray):
        (WebCore::WebGLUnsignedIntArray::slice):
        * html/canvas/WebGLUnsignedIntArray.h:
        (WebCore::WebGLUnsignedIntArray::isUnsignedIntArray):
        * html/canvas/WebGLUnsignedShortArray.cpp:
        (WebCore::WebGLUnsignedShortArray::create):
        (WebCore::WebGLUnsignedShortArray::WebGLUnsignedShortArray):
        (WebCore::WebGLUnsignedShortArray::slice):
        * html/canvas/WebGLUnsignedShortArray.h:
        (WebCore::WebGLUnsignedShortArray::isUnsignedShortArray):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed.
jer.noble@apple.com [Mon, 10 May 2010 17:25:38 +0000 (17:25 +0000)]
Unreviewed.

Adding myself as a committer.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix, not reviewed.
bfulgham@webkit.org [Mon, 10 May 2010 17:12:11 +0000 (17:12 +0000)]
Build fix, not reviewed.

Correct post-build copy command for WinCairo port to make sure
cairo headers are available for WebKit.dll build.

* WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Mon, 10 May 2010 16:23:36 +0000 (16:23 +0000)]
2010-05-10  Dirk Schulze  <krit@webkit.org>

        Unreviewed.

        Further optimization for SVG's repaintRect calculation
        https://bugs.webkit.org/show_bug.cgi?id=38820

        New baseline for Qt.

        * platform/qt/svg/css/circle-in-mask-with-shadow-expected.txt:
        * platform/qt/svg/css/mask-with-shadow-expected.txt:
        * platform/qt/svg/custom/empty-mask-expected.txt:
        * platform/qt/svg/custom/mask-invalidation-expected.txt:
        * platform/qt/svg/custom/resource-invalidate-on-target-update-expected.txt:
        * platform/qt/svg/custom/transformedMaskFails-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Mon, 10 May 2010 15:59:19 +0000 (15:59 +0000)]
2010-05-10  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Further optimization for SVG's repaintRect calculation
        https://bugs.webkit.org/show_bug.cgi?id=38820

        This is a further optimization to get smaller repaintRects on SVG objects
        in combination with masker or clipper resources.
        Masker takes the unite of all stroke boundaries of it's childs.
        Both, clipper and masker, store this union to avoid multiple calls of the childs
        and the unite calculations now.
        The unite rect can be transformed to any targets objectBoundingBox, if the content
        unit of the resource is set to objectBoundingBoxMode.
        This speeds up the use of resources with multiple target objects.

        No behavior changes, the smaller repaintRects cause updates for DRT results.

        * rendering/RenderSVGResource.h:
        * rendering/RenderSVGResourceClipper.cpp:
        (WebCore::RenderSVGResourceClipper::invalidateClients):
        (WebCore::RenderSVGResourceClipper::calculateClipContentRepaintRect):
        (WebCore::RenderSVGResourceClipper::resourceBoundingBox):
        * rendering/RenderSVGResourceClipper.h:
        * rendering/RenderSVGResourceFilter.cpp:
        (WebCore::RenderSVGResourceFilter::resourceBoundingBox):
        * rendering/RenderSVGResourceFilter.h:
        * rendering/RenderSVGResourceGradient.h:
        (WebCore::RenderSVGResourceGradient::resourceBoundingBox):
        * rendering/RenderSVGResourceMarker.h:
        (WebCore::RenderSVGResourceMarker::resourceBoundingBox):
        * rendering/RenderSVGResourceMasker.cpp:
        (WebCore::RenderSVGResourceMasker::invalidateClients):
        (WebCore::RenderSVGResourceMasker::createMaskImage):
        (WebCore::RenderSVGResourceMasker::calculateMaskContentRepaintRect):
        (WebCore::RenderSVGResourceMasker::resourceBoundingBox):
        * rendering/RenderSVGResourceMasker.h:
        * rendering/RenderSVGResourcePattern.h:
        (WebCore::RenderSVGResourcePattern::resourceBoundingBox):
        * rendering/RenderSVGResourceSolidColor.h:
        (WebCore::RenderSVGResourceSolidColor::resourceBoundingBox):
2010-05-10  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Further optimization for SVG's repaintRect calculation
        https://bugs.webkit.org/show_bug.cgi?id=38820

        The repaintRect of SVG objects with masks got smaller. This made
        updates of some results necessary.

        * platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt:
        * platform/mac/svg/batik/masking/maskRegions-expected.txt:
        * platform/mac/svg/clip-path/clip-path-with-invisibile-child-expected.txt:
        * platform/mac/svg/css/circle-in-mask-with-shadow-expected.txt:
        * platform/mac/svg/css/mask-with-shadow-expected.txt:
        * platform/mac/svg/custom/empty-mask-expected.txt:
        * platform/mac/svg/custom/mask-excessive-malloc-expected.txt:
        * platform/mac/svg/custom/mask-inside-defs-expected.txt:
        * platform/mac/svg/custom/mask-invalidation-expected.txt:
        * platform/mac/svg/custom/mask-with-all-units-expected.txt:
        * platform/mac/svg/custom/resource-invalidate-on-target-update-expected.txt:
        * platform/mac/svg/custom/visibility-override-mask-expected.txt:
        * svg/custom/transformedMaskFails-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-11 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Mon, 10 May 2010 15:21:41 +0000 (15:21 +0000)]
2010-05-11  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        WebInspector: Cosmetic changes.
        1) Inner Function Call event of Timer Fire should be merged into parent even if it is not the only child.
        2) Standard tooltips for resource links are clashing with Popover.
        3) Recalculate Style caller info are duplicating in Details Popover (Caller and Details rows).
        https://bugs.webkit.org/show_bug.cgi?id=38732

        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
        (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
        (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
        * inspector/front-end/inspector.js:
        (WebInspector.linkifyURLAsNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Hans Wennborg <hans@chromium.org>
eric@webkit.org [Mon, 10 May 2010 14:48:55 +0000 (14:48 +0000)]
2010-05-10  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        Layout test for Session Storage quota should only expect to fit 39 objects.
        https://bugs.webkit.org/show_bug.cgi?id=38843

        The script should be ready for the exception when inserting the 40th
        element, as that is where it will be thrown if a quota is enforced.
        This is the same change as in http://trac.webkit.org/changeset/50979.

        * storage/domstorage/quota-expected.txt:
        * storage/domstorage/script-tests/quota.js:
        (testNoQuota):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Adam Langley <agl@chromium.org>
agl@chromium.org [Mon, 10 May 2010 14:36:20 +0000 (14:36 +0000)]
2010-05-10  Adam Langley  <agl@chromium.org>

        Expectations change. Not reviewed.

        Delete the current baselines for the WOFF test because they are
        incomplete.

        Remove the SKIP tag from test_expectations so that the builders
        will run the test and then the rebaseline tool can be used to
        checkin real baselines.

        * platform/chromium-linux/fast/css/font-face-woff-expected.checksum: Removed.
        * platform/chromium-win/fast/css/font-face-woff-expected.checksum: Removed.
        * platform/chromium-win/fast/css/font-face-woff-expected.txt: Removed.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Hans Wennborg <hans@chromium.org>
eric@webkit.org [Mon, 10 May 2010 14:27:26 +0000 (14:27 +0000)]
2010-05-10  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        [Chromium] Add quota parameter to WebViewClient::createSessionStorageNamespace()
        https://bugs.webkit.org/show_bug.cgi?id=38750

        Put a per-origin quota on session storage since it is using memory in
        the browser process, and should not be allowed to grow arbitrarily
        large. See also http://trac.webkit.org/changeset/58828.

        * public/WebStorageNamespace.h:
        * public/WebViewClient.h:
        (WebKit::WebViewClient::createSessionStorageNamespace):
        * src/StorageNamespaceProxy.cpp:
        (WebCore::StorageNamespace::sessionStorageNamespace):

2010-05-10  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        [Chromium] Add quota parameter to WebViewClient::createSessionStorageNamespace()
        https://bugs.webkit.org/show_bug.cgi?id=38750

        Put a per-origin quota on session storage since it is using memory in
        the browser process, and should not be allowed to grow arbitrarily
        large. See also http://trac.webkit.org/changeset/58828.

        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::createSessionStorageNamespace):
        * DumpRenderTree/chromium/WebViewHost.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Roll-out r59020 and r59021, because the Qt part of these changes
ossy@webkit.org [Mon, 10 May 2010 14:03:26 +0000 (14:03 +0000)]
[Qt] Roll-out r59020 and r59021, because the Qt part of these changes
haven't been landed in Qt trunk yet. Should be rolled-in again after the merge.

Rubber-stamped by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=32967

WebCore:

* platform/network/qt/ResourceRequestQt.cpp:
(WebCore::ResourceRequest::toNetworkRequest):

WebKitTools:

* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::WebPage::WebPage):
(WebCore::DumpRenderTree::DumpRenderTree):
* DumpRenderTree/qt/DumpRenderTreeQt.h:

LayoutTests:

* platform/qt/Skipped:
* platform/qt/http/tests/xmlhttprequest/cross-origin-no-authorization-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Markus Goetz <Markus.Goetz@nokia.com>
eric@webkit.org [Mon, 10 May 2010 13:18:38 +0000 (13:18 +0000)]
2010-05-10  Markus Goetz  <Markus.Goetz@nokia.com>

        Reviewed by Simon Hausmann.

        Qt after 4.6.3 has its integrated DNS cache. Therefore some
        code is not necessary anymore.

        https://bugs.webkit.org/show_bug.cgi?id=38834

        * platform/network/qt/DnsPrefetchHelper.h:
        (WebCore::DnsPrefetchHelper::lookup):
        (WebCore::DnsPrefetchHelper::lookedUp):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Mon, 10 May 2010 13:07:31 +0000 (13:07 +0000)]
2010-05-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Darin Adler.

        [Qt] Disable JIT support for mingw-w64
        https://bugs.webkit.org/show_bug.cgi?id=38747

        Disale JIT for mingw-w64 as it is reportedly
        unstable.

        Thanks for Vanboxem Rruben for the investigation.

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Mon, 10 May 2010 11:53:47 +0000 (11:53 +0000)]
2010-05-10  Dirk Schulze  <krit@webkit.org>

        Uneviewed.

        SVG FilterEffects need more detailed DRT information
        https://bugs.webkit.org/show_bug.cgi?id=38683

        New baseline for Win. Only two tests needed an update.

        * platform/win/svg/custom/image-with-transform-clip-filter-expected.txt:
        * platform/win/svg/filters/feColorMatrix-values-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Chris Jerdonek <cjerdonek@webkit.org>
eric@webkit.org [Mon, 10 May 2010 11:40:49 +0000 (11:40 +0000)]
2010-05-10  Chris Jerdonek  <cjerdonek@webkit.org>

        Reviewed by Darin Adler.

        Asserted that Node::setDocument() is not being used to change
        the document of a node.

        https://bugs.webkit.org/show_bug.cgi?id=38821

        * dom/Node.cpp:
        (WebCore::Node::setDocument):
          Added an ASSERT at the beginning of the function.
        * dom/Node.h:
          Documented that Node::setDocument() should not be used to change the
          document of a node until after the node has been removed from its
          prior document.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Mon, 10 May 2010 11:37:33 +0000 (11:37 +0000)]
2010-05-10  Dirk Schulze  <krit@webkit.org>

        Unreviewed.

        SVG FilterEffects need more detailed DRT information
        https://bugs.webkit.org/show_bug.cgi?id=38683

        New baseline for Gtk. Just one test needed an update.

        * platform/gtk/svg/filters/filter-on-tspan-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Mon, 10 May 2010 11:34:49 +0000 (11:34 +0000)]
2010-05-10  Dirk Schulze  <krit@webkit.org>

        Unreviewed.

        SVG FilterEffects need more detailed DRT information
        https://bugs.webkit.org/show_bug.cgi?id=38683

        New baseline for Qt.

        * platform/qt/svg/custom/resource-invalidate-on-target-update-expected.txt:
        * platform/qt/svg/filters/feColorMatrix-values-expected.txt:
        * platform/qt/svg/filters/feComposite-expected.txt:
        * platform/qt/svg/filters/feGaussianBlur-expected.txt:
        * platform/qt/svg/filters/feMerge-expected.txt:
        * platform/qt/svg/filters/feOffset-expected.txt:
        * platform/qt/svg/filters/feTile-expected.txt:
        * platform/qt/svg/filters/filter-clip-expected.txt:
        * platform/qt/svg/filters/filter-on-tspan-expected.txt:
        * platform/qt/svg/filters/filter-source-position-expected.txt:
        * platform/qt/svg/filters/shadow-on-filter-expected.txt:
        * platform/qt/svg/filters/shadow-on-rect-with-filter-expected.txt:
        * platform/qt/svg/filters/sourceAlpha-expected.txt:
        * platform/qt/svg/filters/subRegion-in-userSpace-expected.txt:
        * platform/qt/svg/filters/subRegion-one-effect-expected.txt:
        * platform/qt/svg/filters/subRegion-two-effects-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Mon, 10 May 2010 11:15:25 +0000 (11:15 +0000)]
2010-05-10  Dirk Schulze  <krit@webkit.org>

        Reviewed by Darin Adler.

        SVG FilterEffects need more detailed DRT information
        https://bugs.webkit.org/show_bug.cgi?id=38683

        All SVG Filter effects get dumped now. The structure of the DRT output
        changed. The last effect is shown first, followed by the previous effects.

        No changed behaior, so no new test added.

        * platform/graphics/filters/FEBlend.cpp:
        (WebCore::operator<<):
        (WebCore::FEBlend::externalRepresentation):
        * platform/graphics/filters/FEBlend.h:
        * platform/graphics/filters/FEColorMatrix.cpp:
        (WebCore::operator<<):
        (WebCore::FEColorMatrix::externalRepresentation):
        * platform/graphics/filters/FEColorMatrix.h:
        * platform/graphics/filters/FEComponentTransfer.cpp:
        (WebCore::operator<<):
        (WebCore::FEComponentTransfer::externalRepresentation):
        * platform/graphics/filters/FEComponentTransfer.h:
        * platform/graphics/filters/FEComposite.cpp:
        (WebCore::operator<<):
        (WebCore::FEComposite::externalRepresentation):
        * platform/graphics/filters/FEComposite.h:
        (WebCore::):
        (WebCore::FEComposite::uniteChildEffectSubregions):
        * platform/graphics/filters/FEGaussianBlur.cpp:
        (WebCore::FEGaussianBlur::externalRepresentation):
        * platform/graphics/filters/FEGaussianBlur.h:
        (WebCore::FEGaussianBlur::uniteChildEffectSubregions):
        * platform/graphics/filters/FilterEffect.cpp:
        (WebCore::FilterEffect::externalRepresentation):
        * platform/graphics/filters/FilterEffect.h:
        * platform/graphics/filters/SourceAlpha.cpp:
        (WebCore::SourceAlpha::externalRepresentation):
        * platform/graphics/filters/SourceAlpha.h:
        * platform/graphics/filters/SourceGraphic.cpp:
        (WebCore::SourceGraphic::externalRepresentation):
        * platform/graphics/filters/SourceGraphic.h:
        * rendering/RenderTreeAsText.cpp:
        (WebCore::writeIndent):
        * rendering/RenderTreeAsText.h:
        * rendering/SVGRenderTreeAsText.cpp:
        (WebCore::writeSVGResourceContainer):
        * svg/graphics/filters/SVGFEConvolveMatrix.cpp:
        (WebCore::operator<<):
        (WebCore::FEConvolveMatrix::externalRepresentation):
        * svg/graphics/filters/SVGFEConvolveMatrix.h:
        * svg/graphics/filters/SVGFEDiffuseLighting.cpp:
        (WebCore::FEDiffuseLighting::externalRepresentation):
        * svg/graphics/filters/SVGFEDiffuseLighting.h:
        * svg/graphics/filters/SVGFEDisplacementMap.cpp:
        (WebCore::operator<<):
        (WebCore::FEDisplacementMap::externalRepresentation):
        * svg/graphics/filters/SVGFEDisplacementMap.h:
        * svg/graphics/filters/SVGFEFlood.cpp:
        (WebCore::FEFlood::externalRepresentation):
        * svg/graphics/filters/SVGFEFlood.h:
        * svg/graphics/filters/SVGFEImage.cpp:
        (WebCore::FEImage::externalRepresentation):
        * svg/graphics/filters/SVGFEImage.h:
        * svg/graphics/filters/SVGFEMerge.cpp:
        (WebCore::FEMerge::externalRepresentation):
        * svg/graphics/filters/SVGFEMerge.h:
        * svg/graphics/filters/SVGFEMorphology.cpp:
        (WebCore::operator<<):
        (WebCore::FEMorphology::externalRepresentation):
        * svg/graphics/filters/SVGFEMorphology.h:
        * svg/graphics/filters/SVGFEOffset.cpp:
        (WebCore::FEOffset::externalRepresentation):
        * svg/graphics/filters/SVGFEOffset.h:
        * svg/graphics/filters/SVGFESpecularLighting.cpp:
        (WebCore::FESpecularLighting::externalRepresentation):
        * svg/graphics/filters/SVGFESpecularLighting.h:
        * svg/graphics/filters/SVGFETile.cpp:
        (WebCore::FETile::externalRepresentation):
        * svg/graphics/filters/SVGFETile.h:
        * svg/graphics/filters/SVGFETurbulence.cpp:
        (WebCore::operator<<):
        (WebCore::FETurbulence::externalRepresentation):
        * svg/graphics/filters/SVGFETurbulence.h:
2010-05-10  Dirk Schulze  <krit@webkit.org>

        Reviewed by Darin Adler.

        SVG FilterEffects need more detailed DRT information
        https://bugs.webkit.org/show_bug.cgi?id=38683

        All SVG Filter effects get dumped now. The structure of the DRT output
        changed. The last effect is shown first, followed by the previous effects.

        * platform/mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
        * platform/mac/svg/batik/filters/feTile-expected.txt:
        * platform/mac/svg/batik/filters/filterRegions-expected.txt:
        * platform/mac/svg/batik/text/textEffect-expected.txt:
        * platform/mac/svg/batik/text/textEffect3-expected.txt:
        * platform/mac/svg/batik/text/textFeatures-expected.txt:
        * platform/mac/svg/batik/text/textProperties-expected.txt:
        * platform/mac/svg/custom/empty-merge-expected.txt:
        * platform/mac/svg/custom/feComponentTransfer-Discrete-expected.txt:
        * platform/mac/svg/custom/feComponentTransfer-Gamma-expected.txt:
        * platform/mac/svg/custom/feComponentTransfer-Linear-expected.txt:
        * platform/mac/svg/custom/feComponentTransfer-Table-expected.txt:
        * platform/mac/svg/custom/feDisplacementMap-01-expected.txt:
        * platform/mac/svg/custom/image-with-transform-clip-filter-expected.txt:
        * platform/mac/svg/custom/invalid-css-expected.txt:
        * platform/mac/svg/custom/non-opaque-filters-expected.txt:
        * platform/mac/svg/custom/resource-invalidate-on-target-update-expected.txt:
        * platform/mac/svg/custom/text-filter-expected.txt:
        * platform/mac/svg/custom/visibility-override-filter-expected.txt:
        * platform/mac/svg/filters/big-sized-filter-2-expected.txt:
        * platform/mac/svg/filters/big-sized-filter-expected.txt:
        * platform/mac/svg/filters/feColorMatrix-values-expected.txt:
        * platform/mac/svg/filters/feComposite-expected.txt:
        * platform/mac/svg/filters/feDisplacementMap-expected.txt:
        * platform/mac/svg/filters/feGaussianBlur-expected.txt:
        * platform/mac/svg/filters/feMerge-expected.txt:
        * platform/mac/svg/filters/feOffset-expected.txt:
        * platform/mac/svg/filters/feTile-expected.txt:
        * platform/mac/svg/filters/filter-clip-expected.txt:
        * platform/mac/svg/filters/filter-on-tspan-expected.txt:
        * platform/mac/svg/filters/filter-source-position-expected.txt:
        * platform/mac/svg/filters/filterRes-expected.txt:
        * platform/mac/svg/filters/shadow-on-filter-expected.txt:
        * platform/mac/svg/filters/shadow-on-rect-with-filter-expected.txt:
        * platform/mac/svg/filters/sourceAlpha-expected.txt:
        * platform/mac/svg/filters/subRegion-in-userSpace-expected.txt:
        * platform/mac/svg/filters/subRegion-one-effect-expected.txt:
        * platform/mac/svg/filters/subRegion-two-effects-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Mon, 10 May 2010 09:53:53 +0000 (09:53 +0000)]
2010-05-10  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Nate Chapin.

        Change IndexedDB to use events instead of callbacks
        https://bugs.webkit.org/show_bug.cgi?id=38594

        Switch IndexedDB over to an event based model to match what
        Mozilla (and probably MS?) are doing.  This also gets rid of
        a lot of template mess at the expense of a little extra boiler
        plate code (for each type that IDBResult.result could be).

        This change also introduces JSC bindings that match the level of
        functionality the V8 bindings have.

        Still not testable, but that shoudl change shortly.

        * DerivedSources.cpp:
        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pri:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSEventCustom.cpp:
        * bindings/js/JSIDBRequestCustom.cpp: Added.
        (WebCore::JSIDBRequest::result):
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
        * bindings/v8/custom/V8CustomIDBCallbacks.h: Removed.
        * bindings/v8/custom/V8IDBRequestCustom.cpp: Added.
        (WebCore::V8IDBRequest::resultAccessorGetter):
        * bindings/v8/custom/V8IndexedDatabaseRequestCustom.cpp: Removed.
        * dom/EventTarget.cpp:
        (WebCore::EventTarget::toIDBRequest):
        * dom/EventTarget.h:
        * storage/IDBCallbacks.h:
        * storage/IDBDatabaseRequest.h:
        (WebCore::IDBDatabaseRequest::createObjectStore):
        * storage/IDBRequest.cpp: Added.
        (WebCore::IDBRequest::IDBRequest):
        (WebCore::IDBRequest::~IDBRequest):
        (WebCore::IDBRequest::idbDatabaseResult):
        (WebCore::IDBRequest::serializedScriptValueResult):
        (WebCore::IDBRequest::onError):
        (WebCore::IDBRequest::onSuccess):
        (WebCore::IDBRequest::abort):
        (WebCore::IDBRequest::scriptExecutionContext):
        (WebCore::IDBRequest::stop):
        (WebCore::IDBRequest::suspend):
        (WebCore::IDBRequest::resume):
        (WebCore::IDBRequest::eventTargetData):
        (WebCore::IDBRequest::ensureEventTargetData):
        (WebCore::IDBRequest::timerFired):
        (WebCore::IDBRequest::onEventCommon):
        * storage/IDBRequest.h: Added.
        (WebCore::IDBRequest::create):
        (WebCore::IDBRequest::):
        (WebCore::IDBRequest::resultType):
        (WebCore::IDBRequest::readyState):
        (WebCore::IDBRequest::error):
        (WebCore::IDBRequest::toIDBRequest):
        (WebCore::IDBRequest::refEventTarget):
        (WebCore::IDBRequest::derefEventTarget):
        * storage/IDBRequest.idl: Added.
        * storage/IndexedDatabase.h:
        * storage/IndexedDatabaseImpl.cpp:
        (WebCore::IndexedDatabaseImpl::open):
        * storage/IndexedDatabaseImpl.h:
        * storage/IndexedDatabaseRequest.cpp:
        (WebCore::IndexedDatabaseRequest::open):
        * storage/IndexedDatabaseRequest.h:
        * storage/IndexedDatabaseRequest.idl:
2010-05-10  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Nate Chapin.

        Change IndexedDB to use events instead of callbacks
        https://bugs.webkit.org/show_bug.cgi?id=38594

        Change the glue here to match the changes I made in WebCore.

        * WebKit.gyp:
        * public/WebIDBCallbacks.h:
        * public/WebIndexedDatabase.h:
        * src/IDBCallbacksProxy.cpp: Added.
        (WebCore::IDBCallbacksProxy::IDBCallbacksProxy):
        (WebCore::IDBCallbacksProxy::~IDBCallbacksProxy):
        (WebCore::IDBCallbacksProxy::onError):
        (WebCore::IDBCallbacksProxy::onSuccess):
        * src/IDBCallbacksProxy.h:
        * src/IndexedDatabaseProxy.cpp:
        (WebCore::IndexedDatabaseProxy::open):
        * src/IndexedDatabaseProxy.h:
        * src/WebIndexedDatabaseImpl.cpp:
        (WebKit::WebIndexedDatabaseImpl::open):
        * src/WebIndexedDatabaseImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-09 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Mon, 10 May 2010 07:02:34 +0000 (07:02 +0000)]
2010-05-09  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Eric Seidel.

        JavaScriptCore/wtf/MD5.h: checksum should take a reference to output.
        https://bugs.webkit.org/show_bug.cgi?id=38723

        * JavaScriptCore.exp:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        * wtf/MD5.cpp:
        (WTF::expectMD5):
          Fix for checksum change.
        (WTF::MD5::checksum):
          Take a reference to output, instead of returning the result by value, to reduce coping for performance.
        * wtf/MD5.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, test expectation update.
tkent@chromium.org [Mon, 10 May 2010 05:07:50 +0000 (05:07 +0000)]
Unreviewed, test expectation update.

Update Chromium/Linux expectation for fast/forms/input-file-re-render.html.
http://crbug.com/40027

* platform/chromium-linux/fast/forms/input-file-re-render-expected.checksum:
* platform/chromium-linux/fast/forms/input-file-re-render-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix accidental repeat addition of emit_op_new_regexp
oliver@apple.com [Mon, 10 May 2010 02:17:55 +0000 (02:17 +0000)]
Fix accidental repeat addition of emit_op_new_regexp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-09 Geoffrey Garen <ggaren@apple.com>
oliver@apple.com [Mon, 10 May 2010 01:41:07 +0000 (01:41 +0000)]
2010-05-09  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Reserve a large-ish initial capacity for Lexer::m_buffer16.

        SunSpider says 0.3% faster.

        m_buffer16 is used when parsing complex strings -- for example, strings
        with escape sequences in them. These kinds of strings can be really long,
        and we want to avoid repeatedly copying as we grow m_buffer16.

        The net memory cost is quite low, since it's proporitional to source
        code we already have in memory, and we throw away m_buffer16 right when
        we're done parsing.

        * parser/Lexer.cpp:
        (JSC::Lexer::Lexer): No need to reserve initial capacity in our constructor,
        since setCode will be called before we're asked to lex anything.
        (JSC::Lexer::setCode): Reserve enough space to lex half the source code
        as a complex string without having to copy.
        (JSC::Lexer::clear): No need to reserve initial capacity here either,
        since setCode will be called before we're asked to lex anything.
2010-05-09  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        REGRESSION(r57955): RegExp literals should not actually be cached, so r57955 should be rolled out.
        https://bugs.webkit.org/show_bug.cgi?id=38828

        Replace incorrect test for caching regexp literals with ones that tests that they are not cached.

        * fast/js/regexp-literals-are-constants-expected.txt: Removed.
        * fast/js/regexp-literals-are-constants.html: Removed.
        * fast/js/regexp-literals-arent-constants-expected.txt: Added.
        * fast/js/regexp-literals-arent-constants.html: Added.
        * fast/js/script-tests/regexp-literals-are-constants.js: Removed.
        * fast/js/script-tests/regexp-literals-arent-constants.js: Added.
        (test1):
        (returnRegExpLiteral):
        (returnConditionalRegExpLiteral):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Sun, 9 May 2010 22:09:43 +0000 (22:09 +0000)]
2010-05-10  Ilya Tikhonovsky  <loislo@chromium.org>

        Not reviewed: rollback the commit r59062

        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
        (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
        (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
        * inspector/front-end/inspector.js:
        (WebInspector.linkifyURLAsNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Sun, 9 May 2010 21:38:18 +0000 (21:38 +0000)]
2010-05-10  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        WebInspector: Cosmetic changes.
        1) Inner Function Call event of Timer Fire should be merged into parent even if it is not the only child.
        2) Standard tooltips for resource links are clashing with Popover.
        3) Recalculate Style caller info are duplicating in Details Popover (Caller and Details rows).
        https://bugs.webkit.org/show_bug.cgi?id=38732

        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
        (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
        (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
        * inspector/front-end/inspector.js:
        (WebInspector.linkifyURLAsNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoReserve a large-ish initial capacity for Lexer::m_buffer16.
ggaren@apple.com [Sun, 9 May 2010 21:16:16 +0000 (21:16 +0000)]
Reserve a large-ish initial capacity for Lexer::m_buffer16.

Reviewed by Oliver Hunt.

SunSpider says 0.3% faster.

m_buffer16 is used when parsing complex strings -- for example, strings
with escape sequences in them. These kinds of strings can be really long,
and we want to avoid repeatedly copying as we grow m_buffer16.

The net memory cost is quite low, since it's proporitional to source
code we already have in memory, and we throw away m_buffer16 right when
we're done parsing.

* parser/Lexer.cpp:
(JSC::Lexer::Lexer): No need to reserve initial capacity in our constructor,
since setCode will be called before we're asked to lex anything.
(JSC::Lexer::setCode): Reserve enough space to lex half the source code
as a complex string without having to copy.
(JSC::Lexer::clear): No need to reserve initial capacity here either,
since setCode will be called before we're asked to lex anything.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-09 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Sun, 9 May 2010 21:11:50 +0000 (21:11 +0000)]
2010-05-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Eric Seidel.

        [Qt] Remove YARR configuration rules from Qt make system
        https://bugs.webkit.org/show_bug.cgi?id=38819

        Setting YARR based on JIT seeting is now in Platform.h
        for all ports. This patch essentially reverses r49238.

        * JavaScriptCore.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-08 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Sun, 9 May 2010 20:58:42 +0000 (20:58 +0000)]
2010-05-08  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        WebInspector: If some record is not in visible area then it's expand element also is not
        visible even if it has children in visible area.
        https://bugs.webkit.org/show_bug.cgi?id=38643

        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel):
        (WebInspector.TimelinePanel.prototype._refreshRecords):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=38557
weinig@apple.com [Sun, 9 May 2010 20:34:20 +0000 (20:34 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=38557
r58526 introduced a ~30% regression on Dromaeo JS lib

Reviewed by Darin Adler.

This fix does two things.
- Don't use QualifiedName as the key to a HashMap, use a
  RefPtr<QualifiedNameImpl> instead.  We should remove the HashTraits for
  QualifiedName and that will happen in a follow up patch.
- Only mark cached NodeLists on Documents instead of all Nodes. This is
  okay since the marking of NodeLists is an optimization to keep NodeList
  wrappers alive and is not mandated by any spec.

* bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::markChildren):
* bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::markChildren):
* dom/Node.cpp:
(WebCore::Node::removeCachedTagNodeList):
(WebCore::Node::getElementsByTagNameNS):
* dom/NodeRareData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-09 Noam Rosenthal <noam.rosenthal@nokia.com>
eric@webkit.org [Sun, 9 May 2010 16:37:25 +0000 (16:37 +0000)]
2010-05-09  Noam Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Crash in QGraphicsWebViewPrivate::~QGraphicsWebViewPrivate when animation were used
        https://bugs.webkit.org/show_bug.cgi?id=38574

        The fix uses a QWeakPointer for rootGraphicsLayer, protecting from a crash in case the layer is deleted before the QGraphicsWebView.

        * Api/qgraphicswebview.cpp:
        (QGraphicsWebViewPrivate::QGraphicsWebViewPrivate):
        (QGraphicsWebViewPrivate::~QGraphicsWebViewPrivate):
        (QGraphicsWebViewPrivate::setRootGraphicsLayer):
        (QGraphicsWebViewPrivate::updateCompositingScrollPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-09 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Sun, 9 May 2010 11:42:22 +0000 (11:42 +0000)]
2010-05-09  Oliver Hunt  <oliver@apple.com>

        Reviewed by Maciej Stachowiak.

        Improve string indexing performance
        https://bugs.webkit.org/show_bug.cgi?id=38814

        Add an assembly stub to do indexed loads from strings much
        more cheaply than the current stub dispatch logic.  We can
        do this because we are able to make guarantees about the
        register contents when entering the stub so the call overhead
        is negligible.

        * jit/JIT.h:
        * jit/JITInlineMethods.h:
        * jit/JITOpcodes.cpp:
        * jit/JITPropertyAccess.cpp:
        (JSC::JIT::stringGetByValStubGenerator):
        (JSC::JIT::emitSlow_op_get_by_val):
           Moved from JITOpcodes.cpp to keep the slowcase next to
           the normal case codegen as we do for everything else.
        * jit/JITPropertyAccess32_64.cpp:
        (JSC::JIT::stringGetByValStubGenerator):
        (JSC::JIT::emitSlow_op_get_by_val):
        * jit/JSInterfaceJIT.h:
        (JSC::JSInterfaceJIT::emitFastArithImmToInt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-09 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Sun, 9 May 2010 11:18:25 +0000 (11:18 +0000)]
2010-05-09  Maciej Stachowiak  <mjs@apple.com>

        Fixed version of: "Optimized o[s] where o is a cell and s is a string"
        https://bugs.webkit.org/show_bug.cgi?id=38815

        Fixed the previous patch for this from Geoff Garen.

        The two problems were a missing exception check and a PropertySlot
        initialized improperly, leading to crashes and failures in the case
        of getters accessed with bracket syntax.

    Previous patch:

        Optimized o[s] where o is a cell and s is a string, removing some old
        code that wasn't really tuned for the JIT.

        SunSpider says 0.8% faster.

        * jit/JITStubs.cpp:
        (JSC::DEFINE_STUB_FUNCTION):
        * runtime/JSCell.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-09 Robert Hogan <robert@webkit.org>
robert@webkit.org [Sun, 9 May 2010 10:24:58 +0000 (10:24 +0000)]
2010-05-09  Robert Hogan  <robert@webkit.org>

        [Qt] Update expected results for unskipped editing/inserting tests

        Unreviewed, remove platform-specific results for editing/inserting/6633727.html

        https://bugs.webkit.org/show_bug.cgi?id=38472

        * platform/qt/editing/inserting/6633727-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Update expected results for unskipped editing/inserting tests
robert@webkit.org [Sun, 9 May 2010 10:15:16 +0000 (10:15 +0000)]
[Qt] Update expected results for unskipped editing/inserting tests

Unreviewed, add expected results for unskipped tests. Results are taken
from Qt bot.

https://bugs.webkit.org/show_bug.cgi?id=38472

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Unskip editing/inserting tests that fail due to x/y differences
robert@webkit.org [Sun, 9 May 2010 09:52:31 +0000 (09:52 +0000)]
[Qt] Unskip editing/inserting tests that fail due to x/y differences

2010-05-03  Robert Hogan  <robert@webkit.org>

        Reviewed by Eric Seidel.

        [Qt] Unskip editing/inserting tests that fail due to x/y differences

        https://bugs.webkit.org/show_bug.cgi?id=38472

        Unskip the following tests:

        editing/inserting/12882.html
        editing/inserting/4840662.html
        editing/inserting/4875189-1.html
        editing/inserting/4959067.html
        editing/inserting/4960120-2.html
        editing/inserting/5002441.html
        editing/inserting/5058163-2.html
        editing/inserting/5156401-2.html
        editing/inserting/5418891.html
        editing/inserting/5510537.html
        editing/inserting/5549929-2.html
        editing/inserting/5549929-3.html
        editing/inserting/6633727.html
        editing/inserting/6703873.html
        editing/inserting/editable-inline-element.html
        editing/inserting/insert-3654864-fix.html
        editing/inserting/insert-3659587-fix.html
        editing/inserting/insert-3775316-fix.html
        editing/inserting/insert-3778059-fix.html
        editing/inserting/insert-3786362-fix.html
        editing/inserting/insert-3800346-fix.html
        editing/inserting/insert-3851164-fix.html
        editing/inserting/insert-3907422-fix.html
        editing/inserting/insert-after-delete-001.html
        editing/inserting/insert-at-end-01.html
        editing/inserting/insert-at-end-02.html
        editing/inserting/insert-before-link-1.html
        editing/inserting/insert-br-001.html
        editing/inserting/insert-br-002.html
        editing/inserting/insert-br-003.html
        editing/inserting/insert-br-004.html
        editing/inserting/insert-br-005.html
        editing/inserting/insert-br-006.html
        editing/inserting/insert-br-007.html
        editing/inserting/insert-br-008.html
        editing/inserting/insert-br-009.html
        editing/inserting/insert-br-at-tabspan-001.html
        editing/inserting/insert-br-at-tabspan-002.html
        editing/inserting/insert-br-at-tabspan-003.html
        editing/inserting/insert-br-quoted-001.html
        editing/inserting/insert-br-quoted-002.html
        editing/inserting/insert-br-quoted-003.html
        editing/inserting/insert-br-quoted-004.html
        editing/inserting/insert-br-quoted-005.html
        editing/inserting/insert-br-quoted-006.html
        editing/inserting/insert-div-001.html
        editing/inserting/insert-div-002.html
        editing/inserting/insert-div-003.html
        editing/inserting/insert-div-004.html
        editing/inserting/insert-div-005.html
        editing/inserting/insert-div-006.html
        editing/inserting/insert-div-007.html
        editing/inserting/insert-div-008.html
        editing/inserting/insert-div-009.html
        editing/inserting/insert-div-010.html
        editing/inserting/insert-div-011.html
        editing/inserting/insert-div-012.html
        editing/inserting/insert-div-013.html
        editing/inserting/insert-div-014.html
        editing/inserting/insert-div-015.html
        editing/inserting/insert-div-016.html
        editing/inserting/insert-div-017.html
        editing/inserting/insert-div-018.html
        editing/inserting/insert-div-019.html
        editing/inserting/insert-div-020.html
        editing/inserting/insert-div-021.html
        editing/inserting/insert-div-022.html
        editing/inserting/insert-div-024.html
        editing/inserting/insert-div-025.html
        editing/inserting/insert-div-026.html
        editing/inserting/insert-div-027.html
        editing/inserting/insert-paragraph-01.html
        editing/inserting/insert-paragraph-02.html
        editing/inserting/insert-paragraph-03.html
        editing/inserting/insert-paragraph-04.html
        editing/inserting/insert-paragraph-05.html
        editing/inserting/insert-space-in-empty-doc.html
        editing/inserting/insert-tab-001.html
        editing/inserting/insert-tab-002.html
        editing/inserting/insert-tab-004.html
        editing/inserting/insert-text-at-tabspan-001.html
        editing/inserting/insert-text-at-tabspan-002.html
        editing/inserting/insert-text-at-tabspan-003.html
        editing/inserting/line-break.html
        editing/inserting/paragraph-separator-01.html
        editing/inserting/paragraph-separator-02.html
        editing/inserting/paragraph-separator-in-table-1.html
        editing/inserting/paragraph-separator-in-table-2.html
        editing/inserting/redo.html
        editing/inserting/return-key-with-selection-003.html
        editing/inserting/typing-001.html
        editing/inserting/typing-002.html
        editing/inserting/typing-003.html
        editing/inserting/typing-around-br-001.html
        editing/inserting/typing-around-image-001.html

        editing/inserting/5058163-1.html
        editing/inserting/edited-whitespace-1.html
        editing/inserting/paragraph-separator-03.html
        editing/inserting/return-key-with-selection-001.html
        editing/inserting/return-key-with-selection-002.html
        editing/inserting/4875189-2.html

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-09 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Sun, 9 May 2010 09:50:32 +0000 (09:50 +0000)]
2010-05-09  Daniel Bates  <dbates@rim.com>

        Reviewed by Chris Jerdonek.

        https://bugs.webkit.org/show_bug.cgi?id=38812

        Make the regular expressions for parsing the start of an SVN
        and Git header global variables since they are used throughout
        VCSUtils.pm.

        * Scripts/VCSUtils.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-07 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Sun, 9 May 2010 09:08:55 +0000 (09:08 +0000)]
2010-05-07  Daniel Bates  <dbates@rim.com>

         Unreviewed, change log fix.

         Add back some entries inadvertently deleted in changeset 59000
         <http://trac.webkit.org/changeset/59000> and not restored (as
         intended) in changeset 59005 <http://trac.webkit.org/changeset/59005>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd back some entries accidentally deleted in r59000 and not restored as intended...
mjs@apple.com [Sun, 9 May 2010 08:42:22 +0000 (08:42 +0000)]
Add back some entries accidentally deleted in r59000 and not restored as intended in r59005.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-09 Chris Jerdonek <cjerdonek@webkit.org>
cjerdonek@webkit.org [Sun, 9 May 2010 07:21:35 +0000 (07:21 +0000)]
2010-05-09  Chris Jerdonek  <cjerdonek@webkit.org>

        Reviewed by Daniel Bates.

        Finished moving the header-parsing logic from svn-apply and -unapply
        to VCSUtils.pm's parsing methods.

        https://bugs.webkit.org/show_bug.cgi?id=38802

        * Scripts/VCSUtils.pm:
          - Added to parseGitDiffHeader() the ability to parse and store
            whether a file is new or deleted.
          - Also reordered in parseGitDiffHeader() some of the else statements
            to a more readable ordering.
          - Added to parseSvnDiffHeader() the ability to parse and store
            whether a file is new.
        * Scripts/svn-apply:
          - Changed handleGitBinaryChange() to use the new "isNew" and "isDeletion"
            diffHash key-values.
          - Changed patch() to use the new "isNew" diffHash key-value.
        * Scripts/svn-unapply:
          - Changed patch() to use the new "isNew" and "isDeletion" diffHash key-values.
        * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
          - Added unit tests for new and deleted files.
        * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
          - Updated the unit tests as necessary.
          - Added a unit test for a deleted file.
        * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
          - Updated the unit tests as necessary.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-08 Chris Jerdonek <cjerdonek@webkit.org>
cjerdonek@webkit.org [Sun, 9 May 2010 06:50:36 +0000 (06:50 +0000)]
2010-05-08  Chris Jerdonek  <cjerdonek@webkit.org>

        Reviewed by Maciej Stachowiak.

        Allow long comment lines to wrap to the window width instead
        of to 80 characters.

        https://bugs.webkit.org/show_bug.cgi?id=37792

        * Bugzilla/Constants.pm:
          - Introduced a new constant COMMENT_COLS_WRAP to replace COMMENT_COLS
            inside the wrap_comment() subroutine.  The new constant effectively
            disables text wrapping by increasing the value used in wrap_comment()
            from 80 characters to a very large value (8000).
        * Bugzilla/Util.pm:
          - Replaced COMMENT_COLS with COMMENT_COLS_WRAP inside wrap_comment().
        * skins/custom/global.css:
        (.bz_comment_text):
          - Eliminate the width styling on comments to allow long lines
            to wrap at the window width.
        (.bz_comment_text > span.quote):
          - Inherit the "white-space" property.  This prevents long quoted
            lines in comments from causing non-quoted lines to extend beyond
            the window width.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-08 Antonio Gomes <tonikitoo@webkit.org>
tonikitoo@webkit.org [Sun, 9 May 2010 03:21:00 +0000 (03:21 +0000)]
2010-05-08  Antonio Gomes  <tonikitoo@webkit.org>

        Unreviewed attempt to fix Windows build.

        * page/SpatialNavigation.h:
        (WebCore::fudgeFactor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSpatial Navigation: create a getter for the "fudgeFactor"
tonikitoo@webkit.org [Sun, 9 May 2010 03:05:46 +0000 (03:05 +0000)]
Spatial Navigation: create a getter for the "fudgeFactor"
https://bugs.webkit.org/show_bug.cgi?id=38488

Reviewed by Kenneth Christiansen.
Patch by Antonio Gomes <tonikitoo@webkit.org>

A couple of places in the Spatial Navigation code make use of a "fudge factor"
to improve precision by working around outline focus metrics and such. Patch adds
a helper method for unify getter operations of this value, instead of having it
declared locally in the various methods it is used.

No behaviour change.

* page/SpatialNavigation.cpp:
(WebCore::scrollIntoView):
(WebCore::deflateIfOverlapped):
* page/SpatialNavigation.h:
(WebCore::fudgeFactor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdded to svn-apply support for git renames and copies with similarity
cjerdonek@webkit.org [Sun, 9 May 2010 02:52:26 +0000 (02:52 +0000)]
Added to svn-apply support for git renames and copies with similarity
index less than 100%.

Reviewed by Daniel Bates.

https://bugs.webkit.org/show_bug.cgi?id=32834

* Scripts/VCSUtils.pm:
  - Added to parseGitDiffHeader() support for renames and similarity
    index less than 100%.
  - Added to parseDiff() support for processing renames, renames with
    changes, and copies with changes.
  - Added to parsePatch() the ability to process multiple return
    values from parseDiff().
* Scripts/svn-apply:
  - Added to patch() the ability to process diff hashes with the
    isDeletion key-value set.
* Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
  - Updated the unit tests as necessary.
  - Added unit tests for rename with similarity index 100%,
    rename with similarity index < 100%, and rename with a change
    to the executable bit.
* Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
  - Added unit tests for rename with similarity index 100%,
    rename with similarity index < 100%, and rename with a change
    to the executable bit.
* Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl:
  - Updated the unit tests as necessary.
* Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
  - Simplified the carriage-return unit test to more narrowly test
    only carriage returns.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoThis revision suppresses the misleading "error: pathspec..." messages
cjerdonek@webkit.org [Sun, 9 May 2010 02:37:10 +0000 (02:37 +0000)]
This revision suppresses the misleading "error: pathspec..." messages
when using svn-apply to add a binary file from a Git diff.

Reviewed by Daniel Bates.

https://bugs.webkit.org/show_bug.cgi?id=38047

When adding a new binary file from a Git diff, svn-apply prints
a misleading error of the form -- "error: pathspec '<filename>' did
not match any file(s) known to git.  Did you forget to 'git add'?"
This patch suppresses these messages since they are normal.

* Scripts/VCSUtils.pm:
  Added the callSilently() subroutine from runPatchCommand.pl, which
  executes a Perl function while suppressing STDERR.
* Scripts/svn-apply:
  Refactored the Git portion of scmKnowsOfFile() into a
  gitKnowsOfFile(), and called this new subroutine using callSilently().
* Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl:
  Removed callSilently() since it was moved to VCSUtils.pm in this patch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-08 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Sun, 9 May 2010 02:02:24 +0000 (02:02 +0000)]
2010-05-08  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Unreviewed, build fix.

        Fix missing terminating ' character warning

        The warning has been only seen on the Gtk buildbots.

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-08 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Sun, 9 May 2010 00:38:43 +0000 (00:38 +0000)]
2010-05-08  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Gavin Barraclough.

        Refactor YARR and YARR_JIT default rules in Platform.h
        https://bugs.webkit.org/show_bug.cgi?id=38727

        Turn on YARR and YARR JIT by default of JIT is enabled.
        Ports can overrule this default decisions as they wish.

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-08 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Sat, 8 May 2010 22:59:03 +0000 (22:59 +0000)]
2010-05-08  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Split JSVALUE32_64 code out of JITOpcodes.cpp and into JITOpcodes32_64.cpp
        https://bugs.webkit.org/show_bug.cgi?id=38808

        * GNUmakefile.am:
        * JavaScriptCore.gypi:
        * JavaScriptCore.pro:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * jit/JITOpcodes.cpp:
        * jit/JITOpcodes32_64.cpp: Added.
        (JSC::JIT::privateCompileCTIMachineTrampolines):
        (JSC::JIT::emit_op_mov):
        (JSC::JIT::emit_op_end):
        (JSC::JIT::emit_op_jmp):
        (JSC::JIT::emit_op_loop_if_lesseq):
        (JSC::JIT::emitSlow_op_loop_if_lesseq):
        (JSC::JIT::emit_op_new_object):
        (JSC::JIT::emit_op_instanceof):
        (JSC::JIT::emitSlow_op_instanceof):
        (JSC::JIT::emit_op_new_func):
        (JSC::JIT::emit_op_get_global_var):
        (JSC::JIT::emit_op_put_global_var):
        (JSC::JIT::emit_op_get_scoped_var):
        (JSC::JIT::emit_op_put_scoped_var):
        (JSC::JIT::emit_op_tear_off_activation):
        (JSC::JIT::emit_op_tear_off_arguments):
        (JSC::JIT::emit_op_new_array):
        (JSC::JIT::emit_op_resolve):
        (JSC::JIT::emit_op_to_primitive):
        (JSC::JIT::emitSlow_op_to_primitive):
        (JSC::JIT::emit_op_strcat):
        (JSC::JIT::emit_op_resolve_base):
        (JSC::JIT::emit_op_resolve_skip):
        (JSC::JIT::emit_op_resolve_global):
        (JSC::JIT::emitSlow_op_resolve_global):
        (JSC::JIT::emit_op_not):
        (JSC::JIT::emitSlow_op_not):
        (JSC::JIT::emit_op_jfalse):
        (JSC::JIT::emitSlow_op_jfalse):
        (JSC::JIT::emit_op_jtrue):
        (JSC::JIT::emitSlow_op_jtrue):
        (JSC::JIT::emit_op_jeq_null):
        (JSC::JIT::emit_op_jneq_null):
        (JSC::JIT::emit_op_jneq_ptr):
        (JSC::JIT::emit_op_jsr):
        (JSC::JIT::emit_op_sret):
        (JSC::JIT::emit_op_eq):
        (JSC::JIT::emitSlow_op_eq):
        (JSC::JIT::emit_op_neq):
        (JSC::JIT::emitSlow_op_neq):
        (JSC::JIT::compileOpStrictEq):
        (JSC::JIT::emit_op_stricteq):
        (JSC::JIT::emitSlow_op_stricteq):
        (JSC::JIT::emit_op_nstricteq):
        (JSC::JIT::emitSlow_op_nstricteq):
        (JSC::JIT::emit_op_eq_null):
        (JSC::JIT::emit_op_neq_null):
        (JSC::JIT::emit_op_resolve_with_base):
        (JSC::JIT::emit_op_new_func_exp):
        (JSC::JIT::emit_op_throw):
        (JSC::JIT::emit_op_get_pnames):
        (JSC::JIT::emit_op_next_pname):
        (JSC::JIT::emit_op_push_scope):
        (JSC::JIT::emit_op_pop_scope):
        (JSC::JIT::emit_op_to_jsnumber):
        (JSC::JIT::emitSlow_op_to_jsnumber):
        (JSC::JIT::emit_op_push_new_scope):
        (JSC::JIT::emit_op_catch):
        (JSC::JIT::emit_op_jmp_scopes):
        (JSC::JIT::emit_op_switch_imm):
        (JSC::JIT::emit_op_switch_char):
        (JSC::JIT::emit_op_switch_string):
        (JSC::JIT::emit_op_new_error):
        (JSC::JIT::emit_op_debug):
        (JSC::JIT::emit_op_enter):
        (JSC::JIT::emit_op_enter_with_activation):
        (JSC::JIT::emit_op_create_arguments):
        (JSC::JIT::emit_op_init_arguments):
        (JSC::JIT::emit_op_convert_this):
        (JSC::JIT::emitSlow_op_convert_this):
        (JSC::JIT::emit_op_profile_will_call):
        (JSC::JIT::emit_op_profile_did_call):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-08 Stuart Morgan <stuartmorgan@chromium.org>
eric@webkit.org [Sat, 8 May 2010 20:47:38 +0000 (20:47 +0000)]
2010-05-08  Stuart Morgan  <stuartmorgan@chromium.org>

        Reviewed by Darin Adler.

        Change the npapi.h header guards to match the npapi-headers repository
        copy.

        https://bugs.webkit.org/show_bug.cgi?id=38666

        * bridge/npapi.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-08 Gabor Loki <loki@webkit.org>
eric@webkit.org [Sat, 8 May 2010 20:03:31 +0000 (20:03 +0000)]
2010-05-08  Gabor Loki  <loki@webkit.org>

        Reviewed by Gavin Barraclough.

        Fix halfword loads on ARM
        https://bugs.webkit.org/show_bug.cgi?id=38741

        The BaseIndex and ImplicitAddress are contain 32bit wide offset, but
        the load16 functions were working with 8 bit data (encoded in the
        instruction). If the offset cannot be encoded in an instruction, it
        should be stored in a temporary register.

        * assembler/ARMAssembler.h:
        (JSC::ARMAssembler::getOffsetForHalfwordDataTransfer):
        * assembler/MacroAssemblerARM.h:
        (JSC::MacroAssemblerARM::load16):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-08 Gabor Loki <loki@webkit.org>
eric@webkit.org [Sat, 8 May 2010 19:51:23 +0000 (19:51 +0000)]
2010-05-08  Gabor Loki  <loki@webkit.org>

        Reviewed by Gavin Barraclough.

        Fix spanning branch instruction on Cortex-A8 with Thumb-2 JIT
        https://bugs.webkit.org/show_bug.cgi?id=38280

        If the 32-bit Thumb-2 branch instruction spans two 4KiB regions and
        the target of the branch falls within the first region it is
        possible for the processor to incorrectly determine the branch
        instruction, and it is also possible in some cases for the processor
        to enter a deadlock state.

        * assembler/ARMv7Assembler.h:
        (JSC::ARMv7Assembler::linkJumpAbsolute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-08 Victor Wang <victorw@chromium.org>
eric@webkit.org [Sat, 8 May 2010 19:36:42 +0000 (19:36 +0000)]
2010-05-08  Victor Wang  <victorw@chromium.org>

        Reviewed by Adam Barth.

        [chromium]: Upload test results json files to app engine server
        Add an option to run_webkit_tests.py to upload generated
        JSON files to app engine server. These JSON files will be used
        by chromium layout test falkiness dashboard.

        https://bugs.webkit.org/show_bug.cgi?id=36063

        * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py: Added.
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-08 Stuart Morgan <stuartmorgan@chromium.org>
eric@webkit.org [Sat, 8 May 2010 19:23:33 +0000 (19:23 +0000)]
2010-05-08  Stuart Morgan  <stuartmorgan@chromium.org>

        Reviewed by Darin Fisher.

        Resolve most of the whitespace/comment/order differences in npapi.h
        and npruntime.h relative to the npapi-headers repository versions.
        No changes to the substance of the code.

        https://bugs.webkit.org/show_bug.cgi?id=38666

        * bridge/npapi.h:
        (_NPPrint::):
        (_NPCocoaEvent::):
        * bridge/npruntime.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-08 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Sat, 8 May 2010 19:05:46 +0000 (19:05 +0000)]
2010-05-08  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Darin Adler.

        Fix guard around IndexedDatabase
        https://bugs.webkit.org/show_bug.cgi?id=38710

        No new tests, there is no new functionality.

        * page/PageGroup.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-08 Luiz Agostini <luiz.agostini@openbossa.org>
eric@webkit.org [Sat, 8 May 2010 18:51:48 +0000 (18:51 +0000)]
2010-05-08  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Simon Hausmann.

        [Qt] Platform plugin
        https://bugs.webkit.org/show_bug.cgi?id=38438

        Select popups delegate private API. To provide select popup delegates
        a plugin that implements QWebKitPlatformPlugin must be found
        in QCoreApplication::libraryPaths.

        * WebCore.pro:
2010-05-08  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Simon Hausmann.

        [Qt] Platform plugin
        https://bugs.webkit.org/show_bug.cgi?id=38438

        Select popups delegate private API. To provide select popup delegates
        a plugin that implements QWebKitPlatformPlugin must be found
        in QCoreApplication::libraryPaths.

        * Api/headers.pri:
        * Api/qwebkitplatformplugin.h: Added.
        (QWebSelectData::~QWebSelectData):
        (QWebSelectData::):
        (QWebSelectMethod::~QWebSelectMethod):
        (QWebKitPlatformPlugin::~QWebKitPlatformPlugin):
        (QWebKitPlatformPlugin::):
        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::createSelectPopup):
        * WebCoreSupport/ChromeClientQt.h:
        * WebCoreSupport/QtPlatformPlugin.cpp: Added.
        (WebCore::SelectData::SelectData):
        (WebCore::SelectData::itemText):
        (WebCore::SelectData::itemToolTip):
        (WebCore::SelectData::itemIsEnabled):
        (WebCore::SelectData::itemCount):
        (WebCore::SelectData::itemIsSelected):
        (WebCore::SelectData::multiple):
        (WebCore::SelectData::itemType):
        (WebCore::SelectInputMethodWrapper::SelectInputMethodWrapper):
        (WebCore::SelectInputMethodWrapper::show):
        (WebCore::SelectInputMethodWrapper::hide):
        (WebCore::SelectInputMethodWrapper::selectItem):
        (WebCore::SelectInputMethodWrapper::didHide):
        (WebCore::getPluginObject):
        (WebCore::QtPlatformPlugin::~QtPlatformPlugin):
        (WebCore::QtPlatformPlugin::plugin):
        (WebCore::QtPlatformPlugin::createSelectInputMethod):
        * WebCoreSupport/QtPlatformPlugin.h: Added.
        (WebCore::QtPlatformPlugin::QtPlatformPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-08 Leandro Pereira <leandro@profusion.mobi>
eric@webkit.org [Sat, 8 May 2010 18:40:06 +0000 (18:40 +0000)]
2010-05-08  Leandro Pereira  <leandro@profusion.mobi>

        Reviewed by Laszlo Gombos.

        [EFL] Only compile database stuff if ENABLE_DATABASE is set.
        http://webkit.org/b/38777

        * efl/WebCoreSupport/ChromeClientEfl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-08 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Sat, 8 May 2010 18:29:02 +0000 (18:29 +0000)]
2010-05-08  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Build the ImageDiff tool for all platforms including Windows and Symbian
        https://bugs.webkit.org/show_bug.cgi?id=38706

        * WebKit.pro:
2010-05-08  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Build the ImageDiff tool for all platforms including Windows and Symbian
        https://bugs.webkit.org/show_bug.cgi?id=38706

        Use qmath.h instead of math.h to make it portable.

        * DumpRenderTree/qt/ImageDiff.cpp:
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-08 Leandro Pereira <leandro@profusion.mobi>
eric@webkit.org [Sat, 8 May 2010 18:17:57 +0000 (18:17 +0000)]
2010-05-08  Leandro Pereira  <leandro@profusion.mobi>

        Reviewed by Gustavo Noronha Silva.

        [EFL] It does not make sense to use RenderThemeEfl::RenderThemeEfl, so
        use RenderThemeEfl (GCC 4.5 seems to be pickier about this).
        http://webkit.org/b/38770

        * platform/efl/RenderThemeEfl.cpp:
        (WebCore::renderThemeEflColorClassSelectionActive):
        (WebCore::renderThemeEflColorClassSelectionInactive):
        (WebCore::renderThemeEflColorClassFocusRing):
        (WebCore::renderThemeEflColorClassButtonText):
        (WebCore::renderThemeEflColorClassComboText):
        (WebCore::renderThemeEflColorClassEntryText):
        (WebCore::renderThemeEflColorClassSearchText):
        (WebCore::RenderThemeEfl::adjustCheckboxStyle):
        (WebCore::RenderThemeEfl::adjustRadioStyle):
        (WebCore::RenderThemeEfl::adjustButtonStyle):
        (WebCore::RenderThemeEfl::adjustMenuListStyle):
        (WebCore::RenderThemeEfl::adjustTextFieldStyle):
        (WebCore::RenderThemeEfl::adjustSearchFieldDecorationStyle):
        (WebCore::RenderThemeEfl::adjustSearchFieldResultsButtonStyle):
        (WebCore::RenderThemeEfl::adjustSearchFieldResultsDecorationStyle):
        (WebCore::RenderThemeEfl::adjustSearchFieldCancelButtonStyle):
        (WebCore::RenderThemeEfl::adjustSearchFieldStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-08 Jens Alfke <snej@chromium.org>
eric@webkit.org [Sat, 8 May 2010 18:06:37 +0000 (18:06 +0000)]
2010-05-08  Jens Alfke  <snej@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] WebFrame::registerPasswordListener shouldn't assert on duplicate listener.
        https://bugs.webkit.org/show_bug.cgi?id=38765

        * public/WebFrame.h:
        (WebKit::WebFrameImpl::registerPasswordListener): Changed return type to bool. Updated comment.
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::registerPasswordListener): Return false instead of asserting.
        * src/WebFrameImpl.h:
        (WebKit::WebFrameImpl::registerPasswordListener): Changed return type to bool.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-08 Leandro Pereira <leandro@profusion.mobi>
eric@webkit.org [Sat, 8 May 2010 17:53:41 +0000 (17:53 +0000)]
2010-05-08  Leandro Pereira  <leandro@profusion.mobi>

        Reviewed by Gustavo Noronha Silva.

        ResourceHandleSoup should depend only on GLib, not on GTK+.
        http://webkit.org/b/38763

        * platform/network/soup/ResourceHandleSoup.cpp: Include glib.h
        instead of gtk/gtk.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-08 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sat, 8 May 2010 16:49:51 +0000 (16:49 +0000)]
2010-05-08  Eric Seidel  <eric@webkit.org>

        Unreviewed, rolling out r59023.
        http://trac.webkit.org/changeset/59023
        https://bugs.webkit.org/show_bug.cgi?id=37874

        Caused Chromium Windows build to fail to link.

        * WebCore.gypi:
        * loader/CachedMetadata.h: Removed.
        * loader/CachedResource.cpp:
        * loader/CachedResource.h:
        * loader/ResourceLoader.h:
        * loader/SubresourceLoader.cpp:
        * loader/SubresourceLoader.h:
        * loader/SubresourceLoaderClient.h:
        * loader/loader.cpp:
        * loader/loader.h:
        * platform/network/ResourceHandle.cpp:
        * platform/network/ResourceHandle.h:
        * platform/network/ResourceHandleClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59027 268f45cc-cd09-0410-ab3c-d52691b4dbfc