WebKit-https.git
10 years agohttps://bugs.webkit.org/show_bug.cgi?id=37370
darin@apple.com [Fri, 9 Apr 2010 22:58:37 +0000 (22:58 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=37370
Division by 0 in RenderBoxModelObject::calculateFillTileSize

Reviewed by Maciej Stachowiak.

WebCore:

Test: fast/backgrounds/background-fill-zero-area-crash.html

* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::calculateFillTileSize): Added checks for
zero before doing division. These come up when the area to fill is zero.

LayoutTests:

* fast/backgrounds/background-fill-zero-area-crash-expected.txt: Added.
* fast/backgrounds/background-fill-zero-area-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[wx] Build fix after addition of LayoutTestController method.
kevino@webkit.org [Fri, 9 Apr 2010 22:53:11 +0000 (22:53 +0000)]
[wx] Build fix after addition of LayoutTestController method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=37351
weinig@apple.com [Fri, 9 Apr 2010 22:50:22 +0000 (22:50 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=37351
Cannot build with build-webkit --webkit2

Reviewed by Darin Adler.

Add some headers that it seems others are not getting
already.

* Platform/mac/WorkQueueMac.cpp: #inlude <mach/mach_port.h>
* Shared/mac/UpdateChunk.cpp: #inlude <mach/vm_map.h>

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=37368
weinig@apple.com [Fri, 9 Apr 2010 22:46:31 +0000 (22:46 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=37368
Add MiniBrowser.

Reviewed by Anders Carlsson.

* MiniBrowser: Added.
* MiniBrowser/MiniBrowser.vcproj: Added.
* MiniBrowser/MiniBrowser.xcodeproj: Added.
* MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Added.
* MiniBrowser/mac: Added.
* MiniBrowser/mac/AppDelegate.h: Added.
* MiniBrowser/mac/AppDelegate.m: Added.
* MiniBrowser/mac/BrowserWindowController.h: Added.
* MiniBrowser/mac/BrowserWindowController.m: Added.
* MiniBrowser/mac/English.lproj: Added.
* MiniBrowser/mac/English.lproj/BrowserWindow.xib: Added.
* MiniBrowser/mac/English.lproj/InfoPlist.strings: Added.
* MiniBrowser/mac/English.lproj/MainMenu.xib: Added.
* MiniBrowser/mac/MiniBrowser-Info.plist: Added.
* MiniBrowser/mac/MiniBrowser_Prefix.pch: Added.
* MiniBrowser/mac/main.m: Added.
* MiniBrowser/win: Added.
* MiniBrowser/win/BrowserView.cpp: Added.
* MiniBrowser/win/BrowserView.h: Added.
* MiniBrowser/win/BrowserWindow.cpp: Added.
* MiniBrowser/win/BrowserWindow.h: Added.
* MiniBrowser/win/MiniBrowser.cpp: Added.
* MiniBrowser/win/MiniBrowser.h: Added.
* MiniBrowser/win/MiniBrowser.rc: Added.
* MiniBrowser/win/Resources: Added.
* MiniBrowser/win/main.cpp: Added.
* MiniBrowser/win/resource.h: Added.
* MiniBrowser/win/stdafx.cpp: Added.
* MiniBrowser/win/stdafx.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Maciej Stachowiak.
ap@apple.com [Fri, 9 Apr 2010 22:33:27 +0000 (22:33 +0000)]
    Reviewed by Maciej Stachowiak.

        https://bugs.webkit.org/show_bug.cgi?id=24572
        XMLHttpRequest.statusText returns always "OK" on Mac

        Covered by existing tests, which now pass.

        * WebCore.base.exp:
        * platform/mac/WebCoreSystemInterface.h:
        * platform/mac/WebCoreSystemInterface.mm:
        Added a WebKitSystemInterface method to fetch status line.

        * platform/network/HTTPParsers.cpp: (WebCore::extractReasonPhraseFromHTTPStatusLine):
        * platform/network/HTTPParsers.h:
        * platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::platformLazyInit):
        Moved code for parsing status line to HTTPHeaders, as it's used for both Mac and CF now.

        * platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::platformLazyInit):
        Use the actual reason phrase when available, and "OK" otherwise. Synthesizing a reson when
        there isn't one is misleading, so we'll stick to our old broken behavior on Tiger, rather than
        introduce a new broken one.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling back the last two changes. The failing tests
dumi@chromium.org [Fri, 9 Apr 2010 22:19:46 +0000 (22:19 +0000)]
Unreviewed, rolling back the last two changes. The failing tests
are a Chromium problem, not a WebKit one.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=37361, clean up FillLayer.
hyatt@apple.com [Fri, 9 Apr 2010 22:14:15 +0000 (22:14 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=37361, clean up FillLayer.

Reviewed by Oliver Hunt.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* rendering/style/FillLayer.h:
(WebCore::FillLayer::sizeType):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::backgroundImage):
(WebCore::InheritedFlags::backgroundRepeatX):
(WebCore::InheritedFlags::backgroundRepeatY):
(WebCore::InheritedFlags::backgroundComposite):
(WebCore::InheritedFlags::backgroundAttachment):
(WebCore::InheritedFlags::backgroundClip):
(WebCore::InheritedFlags::backgroundOrigin):
(WebCore::InheritedFlags::backgroundXPosition):
(WebCore::InheritedFlags::backgroundYPosition):
(WebCore::InheritedFlags::backgroundSizeType):
(WebCore::InheritedFlags::backgroundSizeLength):
(WebCore::InheritedFlags::maskImage):
(WebCore::InheritedFlags::maskRepeatX):
(WebCore::InheritedFlags::maskRepeatY):
(WebCore::InheritedFlags::maskComposite):
(WebCore::InheritedFlags::maskAttachment):
(WebCore::InheritedFlags::maskClip):
(WebCore::InheritedFlags::maskOrigin):
(WebCore::InheritedFlags::maskXPosition):
(WebCore::InheritedFlags::maskYPosition):
(WebCore::InheritedFlags::maskSizeType):
(WebCore::InheritedFlags::maskSizeLength):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, adding a TIMEOUT expectations for worker-simple.html
dumi@chromium.org [Fri, 9 Apr 2010 21:40:36 +0000 (21:40 +0000)]
Unreviewed, adding a TIMEOUT expectations for worker-simple.html
on Linux.
https://bugs.webkit.org/show_bug.cgi?id=37274

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMore build fixes.
andersca@apple.com [Fri, 9 Apr 2010 21:36:47 +0000 (21:36 +0000)]
More build fixes.

* WebProcess/win/WebProcessMain.h:
Include windows.h here.

* win/WebKit2.def:
Add new exports.

* win/WebKit2.vcproj:
Add new files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd another missing export to fix the build.
weinig@apple.com [Fri, 9 Apr 2010 21:20:43 +0000 (21:20 +0000)]
Add another missing export to fix the build.

* WebCore.base.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd new WKString.h and WKURL.h headers to top
weinig@apple.com [Fri, 9 Apr 2010 21:19:47 +0000 (21:19 +0000)]
Add new WKString.h and WKURL.h headers to top
level include.

Reviewed by Anders Carlsson.

* UIProcess/API/C/WebKit2.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMore Windows build fixes.
andersca@apple.com [Fri, 9 Apr 2010 21:10:47 +0000 (21:10 +0000)]
More Windows build fixes.

* Shared/NotImplemented.h:
* UIProcess/API/C/cf/WKURLCF.cpp:
Fix typo.

(WKURLCreateWithCFURL):
* UIProcess/API/C/cf/WKURLCF.h:
Ditto.

* win/WebKit2Generated.make:
Copy the new CF headers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, skipping a test on Linux in Chromium.
dumi@chromium.org [Fri, 9 Apr 2010 21:06:12 +0000 (21:06 +0000)]
Unreviewed, skipping a test on Linux in Chromium.
https://bugs.webkit.org/show_bug.cgi?id=37359

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-09 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 9 Apr 2010 21:01:32 +0000 (21:01 +0000)]
2010-04-09  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        webkit-patch attached my patch to the wrong bug
        https://bugs.webkit.org/show_bug.cgi?id=37015

        The problem here is that SVN was violating SCM's implicit
        contract of always returning paths relative to the repository root.
        That can easily be fixed by telling SVN that the CWD is the repository root.

        When fixing this I realized there are a large number of places in SCM.py where
        we want to consider explicitly passing self.checkout_root as the CWD.
        That would allow scm methods to be executed even when the CWD is not inside
        the scm tree at all, and would also make sure (in the case of SVN) that paths
        returned are relative to the root.  Git (almost always) returns paths relative
        to the repository root.

        * Scripts/webkitpy/common/checkout/scm.py:
         - Explicitly pass self.checkout_root as cwd in run_status_and_extract_filenames
         - Add a ton of FIXMEs about the need to go back and decide which methods require cwd=self.checkout_root
           and which do not.  We'll probably add a helper function to scm (likely SCM._run) which
           always passes cwd=self.checkout_root to Executive.run_command
        * Scripts/webkitpy/common/checkout/scm_unittest.py:
         - Add a test for this change.
        * Scripts/webkitpy/tool/commands/upload.py:
         - Removed the explicit os.chdir to the repository root, since scm.py methods
           should be robust against the cwd not being equal to the root.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTwo more #include sorting issues.
weinig@apple.com [Fri, 9 Apr 2010 20:51:31 +0000 (20:51 +0000)]
Two more #include sorting issues.

Reviewed by Anders Carlsson.

* Shared/NotImplemented.h:
* WebProcess/WebPage/win/DrawingAreaUpdateChunk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix minor style nits found by the style-script.
weinig@apple.com [Fri, 9 Apr 2010 20:49:01 +0000 (20:49 +0000)]
Fix minor style nits found by the style-script.

Reviewed by Anders Carlsson.

* Platform/CoreIPC/ArgumentDecoder.h:
* Platform/CoreIPC/ArgumentEncoder.cpp:
* Platform/CoreIPC/Attachment.cpp:
* Platform/CoreIPC/Connection.cpp:
* Platform/CoreIPC/Connection.h:
* Platform/CoreIPC/mac/ConnectionMac.cpp:
* Platform/CoreIPC/win/ConnectionWin.cpp:
* Platform/WorkQueue.h:
* Platform/mac/WorkQueueMac.cpp:
* Platform/win/RunLoopWin.cpp:
* Shared/KURLWrapper.h:
* Shared/WebCoreTypeArgumentMarshalling.h:
* Shared/mac/UpdateChunk.cpp:
* UIProcess/API/C/WKPage.cpp:
* UIProcess/API/C/WKURL.cpp:
* UIProcess/Launcher/win/WebProcessLauncher.cpp:
* UIProcess/ResponsivenessTimer.cpp:
* UIProcess/WebLoaderClient.cpp:
* UIProcess/WebPageProxy.h:
* UIProcess/WebPolicyClient.cpp:
* UIProcess/WebUIClient.cpp:
* UIProcess/win/DrawingAreaProxy.cpp:
* UIProcess/win/WebView.cpp:
* WebProcess/Launching/win/WebProcessWinMain.cpp:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
* WebProcess/WebCoreSupport/mac/WebSystemInterface.h:
* WebProcess/WebCoreSupport/win/WebCoreLocalizedStrings.cpp:
* WebProcess/WebCoreSupport/win/WebErrorsWin.cpp:
* WebProcess/WebPage/WebFrame.h:
* WebProcess/WebPage/WebPage.cpp:
* WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp:
* WebProcess/WebProcess.h:
* WebProcess/win/WebLocalizableStrings.cpp:
* WebProcess/win/WebLocalizableStrings.h:
* WebProcess/win/WebProcessMain.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=37353, clean up cursors used by RenderStyles.
hyatt@apple.com [Fri, 9 Apr 2010 20:44:13 +0000 (20:44 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=37353, clean up cursors used by RenderStyles.

Reviewed by Adam Roben.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* page/EventHandler.cpp:
(WebCore::EventHandler::selectCursor):
* rendering/style/CursorData.h:
(WebCore::CursorData::CursorData):
(WebCore::CursorData::operator==):
(WebCore::CursorData::image):
(WebCore::CursorData::hotSpot):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::addCursor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-09 Antonio Gomes <tonikitoo@webkit.org>
tonikitoo@webkit.org [Fri, 9 Apr 2010 20:40:35 +0000 (20:40 +0000)]
2010-04-09  Antonio Gomes  <tonikitoo@webkit.org>

        Reviewed by Holger Freyther.

        Removing the use of topLevelWidget of QWidget class since it is deprecated/obsolete
        since Qt 4.5. window() method is being used instead now.

        See http://doc.trolltech.com/4.5/qwidget-obsolete.html#topLevelWidget for more info.

        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::windowRect):
        (WebCore::ChromeClientQt::show):
        (WebCore::ChromeClientQt::windowResizerRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix Windows build.
andersca@apple.com [Fri, 9 Apr 2010 20:35:00 +0000 (20:35 +0000)]
Fix Windows build.

* Shared/NotImplemented.h:
Include stdio.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=37349, RenderStyle cleanup. Working from...
hyatt@apple.com [Fri, 9 Apr 2010 20:21:55 +0000 (20:21 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=37349, RenderStyle cleanup.  Working from the outside in to
bring some style consistency to RenderStyle and its associated classes.  This patch cleans up the
border and outline classes.

Reviewed by Adam Roben.

* rendering/RenderTable.cpp:
(WebCore::RenderTable::calcBorderLeft):
(WebCore::RenderTable::calcBorderRight):
(WebCore::RenderTable::outerBorderTop):
(WebCore::RenderTable::outerBorderBottom):
(WebCore::RenderTable::outerBorderLeft):
(WebCore::RenderTable::outerBorderRight):
* rendering/RenderTableCell.cpp:
(WebCore::compareBorders):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcOuterBorderTop):
(WebCore::RenderTableSection::calcOuterBorderBottom):
(WebCore::RenderTableSection::calcOuterBorderLeft):
(WebCore::RenderTableSection::calcOuterBorderRight):
* rendering/style/BorderData.h:
(WebCore::BorderData::hasBorder):
(WebCore::BorderData::hasBorderRadius):
(WebCore::BorderData::borderLeftWidth):
(WebCore::BorderData::borderRightWidth):
(WebCore::BorderData::borderTopWidth):
(WebCore::BorderData::borderBottomWidth):
(WebCore::BorderData::operator==):
(WebCore::BorderData::left):
(WebCore::BorderData::right):
(WebCore::BorderData::top):
(WebCore::BorderData::bottom):
(WebCore::BorderData::image):
(WebCore::BorderData::topLeft):
(WebCore::BorderData::topRight):
(WebCore::BorderData::bottomLeft):
(WebCore::BorderData::bottomRight):
* rendering/style/BorderValue.h:
(WebCore::BorderValue::BorderValue):
(WebCore::BorderValue::nonZero):
(WebCore::BorderValue::isTransparent):
(WebCore::BorderValue::operator==):
(WebCore::BorderValue::color):
(WebCore::BorderValue::width):
(WebCore::BorderValue::style):
* rendering/style/CollapsedBorderValue.h:
(WebCore::CollapsedBorderValue::CollapsedBorderValue):
(WebCore::CollapsedBorderValue::width):
(WebCore::CollapsedBorderValue::style):
(WebCore::CollapsedBorderValue::exists):
(WebCore::CollapsedBorderValue::color):
(WebCore::CollapsedBorderValue::isTransparent):
(WebCore::CollapsedBorderValue::precedence):
(WebCore::CollapsedBorderValue::operator==):
* rendering/style/OutlineValue.h:
(WebCore::OutlineValue::OutlineValue):
(WebCore::OutlineValue::operator==):
(WebCore::OutlineValue::offset):
(WebCore::OutlineValue::isAuto):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::getBorderRadiiForRect):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::borderLeft):
(WebCore::InheritedFlags::borderRight):
(WebCore::InheritedFlags::borderTop):
(WebCore::InheritedFlags::borderBottom):
(WebCore::InheritedFlags::borderImage):
(WebCore::InheritedFlags::borderTopLeftRadius):
(WebCore::InheritedFlags::borderTopRightRadius):
(WebCore::InheritedFlags::borderBottomLeftRadius):
(WebCore::InheritedFlags::borderBottomRightRadius):
(WebCore::InheritedFlags::borderLeftStyle):
(WebCore::InheritedFlags::borderLeftColor):
(WebCore::InheritedFlags::borderLeftIsTransparent):
(WebCore::InheritedFlags::borderRightStyle):
(WebCore::InheritedFlags::borderRightColor):
(WebCore::InheritedFlags::borderRightIsTransparent):
(WebCore::InheritedFlags::borderTopStyle):
(WebCore::InheritedFlags::borderTopColor):
(WebCore::InheritedFlags::borderTopIsTransparent):
(WebCore::InheritedFlags::borderBottomStyle):
(WebCore::InheritedFlags::borderBottomColor):
(WebCore::InheritedFlags::borderBottomIsTransparent):
(WebCore::InheritedFlags::outlineWidth):
(WebCore::InheritedFlags::outlineStyleIsAuto):
(WebCore::InheritedFlags::outlineColor):
(WebCore::InheritedFlags::outlineOffset):
(WebCore::InheritedFlags::columnRuleColor):
(WebCore::InheritedFlags::resetBorderTop):
(WebCore::InheritedFlags::resetBorderRight):
(WebCore::InheritedFlags::resetBorderBottom):
(WebCore::InheritedFlags::resetBorderLeft):
(WebCore::InheritedFlags::resetBorderImage):
(WebCore::InheritedFlags::resetBorderTopLeftRadius):
(WebCore::InheritedFlags::resetBorderTopRightRadius):
(WebCore::InheritedFlags::resetBorderBottomLeftRadius):
(WebCore::InheritedFlags::resetBorderBottomRightRadius):
(WebCore::InheritedFlags::setBorderImage):
(WebCore::InheritedFlags::setBorderTopLeftRadius):
(WebCore::InheritedFlags::setBorderTopRightRadius):
(WebCore::InheritedFlags::setBorderBottomLeftRadius):
(WebCore::InheritedFlags::setBorderBottomRightRadius):
(WebCore::InheritedFlags::setBorderLeftWidth):
(WebCore::InheritedFlags::setBorderLeftStyle):
(WebCore::InheritedFlags::setBorderLeftColor):
(WebCore::InheritedFlags::setBorderRightWidth):
(WebCore::InheritedFlags::setBorderRightStyle):
(WebCore::InheritedFlags::setBorderRightColor):
(WebCore::InheritedFlags::setBorderTopWidth):
(WebCore::InheritedFlags::setBorderTopStyle):
(WebCore::InheritedFlags::setBorderTopColor):
(WebCore::InheritedFlags::setBorderBottomWidth):
(WebCore::InheritedFlags::setBorderBottomStyle):
(WebCore::InheritedFlags::setBorderBottomColor):
(WebCore::InheritedFlags::setOutlineWidth):
(WebCore::InheritedFlags::setOutlineStyle):
(WebCore::InheritedFlags::setOutlineColor):
(WebCore::InheritedFlags::setOutlineOffset):
(WebCore::InheritedFlags::setColumnRuleColor):
(WebCore::InheritedFlags::setColumnRuleWidth):
* rendering/style/StyleMultiColData.h:
(WebCore::StyleMultiColData::ruleWidth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-09 Mikhail Naganov <mnaganov@chromium.org>
eric@webkit.org [Fri, 9 Apr 2010 20:20:36 +0000 (20:20 +0000)]
2010-04-09  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Make CallIdentifier constructor to handle null urls.

        https://bugs.webkit.org/show_bug.cgi?id=37341

        * profiler/CallIdentifier.h:
        (JSC::CallIdentifier::CallIdentifier):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd some missing URLs to ChangeLogs.
weinig@apple.com [Fri, 9 Apr 2010 20:10:08 +0000 (20:10 +0000)]
Add some missing URLs to ChangeLogs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=37347
weinig@apple.com [Fri, 9 Apr 2010 20:08:38 +0000 (20:08 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=37347
Don't use CF types in the new C API

Reviewed by Anders Carlsson.

Replace all uses of CF types in the C API.
- Replace CFStringRef with WKStringRef.
- Replace CFURLRef with WKURLRef.

* WebKit2.xcodeproj/project.pbxproj: Add new files.

* Shared/KURLWrapper.h: Added. RefCounted wrapper around KURL.
* UIProcess/API/C/WKAPICast.h: Add new conversions.
* UIProcess/API/C/WKBase.h: Add new types.
* UIProcess/API/C/WKFrame.cpp:
* UIProcess/API/C/WKFrame.h:
* UIProcess/API/C/WKPage.cpp:
* UIProcess/API/C/WKPage.h:
Replace uses of CF types with WK equivalents.

* UIProcess/API/C/WKString.cpp: Added.
* UIProcess/API/C/WKString.h: Added.
Represents a WebCore::StringImpl*.

* UIProcess/API/C/WKURL.cpp: Added.
* UIProcess/API/C/WKURL.h: Added.
Represents a WebKit::KURLWrapper*.

* UIProcess/API/C/cf: Added.
* UIProcess/API/C/cf/WKStringCF.cpp: Added.
* UIProcess/API/C/cf/WKStringCF.h: Added.
* UIProcess/API/C/cf/WKURLCF.cpp: Added.
* UIProcess/API/C/cf/WKURLCF.h: Added.
CoreFoundation conversion files. Allows converting
 WKStringRef <-> CFStringRef
 WKURLRef <-> CFURLRef

* UIProcess/ScriptReturnValueCallback.cpp:
(WebKit::ScriptReturnValueCallback::performCallbackWithReturnValue):
* UIProcess/ScriptReturnValueCallback.h:
* UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::didStartProvisionalLoad):
(WebKit::WebFrameProxy::didCommitLoad):
* UIProcess/WebFrameProxy.h:
(WebKit::WebFrameProxy::url):
(WebKit::WebFrameProxy::provisionalURL):
* UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::didReceiveTitleForFrame):
* UIProcess/WebLoaderClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::didReceiveTitleForFrame):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
(WebKit::WebPageProxy::decidePolicyForMIMEType):
(WebKit::WebPageProxy::runJavaScriptAlert):
(WebKit::WebPageProxy::didRunJavaScriptInMainFrame):
(WebKit::WebPageProxy::processDidExit):
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::pageTitle):
(WebKit::WebPageProxy::urlAtProcessExit):
* UIProcess/WebPolicyClient.cpp:
(WebKit::WebPolicyClient::decidePolicyForNavigationAction):
(WebKit::WebPolicyClient::decidePolicyForNewWindowAction):
(WebKit::WebPolicyClient::decidePolicyForMIMEType):
* UIProcess/WebPolicyClient.h:
* UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::runJavaScriptAlert):
* UIProcess/WebUIClient.h:
Don't use CF types internally at all.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::frameLoaderDestroyed):
Fix typo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-09 Andrey Kosyakov <caseq@chromium.org>
eric@webkit.org [Fri, 9 Apr 2010 20:01:20 +0000 (20:01 +0000)]
2010-04-09  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Darin Adler.

        Changed expectation for text status for HTTP status of 4xx following
        a fix for localized status messages.
        https://bugs.webkit.org/show_bug.cgi?id=37274

        * platform/mac/http/tests/xmlhttprequest/web-apps/013-expected.txt:
        * platform/mac/http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception-expected.txt:
2010-04-09  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Darin Adler.

        Fixed ResourceError::failingURL() and ResourceResponse::httpStatusText()
        to return meaningful values.
        https://bugs.webkit.org/show_bug.cgi?id=37274

        * platform/network/mac/ResourceErrorMac.mm:
        (WebCore::ResourceError::platformLazyInit):
        * platform/network/mac/ResourceResponseMac.mm:
        (WebCore::ResourceResponse::platformLazyInit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-09 Jeremy Orlow <jorlow@chromium.org>
eric@webkit.org [Fri, 9 Apr 2010 19:50:39 +0000 (19:50 +0000)]
2010-04-09  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Adler.

        Move the IDB::open ExceptionCode paramter to be last
        https://bugs.webkit.org/show_bug.cgi?id=37277

        Move the ExceptionCode paramter to the last position in
        IndexedDatabaseRequest::open and friends.  It should definitely
        go after the callbacks to keep the parameters that come directly
        from javascript together.  And having output parameters appear
        last is done often in the code base, so it makes sense to push
        it past the Frame* param as well.

        No functional change.

        * bindings/v8/custom/V8IndexedDatabaseRequestCustom.cpp:
        (WebCore::V8IndexedDatabaseRequest::openCallback):
        * storage/IndexedDatabase.h:
        * storage/IndexedDatabaseImpl.cpp:
        (WebCore::IndexedDatabaseImpl::open):
        * storage/IndexedDatabaseImpl.h:
        * storage/IndexedDatabaseRequest.cpp:
        (WebCore::IndexedDatabaseRequest::open):
        * storage/IndexedDatabaseRequest.h:
2010-04-09  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Adler.

        Move the IDB::open ExceptionCode paramter to be last
        https://bugs.webkit.org/show_bug.cgi?id=37277

        Move the ExceptionCode paramter to the last position in
        IndexedDatabaseRequest::open and friends.  It should definitely
        go after the callbacks to keep the parameters that come directly
        from javascript together.  And having output parameters appear
        last is done often in the code base, so it makes sense to push
        it past the Frame* param as well.

        * public/WebIndexedDatabase.h:
        * src/IndexedDatabaseProxy.cpp:
        (WebCore::IndexedDatabaseProxy::open):
        * src/IndexedDatabaseProxy.h:
        * src/WebIndexedDatabaseImpl.cpp:
        (WebKit::WebIndexedDatabaseImpl::open):
        * src/WebIndexedDatabaseImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: WorkerGlobalScope.close() should let the currently running script complete...
dimich@chromium.org [Fri, 9 Apr 2010 19:29:43 +0000 (19:29 +0000)]
WebCore: WorkerGlobalScope.close() should let the currently running script complete execution, then terminate the worker.
https://bugs.webkit.org/show_bug.cgi?id=37053

Reviewed by Darin Adler.

WebCore:

Test: fast/workers/worker-close-more.html

* bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::forbidExecution):
(WebCore::WorkerScriptController::):
* bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::forbidExecution):
* bindings/v8/WorkerScriptController.h:
(WebCore::WorkerScriptController::):
Added option parameter to forbidExecution (both JCS and V8 versions) that specifies whether currently running
script should be immediately terminated or left executed until the end.

* bindings/js/WorkerScriptController.h:
(WebCore::WorkerScriptController::workerContextWrapper):
This method now can return 0 instead of context if the further execution of JS is forbidden. Since any JS execution requires
fetching JS global object first, returning 0 here is a good way to prevent re-entry into JS once worker started termination.
V8 version does similar thing already in WorkerScriptController::proxy().

* workers/DedicatedWorkerContext.cpp:
(WebCore::DedicatedWorkerContext::postMessage):
Removed check that immediately disables postMessage from WorkerContext after close().

* workers/WorkerContext.cpp:
(WebCore::CloseWorkerContextTask::create):
(WebCore::CloseWorkerContextTask::performTask):
(WebCore::CloseWorkerContextTask::isCleanupTask):
(WebCore::WorkerContext::close):
Use new forbidExecution(LetRunningScriptFinish) to avoid termination of script until it executes and exits.
Post a task to actually terminate the worker once the currently executing JS fragment exits.

* workers/WorkerThread.cpp:
(WebCore::WorkerThread::workerThread):
(WebCore::WorkerThread::stop):
Use new forbidExecution(TerminateRunningScript) to immediately terminate the JS.

LayoutTests:

* fast/workers/resources/worker-close.js:
* fast/workers/worker-close-expected.txt:
Updated tests to expect the script fragment that includes close() to run to completion.

* fast/workers/worker-close-more-expected.txt: Added.
* fast/workers/worker-close-more.html: Added.
* fast/workers/worker-close.html:
Added test to check terminate() after close() and close() in the case of multiple MessagePort messages dispatching.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-09 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 9 Apr 2010 19:10:00 +0000 (19:10 +0000)]
2010-04-09  Eric Seidel  <eric@webkit.org>

        Unreviewed, rolling out r57343.
        http://trac.webkit.org/changeset/57343
        https://bugs.webkit.org/show_bug.cgi?id=37311

        Broke Tiger compile.

        * WebView/WebVideoFullscreenController.mm:
        (-[WebVideoFullscreenController windowDidLoad]):
        (-[WebVideoFullscreenController setMediaElement:WebCore::]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/7846015> REGRESSION (r57332) - Crash in [WebDynamicScrollBarsView...
mitz@apple.com [Fri, 9 Apr 2010 18:56:02 +0000 (18:56 +0000)]
<rdar://problem/7846015> REGRESSION (r57332) - Crash in [WebDynamicScrollBarsView(WebInternal) reflectScrolledClipView:] when opening the Downloads window

Reviewed by Darin Adler.

* WebView/WebDynamicScrollBarsView.mm:
(-[WebDynamicScrollBarsView initWithCoder:]): Added. Calls super and then initializes _private.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoImplement interactive validation for forms.
tkent@chromium.org [Fri, 9 Apr 2010 18:03:06 +0000 (18:03 +0000)]
Implement interactive validation for forms.
https://bugs.webkit.org/show_bug.cgi?id=34930

Reviewed by Darin Adler.

WebCore:

- HTMLFormControlElement::checkValidity() supports unhandled invalid control list
- HTMLFormElement::validateInteractively() called from prepareSubmit()
  prevents the submission if neither noValidate nor formNoValidate is
  specified, and focuses on the first invalid control of which "invalid"
  event is not canceled.

Tests: fast/forms/checkValidity-cancel.html
       fast/forms/interactive-validation-cancel.html
       fast/forms/interactive-validation-formnovalidate.html
       fast/forms/interactive-validation-novalidate.html
       fast/forms/interactive-validation-prevented.html
       fast/forms/interactive-validation-remove-node-in-handler.html

* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::checkValidity):
  If the control is invalid and the "invalid" is not canceled,
  push the control to the specified vector.
* html/HTMLFormControlElement.h:
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::validateInteractively):
 The main part of the interactive validation.
(WebCore::HTMLFormElement::prepareSubmit):
 Calls validateInteractively().
(WebCore::HTMLFormElement::checkValidity):
 Uses collectUnhandledInvalidControls().
(WebCore::HTMLFormElement::collectUnhandledInvalidControls):
* html/HTMLFormElement.h:

LayoutTests:

Add tests for "invalid" event and interactive validation.

* fast/forms/checkValidity-cancel-expected.txt: Added.
* fast/forms/checkValidity-cancel.html: Added.
* fast/forms/interactive-validation-cancel-expected.txt: Added.
* fast/forms/interactive-validation-cancel.html: Added.
* fast/forms/interactive-validation-formnovalidate-expected.txt: Added.
* fast/forms/interactive-validation-formnovalidate.html: Added.
* fast/forms/interactive-validation-novalidate-expected.txt: Added.
* fast/forms/interactive-validation-novalidate.html: Added.
* fast/forms/interactive-validation-prevented-expected.txt: Added.
* fast/forms/interactive-validation-prevented.html: Added.
* fast/forms/interactive-validation-remove-node-in-handler-expected.txt: Added.
* fast/forms/interactive-validation-remove-node-in-handler.html: Added.
* fast/forms/script-tests/checkValidity-cancel.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-09 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Fri, 9 Apr 2010 17:45:01 +0000 (17:45 +0000)]
2010-04-09  Gustavo Noronha Silva  <gns@gnome.org>

        [GTK+] media/video-src-invalid-remove.html
        https://bugs.webkit.org/show_bug.cgi?id=37344

        Skip test that is failing constantly but apparently without reason
        on the 64 bits release bot.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix the mac WebKit2 build.
weinig@apple.com [Fri, 9 Apr 2010 17:04:01 +0000 (17:04 +0000)]
Fix the mac WebKit2 build.

* WebCore.base.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-09 Jer Noble <jer.noble@apple.com>
eric@webkit.org [Fri, 9 Apr 2010 16:53:15 +0000 (16:53 +0000)]
2010-04-09  Jer Noble  <jer.noble@apple.com>

        Reviewed by Darin Adler.

        Work around QTMovieView bug (<rdar://problem/7712713>) by using a QTMovieLayer instead.
        https://bugs.webkit.org/show_bug.cgi?id=37311 / <rdar://problem/7749993>

        * WebView/WebVideoFullscreenController.mm:
        (-[WebVideoFullscreenController windowDidLoad]):
        (-[WebVideoFullscreenController setMediaElement:WebCore::]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Add expected results for passing new tests. Compared to the Mac png-s and expect...
abecsi@webkit.org [Fri, 9 Apr 2010 16:49:28 +0000 (16:49 +0000)]
[Qt] Add expected results for passing new tests. Compared to the Mac png-s and expected files these
platform dependent results only differ from Mac resulst in font metrics and svg implementation.

Rubber-stamped by Simon Hausmann.
Patch by Andras Becsi <abecsi@inf.u-szeged.hu>

* platform/qt/editing/deleting/non-smart-delete-expected.checksum: Added.
* platform/qt/editing/deleting/non-smart-delete-expected.png: Added.
* platform/qt/editing/deleting/non-smart-delete-expected.txt: Added.
* platform/qt/fast/css/first-letter-first-line-hover-expected.checksum: Added.
* platform/qt/fast/css/first-letter-first-line-hover-expected.png: Added.
* platform/qt/fast/css/first-letter-first-line-hover-expected.txt: Added.
* platform/qt/fast/forms/basic-selects-expected.checksum: Added.
* platform/qt/fast/forms/basic-selects-expected.png: Added.
* platform/qt/fast/forms/basic-selects-expected.txt: Added.
* platform/qt/fast/repaint/moving-shadow-on-container-expected.checksum: Added.
* platform/qt/fast/repaint/moving-shadow-on-container-expected.png: Added.
* platform/qt/fast/repaint/moving-shadow-on-container-expected.txt: Added.
* platform/qt/fast/repaint/moving-shadow-on-path-expected.checksum: Added.
* platform/qt/fast/repaint/moving-shadow-on-path-expected.png: Added.
* platform/qt/fast/repaint/moving-shadow-on-path-expected.txt: Added.
* platform/qt/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.checksum: Added.
* platform/qt/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.png: Added.
* platform/qt/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.txt: Added.
* platform/qt/fast/repaint/selection-gap-overflow-scroll-2-expected.checksum: Added.
* platform/qt/fast/repaint/selection-gap-overflow-scroll-2-expected.png: Added.
* platform/qt/fast/repaint/selection-gap-overflow-scroll-2-expected.txt: Added.
* platform/qt/fast/repaint/stacked-diacritics-expected.checksum: Added.
* platform/qt/fast/repaint/stacked-diacritics-expected.png: Added.
* platform/qt/fast/repaint/stacked-diacritics-expected.txt: Added.
* platform/qt/fast/ruby: Added.
* platform/qt/fast/ruby/ruby-inline-table-expected.checksum: Added.
* platform/qt/fast/ruby/ruby-inline-table-expected.png: Added.
* platform/qt/fast/ruby/ruby-inline-table-expected.txt: Added.
* platform/qt/fast/runin/generated2-expected.checksum: Added.
* platform/qt/fast/runin/generated2-expected.png: Added.
* platform/qt/fast/runin/generated2-expected.txt: Added.
* platform/qt/fast/runin/generated3-expected.checksum: Added.
* platform/qt/fast/runin/generated3-expected.png: Added.
* platform/qt/fast/runin/generated3-expected.txt: Added.
* platform/qt/fast/runin/generated4-expected.checksum: Added.
* platform/qt/fast/runin/generated4-expected.png: Added.
* platform/qt/fast/runin/generated4-expected.txt: Added.
* platform/qt/fast/text/international/hebrew-vowels-expected.checksum: Added.
* platform/qt/fast/text/international/hebrew-vowels-expected.png: Added.
* platform/qt/fast/text/international/hebrew-vowels-expected.txt: Added.
* platform/qt/svg/custom/mask-invalidation-expected.checksum: Added.
* platform/qt/svg/custom/mask-invalidation-expected.png: Added.
* platform/qt/svg/custom/mask-invalidation-expected.txt: Added.
* platform/qt/svg/custom/pattern-excessive-malloc-expected.checksum: Added.
* platform/qt/svg/custom/pattern-excessive-malloc-expected.png: Added.
* platform/qt/svg/custom/pattern-excessive-malloc-expected.txt: Added.
* platform/qt/svg/custom/pattern-size-bigger-than-target-size-expected.checksum: Added.
* platform/qt/svg/custom/pattern-size-bigger-than-target-size-expected.png: Added.
* platform/qt/svg/custom/pattern-size-bigger-than-target-size-expected.txt: Added.
* platform/qt/svg/custom/pattern-skew-transformed-expected.checksum: Added.
* platform/qt/svg/custom/pattern-skew-transformed-expected.png: Added.
* platform/qt/svg/custom/pattern-skew-transformed-expected.txt: Added.
* platform/qt/svg/custom/stroke-width-large-expected.checksum: Added.
* platform/qt/svg/custom/stroke-width-large-expected.png: Added.
* platform/qt/svg/custom/stroke-width-large-expected.txt: Added.
* platform/qt/svg/custom/use-on-clip-path-with-transformation-expected.checksum: Added.
* platform/qt/svg/custom/use-on-clip-path-with-transformation-expected.png: Added.
* platform/qt/svg/custom/use-on-clip-path-with-transformation-expected.txt: Added.
* platform/qt/svg/filters/filter-on-tspan-expected.checksum: Added.
* platform/qt/svg/filters/filter-on-tspan-expected.png: Added.
* platform/qt/svg/filters/filter-on-tspan-expected.txt: Added.
* platform/qt/svg/overflow: Added.
* platform/qt/svg/overflow/overflow-on-foreignObject-expected.checksum: Added.
* platform/qt/svg/overflow/overflow-on-foreignObject-expected.png: Added.
* platform/qt/svg/overflow/overflow-on-foreignObject-expected.txt: Added.
* platform/qt/svg/overflow/overflow-on-inner-svg-element-defaults-expected.checksum: Added.
* platform/qt/svg/overflow/overflow-on-inner-svg-element-defaults-expected.png: Added.
* platform/qt/svg/overflow/overflow-on-inner-svg-element-defaults-expected.txt: Added.
* platform/qt/svg/overflow/overflow-on-inner-svg-element-expected.checksum: Added.
* platform/qt/svg/overflow/overflow-on-inner-svg-element-expected.png: Added.
* platform/qt/svg/overflow/overflow-on-inner-svg-element-expected.txt: Added.
* platform/qt/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.checksum: Added.
* platform/qt/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png: Added.
* platform/qt/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.txt: Added.
* platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.checksum: Added.
* platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png: Added.
* platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.txt: Added.
* platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.checksum: Added.
* platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png: Added.
* platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.txt: Added.
* platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.checksum: Added.
* platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png: Added.
* platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.txt: Added.
* platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.checksum: Added.
* platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.png: Added.
* platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.txt: Added.
* platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.checksum: Added.
* platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png: Added.
* platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.txt: Added.
* platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.checksum: Added.
* platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.png: Added.
* platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.txt: Added.
* platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.checksum: Added.
* platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.png: Added.
* platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.txt: Added.
* platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.checksum: Added.
* platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.png: Added.
* platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.txt: Added.
* platform/qt/svg/text/selection-doubleclick-expected.checksum: Added.
* platform/qt/svg/text/selection-doubleclick-expected.png: Added.
* platform/qt/svg/text/selection-doubleclick-expected.txt: Added.
* platform/qt/svg/text/selection-styles-expected.checksum: Added.
* platform/qt/svg/text/selection-styles-expected.png: Added.
* platform/qt/svg/text/selection-styles-expected.txt: Added.
* platform/qt/svg/text/selection-tripleclick-expected.checksum: Added.
* platform/qt/svg/text/selection-tripleclick-expected.png: Added.
* platform/qt/svg/text/selection-tripleclick-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-09 Jochen Eisinger <jochen@chromium.org>
eric@webkit.org [Fri, 9 Apr 2010 16:38:57 +0000 (16:38 +0000)]
2010-04-09  Jochen Eisinger  <jochen@chromium.org>

        Reviewed by Darin Fisher.

        Complete move of createApplicationCacheHost from WebKitClient to WebFrameClient.
        https://bugs.webkit.org/show_bug.cgi?id=37330

        * public/WebApplicationCacheHost.h:
        * public/WebKitClient.h:
        * src/ApplicationCacheHostInternal.h:
        (WebCore::ApplicationCacheHostInternal::ApplicationCacheHostInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Darin Adler.
ap@apple.com [Fri, 9 Apr 2010 16:35:05 +0000 (16:35 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=37181
        <rdar://problem/7835374> REGRESSION (r54400): Hangs when doing AJAX update with large amount of data

        Test: fast/events/gc-freeze-with-attribute-listeners.html

        The problem was that we were creating JS wrappers for nodes with attribute event listeners,
        and GC is very slow if there are nodes with wrappers in a detached tree whose root does not
        have a wrapper.

        * bindings/js/ScriptEventListener.cpp: (WebCore::createAttributeEventListener): Don't create
        wrappers for attribute event listeners - if there is a node, JSLazyEventListener::initializeJSFunction()
        will create one.

        * bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::markChildren): Added a FIXME about the problem
        we are stepping around now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake :visited tests added in r57292 not assert on Windows and GTK builds
aroben@apple.com [Fri, 9 Apr 2010 15:56:00 +0000 (15:56 +0000)]
Make :visited tests added in r57292 not assert on Windows and GTK builds

Fixes <http://webkit.org/b/37333>.

Reviewed by Anders Carlsson.

WebKitTools:

Don't return 0 as a JSValueRef

That is an illegal use of the JSC API.

* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::computedStyleIncludingVisitedInfo):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::computedStyleIncludingVisitedInfo):
Return an "undefined" JSValueRef instead of 0.

LayoutTests:

Add Windows- and GTK-specific results for new :visited tests

These platforms haven't yet implemented the new LayoutTestController
API these tests require. Implementing the API is tracked by
<http://webkit.org/b/37336> and <http://webkit.org/b/37337>.

* platform/gtk/fast/history/nested-visited-test-expected.txt: Added.
* platform/gtk/fast/history/self-is-visited-expected.txt: Added.
* platform/gtk/fast/history/sibling-visited-test-expected.txt: Added.
* platform/win/fast/history/nested-visited-test-expected.txt: Added.
* platform/win/fast/history/self-is-visited-expected.txt: Added.
* platform/win/fast/history/sibling-visited-test-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-09 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Fri, 9 Apr 2010 14:01:15 +0000 (14:01 +0000)]
2010-04-09  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        WebGtk GLib-CRITICAL Segmentation fault
        https://bugs.webkit.org/show_bug.cgi?id=34937

        Do not crash if a plugin does not return anything in
        NP_GetMIMEDescription. This can happen, and other ports gracefully
        handle the situation.

        * plugins/gtk/PluginPackageGtk.cpp:
        (WebCore::PluginPackage::fetchInfo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-09 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 9 Apr 2010 13:44:44 +0000 (13:44 +0000)]
2010-04-09  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Cannot select elements within iframes with the magnifying glass.

        https://bugs.webkit.org/show_bug.cgi?id=31732

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::inspect):
        (WebCore::InspectorController::handleMousePress):
        * inspector/InspectorController.h:
        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMousePressEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows Debug/Release build fix after r57244
aroben@apple.com [Fri, 9 Apr 2010 13:40:43 +0000 (13:40 +0000)]
Windows Debug/Release build fix after r57244

* WebKit.vcproj/WebKit.vcproj: Don't delay-load QuartzCore.dll or
QuartzCoreInterface.dll in any configurations. r57244 made this change
only for Debug_Internal.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-09 Marcus Bulach <bulach@chromium.org>
eric@webkit.org [Fri, 9 Apr 2010 13:13:45 +0000 (13:13 +0000)]
2010-04-09  Marcus Bulach  <bulach@chromium.org>

        Reviewed by Jeremy Orlow.

        Crash on WebKit::WebGeolocationServiceBridgeImpl::stopUpdating() during frame disconnection
        Should not try to access WebViewClient if the frame has already been disconnected.
        https://bugs.webkit.org/show_bug.cgi?id=37318

        * src/WebGeolocationServiceBridgeImpl.cpp:
        (WebKit::WebGeolocationServiceBridgeImpl::stopUpdating):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-09 Tasuku Suzuki <tasuku.suzuki@nokia.com>
eric@webkit.org [Fri, 9 Apr 2010 13:03:43 +0000 (13:03 +0000)]
2010-04-09  Tasuku Suzuki  <tasuku.suzuki@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt]Fix compile error with QT_NO_PROPERTIES
        https://bugs.webkit.org/show_bug.cgi?id=36526

        Disable dynamic properties when QT_NO_PROPERTIES is defined.

        * bridge/qt/qt_class.cpp:
        (JSC::Bindings::QtClass::fieldNamed):
        * bridge/qt/qt_instance.cpp:
        (JSC::Bindings::QtInstance::getPropertyNames):
        (JSC::Bindings::QtField::name):
        (JSC::Bindings::QtField::valueFromInstance):
        (JSC::Bindings::QtField::setValueToInstance):
        * bridge/qt/qt_runtime.h:
        (JSC::Bindings::QtField::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Symbian apps crash on exit due to a bad qObject_cast.
hausmann@webkit.org [Fri, 9 Apr 2010 12:12:27 +0000 (12:12 +0000)]
[Qt] Symbian apps crash on exit due to a bad qObject_cast.

Patch by David Leong <david.leong@nokia.com> on 2010-04-09
Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=37303

Added check for NULL to avoid the crash.

* plugins/symbian/PluginViewSymbian.cpp:
(WebCore::PluginView::platformDestroy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/7814899> REGRESSION(r56008): iTunes crashes on quit inside -[NSScroll...
mrowe@apple.com [Fri, 9 Apr 2010 12:03:27 +0000 (12:03 +0000)]
<rdar://problem/7814899> REGRESSION(r56008): iTunes crashes on quit inside -[NSScrollView dealloc]

[ Re-landing of r57329 with the requisite memset added in -initWithFrame: so that the tests keep working. ]

Reviewed by John Sullivan.

In r56008 new instance variables were added to WebDynamicScrollBarsView, increasing its size.
This causes problems for 32-bit applications that derive from WebDynamicScrollBarsView, as the
size and layout of their subclasses is baked in at compile time.  This results in instances
being allocated that are smaller than the new code expects, and may result in the new instance
variables sharing the same memory space as any instance variables that the subclass defines.

We can avoid this problem by having the class contain only a single member that acts as a pointer
to a heap-allocated structure that acts as storage for the real instance variables.  This makes
us free to add instance variables in the future without risk of changing the size of the class.
To ensure that 32-bit applications that are built against this new WebDynamicScrollBarsView header
are able to run against older versions of WebKit we pad the class out to its previous size.  This
results in any subclasses of WebDynamicScrollBarsView being created with a layout that is compatible
with both versions of the code.

This change could potentially break a subclass of WebDynamicScrollBarsView that directly accesses
instance variables of its superclass.  However, this is a private header and no known subclasses
of WebDynamicScrollBarsView access superclass instance variables in this fashion.

* WebView/WebDynamicScrollBarsView.h:
* WebView/WebDynamicScrollBarsView.mm:
(-[WebDynamicScrollBarsView initWithFrame:]):
(-[WebDynamicScrollBarsView dealloc]):
(-[WebDynamicScrollBarsView finalize]):
(-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]):
(-[WebDynamicScrollBarsView setAllowsScrollersToOverlapContent:]):
(-[WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]):
(-[WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]):
(-[WebDynamicScrollBarsView horizontalScrollingAllowed]):
(-[WebDynamicScrollBarsView verticalScrollingAllowed]):
(-[WebDynamicScrollBarsView contentViewFrame]):
(-[WebDynamicScrollBarsView tile]):
(-[WebDynamicScrollBarsView setSuppressLayout:]):
(-[WebDynamicScrollBarsView setScrollBarsSuppressed:repaintOnUnsuppress:]):
(-[WebDynamicScrollBarsView updateScrollers]):
(-[WebDynamicScrollBarsView reflectScrolledClipView:]):
(-[WebDynamicScrollBarsView allowsHorizontalScrolling]):
(-[WebDynamicScrollBarsView allowsVerticalScrolling]):
(-[WebDynamicScrollBarsView scrollingModes:WebCore::vertical:WebCore::]):
(-[WebDynamicScrollBarsView horizontalScrollingMode]):
(-[WebDynamicScrollBarsView verticalScrollingMode]):
(-[WebDynamicScrollBarsView setScrollingModes:vertical:andLock:]):
(-[WebDynamicScrollBarsView setHorizontalScrollingModeLocked:]):
(-[WebDynamicScrollBarsView setVerticalScrollingModeLocked:]):
(-[WebDynamicScrollBarsView setScrollingModesLocked:]):
(-[WebDynamicScrollBarsView horizontalScrollingModeLocked]):
(-[WebDynamicScrollBarsView verticalScrollingModeLocked]):
(-[WebDynamicScrollBarsView scrollWheel:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed crash fix.
hausmann@webkit.org [Fri, 9 Apr 2010 11:55:53 +0000 (11:55 +0000)]
Unreviewed crash fix.

Revert part of 57320 that would remove NDEBUG in release builds for
DRT, etc.

* WebKit.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRoll out r57329 since the bots are seeing lots of failures that I wasn't seeing locally.
mrowe@apple.com [Fri, 9 Apr 2010 11:55:50 +0000 (11:55 +0000)]
Roll out r57329 since the bots are seeing lots of failures that I wasn't seeing locally.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/7814899> REGRESSION(r56008): iTunes crashes on quit inside -[NSScroll...
mrowe@apple.com [Fri, 9 Apr 2010 11:44:44 +0000 (11:44 +0000)]
<rdar://problem/7814899> REGRESSION(r56008): iTunes crashes on quit inside -[NSScrollView dealloc]

Reviewed by John Sullivan.

In r56008 new instance variables were added to WebDynamicScrollBarsView, increasing its size.
This causes problems for 32-bit applications that derive from WebDynamicScrollBarsView, as the
size and layout of their subclasses is baked in at compile time.  This results in instances
being allocated that are smaller than the new code expects, and may result in the new instance
variables sharing the same memory space as any instance variables that the subclass defines.

We can avoid this problem by having the class contain only a single member that acts as a pointer
to a heap-allocated structure that acts as storage for the real instance variables.  This makes
us free to add instance variables in the future without risk of changing the size of the class.
To ensure that 32-bit applications that are built against this new WebDynamicScrollBarsView header
are able to run against older versions of WebKit we pad the class out to its previous size.  This
results in any subclasses of WebDynamicScrollBarsView being created with a layout that is compatible
with both versions of the code.

This change could potentially break a subclass of WebDynamicScrollBarsView that directly accesses
instance variables of its superclass.  However, this is a private header and no known subclasses
of WebDynamicScrollBarsView access superclass instance variables in this fashion.

* WebView/WebDynamicScrollBarsView.h:
* WebView/WebDynamicScrollBarsView.mm:
(-[WebDynamicScrollBarsView initWithFrame:]):
(-[WebDynamicScrollBarsView dealloc]):
(-[WebDynamicScrollBarsView finalize]):
(-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]):
(-[WebDynamicScrollBarsView setAllowsScrollersToOverlapContent:]):
(-[WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]):
(-[WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]):
(-[WebDynamicScrollBarsView horizontalScrollingAllowed]):
(-[WebDynamicScrollBarsView verticalScrollingAllowed]):
(-[WebDynamicScrollBarsView contentViewFrame]):
(-[WebDynamicScrollBarsView tile]):
(-[WebDynamicScrollBarsView setSuppressLayout:]):
(-[WebDynamicScrollBarsView setScrollBarsSuppressed:repaintOnUnsuppress:]):
(-[WebDynamicScrollBarsView updateScrollers]):
(-[WebDynamicScrollBarsView reflectScrolledClipView:]):
(-[WebDynamicScrollBarsView allowsHorizontalScrolling]):
(-[WebDynamicScrollBarsView allowsVerticalScrolling]):
(-[WebDynamicScrollBarsView scrollingModes:WebCore::vertical:WebCore::]):
(-[WebDynamicScrollBarsView horizontalScrollingMode]):
(-[WebDynamicScrollBarsView verticalScrollingMode]):
(-[WebDynamicScrollBarsView setScrollingModes:vertical:andLock:]):
(-[WebDynamicScrollBarsView setHorizontalScrollingModeLocked:]):
(-[WebDynamicScrollBarsView setVerticalScrollingModeLocked:]):
(-[WebDynamicScrollBarsView setScrollingModesLocked:]):
(-[WebDynamicScrollBarsView horizontalScrollingModeLocked]):
(-[WebDynamicScrollBarsView verticalScrollingModeLocked]):
(-[WebDynamicScrollBarsView scrollWheel:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake DumpRenderTree parallelizable
ossy@webkit.org [Fri, 9 Apr 2010 11:30:23 +0000 (11:30 +0000)]
Make DumpRenderTree parallelizable
https://bugs.webkit.org/show_bug.cgi?id=36899

Reviewed by Eric Seidel.

* DumpRenderTree/mac/DumpRenderTree.mm:
(libraryPathForDumpRenderTree): Use DUMPRENDERTREE_TEMP if exist.
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::DumpRenderTree): Use DUMPRENDERTREE_TEMP if exist.
* Scripts/run-webkit-tests:
  - Create a unique temporary directory and pass its path to
  DumpRenderTree with DUMPRENDERTREE_TEMP environment variable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-09 Tasuku Suzuki <tasuku.suzuki@nokia.com>
eric@webkit.org [Fri, 9 Apr 2010 10:55:22 +0000 (10:55 +0000)]
2010-04-09  Tasuku Suzuki  <tasuku.suzuki@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Fix compile error with QT_NO_ACTION
        https://bugs.webkit.org/show_bug.cgi?id=36529

        Make sure QT_NO_ACTION is not defined to use QAction

        * Api/qgraphicswebview.cpp:
        (QGraphicsWebView::pageAction):
        * Api/qwebpage.cpp:
        (QWebPagePrivate::updateAction):
        (QWebPage::updatePositionDependentActions):
        * Api/qwebpage.h:
        * Api/qwebview.cpp:
        * Api/qwebview.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<http://webkit.org/b/37326> IDL files are being copied in to the WebCore framework...
mrowe@apple.com [Fri, 9 Apr 2010 10:53:00 +0000 (10:53 +0000)]
<webkit.org/b/37326> IDL files are being copied in to the WebCore framework again

Reviewed by Oliver Hunt.

WebCore:

* WebCore.xcodeproj/project.pbxproj: Wire up the script.  Remove the three inappropriate
files from the Copy Bundle Resources build phase.

WebKitTools:

Add a script to detect the presence of inappropriate files in the frameworks.  At present
it only looks for .css, .idl and .in files in the top level of WebCore.framework/Resources,
as these are the only cases we've encountered recently.  It can be extended to check the
other frameworks or for other inappropriate files in the future.

* Scripts/check-for-inappropriate-files-in-framework: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-09 Jochen Eisinger <jochen@chromium.org>
eric@webkit.org [Fri, 9 Apr 2010 10:46:19 +0000 (10:46 +0000)]
2010-04-09  Jochen Eisinger  <jochen@chromium.org>

        Reviewed by Adam Barth.

        Expose SecurityOrigin::canRequest in WebSecurityOrigin.
        https://bugs.webkit.org/show_bug.cgi?id=37271

        * public/WebSecurityOrigin.h:
        * src/WebSecurityOrigin.cpp:
        (WebKit::WebSecurityOrigin::canRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-09 Zhenyao Mo <zmo@google.com>
eric@webkit.org [Fri, 9 Apr 2010 10:37:19 +0000 (10:37 +0000)]
2010-04-09  Zhenyao Mo  <zmo@google.com>

        Reviewed by Darin Fisher.

        Passing null WebGLObjects should synthesize INVALID_VALUE error
        https://bugs.webkit.org/show_bug.cgi?id=37047

        * fast/canvas/webgl/error-reporting-expected.txt: Change a few errors from INVALID_OPERATION to INVALID_VALUE.
        * fast/canvas/webgl/getActiveTest-expected.txt: Ditto.
        * fast/canvas/webgl/null-object-behaviour-expected.txt: Ditto.
        * fast/canvas/webgl/script-tests/error-reporting.js: Ditto.
2010-04-09  Zhenyao Mo  <zmo@google.com>

        Reviewed by Darin Fisher.

        Passing null WebGLObjects should synthesize INVALID_VALUE error
        https://bugs.webkit.org/show_bug.cgi?id=37047

        * html/canvas/WebGLRenderingContext.cpp: Synthesize INVALID_VALUE error when input object is 0.
        (WebCore::WebGLRenderingContext::bindAttribLocation):
        (WebCore::WebGLRenderingContext::compileShader):
        (WebCore::WebGLRenderingContext::detachShader):
        (WebCore::WebGLRenderingContext::validateWebGLObject):
        (WebCore::WebGLRenderingContext::getActiveAttrib):
        (WebCore::WebGLRenderingContext::getActiveUniform):
        (WebCore::WebGLRenderingContext::getProgramParameter):
        (WebCore::WebGLRenderingContext::getProgramInfoLog):
        (WebCore::WebGLRenderingContext::getShaderParameter):
        (WebCore::WebGLRenderingContext::getShaderInfoLog):
        (WebCore::WebGLRenderingContext::getShaderSource):
        (WebCore::WebGLRenderingContext::getUniform):
        (WebCore::WebGLRenderingContext::getUniformLocation):
        (WebCore::WebGLRenderingContext::linkProgram):
        (WebCore::WebGLRenderingContext::shaderSource):
        * html/canvas/WebGLRenderingContext.h: Add helper function to validate webgl object input parameters.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] tests/qgraphicswebview fails
hausmann@webkit.org [Fri, 9 Apr 2010 10:10:05 +0000 (10:10 +0000)]
[Qt] tests/qgraphicswebview fails
https://bugs.webkit.org/show_bug.cgi?id=37317

Reviewed by Lars Knoll.

* Api/qwebpage.cpp:
(QWebPage::userAgentForUrl): Don't crash if the ownerWidget is null.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-09 Zhenyao Mo <zmo@google.com>
eric@webkit.org [Fri, 9 Apr 2010 10:06:56 +0000 (10:06 +0000)]
2010-04-09  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        Must resolve multisampled back buffer during copyTexImage2D and copyTexSubImage2D
        https://bugs.webkit.org/show_bug.cgi?id=37174

        * fast/canvas/webgl/copy-tex-image-and-sub-image-2d-expected.txt: Added.
        * fast/canvas/webgl/copy-tex-image-and-sub-image-2d.html: Added.
        * fast/canvas/webgl/resources/utils3d.js: Add ContextAttributes parameter to initWebGL function.
2010-04-09  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        Must resolve multisampled back buffer during copyTexImage2D and copyTexSubImage2D
        https://bugs.webkit.org/show_bug.cgi?id=37174

        Test: fast/canvas/webgl/copy-tex-image-and-sub-image-2d.html

        * platform/graphics/mac/GraphicsContext3DMac.cpp: resolve multisampled back buffer during copyTexImage2D and copyTexSubImage2D.
        (WebCore::GraphicsContext3D::copyTexImage2D):
        (WebCore::GraphicsContext3D::copyTexSubImage2D):
2010-04-09  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        Must resolve multisampled back buffer during copyTexImage2D and copyTexSubImage2D
        https://bugs.webkit.org/show_bug.cgi?id=37174

        Test: fast/canvas/webgl/copy-tex-image-and-sub-image-2d.html

        * src/WebGraphicsContext3DDefaultImpl.cpp: Resolve multisampled back buffer during copyTexImage2D and copyTexSubImage2D.
        (WebKit::WebGraphicsContext3DDefaultImpl::copyTexImage2D):
        (WebKit::WebGraphicsContext3DDefaultImpl::copyTexSubImage2D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-09 Evan Stade <estade@chromium.org>
eric@webkit.org [Fri, 9 Apr 2010 09:48:00 +0000 (09:48 +0000)]
2010-04-09  Evan Stade  <estade@chromium.org>

        Reviewed by Dimitri Glazkov.

        [chromium] <select> dropdowns don't die when an item is selected
        https://bugs.webkit.org/show_bug.cgi?id=37243

        * platform/chromium/PopupMenuChromium.cpp:
        (WebCore::PopupContainer::hidePopup):
        (WebCore::PopupContainer::notifyPopupHidden):
        (WebCore::PopupListBox::hidePopup): inform container that popup is closing
        * platform/chromium/PopupMenuChromium.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Fix crashes with package builds in release
hausmann@webkit.org [Fri, 9 Apr 2010 09:03:15 +0000 (09:03 +0000)]
[Qt] Fix crashes with package builds in release

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2010-04-09
Reviewed by Simon Hausmann.

.:

* WebKit.pri: Don't randomly add NDEBUG to the defines.

JavaScriptCore:

Add NDEBUG to the defines for package build in JavaScriptCore.pri,
so that it's consistently used for JavaScriptCore, WebCore, jsc and all
other tools using wtf, etc. data structures directly. Mixing NDEBUG with
non-NDEBUG builds causes crashes due to differences in data structures when
assertions/checks are enabled.

* JavaScriptCore.pri:

WebCore:

* WebCore.pro: Don't add NDEBUG to the defines here, add it from JavaScriptCore.pri

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-09 Kenneth Rohde Christiansen <kenneth@webkit.org>
eric@webkit.org [Fri, 9 Apr 2010 08:59:31 +0000 (08:59 +0000)]
2010-04-09  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Simon Fraser.

        Update test as the 'all' value has been removed

        * fast/media/media-feature-wgt-view-mode.html:
2010-04-09  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Simon Fraser.

        Remove "all" value from the view-mode media feature (as agreed on
        1-Apr-2010) in the Widgets voice conf.

        * css/CSSValueKeywords.in:
        * css/MediaQueryEvaluator.cpp:
        (WebCore::view_modeMediaFeatureEval):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-09 Patrick Gansterer <paroga@paroga.com>
eric@webkit.org [Fri, 9 Apr 2010 08:36:31 +0000 (08:36 +0000)]
2010-04-09  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Darin Adler.

        Implement NO_RETURN for COMPILER(MSVC).
        https://bugs.webkit.org/show_bug.cgi?id=33056

        Added NO_RETURN_WITH_VALUE for functions with non-void return type.

        * jsc.cpp:
        * wtf/AlwaysInline.h:
        * wtf/FastMalloc.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-09 Sheriff Bot <webkit.review.bot@gmail.com>
eric@webkit.org [Fri, 9 Apr 2010 08:15:04 +0000 (08:15 +0000)]
2010-04-09  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r57286.
        http://trac.webkit.org/changeset/57286
        https://bugs.webkit.org/show_bug.cgi?id=37312

        "Caused intermittent test failures on all Mac bots."
        (Requested by eseidel on #webkit).

        * storage/DatabaseTracker.cpp:
        (WebCore::DatabaseTracker::originQuotaManagerNoLock):
        (WebCore::DatabaseTracker::originQuotaManager):
        (WebCore::DatabaseTracker::DatabaseTracker):
        (WebCore::DatabaseTracker::canEstablishDatabase):
        (WebCore::DatabaseTracker::hasEntryForOrigin):
        (WebCore::DatabaseTracker::getMaxSizeForDatabase):
        (WebCore::DatabaseTracker::fullPathForDatabaseNoLock):
        (WebCore::DatabaseTracker::fullPathForDatabase):
        (WebCore::DatabaseTracker::populateOrigins):
        (WebCore::DatabaseTracker::origins):
        (WebCore::DatabaseTracker::databaseNamesForOrigin):
        (WebCore::DatabaseTracker::addOpenDatabase):
        (WebCore::DatabaseTracker::removeOpenDatabase):
        (WebCore::DatabaseTracker::usageForOriginNoLock):
        (WebCore::DatabaseTracker::usageForOrigin):
        (WebCore::DatabaseTracker::quotaForOrigin):
        (WebCore::DatabaseTracker::setQuota):
        (WebCore::DatabaseTracker::deleteOrigin):
        (WebCore::DatabaseTracker::deleteDatabase):
        (WebCore::DatabaseTracker::deleteDatabaseFile):
        * storage/DatabaseTracker.h:
        * storage/SQLTransactionClient.cpp:
        (WebCore::SQLTransactionClient::didExecuteStatement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] User agent style sheets are crippled by moc -E in make-css-file-arrays.pl
abecsi@webkit.org [Fri, 9 Apr 2010 07:59:04 +0000 (07:59 +0000)]
[Qt] User agent style sheets are crippled by moc -E in make-css-file-arrays.pl
https://bugs.webkit.org/show_bug.cgi?id=37296

Reviewed by Simon Hausmann.
Patch by Andras Becsi <abecsi@inf.u-szeged.hu>

WebCore:

Do not use moc to preprocess user agent style sheets because it removes at-symbols
and hexadecimal colours from declarations.
Remove unneeded preprocessor usage from make-css-file-arrays.pl since the script
processes default css files using regular expressions therefore preprocessing is redundant.

* WebCore.pri: remove --preprocessor usage
* css/make-css-file-arrays.pl: remove gcc dependency

LayoutTests:

Update expected files after removal of moc preprocessing of default css sheets.
These test results now only differ in metrics from Mac ones.

* platform/qt/editing/execCommand/insert-list-xml-expected.txt:
* platform/qt/svg/custom/createImageElement2-expected.txt:
* platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoVersioning.
mrowe@apple.com [Fri, 9 Apr 2010 07:35:22 +0000 (07:35 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-08 Chris Evans <cevans@chromium.org>
abarth@webkit.org [Fri, 9 Apr 2010 06:43:19 +0000 (06:43 +0000)]
2010-04-08  Chris Evans  <cevans@chromium.org>

        Reviewed by Sam Weinig.

        Add test for POST & _blank popup blocker bypass.
        https://bugs.webkit.org/show_bug.cgi?id=34541

        * fast/events/popup-blocked-to-post-blank.html: added
        * fast/events/popup-blocked-to-post-blank-expected.txt: added
2010-04-08  Chris Evans  <cevans@chromium.org>

        Reviewed by Sam Weinig.

        Use the new UserGestureIndictor for _blank POST requests.

        https://bugs.webkit.org/show_bug.cgi?id=34541

        Test: fast/events/popup-blocked-to-post-blank.html

        * bindings/v8/ScriptController.cpp:
        (WebCore::ScriptController::processingUserGesture):
          Use UserGestureIndicator in more cases.
        * page/EventHandler.cpp:
        (WebCore::EventHandler):
          Impact from UserGestureIndicator API change.
        (WebCore::FrameLoader::submitForm):
          Block the load immediately if popups are not allowed and it would
          open a new window.
        * loader/RedirectScheduler.cpp:
        (WebCore::ScheduledFormSubmission::ScheduledFormSubmission):
          Note the UserGestureIndicator status at the time of submission.
        (WebCore::ScheduledFormSubmission::fire):
          Use the stored UserGestureIndicator status in the asynchronous
          callback.
        * dom/UserGestureIndicator.h:
        * dom/UserGestureIndicator.cpp:
        (WebCore::UserGestureIndicator::UserGestureIndicator):
          Add ability to store a negative indication.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd option to build WebKit2 to build-webkit.
weinig@apple.com [Fri, 9 Apr 2010 01:14:59 +0000 (01:14 +0000)]
Add option to build WebKit2 to build-webkit.

Reviewed by Darin Adler.

* Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd build support for WebKit2.
weinig@apple.com [Fri, 9 Apr 2010 00:52:48 +0000 (00:52 +0000)]
Add build support for WebKit2.

Reviewed by Anders Carlsson.

* Configurations: Added.
* Configurations/Base.xcconfig: Added.
* Configurations/DebugRelease.xcconfig: Added.
* Configurations/FeatureDefines.xcconfig: Added.
* Configurations/Version.xcconfig: Added.
* Configurations/WebKit2.xcconfig: Added.
* English.lproj: Added.
* English.lproj/InfoPlist.strings: Added.
* Info.plist: Added.
* Makefile: Added.
* WebKit2.xcodeproj: Added.
* WebKit2.xcodeproj/project.pbxproj: Added.
* WebKit2Prefix.cpp: Added.
* WebKit2Prefix.h: Added.
* WebKit2_Prefix.pch: Added.
* WebProcess-Info.plist: Added.
* version.plist: Added.
* win: Added.
* win/WebKit2.def: Added.
* win/WebKit2.vcproj: Added.
* win/WebKit2Generated.make: Added.
* win/WebKit2Generated.vcproj: Added.
* win/WebKit2WebProcess.vcproj: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd WebKit2/UIProcess directory.
weinig@apple.com [Fri, 9 Apr 2010 00:50:10 +0000 (00:50 +0000)]
Add WebKit2/UIProcess directory.

Patch by Anders Carlsson <andersca@apple.com> on 2010-04-08
Reviewed by Sam Weinig.

* UIProcess: Added.
* UIProcess/API: Added.
* UIProcess/API/C: Added.
* UIProcess/API/C/WKAPICast.h: Added.
* UIProcess/API/C/WKBase.h: Added.
* UIProcess/API/C/WKContext.cpp: Added.
* UIProcess/API/C/WKContext.h: Added.
* UIProcess/API/C/WKFrame.cpp: Added.
* UIProcess/API/C/WKFrame.h: Added.
* UIProcess/API/C/WKFramePolicyListener.cpp: Added.
* UIProcess/API/C/WKFramePolicyListener.h: Added.
* UIProcess/API/C/WKPage.cpp: Added.
* UIProcess/API/C/WKPage.h: Added.
* UIProcess/API/C/WKPageNamespace.cpp: Added.
* UIProcess/API/C/WKPageNamespace.h: Added.
* UIProcess/API/C/WKPreferences.cpp: Added.
* UIProcess/API/C/WKPreferences.h: Added.
* UIProcess/API/C/WebKit2.h: Added.
* UIProcess/API/mac: Added.
* UIProcess/API/mac/PageClientImpl.h: Added.
* UIProcess/API/mac/PageClientImpl.mm: Added.
* UIProcess/API/mac/WKView.h: Added.
* UIProcess/API/mac/WKView.mm: Added.
* UIProcess/API/mac/WKViewInternal.h: Added.
* UIProcess/API/win: Added.
* UIProcess/API/win/WKAPICastWin.h: Added.
* UIProcess/API/win/WKBaseWin.h: Added.
* UIProcess/API/win/WKView.cpp: Added.
* UIProcess/API/win/WKView.h: Added.
* UIProcess/Launcher: Added.
* UIProcess/Launcher/WebProcessLauncher.h: Added.
* UIProcess/Launcher/mac: Added.
* UIProcess/Launcher/mac/WebProcessLauncher.mm: Added.
* UIProcess/Launcher/win: Added.
* UIProcess/Launcher/win/WebProcessLauncher.cpp: Added.
* UIProcess/PageClient.h: Added.
* UIProcess/ProcessModel.h: Added.
* UIProcess/ResponsivenessTimer.cpp: Added.
* UIProcess/ResponsivenessTimer.h: Added.
* UIProcess/ScriptReturnValueCallback.cpp: Added.
* UIProcess/ScriptReturnValueCallback.h: Added.
* UIProcess/WebContext.cpp: Added.
* UIProcess/WebContext.h: Added.
* UIProcess/WebFramePolicyListenerProxy.cpp: Added.
* UIProcess/WebFramePolicyListenerProxy.h: Added.
* UIProcess/WebFrameProxy.cpp: Added.
* UIProcess/WebFrameProxy.h: Added.
* UIProcess/WebLoaderClient.cpp: Added.
* UIProcess/WebLoaderClient.h: Added.
* UIProcess/WebPageNamespace.cpp: Added.
* UIProcess/WebPageNamespace.h: Added.
* UIProcess/WebPageProxy.cpp: Added.
* UIProcess/WebPageProxy.h: Added.
* UIProcess/WebPolicyClient.cpp: Added.
* UIProcess/WebPolicyClient.h: Added.
* UIProcess/WebPreferences.cpp: Added.
* UIProcess/WebPreferences.h: Added.
* UIProcess/WebProcessManager.cpp: Added.
* UIProcess/WebProcessManager.h: Added.
* UIProcess/WebProcessProxy.cpp: Added.
* UIProcess/WebProcessProxy.h: Added.
* UIProcess/WebUIClient.cpp: Added.
* UIProcess/WebUIClient.h: Added.
* UIProcess/mac: Added.
* UIProcess/mac/DrawingAreaProxy.h: Added.
* UIProcess/mac/DrawingAreaProxy.mm: Added.
* UIProcess/mac/DrawingAreaProxyUpdateChunk.h: Added.
* UIProcess/mac/DrawingAreaProxyUpdateChunk.mm: Added.
* UIProcess/win: Added.
* UIProcess/win/DrawingAreaProxy.cpp: Added.
* UIProcess/win/DrawingAreaProxy.h: Added.
* UIProcess/win/WebView.cpp: Added.
* UIProcess/win/WebView.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd WebKit2/WebProcess directory.
weinig@apple.com [Fri, 9 Apr 2010 00:49:12 +0000 (00:49 +0000)]
Add WebKit2/WebProcess directory.

Patch by Anders Carlsson <andersca@apple.com> on 2010-04-08
Reviewed by Sam Weinig and Oliver Hunt.

* WebProcess: Added.
* WebProcess/Launching: Added.
* WebProcess/Launching/mac: Added.
* WebProcess/Launching/mac/WebProcessMain.mm: Added.
* WebProcess/Launching/win: Added.
* WebProcess/Launching/win/WebProcessWinMain.cpp: Added.
* WebProcess/WebCoreSupport: Added.
* WebProcess/WebCoreSupport/WebChromeClient.cpp: Added.
* WebProcess/WebCoreSupport/WebChromeClient.h: Added.
* WebProcess/WebCoreSupport/WebContextMenuClient.cpp: Added.
* WebProcess/WebCoreSupport/WebContextMenuClient.h: Added.
* WebProcess/WebCoreSupport/WebDragClient.cpp: Added.
* WebProcess/WebCoreSupport/WebDragClient.h: Added.
* WebProcess/WebCoreSupport/WebEditorClient.cpp: Added.
* WebProcess/WebCoreSupport/WebEditorClient.h: Added.
* WebProcess/WebCoreSupport/WebErrors.h: Added.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: Added.
* WebProcess/WebCoreSupport/WebInspectorClient.h: Added.
* WebProcess/WebCoreSupport/mac: Added.
* WebProcess/WebCoreSupport/mac/WebErrorsMac.mm: Added.
* WebProcess/WebCoreSupport/mac/WebSystemInterface.h: Added.
* WebProcess/WebCoreSupport/mac/WebSystemInterface.m: Added.
* WebProcess/WebCoreSupport/win: Added.
* WebProcess/WebCoreSupport/win/WebCoreLocalizedStrings.cpp: Added.
* WebProcess/WebCoreSupport/win/WebErrorsWin.cpp: Added.
* WebProcess/WebPage: Added.
* WebProcess/WebPage/DrawingArea.cpp: Added.
* WebProcess/WebPage/DrawingArea.h: Added.
* WebProcess/WebPage/WebFrame.cpp: Added.
* WebProcess/WebPage/WebFrame.h: Added.
* WebProcess/WebPage/WebPage.cpp: Added.
* WebProcess/WebPage/WebPage.h: Added.
* WebProcess/WebPage/mac: Added.
* WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp: Added.
* WebProcess/WebPage/mac/DrawingAreaUpdateChunk.h: Added.
* WebProcess/WebPage/mac/WebPageMac.mm: Added.
* WebProcess/WebPage/win: Added.
* WebProcess/WebPage/win/DrawingAreaUpdateChunk.cpp: Added.
* WebProcess/WebPage/win/DrawingAreaUpdateChunk.h: Added.
* WebProcess/WebPage/win/WebPageWin.cpp: Added.
* WebProcess/WebProcess.cpp: Added.
* WebProcess/WebProcess.h: Added.
* WebProcess/win: Added.
* WebProcess/win/DllMain.cpp: Added.
* WebProcess/win/WebLocalizableStrings.cpp: Added.
* WebProcess/win/WebLocalizableStrings.h: Added.
* WebProcess/win/WebProcessMain.cpp: Added.
* WebProcess/win/WebProcessMain.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd WebKit2/Shared directory.
weinig@apple.com [Fri, 9 Apr 2010 00:47:36 +0000 (00:47 +0000)]
Add WebKit2/Shared directory.

Reviewed by Anders Carlsson.

* Shared: Added.
* Shared/CoreIPCSupport: Added.
* Shared/CoreIPCSupport/DrawingAreaMessageKinds.h: Added.
* Shared/CoreIPCSupport/DrawingAreaProxyMessageKinds.h: Added.
* Shared/CoreIPCSupport/WebPageMessageKinds.h: Added.
* Shared/CoreIPCSupport/WebPageProxyMessageKinds.h: Added.
* Shared/CoreIPCSupport/WebProcessMessageKinds.h: Added.
* Shared/NotImplemented.h: Added.
* Shared/WebCoreTypeArgumentMarshalling.h: Added.
* Shared/WebEvent.h: Added.
* Shared/WebEventConversion.cpp: Added.
* Shared/WebEventConversion.h: Added.
* Shared/WebPreferencesStore.cpp: Added.
* Shared/WebPreferencesStore.h: Added.
* Shared/mac: Added.
* Shared/mac/UpdateChunk.cpp: Added.
* Shared/mac/UpdateChunk.h: Added.
* Shared/mac/WebEventFactory.h: Added.
* Shared/mac/WebEventFactory.mm: Added.
* Shared/win: Added.
* Shared/win/UpdateChunk.cpp: Added.
* Shared/win/UpdateChunk.h: Added.
* Shared/win/WebEventFactory.cpp: Added.
* Shared/win/WebEventFactory.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd WebKit2/Platform directory.
weinig@apple.com [Fri, 9 Apr 2010 00:46:22 +0000 (00:46 +0000)]
Add WebKit2/Platform directory.

Reviewed by Anders Carlsson.

* Platform: Added.
* Platform/CoreIPC: Added.
* Platform/CoreIPC/ArgumentDecoder.cpp: Added.
* Platform/CoreIPC/ArgumentDecoder.h: Added.
* Platform/CoreIPC/ArgumentEncoder.cpp: Added.
* Platform/CoreIPC/ArgumentEncoder.h: Added.
* Platform/CoreIPC/Arguments.h: Added.
* Platform/CoreIPC/Attachment.cpp: Added.
* Platform/CoreIPC/Attachment.h: Added.
* Platform/CoreIPC/Connection.cpp: Added.
* Platform/CoreIPC/Connection.h: Added.
* Platform/CoreIPC/MessageID.h: Added.
* Platform/CoreIPC/mac: Added.
* Platform/CoreIPC/mac/ConnectionMac.cpp: Added.
* Platform/CoreIPC/mac/MachPort.h: Added.
* Platform/CoreIPC/win: Added.
* Platform/CoreIPC/win/ConnectionWin.cpp: Added.
* Platform/PlatformProcessIdentifier.h: Added.
* Platform/RunLoop.cpp: Added.
* Platform/RunLoop.h: Added.
* Platform/WorkItem.h: Added.
* Platform/WorkQueue.cpp: Added.
* Platform/WorkQueue.h: Added.
* Platform/mac: Added.
* Platform/mac/RunLoopMac.mm: Added.
* Platform/mac/WorkQueueMac.cpp: Added.
* Platform/win: Added.
* Platform/win/RunLoopWin.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agorun-webkit-tests should respect argument order
darin@apple.com [Fri, 9 Apr 2010 00:37:25 +0000 (00:37 +0000)]
run-webkit-tests should respect argument order
https://bugs.webkit.org/show_bug.cgi?id=37257

Reviewed by Alexey Proskuryakov.

* Scripts/run-webkit-tests: Changed so that sorting is done only
on the results of iterating directories. Test order is based on
what's passed on the command line. Removed code that aimed to
eliminate duplicates since it can be useful to run the same test
more than once.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-08 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 8 Apr 2010 23:31:58 +0000 (23:31 +0000)]
2010-04-08  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        [Chromium] Mark failing tests after r57292
        https://bugs.webkit.org/show_bug.cgi?id=37298

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSpatial Navigation: proper handle negative x or y coordinates https://bugs.webkit...
tonikitoo@webkit.org [Thu, 8 Apr 2010 23:24:26 +0000 (23:24 +0000)]
Spatial Navigation: proper handle negative x or y coordinates https://bugs.webkit.org/show_bug.cgi?id=36773

Reviewed by Simon Fraser.
Patch by Antonio Gomes <tonikitoo@webkit.org>

WebCore:

In Spatial Navigation logic, during rect acquisition in renderRectRelativeToRootDocument,
sometimes negative x() or y() values are got, and the current algorithm bails out in
any of such cases.

However, when a node is in a scrollable content (content overflow <div>) and
this scrollable container scrolled up, element gets offscreen, and gets negative values
for y(), for example. In such cases, they are still valid to be used in Spatial Navigation
logic.

Test: fast/events/spatial-navigation/snav-offscreen-content.html

* page/SpatialNavigation.cpp:
(WebCore::distanceDataForNode):
(WebCore::checkNegativeCoordsForNode):

LayoutTests:

* fast/events/spatial-navigation/snav-offscreen-content-expected.txt: Added.
* fast/events/spatial-navigation/snav-offscreen-content.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] r57274 removed fast/forms/willvalidate-000.html,
ossy@webkit.org [Thu, 8 Apr 2010 23:07:24 +0000 (23:07 +0000)]
[Qt] r57274 removed fast/forms/willvalidate-000.html,
so it should be removed from Skipped list too.

* platform/qt/Skipped: fast/forms/willvalidate-000.html removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebView::isLoading should null check m_mainFrame
sfalken@apple.com [Thu, 8 Apr 2010 22:59:56 +0000 (22:59 +0000)]
WebView::isLoading should null check m_mainFrame
https://bugs.webkit.org/show_bug.cgi?id=37294

Reviewed by Darin Adler.

* WebView.cpp:
(WebView::isLoading):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Create the creation callback is the current world.
dumi@chromium.org [Thu, 8 Apr 2010 22:55:12 +0000 (22:55 +0000)]
WebCore: Create the creation callback is the current world.
https://bugs.webkit.org/show_bug.cgi?id=37290

Reviewed by Geoffrey Garen.

* bindings/js/JSDatabaseCallback.cpp:
(WebCore::JSDatabaseCallback::JSDatabaseCallback):

LayoutTests: Test that the creation callback is executed in the world where it
was created.
https://bugs.webkit.org/show_bug.cgi?id=37290

Reviewed by Geoffrey Garen.

* storage/open-database-creation-callback-isolated-world-expected.txt:
* storage/open-database-creation-callback-isolated-world.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Skip new tests introduced in r57292, because of unimplemented
ossy@webkit.org [Thu, 8 Apr 2010 22:39:48 +0000 (22:39 +0000)]
[Qt] Skip new tests introduced in r57292, because of unimplemented
layoutTestController.computedStyleIncludingVisitedInfo()

* platform/qt/Skipped:
 - fast/history/nested-visited-test.html skipped.
 - fast/history/self-is-visited.html skipped.
 - fast/history/sibling-visited-test.html skipped.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFollowup optimization to bug 24300, don't leak history info via CSS :visited. If...
hyatt@apple.com [Thu, 8 Apr 2010 22:37:37 +0000 (22:37 +0000)]
Followup optimization to bug 24300, don't leak history info via CSS :visited.  If a Web
site uses document colors that are the same for link and vlink in HTML and also doesn't
specify any :link or :visited rules, then don't waste time resolving visited styles.

Reviewed by Oliver Hunt.

There is a further optimization that could be done to detect when :link and :visited are
used together in the same rule to specify a color, and this is how most sites turn off
visited link colors, but this fix doesn't address that.  It just restores the optimization
that existed prior to the patch in 24300 landing.

* css/CSSGrammar.y:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::styleForElement):
* dom/Document.cpp:
(WebCore::Document::Document):
* dom/Document.h:
(WebCore::Document::usesLinkRules):
(WebCore::Document::setUsesLinkRules):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-08 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Thu, 8 Apr 2010 22:18:52 +0000 (22:18 +0000)]
2010-04-08  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Darin Adler.

        Another trial

        Tests that should have been landed as part of the earlier patch for Bug 36276.
        https://bugs.webkit.org/show_bug.cgi?id=36276

        * fast/css/invalid-not-with-simple-selector-sequence-expected.txt: Added.
        * fast/css/invalid-not-with-simple-selector-sequence.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCaught by pixel tests. I missed patching the borderRightColor() call for fieldset...
hyatt@apple.com [Thu, 8 Apr 2010 22:17:48 +0000 (22:17 +0000)]
Caught by pixel tests.  I missed patching the borderRightColor() call for fieldset border painting so the
border stopped showing up.

Reviewed by Oliver Hunt.

* rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::paintBorderMinusLegend):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Mark Rowe.
weinig@apple.com [Thu, 8 Apr 2010 22:09:23 +0000 (22:09 +0000)]
Rubber-stamped by Mark Rowe.

Add WebKit2 directory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-08 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Thu, 8 Apr 2010 22:05:49 +0000 (22:05 +0000)]
2010-04-08  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Darin Adler.

        Tests that should have been landed as part of the earlier patch for Bug 36276.
        https://bugs.webkit.org/show_bug.cgi?id=36276

        * fast/css/invalid-not-with-simple-selector-sequence-expected.txt: Added.
        * fast/css/invalid-not-with-simple-selector-sequence.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix Qt build.
hyatt@apple.com [Thu, 8 Apr 2010 22:02:09 +0000 (22:02 +0000)]
Fix Qt build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-08 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 8 Apr 2010 21:48:52 +0000 (21:48 +0000)]
2010-04-08  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Dimitri Glazkov.

        [chromium] Many new test results are needed due to recent check-ins.
        https://bugs.webkit.org/show_bug.cgi?id=36799

        I missed the linux-only results in http://trac.webkit.org/changeset/57291

        * platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.checksum:
        * platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.png: Removed.
        * platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.checksum:
        * platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.png:
        * platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-group-expected.checksum:
        * platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
        * platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-group-expected.checksum:
        * platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
        * platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.checksum:
        * platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png:
        * platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.checksum:
        * platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
        * platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.checksum:
        * platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
        * platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.checksum:
        * platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
        * platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.checksum:
        * platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
        * platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.checksum:
        * platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
        * platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.checksum:
        * platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: https://bugs.webkit.org/show_bug.cgi?id=24300, don't leak history info via...
hyatt@apple.com [Thu, 8 Apr 2010 21:29:39 +0000 (21:29 +0000)]
WebCore: https://bugs.webkit.org/show_bug.cgi?id=24300, don't leak history info via CSS :visited.

Reviewed by Oliver Hunt.

This patch implements the policy described by David Baron here:

http://dbaron.org/mozilla/visited-privacy

Added new tests in fast/history.

* WebCore.base.exp:
Expose functions needed for the WebKit SPI used by layout tests.

* WebCore.xcodeproj/project.pbxproj:
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isVisited):
Make sure accessibility objects still return visited information.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::CSSComputedStyleDeclaration):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSComputedStyleDeclaration.h:
(WebCore::computedStyle):
Add a boolean to computed style declarations that - if set - causes the computed style
to still return :visited information.  For normal Web pages, this will be false.  It is set
to true for the Web Inspector and by the WebKit SPI used by the layout tests.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::initElement):
(WebCore::CSSStyleSelector::SelectorChecker::SelectorChecker):
(WebCore::CSSStyleSelector::SelectorChecker::determineLinkState):
(WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::keyframeStylesForAnimation):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::CSSStyleSelector::pseudoStyleRulesForElement):
(WebCore::CSSStyleSelector::checkSelector):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
(WebCore::CSSStyleSelector::applyPropertyToStyle):
(WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
* css/CSSStyleSelector.h:
Rework the style selector to resolve two styles instead of one.  The first forces the link to
be unvisited, and the second forces the link to be visited.  The real state of the link is
cached on the principal (unvisited) style.  The visited style hangs off the principal style
as a pseudo style (VISITED_LINK).

* dom/Element.cpp:
(WebCore::Element::pseudoStyleCacheIsInvalid):
Make sure to deal with the VISITED_LINK pseudo to know when only :visited style info changed.

* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::getStyles):
Let the Web Inspector see :visited computed styles by default.

* platform/LinkHash.cpp:
(WebCore::visitedURL):
Fix an issue where <a href=""> is not hashed properly to the document's base URI, so it wasn't
correctly reported as :visited.

* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintTextDecorations):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintSelection):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::paintObject):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBorder):
* rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::paintBorderMinusLegend):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::paintFocusRings):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::paintOutline):
(WebCore::RenderInline::paintOutlineForLine):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::drawLineForBoxSide):
(WebCore::RenderObject::drawArcForBoxSide):
(WebCore::RenderObject::paintOutline):
(WebCore::decorationColor):
(WebCore::RenderObject::getTextDecorationColors):
* rendering/RenderObject.h:
* rendering/RenderPath.cpp:
(WebCore::RenderPath::paint):
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::paint):
* rendering/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::paint):
* rendering/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::paint):
* rendering/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::paint):
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::collapsedLeftBorder):
(WebCore::RenderTableCell::collapsedRightBorder):
(WebCore::RenderTableCell::collapsedTopBorder):
(WebCore::RenderTableCell::collapsedBottomBorder):
(WebCore::RenderTableCell::paintCollapsedBorder):
* rendering/style/CollapsedBorderValue.h:
(WebCore::CollapsedBorderValue::CollapsedBorderValue):
(WebCore::CollapsedBorderValue::color):
(WebCore::CollapsedBorderValue::operator==):
Patch painting code to fetch visitedDependentColors from the RenderStyle.  Properties that
are honored include background-color, color, border colors, outline color, column rules,
and fill and stroke (both SVG and our custom versions).

* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::RenderStyle):
(WebCore::RenderStyle::diff):
(WebCore::borderStyleForColorProperty):
(WebCore::colorIncludingFallback):
(WebCore::RenderStyle::visitedDependentColor):
* rendering/style/RenderStyle.h:
(WebCore::):
(WebCore::InheritedFlags::NonInheritedFlags::operator==):
(WebCore::InheritedFlags::setBitDefaults):
(WebCore::InheritedFlags::insideLink):
(WebCore::InheritedFlags::isLink):
(WebCore::InheritedFlags::setInsideLink):
(WebCore::InheritedFlags::setIsLink):
* rendering/style/RenderStyleConstants.h:
Change how link information is stored.  The noninherited flags now have a bit set for if you're a link
or not.  The inherited flags now cache whether you're inside a visited or unvisited link (or no link at
all).

(WebCore::):
* svg/graphics/SVGPaintServer.cpp:
(WebCore::SVGPaintServer::fillPaintServer):
(WebCore::SVGPaintServer::strokePaintServer):
Patch SVG fill/stroke painting to honor :visited.

WebKit/mac: https://bugs.webkit.org/show_bug.cgi?id=24300, don't expose history info via CSS

Reviewed by Oliver Hunt.

Add SPI so that layout tests can access computed style including :visited information.

* WebView/WebRenderNode.mm:
(copyRenderNode):
* WebView/WebView.mm:
(-[WebView _computedStyleIncludingVisitedInfo:forElement:]):
* WebView/WebViewInternal.h:
* WebView/WebViewPrivate.h:

WebKitTools: https://bugs.webkit.org/show_bug.cgi?id=24300, don't expose history info via CSS.  Add a new method for
obtaining computed style with :visited info included.  This allows layout tests to actually tell that
:visited is in effect.

Reviewed by Oliver Hunt.

* DumpRenderTree/LayoutTestController.cpp:
(computedStyleIncludingVisitedInfoCallback):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::computedStyleIncludingVisitedInfo):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=24300, don't expose history info via CSS

Reviewed by Oliver Hunt.

* fast/history/clicked-link-is-visited.html: Removed.
* fast/history/nested-visited-test-expected.txt: Added.
* fast/history/nested-visited-test.html: Added.
* fast/history/resources/dummy.html: Added.
* fast/history/self-is-visited-expected.txt: Added.
* fast/history/self-is-visited.html: Added.
* fast/history/sibling-visited-test-expected.txt: Added.
* fast/history/sibling-visited-test.html: Added.
* fast/history/subframe-is-visited-expected.txt: Removed.
* fast/history/subframe-is-visited.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-08 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 8 Apr 2010 21:09:28 +0000 (21:09 +0000)]
2010-04-08  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Daniel Bates.

        [chromium] Many new test results are needed due to recent check-ins.
        https://bugs.webkit.org/show_bug.cgi?id=36799

        Adds new results for all the tests that started failing after http://trac.webkit.org/changeset/57287.

        * platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.checksum: Removed.
        * platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.png: Removed.
        * platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.checksum: Removed.
        * platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.png: Removed.
        * platform/chromium-win/tables/mozilla/bugs/bug1296-expected.checksum:
        * platform/chromium-win/tables/mozilla/bugs/bug1296-expected.png:
        * platform/chromium-win/tables/mozilla/bugs/bug1430-expected.checksum:
        * platform/chromium-win/tables/mozilla/bugs/bug1430-expected.png:
        * platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-expected.checksum:
        * platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
        * platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-group-expected.checksum:
        * platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
        * platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-expected.checksum:
        * platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
        * platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-group-expected.checksum:
        * platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
        * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.checksum:
        * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png:
        * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.checksum:
        * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
        * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.checksum:
        * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
        * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.checksum:
        * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
        * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.checksum:
        * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
        * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.checksum:
        * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
        * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.checksum:
        * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
        * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.checksum:
        * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
        * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.checksum:
        * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
        * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.checksum:
        * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-07 Laszlo Gombos <laszlo.1.gombos@nokia.com>
dpranke@chromium.org [Thu, 8 Apr 2010 20:47:06 +0000 (20:47 +0000)]
2010-04-07  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Fix trunk (non-standalone) builds for Symbian
        https://bugs.webkit.org/show_bug.cgi?id=37136

        Test for source files before building instead of relying on
        standalone_package config.

        * WebKit.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-08 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Thu, 8 Apr 2010 19:46:19 +0000 (19:46 +0000)]
2010-04-08  Daniel Bates  <dbates@rim.com>

        No review, rolling out 56717.
        http://trac.webkit.org/changeset/56717
        https://bugs.webkit.org/show_bug.cgi?id=9268

        Rolling out the change committed in change set 56717
        since we rolled out the change committed in change set 56655,
        <http://trac.webkit.org/changeset/56655> (in change set 57287,
        <http://trac.webkit.org/changeset/57287>). The change committed
        in change set 56655 caused a layout test regression of the some
        of the mozilla- and mozilla expected failure- tests. See bug #9268
        for more details.

        * platform/qt/fast/table/table-background-expected.checksum: Removed.
        * platform/qt/fast/table/table-background-expected.png: Removed.
        * platform/qt/fast/table/table-background-expected.txt: Removed.
        * platform/qt/fast/table/table-cell-border-draws-on-top-of-col-background-expected.checksum: Removed.
        * platform/qt/fast/table/table-cell-border-draws-on-top-of-col-background-expected.png: Removed.
        * platform/qt/fast/table/table-cell-border-draws-on-top-of-col-background-expected.txt: Removed.
        * platform/qt/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.checksum: Removed.
        * platform/qt/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.png: Removed.
        * platform/qt/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.txt: Removed.
        * platform/qt/fast/table/table-cell-border-draws-on-top-of-row-background-expected.checksum: Removed.
        * platform/qt/fast/table/table-cell-border-draws-on-top-of-row-background-expected.png: Removed.
        * platform/qt/fast/table/table-cell-border-draws-on-top-of-row-background-expected.txt: Removed.
        * platform/qt/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.checksum: Removed.
        * platform/qt/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.png: Removed.
        * platform/qt/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.txt: Removed.
        * platform/qt/fast/table/table-cell-overrides-row-background-expected.checksum: Removed.
        * platform/qt/fast/table/table-cell-overrides-row-background-expected.png: Removed.
        * platform/qt/fast/table/table-cell-overrides-row-background-expected.txt: Removed.
        * platform/qt/fast/table/table-col-background-expected.checksum: Removed.
        * platform/qt/fast/table/table-col-background-expected.png: Removed.
        * platform/qt/fast/table/table-col-background-expected.txt: Removed.
        * platform/qt/fast/table/table-col-group-background-expected.checksum: Removed.
        * platform/qt/fast/table/table-col-group-background-expected.png: Removed.
        * platform/qt/fast/table/table-col-group-background-expected.txt: Removed.
        * platform/qt/fast/table/table-col-group-col-span-background-expected.checksum: Removed.
        * platform/qt/fast/table/table-col-group-col-span-background-expected.png: Removed.
        * platform/qt/fast/table/table-col-group-col-span-background-expected.txt: Removed.
        * platform/qt/fast/table/table-col-group-span-background-expected.checksum: Removed.
        * platform/qt/fast/table/table-col-group-span-background-expected.png: Removed.
        * platform/qt/fast/table/table-col-group-span-background-expected.txt: Removed.
        * platform/qt/fast/table/table-col-span-background-expected.checksum: Removed.
        * platform/qt/fast/table/table-col-span-background-expected.png: Removed.
        * platform/qt/fast/table/table-col-span-background-expected.txt: Removed.
        * platform/qt/fast/table/table-row-background-expected.checksum: Removed.
        * platform/qt/fast/table/table-row-background-expected.png: Removed.
        * platform/qt/fast/table/table-row-background-expected.txt: Removed.
        * platform/qt/fast/table/table-row-background-left-50px-expected.checksum: Removed.
        * platform/qt/fast/table/table-row-background-left-50px-expected.png: Removed.
        * platform/qt/fast/table/table-row-background-left-50px-expected.txt: Removed.
        * platform/qt/fast/table/table-row-background-right-100percent-expected.checksum: Removed.
        * platform/qt/fast/table/table-row-background-right-100percent-expected.png: Removed.
        * platform/qt/fast/table/table-row-background-right-100percent-expected.txt: Removed.
        * platform/qt/fast/table/table-row-background-right-50px-expected.checksum: Removed.
        * platform/qt/fast/table/table-row-background-right-50px-expected.png: Removed.
        * platform/qt/fast/table/table-row-background-right-50px-expected.txt: Removed.
        * platform/qt/fast/table/table-row-group-background-expected.checksum: Removed.
        * platform/qt/fast/table/table-row-group-background-expected.png: Removed.
        * platform/qt/fast/table/table-row-group-background-expected.txt: Removed.
        * platform/qt/fast/table/table-row-group-background-positioned-expected.checksum: Removed.
        * platform/qt/fast/table/table-row-group-background-positioned-expected.png: Removed.
        * platform/qt/fast/table/table-row-group-background-positioned-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-08 Benjamin Otte <otte@gnome.org>
otte@webkit.org [Thu, 8 Apr 2010 19:42:55 +0000 (19:42 +0000)]
2010-04-08  Benjamin Otte  <otte@gnome.org>

        Reviewed by Gustavo Noronha.

        Fix build with MathML enabled.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-08 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Thu, 8 Apr 2010 19:21:13 +0000 (19:21 +0000)]
2010-04-08  Daniel Bates  <dbates@rim.com>

        No review, rolling out 56655.
        http://trac.webkit.org/changeset/56655
        https://bugs.webkit.org/show_bug.cgi?id=9268

        Rolling out the change committed in change set 56655
        because it caused a regression in some of the mozilla
        and mozilla expected failure test cases, such as:
        tables/mozilla/marvin/backgr_simple-table-row.html, and
        tables/mozilla/marvin/backgr_simple-table-row-group.html.

        We need to look into this issue some more.

        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintFillLayerExtended):
        (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
        * rendering/RenderBoxModelObject.h:
        * rendering/RenderObject.h:
        * rendering/RenderTableCell.cpp:
        * rendering/RenderTableCell.h:

2010-04-08  Daniel Bates  <dbates@rim.com>

        No review, rolling out 56655.
        http://trac.webkit.org/changeset/56655
        https://bugs.webkit.org/show_bug.cgi?id=9268

        Rolling out the change committed in change set 56655
        because it caused a regression in some of the mozilla
        and mozilla expected failure test cases, such as:
        tables/mozilla/marvin/backgr_simple-table-row.html, and
        tables/mozilla/marvin/backgr_simple-table-row-group.html.

        We need to look into this issue some more.

        * fast/table/table-background.html: Removed.
        * fast/table/table-cell-border-draws-on-top-of-col-background.html: Removed.
        * fast/table/table-cell-border-draws-on-top-of-col-group-background.html: Removed.
        * fast/table/table-cell-border-draws-on-top-of-row-background.html: Removed.
        * fast/table/table-cell-border-draws-on-top-of-row-group-background.html: Removed.
        * fast/table/table-cell-overrides-row-background.html: Removed.
        * fast/table/table-col-background.html: Removed.
        * fast/table/table-col-group-background.html: Removed.
        * fast/table/table-col-group-col-span-background.html: Removed.
        * fast/table/table-col-group-span-background.html: Removed.
        * fast/table/table-col-span-background.html: Removed.
        * fast/table/table-row-background-left-50px.html: Removed.
        * fast/table/table-row-background-right-100percent.html: Removed.
        * fast/table/table-row-background-right-50px.html: Removed.
        * fast/table/table-row-background.html: Removed.
        * fast/table/table-row-group-background-positioned.html: Removed.
        * fast/table/table-row-group-background.html: Removed.
        * platform/mac/fast/table/table-background-expected.checksum: Removed.
        * platform/mac/fast/table/table-background-expected.png: Removed.
        * platform/mac/fast/table/table-background-expected.txt: Removed.
        * platform/mac/fast/table/table-cell-border-draws-on-top-of-col-background-expected.checksum: Removed.
        * platform/mac/fast/table/table-cell-border-draws-on-top-of-col-background-expected.png: Removed.
        * platform/mac/fast/table/table-cell-border-draws-on-top-of-col-background-expected.txt: Removed.
        * platform/mac/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.checksum: Removed.
        * platform/mac/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.png: Removed.
        * platform/mac/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.txt: Removed.
        * platform/mac/fast/table/table-cell-border-draws-on-top-of-row-background-expected.checksum: Removed.
        * platform/mac/fast/table/table-cell-border-draws-on-top-of-row-background-expected.png: Removed.
        * platform/mac/fast/table/table-cell-border-draws-on-top-of-row-background-expected.txt: Removed.
        * platform/mac/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.checksum: Removed.
        * platform/mac/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.png: Removed.
        * platform/mac/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.txt: Removed.
        * platform/mac/fast/table/table-cell-overrides-row-background-expected.checksum: Removed.
        * platform/mac/fast/table/table-cell-overrides-row-background-expected.png: Removed.
        * platform/mac/fast/table/table-cell-overrides-row-background-expected.txt: Removed.
        * platform/mac/fast/table/table-col-background-expected.checksum: Removed.
        * platform/mac/fast/table/table-col-background-expected.png: Removed.
        * platform/mac/fast/table/table-col-background-expected.txt: Removed.
        * platform/mac/fast/table/table-col-group-background-expected.checksum: Removed.
        * platform/mac/fast/table/table-col-group-background-expected.png: Removed.
        * platform/mac/fast/table/table-col-group-background-expected.txt: Removed.
        * platform/mac/fast/table/table-col-group-col-span-background-expected.checksum: Removed.
        * platform/mac/fast/table/table-col-group-col-span-background-expected.png: Removed.
        * platform/mac/fast/table/table-col-group-col-span-background-expected.txt: Removed.
        * platform/mac/fast/table/table-col-group-span-background-expected.checksum: Removed.
        * platform/mac/fast/table/table-col-group-span-background-expected.png: Removed.
        * platform/mac/fast/table/table-col-group-span-background-expected.txt: Removed.
        * platform/mac/fast/table/table-col-span-background-expected.checksum: Removed.
        * platform/mac/fast/table/table-col-span-background-expected.png: Removed.
        * platform/mac/fast/table/table-col-span-background-expected.txt: Removed.
        * platform/mac/fast/table/table-row-background-expected.checksum: Removed.
        * platform/mac/fast/table/table-row-background-expected.png: Removed.
        * platform/mac/fast/table/table-row-background-expected.txt: Removed.
        * platform/mac/fast/table/table-row-background-left-50px-expected.checksum: Removed.
        * platform/mac/fast/table/table-row-background-left-50px-expected.png: Removed.
        * platform/mac/fast/table/table-row-background-left-50px-expected.txt: Removed.
        * platform/mac/fast/table/table-row-background-right-100percent-expected.checksum: Removed.
        * platform/mac/fast/table/table-row-background-right-100percent-expected.png: Removed.
        * platform/mac/fast/table/table-row-background-right-100percent-expected.txt: Removed.
        * platform/mac/fast/table/table-row-background-right-50px-expected.checksum: Removed.
        * platform/mac/fast/table/table-row-background-right-50px-expected.png: Removed.
        * platform/mac/fast/table/table-row-background-right-50px-expected.txt: Removed.
        * platform/mac/fast/table/table-row-group-background-expected.checksum: Removed.
        * platform/mac/fast/table/table-row-group-background-expected.png: Removed.
        * platform/mac/fast/table/table-row-group-background-expected.txt: Removed.
        * platform/mac/fast/table/table-row-group-background-positioned-expected.checksum: Removed.
        * platform/mac/fast/table/table-row-group-background-positioned-expected.png: Removed.
        * platform/mac/fast/table/table-row-group-background-positioned-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRefactor DatabaseTracker, part 1: Remove the dependency on
dumi@chromium.org [Thu, 8 Apr 2010 18:40:00 +0000 (18:40 +0000)]
Refactor DatabaseTracker, part 1: Remove the dependency on
OriginQuotaManager from DatabaseTracker.h.

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=31482

* storage/DatabaseTracker.cpp:
(originQuotaManager):
(WebCore::DatabaseTracker::DatabaseTracker):
(WebCore::DatabaseTracker::canEstablishDatabase):
(WebCore::DatabaseTracker::hasEntryForOrigin):
(WebCore::DatabaseTracker::getMaxSizeForDatabase):
(WebCore::DatabaseTracker::databaseChanged):
(WebCore::DatabaseTracker::fullPathForDatabaseNoLock):
(WebCore::DatabaseTracker::fullPathForDatabase):
(WebCore::DatabaseTracker::populateOrigins):
(WebCore::DatabaseTracker::origins):
(WebCore::DatabaseTracker::databaseNamesForOrigin):
(WebCore::DatabaseTracker::removeOpenDatabase):
(WebCore::DatabaseTracker::usageForOriginNoLock):
(WebCore::DatabaseTracker::usageForOrigin):
(WebCore::DatabaseTracker::quotaForOrigin):
(WebCore::DatabaseTracker::setQuota):
(WebCore::DatabaseTracker::deleteOrigin):
(WebCore::DatabaseTracker::deleteDatabase):
(WebCore::DatabaseTracker::deleteDatabaseFile):
* storage/DatabaseTracker.h:
* storage/SQLTransactionClient.cpp:
(WebCore::SQLTransactionClient::didExecuteStatement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-08 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 8 Apr 2010 18:11:15 +0000 (18:11 +0000)]
2010-04-08  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Dimitri Glazkov.

        A couple test expectations cleanups
        https://bugs.webkit.org/show_bug.cgi?id=37285

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-08 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 8 Apr 2010 16:35:34 +0000 (16:35 +0000)]
2010-04-08  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        Fix http.conf for GTK-Debug and Chromium-Linux bots
        https://bugs.webkit.org/show_bug.cgi?id=37279

        * http/conf/apache2-debian-httpd.conf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-08 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Thu, 8 Apr 2010 16:23:24 +0000 (16:23 +0000)]
2010-04-08  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Simon Hausmann.

        [WINCE] Replace max with std::max
        https://bugs.webkit.org/show_bug.cgi?id=37201

        std::max is preferred.

        * platform/wince/FileSystemWince.cpp:
        (WebCore::makeAllDirectories):
        (WebCore::pathGetFileName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] Move AccessibilityObjectEfl.cpp from page to accessibility
tonikitoo@webkit.org [Thu, 8 Apr 2010 16:08:57 +0000 (16:08 +0000)]
[EFL] Move AccessibilityObjectEfl.cpp from page to accessibility
https://bugs.webkit.org/show_bug.cgi?id=36405

Reviewed by Laszlo Gombos.
Patch by Antonio Gomes <tonikitoo@webkit.org>

* accessibility/efl/AccessibilityObjectEfl.cpp: Renamed from WebCore/page/efl/AccessibilityObjectEfl.cpp.
(WebCore::AccessibilityObject::accessibilityIgnoreAttachment):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-08 Benjamin Poulain <benjamin.poulain@nokia.com>
eric@webkit.org [Thu, 8 Apr 2010 15:57:13 +0000 (15:57 +0000)]
2010-04-08  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Warnings when compiling InspectorClientQt.cpp
        https://bugs.webkit.org/show_bug.cgi?id=37266

        Add a default: for the switch()-case to avoid
        warnings.

        * WebCoreSupport/InspectorClientQt.cpp:
        (WebCore::variantToSetting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-08 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 8 Apr 2010 15:27:32 +0000 (15:27 +0000)]
2010-04-08  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Render Load, DOM Content and MarkTimeline event dividers on Timeline panel.

        https://bugs.webkit.org/show_bug.cgi?id=37267

        * English.lproj/localizedStrings.js:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::mainResourceFiredDOMContentEvent):
        (WebCore::InspectorController::mainResourceFiredLoadEvent):
        * inspector/InspectorController.h:
        * inspector/InspectorTimelineAgent.cpp:
        (WebCore::InspectorTimelineAgent::didMarkDOMContentEvent):
        (WebCore::InspectorTimelineAgent::didMarkLoadEvent):
        * inspector/InspectorTimelineAgent.h:
        (WebCore::):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype.updateGraphDividersIfNeeded):
        * inspector/front-end/TimelineAgent.js:
        * inspector/front-end/TimelineGrid.js:
        (WebInspector.TimelineGrid.prototype.removeEventDividers):
        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel):
        (WebInspector.TimelinePanel.prototype.get _recordStyles):
        (WebInspector.TimelinePanel.prototype._updateMarks):
        (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
        (WebInspector.TimelinePanel.prototype._clearPanel):
        (WebInspector.TimelinePanel.prototype._refresh):
        (WebInspector.TimelinePanel.prototype._refreshRecords):
        (WebInspector.TimelineCalculator.prototype.computeBarGraphWindowPosition):
        (WebInspector.TimelineRecordGraphRow.prototype.update):
        * inspector/front-end/inspector.css:
        (.resources-event-divider):
        (.resources-red-divider):
        (.resources-blue-divider):
        (.resources-orange-divider):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Fix a test for the behavior change by r57274.
tkent@chromium.org [Thu, 8 Apr 2010 15:00:59 +0000 (15:00 +0000)]
Unreviewed. Fix a test for the behavior change by r57274.

* fast/css/pseudo-invalid-novalidate-001.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-05 Antonio Gomes <tonikitoo@webkit.org>
tonikitoo@webkit.org [Thu, 8 Apr 2010 14:43:50 +0000 (14:43 +0000)]
2010-04-05  Antonio Gomes  <tonikitoo@webkit.org>

        Reviewed by Simon Hausmann.

        [Qt] REGRESSION:(r50665) QWebFrame::setScrollBarPolicy(Qt::Vertical,Qt::ScrollBarAlwaysOff) has no effect.
        https://bugs.webkit.org/show_bug.cgi?id=29431

        Added stubs for Mac, win, gtk and wx DRTs to implement setScrollbarPolicy method.

        * DumpRenderTree/LayoutTestController.cpp:
        (setScrollbarPolicyCallback):
        (LayoutTestController::staticFunctions):
        * DumpRenderTree/LayoutTestController.h:
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::setScrollbarPolicy):
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (LayoutTestController::setScrollbarPolicy):
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::setScrollbarPolicy):
        * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
        (LayoutTestController::setScrollbarPolicy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-01 Antonio Gomes <tonikitoo@webkit.org>
tonikitoo@webkit.org [Thu, 8 Apr 2010 14:38:12 +0000 (14:38 +0000)]
2010-04-01  Antonio Gomes  <tonikitoo@webkit.org>

        Reviewed by David Hyatt.

        [Qt] REGRESSION:(r50665) QWebFrame::setScrollBarPolicy(Qt::Vertical,Qt::ScrollBarAlwaysOff) has no effect.
        https://bugs.webkit.org/show_bug.cgi?id=29431

        Test: fast/overflow/scrollbar-restored-and-then-locked.html

        WebCore:

        Patch introduces a lock scrollbars concept to ScrollView, as in WebDynamicScrollBarsView.mm/h
        on WebKit/mac. It is needed because in QtWebKit, we have Api for setting both vertical and
        horizontal scrollbars on/off/auto. When it is set to off, for example, it should remain
        as such, unless unset.

        For the locking concept, optional 'lock' parameters were added to setScrollbarModes,
        setHorizontalScrollbarMode and setVerticalScrollbarMode methods of ScrollView. As these
        are all optional, any previous code calling them do not need modification.

        Two optional parameters were also added to Frame's createView method, for horizontal and vertical
        lock state persistence cross page loads.

        * WebCore.base.exp:
        * page/Frame.cpp:
        (WebCore::Frame::createView):
        * platform/ScrollView.cpp:
        (WebCore::ScrollView::ScrollView):
        (WebCore::ScrollView::setScrollbarModes):
        (WebCore::ScrollView::setHorizontalScrollbarMode):
        (WebCore::ScrollView::setVerticalScrollbarMode):
        * platform/ScrollView.h:
        (WebCore::ScrollView::setHorizontalScrollbarLock):
        (WebCore::ScrollView::isHorizontalScrollbarLocked):
        (WebCore::ScrollView::setVerticalScrollbarLock):
        (WebCore::ScrollView::isVerticalScrollbarLocked):
        (WebCore::ScrollView::setScrollingModesLocked):

        WebKit/qt:

        Make use of the new lock parameter of set{Vertical,Horizontal}ScrollbarMode.

        Always added a qt auto test for set scrollbar policy feature.

        * Api/qwebframe.cpp:
        (QWebFrame::setScrollBarPolicy):
        * tests/qwebframe/tst_qwebframe.cpp:
        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (FrameLoaderClientQt::transitionToCommittedForNewPage):

        WebKitTools:

        Make possible to DRT to set scrollbar policies (on, off or auto).

        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::setScrollbarPolicy):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:
        * QtLauncher/main.cpp:
        (LauncherWindow::toggleScrollbars):
        (LauncherWindow::createChrome):

        LayoutTests:

        * fast/overflow/scrollbar-restored-and-then-locked-expected.txt: Added.
        * fast/overflow/scrollbar-restored-and-then-locked.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-08 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Thu, 8 Apr 2010 14:28:32 +0000 (14:28 +0000)]
2010-04-08  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Correctly save number of properties when object being serialized
        have properties in its prorotype.

        https://bugs.webkit.org/show_bug.cgi?id=37263

        * bindings/v8/SerializedScriptValue.cpp:
        (WebCore::ZigZag::Serializer::AbstractObjectState::AbstractObjectState):
        (WebCore::ZigZag::Serializer::AbstractObjectState::advance):

2010-04-08  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Test that object with ptototype can be sent as message.

        https://bugs.webkit.org/show_bug.cgi?id=37263

        * fast/dom/Window/window-postmessage-clone-expected.txt:
        * fast/dom/Window/window-postmessage-clone.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-08 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Thu, 8 Apr 2010 14:14:34 +0000 (14:14 +0000)]
2010-04-08  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Yury Semikhatsky.

        IDB callbacks should fire asynchronously
        https://bugs.webkit.org/show_bug.cgi?id=37265

        Fix the firing behavior of the callbacks to not be synchronous.

        There's still a major bug that I'm trying to track down that is keeping
        us from testing this stuff.  Promise lots of tests ASAP.

        * bindings/v8/custom/V8CustomIDBCallbacks.h:
        (WebCore::V8CustomIDBCallbacks::onSuccessAsync):
        (WebCore::V8CustomIDBCallbacks::onErrorAsync):
        * storage/IDBCallbacks.h:
        (WebCore::IDBCallbacks::IDBCallbacks):
        (WebCore::IDBCallbacks::onSuccess):
        (WebCore::IDBCallbacks::onError):
        (WebCore::IDBCallbacks::timerFired):
        * storage/IndexedDatabaseRequest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agowillValidate doesn't need to check existence of a form element and a name attribute.
tkent@chromium.org [Thu, 8 Apr 2010 14:10:49 +0000 (14:10 +0000)]
willValidate doesn't need to check existence of a form element and a name attribute.
https://bugs.webkit.org/show_bug.cgi?id=34733

Reviewed by Darin Adler.

WebCore:

Remove checks against m_form and m_hasName in
HTMLFormControlElement::willValidate(), and remove the code to
track their updates.

Test: fast/forms/willvalidate.html

* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::HTMLFormControlElement):
(WebCore::HTMLFormControlElement::parseMappedAttribute):
(WebCore::HTMLFormControlElement::insertedIntoTree):
(WebCore::HTMLFormControlElement::removedFromTree):
(WebCore::HTMLFormControlElement::recalcWillValidate):
(WebCore::HTMLFormControlElement::willValidate):
(WebCore::HTMLFormControlElement::setNeedsWillValidateCheck):
* html/HTMLFormControlElement.h:
(WebCore::HTMLFormControlElement::formDestroyed):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setInputType):
  setNeedsWillValidateCheck() should be called before
  setAttribute(valueAttr, ...) is called.

LayoutTests:

- Merge willvalidate-00x tests into one file.
- Update tests affected by the willValidate behavior change.

* fast/forms/input-live-pseudo-selectors-expected.txt:
* fast/forms/resources/input-live-pseudo-selectors.js:
* fast/forms/resources/textarea-live-pseudo-selectors.js:
* fast/forms/script-tests/willvalidate.js: Added.
* fast/forms/textarea-live-pseudo-selectors-expected.txt:
* fast/forms/willvalidate-000-expected.txt: Removed.
* fast/forms/willvalidate-000.html: Removed.
* fast/forms/willvalidate-001-expected.txt: Removed.
* fast/forms/willvalidate-001.html: Removed.
* fast/forms/willvalidate-002-expected.txt: Removed.
* fast/forms/willvalidate-002.html: Removed.
* fast/forms/willvalidate-003-expected.txt: Removed.
* fast/forms/willvalidate-003.html: Removed.
* fast/forms/willvalidate-004-expected.txt: Removed.
* fast/forms/willvalidate-004.html: Removed.
* fast/forms/willvalidate-005-expected.txt: Removed.
* fast/forms/willvalidate-005.html: Removed.
* fast/forms/willvalidate-006-expected.txt: Removed.
* fast/forms/willvalidate-006.html: Removed.
* fast/forms/willvalidate-007-expected.txt: Removed.
* fast/forms/willvalidate-007.html: Removed.
* fast/forms/willvalidate-008-expected.txt: Removed.
* fast/forms/willvalidate-008.html: Removed.
* fast/forms/willvalidate-009-expected.txt: Removed.
* fast/forms/willvalidate-009.html: Removed.
* fast/forms/willvalidate-expected.txt: Added.
* fast/forms/willvalidate.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57274 268f45cc-cd09-0410-ab3c-d52691b4dbfc