WebKit-https.git
12 years ago Reviewed by Darin Adler.
ap@webkit.org [Sat, 24 Jan 2009 09:39:19 +0000 (09:39 +0000)]
    Reviewed by Darin Adler.

        <rdar://problem/6368059> REGRESSION: URL encoding problems on http://www.cineman.ch

        Test: http/tests/xmlhttprequest/encode-request-url-2.html

        * platform/KURL.cpp:
        (WebCore::appendASCII): Added a helper function.
        (WebCore::KURL::KURL): Explicitly encode the URL to call two-argument parse() with better
        specified behavior.
        (WebCore::KURL::init): Ditto. This avoids trying to round-trip an URL encoded into a byte
        stream, but not yet transformed to ASCII-only using percent escapes. Since different parts
        of the byte stream can use different encodings, round-tripping is not possible.
        (WebCore::KURL::parse): Reverted an earlier change that made the single-argument version of
        this function convert the string to utf-8. I think that on the remanining code paths, it is
        correct to assume that the string is all ASCII, but I'm not yet confident enough to drop a
        FIXME warning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-24 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sat, 24 Jan 2009 08:05:24 +0000 (08:05 +0000)]
2009-01-24  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Gtk build fix after r40170

        * GNUmakefile.am: Removed editing/RemoveNodeAttributeCommand.cpp
        and editing/RemoveNodeAttributeCommand.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix the Qt build after r40205.
treat@webkit.org [Sat, 24 Jan 2009 06:19:11 +0000 (06:19 +0000)]
Fix the Qt build after r40205.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-23 Brady Eidson <beidson@apple.com>
beidson@apple.com [Sat, 24 Jan 2009 05:47:59 +0000 (05:47 +0000)]
2009-01-23  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler

        In CachedPage, break off per-Frame pieces of data into a CachedFrame object.

        * GNUmakefile.am:
        * WebCore.base.exp:
        * WebCore.pro:
        * WebCore.scons:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:

        * history/CachedFrame.cpp: Added.
        (WebCore::cachedFrameCounter):
        (WebCore::CachedFrame::CachedFrame):
        (WebCore::CachedFrame::~CachedFrame):
        (WebCore::CachedFrame::restore):
        (WebCore::CachedFrame::clear):
        (WebCore::CachedFrame::setCachedFramePlatformData):
        (WebCore::CachedFrame::cachedFramePlatformData):
        * history/CachedFrame.h: Added.
        (WebCore::CachedFrame::document):
        (WebCore::CachedFrame::documentLoader):
        (WebCore::CachedFrame::view):
        (WebCore::CachedFrame::mousePressNode):
        (WebCore::CachedFrame::url):
        (WebCore::CachedFrame::domWindow):

        * history/CachedPage.cpp:
        (WebCore::CachedPage::CachedPage):
        (WebCore::CachedPage::restore):
        (WebCore::CachedPage::clear):
        (WebCore::CachedPage::setCachedFramePlatformData):
        (WebCore::CachedPage::cachedFramePlatformData):
        * history/CachedPage.h:
        (WebCore::CachedPage::document):
        (WebCore::CachedPage::documentLoader):
        (WebCore::CachedPage::view):
        (WebCore::CachedPage::mousePressNode):
        (WebCore::CachedPage::url):
        (WebCore::CachedPage::domWindow):

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::cachePageForHistoryItem): Setting the DocumentLoader independently of
          creating a CachedPage was a historical relic.  Take the opportunity to clean that up.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-23 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sat, 24 Jan 2009 03:59:09 +0000 (03:59 +0000)]
2009-01-23  David Hyatt  <hyatt@apple.com>

        Add ASSERTs to catch anyone trying to obtain the width/height of an inline flow.  Fix up all the places
        that triggered the ASSERT (since all of these places are effectively regressions from my landing that
        devirtualized width()/height()).

        Reviewed by Adele

        * dom/Position.cpp:
        (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
        * editing/DeleteButtonController.cpp:
        (WebCore::isDeletableElement):
        * html/HTMLAnchorElement.cpp:
        (WebCore::HTMLAnchorElement::isKeyboardFocusable):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::clientWidth):
        (WebCore::RenderBox::clientHeight):
        (WebCore::RenderBox::scrollWidth):
        (WebCore::RenderBox::scrollHeight):
        (WebCore::RenderBox::absoluteOutlineBounds):
        * rendering/RenderBox.h:
        (WebCore::RenderBox::width):
        (WebCore::RenderBox::height):
        (WebCore::RenderBox::size):
        (WebCore::RenderBox::frameRect):
        (WebCore::RenderBox::borderBoundingBox):
        * rendering/RenderFlow.h:
        (WebCore::RenderFlow::borderBoundingBox):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::updateLayerPosition):
        * rendering/RenderScrollbarPart.cpp:
        (WebCore::RenderScrollbarPart::styleWillChange):
        * rendering/RenderScrollbarPart.h:
        * wml/WMLAElement.cpp:
        (WebCore::WMLAElement::isKeyboardFocusable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-23 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Sat, 24 Jan 2009 03:03:25 +0000 (03:03 +0000)]
2009-01-23  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Geoff Garen.

        Fix for <rdar://problem/6126212>
        Ensure that callbacks out from the JSC interface are only allowed
        to return in reverse-chronological order to that in which they were
        made.  If we allow earlier callbacks to return first, then this may
        result in setions of the RegisterFile in use by another thread
        being trampled.

        See uber-comment in JSLock.h for details.

        * runtime/JSLock.cpp:
        (JSC::JSLock::DropAllLocks::DropAllLocks):
        (JSC::JSLock::DropAllLocks::~DropAllLocks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-23 Darin Adler <darin@apple.com>
darin@apple.com [Sat, 24 Jan 2009 02:39:56 +0000 (02:39 +0000)]
2009-01-23  Darin Adler  <darin@apple.com>

        Reviewed by Anders Carlsson.

        Bug 23352: Turn on more compiler warnings in the Mac build
        https://bugs.webkit.org/show_bug.cgi?id=23352

        Second patch: Slightly less simple cases of various warnings.

        * bridge/jni/jni_runtime.h:
        (JSC::Bindings::JavaString::_commonInit): Use reinterpret_cast here and avoid casting
        away const.

        * dom/XMLTokenizerLibxml2.cpp:
        (WebCore::PendingCallbacks::appendStartElementNSCallback): Use static_cast instead of
        reinterpret_cast; this is casting the result of malloc, and the idiom is to use
        static_cast, which works because we're casting from void*.
        (WebCore::PendingCallbacks::PendingStartElementNSCallback::call): Use const_cast instead
        C-style casts.

        * xml/XSLTUnicodeSort.cpp:
        (inlineXSLTTransformError): Tweak soft linking of xsltTransformError to use a macro
        instead of redefining the function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-23 Darin Adler <darin@apple.com>
darin@apple.com [Sat, 24 Jan 2009 02:23:12 +0000 (02:23 +0000)]
2009-01-23  Darin Adler  <darin@apple.com>

        Reviewed by Anders Carlsson.

        Bug 23475: fast/text/find-backwards.html fails with ICU disabled SearchBuffer
        https://bugs.webkit.org/show_bug.cgi?id=23475

        * editing/TextIterator.cpp:
        (WebCore::SearchBuffer::search): Set the character start flag to false to
        ensure we won't ever return the same result twice. There are other ways we
        could accomplish this, mentioned in the comment, but this one was the smallest
        and cleanest I could think of.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-23 Darin Adler <darin@apple.com>
darin@apple.com [Sat, 24 Jan 2009 02:22:21 +0000 (02:22 +0000)]
2009-01-23  Darin Adler  <darin@apple.com>

        Reviewed by Anders Carlsson.

        Bug 23510: REGRESSION (r40171): CDATASection objects not getting proper JavaScript wrappers
        https://bugs.webkit.org/show_bug.cgi?id=23510

        That patch fixed the optimization that's supposed to give a faster path for
        allocating the wrappers for DOM Text objects. But CDATASection is the one
        subclass of Text objects.

        * GNUmakefile.am: Added JSCDATASectionCustom.cpp.
        * WebCore.scons: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * WebCoreSources.bkl: Ditto.

        * bindings/js/JSCDATASectionCustom.cpp: Copied from bindings/js/JSTextCustom.cpp.
        (WebCore::toJSNewlyCreated): Changed to do CDATASection, not Text.

        * bindings/scripts/CodeGeneratorJS.pm: Added another toJSNewlyCreated function
        for CDATASection. We don't want to have to check when creating a wrapper for a
        Text object whether it's a CDATASection object or not, so we need to do this overload
        at compile time.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Eric Seidel.
zimmermann@webkit.org [Sat, 24 Jan 2009 02:00:43 +0000 (02:00 +0000)]
Reviewed by Eric Seidel.

Add a base class for WML form control elements: WMLFormControlElement (as it's designed in HTML as well).
WMLFormControlElement inherits from WMLElement and FormControlElement (just like the HTMLFormControlElement equivalent).

WMLInputElement / WMLOptionElement / WMLOptGroupElement are supposed to inherit from the new WMLFormControlElement class.
Now WMLInputElement & WMLOptGroupElement only inherit from WMLElement and FormControlElement, but WMLOptionElement inherits
from WMLEventHandlingElement (which in turn inherits from WMLElement) and FormControlElement. In order to introduce a shared
base class, WMLEventHandlingElement is no longer allowed to inherit from WMLElement directly. Instead it should turn into
another base class, just like FormControlElement.

Add a base class for form control elements 'with state': FormControlElementWithState, serving as base class for
HTMLFormControlElementWithState and WMLFormControlElementWithState. -> Make Document operate on FormControlElementWithState
objects instead of HTMLFormControlElementWithState objects, to support save/restore control state for non HTMLFormControlElements.

Rename isGenericFormElement() to isFormControlElement(), and move it to Element.h
Add new virtual function isFormControlElementWithState() to Element.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBug 23492: Separating the WebKitSystemInterface Calls.
bfulgham@webkit.org [Sat, 24 Jan 2009 01:23:21 +0000 (01:23 +0000)]
Bug 23492: Separating the WebKitSystemInterface Calls.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBug 23509: Crash at -[WebCoreAXObject doAXNextSentenceEndTextMarkerForTextMarker:]
cfleizach@apple.com [Sat, 24 Jan 2009 01:21:29 +0000 (01:21 +0000)]
Bug 23509: Crash at -[WebCoreAXObject doAXNextSentenceEndTextMarkerForTextMarker:]

Move null checking into makeRange

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix the Gtk build too after removal of RenderBox::toConstRenderBox
treat@webkit.org [Sat, 24 Jan 2009 00:54:46 +0000 (00:54 +0000)]
Fix the Gtk build too after removal of RenderBox::toConstRenderBox

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix the Qt build after rename of RenderBox::toConstRenderBox -> toRenderBox
treat@webkit.org [Sat, 24 Jan 2009 00:52:36 +0000 (00:52 +0000)]
Fix the Qt build after rename of RenderBox::toConstRenderBox -> toRenderBox

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix the Qt build after r40168.
treat@webkit.org [Sat, 24 Jan 2009 00:47:44 +0000 (00:47 +0000)]
Fix the Qt build after r40168.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
beidson@apple.com [Sat, 24 Jan 2009 00:26:43 +0000 (00:26 +0000)]
WebCore:

2009-01-23  Brady Eidson  <beidson@apple.com>

        Rubberstamped by Darin Adler

        Rename CachedPagePlatformData to CachedFramePlatformData to more accurately reflect its true role.

        * GNUmakefile.am:
        * WebCore.base.exp:
        * WebCore.order:
        * WebCore.xcodeproj/project.pbxproj:

        * history/CachedFramePlatformData.h: Copied from WebCore/history/CachedPagePlatformData.h.
        (WebCore::CachedFramePlatformData::~CachedFramePlatformData):
        * history/CachedPagePlatformData.h: Removed.

        * history/CachedPage.cpp:
        (WebCore::CachedPage::clear):
        (WebCore::CachedPage::setCachedFramePlatformData):
        (WebCore::CachedPage::cachedFramePlatformData):
        * history/CachedPage.h:

WebKit:

2009-01-23  Brady Eidson  <beidson@apple.com>

        Rubberstamped by Darin Adler

        Rename CachedPagePlatformData to CachedFramePlatformData to more accurately reflect its true role.

        * WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2009-01-23  Brady Eidson  <beidson@apple.com>

        Rubberstamped by Darin Adler

        Rename CachedPagePlatformData to CachedFramePlatformData to more accurately reflect its true role.

        * WebCoreSupport/WebCachedFramePlatformData.h: Copied from WebKit/mac/WebCoreSupport/WebCachedPagePlatformData.h.
        (WebCachedFramePlatformData::WebCachedFramePlatformData):
        * WebCoreSupport/WebCachedPagePlatformData.h: Removed.

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::savePlatformDataToCachedPage):
        (WebFrameLoaderClient::transitionToCommittedFromCachedPage):

        * WebKit.order:

WebKit/win:

2009-01-23  Brady Eidson  <beidson@apple.com>

        Rubberstamped by Darin Adler

        Rename CachedPagePlatformData to CachedFramePlatformData to more accurately reflect its true role.

        * WebCachedFramePlatformData.h: Copied from WebKit/win/WebCachedPagePlatformData.h.
        (WebCachedFramePlatformData::WebCachedFramePlatformData):
        * WebCachedPagePlatformData.h: Removed.

        * WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebFrameLoaderClient::savePlatformDataToCachedPage):

        * WebKit.vcproj/WebKit.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Kevin Ollivier.
kevino@webkit.org [Sat, 24 Jan 2009 00:23:04 +0000 (00:23 +0000)]
Reviewed by Kevin Ollivier.

Fix drawing in situations where sub-portions of the bitmap are to be drawn to the screen.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fixes for recent changes.
kevino@webkit.org [Sat, 24 Jan 2009 00:19:17 +0000 (00:19 +0000)]
Build fixes for recent changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix Windows bustage.
hyatt@apple.com [Fri, 23 Jan 2009 23:33:57 +0000 (23:33 +0000)]
Fix Windows bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix Windows bustage.
hyatt@apple.com [Fri, 23 Jan 2009 23:33:35 +0000 (23:33 +0000)]
Fix Windows bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-23 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Fri, 23 Jan 2009 23:33:28 +0000 (23:33 +0000)]
2009-01-23  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Adele Peterson

        Fix for https://bugs.webkit.org/show_bug.cgi?id=23407

        Implement QTMovieWin::hasVideo so the controller on an audio-only <video> element
        is never hidden (as with an <audio> element).

        Test: media/video-controls-visible-audio-only.html

        * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
        (WebCore::MediaPlayerPrivate::hasVideo):
        * platform/graphics/win/QTMovieWin.cpp:
        (QTMovieWin::hasVideo):
        * platform/graphics/win/QTMovieWin.h:

2009-01-23  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Adele Peterson

        Test for behavior of <video> element controller when a media file has
        only audio.
        https://bugs.webkit.org/show_bug.cgi?id=23407

        * media/video-controls-visible-audio-only.html: Added.
        * platform/mac/media/video-controls-visible-audio-only-expected.checksum: Added.
        * platform/mac/media/video-controls-visible-audio-only-expected.png: Added.
        * platform/mac/media/video-controls-visible-audio-only-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-23 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Fri, 23 Jan 2009 23:25:07 +0000 (23:25 +0000)]
2009-01-23  David Hyatt  <hyatt@apple.com>

        Make toRenderBox a non-member function.  Rename toConstRenderBox to just also be called toRenderBox.

        Reviewed by Oliver Hunt

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::sizingBox):
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::getUpperLeftCorner):
        (WebCore::ContainerNode::getLowerRightCorner):
        * dom/Element.cpp:
        (WebCore::Element::scrollByUnits):
        * dom/Position.cpp:
        (WebCore::endsOfNodeAreVisuallyDistinctPositions):
        (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
        (WebCore::Position::isCandidate):
        * editing/DeleteButtonController.cpp:
        (WebCore::isDeletableElement):
        * editing/EditorCommand.cpp:
        (WebCore::verticalScrollDistance):
        * editing/TextIterator.cpp:
        (WebCore::shouldEmitExtraNewlineForNode):
        * html/HTMLAnchorElement.cpp:
        (WebCore::HTMLAnchorElement::isKeyboardFocusable):
        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLFormControlElement::isFocusable):
        * html/HTMLFrameElementBase.cpp:
        (WebCore::HTMLFrameElementBase::width):
        (WebCore::HTMLFrameElementBase::height):
        * page/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMouseDraggedEvent):
        (WebCore::EventHandler::autoscrollTimerFired):
        (WebCore::EventHandler::updateAutoscrollRenderer):
        (WebCore::EventHandler::stopAutoscrollTimer):
        (WebCore::EventHandler::scrollOverflow):
        * page/FrameView.cpp:
        (WebCore::FrameView::layout):
        * page/animation/AnimationBase.cpp:
        (WebCore::blendFunc):
        * rendering/InlineBox.cpp:
        (WebCore::InlineBox::adjustPosition):
        * rendering/InlineBox.h:
        (WebCore::InlineBox::renderBox):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::clearFloats):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::offsetFromContainer):
        (WebCore::RenderBox::computeAbsoluteRepaintRect):
        (WebCore::RenderBox::containingBlockWidthForPositioned):
        (WebCore::RenderBox::containingBlockHeightForPositioned):
        (WebCore::RenderBox::calcAbsoluteHorizontal):
        (WebCore::RenderBox::calcAbsoluteVertical):
        (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
        (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
        * rendering/RenderBox.h:
        (WebCore::toRenderBox):
        (WebCore::RenderBox::previousSiblingBox):
        (WebCore::RenderBox::nextSiblingBox):
        (WebCore::RenderBox::parentBox):
        * rendering/RenderFlow.cpp:
        (WebCore::RenderFlow::absoluteClippedOverflowRect):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::updateLayerPosition):
        (WebCore::RenderLayer::resize):
        (WebCore::RenderLayer::boundingBox):
        * rendering/RenderObject.cpp:
        (WebCore::addLayers):
        (WebCore::RenderObject::removeLayers):
        (WebCore::RenderObject::moveLayers):
        (WebCore::RenderObject::findNextLayer):
        (WebCore::RenderObject::enclosingLayer):
        (WebCore::RenderObject::setNeedsLayout):
        (WebCore::RenderObject::setNeedsPositionedMovementLayout):
        (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
        (WebCore::RenderObject::getAbsoluteRepaintRectWithOutline):
        (WebCore::RenderObject::computeAbsoluteRepaintRect):
        (WebCore::RenderObject::localToAbsolute):
        (WebCore::RenderObject::absoluteToLocal):
        (WebCore::RenderObject::localToAbsoluteQuad):
        (WebCore::RenderObject::offsetFromContainer):
        (WebCore::RenderObject::removeFromObjectLists):
        (WebCore::RenderObject::destroy):
        (WebCore::RenderObject::updateHitTestResult):
        (WebCore::RenderObject::addDashboardRegions):
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::layoutRows):
        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::hitTestMediaControlPart):
        (WebCore::RenderTheme::baselinePosition):
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::hitTestMediaControlPart):
        * rendering/RenderTreeAsText.cpp:
        (WebCore::externalRepresentation):
        * rendering/bidi.cpp:
        (WebCore::inlineWidth):
        (WebCore::RenderBlock::computeHorizontalPositionsForLine):
        (WebCore::requiresLineBox):
        (WebCore::RenderBlock::findNextLineBreak):
        * svg/SVGLength.cpp:
        (WebCore::SVGLength::PercentageOfViewport):
        * wml/WMLAElement.cpp:
        (WebCore::WMLAElement::isKeyboardFocusable):
        * wml/WMLInputElement.cpp:
        (WebCore::isInputFocusable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-23 Chris Fleizach <cfleizach@apple.com>
cfleizach@apple.com [Fri, 23 Jan 2009 23:03:21 +0000 (23:03 +0000)]
2009-01-23  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Beth Dakin.

        Bug 23509: Crash at -[WebCoreAXObject doAXNextSentenceEndTextMarkerForTextMarker:]
        https://bugs.webkit.org/show_bug.cgi?id=23509

        Add null checking around next/previous sentence retrieval in AX code

        * page/AccessibilityObject.cpp:
        (WebCore::AccessibilityObject::nextSentenceEndPosition):
        (WebCore::AccessibilityObject::previousSentenceStartPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-23 Adele Peterson <adele@apple.com>
adele@apple.com [Fri, 23 Jan 2009 22:50:47 +0000 (22:50 +0000)]
2009-01-23  Adele Peterson  <adele@apple.com>

        Build fix.

        Use new linesBoundingBox method instead of
        boundingBoxWidth and boundingBoxHeight for RenderText objects.

        * WebView/WebRenderNode.mm: (copyRenderNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowx build fix, add missing include dir.
kevino@webkit.org [Fri, 23 Jan 2009 22:41:48 +0000 (22:41 +0000)]
wx build fix, add missing include dir.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-23 David Kilzer <ddkilzer@apple.com>
ddkilzer@apple.com [Fri, 23 Jan 2009 22:39:31 +0000 (22:39 +0000)]
2009-01-23  David Kilzer  <ddkilzer@apple.com>

        * Scripts/do-webcore-rename: Removed 10 header guard renames that
        had already been fixed, and updated 4 renames whose original values
        had changed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdded missing comma to copyright.
ddkilzer@apple.com [Fri, 23 Jan 2009 22:38:25 +0000 (22:38 +0000)]
Added missing comma to copyright.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLand new results now that text runs at negative positions dump their widths correctly.
hyatt@apple.com [Fri, 23 Jan 2009 22:20:23 +0000 (22:20 +0000)]
Land new results now that text runs at negative positions dump their widths correctly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLand new results now that text runs at negative positions dump their widths correctly.
hyatt@apple.com [Fri, 23 Jan 2009 22:19:59 +0000 (22:19 +0000)]
Land new results now that text runs at negative positions dump their widths correctly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUpdate the test results for compacts and run-ins now that they dump accurate positions.
hyatt@apple.com [Fri, 23 Jan 2009 22:19:09 +0000 (22:19 +0000)]
Update the test results for compacts and run-ins now that they dump accurate positions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd new repaint test for hover regression.
hyatt@apple.com [Fri, 23 Jan 2009 22:18:18 +0000 (22:18 +0000)]
Add new repaint test for hover regression.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-23 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Fri, 23 Jan 2009 22:17:26 +0000 (22:17 +0000)]
2009-01-23  David Hyatt  <hyatt@apple.com>

        Fix for <rdar://problem/6518850> REGRESSION: hover feedback not showing on many sites

        Inline flow repainting was broken because it relied on width() and height().  Give RenderFlow a linesBoundingBox
        method for obtaining a reasonable bounding box to use for repainting.  Eliminate the methods from RenderInline
        since compacts/run-ins need them too, so putting them on RenderFlow is necessary.

        For consistency, change RenderText's version of these methods into the single linesBoundingBox method as
        well.

        Reviewed by Oliver Hunt

        * WebCore.base.exp:
        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::getUpperLeftCorner):
        (WebCore::ContainerNode::getLowerRightCorner):
        * dom/Position.cpp:
        (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::containingBlockHeightForPositioned):
        * rendering/RenderFlow.cpp:
        (WebCore::RenderFlow::absoluteClippedOverflowRect):
        (WebCore::RenderFlow::linesBoundingBox):
        * rendering/RenderFlow.h:
        * rendering/RenderInline.cpp:
        * rendering/RenderInline.h:
        (WebCore::RenderInline::offsetWidth):
        (WebCore::RenderInline::offsetHeight):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::updateLayerPosition):
        * rendering/RenderText.cpp:
        (WebCore::RenderText::linesBoundingBox):
        * rendering/RenderText.h:
        * rendering/RenderTreeAsText.cpp:
        (WebCore::operator<<):
        * rendering/SVGRenderTreeAsText.cpp:
        (WebCore::write):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix RenderFlow. Botched the application of my patch.
hyatt@apple.com [Fri, 23 Jan 2009 21:28:37 +0000 (21:28 +0000)]
Fix RenderFlow. Botched the application of my patch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-23 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Fri, 23 Jan 2009 21:25:32 +0000 (21:25 +0000)]
2009-01-23  David Hyatt  <hyatt@apple.com>

        Move layer() into RenderBox and make it non-virtual.  Move all of the scrolling functions from RenderObject
        to RenderBox and devirtualize as many as possible.  Clean up styleWillChange to factor code specific to
        RenderBox and RenderBlock into their appropriate subclasses.  Stubbed out an empty styleWillChange on
        RenderText, since none of the work done in styleWillChange was relevant to text nodes.

        Reviewed by Sam Weinig

        * dom/Document.cpp:
        (WebCore::Document::elementFromPoint):
        (WebCore::Document::renderView):
        (WebCore::Document::prepareMouseEvent):
        * dom/Document.h:
        * dom/Element.cpp:
        (WebCore::Element::scrollByUnits):
        * editing/SelectionController.cpp:
        (WebCore::SelectionController::contains):
        * html/HTMLMarqueeElement.cpp:
        (WebCore::HTMLMarqueeElement::start):
        (WebCore::HTMLMarqueeElement::stop):
        * page/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::topRenderer):
        (WebCore::AccessibilityRenderObject::visiblePositionForPoint):
        (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
        * page/AccessibilityRenderObject.h:
        * page/EventHandler.cpp:
        (WebCore::scrollAndAcceptEvent):
        (WebCore::EventHandler::handleMousePressEvent):
        (WebCore::EventHandler::handleMouseDraggedEvent):
        (WebCore::EventHandler::updateSelectionForMouseDrag):
        (WebCore::EventHandler::autoscrollTimerFired):
        (WebCore::EventHandler::updateAutoscrollRenderer):
        (WebCore::EventHandler::stopAutoscrollTimer):
        (WebCore::EventHandler::scrollOverflow):
        (WebCore::EventHandler::handleWheelEvent):
        (WebCore::EventHandler::hoverTimerFired):
        * page/Frame.cpp:
        (WebCore::Frame::clearTimers):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::styleWillChange):
        * rendering/RenderBlock.h:
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::styleWillChange):
        (WebCore::RenderBox::verticalScrollbarWidth):
        (WebCore::RenderBox::horizontalScrollbarHeight):
        (WebCore::RenderBox::scroll):
        (WebCore::RenderBox::canBeProgramaticallyScrolled):
        (WebCore::RenderBox::autoscroll):
        (WebCore::RenderBox::panScroll):
        (WebCore::RenderBox::offsetFromContainer):
        (WebCore::RenderBox::computeAbsoluteRepaintRect):
        * rendering/RenderBox.h:
        (WebCore::RenderBox::layer):
        (WebCore::RenderBox::requiresLayer):
        (WebCore::RenderBox::stopAutoscroll):
        (WebCore::RenderBox::hasAutoVerticalScrollbar):
        (WebCore::RenderBox::hasAutoHorizontalScrollbar):
        (WebCore::RenderBox::scrollsOverflow):
        (WebCore::RenderBox::scrollsOverflowX):
        (WebCore::RenderBox::scrollsOverflowY):
        (WebCore::RenderBox::includeVerticalScrollbarSize):
        (WebCore::RenderBox::includeHorizontalScrollbarSize):
        * rendering/RenderFlow.cpp:
        (WebCore::RenderFlow::absoluteClippedOverflowRect):
        (WebCore::RenderFlow::addFocusRingRects):
        * rendering/RenderForeignObject.cpp:
        * rendering/RenderForeignObject.h:
        (WebCore::RenderForeignObject::requiresLayer):
        * rendering/RenderInline.cpp:
        * rendering/RenderInline.h:
        (WebCore::RenderInline::requiresLayer):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::childrenClipRect):
        (WebCore::RenderLayer::selfClipRect):
        * rendering/RenderListBox.cpp:
        * rendering/RenderListBox.h:
        * rendering/RenderObject.cpp:
        (WebCore::addLayers):
        (WebCore::RenderObject::removeLayers):
        (WebCore::RenderObject::moveLayers):
        (WebCore::RenderObject::findNextLayer):
        (WebCore::RenderObject::enclosingLayer):
        (WebCore::RenderObject::setNeedsLayout):
        (WebCore::RenderObject::setNeedsPositionedMovementLayout):
        (WebCore::RenderObject::computeAbsoluteRepaintRect):
        (WebCore::RenderObject::styleWillChange):
        (WebCore::RenderObject::localToAbsolute):
        (WebCore::RenderObject::absoluteToLocal):
        (WebCore::RenderObject::localToAbsoluteQuad):
        (WebCore::RenderObject::offsetFromContainer):
        (WebCore::RenderObject::destroy):
        * rendering/RenderObject.h:
        * rendering/RenderPath.cpp:
        * rendering/RenderPath.h:
        (WebCore::RenderPath::requiresLayer):
        * rendering/RenderReplica.h:
        (WebCore::RenderReplica::requiresLayer):
        * rendering/RenderSVGContainer.cpp:
        * rendering/RenderSVGContainer.h:
        (WebCore::RenderSVGContainer::requiresLayer):
        * rendering/RenderSVGHiddenContainer.cpp:
        * rendering/RenderSVGHiddenContainer.h:
        (WebCore::RenderSVGHiddenContainer::requiresLayer):
        * rendering/RenderSVGImage.cpp:
        * rendering/RenderSVGImage.h:
        (WebCore::RenderSVGImage::requiresLayer):
        * rendering/RenderSVGInline.h:
        (WebCore::RenderSVGInline::requiresLayer):
        * rendering/RenderSVGInlineText.h:
        (WebCore::RenderSVGInlineText::requiresLayer):
        * rendering/RenderSVGText.cpp:
        * rendering/RenderSVGText.h:
        (WebCore::RenderSVGText::requiresLayer):
        * rendering/RenderScrollbarPart.h:
        (WebCore::RenderScrollbarPart::requiresLayer):
        * rendering/RenderSlider.cpp:
        (WebCore::RenderSlider::setCurrentPosition):
        * rendering/RenderTableCell.cpp:
        * rendering/RenderTableCell.h:
        (WebCore::RenderTableCell::requiresLayer):
        * rendering/RenderTableCol.h:
        (WebCore::RenderTableCol::requiresLayer):
        * rendering/RenderTableRow.h:
        (WebCore::RenderTableRow::requiresLayer):
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::layoutRows):
        * rendering/RenderText.h:
        (WebCore::RenderText::styleWillChange):
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::autoscroll):
        (WebCore::RenderTextControl::scroll):
        * rendering/RenderTextControl.h:
        * rendering/RenderTreeAsText.cpp:
        (WebCore::write):
        (WebCore::externalRepresentation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-23 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 23 Jan 2009 21:18:13 +0000 (21:18 +0000)]
2009-01-23  Anders Carlsson  <andersca@apple.com>

        Fix 64-bit build.

        * Plugins/Hosted/ProxyInstance.mm:
        (WebKit::proxyClass):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-23 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 23 Jan 2009 20:56:33 +0000 (20:56 +0000)]
2009-01-23  Anders Carlsson  <andersca@apple.com>

        Fix GCC 4.0 build.

        * Configurations/Base.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-23 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 23 Jan 2009 20:53:17 +0000 (20:53 +0000)]
2009-01-23  Anders Carlsson  <andersca@apple.com>

        Fix tyop.

        * editing/markup.cpp:
        (WebCore::joinMarkups):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-23 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 23 Jan 2009 20:51:33 +0000 (20:51 +0000)]
2009-01-23  Darin Adler  <darin@apple.com>

        Try to fix WX build.

        * runtime/JSGlobalObjectFunctions.h: Include <wtf/unicode/Unicode.h>
        for the definition of UChar.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-23 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 23 Jan 2009 20:50:59 +0000 (20:50 +0000)]
2009-01-23  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        * Configurations/Base.xcconfig:
        Fix GCC 4.0 build.

        * editing/markup.cpp:
        (WebCore::joinMarkups):
        Pass a const reference to the vector.

        * html/HTMLElement.cpp:
        * platform/text/String.cpp:
        Add comments indicating that these functions are for use in the debugger.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-23 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 23 Jan 2009 20:37:44 +0000 (20:37 +0000)]
2009-01-23  Anders Carlsson  <andersca@apple.com>

        * Configurations/Base.xcconfig:
        GCC 4.0 build fix.

        * runtime/JSNumberCell.h:
        64-bit build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-23 Darin Fisher <darin@chromium.org>
darin@chromium.org [Fri, 23 Jan 2009 20:35:59 +0000 (20:35 +0000)]
2009-01-23  Darin Fisher  <darin@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=23506
        Upstream Chromium's image decoders for use with PLATFORM(SKIA)

        * platform/image-decoders/skia/BMPImageDecoder.cpp: Added.
        * platform/image-decoders/skia/BMPImageDecoder.h: Added.
        * platform/image-decoders/skia/BMPImageReader.cpp: Added.
        * platform/image-decoders/skia/BMPImageReader.h: Added.
        * platform/image-decoders/skia/GIFImageDecoder.cpp:
        (WebCore::GIFImageDecoderPrivate::GIFImageDecoderPrivate):
        (WebCore::GIFImageDecoderPrivate::decode):
        (WebCore::GIFImageDecoderPrivate::getColorMap):
        (WebCore::GIFImageDecoder::GIFImageDecoder):
        (WebCore::GIFImageDecoder::isSizeAvailable):
        (WebCore::GIFImageDecoder::frameCount):
        (WebCore::GIFImageDecoder::frameBufferAtIndex):
        (WebCore::GIFImageDecoder::clearFrameBufferCache):
        (WebCore::GIFImageDecoder::decode):
        (WebCore::GIFImageDecoder::sizeNowAvailable):
        (WebCore::GIFImageDecoder::initFrameBuffer):
        (WebCore::GIFImageDecoder::prepEmptyFrameBuffer):
        (WebCore::GIFImageDecoder::haveDecodedRow):
        (WebCore::GIFImageDecoder::frameComplete):
        * platform/image-decoders/skia/GIFImageDecoder.h:
        (WebCore::GIFImageDecoder::filenameExtension):
        (WebCore::GIFImageDecoder::frameDurationAtIndex):
        (WebCore::GIFImageDecoder::):
        * platform/image-decoders/skia/GIFImageReader.cpp:
        (GIFImageReader::do_lzw):
        (GIFImageReader::read):
        * platform/image-decoders/skia/GIFImageReader.h:
        * platform/image-decoders/skia/ICOImageDecoder.cpp: Added.
        * platform/image-decoders/skia/ICOImageDecoder.h: Added.
        * platform/image-decoders/skia/ImageDecoder.h:
        (WebCore::RefCountedNativeImageSkia::create):
        (WebCore::RefCountedNativeImageSkia::bitmap):
        (WebCore::RefCountedNativeImageSkia::RefCountedNativeImageSkia):
        (WebCore::RGBA32Buffer::):
        (WebCore::RGBA32Buffer::RGBA32Buffer):
        (WebCore::RGBA32Buffer::~RGBA32Buffer):
        (WebCore::RGBA32Buffer::operator=):
        (WebCore::RGBA32Buffer::clear):
        (WebCore::RGBA32Buffer::copyBitmapData):
        (WebCore::RGBA32Buffer::bitmap):
        (WebCore::RGBA32Buffer::setSize):
        (WebCore::RGBA32Buffer::width):
        (WebCore::RGBA32Buffer::height):
        (WebCore::RGBA32Buffer::rect):
        (WebCore::RGBA32Buffer::status):
        (WebCore::RGBA32Buffer::duration):
        (WebCore::RGBA32Buffer::disposalMethod):
        (WebCore::RGBA32Buffer::hasAlpha):
        (WebCore::RGBA32Buffer::setRect):
        (WebCore::RGBA32Buffer::setStatus):
        (WebCore::RGBA32Buffer::setDuration):
        (WebCore::RGBA32Buffer::setDisposalMethod):
        (WebCore::RGBA32Buffer::setHasAlpha):
        (WebCore::RGBA32Buffer::setRGBA):
        (WebCore::ImageDecoder::ImageDecoder):
        (WebCore::ImageDecoder::~ImageDecoder):
        (WebCore::ImageDecoder::setData):
        (WebCore::ImageDecoder::isSizeAvailable):
        (WebCore::ImageDecoder::size):
        (WebCore::ImageDecoder::frameCount):
        (WebCore::ImageDecoder::repetitionCount):
        (WebCore::ImageDecoder::supportsAlpha):
        (WebCore::ImageDecoder::failed):
        (WebCore::ImageDecoder::setFailed):
        (WebCore::ImageDecoder::clearFrameBufferCache):
        (WebCore::ImageDecoder::setSize):
        (WebCore::ImageDecoder::isOverSize):
        * platform/image-decoders/skia/JPEGImageDecoder.cpp:
        (WebCore::JPEGImageReader::JPEGImageReader):
        (WebCore::JPEGImageReader::decode):
        (WebCore::JPEGImageDecoder::isSizeAvailable):
        (WebCore::JPEGImageDecoder::outputScanlines):
        * platform/image-decoders/skia/JPEGImageDecoder.h:
        (WebCore::JPEGImageDecoder::filenameExtension):
        (WebCore::JPEGImageDecoder::supportsAlpha):
        (WebCore::JPEGImageDecoder::reader):
        * platform/image-decoders/skia/PNGImageDecoder.cpp:
        (WebCore::PNGImageReader::close):
        (WebCore::PNGImageDecoder::PNGImageDecoder):
        (WebCore::PNGImageDecoder::isSizeAvailable):
        (WebCore::PNGImageDecoder::frameBufferAtIndex):
        (WebCore::PNGImageDecoder::decode):
        (WebCore::PNGImageDecoder::decodingFailed):
        (WebCore::PNGImageDecoder::headerAvailable):
        (WebCore::rowAvailable):
        (WebCore::PNGImageDecoder::rowAvailable):
        (WebCore::PNGImageDecoder::pngComplete):
        * platform/image-decoders/skia/PNGImageDecoder.h:
        (WebCore::PNGImageDecoder::filenameExtension):
        (WebCore::PNGImageDecoder::reader):
        * platform/image-decoders/skia/XBMImageDecoder.cpp: Added.
        * platform/image-decoders/skia/XBMImageDecoder.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-23 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 23 Jan 2009 19:58:29 +0000 (19:58 +0000)]
2009-01-23  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Turn on -Wmissing-prototypes and fix the resulting warnings.

        * Configurations/Base.xcconfig:
        * History/WebHistory.mm:
        (timeIntervalForBeginningOfDay):
        * History/WebHistoryItem.mm:
        (historyItemWrappers):
        * Misc/WebNSPasteboardExtras.mm:
        (imageFromElement):
        * WebView/WebFrame.mm:
        * WebView/WebScriptDebugger.mm:
        (toNSString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-23 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 23 Jan 2009 19:52:19 +0000 (19:52 +0000)]
2009-01-23  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Turn on -Wmissing-prototypes and fix the resulting warnings.

        * Configurations/Base.xcconfig:
        * bindings/js/JSHistoryCustom.cpp:
        (WebCore::nonCachingStaticBackFunctionGetter):
        (WebCore::nonCachingStaticForwardFunctionGetter):
        (WebCore::nonCachingStaticGoFunctionGetter):
        * bindings/js/JSLocationCustom.cpp:
        (WebCore::nonCachingStaticReplaceFunctionGetter):
        (WebCore::nonCachingStaticReloadFunctionGetter):
        (WebCore::nonCachingStaticAssignFunctionGetter):
        (WebCore::JSLocation::customGetOwnPropertySlot):
        * bindings/objc/DOMRGBColor.mm:
        (WebCore::getWrapperForRGB):
        (WebCore::setWrapperForRGB):
        (WebCore::removeWrapperForRGB):
        * bindings/scripts/CodeGeneratorJS.pm:
        * bridge/c/c_instance.cpp:
        (JSC::Bindings::globalExceptionString):
        * bridge/runtime_object.cpp:
        (JSC::callRuntimeConstructor):
        * css/CSSParser.cpp:
        (WebCore::parseGradientColorStop):
        * css/CSSPrimitiveValue.cpp:
        (WebCore::scaleFactorForConversion):
        * css/CSSStyleSelector.cpp:
        (WebCore::operator >):
        (WebCore::operator <=):
        (WebCore::getTransformOperationType):
        * dom/make_names.pl:
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::updatePositionForTextRemoval):
        * editing/EditorCommand.cpp:
        (WebCore::valueBackColor):
        (WebCore::valueFontName):
        (WebCore::valueFontSize):
        (WebCore::valueFontSizeDelta):
        (WebCore::valueForeColor):
        * editing/VisiblePosition.cpp:
        (WebCore::canonicalizeCandidate):
        * editing/htmlediting.cpp:
        * editing/markup.cpp:
        (WebCore::joinMarkups):
        * html/HTMLElement.cpp:
        (WebCore::inlineTagList):
        (WebCore::blockTagList):
        * html/HTMLMediaElement.cpp:
        (WebCore::serializeTimeOffset):
        (WebCore::parseTimeOffset):
        * page/mac/FrameMac.mm:
        (WebCore::regExpForLabels):
        * platform/Arena.cpp:
        * platform/graphics/Color.cpp:
        (WebCore::colorFloatToRGBAByte):
        * platform/graphics/cg/ImageSourceCG.cpp:
        (WebCore::imageSourceOptions):
        * platform/graphics/cg/PathCG.cpp:
        (WebCore::CGPathApplierToPathApplier):
        * platform/graphics/mac/SimpleFontDataMac.mm:
        (WebCore::initFontData):
        * platform/mac/PlatformMouseEventMac.mm:
        * platform/text/String.cpp:
        * rendering/RenderBlock.cpp:
        (WebCore::continuationOutlineTable):
        (WebCore::getHeightForLineCount):
        * rendering/RenderView.cpp:
        (WebCore::rendererAfterPosition):
        * rendering/RootInlineBox.cpp:
        (WebCore::isEditableLeaf):
        * rendering/SVGRenderTreeAsText.cpp:
        (WebCore::hasFractions):
        * rendering/style/RenderStyle.cpp:
        (WebCore::positionedObjectMoved):
        * svg/SVGFont.cpp:
        (WebCore::floatWidthUsingSVGFontCallback):
        (WebCore::floatWidthMissingGlyphCallback):
        (WebCore::drawTextUsingSVGFontCallback):
        (WebCore::drawTextMissingGlyphCallback):
        * svg/SVGTransformable.cpp:
        (WebCore::parseTransformParamList):
        * svg/graphics/SVGPaintServerGradient.cpp:
        (WebCore::operator<<):
        * xml/XPathGrammar.y:
        * xml/XSLTExtensions.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago No review, removing an empty file.
eric@webkit.org [Fri, 23 Jan 2009 19:42:22 +0000 (19:42 +0000)]
    No review, removing an empty file.

        Remove RemoveNodeAttributeCommand since it was empty.

        * WebCore.pro:
        * WebCore.scons:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * editing/RemoveNodeAttributeCommand.cpp: Removed.
        * editing/RemoveNodeAttributeCommand.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-23 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 23 Jan 2009 19:40:56 +0000 (19:40 +0000)]
2009-01-23  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Turn on -Wmissing-prototypes and fix the warnings.

        * API/JSClassRef.cpp:
        (clearReferenceToPrototype):
        * Configurations/Base.xcconfig:
        * runtime/Collector.cpp:
        (JSC::getPlatformThreadRegisters):
        * runtime/ExceptionHelpers.cpp:
        (JSC::createError):
        * runtime/JSGlobalObjectFunctions.h:
        * runtime/JSNumberCell.h:
        * runtime/UString.cpp:
        (JSC::initializeStaticBaseString):
        (JSC::createRep):
        * wtf/FastMalloc.cpp:
        * wtf/Threading.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-23 Brady Eidson <beidson@apple.com>
beidson@apple.com [Fri, 23 Jan 2009 19:16:59 +0000 (19:16 +0000)]
2009-01-23  Brady Eidson  <beidson@apple.com>

        Rubberstamped by Sam Weinig

        Rework ScriptCachedPageData to ScriptCachedFrameData to more accurately reflect its true purpose

        * GNUmakefile.am:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:

        * bindings/js/ScriptCachedFrameData.cpp: Copied from bindings/js/ScriptCachedPageData.cpp.
        (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
        (WebCore::ScriptCachedFrameData::domWindow):
        (WebCore::ScriptCachedFrameData::~ScriptCachedFrameData):
        (WebCore::ScriptCachedFrameData::restore):
        (WebCore::ScriptCachedFrameData::clear):
        * bindings/js/ScriptCachedFrameData.h: Copied from bindings/js/ScriptCachedPageData.h.
        * bindings/js/ScriptCachedPageData.cpp: Removed.
        * bindings/js/ScriptCachedPageData.h: Removed.

        * history/CachedPage.cpp:
        (WebCore::CachedPage::CachedPage):
        (WebCore::CachedPage::restore):
        * history/CachedPage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix build.
sfalken@apple.com [Fri, 23 Jan 2009 19:03:51 +0000 (19:03 +0000)]
    Fix build.

        * rendering/RenderThemeSafari.cpp:
        (WebCore::RenderThemeSafari::baselinePosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-23 Darin Fisher <darin@chromium.org>
darin@chromium.org [Fri, 23 Jan 2009 18:56:17 +0000 (18:56 +0000)]
2009-01-23  Darin Fisher  <darin@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=23506
        Copy existing ImageDecoder.h in preparation for landing Skia changes on top.

        * platform/image-decoders/skia/ImageDecoder.h: Copied from platform/image-decoders/ImageDecoder.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-23 Darin Fisher <darin@chromium.org>
darin@chromium.org [Fri, 23 Jan 2009 18:53:20 +0000 (18:53 +0000)]
2009-01-23  Darin Fisher  <darin@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=23506
        Copy existing image-decoders in preparation for landing Skia changes on top.

        * platform/image-decoders/skia: Added.
        * platform/image-decoders/skia/GIFImageDecoder.cpp: Copied from platform/image-decoders/gif/GIFImageDecoder.cpp.
        * platform/image-decoders/skia/GIFImageDecoder.h: Copied from platform/image-decoders/gif/GIFImageDecoder.h.
        * platform/image-decoders/skia/GIFImageReader.cpp: Copied from platform/image-decoders/gif/GIFImageReader.cpp.
        * platform/image-decoders/skia/GIFImageReader.h: Copied from platform/image-decoders/gif/GIFImageReader.h.
        * platform/image-decoders/skia/JPEGImageDecoder.cpp: Copied from platform/image-decoders/jpeg/JPEGImageDecoder.cpp.
        * platform/image-decoders/skia/JPEGImageDecoder.h: Copied from platform/image-decoders/jpeg/JPEGImageDecoder.h.
        * platform/image-decoders/skia/PNGImageDecoder.cpp: Copied from platform/image-decoders/png/PNGImageDecoder.cpp.
        * platform/image-decoders/skia/PNGImageDecoder.h: Copied from platform/image-decoders/png/PNGImageDecoder.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Oliver Hunt.
ap@webkit.org [Fri, 23 Jan 2009 16:57:16 +0000 (16:57 +0000)]
    Reviewed by Oliver Hunt.

        https://bugs.webkit.org/show_bug.cgi?id=23478
        Add a test for application test resource loading failure

        * http/tests/appcache/404-resource-expected.txt: Added.
        * http/tests/appcache/404-resource.html: Added.
        * http/tests/appcache/resources/404-resource.manifest: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix in RenderThemeGtk for RenderBox usage.
zecke@webkit.org [Fri, 23 Jan 2009 16:18:13 +0000 (16:18 +0000)]
Build fix in RenderThemeGtk for RenderBox usage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-23 David Levin <levin@chromium.org>
ap@webkit.org [Fri, 23 Jan 2009 16:07:37 +0000 (16:07 +0000)]
2009-01-23  David Levin  <levin@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Bug 22720: Make XMLHttpRequest work in Workers
        <https://bugs.webkit.org/show_bug.cgi?id=22720>

        Add copy/adopt for ResourceResponse(Base)/ResourceRequest(Base) to allow the
        data to be passed across threads.

        No observable change in behavior, so no test.

        * platform/network/FormData.cpp:
        (WebCore::FormData::deepCopy):
        * platform/network/FormData.h:
        * platform/network/HTTPHeaderMap.cpp:
        (WebCore::HTTPHeaderMap::copyData):
        (WebCore::HTTPHeaderMap::adopt):
        * platform/network/HTTPHeaderMap.h:
        * platform/network/ResourceRequestBase.cpp:
        (WebCore::ResourceRequestBase::adopt):
        (WebCore::ResourceRequestBase::copyData):
        * platform/network/ResourceRequestBase.h:
        * platform/network/ResourceResponseBase.cpp:
        (WebCore::ResourceResponseBase::adopt):
        (WebCore::ResourceResponseBase::copyData):
        * platform/network/ResourceResponseBase.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-23 Dmitry Titov <dimich@chromium.org>
ap@webkit.org [Fri, 23 Jan 2009 15:53:42 +0000 (15:53 +0000)]
2009-01-23  Dmitry Titov  <dimich@chromium.org>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=23374
        Add WorkerRunLoop to encapsulate message queue and timer heap.
        This is first half (timer heap is added as separate patch).

        * GNUmakefile.am: Added WorkerRunLoop.cpp to the build.
        * WebCore.vcproj/WebCore.vcproj: Same as above.
        * WebCore.xcodeproj/project.pbxproj: Same as above
        * dom/WorkerContext.cpp:
        (WebCore::WorkerContext::postTask):
        * dom/WorkerContext.h:
        * dom/WorkerMessagingProxy.cpp:
        (WebCore::WorkerMessagingProxy::postMessageToWorkerContext):
        (WebCore::WorkerMessagingProxy::workerThreadCreated):
        * dom/WorkerRunLoop.cpp: Added.
        (WebCore::WorkerRunLoop::run): Runs the loop until terminate() is called.
        (WebCore::WorkerRunLoop::terminate): Causes the loop to exit.
        (WebCore::WorkerRunLoop::postTask): Adds a task to the internal queue.
        * dom/WorkerRunLoop.h: Added.
        (WebCore::WorkerRunLoop::WorkerRunLoop):
        * dom/WorkerThread.cpp:
        (WebCore::WorkerThread::workerThread):
        (WebCore::WorkerThread::stop):
        * dom/WorkerThread.h:
        (WebCore::WorkerThread::runLoop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRedo previous patch http://trac.webkit.org/changeset/34260 which fixes a
treat@webkit.org [Fri, 23 Jan 2009 15:02:38 +0000 (15:02 +0000)]
Redo previous patch trac.webkit.org/changeset/34260 which fixes a
huge memory leak by ensuring that the timer is fired one last time on
application tear down thus triggering the GCController thereby freeing
JavaScript objects as well as triggering other timer based tear down methods.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Oliver Hunt.
ap@webkit.org [Fri, 23 Jan 2009 14:50:54 +0000 (14:50 +0000)]
    Reviewed by Oliver Hunt.

        https://bugs.webkit.org/show_bug.cgi?id=23459
        Workers are not properly terminated if execution hasn't begun yet

        Doesn't affect observable behavior, so test case is not possible.

        * dom/WorkerThread.cpp: (WebCore::WorkerThread::workerThread): Call forbidExecution() if
        it couldn't be called earlier.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-23 Ariya Hidayat <ariya.hidayat@trolltech.com>
ariya@webkit.org [Fri, 23 Jan 2009 13:29:42 +0000 (13:29 +0000)]
2009-01-23  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Simon Hausmann.

        Make the test more robust by taking into account the platform-specific
        cursor flashing time.

        * tests/qwebframe/tst_qwebframe.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-23 Ariya Hidayat <ariya.hidayat@trolltech.com>
ariya@webkit.org [Fri, 23 Jan 2009 12:39:32 +0000 (12:39 +0000)]
2009-01-23  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        [Qt] Fix the build after RenderBox refactoring in r40153.

        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::baselinePosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-23 Ariya Hidayat <ariya.hidayat@trolltech.com>
ariya@webkit.org [Fri, 23 Jan 2009 12:39:10 +0000 (12:39 +0000)]
2009-01-23  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Rubber-stamped by Alexey Proskuryakov.

        Fix the build after RenderBox refactoring in r40153.

        * plugins/PluginView.cpp:
        (WebCore::PluginView::invalidateWindowlessPluginRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-23 Ariya Hidayat <ariya.hidayat@trolltech.com>
ariya@webkit.org [Fri, 23 Jan 2009 12:38:47 +0000 (12:38 +0000)]
2009-01-23  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Simon Hausmann.

        [Qt] Simplify the assertion.

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::getWindowsContext):
        (WebCore::GraphicsContext::releaseWindowsContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLand updated layout tests (progressions) after border/padding move.
hyatt@apple.com [Fri, 23 Jan 2009 07:19:48 +0000 (07:19 +0000)]
Land updated layout tests (progressions) after border/padding move.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-22 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Fri, 23 Jan 2009 07:14:49 +0000 (07:14 +0000)]
2009-01-22  David Hyatt  <hyatt@apple.com>

        Move the border and padding methods from RenderObject to RenderBox.

        Reviewed by Oliver Hunt

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * editing/DeleteButtonController.cpp:
        (WebCore::DeleteButtonController::createDeletionUI):
        * page/EventHandler.cpp:
        (WebCore::EventHandler::hitTestResultAtPoint):
        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::placeBoxesVertically):
        * rendering/InlineFlowBox.h:
        (WebCore::InlineFlowBox::borderLeft):
        (WebCore::InlineFlowBox::borderRight):
        (WebCore::InlineFlowBox::paddingLeft):
        (WebCore::InlineFlowBox::paddingRight):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::clearFloats):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::paddingTop):
        (WebCore::RenderBox::paddingBottom):
        (WebCore::RenderBox::paddingLeft):
        (WebCore::RenderBox::paddingRight):
        (WebCore::RenderBox::calcHeight):
        (WebCore::RenderBox::containingBlockWidthForPositioned):
        (WebCore::RenderBox::containingBlockHeightForPositioned):
        (WebCore::RenderBox::calcAbsoluteHorizontal):
        (WebCore::RenderBox::calcAbsoluteHorizontalValues):
        (WebCore::RenderBox::calcAbsoluteVertical):
        (WebCore::RenderBox::calcAbsoluteVerticalValues):
        (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
        (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
        * rendering/RenderBox.h:
        (WebCore::RenderBox::borderTop):
        (WebCore::RenderBox::borderBottom):
        (WebCore::RenderBox::borderLeft):
        (WebCore::RenderBox::borderRight):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
        * rendering/RenderObject.h:
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::textBlockWidth):
        (WebCore::RenderTextControl::calcHeight):
        (WebCore::RenderTextControl::calcPrefWidths):
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::preferredContentWidth):
        * rendering/RenderTreeAsText.cpp:
        (WebCore::operator<<):
        * rendering/RenderView.cpp:
        (WebCore::RenderView::repaintViewRectangle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-22 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Fri, 23 Jan 2009 05:13:22 +0000 (05:13 +0000)]
2009-01-22  David Hyatt  <hyatt@apple.com>

        Devirtualize the marginTop/Right/Left/Bottom functions and move them to RenderBox (along with some of the
        other margin functions that have to come along for the ride).

        Reviewed by Oliver Hunt

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * editing/TextIterator.cpp:
        (WebCore::shouldEmitExtraNewlineForNode):
        * rendering/InlineBox.cpp:
        * rendering/InlineBox.h:
        (WebCore::InlineBox::renderBox):
        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::marginLeft):
        (WebCore::InlineFlowBox::marginRight):
        (WebCore::InlineFlowBox::placeBoxesHorizontally):
        (WebCore::InlineFlowBox::computeLogicalBoxHeights):
        (WebCore::InlineFlowBox::placeBoxesVertically):
        (WebCore::InlineFlowBox::shrinkBoxesWithNoTextChildren):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::isSelfCollapsingBlock):
        (WebCore::RenderBlock::adjustPositionedBlock):
        (WebCore::RenderBlock::handleCompactChild):
        (WebCore::RenderBlock::estimateVerticalPosition):
        (WebCore::getBorderPaddingMargin):
        (WebCore::RenderBlock::calcInlinePrefWidths):
        * rendering/RenderBlock.h:
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::calcHeight):
        * rendering/RenderBox.h:
        (WebCore::RenderBox::hasHorizontalBordersPaddingOrMargin):
        (WebCore::RenderBox::hasHorizontalBordersOrPadding):
        (WebCore::RenderBox::marginTop):
        (WebCore::RenderBox::marginBottom):
        (WebCore::RenderBox::marginLeft):
        (WebCore::RenderBox::marginRight):
        (WebCore::RenderBox::isSelfCollapsingBlock):
        (WebCore::RenderBox::collapsedMarginTop):
        (WebCore::RenderBox::collapsedMarginBottom):
        (WebCore::RenderBox::isTopMarginQuirk):
        (WebCore::RenderBox::isBottomMarginQuirk):
        (WebCore::RenderBox::maxTopMargin):
        (WebCore::RenderBox::maxBottomMargin):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::getAbsoluteRepaintRectWithOutline):
        * rendering/RenderObject.h:
        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::lineHeight):
        (WebCore::RenderSVGContainer::baselinePosition):
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::calcHeight):
        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::baselinePosition):
        * rendering/bidi.cpp:
        (WebCore::getBorderPaddingMargin):
        (WebCore::inlineWidth):
        (WebCore::RenderBlock::computeHorizontalPositionsForLine):
        (WebCore::inlineFlowRequiresLineBox):
        (WebCore::requiresLineBox):
        (WebCore::RenderBlock::findNextLineBreak):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoDisable GCC_WARN_ABOUT_MISSING_PROTOTYPES temporarily.
mrowe@apple.com [Fri, 23 Jan 2009 04:57:00 +0000 (04:57 +0000)]
Disable GCC_WARN_ABOUT_MISSING_PROTOTYPES temporarily.

Rubber-stamped by Anders Carlsson.

Current versions of Xcode only respect it for C and Objective-C files,
and our code doesn't currently compile if it is applied to C++ and
Objective-C++ files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix build bustage on Gtk.
hyatt@apple.com [Fri, 23 Jan 2009 04:30:47 +0000 (04:30 +0000)]
Fix build bustage on Gtk.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-22 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Fri, 23 Jan 2009 04:07:34 +0000 (04:07 +0000)]
2009-01-22  David Hyatt  <hyatt@apple.com>

        Move the m_widthChanged bit on RenderTableCell into RenderFlow's set of bits.  Let intrinsicPaddingTop and
        intrinsicPaddingBottom just be normal non-bitfield values.

        Reviewed by Oliver Hunt

        * rendering/RenderFlow.h:
        (WebCore::RenderFlow::RenderFlow):
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::RenderTableCell):
        (WebCore::RenderTableCell::updateWidth):
        (WebCore::RenderTableCell::layout):
        * rendering/RenderTableCell.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUpdate layout tests for table cell changes.
hyatt@apple.com [Fri, 23 Jan 2009 04:06:06 +0000 (04:06 +0000)]
Update layout tests for table cell changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUpdate layout tests for table cell changes.
hyatt@apple.com [Fri, 23 Jan 2009 04:05:26 +0000 (04:05 +0000)]
Update layout tests for table cell changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUpdate layout tests for table cell changes.
hyatt@apple.com [Fri, 23 Jan 2009 04:04:53 +0000 (04:04 +0000)]
Update layout tests for table cell changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUpdate layout tests for table cell changes.
hyatt@apple.com [Fri, 23 Jan 2009 04:03:48 +0000 (04:03 +0000)]
Update layout tests for table cell changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUpdate layout tests for table cell changes.
hyatt@apple.com [Fri, 23 Jan 2009 04:03:12 +0000 (04:03 +0000)]
Update layout tests for table cell changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-22 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Fri, 23 Jan 2009 03:55:34 +0000 (03:55 +0000)]
2009-01-22  David Hyatt  <hyatt@apple.com>

        Properly encapsulate m_frameRect.y() behind the RenderBox::y() method now that they are the same thing.
        Make m_frameRect private.

        Reviewed by Oliver Hunt

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paint):
        (WebCore::RenderBlock::clearFloats):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::offsetTop):
        (WebCore::RenderBox::nodeAtPoint):
        (WebCore::RenderBox::paint):
        (WebCore::RenderBox::paintCustomHighlight):
        (WebCore::RenderBox::containingBlockWidth):
        (WebCore::RenderBox::localToAbsolute):
        (WebCore::RenderBox::offsetFromContainer):
        (WebCore::RenderBox::computeAbsoluteRepaintRect):
        (WebCore::RenderBox::repaintDuringLayoutIfMoved):
        * rendering/RenderContainer.cpp:
        (WebCore::RenderContainer::layout):
        * rendering/RenderFlexibleBox.cpp:
        (WebCore::RenderFlexibleBox::layoutBlock):
        * rendering/RenderFrameSet.cpp:
        (WebCore::RenderFrameSet::paint):
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::paintReplaced):
        (WebCore::RenderImage::nodeAtPoint):
        * rendering/RenderListMarker.cpp:
        (WebCore::RenderListMarker::paint):
        (WebCore::RenderListMarker::getRelativeMarkerRect):
        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::paint):
        (WebCore::RenderReplaced::shouldPaint):
        * rendering/RenderReplica.cpp:
        (WebCore::RenderReplica::paint):
        * rendering/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::applyContentTransforms):
        (WebCore::RenderSVGRoot::paint):
        (WebCore::RenderSVGRoot::absoluteTransform):
        (WebCore::RenderSVGRoot::nodeAtPoint):
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::calcWidth):
        (WebCore::RenderTable::layout):
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::paint):
        (WebCore::RenderTableCell::paintBackgroundsBehindCell):
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::setCellWidths):
        (WebCore::RenderTableSection::calcRowHeight):
        (WebCore::RenderTableSection::layoutRows):
        (WebCore::RenderTableSection::paint):
        (WebCore::RenderTableSection::nodeAtPoint):
        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-22 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Fri, 23 Jan 2009 03:42:12 +0000 (03:42 +0000)]
2009-01-22  David Hyatt  <hyatt@apple.com>

        Fix for https://bugs.webkit.org/show_bug.cgi?id=23487.

        This patch completely reworks vertical alignment of table cells.  The current system uses methods called borderTopExtra() and borderBottomExtra() to
        add extra space above and below the content of a cell.  This system was not confined to the table code and spilled out into all the other RenderObjects.
        The y-position of the table cell box was set to the outer edge of the cell, but the y() method of RenderBox lied and added in borderTopExtra().  height()
        also excluded the extra space, so did not accurately reflect the true size of the cell.

        With the new system, the table cell box is completely accurate.  The extra space becomes part of the padding of the cell.  Padding has been reworked so that
        additional intrinsic padding can be added on to the specified padding from style.  Only the table code has to deal with the extra cell padding.

        localToAbsoluteForContent has now been removed, since there no longer has to be a special hacked content box.

        A number of table layout tests progress with this change, since the new layout system actually fixes existing bugs in baseline alignment of cells.

        Reviewed by Oliver Hunt

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        Make CSSComputedStyleDeclaration ask for padding values that exclude the built-in intrinsic padding.  This ensures that getComputedStyle continues
        to give the right answer.

        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::getLowerRightCorner):
        * editing/visible_units.cpp:
        (WebCore::previousLinePosition):
        (WebCore::nextLinePosition):
        * rendering/LayoutState.cpp:
        (WebCore::LayoutState::LayoutState):
        Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::overflowRect):
        Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.

        (WebCore::RenderBlock::layoutBlock):
        (WebCore::RenderBlock::expandsToEncloseOverhangingFloats):
        The expandsToEncloseOverhangingFloats logic has been reworked.  Table cells and fieldsets did not properly handle floats that spilled into the bottom padding.  The
        resulting box needed to not only expand to encompass the float, but also needed to place the full bottom padding after the float.  The switch to make the extra table cell
        space into padding exposed this issue.  No extra layout test is required, since an existing table layout test exposes this issue and progresses to match Firefox with
        this change.

        (WebCore::RenderBlock::selectionGapRects):
        (WebCore::RenderBlock::paintSelection):
        (WebCore::RenderBlock::fillSelectionGaps):
        (WebCore::RenderBlock::nodeAtPoint):
        (WebCore::RenderBlock::positionForCoordinates):
        (WebCore::RenderBlock::offsetForContents):
        Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.

        * rendering/RenderBlock.h:
        Add the new simplified method for expanding to encompass overhanging floats.  The method has been devirtualized and made to include all of the cases (and not just a subset).

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::absoluteRects):
        (WebCore::RenderBox::absoluteQuads):
        (WebCore::RenderBox::absoluteContentBox):
        (WebCore::RenderBox::paintBoxDecorations):
        (WebCore::RenderBox::paintMask):
        (WebCore::RenderBox::getOverflowClipRect):
        (WebCore::RenderBox::localToAbsolute):
        (WebCore::RenderBox::absoluteToLocal):
        (WebCore::RenderBox::localToAbsoluteQuad):
        Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.

        * rendering/RenderBox.h:
        (WebCore::RenderBox::y):
        (WebCore::RenderBox::location):
        (WebCore::RenderBox::borderBoxRect):
        (WebCore::RenderBox::offsetHeight):
        Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.

        * rendering/RenderContainer.cpp:
        (WebCore::RenderContainer::addLineBoxRects):
        * rendering/RenderFieldset.cpp:
        (WebCore::RenderFieldset::paintBoxDecorations):
        (WebCore::RenderFieldset::paintMask):
        * rendering/RenderFieldset.h:
        (WebCore::RenderFieldset::avoidsFloats):
        * rendering/RenderFlow.cpp:
        (WebCore::RenderFlow::localCaretRect):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::updateLayerPosition):
        (WebCore::RenderLayer::paintLayer):
        (WebCore::RenderLayer::hitTestLayer):
        (WebCore::RenderLayer::boundingBox):
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::isPointInOverflowControl):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::localToAbsolute):
        (WebCore::RenderObject::absoluteToLocal):
        (WebCore::RenderObject::localToAbsoluteQuad):
        (WebCore::RenderObject::offsetFromContainer):
        (WebCore::RenderObject::paddingTop):
        (WebCore::RenderObject::paddingBottom):
        (WebCore::RenderObject::paddingLeft):
        (WebCore::RenderObject::paddingRight):
        * rendering/RenderObject.h:
        (WebCore::RenderObject::hasOverhangingFloats):
        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::selectionRect):
        (WebCore::RenderReplaced::localSelectionRect):
        Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.  Also modifed paddingLeft/Top/Right/Bottom to take an argument indicating
        whether or not the intrinsic padding of an object should be included (by default it is).  getComputedStyle needs to exclude it, which is why this argument is
        necessary.

        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::RenderTableCell):
        (WebCore::RenderTableCell::paddingTop):
        (WebCore::RenderTableCell::paddingBottom):
        The new paddingTop() and paddingBottom() methods on table cells include the extra intrinsic padding.

        (WebCore::RenderTableCell::setOverrideSize):
        When a table's override size gets altered, the intrinsic padding needs to be cleared.

        (WebCore::RenderTableCell::absoluteClippedOverflowRect):
        (WebCore::RenderTableCell::computeAbsoluteRepaintRect):
        (WebCore::RenderTableCell::baselinePosition):
        (WebCore::RenderTableCell::paint):
        (WebCore::RenderTableCell::paintBackgroundsBehindCell):
        (WebCore::RenderTableCell::paintBoxDecorations):
        (WebCore::RenderTableCell::paintMask):
        Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.

        * rendering/RenderTableCell.h:
        (WebCore::RenderTableCell::setIntrinsicPaddingTop):
        (WebCore::RenderTableCell::setIntrinsicPaddingBottom):
        (WebCore::RenderTableCell::setIntrinsicPadding):
        (WebCore::RenderTableCell::clearIntrinsicPadding):
        (WebCore::RenderTableCell::intrinsicPaddingTop):
        (WebCore::RenderTableCell::intrinsicPaddingBottom):
        Add new helper methods for getting/setting a cell's intrinsic padding.

        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::calcRowHeight):
        calcRowHeight has been modified to exclude the intrinsic padding when calculating the base height of rows prior to flexing.  Because a cell now includes that
        extra space, it has to be subtracted out in this method.

        (WebCore::RenderTableSection::layoutRows):
        Modify the code that sets up the intrinsic padding so that it does a relayout if the intrinsic padding changes.   There was also an error where the baseline
        position mismatched leading to negative intrinsic padding being added in (this error exists in ToT).  The code now properly ignores cells that don't establish
        a baseline.  A number of tests progress with this change.

        * rendering/RenderText.cpp:
        (WebCore::RenderText::addLineBoxRects):
        Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.

        * rendering/RenderTreeAsText.cpp:
        (WebCore::operator<<):
        (WebCore::writeTextRun):
        Modify the render tree dumping code to continue to produce the same results as before.  This is really a hack, since we're now capable of indicating the correct
        position for the descendants of cells with intrinsic padding (and also indicating what the correct cell box is).  A future patch can remove these hacks so that the
        layout test results can all be regenerated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago https://bugs.webkit.org/show_bug.cgi?id=23489
sfalken@apple.com [Fri, 23 Jan 2009 02:30:29 +0000 (02:30 +0000)]
    https://bugs.webkit.org/show_bug.cgi?id=23489

        Return currentTime() in correct units for the two early return cases.

        Reviewed by Mark Rowe.

        * wtf/CurrentTime.cpp:
        (WTF::currentTime):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-22 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 23 Jan 2009 01:01:31 +0000 (01:01 +0000)]
2009-01-22  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Add support for Invoke and InvokeDefault. Clean up code.

        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCBooleanReply):
        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        (WebKit::NetscapePluginInstanceProxy::Reply::):
        (WebKit::NetscapePluginInstanceProxy::BooleanReply::BooleanReply):
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
        * Plugins/Hosted/ProxyInstance.h:
        * Plugins/Hosted/ProxyInstance.mm:
        (WebKit::ProxyInstance::invoke):
        (WebKit::ProxyInstance::invokeMethod):
        (WebKit::ProxyInstance::supportsInvokeDefaultMethod):
        (WebKit::ProxyInstance::invokeDefaultMethod):
        (WebKit::ProxyInstance::methodsNamed):
        (WebKit::ProxyInstance::fieldNamed):
        * Plugins/Hosted/WebKitPluginClient.defs:
        * Plugins/Hosted/WebKitPluginHost.defs:
        * Plugins/Hosted/WebKitPluginHostTypes.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Justin Garcia.
eric@webkit.org [Fri, 23 Jan 2009 00:46:58 +0000 (00:46 +0000)]
    Reviewed by Justin Garcia.

        Remove <span> turds left by editing commands
        https://bugs.webkit.org/show_bug.cgi?id=23466

        Tests:
        * editing/execCommand/empty-span-removal.html
        * editing/execCommand/toggle-styles.html

        * editing/ApplyStyleCommand.cpp:
        (WebCore::styleSpanClassString):
        (WebCore::isStyleSpan):
        (WebCore::isUnstyledStyleSpan):
        (WebCore::isSpanWithoutAttributesOrUnstyleStyleSpan):
        (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
        (WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):
        (WebCore::ApplyStyleCommand::removeHTMLBidiEmbeddingStyle):
        (WebCore::ApplyStyleCommand::removeCSSStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-22 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 22 Jan 2009 23:24:30 +0000 (23:24 +0000)]
2009-01-22  Anders Carlsson  <andersca@apple.com>

        Fix Windows build.

        * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Eric Seidel.
zimmermann@webkit.org [Thu, 22 Jan 2009 22:53:47 +0000 (22:53 +0000)]
Reviewed by Eric Seidel.

Rename some of the casting functions in dom/*Element.cpp:
formControlElementForElement -> toFormControlElement
inputElementForElement -> toInputElement
optionElementForElement -> toOptionElement
optionGroupElementForElement -> toOptionGroupElement

Suggested by Alexey, while refactoring the Element*->ScriptElement* code.
The Element*->ScriptElement* helper function is already named 'toScriptElement'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-22 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 22 Jan 2009 22:48:26 +0000 (22:48 +0000)]
2009-01-22  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Fix for <rdar://problem/6439247>
        FastMalloc allocating an extra 4MB of meta-data on 64-bit

        Rely on the fact that on all known x86-64 platforms only use 48 bits of
        address space to shrink the initial size of the PageMap from ~4MB to 120K.
        For 64-bit we still use a 3-level radix tree, but now each level is only 12
        bits wide.

        No performance change.

        * wtf/FastMalloc.cpp:
        (WTF::MapSelector): Add specialization for 64 bit that takes into account the
        16 bits of unused address space on x86-64.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRubber-stamped by George Staikos.
zimmermann@webkit.org [Thu, 22 Jan 2009 22:24:03 +0000 (22:24 +0000)]
Rubber-stamped by George Staikos.
Forgot to include in my last commit: Activate code depending on WMLOptionElement/WMLOptGroupElement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by George Staikos.
zimmermann@webkit.org [Thu, 22 Jan 2009 22:04:49 +0000 (22:04 +0000)]
Reviewed by George Staikos.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=23454

Add WML <option>/<optgroup> element support.
Currently the implementation is stubbed, all relevant parts can be enabled
once WMLSelectElement/SelectElement has been created.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
bdakin@apple.com [Thu, 22 Jan 2009 21:51:47 +0000 (21:51 +0000)]
JavaScriptCore:

2009-01-22  Beth Dakin  <bdakin@apple.com>

        Reviewed by Sam Weinig.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=23461 LayoutTests/
        fast/js/numeric-conversion.html is broken, and corresponding
        <rdar://problem/6514842>

        The basic problem here is that parseInt(Infinity) should be NaN,
        but we were returning 0. NaN matches Safari 3.2.1 and Firefox.

        * runtime/JSGlobalObjectFunctions.cpp:
        (JSC::globalFuncParseInt):

LayoutTests:

2009-01-22  Beth Dakin  <bdakin@apple.com>

        Reviewed by Sam Weinig.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=23461 LayoutTests/
        fast/js/numeric-conversion.html is broken, and corresponding
        <rdar://problem/6514842>

        The basic problem here is that parseInt(Infinity) should be NaN,
        but we were returning 0. NaN matches Safari 3.2.1 and Firefox.

        * fast/js/numeric-conversion-expected.txt:
        * fast/js/resources/numeric-conversion.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
dglazkov@chromium.org [Thu, 22 Jan 2009 21:16:25 +0000 (21:16 +0000)]
WebCore:

2009-01-22  Eric Roman  <eroman@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=20806
        Send referrer for history navigations.

        Test: http/tests/navigation/back-send-referrer.html

        Consolidates HistoryItem::rssFeedReferrer and HistoryItem::formReferrer into a single HistoryItem::referrer property.

        * history/HistoryItem.cpp:
        (WebCore::HistoryItem::HistoryItem):
        (WebCore::HistoryItem::referrer):
        (WebCore::HistoryItem::setReferrer):
        (WebCore::HistoryItem::formReferrer):
        (WebCore::HistoryItem::rssFeedReferrer):
        (WebCore::HistoryItem::setRSSFeedReferrer):
        (WebCore::HistoryItem::setFormInfoFromRequest):
        * history/HistoryItem.h:
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::loadItem):

WebKit/win:

2009-01-22  Eric Roman  <eroman@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=20806
        Deprecate RSSFeedReferrer() and setRSSFeedReferrer().

        * WebHistoryItem.cpp:
        (WebHistoryItem::RSSFeedReferrer):
        (WebHistoryItem::setRSSFeedReferrer):

WebKit/mac:

2009-01-22  Eric Roman  <eroman@chromium.og>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=20806
        Deprecate RSSFeedReferrer() and setRSSFeedReferrer().

        * History/WebHistoryItem.mm:
        (-[WebHistoryItem RSSFeedReferrer]):
        (-[WebHistoryItem setRSSFeedReferrer:]):

LayoutTests:

2009-01-22  Eric Roman  <eroman@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=20806
        "Referer" header not sent for history navigation.

        * http/tests/navigation/back-send-referrer-expected.txt: Added.
        * http/tests/navigation/back-send-referrer.html: Added.
        * http/tests/navigation/resources/back-send-referrer-helper.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/6516853> (r39682-r39736) JSFunFuzz: crash on "(function(){({ x2:...
oliver@apple.com [Thu, 22 Jan 2009 21:07:14 +0000 (21:07 +0000)]
<rdar://problem/6516853> (r39682-r39736) JSFunFuzz: crash on "(function(){({ x2: x }), })()"
<https://bugs.webkit.org/show_bug.cgi?id=23479>

Reviewed by Geoff Garen.

Automatic semicolon insertion was resulting in this being accepted in the initial
nodeless parsing, but subsequent reparsing for code generation would fail, leading
to a crash.  The solution is to ensure that reparsing a function performs parsing
in the same state as the initial parse.  We do this by modifying the saved source
ranges to include rather than exclude the opening and closing braces.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Eric Seidel.
zimmermann@webkit.org [Thu, 22 Jan 2009 20:40:18 +0000 (20:40 +0000)]
Reviewed by Eric Seidel.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=23465

Further enhancments to share code between HTMLOptionElement and the upcoming WMLOptionElement.

Rename optionText() to textIndentedToRespectGroupLabel() in (HTML)OptionElement, as it fits better.
optionText() returns the options text prefixed with some spaces, in case it got an optgroup parent.

Add two more pure-virtual functions to OptionElement: setSelectedState(bool) & value().
These aren't used outside of html/ at the moment (unlike the other pure-virtual functions
used by RenderMenuList/RenderListBox) - but they will be used by SelectElement, once it exists.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-22 Chris Fleizach <cfleizach@apple.com>
cfleizach@apple.com [Thu, 22 Jan 2009 20:30:32 +0000 (20:30 +0000)]
2009-01-22  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Justin Garcia.

        Bug 23464: Infinite recursion at SelectionController::setSelection
        https://bugs.webkit.org/show_bug.cgi?id=23464

        Check for conditions leading to infinite recursion.

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::setSelection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-22 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 22 Jan 2009 20:12:47 +0000 (20:12 +0000)]
2009-01-22  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Clean up the test plug-in code. We now always use the CG drawing model and the
        Cocoa event model. It is however possible to revert to the old Carbon event model by
        specifying forcecarbon=true in the embed/object tag.

        * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
        * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
        (NPP_New):
        (handleEventCarbon):
        (handleEventCocoa):
        (NPP_HandleEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-22 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 22 Jan 2009 19:06:18 +0000 (19:06 +0000)]
2009-01-22  Anders Carlsson  <andersca@apple.com>

        Reviewed by Kevin Decker.

        Don't crash or hang when we fail to instantiate a plug-in.

        * Plugins/Hosted/NetscapePluginHostManager.mm:
        (WebKit::NetscapePluginHostManager::instantiatePlugin):
        Return 0 on failure.

        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (-[WebHostedNetscapePluginView JSC::Bindings::createPluginBindingsInstance:JSC::Bindings::]):
        Null check for the proxy member.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoNot reviewed. Fix WML build problem in RenderBox.cpp, WMLNames is undefined.
zimmermann@webkit.org [Thu, 22 Jan 2009 18:55:42 +0000 (18:55 +0000)]
Not reviewed. Fix WML build problem in RenderBox.cpp, WMLNames is undefined.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix the Qt build after RenderBox changes.
treat@webkit.org [Thu, 22 Jan 2009 15:29:25 +0000 (15:29 +0000)]
Fix the Qt build after RenderBox changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-22 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Thu, 22 Jan 2009 09:41:39 +0000 (09:41 +0000)]
2009-01-22  David Hyatt  <hyatt@apple.com>

        Fix regressions in list box selection on Mac.  The wrong color was being used for the list box
        background, and list box colors actually weren't even being properly fetched because of a bug in
        the RenderTheme base class.  Existing pixel tests cover the bug fix.

        Reviewed by Jon Honeycutt

        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::activeListBoxSelectionBackgroundColor):
        (WebCore::RenderTheme::inactiveListBoxSelectionBackgroundColor):
        (WebCore::RenderTheme::activeListBoxSelectionForegroundColor):
        (WebCore::RenderTheme::inactiveListBoxSelectionForegroundColor):
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::platformInactiveListBoxSelectionBackgroundColor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-22 David Levin <levin@chromium.org>
ap@webkit.org [Thu, 22 Jan 2009 08:58:16 +0000 (08:58 +0000)]
2009-01-22  David Levin  <levin@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Bug 22720: Make XMLHttpRequest work in Workers
        <https://bugs.webkit.org/show_bug.cgi?id=22720>

        Add copy/adopt for HTTPHeaderMap to allow the data to be passed across threads.

        No observable change in behavior, so no test.

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.scons:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * platform/network/HTTPHeaderMap.cpp: Added.
        (WebCore::HTTPHeaderMap::copyData):
        (WebCore::HTTPHeaderMap::adopt):
        * platform/network/HTTPHeaderMap.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-22 Dmitry Titov <dimich@chromium.org>
ap@webkit.org [Thu, 22 Jan 2009 08:32:45 +0000 (08:32 +0000)]
2009-01-22  Dmitry Titov  <dimich@chromium.org>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=23373

        Implement ThreadCondition::timedWait().
        Since we borrow the code for condition variables from other sources,
        I did the same for timedWait(). See comments in ThreadingWin.cpp for
        rationale and more info.

        * wtf/CONTRIBUTORS.pthreads-win32:
        Added. A list of Pthreads-win32 contributors mentioned in their license. The license itself
        is included into wtf/ThreadingWin32.cpp.

        * wtf/Threading.h:
        * wtf/ThreadingWin.cpp:
        Additional info and Pthreads-win32 license at the beginning.
        (WTF::PlatformCondition::timedWait): new method, derived from Pthreads-win32.
        (WTF::PlatformCondition::signal): same
        (WTF::ThreadCondition::ThreadCondition):
        (WTF::ThreadCondition::~ThreadCondition):
        (WTF::ThreadCondition::wait): this now calls PlatformCondition::timedWait.
        (WTF::ThreadCondition::timedWait): same
        (WTF::ThreadCondition::signal): this now calls PlatformCondition::signal.
        (WTF::ThreadCondition::broadcast): same

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix build bustage in WML from RenderBox changes.
hyatt@apple.com [Thu, 22 Jan 2009 08:15:16 +0000 (08:15 +0000)]
Fix build bustage in WML from RenderBox changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix Gtk build bustage.
hyatt@apple.com [Thu, 22 Jan 2009 08:12:35 +0000 (08:12 +0000)]
Fix Gtk build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix Qt build bustage.
hyatt@apple.com [Thu, 22 Jan 2009 08:11:09 +0000 (08:11 +0000)]
Fix Qt build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-21 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Thu, 22 Jan 2009 07:54:25 +0000 (07:54 +0000)]
2009-01-21  David Hyatt  <hyatt@apple.com>

        Back out a portion of my patch that I did not mean to land.  Revert paintOutline back to the way it
        was before my landing.  Fixes failing SVG focus ring tests.

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::paintOutline):
        * rendering/RenderObject.h:
        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::paint):
        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-21 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Thu, 22 Jan 2009 07:19:19 +0000 (07:19 +0000)]
2009-01-21  David Hyatt  <hyatt@apple.com>

        Fix Node's renderBox() method on Windows.

        * dom/Node.cpp:
        (WebCore::Node::renderBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-21 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Thu, 22 Jan 2009 07:05:57 +0000 (07:05 +0000)]
2009-01-21  David Hyatt  <hyatt@apple.com>

        Fix RenderThemeSafari bustage on Win32.

        * rendering/RenderThemeSafari.cpp:
        (WebCore::RenderThemeSafari::baselinePosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-21 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Thu, 22 Jan 2009 06:58:18 +0000 (06:58 +0000)]
2009-01-21  David Hyatt  <hyatt@apple.com>

        Fix bustage in RenderThemeWin. It's actually terrible that RenderThemeWin is using absoluteContentBox,
        but that's a problem for another day.

        * rendering/RenderThemeWin.cpp:
        (WebCore::RenderThemeWin::paintSearchFieldCancelButton):
        (WebCore::RenderThemeWin::paintSearchFieldResultsDecoration):
        (WebCore::RenderThemeWin::paintSearchFieldResultsButton):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBecause bdash hates freedom (tyop fix).
barraclough@apple.com [Thu, 22 Jan 2009 05:59:46 +0000 (05:59 +0000)]
Because bdash hates freedom (tyop fix).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40114 268f45cc-cd09-0410-ab3c-d52691b4dbfc