WebKit-https.git
7 years agoUnreviewed, rebaselining after changes in r115846.
zandobersek@gmail.com [Wed, 2 May 2012 19:46:34 +0000 (19:46 +0000)]
Unreviewed, rebaselining after changes in r115846.

* fast/repaint/table-hover-on-link-expected.txt:
* platform/gtk/editing/inserting/before-after-input-element-expected.txt:
* platform/gtk/editing/pasteboard/4806874-expected.txt:
* platform/gtk/editing/pasteboard/input-field-1-expected.txt:
* platform/gtk/editing/selection/3690703-2-expected.txt:
* platform/gtk/editing/selection/3690703-expected.txt:
* platform/gtk/editing/selection/3690719-expected.txt:
* platform/gtk/editing/selection/4895428-3-expected.txt:
* platform/gtk/editing/selection/4975120-expected.txt:
* platform/gtk/editing/selection/drag-select-1-expected.txt:
* platform/gtk/editing/selection/select-across-readonly-input-1-expected.txt:
* platform/gtk/editing/selection/select-across-readonly-input-4-expected.txt:
* platform/gtk/editing/selection/select-across-readonly-input-5-expected.txt:
* platform/gtk/editing/selection/select-from-textfield-outwards-expected.txt:
* platform/gtk/editing/spelling/inline_spelling_markers-expected.txt:
* platform/gtk/fast/block/float/032-expected.txt:
* platform/gtk/fast/block/float/033-expected.txt:
* platform/gtk/fast/block/float/avoidance-rtl-expected.txt:
* platform/gtk/fast/block/float/float-not-removed-from-next-sibling3-expected.txt:
* platform/gtk/fast/block/float/float-overflow-hidden-containing-block-width-expected.txt:
* platform/gtk/fast/block/float/in-margin-expected.txt:
* platform/gtk/fast/block/float/overlapping-floats-with-overflow-hidden-expected.txt:
* platform/gtk/fast/block/float/shrink-to-avoid-float-complexity-expected.txt:
* platform/gtk/fast/block/lineboxcontain/parsing-invalid-expected.txt:
* platform/gtk/fast/block/margin-collapse/103-expected.txt:
* platform/gtk/fast/clip/008-expected.txt:
* platform/gtk/fast/clip/011-expected.txt:
* platform/gtk/fast/clip/012-expected.txt:
* platform/gtk/fast/clip/017-expected.txt:
* platform/gtk/fast/css/input-search-padding-expected.txt:
* platform/gtk/fast/css/invalidation-errors-2-expected.txt:
* platform/gtk/fast/css/invalidation-errors-expected.txt:
* platform/gtk/fast/css/text-overflow-input-expected.txt:
* platform/gtk/fast/dom/isindex-001-expected.txt:
* platform/gtk/fast/dom/isindex-002-expected.txt:
* platform/gtk/fast/dynamic/subtree-boundary-percent-height-expected.txt:
* platform/gtk/fast/dynamic/subtree-no-common-root-static-y-expected.txt:
* platform/gtk/fast/dynamic/subtree-table-cell-height-expected.txt:
* platform/gtk/fast/events/autoscroll-expected.txt:
* platform/gtk/fast/events/context-no-deselect-expected.txt:
* platform/gtk/fast/forms/box-shadow-override-expected.txt:
* platform/gtk/fast/forms/encoding-test-expected.txt:
* platform/gtk/fast/forms/fieldset-align-expected.txt:
* platform/gtk/fast/forms/input-appearance-bkcolor-expected.txt:
* platform/gtk/fast/forms/input-appearance-focus-expected.txt:
* platform/gtk/fast/forms/input-appearance-height-expected.txt:
* platform/gtk/fast/forms/input-appearance-readonly-expected.txt:
* platform/gtk/fast/forms/input-appearance-selection-expected.txt:
* platform/gtk/fast/forms/input-appearance-width-expected.txt:
* platform/gtk/fast/forms/input-baseline-expected.txt:
* platform/gtk/fast/forms/input-double-click-selection-gap-bug-expected.txt:
* platform/gtk/fast/forms/input-field-text-truncated-expected.txt:
* platform/gtk/fast/forms/input-placeholder-visibility-1-expected.txt:
* platform/gtk/fast/forms/input-readonly-autoscroll-expected.txt:
* platform/gtk/fast/forms/input-readonly-empty-expected.txt:
* platform/gtk/fast/forms/input-table-expected.txt:
* platform/gtk/fast/forms/input-text-click-inside-expected.txt:
* platform/gtk/fast/forms/input-text-click-outside-expected.txt:
* platform/gtk/fast/forms/input-text-double-click-expected.txt:
* platform/gtk/fast/forms/input-text-drag-down-expected.txt:
* platform/gtk/fast/forms/input-text-scroll-left-on-blur-expected.txt:
* platform/gtk/fast/forms/input-text-self-emptying-click-expected.txt:
* platform/gtk/fast/forms/input-width-expected.txt:
* platform/gtk/fast/forms/placeholder-position-expected.txt:
* platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.txt:
* platform/gtk/fast/forms/search-rtl-expected.txt:
* platform/gtk/fast/forms/search-styled-expected.txt:
* platform/gtk/fast/forms/searchfield-heights-expected.txt:
* platform/gtk/fast/forms/tabbing-input-iframe-expected.txt:
* platform/gtk/fast/forms/textfield-focus-ring-expected.txt:
* platform/gtk/fast/forms/textfield-overflow-expected.txt:
* platform/gtk/fast/forms/validation-message-appearance-expected.txt:
* platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
* platform/gtk/fast/html/details-no-summary4-expected.txt:
* platform/gtk/fast/html/details-open-javascript-expected.txt:
* platform/gtk/fast/html/details-open2-expected.txt:
* platform/gtk/fast/html/details-open4-expected.txt:
* platform/gtk/fast/invalid/residual-style-expected.txt:
* platform/gtk/fast/layers/add-layer-with-nested-stacking-expected.txt:
* platform/gtk/fast/layers/remove-layer-with-nested-stacking-expected.txt:
* platform/gtk/fast/layers/self-painting-outline-expected.txt:
* platform/gtk/fast/multicol/layers-split-across-columns-expected.txt:
* platform/gtk/fast/overflow/004-expected.txt:
* platform/gtk/fast/overflow/clip-rects-fixed-ancestor-expected.txt:
* platform/gtk/fast/overflow/overflow-focus-ring-expected.txt:
* platform/gtk/fast/repaint/inline-relative-positioned-expected.txt:
* platform/gtk/fast/repaint/layer-outline-expected.txt:
* platform/gtk/fast/repaint/layer-outline-horizontal-expected.txt:
* platform/gtk/fast/repaint/opacity-change-on-overflow-float-expected.txt:
* platform/gtk/fast/repaint/overflow-clip-subtree-layout-expected.txt:
* platform/gtk/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
* platform/gtk/fast/repaint/repaint-resized-overflow-expected.txt:
* platform/gtk/fast/repaint/subtree-layoutstate-transform-expected.txt:
* platform/gtk/fast/repaint/subtree-root-clip-2-expected.txt:
* platform/gtk/fast/repaint/subtree-root-clip-3-expected.txt:
* platform/gtk/fast/repaint/subtree-root-clip-expected.txt:
* platform/gtk/fast/repaint/subtree-root-skipped-expected.txt:
* platform/gtk/fast/replaced/replaced-breaking-expected.txt:
* platform/gtk/fast/replaced/replaced-breaking-mixture-expected.txt:
* platform/gtk/fast/table/003-expected.txt:
* platform/gtk/fast/table/029-expected.txt:
* platform/gtk/fast/table/colspanMinWidth-expected.txt:
* platform/gtk/fast/table/overflowHidden-expected.txt:
* platform/gtk/fast/table/text-field-baseline-expected.txt:
* platform/gtk/fast/text/selection-painted-separately-expected.txt:
* platform/gtk/fast/text/selection-rect-rounding-expected.txt:
* platform/gtk/fast/text/textIteratorNilRenderer-expected.txt:
* platform/gtk/fast/transforms/transformed-focused-text-input-expected.txt:
* platform/gtk/http/tests/navigation/javascriptlink-frames-expected.txt:
* platform/gtk/plugins/mouse-click-plugin-clears-selection-expected.txt:
* platform/gtk/svg/custom/inline-svg-in-xhtml-expected.txt:
* platform/gtk/tables/mozilla/bugs/45621-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug1188-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug12384-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug24200-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug2479-2-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug2479-3-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug2479-4-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug28928-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug4382-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug44505-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug4527-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug55545-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug7342-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug99948-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug45621-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, changing test expectations due to https://bugs.webkit.org/show_bug.cgi...
fpizlo@apple.com [Wed, 2 May 2012 19:41:18 +0000 (19:41 +0000)]
Unreviewed, changing test expectations due to https://bugs.webkit.org/show_bug.cgi?id=85404

* platform/mac/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-05-02 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 2 May 2012 19:37:09 +0000 (19:37 +0000)]
2012-05-02  Nate Chapin  <japhet@chromium.org>

        Unreviewed, expectations updates after r115774.

        * platform/chromium-win/http/tests/loading/pdf-commit-load-callbacks-expected.txt: Added.
        * platform/chromium/test_expectations.txt:
        * platform/gtk/http/tests/loading/pdf-commit-load-callbacks-expected.txt: Added.
        * platform/gtk/test_expectations.txt:
        * platform/qt/Skipped:
        * platform/qt/http/tests/loading/pdf-commit-load-callbacks-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, changing test expectations due to https://bugs.webkit.org/show_bug.cgi...
fpizlo@apple.com [Wed, 2 May 2012 19:28:28 +0000 (19:28 +0000)]
Unreviewed, changing test expectations due to https://bugs.webkit.org/show_bug.cgi?id=85401

* platform/mac/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRevert r115191 - "Make the web view's url property follow the active url"
vestbo@webkit.org [Wed, 2 May 2012 19:19:24 +0000 (19:19 +0000)]
Revert r115191 - "Make the web view's url property follow the active url"

It uncovered/caused issues in the icon-implementation that can't be
easily fixed, so rolling out instead.

https://bugs.webkit.org/show_bug.cgi?id=77554

Rubber-stamped by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r115388.
oliver@apple.com [Wed, 2 May 2012 19:18:28 +0000 (19:18 +0000)]
Unreviewed, rolling out r115388.
http://trac.webkit.org/changeset/115388
https://bugs.webkit.org/show_bug.cgi?id=85011

This caused many weird performance problems, and needs to be
landed in pieces.

Source/JavaScriptCore:

* dfg/DFGOperations.cpp:
* heap/Heap.cpp:
(JSC::Heap::getConservativeRegisterRoots):
(JSC::Heap::markRoots):
* interpreter/CallFrame.cpp:
(JSC::CallFrame::dumpCaller):
(JSC):
* interpreter/CallFrame.h:
(JSC::ExecState::init):
(ExecState):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):
(JSC::Interpreter::privateExecute):
* interpreter/Interpreter.h:
(JSC::Interpreter::execute):
* interpreter/RegisterFile.cpp:
(JSC::RegisterFile::growSlowCase):
(JSC::RegisterFile::gatherConservativeRoots):
* interpreter/RegisterFile.h:
(JSC::RegisterFile::end):
(JSC::RegisterFile::size):
(JSC::RegisterFile::addressOfEnd):
(RegisterFile):
(JSC::RegisterFile::RegisterFile):
(JSC::RegisterFile::shrink):
(JSC::RegisterFile::grow):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
(JSC::jitCompileFor):
(JSC::lazyLinkFor):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::handleHostCall):
* llint/LowLevelInterpreter.asm:
* runtime/CommonSlowPaths.h:
(JSC::CommonSlowPaths::arityCheckFor):

LayoutTests:

* fast/js/global-recursion-on-full-stack-expected.txt:
* fast/js/stack-trace-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove title and media queries from StyleSheetInternal to CSSStyleSheet
antti@apple.com [Wed, 2 May 2012 19:05:31 +0000 (19:05 +0000)]
Move title and media queries from StyleSheetInternal to CSSStyleSheet
https://bugs.webkit.org/show_bug.cgi?id=85387

Reviewed by Anders Carlsson.

Stylesheet title and media queries are determined by the owner, not by the stylesheet itself.
The fields belong to CSSStyleSheet.

This will make it easier to share StyleSheetInternal instances between documents.

* css/CSSStyleSheet.cpp:
(WebCore::StyleSheetInternal::StyleSheetInternal):
(WebCore::StyleSheetInternal::isCacheable):
(WebCore):
(WebCore::CSSStyleSheet::setDisabled):

    Invalidate the document style directly instead of ping-ponging through StyleSheetInternal.

(WebCore::CSSStyleSheet::setMediaQueries):
(WebCore::CSSStyleSheet::media):
* css/CSSStyleSheet.h:
(StyleSheetInternal):
(WebCore::StyleSheetInternal::originalURL):
(WebCore::StyleSheetInternal::hasCharsetRule):
(WebCore::CSSStyleSheet::mediaQueries):
(CSSStyleSheet):
(WebCore::CSSStyleSheet::setTitle):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::appendAuthorStylesheets):
(WebCore::StyleResolver::collectMatchingRulesForList):
* dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createCSSStyleSheet):
* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::setCSSStyleSheet):
* dom/StyleElement.cpp:
(WebCore::StyleElement::createSheet):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::parseAttribute):
(WebCore::HTMLLinkElement::setCSSStyleSheet):
* html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::parseAttribute):
* svg/SVGStyleElement.cpp:
(WebCore::SVGStyleElement::parseAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWhen viewing a PDF, the Safari Status Bar shows other text
andersca@apple.com [Wed, 2 May 2012 19:01:32 +0000 (19:01 +0000)]
When viewing a PDF, the Safari Status Bar shows other text
https://bugs.webkit.org/show_bug.cgi?id=85395
<rdar://problem/11297250>

Reviewed by Beth Dakin.

Set the layer contents placement for the WKView so that its layer will get masksToBounds set.

* UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:contextRef:pageGroupRef:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, removing recent test expectations for changes in r115846
zandobersek@gmail.com [Wed, 2 May 2012 18:53:49 +0000 (18:53 +0000)]
Unreviewed, removing recent test expectations for changes in r115846
to get proper new baselines from the buildbots.

* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed Qt build fix with GCC 4.7.0.
alexis.menard@openbossa.org [Wed, 2 May 2012 18:52:49 +0000 (18:52 +0000)]
Unreviewed Qt build fix with GCC 4.7.0.

* platform/qt/DeviceMotionProviderQt.h:
(DeviceMotionProviderQt):
* platform/qt/DeviceOrientationProviderQt.cpp:
(WebCore::DeviceOrientationProviderQt::~DeviceOrientationProviderQt):
(WebCore):
* platform/qt/DeviceOrientationProviderQt.h:
(DeviceOrientationProviderQt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed Chromium gardening.
jchaffraix@webkit.org [Wed, 2 May 2012 18:50:23 +0000 (18:50 +0000)]
Unreviewed Chromium gardening.

* platform/chromium-mac-leopard/fast/layers/add-layer-with-nested-stacking-expected.txt: Added.
* platform/chromium-mac-leopard/fast/speech/input-appearance-searchandspeech-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/layers/add-layer-with-nested-stacking-expected.txt: Added.
* platform/chromium-mac/editing/selection/select-from-textfield-outwards-expected.txt:
* platform/chromium-mac/editing/spelling/inline_spelling_markers-expected.txt: Removed.
* platform/chromium-mac/fast/forms/form-element-geometry-expected.txt:
* platform/chromium-mac/fast/forms/input-value-expected.txt:
* platform/chromium-mac/fast/layers/add-layer-with-nested-stacking-expected.txt: Added.
* platform/chromium-mac/fast/layers/remove-layer-with-nested-stacking-expected.txt: Removed.
Rebaselined the previous tests.

* platform/chromium/test_expectations.txt:
Tweaked the expectation files to cover the failures on Mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Texmap] Enable css filters in TextureMapperGL
noam.rosenthal@nokia.com [Wed, 2 May 2012 18:26:58 +0000 (18:26 +0000)]
[Texmap] Enable css filters in TextureMapperGL
https://bugs.webkit.org/show_bug.cgi?id=75778

Unreviewed build fix to greenify the Qt Minimal bot.

* platform/graphics/texmap/TextureMapperShaderManager.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed expectation updates after r115846.
jchaffraix@webkit.org [Wed, 2 May 2012 18:22:33 +0000 (18:22 +0000)]
Unreviewed expectation updates after r115846.

* platform/gtk/test_expectations.txt:
* platform/qt/test_expectations.txt:
Added more files after triaging the diffs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoReftest mismatches are providing undefined diff percent in results.html
zandobersek@gmail.com [Wed, 2 May 2012 18:01:27 +0000 (18:01 +0000)]
Reftest mismatches are providing undefined diff percent in results.html
https://bugs.webkit.org/show_bug.cgi?id=85283

Reviewed by Ojan Vafai.

When writing test results for a reftest mismatch, also take into account the
difference percent that is produced when generating image diff. This value is
then used when creating test results in the form of dictionaries, stored under
the 'image_diff_percent' key. It ultimately ends up in JSON results data,
providing additional information about the reftest difference.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(interpret_test_failures): Store the diff percent for reftest failure under the
'image_diff_percent' key.
* Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(write_test_result): Also set the new diff_percent attribute of the reftest
mismatch failure to the value of the difference percent ImageDiff outputs.
* Scripts/webkitpy/layout_tests/models/test_failures.py:
(FailureReftestMismatch.__init__): Add the new diff_percent attribute with the
default value of None.
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(EndToEndTest.test_reftest_with_two_notrefs): Update the test case expected results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Compilation warnings in RenderTheme
philn@webkit.org [Wed, 2 May 2012 17:57:34 +0000 (17:57 +0000)]
[GTK] Compilation warnings in RenderTheme
https://bugs.webkit.org/show_bug.cgi?id=85286

Reviewed by Martin Robinson.

Removed un-needed code and refactored fileListNameForWidth
accordingly to avoid un-used variable warnings during compilation.

* platform/gtk/RenderThemeGtk.cpp:
(WebCore):
(WebCore::RenderThemeGtk::fileListNameForWidth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNULL ptr in WebCore::AppendNodeCommand::AppendNodeCommand
rniwa@webkit.org [Wed, 2 May 2012 17:45:14 +0000 (17:45 +0000)]
NULL ptr in WebCore::AppendNodeCommand::AppendNodeCommand
https://bugs.webkit.org/show_bug.cgi?id=75843

Reviewed by Tony Chang.

Source/WebCore:

The crash was caused by indentIntoBlockquote's passing a bad outerBlock to moveParagraphsWithClone.

When the position is created after blockquote in the following DOM:
BODY
* BLOCKQUOTE style=margin: 0 0 0 40px; border: none; padding: 0px;
    E
        #text "\nx\n"
VisiblePosition's constructor (of startOfContents) turns the position into a legacy position (blockquote, 0).
The crash occurs because this position doesn't belong in the same paragraph as E, which is the paragraph
we're trying to move into the blockquote.

Fixed bug by calling positionInParentAfterNode instead of positionAfterNode for now. We should eventually be
able to use positionAfterNode here once VisiblePosition's constructor starts handling before/after positions
properly.

Test: editing/execCommand/indent-with-after-content-crash.html

* editing/IndentOutdentCommand.cpp:
(WebCore::IndentOutdentCommand::indentIntoBlockquote):

LayoutTests:

Add a regression test.

* editing/execCommand/indent-with-after-content-crash-expected.txt: Added.
* editing/execCommand/indent-with-after-content-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebWindowFadeAnimation ignores "duration" parameter. https://bugs.webkit.org/show_bug...
jer.noble@apple.com [Wed, 2 May 2012 17:42:07 +0000 (17:42 +0000)]
WebWindowFadeAnimation ignores "duration" parameter. https://bugs.webkit.org/show_bug.cgi?id=85386

Reviewed by Brady Eidson.

Ignoring the "duration" parameter causes the full screen fade and scale animations
to get out of sync.

* platform/mac/WebWindowAnimation.mm:
(-[WebWindowFadeAnimation initWithDuration:window:initialAlpha:finalAlpha:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(110072): Clipping is not applied on layers that are animated using platfor...
jchaffraix@webkit.org [Wed, 2 May 2012 17:17:14 +0000 (17:17 +0000)]
REGRESSION(110072): Clipping is not applied on layers that are animated using platform code
https://bugs.webkit.org/show_bug.cgi?id=83954

Reviewed by Simon Fraser.

Source/WebCore:

Tests: fast/layers/no-clipping-overflow-hidden-added-after-transform-expected.html
       fast/layers/no-clipping-overflow-hidden-added-after-transform.html
       fast/layers/no-clipping-overflow-hidden-added-after-transition-expected.html
       fast/layers/no-clipping-overflow-hidden-added-after-transition.html
       fast/layers/no-clipping-overflow-hidden-hardware-acceleration-expected.html
       fast/layers/no-clipping-overflow-hidden-hardware-acceleration.html
       (and all the tests that will need to be rebaselined)

r110072 changed the way we create layers to lazily allocate overflow: hidden ones
based on layout overflow. However with hardware acceleration, certain operations
do cause overflow without actually calling layout (the test cases added as part
of this change are using transition / animation). This means that those cases
wouldn't properly clip.

Due to the above issue and the other regressions from r110072, the easiest fix is
to just to roll it out.

* rendering/RenderBox.h:
Changed to allocate a layer whenever we have an overflow clip.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::scrolledContentOffset):
(WebCore::RenderBox::cachedSizeForOverflowClip):
Reverted those 2 to avoid using the cached size logic.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateScrollInfoAfterLayout):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::paint):
(WebCore::RenderBlock::isPointInOverflowControl):
* rendering/RenderBlock.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::willBeDestroyed):
(WebCore::RenderBox::styleDidChange):
(WebCore::RenderBox::layout):
(WebCore::RenderBox::scrollWidth):
(WebCore::RenderBox::scrollHeight):
(WebCore::RenderBox::scrollLeft):
(WebCore::RenderBox::scrollTop):
(WebCore::RenderBox::setScrollLeft):
(WebCore::RenderBox::setScrollTop):
(WebCore::RenderBox::includeVerticalScrollbarSize):
(WebCore::RenderBox::includeHorizontalScrollbarSize):
(WebCore::RenderBox::pushContentsClip):
(WebCore::RenderBox::popContentsClip):
(WebCore::RenderBox::addLayoutOverflow):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::styleDidChange):
* rendering/RenderBoxModelObject.h:
(RenderBoxModelObject):
* rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::layout):
* rendering/RenderTableRow.h:
(RenderTableRow):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layout):
Removed the previous scaffolding code and reverted some functions to
being private (as they were prior to r110072).

LayoutTests:

* fast/layers/no-clipping-overflow-hidden-added-after-transform-expected.html: Added.
* fast/layers/no-clipping-overflow-hidden-added-after-transform.html: Added.
* fast/layers/no-clipping-overflow-hidden-added-after-transition-expected.html: Added.
* fast/layers/no-clipping-overflow-hidden-added-after-transition.html: Added.
* fast/layers/no-clipping-overflow-hidden-hardware-acceleration-expected.html: Added.
* fast/layers/no-clipping-overflow-hidden-hardware-acceleration.html: Added.

* platform/chromium/test_expectations.txt:
* platform/gtk/test_expectations.txt:
* platform/qt/test_expectations.txt:
Disabled some tests for those platforms.

* platform/efl/test_expectations.txt:
* platform/mac/test_expectations.txt:
* platform/qt/Skipped:
* platform/win/Skipped:
Re-enabled those tests on the premises that r11072 / bug 75568 got rolled out.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAddition of a contributor to committers.py
commit-queue@webkit.org [Wed, 2 May 2012 17:13:35 +0000 (17:13 +0000)]
Addition of a contributor to committers.py
https://bugs.webkit.org/show_bug.cgi?id=85324

Patch by Terry Anderson <tdanderson@chromium.org> on 2012-05-02
Reviewed by Unreviewed.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Build fix for Qt port on mac.
mahesh.kulkarni@nokia.com [Wed, 2 May 2012 17:03:49 +0000 (17:03 +0000)]
Unreviewed. Build fix for Qt port on mac.

* UIProcess/API/qt/qwebnavigationhistory_p.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] EFL's LayoutTestController overridePreference implementation
commit-queue@webkit.org [Wed, 2 May 2012 16:52:02 +0000 (16:52 +0000)]
[EFL] EFL's LayoutTestController overridePreference implementation
https://bugs.webkit.org/show_bug.cgi?id=83007

Tools:

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-02
Reviewed by Antonio Gomes.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(toBool): aux function converting JSStringRef to bool
(toInt): aux function converting JSStringRef to int
(LayoutTestController::overridePreference): added implementation

LayoutTests:

Unskip tescases depending on LayoutTestController overridePreference method.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-02
Reviewed by Antonio Gomes.

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake ShareableSurface's ref-counting thread-safe
vestbo@webkit.org [Wed, 2 May 2012 16:15:24 +0000 (16:15 +0000)]
Make ShareableSurface's ref-counting thread-safe

Fixes assert when threaded rendering is enabled for the Qt scene-graph.

https://bugs.webkit.org/show_bug.cgi?id=85381

Reviewed by Noam Rosenthal.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Refining expectations for passing tests.
caseq@chromium.org [Wed, 2 May 2012 15:49:20 +0000 (15:49 +0000)]
Unreviewed. Refining expectations for passing tests.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, EFL rebaseline after r115415 and r115294.
rakuco@webkit.org [Wed, 2 May 2012 15:32:06 +0000 (15:32 +0000)]
Unreviewed, EFL rebaseline after r115415 and r115294.

* platform/efl/fast/images/support-broken-image-delegate-expected.txt:
* platform/efl/http/tests/loading/simple-subframe-expected.txt:
* platform/efl/security/block-test-expected.txt:
* platform/efl/security/block-test-no-port-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Texmap] Enable css filters in TextureMapperGL
noam.rosenthal@nokia.com [Wed, 2 May 2012 15:30:29 +0000 (15:30 +0000)]
[Texmap] Enable css filters in TextureMapperGL
https://bugs.webkit.org/show_bug.cgi?id=75778

Source/WebCore:

Reviewed by Jocelyn Turcotte.

Added support for color filters in TextureMapperGL. Blur and shadow would be done in a
different patch.

Modified BitmapTexture::applyFilters to return a texture, since GL cannot paint a texture
into itself.
Created a shader map for standard filters, since all of them work more or less the same way
with a single uniform. Added the colorization shaders based on the W3C filter spec, as
already implemented in FEFilterRenderer.cpp and FEColorMatrix.cpp.
We use two swapping textures to render the filters.

Covered by tests in css3/filters.

* platform/graphics/texmap/TextureMapper.cpp:
(WebCore::TextureMapper::acquireTextureFromPool):
* platform/graphics/texmap/TextureMapper.h:
(WebCore::BitmapTexture::applyFilters):
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::updateContents):
(WebCore):
(WebCore::TextureMapperGL::drawFiltered):
(WebCore::BitmapTextureGL::applyFilters):
(WebCore::BitmapTextureGL::bind):
* platform/graphics/texmap/TextureMapperGL.h:
(TextureMapperGL):
(BitmapTextureGL):
* platform/graphics/texmap/TextureMapperImageBuffer.cpp:
(WebCore::BitmapTextureImageBuffer::applyFilters):
* platform/graphics/texmap/TextureMapperImageBuffer.h:
(BitmapTextureImageBuffer):
* platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::applyFilters):
(WebCore::TextureMapperLayer::syncCompositingStateSelf):
* platform/graphics/texmap/TextureMapperShaderManager.cpp:
(WebCore::TextureMapperShaderManager::~TextureMapperShaderManager):
(WebCore):
(WebCore::StandardFilterProgram::~StandardFilterProgram):
(WebCore::StandardFilterProgram::StandardFilterProgram):
(WebCore::StandardFilterProgram::create):
(WebCore::StandardFilterProgram::prepare):
(WebCore::TextureMapperShaderManager::getShaderForFilter):
* platform/graphics/texmap/TextureMapperShaderManager.h:
(WebCore):
(StandardFilterProgram):
(WebCore::StandardFilterProgram::vertexAttrib):
(WebCore::StandardFilterProgram::texCoordAttrib):
(WebCore::StandardFilterProgram::textureUniform):
(TextureMapperShaderManager):

Source/WebKit2:

Add the plumbing in the ui-side compositing code in Qt to support filters.
Serialize the filter operations for a layer when it's changed.

Reviewed by Jocelyn Turcotte.

* Shared/WebCoreArgumentCoders.cpp:
(CoreIPC):
(CoreIPC::::encode):
(CoreIPC::::decode):
* Shared/WebCoreArgumentCoders.h:
(WebCore):
* UIProcess/LayerTreeHostProxy.cpp:
(WebKit):
(WebKit::LayerTreeHostProxy::setCompositingLayerFilters):
* UIProcess/LayerTreeHostProxy.h:
(LayerTreeHostProxy):
* UIProcess/LayerTreeHostProxy.messages.in:
* UIProcess/WebLayerTreeRenderer.cpp:
(WebKit):
(WebKit::WebLayerTreeRenderer::setLayerFilters):
* UIProcess/WebLayerTreeRenderer.h:
(WebLayerTreeRenderer):
* WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore):
(WebCore::WebGraphicsLayer::didChangeFilters):
(WebCore::WebGraphicsLayer::setFilters):
(WebCore::WebGraphicsLayer::syncFilters):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):
* WebProcess/WebCoreSupport/WebGraphicsLayer.h:
(WebGraphicsLayerClient):
(WebGraphicsLayer):
* WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit):
(WebKit::LayerTreeHostQt::syncLayerFilters):
* WebProcess/WebPage/qt/LayerTreeHostQt.h:
(LayerTreeHostQt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, GTK rebaseline after r115825.
philn@webkit.org [Wed, 2 May 2012 15:29:55 +0000 (15:29 +0000)]
Unreviewed, GTK rebaseline after r115825.

* platform/gtk/fast/lists/drag-into-marker-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, EFL rebaseline after r113885.
rakuco@webkit.org [Wed, 2 May 2012 15:20:04 +0000 (15:20 +0000)]
Unreviewed, EFL rebaseline after r113885.

* platform/efl/css2.1/20110323/replaced-elements-001-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, GTK rebaseline after r115829.
philn@webkit.org [Wed, 2 May 2012 15:17:50 +0000 (15:17 +0000)]
Unreviewed, GTK rebaseline after r115829.

* platform/gtk/fast/hidpi/video-controls-in-hidpi-expected.txt:
* platform/gtk/fast/layers/video-layer-expected.txt:
* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Hyperlink auditing ewk_view setting
commit-queue@webkit.org [Wed, 2 May 2012 15:17:13 +0000 (15:17 +0000)]
[EFL] Hyperlink auditing ewk_view setting
https://bugs.webkit.org/show_bug.cgi?id=84451

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-02
Reviewed by Antonio Gomes.

Exporting new ewk_view setting:  hyperlinkAuditingEnabled - enbles/disables hyperlink auditing.

* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(ewk_view_setting_enable_hyperlink_auditing_get):
(ewk_view_setting_enable_hyperlink_auditing_set):
* ewk/ewk_view.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowebkitpy: Fix sys.platform check in find_files_unittest.
rakuco@webkit.org [Wed, 2 May 2012 15:13:35 +0000 (15:13 +0000)]
webkitpy: Fix sys.platform check in find_files_unittest.
https://bugs.webkit.org/show_bug.cgi?id=85339

Reviewed by Ryosuke Niwa.

Follow-up to r101618 -- 'win' is not a valid sys.platform value,
'win32' should be used instead. The check always returned false
due to this, so assert_normalize() was never called.

* Scripts/webkitpy/common/find_files_unittest.py:
(TestWinNormalize.test_win): Add the missing import for the
FileSystem class and fix the sys.platform check.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Pass page-height to PrintContext::begin to fix print layouting
commit-queue@webkit.org [Wed, 2 May 2012 15:08:03 +0000 (15:08 +0000)]
[Qt] Pass page-height to PrintContext::begin to fix print layouting
https://bugs.webkit.org/show_bug.cgi?id=84864

Patch by Milian Wolff <milian.wolff@kdab.com> on 2012-05-02
Reviewed by Simon Hausmann.

* Api/qwebframe.cpp:
(QWebFrame::print):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix vkb showing incorrect flags/keys when content changes
hausmann@webkit.org [Wed, 2 May 2012 14:55:40 +0000 (14:55 +0000)]
[Qt] Fix vkb showing incorrect flags/keys when content changes

Reviewed by Tor Arne Vestbø.

When the editor state changes we have to inform the input method about changed
properties so that it can issue a new input method query. Otherwise it may use old values
from other QQuickItems or other incorrectly initialized data.

Also use isActiveFocus() instead of hasFocus() to detect whether we're actively focused.
This is also what QQuick uses internally to determine whether it can make calls to the input method
or not.

* UIProcess/qt/QtWebPageEventHandler.cpp:
(WebKit::QtWebPageEventHandler::inputPanelVisibleChanged):
(WebKit::QtWebPageEventHandler::updateTextInputState):
(WebKit::QtWebPageEventHandler::doneWithGestureEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Add initial QML documentation
kenneth@webkit.org [Wed, 2 May 2012 14:37:41 +0000 (14:37 +0000)]
[Qt] Add initial QML documentation
https://bugs.webkit.org/show_bug.cgi?id=85370

Reviewed by Simon Hausmann.

Source/WebKit/qt:

* docs/qtwebkit.qdocconf: Add WebKit2 dirs.

Source/WebKit2:

Add initial documentation which also serves as an example on how it
should be done.

* UIProcess/API/qt/qquickwebview.cpp:
* UIProcess/API/qt/qwebloadrequest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] media/track/track-cue-rendering-snap-to-lines-not-set.html fails
philn@webkit.org [Wed, 2 May 2012 14:19:34 +0000 (14:19 +0000)]
[GTK] media/track/track-cue-rendering-snap-to-lines-not-set.html fails
https://bugs.webkit.org/show_bug.cgi?id=84378

Reviewed by Eric Carlson.

Source/WebCore:

Fix positioning of the controls panel back to relative, as it is
in the parent CSS. Also remove some duplicate CSS attributes.

* css/mediaControlsGtk.css:
(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):

LayoutTests:

* platform/gtk/media/audio-controls-rendering-expected.txt:
* platform/gtk/media/audio-repaint-expected.txt:
* platform/gtk/media/controls-after-reload-expected.txt:
* platform/gtk/media/controls-strict-expected.txt:
* platform/gtk/media/controls-styling-expected.txt:
* platform/gtk/media/controls-without-preload-expected.txt:
* platform/gtk/media/media-controls-clone-expected.txt:
* platform/gtk/media/media-document-audio-repaint-expected.txt:
* platform/gtk/media/video-controls-rendering-expected.txt:
* platform/gtk/media/video-display-toggle-expected.txt:
* platform/gtk/media/video-empty-source-expected.txt:
* platform/gtk/media/video-no-audio-expected.txt:
* platform/gtk/media/video-playing-and-pause-expected.txt:
* platform/gtk/media/video-volume-slider-expected.txt:
* platform/gtk/media/video-zoom-controls-expected.txt:
* platform/gtk/test_expectations.txt: Unflag fixed test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Buildfix after r115812 for !ENABLE(DEVICE_ORIENTATION) builds.
ossy@webkit.org [Wed, 2 May 2012 14:18:55 +0000 (14:18 +0000)]
[Qt] Buildfix after r115812 for !ENABLE(DEVICE_ORIENTATION) builds.
https://bugs.webkit.org/show_bug.cgi?id=64595

Reviewed by Kenneth Rohde Christiansen.

* Api/qwebpage.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: TypeError: Cannot call method 'createLiveLocation' of undefined
yurys@chromium.org [Wed, 2 May 2012 14:10:01 +0000 (14:10 +0000)]
Web Inspector: TypeError: Cannot call method 'createLiveLocation' of undefined
https://bugs.webkit.org/show_bug.cgi?id=85371

Standard extension scripts injected to the Chromium background page should have
correct script data which means that context debug id should be already set on
the context where they are compiled before the compilation. This patch moves
assignment of context debug id earlier where it is known that no scripts have
been evaluated in the context.

Reviewed by Pavel Feldman.

* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::dispatchDidClearWindowObjectInWorld):
(WebKit::FrameLoaderClientImpl::didCreateScriptContext):
* src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::didCreateScriptContext):
* src/WebDevToolsAgentImpl.h:
(WebDevToolsAgentImpl):
* src/WebDevToolsAgentPrivate.h:
(WebDevToolsAgentPrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed prospective QtMobility build fix.
hausmann@webkit.org [Wed, 2 May 2012 14:09:49 +0000 (14:09 +0000)]
[Qt] Unreviewed prospective QtMobility build fix.

* Source/api.pri: The Qt 4 equivalent of QT += sensors should be handled by
WebCore.pri, but somehow it isn't.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] drag&drop related failures
zandobersek@gmail.com [Wed, 2 May 2012 14:08:30 +0000 (14:08 +0000)]
[GTK] drag&drop related failures
https://bugs.webkit.org/show_bug.cgi?id=84675

Reviewed by Philippe Normand.

Tools:

Rather than checking options to see whether we're running pixel tests
the pixel_tests argument passed to GtkDriver._start should be used as
it also covers cases when pixel tests should be run because of testing
reftests. This again creates different Xvfb processes with proper
display IDs for a worker that's performing both ordinary and pixel
tests, as was the case before changes made in r114788.

* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkDriver._start):

LayoutTests:

Remove test cases from expectations that are now passing.

* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Removed entries for 4 media tests that pass now.
caseq@chromium.org [Wed, 2 May 2012 14:01:50 +0000 (14:01 +0000)]
Unreviewed. Removed entries for 4 media tests that pass now.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttps://bugs.webkit.org/show_bug.cgi?id=85309
bdakin@apple.com [Wed, 2 May 2012 13:41:29 +0000 (13:41 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=85309
supportsExpandedScrollbars() should check for the method we actually call rather
than a related method
-and corresponding-
<rdar://problem/11065691>

Reviewed by Anders Carlsson.

* platform/mac/ScrollbarThemeMac.mm:
(WebCore::supportsExpandedScrollbars):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, GTK test_expectations update.
philn@webkit.org [Wed, 2 May 2012 13:37:24 +0000 (13:37 +0000)]
Unreviewed, GTK test_expectations update.

* platform/gtk/test_expectations.txt:
http/tests/loading/pdf-commit-load-callbacks.html is failing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Enable device orientation/motion with Qt 5
hausmann@webkit.org [Wed, 2 May 2012 13:19:51 +0000 (13:19 +0000)]
[Qt] Enable device orientation/motion with Qt 5

Reviewed by Tor Arne Vestbø.

Enable device orientation/motion features with Qt 5 if Qt Sensors is available.

* qmake/mkspecs/features/features.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][DRT] Gardening failure cases on EFL port
commit-queue@webkit.org [Wed, 2 May 2012 13:17:17 +0000 (13:17 +0000)]
[EFL][DRT] Gardening failure cases on EFL port
https://bugs.webkit.org/show_bug.cgi?id=85365

Unreviewed EFL gardening.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-02

* platform/efl/Skipped:
* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: [Qt] Remove redundant updateViewportArguments() call from HTMLBodyEle...
commit-queue@webkit.org [Wed, 2 May 2012 13:00:47 +0000 (13:00 +0000)]
Source/WebCore: [Qt] Remove redundant updateViewportArguments() call from HTMLBodyElement::didNotifyDescendantInseretions()
https://bugs.webkit.org/show_bug.cgi?id=84241

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-05-02
Reviewed by Kenneth Rohde Christiansen.

No need to update viewport arguments when the body element is inserted into the Document.
Viewport arguments are updated first when the Document is set on the Frame, and later
on any subsequent occurence of the viewport meta tag in the document.
It is sufficient to dispatch viewport update once per main frame, if no viewport meta tag is present.

Also add a flag to be able to track viewport argument update dispatch.

No tests. Currrent viewport tests cover this behaviour.

* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::updateViewportArguments):
(WebCore::Document::documentWillSuspendForPageCache):
* dom/Document.h:
(Document):
(WebCore::Document::didDispatchViewportPropertiesChanged):
* html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::didNotifyDescendantInseretions):

Source/WebKit2: [Qt][WK2] Remove redundant updateViewportArguments() call from HTMLBodyElement::didNotifyDescendantInseretions()
https://bugs.webkit.org/show_bug.cgi?id=84241

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-05-02
Reviewed by Kenneth Rohde Christiansen.

Add ASSERT to ensure at least one viewport argument change call is dispatched to WebPage per main frame.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidFirstLayout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][Mac] Skip new failing tests and one crashing test to paint the bot green.
ossy@webkit.org [Wed, 2 May 2012 12:13:57 +0000 (12:13 +0000)]
[Qt][Mac] Skip new failing tests and one crashing test to paint the bot green.

* platform/qt-mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Cannot read property 'length' of undefined TextEditorModel.js:467
pfeldman@chromium.org [Wed, 2 May 2012 12:07:34 +0000 (12:07 +0000)]
Web Inspector: Cannot read property 'length' of undefined TextEditorModel.js:467
https://bugs.webkit.org/show_bug.cgi?id=85360

Reviewed by Yury Semikhatsky.

Added the undo/redo stack length checks.

* inspector/front-end/TextEditorModel.js:
(WebInspector.TextEditorModel.endsWithBracketRegex.):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening, skipping failing test
ossy@webkit.org [Wed, 2 May 2012 12:04:46 +0000 (12:04 +0000)]
[Qt] Unreviewed gardening, skipping failing test

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-05-02

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebInspector: Scripts panel editor dirty state is cleared when the tab with editor...
pfeldman@chromium.org [Wed, 2 May 2012 12:03:48 +0000 (12:03 +0000)]
WebInspector: Scripts panel editor dirty state is cleared when the tab with editor is closed.
https://bugs.webkit.org/show_bug.cgi?id=85361

Reviewed by Yury Semikhatsky.

Added content validation upon script show.

* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.wasShown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: breakpoints are de-activated only upon the second click.
pfeldman@chromium.org [Wed, 2 May 2012 12:01:31 +0000 (12:01 +0000)]
Web Inspector: breakpoints are de-activated only upon the second click.
https://bugs.webkit.org/show_bug.cgi?id=85359

Reviewed by Yury Semikhatsky.

Initial value for activated state is set.

* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: live edit fails to report error
pfeldman@chromium.org [Wed, 2 May 2012 11:56:34 +0000 (11:56 +0000)]
Web Inspector: live edit fails to report error
https://bugs.webkit.org/show_bug.cgi?id=85357

Reviewed by Yury Semikhatsky.

ProtocolError is now a string, not an error object.

* inspector/front-end/DatabaseQueryView.js:
(WebInspector.DatabaseQueryView.prototype._queryError):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.didEditContent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Make DeviceMotion and DeviceOrientation work with WebKit2
commit-queue@webkit.org [Wed, 2 May 2012 11:51:32 +0000 (11:51 +0000)]
[Qt] Make DeviceMotion and DeviceOrientation work with WebKit2
https://bugs.webkit.org/show_bug.cgi?id=64595

Patch by Lars Knudsen <lars.knudsen@nokia.com> on 2012-05-02
Reviewed by Kenneth Rohde Christiansen.

.:

Moving DeviceMotion and DeviceOrientation clients and providers
to WebCore.  This is done to allow clean dependencies when
statically linking WK2.

* Source/api.pri:

Source/WebCore:

No new tests added.  This change adds support for WK2
what was in WK1.

Also moving DeviceMotion and DeviceOrientation clients and
providers to WebCore.  This is done to allow clean dependencies
when statically linking WK2.

* Target.pri:
* WebCore.pri:
* platform/qt/DeviceMotionClientQt.cpp: Renamed from Source/WebKit/qt/WebCoreSupport/DeviceMotionClientQt.cpp.
(WebCore):
(WebCore::DeviceMotionClientQt::~DeviceMotionClientQt):
(WebCore::DeviceMotionClientQt::deviceMotionControllerDestroyed):
(WebCore::DeviceMotionClientQt::setController):
(WebCore::DeviceMotionClientQt::startUpdating):
(WebCore::DeviceMotionClientQt::stopUpdating):
(WebCore::DeviceMotionClientQt::currentDeviceMotion):
* platform/qt/DeviceMotionClientQt.h: Renamed from Source/WebKit/qt/WebCoreSupport/DeviceMotionClientQt.h.
(WebCore):
(DeviceMotionClientQt):
(WebCore::DeviceMotionClientQt::DeviceMotionClientQt):
* platform/qt/DeviceMotionProviderQt.cpp: Renamed from Source/WebKit/qt/WebCoreSupport/DeviceMotionProviderQt.cpp.
(WebCore):
(WebCore::DeviceMotionProviderQt::DeviceMotionProviderQt):
(WebCore::DeviceMotionProviderQt::~DeviceMotionProviderQt):
(WebCore::DeviceMotionProviderQt::setController):
(WebCore::DeviceMotionProviderQt::start):
(WebCore::DeviceMotionProviderQt::stop):
(WebCore::DeviceMotionProviderQt::filter):
* platform/qt/DeviceMotionProviderQt.h: Renamed from Source/WebKit/qt/WebCoreSupport/DeviceMotionProviderQt.h.
(WebCore):
(DeviceMotionProviderQt):
(WebCore::DeviceMotionProviderQt::currentDeviceMotion):
* platform/qt/DeviceOrientationClientQt.cpp: Renamed from Source/WebKit/qt/WebCoreSupport/DeviceOrientationClientQt.cpp.
(WebCore):
(WebCore::DeviceOrientationClientQt::deviceOrientationControllerDestroyed):
(WebCore::DeviceOrientationClientQt::setController):
(WebCore::DeviceOrientationClientQt::startUpdating):
(WebCore::DeviceOrientationClientQt::stopUpdating):
(WebCore::DeviceOrientationClientQt::lastOrientation):
* platform/qt/DeviceOrientationClientQt.h: Renamed from Source/WebKit/qt/WebCoreSupport/DeviceOrientationClientQt.h.
(WebCore):
(DeviceOrientationClientQt):
* platform/qt/DeviceOrientationProviderQt.cpp: Renamed from Source/WebKit/qt/WebCoreSupport/DeviceOrientationProviderQt.cpp.
(WebCore):
(WebCore::DeviceOrientationProviderQt::DeviceOrientationProviderQt):
(WebCore::DeviceOrientationProviderQt::~DeviceOrientationProviderQt):
(WebCore::DeviceOrientationProviderQt::setController):
(WebCore::DeviceOrientationProviderQt::start):
(WebCore::DeviceOrientationProviderQt::stop):
(WebCore::DeviceOrientationProviderQt::filter):
* platform/qt/DeviceOrientationProviderQt.h: Renamed from Source/WebKit/qt/WebCoreSupport/DeviceOrientationProviderQt.h.
(WebCore):
(DeviceOrientationProviderQt):
(WebCore::DeviceOrientationProviderQt::isActive):
(WebCore::DeviceOrientationProviderQt::lastOrientation):
(WebCore::DeviceOrientationProviderQt::hasAlpha):

Source/WebKit2:

Adding support for DeviceOrientation in WK2 WebPage

* Target.pri:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: exception in console when there are watch expressions
yurys@chromium.org [Wed, 2 May 2012 10:43:10 +0000 (10:43 +0000)]
Web Inspector: exception in console when there are watch expressions
https://bugs.webkit.org/show_bug.cgi?id=85351

Check if script execution is still paused before trying to resolve an
object for script popover because execution may be resumed after popover
showing is scheduled but before we start resolving the object under
the cursor in which case there is no selected call frame any more and
we should hide the popover.

Reviewed by Pavel Feldman.

* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype._resolveObjectForPopover):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMediaStream API: Changing webkitGetUserMedia to take an object instead of a string
tommyw@google.com [Wed, 2 May 2012 10:31:53 +0000 (10:31 +0000)]
MediaStream API: Changing webkitGetUserMedia to take an object instead of a string
https://bugs.webkit.org/show_bug.cgi?id=84850

Reviewed by Dimitri Glazkov.

Source/WebCore:

The standard changed a while back to use an object as a dictionary but since JSC
didn't support the Dictionary class until just recently we have not updated the API until now.

Change covered by existing, and edited, tests.

* Modules/mediastream/NavigatorMediaStream.cpp:
(WebCore::NavigatorMediaStream::webkitGetUserMedia):
* Modules/mediastream/NavigatorMediaStream.h:
(WebCore):
(NavigatorMediaStream):
* Modules/mediastream/NavigatorMediaStream.idl:
* Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::create):
(WebCore::UserMediaRequest::UserMediaRequest):
* Modules/mediastream/UserMediaRequest.h:
(WebCore):
(UserMediaRequest):
* platform/mediastream/MediaStreamSourcesQueryClient.h:
(MediaStreamSourcesQueryClient):

Source/WebKit/chromium:

* public/WebUserMediaRequest.h:
(WebUserMediaRequest):
* src/WebUserMediaRequest.cpp:

LayoutTests:

Also took the opportunity to update the peerconnection-Attributes test
to test PeerConnection00 instead.

* fast/mediastream/argument-types-expected.txt:
* fast/mediastream/peerconnection-Attributes-expected.txt:
* fast/mediastream/script-tests/argument-types.js:
(emptyFunction):
* fast/mediastream/script-tests/peerconnection-Attributes.js:
* platform/chromium/media/video-capture-preview.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Fix typo introduced in r115800.
commit-queue@webkit.org [Wed, 2 May 2012 10:14:59 +0000 (10:14 +0000)]
[EFL] Fix typo introduced in r115800.
https://bugs.webkit.org/show_bug.cgi?id=85354

Patch by Dongwoo Im <dw.im@samsung.com> on 2012-05-02
Reviewed by Nikolas Zimmermann.

* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data): Assign 1 bit to the boolean attribute, webAudio.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Minibrowser's progress bar should reset when WebProcess crashes while loading.
commit-queue@webkit.org [Wed, 2 May 2012 10:00:28 +0000 (10:00 +0000)]
[Qt][WK2] Minibrowser's progress bar should reset when WebProcess crashes while loading.
https://bugs.webkit.org/show_bug.cgi?id=84445

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-05-02
Reviewed by Jocelyn Turcotte.

Progress value needs resetting, when WebProcess crashes.
This patch moves crash logic for loading to QtWebPageLoadClient. It
also simplifies the callback function names in QtWebPageLoadClient, as they
all valid only for main frames.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::processDidCrash):
(QQuickWebViewFlickablePrivate::loadDidSucceed):
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate::didChangeViewportProperties):
(QQuickWebViewPrivate):
* UIProcess/qt/QtWebPageLoadClient.cpp:
(WebKit::QtWebPageLoadClient::QtWebPageLoadClient):
(WebKit::QtWebPageLoadClient::completeLoadWhenProcessDidCrashIfNeeded):
(WebKit):
(WebKit::QtWebPageLoadClient::didStartProvisionalLoad):
(WebKit::QtWebPageLoadClient::didReceiveServerRedirectForProvisionalLoad):
(WebKit::QtWebPageLoadClient::didCommitLoad):
(WebKit::QtWebPageLoadClient::didSameDocumentNavigation):
(WebKit::QtWebPageLoadClient::didReceiveTitle):
(WebKit::QtWebPageLoadClient::didFirstVisuallyNonEmptyLayout):
(WebKit::QtWebPageLoadClient::didStartProvisionalLoadForFrame):
(WebKit::QtWebPageLoadClient::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::QtWebPageLoadClient::didCommitLoadForFrame):
(WebKit::QtWebPageLoadClient::didSameDocumentNavigationForFrame):
(WebKit::QtWebPageLoadClient::didReceiveTitleForFrame):
(WebKit::QtWebPageLoadClient::didFirstVisuallyNonEmptyLayoutForFrame):
* UIProcess/qt/QtWebPageLoadClient.h:
(WebKit):
(QtWebPageLoadClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] CSS tests needs rebaselining
commit-queue@webkit.org [Wed, 2 May 2012 09:52:19 +0000 (09:52 +0000)]
[EFL] CSS tests needs rebaselining
https://bugs.webkit.org/show_bug.cgi?id=85177

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-02

* platform/efl/fast/css/disabled-author-styles-expected.png: Added.
* platform/efl/fast/css/import-rule-regression-11590-expected.txt:
* platform/efl/fast/css/inline-element-line-break-expected.txt:
* platform/efl/fast/css/inline-properties-important-expected.txt:
* platform/efl/fast/css/invalid-percentage-property-expected.txt:
* platform/efl/fast/css/invalidation-errors-3-expected.txt:
* platform/efl/fast/css/last-child-pseudo-class-expected.txt:
* platform/efl/fast/css/last-of-type-pseudo-class-expected.txt:
* platform/efl/fast/css/layerZOrderCrash-expected.txt:
* platform/efl/fast/css/line-height-expected.txt:
* platform/efl/fast/css/line-height-overflow-expected.txt:
* platform/efl/fast/css/list-outline-expected.txt:
* platform/efl/fast/css/margin-bottom-form-element-quirk-expected.txt:
* platform/efl/fast/css/margin-bottom-form-element-strict-expected.txt:
* platform/efl/fast/css/margin-top-bottom-dynamic-expected.txt:
* platform/efl/fast/css/negative-leading-expected.txt:
* platform/efl/fast/css/negative-nth-child-expected.txt:
* platform/efl/fast/css/nested-floating-relative-position-percentages-expected.txt:
* platform/efl/fast/css/nested-layers-with-hover-expected.txt:
* platform/efl/fast/css/non-empty-span-expected.png:
* platform/efl/fast/css/non-empty-span-expected.txt:
* platform/efl/fast/css/nth-child-dynamic-expected.txt:
* platform/efl/fast/css/only-child-pseudo-class-expected.txt:
* platform/efl/fast/css/only-of-type-pseudo-class-expected.txt:
* platform/efl/fast/css/outline-auto-location-expected.txt:
* platform/efl/fast/css/outline-narrowLine-expected.txt:
* platform/efl/fast/css/percent-top-relative-container-height-unspecified-expected.txt:
* platform/efl/fast/css/preserve-user-specified-zoom-level-on-reload-expected.png:
* platform/efl/fast/css/preserve-user-specified-zoom-level-on-reload-expected.txt:
* platform/efl/fast/css/pseudo-element-line-break-expected.txt:
* platform/efl/fast/css/quirk-orphaned-units-expected.txt:
* platform/efl/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.png:
* platform/efl/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.txt:
* platform/efl/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.png:
* platform/efl/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.txt:
* platform/efl/fast/css/relative-positioned-block-nested-with-inline-parent-expected.png:
* platform/efl/fast/css/relative-positioned-block-nested-with-inline-parent-expected.txt:
* platform/efl/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.png:
* platform/efl/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.txt:
* platform/efl/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png:
* platform/efl/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.txt:
* platform/efl/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png:
* platform/efl/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.txt:
* platform/efl/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png:
* platform/efl/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.txt:
* platform/efl/fast/css/relative-positioned-block-with-inline-ancestor-expected.png:
* platform/efl/fast/css/relative-positioned-block-with-inline-ancestor-expected.txt:
* platform/efl/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png:
* platform/efl/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.txt:
* platform/efl/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.png:
* platform/efl/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.txt:
* platform/efl/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.png:
* platform/efl/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.txt:
* platform/efl/fast/css/selector-set-attribute-expected.txt:
* platform/efl/fast/css/table-text-align-quirk-expected.txt:
* platform/efl/fast/css/table-text-align-strict-expected.txt:
* platform/efl/fast/css/text-align-expected.txt:
* platform/efl/fast/css/text-input-with-webkit-border-radius-expected.txt:
* platform/efl/fast/css/text-overflow-ellipsis-bidi-expected.txt:
* platform/efl/fast/css/text-overflow-ellipsis-expected.txt:
* platform/efl/fast/css/text-overflow-ellipsis-strict-expected.txt:
* platform/efl/fast/css/text-transform-select-expected.txt:
* platform/efl/fast/css/textCapitalizeEdgeCases-expected.txt:
* platform/efl/fast/css/universal-hover-quirk-expected.txt:
* platform/efl/fast/css/value-list-out-of-bounds-crash-expected.txt:
* platform/efl/fast/css/word-space-extra-expected.txt:
* platform/efl/fast/css/zoom-font-size-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening, marked fast/js/random-array-gc-stress.html as SLOW on debug.
caseq@chromium.org [Wed, 2 May 2012 09:39:14 +0000 (09:39 +0000)]
Unreviewed gardening, marked fast/js/random-array-gc-stress.html as SLOW on debug.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoStyleSheetInternal::parseUserStyleSheet() should be called parseAuthorStyleSheet().
antti@apple.com [Wed, 2 May 2012 09:02:44 +0000 (09:02 +0000)]
StyleSheetInternal::parseUserStyleSheet() should be called parseAuthorStyleSheet().

Rubber-stamped by Nikolas Zimmermann.

* css/CSSImportRule.cpp:
(WebCore::StyleRuleImport::setCSSStyleSheet):
* css/CSSStyleSheet.cpp:
(WebCore::StyleSheetInternal::parseAuthorStyleSheet):
* css/CSSStyleSheet.h:
(StyleSheetInternal):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::setCSSStyleSheet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION: Web Inspector doesn't show cookies anymore
yurys@chromium.org [Wed, 2 May 2012 08:51:50 +0000 (08:51 +0000)]
REGRESSION: Web Inspector doesn't show cookies anymore
https://bugs.webkit.org/show_bug.cgi?id=85349

Pass root node instead of DataGrid object to the "populateNode" method.
Added compiler annotations so that closure compiler catches such errors.

Reviewed by Pavel Feldman.

* inspector/front-end/CookiesTable.js:
(WebInspector.CookiesTable.prototype._rebuildTable):
* inspector/front-end/NetworkRequest.js:
(WebInspector.NetworkRequest.prototype.addFrameError):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed test rebaseline after r115749.
caseq@chromium.org [Wed, 2 May 2012 08:29:52 +0000 (08:29 +0000)]
Unreviewed test rebaseline after r115749.

* platform/chromium-mac-leopard/media/audio-controls-rendering-expected.png:
* platform/chromium-mac-leopard/media/audio-repaint-expected.png:
* platform/chromium-mac-leopard/media/controls-after-reload-expected.png:
* platform/chromium-mac/media/audio-controls-rendering-expected.png:
* platform/chromium-mac/media/audio-repaint-expected.png:
* platform/chromium-mac/media/controls-after-reload-expected.png:
* platform/chromium-mac/media/controls-layout-direction-expected.png:
* platform/chromium-mac/media/media-controls-clone-expected.png:
* platform/chromium-win/media/audio-controls-rendering-expected.png:
* platform/chromium-win/media/audio-repaint-expected.png:
* platform/chromium-win/media/controls-after-reload-expected.png:
* platform/chromium-win/media/controls-layout-direction-expected.png:
* platform/chromium-win/media/media-controls-clone-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt]r57240 broke Qt build (gcc bug)
ossy@webkit.org [Wed, 2 May 2012 08:20:09 +0000 (08:20 +0000)]
[Qt]r57240 broke Qt build (gcc bug)
https://bugs.webkit.org/show_bug.cgi?id=37253

Patch by Adenilson Cavalcanti <cavalcantii@gmail.com> on 2012-05-02
Reviewed by Noam Rosenthal.

Removing workaround macro since current gcc/Qt doesn't require it to compile.

* wtf/PassRefPtr.h:
(WTF):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] QQuickWebView does not allow for input from virtual keyboard
hausmann@webkit.org [Wed, 2 May 2012 08:10:38 +0000 (08:10 +0000)]
[Qt] QQuickWebView does not allow for input from virtual keyboard
https://bugs.webkit.org/show_bug.cgi?id=85350

Reviewed by Kenneth Christiansen.

It is necessary to set the ItemAcceptsInputMethod flag on the QQuickWebView if we have editable
content, in order for the input method to recognize that we can handle input method events.

Analyzed by Michael Brüning.

* UIProcess/API/qt/qquickwebview.cpp: Add simple hook for executing JS as private C++ API.
(JSCallbackClosure):
(javaScriptCallback):
(QQuickWebView::runJavaScriptInMainFrame):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/tests/html/inputmethod.html: Added.
* UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
(tst_QQuickWebView):
(tst_QQuickWebView::runJavaScript): Simple helper for running JS.
(tst_QQuickWebView::inputMethod): Added simple test for ItemAcceptsInputMethod toggling.
* UIProcess/qt/QtWebPageEventHandler.cpp:
(WebKit::QtWebPageEventHandler::updateTextInputState): Set ItemAcceptsInputMethod as soon as we
have editable content.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Implement the Web Audio API feature.
commit-queue@webkit.org [Wed, 2 May 2012 07:58:30 +0000 (07:58 +0000)]
[EFL] Implement the Web Audio API feature.
https://bugs.webkit.org/show_bug.cgi?id=78688

Patch by Dongwoo Im <dw.im@samsung.com> on 2012-05-02
Reviewed by Philippe Normand.

Implement the Web Audio API feature on the EFL port.
https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html

.:

* Source/cmake/FindGStreamer-Audio.cmake: Added. Find the pkgconfig of the GStreamer-audio.
* Source/cmake/FindGStreamer-FFT.cmake: Added. Find the pkgconfig of the GStreamer-fft.
* Source/cmake/OptionsEfl.cmake: Add the ENABLE_WEB_AUDIO option.
* Source/cmakeconfig.h.cmake: Add the ENABLE_WEB_AUDIO option.

Source/WebCore:

* CMakeLists.txt: Add the list of the files which are needed for the Web Audio APi.
* PlatformEfl.cmake: Add the list of the files which are needed for the Web Audio APi.
* UseJSC.cmake: Add the list of the files which are needed for the Web Audio APi.
* platform/audio/HRTFElevation.cpp: Enable the USE_CONCATENATED_IMPULSE_RESPONSES macro.
(WebCore):
* platform/audio/efl/AudioBusEfl.cpp: Added.
(WebCore):
(WebCore::AudioBus::loadPlatformResource): Create the absolute path of the audio resource.

Source/WebKit/efl:

* ewk/ewk_view.cpp: Add the setter/getter of the webaudio feature.
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(ewk_view_setting_web_audio_get): Enable/disable the Web Audio API feature.
(ewk_view_setting_web_audio_set): Query if the Web Audio API feature is enabled.
* ewk/ewk_view.h: Add the prototypes.

LayoutTests:

* platform/efl/Skipped: Change the comment of webaudio.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Adjust baseline location for media/media-can-play-type-webm.html.
scherkus@chromium.org [Wed, 2 May 2012 07:00:52 +0000 (07:00 +0000)]
[Chromium] Adjust baseline location for media/media-can-play-type-webm.html.

* platform/chromium/media/media-can-play-webm-expected.txt: Renamed from LayoutTests/media/media-can-play-webm-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoClean up media canPlayType() tests and add a test for WebM.
scherkus@chromium.org [Wed, 2 May 2012 06:07:46 +0000 (06:07 +0000)]
Clean up media canPlayType() tests and add a test for WebM.
https://bugs.webkit.org/show_bug.cgi?id=85116

Reviewed by Eric Carlson.

* media/media-can-play-flac-audio-expected.txt:
* media/media-can-play-flac-audio.html:
* media/media-can-play-mpeg-audio-expected.txt:
* media/media-can-play-mpeg-audio.html:
* media/media-can-play-mpeg4-video.html:
* media/media-can-play-octet-stream-expected.txt:
* media/media-can-play-octet-stream.html:
* media/media-can-play-ogg-expected.txt:
* media/media-can-play-ogg.html:
* media/media-can-play-type-expected.txt: Renamed from LayoutTests/media/video-can-play-type-expected.txt.
* media/media-can-play-type.html: Added.
* media/media-can-play-wav-audio-expected.txt:
* media/media-can-play-wav-audio.html:
* media/media-can-play-webm-expected.txt: Added.
* media/media-can-play-webm.html: Added.
* media/video-can-play-type.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Add an Isolate parameter to setJSWrapperForXXX()
haraken@chromium.org [Wed, 2 May 2012 06:07:03 +0000 (06:07 +0000)]
[V8] Add an Isolate parameter to setJSWrapperForXXX()
https://bugs.webkit.org/show_bug.cgi?id=85329

Reviewed by Adam Barth.

The objective is to pass Isolate around in V8 bindings.
This patch adds an Isolate parameter to setJSWrapperForXXX()
and passes Isolate to setJSWrapperForXXX() in CodeGeneratorV8.pm.
I'll pass Isolate to setJSWrapperForXXX() in custom bindings
in a follow-up patch.

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm: Modified as described above.
(GenerateConstructorCallback):
(GenerateEventConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateToV8Converters):
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::setJSWrapperForDOMNode):
(WebCore::V8DOMWrapper::setJSWrapperForActiveDOMNode):
* bindings/v8/V8DOMWrapper.h:
(V8DOMWrapper):
(WebCore::V8DOMWrapper::setJSWrapperForDOMObject):
(WebCore::V8DOMWrapper::setJSWrapperForActiveDOMObject):

* bindings/scripts/test/V8/V8Float64Array.cpp: Updated run-bindings-tests results.
(WebCore::V8Float64Array::wrapSlow):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::V8TestActiveDOMObject::wrapSlow):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::wrapSlow):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::constructorCallback):
(WebCore::V8TestEventConstructor::wrapSlow):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::V8TestEventTarget::wrapSlow):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::constructorCallback):
(WebCore::V8TestInterface::wrapSlow):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::wrapSlow):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructorConstructorCallback):
(WebCore::V8TestNamedConstructor::wrapSlow):
* bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::constructorCallback):
(WebCore::V8TestNode::wrapSlow):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::constructorCallback):
(WebCore::V8TestObj::wrapSlow):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):
(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd <iframe seamless> navigation code (and pass all the navigation tests)
eric@webkit.org [Wed, 2 May 2012 05:54:44 +0000 (05:54 +0000)]
Add <iframe seamless> navigation code (and pass all the navigation tests)
https://bugs.webkit.org/show_bug.cgi?id=85340

Reviewed by Adam Barth.

Source/WebCore:

This code was primarily written by Adam Barth and then submitted to my
GitHub branch via a pull request:
https://github.com/eseidel/webkit/compare/master...seamless
https://github.com/eseidel/webkit/pull/2
https://github.com/eseidel/webkit/pull/3

I rewrote parts of it to use Docment::shouldDisplaySeamlesslyWithParent.

Other parts of the original change have already been committed to WebKit by Adam
as part of prep-work for making the loader seamless-ready.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::findFrameForNavigation):

LayoutTests:

Update results now that we pass all the navigation tests.

* fast/frames/seamless/seamless-form-get-expected.txt:
* fast/frames/seamless/seamless-form-get-named-expected.txt:
* fast/frames/seamless/seamless-form-post-expected.txt:
* fast/frames/seamless/seamless-form-post-named-expected.txt:
* fast/frames/seamless/seamless-hyperlink-expected.txt:
* fast/frames/seamless/seamless-hyperlink-named-expected.txt:
* fast/frames/seamless/seamless-window-location-expected.txt:
* fast/frames/seamless/seamless-window-location-href-expected.txt:
* fast/frames/seamless/seamless-window-location-sandbox-expected.txt:
* fast/frames/seamless/seamless-window-open-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Move date-input-visible-strings-expected.txt to the correct place.
tkent@chromium.org [Wed, 2 May 2012 05:12:58 +0000 (05:12 +0000)]
[Chromium] Move date-input-visible-strings-expected.txt to the correct place.

* platform/chromium-linux/fast/forms/date/date-input-visible-strings-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/forms/date/date-input-visible-strings-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnnecessary <form> tags created inside of an <iframe> with designMode on
rniwa@webkit.org [Wed, 2 May 2012 04:57:30 +0000 (04:57 +0000)]
Unnecessary <form> tags created inside of an <iframe> with designMode on
https://bugs.webkit.org/show_bug.cgi?id=13126

Reviewed by Eric Seidel.

Add a regression test since this bug doesn't reproduce anymore but it's still good to test it.

* editing/inserting/insert-paragraph-inside-form-expected.txt: Added.
* editing/inserting/insert-paragraph-inside-form.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFullscreen pop-up logic restored to using processingUserGesture.
scheib@chromium.org [Wed, 2 May 2012 04:28:14 +0000 (04:28 +0000)]
Fullscreen pop-up logic restored to using processingUserGesture.
https://bugs.webkit.org/show_bug.cgi?id=85105

WebKit was recently updated to the new Fullscreen API:
http://dvcs.w3.org/hg/fullscreen/raw-file/tip/Overview.html#api
http://trac.webkit.org/changeset/111028

This change reverts back to using processingUserGesture() instead
of DOMWindow::allowPopUp(). This fixes incorrect behavior in
at least the Chromium port and is consistent with the cited
definition of "allowed to show a pop-up":
  An algorithm is allowed to show a pop-up if, in the task in which the algorithm is running, either:
  - an activation behavior is currently being processed whose click event was trusted, or
  - the event listener for a trusted click event is being handled.

Reviewed by Dimitri Glazkov.

No new tests.

* dom/Document.cpp:
(WebCore::Document::requestFullScreenForElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-05-01 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Wed, 2 May 2012 04:16:31 +0000 (04:16 +0000)]
2012-05-01  Xiaomei Ji  <xji@chromium.org>

        Skip editing/selection/move-by-word-visually-mac.html (introduced in r115788) in qt and wk2.

        * platform/qt/Skipped:
        * platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowebkitpy: Remove unused platform imports.
rakuco@webkit.org [Wed, 2 May 2012 04:01:24 +0000 (04:01 +0000)]
webkitpy: Remove unused platform imports.
https://bugs.webkit.org/show_bug.cgi?id=85341

Reviewed by Eric Seidel.

Remove a few uses of `import platform' which were either rendered
unneeded after r105931 or were never needed at all.

* Scripts/webkitpy/common/system/executive.py:
* Scripts/webkitpy/tool/bot/flakytestreporter.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: enable ctrl-arrow move by word visually in non-Windows platforms.
xji@chromium.org [Wed, 2 May 2012 03:41:29 +0000 (03:41 +0000)]
Source/WebCore: enable ctrl-arrow move by word visually in non-Windows platforms.
https://bugs.webkit.org/show_bug.cgi?id=85017

Reviewed by Ryosuke Niwa.

Enable ctrl-arrow moves caret by word in visual order in non-Windows platforms that use ICU word
break iterator (it is not enabled for WinCE and Qt where ICU is not used). For those platforms, ctrl-arrow
moves caret to word break position before spaces. For example, given a logical text "abc def hij", the word
break positions using ctrl-left-arrow from rightmost position are "|abc |def |hij".
The word break positions using ctrl-right-arrow from leftmost position are "abc| def| hij|".

Test: editing/selection/move-by-word-visually-mac.html

* editing/EditingBehavior.h:
(EditingBehavior):
(WebCore::EditingBehavior::shouldEatSpaceToNextWord): To control different word break positions
(regards to space) for different platforms.
* editing/FrameSelection.cpp:
(WebCore::FrameSelection::modifyMovingRight): Enable visual word movement for all platforms that use ICU.
(WebCore::FrameSelection::modifyMovingLeft):
* editing/visible_units.cpp:
(WebCore::visualWordPosition): Determine the right word break position (regards to space) based on EditingBehavior.
(WebCore::leftWordPosition):
(WebCore::rightWordPosition):
* editing/visible_units.h:

LayoutTests: enable ctrl-arrow move by word visually in other platforms (besides Windows)
https://bugs.webkit.org/show_bug.cgi?id=85017

Reviewed by Ryosuke Niwa.

Since DOMSelection.modify('move', 'left'/'right', 'word') moves caret by word in visual order (instead of
logical order) now, there are several changes to the test file:
1. file name renamed from move-left-right-by-word-mac.html to move-by-word-visually-mac.html.
2. test expectations change from moving caret by word in logical order to moving caret by word in visual order.
3. since test expectations are inside test file itself, test file itself changes accordingly.

* editing/selection/move-by-word-visually-mac-expected.txt: Copied from LayoutTests/editing/selection/move-left-right-by-word-mac-expected.txt.
* editing/selection/move-by-word-visually-mac.html: Copied from LayoutTests/editing/selection/move-left-right-by-word-mac.html.
* editing/selection/move-left-right-by-word-mac-expected.txt: Removed.
* editing/selection/move-left-right-by-word-mac.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoModify RealtimeAnalyserNode pull mechanism
commit-queue@webkit.org [Wed, 2 May 2012 03:38:23 +0000 (03:38 +0000)]
Modify RealtimeAnalyserNode pull mechanism
https://bugs.webkit.org/show_bug.cgi?id=77515

Patch by Raymond Liu <raymond.liu@intel.com> on 2012-05-01
Reviewed by Chris Rogers.

Source/WebCore:

Test: webaudio/automatic-pull-node.html

* GNUmakefile.list.am:
* Modules/webaudio/AudioBasicInspectorNode.cpp: Added.
(WebCore):
(WebCore::AudioBasicInspectorNode::AudioBasicInspectorNode):
(WebCore::AudioBasicInspectorNode::pullInputs):
(WebCore::AudioBasicInspectorNode::connect):
(WebCore::AudioBasicInspectorNode::disconnect):
(WebCore::AudioBasicInspectorNode::checkNumberOfChannelsForInput):
(WebCore::AudioBasicInspectorNode::updatePullStatus):
* Modules/webaudio/AudioBasicInspectorNode.h: Added.
(WebCore):
(AudioBasicInspectorNode):
* Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::AudioContext):
(WebCore::AudioContext::~AudioContext):
(WebCore::AudioContext::handlePreRenderTasks):
(WebCore::AudioContext::handlePostRenderTasks):
(WebCore::AudioContext::markForDeletion):
(WebCore):
(WebCore::AudioContext::addAutomaticPullNode):
(WebCore::AudioContext::removeAutomaticPullNode):
(WebCore::AudioContext::updateAutomaticPullNodes):
(WebCore::AudioContext::processAutomaticPullNodes):
* Modules/webaudio/AudioContext.h:
(AudioContext):
* Modules/webaudio/AudioDestinationNode.cpp:
(WebCore::AudioDestinationNode::provideInput):
* Modules/webaudio/AudioNode.h:
(AudioNode):
* Modules/webaudio/AudioNodeOutput.h:
(WebCore::AudioNodeOutput::isConnected):
(AudioNodeOutput):
* Modules/webaudio/RealtimeAnalyserNode.cpp:
(WebCore::RealtimeAnalyserNode::RealtimeAnalyserNode):
* Modules/webaudio/RealtimeAnalyserNode.h:
(RealtimeAnalyserNode):
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:

LayoutTests:

* webaudio/automatic-pull-node-expected.txt: Added.
* webaudio/automatic-pull-node.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agodatalist: Form control in a <datalist> should be barred from constraint validation
keishi@webkit.org [Wed, 2 May 2012 03:35:48 +0000 (03:35 +0000)]
datalist: Form control in a <datalist> should be barred from constraint validation
https://bugs.webkit.org/show_bug.cgi?id=84359

Reviewed by Kent Tamura.

Source/WebCore:

Tests: fast/forms/datalist/datalist-child-validation.html
       fast/forms/form-control-element-crash.html

* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::HTMLFormControlElement):
(WebCore::HTMLFormControlElement::updateAncestors): Updates the ancestor information.
(WebCore::HTMLFormControlElement::insertedInto): Invalidate the ancestor information and call setNeedsWillValidateCheck because willValidate might have changed.
(WebCore::HTMLFormControlElement::removedFrom): Ditto.
(WebCore::HTMLFormControlElement::disabled):
(WebCore::HTMLFormControlElement::recalcWillValidate): Returns false if element has a datalist ancestor.
(WebCore::HTMLFormControlElement::willValidate): Check if ancestor information is valid too.
(WebCore::HTMLFormControlElement::setNeedsWillValidateCheck):
* html/HTMLFormControlElement.h:
(HTMLFormControlElement):

LayoutTests:

* fast/forms/datalist/datalist-child-validation-expected.txt: Added.
* fast/forms/datalist/datalist-child-validation.html: Added. Tests that willValidate changes from false to true when we move the element out of the datalist.
* fast/forms/form-control-element-crash-expected.txt: Added.
* fast/forms/form-control-element-crash.html: Added. Tests for the crash reported in Bug 85149.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCalendar Picker: Close the picker by ESC key
tkent@chromium.org [Wed, 2 May 2012 03:27:06 +0000 (03:27 +0000)]
Calendar Picker: Close the picker by ESC key
https://bugs.webkit.org/show_bug.cgi?id=85337

Reviewed by Kentaro Hara.

No new tests. Calendar picker is not testable in DRT yet.

* Resources/calendarPicker.js:
(handleGlobalKey): Close the popup by ESC key.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPNGImageDecoder: Handle interlace buffer allocation failure
noel.gordon@gmail.com [Wed, 2 May 2012 03:20:30 +0000 (03:20 +0000)]
PNGImageDecoder: Handle interlace buffer allocation failure
https://bugs.webkit.org/show_bug.cgi?id=85276

Reviewed by Eric Seidel.

No new tests. Not something we can easily test (malloc failure).

* platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::PNGImageDecoder::rowAvailable): Check interlace buffer allocations
and bail via longjmp on failure. Note PNG_INTERLACE_ADAM7 is the only libpng
supported interlace type so test for it explicitly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCalendar Picker: Too wide in Japanese locale
tkent@chromium.org [Wed, 2 May 2012 03:01:29 +0000 (03:01 +0000)]
Calendar Picker: Too wide in Japanese locale
https://bugs.webkit.org/show_bug.cgi?id=85331

Reviewed by Kentaro Hara.

No new tests. This is a locale-specific behavior.

* Resources/calendarPicker.js:
(formatJapaneseImperialEra):
Do not show an imperial era later than 平成99年 to avoid very long
year string like "275760年(平成273772年)."
(YearMonthController.prototype.attachTo):
- Respect the maximum year specfied by <input max=...>
  If <input max="9999-12-31"> is specified, we don't need to
  secure space for the year 275,760.
- Check the width for 平成99年 as well as the maximum year because
  "2087年(平成99年)" is usually wider than "275760年".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPNGImageDecoder: Add ENABLE(IMAGE_DECODER_DOWN_SAMPLING) guards to rowAvailable
noel.gordon@gmail.com [Wed, 2 May 2012 02:52:32 +0000 (02:52 +0000)]
PNGImageDecoder: Add ENABLE(IMAGE_DECODER_DOWN_SAMPLING) guards to rowAvailable
https://bugs.webkit.org/show_bug.cgi?id=85268

Reviewed by Eric Seidel.

PNGImageDecoder supports image downsampling. Add ENABLE guards to show where
downsampling is applied when outputting decoded rows to the frame buffer. Most
ports don't enable the flag: don't penalize them in terms speed in this tight
row pixel write loop. s/y/destY/ to match setRGBA() and amend some comments.

No new tests. No change in behavior.

* platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::PNGImageDecoder::rowAvailable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Rebaseline for date-input-visible-strings.html.
tkent@chromium.org [Wed, 2 May 2012 02:24:20 +0000 (02:24 +0000)]
[Chromium] Rebaseline for date-input-visible-strings.html.

* platform/chromium-linux-x86/fast/forms/date/date-input-visible-strings-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/forms/date/date-input-visible-strings-expected.txt.
* platform/chromium/fast/forms/date/date-input-visible-strings-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/forms/date/date-input-visible-strings-expected.txt.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoscrollbars/scrollbar-miss-mousemove-disabled.html is asserting in markAllMisspellings...
aestes@apple.com [Wed, 2 May 2012 02:14:42 +0000 (02:14 +0000)]
scrollbars/scrollbar-miss-mousemove-disabled.html is asserting in markAllMisspellingsAndBadGrammarInRanges()
https://bugs.webkit.org/show_bug.cgi?id=85273

* platform/mac/Skipped: Skip the test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove uneeded min/max pref width assignment from RenderView
eric@webkit.org [Wed, 2 May 2012 02:09:34 +0000 (02:09 +0000)]
Remove uneeded min/max pref width assignment from RenderView
https://bugs.webkit.org/show_bug.cgi?id=85325

Reviewed by Julien Chaffraix.

This code has been with us since the original import from KDE:
http://trac.webkit.org/browser/trunk/WebCore/khtml/rendering/render_root.cpp?annotate=blame&rev=4#L93
It's never been documented, or explained.  Removing it showed no
effect on my local layout tests run.
However this code blocks proper implementation of <iframe seamless>
as we have to do proper min/max width negotiation across the iframe boundary.

I would remove the whole function, but doing so opens a whole can of worms
as this override is public, yet normally this function is *private* (well protected on RenderBox).
It seems plausible that frame flattening code needs this override since it doesn't always
call the min/maxPreferredWidth() calls which normally automatically call this compute*
function if the pref-widths are dirty.
Instead of trying to track that all down, I'm just removing this line, and we'll go
back and remove the whole function at a later date if possible.

* rendering/RenderView.cpp:
(WebCore::RenderView::computePreferredLogicalWidths):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoActually commit changes.
rniwa@webkit.org [Wed, 2 May 2012 01:36:44 +0000 (01:36 +0000)]
Actually commit changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSkip the test added by r115724 on WebKit2 and Qt because drag and drop isn't supporte...
rniwa@webkit.org [Wed, 2 May 2012 01:34:06 +0000 (01:34 +0000)]
Skip the test added by r115724 on WebKit2 and Qt because drag and drop isn't supported by DRT
on those platforms.

* platform/qt/Skipped:
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] new ref test fast/forms/listbox-clear-restore.html fails.
commit-queue@webkit.org [Wed, 2 May 2012 01:32:38 +0000 (01:32 +0000)]
[GTK] new ref test fast/forms/listbox-clear-restore.html fails.
https://bugs.webkit.org/show_bug.cgi?id=77633

Patch by Joe Thomas <joethomas@motorola.com> on 2012-05-01
Reviewed by Martin Robinson.

Flakiness of the test case is fixed in http://trac.webkit.org/changeset/115526.
Enabling the test for GTK and Chromium ports.

* platform/chromium/test_expectations.txt:
* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: REGRESSION(r115654): PDFs come up blank
japhet@chromium.org [Wed, 2 May 2012 01:23:10 +0000 (01:23 +0000)]
Source/WebCore: REGRESSION(r115654): PDFs come up blank
https://bugs.webkit.org/show_bug.cgi?id=85275

Reviewed by Alexey Proskuryakov.

Test: http/tests/loading/pdf-commit-load-callbacks.html

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::finishedLoading): The load needs to be
    committed before we call finishedLoading on the
    FrameLoaderClient.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::transitionToCommitted): We're guaranteeing
    that receivedFirstData() will be called other ways (namely,
    DocumentLoader won't finish without doing so). This call now
    causes custom representations to double-commit, which is bad.

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=85275.

Reviewed by Alexey Proskuryakov.

* http/tests/loading/pdf-commit-load-callbacks-expected.txt: Added.
* http/tests/loading/pdf-commit-load-callbacks.html: Added.
* platform/chromium/http/tests/loading: Added.
* platform/chromium/http/tests/loading/pdf-commit-load-callbacks-expected.txt: Added.
* platform/wk2/Skipped: New test requires layoutTestController.dumpResourceLoadCallbacks(),
    which isn't support for wk2 yet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd support for seamless attribute as well as seamless sandbox flag and default CSS...
eric@webkit.org [Wed, 2 May 2012 01:09:53 +0000 (01:09 +0000)]
Add support for seamless attribute as well as seamless sandbox flag and default CSS styling
https://bugs.webkit.org/show_bug.cgi?id=85302

Reviewed by Ojan Vafai.

Source/WebCore:

This also adds support for the seamless sandbox flag from HTML 5.
The sandbox flag is not speficially overridable in the current HTML5,
but it is set (like all sandbox flags) by default when sandbox is specified.
Unfortunately this support is not yet observable in this patch, as
this patch adds not observable features of seamless.

This patch also adds the html.css additions for seamless, as specified:
http://www.whatwg.org/specs/web-apps/current-work/multipage/rendering.html#replaced-elements

I noticed that my previous testing did not confirm that iframes marked
for seamless (but not possible to display as seamless due to sandbox, etc.)
were still to have this seamless styling.  I've added additional testing for this case.

I also added another test for the about:blank FIXME added as part of this change.

In order to support srcdoc w/ seamless, we needed to move the srcdoc determination
sooner in the initSecurityContext function (before the should-inherit early return).

The next patch will make seamless actually observable from JS/DOM, this one
just lays down all the plumbing, and separates the security aspects for
easy review.

Test: fast/frames/seamless/seamless-inherited-origin.html

* css/html.css:
(iframe:not([seamless])):
(iframe[seamless]):
* dom/Document.cpp:
(WebCore::isEligibleForSeamless):
(WebCore):
(WebCore::Document::initSecurityContext):
(WebCore::Document::seamlessParentIFrame):
(WebCore::Document::shouldDisplaySeamlesslyWithParent):
* dom/Document.h:
(WebCore):
(Document):
* dom/SecurityContext.cpp:
(WebCore::SecurityContext::SecurityContext):
* dom/SecurityContext.h:
(WebCore::SecurityContext::mayDisplaySeamlessWithParent):
(SecurityContext):
* html/HTMLAttributeNames.in:
* html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::shouldDisplaySeamlessly):
(WebCore):
* html/HTMLIFrameElement.h:
(HTMLIFrameElement):
* html/HTMLIFrameElement.idl:

LayoutTests:

Update all the test results now that the html.css changes have
been added for seamless, as specified by HTML5:
http://www.whatwg.org/specs/web-apps/current-work/multipage/rendering.html#replaced-elements

I also added a new test for about:blank iframes (per a code-FIXME)
as well as some new testing to confirm that the default seamless-CSS style
applies even when iframes cannot render seamless due to security restrictions.

* fast/frames/seamless/seamless-basic-expected.txt:
* fast/frames/seamless/seamless-basic.html:
* fast/frames/seamless/seamless-inherited-origin-expected.txt: Added.
* fast/frames/seamless/seamless-inherited-origin.html: Added.
* fast/frames/seamless/seamless-inline-expected.txt:
* fast/frames/seamless/seamless-min-max-expected.txt:
* fast/frames/seamless/seamless-nested-expected.txt:
* fast/frames/seamless/seamless-quirks-expected.txt:
* fast/frames/seamless/seamless-sandbox-flag-expected.txt:
* fast/frames/seamless/seamless-sandbox-flag.html:
* fast/frames/seamless/seamless-sandbox-srcdoc-expected.txt:
* http/tests/security/seamless/seamless-cross-origin-expected.txt:
* http/tests/security/seamless/seamless-sandbox-srcdoc-expected.txt:
* svg/in-html/by-reference.html: was using seamless, but really doens't want to, doing so just adds noise.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Additional instances of calling histogramCustomCounts directly
pilgrim@chromium.org [Wed, 2 May 2012 00:41:34 +0000 (00:41 +0000)]
[Chromium] Additional instances of calling histogramCustomCounts directly
https://bugs.webkit.org/show_bug.cgi?id=85322

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

* src/painting/PaintAggregator.cpp:
(WebKit::PaintAggregator::invalidateRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agouse USE(NATIVE_FULLSCREEN_VIDEO) instead of ENABLE(NATIVE_FULLSCREEN_VIDEO)
commit-queue@webkit.org [Wed, 2 May 2012 00:39:31 +0000 (00:39 +0000)]
use USE(NATIVE_FULLSCREEN_VIDEO) instead of ENABLE(NATIVE_FULLSCREEN_VIDEO)
https://bugs.webkit.org/show_bug.cgi?id=85316

Patch by Min Qin <qinmin@google.com> on 2012-05-01
Reviewed by Kent Tamura.

Source/WebCore:

NATIVE_FULLSCREEN_VIDEO means the fullscreen video is implemented by native
system view instead of webkit.
So it is more appropriate to use USE(NATIVE_FULLSCREEN_VIDEO).
This chagne also disabled the rendering of the fullscreen video element in webkit
when that flag is set.
Just renaming the variable, no new tests.

* dom/Document.cpp:
(WebCore::Document::webkitWillEnterFullScreenForElement):
(WebCore):
* platform/graphics/MediaPlayer.cpp:
(WebCore):
* platform/graphics/MediaPlayer.h:
(MediaPlayer):
* platform/graphics/MediaPlayerPrivate.h:
(MediaPlayerPrivateInterface):

Source/WebKit/chromium:

NATIVE_FULLSCREEN_VIDEO means the fullscreen video is implemented by native
system view instead of webkit
So it is more appropriate to use USE(NATIVE_FULLSCREEN_VIDEO).
Just rename the flag, no new tests

* features.gypi:
* src/WebMediaPlayerClientImpl.cpp:
(WebKit):
* src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::enterFullScreenForElement):
(WebKit::WebViewImpl::exitFullScreenForElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoinspectorReallyUsesWebKitUserInterface should be more robust against missing files
andersca@apple.com [Wed, 2 May 2012 00:36:31 +0000 (00:36 +0000)]
inspectorReallyUsesWebKitUserInterface should be more robust against missing files
https://bugs.webkit.org/show_bug.cgi?id=85327
<rdar://problem/11332864>

Reviewed by Timothy Hatcher.

* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::inspectorReallyUsesWebKitUserInterface):
* WebProcess/WebPage/mac/WebInspectorMac.mm:
(WebKit::inspectorReallyUsesWebKitUserInterface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Additional instances of calling createAudioDevice directly
pilgrim@chromium.org [Wed, 2 May 2012 00:33:43 +0000 (00:33 +0000)]
[Chromium] Additional instances of calling createAudioDevice directly
https://bugs.webkit.org/show_bug.cgi?id=85321

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

* src/AudioDestinationChromium.cpp:
(WebCore::AudioDestinationChromium::AudioDestinationChromium):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Additional instances of calling mimeRegistry directly
pilgrim@chromium.org [Wed, 2 May 2012 00:27:45 +0000 (00:27 +0000)]
[Chromium] Additional instances of calling mimeRegistry directly
https://bugs.webkit.org/show_bug.cgi?id=85320

Reviewed by Eric Seidel.

Part of a refactoring series. See tracking bug 82948.

* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::canShowMIMEType):
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::supportsType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Accept four parameters when dispatching a WebInputEvent::GestureTap in...
commit-queue@webkit.org [Wed, 2 May 2012 00:21:20 +0000 (00:21 +0000)]
[chromium] Accept four parameters when dispatching a WebInputEvent::GestureTap in chromium DRT eventSender
https://bugs.webkit.org/show_bug.cgi?id=85289

Patch by Terry Anderson <tdanderson@chromium.org> on 2012-05-01
Reviewed by Eric Seidel.

* DumpRenderTree/chromium/EventSender.cpp:
(EventSender::gestureEvent):
    This change will allow for testing of WK85101. Currently
    no tests use the extra parameters deltaX and deltaY. Added
    a check for the size of |arguments|.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago<rdar://problem/10422318> Support for web content filter delegate for filtering https...
jpfau@apple.com [Wed, 2 May 2012 00:17:06 +0000 (00:17 +0000)]
<rdar://problem/10422318> Support for web content filter delegate for filtering https content
https://bugs.webkit.org/show_bug.cgi?id=85300

Reviewed by Alexey Proskuryakov.

Source/WebCore:

No new tests.

* WebCore.exp.in:
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::MainResourceLoader):
(WebCore::MainResourceLoader::~MainResourceLoader):
(WebCore::MainResourceLoader::didCancel):
(WebCore::MainResourceLoader::didReceiveResponse):
(WebCore::MainResourceLoader::didReceiveData):
(WebCore::MainResourceLoader::didFinishLoading):
(WebCore::MainResourceLoader::didFail):
* loader/MainResourceLoader.h:
(MainResourceLoader):
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac:

* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

Source/WebKit2:

* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCalendar Picker: Add capability to add platform-specific style sheet
tkent@chromium.org [Wed, 2 May 2012 00:12:49 +0000 (00:12 +0000)]
Calendar Picker: Add capability to add platform-specific style sheet
https://bugs.webkit.org/show_bug.cgi?id=85272

Reviewed by Kentaro Hara.

Add RenderTheme::extraCalendarPickerStyleSheet(). The resultant string
of the function is inserted into the calendar picker page.

No new tests. Calendar picker apperance is not testable yet.

* Resources/calendarPicker.css: Removed styles for year-month buttons.
* Resources/calendarPickerMac.css:
Moved from calendarPicker.css, and adjust styles so that they look
standard Lion buttons.
(.year-month-button):
(.year-month-button:active):
(.year-month-button:disabled):
* WebCore.gyp/WebCore.gyp: Add a rule to produce CalendarPickerMac.{cpp,h}.
* html/shadow/CalendarPickerElement.cpp:
(WebCore::CalendarPickerElement::writeDocument):
Add extraCalendarPickerStyleSheet() result to the document.
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::extraCalendarPickerStyleSheet):
Added. Returns an empty CString by default.
* rendering/RenderTheme.h:
(RenderTheme): Added extraCalendarPickerStyleSheet().
* rendering/RenderThemeChromiumMac.h: Added extraCalendarPickerStyleSheet().
* rendering/RenderThemeChromiumMac.mm:
(WebCore::RenderThemeChromiumMac::extraCalendarPickerStyleSheet):
Added. Returns the content of Resources/calendarPickerMac.css.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEnsure HTMLElementStack fails gracefully if it has a non-Element.
simonjam@chromium.org [Wed, 2 May 2012 00:04:01 +0000 (00:04 +0000)]
Ensure HTMLElementStack fails gracefully if it has a non-Element.
https://bugs.webkit.org/show_bug.cgi?id=85167

Reviewed by Adam Barth.

Source/WebCore:

Test: Added to html5lib/resources/webkit02.dat

* html/parser/HTMLElementStack.cpp:
(WebCore::HTMLElementStack::oneBelowTop):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processEndTag):

LayoutTests:

* html5lib/resources/webkit02.dat:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd myself to the watchlist to watch all rendering changes, as well as sort the watch...
eric@webkit.org [Tue, 1 May 2012 23:39:21 +0000 (23:39 +0000)]
Add myself to the watchlist to watch all rendering changes, as well as sort the watchers in the list
https://bugs.webkit.org/show_bug.cgi?id=85305

Reviewed by Adam Barth.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago*Command.h files shouldn't be exported to WebKit layer
rniwa@webkit.org [Tue, 1 May 2012 23:36:57 +0000 (23:36 +0000)]
*Command.h files shouldn't be exported to WebKit layer
https://bugs.webkit.org/show_bug.cgi?id=74778

Reviewed by Eric Seidel.

Source/WebCore:

Remove the dependency on *Command.h files from Mac port's WebKit layer.
Also wrapped the call to TypingCommand::insertParagraphSeparatorInQuotedContent in the Editor class
so that we can just expose Editor's method instead of directly exposing the said static method.

* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:
* editing/Editor.h:
(Editor):
* editing/mac/EditorMac.mm:
(WebCore::Editor::insertParagraphSeparatorInQuotedContent):
(WebCore):

Source/WebKit/chromium:

* src/WebFrameImpl.cpp:
* src/WebViewImpl.cpp:

Source/WebKit/gtk:

* webkit/webkitwebframe.cpp:

Source/WebKit/mac:

* WebView/WebFrame.mm:
(-[WebFrame _insertParagraphSeparatorInQuotedContent]):

Source/WebKit/win:

* WebView.cpp:

Source/WebKit2:

* WebProcess/WebPage/WebPage.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] fast/loader/file-protocol-fragment.html needs rebaselining
commit-queue@webkit.org [Tue, 1 May 2012 23:09:14 +0000 (23:09 +0000)]
[EFL] fast/loader/file-protocol-fragment.html needs rebaselining
https://bugs.webkit.org/show_bug.cgi?id=85182

Unreviewed, add EFL expectation for fast/loader/file-protocol-fragment.html
and unskip the test.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-01

* platform/efl/Skipped:
* platform/efl/fast/loader/file-protocol-fragment-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove expectations for media/encrypted-media/encrypted-media-events.html now that...
commit-queue@webkit.org [Tue, 1 May 2012 23:01:35 +0000 (23:01 +0000)]
Remove expectations for media/encrypted-media/encrypted-media-events.html now that crash is fixed.
https://bugs.webkit.org/show_bug.cgi?id=84596

Unreviewed expectations update.

Patch by David Dorwin <ddorwin@chromium.org> on 2012-05-01

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115757 268f45cc-cd09-0410-ab3c-d52691b4dbfc