WebKit-https.git
11 years ago2009-07-23 Jian Li <jianli@chromium.org>
jianli@chromium.org [Thu, 23 Jul 2009 20:37:02 +0000 (20:37 +0000)]
2009-07-23  Jian Li  <jianli@chromium.org>

        Reviewed by David Levin.

        [V8] Fix an assert in running workers in Chrome.
        https://bugs.webkit.org/show_bug.cgi?id=27620

        The fix is to change V8DOMMap::removeAllDOMObjectsInCurrentThreadHelper
        to do not call removeObjectsFromWrapperMap for certain types of DOM
        objects that exist only in main thread.

        * bindings/v8/V8DOMMap.cpp:
        (WebCore::removeAllDOMObjectsInCurrentThreadHelper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-23 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 23 Jul 2009 19:24:52 +0000 (19:24 +0000)]
2009-07-23  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by David Hyatt.

        Rebaseline for http://trac.webkit.org/changeset/46274
        (The changeset rebaselined the expected results for mac but not for windows)

        * platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
        * platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
hyatt@apple.com [Thu, 23 Jul 2009 19:06:33 +0000 (19:06 +0000)]
WebCore:

2009-07-23  David Hyatt  <hyatt@apple.com>

        Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=27572
        Implement support for background-attachment:local.

        Added new test fast/overflow/overflow-with-local-attachment.html.

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseFillProperty):
        * css/CSSPrimitiveValueMappings.h:
        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
        (WebCore::CSSPrimitiveValue::operator EFillAttachment):
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::mapFillAttachment):
        * css/CSSValueKeywords.in:
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintFillLayerExtended):
        (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
        * rendering/style/FillLayer.h:
        (WebCore::FillLayer::attachment):
        (WebCore::FillLayer::setAttachment):
        (WebCore::FillLayer::hasFixedImage):
        (WebCore::FillLayer::initialFillAttachment):
        * rendering/style/RenderStyle.h:
        (WebCore::InheritedFlags::backgroundAttachment):
        (WebCore::InheritedFlags::maskAttachment):
        * rendering/style/RenderStyleConstants.h:
        (WebCore::):

LayoutTests:

2009-07-23  David Hyatt  <hyatt@apple.com>

        Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=27572
        Implement support for background-attachment:local.

        Added new test fast/overflow/overflow-with-local-attachment.html.

        * fast/overflow/overflow-with-local-background-attachment.html: Added.
        * platform/mac/fast/overflow/overflow-with-local-background-attachment-expected.checksum: Added.
        * platform/mac/fast/overflow/overflow-with-local-background-attachment-expected.png: Added.
        * platform/mac/fast/overflow/overflow-with-local-background-attachment-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-23 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 23 Jul 2009 18:55:48 +0000 (18:55 +0000)]
2009-07-23  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        copyInheritableProperties and removeComputedInheritablePropertiesFrom should be deprecated
        https://bugs.webkit.org/show_bug.cgi?id=27325

        This patch deprecates copyInheritableProperties because it has been used for two different purposes:
        1.  Calculating the typing style.
        2.  Moving HTML subtrees and seeking to remove redundant styles.
        These tasks should be broken out into two separate functions.  New code should not use this function.

        It deletes removeComputedInheritablePropertiesFrom because it hasn't been used anywhere.

        There is no test since the patch does not change any behavior.

        * css/CSSComputedStyleDeclaration.cpp: removeComputedInheritablePropertiesFrom has been removed
        (WebCore::CSSComputedStyleDeclaration::deprecatedCopyInheritableProperties): has been renamed from copyInheritableProperties
        * css/CSSComputedStyleDeclaration.h: ditto
        * editing/DeleteSelectionCommand.cpp: ditto
        (WebCore::removeEnclosingAnchorStyle): ditto
        (WebCore::DeleteSelectionCommand::saveTypingStyleState): ditto
        * editing/EditCommand.cpp: ditto
        (WebCore::EditCommand::styleAtPosition): ditto
        * editing/RemoveFormatCommand.cpp: ditto
        (WebCore::RemoveFormatCommand::doApply): ditto
        * editing/ReplaceSelectionCommand.cpp: ditto
        (WebCore::handleStyleSpansBeforeInsertion): ditto
        (WebCore::ReplaceSelectionCommand::handleStyleSpans): ditto
        * editing/markup.cpp: ditto
        (WebCore::removeEnclosingMailBlockquoteStyle): ditto
        (WebCore::removeDefaultStyles): ditto
        (WebCore::createMarkup): ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
pdherbemont@apple.com [Thu, 23 Jul 2009 18:42:23 +0000 (18:42 +0000)]
WebCore:

    2009-07-22  Pierre d'Herbemont  <pdherbemont@apple.com>

        Reviewed by Simon Fraser.

        Audio element at default width shouldn't have time field.
        https://bugs.webkit.org/show_bug.cgi?id=27589

        * rendering/MediaControlElements.cpp:
        (WebCore::MediaControlTimeDisplayElement::setVisible): Make sure we don't
        forget to remember the visibility if there is no renderer.

LayoutTests:

2009-07-22  Pierre d'Herbemont  <pdherbemont@apple.com>

        Reviewed by Simon Fraser.

        Audio element at default width shouldn't have time field.
        https://bugs.webkit.org/show_bug.cgi?id=27589

        * platform/mac-snowleopard/Skipped: Enables back audio-controls-rendering.
        * platform/mac/media/audio-controls-rendering-expected.checksum:
        * platform/mac/media/audio-controls-rendering-expected.png:
        * platform/mac/media/audio-controls-rendering-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-23 Kenneth Rohde Christiansen <kenneth@webkit.org>
kenneth@webkit.org [Thu, 23 Jul 2009 18:29:39 +0000 (18:29 +0000)]
2009-07-23  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Adam Treat.

        Added expected results for tests that we pass.

        * platform/qt/editing/inserting/break-blockquote-after-delete-expected.txt: Added.
        * platform/qt/fast/backgrounds/body-generated-image-propagated-to-root-expected.txt: Added.
        * platform/qt/fast/box-shadow/transform-fringing-expected.txt: Added.
        * platform/qt/fast/canvas/drawImage-with-globalAlpha-expected.txt: Added.
        * platform/qt/fast/css/attribute-selector-dynamic-expected.txt: Added.
        * platform/qt/fast/css/nth-child-dynamic-expected.txt: Added.
        * platform/qt/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt: Added.
        * platform/qt/fast/dynamic/anchor-lock-expected.txt: Added.
        * platform/qt/fast/frames/frameset-style-recalc-expected.txt: Added.
        * platform/qt/fast/frames/iframe-text-contents-expected.txt: Added, equal to mac.
        * platform/qt/fast/frames/viewsource-on-image-file-expected.txt: Added.
        * platform/qt/fast/repaint/background-generated-expected.txt: Added, equal to mac.
        * platform/qt/fast/repaint/background-misaligned-expected.txt: Added, equal to mac.
        * platform/qt/fast/repaint/float-in-new-block-with-layout-delta-expected.txt: Added, equal to mac.
        * platform/qt/fast/text/international/hindi-whitespace-expected.txt: Added.
        * platform/qt/fast/transforms/bounding-rect-zoom-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agowx build fix, adding missing header.
kevino@webkit.org [Thu, 23 Jul 2009 18:21:30 +0000 (18:21 +0000)]
wx build fix, adding missing header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-23 Beth Dakin <bdakin@apple.com>
bdakin@apple.com [Thu, 23 Jul 2009 18:10:40 +0000 (18:10 +0000)]
2009-07-23  Beth Dakin  <bdakin@apple.com>

        Reviewed by Darin Adler.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=27598 Clean up the
        AccessibilityObject class

        Mostly this is just moving empty stubs into the header rather than
        muddying the cpp file with them. A few functions were made pure
        virtual.

        * accessibility/AccessibilityObject.cpp:
        (WebCore::AccessibilityObject::isARIAControl):
        (WebCore::AccessibilityObject::clickPoint):
        (WebCore::AccessibilityObject::documentFrameView):
        (WebCore::AccessibilityObject::actionVerb):
        * accessibility/AccessibilityObject.h:
        (WebCore::AccessibilityObject::intValue):
        (WebCore::AccessibilityObject::layoutCount):
        (WebCore::AccessibilityObject::doAccessibilityHitTest):
        (WebCore::AccessibilityObject::focusedUIElement):
        (WebCore::AccessibilityObject::firstChild):
        (WebCore::AccessibilityObject::lastChild):
        (WebCore::AccessibilityObject::previousSibling):
        (WebCore::AccessibilityObject::nextSibling):
        (WebCore::AccessibilityObject::parentObjectIfExists):
        (WebCore::AccessibilityObject::observableObject):
        (WebCore::AccessibilityObject::linkedUIElements):
        (WebCore::AccessibilityObject::titleUIElement):
        (WebCore::AccessibilityObject::ariaRoleAttribute):
        (WebCore::AccessibilityObject::isPresentationalChildOfAriaRole):
        (WebCore::AccessibilityObject::ariaRoleHasPresentationalChildren):
        (WebCore::AccessibilityObject::roleValue):
        (WebCore::AccessibilityObject::ariaAccessiblityName):
        (WebCore::AccessibilityObject::ariaLabeledByAttribute):
        (WebCore::AccessibilityObject::ariaDescribedByAttribute):
        (WebCore::AccessibilityObject::accessibilityDescription):
        (WebCore::AccessibilityObject::ariaSelectedTextDOMRange):
        (WebCore::AccessibilityObject::axObjectCache):
        (WebCore::AccessibilityObject::axObjectID):
        (WebCore::AccessibilityObject::setAXObjectID):
        (WebCore::AccessibilityObject::anchorElement):
        (WebCore::AccessibilityObject::actionElement):
        (WebCore::AccessibilityObject::boundingBoxRect):
        (WebCore::AccessibilityObject::selectedTextRange):
        (WebCore::AccessibilityObject::selectionStart):
        (WebCore::AccessibilityObject::selectionEnd):
        (WebCore::AccessibilityObject::url):
        (WebCore::AccessibilityObject::selection):
        (WebCore::AccessibilityObject::stringValue):
        (WebCore::AccessibilityObject::title):
        (WebCore::AccessibilityObject::helpText):
        (WebCore::AccessibilityObject::textUnderElement):
        (WebCore::AccessibilityObject::text):
        (WebCore::AccessibilityObject::textLength):
        (WebCore::AccessibilityObject::selectedText):
        (WebCore::AccessibilityObject::accessKey):
        (WebCore::AccessibilityObject::widget):
        (WebCore::AccessibilityObject::widgetForAttachmentView):
        (WebCore::AccessibilityObject::setFocused):
        (WebCore::AccessibilityObject::setSelectedText):
        (WebCore::AccessibilityObject::setSelectedTextRange):
        (WebCore::AccessibilityObject::setValue):
        (WebCore::AccessibilityObject::setSelected):
        (WebCore::AccessibilityObject::makeRangeVisible):
        (WebCore::AccessibilityObject::childrenChanged):
        (WebCore::AccessibilityObject::addChildren):
        (WebCore::AccessibilityObject::hasChildren):
        (WebCore::AccessibilityObject::selectedChildren):
        (WebCore::AccessibilityObject::visibleChildren):
        (WebCore::AccessibilityObject::visiblePositionRange):
        (WebCore::AccessibilityObject::visiblePositionRangeForLine):
        (WebCore::AccessibilityObject::boundsForVisiblePositionRange):
        (WebCore::AccessibilityObject::setSelectedVisiblePositionRange):
        (WebCore::AccessibilityObject::visiblePositionForPoint):
        (WebCore::AccessibilityObject::nextVisiblePosition):
        (WebCore::AccessibilityObject::previousVisiblePosition):
        (WebCore::AccessibilityObject::visiblePositionForIndex):
        (WebCore::AccessibilityObject::indexForVisiblePosition):
        (WebCore::AccessibilityObject::index):
        (WebCore::AccessibilityObject::doAXRangeForLine):
        (WebCore::AccessibilityObject::doAXRangeForIndex):
        (WebCore::AccessibilityObject::doAXStringForRange):
        (WebCore::AccessibilityObject::doAXBoundsForRange):
        (WebCore::AccessibilityObject::updateBackingStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix of <rdar://4877658> Dragging from the area between the horizontal/vertical scroll...
bweinstein@apple.com [Thu, 23 Jul 2009 18:05:21 +0000 (18:05 +0000)]
Fix of <rdar://4877658> Dragging from the area between the horizontal/vertical scrollbars when status bar is showing starts a selection and autoscroll.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
hyatt@apple.com [Thu, 23 Jul 2009 17:20:13 +0000 (17:20 +0000)]
WebCore:

2009-07-23  David Hyatt  <hyatt@apple.com>

        Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=27581
        Drop the prefix from the box-shadow property.

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::):
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        (WebCore::ShadowParseContext::commitLength):
        (WebCore::cssPropertyID):
        * css/CSSPropertyNames.in:
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        * page/animation/AnimationBase.cpp:
        (WebCore::ensurePropertyMap):

LayoutTests:

2009-07-23  David Hyatt  <hyatt@apple.com>

        Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=27581
        Drop the prefix from the box-shadow property.

        * platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
        * platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
        * svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
treat@webkit.org [Thu, 23 Jul 2009 16:55:55 +0000 (16:55 +0000)]
WebCore:
2009-07-22  Viet-Trung Luu  <viettrungluu@gmail.com>

        Reviewed by David Hyatt.

        https://bugs.webkit.org/show_bug.cgi?id=27289
        When a mouse click occurs on a scrollbar without a preceding mouse move
        onto it, the release isn't handled correctly (since
        EventHandler::m_lastScrollbarUnderMouse isn't set on mouse down, but
        only on mouse move). (Side comment: That scrollbar-handling code
        in EventHandler is ugly. It should be fixed properly.)

        Tests: scrollbars/scrollbar-miss-mousemove.html
               scrollbars/scrollbar-miss-mousemove-disabled.html

        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMousePressEvent):
        (WebCore::EventHandler::handleMouseMoveEvent):
        (WebCore::EventHandler::updateLastScrollbarUnderMouse):
        * page/EventHandler.h:

LayoutTests:
2009-07-22  Viet-Trung Luu  <viettrungluu@gmail.com>

        Reviewed by David Hyatt.

        https://bugs.webkit.org/show_bug.cgi?id=27289
        Tests that mouse clicks/releases are handled properly on scrollbars
        even when there is no mouse move onto the scrollbar (two cases: enabled
        and disabled controls).

        * scrollbars/scrollbar-miss-mousemove-disabled-expected.txt: Added.
        * scrollbars/scrollbar-miss-mousemove-disabled.html: Added.
        * scrollbars/scrollbar-miss-mousemove-expected.txt: Added.
        * scrollbars/scrollbar-miss-mousemove.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-23 Mike Fenton <mike.fenton@torchmobile.com>
levin@chromium.org [Thu, 23 Jul 2009 16:52:55 +0000 (16:52 +0000)]
2009-07-23  Mike Fenton  <mike.fenton@torchmobile.com>

        Reviewed by David Levin.

        Update WebCore/page/BarInfo.cpp to conform to WebKit
        Style Guidelines as identified by cpplint.py.
        https://bugs.webkit.org/show_bug.cgi?id=27606

        * page/BarInfo.cpp:
        (WebCore::BarInfo::visible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-23 Mike Fenton <mike.fenton@torchmobile.com>
levin@chromium.org [Thu, 23 Jul 2009 16:52:50 +0000 (16:52 +0000)]
2009-07-23  Mike Fenton  <mike.fenton@torchmobile.com>

        Reviewed by David Levin.

        Update WebCore/page/Console.cpp to conform to WebKit
        Style Guidelines as identified by cpplint.py.
        https://bugs.webkit.org/show_bug.cgi?id=27606

        * page/Console.cpp:
        (WebCore::printMessageSourceAndLevelPrefix):
        (WebCore::Console::profile):
        (WebCore::Console::time):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-23 Eli Fidler <eli.fidler@torchmobile.com>
treat@webkit.org [Thu, 23 Jul 2009 16:32:44 +0000 (16:32 +0000)]
2009-07-23  Eli Fidler  <eli.fidler@torchmobile.com>

         Reviewed by Adam Treat.

         Improve git workflow by populating commit messages with ChangeLog entries.
         https://bugs.webkit.org/show_bug.cgi?id=27605

         add --[no-]write option to optionally output new ChangeLog entries to
         stdout instead of modifying ChangeLog files

         fix Torch Mobile copyright

         * Scripts/prepare-ChangeLog:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-23 Jakob Petsovits <jakob.petsovits@torchmobile.com>
treat@webkit.org [Thu, 23 Jul 2009 16:13:50 +0000 (16:13 +0000)]
2009-07-23  Jakob Petsovits  <jakob.petsovits@torchmobile.com>

        Reviewed by Adam Treat.

        Enable cpplint for .c files.
        https://bugs.webkit.org/show_bug.cgi?id=27604

        Also make sure that the check for NULL does not apply to .c files.

        * Scripts/modules/cpplint.py:
        * Scripts/modules/cpplint_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-22 Yong Li <yong.li@torchmobile.com>
treat@webkit.org [Thu, 23 Jul 2009 15:51:25 +0000 (15:51 +0000)]
2009-07-22  Yong Li  <yong.li@torchmobile.com>

        Reviewed by George Staikos.

        Add wince specific memory files into wtf/wince
        https://bugs.webkit.org/show_bug.cgi?id=27550

        * wtf/wince/FastMallocWince.h: Added.
        * wtf/wince/MemoryManager.cpp: Added.
        * wtf/wince/MemoryManager.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-23 Laszlo Gombos <laszlo.1.gombos@nokia.com>
hausmann@webkit.org [Thu, 23 Jul 2009 14:31:10 +0000 (14:31 +0000)]
2009-07-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Add simple proxy support for QtLauncher
        https://bugs.webkit.org/show_bug.cgi?id=27495

        Picks up proxy settings from the http_proxy environment
        variable.

        * QtLauncher/QtLauncher.pro: Add QtNetwork dependency for all
        platforms.
        * QtLauncher/main.cpp:
        (MainWindow::MainWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-23 Norbert Leser <norbert.leser@nokia.com>
hausmann@webkit.org [Thu, 23 Jul 2009 14:28:47 +0000 (14:28 +0000)]
2009-07-23  Norbert Leser  <norbert.leser@nokia.com>

        Reviewed by Simon Hausmann.

        Fix for missing mmap features in Symbian
        https://bugs.webkit.org/show_bug.cgi?id=24540

        Fix, conditionally for PLATFORM(SYMBIAN), as an alternative
        to missing support for the MAP_ANON property flag in mmap.
        It utilizes Symbian specific memory allocation features.

        * runtime/Collector.cpp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
hausmann@webkit.org [Thu, 23 Jul 2009 13:34:34 +0000 (13:34 +0000)]
WebCore:

2009-07-23  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Holger Freyther.

        Fix crashes with the QObject bindings after garbage collection.

        There is one QtInstance per wrapped QObject, and that QtInstance keeps
        references to cached JSObjects for slots. When those objects get
        deleted due to GC, then they becoming dangling pointers.

        When a cached member dies, it is now removed from the QtInstance's
        cache.

        As we cannot track the lifetime of the children, we have to remove
        them from QtInstance alltogether. They are not cached and were
        only used for mark(), but we _want_ them to be subject to gc.

        * bridge/qt/qt_instance.cpp:
        (JSC::Bindings::QtInstance::~QtInstance): Minor coding style cleanup,
        use qDeleteAll().
        (JSC::Bindings::QtInstance::removeCachedMethod): New function, to
        clean m_methods and m_defaultMethod.
        (JSC::Bindings::QtInstance::mark): Avoid marking already marked objects.
        (JSC::Bindings::QtField::valueFromInstance): Don't save children for
        marking.
        * bridge/qt/qt_instance.h: Declare removeCachedMethod.
        * bridge/qt/qt_runtime.cpp:
        (JSC::Bindings::QtRuntimeMethod::~QtRuntimeMethod): Call removeCachedMethod
        with this on the instance.

WebKit/qt:

2009-07-23  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Holger Freyther.

        Added a testcase to verify that cached methods in the QOBject bindings
        remain alife even after garbage collection.

        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::protectBindingsRuntimeObjectsFromCollector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-23 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
hausmann@webkit.org [Thu, 23 Jul 2009 10:24:12 +0000 (10:24 +0000)]
2009-07-23  Zoltan Herczeg  <zherczeg@inf.u-szeged.hu>

        Reviewed by Simon Hausmann.

        Fixing two issues related to QtLauncher
          - MainWindow objects are not always freed after close
          - JavaScript window.close() sometimes crashes
        https://bugs.webkit.org/show_bug.cgi?id=27601

        * QtLauncher/main.cpp:
        (MainWindow::MainWindow):
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-23 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Thu, 23 Jul 2009 10:20:51 +0000 (10:20 +0000)]
2009-07-23  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Tor Arne Vestbø.

        Rebaseline the Qt results for computed-style.html and
        computed-style-without-rendered.html after r46240, similar to r46252.

        * platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
        * platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-23 David Levin <levin@chromium.org>
levin@chromium.org [Thu, 23 Jul 2009 09:57:15 +0000 (09:57 +0000)]
2009-07-23  David Levin  <levin@chromium.org>

         Rubber-stamped by Oliver Hunt.

        Improve keyboard navigation of Select elements.
        Home/End and PageUp/PageDn buttons do not do anything in drop down lists,
        on non-Mac platforms.
        https://bugs.webkit.org/show_bug.cgi?id=22784

        One more round of speculative fixes:
         - Really fix the general and win expected results.  (They were missing a return.)
         - Disable the test for gtk (and remove the attempted workaround for that platform).

        * fast/forms/select-popup-pagekeys-expected.txt:
        * fast/forms/select-popup-pagekeys.html:
        * platform/gtk/Skipped:
        * platform/win/fast/forms/select-popup-pagekeys-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-23 David Levin <levin@chromium.org>
levin@chromium.org [Thu, 23 Jul 2009 09:09:55 +0000 (09:09 +0000)]
2009-07-23  David Levin  <levin@chromium.org>

        Rubber-stamped by Oliver Hunt.

        3 (speculative) fixes for the new layout test: select-popup-pagekeys
         - Help Windows to pass by adding platform results.
         - Fix the general expected results.
         - Fix select-popup-pagekeys on gtk which doesn't seem to implement eventSender.

        * fast/forms/select-popup-pagekeys-expected.txt:
        * fast/forms/select-popup-pagekeys.html:
        * platform/win/fast/forms/select-popup-pagekeys-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-23 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 23 Jul 2009 08:01:08 +0000 (08:01 +0000)]
2009-07-23  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Mark Rowe.

        https://bugs.webkit.org/show_bug.cgi?id=27599
        'const unsigned' in return value

        Remove const modifier from unsigned return value, as it does not
        make sense.

        * dom/ErrorEvent.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-22 Jens Alfke <snej@chromium.org>
levin@chromium.org [Thu, 23 Jul 2009 07:52:31 +0000 (07:52 +0000)]
2009-07-22  Jens Alfke  <snej@chromium.org>

        Reviewed by David Levin.

        Bug 22784: Improve keyboard navigation of Select elements.
        Home/End and PageUp/PageDn buttons do not do anything in drop down lists,
        on non-Mac platforms.
        https://bugs.webkit.org/show_bug.cgi?id=22784
        http://code.google.com/p/chromium/issues/detail?id=4576

WebCore:

        New test: LayoutTests/fast/forms/select-popup-pagekeys.html

        * dom/SelectElement.cpp:
        (WebCore::nextValidIndex):
        New utility fn for traversing items of a select's list.
        (WebCore::SelectElement::menuListDefaultEventHandler):
        Added code to handle Home/End and PageUp/PageDn when ARROW_KEYS_POP_MENU is false.

LayoutTests:

        * LayoutTests/fast/forms/select-popup-pagekeys.html: Added.
        * LayoutTests/fast/forms/select-popup-pagekeys-expected.txt: Added
        * LayoutTests/platform/mac/fast/forms/select-popup-pagekeys-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-23 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 23 Jul 2009 07:36:00 +0000 (07:36 +0000)]
2009-07-23  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Mark Rowe.

        Fix a couple of compiler warnings.

        * platform/graphics/cairo/ImageBufferCairo.cpp:
        (copySurface):
        * platform/graphics/gtk/SimpleFontDataGtk.cpp:
        (WebCore::SimpleFontData::containsCharacters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
hausmann@webkit.org [Thu, 23 Jul 2009 07:19:17 +0000 (07:19 +0000)]
WebCore:

2009-07-22  Simon Hausmann  <simon.hausmann@nokia.com>

        Rubber-stamped by David Levin.

        Enable HTML5 Datagrid defines for the Qt build.

        * WebCore.pro:

LayoutTests:

2009-07-22  Simon Hausmann  <simon.hausmann@nokia.com>

        Rubber-stamped by David Levin.

        Unskip HTML 5 Datagrid tests for the Qt DRT, as they pass.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-22 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 23 Jul 2009 07:00:40 +0000 (07:00 +0000)]
2009-07-22  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Mark Rowe.

        Fix compiler warning.

        * tests/testwebsettings.c:
        (test_webkit_web_settings_user_agent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-22 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 23 Jul 2009 06:32:58 +0000 (06:32 +0000)]
2009-07-22  Adam Barth  <abarth@webkit.org>

        Reviewed by David Levin.

        [V8] Make Node wrappers go fast
        https://bugs.webkit.org/show_bug.cgi?id=27597

        Profiles indicate we're spending a lot of time asking whether we're on
        the main thread when looking up DOM wrappers for Nodes, but there isn't
        much point in doing that work because Nodes only exist on the main
        thread.  I've also added an assert to keep us honest in this regard.

        * bindings/v8/V8DOMMap.cpp:
        (WebCore::):
        (WebCore::getDOMNodeMap):
        (WebCore::DOMData::getCurrent):
        (WebCore::DOMData::getCurrentMainThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Checkpoint new Windows nightly launcher.
sfalken@apple.com [Thu, 23 Jul 2009 05:39:55 +0000 (05:39 +0000)]
    Checkpoint new Windows nightly launcher.

        Reviewed by Mark Rowe.

        * WebKitLauncherWin: Added.
        * WebKitLauncherWin/Resource.h: Added.
        * WebKitLauncherWin/WebKitLauncherWin.cpp: Added.
        (getStringValue): Retrieve a string registry value.
        (applePathFromRegistry): Get an Apple-related path out of the registry.
        (copyEnvironmentVariable): Copy an environment variable.
        (safariInstallDir): Helper function to get the install directory for Safari.
        (safariBrowserExe): Helper function to get the full path of the Safari executable.
        (_tWinMain): Locate Safari and launch it after setting up an environment variable.
        * WebKitLauncherWin/WebKitLauncherWin.h: Added.
        * WebKitLauncherWin/WebKitLauncherWin.rc: Added.
        * WebKitLauncherWin/WebKitLauncherWin.vcproj: Added.
        * WebKitLauncherWin/webkit.ico: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-22 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 23 Jul 2009 02:52:22 +0000 (02:52 +0000)]
2009-07-22  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Remove unneeded virtual destructor from ScriptSourceProvider
        https://bugs.webkit.org/show_bug.cgi?id=27563

        * bindings/js/ScriptSourceProvider.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-22 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 23 Jul 2009 02:29:01 +0000 (02:29 +0000)]
2009-07-22  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Adam Barth.

        REGRESSION (r46240): /fast/css/getComputedStyle/computed-style & computed-style-without-renderer needs rebaseline for Windows
        https://bugs.webkit.org/show_bug.cgi?id=27591

        Rebaselines the tests.

        * platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
        * platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
rniwa@webkit.org [Thu, 23 Jul 2009 02:01:02 +0000 (02:01 +0000)]
WebCore:

2009-07-22  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        execCommand('underline' / 'strikeThrough') doesn't work properly with multiple styles in text-decoration
        https://bugs.webkit.org/show_bug.cgi?id=27476

        executeStrikethrough and executeUnderline were toggling between "line-through" / "underline" and "none".
        This patch adds executeToggleStyleInList that toggles a style in CSSValueList instead of toggling the entire value.
        It modifies CSSComputedStyleDeclaration to return CSSValueList instead of CSSPrimitiveValue for text decorations,
        and adds removeAll member function to CSSValueList.

        Tests: editing/execCommand/toggle-text-decorations.html
               fast/css/getComputedStyle/getComputedStyle-text-decoration.html

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::renderTextDecorationFlagsToCSSValue): Creates a CSSValueList
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Returns a CSSValueList instead of CSSValue
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue): Text decorations are space separated instead of comma separated
        * css/CSSValueList.cpp:
        (WebCore::CSSValueList::removeAll): Removes all values that match the specified value
        * css/CSSValueList.h:
        * editing/EditorCommand.cpp:
        (WebCore::applyCommandToFrame): Apply style to a frame using specified command
        (WebCore::executeApplyStyle): Uses applyCommandToFrame
        (WebCore::executeToggleStyleInList): Uses applyCommandToFrame
        (WebCore::executeToggleStyle): Toggles a style in CSSValueList
        (WebCore::executeStrikethrough): Uses executeToggleStyleInList
        (WebCore::executeUnderline): Uses executeToggleStyleInList

LayoutTests:

2009-07-22  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        execCommand('underline' / 'strikeThrough') doesn't work properly with multiple styles in text-decoration
        https://bugs.webkit.org/show_bug.cgi?id=27476

        toggle-text-decorations checks whether we can toggle text decorations with multiple styles properly.
        e.g. execCommand("underline") should modify "text-decoration: underline overline" to "text-decoration: overline"

        getComputedStyle-text-decorations checks whether the CSS value of text decoration and its computed style are
        both space-separated CSSValueList instead of CSSPrimitiveValue or comma-separated CSSValueList.

        * editing/execCommand/resources/toggle-text-decorations.js: Added.
        (testSingleToggle):
        * editing/execCommand/toggle-text-decorations-expected.txt: Added.
        * editing/execCommand/toggle-text-decorations.html: Added.
        * fast/css/getComputedStyle/getComputedStyle-text-decoration-expected.txt: Added.
        * fast/css/getComputedStyle/getComputedStyle-text-decoration.html: Added.
        * fast/css/getComputedStyle/resources: Added.
        * fast/css/getComputedStyle/resources/TEMPLATE.html: Added.
        * fast/css/getComputedStyle/resources/getComputedStyle-text-decoration.js: Added.
        (expect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-22 Daniel Bates <dbates@intudata.com>
abarth@webkit.org [Wed, 22 Jul 2009 23:27:19 +0000 (23:27 +0000)]
2009-07-22  Daniel Bates  <dbates@intudata.com>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=27174
        And
        https://bugs.webkit.org/show_bug.cgi?id=26938

        Tests prevention of attacks transformed by PHP Magic Quotes/PHP addslashes().

        * http/tests/security/xssAuditor/resources/echo-intertag-addslashes.pl: Added.
        * http/tests/security/xssAuditor/script-tag-addslashes-backslash-expected.txt: Added.
        * http/tests/security/xssAuditor/script-tag-addslashes-backslash.html: Added.
        * http/tests/security/xssAuditor/script-tag-addslashes-double-quote-expected.txt: Added.
        * http/tests/security/xssAuditor/script-tag-addslashes-double-quote.html: Added.
        * http/tests/security/xssAuditor/script-tag-addslashes-null-char-expected.txt: Added.
        * http/tests/security/xssAuditor/script-tag-addslashes-null-char.html: Added.
        * http/tests/security/xssAuditor/script-tag-addslashes-single-quote-expected.txt: Added.
        * http/tests/security/xssAuditor/script-tag-addslashes-single-quote.html: Added.

2009-07-22  Daniel Bates  <dbates@intudata.com>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=27174
        And
        https://bugs.webkit.org/show_bug.cgi?id=26938

        Code cleanup. Implements support for detecting attacks transformed by
        PHP Magic Quotes/PHP addslashes().

        Tests: http/tests/security/xssAuditor/script-tag-addslashes-backslash.html
               http/tests/security/xssAuditor/script-tag-addslashes-double-quote.html
               http/tests/security/xssAuditor/script-tag-addslashes-null-char.html
               http/tests/security/xssAuditor/script-tag-addslashes-single-quote.html

        * page/XSSAuditor.cpp:
        (WebCore::isInvalidCharacter):
        (WebCore::XSSAuditor::canEvaluate):
        (WebCore::XSSAuditor::canEvaluateJavaScriptURL):
        (WebCore::XSSAuditor::canLoadObject):
        (WebCore::XSSAuditor::normalize): Decodes HTML entities, removes backslashes,
        and removes control characters that could otherwise cause a discrepancy between
        the source code of a script and the outgoing HTTP parameters.
        (WebCore::XSSAuditor::decodeURL):
        (WebCore::XSSAuditor::decodeHTMLEntities):
        (WebCore::XSSAuditor::findInRequest):
        * page/XSSAuditor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-22 David Levin <levin@chromium.org>
levin@chromium.org [Wed, 22 Jul 2009 22:48:40 +0000 (22:48 +0000)]
2009-07-22  David Levin  <levin@chromium.org>

        Reviewed by Adam Treat.

        run-webkit-lint should be named check-webkit-style
        https://bugs.webkit.org/show_bug.cgi?id=27568

        This name better reflects the fact that it is about checking the style of files.

        * Scripts/check-webkit-style: Renamed from WebKitTools/Scripts/run-webkit-lint.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-22 Jakob Petsovits <jakob.petsovits@torchmobile.com>
treat@webkit.org [Wed, 22 Jul 2009 22:31:00 +0000 (22:31 +0000)]
2009-07-22  Jakob Petsovits  <jakob.petsovits@torchmobile.com>

        Reviewed by Adam Treat.

        Fix false positives in namespace indentation checks.
        https://bugs.webkit.org/show_bug.cgi?id=27567

        The regular expression detecting goto labels (in order
        to skip those) was too permissive, which caused other
        code like "Foo::Bar()" to be treated as a label too,
        thereby not stopping the processing loop as expected.

        Now comes with a stricter regexp, and more demanding
        test cases to check for these issues.

        * Scripts/modules/cpplint.py:
        * Scripts/modules/cpplint_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-22 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Wed, 22 Jul 2009 22:17:10 +0000 (22:17 +0000)]
2009-07-22  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Sam Weinig.

        With ENABLE(ASSEMBLER_WX_EXCLUSIVE), only change permissions once per repatch event.
        ( https://bugs.webkit.org/show_bug.cgi?id=27564 )

        Currently we change permissions forwards and backwards for each instruction modified,
        instead we should only change permissions once per complete repatching event.

        2.5% progression running with ENABLE(ASSEMBLER_WX_EXCLUSIVE) enabled,
        which recoups 1/3 of the penalty of running with this mode enabled.

        * assembler/ARMAssembler.cpp:
        (JSC::ARMAssembler::linkBranch):
            - Replace usage of MakeWritable with cacheFlush.

        * assembler/ARMAssembler.h:
        (JSC::ARMAssembler::patchPointerInternal):
        (JSC::ARMAssembler::repatchLoadPtrToLEA):
            - Replace usage of MakeWritable with cacheFlush.

        * assembler/ARMv7Assembler.h:
        (JSC::ARMv7Assembler::relinkJump):
        (JSC::ARMv7Assembler::relinkCall):
        (JSC::ARMv7Assembler::repatchInt32):
        (JSC::ARMv7Assembler::repatchPointer):
        (JSC::ARMv7Assembler::repatchLoadPtrToLEA):
        (JSC::ARMv7Assembler::setInt32):
            - Replace usage of MakeWritable with cacheFlush.

        * assembler/LinkBuffer.h:
        (JSC::LinkBuffer::performFinalization):
            - Make explicit call to cacheFlush.

        * assembler/MacroAssemblerCodeRef.h:
        (JSC::MacroAssemblerCodeRef::MacroAssemblerCodeRef):
            - Make size always available.

        * assembler/RepatchBuffer.h:
        (JSC::RepatchBuffer::RepatchBuffer):
        (JSC::RepatchBuffer::~RepatchBuffer):
            - Add calls to MakeWritable & makeExecutable.

        * assembler/X86Assembler.h:
        (JSC::X86Assembler::relinkJump):
        (JSC::X86Assembler::relinkCall):
        (JSC::X86Assembler::repatchInt32):
        (JSC::X86Assembler::repatchPointer):
        (JSC::X86Assembler::repatchLoadPtrToLEA):
            - Remove usage of MakeWritable.

        * bytecode/CodeBlock.h:
        (JSC::CodeBlock::getJITCode):
            - Provide access to CodeBlock's JITCode.

        * jit/ExecutableAllocator.h:
        (JSC::ExecutableAllocator::makeExecutable):
        (JSC::ExecutableAllocator::cacheFlush):
            - Remove MakeWritable, make cacheFlush public.

        * jit/JIT.cpp:
        (JSC::ctiPatchNearCallByReturnAddress):
        (JSC::ctiPatchCallByReturnAddress):
        (JSC::JIT::privateCompile):
        (JSC::JIT::unlinkCall):
        (JSC::JIT::linkCall):
            - Add CodeBlock argument to RepatchBuffer.

        * jit/JIT.h:
            - Pass CodeBlock argument for use by RepatchBuffer.

        * jit/JITCode.h:
        (JSC::JITCode::start):
        (JSC::JITCode::size):
            - Provide access to code start & size.

        * jit/JITPropertyAccess.cpp:
        (JSC::JIT::privateCompilePutByIdTransition):
        (JSC::JIT::patchGetByIdSelf):
        (JSC::JIT::patchMethodCallProto):
        (JSC::JIT::patchPutByIdReplace):
        (JSC::JIT::privateCompilePatchGetArrayLength):
        (JSC::JIT::privateCompileGetByIdProto):
        (JSC::JIT::privateCompileGetByIdSelfList):
        (JSC::JIT::privateCompileGetByIdProtoList):
        (JSC::JIT::privateCompileGetByIdChainList):
        (JSC::JIT::privateCompileGetByIdChain):
            - Add CodeBlock argument to RepatchBuffer.

        * jit/JITStubs.cpp:
        (JSC::JITThunks::tryCachePutByID):
        (JSC::JITThunks::tryCacheGetByID):
        (JSC::JITStubs::DEFINE_STUB_FUNCTION):
            - Pass CodeBlock argument for use by RepatchBuffer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNull deref in JSObject::mark due to null xhr wrapper
oliver@apple.com [Wed, 22 Jul 2009 22:12:57 +0000 (22:12 +0000)]
Null deref in JSObject::mark due to null xhr wrapper
https://bugs.webkit.org/show_bug.cgi?id=27565

Reviewed by Adele Peterson.

Make event target binding for appcache and xhr behave in the same way as
it does for all other events.

No test as I couldn't make a testcase which was remotely reliable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-22 Takeshi Yoshino <tyoshino@google.com>
levin@chromium.org [Wed, 22 Jul 2009 22:10:01 +0000 (22:10 +0000)]
2009-07-22  Takeshi Yoshino  <tyoshino@google.com>

        Reviewed by Darin Adler.

        VC++ 2005 Express failed to build WebKit due to raw UTF-8 string in WebKit/win/WebCoreLocalizedStrings.cpp
        https://bugs.webkit.org/show_bug.cgi?id=26375

WebKit/win:

        Replace a multiplication sign (U+00D7) encoded in UTF-8 (0xC3 0x97) in WebCoreLocalizedStrings.cpp
        with hex escape sequences.

        VC2005 failed to build due to this raw UTF-8 data in source code. Here's the warning message (
        treated as an error and stopped build).

        WebCoreLocalizedStrings.cpp : warning C4819: The file contains a character that cannot be
        represented in the current code page (932). Save the file in Unicode format to prevent data loss

        A change on WebKitTools/Scripts/extract-localizable-strings is attached to this change not to break
        localized string generation process.

        * WebCoreLocalizedStrings.cpp:
        (WebCore::imageTitle):

WebKitTools:

        Make it able to use hexadecimal escape sequences in .*UI_STRING(_KEY)? macros. Now,
        the extract-localizable-strings script unescapes hexadecimal escape sequences in string literals
        in the macros before writing out them into the file to update.

        By this fix, we can eliminate raw UTF-8 strings in source code while using raw UTF-16 big endian
        strings in the Localizable.strings file.

        Bonus: There's no longer extract-webkit-localizable-strings script. Fix usage message to guide
        users to update-webkit-localizable-strings.

        * Scripts/extract-localizable-strings:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-22 Shinichiro Hamaji <hamaji@google.com>
levin@chromium.org [Wed, 22 Jul 2009 22:09:56 +0000 (22:09 +0000)]
2009-07-22  Shinichiro Hamaji  <hamaji@google.com>

        Reviewed by David Levin.

        Tiny typo fixes for cpplint.py
        https://bugs.webkit.org/show_bug.cgi?id=27530

        * Scripts/modules/cpplint.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-22 Shinichiro Hamaji <hamaji@chromium.org>
levin@chromium.org [Wed, 22 Jul 2009 22:09:50 +0000 (22:09 +0000)]
2009-07-22  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by David Levin.

        run-webkit-lint checks code which are not changed
        https://bugs.webkit.org/show_bug.cgi?id=27529

        Add check if the line is newly added.

        * Scripts/run-webkit-lint:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-22 Shinichiro Hamaji <hamaji@chromium.org>
levin@chromium.org [Wed, 22 Jul 2009 22:09:45 +0000 (22:09 +0000)]
2009-07-22  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by David Levin.

        run-webkit-lint should have --git-commit option
        https://bugs.webkit.org/show_bug.cgi?id=27528

        * Scripts/modules/cpplint.py:
        * Scripts/run-webkit-lint:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-22 Mads Ager <ager@chromium.org>
levin@chromium.org [Wed, 22 Jul 2009 22:09:40 +0000 (22:09 +0000)]
2009-07-22  Mads Ager  <ager@chromium.org>

        Reviewed by David Levin.

        Inform V8 of the amount of WebCore string memory it is keeping alive.
        https://bugs.webkit.org/show_bug.cgi?id=27537

        V8 uses external strings that are backed by WebCore strings. Since
        the external strings themselves are small, V8 has no way of
        knowing how much memory it is actually holding on to. With this
        change, we inform V8 of the amount of WebCore string data it is
        holding on to with external strings.

        * bindings/v8/V8Binding.cpp:
        (WebCore::WebCoreStringResource::WebCoreStringResource):
        (WebCore::WebCoreStringResource::~WebCoreStringResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
hyatt@apple.com [Wed, 22 Jul 2009 21:59:47 +0000 (21:59 +0000)]
WebCore:

2009-07-22  David Hyatt  <hyatt@apple.com>

        Reviewed by Beth Dakin.

        https://bugs.webkit.org/show_bug.cgi?id=27562
        Add the finalized versions of background-clip and background-origin.  Remove background-clip from
        the background shorthand and have it be auto-set based off background-origin's value.

        Three new tests added in fast/backgrounds/size

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::):
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/CSSMutableStyleDeclaration.cpp:
        (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseFillShorthand):
        (WebCore::CSSParser::parseFillProperty):
        * css/CSSPropertyLonghand.cpp:
        (WebCore::initShorthandMap):
        * css/CSSPropertyNames.in:
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        * css/CSSValueKeywords.in:

LayoutTests:

2009-07-22  David Hyatt  <hyatt@apple.com>

        Reviewed by Beth Dakin.

        https://bugs.webkit.org/show_bug.cgi?id=27562
        Add some new layout tests that drop the prefix from the background properties and use origin
        in a shorthand.  Update shorthand results and computed style results to account for new properties.

        * fast/backgrounds/size/backgroundSize20.html: Added.
        * fast/backgrounds/size/backgroundSize21.html: Added.
        * fast/backgrounds/size/backgroundSize22.html: Added.
        * fast/css/background-position-serialize-expected.txt:
        * fast/css/remove-shorthand-expected.txt:
        * platform/mac/fast/backgrounds/size/backgroundSize20-expected.checksum: Added.
        * platform/mac/fast/backgrounds/size/backgroundSize20-expected.png: Added.
        * platform/mac/fast/backgrounds/size/backgroundSize20-expected.txt: Added.
        * platform/mac/fast/backgrounds/size/backgroundSize21-expected.checksum: Added.
        * platform/mac/fast/backgrounds/size/backgroundSize21-expected.png: Added.
        * platform/mac/fast/backgrounds/size/backgroundSize21-expected.txt: Added.
        * platform/mac/fast/backgrounds/size/backgroundSize22-expected.checksum: Added.
        * platform/mac/fast/backgrounds/size/backgroundSize22-expected.png: Added.
        * platform/mac/fast/backgrounds/size/backgroundSize22-expected.txt: Added.
        * platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
        * platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
        * platform/mac/fast/inspector/style-expected.txt:
        * svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
jorlow@chromium.org [Wed, 22 Jul 2009 21:47:11 +0000 (21:47 +0000)]
WebCore:

2009-07-22  Jens Alfke  <snej@chromium.org>

        Reviewed by Darin Fisher.

        Hook up V8 bindings for DataGrid elements.
        https://bugs.webkit.org/show_bug.cgi?id=27383
        http://code.google.com/p/chromium/issues/detail?id=16730

        Tests: Enhanced LayoutTests/fast/dom/HTMLDataGridElement/*
        to handle exceptions, check appropriate JS prototypes, and
        test column-list's item() method as well as array-indexing.

        * WebCore.gypi: Added new source files.
        * bindings/scripts/CodeGeneratorV8.pm: Made GenerateBatchedAttributeData put #if's around conditional attributes.
        * bindings/v8/DOMObjectsInclude.h: #include DataGrid headers.
        * bindings/v8/V8DOMWrapper.cpp: Add bindings from HTML tags to datagrid templates.
        (WebCore::V8DOMWrapper::getTemplate): Customize datagrid template.
        * bindings/v8/V8DataGridDataSource.cpp: Added. (Based on JSDataGridDataSource)
        (WebCore::V8DataGridDataSource::V8DataGridDataSource):
        (WebCore::V8DataGridDataSource::~V8DataGridDataSource):
        * bindings/v8/V8DataGridDataSource.h: Added. (Based on JSDataGridDataSource)
        (WebCore::V8DataGridDataSource::create):
        (WebCore::V8DataGridDataSource::isJSDataGridDataSource):
        (WebCore::V8DataGridDataSource::jsDataSource):
        (WebCore::asV8DataGridDataSource):
        * bindings/v8/V8GCController.h: Added new handle type "DATASOURCE".
        * bindings/v8/V8Index.h: Conditionalize datagrid stuff.
        * bindings/v8/custom/V8CustomBinding.h: Declare more accessors. Conditionalize.
        * bindings/v8/custom/V8DataGridColumnListCustom.cpp: Added.
        * bindings/v8/custom/V8HTMLDataGridElementCustom.cpp: Fill in dataSource accessors.
        (WebCore::ACCESSOR_GETTER):
        (WebCore::ACCESSOR_SETTER):

LayoutTests:

2009-07-22  Jens Alfke  <snej@chromium.org>

        Reviewed by Darin Fisher.

        Hook up V8 bindings for DataGrid elements.
        https://bugs.webkit.org/show_bug.cgi?id=27383
        http://code.google.com/p/chromium/issues/detail?id=16730

        Tests: Enhanced LayoutTests/fast/dom/HTMLDataGridElement/*
        to handle exceptions, check appropriate JS prototypes, and
        test column-list's item() method as well as array-indexing.

        * fast/dom/HTMLDataGridElement/DataGridColumns-basic-expected.txt:
        * fast/dom/HTMLDataGridElement/DataGridColumns-basic.html:
        * fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html:
        * fast/dom/HTMLDataGridElement/DataGridColumns-dom-expected.txt:
        * fast/dom/HTMLDataGridElement/DataGridColumns-dom.html:
        * fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-22 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 22 Jul 2009 20:46:36 +0000 (20:46 +0000)]
2009-07-22  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        pushDownTextDecorationStyleAroundNode needs clean up
        https://bugs.webkit.org/show_bug.cgi?id=27556

        Cleaned up. pushDownTextDecorationStyleAroundNode traverses tree vertically from highestAncestor to targetNode
        While traversing, it will apply the specified style to all nodes but targetNode.
        i.e. the style is applies to all ancestor nodes and their siblings of targetNode.

        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode): Cleaned up and added comments
        * editing/ApplyStyleCommand.h: Updated prototype

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-22 Peter Kasting <pkasting@google.com>
pkasting@chromium.org [Wed, 22 Jul 2009 20:35:04 +0000 (20:35 +0000)]
2009-07-22  Peter Kasting  <pkasting@google.com>

        Reviewed by David Kilzer.

        https://bugs.webkit.org/show_bug.cgi?id=27323
        Handle any type of line endings in WebCore/css/*CSSPropertyNames.in.

        * DerivedSources.make:
        * css/makeprop.pl:
        * css/makevalues.pl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-22 Peter Kasting <pkasting@google.com>
pkasting@chromium.org [Wed, 22 Jul 2009 20:32:35 +0000 (20:32 +0000)]
2009-07-22  Peter Kasting  <pkasting@google.com>

        Reviewed by David Kilzer.

        https://bugs.webkit.org/show_bug.cgi?id=27323
        Factor svn-create-patch's "determineSvnRoot()" into a function in
        VCSUtils.pm so commit-log-editor can use it too.

        * Scripts/VCSUtils.pm: Add determineSVNRoot().
        * Scripts/commit-log-editor: Use determineSVNRoot() instead of old
          code (which didn't work as well).
        * Scripts/svn-create-patch: Remove determineSvnRoot() (moved).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRevert bugfix for 27557 as this is invalid according to Darin Adler
treat@webkit.org [Wed, 22 Jul 2009 20:18:50 +0000 (20:18 +0000)]
Revert bugfix for 27557 as this is invalid according to Darin Adler
who states that include order sorting should be case-sensitive.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-22 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 22 Jul 2009 20:06:42 +0000 (20:06 +0000)]
2009-07-22  Eric Seidel  <eric@webkit.org>

        Reviewed by Darin Adler.

        expand prototype-inheritance test to cover constructors
        https://bugs.webkit.org/show_bug.cgi?id=27547

        * fast/dom/prototype-inheritance-expected.txt:
        * fast/dom/resources/prototype-inheritance.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-22 Jakob Petsovits <jakob.petsovits@torchmobile.com>
treat@webkit.org [Wed, 22 Jul 2009 20:05:42 +0000 (20:05 +0000)]
2009-07-22  Jakob Petsovits  <jakob.petsovits@torchmobile.com>

        Reviewed by Adam Treat.

        Case-insensitive comparison of include file order for cpplint.
        https://bugs.webkit.org/show_bug.cgi?id=27557

        * Scripts/modules/cpplint.py:
        * Scripts/modules/cpplint_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-22 Jakob Petsovits <jakob.petsovits@torchmobile.com>
treat@webkit.org [Wed, 22 Jul 2009 19:51:30 +0000 (19:51 +0000)]
2009-07-22  Jakob Petsovits  <jakob.petsovits@torchmobile.com>

        Reviewed by Adam Treat.

        Fix cpplint generating false positives for
        "primary" includes in headers.
        https://bugs.webkit.org/show_bug.cgi?id=27553

        Doing so by only flagging includes in header files
        as primary when the include filename exactly matches
        the header filename.

        * Scripts/modules/cpplint.py:
        * Scripts/modules/cpplint_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-22 Jakob Petsovits <jakob.petsovits@torchmobile.com>
treat@webkit.org [Wed, 22 Jul 2009 19:24:13 +0000 (19:24 +0000)]
2009-07-22  Jakob Petsovits  <jakob.petsovits@torchmobile.com>

        Reviewed by Adam Treat.

        cpplint generates false positives for primary includes
        https://bugs.webkit.org/show_bug.cgi?id=27544

        Fix false positives for instances when cpplint would
        normally classify multiple includes as primary: After
        the first primary include, classify subsequent ones as
        "other" includes even if they look like primary ones.

        * Scripts/modules/cpplint.py:
        * Scripts/modules/cpplint_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-22 Paul Godavari <paul@chromium.org>
levin@chromium.org [Wed, 22 Jul 2009 18:55:05 +0000 (18:55 +0000)]
2009-07-22  Paul Godavari  <paul@chromium.org>

        Reviewed by Darin Fisher.

        Chromium has a build break after removal of JSRGBColor bindings
        https://bugs.webkit.org/show_bug.cgi?id=27548

        Fix a build break in Chromium V8 after the JSRGBColor bindings change:
        https://bugs.webkit.org/show_bug.cgi?id=27242

        * bindings/scripts/CodeGeneratorV8.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-22 Gabor Rapcsanyi <rapcsanyi.gabor@stud.u-szeged.hu>
hausmann@webkit.org [Wed, 22 Jul 2009 18:46:03 +0000 (18:46 +0000)]
2009-07-22  Gabor Rapcsanyi  <rapcsanyi.gabor@stud.u-szeged.hu>

        Reviewed by Simon Hausmann.

        Pass XAUTHORITY environment variable to $dumpTool as well.

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-20 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 22 Jul 2009 17:02:35 +0000 (17:02 +0000)]
2009-07-20  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        REGRESSION (r39185): Safari adds ".jpeg" extension to images that already have ".JPG" extension
        https://bugs.webkit.org/show_bug.cgi?id=27472

        * WebView/WebHTMLView.mm:
        (matchesExtensionOrEquivalent): Changed category method into a C function.
        Made it require the leading dot when checking for the extension and do it
        in a non-case-sensitive way.
        (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Changed to call
        the function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-22 Adam Langley <agl@google.com>
agl@chromium.org [Wed, 22 Jul 2009 16:56:33 +0000 (16:56 +0000)]
2009-07-22  Adam Langley  <agl@google.com>

        Reviewed by Darin Fisher.

        Chromium Linux: add static functions to FontPlatformData which allow
        for setting the global font rendering preferences.

        https://bugs.webkit.org/show_bug.cgi?id=27513
        http://code.google.com/p/chromium/issues/detail?id=12179

        This should not affect any layout tests.

        * platform/graphics/chromium/FontPlatformDataLinux.cpp:
        (WebCore::FontPlatformData::setHinting):
        (WebCore::FontPlatformData::setAntiAlias):
        (WebCore::FontPlatformData::setSubpixelGlyphs):
        (WebCore::FontPlatformData::setupPaint):
        * platform/graphics/chromium/FontPlatformDataLinux.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Jakob Petsovits <jakob.petsovits@torchmobile.com>
treat@webkit.org [Wed, 22 Jul 2009 15:20:15 +0000 (15:20 +0000)]
2009-07-21  Jakob Petsovits  <jakob.petsovits@torchmobile.com>

         Reviewed by Adam Treat.

         Add check for correct wtf includes to cpplint.
         https://bugs.webkit.org/show_bug.cgi?id=27524

         * Scripts/modules/cpplint.py:
         * Scripts/modules/cpplint_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Jakob Petsovits <jakob.petsovits@torchmobile.com>
treat@webkit.org [Wed, 22 Jul 2009 15:15:28 +0000 (15:15 +0000)]
2009-07-21  Jakob Petsovits  <jakob.petsovits@torchmobile.com>

        Reviewed by David Levin.

        Add checks for multi-line boolean operator placement.
        https://bugs.webkit.org/show_bug.cgi?id=27496

        * Scripts/modules/cpplint.py:
        * Scripts/modules/cpplint_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-22 Holger Hans Peter Freyther <zecke@selfish.org>
zecke@webkit.org [Wed, 22 Jul 2009 14:13:15 +0000 (14:13 +0000)]
2009-07-22  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Adam Treat.

        Mention the new webkit-help and webkit-jobs mailinglist. Change
        the description of webkit-dev to be more strict.

        * contact.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-22 Mikhail Naganov <mnaganov@chromium.org>
pfeldman@chromium.org [Wed, 22 Jul 2009 13:34:45 +0000 (13:34 +0000)]
2009-07-22  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Timothy Hatcher.

        Move Inspector panels creation into a function to make possible introducing
        custom panels.

        * inspector/front-end/inspector.js:
        (WebInspector._createPanels):
        (WebInspector.loaded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-22 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 22 Jul 2009 13:33:21 +0000 (13:33 +0000)]
2009-07-22  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Remove unused variables.

        * webkit/webkitwebview.cpp:
        (webkit_web_view_grab_focus):
        (webkit_web_view_focus_in_event):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-22 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 22 Jul 2009 13:30:10 +0000 (13:30 +0000)]
2009-07-22  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        WebInspector: Print console command message upon evaluate
        selection request; Handle errors in evaluation request
        properly.

        https://bugs.webkit.org/show_bug.cgi?id=27535

        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._evalSelectionInCallFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-22 Kenneth Rohde Christiansen <kenneth@webkit.org>
kenneth@webkit.org [Wed, 22 Jul 2009 13:04:18 +0000 (13:04 +0000)]
2009-07-22  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Adam Treat.

        Coding style - Clarify some cases with spacing
        https://bugs.webkit.org/show_bug.cgi?id=27499

        Add explicit rule about no space before comma or semicolon.

        * coding/coding-style.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-22 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 22 Jul 2009 07:17:38 +0000 (07:17 +0000)]
2009-07-22  Xan Lopez  <xlopez@igalia.com>

        Attempt to fix the GTK+ build.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Wed, 22 Jul 2009 06:54:57 +0000 (06:54 +0000)]
2009-07-21  Simon Hausmann  <simon.hausmann@nokia.com>

        Fix the Qt build.

        * WebCore.pro: Add RGBColor.cpp to the build, remove JSRGBColor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Daniel Bates <dbates@intudata.com>
abarth@webkit.org [Wed, 22 Jul 2009 06:19:57 +0000 (06:19 +0000)]
2009-07-21  Daniel Bates  <dbates@intudata.com>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=27494

        Fixes an issue that can cause a crash or unexpected behavior when calling
        WebCore::ScriptSourceCode::source on a cached script.

        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/CachedScriptSourceProvider.h: Modified to inherit from
        WebCore::ScriptSourceCode.
        (WebCore::CachedScriptSourceProvider::source):
        (WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider):
        * bindings/js/ScriptSourceCode.h:
        (WebCore::ScriptSourceCode::ScriptSourceCode): Separated out source provider and
        rewrote to use WebCore::ScriptSourceProvider.
        (WebCore::ScriptSourceCode::source):
        * bindings/js/ScriptSourceProvider.h: Added.
        (WebCore::ScriptSourceProvider::ScriptSourceProvider):
        (WebCore::ScriptSourceProvider::~ScriptSourceProvider):
        * bindings/js/StringSourceProvider.h: Modified to inherit from
        WebCore::ScriptSourceCode.
        (WebCore::StringSourceProvider::StringSourceProvider):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Sam Weinig <sam@webkit.org>
weinig@apple.com [Wed, 22 Jul 2009 05:31:23 +0000 (05:31 +0000)]
2009-07-21  Sam Weinig  <sam@webkit.org>

        Another attempt to fix the Windows build.

        * WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Sam Weinig <sam@webkit.org>
weinig@apple.com [Wed, 22 Jul 2009 05:19:21 +0000 (05:19 +0000)]
2009-07-21  Sam Weinig  <sam@webkit.org>

        Attempt to fix the Windows build.

        * DerivedSources.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Sam Weinig <sam@webkit.org>
weinig@apple.com [Wed, 22 Jul 2009 05:17:19 +0000 (05:17 +0000)]
2009-07-21  Sam Weinig  <sam@webkit.org>

        Attempt to fix the GTK build

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Sam Weinig <sam@webkit.org>
weinig@apple.com [Wed, 22 Jul 2009 05:04:42 +0000 (05:04 +0000)]
2009-07-21  Sam Weinig  <sam@webkit.org>

        Reviewed by Dan Bernstein.

        Autogenerate Objective-C binding implementation for RGBColor.

        No functionality change.

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/objc/DOMRGBColor.mm: Removed.
        * bindings/scripts/CodeGeneratorObjC.pm: Add logic to convert from
        WebCore::Color to NSColor*.
        * css/RGBColor.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
weinig@apple.com [Wed, 22 Jul 2009 04:27:22 +0000 (04:27 +0000)]
WebCore:

2009-07-21  Sam Weinig  <sam@webkit.org>

        Reviewed by Dan Bernstein.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=27242
        JSC bindings should use an auto-bound RGBColor class instead of hand-rolled JSRGBColor

        Move the JSC and Objective-C bindings onto using the RGBColor object instead
        of just an unsigned int. The JSC bindings are now completely autogenerated for
        this class. (Also removes the last lut from WebCore).

        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * bindings/js/JSRGBColor.cpp: Removed.
        * bindings/js/JSRGBColor.h: Removed.
        * bindings/objc/DOM.mm:
        (-[DOMRGBColor _color]):
        * bindings/objc/DOMRGBColor.mm:
        (-[DOMRGBColor dealloc]):
        (-[DOMRGBColor finalize]):
        (-[DOMRGBColor red]):
        (-[DOMRGBColor green]):
        (-[DOMRGBColor blue]):
        (-[DOMRGBColor alpha]):
        (-[DOMRGBColor color]):
        * bindings/scripts/CodeGenerator.pm:
        * bindings/scripts/CodeGeneratorJS.pm:
        * bindings/scripts/CodeGeneratorObjC.pm:
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseColor):
        * css/CSSPrimitiveValue.cpp:
        (WebCore::CSSPrimitiveValue::getRGBColorValue):
        * css/CSSPrimitiveValue.h:
        (WebCore::CSSPrimitiveValue::getRGBA32Value):
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
        * css/RGBColor.cpp:
        (WebCore::RGBColor::alpha):
        * css/RGBColor.h:
        (WebCore::RGBColor::color):
        (WebCore::RGBColor::RGBColor):
        * css/RGBColor.idl:
        * page/DOMWindow.idl:
        * svg/SVGColor.cpp:
        (WebCore::SVGColor::rgbColor):
        * svg/SVGColor.h:

LayoutTests:

2009-07-21  Sam Weinig  <sam@webkit.org>

        Reviewed by Dan Bernstein.

        Changes for https://bugs.webkit.org/show_bug.cgi?id=27242
        JSC bindings should use an auto-bound RGBColor class instead of hand-rolled JSRGBColor

        * fast/dom/Window/window-properties-expected.txt:
        * fast/dom/dom-constructors-expected.txt:
        * fast/dom/prototype-inheritance-expected.txt:
        * fast/dom/wrapper-classes-expected.txt:
        * fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
barraclough@apple.com [Wed, 22 Jul 2009 04:03:32 +0000 (04:03 +0000)]
JavaScriptCore:

2009-07-21  Zoltan Herczeg  <zherczeg@inf.u-szeged.hu>

        Reviewed by Gavin Barraclough.

        Cache not only the structure of the method, but the
        structure of its prototype as well.
        https://bugs.webkit.org/show_bug.cgi?id=27077

        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::~CodeBlock):
        * bytecode/CodeBlock.h:
        (JSC::MethodCallLinkInfo::MethodCallLinkInfo):
        * jit/JITPropertyAccess.cpp:
        (JSC::JIT::patchMethodCallProto):

LayoutTests:

2009-07-21  Zoltan Herczeg  <zherczeg@inf.u-szeged.hu>

        Reviewed by Gavin Barraclough, RS olliej fix to make the test pass.

        Check whether a crash happens after the string
        prototype is overwritten twice. The JIT'ed code
        may crash if one of its already cached method
        called again. Note: This test is not necessary
        crash on all systems, because they use different
        memory allocators!
        https://bugs.webkit.org/show_bug.cgi?id=27077

        * fast/js/method-check-expected.txt: Added.
        * fast/js/method-check.html: Added.
        * fast/js/resources/method-check.js: Added.
        (func2):
        (func.String.prototype.a):
        (func.String.prototype.b):
        (func):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Wed, 22 Jul 2009 03:24:34 +0000 (03:24 +0000)]
2009-07-21  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Sam Weinig.

        Move call linking / repatching down from AbstractMacroAssembler into MacroAssemblerARCH classes.
        ( https://bugs.webkit.org/show_bug.cgi?id=27527 )

        This allows the implementation to be defined per architecture.  Specifically this addresses the
        fact that x86-64 MacroAssembler implements far calls as a load to register, followed by a call
        to register.  Patching the call actually requires the pointer load to be patched, rather than
        the call to be patched.  This is implementation detail specific to MacroAssemblerX86_64, and as
        such is best handled there.

        * assembler/AbstractMacroAssembler.h:
        * assembler/MacroAssemblerARM.h:
        (JSC::MacroAssemblerARM::linkCall):
        (JSC::MacroAssemblerARM::repatchCall):
        * assembler/MacroAssemblerARMv7.h:
        (JSC::MacroAssemblerARMv7::linkCall):
        (JSC::MacroAssemblerARMv7::repatchCall):
        * assembler/MacroAssemblerX86.h:
        (JSC::MacroAssemblerX86::linkCall):
        (JSC::MacroAssemblerX86::repatchCall):
        * assembler/MacroAssemblerX86_64.h:
        (JSC::MacroAssemblerX86_64::linkCall):
        (JSC::MacroAssemblerX86_64::repatchCall):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Correct relative path in the test after moving it.
mitz@apple.com [Wed, 22 Jul 2009 02:42:00 +0000 (02:42 +0000)]
    Correct relative path in the test after moving it.

        * platform/mac/fast/loader/non-html-load-event.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Rubber-stamped by Mark Rowe.
mitz@apple.com [Wed, 22 Jul 2009 02:39:49 +0000 (02:39 +0000)]
    Rubber-stamped by Mark Rowe.

        Move fast/loader/non-html-load-event.html under platform/mac because
        non-HTML views exist only on Mac.

        * fast/loader/non-html-load-event-expected.txt: Removed.
        * fast/loader/non-html-load-event.html: Removed.
        * platform/mac/fast/loader/non-html-load-event-expected.txt: Copied from LayoutTests/fast/loader/non-html-load-event-expected.txt.
        * platform/mac/fast/loader/non-html-load-event.html: Copied from LayoutTests/fast/loader/non-html-load-event.html.
        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Wed, 22 Jul 2009 01:39:49 +0000 (01:39 +0000)]
2009-07-21  Adam Treat  <adam.treat@torchmobile.com>

        Reviewed by George Staikos.

        Every wtf file includes other wtf files with <> style includes
        except this one.  Fix the exception.

        * wtf/ByteArray.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Jian Li <jianli@chromium.org>
jianli@chromium.org [Wed, 22 Jul 2009 00:43:21 +0000 (00:43 +0000)]
2009-07-21  Jian Li  <jianli@chromium.org>

        Reviewed by David Levin.

        Implement AbstractWorker::dispatchScriptErrorEvent by generating an ErrorEvent.
        https://bugs.webkit.org/show_bug.cgi?id=27515

        * workers/AbstractWorker.cpp:
        (WebCore::AbstractWorker::dispatchScriptErrorEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Wed, 22 Jul 2009 00:37:03 +0000 (00:37 +0000)]
2009-07-21  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Oliver Hunt.

        Move LinkBuffer/RepatchBuffer out of AbstractMacroAssembler.
        ( https://bugs.webkit.org/show_bug.cgi?id=27485 )

        This change is the first step in a process to move code that should be in
        the architecture-specific MacroAssembler classes up out of Assmbler and
        AbstractMacroAssembler.

        * JavaScriptCore.xcodeproj/project.pbxproj:
            - added new files

        * assembler/ARMAssembler.h:
        (JSC::ARMAssembler::linkPointer):
            - rename patchPointer to bring it in line with the current link/repatch naming scheme

        * assembler/ARMv7Assembler.h:
        (JSC::ARMv7Assembler::linkCall):
        (JSC::ARMv7Assembler::linkPointer):
        (JSC::ARMv7Assembler::relinkCall):
        (JSC::ARMv7Assembler::repatchInt32):
        (JSC::ARMv7Assembler::repatchPointer):
        (JSC::ARMv7Assembler::setInt32):
        (JSC::ARMv7Assembler::setPointer):
            - rename patchPointer to bring it in line with the current link/repatch naming scheme

        * assembler/AbstractMacroAssembler.h:
        (JSC::AbstractMacroAssembler::linkJump):
        (JSC::AbstractMacroAssembler::linkCall):
        (JSC::AbstractMacroAssembler::linkPointer):
        (JSC::AbstractMacroAssembler::getLinkerAddress):
        (JSC::AbstractMacroAssembler::getLinkerCallReturnOffset):
        (JSC::AbstractMacroAssembler::repatchJump):
        (JSC::AbstractMacroAssembler::repatchCall):
        (JSC::AbstractMacroAssembler::repatchNearCall):
        (JSC::AbstractMacroAssembler::repatchInt32):
        (JSC::AbstractMacroAssembler::repatchPointer):
        (JSC::AbstractMacroAssembler::repatchLoadPtrToLEA):
            - remove the LinkBuffer/RepatchBuffer classes, but leave a set of (private, friended) methods to interface to the Assembler

        * assembler/LinkBuffer.h: Added.
        (JSC::LinkBuffer::LinkBuffer):
        (JSC::LinkBuffer::~LinkBuffer):
        (JSC::LinkBuffer::link):
        (JSC::LinkBuffer::patch):
        (JSC::LinkBuffer::locationOf):
        (JSC::LinkBuffer::locationOfNearCall):
        (JSC::LinkBuffer::returnAddressOffset):
        (JSC::LinkBuffer::finalizeCode):
        (JSC::LinkBuffer::finalizeCodeAddendum):
        (JSC::LinkBuffer::code):
        (JSC::LinkBuffer::performFinalization):
            - new file containing the LinkBuffer class, previously a member of AbstractMacroAssembler

        * assembler/RepatchBuffer.h: Added.
        (JSC::RepatchBuffer::RepatchBuffer):
        (JSC::RepatchBuffer::relink):
        (JSC::RepatchBuffer::repatch):
        (JSC::RepatchBuffer::repatchLoadPtrToLEA):
        (JSC::RepatchBuffer::relinkCallerToTrampoline):
        (JSC::RepatchBuffer::relinkCallerToFunction):
        (JSC::RepatchBuffer::relinkNearCallerToTrampoline):
            - new file containing the RepatchBuffer class, previously a member of AbstractMacroAssembler

        * assembler/X86Assembler.h:
        (JSC::X86Assembler::linkJump):
        (JSC::X86Assembler::linkCall):
        (JSC::X86Assembler::linkPointerForCall):
        (JSC::X86Assembler::linkPointer):
        (JSC::X86Assembler::relinkJump):
        (JSC::X86Assembler::relinkCall):
        (JSC::X86Assembler::repatchInt32):
        (JSC::X86Assembler::repatchPointer):
        (JSC::X86Assembler::setPointer):
        (JSC::X86Assembler::setInt32):
        (JSC::X86Assembler::setRel32):
            - rename patchPointer to bring it in line with the current link/repatch naming scheme

        * jit/JIT.cpp:
        (JSC::ctiPatchNearCallByReturnAddress):
        (JSC::ctiPatchCallByReturnAddress):
            - include new headers
            - remove MacroAssembler:: specification from RepatchBuffer usage

        * jit/JITPropertyAccess.cpp:
        * yarr/RegexJIT.cpp:
            - include new headers

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 22 Jul 2009 00:08:22 +0000 (00:08 +0000)]
2009-07-21  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Move m_context out of generator into a superclass
        https://bugs.webkit.org/show_bug.cgi?id=27521

        Mostly this is removing code from CodeGeneratorJS
        and instead using a DOMObjectWithSVGContext superclass in JSDOMBinding.h.

        DOMObjectWithSVGContext.h is its own file so that WebKit doesn't need to
        know about SVGElement.h (WebKit includes JSDOMBinding.h for some reason).

        I also removed context pointer from SVGZoomEvent since it was never used.

        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/DOMObjectWithSVGContext.h: Added.
        (WebCore::DOMObjectWithSVGContext::context):
        (WebCore::DOMObjectWithSVGContext::DOMObjectWithSVGContext):
        * bindings/js/JSDOMBinding.h:
        * bindings/js/JSEventCustom.cpp:
        (WebCore::toJS):
        * bindings/scripts/CodeGeneratorJS.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 21 Jul 2009 23:08:36 +0000 (23:08 +0000)]
2009-07-21  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        REGRESSION (r46142):  editing/execCommand/19087.html & editing/execCommand/19653-1.html fail in Windows build
        https://bugs.webkit.org/show_bug.cgi?id=27480

        Because m_anchorType : 2 is treated as a signed integer by cl.exe, anchorType() wasn't returning the correct value.
        We made m_anchorType unsigned so that anchorType() returns the correct value.

        * dom/Position.h:
        (WebCore::Position::anchorType): statically cast to AnchorType

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Jian Li <jianli@chromium.org>
jianli@chromium.org [Tue, 21 Jul 2009 22:57:51 +0000 (22:57 +0000)]
2009-07-21  Jian Li  <jianli@chromium.org>

        Reviewed by David Levin.

        [V8] Add V8 bindings for onerror in WorkerContext.
        https://bugs.webkit.org/show_bug.cgi?id=27518

        * bindings/v8/custom/V8CustomBinding.h:
        * bindings/v8/custom/V8WorkerContextCustom.cpp:
        (WebCore::ACCESSOR_GETTER):
        (WebCore::ACCESSOR_SETTER):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Jian Li <jianli@chromium.org>
jianli@chromium.org [Tue, 21 Jul 2009 22:54:58 +0000 (22:54 +0000)]
2009-07-21  Jian Li  <jianli@chromium.org>

        Fix the incorrect patch being landed for bug 27516 that has already been reviewed.
        https://bugs.webkit.org/show_bug.cgi?id=27516

        * workers/WorkerContext.h:
        (WebCore::WorkerContext::setOnerror):
        (WebCore::WorkerContext::onerror):
        * workers/WorkerContext.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Jian Li <jianli@chromium.org>
jianli@chromium.org [Tue, 21 Jul 2009 22:44:41 +0000 (22:44 +0000)]
2009-07-21  Jian Li  <jianli@chromium.org>

        Reviewed by David Levin.

        Add onerror to WorkerContext.
        https://bugs.webkit.org/show_bug.cgi?id=27516

        * bindings/js/JSWorkerContextCustom.cpp:
        (WebCore::JSWorkerContext::mark):
        * workers/WorkerContext.h:
        (WebCore::WorkerContext::setOnerror):
        (WebCore::WorkerContext::onerror):
        * workers/WorkerContext.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Yong Li <yong.li@torchmobile.com>
treat@webkit.org [Tue, 21 Jul 2009 22:42:21 +0000 (22:42 +0000)]
2009-07-21  Yong Li  <yong.li@torchmobile.com>

        Reviewed by George Staikos.

        https://bugs.webkit.org/show_bug.cgi?id=27509
        Add font-related files for the WinCE port.

        Written by Yong Li <yong.li@torchmobile.com>

        * platform/graphics/wince/FontCacheWince.cpp: Added.
        * platform/graphics/wince/FontCustomPlatformData.cpp: Added.
        * platform/graphics/wince/FontCustomPlatformData.h: Added.
        * platform/graphics/wince/FontPlatformData.cpp: Added.
        * platform/graphics/wince/FontPlatformData.h: Added.
        * platform/graphics/wince/FontWince.cpp: Added.
        * platform/graphics/wince/GlyphPageTreeNodeWince.cpp: Added.
        * platform/graphics/wince/SimpleFontDataWince.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix the Windows build, and update the comment on top now that wx uses WebCorePrefix...
kevino@webkit.org [Tue, 21 Jul 2009 21:11:09 +0000 (21:11 +0000)]
Fix the Windows build, and update the comment on top now that wx uses WebCorePrefix.h too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCorePrefix.h build fixes for non-Mac and wx / CURL builds.
kevino@webkit.org [Tue, 21 Jul 2009 20:55:03 +0000 (20:55 +0000)]
WebCorePrefix.h build fixes for non-Mac and wx / CURL builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agowx build fix. Missing header added.
kevino@webkit.org [Tue, 21 Jul 2009 20:52:35 +0000 (20:52 +0000)]
wx build fix. Missing header added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Tue, 21 Jul 2009 20:45:48 +0000 (20:45 +0000)]
2009-07-21  Adam Treat  <adam.treat@torchmobile.com>

        Reviewed by David Levin.

        We can't match implementation file and primary header exactly
        since we have so many files in WebKit where the port suffix
        is appended to the filename.

        Example: FooQt.cpp and the primary header is Foo.h.

        * Scripts/modules/cpplint.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 21 Jul 2009 20:35:39 +0000 (20:35 +0000)]
2009-07-21  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        All DOMConstructorObjects should hold a pointer to the JSDOMGlobalObject
        https://bugs.webkit.org/show_bug.cgi?id=27478

        This is just moving code.
        I've added two new classes: DOMObjectWithGlobalPointer and DOMConstructorWithDocument.

        DOMObjectWithGlobalPointer is a new baseclass for DOMConstructorObject.
        (It's a baseclass because eventually all DOMObjects will have a global pointer, but
        I'll be moving them onto DOMObjectWithGlobalPointer in stages.)

        DOMConstructorWithDocument is a new baseclass for the 3 constructor objects
        which require a backpointer to the Document to function.  I made this a subclass of
        DOMConstructorObject to make clear that most constructors can hold no-such assumptions
        about having a back-pointer to the Document (since many constructors can be used from Workers).

        * bindings/js/JSAudioConstructor.cpp:
        (WebCore::JSAudioConstructor::JSAudioConstructor):
        * bindings/js/JSAudioConstructor.h:
        * bindings/js/JSDOMBinding.h:
        (WebCore::DOMObjectWithGlobalPointer::globalObject):
        (WebCore::DOMObjectWithGlobalPointer::scriptExecutionContext):
        (WebCore::DOMObjectWithGlobalPointer::DOMObjectWithGlobalPointer):
        (WebCore::DOMObjectWithGlobalPointer::mark):
        (WebCore::DOMConstructorObject::DOMConstructorObject):
        (WebCore::DOMConstructorWithDocument::document):
        (WebCore::DOMConstructorWithDocument::DOMConstructorWithDocument):
        * bindings/js/JSImageConstructor.cpp:
        (WebCore::JSImageConstructor::JSImageConstructor):
        * bindings/js/JSImageConstructor.h:
        * bindings/js/JSMessageChannelConstructor.cpp:
        (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor):
        * bindings/js/JSMessageChannelConstructor.h:
        * bindings/js/JSOptionConstructor.cpp:
        (WebCore::JSOptionConstructor::JSOptionConstructor):
        * bindings/js/JSOptionConstructor.h:
        * bindings/js/JSWebKitCSSMatrixConstructor.cpp:
        (WebCore::JSWebKitCSSMatrixConstructor::JSWebKitCSSMatrixConstructor):
        * bindings/js/JSWebKitPointConstructor.cpp:
        (WebCore::JSWebKitPointConstructor::JSWebKitPointConstructor):
        * bindings/js/JSWorkerConstructor.cpp:
        (WebCore::JSWorkerConstructor::JSWorkerConstructor):
        * bindings/js/JSXMLHttpRequestConstructor.cpp:
        (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
        * bindings/js/JSXMLHttpRequestConstructor.h:
        * bindings/js/JSXSLTProcessorConstructor.cpp:
        (WebCore::JSXSLTProcessorConstructor::JSXSLTProcessorConstructor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Jakob Petsovits <jakob.petsovits@torchmobile.com>
levin@chromium.org [Tue, 21 Jul 2009 20:06:15 +0000 (20:06 +0000)]
2009-07-21  Jakob Petsovits  <jakob.petsovits@torchmobile.com>

        Reviewed by David Levin.

        Add checks for switch statement indentation to cpplint.
        https://bugs.webkit.org/show_bug.cgi?id=27508

        * Scripts/modules/cpplint.py:
        * Scripts/modules/cpplint_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Kenneth Rohde Christiansen <kenneth@webkit.org>
kenneth@webkit.org [Tue, 21 Jul 2009 19:43:08 +0000 (19:43 +0000)]
2009-07-21 Kenneth Rohde Christiansen <kenneth@webkit.org>

        Reviewed by Adam Treat.

        Feature request: cpplint should check for braces - rule 2
        https://bugs.webkit.org/show_bug.cgi?id=27497

        Add the requested feature: Make sure { is on the same line
        as the foreach "keyword".

        * Scripts/modules/cpplint.py:
        * Scripts/modules/cpplint_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Robert Agoston <Agoston.Robert@stud.u-szeged.hu>
levin@chromium.org [Tue, 21 Jul 2009 19:18:48 +0000 (19:18 +0000)]
2009-07-21  Robert Agoston  <Agoston.Robert@stud.u-szeged.hu>

        Reviewed by David Levin.

        Fixed #undef typo.
        https://bugs.webkit.org/show_bug.cgi?id=27506

        * bytecode/Opcode.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 James Hawkins <jhawkins@google.com>
levin@chromium.org [Tue, 21 Jul 2009 19:18:43 +0000 (19:18 +0000)]
2009-07-21  James Hawkins  <jhawkins@google.com>

        Reviewed by David Hyatt.

        https://bugs.webkit.org/show_bug.cgi?id=27453
        Initialize isInt when creating a CSSParserValue for a function.

        No change in behavior, so no tests.

        * css/CSSFunctionValue.cpp:
        (WebCore::CSSFunctionValue::parserValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-20 Jens Alfke <snej@google.com>
levin@chromium.org [Tue, 21 Jul 2009 19:18:39 +0000 (19:18 +0000)]
2009-07-20  Jens Alfke  <snej@google.com>

         Reviewed by David Levin.

         Bug 27448: [Chromium] On Mac, arrow keys should cause Select to pop up its menu.
         Mac build of Chromium doesn't follow Mac HI guidelines to pop up the menu when
         an arrow key is pressed.
         https://bugs.webkit.org/show_bug.cgi?id=27448

         No new tests; affects only control response to user input.

         * dom/SelectElement.cpp:
         Changed definition of ARROW_KEYS_POP_MENU to make it true in Mac Chromium,
         so it will behave compatibly with Mac HI guidelines on pop-up menus.
         It's not possible to have PLATFORM(MAC) be true in the Mac build of Chromium.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Paul Godavari <paul@chromium.org>
levin@chromium.org [Tue, 21 Jul 2009 19:18:34 +0000 (19:18 +0000)]
2009-07-21  Paul Godavari  <paul@chromium.org>

        Reviewed by Eric Seidel.

        [Chromium] popup menus can crash when the selected index is -1
        https://bugs.webkit.org/show_bug.cgi?id=27275

        Crash reports from users indicate a crash can occur when PopupListBox::isSelectableItem
        is passed an index of less than 0 (which is possible under certain circumstances). This
        change prevents such a value from causing a crash by enforcing valid index values passed
        by all callers of isSelectableItem. isSelectableItem is now a private method of
        PopupListBox, as there are no external callers.

        Also cleaned up a small amount of code for style and grammar errors.

        No automatic test is provided since we cannot send events to the child window used by
        the popup menu.

        * platform/chromium/PopupMenuChromium.cpp:
        (WebCore::PopupListBox::acceptIndex):
        (WebCore::PopupListBox::selectIndex):
        (WebCore::PopupListBox::isSelectableItem):
        (WebCore::PopupListBox::selectPreviousRow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agowx build fix. Don't include winsock2.h on wx, it conflicts with wx's inclusion of...
kevino@webkit.org [Tue, 21 Jul 2009 19:00:07 +0000 (19:00 +0000)]
wx build fix. Don't include winsock2.h on wx, it conflicts with wx's inclusion of winsock.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-20 Jakob Petsovits <jakob.petsovits@torchmobile.com>
treat@webkit.org [Tue, 21 Jul 2009 18:21:59 +0000 (18:21 +0000)]
2009-07-20  Jakob Petsovits  <jakob.petsovits@torchmobile.com>

        Reviewed by David Levin.

        Add checks for namespace indentation to cpplint.
        https://bugs.webkit.org/show_bug.cgi?id=27461

        * Scripts/modules/cpplint.py:
        * Scripts/modules/cpplint_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-20 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Tue, 21 Jul 2009 18:16:52 +0000 (18:16 +0000)]
2009-07-20  Adam Treat  <adam.treat@torchmobile.com>

        Reviewed by David Levin.

        Add cpplint check for proper include order
        https://bugs.webkit.org/show_bug.cgi?id=27462

        Add a new check to cpplint to flag cases where the include section of a file
        does not match the mandated include order and style of the Webkit coding style
        guidelines.

        Add associated tests.

        * Scripts/modules/cpplint.py:
        * Scripts/modules/cpplint_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Roll out r46153, r46154, and r46155
aroben@apple.com [Tue, 21 Jul 2009 18:13:11 +0000 (18:13 +0000)]
    Roll out r46153, r46154, and r46155

        These changes were causing build failures and assertion failures on
        Windows.

JavaScriptCore:

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * runtime/JSArray.cpp:
        * runtime/StringPrototype.cpp:
        * runtime/UString.cpp:
        * runtime/UString.h:
        * wtf/FastMalloc.cpp:
        * wtf/FastMalloc.h:
        * wtf/Platform.h:
        * wtf/PossiblyNull.h: Removed.

WebCore:

        * ForwardingHeaders/wtf/PossiblyNull.h: Removed.
        * platform/graphics/cg/ImageBufferCG.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46180 268f45cc-cd09-0410-ab3c-d52691b4dbfc