WebKit-https.git
7 years ago <rdar://problem/13886443> Assertion failures in NetworkProcess in SandboxExte...
ap@apple.com [Thu, 18 Jul 2013 20:38:41 +0000 (20:38 +0000)]
    <rdar://problem/13886443> Assertion failures in NetworkProcess in SandboxExtension::revoke when aborting SyncNetworkResourceLoader
        <rdar://problem/13826348> ASSERT(!m_useCount) fails in NetworkProcess at SandboxExtension::~SandboxExtension
        https://bugs.webkit.org/show_bug.cgi?id=118855

        Reviewed by Brady Eidson.

        * NetworkProcess/NetworkResourceLoader.cpp:
        (WebKit::NetworkResourceLoader::cleanup):
        (WebKit::NetworkResourceLoader::didFinishLoading):
        (WebKit::NetworkResourceLoader::didFail):
        Moved sandbox extension invalidation to cleanup() meaning that we won't fail to
        do this when aborting a loader that currently loading from network.

        * NetworkProcess/SchedulableLoader.cpp:
        (WebKit::SchedulableLoader::SchedulableLoader):
        (WebKit::SchedulableLoader::consumeSandboxExtensions):
        (WebKit::SchedulableLoader::invalidateSandboxExtensions):
        * NetworkProcess/SchedulableLoader.h:
        Keep track of whether sandbox extensions are consumed, we don't want to revoke
        extensions that were never consumed (as used to be the case with sync loaders,
        and would be with async ones after the above fix). Also, get rid of extensions
        immediately when invalidating, we won't need them again.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Windows] Support in-band text tracks.
bfulgham@apple.com [Thu, 18 Jul 2013 20:30:23 +0000 (20:30 +0000)]
[Windows] Support in-band text tracks.
https://bugs.webkit.org/show_bug.cgi?id=103770.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Test enabling WinEWS tests now that queue is at a good state and NRWT...
roger_fong@apple.com [Thu, 18 Jul 2013 20:28:20 +0000 (20:28 +0000)]
Unreviewed. Test enabling WinEWS tests now that queue is at a good state and NRWT with multiple processes is enabled.

* Scripts/webkitpy/common/config/ews.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake atob() / btoa() argument non optional
ch.dumez@sisa.samsung.com [Thu, 18 Jul 2013 19:07:35 +0000 (19:07 +0000)]
Make atob() / btoa() argument non optional
https://bugs.webkit.org/show_bug.cgi?id=118844

Reviewed by Kentaro Hara.

Source/WebCore:

According to the latest specification, the argument to atob() / btoa()
should not be optional:
http://www.whatwg.org/specs/web-apps/current-work/multipage/webappapis.html#windowbase64

This patch makes WebKit behave according to the specification. The argument
is also mandatory in Firefox, IE10 and Blink.

atob() / btoa() are also moved to their own WindowBase64 interface which
the Window interface implements. This does not change the behavior but
this is closer to the specification and it will make exposing those
methods to workers easier later on.

No new tests, already covered by:
fast/dom/Window/atob-btoa.html

* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* page/DOMWindow.idl:
* page/WindowBase64.idl: Added.

LayoutTests:

Update and rebaseline fast/dom/Window/atob-btoa.html as atob() /
btoa() 's behavior has changed to match the specification and
the behavior in other browsers.

* fast/dom/Window/atob-btoa-expected.txt:
* fast/dom/Window/atob-btoa.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in WebCore::createMarkup()
graouts@apple.com [Thu, 18 Jul 2013 18:58:52 +0000 (18:58 +0000)]
Crash in WebCore::createMarkup()
https://bugs.webkit.org/show_bug.cgi?id=118847

Reviewed by Ryosuke Niwa.

Also check that we have a containingBlock() for the renderer() so that we
may safely call node() on it.

* editing/markup.cpp:
(WebCore::highestAncestorToWrapMarkup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r132678): Tests that use SSL or port 8080 time out when run using old...
dbates@webkit.org [Thu, 18 Jul 2013 18:26:06 +0000 (18:26 +0000)]
REGRESSION (r132678): Tests that use SSL or port 8080 time out when run using old-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=118854
<rdar://problem/14081339>

Reviewed by David Kilzer.

Following <http://trac.webkit.org/changeset/132678> (https://bugs.webkit.org/show_bug.cgi?id=98602)
Apache no longer listens to ports 8443 (SSL) and 8080. So, tests that use these ports time out when
run using old-run-webkit-tests. We need to update old-run-webkit-tests to explicitly tell Apache to
listen on these ports so that we can run tests that use port 8443 and 8080.

* Scripts/old-run-webkit-tests:
(configureAndOpenHTTPDIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoConvert MathML fraction tests to reftests.
commit-queue@webkit.org [Thu, 18 Jul 2013 17:45:34 +0000 (17:45 +0000)]
Convert MathML fraction tests to reftests.
https://bugs.webkit.org/show_bug.cgi?id=118812

Patch by Frédéric Wang <fred.wang@free.fr> on 2013-07-18
Reviewed by Chris Fleizach.

fractions-vertical-alignment and fractions are converted to reftests.

* mathml/presentation/fractions-box-expected.html: Added.
* mathml/presentation/fractions-box.html: Added.
* mathml/presentation/fractions-color-expected-mismatch.html: Added.
* mathml/presentation/fractions-color.html: Added.
* mathml/presentation/fractions-invalid-expected.html: Added.
* mathml/presentation/fractions-invalid.html: Added.
* mathml/presentation/fractions-linethickness-expected.html: Added.
* mathml/presentation/fractions-linethickness.html: Added.
* mathml/presentation/fractions-mrow-expected.html: Added.
* mathml/presentation/fractions-mrow.html: Added.
* mathml/presentation/fractions-numalign-denomalign-expected.html: Added.
* mathml/presentation/fractions-numalign-denomalign.html: Added.
* mathml/presentation/fractions-positions-expected.html: Added.
* mathml/presentation/fractions-positions.html: Added.
* mathml/presentation/fractions-vertical-alignment-expected.html: Added.
* mathml/presentation/fractions-vertical-alignment.html: Added.
* mathml/presentation/fractions-vertical-alignment.xhtml: Removed.
* mathml/presentation/fractions.xhtml: Removed.
* platform/efl/mathml/presentation/fractions-expected.png: Removed.
* platform/efl/mathml/presentation/fractions-expected.txt: Removed.
* platform/efl/mathml/presentation/fractions-vertical-alignment-expected.png: Removed.
* platform/efl/mathml/presentation/fractions-vertical-alignment-expected.txt: Removed.
* platform/gtk/mathml/presentation/fractions-expected.png: Removed.
* platform/gtk/mathml/presentation/fractions-expected.txt: Removed.
* platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.png: Removed.
* platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.txt: Removed.
* platform/mac/mathml/presentation/fractions-expected.png: Removed.
* platform/mac/mathml/presentation/fractions-expected.txt: Removed.
* platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png: Removed.
* platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCodeBlock::m_argumentValueProfiles wastes a lot of memory.
akling@apple.com [Thu, 18 Jul 2013 16:50:38 +0000 (16:50 +0000)]
CodeBlock::m_argumentValueProfiles wastes a lot of memory.
<http://webkit.org/b/118852>
<rdar://problem/14481659>

Reviewed by Anders Carlsson.

Source/JavaScriptCore:

Use Vector::resizeToFit() for CodeBlock::m_argumentValueProfiles. We don't need any padding
for growth, since we won't be appending to it anyway.

921 KB progression on <http://twitter.com/awesomekling>

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::setNumParameters):

Source/WTF:

Add Vector::resizeToFit(size), like resize() but without growth padding.

* wtf/Vector.h:
(WTF::::resizeToFit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofullscreen/full-screen-iframe-with-max-width-height.html is flaky
commit-queue@webkit.org [Thu, 18 Jul 2013 15:44:12 +0000 (15:44 +0000)]
fullscreen/full-screen-iframe-with-max-width-height.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=118820

Patch by Zalan Bujtas <zalan@apple.com> on 2013-07-18
Reviewed by Andreas Kling.

Don't start the test until after the iframe has finished loading.

* fullscreen/full-screen-iframe-with-max-width-height-expected.txt:
* fullscreen/full-screen-iframe-with-max-width-height.html:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoOnly the first call to 'stop' method of AudioBufferSourceNode must be entertained.
commit-queue@webkit.org [Thu, 18 Jul 2013 15:39:25 +0000 (15:39 +0000)]
Only the first call to 'stop' method of AudioBufferSourceNode must be entertained.
https://bugs.webkit.org/show_bug.cgi?id=118776

Patch by Praveen R Jadhav <praveen.j@samsung.com> on 2013-07-18
Reviewed by Jer Noble.

Source/WebCore:

Subsequent calls to 'stop' for a AudioSourceBufferNode throws an exception.
End time set by first 'stop' method is used for processing.

No new tests. audiobuffersource-exception.html is updated.

* Modules/webaudio/AudioScheduledSourceNode.cpp:
(WebCore::AudioScheduledSourceNode::stop):

LayoutTests:

Test case updated to check subsequent calls to 'stop' for a given AudioBufferSourceNode.

* webaudio/audiobuffersource-exception-expected.txt:
* webaudio/audiobuffersource-exception.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSimplify SVG animated type handling in the JSC bindings generator
ch.dumez@sisa.samsung.com [Thu, 18 Jul 2013 14:51:53 +0000 (14:51 +0000)]
Simplify SVG animated type handling in the JSC bindings generator
https://bugs.webkit.org/show_bug.cgi?id=118845

Reviewed by Kentaro Hara.

Simplify IsSVGAnimatedType subroutine in the bindings generator so that
we no longer need to hardcode SVG animated types. Also remove the
CanUseFastAttribute subroutine as it is equivalent to IsSVGAnimatedType.
This allows us to simplify the GetterExpression subroutine so that
we can use fastHasAttribute() unconditionally for boolean type.

No new tests, no behavior change.

* bindings/scripts/CodeGenerator.pm:
(IsSVGAnimatedType):
(GetterExpression):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse [ImplementedAs] instead of special casing in the bindings generators
ch.dumez@sisa.samsung.com [Thu, 18 Jul 2013 14:24:52 +0000 (14:24 +0000)]
Use [ImplementedAs] instead of special casing in the bindings generators
https://bugs.webkit.org/show_bug.cgi?id=118848

Reviewed by Kentaro Hara.

In several instances, special casing were used in the bindings generator to avoid
name clashes in the implementation. The [ImplementedBy] IDL extended attribute is
meant to solve this issue so we now use it instead.

No new tests, no behavior change.

* bindings/scripts/CodeGenerator.pm:
(WK_ucfirst):
(AttributeNameForGetterAndSetter):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
(NativeToJSValue):
* bindings/scripts/CodeGeneratorObjC.pm:
(GenerateHeader):
(GenerateImplementation):
* svg/SVGAElement.idl:
* svg/SVGFECompositeElement.cpp:
(WebCore::SVGFECompositeElement::SVGFECompositeElement):
(WebCore::SVGFECompositeElement::parseAttribute):
(WebCore::SVGFECompositeElement::setFilterEffectAttribute):
(WebCore::SVGFECompositeElement::build):
* svg/SVGFECompositeElement.h:
* svg/SVGFECompositeElement.idl:
* svg/SVGFEMorphologyElement.cpp:
(WebCore::SVGFEMorphologyElement::SVGFEMorphologyElement):
(WebCore::SVGFEMorphologyElement::parseAttribute):
(WebCore::SVGFEMorphologyElement::setFilterEffectAttribute):
(WebCore::SVGFEMorphologyElement::build):
* svg/SVGFEMorphologyElement.h:
* svg/SVGFEMorphologyElement.idl:
* svg/SVGTransform.cpp:
(WebCore::SVGTransform::updateSVGMatrix):
* svg/SVGTransform.h:
* svg/SVGTransform.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK1] Mark failing API tests as XFAIL
zarvai@inf.u-szeged.hu [Thu, 18 Jul 2013 14:03:57 +0000 (14:03 +0000)]
[Qt][WK1] Mark failing API tests as XFAIL

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-07-18
Reviewed by Csaba Osztrogonác.

* tests/qgraphicswebview/tst_qgraphicswebview.cpp:
(tst_QGraphicsWebView::widgetsRenderingThroughCache):
(tst_QGraphicsWebView::windowResizeEvent):
* tests/qwebelement/tst_qwebelement.cpp:
(tst_QWebElement::addElementToHead):
* tests/qwebframe/tst_qwebframe.cpp:
(tst_QWebFrame::setHtmlWithImageResource):
(tst_QWebFrame::setHtmlWithStylesheetResource):
(tst_QWebFrame::setHtmlWithJSAlert):
* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::geolocationRequestJS):
(tst_QWebPage::popupFormSubmission):
(tst_QWebPage::originatingObjectInNetworkRequests):
(tst_QWebPage::testStopScheduledPageRefresh):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnskip mathml tests after r152840.
commit-queue@webkit.org [Thu, 18 Jul 2013 13:05:43 +0000 (13:05 +0000)]
Unskip mathml tests after r152840.
https://bugs.webkit.org/show_bug.cgi?id=118842

Unreviewed.

Patch by Zalan Bujtas <zalan@apple.com> on 2013-07-18

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove PDFViewController and WKView "custom representations"
timothy_horton@apple.com [Thu, 18 Jul 2013 09:35:05 +0000 (09:35 +0000)]
Remove PDFViewController and WKView "custom representations"
https://bugs.webkit.org/show_bug.cgi?id=118720

Reviewed by Alexey Proskuryakov.

PDFViewController was the only implementation of
a "custom representation" for a WKView. As it has
been superceded by PDFPlugin, we can remove both
PDFViewController and the notion of a WKView custom
representation.

* UIProcess/API/gtk/PageClientImpl.cpp:
* UIProcess/API/gtk/PageClientImpl.h:
* UIProcess/API/mac/PDFViewController.h: Removed.
* UIProcess/API/mac/PDFViewController.mm: Removed.
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
* UIProcess/API/mac/WKView.mm:
(-[WKView accessibilityFocusedUIElement]):
(-[WKView accessibilityHitTest:]):
(-[WKView accessibilityAttributeValue:]):
(-[WKView printOperationWithPrintInfo:forFrame:]):
* UIProcess/API/mac/WKViewInternal.h:
* UIProcess/API/qt/raw/qrawwebview_p_p.h:
* UIProcess/CoordinatedGraphics/WebView.cpp:
* UIProcess/CoordinatedGraphics/WebView.h:
* UIProcess/DrawingAreaProxy.h:
* UIProcess/DrawingAreaProxyImpl.cpp:
* UIProcess/DrawingAreaProxyImpl.h:
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::supportsTextEncoding):
(WebKit::WebPageProxy::supportsTextZoom):
(WebKit::WebPageProxy::setTextZoomFactor):
(WebKit::WebPageProxy::setPageZoomFactor):
(WebKit::WebPageProxy::setPageAndTextZoomFactors):
(WebKit::WebPageProxy::findString):
(WebKit::WebPageProxy::countStringMatches):
(WebKit::WebPageProxy::didCommitLoadForFrame):
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::textZoomFactor):
(WebKit::WebPageProxy::pageZoomFactor):
* UIProcess/WebPageProxy.messages.in:
* UIProcess/qt/QtPageClient.h:
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::WebFrameLoaderClient):
(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
(WebKit::WebFrameLoaderClient::committedLoad):
(WebKit::WebFrameLoaderClient::finishedLoading):
(WebKit::WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
* WebProcess/WebPage/DrawingArea.h:
* WebProcess/WebPage/DrawingArea.messages.in:
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::setNeedsDisplayInRect):
(WebKit::DrawingAreaImpl::scroll):
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
(WebKit::DrawingAreaImpl::display):
* WebProcess/WebPage/DrawingAreaImpl.h:
* WebProcess/WebPage/WebPage.cpp:
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::platformPreferencesDidChange):
* mac/WebKit2.order:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIncorrect calculated width for mspace.
commit-queue@webkit.org [Thu, 18 Jul 2013 09:09:00 +0000 (09:09 +0000)]
Incorrect calculated width for mspace.
https://bugs.webkit.org/show_bug.cgi?id=118601

Patch by Zalan Bujtas <zalan@apple.com> on 2013-07-18
Reviewed by Chris Fleizach.

Source/WebCore:

Use intrinsic logical widths to size <mspace> properly.
This patch also fixes an assert on isPreferredLogicalHeightDirty() which occurs
while layouting <mspace>. The assert fix is required, so that the sizing can be
fixed.

Test: mathml/presentation/mspace-prefered-width.html

* rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::parseMathMLLength): switch to LayoutUnits.
(WebCore::parseMathMLNamedSpace): switch to LayoutUnits.
* rendering/mathml/RenderMathMLBlock.h:
* rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::updateFromElement):
* rendering/mathml/RenderMathMLFraction.h:
* rendering/mathml/RenderMathMLSpace.cpp:
(WebCore::RenderMathMLSpace::computeIntrinsicLogicalWidths):
* rendering/mathml/RenderMathMLSpace.h:

LayoutTests:

Use intrinsic logical widths to size <mspace> properly.
This patch also fixes an assert on isPreferredLogicalHeightDirty(), which occurs
while layouting <mspace>. The assert fix is required, so that the sizing can be
fixed.

* mathml/presentation/mspace-prefered-width-expected.html: Added.
* mathml/presentation/mspace-prefered-width.html: Added.
* platform/mac/mathml/presentation/fractions-expected.png: Rebaseline: float->LayoutUnit.
* platform/mac/mathml/presentation/fractions-expected.txt: Rebaseline: float->LayoutUnit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowillWriteSelectionToPasteboard and willPerformDragSourceAction editing callbacks...
rniwa@webkit.org [Thu, 18 Jul 2013 08:45:19 +0000 (08:45 +0000)]
willWriteSelectionToPasteboard and willPerformDragSourceAction editing callbacks are not called for drag and drop
https://bugs.webkit.org/show_bug.cgi?id=118828

Reviewed by Gavin Barraclough.

Call these two callbacks when we start a drag and drop.

No new tests for now but we should start logging these callbacks in DRT and WTR's EditorClients.

* page/DragController.cpp:
(WebCore::DragController::startDrag):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Replace mouseClick with more meaningful method in test_ewk2_color_picker.cpp
commit-queue@webkit.org [Thu, 18 Jul 2013 08:28:55 +0000 (08:28 +0000)]
[EFL][WK2] Replace mouseClick with more meaningful method in test_ewk2_color_picker.cpp
https://bugs.webkit.org/show_bug.cgi?id=118797

Patch by Dong-Gwan Kim <donggwan.kim@samsung.com> on 2013-07-18
Reviewed by Christophe Dumez.

Some mouseClick methods are used in test_ewk2_color_picker.cpp.
But it is difficult to understand what they mean.
So i would like to replace those with more meaningful method for readability.

* UIProcess/API/efl/tests/test_ewk2_color_picker.cpp:
(EWK2ColorPickerTest::clickButton):
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] Replace getRect() to pixelSnappedBoundingBox().
commit-queue@webkit.org [Thu, 18 Jul 2013 08:05:05 +0000 (08:05 +0000)]
[WK2] Replace getRect() to pixelSnappedBoundingBox().
https://bugs.webkit.org/show_bug.cgi?id=118588

Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2013-07-18
Reviewed by Noam Rosenthal.

The Node::getRect() function was removed in the
http://trac.webkit.org/changeset/128006, so use
pixelSnappedBoundingBox() instead.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::findZoomableAreaForPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoASSERTION FAILED: !listItems().size() || m_activeSelectionAnchorIndex >= 0 in WebCore...
commit-queue@webkit.org [Thu, 18 Jul 2013 08:04:30 +0000 (08:04 +0000)]
ASSERTION FAILED: !listItems().size() || m_activeSelectionAnchorIndex >= 0 in WebCore::HTMLSelectElement::updateListBoxSelection
https://bugs.webkit.org/show_bug.cgi?id=118591

Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-07-18
Reviewed by Kent Tamura.

Source/WebCore:

Test: fast/forms/select/selectall-command-crash.html

* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::selectAll):
We should return this function if activeSelectionAnchorIndex is not valid index

LayoutTests:

* fast/forms/select/selectall-command-crash-expected.txt: Added.
* fast/forms/select/selectall-command-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Replace mouseClick with more meaningful method in test_ewk2_context_menu.cpp
commit-queue@webkit.org [Thu, 18 Jul 2013 08:01:22 +0000 (08:01 +0000)]
[EFL][WK2] Replace mouseClick with more meaningful method in test_ewk2_context_menu.cpp
https://bugs.webkit.org/show_bug.cgi?id=118796

Patch by Dong-Gwan Kim <donggwan.kim@samsung.com> on 2013-07-18
Reviewed by Christophe Dumez.

Some mouseClick methods are used in test_ewk2_context_menu.cpp.
But it is difficult to understand what they mean.
So i would like to replace those with more meaningful method for readability.

* UIProcess/API/efl/tests/test_ewk2_context_menu.cpp:
(EWK2ContextMenuTest::testContextMenu):
(EWK2ContextMenuTest::testContextMenuForRemoveAndAppend):
(EWK2ContextMenuTest::testContextMenuForSubmenu):
(EWK2ContextMenuTest::finishTest):
(EWK2ContextMenuTest::showContextMenu):
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Refactor spin.edc not to use offset
ryuan.choi@samsung.com [Thu, 18 Jul 2013 07:51:58 +0000 (07:51 +0000)]
[EFL] Refactor spin.edc not to use offset
https://bugs.webkit.org/show_bug.cgi?id=118830

Reviewed by Gyuyoung Kim.

Source/WebCore:

EDJE allows offset to specify the pixel based position,
but it's not good way if you want to locate object like arrow top or bottom.

Instead, this patch uses align property.

* platform/efl/DefaultTheme/widget/spinner/spinner.edc:

LayoutTests:

Updated pixel tests reults.

* platform/efl/fast/forms/number/number-appearance-rtl-expected.png:
* platform/efl/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png:
* platform/efl/fast/forms/number/number-appearance-spinbutton-layer-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Replace mouseClick with more meaningful method in test_ewk2_file_chooser_r...
commit-queue@webkit.org [Thu, 18 Jul 2013 07:29:19 +0000 (07:29 +0000)]
[EFL][WK2] Replace mouseClick with more meaningful method in test_ewk2_file_chooser_request.cpp
https://bugs.webkit.org/show_bug.cgi?id=118792

Patch by Dong-Gwan Kim <donggwan.kim@samsung.com> on 2013-07-18
Reviewed by Christophe Dumez.

Some mouseClick methods are used in test_ewk2_file_chooser_request.cpp.
But it is difficult to understand what they mean.
So i would like to replace those with more meaningful method for readability.

* UIProcess/API/efl/tests/test_ewk2_file_chooser_request.cpp:
(EWK2FileChooserRequestTest::clickFileInput):
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[gstreamer] Avoid calls to g_slist_index in webKitWebAudioSrcLoop()
commit-queue@webkit.org [Thu, 18 Jul 2013 07:27:16 +0000 (07:27 +0000)]
[gstreamer] Avoid calls to g_slist_index in webKitWebAudioSrcLoop()
https://bugs.webkit.org/show_bug.cgi?id=118827

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-07-18
Reviewed by Philippe Normand.

webKitWebAudioSrcLoop() currently calls g_slist_index for each element
to get its index in a list it's iterating over. g_list_index function uses
a sequential search to find that element, which is clearly unecessary.
This patch adds a local variable to store the current index and use it
instead of calling g_slist_index function.

No new tests, no behavior changes.

* platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webKitWebAudioSrcLoop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Move all the static methods into EWK2TextCheckerTest in test_ewk2_text_che...
commit-queue@webkit.org [Thu, 18 Jul 2013 07:27:08 +0000 (07:27 +0000)]
[EFL][WK2] Move all the static methods into EWK2TextCheckerTest in test_ewk2_text_checker.cpp
https://bugs.webkit.org/show_bug.cgi?id=118790

Patch by Dong-Gwan Kim <donggwan.kim@samsung.com> on 2013-07-18
Reviewed by Christophe Dumez.

All the static methods should be moved to EWK2TextCheckerTest.

* UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:
(EWK2TextCheckerTest::resetCallbacksExecutionStats):
(EWK2TextCheckerTest::onTimeout):
(EWK2TextCheckerTest::onSettingChange):
(EWK2TextCheckerTest::onSpellDocumentTag):
(EWK2TextCheckerTest::onSpellDocumentTagClose):
(EWK2TextCheckerTest::onSpellingCheck):
(EWK2TextCheckerTest::onSpellingForKnownWord):
(EWK2TextCheckerTest::onWordGuesses):
(EWK2TextCheckerTest::onWordLearn):
(EWK2TextCheckerTest::onWordIgnore):
(EWK2TextCheckerTest::findContextMenuItem):
(EWK2TextCheckerTest::checkCorrectnessOfSpellingItems):
(EWK2TextCheckerTest::toogleCheckSpellingWhileTyping):
(EWK2TextCheckerTest::checkClientSuggestionsForWord):
(EWK2TextCheckerTest::selectLearnSpelling):
(EWK2TextCheckerTest::selectIgnoreSpelling):
(EWK2TextCheckerTest::countContextMenuItems):
(EWK2TextCheckerTest::clickButton):
(EWK2TextCheckerTest::showContextMenu):
(EWK2TextCheckerTest::selectFirstWord):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Fix a typo in WebInspector.loaded
commit-queue@webkit.org [Thu, 18 Jul 2013 06:36:26 +0000 (06:36 +0000)]
Web Inspector: Fix a typo in WebInspector.loaded
https://bugs.webkit.org/show_bug.cgi?id=118834

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-07-17
Reviewed by Timothy Hatcher.

* UserInterface/Main.js:
(WebInspector.loaded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIntroduce toSVGInlineFlowBox() and use it
gyuyoung.kim@samsung.com [Thu, 18 Jul 2013 02:13:49 +0000 (02:13 +0000)]
Introduce toSVGInlineFlowBox() and use it
https://bugs.webkit.org/show_bug.cgi?id=118794

Reviewed by Andreas Kling.

As a step to change static_cast with toSVGXXX, static_cast<SVGInlineFlowBox*> can
be changed with toSVGInlineFlowBox().

Blink merge from https://src.chromium.org/viewvc/blink?view=rev&revision=154385

No new tests, no behavior change.

* rendering/svg/SVGInlineFlowBox.cpp:
(WebCore::SVGInlineFlowBox::paintSelectionBackground):
* rendering/svg/SVGInlineFlowBox.h:
(WebCore::toSVGInlineFlowBox):
* rendering/svg/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::paint):
(WebCore::SVGRootInlineBox::layoutCharactersInTextBoxes):
(WebCore::SVGRootInlineBox::layoutChildBoxes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse toSVGMarkerElement() instead of static_cast<>
gyuyoung.kim@samsung.com [Thu, 18 Jul 2013 02:12:14 +0000 (02:12 +0000)]
Use toSVGMarkerElement() instead of static_cast<>
https://bugs.webkit.org/show_bug.cgi?id=118800

Reviewed by Andreas Kling.

Though there is toSVGMarkerElement(), some files still use static_cast<SVGMarkerElement*>.
To remove all static_cast<> use, we need to change argument from SVGElement to Node.

No new tests, no behavior changes.

* rendering/svg/RenderSVGResourceMarker.cpp:
(WebCore::RenderSVGResourceMarker::referencePoint):
(WebCore::RenderSVGResourceMarker::angle):
(WebCore::RenderSVGResourceMarker::markerTransformation):
(WebCore::RenderSVGResourceMarker::viewportTransform):
(WebCore::RenderSVGResourceMarker::calcViewport):
* rendering/svg/RenderSVGResourceMarker.h:
(WebCore::RenderSVGResourceMarker::markerUnits):
* svg/SVGMarkerElement.h:
(WebCore::toSVGMarkerElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDereference null pointer crash in Length::decrementCalculatedRef()
commit-queue@webkit.org [Thu, 18 Jul 2013 01:02:56 +0000 (01:02 +0000)]
Dereference null pointer crash in Length::decrementCalculatedRef()
https://bugs.webkit.org/show_bug.cgi?id=118686

Patch by Jacky Jiang <zhajiang@blackberry.com> on 2013-07-17
Reviewed by Simon Fraser.

Source/WebCore:

Length(Calculated) won't insert any CalculationValue to CalculationValueHandleMap;
therefore, we dereference null CalculationValue pointer when the temporary
Length object goes out of the scope.
Length(Calculated) is not allowed as it doesn't make sense that we construct
a Calculated Length object with uninitialized calc expression.
The code just wants to blend with zero. To fix the bug, we can just blend
with Length(0, Fixed) here as we currently can blend different type units
and zero has the same behavior regardless of unit.

Test: transitions/transition-transform-translate-calculated-length-crash.html

* platform/graphics/transforms/TranslateTransformOperation.cpp:
(WebCore::TranslateTransformOperation::blend):

LayoutTests:

* transitions/transition-transform-translate-calculated-length-crash-expected.txt: Added.
* transitions/transition-transform-translate-calculated-length-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate blocked/missing plug-in UI
timothy_horton@apple.com [Thu, 18 Jul 2013 00:43:18 +0000 (00:43 +0000)]
Update blocked/missing plug-in UI
https://bugs.webkit.org/show_bug.cgi?id=118347
<rdar://problem/14209318>

Reviewed by Sam Weinig.

* WebCore.exp.in:
Export RenderEmbeddedObject::setPluginUnavailabilityReasonWithDescription.

* rendering/RenderEmbeddedObject.cpp:
(WebCore::replacementTextRoundedRectPressedColor):
(WebCore::replacementTextRoundedRectColor):
(WebCore::replacementTextColor):
Change colors to new design and add some more constants.

(WebCore::shouldUnavailablePluginMessageBeButton): Added.

(WebCore::RenderEmbeddedObject::setPluginUnavailabilityReasonWithDescription): Added.
(WebCore::RenderEmbeddedObject::setPluginUnavailabilityReason):
Call through to the -WithDescription variant.

(WebCore::RenderEmbeddedObject::paintReplaced):
Fill the background, and otherwise match the new design.

(WebCore::addReplacementArrowPath):
Add an arrow to the given path, inside the given rect.

(WebCore::RenderEmbeddedObject::getReplacementTextGeometry):
Add a 1px padding to the bottom of the text.
Add a circle and an arrow into the indicator as per the new design.

(WebCore::RenderEmbeddedObject::isInUnavailablePluginIndicator):
Hit-test the indicator arrow as well; otherwise, the fact that the arrow
is a hole in the path means it won't be hit.

* rendering/RenderEmbeddedObject.h:

* Platform/CoreIPC/HandleMessage.h:
(CoreIPC::callMemberFunction):
Add a 6 argument -> 4 reply message handler.
(It seems that FindPlugin is getting a little out of hand.)

* Shared/APIClientTraits.cpp:
* Shared/APIClientTraits.h:
* UIProcess/API/C/WKPage.h:
* UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::pluginLoadPolicy):
* UIProcess/WebLoaderClient.h:
Add an unavailability description out-argument to a new version of
pluginLoadPolicy, so clients can override the text of the unavailable
plugin indicator. Bump the WKPageLoaderClient version and update APIClientTraits.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::findPlugin):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
Plumb the unavailability description through to the WebProcess via
the FindPlugin message.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):
Acquire the unavailability description from the client
(via FindPlugin) and hand it to the RenderEmbeddedObject.

* MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController awakeFromNib]):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::createWebViewWithOptions):
Match new WKPageLoaderClient entry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAnother attempt to make planet cron job happy
bfulgham@apple.com [Thu, 18 Jul 2013 00:35:30 +0000 (00:35 +0000)]
Another attempt to make planet cron job happy

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSkip crashing MathML tests while waiting for a fix for
slewis@apple.com [Thu, 18 Jul 2013 00:30:15 +0000 (00:30 +0000)]
Skip crashing MathML tests while waiting for a fix for
https://bugs.webkit.org/show_bug.cgi?id=118601

Unreviewed.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMade a repeatable process for updating ANGLE that does not include manually editing...
achristensen@apple.com [Thu, 18 Jul 2013 00:23:41 +0000 (00:23 +0000)]
Made a repeatable process for updating ANGLE that does not include manually editing any files.
https://bugs.webkit.org/show_bug.cgi?id=118815

Reviewed by Dean Jackson.

* src/compiler/glslang.y:
* src/compiler/glslang_lex.cpp:
* src/compiler/glslang_tab.cpp:
* src/compiler/glslang_tab.h: Put YYLTYPE definition in %union instead of prologue and ran Bison.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, fix 32-bit after http://trac.webkit.org/changeset/152813
fpizlo@apple.com [Wed, 17 Jul 2013 23:43:53 +0000 (23:43 +0000)]
Unreviewed, fix 32-bit after trac.webkit.org/changeset/152813

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileNewFunctionNoCheck):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAPI tests should test for JSStringCreateWithCFString with empty string
ggaren@apple.com [Wed, 17 Jul 2013 23:41:01 +0000 (23:41 +0000)]
API tests should test for JSStringCreateWithCFString with empty string
https://bugs.webkit.org/show_bug.cgi?id=118819

Reviewed by Mark Hahnenberg.

* API/tests/testapi.c:
(main): Test!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd a thread safety assertion when creating an AtomicString from a StringImpl
benjamin@webkit.org [Wed, 17 Jul 2013 23:37:54 +0000 (23:37 +0000)]
Add a thread safety assertion when creating an AtomicString from a StringImpl
https://bugs.webkit.org/show_bug.cgi?id=118637

Reviewed by Sam Weinig.

The goal is to prevent this kind of use:
-Someone create a String from a StringImpl.
-At some point, the string becomes atomic.
-Later, when the string only has one ref, its ownership is 'passed' to an other thread
 without checking String::isSafeToSendToAnotherThread().
-In the thread B, an AtomicString is created from the String.
->The AtomicString's StringImpl returned is not in the current thread string table.

* wtf/text/AtomicString.cpp:
(WTF::AtomicString::isInAtomicStringTable):
* wtf/text/AtomicString.h:
(WTF::AtomicString::add):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSimplify AtomicString::lower()
benjamin@webkit.org [Wed, 17 Jul 2013 23:34:13 +0000 (23:34 +0000)]
Simplify AtomicString::lower()
https://bugs.webkit.org/show_bug.cgi?id=118719
<rdar://problem/14452883>

Reviewed by Gavin Barraclough.

* wtf/text/AtomicString.cpp:
(WTF::AtomicString::lower): Previously, the code was using a copy constructor for two path
and one regular construction in another path.
Just put the StringImpl where it needs to be instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r152701, r152703, r152739, r152754,
commit-queue@webkit.org [Wed, 17 Jul 2013 23:32:43 +0000 (23:32 +0000)]
Unreviewed, rolling out r152701, r152703, r152739, r152754,
and r152756.
http://trac.webkit.org/changeset/152701
http://trac.webkit.org/changeset/152703
http://trac.webkit.org/changeset/152739
http://trac.webkit.org/changeset/152754
http://trac.webkit.org/changeset/152756
https://bugs.webkit.org/show_bug.cgi?id=118821

this was a buggy fix and we're going to try something
different (Requested by thorton on #webkit).

Source/WebCore:

* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.am:
* WebCore.exp.in:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSDefaultStyleSheets.cpp:
(WebCore::CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement):
* css/unavailablePlugIns.css: Removed.
* dom/EventListener.h:
* html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::updateWidget):
* html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::defaultEventHandler):
* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot):
* loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::createJavaAppletWidget):
* page/ChromeClient.h:
(WebCore::ChromeClient::shouldUnavailablePluginMessageBeButton):
* rendering/RenderEmbeddedObject.cpp:
(WebCore::replacementTextRoundedRectPressedColor):
(WebCore::RenderEmbeddedObject::RenderEmbeddedObject):
(WebCore::RenderEmbeddedObject::setPluginUnavailabilityReason):
(WebCore::RenderEmbeddedObject::setUnavailablePluginIndicatorIsPressed):
(WebCore::RenderEmbeddedObject::paint):
(WebCore::RenderEmbeddedObject::paintReplaced):
(WebCore::RenderEmbeddedObject::getReplacementTextGeometry):
(WebCore::RenderEmbeddedObject::replacementTextRect):
(WebCore::RenderEmbeddedObject::isReplacementObscured):
(WebCore::RenderEmbeddedObject::layout):
(WebCore::RenderEmbeddedObject::isInUnavailablePluginIndicator):
(WebCore::shouldUnavailablePluginMessageBeButton):
(WebCore::RenderEmbeddedObject::handleUnavailablePluginIndicatorEvent):
(WebCore::RenderEmbeddedObject::getCursor):
(WebCore::RenderEmbeddedObject::canHaveChildren):
* rendering/RenderEmbeddedObject.h:
* rendering/RenderWidget.h:

Source/WebKit/mac:

* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::shouldUnavailablePluginMessageBeButton):

Source/WebKit2:

* Platform/CoreIPC/HandleMessage.h:
* Shared/APIClientTraits.cpp:
* Shared/APIClientTraits.h:
* UIProcess/API/C/WKPage.h:
* UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::pluginLoadPolicy):
* UIProcess/WebLoaderClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::findPlugin):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* WebProcess/Plugins/PluginProcessConnection.cpp:
(WebKit::PluginProcessConnection::didClose):
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::pluginProcessCrashed):
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::shouldUnavailablePluginMessageBeButton):
* WebProcess/WebCoreSupport/WebChromeClient.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):
(WebKit::WebPage::canPluginHandleResponse):

Tools:

* MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController awakeFromNib]):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::createWebViewWithOptions):

LayoutTests:

* editing/pasteboard/paste-noplugin-expected.txt:
* http/tests/security/contentSecurityPolicy/object-src-url-blocked-expected.txt:
* platform/mac/accessibility/plugin-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDFG assumes that NewFunction will never pass its input through
fpizlo@apple.com [Wed, 17 Jul 2013 23:27:31 +0000 (23:27 +0000)]
DFG assumes that NewFunction will never pass its input through
https://bugs.webkit.org/show_bug.cgi?id=118798

Source/JavaScriptCore:

Reviewed by Sam Weinig.

Previously the DFG was assuming that NewFunction always returns a function. That's not
the case. It may return whatever was passed to it, if it wasn't passed SpecEmpty.

This fact needed to be wired through the compiler.

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::executeEffects):
* dfg/DFGAbstractValue.h:
(JSC::DFG::AbstractValue::makeTop):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

LayoutTests:

Reviewed by Sam Weinig.

* fast/js/dfg-use-function-as-variable-expected.txt: Added.
* fast/js/dfg-use-function-as-variable-merge-structure-expected.txt: Added.
* fast/js/dfg-use-function-as-variable-merge-structure.html: Added.
* fast/js/dfg-use-function-as-variable-not-constant-expected.txt: Added.
* fast/js/dfg-use-function-as-variable-not-constant.html: Added.
* fast/js/dfg-use-function-as-variable-with-closure-expected.txt: Added.
* fast/js/dfg-use-function-as-variable-with-closure.html: Added.
* fast/js/dfg-use-function-as-variable.html: Added.
* fast/js/jsc-test-list:
* fast/js/script-tests/dfg-use-function-as-variable-merge-structure.js: Added.
(.x):
(run_tests):
* fast/js/script-tests/dfg-use-function-as-variable-not-constant.js: Added.
(run_tests.x):
(run_tests):
* fast/js/script-tests/dfg-use-function-as-variable-with-closure.js: Added.
(run_tests.x):
(run_tests.y):
(run_tests):
* fast/js/script-tests/dfg-use-function-as-variable.js: Added.
(run_tests.x):
(run_tests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCorrect webkit.org blog RSS address.
bfulgham@apple.com [Wed, 17 Jul 2013 23:27:27 +0000 (23:27 +0000)]
Correct webkit.org blog RSS address.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Skip more failing WebGL tests on Mac.
achristensen@apple.com [Wed, 17 Jul 2013 23:04:16 +0000 (23:04 +0000)]
Unreviewed. Skip more failing WebGL tests on Mac.

* platform/mac-lion/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofullscreen/full-screen-iframe-with-max-width-height.html is flaky
slewis@apple.com [Wed, 17 Jul 2013 23:02:44 +0000 (23:02 +0000)]
fullscreen/full-screen-iframe-with-max-width-height.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=118820

Unreviewed.

Label a flaky test as flaky

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoJSStringCreateWithCFString should not convert the empty string into the NULL string
ggaren@apple.com [Wed, 17 Jul 2013 22:14:47 +0000 (22:14 +0000)]
JSStringCreateWithCFString should not convert the empty string into the NULL string
https://bugs.webkit.org/show_bug.cgi?id=118816

Reviewed by Sam Weinig.

* API/JSStringRef.cpp:
(JSStringCreateWithUTF8CString): Removed an extraneous comment, which
a previous version of the patch made incorrect.

* API/JSStringRefCF.cpp:
(JSStringCreateWithCFString): Don't convert the empty string into the
null string.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoOptimize RenderLayerCompositor's OverlapMap
simon.fraser@apple.com [Wed, 17 Jul 2013 22:08:35 +0000 (22:08 +0000)]
Optimize RenderLayerCompositor's OverlapMap
https://bugs.webkit.org/show_bug.cgi?id=118764

Reviewed by Tim Horton.

Overlap stack items can have RectLists with hundreds of rectangles.
This makes the linear search in OverlapMap::overlapsLayers() very slow.

Optimize by storing the bounding rect of the list of rects, and doing an early
check on that. This reduces time spent in RenderLayer::scrollTo() by 13% in some
content with lots of layers inside an overflow:scroll.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::OverlapMap::overlapsLayers):
(WebCore::RenderLayerCompositor::OverlapMap::popCompositingContainer):
(WebCore::RenderLayerCompositor::OverlapMap::RectList::append):
(WebCore::RenderLayerCompositor::OverlapMap::RectList::intersects):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago [Mac] Crashes in CFURLGetBytes under WebProcess::updateActivePages()
ap@apple.com [Wed, 17 Jul 2013 22:05:45 +0000 (22:05 +0000)]
    [Mac] Crashes in CFURLGetBytes under WebProcess::updateActivePages()
        https://bugs.webkit.org/show_bug.cgi?id=118814
        <rdar://problem/14173389>

        Reviewed by Brady Eidson.

        Speculative fix. It's unclear how we end up with an invalid URL when committing
        a load.

        * WebProcess/mac/WebProcessMac.mm: (WebKit::WebProcess::updateActivePages):
        Added a null check.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening after r152800.
roger_fong@apple.com [Wed, 17 Jul 2013 21:22:01 +0000 (21:22 +0000)]
Unreviewed gardening after r152800.
https://bugs.webkit.org/show_bug.cgi?id=118810.

CSS_SHAPES not yet supported on AppleWin port.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening.
roger_fong@apple.com [Wed, 17 Jul 2013 21:16:06 +0000 (21:16 +0000)]
Unreviewed gardening.
Skip some tests on AppleWin port that requires AVFoundation, since it does not support it yet.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rebaseline tests for AppleWin port after r152789.
roger_fong@apple.com [Wed, 17 Jul 2013 20:42:00 +0000 (20:42 +0000)]
Unreviewed. Rebaseline tests for AppleWin port after r152789.

* platform/win/editing/pasteboard/paste-noplugin-expected.txt: Added.
* platform/win/platform/win/plugins/draws-gradient-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Shapes][CSS Exclusions] Cleanup tests to reflect split between CSS Shapes and...
betravis@adobe.com [Wed, 17 Jul 2013 20:31:29 +0000 (20:31 +0000)]
[CSS Shapes][CSS Exclusions] Cleanup tests to reflect split between CSS Shapes and CSS Exclusions
https://bugs.webkit.org/show_bug.cgi?id=117164

Reviewed by Alexandru Chiculita.

Moving shapes tests from the fast/exclusions directory to the new fast/shapes directory.
In addition, some parsing tests which included both exclusions and shapes properties
have been split in order for each piece of functionality to sit within its own directory.

* fast/exclusions/parsing/script-tests/parsing-test-utils.js:
* fast/shapes/css-shapes-disabled-expected.txt: Added.
* fast/shapes/css-shapes-disabled.html: Added.
* fast/shapes/css-shapes-enabled-expected.txt: Added.
* fast/shapes/css-shapes-enabled.html: Added.
* fast/shapes/parsing/parsing-shape-inside-expected.txt: Added.
* fast/shapes/parsing/parsing-shape-inside.html: Added.
* fast/shapes/parsing/parsing-shape-lengths-expected.txt: Added.
* fast/shapes/parsing/parsing-shape-lengths.html: Added.
* fast/shapes/parsing/parsing-shape-margin-expected.txt: Added.
* fast/shapes/parsing/parsing-shape-margin.html: Added.
* fast/shapes/parsing/parsing-shape-outside-expected.txt: Added.
* fast/shapes/parsing/parsing-shape-outside.html: Added.
* fast/shapes/parsing/parsing-shape-padding-expected.txt: Added.
* fast/shapes/parsing/parsing-shape-padding.html: Added.
* fast/shapes/parsing/script-tests/parsing-shape-inside.js: Added.
* fast/shapes/parsing/script-tests/parsing-shape-lengths.js: Added.
* fast/shapes/parsing/script-tests/parsing-shape-margin.js: Added.
* fast/shapes/parsing/script-tests/parsing-shape-outside.js: Added.
* fast/shapes/parsing/script-tests/parsing-shape-padding.js: Added.
* fast/shapes/parsing/script-tests/parsing-test-utils.js: Added.
* fast/shapes/resources/multi-segment-polygon.js: Added.
* fast/shapes/resources/rounded-rectangle.js: Added.
* fast/shapes/resources/simple-polygon.js: Added.
* fast/shapes/resources/simple-rectangle.js: Added.
* fast/shapes/resources/subpixel-utils.js: Added.
* fast/shapes/shape-inside/shape-inside-animation-expected.txt: Added.
* fast/shapes/shape-inside/shape-inside-animation.html: Added.
* fast/shapes/shape-inside/shape-inside-bottom-edge-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-bottom-edge.html: Added.
* fast/shapes/shape-inside/shape-inside-box-sizing-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-box-sizing.html: Added.
* fast/shapes/shape-inside/shape-inside-circle-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-circle-padding-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-circle-padding.html: Added.
* fast/shapes/shape-inside/shape-inside-circle.html: Added.
* fast/shapes/shape-inside/shape-inside-coincident-vertices-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-coincident-vertices.html: Added.
* fast/shapes/shape-inside/shape-inside-collinear-vertices-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-collinear-vertices.html: Added.
* fast/shapes/shape-inside/shape-inside-counterclockwise-polygon-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-counterclockwise-polygon.html: Added.
* fast/shapes/shape-inside/shape-inside-dynamic-nested-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-dynamic-nested.html: Added.
* fast/shapes/shape-inside/shape-inside-dynamic-shape-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-dynamic-shape.html: Added.
* fast/shapes/shape-inside/shape-inside-dynamic-text-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-dynamic-text.html: Added.
* fast/shapes/shape-inside/shape-inside-ellipse-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-ellipse-padding-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-ellipse-padding.html: Added.
* fast/shapes/shape-inside/shape-inside-ellipse.html: Added.
* fast/shapes/shape-inside/shape-inside-empty-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-empty-segments-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-empty-segments.html: Added.
* fast/shapes/shape-inside/shape-inside-empty.html: Added.
* fast/shapes/shape-inside/shape-inside-first-fit-001-horizontal-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-first-fit-001-horizontal.html: Added.
* fast/shapes/shape-inside/shape-inside-first-fit-001-vertical-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-first-fit-001-vertical.html: Added.
* fast/shapes/shape-inside/shape-inside-first-fit-002-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-first-fit-002.html: Added.
* fast/shapes/shape-inside/shape-inside-first-fit-003-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-first-fit-003.html: Added.
* fast/shapes/shape-inside/shape-inside-first-fit-004-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-first-fit-004.html: Added.
* fast/shapes/shape-inside/shape-inside-first-fit-reflex-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-first-fit-reflex.html: Added.
* fast/shapes/shape-inside/shape-inside-floats-simple-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-floats-simple.html: Added.
* fast/shapes/shape-inside/shape-inside-inline-elements-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-inline-elements.html: Added.
* fast/shapes/shape-inside/shape-inside-multiple-blocks-dynamic-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-multiple-blocks-dynamic.html: Added.
* fast/shapes/shape-inside/shape-inside-multiple-blocks-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-multiple-blocks-vertical-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-multiple-blocks-vertical.html: Added.
* fast/shapes/shape-inside/shape-inside-multiple-blocks.html: Added.
* fast/shapes/shape-inside/shape-inside-multiple-segments-001-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-multiple-segments-001.html: Added.
* fast/shapes/shape-inside/shape-inside-multiple-segments-002-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-multiple-segments-002.html: Added.
* fast/shapes/shape-inside/shape-inside-multiple-segments-003-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-multiple-segments-003.html: Added.
* fast/shapes/shape-inside/shape-inside-multiple-segments-004-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-multiple-segments-004.html: Added.
* fast/shapes/shape-inside/shape-inside-on-nested-container-with-unresolved-height-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-on-nested-container-with-unresolved-height.html: Added.
* fast/shapes/shape-inside/shape-inside-outside-shape-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-outside-shape.html: Added.
* fast/shapes/shape-inside/shape-inside-overflow-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-overflow-fixed-dimensions-block-content-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-overflow-fixed-dimensions-block-content.html: Added.
* fast/shapes/shape-inside/shape-inside-overflow-fixed-dimensions-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-overflow-fixed-dimensions.html: Added.
* fast/shapes/shape-inside/shape-inside-overflow.html: Added.
* fast/shapes/shape-inside/shape-inside-partial-fill-001-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-partial-fill-001.html: Added.
* fast/shapes/shape-inside/shape-inside-partial-fill-002-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-partial-fill-002.html: Added.
* fast/shapes/shape-inside/shape-inside-percentage-auto-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-percentage-auto.html: Added.
* fast/shapes/shape-inside/shape-inside-percentage-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-percentage.html: Added.
* fast/shapes/shape-inside/shape-inside-polygon-layout-expected.txt: Added.
* fast/shapes/shape-inside/shape-inside-polygon-layout.html: Added.
* fast/shapes/shape-inside/shape-inside-polygon-padding-001-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-polygon-padding-001.html: Added.
* fast/shapes/shape-inside/shape-inside-polygon-padding-002-expected.txt: Added.
* fast/shapes/shape-inside/shape-inside-polygon-padding-002.html: Added.
* fast/shapes/shape-inside/shape-inside-polygon-padding-003-expected.txt: Added.
* fast/shapes/shape-inside/shape-inside-polygon-padding-003.html: Added.
* fast/shapes/shape-inside/shape-inside-polygon-rectangle-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-polygon-rectangle.html: Added.
* fast/shapes/shape-inside/shape-inside-polygon-zoom-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-polygon-zoom.html: Added.
* fast/shapes/shape-inside/shape-inside-rectangle-padding-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-rectangle-padding.html: Added.
* fast/shapes/shape-inside/shape-inside-rectilinear-polygon-001-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-rectilinear-polygon-001.html: Added.
* fast/shapes/shape-inside/shape-inside-rectilinear-polygon-002-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-rectilinear-polygon-002.html: Added.
* fast/shapes/shape-inside/shape-inside-rectilinear-polygon-003-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-rectilinear-polygon-003.html: Added.
* fast/shapes/shape-inside/shape-inside-rectilinear-polygon-004-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-rectilinear-polygon-004.html: Added.
* fast/shapes/shape-inside/shape-inside-recursive-layout-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-recursive-layout.html: Added.
* fast/shapes/shape-inside/shape-inside-regular-polygon16-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-regular-polygon16.html: Added.
* fast/shapes/shape-inside/shape-inside-regular-polygon8-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-regular-polygon8.html: Added.
* fast/shapes/shape-inside/shape-inside-rounded-rectangle-001-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-rounded-rectangle-001.html: Added.
* fast/shapes/shape-inside/shape-inside-rounded-rectangle-002-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-rounded-rectangle-002.html: Added.
* fast/shapes/shape-inside/shape-inside-rounded-rectangle-003-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-rounded-rectangle-003.html: Added.
* fast/shapes/shape-inside/shape-inside-rounded-rectangle-004-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-rounded-rectangle-004.html: Added.
* fast/shapes/shape-inside/shape-inside-rounded-rectangle-fit-001-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-rounded-rectangle-fit-001.html: Added.
* fast/shapes/shape-inside/shape-inside-rounded-rectangle-fit-002-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-rounded-rectangle-fit-002.html: Added.
* fast/shapes/shape-inside/shape-inside-rounded-rectangle-fit-003-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-rounded-rectangle-fit-003.html: Added.
* fast/shapes/shape-inside/shape-inside-rounded-rectangle-large-radius-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-rounded-rectangle-large-radius.html: Added.
* fast/shapes/shape-inside/shape-inside-rounded-rectangle-padding-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-rounded-rectangle-padding.html: Added.
* fast/shapes/shape-inside/shape-inside-shape-logical-top-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-shape-logical-top.html: Added.
* fast/shapes/shape-inside/shape-inside-sibling-block-dimension-change-needs-relayout-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-sibling-block-dimension-change-needs-relayout.html: Added.
* fast/shapes/shape-inside/shape-inside-simple-polygon-001-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-simple-polygon-001.html: Added.
* fast/shapes/shape-inside/shape-inside-simple-polygon-002-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-simple-polygon-002.html: Added.
* fast/shapes/shape-inside/shape-inside-simple-polygon-003-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-simple-polygon-003.html: Added.
* fast/shapes/shape-inside/shape-inside-simple-polygon-004-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-simple-polygon-004.html: Added.
* fast/shapes/shape-inside/shape-inside-subsequent-blocks-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-subsequent-blocks.html: Added.
* fast/shapes/shape-inside/shape-inside-text-align-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-text-align.html: Added.
* fast/shapes/shape-inside/shape-inside-text-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-text.html: Added.
* fast/shapes/shape-inside/shape-inside-vertical-text-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-vertical-text.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-diamond-margin-polygon-expected.txt: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-diamond-margin-polygon.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-margin-bottom-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-margin-bottom.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-margin-left-expected.txt: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-margin-left.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-margin-right-expected.txt: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-margin-right.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-left-margin-polygon-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-left-margin-polygon.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-right-margin-polygon-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-right-margin-polygon.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-rounded-rectangle-large-radius-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-rounded-rectangle-large-radius.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-simple-circle-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-simple-circle.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-simple-ellipse-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-simple-ellipse.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-simple-inset-rectangle-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-simple-inset-rectangle-percentage-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-simple-inset-rectangle-percentage.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-simple-inset-rectangle.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-simple-polygon-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-simple-polygon.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-simple-rectangle-horizontal-multiple-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-simple-rectangle-horizontal-multiple.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-simple-rectangle-percentage-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-simple-rectangle-percentage.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-simple-rounded-inset-rectangle-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-simple-rounded-inset-rectangle.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-simple-rounded-rectangle-001-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-simple-rounded-rectangle-001.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-simple-rounded-rectangle-002-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-simple-rounded-rectangle-002.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-simple-rounded-rectangle-003-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-simple-rounded-rectangle-003.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-stacked-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-stacked.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r152786 and r152789.
commit-queue@webkit.org [Wed, 17 Jul 2013 19:31:39 +0000 (19:31 +0000)]
Unreviewed, rolling out r152786 and r152789.
http://trac.webkit.org/changeset/152786
http://trac.webkit.org/changeset/152789
https://bugs.webkit.org/show_bug.cgi?id=118807

overly platform specific and dirty API (and Sam says no)
(Requested by thorton on #webkit).

* WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:
* WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.h:
* WebProcess/WebPage/PageOverlay.cpp:
* WebProcess/WebPage/PageOverlay.h:
* WebProcess/WebPage/WebPage.cpp:
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Shapes] Port refactoring of shape-outside code from Blink
commit-queue@webkit.org [Wed, 17 Jul 2013 19:24:50 +0000 (19:24 +0000)]
[CSS Shapes] Port refactoring of shape-outside code from Blink
https://bugs.webkit.org/show_bug.cgi?id=118757

Patch by Bem Jones-Bey <bjonesbe@adobe.com> on 2013-07-17
Reviewed by Dean Jackson.

Refactor the left and right offset methods to reduce the number of
arguments by splitting the methods into smaller methods. This
refactoring was requested as part of porting support for stacked
floats with shape-outside to Blink.

Also add a variable when calling computeSegmentsForLine to make it
more readable and easier to follow the coordinate system change.

No new tests, no behavior change.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeLogicalLocationForFloat): Update to use
    the refactored IgnoringShapeOutside methods.
(WebCore::RenderBlock::logicalLeftFloatOffsetForLine): New method to
    compute the offset contributed by left floats.
(WebCore::RenderBlock::adjustLogicalLeftOffsetForLine): New method to
    compute misc adjustments to the left offset.
(WebCore::RenderBlock::logicalRightFloatOffsetForLine): New method to
    compute the offset contributed by right floats.
(WebCore::RenderBlock::adjustLogicalRightOffsetForLine): New method to
    compute misc adjustments to the right offset.
* rendering/RenderBlock.h:
(WebCore::RenderBlock::logicalRightOffsetForLine): Implement original
    method in terms of the float offset computation method and the
    offset adjustment method. This method takes into account the
    shape-outside on any floats when computing the offset.
(WebCore::RenderBlock::logicalLeftOffsetForLine): Ditto.
(WebCore::RenderBlock::logicalRightOffsetForLineIgnoringShapeOutside):
    Compute the right offset as if there was no shape-outside on any
    of the floats.
(WebCore::RenderBlock::logicalLeftOffsetForLineIgnoringShapeOutside):
    Compute the left offset as if there was no shape-outside on any
    of the floats.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded): Update
    to use a variable to make the calls to computeSegmentsForLine more
    explicit about the coordinate system conversion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWrong linebox height, when block element parent has vertical-align property defined.
akling@apple.com [Wed, 17 Jul 2013 18:46:39 +0000 (18:46 +0000)]
Wrong linebox height, when block element parent has vertical-align property defined.
https://bugs.webkit.org/show_bug.cgi?id=118245

Patch by Zalan Bujtas <zalan@apple.com> on 2013-07-17
Reviewed by David Hyatt.

Do not push the current element to the next, when it is still considered empty, even with
some object(s) in front. Behave as if it was actually empty.
Inline elements like <span></span> generate such lines.

Source/WebCore:

Test: fast/css/empty-span-with-parent-div-and-vertical-align.html

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):

LayoutTests:

* fast/css/empty-span-with-parent-div-and-vertical-align-expected.html: Added.
* fast/css/empty-span-with-parent-div-and-vertical-align.html: Added.
* platform/mac/fast/lists/inlineBoxWrapperNullCheck-expected.png: Rebased.
* platform/mac/fast/lists/inlineBoxWrapperNullCheck-expected.txt: Rebased.
* platform/mac/tables/mozilla/marvin/backgr_index-expected.png: Rebased.
* platform/mac/tables/mozilla/marvin/backgr_index-expected.txt: Rebased.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r151535.
commit-queue@webkit.org [Wed, 17 Jul 2013 18:07:49 +0000 (18:07 +0000)]
Unreviewed, rolling out r151535.
http://trac.webkit.org/changeset/151535
https://bugs.webkit.org/show_bug.cgi?id=118804

Re-disable WinEWS tests (Requested by rfong on #webkit).

* Scripts/webkitpy/common/config/ews.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Skip failing WebGL tests.
achristensen@apple.com [Wed, 17 Jul 2013 17:59:30 +0000 (17:59 +0000)]
Unreviewed. Skip failing WebGL tests.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAX: VoiceOver not working with data detection page overlays
timothy_horton@apple.com [Wed, 17 Jul 2013 17:38:24 +0000 (17:38 +0000)]
AX: VoiceOver not working with data detection page overlays
https://bugs.webkit.org/show_bug.cgi?id=118680

Reviewed by Anders Carlsson.

Bump the API version after r152786.

* WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCSS selector list splitting should be by component, not by selector.
akling@apple.com [Wed, 17 Jul 2013 17:21:51 +0000 (17:21 +0000)]
CSS selector list splitting should be by component, not by selector.
<http://webkit.org/b/118761>
<rdar://problem/14421609>

Reviewed by Antti Koivisto.

Source/WebCore:

Test (amended): fast/css/rule-selector-overflow.html

* css/CSSSelectorList.h:
* css/CSSSelectorList.cpp:
(WebCore::CSSSelectorList::CSSSelectorList):
(WebCore::CSSSelectorList::componentCount):
* css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::setSelectorText):

    Renamed CSSSelectorList::length() to componentCount() and made it public.

* css/RuleSet.h:

    maximumSelectorCount => maximumSelectorComponentCount

* css/StyleRule.cpp:
(WebCore::StyleRule::splitIntoMultipleRulesWithMaximumSelectorComponentCount):

    Make the splits after accumulating 'maximumSelectorComponentCount' components.

* css/StyleRule.h:
* css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::parserAppendRule):

    splitIntoMultipleRulesWithMaximumSelectorCount => splitIntoMultipleRulesWithMaximumSelectorComponentCount

LayoutTests:

Added more cases to the already existing selector list splitting test.

* fast/css/rule-selector-overflow-expected.txt:
* fast/css/rule-selector-overflow.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoYouTube webcam capture (Flash Plug-in) in Safari can't see built-in camera
commit-queue@webkit.org [Wed, 17 Jul 2013 17:10:21 +0000 (17:10 +0000)]
YouTube webcam capture (Flash Plug-in) in Safari can't see built-in camera
https://bugs.webkit.org/show_bug.cgi?id=118787
<rdar://problem/14418799>

Patch by Simon Cooper <scooper@apple.com> on 2013-07-17
Reviewed by Alexey Proskuryakov.

Add support for built-in cameras, including the original iSight.

* Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb:
* Resources/PlugInSandboxProfiles/com.macromedia.Flash Player.plugin.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAX: VoiceOver not working with data detection page overlays
cfleizach@apple.com [Wed, 17 Jul 2013 16:44:43 +0000 (16:44 +0000)]
AX: VoiceOver not working with data detection page overlays
https://bugs.webkit.org/show_bug.cgi?id=118680

Reviewed by Tim Horton.

Expose API methods so that a client implementing data detectors is able to respond
to the needs of accessibility clients like VoiceOver.

* WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:
(PageOverlayClientImpl::supportsDataDetection):
(PageOverlayClientImpl::dataDetectorExistsAtPoint):
(PageOverlayClientImpl::dataDetectorCopyTypeAtPoint):
(PageOverlayClientImpl::showDataDetectorMenuAtPoint):
* WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.h:
* WebProcess/WebPage/PageOverlay.cpp:
(WebKit::PageOverlay::supportsDataDetection):
(WebKit::PageOverlay::dataDetectorExistsAtPoint):
(WebKit::PageOverlay::dataDetectorCopyTypeAtPoint):
(WebKit::PageOverlay::dataDetectorOpenMenuAtPoint):
* WebProcess/WebPage/PageOverlay.h:
(WebKit::PageOverlay::Client::supportsDataDetection):
(WebKit::PageOverlay::Client::dataDetectorExistsAtPoint):
(WebKit::PageOverlay::Client::dataDetectorCopyTypeAtPoint):
(WebKit::PageOverlay::Client::showDataDetectorMenuAtPoint):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::pageOverlayOpenDataDetectorMenuAtPoint):
(WebKit::WebPage::pageOverlayDataDetectorCopyTypeAtPoint):
(WebKit::WebPage::pageOverlayDataDetectorExistsAtPoint):
(WebKit::WebPage::pageOverlaySupportsDataDetection):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm:
(-[WKAccessibilityWebPageObject accessibilityParameterizedAttributeNames]):
(-[WKAccessibilityWebPageObject _convertScreenPointToWindow:]):
(-[WKAccessibilityWebPageObject accessibilityAttributeValue:forParameter:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Mac] REGRESSION(r152685): svg/custom/xlink-prefix-in-attributes.html failed unexpectedly
rwlbuis@webkit.org [Wed, 17 Jul 2013 16:40:11 +0000 (16:40 +0000)]
[Mac] REGRESSION(r152685): svg/custom/xlink-prefix-in-attributes.html failed unexpectedly
https://bugs.webkit.org/show_bug.cgi?id=118701

Reviewed by Ryosuke Niwa.

Source/WebCore:

Use the computed attribute prefix, otherwise href being in xlink namespace but not having any prefix
will cause outputting the xlink namespace in appendNamespace.

Patch fixes svg/custom/xlink-prefix-in-attributes.html.

* editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::appendAttribute):

LayoutTests:

* platform/mac/TestExpectations:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNaming convention on createInvalidParamError is incorrect.
commit-queue@webkit.org [Wed, 17 Jul 2013 16:26:52 +0000 (16:26 +0000)]
Naming convention on createInvalidParamError is incorrect.
https://bugs.webkit.org/show_bug.cgi?id=118756

Patch by Chris Curtis <chris_curtis@apple.com> on 2013-07-17
Reviewed by Geoffrey Garen.

Changed the naming of createInvalidParamError to createInvalidParameterError.
This corrects the naming convention for the function listed in the WebKit code styling.

* interpreter/Interpreter.cpp:
(JSC::loadVarargs):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
* runtime/CommonSlowPaths.h:
(JSC::CommonSlowPaths::opIn):
* runtime/ExceptionHelpers.cpp:
(JSC::createInvalidParameterError):
* runtime/ExceptionHelpers.h:
* runtime/JSObject.cpp:
(JSC::JSObject::hasInstance):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRegression: columnheader/rowheader roles not exposed correctly
cfleizach@apple.com [Wed, 17 Jul 2013 16:15:35 +0000 (16:15 +0000)]
Regression: columnheader/rowheader roles not exposed correctly
https://bugs.webkit.org/show_bug.cgi?id=113628

Reviewed by Tim Horton.

Source/WebCore:

When we determine the row and column headers we look at the ARIA role being returned, but
since TableCell overrides the determineAccessibilityRole method, the ARIA role is never set.

Test: platform/mac/accessibility/aria-columnrowheaders.html

* accessibility/AccessibilityTableCell.cpp:
(WebCore::AccessibilityTableCell::determineAccessibilityRole):

LayoutTests:

* platform/mac/accessibility/aria-columnrowheaders-expected.txt: Added.
* platform/mac/accessibility/aria-columnrowheaders.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Make DRT obbey testRunner's addURLToRedirect
commit-queue@webkit.org [Wed, 17 Jul 2013 15:34:44 +0000 (15:34 +0000)]
[GTK] Make DRT obbey testRunner's addURLToRedirect
https://bugs.webkit.org/show_bug.cgi?id=118239

Patch by Simon Pena <simon.pena@samsung.com> on 2013-07-17
Reviewed by Gustavo Noronha Silva.

Tools:

Support testRunner's addURLToRedirect in GTK's DRT, so it redirects
to the proper URI when indicated.

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(willSendRequestCallback):

LayoutTests:

Unskip http/tests/loading/cross-origin-XHR-willLoadRequest.html now that DRT obbeys
testRunner's addURLToRedirect.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewd gardening. Rebase and skip failing tests.
zarvai@inf.u-szeged.hu [Wed, 17 Jul 2013 13:54:36 +0000 (13:54 +0000)]
[Qt] Unreviewd gardening. Rebase and skip failing tests.

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-07-17

* platform/qt-5.0-wk2/TestExpectations:
* platform/qt-5.0-wk2/fast/replaced/border-radius-clip-expected.png: Added.
* platform/qt-5.0-wk2/fast/replaced/border-radius-clip-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGet rid of SVGPoint special case from the bindings generator
ch.dumez@sisa.samsung.com [Wed, 17 Jul 2013 10:27:51 +0000 (10:27 +0000)]
Get rid of SVGPoint special case from the bindings generator
https://bugs.webkit.org/show_bug.cgi?id=118783

Reviewed by Kentaro Hara.

Get rid of SVGPoint special case from the bindings generator by adding a
new SVGPoint.h header that contains a typedef to FloatPoint.

Also use SVGPoint type in the implementation API for consistency with
the IDL.

No new tests, no behavior change.

* bindings/scripts/CodeGenerator.pm:
(SkipIncludeHeader):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjMutablePoint):
(WebCore::jsTestObjImmutablePoint):
(WebCore::setJSTestObjMutablePoint):
(WebCore::setJSTestObjImmutablePoint):
(WebCore::jsTestObjPrototypeFunctionMutablePointFunction):
(WebCore::jsTestObjPrototypeFunctionImmutablePointFunction):
* bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::jsTestTypedefsPrototypeFunctionImmutablePointFunction):
* bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj mutablePoint]):
(-[DOMTestObj immutablePoint]):
(-[DOMTestObj mutablePointFunction]):
(-[DOMTestObj immutablePointFunction]):
* bindings/scripts/test/ObjC/DOMTestTypedefs.mm:
(-[DOMTestTypedefs immutablePointFunction]):
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::buildLocalToBorderBoxTransform):
* rendering/svg/SVGTextQuery.cpp:
(WebCore::SVGTextQuery::startPositionOfCharacter):
(WebCore::SVGTextQuery::endPositionOfCharacter):
(WebCore::SVGTextQuery::characterNumberAtPosition):
* rendering/svg/SVGTextQuery.h:
* svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::getPointAtLength):
* svg/SVGPathElement.h:
* svg/SVGPathTraversalStateBuilder.cpp:
(WebCore::SVGPathTraversalStateBuilder::currentPoint):
* svg/SVGPathTraversalStateBuilder.h:
* svg/SVGPathUtilities.cpp:
(WebCore::getPointAtLengthOfSVGPathByteStream):
* svg/SVGPathUtilities.h:
* svg/SVGPoint.h: Added.
* svg/SVGPointList.cpp:
(WebCore::SVGPointList::valueAsString):
* svg/SVGPointList.h:
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::createSVGPoint):
* svg/SVGSVGElement.h:
* svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::getStartPositionOfChar):
(WebCore::SVGTextContentElement::getEndPositionOfChar):
(WebCore::SVGTextContentElement::getCharNumAtPosition):
* svg/SVGTextContentElement.h:
* svg/SVGZoomEvent.cpp:
(WebCore::SVGZoomEvent::previousTranslate):
(WebCore::SVGZoomEvent::newTranslate):
* svg/SVGZoomEvent.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd a new find-resolved-bugs command to webkit-patch.
ossy@webkit.org [Wed, 17 Jul 2013 10:11:20 +0000 (10:11 +0000)]
Add a new find-resolved-bugs command to webkit-patch.
https://bugs.webkit.org/show_bug.cgi?id=118060

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-07-17
Reviewed by Csaba Osztrogonác.

* Scripts/webkitpy/tool/commands/queries.py:
(PrintBaselines._platform_for_path):
(FindResolvedBugs):
(FindResolvedBugs.execute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GStreamer] webkitwebsrc: use SubResourceLoader
carlosgc@webkit.org [Wed, 17 Jul 2013 09:39:21 +0000 (09:39 +0000)]
[GStreamer] webkitwebsrc: use SubResourceLoader
https://bugs.webkit.org/show_bug.cgi?id=73743

Reviewed by Philippe Normand.

* GNUmakefile.list.am: Add new files to compilation.
* PlatformEfl.cmake: Ditto.
* PlatformGTK.cmake: Ditto.
* loader/SubresourceLoader.h: Add getOrCreateReadBuffer() when
using SOUP.
* loader/cache/CachedRawResource.h:
* loader/cache/CachedRawResourceClient.h:
(WebCore::CachedRawResourceClient::getOrCreateReadBuffer): Added
to allow the client to allocate the read buffer.
* loader/cache/CachedResource.h:
(WebCore::CachedResource::getOrCreateReadBuffer):
* loader/soup/CachedRawResourceSoup.cpp: Added.
(WebCore::CachedRawResource::getOrCreateReadBuffer): Iterate the
clients until one returns a valid read buffer or return NULL to
fallback to the default read buffer.
* loader/soup/SubresourceLoaderSoup.cpp: Added.
(WebCore::SubresourceLoader::getOrCreateReadBuffer): Call
CachedResource::getOrCreateReadBuffer().
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(StreamingClient): Make this a CachedRawResourceClient.
(_WebKitWebSrcPrivate): Remove frame and resourceHandle and add a
cached resource handle.
(webKitWebSrcDispose): Clear the player pointer.
(webKitWebSrcStop): Remove the client from the cached resource.
(webKitWebSrcStart): Use CachedResourceLoader to schedule a
CachedRawResource load for the media without buffering the data.
(webKitWebSrcNeedDataMainCb): Call CachedResource::setDefersLoading.
(webKitWebSrcEnoughDataMainCb): Ditto.
(webKitWebSrcSetMediaPlayer): Simply update the player pointer.
(StreamingClient::responseReceived): Update to the
CachedRawResourceClient API.
(StreamingClient::dataReceived): Ditto.
(StreamingClient::getOrCreateReadBuffer): Ditto.
(StreamingClient::notifyFinished): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoReplace MathML pixel tests by reftests.
commit-queue@webkit.org [Wed, 17 Jul 2013 09:16:53 +0000 (09:16 +0000)]
Replace MathML pixel tests by reftests.
https://bugs.webkit.org/show_bug.cgi?id=118599

Patch by Frédéric Wang <fred.wang@free.fr> on 2013-07-17
Reviewed by Chris Fleizach.

- attributes.xhtml is replaced by attributes*.html

- underover.xhtml, under.xhtml, sub.xhtml, sup.xhtml, over.xhtml and subsup.xhtml are replaced by scripts*.html and bug*.html.

- tokenElements.xhtml is replaced by replaced tokenElements-mathvariant.html

* mathml/presentation/attributes-background-color-expected.html: Added.
* mathml/presentation/attributes-background-color.html: Added.
* mathml/presentation/attributes-display-expected.html: Added.
* mathml/presentation/attributes-display.html: Added.
* mathml/presentation/attributes-mathsize-expected.html: Added.
* mathml/presentation/attributes-mathsize.html: Added.
* mathml/presentation/attributes-mathvariant-expected.html: Added.
* mathml/presentation/attributes-mathvariant.html: Added.
* mathml/presentation/attributes-style-expected-mismatch.html: Added.
* mathml/presentation/attributes-style.html: Added.
* mathml/presentation/attributes.xhtml: Removed.
* mathml/presentation/bug95015-expected.html: Added.
* mathml/presentation/bug95015.html: Added.
* mathml/presentation/bug95404-expected.html: Added.
* mathml/presentation/bug95404.html: Added.
* mathml/presentation/bug97990-expected.html: Added.
* mathml/presentation/bug97990.html: Added.
* mathml/presentation/over.xhtml: Removed.
* mathml/presentation/scripts-font-size-expected-mismatch.html: Added.
* mathml/presentation/scripts-font-size.html: Added.
* mathml/presentation/scripts-height-expected.html: Added.
* mathml/presentation/scripts-height.html: Added.
* mathml/presentation/scripts-mrow-expected.html: Added.
* mathml/presentation/scripts-mrow.html: Added.
* mathml/presentation/scripts-subsup-expected.html: Added.
* mathml/presentation/scripts-subsup.html: Added.
* mathml/presentation/scripts-underover-expected.html: Added.
* mathml/presentation/scripts-underover.html: Added.
* mathml/presentation/scripts-width-expected.html: Added.
* mathml/presentation/scripts-width.html: Added.
* mathml/presentation/sub.xhtml: Removed.
* mathml/presentation/subsup.xhtml: Removed.
* mathml/presentation/sup.xhtml: Removed.
* mathml/presentation/tokenElements-mathvariant-expected.html: Added.
* mathml/presentation/tokenElements-mathvariant.html: Added.
* mathml/presentation/tokenElements.xhtml: Removed.
* mathml/presentation/under.xhtml: Removed.
* mathml/presentation/underover.xhtml: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] EWK2CookieManagerTest should be defined by inheriting from EWK2UnitTestBase.
commit-queue@webkit.org [Wed, 17 Jul 2013 08:47:54 +0000 (08:47 +0000)]
[EFL][WK2] EWK2CookieManagerTest should be defined by inheriting from EWK2UnitTestBase.
https://bugs.webkit.org/show_bug.cgi?id=118721

Patch by Dong-Gwan Kim <donggwan.kim@samsung.com> on 2013-07-17
Reviewed by Christophe Dumez.

It should be defined as relevant test class specific to each test file for more readability.
It could be helpful to remove unnecessary static methods.

* UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:
(compareHostNames):
(onCookiesChanged):
(EWK2CookieManagerTest::getAcceptPolicy):
(EWK2CookieManagerTest::getHostnamesWithCookies):
(EWK2CookieManagerTest::freeHostNames):
(EWK2CookieManagerTest::countHostnamesWithCookies):
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove unused member variable m_domURL from WorkerGlobalScope
kseo@webkit.org [Wed, 17 Jul 2013 08:40:12 +0000 (08:40 +0000)]
Remove unused member variable m_domURL from WorkerGlobalScope
https://bugs.webkit.org/show_bug.cgi?id=118784

Reviewed by Christophe Dumez.

WorkerContext::webkitURL() was removed in r107082, and this was the
only place where the member variable |m_domURL| in WorkerContext was
mutated. This variable is no longer needed and so it should be removed.

No behavior change.

* workers/WorkerGlobalScope.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CMake] Undefined references should be detected at build time
kbalazs@webkit.org [Wed, 17 Jul 2013 08:37:03 +0000 (08:37 +0000)]
[CMake] Undefined references should be detected at build time
https://bugs.webkit.org/show_bug.cgi?id=110236

Patch by Balazs Kelemen <kbalazs@webkit.org> on 2013-07-16
Reviewed by Christophe Dumez.

.:

Pass the --no-undefined argument to the linker on platforms where it is available.

* Source/cmake/OptionsCommon.cmake:

Source/WebKit:

Add library dependencies that were not defined explicitly before.

* CMakeLists.txt:
* PlatformEfl.cmake:

Source/WebKit2:

Add library dependencies that were not defined explicitly before.

* CMakeLists.txt:
* PlatformEfl.cmake:

Tools:

Add library dependencies that were not defined explicitly before.

* DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
* TestWebKitAPI/CMakeLists.txt:
* WebKitTestRunner/CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] EWK2WindowFeaturesTest should be defined by inheriting from EWK2UnitTestBase.
commit-queue@webkit.org [Wed, 17 Jul 2013 07:27:41 +0000 (07:27 +0000)]
[EFL][WK2] EWK2WindowFeaturesTest should be defined by inheriting from EWK2UnitTestBase.
https://bugs.webkit.org/show_bug.cgi?id=118780

Patch by Dong-Gwan Kim <donggwan.kim@samsung.com> on 2013-07-17
Reviewed by Christophe Dumez.

It should be defined as relevant test class specific to each test file for more readability.
It could be helpful to remove unnecessary static methods.

* UIProcess/API/efl/tests/test_ewk2_window_features.cpp:
(EWK2WindowFeaturesTest::createDefaultWindow):
(EWK2WindowFeaturesTest::createWindow):
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Shapes] Remove setCSSShapesEnabled(true) from shape-inside-on-first-region-inlin...
zoltan@webkit.org [Wed, 17 Jul 2013 07:26:27 +0000 (07:26 +0000)]
[CSS Shapes] Remove setCSSShapesEnabled(true) from shape-inside-on-first-region-inline-content-expected.html since it's no longer using shapes
https://bugs.webkit.org/show_bug.cgi?id=117952

Reviewed by Alexandru Chiculita.

* fast/regions/shape-inside/shape-inside-on-first-region-inline-content-expected.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] EWK2ViewTest should be defined by inheriting from EWK2UnitTestBase.
commit-queue@webkit.org [Wed, 17 Jul 2013 07:25:04 +0000 (07:25 +0000)]
[EFL][WK2] EWK2ViewTest should be defined by inheriting from EWK2UnitTestBase.
https://bugs.webkit.org/show_bug.cgi?id=118779

Patch by Dong-Gwan Kim <donggwan.kim@samsung.com> on 2013-07-17
Reviewed by Christophe Dumez.

It should be defined as relevant test class specific to each test file for more readability.
It could be helpful to remove unnecessary static methods.

* UIProcess/API/efl/tests/test_ewk2_view.cpp:
(EWK2ViewTest::onLoadFinishedForRedirection):
(EWK2ViewTest::serverCallbackNavigation):
(EWK2ViewTest::onFormAboutToBeSubmitted):
(EWK2ViewTest::fullScreenCallback):
(EWK2ViewTest::fullScreenExitCallback):
(EWK2ViewTest::checkAlert):
(EWK2ViewTest::checkConfirm):
(EWK2ViewTest::checkPrompt):
(EWK2ViewTest::onTextFound):
(EWK2ViewTest::onVibrate):
(EWK2ViewTest::onCancelVibration):
(EWK2ViewTest::loadVibrationHTMLString):
(EWK2ViewTest::onContentsSizeChangedPortrait):
(EWK2ViewTest::onContentsSizeChangedLandscape):
(EWK2ViewTest::PageContentsAsMHTMLCallback):
(EWK2ViewTest::PageContentsAsStringCallback):
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] EWK2StorageManagerTest should be defined by inheriting from EWK2UnitTestBase.
commit-queue@webkit.org [Wed, 17 Jul 2013 07:23:25 +0000 (07:23 +0000)]
[EFL][WK2] EWK2StorageManagerTest should be defined by inheriting from EWK2UnitTestBase.
https://bugs.webkit.org/show_bug.cgi?id=118777

Patch by Dong-Gwan Kim <donggwan.kim@samsung.com> on 2013-07-17
Reviewed by Christophe Dumez.

It should be defined as relevant test class specific to each test file for more readability.
It could be helpful to remove unnecessary static methods.

* UIProcess/API/efl/tests/test_ewk2_storage_manager.cpp:
(EWK2StorageManagerTest::OriginData::OriginData):
(EWK2StorageManagerTest::getStorageOriginsCallback):
(EWK2StorageManagerTest::timerCallback):
(EWK2StorageManagerTest::checkOrigin):
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] EWK2PopupMenuTest should be defined by inheriting from EWK2UnitTestBase.
commit-queue@webkit.org [Wed, 17 Jul 2013 07:22:43 +0000 (07:22 +0000)]
[EFL][WK2] EWK2PopupMenuTest should be defined by inheriting from EWK2UnitTestBase.
https://bugs.webkit.org/show_bug.cgi?id=118775

Patch by Dong-Gwan Kim <donggwan.kim@samsung.com> on 2013-07-17
Reviewed by Christophe Dumez.

It should be defined as relevant test class specific to each test file for more readability.
It could be helpful to remove unnecessary static methods.

* UIProcess/API/efl/tests/test_ewk2_popup_menu.cpp:
(EWK2PopupMenuTest::checkBasicPopupMenuItem):
(EWK2PopupMenuTest::selectItemAfterDelayed):
(EWK2PopupMenuTest::showPopupMenu):
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoASSERTION FAILED: layoutState->m_renderer == this in WebCore::RenderBlock::offsetFrom...
commit-queue@webkit.org [Wed, 17 Jul 2013 07:20:34 +0000 (07:20 +0000)]
ASSERTION FAILED: layoutState->m_renderer == this in WebCore::RenderBlock::offsetFromLogicalTopOfFirstPage
https://bugs.webkit.org/show_bug.cgi?id=118587

Patch by Mihai Maerean <mmaerean@adobe.com> on 2013-07-17
Reviewed by David Hyatt.

Source/WebCore:

The fix consists in not calling containingBlockLogicalHeightForPositioned for flow threads (in
RenderBox::availableLogicalHeightUsing) as it gets to handle the RenderView as it would have been flowed into
the flow thread.

Test: fast/regions/crash-div-outside-body-vertical-rl.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::availableLogicalHeightUsing):

LayoutTests:

* fast/regions/crash-div-outside-body-vertical-rl-expected.html: Added.
* fast/regions/crash-div-outside-body-vertical-rl.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] EWK2FileChooserRequestTest should be defined by inheriting from EWK2UnitTe...
commit-queue@webkit.org [Wed, 17 Jul 2013 07:19:15 +0000 (07:19 +0000)]
[EFL][WK2] EWK2FileChooserRequestTest should be defined by inheriting from EWK2UnitTestBase.
https://bugs.webkit.org/show_bug.cgi?id=118773

Patch by Dong-Gwan Kim <donggwan.kim@samsung.com> on 2013-07-17
Reviewed by Christophe Dumez.

It should be defined as relevant test class specific to each test file for more readability.
It could be helpful to remove unnecessary static methods.

* UIProcess/API/efl/tests/test_ewk2_file_chooser_request.cpp:
(EWK2FileChooserRequestTest::onFileChooserRequest):
(EWK2FileChooserRequestTest::compareStrings):
(EWK2FileChooserRequestTest::freeStringList):
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] EWK2FaviconDatabaseTest should be defined by inheriting from EWK2UnitTestBase.
commit-queue@webkit.org [Wed, 17 Jul 2013 07:18:31 +0000 (07:18 +0000)]
[EFL][WK2] EWK2FaviconDatabaseTest should be defined by inheriting from EWK2UnitTestBase.
https://bugs.webkit.org/show_bug.cgi?id=118772

Patch by Dong-Gwan Kim <donggwan.kim@samsung.com> on 2013-07-17
Reviewed by Christophe Dumez.

It should be defined as relevant test class specific to each test file for more readability.
It could be helpful to remove unnecessary static methods.

* UIProcess/API/efl/tests/test_ewk2_favicon_database.cpp:
(EWK2FaviconDatabaseTest::serverCallback):
(EWK2FaviconDatabaseTest::requestFaviconData):
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] EWK2EinaSharedStringTest should be defined by inheriting from EWK2UnitTest...
commit-queue@webkit.org [Wed, 17 Jul 2013 07:16:42 +0000 (07:16 +0000)]
[EFL][WK2] EWK2EinaSharedStringTest should be defined by inheriting from EWK2UnitTestBase.
https://bugs.webkit.org/show_bug.cgi?id=118771

Patch by Dong-Gwan Kim <donggwan.kim@samsung.com> on 2013-07-17
Reviewed by Christophe Dumez.

It should be defined as relevant test class specific to each test file for more readability.
It could be helpful to remove unnecessary static methods.

* UIProcess/API/efl/tests/test_ewk2_eina_shared_string.cpp:
(EWK2EinaSharedStringTest::checkString):
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] EWK2DownloadJobTest should be defined by inheriting from EWK2UnitTestBase.
commit-queue@webkit.org [Wed, 17 Jul 2013 07:15:09 +0000 (07:15 +0000)]
[EFL][WK2] EWK2DownloadJobTest should be defined by inheriting from EWK2UnitTestBase.
https://bugs.webkit.org/show_bug.cgi?id=118769

Patch by Dong-Gwan Kim <donggwan.kim@samsung.com> on 2013-07-17
Reviewed by Christophe Dumez.

It should be defined as relevant test class specific to each test file for more readability.
It could be helpful to remove unnecessary static methods.

* UIProcess/API/efl/tests/test_ewk2_download_job.cpp:
(EWK2DownloadJobTest::fileExists):
(EWK2DownloadJobTest::serverCallback):
(EWK2DownloadJobTest::on_download_requested):
(EWK2DownloadJobTest::on_download_cancelled):
(EWK2DownloadJobTest::on_download_failed):
(EWK2DownloadJobTest::on_download_finished):
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse toHTMLMediaElement
kangil.han@samsung.com [Wed, 17 Jul 2013 07:12:11 +0000 (07:12 +0000)]
Use toHTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=118727

Reviewed by Ryosuke Niwa.

To avoid direct use of static_cast, this patch uses toHTMLMediaElement for code cleanup.

Source/WebCore:

* bindings/js/JSHTMLMediaElementCustom.cpp:
(WebCore::JSHTMLMediaElement::setController):
* html/HTMLMediaElement.h:
(WebCore::toHTMLMediaElement):
* html/HTMLSourceElement.cpp:
(WebCore::HTMLSourceElement::insertedInto):
(WebCore::HTMLSourceElement::removedFrom):
* html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::removedFrom):
(WebCore::HTMLTrackElement::mediaElement):
* html/shadow/MediaControlElementTypes.cpp:
(WebCore::toParentMediaElement):
* loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::loadMediaPlayerProxyPlugin):
* page/FrameView.cpp:
(WebCore::FrameView::updateWidget):
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::paintMediaFullscreenButton):
(WebCore::RenderThemeEfl::paintMediaMuteButton):
(WebCore::RenderThemeEfl::paintMediaToggleClosedCaptionsButton):
* platform/graphics/wince/MediaPlayerProxy.cpp:
(WebCore::WebMediaPlayerProxy::initEngine):
(WebCore::WebMediaPlayerProxy::element):
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::getMediaElementFromRenderObject):
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::mediaElement):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForVideo):
* rendering/RenderMedia.cpp:
(WebCore::RenderMedia::mediaElement):
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMediaSliderTrack):
* rendering/RenderThemeWinCE.cpp:
(WebCore::mediaElementParent):
* testing/Internals.cpp:
(WebCore::Internals::simulateAudioInterruption):

Source/WebKit/blackberry:

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::webContext):
(BlackBerry::WebKit::WebPage::notifyFullScreenVideoExited):
(BlackBerry::WebKit::WebPagePrivate::enterFullscreenForNode):
(BlackBerry::WebKit::WebPagePrivate::exitFullscreenForNode):

Source/WebKit/gtk:

* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::enterFullscreenForNode):
(WebKit::ChromeClient::exitFullscreenForNode):
(WebKit::ChromeClient::enterFullScreenForElement):
(WebKit::ChromeClient::exitFullScreenForElement):

Source/WebKit/mac:

* WebView/WebView.mm:
(-[WebView _enterFullscreenForNode:WebCore::]):

Source/WebKit/win:

* WebView.cpp:
(WebView::enterFullscreenForNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] EWK2AuthRequestTest should be defined by inheriting from EWK2UnitTestBase.
commit-queue@webkit.org [Wed, 17 Jul 2013 07:11:19 +0000 (07:11 +0000)]
[EFL][WK2] EWK2AuthRequestTest should be defined by inheriting from EWK2UnitTestBase.
https://bugs.webkit.org/show_bug.cgi?id=118766

Patch by Dong-Gwan Kim <donggwan.kim@samsung.com> on 2013-07-17
Reviewed by Christophe Dumez.

It should be defined as relevant test class specific to each test file for more readability.
It could be helpful to remove unnecessary static methods.

* UIProcess/API/efl/tests/test_ewk2_auth_request.cpp:
(EWK2AuthRequestTest::serverCallback):
(EWK2AuthRequestTest::onAuthenticationRequest):
(EWK2AuthRequestTest::onLoadFinished):
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] EWK2ContextMenuTest should be defined by inheriting from EWK2UnitTestBase.
commit-queue@webkit.org [Wed, 17 Jul 2013 07:09:51 +0000 (07:09 +0000)]
[EFL][WK2] EWK2ContextMenuTest should be defined by inheriting from EWK2UnitTestBase.
https://bugs.webkit.org/show_bug.cgi?id=118767

Patch by Dong-Gwan Kim <donggwan.kim@samsung.com> on 2013-07-17
Reviewed by Christophe Dumez.

It should be defined as relevant test class specific to each test file for more readability.
It could be helpful to remove unnecessary static methods.

* UIProcess/API/efl/tests/test_ewk2_context_menu.cpp:
(EWK2ContextMenuTest::checkBasicContextMenuItem):
(EWK2ContextMenuTest::customItemSelected):
(EWK2ContextMenuTest::showContextMenu):
(EWK2ContextMenuTest::showContextMenuForRemoveAndAppend):
(EWK2ContextMenuTest::showContextMenuForSubmenu):
(EWK2ContextMenuTest::hideContextMenu):
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] EWK2ContextTest should be defined by inheriting from EWK2UnitTestBase.
commit-queue@webkit.org [Wed, 17 Jul 2013 07:06:18 +0000 (07:06 +0000)]
[EFL][WK2] EWK2ContextTest should be defined by inheriting from EWK2UnitTestBase.
https://bugs.webkit.org/show_bug.cgi?id=118763

Patch by Dong-Gwan Kim <donggwan.kim@samsung.com> on 2013-07-17
Reviewed by Christophe Dumez.

It should be defined as relevant test class specific to each test file for more readability.
It could be helpful to remove unnecessary static methods.

* UIProcess/API/efl/tests/test_ewk2_context.cpp:
(EWK2ContextTest::schemeRequestCallback):
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] EWK2DatabaseManagerTest should be defined by inheriting from EWK2UnitTestBase
commit-queue@webkit.org [Wed, 17 Jul 2013 07:05:40 +0000 (07:05 +0000)]
[EFL][WK2] EWK2DatabaseManagerTest should be defined by inheriting from EWK2UnitTestBase
https://bugs.webkit.org/show_bug.cgi?id=118726

Patch by Dong-Gwan Kim <donggwan.kim@samsung.com> on 2013-07-17
Reviewed by Christophe Dumez.

It should be defined as relevant test class specific to each test file for more readability.
It could be helpful to remove unnecessary static methods.

* UIProcess/API/efl/tests/test_ewk2_database_manager.cpp:
(EWK2DatabaseManagerTest::OriginData::OriginData):
(EWK2DatabaseManagerTest::databaseOriginsCallback):
(EWK2DatabaseManagerTest::timerCallback):
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] EWK2ColorPickerTest should be defined by inheriting from EWK2UnitTestBase.
commit-queue@webkit.org [Wed, 17 Jul 2013 07:03:48 +0000 (07:03 +0000)]
[EFL][WK2] EWK2ColorPickerTest should be defined by inheriting from EWK2UnitTestBase.
https://bugs.webkit.org/show_bug.cgi?id=118762

Patch by Dong-Gwan Kim <donggwan.kim@samsung.com> on 2013-07-17
Reviewed by Christophe Dumez.

It should be defined as relevant test class specific to each test file for more readability.
It could be helpful to remove unnecessary static methods.

* UIProcess/API/efl/tests/test_ewk2_color_picker.cpp:
(EWK2ColorPickerTest::onColorPickerDone):
(EWK2ColorPickerTest::setColorPickerColor):
(EWK2ColorPickerTest::showColorPicker):
(EWK2ColorPickerTest::hideColorPicker):
(EWK2ColorPickerTest::hideColorPickerByRemovingElement):
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove Platform(EFL) guard from Widget::frameRectsChanged
ryuan.choi@samsung.com [Wed, 17 Jul 2013 06:43:07 +0000 (06:43 +0000)]
Remove Platform(EFL) guard from Widget::frameRectsChanged
https://bugs.webkit.org/show_bug.cgi?id=118782

Reviewed by Christophe Dumez.

Since r58487, Widget::frameRectsChanged was moved to cpp and guarded.
But we can move back to header because WebKit/Efl refactored related code in r145710.

No new tests, refactoring.

* platform/Widget.cpp: Removed platform guard and move frameRectsChangd() back to header.
* platform/Widget.h:
(WebCore::Widget::frameRectsChanged):
* platform/efl/WidgetEfl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agosetPluginUnavailabilityReason can destroy renderObject before obscurity check
commit-queue@webkit.org [Wed, 17 Jul 2013 06:04:04 +0000 (06:04 +0000)]
setPluginUnavailabilityReason can destroy renderObject before obscurity check
https://bugs.webkit.org/show_bug.cgi?id=118770
<rdar://problem/14462331>

Patch by Gordon Sheridan <gordon_sheridan@apple.com> on 2013-07-16
Reviewed by Tim Horton.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):
Moved obscurity check to before renderObject is potentially destroyed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/ThirdParty/ANGLE: Update ANGLE from r1987 to r2426 while keeping these changes:
achristensen@apple.com [Wed, 17 Jul 2013 05:34:17 +0000 (05:34 +0000)]
Source/ThirdParty/ANGLE: Update ANGLE from r1987 to r2426 while keeping these changes:
Keeping #if defined(_MSC_VER) around #pragma warning(disable: 4718) in DependencyGraph.cpp.
Keeping include khrplatform.h instead of KHR/khrplatform.h in ShaderLang.h.
Added static_casts in Intermediate.cpp to fix compiling on Mac.
Changed enum bit fields to just enums for GCC in Types.h to fix compiling for GTK.
Ran Bison on Mac after removing the unsupported %code tag (See diff uploaded to bug for details).
Added YYLTYPE definition to glslang_tab.h which would have been put there by the unsupported %code tag.

https://bugs.webkit.org/show_bug.cgi?id=118550

Reviewed by Dean Jackson.

* ANGLE.plist: Updated revision of ANGLE to 2426.
* ANGLE.xcodeproj/project.pbxproj:
* GNUmakefile.am:
* Target.pri:
    Renamed DetectRecursion to DetectCallDepth and added builtin_symbol_table.
* include/GLSLANG/ShaderLang.h:
* src/common/version.h:
* src/compiler/BaseTypes.h:
(getQualifierString):
* src/compiler/Common.h:
* src/compiler/Compiler.cpp:
(TCompiler::TCompiler):
(TCompiler::Init):
(TCompiler::compile):
(TCompiler::detectCallDepth):
(TCompiler::enforceTimingRestrictions):
(TCompiler::limitExpressionComplexity):
* src/compiler/ConstantUnion.h:
(ConstantUnion::ConstantUnion):
* src/compiler/DetectCallDepth.cpp: Added.
(DetectCallDepth::FunctionNode::FunctionNode):
(DetectCallDepth::FunctionNode::getName):
(DetectCallDepth::FunctionNode::addCallee):
(DetectCallDepth::FunctionNode::detectCallDepth):
(DetectCallDepth::FunctionNode::reset):
(DetectCallDepth::DetectCallDepth):
(DetectCallDepth::~DetectCallDepth):
(DetectCallDepth::visitAggregate):
(DetectCallDepth::checkExceedsMaxDepth):
(DetectCallDepth::resetFunctionNodes):
(DetectCallDepth::detectCallDepthForFunction):
(DetectCallDepth::detectCallDepth):
(DetectCallDepth::findFunctionByName):
* src/compiler/DetectCallDepth.h: Added.
(DetectCallDepth::getInfoSink):
* src/compiler/DetectRecursion.cpp: Removed.
* src/compiler/DetectRecursion.h: Removed.
* src/compiler/Diagnostics.cpp:
(TDiagnostics::writeInfo):
* src/compiler/ForLoopUnroll.cpp:
(ForLoopUnroll::evaluateIntConstant):
* src/compiler/InfoSink.cpp:
(TInfoSinkBase::prefix):
(TInfoSinkBase::location):
(TInfoSinkBase::message):
* src/compiler/InfoSink.h:
* src/compiler/Initialize.cpp:
(TBuiltIns::initialize):
(IdentifyBuiltIns):
(InitExtensionBehavior):
* src/compiler/Intermediate.cpp: Updated and added static_casts to fix build errors on Mac.
(TIntermediate::addSymbol):
(TIntermediate::addBinaryMath):
(TIntermediate::addAssign):
(TIntermediate::addIndex):
(TIntermediate::addUnaryMath):
(TIntermediate::setAggregateOperator):
(TIntermediate::addConversion):
(TIntermediate::growAggregate):
(TIntermediate::makeAggregate):
(TIntermediate::addSelection):
(TIntermediate::addComma):
(TIntermediate::addConstantUnion):
(TIntermediate::addSwizzle):
(TIntermediate::addLoop):
(TIntermediate::addBranch):
(TIntermUnary::promote):
(TIntermBinary::promote):
(CompareStruct):
(CompareStructure):
(TIntermConstantUnion::fold):
(TIntermediate::promoteConstantUnion):
* src/compiler/OutputGLSL.cpp:
(TOutputGLSL::visitSymbol):
* src/compiler/OutputGLSL.h:
* src/compiler/OutputGLSLBase.cpp:
(TOutputGLSLBase::writeVariableType):
(TOutputGLSLBase::writeConstantUnion):
(TOutputGLSLBase::visitBinary):
(TOutputGLSLBase::visitAggregate):
(TOutputGLSLBase::getTypeName):
(TOutputGLSLBase::hashFunctionName):
(TOutputGLSLBase::structDeclared):
(TOutputGLSLBase::declareStruct):
* src/compiler/OutputGLSLBase.h:
* src/compiler/OutputHLSL.cpp:
(sh::OutputHLSL::OutputHLSL):
(sh::OutputHLSL::header):
(sh::OutputHLSL::visitSymbol):
(sh::OutputHLSL::visitBinary):
(sh::OutputHLSL::visitAggregate):
(sh::OutputHLSL::visitSelection):
(sh::OutputHLSL::visitLoop):
(sh::OutputHLSL::handleExcessiveLoop):
(sh::OutputHLSL::typeString):
(sh::OutputHLSL::initializer):
(sh::OutputHLSL::addConstructor):
(sh::OutputHLSL::writeConstantUnion):
(sh::OutputHLSL::decorateField):
* src/compiler/OutputHLSL.h:
* src/compiler/ParseHelper.cpp:
(TParseContext::parseVectorFields):
(TParseContext::parseMatrixFields):
(TParseContext::error):
(TParseContext::warning):
(TParseContext::assignError):
(TParseContext::unaryOpError):
(TParseContext::binaryOpError):
(TParseContext::precisionErrorCheck):
(TParseContext::lValueErrorCheck):
(TParseContext::globalErrorCheck):
(TParseContext::reservedErrorCheck):
(TParseContext::constructorErrorCheck):
(TParseContext::voidErrorCheck):
(TParseContext::boolErrorCheck):
(TParseContext::samplerErrorCheck):
(TParseContext::structQualifierErrorCheck):
(TParseContext::parameterSamplerErrorCheck):
(TParseContext::containsSampler):
(TParseContext::arraySizeErrorCheck):
(TParseContext::arrayQualifierErrorCheck):
(TParseContext::arrayTypeErrorCheck):
(TParseContext::arrayErrorCheck):
(TParseContext::nonInitConstErrorCheck):
(TParseContext::nonInitErrorCheck):
(TParseContext::paramErrorCheck):
(TParseContext::extensionErrorCheck):
(TParseContext::findFunction):
(TParseContext::isVariableBuiltIn):
(TParseContext::executeInitializer):
(TParseContext::addConstructor):
(TParseContext::constructBuiltIn):
(TParseContext::constructStruct):
(TParseContext::addConstVectorNode):
(TParseContext::addConstMatrixNode):
(TParseContext::addConstArrayNode):
(TParseContext::addConstStruct):
(TParseContext::enterStructDeclaration):
(TParseContext::structNestingErrorCheck):
* src/compiler/ParseHelper.h:
(TParseContext::TParseContext):
(TParseContext::pragma):
* src/compiler/PoolAlloc.cpp:
(TPoolAllocator::allocate):
* src/compiler/ShHandle.h:
* src/compiler/ShaderLang.cpp:
(ShInitBuiltInResources):
* src/compiler/SymbolTable.cpp:
(TType::TType):
(TType::buildMangledName):
(TType::getObjectSize):
(TStructure::containsArrays):
(TStructure::buildMangledName):
(TStructure::calculateObjectSize):
(TStructure::calculateDeepestNesting):
(TSymbolTableLevel::relateToExtension):
* src/compiler/SymbolTable.h:
(TSymbol::relateToExtension):
(TSymbol::getExtension):
(TVariable::TVariable):
(TVariable::setQualifier):
(TVariable::shareConstPointer):
* src/compiler/Types.h: Updated and changed enum bit fields to enums to fix compiling with GCC.
(TField::TField):
(TField::type):
(TField::name):
(NewPoolTFieldList):
(TStructure::TStructure):
(TStructure::name):
(TStructure::fields):
(TStructure::mangledName):
(TStructure::objectSize):
(TStructure::deepestNesting):
(TType::TType):
(TType::clearArrayness):
(TType::getStruct):
(TType::setStruct):
(TType::getMangledName):
(TType::getDeepestStructNesting):
(TType::isStructureContainingArrays):
(TPublicType::setBasic):
* src/compiler/VariableInfo.cpp:
(getUserDefinedVariableInfo):
* src/compiler/builtin_symbol_table.cpp: Added.
(builtin1):
(builtin2):
(builtin3):
(InsertBuiltInFunctionsCommon):
(InsertBuiltInFunctionsVertex):
* src/compiler/builtin_symbol_table.h: Added.
* src/compiler/glslang.l:
* src/compiler/glslang.y:
* src/compiler/glslang_lex.cpp:
(yy_get_previous_state):
(yy_try_NUL_trans):
(yyget_lloc):
(yyset_lloc):
(string_input):
(check_type):
(reserved_word):
(glslang_scan):
* src/compiler/glslang_tab.cpp:
(yysyntax_error):
(yyerror):
(glslang_parse):
* src/compiler/glslang_tab.h: Readded YYLTYPE definition after Bison removed it.
* src/compiler/intermOut.cpp:
(TOutputTraverser::visitUnary):
(TOutputTraverser::visitAggregate):
(TOutputTraverser::visitConstantUnion):
* src/compiler/intermediate.h:
(TIntermNode::TIntermNode):
(TIntermNode::~TIntermNode):
(TIntermNode::getLine):
(TIntermNode::setLine):
(TIntermNode::getAsLoopNode):
(TIntermConstantUnion::getIConst):
(TIntermConstantUnion::getFConst):
(TIntermConstantUnion::getBConst):
(TIntermAggregate::TIntermAggregate):
(TIntermTraverser::TIntermTraverser):
(TIntermTraverser::getMaxDepth):
(TIntermTraverser::incrementDepth):
* src/compiler/localintermediate.h:
* src/compiler/parseConst.cpp:
(TConstTraverser::visitSymbol):
(TConstTraverser::visitBinary):
(TConstTraverser::visitUnary):
(TConstTraverser::visitAggregate):
(TConstTraverser::visitSelection):
(TConstTraverser::visitConstantUnion):
(TConstTraverser::visitLoop):
(TConstTraverser::visitBranch):
(TIntermediate::parseConstTree):
* src/compiler/preprocessor/ExpressionParser.cpp:
* src/compiler/timing/RestrictVertexShaderTiming.cpp:
(RestrictVertexShaderTiming::visitSymbol):
    Updated ANGLE to r2426 and ran Bison.

Source/WebCore: Update ANGLE to r2426.
https://bugs.webkit.org/show_bug.cgi?id=118550

Reviewed by Dean Jackson.

* CMakeLists.txt: Renamed DetectRecursion to DetectCallDepth and added builtin_symbol_table.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMany crashes loading Java applets after r152701
timothy_horton@apple.com [Wed, 17 Jul 2013 02:04:00 +0000 (02:04 +0000)]
Many crashes loading Java applets after r152701
https://bugs.webkit.org/show_bug.cgi?id=118760
<rdar://problem/14462836>

Reviewed by Dean Jackson.

* html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::updateWidget):
Re-acquire the renderer after calling createJavaAppletWidget,
because it can cause reattach, leaving our renderer pointer stale.

* loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::createJavaAppletWidget):
Null-check renderer, as element->renderEmbeddedObject() can very clearly
return null in some cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAX: Add a 'choose product' link for the new-ax-bug alias.
commit-queue@webkit.org [Wed, 17 Jul 2013 00:50:16 +0000 (00:50 +0000)]
AX: Add a 'choose product' link for the new-ax-bug alias.
https://bugs.webkit.org/show_bug.cgi?id=118697

Patch by James Craig <james@cookiecrook.com> on 2013-07-16
Reviewed by Chris Fleizach.

* template/en/custom/global/choose-product.html.tmpl: Added new link for accessibility bugs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMissing break in WebGLRenderingContext::validateCompressedTexFuncData()
psolanki@apple.com [Wed, 17 Jul 2013 00:33:03 +0000 (00:33 +0000)]
Missing break in WebGLRenderingContext::validateCompressedTexFuncData()
https://bugs.webkit.org/show_bug.cgi?id=118742

Reviewed by Ryosuke Niwa.

* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::validateCompressedTexFuncData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: InspectorFrontendHost is undefined
commit-queue@webkit.org [Wed, 17 Jul 2013 00:32:14 +0000 (00:32 +0000)]
Web Inspector: InspectorFrontendHost is undefined
https://bugs.webkit.org/show_bug.cgi?id=118715

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-07-16
Reviewed by Timothy Hatcher.

Add InspectorFrontendHostStub.js to New Inspector because of the InspectorFrontendHost initialization.

* UserInterface/InspectorFrontendHostStub.js: Added.
(.WebInspector.InspectorFrontendHostStub):
(.WebInspector.InspectorFrontendHostStub.prototype.platform):
(.WebInspector.InspectorFrontendHostStub.prototype.port):
(.WebInspector.InspectorFrontendHostStub.prototype.bringToFront):
(.WebInspector.InspectorFrontendHostStub.prototype.closeWindow):
(.WebInspector.InspectorFrontendHostStub.prototype.requestSetDockSide):
(.WebInspector.InspectorFrontendHostStub.prototype.setAttachedWindowHeight):
(.WebInspector.InspectorFrontendHostStub.prototype.setAttachedWindowWidth):
(.WebInspector.InspectorFrontendHostStub.prototype.setToolbarHeight):
(.WebInspector.InspectorFrontendHostStub.prototype.moveWindowBy):
(.WebInspector.InspectorFrontendHostStub.prototype.loaded):
(.WebInspector.InspectorFrontendHostStub.prototype.localizedStringsURL):
(.WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):
(.WebInspector.InspectorFrontendHostStub.prototype.copyText):
(.WebInspector.InspectorFrontendHostStub.prototype.openInNewTab):
(.WebInspector.InspectorFrontendHostStub.prototype.canSave):
(.WebInspector.InspectorFrontendHostStub.prototype.save):
(.WebInspector.InspectorFrontendHostStub.prototype.append):
(.WebInspector.InspectorFrontendHostStub.prototype.close.cleanup):
(.WebInspector.InspectorFrontendHostStub.prototype.close):
(.WebInspector.InspectorFrontendHostStub.prototype.sendMessageToBackend):
(.WebInspector.InspectorFrontendHostStub.prototype.loadResourceSynchronously):
* UserInterface/Main.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agocheck-webkit-style: "using namespace foo;" should be flagged as an error only in...
kseo@webkit.org [Wed, 17 Jul 2013 00:12:22 +0000 (00:12 +0000)]
check-webkit-style: "using namespace foo;" should be flagged as an error only in headers
https://bugs.webkit.org/show_bug.cgi?id=118755

Reviewed by Ryosuke Niwa.

Fix r152719 to check "using namespace foo;" only in headers.

* Scripts/webkitpy/style/checkers/cpp.py:
(check_using_namespace):
(check_style):
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(WebKitStyleTest.test_using_namespace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTypo in DFGInsertionSet.h header guard: "DFGInsectionSet_h" -> "DFGInsertionSet_h"
dfarler@apple.com [Tue, 16 Jul 2013 23:24:33 +0000 (23:24 +0000)]
Typo in DFGInsertionSet.h header guard: "DFGInsectionSet_h" -> "DFGInsertionSet_h"
https://bugs.webkit.org/show_bug.cgi?id=118753

Reviewed by Geoffrey Garen.

* dfg/DFGInsertionSet.h:
"DFGInsectionSet_h" -> "DFGInsertionSet_h"

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdded passing WebGL tests.
achristensen@apple.com [Tue, 16 Jul 2013 22:57:11 +0000 (22:57 +0000)]
Added passing WebGL tests.
https://bugs.webkit.org/show_bug.cgi?id=118696

Reviewed by Dean Jackson.

* platform/mac/TestExpectations: Replaced webgl directory with list of failing webgl tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAtomicize HTMLAnchorElement.hash before passing it to JS.
akling@apple.com [Tue, 16 Jul 2013 22:03:18 +0000 (22:03 +0000)]
Atomicize HTMLAnchorElement.hash before passing it to JS.
<http://webkit.org/b/118748>
<rdar://problem/14459780>

Reviewed by Sam Weinig.

Instead of generating a unique string from '#' + the URL hash every time HTMLAnchorElement.hash
is queried, turn it into an AtomicString. This prevents massive memory usage in scripts that
fetch .hash a lot.

Reduces memory consumption by 4.65 MB when viewing the full HTML5 spec at <http://whatwg.org/c>

* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::hash):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMakeRope fixup shouldn't lead to an Identity without kids
fpizlo@apple.com [Tue, 16 Jul 2013 21:41:06 +0000 (21:41 +0000)]
MakeRope fixup shouldn't lead to an Identity without kids
https://bugs.webkit.org/show_bug.cgi?id=118745

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

Make the empty string pruning part of fixupMakeRope() stop if it's on the last child.

Make Node::convertToIdentity release-assert that it has exactly one kid.

* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupMakeRope):
* dfg/DFGNode.h:
(JSC::DFG::Node::convertToIdentity):

LayoutTests:

Reviewed by Mark Hahnenberg.

* fast/js/dfg-make-rope-all-empty-strings.html: Added.
* fast/js/dfg-make-rope-all-empty-strings-expected.txt: Added.
* fast/js/jsc-test-list:
* fast/js/script-tests/dfg-make-rope-all-empty-strings.js: Added.
(foo):
(bar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake WebVTTParser return cue data instead of cue DOM objects
commit-queue@webkit.org [Tue, 16 Jul 2013 21:34:12 +0000 (21:34 +0000)]
Make WebVTTParser return cue data instead of cue DOM objects
https://bugs.webkit.org/show_bug.cgi?id=118687

Patch by Brendan Long <b.long@cablelabs.com> on 2013-07-16
Reviewed by Eric Carlson.

No new tests because this doesn't change functionality.

* html/track/InbandTextTrack.cpp:
Make TextTrackCueMap handle WebVTTCues instead of just generic cues.
m_dataToCueMap and m_cueToDataMap were renamed m_genericDataToCueMap
and m_genericCueToDataMap. The cue maps were turned into pointers so we
only allocate the ones we need.
(WebCore::TextTrackCueMap::TextTrackCueMap): Initialize maps to 0.
(WebCore::TextTrackCueMap::~TextTrackCueMap): Delete allocated maps.
(WebCore::TextTrackCueMap::add): Changed to allocate cue maps as needed, and added WebVTT version.
(WebCore::TextTrackCueMap::find): Checked to check if cue maps are allocated, and added WebVTT version.
(WebCore::TextTrackCueMap::findGenericData): Changed to accept TextTrackCue instead of TextTrackCueGeneric.
(WebCore::TextTrackCueMap::findWebVTTData): Same as findGenericData, except for WebVTTCueData.
(WebCore::TextTrackCueMap::remove): Accept TextTrackCue instead of TextTrackCueGeneric, and look in both maps.
(WebCore::InbandTextTrack::addWebVTTCue): Added, based on addGenericCue.
(WebCore::InbandTextTrack::removeWebVTTCue): Added, almost identical to removeGenericCue.
(WebCore::InbandTextTrack::removeCue): m_cueMap.remove() takes a TextTrackCue now so it can remove both types of cue.
(WebCore::InbandTextTrack::willRemoveTextTrackPrivate): Use ASSERT_UNUSED instead of UNUSED_PARAM + ASSERT.
* html/track/InbandTextTrack.h: Add new functions above, change maps to pointers and add maps for holding WebVTT cues.
* html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::getNewCues): Return WebVTTCueData instead of TextTrackCue.
(WebCore::WebVTTParser::createNewCue): Create WebVTTCueData instead of TextTrackCue.
* html/track/WebVTTParser.h: Add WebVTTCueData class, based on GenericCueData.
The following functions are just constructors, destructors, getters, or setters.
(WebCore::WebVTTCueData::create):
(WebCore::WebVTTCueData::~WebVTTCueData):
(WebCore::WebVTTCueData::startTime):
(WebCore::WebVTTCueData::setStartTime):
(WebCore::WebVTTCueData::endTime):
(WebCore::WebVTTCueData::setEndTime):
(WebCore::WebVTTCueData::id):
(WebCore::WebVTTCueData::setId):
(WebCore::WebVTTCueData::content):
(WebCore::WebVTTCueData::setContent):
(WebCore::WebVTTCueData::settings):
(WebCore::WebVTTCueData::setSettings):
(WebCore::WebVTTCueData::WebVTTCueData):
* loader/TextTrackLoader.cpp:
(WebCore::TextTrackLoader::getNewCues): Convert WebVTTCueData to TextTrackCue when we get them.
* platform/graphics/InbandTextTrackPrivateClient.h: Add addWebVTTCue and removeWebVTTCue functions to the interface.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago REGRESSION (r150291): Chinese predictive input pop-up disappears on twitter.com
ap@apple.com [Tue, 16 Jul 2013 21:14:58 +0000 (21:14 +0000)]
    REGRESSION (r150291): Chinese predictive input pop-up disappears on twitter.com
        https://bugs.webkit.org/show_bug.cgi?id=118739
        <rdar://problem/14300350>

        Reviewed by Daniel Bates.

        EditorState tracking on UI side is very fragile. This is a targeted fix just for
        this specific scenario.

        The issue was that we had a stale m_temporarilyClosedComposition flag, which was
        making UI process believe that a composition was closed from WebProcess side,
        and notify input method about that. It shouldn't have been a problem, because there
        is no composition at this point indeed, but this extra call is a problem for
        predictive input, which works in a somewhat unconventional way (<rdar://problem/14458297>).

        * UIProcess/mac/WebPageProxyMac.mm:
        (WebKit::WebPageProxy::insertText): Reset m_temporarilyClosedComposition flag when
        getting new EditorState in response to performing this action. There is certainly
        no composition after insertText, and all interested parties are on the same page
        already.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152740 268f45cc-cd09-0410-ab3c-d52691b4dbfc