WebKit-https.git
2 years agoSpeedometer: Update to modern Vue.js version
commit-queue@webkit.org [Fri, 18 Aug 2017 04:03:24 +0000 (04:03 +0000)]
Speedometer: Update to modern Vue.js version
https://bugs.webkit.org/show_bug.cgi?id=175660

Patch by Mathias Bynens <mathias@qiwi.be> on 2017-08-17
Reviewed by Ryosuke Niwa.

* Speedometer/resources/todomvc/architecture-examples/vuejs-cli/README.md: Documented build process.
* Speedometer/resources/todomvc/architecture-examples/vuejs-cli/config/index.js: Forced relative URLs to avoid breaking the interactive runner.
* Speedometer/resources/todomvc/architecture-examples/vuejs-cli/dist/*: Updated per build steps.
* Speedometer/resources/todomvc/architecture-examples/vuejs-cli/package-lock.json: Added to pin dependencies and make builds deterministic.
* Speedometer/resources/todomvc/architecture-examples/vuejs-cli/package.json: Update to modern Vue.js version.
* Speedometer/resources/todomvc/architecture-examples/vuejs-cli/src/components/Todos.vue: Fix markup error.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoSpeedometer: Update to modern React/Redux version
commit-queue@webkit.org [Fri, 18 Aug 2017 03:51:17 +0000 (03:51 +0000)]
Speedometer: Update to modern React/Redux version
https://bugs.webkit.org/show_bug.cgi?id=175669

Patch by Mathias Bynens <mathias@qiwi.be> on 2017-08-17
Reviewed by Ryosuke Niwa.

* Speedometer/resources/todomvc/architecture-examples/react-redux/README.md: Documented build steps.
* Speedometer/resources/todomvc/architecture-examples/react-redux/dist/*: Updated per build instructions.
* Speedometer/resources/todomvc/architecture-examples/react-redux/package-lock.json: Pinned dependencies to make builds deterministic.
* Speedometer/resources/todomvc/architecture-examples/react-redux/package.json: Fixed build command.
* Speedometer/resources/todomvc/architecture-examples/react-redux/public/index.html: Made title consistent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWeb Inspector: create better icon for Canvas Path navigation item
mattbaker@apple.com [Fri, 18 Aug 2017 03:13:53 +0000 (03:13 +0000)]
Web Inspector: create better icon for Canvas Path navigation item
https://bugs.webkit.org/show_bug.cgi?id=175274

Reviewed by Joseph Pecoraro.

* UserInterface/Images/Path.svg: Added.
* UserInterface/Views/RecordingContentView.js:
(WI.RecordingContentView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Curl] Improve multi-threaded networking
commit-queue@webkit.org [Fri, 18 Aug 2017 02:17:28 +0000 (02:17 +0000)]
[Curl] Improve multi-threaded networking
https://bugs.webkit.org/show_bug.cgi?id=175253

Patch by Daewoong Jang <daewoong.jang@navercorp.com> on 2017-08-17
Reviewed by Alex Christensen.

* platform/network/curl/CurlContext.cpp:
(WebCore::CurlMultiHandle::CurlMultiHandle):
(WebCore::CurlHandle::CurlHandle):
(WebCore::CurlHandle::initialize):
(WebCore::CurlHandle::setSslKeyPassword):
(WebCore::CurlHandle::setSslErrors):
(WebCore::CurlHandle::getSslErrors):
* platform/network/curl/CurlContext.h:
* platform/network/curl/CurlDownload.cpp:
(WebCore::CurlDownload::init):
(WebCore::CurlDownload::getResponse const):
(WebCore::CurlDownload::setupRequest):
(WebCore::CurlDownload::didReceiveHeader):
(WebCore::CurlDownload::didReceiveData):
(WebCore::CurlDownload::headerCallback):
(WebCore::CurlDownload::getTempPath const): Deleted.
(WebCore::CurlDownload::getUrl const): Deleted.
(WebCore::CurlDownload::downloadFinishedCallback): Deleted.
(WebCore::CurlDownload::downloadFailedCallback): Deleted.
(WebCore::CurlDownload::receivedDataCallback): Deleted.
(WebCore::CurlDownload::receivedResponseCallback): Deleted.
* platform/network/curl/CurlDownload.h:
* platform/network/curl/ResourceError.h:
(WebCore::ResourceError::ResourceError):
(WebCore::ResourceError::sslErrors const):
(WebCore::ResourceError::setSSLErrors): Deleted.
* platform/network/curl/ResourceHandleCurl.cpp:
(WebCore::ResourceHandleInternal::initialize):
(WebCore::ResourceHandleInternal::didFail):
(WebCore::ResourceHandleInternal::dispatchSynchronousJob):
* platform/network/curl/SSLHandle.cpp:
(WebCore::allowedClientHosts):
(WebCore::addAllowedClientCertificate):
(WebCore::getSSLClientCertificate):
(WebCore::certVerifyCallback):
(WebCore::setSSLVerifyOptions):
(WebCore::setSSLClientCertificate): Deleted.
* platform/network/curl/SSLHandle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agocheck-webkit-style shouldn't check spacing in #elif preprocessor lines
commit-queue@webkit.org [Fri, 18 Aug 2017 02:17:06 +0000 (02:17 +0000)]
check-webkit-style shouldn't check spacing in #elif preprocessor lines
https://bugs.webkit.org/show_bug.cgi?id=175652

Patch by Yoshiaki Jitsukawa <Yoshiaki.Jitsukawa@sony.com> on 2017-08-17
Reviewed by Alex Christensen.

* Scripts/webkitpy/style/checkers/cpp.py:
(check_spacing):
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppStyleTest.test_spacing_for_binary_ops):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUpdate to changeSelectionWithTouchAt:baseIsStart:withFlags:
megan_gardner@apple.com [Fri, 18 Aug 2017 01:34:16 +0000 (01:34 +0000)]
Update to changeSelectionWithTouchAt:baseIsStart:withFlags:
https://bugs.webkit.org/show_bug.cgi?id=175615

Update calls to use the flag versions, as they are used for passing state.
Leave old calls, but set them up to be removed next cycle.

Reviewed by Tim Horton.

* Platform/spi/ios/UIKitSPI.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(selectionChangedWithTouch):
(-[WKContentView changeSelectionWithGestureAt:withGesture:withState:]):
(-[WKContentView changeSelectionWithGestureAt:withGesture:withState:withFlags:]):
(-[WKContentView changeSelectionWithTouchAt:withSelectionTouch:baseIsStart:]):
(-[WKContentView changeSelectionWithTouchAt:withSelectionTouch:baseIsStart:withFlags:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWebAssembly: const in unreachable code decoded incorrectly, erroneously rejects binar...
jfbastien@apple.com [Fri, 18 Aug 2017 01:04:00 +0000 (01:04 +0000)]
WebAssembly: const in unreachable code decoded incorrectly, erroneously rejects binary as invalid
https://bugs.webkit.org/show_bug.cgi?id=175693
<rdar://problem/33952443>

Reviewed by Saam Barati.

JSTests:

Add a regression directory for WebAssembly tests.

* wasm.yaml:
* wasm/regress/175693.js: Added.
(else.else):
(instance.new.WebAssembly.Instance.new.WebAssembly.Module):
(catch):
* wasm/regress/175693.wasm: Added.

Source/JavaScriptCore:

64-bit constants in an unreachable context were being decoded as
32-bit constants. This is pretty benign because unreachable code
shouldn't occur often. The effect is that 64-bit constants which
can't be encoded as 32-bit constants would cause the binary to be
rejected.

At the same time, 32-bit integer constants should be decoded as signed.

* wasm/WasmFunctionParser.h:
(JSC::Wasm::FunctionParser<Context>::parseUnreachableExpression):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAdd a Unicode test to RexBench that matches non-BMP characters
msaboff@apple.com [Fri, 18 Aug 2017 00:56:59 +0000 (00:56 +0000)]
Add a Unicode test to RexBench that matches non-BMP characters
https://bugs.webkit.org/show_bug.cgi?id=175697

Reviewed by JF Bastien.

Added a new sub test that simulates 5 card stud poker.  This test uses the Unicode playing
cards code points, U+1F0A1..U+1F0DE, as the card representation.  The scoring of hands is
done using three regular expressions, one to check for a flush, one to check for straights
and one to check for pairs, three of a kind and four of a kind.

* RexBench/UniPoker: Added.
* RexBench/UniPoker/benchmark.js: Added.
(UniPokerBenchmark):
(UniPokerBenchmark.prototype.setup.):
(UniPokerBenchmark.prototype.setup.Math.random):
(UniPokerBenchmark.prototype.setup):
(UniPokerBenchmark.prototype.runOnce):
(UniPokerBenchmark.prototype.validate):
* RexBench/UniPoker/expected.js: Added.
(PlayerExpectation):
(PlayerExpectation.prototype.validate):
* RexBench/UniPoker/poker.js: Added.
(CardDeck):
(CardDeck.prototype.newDeck):
(CardDeck.prototype.shuffle):
(CardDeck.prototype.dealOneCard):
(CardDeck.cardRank):
(CardDeck.cardName):
(Hand):
(Hand.prototype.clear):
(Hand.prototype.takeCard):
(Hand.prototype.score):
(Hand.prototype.get rank):
(Hand.prototype.toString):
(Player):
(Player.prototype.scoreHand):
(Player.prototype.wonHand):
(Player.prototype.get name):
(Player.prototype.get hand):
(Player.prototype.get wins):
(Player.prototype.get handTypeCounts):
(playHands):
* RexBench/about.html:
* RexBench/cli.js:
* RexBench/glue.js:
(driver.reportResult):
* RexBench/index.html:
* RexBench/unipoker_benchmark.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMark media/video-controls-rendering.html as flaky.
ryanhaddad@apple.com [Fri, 18 Aug 2017 00:54:17 +0000 (00:54 +0000)]
Mark media/video-controls-rendering.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=175700

Unreviewed test gardening.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUseedate TestExpectations for media/video-controls-show-on-kb-or-ax-event.html.
ryanhaddad@apple.com [Fri, 18 Aug 2017 00:46:47 +0000 (00:46 +0000)]
Useedate TestExpectations for media/video-controls-show-on-kb-or-ax-event.html.
https://bugs.webkit.org/show_bug.cgi?id=158889

Unreviewed test gardening.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoTeach DFGFixupPhase.cpp that the current scope is always a cell
commit-queue@webkit.org [Fri, 18 Aug 2017 00:19:39 +0000 (00:19 +0000)]
Teach DFGFixupPhase.cpp that the current scope is always a cell
https://bugs.webkit.org/show_bug.cgi?id=175610

Patch by Robin Morisset <rmorisset@apple.com> on 2017-08-17
Reviewed by Keith Miller.

Also teach it that the argument to with can usually be speculated to be an object,
since toObject() is called on it.

* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePushWithScope):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compilePushWithScope):
* jit/JITOperations.cpp:
* jit/JITOperations.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMarked accessibility/mac/select-element-selection-with-optgroups.html as flaky.
jlewis3@apple.com [Thu, 17 Aug 2017 23:32:18 +0000 (23:32 +0000)]
Marked accessibility/mac/select-element-selection-with-optgroups.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=175341

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRegression(r220817): We should only copy the original request headers for Ping loads
cdumez@apple.com [Thu, 17 Aug 2017 22:56:59 +0000 (22:56 +0000)]
Regression(r220817): We should only copy the original request headers for Ping loads
https://bugs.webkit.org/show_bug.cgi?id=175679

Reviewed by Youenn Fablet.

Source/WebCore:

For performance reason, we should only copy the original request headers for Ping loads
(Beacon at the moment), not for all CachedResourceRequests.

* loader/LoaderStrategy.h:
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::load):
* loader/cache/CachedResource.h:
(WebCore::CachedResource::shouldUsePingLoad):
(WebCore::CachedResource::setOriginalRequestHeaders):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):
* loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::CachedResourceRequest):
* loader/cache/CachedResourceRequest.h:
(WebCore::CachedResourceRequest::releaseResourceRequest):
(WebCore::CachedResourceRequest::releaseOriginalRequestHeaders): Deleted.

Source/WebKit:

For performance reason, we should only copy the original request headers for Ping loads
(Beacon at the moment), not for all CachedResourceRequests.

* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::loadPing):
* NetworkProcess/NetworkConnectionToWebProcess.h:
* NetworkProcess/NetworkConnectionToWebProcess.messages.in:
* NetworkProcess/NetworkResourceLoadParameters.cpp:
(WebKit::NetworkResourceLoadParameters::encode const):
(WebKit::NetworkResourceLoadParameters::decode):
* NetworkProcess/NetworkResourceLoadParameters.h:
* NetworkProcess/PingLoad.cpp:
(WebKit::PingLoad::PingLoad):
(WebKit::PingLoad::willPerformHTTPRedirection):
(WebKit::PingLoad::makeCrossOriginAccessRequest):
(WebKit::PingLoad::makeSimpleCrossOriginAccessRequest):
(WebKit::PingLoad::originalRequestHeaders const): Deleted.
* NetworkProcess/PingLoad.h:
* WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::createPingHandle):
* WebProcess/Network/WebLoaderStrategy.h:

Source/WebKitLegacy:

* WebCoreSupport/WebResourceLoadScheduler.cpp:
(WebResourceLoadScheduler::createPingHandle):
* WebCoreSupport/WebResourceLoadScheduler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[PAL] Relocate SessionID to root
don.olmstead@sony.com [Thu, 17 Aug 2017 22:48:54 +0000 (22:48 +0000)]
[PAL] Relocate SessionID to root
https://bugs.webkit.org/show_bug.cgi?id=175684

Reviewed by Alex Christensen.

Source/WebCore:

No new tests. No change in functionality.

* dom/Document.h:
* html/HTMLMediaElement.cpp:
* loader/cache/CachedResource.h:
* loader/cache/CachedResourceLoader.cpp:
* loader/cache/MemoryCache.h:
* loader/cocoa/DiskCacheMonitorCocoa.h:
* page/CacheStorageProvider.h:
* page/Page.h:
* page/PlugInClient.h:
* page/SocketProvider.h:
* platform/CookiesStrategy.h:
* platform/WebCoreCrossThreadCopier.cpp:
* platform/network/CacheValidation.h:
* platform/network/NetworkStorageSession.cpp:
* platform/network/NetworkStorageSession.h:
* platform/network/cf/SocketStreamHandleImpl.h:
* platform/network/curl/SocketStreamHandleImpl.h:
* platform/network/soup/SocketStreamHandleImpl.h:
* workers/WorkerGlobalScope.h:
* workers/service/ServiceWorkerContainer.h:
* workers/service/ServiceWorkerRegistrationParameters.h:

Source/WebCore/PAL:

* PAL.xcodeproj/project.pbxproj:
* pal/CMakeLists.txt:
* pal/SessionID.cpp: Renamed from Source/WebCore/PAL/pal/identifier/SessionID.cpp.
* pal/SessionID.h: Renamed from Source/WebCore/PAL/pal/identifier/SessionID.h.

Source/WebKit:

* NetworkProcess/Downloads/Download.h:
* NetworkProcess/Downloads/DownloadManager.cpp:
* NetworkProcess/NetworkCORSPreflightChecker.h:
* NetworkProcess/NetworkConnectionToWebProcess.cpp:
* NetworkProcess/NetworkLoad.cpp:
* NetworkProcess/NetworkLoadParameters.h:
* NetworkProcess/NetworkProcess.cpp:
* NetworkProcess/NetworkProcess.h:
* NetworkProcess/NetworkResourceLoadParameters.h:
* NetworkProcess/NetworkSession.h:
* NetworkProcess/NetworkSocketStream.h:
* NetworkProcess/RemoteNetworkingContext.h:
* NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:
* Scripts/webkit/messages.py:
(forward_declarations_and_headers.templates): Deleted.
(class_template_headers.template): Deleted.
* Shared/ChildProcess.cpp:
* Shared/SessionTracker.h:
* Shared/Storage/StorageProcessCreationParameters.h:
* Shared/WebCoreArgumentCoders.cpp:
* Shared/WebPageCreationParameters.h:
* Shared/WebProcessCreationParameters.h:
* Shared/WebsiteDataStoreParameters.h:
* Shared/mac/CookieStorageShim.mm:
* StorageProcess/IndexedDB/WebIDBConnectionToClient.h:
* StorageProcess/StorageProcess.cpp:
* StorageProcess/StorageProcess.h:
* StorageProcess/StorageToWebProcessConnection.h:
* UIProcess/API/APIPageConfiguration.h:
* UIProcess/API/APIWebsiteDataStore.h:
* UIProcess/API/glib/WebKitCookieManager.cpp:
* UIProcess/Plugins/PlugInAutoStartProvider.h:
* UIProcess/WebCookieManagerProxy.h:
* UIProcess/WebProcessPool.cpp:
* UIProcess/WebProcessPool.h:
* UIProcess/WebProcessProxy.h:
* UIProcess/WebsiteData/WebsiteDataStore.h:
* WebProcess/Cookies/WebCookieManager.h:
* WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h:
* WebProcess/Databases/WebDatabaseProvider.cpp:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
* WebProcess/Network/NetworkProcessConnection.cpp:
* WebProcess/Network/WebLoaderStrategy.cpp:
* WebProcess/Network/WebSocketStream.cpp:
* WebProcess/Network/WebSocketStream.h:
* WebProcess/Storage/WebToStorageProcessConnection.h:
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
* WebProcess/WebCoreSupport/WebPlugInClient.h:
* WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
* WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:
* WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h:
* WebProcess/WebPage/WebPage.cpp:
* WebProcess/WebProcess.h:

Source/WebKitLegacy:

* Storage/WebDatabaseProvider.cpp:

Source/WebKitLegacy/mac:

* WebCoreSupport/WebFrameNetworkingContext.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRebaseline js/dom/global-constructors-attributes.html for Sierra.
ryanhaddad@apple.com [Thu, 17 Aug 2017 22:47:03 +0000 (22:47 +0000)]
Rebaseline js/dom/global-constructors-attributes.html for Sierra.

Unreviewed test gardening.

* platform/mac/js/dom/global-constructors-attributes-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRebaseline two tests after r220870.
ryanhaddad@apple.com [Thu, 17 Aug 2017 22:41:08 +0000 (22:41 +0000)]
Rebaseline two tests after r220870.

Unreviewed test gardening.

* inspector/dom/content-node-region-info-expected.txt:
* platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMark inspector/canvas/context-attributes.html as flaky.
ryanhaddad@apple.com [Thu, 17 Aug 2017 22:41:05 +0000 (22:41 +0000)]
Mark inspector/canvas/context-attributes.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=173931

Unreviewed test gardening.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoFix the build on other platforms after r220865
wenson_hsieh@apple.com [Thu, 17 Aug 2017 22:20:02 +0000 (22:20 +0000)]
Fix the build on other platforms after r220865
https://bugs.webkit.org/show_bug.cgi?id=175683

Reviewed by Tim Horton.

Source/WebCore:

Instead of special casing iOS 10 behavior with __IPHONE_OS_VERSION_MAX_ALLOWED < 110000, revert to special
casing iOS 11 behavior with __IPHONE_OS_VERSION_MAX_ALLOWED >= 110000. This is because other targets that are
neither iOS 10 nor 11 will fail the "before iOS 11" compile-time check, and subsequently assume that item
providers exist. To fix this, flip the compiler-time checks and the order of codeblocks in the
PlatformPasteboard::write methods.

There is no change in behavior.

* platform/ios/PlatformPasteboardIOS.mm:
(WebCore::registerItemToPasteboard):
(WebCore::PlatformPasteboard::write):

Tools:

Check __IPHONE_OS_VERSION_MAX_ALLOWED instead of __IPHONE_OS_VERSION_MIN_REQUIRED in an SPI header. SPI
availability is determined by SDK version rather than deployment version.

* TestWebKitAPI/ios/UIKitSPI.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoNumber each section in ReadMe.md and add more clarifications
rniwa@webkit.org [Thu, 17 Aug 2017 22:03:37 +0000 (22:03 +0000)]
Number each section in ReadMe.md and add more clarifications
https://bugs.webkit.org/show_bug.cgi?id=175687

Rubber-stamped by Joseph Pecoraro.

Numbered each section and added more clarifications per issues Aakash encountered.

* ReadMe.md:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMarked fast/hidpi/hidpi-long-page-with-inset-element.html as a flaky ImageOnlyFailure.
jlewis3@apple.com [Thu, 17 Aug 2017 21:50:37 +0000 (21:50 +0000)]
Marked fast/hidpi/hidpi-long-page-with-inset-element.html as a flaky ImageOnlyFailure.
https://bugs.webkit.org/show_bug.cgi?id=172384

Unreviewed test gardening.

* platform/ios-simulator-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoREGRESSION (r220601): Crash under ProcessAssertion::markAsInvalidated()
cdumez@apple.com [Thu, 17 Aug 2017 21:40:15 +0000 (21:40 +0000)]
REGRESSION (r220601): Crash under ProcessAssertion::markAsInvalidated()
https://bugs.webkit.org/show_bug.cgi?id=175685
<rdar://problem/33868623>

Reviewed by Sam Weinig.

After r220601, it is no longer safe to call a default-initialized WTF::Function.

* UIProcess/ios/ProcessAssertionIOS.mm:
(WebKit::ProcessAssertion::markAsInvalidated):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoBuild fix. Make the test work with the latest versions of node modules.
rniwa@webkit.org [Thu, 17 Aug 2017 21:23:46 +0000 (21:23 +0000)]
Build fix. Make the test work with the latest versions of node modules.

* server-tests/privileged-api-upload-file-tests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago-Wreturn-type warnings in CryptoKey.cpp and SubtleCrypto.cpp
mcatanzaro@igalia.com [Thu, 17 Aug 2017 21:17:34 +0000 (21:17 +0000)]
-Wreturn-type warnings in CryptoKey.cpp and SubtleCrypto.cpp
https://bugs.webkit.org/show_bug.cgi?id=175675

Reviewed by Jiewen Tan.

* crypto/CryptoKey.cpp:
(WebCore::CryptoKey::algorithm const):
* crypto/SubtleCrypto.cpp:
(WebCore::toCryptoKeyUsageBitmap):
(WebCore::toKeyData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWeb Inspector: Styles: replace "Enter Class Name" with "Add New Class"
nvasilyev@apple.com [Thu, 17 Aug 2017 20:54:17 +0000 (20:54 +0000)]
Web Inspector: Styles: replace "Enter Class Name" with "Add New Class"
https://bugs.webkit.org/show_bug.cgi?id=175686

Reviewed by Matt Baker.

"Enter Class Name" isn't very descriptive. It doesn't suggest what's going to happen after you enter a class name.

* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
(WI.CSSStyleDetailsSidebarPanel.prototype.initialLayout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoChanged expectations to include release for memory/memory-pressure-simulation.html.
jlewis3@apple.com [Thu, 17 Aug 2017 20:38:15 +0000 (20:38 +0000)]
Changed expectations to include release for memory/memory-pressure-simulation.html.
https://bugs.webkit.org/show_bug.cgi?id=170629

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWeb Inspector: Ensure three.js gets minified properly for production builds.
commit-queue@webkit.org [Thu, 17 Aug 2017 20:30:12 +0000 (20:30 +0000)]
Web Inspector: Ensure three.js gets minified properly for production builds.
https://bugs.webkit.org/show_bug.cgi?id=175452

Patch by Ross Kirsling <ross.kirsling@sony.com> on 2017-08-17
Reviewed by Brian Burg.

* Scripts/copy-user-interface-resources.pl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWeb Inspector: remove unused private struct from InspectorScriptProfilerAgent
mattbaker@apple.com [Thu, 17 Aug 2017 20:25:32 +0000 (20:25 +0000)]
Web Inspector: remove unused private struct from InspectorScriptProfilerAgent
https://bugs.webkit.org/show_bug.cgi?id=175644

Reviewed by Brian Burg.

* inspector/agents/InspectorScriptProfilerAgent.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoOnly use 16 VFP registers if !CPU(ARM_NEON).
mark.lam@apple.com [Thu, 17 Aug 2017 19:57:46 +0000 (19:57 +0000)]
Only use 16 VFP registers if !CPU(ARM_NEON).
https://bugs.webkit.org/show_bug.cgi?id=175514

Reviewed by JF Bastien.

Source/JavaScriptCore:

Deleted q16-q31 FPQuadRegisterID enums in ARMv7Assembler.h.  The NEON spec
says that there are only 16 128-bit NEON registers.  This change is merely to
correct the code documentation of these registers.  The FPQuadRegisterID are
currently unused.

* assembler/ARMAssembler.h:
(JSC::ARMAssembler::lastFPRegister):
(JSC::ARMAssembler::fprName):
* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::lastFPRegister):
(JSC::ARMv7Assembler::fprName):
* assembler/MacroAssemblerARM.cpp:
* assembler/MacroAssemblerARMv7.cpp:

Source/WTF:

If CPU(ARM_NEON) is not enabled, we'll conservatively assume only VFP2 support is
available. Hence, we'll only the first 16 FPDoubleRegisterIDs are available.

For reference, see:
NEON registers: http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0473c/CJACABEJ.html
VFP2 and VFP3 registers: http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0473c/CIHDIBDG.html
NEON to VFP register mapping: http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0473c/CJAIJHFC.html

This is mostly for GTK toolchains which may target older ARM CPUs which only have
VFP2 support.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoDisable CSS regions at compile time
akling@apple.com [Thu, 17 Aug 2017 19:18:54 +0000 (19:18 +0000)]
Disable CSS regions at compile time
https://bugs.webkit.org/show_bug.cgi?id=175630

Reviewed by Antti Koivisto.

.:

* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsMac.cmake:
* Source/cmake/OptionsWPE.cmake:
* Source/cmake/OptionsWin.cmake:
* Source/cmake/tools/vsprops/FeatureDefines.props:
* Source/cmake/tools/vsprops/FeatureDefinesCairo.props:

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit:

* Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

* Configurations/FeatureDefines.xcconfig:

Tools:

* Scripts/webkitperl/FeatureList.pm:
* TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

LayoutTests:

Skip tests that are entirely about regions, and tweak logic
and/or expectations for tests that test regions in addition to
other things.

* TestExpectations:
* fast/css/will-change/resources/will-change-stacking-helper.js:
* fast/dom/collection-iterators-expected.txt:
* fast/dom/collection-iterators.html:
* js/dom/dom-static-property-for-in-iteration-expected.txt:
* platform/gtk/js/dom/dom-static-property-for-in-iteration-expected.txt:
* platform/ios/fast/dom/collection-iterators-expected.txt:
* platform/mac-wk2/TestExpectations:
* platform/win/js/dom/dom-static-property-for-in-iteration-expected.txt:
* platform/wpe/js/dom/dom-static-property-for-in-iteration-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, try to fix the internal iOS 10 build after r220865.
wenson_hsieh@apple.com [Thu, 17 Aug 2017 19:01:08 +0000 (19:01 +0000)]
Unreviewed, try to fix the internal iOS 10 build after r220865.

* TestWebKitAPI/ios/UIKitSPI.h:

On the iOS 10 SDK, UIApplication_Private.h cannot be imported in the simulator. Simply fall back to using the
extern declaration when building for pre-iOS 11; once the bots stop building for iOS 10, we can safely remove
this compiler guard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[iOS] Respect type fidelities when copying image elements to the pasteboard
wenson_hsieh@apple.com [Thu, 17 Aug 2017 18:34:15 +0000 (18:34 +0000)]
[iOS] Respect type fidelities when copying image elements to the pasteboard
https://bugs.webkit.org/show_bug.cgi?id=175638
<rdar://problem/26556043>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Ensures that we respect type fidelities when copying on iOS, by unifying pasteboard writing codepaths across
dragging and copying. When dragging and copying, we now generate and set UIItemProviders on the UIPasteboard.

Tests: ActionSheetTests.CopyImageElementWithHREF
       ActionSheetTests.CopyImageElementWithoutHREF

* platform/PlatformPasteboard.h:

Remove all variants of the writeObjectRepresentations helper method. Now that both paths for writing to the
pasteboard are unified, it's no longer useful to separate out item-provider-based pasteboard logic.

* platform/ios/AbstractPasteboard.h:
* platform/ios/PlatformPasteboardIOS.mm:

Replaces -setItemsUsingRegistrationInfoLists: with -setRegistrationInfoLists:. Rather than have a helper that
both sets up item providers and item registration lists, split this functionality out into two setters. This is
because UIPasteboard does not need to know about the registration info lists used to set up the item providers
in the first place, but internal drag-and-drop clients require this information immediately when starting a drag
in order to construct custom drag previews.

(WebCore::richTextRepresentationsForPasteboardWebContent):
(WebCore::registerItemToPasteboard):

Add a new helper to register item providers to the pasteboard, given an WebItemProviderRegistrationInfoList.

(WebCore::PlatformPasteboard::write):
(WebCore::PlatformPasteboard::writeObjectRepresentations): Deleted.

Refactors PlatformPasteboard::write to always generate and set item providers, unless we're building for an SDK
prior to iOS 11. For images, strings and URLs, we can simply transition to using the new item-provider-based
codepaths used for drag and drop. For web content, we add two additional UTIs that were present when copying,
but not when dragging: flat RTFD and a string constant used to indicate to UIKit that the pasteboard contains
rich text.

* platform/ios/WebItemProviderPasteboard.h:
* platform/ios/WebItemProviderPasteboard.mm:
(-[WebItemProviderRegistrationInfoList init]):
(-[WebItemProviderRegistrationInfoList addData:forType:]):
(-[WebItemProviderRegistrationInfoList addRepresentingObject:]):
(-[WebItemProviderRegistrationInfoList numberOfItems]):
(-[WebItemProviderRegistrationInfoList itemAtIndex:]):
(-[WebItemProviderRegistrationInfoList itemProvider]):
(-[WebItemProviderRegistrationInfoList description]):

Make some small tweaks in WebItemProviderPasteboard (and related classes):
1. Transition to preferredPresentationSize from estimatedDisplayedSize, which is now deprecated.
2. Remove calls to -initWithItemProviderData:typeIdentifier:error:, which is deprecated.
3. Rename _items to _representations to better reflect the role of WebItemProviderRegistrationInfo.
4. Implement -description for WebItemProviderRegistrationInfoList for debugging purposes.

(-[WebItemProviderPasteboard valuesForPasteboardType:inItemSet:]):
(-[WebItemProviderPasteboard setRegistrationInfoLists:]):
(-[WebItemProviderPasteboard setItemsUsingRegistrationInfoLists:]): Deleted.

Source/WebCore/PAL:

Replace -estimatedDisplayedSize with its non-deprecated counterpart, -preferredPresentationSize.

* pal/spi/ios/UIKitSPI.h:

Source/WebKit:

Currently, we treat the case when copying an image enclosed by a link by only writing a URL to the pasteboard.
This patch tweaks logic in WebPage::performActionOnElement to write both an image and a link to the pasteboard
if the hit-tested image element is enclosed by an anchor.

* Platform/spi/ios/UIKitSPI.h:
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::containingLinkElement):

Tweak this helper to be more restrictive when finding an enclosing 'link' -- only return an element if isLink()
is true, and it is an HTMLAnchorElement. Currently, the isLink() also matches HTMLLinkElements, but this isn't
the intention here.

(WebKit::WebPage::performActionOnElement):

Tools:

Add API tests that simulate copying an image element using the action sheet, and verifying that the pasteboard
contains UTIs in order of fidelity (image type before URL). Also pulls out UIKit SPI (UIApplicationInitialize)
used in UIPasteboardTests and ActionSheetTests into a common UIKitSPI header.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
(-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
(TestWebKitAPI::TEST):
(TestWebKitAPI::presentActionSheetAndChooseAction):
(-[ActionSheetObserver waitForActionSheetAfterBlock:]): Deleted.
* TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
(checkEstimatedSize):
(checkSuggestedNameAndEstimatedSize):

Replace -estimatedDisplayedSize with its non-deprecated counterpart, -preferredPresentationSize.

* TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/ios/DataInteractionSimulator.h:
* TestWebKitAPI/ios/UIKitSPI.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRecursively create resource load statistics folder for testing
jbedard@apple.com [Thu, 17 Aug 2017 18:21:27 +0000 (18:21 +0000)]
Recursively create resource load statistics folder for testing
https://bugs.webkit.org/show_bug.cgi?id=175676

Reviewed by Brady Eidson.

* WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::TestController::cocoaPlatformInitialize): Recursively create resourceLoadStatisticsFolder.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAdd a DOMPromiseDeferred method to handle ExceptionOr<> results
commit-queue@webkit.org [Thu, 17 Aug 2017 18:07:26 +0000 (18:07 +0000)]
Add a DOMPromiseDeferred method to handle ExceptionOr<> results
https://bugs.webkit.org/show_bug.cgi?id=175603

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-17
Reviewed by Darin Adler.

No change of behavior.

Introduce DOMPromiseDeferred::settle to reject/resolve a promise with an ExceptionOr<>.
Making batchPutOperation/batchDeleteOperation take a Function with an ExceptionOr<>.
Using DOMPromiseDeferred::settle in Cache put/remove.
Updated CacheStorageConnection to create ExceptionOr<> from CacheStorageConnection::Error.

* Modules/cache/Cache.cpp:
(WebCore::Cache::put):
(WebCore::Cache::remove):
(WebCore::Cache::batchDeleteOperation):
(WebCore::Cache::batchPutOperation):
* Modules/cache/Cache.h:
* Modules/cache/CacheStorage.cpp:
(WebCore::CacheStorage::open):
(WebCore::CacheStorage::remove):
* Modules/cache/CacheStorageConnection.cpp:
(WebCore::CacheStorageConnection::errorToException):
* Modules/cache/CacheStorageConnection.h:
(WebCore::CacheStorageConnection::errorToException):
(WebCore::CacheStorageConnection::exceptionOrResult):
* bindings/js/JSDOMPromiseDeferred.h:
(WebCore::DOMPromiseDeferred::settle):
(WebCore::DOMPromiseDeferred<void>::settle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[GStreamer] AppendPipeline: support dispatch of decryption-specific GstStructure...
zandobersek@gmail.com [Thu, 17 Aug 2017 16:40:56 +0000 (16:40 +0000)]
[GStreamer] AppendPipeline: support dispatch of decryption-specific GstStructure into the pipeline
https://bugs.webkit.org/show_bug.cgi?id=175668

Reviewed by Xabier Rodriguez-Calvar.

Add the AppendPipeline::dispatchDecryptionStructure() method. Callers can
pass in a GstStructure object that contains all the information the
decryption elements in the pipeline will require to properly decrypt the
content. In case the decryptor element isn't available yet, the
GstStructure is stored and dispatched when that element becomes available.

The dispatch itself simply creates a new custom GstEvent that adopts the
given GstStructure object, sends that into the pipeline element, and
shifts the state to 'ongoing'.

* platform/graphics/gstreamer/mse/AppendPipeline.cpp:
(WebCore::AppendPipeline::connectDemuxerSrcPadToAppsinkFromAnyThread):
(WebCore::AppendPipeline::dispatchPendingDecryptionStructure):
(WebCore::AppendPipeline::dispatchDecryptionStructure):
* platform/graphics/gstreamer/mse/AppendPipeline.h: Remove a redundant private: label.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[GStreamer] GstStructure shouldn't be handled through GRefPtr
zandobersek@gmail.com [Thu, 17 Aug 2017 16:37:28 +0000 (16:37 +0000)]
[GStreamer] GstStructure shouldn't be handled through GRefPtr
https://bugs.webkit.org/show_bug.cgi?id=175673

Reviewed by Xabier Rodriguez-Calvar.

* platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp:
(webkitMediaCommonEncryptionDecryptTransformCaps): GstStructure isn't
ref-counted, so it should be handled through the GUniquePtr<GstStructure>
smart pointer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[WPE][GTK] Ensure proper casting of data in gvariants
commit-queue@webkit.org [Thu, 17 Aug 2017 16:17:19 +0000 (16:17 +0000)]
[WPE][GTK] Ensure proper casting of data in gvariants
https://bugs.webkit.org/show_bug.cgi?id=175667

Patch by Jacobo Aragunde Pérez <jaragunde@igalia.com> on 2017-08-17
Reviewed by Michael Catanzaro.

Source/JavaScriptCore:

g_variant_new requires data to have the correct width for their types, using
casting if necessary. Some data of type `unsigned` were being saved to `guint64`
types without explicit casting, leading to undefined behavior in some platforms.

* inspector/remote/glib/RemoteInspectorGlib.cpp:
(Inspector::RemoteInspector::listingForInspectionTarget const):
(Inspector::RemoteInspector::listingForAutomationTarget const):
(Inspector::RemoteInspector::sendMessageToRemote):

Source/WebKit:

g_variant_builder_add requires data to have the correct width for their types, using
casting if necessary. Corrected a call where a single precision float was being put
into a double precision parameter without a cast.

* UIProcess/API/glib/WebKitWebViewSessionState.cpp:
(encodeFrameState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Mac/iOS] Increase the audio buffer size when audio capture is on but web audio is...
commit-queue@webkit.org [Thu, 17 Aug 2017 16:11:07 +0000 (16:11 +0000)]
[Mac/iOS] Increase the audio buffer size when audio capture is on but web audio is not used
https://bugs.webkit.org/show_bug.cgi?id=175631

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-17
Reviewed by Eric Carlson.

* platform/audio/cocoa/MediaSessionManagerCocoa.cpp:
(PlatformMediaSessionManager::updateSessionState): Change value from 128 to the equivalent of 20ms when audio capture happens but not web audio.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRenderListItem - Avoid render tree mutation during layout
antti@apple.com [Thu, 17 Aug 2017 15:19:38 +0000 (15:19 +0000)]
RenderListItem - Avoid render tree mutation during layout
https://bugs.webkit.org/show_bug.cgi?id=175666

Reviewed by Andreas Kling.

Source/WebCore:

Mutations should be done by RenderTreeUpdater only.

* rendering/RenderListItem.cpp:
(WebCore::RenderListItem::updateMarkerRenderer):

    This is now called by RenderTreeUpdater only.
    Remove code dealing with this being called at layout time.
    Merged marker construction code from styleDidChange here and renamed for clarity.

(WebCore::RenderListItem::layout):
(WebCore::RenderListItem::computePreferredLogicalWidths):

    Remove mutating calls.

(WebCore::RenderListItem::styleDidChange): Deleted.
(WebCore::RenderListItem::insertOrMoveMarkerRendererIfNeeded): Deleted.
* rendering/RenderListItem.h:
* rendering/TextAutoSizing.cpp:
(WebCore::TextAutoSizingValue::adjustTextNodeSizes):

    Call updateMarkerRenderer.

* style/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::popParent):
(WebCore::RenderTreeUpdater::updateBeforeOrAfterPseudoElement):

    Call updateMarkerRenderer.

LayoutTests:

Changes in render tree dumps that don't affect rendering.

* platform/ios/fast/doctypes/002-expected.txt:
* platform/ios/fast/lists/marker-before-empty-inline-expected.txt:
* platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
* platform/mac/fast/doctypes/002-expected.txt:
* platform/mac/fast/lists/marker-before-empty-inline-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[PAL] Move SessionID into PAL
don.olmstead@sony.com [Thu, 17 Aug 2017 15:17:02 +0000 (15:17 +0000)]
[PAL] Move SessionID into PAL
https://bugs.webkit.org/show_bug.cgi?id=174192

Reviewed by Antti Koivisto.

Source/WebCore:

No new tests. No change in behavior.

* CMakeLists.txt:
* Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::connect):
* WebCore.xcodeproj/project.pbxproj:
* dom/Document.cpp:
(WebCore::Document::sessionID const):
* dom/Document.h:
* dom/ScriptExecutionContext.h:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::elementWithID):
(WebCore::HTMLMediaElement::finishParsingChildren):
(WebCore::HTMLMediaElement::scheduleEvent):
(WebCore::HTMLMediaElement::canPlayType const):
(WebCore::HTMLMediaElement::load):
(WebCore::HTMLMediaElement::loadResource):
(WebCore::HTMLMediaElement::textTracksAreReady const):
(WebCore::HTMLMediaElement::textTrackModeChanged):
(WebCore::HTMLMediaElement::noneSupported):
(WebCore::HTMLMediaElement::mediaLoadingFailedFatally):
(WebCore::HTMLMediaElement::mediaLoadingFailed):
(WebCore::HTMLMediaElement::setReadyState):
(WebCore::HTMLMediaElement::addPlayedRange):
(WebCore::HTMLMediaElement::seekTask):
(WebCore::HTMLMediaElement::refreshCachedTime const):
(WebCore::HTMLMediaElement::currentMediaTime const):
(WebCore::HTMLMediaElement::setWebkitPreservesPitch):
(WebCore::HTMLMediaElement::ended const):
(WebCore::HTMLMediaElement::playInternal):
(WebCore::HTMLMediaElement::pause):
(WebCore::HTMLMediaElement::togglePlayState):
(WebCore::HTMLMediaElement::beginScrubbing):
(WebCore::HTMLMediaElement::playbackProgressTimerFired):
(WebCore::HTMLMediaElement::mediaPlayerDidAddTextTrack):
(WebCore::HTMLMediaElement::didAddTextTrack):
(WebCore::HTMLMediaElement::didRemoveTextTrack):
(WebCore::controllerJSValue):
(WebCore::HTMLMediaElement::configureTextTracks):
(WebCore::HTMLMediaElement::selectNextSourceChild):
(WebCore::HTMLMediaElement::sourceWasAdded):
(WebCore::HTMLMediaElement::sourceWasRemoved):
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
(WebCore::HTMLMediaElement::mediaPlayerCharacteristicChanged):
(WebCore::HTMLMediaElement::potentiallyPlaying const):
(WebCore::HTMLMediaElement::endedPlayback const):
(WebCore::HTMLMediaElement::stoppedDueToErrors const):
(WebCore::HTMLMediaElement::updatePlayState):
(WebCore::HTMLMediaElement::userCancelledLoad):
(WebCore::HTMLMediaElement::canSuspendForDocumentSuspension const):
(WebCore::HTMLMediaElement::addEventListener):
(WebCore::HTMLMediaElement::isFullscreen const):
(WebCore::HTMLMediaElement::toggleStandardFullscreenState):
(WebCore::HTMLMediaElement::waitForPreparedForInlineThen):
(WebCore::HTMLMediaElement::setVideoFullscreenLayer):
(WebCore::HTMLMediaElement::updateTextTrackDisplay):
(WebCore::HTMLMediaElement::mediaControls const):
(WebCore::HTMLMediaElement::configureTextTrackDisplay):
(WebCore::HTMLMediaElement::setMediaGroup):
(WebCore::HTMLMediaElement::setControllerForBindings):
(WebCore::HTMLMediaElement::isBlockedOnMediaController const):
(WebCore::HTMLMediaElement::prepareMediaFragmentURI):
(WebCore::HTMLMediaElement::didAddUserAgentShadowRoot):
(WebCore::HTMLMediaElement::fileSize const):
(WebCore::HTMLMediaElement::mediaSessionTitle const):
(WebCore::needsSeekingSupportQuirk):
(WebCore::HTMLMediaElement::supportsSeeking const):
(WebCore::HTMLMediaElement::doesHaveAttribute const):
(WebCore::HTMLMediaElement::isVideoTooSmallForInlinePlayback):
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::continueAfterContentPolicy):
* loader/EmptyClients.cpp:
* loader/FrameLoaderClient.h:
* loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
* loader/cache/CachedCSSStyleSheet.h:
* loader/cache/CachedFont.cpp:
(WebCore::CachedFont::CachedFont):
* loader/cache/CachedFont.h:
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::CachedImage):
* loader/cache/CachedImage.h:
* loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::CachedRawResource):
* loader/cache/CachedRawResource.h:
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::CachedResource):
* loader/cache/CachedResource.h:
(WebCore::CachedResource::sessionID const):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::createResource):
(WebCore::CachedResourceLoader::sessionID const):
* loader/cache/CachedResourceLoader.h:
* loader/cache/CachedSVGDocument.cpp:
(WebCore::CachedSVGDocument::CachedSVGDocument):
* loader/cache/CachedSVGDocument.h:
* loader/cache/CachedSVGFont.cpp:
(WebCore::CachedSVGFont::CachedSVGFont):
* loader/cache/CachedSVGFont.h:
* loader/cache/CachedScript.cpp:
(WebCore::CachedScript::CachedScript):
* loader/cache/CachedScript.h:
* loader/cache/CachedTextTrack.cpp:
(WebCore::CachedTextTrack::CachedTextTrack):
* loader/cache/CachedTextTrack.h:
* loader/cache/CachedXSLStyleSheet.cpp:
(WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
* loader/cache/CachedXSLStyleSheet.h:
* loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::sessionResourceMap const):
(WebCore::MemoryCache::ensureSessionResourceMap):
(WebCore::MemoryCache::resourceForRequest):
(WebCore::MemoryCache::addImageToCache):
(WebCore::MemoryCache::removeImageFromCache):
(WebCore::MemoryCache::forEachSessionResource):
(WebCore::MemoryCache::removeResourcesWithOrigins):
(WebCore::MemoryCache::originsWithCache const):
(WebCore::MemoryCache::evictResources):
* loader/cache/MemoryCache.h:
* loader/cocoa/DiskCacheMonitorCocoa.h:
(WebCore::DiskCacheMonitor::sessionID const):
* loader/cocoa/DiskCacheMonitorCocoa.mm:
(WebCore::DiskCacheMonitor::monitorFileBackingStoreCreation):
(WebCore::DiskCacheMonitor::DiskCacheMonitor):
* page/CacheStorageProvider.h:
* page/DatabaseProvider.h:
* page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::enableLegacyPrivateBrowsing):
(WebCore::Page::sessionID const):
(WebCore::Page::setSessionID):
* page/Page.h:
* page/PlugInClient.h:
* page/SocketProvider.cpp:
(WebCore::SocketProvider::createSocketStreamHandle):
* page/SocketProvider.h:
* platform/CookiesStrategy.h:
* platform/WebCoreCrossThreadCopier.cpp:
(WTF::PAL::SessionID>::copy):
(WTF::WebCore::SessionID>::copy): Deleted.
* platform/WebCoreCrossThreadCopier.h:
* platform/network/CacheValidation.cpp:
(WebCore::headerValueForVary):
(WebCore::collectVaryingRequestHeaders):
(WebCore::verifyVaryingRequestHeaders):
* platform/network/CacheValidation.h:
* platform/network/NetworkStorageSession.cpp:
(WebCore::NetworkStorageSession::globalSessionMap):
(WebCore::NetworkStorageSession::storageSession):
(WebCore::NetworkStorageSession::destroySession):
* platform/network/NetworkStorageSession.h:
(WebCore::NetworkStorageSession::sessionID const):
* platform/network/NetworkStorageSessionStub.cpp:
(WebCore::NetworkStorageSession::NetworkStorageSession):
(WebCore::NetworkStorageSession::ensurePrivateBrowsingSession):
(WebCore::NetworkStorageSession::ensureSession):
(WebCore::NetworkStorageSession::defaultStorageSession):
* platform/network/cf/NetworkStorageSessionCFNet.cpp:
(WebCore::NetworkStorageSession::NetworkStorageSession):
(WebCore::NetworkStorageSession::switchToNewTestingSession):
(WebCore::NetworkStorageSession::defaultStorageSession):
(WebCore::NetworkStorageSession::ensurePrivateBrowsingSession):
(WebCore::NetworkStorageSession::ensureSession):
* platform/network/cf/SocketStreamHandleImpl.h:
(WebCore::SocketStreamHandleImpl::create):
* platform/network/cf/SocketStreamHandleImplCFNet.cpp:
(WebCore::SocketStreamHandleImpl::SocketStreamHandleImpl):
* platform/network/curl/SocketStreamHandleImpl.h:
(WebCore::SocketStreamHandleImpl::create):
* platform/network/soup/NetworkStorageSessionSoup.cpp:
(WebCore::NetworkStorageSession::NetworkStorageSession):
(WebCore::NetworkStorageSession::defaultStorageSession):
(WebCore::NetworkStorageSession::ensurePrivateBrowsingSession):
(WebCore::NetworkStorageSession::ensureSession):
(WebCore::NetworkStorageSession::switchToNewTestingSession):
* platform/network/soup/SocketStreamHandleImpl.h:
* platform/network/soup/SocketStreamHandleImplSoup.cpp:
(WebCore::SocketStreamHandleImpl::create):
* workers/DedicatedWorkerGlobalScope.cpp:
(WebCore::DedicatedWorkerGlobalScope::create):
(WebCore::DedicatedWorkerGlobalScope::DedicatedWorkerGlobalScope):
* workers/DedicatedWorkerGlobalScope.h:
* workers/DedicatedWorkerThread.cpp:
(WebCore::DedicatedWorkerThread::DedicatedWorkerThread):
(WebCore::DedicatedWorkerThread::createWorkerGlobalScope):
* workers/DedicatedWorkerThread.h:
* workers/Worker.cpp:
(WebCore::Worker::notifyFinished):
* workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::WorkerGlobalScope):
* workers/WorkerGlobalScope.h:
* workers/WorkerGlobalScopeProxy.h:
* workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::startWorkerGlobalScope):
* workers/WorkerMessagingProxy.h:
* workers/WorkerThread.cpp:
(WebCore::WorkerThreadStartupData::WorkerThreadStartupData):
(WebCore::WorkerThread::WorkerThread):
* workers/WorkerThread.h:
* workers/service/ServiceWorkerContainer.h:
* workers/service/ServiceWorkerRegistrationParameters.h:

Source/WebCore/PAL:

* PAL.xcodeproj/project.pbxproj:
* pal/CMakeLists.txt:
* pal/identifier/SessionID.cpp: Renamed from Source/WebCore/page/SessionID.cpp.
* pal/identifier/SessionID.h: Renamed from Source/WebCore/page/SessionID.h.
(WTF::SessionIDHash::hash):
(WTF::SessionIDHash::equal):
(WTF::HashTraits<PAL::SessionID>::emptyValue):
(WTF::HashTraits<PAL::SessionID>::constructDeletedValue):
(WTF::HashTraits<PAL::SessionID>::isDeletedValue):

Source/WebKit:

* NetworkProcess/Downloads/Download.cpp:
(WebKit::Download::Download):
* NetworkProcess/Downloads/Download.h:
(WebKit::Download::Download):
* NetworkProcess/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::startDownload):
(WebKit::DownloadManager::resumeDownload):
* NetworkProcess/Downloads/DownloadManager.h:
(WebKit::DownloadManager::startDownload):
* NetworkProcess/NetworkCORSPreflightChecker.h:
* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::createSocketStream):
(WebKit::storageSession):
(WebKit::NetworkConnectionToWebProcess::startDownload):
(WebKit::NetworkConnectionToWebProcess::convertMainResourceLoadToDownload):
(WebKit::NetworkConnectionToWebProcess::cookiesForDOM):
(WebKit::NetworkConnectionToWebProcess::setCookiesFromDOM):
(WebKit::NetworkConnectionToWebProcess::cookiesEnabled):
(WebKit::NetworkConnectionToWebProcess::cookieRequestHeaderFieldValue):
(WebKit::NetworkConnectionToWebProcess::getRawCookies):
(WebKit::NetworkConnectionToWebProcess::deleteCookie):
(WebKit::NetworkConnectionToWebProcess::ensureLegacyPrivateBrowsingSession):
* NetworkProcess/NetworkConnectionToWebProcess.h:
(WebKit::NetworkConnectionToWebProcess::startDownload):
* NetworkProcess/NetworkConnectionToWebProcess.messages.in:
* NetworkProcess/NetworkLoad.cpp:
* NetworkProcess/NetworkLoadParameters.h:
* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit::NetworkProcess::destroySession):
(WebKit::fetchDiskCacheEntries):
(WebKit::NetworkProcess::fetchWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteDataForOrigins):
(WebKit::NetworkProcess::downloadRequest):
(WebKit::NetworkProcess::resumeDownload):
* NetworkProcess/NetworkProcess.h:
* NetworkProcess/NetworkProcess.messages.in:
* NetworkProcess/NetworkResourceLoadParameters.h:
* NetworkProcess/NetworkResourceLoader.h:
* NetworkProcess/NetworkSession.cpp:
(WebKit::NetworkSession::create):
(WebKit::NetworkSession::defaultSession):
(WebKit::NetworkSession::NetworkSession):
* NetworkProcess/NetworkSession.h:
(WebKit::NetworkSession::sessionID const):
* NetworkProcess/NetworkSocketStream.cpp:
(WebKit::NetworkSocketStream::create):
(WebKit::NetworkSocketStream::NetworkSocketStream):
* NetworkProcess/NetworkSocketStream.h:
* NetworkProcess/RemoteNetworkingContext.h:
* NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:
(WebKit::NetworkCache::SpeculativeLoad::SpeculativeLoad):
* NetworkProcess/cocoa/NetworkSessionCocoa.h:
* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::configurationForSessionID):
(WebKit::NetworkSessionCocoa::create):
(WebKit::NetworkSessionCocoa::defaultSession):
(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
* NetworkProcess/soup/NetworkSessionSoup.cpp:
(WebKit::NetworkSessionSoup::NetworkSessionSoup):
* NetworkProcess/soup/NetworkSessionSoup.h:
* Scripts/webkit/messages.py:
(forward_declarations_and_headers.templates): Deleted.
(class_template_headers.template): Deleted.
* Shared/ChildProcess.cpp:
(WebKit::ChildProcess::initialize):
* Shared/SessionTracker.cpp:
(WebKit::staticSessionMap):
(WebKit::SessionTracker::networkSession):
(WebKit::SessionTracker::setSession):
(WebKit::SessionTracker::destroySession):
* Shared/SessionTracker.h:
* Shared/Storage/StorageProcessCreationParameters.h:
* Shared/WebCoreArgumentCoders.cpp:
* Shared/WebCoreArgumentCoders.h:
* Shared/WebPageCreationParameters.h:
* Shared/WebProcessCreationParameters.h:
* Shared/WebsiteDataStoreParameters.h:
* Shared/mac/CookieStorageShim.mm:
(WebKit::webKitCookieStorageCopyRequestHeaderFieldsForURL):
* StorageProcess/IndexedDB/WebIDBConnectionToClient.cpp:
(WebKit::WebIDBConnectionToClient::create):
(WebKit::WebIDBConnectionToClient::WebIDBConnectionToClient):
* StorageProcess/IndexedDB/WebIDBConnectionToClient.h:
* StorageProcess/StorageProcess.cpp:
(WebKit::StorageProcess::idbServer):
(WebKit::StorageProcess::fetchWebsiteData):
(WebKit::StorageProcess::deleteWebsiteData):
(WebKit::StorageProcess::deleteWebsiteDataForOrigins):
* StorageProcess/StorageProcess.h:
* StorageProcess/StorageProcess.messages.in:
* StorageProcess/StorageToWebProcessConnection.cpp:
(WebKit::StorageToWebProcessConnection::establishIDBConnectionToServer):
* StorageProcess/StorageToWebProcessConnection.h:
* StorageProcess/StorageToWebProcessConnection.messages.in:
* UIProcess/API/APIPageConfiguration.cpp:
(API::PageConfiguration::setWebsiteDataStore):
(API::PageConfiguration::sessionID):
(API::PageConfiguration::setSessionID):
* UIProcess/API/APIPageConfiguration.h:
* UIProcess/API/APIWebsiteDataStore.cpp:
(API::WebsiteDataStore::defaultDataStore):
(API::WebsiteDataStore::createLegacy):
(API::WebsiteDataStore::WebsiteDataStore):
* UIProcess/API/APIWebsiteDataStore.h:
* UIProcess/API/C/WKCookieManager.cpp:
(WKCookieManagerGetHostnamesWithCookies):
(WKCookieManagerDeleteCookiesForHostname):
(WKCookieManagerDeleteAllCookies):
(WKCookieManagerDeleteAllCookiesModifiedAfterDate):
(WKCookieManagerSetHTTPCookieAcceptPolicy):
(WKCookieManagerGetHTTPCookieAcceptPolicy):
(WKCookieManagerStartObservingCookieChanges):
(WKCookieManagerStopObservingCookieChanges):
* UIProcess/API/Cocoa/WKProcessPool.mm:
(-[WKProcessPool _setCookieAcceptPolicy:]):
* UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(-[WKWebsiteDataStore _initWithConfiguration:]):
* UIProcess/API/glib/WebKitCookieManager.cpp:
(webkit_cookie_manager_set_accept_policy):
(webkit_cookie_manager_get_accept_policy):
* UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::fetchWebsiteData):
(WebKit::NetworkProcessProxy::deleteWebsiteData):
(WebKit::NetworkProcessProxy::deleteWebsiteDataForOrigins):
* UIProcess/Network/NetworkProcessProxy.h:
* UIProcess/Plugins/PlugInAutoStartProvider.cpp:
(WebKit::PlugInAutoStartProvider::PlugInAutoStartProvider):
(WebKit::PlugInAutoStartProvider::addAutoStartOriginHash):
(WebKit::PlugInAutoStartProvider::autoStartOriginsTableCopy const):
(WebKit::PlugInAutoStartProvider::setAutoStartOriginsTableWithItemsPassingTest):
(WebKit::PlugInAutoStartProvider::didReceiveUserInteraction):
* UIProcess/Plugins/PlugInAutoStartProvider.h:
* UIProcess/Storage/StorageProcessProxy.cpp:
(WebKit::StorageProcessProxy::fetchWebsiteData):
(WebKit::StorageProcessProxy::deleteWebsiteData):
(WebKit::StorageProcessProxy::deleteWebsiteDataForOrigins):
* UIProcess/Storage/StorageProcessProxy.h:
* UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::getHostnamesWithCookies):
(WebKit::WebCookieManagerProxy::deleteCookiesForHostname):
(WebKit::WebCookieManagerProxy::deleteAllCookies):
(WebKit::WebCookieManagerProxy::deleteCookie):
(WebKit::WebCookieManagerProxy::deleteAllCookiesModifiedSince):
(WebKit::WebCookieManagerProxy::setCookie):
(WebKit::WebCookieManagerProxy::setCookies):
(WebKit::WebCookieManagerProxy::getAllCookies):
(WebKit::WebCookieManagerProxy::getCookies):
(WebKit::WebCookieManagerProxy::startObservingCookieChanges):
(WebKit::WebCookieManagerProxy::stopObservingCookieChanges):
(WebKit::WebCookieManagerProxy::setCookieObserverCallback):
(WebKit::WebCookieManagerProxy::registerObserver):
(WebKit::WebCookieManagerProxy::unregisterObserver):
(WebKit::WebCookieManagerProxy::cookiesDidChange):
(WebKit::WebCookieManagerProxy::setHTTPCookieAcceptPolicy):
(WebKit::WebCookieManagerProxy::getHTTPCookieAcceptPolicy):
* UIProcess/WebCookieManagerProxy.h:
* UIProcess/WebCookieManagerProxy.messages.in:
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::sessionID const):
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::setAnyPageGroupMightHavePrivateBrowsingEnabled):
(WebKit::WebProcessPool::createNewWebProcess):
(WebKit::WebProcessPool::createWebPage):
(WebKit::WebProcessPool::pageAddedToProcess):
(WebKit::WebProcessPool::pageRemovedFromProcess):
(WebKit::WebProcessPool::download):
(WebKit::WebProcessPool::resumeDownload):
(WebKit::WebProcessPool::addPlugInAutoStartOriginHash):
(WebKit::WebProcessPool::plugInDidReceiveUserInteraction):
* UIProcess/WebProcessPool.h:
* UIProcess/WebProcessPool.messages.in:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::deleteWebsiteDataForTopPrivatelyControlledDomainsInAllPersistentDataStores):
(WebKit::WebProcessProxy::topPrivatelyControlledDomainsWithWebsiteData):
(WebKit::WebProcessProxy::fetchWebsiteData):
(WebKit::WebProcessProxy::deleteWebsiteData):
(WebKit::WebProcessProxy::deleteWebsiteDataForOrigins):
* UIProcess/WebProcessProxy.h:
* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::createNonPersistent):
(WebKit::WebsiteDataStore::create):
(WebKit::WebsiteDataStore::WebsiteDataStore):
(WebKit::WebsiteDataStore::~WebsiteDataStore):
* UIProcess/WebsiteData/WebsiteDataStore.h:
(WebKit::WebsiteDataStore::sessionID const):
* WebProcess/Cookies/WebCookieManager.cpp:
(WebKit::WebCookieManager::getHostnamesWithCookies):
(WebKit::WebCookieManager::deleteCookiesForHostname):
(WebKit::WebCookieManager::deleteAllCookies):
(WebKit::WebCookieManager::deleteCookie):
(WebKit::WebCookieManager::deleteAllCookiesModifiedSince):
(WebKit::WebCookieManager::getAllCookies):
(WebKit::WebCookieManager::getCookies):
(WebKit::WebCookieManager::setCookie):
(WebKit::WebCookieManager::setCookies):
(WebKit::WebCookieManager::notifyCookiesDidChange):
(WebKit::WebCookieManager::startObservingCookieChanges):
(WebKit::WebCookieManager::stopObservingCookieChanges):
* WebProcess/Cookies/WebCookieManager.h:
* WebProcess/Cookies/WebCookieManager.messages.in:
* WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp:
(WebKit::WebIDBConnectionToServer::create):
(WebKit::WebIDBConnectionToServer::WebIDBConnectionToServer):
* WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h:
* WebProcess/Databases/WebDatabaseProvider.cpp:
(WebKit::WebDatabaseProvider::idbConnectionToServerForSession):
* WebProcess/Databases/WebDatabaseProvider.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setPrivateBrowsingEnabled):
* WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::didCacheResource):
* WebProcess/Network/NetworkProcessConnection.h:
* WebProcess/Network/NetworkProcessConnection.messages.in:
* WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::scheduleLoad):
(WebKit::WebLoaderStrategy::loadResourceSynchronously):
(WebKit::WebLoaderStrategy::createPingHandle):
* WebProcess/Network/WebSocketProvider.cpp:
(WebKit::WebSocketProvider::createSocketStreamHandle):
* WebProcess/Network/WebSocketProvider.h:
* WebProcess/Network/WebSocketStream.cpp:
(WebKit::WebSocketStream::create):
(WebKit::WebSocketStream::WebSocketStream):
* WebProcess/Network/WebSocketStream.h:
* WebProcess/Storage/WebToStorageProcessConnection.cpp:
(WebKit::WebToStorageProcessConnection::idbConnectionToServerForSession):
* WebProcess/Storage/WebToStorageProcessConnection.h:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::convertMainResourceLoadToDownload):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::cookieRequestHeaderFieldValue):
* WebProcess/WebCoreSupport/WebPlatformStrategies.h:
* WebProcess/WebCoreSupport/WebPlugInClient.cpp:
(WebKit::WebPlugInClient::didStartFromOrigin):
* WebProcess/WebCoreSupport/WebPlugInClient.h:
* WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
* WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
* WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:
(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
* WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h:
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::startDownload):
(WebKit::WebFrame::convertMainResourceLoadToDownload):
* WebProcess/WebPage/WebFrame.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setSessionID):
(WebKit::WebPage::updatePreferences):
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::sessionID const):
* WebProcess/WebProcess.cpp:
(WebKit::m_webSQLiteDatabaseTracker):
(WebKit::WebProcess::ensurePrivateBrowsingSession):
(WebKit::WebProcess::destroySession):
(WebKit::WebProcess::isPlugInAutoStartOriginHash):
(WebKit::WebProcess::plugInDidStartFromOrigin):
(WebKit::WebProcess::didAddPlugInAutoStartOriginHash):
(WebKit::WebProcess::resetPlugInAutoStartOriginDefaultHashes):
(WebKit::WebProcess::resetPlugInAutoStartOriginHashes):
(WebKit::WebProcess::plugInDidReceiveUserInteraction):
(WebKit::WebProcess::fetchWebsiteData):
(WebKit::WebProcess::deleteWebsiteData):
(WebKit::WebProcess::deleteWebsiteDataForOrigins):
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in:

Source/WebKitLegacy:

* Storage/WebDatabaseProvider.cpp:
(WebDatabaseProvider::idbConnectionToServerForSession):
* Storage/WebDatabaseProvider.h:

Source/WebKitLegacy/mac:

* Misc/WebCache.mm:
(+[WebCache imageForURL:]):
* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::convertMainResourceLoadToDownload):
* WebCoreSupport/WebFrameNetworkingContext.mm:
(WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebFrameNetworkingContext::destroyPrivateBrowsingSession):
(WebFrameNetworkingContext::storageSession const):
* WebCoreSupport/WebPlatformStrategies.h:
* WebCoreSupport/WebPlatformStrategies.mm:
(WebPlatformStrategies::cookieRequestHeaderFieldValue):
* WebKitPrefix.h:

Source/WebKitLegacy/win:

* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::convertMainResourceLoadToDownload):
* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameNetworkingContext.cpp:
(WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
(WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebFrameNetworkingContext::destroyPrivateBrowsingSession):
(WebFrameNetworkingContext::storageSession const):
* WebCoreSupport/WebPlatformStrategies.cpp:
(WebPlatformStrategies::cookieRequestHeaderFieldValue):
* WebCoreSupport/WebPlatformStrategies.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoFix typo: setUpInectedBundleClient
commit-queue@webkit.org [Thu, 17 Aug 2017 14:58:51 +0000 (14:58 +0000)]
Fix typo: setUpInectedBundleClient
https://bugs.webkit.org/show_bug.cgi?id=175655

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2017-08-17
Reviewed by Andreas Kling.

* UIProcess/API/Cocoa/WKProcessGroup.mm:
(setUpInjectedBundleClient):
(-[WKProcessGroup initWithInjectedBundleURL:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[GTK][WPE] Add NTLM authentication enabled API
carlosgc@webkit.org [Thu, 17 Aug 2017 13:13:32 +0000 (13:13 +0000)]
[GTK][WPE] Add NTLM authentication enabled API
https://bugs.webkit.org/show_bug.cgi?id=122952

Reviewed by Michael Catanzaro.

Source/WebCore:

Add/remove NTLM feature to/from soup session depending on whether the feature is enabled or disabled.

* platform/network/soup/SoupNetworkSession.cpp:
(WebCore::SoupNetworkSession::SoupNetworkSession):
(WebCore::SoupNetworkSession::setInitialNTLMAuthenticationEnabled):
(WebCore::SoupNetworkSession::setNTLMAuthenticationEnabled):
* platform/network/soup/SoupNetworkSession.h:

Source/WebKit:

Add API to WebKitWebContext to enable/disable NTLM authentication.

* NetworkProcess/NetworkProcess.h:
* NetworkProcess/NetworkProcess.messages.in:
* NetworkProcess/NetworkProcessCreationParameters.cpp:
(WebKit::NetworkProcessCreationParameters::encode const):
(WebKit::NetworkProcessCreationParameters::decode):
* NetworkProcess/NetworkProcessCreationParameters.h:
* NetworkProcess/soup/NetworkProcessSoup.cpp:
(WebKit::NetworkProcess::platformInitializeNetworkProcess):
(WebKit::NetworkProcess::setNTLMAuthenticationEnabled):
* UIProcess/API/glib/WebKitWebContext.cpp:
(webkit_web_context_get_ntlm_authentication_enabled):
(webkit_web_context_set_ntlm_authentication_enabled):
* UIProcess/API/gtk/WebKitWebContext.h:
* UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt:
* UIProcess/API/wpe/WebKitWebContext.h:
* UIProcess/WebProcessPool.h:
* UIProcess/soup/WebProcessPoolSoup.cpp:
(WebKit::WebProcessPool::setNTLMAuthenticationEnabled):

Tools:

Add a test case to check we can enable/disable NTLM.

* TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
(testWebViewAuthenticationNTLM):
(beforeAll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoREGRESSION(r220751): [GTK] Layout Test imported/w3c/web-platform-tests/fetch/api...
commit-queue@webkit.org [Thu, 17 Aug 2017 12:41:32 +0000 (12:41 +0000)]
REGRESSION(r220751): [GTK] Layout Test imported/w3c/web-platform-tests/fetch/api/basic/scheme-about.any.html is failing
https://bugs.webkit.org/show_bug.cgi?id=175641

Unreviewed test gardening.

Correct the error message in scheme-about.any-expected.txt.

Patch by Ms2ger <Ms2ger@gmail.com> on 2017-08-17

* platform/gtk/imported/w3c/web-platform-tests/fetch/api/basic/scheme-about.any-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[JSC] Avoid code bloating for iteration if block does not have "break"
utatane.tea@gmail.com [Thu, 17 Aug 2017 12:15:48 +0000 (12:15 +0000)]
[JSC] Avoid code bloating for iteration if block does not have "break"
https://bugs.webkit.org/show_bug.cgi?id=173228

Reviewed by Keith Miller.

Currently, we always emit code for breaked path when emitting for-of iteration.
But we can know that this breaked path can be used when emitting the bytecode.

This patch adds LabelScope::breakTargetMayBeBound(), which returns true if
the break label may be bound. We emit a breaked path only when it returns
true. This reduces bytecode bloating when using for-of iteration.

* bytecompiler/BytecodeGenerator.cpp:
(JSC::Label::setLocation):
(JSC::BytecodeGenerator::newLabel):
(JSC::BytecodeGenerator::emitLabel):
(JSC::BytecodeGenerator::pushFinallyControlFlowScope):
(JSC::BytecodeGenerator::breakTarget):
(JSC::BytecodeGenerator::continueTarget):
(JSC::BytecodeGenerator::emitEnumeration):
* bytecompiler/BytecodeGenerator.h:
* bytecompiler/Label.h:
(JSC::Label::bind const):
(JSC::Label::hasOneRef const):
(JSC::Label::isBound const):
(JSC::Label::Label): Deleted.
* bytecompiler/LabelScope.h:
(JSC::LabelScope::hasOneRef const):
(JSC::LabelScope::breakTargetMayBeBound const):
* bytecompiler/NodesCodegen.cpp:
(JSC::ContinueNode::trivialTarget):
(JSC::ContinueNode::emitBytecode):
(JSC::BreakNode::trivialTarget):
(JSC::BreakNode::emitBytecode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[GTK] Unreviewed test gardening
commit-queue@webkit.org [Thu, 17 Aug 2017 10:02:08 +0000 (10:02 +0000)]
[GTK] Unreviewed test gardening
https://bugs.webkit.org/show_bug.cgi?id=175664

Unreviewed test gardening.

Patch by Ms2ger <Ms2ger@gmail.com> on 2017-08-17

* platform/gtk/TestExpectations: update.
* platform/gtk/crypto/subtle/rsa-generate-key-malformed-parameters-expected.txt: rebaseline for change in r220811.
* platform/wpe/crypto/subtle/rsa-generate-key-malformed-parameters-expected.txt: rebaseline for change in r220811.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoARM build fix after r220807 and r220834.
ossy@webkit.org [Thu, 17 Aug 2017 08:45:12 +0000 (08:45 +0000)]
ARM build fix after r220807 and r220834.
https://bugs.webkit.org/show_bug.cgi?id=175617

Unreviewed typo fix.

* assembler/MacroAssemblerARM.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoGardening: build fix for ARM_TRADITIONAL after r220807.
mark.lam@apple.com [Thu, 17 Aug 2017 07:04:19 +0000 (07:04 +0000)]
Gardening: build fix for ARM_TRADITIONAL after r220807.
https://bugs.webkit.org/show_bug.cgi?id=175617

Not reviewed.

* assembler/MacroAssemblerARM.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAdd the support for mutating clipboard data via DataTransferItemList
rniwa@webkit.org [Thu, 17 Aug 2017 06:17:09 +0000 (06:17 +0000)]
Add the support for mutating clipboard data via DataTransferItemList
https://bugs.webkit.org/show_bug.cgi?id=175639

Reviewed by Wenson Hsieh.

Source/WebCore:

Added the support for adding plaintext data via dataTransfer.items.add, clearing data via clear,
and removing an entry via remove. When DataTransferItem is removed from DataTransferItemList,
we must put into the disabled mode.

To support the removal of DataTransferItem, this patch replaces a reference to DataTransfer by
a WeakPtr to DataTransferItemList, and stops forwarding ref from DataTransferItem to DataTransfer.
This means that DataTransfer can now be GC'ed before DataTransferItem is GC'ed.

Because the identify and the order of DataTransferItems need to be preserved, we can't simply
re-popluate m_itemList in DataTransferItemList. Instead, whenever the clipboard content is mutated,
we make the parallel modifications to m_itemList. This includes changes made via DataTransfer
methods such as setData and clearData.

Test: editing/pasteboard/datatransfer-items-copy-plaintext.html

* dom/DataTransfer.cpp:
(WebCore::DataTransfer::clearData): Invoke didClearStringData when m_itemList exists.
(WebCore::DataTransfer::setData): Ditto.
(WebCore::DataTransfer::createForInputEvent):
(WebCore::DataTransfer::createForDrag):
(WebCore::DataTransfer::createForDrop):
* dom/DataTransferItem.cpp:
(WebCore::DataTransferItem::create):
(WebCore::DataTransferItem::DataTransferItem):
(WebCore::DataTransferItem::clearListAndPutIntoDisabledMode): Added.
(WebCore::DataTransferItem::type const): Moved from the header.
(WebCore::DataTransferItem::getAsString const):
(WebCore::DataTransferItem::getAsFile const):
* dom/DataTransferItem.h:
(WebCore::DataTransferItem::ref): Deleted.
(WebCore::DataTransferItem::deref): Deleted.
(WebCore::DataTransferItem::isFile const): Added.
(WebCore::DataTransferItem::type const): Move to the cpp file.
* dom/DataTransferItemList.cpp:
(WebCore::isSupportedType): Moved.
(WebCore::DataTransferItemList::DataTransferItemList): Moved from the header.
(WebCore::DataTransferItemList::~DataTransferItemList): Added.
(WebCore::DataTransferItemList::item):
(WebCore::DataTransferItemList::add): Implemented the variant to add string data.
(WebCore::DataTransferItemList::remove): Implemented. For now, we don't have to deal with removing
a file since a writable dataTransfer never contains a File object.
(WebCore::DataTransferItemList::clear): Implemented.
(WebCore::DataTransferItemList::ensureItems const):
(WebCore::removeStringItemOfLowercasedType): Added.
(WebCore::DataTransferItemList::didClearStringData): Called when dataTransfer.clear is called.
(WebCore::DataTransferItemList::didSetStringData): Ditto for
* dom/DataTransferItemList.h:
(WebCore::DataTransferItemList): Added a WeakPtrFactory. Also use a vector of Ref<DataTransferItem>
instead of unique_ptr<DataTransferItem> since DataTransferItem can outlive DataTransferItemList.
(WebCore::DataTransferItemList::dataTransfer): Added.
* dom/DataTransferItemList.idl:

LayoutTests:

Rebaselined the IDL test which now passes all test cases, and added a regression test for mutating clipboard data
via dataTransfer.items and methods on dataTransfer for plaintext.

* editing/pasteboard/datatransfer-idl-expected.txt:
* editing/pasteboard/datatransfer-items-copy-plaintext-expected.txt: Added.
* editing/pasteboard/datatransfer-items-copy-plaintext.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAdd back the ability to disable MASM_PROBE from the build.
mark.lam@apple.com [Thu, 17 Aug 2017 05:09:06 +0000 (05:09 +0000)]
Add back the ability to disable MASM_PROBE from the build.
https://bugs.webkit.org/show_bug.cgi?id=175656
<rdar://problem/33933720>

Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

This is needed for ports that the existing MASM_PROBE implementation doesn't work
well with e.g. GTK with ARM_THUMB2.  Note that if the DFG_JIT will be disabled by
default if !ENABLE(MASM_PROBE).

* assembler/AbstractMacroAssembler.h:
* assembler/MacroAssembler.cpp:
* assembler/MacroAssembler.h:
* assembler/MacroAssemblerARM.cpp:
* assembler/MacroAssemblerARM64.cpp:
* assembler/MacroAssemblerARMv7.cpp:
* assembler/MacroAssemblerPrinter.cpp:
* assembler/MacroAssemblerPrinter.h:
* assembler/MacroAssemblerX86Common.cpp:
* assembler/testmasm.cpp:
(JSC::run):
* b3/B3LowerToAir.cpp:
* b3/air/AirPrintSpecial.cpp:
* b3/air/AirPrintSpecial.h:

Source/WTF:

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Cocoa] Older-iOS install name symbols are being exported on other platforms
mitz@apple.com [Thu, 17 Aug 2017 03:32:13 +0000 (03:32 +0000)]
[Cocoa] Older-iOS install name symbols are being exported on other platforms
https://bugs.webkit.org/show_bug.cgi?id=175654

Reviewed by Tim Horton.

* API/JSBase.cpp: Define the symbols only when targeting iOS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Apple Pay] Rename PaymentRequest to ApplePaySessionPaymentRequest
aestes@apple.com [Thu, 17 Aug 2017 01:24:30 +0000 (01:24 +0000)]
[Apple Pay] Rename PaymentRequest to ApplePaySessionPaymentRequest
https://bugs.webkit.org/show_bug.cgi?id=175648

Reviewed by Tim Horton.

Source/WebCore:

The W3C Payment Request API defines an interface called PaymentRequest, which conflicts with
an existing Apple Pay class. This patch renames PaymentRequest to
ApplePaySessionPaymentRequest so that a follow-on patch can introduce PaymentRequest for the
W3C API.

* Modules/applepay/ApplePayError.h:
* Modules/applepay/ApplePayLineItem.h:
* Modules/applepay/ApplePayPaymentRequest.h:
* Modules/applepay/ApplePaySession.cpp:
(WebCore::convertAndValidateTotal):
(WebCore::convertAndValidate):
(WebCore::ApplePaySession::ApplePaySession):
(WebCore::ApplePaySession::didSelectShippingMethod):
* Modules/applepay/ApplePaySession.h:
* Modules/applepay/ApplePaySessionPaymentRequest.cpp: Renamed from Source/WebCore/Modules/applepay/PaymentRequest.cpp.
(WebCore::ApplePaySessionPaymentRequest::ApplePaySessionPaymentRequest):
(WebCore::ApplePaySessionPaymentRequest::~ApplePaySessionPaymentRequest):
(WebCore::ApplePaySessionPaymentRequest::isValidSupportedNetwork):
* Modules/applepay/ApplePaySessionPaymentRequest.h: Renamed from Source/WebCore/Modules/applepay/PaymentRequest.h.
* Modules/applepay/ApplePayShippingMethodSelectedEvent.cpp:
(WebCore::convert):
(WebCore::ApplePayShippingMethodSelectedEvent::ApplePayShippingMethodSelectedEvent):
* Modules/applepay/ApplePayShippingMethodSelectedEvent.h:
* Modules/applepay/PaymentCoordinator.cpp:
(WebCore::PaymentCoordinator::beginPaymentSession):
(WebCore::PaymentCoordinator::didSelectShippingMethod):
* Modules/applepay/PaymentCoordinator.h:
* Modules/applepay/PaymentCoordinatorClient.h:
* Modules/applepay/PaymentHeaders.h:
* Modules/applepay/PaymentRequestValidator.cpp:
(WebCore::PaymentRequestValidator::validate):
(WebCore::PaymentRequestValidator::validateTotal):
(WebCore::validateMerchantCapabilities):
(WebCore::validateShippingMethod):
(WebCore::validateShippingMethods):
* Modules/applepay/PaymentRequestValidator.h:
* WebCore.xcodeproj/project.pbxproj:
* loader/EmptyClients.cpp:

Source/WebKit:

* Scripts/webkit/messages.py:
(headers_for_type):
* Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest>::encode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest>::decode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest::ContactFields>::encode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest::ContactFields>::decode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest::LineItem>::encode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest::LineItem>::decode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest::MerchantCapabilities>::encode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest::MerchantCapabilities>::decode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest::ShippingMethod>::encode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest::ShippingMethod>::decode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest::TotalAndLineItems>::encode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest::TotalAndLineItems>::decode):
(IPC::ArgumentCoder<PaymentRequest>::encode): Deleted.
(IPC::ArgumentCoder<PaymentRequest>::decode): Deleted.
(IPC::ArgumentCoder<PaymentRequest::ContactFields>::encode): Deleted.
(IPC::ArgumentCoder<PaymentRequest::ContactFields>::decode): Deleted.
(IPC::ArgumentCoder<PaymentRequest::LineItem>::encode): Deleted.
(IPC::ArgumentCoder<PaymentRequest::LineItem>::decode): Deleted.
(IPC::ArgumentCoder<PaymentRequest::MerchantCapabilities>::encode): Deleted.
(IPC::ArgumentCoder<PaymentRequest::MerchantCapabilities>::decode): Deleted.
(IPC::ArgumentCoder<PaymentRequest::ShippingMethod>::encode): Deleted.
(IPC::ArgumentCoder<PaymentRequest::ShippingMethod>::decode): Deleted.
(IPC::ArgumentCoder<PaymentRequest::TotalAndLineItems>::encode): Deleted.
(IPC::ArgumentCoder<PaymentRequest::TotalAndLineItems>::decode): Deleted.
* Shared/WebCoreArgumentCoders.h:
* UIProcess/ApplePay/WebPaymentCoordinatorProxy.cpp:
(WebKit::WebPaymentCoordinatorProxy::showPaymentUI):
(WebKit::WebPaymentCoordinatorProxy::didSelectShippingMethod):
* UIProcess/ApplePay/WebPaymentCoordinatorProxy.h:
* UIProcess/ApplePay/WebPaymentCoordinatorProxy.messages.in:
* UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:
* UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:
(toShippingMethod):
(WebKit::toPKContactFields):
(WebKit::toPKAddressField):
(WebKit::toPKPaymentSummaryItemType):
(WebKit::toPKPaymentSummaryItem):
(WebKit::toPKPaymentSummaryItems):
(WebKit::toPKMerchantCapabilities):
(WebKit::toPKShippingType):
(WebKit::toPKShippingMethod):
(WebKit::toPKPaymentRequest):
* UIProcess/ApplePay/ios/WebPaymentCoordinatorProxyIOS.mm:
(WebKit::WebPaymentCoordinatorProxy::platformShowPaymentUI):
* UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm:
(WebKit::WebPaymentCoordinatorProxy::platformShowPaymentUI):
* WebProcess/ApplePay/WebPaymentCoordinator.cpp:
(WebKit::WebPaymentCoordinator::showPaymentUI):
(WebKit::WebPaymentCoordinator::didSelectShippingMethod):
* WebProcess/ApplePay/WebPaymentCoordinator.h:
* WebProcess/ApplePay/WebPaymentCoordinator.messages.in:

Source/WebKitLegacy/mac:

* WebCoreSupport/WebPaymentCoordinatorClient.h:
* WebCoreSupport/WebPaymentCoordinatorClient.mm:
(WebPaymentCoordinatorClient::showPaymentUI):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMark fullscreen/full-screen-iframe-legacy.html as flaky on Sierra WK1.
ryanhaddad@apple.com [Thu, 17 Aug 2017 00:45:54 +0000 (00:45 +0000)]
Mark fullscreen/full-screen-iframe-legacy.html as flaky on Sierra WK1.
https://bugs.webkit.org/show_bug.cgi?id=175554

Unreviewed test gardening.

* platform/mac-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoCorrect a typo in a test name.
ryanhaddad@apple.com [Thu, 17 Aug 2017 00:40:24 +0000 (00:40 +0000)]
Correct a typo in a test name.

Unreviewed test gardening.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRebaseline crypto/subtle/rsa-generate-key-malformed-parameters.html after r220811.
ryanhaddad@apple.com [Thu, 17 Aug 2017 00:33:23 +0000 (00:33 +0000)]
Rebaseline crypto/subtle/rsa-generate-key-malformed-parameters.html after r220811.

Unreviewed test gardening.

* platform/ios-11/crypto/subtle/rsa-generate-key-malformed-parameters-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoCross origin Beacon requests with a ArrayBuffer / ArrayBufferView payload should...
cdumez@apple.com [Thu, 17 Aug 2017 00:28:25 +0000 (00:28 +0000)]
Cross origin Beacon requests with a ArrayBuffer / ArrayBufferView payload should not do a CORS preflight
https://bugs.webkit.org/show_bug.cgi?id=175628
<rdar://problem/33919278>

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Rebaseline a few web-platform-tests due to revert of r220779.

* web-platform-tests/beacon/headers/header-content-type-expected.txt:
* web-platform-tests/fetch/api/basic/request-headers.any-expected.txt:
* web-platform-tests/fetch/api/basic/request-headers.any.worker-expected.txt:

Source/WebCore:

Cross origin Beacon requests with a ArrayBuffer / ArrayBufferView payload should not do a CORS preflight.
To achieve this, the following changes were made:
1. Revert r220779 which caused us to use a non CORS-safelisted Content-Type header for such payload
2. Teach PingLoad how to deal with "simple" cross origin requests (i.e. Don't assume we need a CORS
   preflight merely because the fetch mode is set to "cors").

Test: http/wpt/beacon/cors/crossorigin-arraybufferview-no-preflight.html

* Modules/fetch/FetchBody.cpp:
(WebCore::FetchBody::extract):
* loader/CrossOriginAccessControl.h:
* loader/LoaderStrategy.h:
* loader/PingLoader.cpp:
(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):
(WebCore::PingLoader::sendViolationReport):
(WebCore::PingLoader::startPingLoad):
* loader/PingLoader.h:
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::load):
* loader/cache/CachedResource.h:
* loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::CachedResourceRequest):
* loader/cache/CachedResourceRequest.h:
(WebCore::CachedResourceRequest::releaseOriginalRequestHeaders):
* platform/network/HTTPHeaderValues.cpp:
* platform/network/HTTPHeaderValues.h:

Source/WebKit:

Cross origin Beacon requests with a ArrayBuffer / ArrayBufferView payload should not do a CORS preflight.
To achieve this, the following changes were made:
1. Revert r220779 which caused us to use a non CORS-safelisted Content-Type header for such payload
2. Teach PingLoad how to deal with "simple" cross origin requests (i.e. Don't assume we need a CORS
   preflight merely because the fetch mode is set to "cors").

* NetworkProcess/NetworkCORSPreflightChecker.cpp:
(WebKit::NetworkCORSPreflightChecker::startPreflight):
* NetworkProcess/NetworkResourceLoadParameters.cpp:
(WebKit::NetworkResourceLoadParameters::encode const):
(WebKit::NetworkResourceLoadParameters::decode):
* NetworkProcess/NetworkResourceLoadParameters.h:
* NetworkProcess/PingLoad.cpp:
(WebKit::PingLoad::PingLoad):
(WebKit::PingLoad::loadRequest):
(WebKit::PingLoad::originalRequestHeaders const):
(WebKit::PingLoad::willPerformHTTPRedirection):
(WebKit::PingLoad::isAllowedRedirect const):
(WebKit::PingLoad::makeCrossOriginAccessRequest):
(WebKit::PingLoad::makeSimpleCrossOriginAccessRequest):
(WebKit::PingLoad::makeCrossOriginAccessRequestWithPreflight):
(WebKit::PingLoad::preflightSuccess):
* NetworkProcess/PingLoad.h:
* WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::createPingHandle):
* WebProcess/Network/WebLoaderStrategy.h:

Source/WebKitLegacy:

* WebCoreSupport/WebResourceLoadScheduler.cpp:
(WebResourceLoadScheduler::createPingHandle):
* WebCoreSupport/WebResourceLoadScheduler.h:

LayoutTests:

* http/tests/blink/sendbeacon/beacon-same-origin-expected.txt:
* http/wpt/fetch/fetch-request-arraybuffer-content-type-expected.txt:
* http/wpt/fetch/fetch-request-arraybuffer-content-type.html:
Rebaseline test due to revert of r220779.

* http/wpt/beacon/cors/cors-preflight-arraybufferview-failure-expected.txt: Removed.
* http/wpt/beacon/cors/cors-preflight-arraybufferview-failure.html: Removed.
Drop outdated test. CORS preflight failure is still covered by the corresponding Blob payload test.

* http/wpt/beacon/cors/cors-preflight-arraybufferview-success-expected.txt: Removed.
* http/wpt/beacon/cors/cors-preflight-arraybufferview-success.html: Removed.
* http/wpt/beacon/cors/crossorigin-arraybufferview-no-preflight-expected.txt: Added.
* http/wpt/beacon/cors/crossorigin-arraybufferview-no-preflight.html: Added.
Rename and update test so that it checks that we no longer do a CORS preflight for cross origin
beacons that have an ArrayBuffer payload.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoGardening: fix GTK ARM_THUMB2 build.
mark.lam@apple.com [Wed, 16 Aug 2017 23:29:47 +0000 (23:29 +0000)]
Gardening: fix GTK ARM_THUMB2 build.
https://bugs.webkit.org/show_bug.cgi?id=175446

Not reviewed.

Disable the use of the DFG for GTK ARM_THUMB2 builds until
https://bugs.webkit.org/show_bug.cgi?id=175514 is fixed.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWeb Inspector: capture async stack trace when workers/main context posts a message
mattbaker@apple.com [Wed, 16 Aug 2017 23:15:32 +0000 (23:15 +0000)]
Web Inspector: capture async stack trace when workers/main context posts a message
https://bugs.webkit.org/show_bug.cgi?id=167084
<rdar://problem/30033673>

Reviewed by Brian Burg.

Source/JavaScriptCore:

* inspector/agents/InspectorDebuggerAgent.h:
Add `PostMessage` async call type.

Source/WebCore:

Add instrumentation to DOMWindow to support showing asynchronous
stack traces when the debugger pauses in a MessageEvent handler.

Test: inspector/debugger/async-stack-trace.html

* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didPostMessageImpl):
(WebCore::InspectorInstrumentation::didFailPostMessageImpl):
(WebCore::InspectorInstrumentation::willDispatchPostMessageImpl):
(WebCore::InspectorInstrumentation::didDispatchPostMessageImpl):

* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didPostMessage):
(WebCore::InspectorInstrumentation::didFailPostMessage):
(WebCore::InspectorInstrumentation::willDispatchPostMessage):
(WebCore::InspectorInstrumentation::didDispatchPostMessage):

* inspector/PageDebuggerAgent.cpp:
(WebCore::PageDebuggerAgent::didClearAsyncStackTraceData):
(WebCore::PageDebuggerAgent::didPostMessage):
(WebCore::PageDebuggerAgent::didFailPostMessage):
(WebCore::PageDebuggerAgent::willDispatchPostMessage):
(WebCore::PageDebuggerAgent::didDispatchPostMessage):
* inspector/PageDebuggerAgent.h:

* page/DOMWindow.cpp:
(WebCore::DOMWindow::postMessage):
(WebCore::DOMWindow::postMessageTimerFired):

LayoutTests:

Add a test to check for asynchronous stack trace data when the debugger
pauses inside a MessageEvent handler.

* inspector/debugger/async-stack-trace-expected.txt:
* inspector/debugger/async-stack-trace.html:
* inspector/debugger/resources/postMessage-echo.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoTry to fix the build
timothy_horton@apple.com [Wed, 16 Aug 2017 23:00:04 +0000 (23:00 +0000)]
Try to fix the build

* platform/ios/PlatformPasteboardIOS.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoBuild fix after r220812
simon.fraser@apple.com [Wed, 16 Aug 2017 22:58:40 +0000 (22:58 +0000)]
Build fix after r220812

Fix builds where LOG_DISABLED is defined.

* css/MediaQueryEvaluator.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAdd a log channel for media queries
simon.fraser@apple.com [Wed, 16 Aug 2017 22:12:12 +0000 (22:12 +0000)]
Add a log channel for media queries
https://bugs.webkit.org/show_bug.cgi?id=175591

Reviewed by Zalan Bujtas.

Add a "MediaQueries" log channel which logs data about media query evaluation.

* css/MediaList.cpp:
(WebCore::MediaQuerySet::MediaQuerySet):
(WebCore::operator<<):
* css/MediaList.h:
* css/MediaQuery.cpp:
(WebCore::operator<<):
* css/MediaQuery.h:
* css/MediaQueryEvaluator.cpp:
(WebCore::operator<<):
(WebCore::MediaQueryEvaluator::evaluate const):
(WebCore::aspectRatioValueAsString):
(WebCore::orientationEvaluate):
(WebCore::aspectRatioEvaluate):
(WebCore::deviceAspectRatioEvaluate):
(WebCore::evaluateResolution):
(WebCore::deviceHeightEvaluate):
(WebCore::deviceWidthEvaluate):
(WebCore::heightEvaluate):
(WebCore::widthEvaluate):
* css/MediaQueryExpression.cpp:
(WebCore::operator<<):
* css/MediaQueryExpression.h:
* css/MediaQueryMatcher.cpp:
(WebCore::MediaQueryMatcher::styleResolverChanged):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::hasMediaQueriesAffectedByViewportChange const):
(WebCore::StyleResolver::hasMediaQueriesAffectedByAccessibilitySettingsChange const):
* dom/InlineStyleSheetOwner.cpp:
(WebCore::InlineStyleSheetOwner::createSheet):
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::process):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::selectNextSourceChild):
* html/HTMLPictureElement.cpp:
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture const):
* html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):
* page/FrameView.cpp:
(WebCore::FrameView::layout):
* platform/Logging.cpp:
(WebCore::initializeLogChannelsIfNecessary):
* platform/Logging.h:
* platform/URL.cpp:
(WebCore::isSchemeFirstChar):
(WebCore::operator<<):
* platform/URL.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[WebIDL] Remove the need for JSSubtleCryptoCustom.cpp
commit-queue@webkit.org [Wed, 16 Aug 2017 22:11:18 +0000 (22:11 +0000)]
[WebIDL] Remove the need for JSSubtleCryptoCustom.cpp
https://bugs.webkit.org/show_bug.cgi?id=175526

Patch by Sam Weinig <sam@webkit.org> on 2017-08-16
Reviewed by Chris Dumez.

Source/WebCore:

- Generates bindings for all of SubtleCrypto except AlgorithmIdentifier normalization,
  which is defined in the WebCrypto spec to happen after normal IDL operations.
- Adds initial support for IDL object types in unions (some, unneeded at the moment,
  edge cases remain).

* CMakeLists.txt:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSSubtleCryptoCustom.cpp: Removed.

    Remove JSSubtleCryptoCustom.cpp, added CryptoKeyFormat.h

* bindings/js/JSDOMConvertObject.h:

    Add needed, when included in generated code, #include of StrongInlines.h

* bindings/js/JSDOMConvertUnion.h:

    Add initial support for object (needed for AlgorithmIdentifier which is
    (object or DOMString)). Remaining support will be handled by https://webkit.org/b/175616

    Also add remaining spec comments while in the area.

* bindings/js/JSDOMPromiseDeferred.cpp:
(WebCore::DeferredPromise::reject):

    Add support for the special ExistingExceptionError error code. Capturing
    the current exception and using it as the rejection value.

* crypto/SubtleCrypto.cpp:
(WebCore::SubtleCrypto::~SubtleCrypto):
(WebCore::toHashIdentifier):
(WebCore::normalizeCryptoAlgorithmParameters):
(WebCore::toCryptoKeyUsageBitmap):
(WebCore::rejectWithException):
(WebCore::normalizeJsonWebKey):
(WebCore::toKeyData):
(WebCore::copyToVector):
(WebCore::isSupportedExportKey):
(WebCore::SubtleCrypto::encrypt):
(WebCore::SubtleCrypto::decrypt):
(WebCore::SubtleCrypto::sign):
(WebCore::SubtleCrypto::verify):
(WebCore::SubtleCrypto::digest):
(WebCore::SubtleCrypto::generateKey):
(WebCore::SubtleCrypto::deriveKey):
(WebCore::SubtleCrypto::deriveBits):
(WebCore::SubtleCrypto::importKey):
(WebCore::SubtleCrypto::exportKey):
(WebCore::SubtleCrypto::wrapKey):
(WebCore::SubtleCrypto::unwrapKey):
* crypto/SubtleCrypto.h:
* crypto/SubtleCrypto.idl:

    Moves implementation from JSSubtleCryptoCustom.cpp -> here. Important changes that come
    with that are:
    - All parameters are now converted / type checked for us.
    - Rather than throwing exceptions and expecting the bindings layer to convert
      them to promise rejections, all rejections are now explicitly made.
    - Algorithms are no longer checked for being supported twice, once in normalizeCryptoAlgorithmParameters
      and then again in the operation. We instead rely on normalizeCryptoAlgorithmParameters to return
      an Exception if its not supported.
    - Shaves 251 lines off the file.

* crypto/CryptoKeyFormat.h: Added.

    Add new header for unified key format enum. (For bindings purposes, SubtleCrypto
    re aliases it to SubtleCrypto::KeyFormat).

* bindings/js/JSWebKitSubtleCryptoCustom.cpp:
* crypto/CryptoAlgorithm.cpp:
* crypto/CryptoAlgorithm.h:
* crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:
* crypto/algorithms/CryptoAlgorithmAES_CBC.h:
* crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:
* crypto/algorithms/CryptoAlgorithmAES_CFB.h:
* crypto/algorithms/CryptoAlgorithmAES_CTR.cpp:
* crypto/algorithms/CryptoAlgorithmAES_CTR.h:
* crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:
* crypto/algorithms/CryptoAlgorithmAES_GCM.h:
* crypto/algorithms/CryptoAlgorithmAES_KW.cpp:
* crypto/algorithms/CryptoAlgorithmAES_KW.h:
* crypto/algorithms/CryptoAlgorithmECDH.cpp:
* crypto/algorithms/CryptoAlgorithmECDH.h:
* crypto/algorithms/CryptoAlgorithmECDSA.cpp:
* crypto/algorithms/CryptoAlgorithmECDSA.h:
* crypto/algorithms/CryptoAlgorithmHKDF.cpp:
* crypto/algorithms/CryptoAlgorithmHKDF.h:
* crypto/algorithms/CryptoAlgorithmHMAC.cpp:
* crypto/algorithms/CryptoAlgorithmHMAC.h:
* crypto/algorithms/CryptoAlgorithmPBKDF2.cpp:
* crypto/algorithms/CryptoAlgorithmPBKDF2.h:
* crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.cpp:
* crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.h:
* crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:
* crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.h:
* crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:
* crypto/algorithms/CryptoAlgorithmRSA_OAEP.h:
* crypto/algorithms/CryptoAlgorithmRSA_PSS.cpp:
* crypto/algorithms/CryptoAlgorithmRSA_PSS.h:

    Use CryptoKeyFormat enum directly, rather than SubtleCrypto::KeyFormat,
    to allow not including SubtleCrypto.h.

* crypto/parameters/CryptoAlgorithmEcdsaParams.h:
* crypto/parameters/CryptoAlgorithmHkdfParams.h:
* crypto/parameters/CryptoAlgorithmHmacKeyParams.h:
* crypto/parameters/CryptoAlgorithmPbkdf2Params.h:
* crypto/parameters/CryptoAlgorithmRsaHashedImportParams.h:
* crypto/parameters/CryptoAlgorithmRsaHashedKeyGenParams.h:
* crypto/parameters/EcdsaParams.idl:
* crypto/parameters/HkdfParams.idl:
* crypto/parameters/HmacKeyParams.idl:
* crypto/parameters/Pbkdf2Params.idl:
* crypto/parameters/RsaHashedImportParams.idl:
* crypto/parameters/RsaHashedKeyGenParams.idl:

    Update IDLs and implementations to use the correct definition of HashAlgorithmIdentifier,
    which is (object or DOMString), now that it is supported.

LayoutTests:

* crypto/subtle/encrypt-malformed-parameters-expected.txt:
* crypto/subtle/export-key-malformed-parameters-expected.txt:
* crypto/subtle/generate-key-malformed-parameters-expected.txt:
* crypto/subtle/hkdf-derive-bits-malformed-parametrs-expected.txt:
* crypto/subtle/hmac-generate-key-malformed-parameters-expected.txt:
* crypto/subtle/import-key-malformed-parameters-expected.txt:
* crypto/subtle/pbkdf2-derive-bits-malformed-parametrs-expected.txt:
* crypto/subtle/rsa-generate-key-malformed-parameters-expected.txt:
* platform/mac-highsierra/crypto/subtle/rsa-generate-key-malformed-parameters-expected.txt:
Update expectations with improved error messages.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Cache API] Implement Worker connection to the Cache storage engine
commit-queue@webkit.org [Wed, 16 Aug 2017 22:09:34 +0000 (22:09 +0000)]
[Cache API] Implement Worker connection to the Cache storage engine
https://bugs.webkit.org/show_bug.cgi?id=175599

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-16
Reviewed by Chris Dumez.

Covered by existing tests.

Adding a WorkerCacheStorageConnection to connect workers Cache/CacheStorage
to the cache storage engine.
WorkerCacheStorageConnection does this by hopping to the main thread to call the document cache storage connection to do the actual job.
Doing some CacheStorageConnection refactoring to share code with WK2 implementation of the cache storage connection.

* Modules/cache/CacheQueryOptions.h:
(WebCore::CacheQueryOptions::isolatedCopy const):
* Modules/cache/CacheStorageConnection.cpp:
(WebCore::CacheStorageConnection::open):
(WebCore::CacheStorageConnection::remove):
(WebCore::CacheStorageConnection::retrieveCaches):
(WebCore::CacheStorageConnection::retrieveRecords):
(WebCore::CacheStorageConnection::batchDeleteOperation):
(WebCore::CacheStorageConnection::batchPutOperation):
(WebCore::CacheStorageConnection::openOrRemoveCompleted):
(WebCore::CacheStorageConnection::updateCaches):
(WebCore::CacheStorageConnection::updateRecords):
(WebCore::CacheStorageConnection::removeRecordsCompleted):
(WebCore::CacheStorageConnection::putRecordsCompleted):
* Modules/cache/CacheStorageConnection.h:
(WebCore::CacheStorageConnection::openCompleted):
(WebCore::CacheStorageConnection::removeCompleted):
(WebCore::CacheStorageConnection::doOpen):
(WebCore::CacheStorageConnection::doRemove):
(WebCore::CacheStorageConnection::doRetrieveCaches):
(WebCore::CacheStorageConnection::doRetrieveRecords):
(WebCore::CacheStorageConnection::doBatchDeleteOperation):
(WebCore::CacheStorageConnection::doBatchPutOperation):
* Modules/cache/WorkerCacheStorageConnection.cpp: Added.
(WebCore::toCrossThreadRecordData):
(WebCore::fromCrossThreadRecordData):
(WebCore::WorkerCacheStorageConnection::create):
(WebCore::WorkerCacheStorageConnection::WorkerCacheStorageConnection):
(WebCore::WorkerCacheStorageConnection::doOpen):
(WebCore::WorkerCacheStorageConnection::doRemove):
(WebCore::WorkerCacheStorageConnection::doRetrieveCaches):
(WebCore::WorkerCacheStorageConnection::doRetrieveRecords):
(WebCore::WorkerCacheStorageConnection::doBatchDeleteOperation):
(WebCore::WorkerCacheStorageConnection::doBatchPutOperation):
* Modules/cache/WorkerCacheStorageConnection.h: Added.
* Modules/cache/WorkerGlobalScopeCaches.cpp:
(WebCore::WorkerGlobalScopeCaches::caches const):
* WebCore.xcodeproj/project.pbxproj:
* loader/FetchOptions.h:
(WebCore::FetchOptions::isolatedCopy const):
* workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::cacheStorageConnection):
* workers/WorkerGlobalScope.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[PAL] Move spi/ios and spi/win directories into PAL
commit-queue@webkit.org [Wed, 16 Aug 2017 21:42:12 +0000 (21:42 +0000)]
[PAL] Move spi/ios and spi/win directories into PAL
https://bugs.webkit.org/show_bug.cgi?id=175171

Patch by Yoshiaki Jitsukawa <Yoshiaki.Jitsukawa@sony.com> on 2017-08-16
Reviewed by Antti Koivisto.

Source/WebCore:

* PlatformWin.cmake:
* WebCore.xcodeproj/project.pbxproj:
* editing/cocoa/DataDetection.mm:
* loader/ios/PreviewLoader.mm:
* page/CaptionUserPreferencesMediaAF.cpp:
* page/cocoa/MemoryReleaseCocoa.mm:
* page/cocoa/SettingsCocoa.mm:
* page/ios/UserAgentIOS.mm:
* platform/audio/ios/MediaSessionManagerIOS.mm:
* platform/graphics/ca/PlatformCALayer.cpp:
* platform/graphics/cocoa/FontCascadeCocoa.mm:
* platform/graphics/cocoa/GraphicsContext3DCocoa.mm:
* platform/graphics/opentype/OpenTypeCG.h:
* platform/graphics/win/SimpleFontDataCGWin.cpp:
* platform/graphics/win/SimpleFontDataDirect2D.cpp:
* platform/ios/Device.h:
* platform/ios/PlatformPasteboardIOS.mm:
* platform/ios/PlatformScreenIOS.mm:
* platform/ios/QuickLookSoftLink.h:
* platform/ios/QuickLookSoftLink.mm:
* platform/ios/ValidationBubbleIOS.mm:
* platform/ios/WebItemProviderPasteboard.mm:
* platform/network/ios/PreviewConverter.mm:
* platform/sql/SQLiteFileSystem.cpp:
* rendering/RenderThemeIOS.mm:

Source/WebCore/PAL:

* PAL.xcodeproj/project.pbxproj:
* pal/spi/ios/CoreUISPI.h: Renamed from Source/WebCore/platform/spi/ios/CoreUISPI.h.
* pal/spi/ios/DataDetectorsUISPI.h: Renamed from Source/WebCore/platform/spi/ios/DataDetectorsUISPI.h.
* pal/spi/ios/GraphicsServicesSPI.h: Renamed from Source/WebCore/platform/spi/ios/GraphicsServicesSPI.h.
* pal/spi/ios/LaunchServicesSPI.h: Renamed from Source/WebCore/platform/spi/ios/LaunchServicesSPI.h.
* pal/spi/ios/MediaPlayerSPI.h: Renamed from Source/WebCore/platform/spi/ios/MediaPlayerSPI.h.
* pal/spi/ios/MobileGestaltSPI.h: Renamed from Source/WebCore/platform/spi/ios/MobileGestaltSPI.h.
* pal/spi/ios/OpenGLESSPI.h: Renamed from Source/WebCore/platform/spi/ios/OpenGLESSPI.h.
* pal/spi/ios/QuickLookSPI.h: Renamed from Source/WebCore/platform/spi/ios/QuickLookSPI.h.
* pal/spi/ios/SQLite3SPI.h: Renamed from Source/WebCore/platform/spi/ios/SQLite3SPI.h.
* pal/spi/ios/UIKitSPI.h: Renamed from Source/WebCore/platform/spi/ios/UIKitSPI.h.
* pal/spi/win/CoreTextSPIWin.h: Renamed from Source/WebCore/platform/spi/win/CoreTextSPIWin.h.

Source/WebKit:

* UIProcess/Cocoa/NavigationState.mm:
* UIProcess/ios/WKActionSheetAssistant.h:
* UIProcess/ios/WKActionSheetAssistant.mm:
* UIProcess/ios/WKContentViewInteraction.mm:
* UIProcess/ios/forms/WKAirPlayRoutePicker.mm:
* WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm:
* WebProcess/cocoa/WebProcessCocoa.mm:

Source/WebKitLegacy:

* Storage/StorageTracker.cpp:

Source/WebKitLegacy/mac:

* WebCoreSupport/WebFrameLoaderClient.mm:
* WebView/WebView.mm:

Tools:

* DumpRenderTree/mac/EventSendingController.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago2-3% of main thread time under UTTypeCreatePreferredIdentifierForTag on wunderground map
timothy_horton@apple.com [Wed, 16 Aug 2017 20:49:47 +0000 (20:49 +0000)]
2-3% of main thread time under UTTypeCreatePreferredIdentifierForTag on wunderground map
https://bugs.webkit.org/show_bug.cgi?id=175618

Reviewed by Simon Fraser.

No new tests, just a perf win.

UTTypeCreatePreferredIdentifierForTag is fairly expensive, and is called
under every toDataURL, which the Wunderground wundermap does a /lot/.

Keep a 16-item LRU cache of MIMEType->UTI mappings.

Also, make other callers of UTTypeCreatePreferredIdentifierForTag use
the UTIUtilities version so they can share in the caching.

Also, as a drive-by, add and make other callers use mimeTypeFromUTI too,
and make the UTIUtilities operate on Strings for a slightly more WebCore-y feel.

* editing/ios/EditorIOS.mm:
(WebCore::Editor::WebContentReader::readImage):
* platform/MIMETypeRegistry.cpp:
(WebCore::initializeSupportedImageMIMETypes):
(WebCore::initializeSupportedImageMIMETypesForEncoding):
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::createFileTypesSet):
* platform/graphics/cg/ImageSourceCGMac.mm:
(WebCore::MIMETypeForImageSourceType):
Adopt newly-added MIMETypeFromUTI().

* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::utiFromImageBufferMIMEType):
(WebCore::ImageBuffer::toCFData const):
(WebCore::cfData):
(WebCore::utiFromMIMEType): Deleted.
Adopt UTIFromMIMEType, and rename the local helper that does something
different (a small static map) on iOS and Windows to not have an overlapping name.

* platform/ios/PasteboardIOS.mm:
(WebCore::Pasteboard::resourceMIMEType):
(WebCore::utiTypeFromCocoaType):
Adopt UTIFromMIMEType().

* platform/ios/PlatformPasteboardIOS.mm:
(WebCore::PlatformPasteboard::writeObjectRepresentations):
* platform/mac/PasteboardMac.mm:
(WebCore::cocoaTypeFromHTMLClipboardType):
Adopt isDeclaredUTI and UTIFromMIMEType().

* platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:
(WebCore::WebCoreAVFResourceLoader::responseReceived):
* platform/network/ios/WebCoreURLResponseIOS.mm:
(WebCore::adjustMIMETypeIfNecessary):
* platform/network/mac/WebCoreURLResponse.mm:
(WebCore::adjustMIMETypeIfNecessary):
* rendering/RenderThemeIOS.mm:
(WebCore::iconForAttachment):
* rendering/RenderThemeMac.mm:
(WebCore::iconForAttachment):
Deal with the fact that UTI utilities deal in Strings now.

* platform/network/mac/UTIUtilities.h:
* platform/network/mac/UTIUtilities.mm:
(WebCore::MIMETypeFromUTI):
Added. This doesn't crawl up the UTI tree if the first conversion fails,
which is what most of the existing code does. It's possible we want to
use MIMETypeFromUTITree's logic everywhere, but I didn't want to change
that in this patch.

(WebCore::MIMETypeFromUTITree):
(WebCore::isDeclaredUTI):
Take and return strings.

(WebCore::UTIFromMIMETypeCachePolicy::createValueForKey):
(WebCore::UTIFromMIMEType):
Add the aforementioned cache.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoEnhance MacroAssembler::probe() to support an initializeStackFunction callback.
mark.lam@apple.com [Wed, 16 Aug 2017 20:38:57 +0000 (20:38 +0000)]
Enhance MacroAssembler::probe() to support an initializeStackFunction callback.
https://bugs.webkit.org/show_bug.cgi?id=175617
<rdar://problem/33912104>

Reviewed by JF Bastien.

This patch adds a new feature to MacroAssembler::probe() where the probe function
can provide a ProbeFunction callback to fill in stack values after the stack
pointer has been adjusted.  The probe function can use this feature as follows:

1. Set the new sp value in the ProbeContext's CPUState.

2. Set the ProbeContext's initializeStackFunction to a ProbeFunction callback
   which will do the work of filling in the stack values after the probe
   trampoline has adjusted the machine stack pointer.

3. Set the ProbeContext's initializeStackArgs to any value that the client wants
   to pass to the initializeStackFunction callback.

4. Return from the probe function.

Upon returning from the probe function, the probe trampoline will adjust the
the stack pointer based on the sp value in CPUState.  If initializeStackFunction
is not set, the probe trampoline will restore registers and return to its caller.

If initializeStackFunction is set, the trampoline will move the ProbeContext
beyond the range of the stack pointer i.e. it will place the new ProbeContext at
an address lower than where CPUState.sp() points.  This ensures that the
ProbeContext will not be trashed by the initializeStackFunction when it writes to
the stack.  Then, the trampoline will call back to the initializeStackFunction
ProbeFunction to let it fill in the stack values as desired.  The
initializeStackFunction ProbeFunction will be passed the moved ProbeContext at
the new location.

initializeStackFunction may now write to the stack at addresses greater or
equal to CPUState.sp(), but not below that.  initializeStackFunction is also
not allowed to change CPUState.sp().  If the initializeStackFunction does not
abide by these rules, then behavior is undefined, and bad things may happen.

For future reference, some implementation details that this patch needed to
be mindful of:

1. When the probe trampoline allocates stack space for the ProbeContext, it
   should include OUT_SIZE as well.  This ensures that it doesn't have to move
   the ProbeContext on exit if the probe function didn't change the sp.

2. If the trampoline has to move the ProbeContext, it needs to point the machine
   sp to new ProbeContext first before copying over the ProbeContext data.  This
   protects the new ProbeContext from possibly being trashed by interrupts.

3. When computing the new address of ProbeContext to move to, we need to make
   sure that it is properly aligned in accordance with stack ABI requirements
   (just like we did when we allocated the ProbeContext on entry to the
   probe trampoline).

4. When copying the ProbeContext to its new location, the trampoline should
   always copy words from low addresses to high addresses.  This is because if
   we're moving the ProbeContext, we'll always be moving it to a lower address.

* assembler/MacroAssembler.h:
* assembler/MacroAssemblerARM.cpp:
* assembler/MacroAssemblerARM64.cpp:
* assembler/MacroAssemblerARMv7.cpp:
* assembler/MacroAssemblerX86Common.cpp:
* assembler/testmasm.cpp:
(JSC::testProbePreservesGPRS):
(JSC::testProbeModifiesStackPointer):
(JSC::fillStack):
(JSC::testProbeModifiesStackWithCallback):
(JSC::run):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMake RenderLayer and RenderLayerBacking TextStream-loggable, and clean up compositing...
simon.fraser@apple.com [Wed, 16 Aug 2017 20:30:47 +0000 (20:30 +0000)]
Make RenderLayer and RenderLayerBacking TextStream-loggable, and clean up compositing logging
https://bugs.webkit.org/show_bug.cgi?id=175634

Reviewed by Zalan Bujtas.

Add operator<<(TextStream&) for RenderLayer and RenderLayer backing, and use them for compositing logging.

Convert CompositingUpdateType to an enum class.

* page/FrameView.cpp:
(WebCore::FrameView::updateCompositingLayersAfterLayout):
(WebCore::FrameView::updateCompositingLayersAfterScrolling):
* page/ios/FrameIOS.mm:
(WebCore::Frame::viewportOffsetChanged):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositionsAfterLayout):
(WebCore::RenderLayer::updateCompositingLayersAfterScroll):
(WebCore::RenderLayer::calculateClipRects const):
* rendering/RenderLayer.h:
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateAfterLayout):
(WebCore::RenderLayerBacking::updateGeometry):
(WebCore::operator<<):
* rendering/RenderLayerBacking.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::didRecalcStyleWithNoPendingLayout):
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
(WebCore::RenderLayerCompositor::updateCompositingLayersTimerFired):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::layerTreeAsText):
(WebCore::operator<<):
* rendering/RenderLayerCompositor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoConsider allow gUM to be called from localhost without https
eric.carlson@apple.com [Wed, 16 Aug 2017 20:20:56 +0000 (20:20 +0000)]
Consider allow gUM to be called from localhost without https
https://bugs.webkit.org/show_bug.cgi?id=173457
<rdar://problem/33900527>

Reviewed by Youenn Fablet.

Source/WebCore:

Tests: http/tests/media/media-stream/get-user-media-localhost.html
       http/tests/media/media-stream/get-user-media-loopback-ip.html

* Modules/mediastream/UserMediaRequest.cpp:
(WebCore::isSecure): Call SchemeRegistry::shouldTreatURLSchemeAsSecure instead of looking for
the string 'https'.
(WebCore::canCallGetUserMedia): Allow localhost or loopback address.

* page/SecurityOrigin.cpp:
(WebCore::isLoopbackIPAddress): Add a comment.
(WebCore::shouldTreatAsPotentionallyTrustworthy): Move tests for localhost and loopback address
to isLocalHostOrLoopbackIPAddress, call it.
(WebCore::SecurityOrigin::isLocalHostOrLoopbackIPAddress):
* page/SecurityOrigin.h:

LayoutTests:

* http/tests/media/media-stream/get-user-media-localhost-expected.txt: Added.
* http/tests/media/media-stream/get-user-media-localhost.html: Added.
* http/tests/media/media-stream/get-user-media-loopback-ip-expected.txt: Added.
* http/tests/media/media-stream/get-user-media-loopback-ip.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoSkip workers/wasm-hashset-many.html and workers/wasm-hashset-many-2.html
ryanhaddad@apple.com [Wed, 16 Aug 2017 20:19:58 +0000 (20:19 +0000)]
Skip workers/wasm-hashset-many.html and workers/wasm-hashset-many-2.html
https://bugs.webkit.org/show_bug.cgi?id=175102

Unreviewed test gardening.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoVersioning.
jmarcell@apple.com [Wed, 16 Aug 2017 19:42:36 +0000 (19:42 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoSpeedometer: Update Angular 1 TodoMVC example to v1.6.5
commit-queue@webkit.org [Wed, 16 Aug 2017 19:17:33 +0000 (19:17 +0000)]
Speedometer: Update Angular 1 TodoMVC example to v1.6.5
https://bugs.webkit.org/show_bug.cgi?id=175623

Patch by Mathias Bynens <mathias@qiwi.be> on 2017-08-16
Reviewed by Ryosuke Niwa.

* Speedometer/resources/todomvc/architecture-examples/angularjs/index.html: Made title consistent.
* Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/angular-resource/angular-resource.min.js: Added.
* Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/angular-resource/angular-resource.min.js.map: Added.
* Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/angular-route/angular-route.min.js: Added.
* Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/angular-route/angular-route.min.js.map: Added.
* Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/angular/angular.min.js: Added.
* Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/angular/angular.min.js.map: Added.
* Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/todomvc-app-css/package.json: Updated per build steps.
* Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/todomvc-common/package.json: Updated per build steps.
* Speedometer/resources/todomvc/architecture-examples/angularjs/package-lock.json: Added to pin dependencies.
* Speedometer/resources/todomvc/architecture-examples/angularjs/package.json: Updated per build steps.
* Speedometer/resources/todomvc/architecture-examples/angularjs/readme.md: Document the build process.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoSpeedometer: Document Backbone example
commit-queue@webkit.org [Wed, 16 Aug 2017 18:59:28 +0000 (18:59 +0000)]
Speedometer: Document Backbone example
https://bugs.webkit.org/show_bug.cgi?id=175626

Patch by Mathias Bynens <mathias@qiwi.be> on 2017-08-16
Reviewed by Ryosuke Niwa.

* Speedometer/resources/todomvc/architecture-examples/backbone/index.html: Made title consistent.
* Speedometer/resources/todomvc/architecture-examples/backbone/node_modules/backbone/backbone-min.js: Added.
* Speedometer/resources/todomvc/architecture-examples/backbone/node_modules/backbone/backbone-min.map: Added.
* Speedometer/resources/todomvc/architecture-examples/backbone/node_modules/jquery/dist/jquery.js: Updated per build steps.
* Speedometer/resources/todomvc/architecture-examples/backbone/node_modules/jquery/dist/jquery.min.js: Added.
* Speedometer/resources/todomvc/architecture-examples/backbone/node_modules/jquery/dist/jquery.min.map: Added.
* Speedometer/resources/todomvc/architecture-examples/backbone/node_modules/todomvc-app-css/index.css: Updated per build steps.
* Speedometer/resources/todomvc/architecture-examples/backbone/node_modules/underscore/underscore-min.js: Added.
* Speedometer/resources/todomvc/architecture-examples/backbone/node_modules/underscore/underscore-min.map: Added.
* Speedometer/resources/todomvc/architecture-examples/backbone/package-lock.json: Added.
* Speedometer/resources/todomvc/architecture-examples/backbone/readme.md: Documented build steps.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoEventSource: ignore IDs with U+0000
cdumez@apple.com [Wed, 16 Aug 2017 17:30:39 +0000 (17:30 +0000)]
EventSource: ignore IDs with U+0000
https://bugs.webkit.org/show_bug.cgi?id=175178

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Import WPT test coverage from:
- https://github.com/w3c/web-platform-tests/pull/6584

* web-platform-tests/eventsource/format-field-id-null-expected.txt: Added.
* web-platform-tests/eventsource/format-field-id-null.htm: Added.
* web-platform-tests/eventsource/resources/last-event-id.py:
(main):
* web-platform-tests/eventsource/w3c-import.log:

Source/WebCore:

EventSource: ignore IDs with U+0000 as per:
https://github.com/whatwg/html/pull/2849

Test: imported/w3c/web-platform-tests/eventsource/format-field-id-null.htm

* page/EventSource.cpp:
(WebCore::EventSource::parseEventStreamLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRebaseline js/dom/global-constructors-attributes.html.
ryanhaddad@apple.com [Wed, 16 Aug 2017 16:46:15 +0000 (16:46 +0000)]
Rebaseline js/dom/global-constructors-attributes.html.

Unreviewed test gardening.

* platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[HarfBuzz] Decomposed Vietnamese characters are rendered incorrectly
commit-queue@webkit.org [Wed, 16 Aug 2017 16:36:35 +0000 (16:36 +0000)]
[HarfBuzz] Decomposed Vietnamese characters are rendered incorrectly
https://bugs.webkit.org/show_bug.cgi?id=174418

Patch by Fujii Hironori <Hironori.Fujii@sony.com> on 2017-08-16
Reviewed by Michael Catanzaro.

Source/WebCore:

HarfBuzzShaper should normalize the input text before collecting
HarfBuzzRuns. Actually, HarfBuzzShaper::setNormalizedBuffer does
the task. But, this function hasn't been called from anywhere
since Bug 90951.

Test: fast/text/international/vietnamese-nfd.html
      imported/blink/fast/text/international/text-shaping-arabic-diffs.html

* platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::HarfBuzzShaper):
Call setNormalizedBuffer instead of normalizeCharacters.
(WebCore::normalizeCharacters): Deleted.
(WebCore::normalizeSpacesAndMirrorChars) Use
FontCascade::treatAsZeroWidthSpaceInComplexScript instead of
FontCascade::treatAsZeroWidthSpace to preserve ZWJ and ZWNJ.

LayoutTests:

* fast/text/international/vietnamese-nfd-expected.html: Added.
* fast/text/international/vietnamese-nfd.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, rebaseline a few tests after r220779.
cdumez@apple.com [Wed, 16 Aug 2017 15:43:26 +0000 (15:43 +0000)]
Unreviewed, rebaseline a few tests after r220779.

* http/tests/blink/sendbeacon/beacon-same-origin-expected.txt:
* http/wpt/beacon/cors/cors-preflight-arraybufferview-failure.html:
* http/wpt/beacon/cors/cors-preflight-arraybufferview-success.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMove first-letter renderer mutation code out of RenderBlock and into RenderTreeUpdater
antti@apple.com [Wed, 16 Aug 2017 13:15:20 +0000 (13:15 +0000)]
Move first-letter renderer mutation code out of RenderBlock and into RenderTreeUpdater
https://bugs.webkit.org/show_bug.cgi?id=175627

Reviewed by Andreas Kling.

Render tree should not mutate itself. We already fixed this for first-letter, supporting code
can now move to RenderTreeUpdater too.

* CMakeLists.txt:
* WebCore.xcodeproj/project.pbxproj:
* rendering/RenderBlock.cpp:
(WebCore::styleForFirstLetter): Deleted.
(WebCore::isPunctuationForFirstLetter): Deleted.
(WebCore::shouldSkipForFirstLetter): Deleted.
(WebCore::RenderBlock::updateFirstLetterStyle): Deleted.
(WebCore::RenderBlock::createFirstLetterRenderer): Deleted.
(WebCore::RenderBlock::updateFirstLetter): Deleted.
* rendering/RenderBlock.h:
* rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::updateFirstLetter): Deleted.
* rendering/RenderRubyRun.h:
* rendering/RenderTable.cpp:
(WebCore::RenderTable::updateFirstLetter): Deleted.
* rendering/RenderTable.h:

    Virtual overrides just disabled first letter for some RenderBlock subclasses. This is now achieved via
    supportsFirstLetter test in the first letter updater.

* rendering/TextAutoSizing.cpp:
(WebCore::TextAutoSizingValue::adjustTextNodeSizes):
* rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::updateFirstLetter): Deleted.
* rendering/svg/RenderSVGText.h:
* style/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::popParent):
* style/RenderTreeUpdater.h:
* style/RenderTreeUpdaterFirstLetter.cpp: Added.
(WebCore::styleForFirstLetter):
(WebCore::isPunctuationForFirstLetter):
(WebCore::shouldSkipForFirstLetter):
(WebCore::updateFirstLetterStyle):
(WebCore::createFirstLetterRenderer):
(WebCore::supportsFirstLetter):
(WebCore::RenderTreeUpdater::FirstLetter::update):
* style/RenderTreeUpdaterFirstLetter.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWebDriver: fix return value of close window command
carlosgc@webkit.org [Wed, 16 Aug 2017 11:38:22 +0000 (11:38 +0000)]
WebDriver: fix return value of close window command
https://bugs.webkit.org/show_bug.cgi?id=174861

Reviewed by Brian Burg.

We are currently returning null, but we should return the list of window handles, and try to close the session
if there aren't more window handles.

10.2 Close Window
https://w3c.github.io/webdriver/webdriver-spec.html#close-window

3. If there are no more open top-level browsing contexts, then try to close the session.
4. Return the result of running the remote end steps for the Get Window Handles command.

* Session.cpp:
(WebDriver::Session::closeAllToplevelBrowsingContexts): Helper function to close the given toplevel browsing
context and the next one if there are more.
(WebDriver::Session::close): Call closeAllToplevelBrowsingContexts() to delete all toplevel browsing contexts of
the session.
(WebDriver::Session::closeTopLevelBrowsingContext): Close the given toplevel browsing context and call
getWindowHandles() when done.
(WebDriver::Session::closeWindow): Call closeTopLevelBrowsingContext() passing the current toplevel browsing context.
(WebDriver::Session::getWindowHandles): Remove the early return, this command doesn't depend on a current
toplevel browsing context.
* Session.h:
* SessionHost.h:
* WebDriverService.cpp:
(WebDriver::WebDriverService::run): Disconnect the server when main loop quits.
(WebDriver::WebDriverService::deleteSession): Do not fail if the given session is not active.
(WebDriver::WebDriverService::closeWindow): Remove the session if the closed window was the last one.
* WebDriverService.h: Remove unused quit() method.
* glib/SessionHostGlib.cpp:
(WebDriver::SessionHost::isConnected): Return whether host is connected to a browser instance.
(WebDriver::SessionHost::dbusConnectionClosedCallback): Delete m_browser.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[GTK] Crash of WebProcess with on-demand AC
magomez@igalia.com [Wed, 16 Aug 2017 11:26:39 +0000 (11:26 +0000)]
[GTK] Crash of WebProcess with on-demand AC
https://bugs.webkit.org/show_bug.cgi?id=171161

Reviewed by Carlos Garcia Campos.

Set the viewOverlayRootLayer to the previous layerTreeHost if it exists. This avoids a
crash when reusing the previous layerTreeHost, because it would keep a reference to an
already destroyed viewOverlayRootLayer.

* WebProcess/WebPage/AcceleratedDrawingArea.cpp:
(WebKit::AcceleratedDrawingArea::attachViewOverlayGraphicsLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[CoordGraphics] Simplify CoordinatedGraphicsScene state updates
zandobersek@gmail.com [Wed, 16 Aug 2017 11:21:41 +0000 (11:21 +0000)]
[CoordGraphics] Simplify CoordinatedGraphicsScene state updates
https://bugs.webkit.org/show_bug.cgi?id=175528
<rdar://problem/33876795>

Reviewed by Carlos Garcia Campos.

Hold the information about state updates in ThreadedCompositor, in the
m_attributes struct. This way we don't need to store the updates in
functors and accumulate them in the CoordinatedGraphicsScene class, but
instead just apply any pending state update or atlas removal before the
scene is rendered.

This removes the need to update the CoordinatedGraphicsScene object from
the main thread with data that ultimately has to be handled on the
composition thread. Similarly, when updating CoordinatedGraphicsScene, we
only need to synchronize on the m_attributes lock object once in order to
retrieve the scene update information, instead of having each functor do
that repeatedly.

Outside of CoordinatedGraphicsScene and ThreadedCompositor classes, the
CompositingCoordinator class now passes the atlases-to-remove Vector by
a const lvalue reference down to ThreadedCompositor, and then manually
clears the Vector. Before the Vector was passed as an rvalue reference,
depending on the ThreadedCompositor code to clear out the original Vector
object by moving its resources into the functor object. This doesn't occur
anymore because the Vector object is now appended to another Vector.

* Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:
(WebKit::CoordinatedGraphicsScene::applyStateChanges):
(WebKit::CoordinatedGraphicsScene::paintToCurrentGLContext):
(WebKit::CoordinatedGraphicsScene::detach):
(WebKit::CoordinatedGraphicsScene::setActive):
(WebKit::CoordinatedGraphicsScene::syncRemoteContent): Deleted.
(WebKit::CoordinatedGraphicsScene::appendUpdate): Deleted.
* Shared/CoordinatedGraphics/CoordinatedGraphicsScene.h:
* Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:
(WebKit::ThreadedCompositor::renderLayerTree):
(WebKit::ThreadedCompositor::updateSceneState):
(WebKit::ThreadedCompositor::releaseUpdateAtlases):
* Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
* WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:
(WebKit::CompositingCoordinator::flushPendingLayerChanges):
(WebKit::CompositingCoordinator::releaseAtlases):
(WebKit::CompositingCoordinator::clearUpdateAtlases):
* WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h:
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
* WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:
(WebKit::ThreadedCoordinatedLayerTreeHost::releaseUpdateAtlases):
* WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoFix JSCOnly ARM buildbots after r220047 and r220184
ossy@webkit.org [Wed, 16 Aug 2017 10:06:14 +0000 (10:06 +0000)]
Fix JSCOnly ARM buildbots after r220047 and r220184
https://bugs.webkit.org/show_bug.cgi?id=174993

Reviewed by Carlos Alberto Lopez Perez.

* CMakeLists.txt: Generate only one backend on Linux to save build time.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[GStreamer][EME] Rework handling key systems and UUIDs
calvaris@igalia.com [Wed, 16 Aug 2017 08:25:45 +0000 (08:25 +0000)]
[GStreamer][EME] Rework handling key systems and UUIDs
https://bugs.webkit.org/show_bug.cgi?id=175567

Reviewed by Žan Doberšek.

The UUIDs and key system strings were moved to the
GStreamerEMEUtilities class because so far they were managed by
the decryptors and that was ugly.

* platform/GStreamer.cmake:
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::supportsKeySystem):
* platform/graphics/gstreamer/eme/GStreamerEMEUtilities.cpp: Added.
* platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h: Added.
(WebCore::GStreamerEMEUtilities::isClearKeyKeySystem):
(WebCore::GStreamerEMEUtilities::keySystemToUuid):
* platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp:
(webkit_media_clear_key_decrypt_class_init):
* platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Payment Request] Add an ENABLE flag and an experimental feature preference
aestes@apple.com [Wed, 16 Aug 2017 07:34:15 +0000 (07:34 +0000)]
[Payment Request] Add an ENABLE flag and an experimental feature preference
https://bugs.webkit.org/show_bug.cgi?id=175622

Reviewed by Tim Horton.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:
* page/Settings.in:

Source/WebCore/PAL:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit:

* Configurations/FeatureDefines.xcconfig:
* Shared/WebPreferencesDefinitions.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetPaymentRequestEnabled):
(WKPreferencesGetPaymentRequestEnabled):
* UIProcess/API/C/WKPreferencesRefPrivate.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):

Source/WebKitLegacy/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WTF:

* wtf/FeatureDefines.h:

Tools:

* TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[GTK][WPE] WebKitAutomationSession should set session client to nullptr on dispose
carlosgc@webkit.org [Wed, 16 Aug 2017 06:09:38 +0000 (06:09 +0000)]
[GTK][WPE] WebKitAutomationSession should set session client to nullptr on dispose
https://bugs.webkit.org/show_bug.cgi?id=175564

Reviewed by Carlos Alberto Lopez Perez.

WebAutomationSession expects its client to be nullptr in the destructor.

* UIProcess/API/glib/WebKitAutomationSession.cpp:
(webkitAutomationSessionDispose):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Payment Request] Import test suite from web-platform-tests
aestes@apple.com [Wed, 16 Aug 2017 03:52:22 +0000 (03:52 +0000)]
[Payment Request] Import test suite from web-platform-tests
https://bugs.webkit.org/show_bug.cgi?id=175612
<rdar://problem/33906070>

Reviewed by Tim Horton.

LayoutTests/imported/w3c:

Imported the payment-request test suite using import-w3c-tests. Generated failing expected
results for each test and skipped 5 tests that currently time out.

* resources/import-expectations.json:
* resources/resource-files.json:
* web-platform-tests/payment-request/OWNERS: Added.
* web-platform-tests/payment-request/allowpaymentrequest/active-document-cross-origin.https.sub-expected.txt: Added.
* web-platform-tests/payment-request/allowpaymentrequest/active-document-cross-origin.https.sub.html: Added.
* web-platform-tests/payment-request/allowpaymentrequest/active-document-same-origin.https-expected.txt: Added.
* web-platform-tests/payment-request/allowpaymentrequest/active-document-same-origin.https.html: Added.
* web-platform-tests/payment-request/allowpaymentrequest/allowpaymentrequest-attribute-cross-origin-bc-containers.https-expected.txt: Added.
* web-platform-tests/payment-request/allowpaymentrequest/allowpaymentrequest-attribute-cross-origin-bc-containers.https.html: Added.
* web-platform-tests/payment-request/allowpaymentrequest/allowpaymentrequest-attribute-same-origin-bc-containers.https-expected.txt: Added.
* web-platform-tests/payment-request/allowpaymentrequest/allowpaymentrequest-attribute-same-origin-bc-containers.https.html: Added.
* web-platform-tests/payment-request/allowpaymentrequest/basic.https-expected.txt: Added.
* web-platform-tests/payment-request/allowpaymentrequest/basic.https.html: Added.
* web-platform-tests/payment-request/allowpaymentrequest/common.sub.js: Added.
(window.onmessage):
(string_appeared_here.forEach):
* web-platform-tests/payment-request/allowpaymentrequest/echo-PaymentRequest.html: Added.
* web-platform-tests/payment-request/allowpaymentrequest/no-attribute-cross-origin-bc-containers.https-expected.txt: Added.
* web-platform-tests/payment-request/allowpaymentrequest/no-attribute-cross-origin-bc-containers.https.html: Added.
* web-platform-tests/payment-request/allowpaymentrequest/no-attribute-same-origin-bc-containers.https-expected.txt: Added.
* web-platform-tests/payment-request/allowpaymentrequest/no-attribute-same-origin-bc-containers.https.html: Added.
* web-platform-tests/payment-request/allowpaymentrequest/removing-allowpaymentrequest.https.sub-expected.txt: Added.
* web-platform-tests/payment-request/allowpaymentrequest/removing-allowpaymentrequest.https.sub.html: Added.
* web-platform-tests/payment-request/allowpaymentrequest/setting-allowpaymentrequest-timing.https.sub-expected.txt: Added.
* web-platform-tests/payment-request/allowpaymentrequest/setting-allowpaymentrequest-timing.https.sub.html: Added.
* web-platform-tests/payment-request/allowpaymentrequest/setting-allowpaymentrequest.https.sub-expected.txt: Added.
* web-platform-tests/payment-request/allowpaymentrequest/setting-allowpaymentrequest.https.sub.html: Added.
* web-platform-tests/payment-request/allowpaymentrequest/w3c-import.log: Added.
* web-platform-tests/payment-request/historical.https-expected.txt: Added.
* web-platform-tests/payment-request/historical.https.html: Added.
* web-platform-tests/payment-request/interfaces.https-expected.txt: Added.
* web-platform-tests/payment-request/interfaces.https.html: Added.
* web-platform-tests/payment-request/payment-request-abort-method.https-expected.txt: Added.
* web-platform-tests/payment-request/payment-request-abort-method.https.html: Added.
* web-platform-tests/payment-request/payment-request-canmakepayment-method.https.http: Added.
* web-platform-tests/payment-request/payment-request-constructor-crash.https-expected.txt: Added.
* web-platform-tests/payment-request/payment-request-constructor-crash.https.html: Added.
* web-platform-tests/payment-request/payment-request-constructor.https-expected.txt: Added.
* web-platform-tests/payment-request/payment-request-constructor.https.html: Added.
* web-platform-tests/payment-request/payment-request-id.https-expected.txt: Added.
* web-platform-tests/payment-request/payment-request-id.https.html: Added.
* web-platform-tests/payment-request/payment-request-in-iframe-expected.txt: Added.
* web-platform-tests/payment-request/payment-request-in-iframe.html: Added.
* web-platform-tests/payment-request/payment-request-onshippingaddresschange-attribute.https-expected.txt: Added.
* web-platform-tests/payment-request/payment-request-onshippingaddresschange-attribute.https.html: Added.
* web-platform-tests/payment-request/payment-request-onshippingoptionchange-attribute.https-expected.txt: Added.
* web-platform-tests/payment-request/payment-request-onshippingoptionchange-attribute.https.html: Added.
* web-platform-tests/payment-request/payment-request-response-id.html: Added.
* web-platform-tests/payment-request/payment-request-show-method.https-expected.txt: Added.
* web-platform-tests/payment-request/payment-request-show-method.https.html: Added.
* web-platform-tests/payment-request/payment-request-update-event-constructor.http-expected.txt: Added.
* web-platform-tests/payment-request/payment-request-update-event-constructor.http.html: Added.
* web-platform-tests/payment-request/payment-request-update-event-constructor.https-expected.txt: Added.
* web-platform-tests/payment-request/payment-request-update-event-constructor.https.html: Added.
* web-platform-tests/payment-request/w3c-import.log: Added.

LayoutTests:

* TestExpectations: Skipped payment-request tests that currently time out.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWKSnapshotConfiguration is missing from the WebKit umbrella header
timothy_horton@apple.com [Wed, 16 Aug 2017 03:06:42 +0000 (03:06 +0000)]
WKSnapshotConfiguration is missing from the WebKit umbrella header
https://bugs.webkit.org/show_bug.cgi?id=175614
<rdar://problem/33812691>

Reviewed by Dan Bernstein.

* Shared/API/Cocoa/WebKit.h:
Add WKSnapshotConfiguration, which is a public header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWe are too conservative about the effects of PushWithScope
commit-queue@webkit.org [Wed, 16 Aug 2017 02:49:04 +0000 (02:49 +0000)]
We are too conservative about the effects of PushWithScope
https://bugs.webkit.org/show_bug.cgi?id=175584

Patch by Robin Morisset <rmorisset@apple.com> on 2017-08-15
Reviewed by Saam Barati.

PushWithScope converts its argument to an object (this can throw a type error,
but has no other observable effect), and allocates a new scope, that it then
makes the new current scope. We were a bit too
conservative in saying that it clobbers the world.

* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
* dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
* dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMake DataTransferItemList work with plain text entries
rniwa@webkit.org [Wed, 16 Aug 2017 02:23:41 +0000 (02:23 +0000)]
Make DataTransferItemList work with plain text entries
https://bugs.webkit.org/show_bug.cgi?id=175596

Reviewed by Wenson Hsieh.

Source/JavaScriptCore:

Added DataTransferItem as a common identifier since it's a runtime enabled feature.

* runtime/CommonIdentifiers.h:

Source/WebCore:

Added the basic machinery to get the list of plain text items to DataTransferItemList and DataTransferItem.

Each DataTransferItem now depends on DataTransfer so it does ref-forwarding like DataTransferItemList to make
DataTransfer alive as long as any DataTransferItem is alive.

Specifications: https://html.spec.whatwg.org/multipage/dnd.html#the-datatransferitem-interface
                https://html.spec.whatwg.org/multipage/dnd.html#the-datatransferitemlist-interface

Tests: editing/pasteboard/datatransfer-items-drop-plaintext-file.html
       editing/pasteboard/datatransfer-items-paste-plaintext.html

* dom/DataTransferItem.cpp:
(WebCore::DataTransferItem::DataTransferItem): Added two variants one for plain text and another one for a file.
(WebCore::DataTransferItem::kind const): Rewritten.
(WebCore::DataTransferItem::getAsString const): Implemented.
(WebCore::DataTransferItem::getAsFile const): Implemented.
* dom/DataTransferItem.h:
(WebCore::DataTransferItem::ref): Added.
(WebCore::DataTransferItem::deref): Added.
(WebCore::DataTransferItem::type const): Returns String instead of AtomicString.
(WebCore::DataTransferItem::kind const): Moved to cpp.
* dom/DataTransferItem.idl: Removed NoInterfaceObject since the interface object should exist on DOMWindow.
* dom/DataTransferItemList.cpp:
(WebCore::DataTransferItemList::length): Implemented.
(WebCore::DataTransferItemList::item): Ditto.
(WebCore::isSupportedType): Added. For now, we only support text/plain.
(WebCore::DataTransferItemList::ensureItems): Added. Constructs the list of DataTransferItems.
* dom/DataTransferItemList.h:
(DataTransferItemList): Added m_items. The list is filled lazily by ensureItems.
* dom/DataTransferItemList.idl: Removed NoInterfaceObject since the interface object should exist on DOMWindow.

LayoutTests:

Rebaselined the tests and added two regression tests for pasting plain text and dropping a plain text file.

Unfortunately, dropping a file is only supported by DumpRenderTree on Mac :( so it's disabled elsewhere.

* editing/pasteboard/datatransfer-idl-expected.txt: Rebaselined now that NoInterfaceObject has been dropped from
DataTransferItem.idl and DataTransferItemList.idl as expected.
* editing/pasteboard/datatransfer-idl.html: Fixed the bug that it wasn't testing IDL for DataTransferItem.
* editing/pasteboard/datatransfer-items-drop-plaintext-file-expected.txt: Added.
* editing/pasteboard/datatransfer-items-drop-plaintext-file.html: Added.
* editing/pasteboard/datatransfer-items-paste-plaintext-expected.txt: Added.
* editing/pasteboard/datatransfer-items-paste-plaintext.html: Added.
* editing/resources/text-pasteboard-data.txt: Added.
* platform/gtk/js/dom/global-constructors-attributes-expected.txt:
* platform/ios/TestExpectations:
* platform/mac-elcapitan-wk2/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-elcapitan/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-highsierra-wk1/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-highsierra/js/dom/global-constructors-attributes-expected.txt:
* platform/mac/js/dom/global-constructors-attributes-expected.txt:
* platform/win/TestExpectations:
* platform/wk2/TestExpectations:
* platform/wpe/js/dom/global-constructors-attributes-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRemove ScrollView::clipsRepaints() which was only used by Chromium
simon.fraser@apple.com [Wed, 16 Aug 2017 02:05:28 +0000 (02:05 +0000)]
Remove ScrollView::clipsRepaints() which was only used by Chromium
https://bugs.webkit.org/show_bug.cgi?id=175594

Reviewed by Tim Horton.

clipsRepaints() was added in r74568 but was only used by Chromium. It's always
true for other platforms, so remove conditionals that test for it and assume true.

* page/FrameView.cpp:
(WebCore::FrameView::scrollContentsFastPath):
* platform/ScrollView.cpp:
(WebCore::ScrollView::repaintContentRectangle):
(WebCore::ScrollView::setClipsRepaints): Deleted.
* platform/ScrollView.h:
(WebCore::ScrollView::clipsRepaints const): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAllow WebCore logging channels to be set from the UI process
simon.fraser@apple.com [Wed, 16 Aug 2017 01:37:30 +0000 (01:37 +0000)]
Allow WebCore logging channels to be set from the UI process
https://bugs.webkit.org/show_bug.cgi?id=175608

Reviewed by Tim Horton.

Source/WebCore:

Change initializeLogChannelsIfNecessary() to take an optional String, which can
be a list of log channels passed from the UI process.

* platform/LogInitialization.h:
* platform/Logging.cpp:
(WebCore::initializeLogChannelsIfNecessary):

Source/WebKit:

The UI process can now read the "WebCoreLogging" default, and pass it to the web process
via WebProcessCreationParameters, where WebProcess::platformInitializeWebProcess() uses
it to set up WebCore logging channels. Note that these will override channels read from
the web process user defaults domain (but those are hard to set anyway).

* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoFetch / Beacon: Use "application/octet-stream" Content-Type for payloads of type...
cdumez@apple.com [Wed, 16 Aug 2017 01:23:50 +0000 (01:23 +0000)]
Fetch / Beacon: Use "application/octet-stream" Content-Type for payloads of type ArrayBuffer / ArrayBufferView
https://bugs.webkit.org/show_bug.cgi?id=175600

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

* web-platform-tests/beacon/headers/header-content-type-expected.txt:
* web-platform-tests/fetch/api/basic/request-headers.any-expected.txt:
* web-platform-tests/fetch/api/basic/request-headers.any.worker-expected.txt:

Source/WebCore:

Use "application/octet-stream" Content-Type for payloads of type ArrayBuffer / ArrayBufferView in Fetch & Beacon.
If we don't set a Content-Type header, our underlying network stack is going to add a "application/x-www-form-urlencoded"
Content-Type header, which is worse.

Chrome is already using "application/octet-stream" Content-Type in Beacon, but use no Content-Type in Fetch.
The Fetch/Beacon specification says we should have no Content-Type header in this case but this is unfortunately
not something we can support at the moment. Using "application/octet-stream" Content-Type for now seems like the
lesser evil.

Test: http/wpt/fetch/fetch-request-arraybuffer-content-type.html

* Modules/fetch/FetchBody.cpp:
(WebCore::FetchBody::extract):
* platform/network/HTTPHeaderValues.cpp:
(WebCore::HTTPHeaderValues::octetStreamContentType):
* platform/network/HTTPHeaderValues.h:

LayoutTests:

* http/wpt/fetch/fetch-request-arraybuffer-content-type-expected.txt: Added.
* http/wpt/fetch/fetch-request-arraybuffer-content-type.html: Added.
* platform/mac-highsierra/imported/w3c/web-platform-tests/fetch/api/basic/request-headers.any-expected.txt:
* platform/mac-highsierra/imported/w3c/web-platform-tests/fetch/api/basic/request-headers.any.worker-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoJSTests:
commit-queue@webkit.org [Wed, 16 Aug 2017 01:10:01 +0000 (01:10 +0000)]
JSTests:
Support the 'with' keyword in FTL.
https://bugs.webkit.org/show_bug.cgi?id=175585

Patch by Robin Morisset <rmorisset@apple.com> on 2017-08-15
Reviewed by Saam Barati.

Also improve the JSTest/stress/with.js file to test
what happens when non-objects are passed to with.

* stress/with.js:
(foo):
(i.catch):
(i.with): Deleted.

Source/JavaScriptCore:
Support the 'with' keyword in FTL
https://bugs.webkit.org/show_bug.cgi?id=175585

Patch by Robin Morisset <rmorisset@apple.com> on 2017-08-15
Reviewed by Saam Barati.

Also makes sure that the order of arguments of PushWithScope, op_push_with_scope, JSWithScope::create()
and so on is consistent (always parentScope first, the new scopeObject second). We used to go from one
to the other at different step which was quite confusing. I picked this order for consistency with CreateActivation
that takes its parentScope argument first.

* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitPushWithScope):
* debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::evaluateWithScopeExtension):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePushWithScope):
* ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compilePushWithScope):
* jit/JITOperations.cpp:
* runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
* runtime/Completion.cpp:
(JSC::evaluateWithScopeExtension):
* runtime/JSWithScope.cpp:
(JSC::JSWithScope::create):
* runtime/JSWithScope.h:

Source/WebCore:
Change the order of arguments of JSWithScope::create() for consistency
https://bugs.webkit.org/show_bug.cgi?id=175585

Patch by Robin Morisset <rmorisset@apple.com> on 2017-08-15
Reviewed by Saam Barati.

No change of behavior.

* bindings/js/JSHTMLElementCustom.cpp:
(WebCore::JSHTMLElement::pushEventHandlerScope const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMake VM::scratchBufferForSize thread safe
sbarati@apple.com [Wed, 16 Aug 2017 00:03:45 +0000 (00:03 +0000)]
Make VM::scratchBufferForSize thread safe
https://bugs.webkit.org/show_bug.cgi?id=175604

Reviewed by Geoffrey Garen and Mark Lam.

I want to use the VM::scratchBufferForSize in another patch I'm writing.
The use case for my other patch is to call it from the compiler thread.
When reading the code, I saw that this API was not thread safe. This patch
makes it thread safe. It actually turns out we were calling this API from
the compiler thread already when we created FTL::State for an FTL OSR entry
compilation, and from FTLLowerDFGToB3. That code was racy and wrong, but
is now correct with this patch.

* runtime/VM.cpp:
(JSC::VM::VM):
(JSC::VM::~VM):
(JSC::VM::gatherConservativeRoots):
(JSC::VM::scratchBufferForSize):
* runtime/VM.h:
(JSC::VM::scratchBufferForSize): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoSkipped media/modern-media-controls/time-labels-support/elapsed-time.html.
jlewis3@apple.com [Wed, 16 Aug 2017 00:02:51 +0000 (00:02 +0000)]
Skipped media/modern-media-controls/time-labels-support/elapsed-time.html.
<rdar://problem/33731086>

Unreviewed test gardening.

* platform/mac-highsierra/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoLayoutTests: test that an XMLHttpRequest with Content-Encoding: gzip is properly...
jfbastien@apple.com [Tue, 15 Aug 2017 23:48:46 +0000 (23:48 +0000)]
LayoutTests: test that an XMLHttpRequest with Content-Encoding: gzip is properly decompressed
https://bugs.webkit.org/show_bug.cgi?id=175579

Also test that without Content-Encoding proper sniffing takes place, and gzip
decoding occurs. This test is disabled and tracked by #175597.

Reviewed by Daniel Bates.

* TestExpectations:
* http/tests/xmlhttprequest/gzip-content-type-expected.txt: Added.
* http/tests/xmlhttprequest/gzip-content-type-no-content-encoding-expected.txt: Added.
* http/tests/xmlhttprequest/gzip-content-type-no-content-encoding.html: Added.
* http/tests/xmlhttprequest/gzip-content-type.html: Added.
* http/tests/xmlhttprequest/resources/gzip-lorem-no-content-encoding.php: Added.
* http/tests/xmlhttprequest/resources/gzip-lorem.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRe-sync DOM Web-Platform-Tests from upstream
cdumez@apple.com [Tue, 15 Aug 2017 23:23:51 +0000 (23:23 +0000)]
Re-sync DOM Web-Platform-Tests from upstream
https://bugs.webkit.org/show_bug.cgi?id=175588

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Re-sync DOM Web-Platform-Tests from upstream b5129e92ce.

* web-platform-tests/dom/abort/event.any-expected.txt: Added.
* web-platform-tests/dom/abort/event.any.html: Added.
* web-platform-tests/dom/abort/event.any.js: Added.
* web-platform-tests/dom/abort/event.any.worker-expected.txt: Added.
* web-platform-tests/dom/abort/event.any.worker.html: Added.
* web-platform-tests/dom/abort/w3c-import.log: Added.
* web-platform-tests/dom/events/Event-dispatch-click-expected.txt:
* web-platform-tests/dom/events/Event-dispatch-click.html:
* web-platform-tests/dom/events/Event-timestamp-high-resolution-expected.txt: Added.
* web-platform-tests/dom/events/Event-timestamp-high-resolution.html: Added.
* web-platform-tests/dom/events/Event-timestamp-safe-resolution-expected.txt: Added.
* web-platform-tests/dom/events/Event-timestamp-safe-resolution.html: Added.
* web-platform-tests/dom/events/EventTarget-constructible.any-expected.txt: Added.
* web-platform-tests/dom/events/EventTarget-constructible.any.html: Added.
* web-platform-tests/dom/events/EventTarget-constructible.any.js: Added.
(test.listener):
(test):
(test.prototype.on):
(test.prototype.off):
(test.prototype.dispatch):
* web-platform-tests/dom/events/EventTarget-constructible.any.worker-expected.txt: Added.
* web-platform-tests/dom/events/EventTarget-constructible.any.worker.html: Added.
* web-platform-tests/dom/events/EventTarget-dispatchEvent-expected.txt:
* web-platform-tests/dom/events/w3c-import.log:
* web-platform-tests/dom/interface-objects-expected.txt:
* web-platform-tests/dom/interface-objects.html:
* web-platform-tests/dom/interfaces-expected.txt:
* web-platform-tests/dom/interfaces.html:
* web-platform-tests/dom/nodes/Document-constructor-svg.svg: Removed.
* web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_datauri_01-expected.txt: Removed.
* web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_datauri_01.html: Removed.
* web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_datauri_02-expected.txt:
* web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_datauri_02.html:
* web-platform-tests/dom/nodes/Document-contentType/contentType/w3c-import.log:
* web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.html: Added.
* web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.svg: Added.
* web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.xhtml: Added.
* web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.xml: Added.
* web-platform-tests/dom/nodes/Document-createElement-namespace-tests/w3c-import.log:
* web-platform-tests/dom/nodes/Document-createEvent-expected.txt:
* web-platform-tests/dom/nodes/Document-createEvent.html:
* web-platform-tests/dom/nodes/Document-createEvent.js:
* web-platform-tests/dom/nodes/Element-classlist-expected.txt:
* web-platform-tests/dom/nodes/Element-classlist.html:
* web-platform-tests/dom/nodes/Element-matches-init.js: Copied from LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Element-matches.html.
(init):
* web-platform-tests/dom/nodes/Element-matches.html:
* web-platform-tests/dom/nodes/Element-webkitMatchesSelector.html:
* web-platform-tests/dom/nodes/Node-cloneNode-expected.txt:
* web-platform-tests/dom/nodes/Node-cloneNode.html:
* web-platform-tests/dom/nodes/w3c-import.log:
* web-platform-tests/interfaces/OWNERS: Added.
* web-platform-tests/interfaces/clipboard.idl: Added.
* web-platform-tests/interfaces/cssom.idl: Added.
* web-platform-tests/interfaces/dedicated-workers.idl: Added.
* web-platform-tests/interfaces/dom.idl: Added.
* web-platform-tests/interfaces/fullscreen.idl: Added.
* web-platform-tests/interfaces/geometry.idl: Added.
* web-platform-tests/interfaces/html.idl: Added.
* web-platform-tests/interfaces/mediacapture-main.idl: Added.
* web-platform-tests/interfaces/remoteplayback.idl: Added.
* web-platform-tests/interfaces/touchevents.idl: Added.
* web-platform-tests/interfaces/uievents.idl: Added.
* web-platform-tests/interfaces/web-share.idl: Added.
* web-platform-tests/interfaces/webrtc-pc.idl: Added.
* web-platform-tests/interfaces/webusb.idl: Added.

LayoutTests:

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoundefined URL in PopoverTracker for failed step
aakash_jain@apple.com [Tue, 15 Aug 2017 22:58:17 +0000 (22:58 +0000)]
undefined URL in PopoverTracker for failed step
https://bugs.webkit.org/show_bug.cgi?id=175593
<rdar://problem/33898769>

Reviewed by Daniel Bates.

This fix is a workaround for Buildbot 0.9 bug <https://github.com/buildbot/buildbot/issues/3529> where it
does not provide a URL to stdio for a build step. Buildbot 0.8 always included a URL to the stdio of the step.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
(BuildbotIteration.prototype._parseData): Pass the URL while instantiating BuildbotTestResults.
(BuildbotIteration.prototype._urlForStep): Method to get the URL for a step.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
(BuildbotTestResults): Accept URL in constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoJSC named bytecode offsets should use references rather than pointers
keith_miller@apple.com [Tue, 15 Aug 2017 22:54:50 +0000 (22:54 +0000)]
JSC named bytecode offsets should use references rather than pointers
https://bugs.webkit.org/show_bug.cgi?id=175601

Reviewed by Saam Barati.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_overrides_has_instance):
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof_custom):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_overrides_has_instance):
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof_custom):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMark http/tests/loading/resourceLoadStatistics/clear-in-memory-and-persistent-store...
ryanhaddad@apple.com [Tue, 15 Aug 2017 22:43:14 +0000 (22:43 +0000)]
Mark http/tests/loading/resourceLoadStatistics/clear-in-memory-and-persistent-store.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=175263

Unreviewed test gardening.

* platform/wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Cache API] Ensure ResourceResponse is not null when redirected/tainting/type fields...
commit-queue@webkit.org [Tue, 15 Aug 2017 22:38:24 +0000 (22:38 +0000)]
[Cache API] Ensure ResourceResponse is not null when redirected/tainting/type fields are set
https://bugs.webkit.org/show_bug.cgi?id=175538

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-15
Reviewed by Chris Dumez.

No change of behavior.
This change ensures that response type is preserved when encoding/decoding ResourceResponse, in particular the error type.
This will allow Cache API to preserve responses when reading them from a different process.

* platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::setType):
* platform/network/ResourceResponseBase.h:
(WebCore::ResourceResponseBase::setType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMark fast/images/animated-gif-scrolling-crash.html as flaky.
ryanhaddad@apple.com [Tue, 15 Aug 2017 22:34:48 +0000 (22:34 +0000)]
Mark fast/images/animated-gif-scrolling-crash.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=175345.

Unreviewed test gardening.

* platform/mac-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMark fast/mediacapturefromelement/CanvasCaptureMediaStream-webgl-events.html as flaky.
ryanhaddad@apple.com [Tue, 15 Aug 2017 22:06:14 +0000 (22:06 +0000)]
Mark fast/mediacapturefromelement/CanvasCaptureMediaStream-webgl-events.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=175592

Unreviewed test gardening.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220762 268f45cc-cd09-0410-ab3c-d52691b4dbfc