rniwa@webkit.org [Mon, 9 Jul 2012 20:52:34 +0000 (20:52 +0000)]
Build fix after r122115 and some cleanups.
* html/HTMLCollection.h:
(HTMLCollection):
* html/HTMLElement.cpp:
(WebCore::HTMLElement::properties):
* html/HTMLElement.h:
(HTMLElement):
* html/HTMLPropertiesCollection.cpp:
(WebCore::HTMLPropertiesCollection::HTMLPropertiesCollection):
* html/HTMLPropertiesCollection.h:
(HTMLPropertiesCollection):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122155
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Mon, 9 Jul 2012 20:46:29 +0000 (20:46 +0000)]
Handle missing results in TestResultsServer better
https://bugs.webkit.org/show_bug.cgi?id=90816
Reviewed by Ojan Vafai.
If we can't load the results JSON, don't try to wrap it with the JSONP
callback invocation.
* TestResultServer/handlers/testfilehandler.py:
(GetFile.get):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122154
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 9 Jul 2012 20:46:07 +0000 (20:46 +0000)]
[WK2] Add missing Battery Status API integration to WebContext and WebPage
https://bugs.webkit.org/show_bug.cgi?id=90784
Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-09
Reviewed by Anders Carlsson.
Integrate Battery Status API to WebPage, WebContext and
properly route messages to the WebBatteryManagerProxy.
Without this, the Battery Status tests are crashing for
WebKit2.
* UIProcess/API/C/WKContext.cpp:
(WKContextGetBatteryManager):
* UIProcess/API/C/WKContext.h:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
(WebKit::WebContext::disconnectProcess):
(WebKit::WebContext::didReceiveMessage):
* UIProcess/WebContext.h:
(WebKit):
(WebContext):
(WebKit::WebContext::batteryManagerProxy):
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didReceiveMessage):
* WebProcess/WebCoreSupport/WebBatteryClient.cpp:
(WebKit::WebBatteryClient::setController):
(WebKit):
* WebProcess/WebCoreSupport/WebBatteryClient.h:
(WebBatteryClient):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122153
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dino@apple.com [Mon, 9 Jul 2012 20:36:21 +0000 (20:36 +0000)]
Tiled drawing means some elements can disappear behind the page
https://bugs.webkit.org/show_bug.cgi?id=88906
Reviewed by Simon Fraser.
Source/WebCore:
The compositing layers in the tile cache could become siblings
of the compositing layers for page elements. This meant that in
some 3d transforms, the elements could disappear behind the
page background (which is rendered into the tile cache) or intersect
with the tile cache tiles.
Fix this by inserting a flattening layer between the tile cache
and the page, ensuring that the cache will always be rendered
first. I was able to reuse the clipping layer for this, because
the tile cache is attached to the RenderView, so there should never
be a case where we have both a clipping layer and tiles.
The unfortunate part of this code is the temporary state variable
that wraps the call to GraphicsLayer::create. Because that method
calls back into the object, we need to make sure we don't create
another tile cache.
Also added some obvious names to the tile cache layers to
help with debugging.
Test: compositing/tile-cache-must-flatten.html
* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::TileCache): give the tile host layer a name.
(WebCore::TileCache::createTileLayer):
* platform/graphics/ca/mac/WebTileCacheLayer.mm:
(WebCore): give each tile layer a name.
* rendering/RenderLayerBacking.cpp:
(WebCore):
(WebCore::RenderLayerBacking::shouldUseTileCache): check if we're in the middle
of creating the primary graphics layer before answering.
(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer): wrap our call to
createGraphicsLayer with a message to indicate we are making the layer that should
get a tile cache.
(WebCore::RenderLayerBacking::destroyGraphicsLayers):
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): needs to make
sure the flattening layer is in the tree.
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::updateInternalHierarchy):
(WebCore::RenderLayerBacking::updateClippingLayers):
(WebCore::RenderLayerBacking::backingStoreMemoryEstimate):
* rendering/RenderLayerBacking.h: rename m_clippingLayer to m_containmentLayer
because it can now either be the clip or the tile cache flattener. Also
a new state property used when creating the main graphics layer.
(WebCore::RenderLayerBacking::hasClippingLayer):
(WebCore::RenderLayerBacking::clippingLayer):
(WebCore::RenderLayerBacking::parentForSublayers):
(WebCore::RenderLayerBacking::hasTileCacheFlatteningLayer):
(WebCore::RenderLayerBacking::tileCacheFlatteningLayer):
(RenderLayerBacking):
LayoutTests:
Reftest to make sure elements can't disappear behind the tile cache.
* compositing/tile-cache-must-flatten-expected.html: Added.
* compositing/tile-cache-must-flatten.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122152
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 9 Jul 2012 20:10:31 +0000 (20:10 +0000)]
Unreviewed, rolling out r122124.
http://trac.webkit.org/changeset/122124
https://bugs.webkit.org/show_bug.cgi?id=90815
It broke NRWT on Qt (Requested by Ossy_HOME on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-09
* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort._skipped_file_search_paths):
* Scripts/webkitpy/layout_tests/port/qt_unittest.py:
(QtPortTest._assert_skipped_path):
(QtPortTest.test_skipped_file_search_path):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122151
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 9 Jul 2012 19:59:02 +0000 (19:59 +0000)]
[EFL] Log significant Gamepad API-related events
https://bugs.webkit.org/show_bug.cgi?id=90595
Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-09
Reviewed by Antonio Gomes.
Log significant Gamepad API-related events in
GamepadsEfl.
No new tests, no behavior change.
* platform/efl/GamepadsEfl.cpp:
(WebCore::GamepadDeviceEfl::deviceFile):
(GamepadDeviceEfl):
(WebCore::GamepadDeviceEfl::GamepadDeviceEfl):
(WebCore::GamepadDeviceEfl::readCallback):
(WebCore::GamepadsEfl::registerDevice):
(WebCore::GamepadsEfl::unregisterDevice):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122150
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zandobersek@gmail.com [Mon, 9 Jul 2012 19:53:29 +0000 (19:53 +0000)]
[Gtk] Implement dumpFrameScrollPosition in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=89356
Reviewed by Martin Robinson.
Source/WebKit/gtk:
Add a new method for returning the WebKitDOMDocument that is loaded
in a given frame, webkit_web_frame_get_dom_document.
* docs/webkitgtk-sections.txt:
* webkit/webkitwebframe.cpp:
(webkit_web_frame_get_dom_document):
* webkit/webkitwebframe.h:
* webkit/webkitwebview.cpp: State explicitly that the document being returned
when calling webkit_web_view_get_dom_document is loaded in the main frame.
Also call the webkit_web_frame_get_dom_document on WebKitWebView's main frame
to get the document.
Tools:
Implement dumpFrameScrollPosition, acquiring the scroll position
through WebKitDOMDOMWindow of the WebKitDOMDocument loaded in the frame
whose scroll position is being dumped.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(dumpFrameScrollPosition):
LayoutTests:
Update baselines for affected tests, removing these tests from the GTK WK2 Skipped list.
* platform/gtk-wk2/Skipped:
* platform/gtk/css2.1/
20110323/abspos-containing-block-initial-001-expected.txt:
* platform/gtk/fast/block/positioning/rtl-fixed-positioning-expected.txt:
* platform/gtk/fast/block/positioning/vertical-rl/fixed-positioning-expected.txt:
* platform/gtk/fast/dom/focus-contenteditable-expected.txt:
* platform/gtk/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt:
* platform/gtk/fast/dom/scroll-reveal-left-overflow-expected.txt:
* platform/gtk/fast/dom/scroll-reveal-top-overflow-expected.txt:
* platform/gtk/fast/dynamic/anchor-lock-expected.txt:
* platform/gtk/fast/events/autoscroll-expected.txt:
* platform/gtk/fast/events/reveal-link-when-focused-expected.txt:
* platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.txt:
* platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.txt:
* platform/gtk/fast/layers/scroll-rect-to-visible-expected.txt:
* platform/gtk/fast/multicol/scrolling-overflow-expected.txt: Added.
* platform/gtk/fast/overflow/clip-rects-fixed-ancestor-expected.txt: Added.
* platform/gtk/fast/overflow/overflow_hidden-expected.txt:
* platform/gtk/fast/overflow/position-fixed-transform-clipping-expected.txt:
* platform/gtk/fast/overflow/scrollRevealButton-expected.txt:
* platform/gtk/fast/repaint/fixed-child-move-after-scroll-expected.txt:
* platform/gtk/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.txt:
* platform/gtk/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.txt:
* platform/gtk/fast/repaint/fixed-expected.txt:
* platform/gtk/fast/repaint/fixed-move-after-scroll-expected.txt:
* platform/gtk/fast/repaint/fixed-tranformed-expected.txt:
* platform/gtk/fast/repaint/repaint-during-scroll-expected.txt:
* platform/gtk/svg/custom/getscreenctm-in-scrollable-svg-area-expected.txt:
* platform/gtk/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
* platform/gtk/transforms/2d/transform-fixed-container-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122147
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Mon, 9 Jul 2012 19:52:25 +0000 (19:52 +0000)]
Reduce the amount of flashing when falling into tiled layers
https://bugs.webkit.org/show_bug.cgi?id=90808
Reviewed by Dean Jackson.
Implement +prefetchedTiles so that CATiledLayer renders more
tiles at a time, reducing the appearance of flashing.
* platform/graphics/mac/WebTiledLayer.mm:
(+[WebTiledLayer prefetchedTiles]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122145
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leandrogracia@chromium.org [Mon, 9 Jul 2012 19:36:57 +0000 (19:36 +0000)]
SurroundingText should not advance character iterators if they are at end.
https://bugs.webkit.org/show_bug.cgi?id=90560
Reviewed by Ryosuke Niwa.
Source/WebCore:
CharacterIterator and BackwardsCharacterIterator try to advance their
internal TextIterator without checking if they already are at end.
This can cause crashes in TextIterator::advance.
Test: platform/chromium/editing/surrounding-text/surrounding-text.html
* editing/SurroundingText.cpp:
(WebCore::SurroundingText::SurroundingText):
(WebCore::SurroundingText::rangeFromContentOffsets):
Source/WebKit/chromium:
Moving the check for null visible positions to WebCore as it makes no
sense to be in a platform-specific code.
* src/WebSurroundingText.cpp:
(WebKit::WebSurroundingText::initialize):
LayoutTests:
Add a new test case where character iterators are already at end when
trying to advance. This was caught by Chromium's address sanitizer
here: http://code.google.com/p/chromium/issues/detail?id=135705
* platform/chromium/editing/surrounding-text/surrounding-text-expected.txt:
* platform/chromium/editing/surrounding-text/surrounding-text.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122139
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 9 Jul 2012 19:27:37 +0000 (19:27 +0000)]
[EFL] [WK2] ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key)
https://bugs.webkit.org/show_bug.cgi?id=90464
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-07-09
Reviewed by Daniel Bates.
HashMap has the property that 0 is the empty value for integer
keys, so do not use 0 as a key in the HashMap.
* Platform/efl/WorkQueueEfl.cpp:
(WorkQueue::dispatchAfterDelay):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122136
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 9 Jul 2012 19:27:11 +0000 (19:27 +0000)]
[BlackBerry] meta viewport initial-scale doesn't factor in device pixel ratio
https://bugs.webkit.org/show_bug.cgi?id=90575
Patch by Mike Lattanzio <mlattanzio@rim.com> on 2012-07-09
Reviewed by Rob Buis.
.:
Add a manual test to verify wide content doesn't interfere
with initial-scale calculations.
Internal review from Konrad Piascik.
* ManualTests/blackberry/meta-viewport-initial-scale-wide-content.html: Added.
Source/WebKit/blackberry:
Refactor meta viewport handling to multiply the developer
specified scale properties by the devicePixelRatio. This
required moving the setting of these values until after
the call to computeViewportAttributes.
This fixes an isssue where content wider than the meta viewport
would case a zoom-out-to-fit scenario because we misinterpreted
the specified initial-scale.
New test to verify wide content doesn't affect initial-scale:
ManualTests/blackberry/meta-viewport-initial-scale-wide-content.html
Internal review from Konrad Piascik, Arvid Nilsson.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
(BlackBerry::WebKit::WebPagePrivate::dispatchViewportPropertiesDidChange):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122135
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 9 Jul 2012 19:25:16 +0000 (19:25 +0000)]
[EFL] [WK2] Ecore errors from ecore_evas_screen_geometry_get()
https://bugs.webkit.org/show_bug.cgi?id=90609
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-07-09
Reviewed by Daniel Bates.
Do not call ecore_evas_screen_geometry_get() if ecoreEvas is null.
No new tests. This patch doesn't change behavior.
* platform/efl/PlatformScreenEfl.cpp:
(WebCore::screenRect): Early return if Evas is null.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122134
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rafaelw@chromium.org [Mon, 9 Jul 2012 19:18:37 +0000 (19:18 +0000)]
Unreviewed gardening. Update TestExpectations after filename change in r122109.
* platform/chromium/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122132
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
achicu@adobe.com [Mon, 9 Jul 2012 19:16:12 +0000 (19:16 +0000)]
[CSS Filters] Blur filter is not repainted correctly when applied on a parent of a fixed element
https://bugs.webkit.org/show_bug.cgi?id=90087
Reviewed by Simon Fraser.
Source/WebCore:
Added a new method, RenderLayer::hasAncestorWithFilterOutsets, to check that there's no filter with outsets (ie. blur)
applied on top level fixed positioned elements, nor any of its parent layers. In the event of a blur filter we need to
disable the fast scrolling optimization, otherwise the outsets of the filter will be carried around the page and
repainting will not work correctly.
Tests: css3/filters/blur-filter-page-scroll-parents.html
css3/filters/blur-filter-page-scroll-self.html
* page/FrameView.cpp:
(WebCore::FrameView::scrollContentsFastPath):
* rendering/RenderLayer.cpp:
(WebCore):
(WebCore::RenderLayer::hasAncestorWithFilterOutsets):
* rendering/RenderLayer.h:
(RenderLayer):
LayoutTests:
Added two new tests to check that we disable fast path scrolling for fixed positioned
elements that have blur applied on them or any of the parent layers.
* css3/filters/blur-filter-page-scroll-parents.html: Added.
* css3/filters/blur-filter-page-scroll-self.html: Added.
* platform/chromium/css3/filters/blur-filter-page-scroll-parents-expected.png: Added.
* platform/chromium/css3/filters/blur-filter-page-scroll-parents-expected.txt: Added.
* platform/chromium/css3/filters/blur-filter-page-scroll-self-expected.png: Added.
* platform/chromium/css3/filters/blur-filter-page-scroll-self-expected.txt: Added.
* platform/mac/css3/filters/blur-filter-page-scroll-parents-expected.png: Added.
* platform/mac/css3/filters/blur-filter-page-scroll-parents-expected.txt: Added.
* platform/mac/css3/filters/blur-filter-page-scroll-self-expected.png: Added.
* platform/mac/css3/filters/blur-filter-page-scroll-self-expected.txt: Added.
* platform/qt/Skipped: Qt needs platform results.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122130
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jsbell@chromium.org [Mon, 9 Jul 2012 19:04:03 +0000 (19:04 +0000)]
IndexedDB: Empty arrays shouldn't be valid key paths
https://bugs.webkit.org/show_bug.cgi?id=90798
Reviewed by Tony Chang.
Source/WebCore:
Other IDB implementations already enforce this although it is not yet in
the spec (see https://www.w3.org/Bugs/Public/show_bug.cgi?id=17657). If an
empty array is passed as the key path arg to IDBDatabase.createObjectStore()
or IDBObjectStore.createIndex(), a SYNTAX_ERR DOMException is now thrown.
Test: storage/indexeddb/keypath-arrays.html
storage/indexeddb/keypath-basics.html
* Modules/indexeddb/IDBKeyPath.cpp:
(WebCore::IDBKeyPath::isValid): Test for empty array.
LayoutTests:
* storage/indexeddb/keypath-arrays-expected.txt:
* storage/indexeddb/keypath-basics-expected.txt:
* storage/indexeddb/resources/keypath-arrays.js:
(openSuccess.request.onsuccess):
(openSuccess):
* storage/indexeddb/resources/keypath-basics.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122127
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 9 Jul 2012 18:53:45 +0000 (18:53 +0000)]
[Qt][NRWT] Enable cascaded TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=89108
Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-07-09
Reviewed by Dirk Pranke.
* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort.expectations_files):
* Scripts/webkitpy/layout_tests/port/qt_unittest.py:
(QtPortTest._assert_expectations_files):
(QtPortTest.test_expectations_files):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122124
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
danakj@chromium.org [Mon, 9 Jul 2012 18:37:28 +0000 (18:37 +0000)]
[chromium] Create render surfaces on main thread only for the current frame
https://bugs.webkit.org/show_bug.cgi?id=89793
Reviewed by Adrienne Walker.
Source/WebCore:
Previously we would create render surfaces for animating layers
in the main thread since these layers might have a surface on impl,
in order to assist culling. This makes it very difficult to estimate
how much texture memory is needed for RenderSurfaces on the main
thread, in order to keep contents+surface memory below our limit.
Here we stop doing this, and create RenderSurfaces on both threads
under the same conditions, so main thread has surfaces only if the
layers in its current frame demand them. While this may reduce
paint culling within an animating subtree, this seems like an edge
case and knowing the amount of surface memory needed for the frame
is important.
Animation tests in CCLayerTreeHostCommonTest used to verify that these
layers got surfaces, so now no longer do. Creation of surfaces under
other conditions is covered by other CCLayerTreeHostCommonTests.
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::subtreeShouldRenderToSeparateSurface):
Source/WebKit/chromium:
* tests/CCLayerTreeHostCommonTest.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122120
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Mon, 9 Jul 2012 18:32:01 +0000 (18:32 +0000)]
Mac build fix after r122116.
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122119
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Mon, 9 Jul 2012 18:25:51 +0000 (18:25 +0000)]
EFL build fix after r122115.
* html/HTMLPropertiesCollection.cpp:
(WebCore::HTMLPropertiesCollection::create):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122118
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Mon, 9 Jul 2012 18:25:20 +0000 (18:25 +0000)]
Fixed clean builds of the All target in the DumpRenderTree project.
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Let Xcode know that the
DumpRenderTree Perl Support target depends on the DumpRenderTree target.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122117
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 9 Jul 2012 18:00:11 +0000 (18:00 +0000)]
Make GC3D and E3D more maintainable for GLES platforms
https://bugs.webkit.org/show_bug.cgi?id=90567
Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-07-09
Reviewed by Rob Buis.
This patch cleans up code for WebGL on OpenGLES platforms which use
GraphicsContext3DOpenGL* and Extensions3DOpenGL*. Although
GraphicsContext3DOpenGL was already split into GraphicsContext3DOpenGL,
GraphicsContext3DOpenGLCommon, and GraphicsContext3DOpenGLES, this patch
is an attempt to refactor this code in a way that will help BlackBerry and
other teams support WebGL on mobile platforms with as little use of
"#IF USE(OPENGL_ES_2)" in common code as possible. Also included is the
separation of Extensions3DOpenGL into Extensions3DOpenGLCommon,
Extensions3DOpenGL, and Extensions3DOpenGLES as well as the introduction
of OpenGLESShims.
This patch is created in large part by Jonathan Feldstein.
No new tests: no new behaviour.
* PlatformBlackBerry.cmake: Recognize BlackBerry as OPENGL ES, add new files to build
* Target.pri: Add new Extensions3DOpenGL* to WebGL builds
* platform/graphics/GraphicsContext3D.h: Add validateDepthStencil, make systemAllowsMultisamplingOnATICards a a member function.
(WebCore):
* platform/graphics/OpenGLESShims.h: Added.
* platform/graphics/opengl/Extensions3DOpenGL.cpp: Move code to Extensions3DOpenGLCommon where possible
(WebCore::Extensions3DOpenGL::Extensions3DOpenGL): Reflect that it is now inherits Extensions3DCommon
(WebCore::Extensions3DOpenGL::supportsExtension): Contains OpenGL specific code from supports
(WebCore):
(WebCore::Extensions3DOpenGL::getExtensions): Returns a list of extensions
* platform/graphics/opengl/Extensions3DOpenGL.h: Remove functions now in Extensions3DOpenGLCommon
(WebCore):
(Extensions3DOpenGL):
* platform/graphics/opengl/Extensions3DOpenGLCommon.cpp: Added.
(WebCore):
(WebCore::Extensions3DOpenGLCommon::Extensions3DOpenGLCommon):
(WebCore::Extensions3DOpenGLCommon::~Extensions3DOpenGLCommon):
(WebCore::Extensions3DOpenGLCommon::supports):
(WebCore::Extensions3DOpenGLCommon::ensureEnabled):
(WebCore::Extensions3DOpenGLCommon::isEnabled):
(WebCore::Extensions3DOpenGLCommon::getGraphicsResetStatusARB):
(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE): Existed before, but did nothing. Now does what is says it does.
(WebCore::Extensions3DOpenGLCommon::initializeAvailableExtensions): Moved from Extensions3DOpenGL::supports
* platform/graphics/opengl/Extensions3DOpenGLCommon.h: Copied from Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.h.
(WebCore):
(Extensions3DOpenGLCommon):
* platform/graphics/opengl/Extensions3DOpenGLES.cpp: Added.
(WebCore):
(WebCore::Extensions3DOpenGLES::Extensions3DOpenGLES):
(WebCore::Extensions3DOpenGLES::~Extensions3DOpenGLES):
(WebCore::Extensions3DOpenGLES::framebufferTexture2DMultisampleIMG):
(WebCore::Extensions3DOpenGLES::renderbufferStorageMultisampleIMG):
(WebCore::Extensions3DOpenGLES::createVertexArrayOES):
(WebCore::Extensions3DOpenGLES::deleteVertexArrayOES):
(WebCore::Extensions3DOpenGLES::isVertexArrayOES):
(WebCore::Extensions3DOpenGLES::bindVertexArrayOES):
(WebCore::Extensions3DOpenGLES::supportsExtension): Contains OpenGLES specific code from supports
(WebCore::Extensions3DOpenGLES::getExtensions):
* platform/graphics/opengl/Extensions3DOpenGLES.h: Copied from Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.h.
(WebCore):
(Extensions3DOpenGLES):
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::validateAttributes):
(WebCore):
(WebCore::GraphicsContext3D::renderbufferStorage):
(WebCore::GraphicsContext3D::texImage2D):
(WebCore::GraphicsContext3D::systemAllowsMultisamplingOnATICards): Now a member function.
(WebCore::GraphicsContext3D::getExtensions):
* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::validateDepthStencil):
(WebCore::GraphicsContext3D::clear):
(WebCore::GraphicsContext3D::isTexture):
(WebCore):
(WebCore::GraphicsContext3D::lineWidth):
(WebCore::GraphicsContext3D::linkProgram):
(WebCore::GraphicsContext3D::pixelStorei):
(WebCore::GraphicsContext3D::polygonOffset):
(WebCore::GraphicsContext3D::readPixels):
(WebCore::GraphicsContext3D::deleteBuffer):
* platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:
(WebCore::GraphicsContext3D::releaseShaderCompiler):
(WebCore::GraphicsContext3D::readPixelsAndConvertToBGRAIfNecessary):
(WebCore::GraphicsContext3D::validateAttributes):
(WebCore):
(WebCore::GraphicsContext3D::getExtensions):
(WebCore::GraphicsContext3D::systemAllowsMultisamplingOnATICards): Now a member function.
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore):
(WebCore::GraphicsContext3D::releaseShaderCompiler):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122116
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Mon, 9 Jul 2012 17:40:09 +0000 (17:40 +0000)]
Make HTMLCollection RefCounted
https://bugs.webkit.org/show_bug.cgi?id=90414
Reviewed by Sam Weinig.
Source/WebCore:
Make HTMLCollection ref counted and stop forwarding ref and deref to its owner (m_base)
so as to align its life time management to that of DynamicNodeList.
After this patch, each HTMLCollection is owned by JSC/V8 and m_cachedCollections in ElementRareData
and m_collection in Document merely hold raw pointers for the caching purpose. These raw pointers
are cleared when each HTMLCollection is destructed via corresponding removeCachedHTMLCollection's.
In the destructor of HTMLCollection, we use the CollectionType to decide whether base() is an element
or an document, and call the appropriate removeCachedHTMLCollection except for WindowNamedItems and
DocumentNamedItems. For those two types, we need to know the atomic string name associated with
the collection just like many DynamicNodeList to remove the cache, so we let HTMLNameCollection
directly call removeWindowNamedItemCache and removeDocumentNamedItemCache. We'll cleanup this mess in
a follow up patch using a nice class hierarchy and virtual destructors.
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::getDocumentLinks):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::namedItemGetter):
* bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::nameGetter):
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::namedPropertyGetter):
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::openSearchDescriptionURL):
(WebCore):
(WebCore::Document::cachedCollection):
(WebCore::Document::removeCachedHTMLCollection):
(WebCore::Document::images):
(WebCore::Document::applets):
(WebCore::Document::embeds):
(WebCore::Document::plugins):
(WebCore::Document::objects):
(WebCore::Document::scripts):
(WebCore::Document::links):
(WebCore::Document::forms):
(WebCore::Document::anchors):
(WebCore::Document::all):
(WebCore::Document::windowNamedItems):
(WebCore::Document::documentNamedItems):
(WebCore::Document::removeWindowNamedItemCache):
(WebCore::Document::removeDocumentNamedItemCache):
* dom/Document.h:
(Document):
* dom/Element.cpp:
(WebCore::Element::ensureCachedHTMLCollection):
(WebCore::ElementRareData::ensureCachedHTMLCollection):
(WebCore::Element::removeCachedHTMLCollection):
(WebCore):
* dom/Element.h:
(Element):
* dom/ElementRareData.h:
(ElementRareData):
(WebCore::ElementRareData::cachedHTMLCollection):
(WebCore::ElementRareData::removeCachedHTMLCollection):
* html/CollectionType.h:
(WebCore): Since WindowNamedItems is not a part of UnnamedDocumentCachedType, we shouldn't addd 1.
(WebCore::isUnnamedDocumentCachedType):
(WebCore::isNodeCollectionType):
* html/HTMLAllCollection.cpp:
(WebCore::HTMLAllCollection::create):
* html/HTMLAllCollection.h:
(HTMLAllCollection):
* html/HTMLCollection.cpp:
(WebCore::HTMLCollection::create):
(WebCore::HTMLCollection::~HTMLCollection):
(WebCore::HTMLCollection::itemAfter):
* html/HTMLCollection.h:
(WebCore::HTMLCollectionCacheBase::HTMLCollectionCacheBase):
(HTMLCollection):
(WebCore::HTMLCollection::base):
* html/HTMLDataListElement.cpp:
(WebCore::HTMLDataListElement::options):
* html/HTMLDataListElement.h:
(HTMLDataListElement):
* html/HTMLElement.cpp:
(WebCore::HTMLElement::children):
(WebCore::HTMLElement::properties):
* html/HTMLElement.h:
(HTMLElement):
* html/HTMLFieldSetElement.cpp:
(WebCore::HTMLFieldSetElement::elements):
* html/HTMLFieldSetElement.h:
(HTMLFieldSetElement):
* html/HTMLFormCollection.cpp:
(WebCore::HTMLFormCollection::create):
* html/HTMLFormCollection.h:
(HTMLFormCollection):
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::elements):
* html/HTMLFormElement.h:
(HTMLFormElement):
* html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::imageElement):
(WebCore::HTMLMapElement::areas):
* html/HTMLMapElement.h:
(HTMLMapElement):
* html/HTMLNameCollection.cpp:
(WebCore::HTMLNameCollection::HTMLNameCollection):
(WebCore::HTMLNameCollection::~HTMLNameCollection):
(WebCore):
* html/HTMLNameCollection.h:
(WebCore::HTMLNameCollection::create):
(HTMLNameCollection):
* html/HTMLOptionsCollection.cpp:
(WebCore::HTMLOptionsCollection::create):
* html/HTMLOptionsCollection.h:
(HTMLOptionsCollection):
* html/HTMLPropertiesCollection.h:
(HTMLPropertiesCollection):
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::selectedOptions):
(WebCore::HTMLSelectElement::options):
* html/HTMLSelectElement.h:
(HTMLSelectElement):
* html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::rows):
(WebCore::HTMLTableElement::tBodies):
* html/HTMLTableElement.h:
(HTMLTableElement):
* html/HTMLTableRowElement.cpp:
(WebCore::HTMLTableRowElement::insertCell):
(WebCore::HTMLTableRowElement::deleteCell):
(WebCore::HTMLTableRowElement::cells):
* html/HTMLTableRowElement.h:
(HTMLTableRowElement):
* html/HTMLTableRowsCollection.cpp:
(WebCore::HTMLTableRowsCollection::create):
* html/HTMLTableRowsCollection.h:
(HTMLTableRowsCollection):
* html/HTMLTableSectionElement.cpp:
(WebCore::HTMLTableSectionElement::insertRow):
(WebCore::HTMLTableSectionElement::deleteRow):
(WebCore::HTMLTableSectionElement::rows):
* html/HTMLTableSectionElement.h:
(HTMLTableSectionElement):
Source/WebKit/chromium:
* src/WebPageSerializer.cpp:
(WebCore::retrieveResourcesForFrame):
* src/WebPageSerializerImpl.cpp:
(WebKit::WebPageSerializerImpl::collectTargetFrames):
Source/WebKit/win:
* DOMHTMLClasses.cpp:
(DOMHTMLDocument::forms):
(DOMHTMLSelectElement::options):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122115
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Mon, 9 Jul 2012 17:30:38 +0000 (17:30 +0000)]
Web Inspector: unindent line ending block upon { hit.
https://bugs.webkit.org/show_bug.cgi?id=90795
Reviewed by Vsevolod Vlasov.
Added block-start / block-end markup into the highlighter.
* inspector/front-end/SourceCSSTokenizer.js:
(WebInspector.SourceCSSTokenizer.prototype.nextToken):
* inspector/front-end/SourceCSSTokenizer.re2js:
* inspector/front-end/SourceJavaScriptTokenizer.js:
(WebInspector.SourceJavaScriptTokenizer.prototype.nextToken):
* inspector/front-end/SourceJavaScriptTokenizer.re2js:
* inspector/front-end/TextEditor.js:
(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
(WebInspector.TextEditorMainPanel.prototype._unindentAfterBlock):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122114
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Mon, 9 Jul 2012 17:24:55 +0000 (17:24 +0000)]
[GTK] Add a setting to enable/disable page cache to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=90773
Reviewed by Martin Robinson.
* UIProcess/API/gtk/WebKitSettings.cpp:
(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init):
(webkit_settings_get_enable_page_cache):
(webkit_settings_set_enable_page_cache):
* UIProcess/API/gtk/WebKitSettings.h:
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
* UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
(testWebKitSettings):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122113
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zandobersek@gmail.com [Mon, 9 Jul 2012 16:39:15 +0000 (16:39 +0000)]
[Gtk] Unskip the CSS Regions layout tests
https://bugs.webkit.org/show_bug.cgi?id=90771
Reviewed by Martin Robinson.
Source/WebKit/gtk:
Add a method to DumpRenderTreeSupportGtk for enabling or disabling
CSS Regions from DumpRenderTree.
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::setCSSRegionsEnabled):
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):
Tools:
Use the DumpRenderTreeSupportGtk method for enabling the CSS Regions,
calling it when resetting the defaults in DumpRenderTree or when the
settings value is overriden through the testRunner.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::overridePreference):
LayoutTests:
Unskip CSS Regions tests, updating baselines for the affected tests.
* platform/gtk/TestExpectations:
* platform/gtk/fast/regions/bottom-overflow-out-of-first-region-expected.png: Added.
* platform/gtk/fast/regions/bottom-overflow-out-of-first-region-expected.txt:
* platform/gtk/fast/regions/flow-content-basic-expected.png: Added.
* platform/gtk/fast/regions/flow-content-basic-expected.txt:
* platform/gtk/fast/regions/flow-content-basic-vertical-expected.png: Added.
* platform/gtk/fast/regions/flow-content-basic-vertical-expected.txt:
* platform/gtk/fast/regions/flow-content-basic-vertical-rl-expected.png: Added.
* platform/gtk/fast/regions/flow-content-basic-vertical-rl-expected.txt:
* platform/gtk/fast/regions/flows-dependency-dynamic-remove-expected.png: Added.
* platform/gtk/fast/regions/flows-dependency-dynamic-remove-expected.txt:
* platform/gtk/fast/regions/flows-dependency-same-flow-expected.png: Added.
* platform/gtk/fast/regions/flows-dependency-same-flow-expected.txt:
* platform/gtk/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png: Added.
* platform/gtk/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt:
* platform/gtk/fast/regions/overflow-in-uniform-regions-dynamic-expected.png: Added.
* platform/gtk/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt:
* platform/gtk/fast/regions/overflow-in-variable-width-regions-expected.png: Added.
* platform/gtk/fast/regions/overflow-in-variable-width-regions-expected.txt:
* platform/gtk/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png: Added.
* platform/gtk/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt:
* platform/gtk/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.png: Added.
* platform/gtk/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt:
* platform/gtk/fast/regions/overflow-rtl-in-variable-width-regions-expected.png: Added.
* platform/gtk/fast/regions/overflow-rtl-in-variable-width-regions-expected.txt:
* platform/gtk/fast/regions/overflow-size-change-in-variable-width-regions-expected.png: Added.
* platform/gtk/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt:
* platform/gtk/fast/regions/overflow-size-change-with-stacking-context-expected.png: Added.
* platform/gtk/fast/regions/overflow-size-change-with-stacking-context-expected.txt:
* platform/gtk/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.png: Added.
* platform/gtk/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.txt:
* platform/gtk/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.png: Added.
* platform/gtk/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.txt:
* platform/gtk/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.png: Added.
* platform/gtk/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.txt:
* platform/gtk/fast/regions/percentage-margins-rtl-variable-width-regions-expected.png: Added.
* platform/gtk/fast/regions/percentage-margins-rtl-variable-width-regions-expected.txt:
* platform/gtk/fast/regions/percentage-margins-variable-width-regions-expected.png: Added.
* platform/gtk/fast/regions/percentage-margins-variable-width-regions-expected.txt:
* platform/gtk/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Added.
* platform/gtk/fast/regions/region-overflow-auto-overflow-hidden-expected.txt:
* platform/gtk/fast/regions/region-overflow-auto-overflow-visible-expected.png: Added.
* platform/gtk/fast/regions/region-overflow-auto-overflow-visible-expected.txt:
* platform/gtk/fast/regions/region-style-block-background-color-expected.png: Added.
* platform/gtk/fast/regions/region-style-block-background-color-expected.txt:
* platform/gtk/fast/regions/region-style-block-background-color2-expected.png: Added.
* platform/gtk/fast/regions/region-style-block-background-color2-expected.txt:
* platform/gtk/fast/regions/text-region-split-small-pagination-expected.png: Added.
* platform/gtk/fast/regions/text-region-split-small-pagination-expected.txt:
* platform/gtk/fast/regions/top-overflow-out-of-second-region-expected.png: Added.
* platform/gtk/fast/regions/top-overflow-out-of-second-region-expected.txt:
* platform/gtk/fast/regions/webkit-flow-double-pagination-float-push-expected.png: Added.
* platform/gtk/fast/regions/webkit-flow-double-pagination-float-push-expected.txt:
* platform/gtk/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png: Added.
* platform/gtk/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt:
* platform/gtk/fast/regions/webkit-flow-float-unable-to-push-expected.png: Added.
* platform/gtk/fast/regions/webkit-flow-float-unable-to-push-expected.txt:
* platform/gtk/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png: Added.
* platform/gtk/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt:
* platform/gtk/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.png: Added.
* platform/gtk/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt:
* platform/gtk/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.png: Added.
* platform/gtk/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt:
* platform/gtk/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.png: Added.
* platform/gtk/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt:
* platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
* platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
* platform/gtk/fast/repaint/line-flow-with-floats-in-regions-expected.png:
* platform/gtk/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
* platform/gtk/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png:
* platform/gtk/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt:
* platform/gtk/fast/repaint/region-painting-invalidation-expected.png:
* platform/gtk/fast/repaint/region-painting-invalidation-expected.txt:
* platform/gtk/fast/repaint/region-painting-via-layout-expected.png:
* platform/gtk/fast/repaint/region-painting-via-layout-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122112
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 9 Jul 2012 16:32:42 +0000 (16:32 +0000)]
[GTK] Memory leak in webkitwebnavigationaction.cpp
https://bugs.webkit.org/show_bug.cgi?id=90787
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-07-09
Reviewed by Martin Robinson.
Fixed a memory leak in WebKitWebNavigationAction.
* webkit/webkitwebnavigationaction.cpp:
(webkit_web_navigation_action_finalize): Free the g_strdup()'d string.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122111
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 9 Jul 2012 15:39:09 +0000 (15:39 +0000)]
Unreviewed, rolling out r122107.
http://trac.webkit.org/changeset/122107
https://bugs.webkit.org/show_bug.cgi?id=90794
Build failure on Mac debug bots (Requested by falken_ on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-09
.:
* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
* Configurations/FeatureDefines.xcconfig:
Source/WebCore:
* CMakeLists.txt:
* Configurations/FeatureDefines.xcconfig:
* DerivedSources.cpp:
* DerivedSources.make:
* DerivedSources.pri:
* Target.pri:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
* bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
* dom/ContextFeatures.cpp:
* dom/ContextFeatures.h:
* html/HTMLDialogElement.cpp: Removed.
* html/HTMLDialogElement.h: Removed.
* html/HTMLDialogElement.idl: Removed.
* html/HTMLElementsAllInOne.cpp:
* html/HTMLTagNames.in:
* page/DOMWindow.idl:
Source/WebKit/chromium:
* features.gypi:
* public/WebRuntimeFeatures.h:
(WebRuntimeFeatures):
* src/WebRuntimeFeatures.cpp:
Source/WebKit/mac:
* Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
* Configurations/FeatureDefines.xcconfig:
Tools:
* Scripts/webkitperl/FeatureList.pm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122110
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 9 Jul 2012 15:35:06 +0000 (15:35 +0000)]
[CSSRegions] Rename NamedFlow::getRegionsByContentNode to NamedFlow::getRegionsByContent
https://bugs.webkit.org/show_bug.cgi?id=90759
Patch by Andrei Onea <onea@adobe.com> on 2012-07-09
Reviewed by Andreas Kling.
Source/WebCore:
Renamed NamedFlow::getRegionsByContentNode to NamedFlow::getRegionsByContent as per CSS Regions spec:
http://www.w3.org/TR/css3-regions/#dom-named-flow
Tests: fast/regions/get-regions-by-content-horiz-bt.html
fast/regions/get-regions-by-content-horiz-tb.html
fast/regions/get-regions-by-content-vert-lr.html
fast/regions/get-regions-by-content-vert-rl.html
fast/regions/get-regions-by-content.html
fast/regions/get-regions-by-content2.html
* dom/WebKitNamedFlow.cpp:
(WebCore::WebKitNamedFlow::getRegionsByContent):
* dom/WebKitNamedFlow.h:
(WebKitNamedFlow):
* dom/WebKitNamedFlow.idl:
LayoutTests:
Renamed test files and functions from 77746: [CSSRegions]Implement NamedFlow::getRegionsByContentNode
* fast/regions/get-regions-by-content-expected.txt: Renamed from LayoutTests/fast/regions/get-regions-by-content-node-expected.txt.
* fast/regions/get-regions-by-content-horiz-bt-expected.txt: Renamed from LayoutTests/fast/regions/get-regions-by-content-node-vert-lr-expected.txt.
* fast/regions/get-regions-by-content-horiz-bt.html: Renamed from LayoutTests/fast/regions/get-regions-by-content-node-horiz-bt.html.
* fast/regions/get-regions-by-content-horiz-tb-expected.txt: Renamed from LayoutTests/fast/regions/get-regions-by-content-node-horiz-tb-expected.txt.
* fast/regions/get-regions-by-content-horiz-tb.html: Renamed from LayoutTests/fast/regions/get-regions-by-content-node-horiz-tb.html.
* fast/regions/get-regions-by-content-vert-lr-expected.txt: Renamed from LayoutTests/fast/regions/get-regions-by-content-node-vert-rl-expected.txt.
* fast/regions/get-regions-by-content-vert-lr.html: Renamed from LayoutTests/fast/regions/get-regions-by-content-node-vert-lr.html.
* fast/regions/get-regions-by-content-vert-rl-expected.txt: Renamed from LayoutTests/fast/regions/get-regions-by-content-node-horiz-bt-expected.txt.
* fast/regions/get-regions-by-content-vert-rl.html: Renamed from LayoutTests/fast/regions/get-regions-by-content-node-vert-rl.html.
* fast/regions/get-regions-by-content.html: Renamed from LayoutTests/fast/regions/get-regions-by-content-node.html.
* fast/regions/get-regions-by-content2-expected.txt: Renamed from LayoutTests/fast/regions/get-regions-by-content-node2-expected.txt.
* fast/regions/get-regions-by-content2.html: Renamed from LayoutTests/fast/regions/get-regions-by-content-node2.html.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122109
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Mon, 9 Jul 2012 15:11:46 +0000 (15:11 +0000)]
[GTK] Fix inspector detach when inspector was attached by the client
https://bugs.webkit.org/show_bug.cgi?id=90763
Reviewed by Martin Robinson.
When the inspector is detached, we are unconditionally removing it
from the inspected view, but if the inspector was attached by the
client, the parent might be another widget.
* UIProcess/gtk/WebInspectorProxyGtk.cpp:
(WebKit::WebInspectorProxy::platformDetach): Remove the inspector
view from its parent widget.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122108
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 9 Jul 2012 14:42:00 +0000 (14:42 +0000)]
Add ENABLE_DIALOG_ELEMENT and skeleton files
https://bugs.webkit.org/show_bug.cgi?id=90521
Patch by Matt Falkenhagen <falken@chromium.org> on 2012-07-09
Reviewed by Kent Tamura.
.:
* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
* Configurations/FeatureDefines.xcconfig:
Source/WebCore:
This adds the ENABLE_DIALOG_ELEMENT feature flag and dummy implementation files for <dialog>. In addition, a runtime feature flag is added.
The feature is diabled by default.
No new tests, as there is no behavior change.
* CMakeLists.txt:
* Configurations/FeatureDefines.xcconfig:
* DerivedSources.cpp:
* DerivedSources.make:
* DerivedSources.pri:
* Target.pri:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
* bindings/generic/RuntimeEnabledFeatures.h: Added a runtime feature flag for dialog.
(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::dialogElementEnabled):
(WebCore::RuntimeEnabledFeatures::setDialogElementEnabled):
* dom/ContextFeatures.cpp:
(WebCore::ContextFeatures::dialogElementEnabled):
(WebCore):
* dom/ContextFeatures.h: Added a per-context flag for dialog so that dialog can be disabled in HTMLTagNames.in and DOMWindow.idl when the dialog runtime feature flag is off.
* html/HTMLDialogElement.cpp: Added.
(WebCore):
(WebCore::HTMLDialogElement::HTMLDialogElement):
(WebCore::HTMLDialogElement::create):
(WebCore::HTMLDialogElement::close):
(WebCore::HTMLDialogElement::show):
* html/HTMLDialogElement.h: Added.
(WebCore):
(HTMLDialogElement):
* html/HTMLDialogElement.idl: Added.
* html/HTMLElementsAllInOne.cpp:
* html/HTMLTagNames.in:
* page/DOMWindow.idl:
Source/WebKit/chromium:
* features.gypi:
* public/WebRuntimeFeatures.h:
(WebRuntimeFeatures):
* src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableDialogElement):
(WebKit):
(WebKit::WebRuntimeFeatures::isDialogElementEnabled):
Source/WebKit/mac:
* Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
* Configurations/FeatureDefines.xcconfig:
Tools:
* Scripts/webkitperl/FeatureList.pm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122107
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Mon, 9 Jul 2012 13:45:34 +0000 (13:45 +0000)]
Web Inspector: inspector does not reflect newly created text nodes from contenteditable
https://bugs.webkit.org/show_bug.cgi?id=90779
Reviewed by Vsevolod Vlasov.
Source/WebCore:
We need to report first text node as inserted, otherwise we fail to report character data modified on it.
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::characterDataModified):
LayoutTests:
* inspector/elements/insert-node-expected.txt:
* inspector/elements/insert-node.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122106
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Mon, 9 Jul 2012 13:36:07 +0000 (13:36 +0000)]
REGRESSION(r121980) Layout Test inspector/timeline/timeline-frames.html started to crash.
https://bugs.webkit.org/show_bug.cgi?id=90747
Reviewed by Pavel Feldman.
Source/WebCore:
- consider didCancelFrame() call normal if there is no pending frame, remove assertion;
- always set empty data object for frame records;
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::didCancelFrame):
(WebCore::InspectorTimelineAgent::commitFrameRecord):
LayoutTests:
- remove CRASH expectations for timeline-frames.html
* platform/chromium/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122105
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 9 Jul 2012 12:33:48 +0000 (12:33 +0000)]
Web Inspector: Add FileContentView for FileSystemView
https://bugs.webkit.org/show_bug.cgi?id=90529
Adding FileContentView to Inspector.
This class provides preview of text files in FileSystem.
Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-07-09
Reviewed by Vsevolod Vlasov.
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/FileContentView.js: Added.
* inspector/front-end/FileSystemView.js:
(WebInspector.FileSystemView.prototype.get visibleView):
(WebInspector.FileSystemView.EntryTreeElement.prototype.onselect):
(WebInspector.FileSystemView.EntryTreeElement.prototype._directoryContentReceived):
(WebInspector.FileSystemView.EntryTreeElement.prototype.refresh):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122104
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Mon, 9 Jul 2012 12:28:12 +0000 (12:28 +0000)]
[SOUP] Use soup_cookie_jar_is_persistent() to set whether cookie is a session one or not
https://bugs.webkit.org/show_bug.cgi?id=90769
Reviewed by Gustavo Noronha Silva.
It's currently set to false, because there were no API to know
whether cookies were persistent or not. Now that we bumped libsoup
requirements, we can use soup_cookie_jar_is_persistent().
* platform/network/soup/CookieJarSoup.cpp:
(WebCore::getRawCookies):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122103
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 9 Jul 2012 11:36:37 +0000 (11:36 +0000)]
[EFL] Simplify runTest function by defining default arguments.
https://bugs.webkit.org/show_bug.cgi?id=90525
Patch by Krzysztof Czech <k.czech@samsung.com> on 2012-07-09
Reviewed by Chang Shu.
Default arguments will simplify macro RUN_TEST.
Function will only have one mandatory argument, callback test function.
Added static modifiers to callback functions.
* tests/UnitTestUtils/EWKTestBase.h:
(EWKTestBase):
* tests/test_ewk_view.cpp:
(ewkViewEditableGetCb):
(TEST):
(ewkViewUriGetCb):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122102
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 9 Jul 2012 10:52:12 +0000 (10:52 +0000)]
Web Inspector: Add text file support for FileSystemAgent::requestFileContent
https://bugs.webkit.org/show_bug.cgi?id=90439
Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-07-09
Reviewed by Vsevolod Vlasov.
Source/WebCore:
* inspector/Inspector.json:
* inspector/InspectorFileSystemAgent.cpp:
(WebCore):
(WebCore::InspectorFileSystemAgent::requestFileContent):
* inspector/InspectorFileSystemAgent.h:
(InspectorFileSystemAgent):
* inspector/front-end/FileSystemModel.js:
(WebInspector.FileSystemModel.prototype.requestFileContent):
(WebInspector.FileSystemModel.File.prototype.requestFileContent):
(WebInspector.FileSystemRequestManager.prototype._fileContentReceived):
(WebInspector.FileSystemDispatcher.prototype.fileContentReceived):
LayoutTests:
* http/tests/inspector/filesystem/read-directory-expected.txt:
* http/tests/inspector/filesystem/read-file-expected.txt:
* http/tests/inspector/filesystem/read-file.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122101
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Mon, 9 Jul 2012 09:33:27 +0000 (09:33 +0000)]
Fix the Mac build when codesign_allocate is not installed at /usr/bin.
* PluginProcess/mac/add-entitlements.sh: Let codesign(1) know where the codesign_allocate
tool is by setting the CODESIGN_ALLOCATE environment variable to its path as obtained with
xcrun.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122100
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Mon, 9 Jul 2012 08:53:48 +0000 (08:53 +0000)]
[Chromium] ContextFeaturesClient::isEnabled is slow
https://bugs.webkit.org/show_bug.cgi?id=90367
Reviewed by Kent Tamura.
Source/WebCore:
* dom/ContextFeatures.h:
(WebCore::ContextFeaturesClient::urlDidChange): Added.
(WebCore::ContextFeatures::urlDidChange): Added.
(WebCore):
* dom/Document.cpp:
(WebCore::Document::setURL): Added an urlDidChange() call.
Source/WebKit/chromium:
ContextFeaturesClientImpl::isEnabled touches a heavy part in chrome
where locks are acquired for each invocation.
This change introduces a set of caches to avoid such slow calls.
The cache class ContextFeaturesCache is implemented as a
Supplement of ScriptExecutionContext because the flag bits
depend on the domain of each Document.
* src/ContextFeaturesClientImpl.cpp:
(ContextFeaturesCache): Added.
(Entry): Added.
(WebKit::ContextFeaturesCache::Entry::Entry):
(WebKit::ContextFeaturesCache::Entry::isEnabled):
(WebKit::ContextFeaturesCache::Entry::set):
(WebKit::ContextFeaturesCache::Entry::needsRefresh):
(WebKit::ContextFeaturesCache::entryFor):
(WebKit):
(WebKit::ContextFeaturesCache::supplementName):
(WebKit::ContextFeaturesCache::from):
(WebKit::ContextFeaturesCache::refreshAgainst):
(WebKit::ContextFeaturesClientImpl::isEnabled):
(WebKit::ContextFeaturesClientImpl::urlDidChange): Added to invoke refrshAgainst.
(WebKit::ContextFeaturesClientImpl::askIfIsEnabled):
* src/ContextFeaturesClientImpl.h:
(ContextFeaturesClientImpl):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122099
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Mon, 9 Jul 2012 08:36:51 +0000 (08:36 +0000)]
Unreviewed chromium inspector test fix.
* src/js/Tests.js:
(.TestSuite.prototype.nonAnonymousUISourceCodes_):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122098
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zandobersek@gmail.com [Mon, 9 Jul 2012 08:14:58 +0000 (08:14 +0000)]
Unreviewed, unskipping CSS Exclusions tests for the Gtk port.
The feature is already enabled for this port and all the tests pass.
* platform/gtk/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122097
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 9 Jul 2012 08:08:39 +0000 (08:08 +0000)]
[CSSRegions] Implement NamedFlow::firstEmptyRegionIndex attribute
https://bugs.webkit.org/show_bug.cgi?id=90608
Patch by Andrei Onea <onea@adobe.com> on 2012-07-09
Reviewed by Andreas Kling.
Source/WebCore:
Implemented NamedFlow::firstEmptyRegionIndex as per spec: http://www.w3.org/TR/css3-regions/#dom-named-flow
Test: fast/regions/webkit-named-flow-first-empty-region-index.html
* dom/WebKitNamedFlow.cpp:
(WebCore::WebKitNamedFlow::firstEmptyRegionIndex):
(WebCore):
* dom/WebKitNamedFlow.h:
(WebKitNamedFlow):
* dom/WebKitNamedFlow.idl:
LayoutTests:
Added tests for NamedFlow::firstEmptyRegionIndex.
* fast/regions/webkit-named-flow-first-empty-region-index-expected.txt: Added.
* fast/regions/webkit-named-flow-first-empty-region-index.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122096
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kkristof@inf.u-szeged.hu [Mon, 9 Jul 2012 07:07:29 +0000 (07:07 +0000)]
[Qt] Unreviewed gardening. Skip the failing test.
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122095
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Mon, 9 Jul 2012 06:55:03 +0000 (06:55 +0000)]
Unreviewed gardening.
Marking a storage/indexeddb/mozilla/key-requirements.html as flaky on WebKit Win.
* platform/chromium/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122094
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kkristof@inf.u-szeged.hu [Mon, 9 Jul 2012 06:43:27 +0000 (06:43 +0000)]
[Qt] Unreviewed gardening. Skip the new failing test.
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122093
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Mon, 9 Jul 2012 06:36:03 +0000 (06:36 +0000)]
Unreviewed, checking in platform results.
* platform/mac/css3/filters/effect-reference-expected.txt: Added.
* platform/mac/css3/filters/effect-reference-external-expected.txt: Added.
* platform/mac/css3/filters/effect-reference-hw-expected.txt: Added.
* platform/mac/css3/filters/effect-reference-ordering-expected.txt: Added.
* platform/mac/fast/repaint/repaint-during-scroll-with-zoom-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122092
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yosin@chromium.org [Mon, 9 Jul 2012 06:30:27 +0000 (06:30 +0000)]
[Platform-Mac] Derive LocaleMac.{cpp,h} and LocalizedDateMac.cpp from LocaleWin
https://bugs.webkit.org/show_bug.cgi?id=90752
Reviewed by Kent Tamura.
This patch is preparation of introducing LocaleMac class for localize date form.
This patch copies LocaleWin and LocalizedDateWin.cpp as below:
- LocaleMac.h from LocaleWin.h
- LocaleMac.mm from LocaliedDateMac.mm
- LocaliedDateMac.cpp from LocalizedDateWin.cpp
Due by git, diffs are appeared as new thing. I'll do svn copy at landing time.
No new tests. This patch doesn't change behavior.
* platform/text/mac/LocaleMac.h: Copied from platform/text/LocaleWin.h
* platform/text/mac/LocaleMac.mm: Copied from platform/text/mac/LocalizedDateMac.mm
* platform/text/mac/LocalizedDateMac.cpp: Copied from platform/text/LocalizedDateWin.cpp
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122091
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Mon, 9 Jul 2012 06:19:54 +0000 (06:19 +0000)]
gcc build fix after r121925.
* runtime/JSObject.h:
(JSC::JSFinalObject::finishCreation):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122090
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
laszlo.1.gombos@nokia.com [Mon, 9 Jul 2012 06:12:24 +0000 (06:12 +0000)]
Introduce a build flag for low quality JPEG images
https://bugs.webkit.org/show_bug.cgi?id=90748
Reviewed by Adam Barth.
Source/WebCore:
Introduce build options for no JPEG dithering (USE(LOW_QUALITY_IMAGE_NO_JPEG_DITHERING))
and no JPEG fancy upsampling (USE(LOW_QUALITY_IMAGE_NO_JPEG_FANCY_UPSAMPLING)).
No new tests as there is no change in functionality.
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(ditherMode):
(doFancyUpsampling):
Source/WTF:
Turn on the newly introduced flags for android.
* wtf/Platform.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122089
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gyuyoung.kim@samsung.com [Mon, 9 Jul 2012 05:10:20 +0000 (05:10 +0000)]
Check returned value in BatteryStatus APIs test cases
https://bugs.webkit.org/show_bug.cgi?id=90665
Reviewed by Adam Barth.
It is good to compare with actual values to recognize what is difference.
* batterystatus/add-listener-from-callback-expected.txt:
* batterystatus/basic-all-types-of-events-expected.txt:
* batterystatus/basic-operation-expected.txt:
* batterystatus/script-tests/add-listener-from-callback.js:
(checkBatteryStatus):
* batterystatus/script-tests/basic-all-types-of-events.js:
(checkBatteryStatus):
* batterystatus/script-tests/basic-operation.js:
* batterystatus/script-tests/updates.js:
(checkBatteryStatus):
* batterystatus/updates-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122088
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 9 Jul 2012 04:59:12 +0000 (04:59 +0000)]
Unreviewed, rolling out r121968.
http://trac.webkit.org/changeset/121968
https://bugs.webkit.org/show_bug.cgi?id=90749
Caused a link error on chromium Win dbg. (Requested by hayato
on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-08
* inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):
* inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.MemoryBlockViewProperties._initialize):
* platform/MemoryUsageSupport.cpp:
* platform/MemoryUsageSupport.h:
(MemoryUsageSupport):
* platform/chromium/MemoryUsageSupportChromium.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122087
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mary.wu@torchmobile.com.cn [Mon, 9 Jul 2012 04:56:36 +0000 (04:56 +0000)]
[BlackBerry] Make setForceDownload a setter method.
https://bugs.webkit.org/show_bug.cgi?id=90591
Reviewed by Rob Buis.
* platform/network/blackberry/ResourceRequest.h:
(WebCore::ResourceRequest::setForceDownload):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122086
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zandobersek@gmail.com [Mon, 9 Jul 2012 04:54:33 +0000 (04:54 +0000)]
Unreviewed GTK gardening, remove a redundant baseline for the
http/tests/xmlhttprequest/send-array-buffer.html test,
required after r122074.
* platform/gtk/http/tests/xmlhttprequest/send-array-buffer-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122085
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Mon, 9 Jul 2012 04:47:48 +0000 (04:47 +0000)]
Unreviewed, rolling out r122076.
http://trac.webkit.org/changeset/122076
https://bugs.webkit.org/show_bug.cgi?id=89560
Broke sheriffbot rollout
* Scripts/prepare-ChangeLog:
(generateNewChangeLogs):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122084
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Mon, 9 Jul 2012 04:38:23 +0000 (04:38 +0000)]
Unreviewed gardening.
Marking a inspector/timeline/timeline-frames.html as a CRASH on WebKit Linux (dbg).
* platform/chromium/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122083
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Mon, 9 Jul 2012 04:36:09 +0000 (04:36 +0000)]
Heap-use-after-free in WebCore::RenderObject::destroyAndCleanupAnonymousWrappers
https://bugs.webkit.org/show_bug.cgi?id=90480
Reviewed by Kent Tamura.
Source/WebCore:
If <select> has any insertion point, the attachment phase
unpextedly creates a renderer for distributed node and added to
the renderer of the <select>, which breaks an assumption and
results the crash.
This change tighten the childShouldCreateRenderer() to forbid
child renderers even from distributed nodes.
There is an exception as always: ValidationMessage can create a
ShadowRoot to <select>, which generates usually-forbidden child
renderers. This change introduces HTMLFormControlElement::validationMessageContains()
to let these renderers in.
Test: fast/dom/shadow/insertion-point-list-menu-crash.html
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::validationMessageContains):
(WebCore):
* html/HTMLFormControlElement.h:
(HTMLFormControlElement):
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::childShouldCreateRenderer):
* html/ValidationMessage.cpp:
(WebCore::ValidationMessage::contains):
(WebCore):
* html/ValidationMessage.h:
(WebCore):
(ValidationMessage):
LayoutTests:
* fast/dom/shadow/insertion-point-list-menu-crash-expected.txt: Added.
* fast/dom/shadow/insertion-point-list-menu-crash.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122082
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kseo@webkit.org [Mon, 9 Jul 2012 04:30:08 +0000 (04:30 +0000)]
Remove unnecessary member HTMLTreeBuilder::m_lastScriptElementStartPosition
https://bugs.webkit.org/show_bug.cgi?id=90726
Reviewed by Adam Barth.
HTMLTreeBuilder::m_lastScriptElementStartPosition is of no use. Currently,
m_lastScriptElementStartPosition is used to store the text position in
"script" start tag, and then the stored position is passed to m_scriptToProcessStartPosition
later in "script" end tag. Because HTMLTreeBuilder handles one script tag at
a time, we can store the text position directly to m_scriptToProcessStartPosition
in "script" start tag.
No behavior change, so no new tests.
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processScriptStartTag):
* html/parser/HTMLTreeBuilder.h:
(HTMLTreeBuilder):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122081
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Mon, 9 Jul 2012 04:15:23 +0000 (04:15 +0000)]
Unreviewed gardening.
Marking a fast/multicol/column-span-parent-continuation-crash.html as a flaky.
* platform/chromium/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122080
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pdr@google.com [Mon, 9 Jul 2012 03:57:03 +0000 (03:57 +0000)]
Refactor RenderSVGShape to not contain fallback code
https://bugs.webkit.org/show_bug.cgi?id=90514
Reviewed by Nikolas Zimmermann.
The interaction between RenderSVGShape and {RenderSVGEllipse, RenderSVGRect}
was too coupled and it was not clear when a path existed or who controlled
falling back to path codepaths in RenderSVGShape.
This patch cleans up RenderSVGShape so that it does not track fallback state
and does not have special handling for creating a shape in strokeContains. Because
some functions of RenderSVGShape can be called without a path existing, each
of these functions has switched to using the path() function which asserts that
a path exists.
There is only one remaining use of hasPath() in RenderSVGShape which I plan
to remove in a followup patch.
This patch also cleans up RenderSVGRect and RenderSVGEllipse. These classes
now handle fallback tracking themselves and choose when to use their optimized
strokeContains codepaths.
No new tests as this is just a refactoring.
* rendering/svg/RenderSVGEllipse.cpp:
(WebCore::RenderSVGEllipse::RenderSVGEllipse):
(WebCore::RenderSVGEllipse::createShape):
(WebCore::RenderSVGEllipse::objectBoundingBox):
(WebCore::RenderSVGEllipse::strokeBoundingBox):
(WebCore::RenderSVGEllipse::fillShape):
(WebCore::RenderSVGEllipse::strokeShape):
(WebCore::RenderSVGEllipse::shapeDependentStrokeContains):
(WebCore::RenderSVGEllipse::shapeDependentFillContains):
* rendering/svg/RenderSVGEllipse.h:
(WebCore::RenderSVGEllipse::isEmpty):
(RenderSVGEllipse):
* rendering/svg/RenderSVGRect.cpp:
(WebCore::RenderSVGRect::RenderSVGRect):
(WebCore::RenderSVGRect::createShape):
(WebCore::RenderSVGRect::objectBoundingBox):
(WebCore::RenderSVGRect::strokeBoundingBox):
(WebCore::RenderSVGRect::fillShape):
(WebCore::RenderSVGRect::strokeShape):
(WebCore::RenderSVGRect::shapeDependentStrokeContains):
(WebCore::RenderSVGRect::shapeDependentFillContains):
* rendering/svg/RenderSVGRect.h:
(WebCore::RenderSVGRect::isEmpty):
(RenderSVGRect):
* rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::RenderSVGShape):
(WebCore::RenderSVGShape::createShape):
(WebCore::RenderSVGShape::isEmpty):
(WebCore::RenderSVGShape::objectBoundingBox):
(WebCore::RenderSVGShape::shapeDependentStrokeContains):
(WebCore::RenderSVGShape::shapeDependentFillContains):
(WebCore::RenderSVGShape::strokeContains):
(WebCore::RenderSVGShape::layout):
(WebCore::RenderSVGShape::hasSmoothStroke):
(WebCore):
* rendering/svg/RenderSVGShape.h:
(RenderSVGShape):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122079
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 9 Jul 2012 03:51:26 +0000 (03:51 +0000)]
[EFL] REGRESSION (r122035): fullscreen/exit-full-screen-iframe.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=90735
Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-08
Reviewed by Antonio Gomes.
Keep a reference to the Element passed to enterFullScreenForElement() so
that we can reuse it later in exitFullScreenForElement(). This is needed
because the Element passed to exitFullScreenForElement() may be null.
This fixes the crash for the fullscreen/exit-full-screen-iframe.html
test introduced in r122035.
* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::enterFullScreenForElement):
(WebCore::ChromeClientEfl::exitFullScreenForElement):
* WebCoreSupport/ChromeClientEfl.h:
(ChromeClientEfl):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122078
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leandrogracia@chromium.org [Mon, 9 Jul 2012 03:48:56 +0000 (03:48 +0000)]
Update the description of LayoutTestController::textSurroundingElement
https://bugs.webkit.org/show_bug.cgi?id=90620
Reviewed by Adam Barth.
Tools:
Rename and fix the description of the method as its behaviour changed
during the review of https://bugs.webkit.org/show_bug.cgi?id=82461
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::textSurroundingNode):
* DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):
LayoutTests:
Rename textSurroundingElement to match is real behaviour.
* platform/chromium/editing/surrounding-text/surrounding-text.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122077
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Mon, 9 Jul 2012 03:38:48 +0000 (03:38 +0000)]
Improve the template generated by prepare-ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=89560
Reviewed by Ryosuke Niwa.
Produce the following template:
> 2012-06-20 Kent Tamura <tkent@chromium.org>
>
> Need a short description (Oops!).
> Need the bug URL (Oops!).
>
> Reviewed by Ryosuke Niwa.
>
> Additional information of the change such as approach, rationale. Please add per-function descriptions below. (Oops!).
>
> No new tests (Oops!).
* Scripts/prepare-ChangeLog:
(generateNewChangeLogs):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122076
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Mon, 9 Jul 2012 03:26:26 +0000 (03:26 +0000)]
Unreviewed gardening.
Marking a fast/events/display-none-on-focus-crash.html as a flaky.
* platform/chromium/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122075
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kinuko@chromium.org [Mon, 9 Jul 2012 03:09:07 +0000 (03:09 +0000)]
XHR.send should support ArrayBufferView
https://bugs.webkit.org/show_bug.cgi?id=90536
Source/WebCore:
XHR.send should support ArrayBufferView according to the latest draft
and also eventually deprecate ArrayBuffer.
Spec: http://dvcs.w3.org/hg/xhr/raw-file/tip/Overview.html#dom-xmlhttprequest-send
Reviewed by Kenneth Russell.
Test: http/tests/xmlhttprequest/send-array-buffer.html
http/tests/xmlhttprequest/send-data-view.html
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::send):
* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::sendCallback):
* xml/XMLHttpRequest.cpp:
(WebCore):
(WebCore::XMLHttpRequest::send):
* xml/XMLHttpRequest.h:
(XMLHttpRequest):
* xml/XMLHttpRequest.idl:
LayoutTests:
Reviewed by Kenneth Russell.
* http/tests/xmlhttprequest/send-array-buffer-expected.txt:
* http/tests/xmlhttprequest/send-array-buffer.html:
* http/tests/xmlhttprequest/send-data-view-expected.txt: Added.
* http/tests/xmlhttprequest/send-data-view.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122074
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 9 Jul 2012 02:42:30 +0000 (02:42 +0000)]
[EFL] Change notifications directory path of WebKit_INCLUDE_DIRECTORIES in the PlatformEfl.cmake
https://bugs.webkit.org/show_bug.cgi?id=90650
Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-07-08
Reviewed by Laszlo Gombos.
Change directory path for including notifications of WebCore
from WebCore/notifications to WebCore/Modules/notifications
* PlatformEfl.cmake:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122073
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Mon, 9 Jul 2012 02:42:00 +0000 (02:42 +0000)]
Unreviewed gardening.
Fix a wrong entry in r122070.
* platform/chromium/TestExpectations: Replace dont-commit-on-blocked.html with cursor-delete.html.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122072
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Mon, 9 Jul 2012 02:29:55 +0000 (02:29 +0000)]
Unreviewed gardening.
Fix a wrong entry in r122064.
* platform/chromium/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122071
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Mon, 9 Jul 2012 02:22:36 +0000 (02:22 +0000)]
Unreviewed gardening. marking a storage/indexeddb/cursor-delete.html as a flaky crasher after r121629.
* platform/chromium/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122070
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Mon, 9 Jul 2012 01:52:26 +0000 (01:52 +0000)]
Unreviewed gardening.
Rebaseline after r121917.
* platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-23-expected.png: Removed.
* platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-24-expected.png: Removed.
* platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-68-expected.png: Removed.
* platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-69-expected.png: Removed.
* platform/chromium-linux-x86/css3/selectors3/xhtml/css3-modsel-23-expected.png: Removed.
* platform/chromium-linux-x86/css3/selectors3/xhtml/css3-modsel-24-expected.png: Removed.
* platform/chromium-linux-x86/css3/selectors3/xhtml/css3-modsel-69-expected.png: Removed.
* platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-23-expected.png: Removed.
* platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-24-expected.png: Removed.
* platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-68-expected.png: Removed.
* platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-69-expected.png: Removed.
* platform/chromium-linux-x86/editing/selection/3690703-2-expected.png: Removed.
* platform/chromium-linux-x86/editing/selection/3690703-expected.png: Removed.
* platform/chromium-linux-x86/editing/selection/3690719-expected.png: Removed.
* platform/chromium-mac-snowleopard/css1/formatting_model/floating_elements-expected.txt: Removed.
* platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-19b-expected.png:
* platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-23-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-23-expected.txt: Added.
* platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-24-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-24-expected.txt: Copied from LayoutTests/platform/chromium-mac/css3/selectors3/html/css3-modsel-24-expected.txt.
* platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-64-expected.png:
* platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-68-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-68-expected.txt: Copied from LayoutTests/platform/chromium-mac/css3/selectors3/html/css3-modsel-68-expected.txt.
* platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-69-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-69-expected.txt: Added.
* platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-19b-expected.png:
* platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-23-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-23-expected.txt: Added.
* platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-24-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-24-expected.txt: Copied from LayoutTests/platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-24-expected.txt.
* platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-64-expected.png:
* platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-68-expected.txt: Copied from LayoutTests/platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-68-expected.txt.
* platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-69-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-69-expected.txt: Added.
* platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-19b-expected.png:
* platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-23-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-23-expected.txt: Added.
* platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-24-expected.txt: Copied from LayoutTests/platform/chromium-mac/css3/selectors3/xml/css3-modsel-24-expected.txt.
* platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-64-expected.png:
* platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-68-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-68-expected.txt: Copied from LayoutTests/platform/chromium-mac/css3/selectors3/xml/css3-modsel-68-expected.txt.
* platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-69-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-69-expected.txt: Added.
* platform/chromium-mac-snowleopard/css3/unicode-bidi-isolate-basic-expected.png:
* platform/chromium-mac-snowleopard/css3/unicode-bidi-isolate-basic-expected.txt: Copied from LayoutTests/platform/chromium-mac/css3/unicode-bidi-isolate-basic-expected.txt.
* platform/chromium-mac-snowleopard/editing/selection/3690703-2-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/3690703-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/3690719-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/4397952-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/selection-button-text-expected.png:
* platform/chromium-mac-snowleopard/fast/block/float/float-avoidance-expected.png:
* platform/chromium-mac-snowleopard/fast/block/positioning/inline-block-relposition-expected.png:
* platform/chromium-mac-snowleopard/fast/css/continuationCrash-expected.png:
* platform/chromium-mac-snowleopard/fast/css/margin-top-bottom-dynamic-expected.png:
* platform/chromium-mac-snowleopard/fast/css/rtl-ordering-expected.png:
* platform/chromium-mac-snowleopard/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/001-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/basic-buttons-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/blankbuttons-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/box-shadow-override-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/button-cannot-be-nested-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/button-generated-content-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/button-positioned-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/button-sizes-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/button-style-color-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/button-table-styles-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/button-text-transform-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/button-white-space-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/control-restrict-line-height-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/file/file-input-direction-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/file/file-input-disabled-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/file/file-input-pressed-state-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/file/input-file-re-render-expected.png:
* platform/chromium-mac-snowleopard/http/tests/navigation/javascriptlink-frames-expected.png:
* platform/chromium-mac/css1/formatting_model/floating_elements-expected.txt:
* platform/chromium-mac/css3/selectors3/html/css3-modsel-19b-expected.png:
* platform/chromium-mac/css3/selectors3/html/css3-modsel-23-expected.png:
* platform/chromium-mac/css3/selectors3/html/css3-modsel-23-expected.txt: Added.
* platform/chromium-mac/css3/selectors3/html/css3-modsel-24-expected.png:
* platform/chromium-mac/css3/selectors3/html/css3-modsel-24-expected.txt:
* platform/chromium-mac/css3/selectors3/html/css3-modsel-64-expected.png:
* platform/chromium-mac/css3/selectors3/html/css3-modsel-68-expected.png:
* platform/chromium-mac/css3/selectors3/html/css3-modsel-68-expected.txt:
* platform/chromium-mac/css3/selectors3/html/css3-modsel-69-expected.png:
* platform/chromium-mac/css3/selectors3/html/css3-modsel-69-expected.txt: Added.
* platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-19b-expected.png:
* platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-23-expected.png:
* platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-23-expected.txt: Added.
* platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-24-expected.png:
* platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-24-expected.txt:
* platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-64-expected.png:
* platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-68-expected.png:
* platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-68-expected.txt:
* platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-69-expected.png:
* platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-69-expected.txt: Added.
* platform/chromium-mac/css3/selectors3/xml/css3-modsel-19b-expected.png:
* platform/chromium-mac/css3/selectors3/xml/css3-modsel-23-expected.png:
* platform/chromium-mac/css3/selectors3/xml/css3-modsel-23-expected.txt: Added.
* platform/chromium-mac/css3/selectors3/xml/css3-modsel-24-expected.png:
* platform/chromium-mac/css3/selectors3/xml/css3-modsel-24-expected.txt:
* platform/chromium-mac/css3/selectors3/xml/css3-modsel-64-expected.png:
* platform/chromium-mac/css3/selectors3/xml/css3-modsel-68-expected.png:
* platform/chromium-mac/css3/selectors3/xml/css3-modsel-68-expected.txt:
* platform/chromium-mac/css3/selectors3/xml/css3-modsel-69-expected.png:
* platform/chromium-mac/css3/selectors3/xml/css3-modsel-69-expected.txt: Added.
* platform/chromium-mac/css3/unicode-bidi-isolate-basic-expected.png:
* platform/chromium-mac/css3/unicode-bidi-isolate-basic-expected.txt:
* platform/chromium-mac/editing/deleting/5144139-2-expected.txt: Added.
* platform/chromium-mac/editing/selection/3690703-2-expected.png:
* platform/chromium-mac/editing/selection/3690703-2-expected.txt:
* platform/chromium-mac/editing/selection/3690703-expected.png:
* platform/chromium-mac/editing/selection/3690703-expected.txt:
* platform/chromium-mac/editing/selection/3690719-expected.png:
* platform/chromium-mac/editing/selection/3690719-expected.txt:
* platform/chromium-mac/editing/selection/4397952-expected.png:
* platform/chromium-mac/editing/selection/4397952-expected.txt:
* platform/chromium-mac/editing/selection/selection-button-text-expected.png:
* platform/chromium-mac/editing/selection/selection-button-text-expected.txt:
* platform/chromium-mac/fast/block/float/float-avoidance-expected.png:
* platform/chromium-mac/fast/block/positioning/inline-block-relposition-expected.png:
* platform/chromium-mac/fast/block/positioning/inline-block-relposition-expected.txt: Added.
* platform/chromium-mac/fast/css/continuationCrash-expected.png:
* platform/chromium-mac/fast/css/continuationCrash-expected.txt:
* platform/chromium-mac/fast/css/margin-top-bottom-dynamic-expected.png:
* platform/chromium-mac/fast/css/margin-top-bottom-dynamic-expected.txt:
* platform/chromium-mac/fast/css/rtl-ordering-expected.png:
* platform/chromium-mac/fast/css/rtl-ordering-expected.txt:
* platform/chromium-mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png:
* platform/chromium-mac/fast/forms/001-expected.png:
* platform/chromium-mac/fast/forms/001-expected.txt:
* platform/chromium-mac/fast/forms/basic-buttons-expected.png:
* platform/chromium-mac/fast/forms/blankbuttons-expected.png:
* platform/chromium-mac/fast/forms/blankbuttons-expected.txt:
* platform/chromium-mac/fast/forms/box-shadow-override-expected.png:
* platform/chromium-mac/fast/forms/box-shadow-override-expected.txt:
* platform/chromium-mac/fast/forms/button-cannot-be-nested-expected.png:
* platform/chromium-mac/fast/forms/button-cannot-be-nested-expected.txt: Added.
* platform/chromium-mac/fast/forms/button-generated-content-expected.png:
* platform/chromium-mac/fast/forms/button-generated-content-expected.txt: Added.
* platform/chromium-mac/fast/forms/button-positioned-expected.png:
* platform/chromium-mac/fast/forms/button-positioned-expected.txt:
* platform/chromium-mac/fast/forms/button-sizes-expected.png:
* platform/chromium-mac/fast/forms/button-sizes-expected.txt:
* platform/chromium-mac/fast/forms/button-style-color-expected.png:
* platform/chromium-mac/fast/forms/button-style-color-expected.txt:
* platform/chromium-mac/fast/forms/button-table-styles-expected.png:
* platform/chromium-mac/fast/forms/button-table-styles-expected.txt:
* platform/chromium-mac/fast/forms/button-text-transform-expected.png:
* platform/chromium-mac/fast/forms/button-text-transform-expected.txt:
* platform/chromium-mac/fast/forms/button-white-space-expected.png:
* platform/chromium-mac/fast/forms/button-white-space-expected.txt: Added.
* platform/chromium-mac/fast/forms/control-restrict-line-height-expected.png:
* platform/chromium-mac/fast/forms/control-restrict-line-height-expected.txt:
* platform/chromium-mac/fast/forms/file/file-input-direction-expected.png:
* platform/chromium-mac/fast/forms/file/file-input-direction-expected.txt:
* platform/chromium-mac/fast/forms/file/file-input-disabled-expected.png:
* platform/chromium-mac/fast/forms/file/file-input-pressed-state-expected.png:
* platform/chromium-mac/fast/forms/file/input-file-re-render-expected.png:
* platform/chromium-mac/fast/ruby/base-shorter-than-text-expected.png:
* platform/chromium-mac/fast/ruby/base-shorter-than-text-expected.txt: Added.
* platform/chromium-mac/fast/text/international/text-combine-image-test-expected.png:
* platform/chromium-mac/http/tests/navigation/javascriptlink-frames-expected.png:
* platform/chromium-mac/http/tests/navigation/javascriptlink-frames-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122069
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gyuyoung.kim@samsung.com [Mon, 9 Jul 2012 01:47:55 +0000 (01:47 +0000)]
[wx] Unreviewed. Fix notificaitons directory path after notifications move.
* waf/build/settings.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122068
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Mon, 9 Jul 2012 01:41:11 +0000 (01:41 +0000)]
Unreviewed gardening.
Rebaseline after r121917.
* platform/chromium-mac-snowleopard/fast/forms/form-element-geometry-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/formmove3-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/formmove3-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/forms/input-appearance-height-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-button-sizes-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-first-letter-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-value-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/select-baseline-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/targeted-frame-submission-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
* platform/chromium-mac-snowleopard/fast/html/details-replace-summary-child-expected.png:
* platform/chromium-mac-snowleopard/fast/html/details-replace-text-expected.png:
* platform/chromium-mac-snowleopard/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
* platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-expected.png:
* platform/chromium-mac-snowleopard/fast/replaced/width100percent-button-expected.png:
* platform/chromium-mac-snowleopard/fast/replaced/width100percent-checkbox-expected.png:
* platform/chromium-mac-snowleopard/fast/replaced/width100percent-radio-expected.png:
* platform/chromium-mac-snowleopard/fast/selectors/064-expected.png:
* platform/chromium-mac-snowleopard/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.png:
* platform/chromium-mac-snowleopard/fast/table/append-cells2-expected.png:
* platform/chromium-mac-snowleopard/fast/table/remove-td-display-none-expected.png:
* platform/chromium-mac-snowleopard/fast/table/rowindex-expected.png:
* platform/chromium-mac-snowleopard/fast/table/rowindex-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-CSS-expected.png:
* platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-HTML-expected.png:
* platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
* platform/chromium-mac-snowleopard/fast/text/international/bidi-layout-across-linebreak-expected.png:
* platform/chromium-mac-snowleopard/fast/text/international/bidi-layout-across-linebreak-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/text/international/bidi-override-expected.png:
* platform/chromium-mac-snowleopard/fast/text/international/bidi-override-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/text/international/hindi-spacing-expected.png:
* platform/chromium-mac-snowleopard/fast/text/international/text-spliced-font-expected.png:
* platform/chromium-mac-snowleopard/fast/text/international/vertical-text-glyph-test-expected.png:
* platform/chromium-mac-snowleopard/fast/text/international/vertical-text-glyph-test-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/text/international/vertical-text-glyph-test-expected.txt.
* platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.png:
* platform/chromium-mac-snowleopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
* platform/chromium-mac-snowleopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt.
* platform/chromium-mac-snowleopard/fullscreen/full-screen-iframe-zIndex-expected.png:
* platform/chromium-mac-snowleopard/fullscreen/full-screen-remove-ancestor-after-expected.png:
* platform/chromium-mac-snowleopard/fullscreen/full-screen-zIndex-after-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1318-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug138725-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug18359-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-2-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-3-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug26178-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug28928-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug33855-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug39209-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4429-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4527-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-1-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-2-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51037-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51727-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug52505-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug52506-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug60749-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug68912-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug7342-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/dom/tableDom-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/other/move_row-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt: Removed.
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png:
* platform/chromium-mac/fast/forms/form-element-geometry-expected.png:
* platform/chromium-mac/fast/forms/form-element-geometry-expected.txt:
* platform/chromium-mac/fast/forms/formmove3-expected.png:
* platform/chromium-mac/fast/forms/formmove3-expected.txt:
* platform/chromium-mac/fast/forms/input-appearance-height-expected.png:
* platform/chromium-mac/fast/forms/input-appearance-height-expected.txt:
* platform/chromium-mac/fast/forms/input-button-sizes-expected.png:
* platform/chromium-mac/fast/forms/input-button-sizes-expected.txt:
* platform/chromium-mac/fast/forms/input-first-letter-expected.png:
* platform/chromium-mac/fast/forms/input-value-expected.png:
* platform/chromium-mac/fast/forms/select-baseline-expected.png:
* platform/chromium-mac/fast/forms/select-baseline-expected.txt: Added.
* platform/chromium-mac/fast/forms/targeted-frame-submission-expected.png:
* platform/chromium-mac/fast/forms/validation-message-appearance-expected.png:
* platform/chromium-mac/fast/forms/validation-message-appearance-expected.txt:
* platform/chromium-mac/fast/html/details-replace-summary-child-expected.png:
* platform/chromium-mac/fast/html/details-replace-text-expected.png:
* platform/chromium-mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
* platform/chromium-mac/fast/replaced/replaced-breaking-expected.png:
* platform/chromium-mac/fast/replaced/width100percent-button-expected.png:
* platform/chromium-mac/fast/replaced/width100percent-button-expected.txt:
* platform/chromium-mac/fast/replaced/width100percent-checkbox-expected.png:
* platform/chromium-mac/fast/replaced/width100percent-checkbox-expected.txt:
* platform/chromium-mac/fast/replaced/width100percent-radio-expected.png:
* platform/chromium-mac/fast/replaced/width100percent-radio-expected.txt:
* platform/chromium-mac/fast/selectors/064-expected.png:
* platform/chromium-mac/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.png:
* platform/chromium-mac/fast/table/append-cells2-expected.png:
* platform/chromium-mac/fast/table/append-cells2-expected.txt: Added.
* platform/chromium-mac/fast/table/remove-td-display-none-expected.png:
* platform/chromium-mac/fast/table/remove-td-display-none-expected.txt: Added.
* platform/chromium-mac/fast/table/rowindex-expected.png:
* platform/chromium-mac/fast/table/rowindex-expected.txt: Added.
* platform/chromium-mac/fast/text/international/bidi-LDB-2-CSS-expected.png:
* platform/chromium-mac/fast/text/international/bidi-LDB-2-CSS-expected.txt:
* platform/chromium-mac/fast/text/international/bidi-LDB-2-HTML-expected.png:
* platform/chromium-mac/fast/text/international/bidi-LDB-2-HTML-expected.txt:
* platform/chromium-mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
* platform/chromium-mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
* platform/chromium-mac/fast/text/international/bidi-layout-across-linebreak-expected.png:
* platform/chromium-mac/fast/text/international/bidi-layout-across-linebreak-expected.txt: Added.
* platform/chromium-mac/fast/text/international/bidi-override-expected.png:
* platform/chromium-mac/fast/text/international/bidi-override-expected.txt: Added.
* platform/chromium-mac/fast/text/international/hindi-spacing-expected.png:
* platform/chromium-mac/fast/text/international/hindi-spacing-expected.txt: Added.
* platform/chromium-mac/fast/text/international/text-spliced-font-expected.png:
* platform/chromium-mac/fast/text/international/text-spliced-font-expected.txt:
* platform/chromium-mac/fast/text/international/vertical-text-glyph-test-expected.png:
* platform/chromium-mac/fast/text/international/vertical-text-glyph-test-expected.txt:
* platform/chromium-mac/fast/text/textIteratorNilRenderer-expected.png:
* platform/chromium-mac/fast/text/textIteratorNilRenderer-expected.txt:
* platform/chromium-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
* platform/chromium-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
* platform/chromium-mac/fullscreen/full-screen-iframe-zIndex-expected.png:
* platform/chromium-mac/fullscreen/full-screen-remove-ancestor-after-expected.png:
* platform/chromium-mac/fullscreen/full-screen-zIndex-after-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.txt:
* platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.txt:
* platform/chromium-mac/tables/mozilla/bugs/bug138725-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug138725-expected.txt:
* platform/chromium-mac/tables/mozilla/bugs/bug18359-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug18359-expected.txt:
* platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.txt:
* platform/chromium-mac/tables/mozilla/bugs/bug2479-3-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug26178-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug28928-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug28928-expected.txt:
* platform/chromium-mac/tables/mozilla/bugs/bug33855-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug33855-expected.txt:
* platform/chromium-mac/tables/mozilla/bugs/bug39209-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug39209-expected.txt:
* platform/chromium-mac/tables/mozilla/bugs/bug4429-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.txt:
* platform/chromium-mac/tables/mozilla/bugs/bug46368-1-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug46368-1-expected.txt:
* platform/chromium-mac/tables/mozilla/bugs/bug46368-2-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug46368-2-expected.txt:
* platform/chromium-mac/tables/mozilla/bugs/bug51037-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug51727-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug51727-expected.txt:
* platform/chromium-mac/tables/mozilla/bugs/bug52505-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug52506-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug60749-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug60749-expected.txt:
* platform/chromium-mac/tables/mozilla/bugs/bug68912-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug7342-expected.png:
* platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
* platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
* platform/chromium-mac/tables/mozilla/dom/tableDom-expected.png:
* platform/chromium-mac/tables/mozilla/other/move_row-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
* platform/chromium-mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
* platform/chromium-mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122067
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Mon, 9 Jul 2012 01:26:13 +0000 (01:26 +0000)]
Unreviewed gardening.
Rebaseline after r121917.
* platform/chromium-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png:
* platform/chromium-mac/svg/custom/inline-svg-in-xhtml-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122066
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Mon, 9 Jul 2012 01:20:00 +0000 (01:20 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=90722
https://bugs.webkit.org/show_bug.cgi?id=90742
Unreviewed, skip crashing tests.
* platform/mac/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122065
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Mon, 9 Jul 2012 01:11:29 +0000 (01:11 +0000)]
Unreviewed gardening.
https://bugs.webkit.org/show_bug.cgi?id=90741
fast/text-autosizing/simple-paragraph.html (reftest) started to fail after r121907.
* platform/chromium/TestExpectations: Add IMAGE on Mac.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122064
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Mon, 9 Jul 2012 00:38:10 +0000 (00:38 +0000)]
Unreviewed gardening.
Add TIMEOUT for inspector/timeline/timeline-network-received-data.html.
* platform/chromium/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122063
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Mon, 9 Jul 2012 00:26:40 +0000 (00:26 +0000)]
Unreviewed gardening.
Add TIMEOUT for inspector/debugger/live-edit.html.
* platform/chromium/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122062
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Sun, 8 Jul 2012 23:33:34 +0000 (23:33 +0000)]
inspector/profiler/heap-snapshot-comparison-*.html are crashing
https://bugs.webkit.org/show_bug.cgi?id=90722
Unreviewed, skipping another crashing inspector/profiler test and consolidating
the bugs for those tests.
* platform/mac/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122061
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zherczeg@webkit.org [Sun, 8 Jul 2012 10:00:04 +0000 (10:00 +0000)]
[Qt][ARM] Implementing missing macro assembler instructions after r121925
https://bugs.webkit.org/show_bug.cgi?id=90657
Reviewed by Csaba Osztrogonác.
Implementing convertibleLoadPtr, replaceWithLoad and
replaceWithAddressComputation.
* assembler/ARMAssembler.h:
(JSC::ARMAssembler::replaceWithLoad):
(ARMAssembler):
(JSC::ARMAssembler::replaceWithAddressComputation):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::convertibleLoadPtr):
(MacroAssemblerARM):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122060
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sun, 8 Jul 2012 09:04:05 +0000 (09:04 +0000)]
Web Inspector: CodeGeneratorInspector.py should not generate statements with no effect
https://bugs.webkit.org/show_bug.cgi?id=90697
Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-07-08
Reviewed by Vsevolod Vlasov.
Fix to remove the statements with no effect. The check for errors is added only when some valid
statements exist.
No new tests as generator related patch.
* inspector/CodeGeneratorInspector.py:
(Generator.process_command):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122059
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sun, 8 Jul 2012 04:03:40 +0000 (04:03 +0000)]
[EFL][CMake] Remove non-existent include directory
https://bugs.webkit.org/show_bug.cgi?id=90605
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-07
Reviewed by Kentaro Hara.
* PlatformEfl.cmake:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122058
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sun, 8 Jul 2012 01:02:53 +0000 (01:02 +0000)]
[EFL] Fix build break when Accelerated Compositing is on.
https://bugs.webkit.org/show_bug.cgi?id=90718
Unreviewed build fix.
ewk_view_accelerated_compositing_XXX APIs are in ewk_view_private.h
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-07-07
* WebCoreSupport/PageClientEfl.cpp:
(PageClientEfl::createEvasObjectForAcceleratedCompositing):
(PageClientEfl::acceleratedCompositingContext):
* WebCoreSupport/PageClientEfl.h:
(PageClientEfl):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122057
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos@webkit.org [Sat, 7 Jul 2012 22:26:33 +0000 (22:26 +0000)]
Detach animation clients properly if we clear the web page pointer.
https://bugs.webkit.org/show_bug.cgi?id=90730
Reviewed by Adam Treat.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::destroyCompositor):
* Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
(BlackBerry::WebKit::WebPageCompositorPrivate::~WebPageCompositorPrivate):
(WebKit):
(BlackBerry::WebKit::WebPageCompositorPrivate::detach):
(BlackBerry::WebKit::WebPageCompositorPrivate::setPage):
* Api/WebPageCompositor_p.h:
(WebPageCompositorPrivate):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122056
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Sat, 7 Jul 2012 20:53:01 +0000 (20:53 +0000)]
inspector/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=90729
Unreviewed, skip crashing test.
* platform/mac/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122055
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zandobersek@gmail.com [Sat, 7 Jul 2012 19:49:34 +0000 (19:49 +0000)]
REGRESSION (r122035): fullscreen/exit-full-screen-iframe.html failing on GTK Linux 64-bit Release
https://bugs.webkit.org/show_bug.cgi?id=90719
Reviewed by Martin Robinson.
Source/WebKit/gtk:
Follow the approach of the BlackBerry port outlined in r122035, using in exitFullScreenForElement
the fullscreen element to which the reference was saved when enterFullScreenForElement was called.
* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::exitFullScreenForElement):
LayoutTests:
Remove the crashing test expectation for the affected test.
* platform/gtk/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122054
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 7 Jul 2012 08:27:36 +0000 (08:27 +0000)]
Fix build with recent clang.
https://bugs.webkit.org/show_bug.cgi?id=90712
Patch by Nuno Lopes <nlopes@apple.com> on 2012-07-07
Reviewed by Alexey Proskuryakov.
* TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
(DOMWindowExtensionBasic):
* TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
(DOMWindowExtensionNoCache):
* TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
(TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122053
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Sat, 7 Jul 2012 07:26:19 +0000 (07:26 +0000)]
media/media-blocked-by-beforeload.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=90725
Unreviewed, skip flaky test.
* platform/mac/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122052
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Sat, 7 Jul 2012 07:22:30 +0000 (07:22 +0000)]
compositing/iframes/iframe-size-from-zero.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=90724
Unreviewed, skip flaky test.
* platform/mac/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122051
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Sat, 7 Jul 2012 07:17:58 +0000 (07:17 +0000)]
inspector/debugger/set-breakpoint.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=90723
Unreviewed, skip crashing test.
* platform/mac/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122050
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Sat, 7 Jul 2012 07:13:23 +0000 (07:13 +0000)]
inspector/profiler/heap-snapshot-comparison-show-next.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=90722
Unreviewed, skip crashing test.
* platform/mac/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122049
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zandobersek@gmail.com [Sat, 7 Jul 2012 06:36:50 +0000 (06:36 +0000)]
Unreviewed GTK gardening, adding a test expectation for
a crashing test introduced in r122035.
* platform/gtk/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122048
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Sat, 7 Jul 2012 00:43:21 +0000 (00:43 +0000)]
WebKit Version 5.1.7 (6534.57.2, r121935): Double-click no longer works on OpenStreetMap
https://bugs.webkit.org/show_bug.cgi?id=90703
Source/JavaScriptCore:
Reviewed by Michael Saboff.
It turns out that in my object model refactoring, I managed to fix get_by_pname in all
execution engines except 64-bit baseline JIT.
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_by_pname):
LayoutTests:
Reviewed by Michael Saboff.
* fast/js/get-by-pname-expected.txt: Added.
* fast/js/get-by-pname-non-final-object-expected.txt: Added.
* fast/js/get-by-pname-non-final-object.html: Added.
* fast/js/get-by-pname.html: Added.
* fast/js/jsc-test-list:
* fast/js/script-tests/get-by-pname-non-final-object.js: Added.
(foo):
* fast/js/script-tests/get-by-pname.js: Added.
(foo):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122047
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Fri, 6 Jul 2012 23:48:39 +0000 (23:48 +0000)]
fast/canvas/webgl/gl-vertexattribpointer.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=90711
Unreviewed, skip crashing test.
* platform/mac/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122043
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Fri, 6 Jul 2012 23:38:01 +0000 (23:38 +0000)]
plugins/npruntime/leak-window-scriptable-object.html is failing
https://bugs.webkit.org/show_bug.cgi?id=90710
Unreviewed. skip failing test.
* platform/mac/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122042
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Fri, 6 Jul 2012 23:18:56 +0000 (23:18 +0000)]
iframe and global variable related inspector tests are failing
https://bugs.webkit.org/show_bug.cgi?id=90709
Unreviewed, skip failing tests.
* platform/mac/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122041
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Fri, 6 Jul 2012 23:14:52 +0000 (23:14 +0000)]
fullscreen/exit-full-screen-iframe.html is failing
https://bugs.webkit.org/show_bug.cgi?id=90708
Unreviewed, skip failing test.
* platform/mac/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122040
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Fri, 6 Jul 2012 23:09:15 +0000 (23:09 +0000)]
inspector/timeline/timeline-receive-response-event is flaky
https://bugs.webkit.org/show_bug.cgi?id=90707
Unreviewed, skip flaky test.
* platform/mac/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122039
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Fri, 6 Jul 2012 23:04:31 +0000 (23:04 +0000)]
Reproducible crash in inspector/timeline/timeline-frames.html
https://bugs.webkit.org/show_bug.cgi?id=90706
Unreviewed, skip crashng test.
* platform/mac/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122038
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 6 Jul 2012 22:44:57 +0000 (22:44 +0000)]
[Qt] Avoid deep copy of QImage in GraphicsContext3D::getImageData()
https://bugs.webkit.org/show_bug.cgi?id=90705
Patch by Lauro Neto <lauro.neto@openbossa.org> on 2012-07-06
Reviewed by Noam Rosenthal.
Use QImage.constBits() as argument to packPixels instead of bits() to avoid
deep copying it.
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::getImageData):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122037
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aestes@apple.com [Fri, 6 Jul 2012 22:13:31 +0000 (22:13 +0000)]
Fix errors reported by generate-bindings.pl after r121882.
* DerivedSources.make: Specify the correct path for notifications idl
files now that notifications/ lives in WebCore/Modules/.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122036
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 6 Jul 2012 21:40:59 +0000 (21:40 +0000)]
[BlackBerry] exitFullScreenForElement() is not working for fullscreen elements in iframes
https://bugs.webkit.org/show_bug.cgi?id=90327
Patch by Max Feil <mfeil@rim.com> on 2012-07-06
Reviewed by Antonio Gomes.
Source/WebKit/blackberry:
Fix exit fullscreen problem for elements in iframes. The
exitFullScreenForElement() call is passed a null element in
this case, instead of the original element which entered
fullscreen. If you look in Document.cpp you can see the
exitFullScreenForElement() call being made on the topDocument
(which has a null m_fullScreenElement) instead of the iframe's
document.
The Chromium and Windows ports get around this problem by
storing either the fullscreen element or its frame during
enterFullScreenForElement(), so I will bring the BlackBerry port
in line with this. See also bug 89817.
* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::enterFullScreenForElement):
(WebCore::ChromeClientBlackBerry::exitFullScreenForElement):
* WebCoreSupport/ChromeClientBlackBerry.h:
(ChromeClientBlackBerry):
LayoutTests:
Test of exit fullscreen for an iframe.
* fullscreen/exit-full-screen-iframe-expected.txt: Added.
* fullscreen/exit-full-screen-iframe.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122035
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 6 Jul 2012 20:43:20 +0000 (20:43 +0000)]
Add an API to explicitly call a JavaScript function with args.
https://bugs.webkit.org/show_bug.cgi?id=90694
Currently the Blackberry port doesn't expose the JavaScript
engine to 3rd parties so they rely upon executeJavaScript
which can be slower than necessary and unsafe as eval is used.
This new API provides a way to explicitly call a specific
JavaScript function with a list of args preventing the case
where an argument comes from a untrusted source and tries to
escape the arg list to take control of the JavaScript engine.
In the future if the Blackberry port introduces a formal
way to interact with the JavaScript engine this function should
be removed.
PR 149294
Patch by Benjamin C Meyer <bmeyer@rim.com> on 2012-07-06
Reviewed by Unreviewed
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::executeJavaScriptFunction):
(WebKit):
* Api/WebPage.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122034
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log