WebKit-https.git
7 years ago[perf-test] Add a benchmark for body.scrollTop
haraken@chromium.org [Fri, 18 May 2012 06:03:56 +0000 (06:03 +0000)]
[perf-test] Add a benchmark for body.scrollTop
https://bugs.webkit.org/show_bug.cgi?id=86806

Reviewed by Ryosuke Niwa.

Currently Bindings/dom-attributes.html is just a collection of random
DOM attributes and methods. We should remove it and instead add more
reasonable micro benchmarks by classifying DOM binding call paths.

This patch adds a benchmark for body.scrollTop, which covers other
DOM attributes that return small integers.

(Note: Performance optimization for the benchmark will be coming soon.)

Test results in my Linux desktop:

RESULT Bindings: scroll-top= 209.410654239 runs/s
median= 211.64021164 runs/s, stdev= 4.09958741195 runs/s, min= 201.005025126 runs/s, max= 212.483399734 runs/s

RESULT Bindings: scroll-top= 195.651111157 runs/s
median= 196.319018405 runs/s, stdev= 1.77011627406 runs/s, min= 191.846522782 runs/s, max= 197.28729963 runs/s
RESULT Bindings: scroll-top= 200.004907612 runs/s
median= 201.511335013 runs/s, stdev= 3.27455403827 runs/s, min= 193.236714976 runs/s, max= 202.53164557 runs/s

RESULT Bindings: scroll-top= 209.582737512 runs/s
median= 210.803689065 runs/s, stdev= 3.16769655464 runs/s, min= 203.045685279 runs/s, max= 211.920529801 runs/s

RESULT Bindings: scroll-top= 199.924607687 runs/s
median= 201.13144338 runs/s, stdev= 3.11080503619 runs/s, min= 193.003618818 runs/s, max= 202.02020202 runs/s

* Bindings/scroll-top.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8][Refactoring] Remove V8Proxy::deletionNotHandledByInterceptor()
haraken@chromium.org [Fri, 18 May 2012 05:50:42 +0000 (05:50 +0000)]
[V8][Refactoring] Remove V8Proxy::deletionNotHandledByInterceptor()
https://bugs.webkit.org/show_bug.cgi?id=86803

Reviewed by Dimitri Glazkov.

V8Proxy::deletionNotHandledByInterceptor() is used by V8StorageCustom.cpp
only, just in order to return v8::Handle<v8::Boolean>(). In such cases,
other custom bindings are hard-coding 'return v8::Handle<v8::Boolean>()'.
Thus we can hard-code 'return v8::Handle<v8::Boolean>()' in V8StorageCustom.cpp
too, and remove V8Proxy::deletionNotHandledByInterceptor().

No tests. No change in behavior.

* bindings/v8/V8Proxy.h:
* bindings/v8/custom/V8StorageCustom.cpp:
(WebCore::storageDeleter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: speed-up markQueriableHeapObjects function.
loislo@chromium.org [Fri, 18 May 2012 05:44:42 +0000 (05:44 +0000)]
Web Inspector: speed-up markQueriableHeapObjects function.
https://bugs.webkit.org/show_bug.cgi?id=86732

Reviewed by Yury Semikhatsky.

* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype._flagsOfNode):
(WebInspector.HeapSnapshot.prototype._markDetachedDOMTreeNodes):
(WebInspector.HeapSnapshot.prototype._markQueriableHeapObjects):
(WebInspector.HeapSnapshot.prototype._calculateFlags):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSome Spelling Mistakes Result in Compile Errors with ENABLE(FILE_SYSTEM) in LocalFile...
kinuko@chromium.org [Fri, 18 May 2012 05:35:07 +0000 (05:35 +0000)]
Some Spelling Mistakes Result in Compile Errors with ENABLE(FILE_SYSTEM) in LocalFileSystem.cpp
https://bugs.webkit.org/show_bug.cgi?id=86103

Reviewed by Rob Buis.

Added build fixes and some (limited) common implementation for non-chromium ports.

No new tests as this should have no functionality changes.

* Modules/filesystem/DOMFileSystemBase.cpp:
(WebCore::DOMFileSystemBase::isValidType): Added common implementation for non-chromium ports.
(WebCore::DOMFileSystemBase::crackFileSystemURL): Ditto.
(WebCore::DOMFileSystemBase::supportsToURL): Ditto.
(WebCore::DOMFileSystemBase::createFileSystemURL): Ditto.
* Modules/filesystem/LocalFileSystem.cpp:
(WebCore::LocalFileSystem::readFileSystem): Fixed.
(WebCore::LocalFileSystem::requestFileSystem): Fixed.
* platform/blackberry/AsyncFileSystemBlackBerry.cpp:
(WebCore::AsyncFileSystem::openFileSystem): Fixed.
* platform/gtk/AsyncFileSystemGtk.cpp:
(WebCore::AsyncFileSystem::openFileSystem): Fixed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAudioBufferSourceNode and MediaElementAudioSourceNode should support multi-channel...
commit-queue@webkit.org [Fri, 18 May 2012 04:57:07 +0000 (04:57 +0000)]
AudioBufferSourceNode and MediaElementAudioSourceNode should support multi-channel > stereo
https://bugs.webkit.org/show_bug.cgi?id=75119

Patch by Wei James <james.wei@intel.com> on 2012-05-17
Reviewed by Chris Rogers.

As multiple channel support in AudioBus and other places is already
implemented, the check can be removed here.

* Modules/webaudio/MediaElementAudioSourceNode.cpp:
(WebCore::MediaElementAudioSourceNode::setFormat):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][DRT] Call resetInternalsObject() after each test.
rakuco@webkit.org [Fri, 18 May 2012 04:46:34 +0000 (04:46 +0000)]
[EFL][DRT] Call resetInternalsObject() after each test.
https://bugs.webkit.org/show_bug.cgi?id=86793

Reviewed by Antonio Gomes.

We need to reset the internals object's settings after running
each test so that there are no interferences between each test's
results.

Source/WebKit/efl:

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::globalContextRefForFrame):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

* DumpRenderTree/efl/DumpRenderTree.cpp:
(runTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, WebKit2 GTK/Qt build fix attempt after r117516.
philn@webkit.org [Fri, 18 May 2012 04:41:07 +0000 (04:41 +0000)]
Unreviewed, WebKit2 GTK/Qt build fix attempt after r117516.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didBlockInsecurePluginVersion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Move Web Workers methods to Platform.h
pilgrim@chromium.org [Fri, 18 May 2012 04:37:37 +0000 (04:37 +0000)]
[Chromium] Move Web Workers methods to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=86799

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/Platform:

* Platform.gypi:
* chromium/public/Platform.h:
(WebKit):
(Platform):
(WebKit::Platform::didStartWorkerRunLoop):
(WebKit::Platform::didStopWorkerRunLoop):
* chromium/public/WebWorkerRunLoop.h: Added.
(WebCore):
(WebKit):
(WebWorkerRunLoop):
(Task):
(WebKit::WebWorkerRunLoop::Task::~Task):
(WebKit::operator==):
(WebKit::operator<):

Source/WebKit/chromium:

* WebKit.gyp:
* public/WebWorkerRunLoop.h:
* public/platform/WebKitPlatformSupport.h:
(WebKit):
(WebKitPlatformSupport):
* src/PlatformSupport.cpp:
(WebCore::PlatformSupport::didStartWorkerRunLoop):
(WebCore::PlatformSupport::didStopWorkerRunLoop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago<rdar://problem/11419933> Problems with flipped writing modes and compositing
mitz@apple.com [Fri, 18 May 2012 04:33:59 +0000 (04:33 +0000)]
<rdar://problem/11419933> Problems with flipped writing modes and compositing
https://bugs.webkit.org/show_bug.cgi?id=86032

Reviewed by Anders Carlsson.

Source/WebCore:

Test: compositing/bounds-in-flipped-writing-mode.html

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateLayerBounds): Apply a writing-mode flip to the bounding box
if needed.

LayoutTests:

* compositing/bounds-in-flipped-writing-mode-expected.txt: Added.
* compositing/bounds-in-flipped-writing-mode.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8][Refactoring] Remove V8Proxy::throwError(const char*, v8::Isolate* = 0)
haraken@chromium.org [Fri, 18 May 2012 03:39:09 +0000 (03:39 +0000)]
[V8][Refactoring] Remove V8Proxy::throwError(const char*, v8::Isolate* = 0)
https://bugs.webkit.org/show_bug.cgi?id=86794

Reviewed by Adam Barth.

As commented here (https://bugs.webkit.org/show_bug.cgi?id=84074#c5),
I am refactoring a series of confusing throwError()s.
This patch removes V8Proxy::throwError(const char*, v8::Isolate* = 0).

No tests. No change in behavior.

* bindings/v8/V8Utilities.cpp:
(WebCore::extractTransferables):
(WebCore::getMessagePortArray):
* bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore::constructWebGLArrayWithArrayBufferArgument):
(WebCore::constructWebGLArray):
* bindings/v8/custom/V8AudioBufferSourceNodeCustom.cpp:
(WebCore::V8AudioBufferSourceNode::bufferAccessorSetter):
* bindings/v8/custom/V8ClipboardCustom.cpp:
(WebCore::V8Clipboard::setDragImageCallback):
* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::V8HTMLDocument::openCallback):
* bindings/v8/custom/V8HTMLInputElementCustom.cpp:
(WebCore::V8HTMLInputElement::selectionStartAccessorGetter):
(WebCore::V8HTMLInputElement::selectionStartAccessorSetter):
(WebCore::V8HTMLInputElement::selectionEndAccessorGetter):
(WebCore::V8HTMLInputElement::selectionEndAccessorSetter):
(WebCore::V8HTMLInputElement::selectionDirectionAccessorGetter):
(WebCore::V8HTMLInputElement::selectionDirectionAccessorSetter):
(WebCore::V8HTMLInputElement::setSelectionRangeCallback):
* bindings/v8/custom/V8HTMLMediaElementCustom.cpp:
(WebCore::V8HTMLMediaElement::controllerAccessorSetter):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::inspectedObjectCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Scale all compositor output by the defaultDeviceScaleFactor
danakj@chromium.org [Fri, 18 May 2012 03:36:12 +0000 (03:36 +0000)]
[chromium] Scale all compositor output by the defaultDeviceScaleFactor
https://bugs.webkit.org/show_bug.cgi?id=86051

Reviewed by James Robinson.

Source/Platform:

* chromium/public/WebLayerTreeView.h:
(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):

Source/WebCore:

On initialization, give the defaultDeviceScaleFactor to the compositor
to have it scale all output from WebCore's layout size to physical
pixels. This allows us to scale up to high-dpi devices without using
fixed-layout, so we can leave the WebCore frame size in layout pixels,
while drawing the frame into a larger physical pixel size.

CCLayerTreeHost becomes aware of the deviceScaleFactor and scales all
output by this factor by scaling the viewport and all drawing
transforms.

Anything that works in physical pixels (content space), uses the
deviceViewportSize() in place of the viewportSize(), since when
deviceScaleFactor != 1 in CCLayerTreeHost, the WebCore viewport
is no longer physical pixels.

Scroll positions are in layout pixels, and must be scaled to/from
content space within the compositor.

Unit tests: CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers

* platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromiumClient):
(WebCore::LayerRendererChromium::viewportSize):
(WebCore::LayerRendererChromium::viewportWidth):
(WebCore::LayerRendererChromium::viewportHeight):
(LayerRendererChromium):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::initializeLayerRenderer):
(WebCore::CCLayerTreeHost::setViewportSize):
(WebCore::CCLayerTreeHost::updateLayers):
(WebCore::CCLayerTreeHost::paintLayerContents):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCSettings::CCSettings):
(CCSettings):
(CCLayerTreeHost):
(WebCore::CCLayerTreeHost::deviceViewportSize):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::setViewportSize):
(WebCore::CCLayerTreeHostImpl::updateMaxScrollPosition):
(WebCore::CCLayerTreeHostImpl::scrollBegin):
(WebCore::CCLayerTreeHostImpl::computePinchZoomDeltas):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(WebCore::CCLayerTreeHostImpl::viewportSize):
(CCLayerTreeHostImpl):

Source/WebKit/chromium:

Add the applyDefaultDeviceScaleInCompositor setting. When enabled, we
apply the scale factor during compositing instead of applying it through
the pageScaleFactor.

NonCompositedContentHost is the GraphicLayerClient for the GraphicsLayer
containing the document's body. It needs to report the page/device scale
that should be used when scaling the contents of the GraphicsLayer, and
when changes occur to them such that its contentsSize or contentsScale
is affected.

Store the deviceScaleFactor being used in the compositor. The remainder
of the deviceScaleFactor() is being applied to the pageScale.

* public/WebSettings.h:
* src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::NonCompositedContentHost):
(WebKit::NonCompositedContentHost::setViewport):
* src/NonCompositedContentHost.h:
(NonCompositedContentHost):
* src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::Settings::operator CCSettings):
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setApplyDefaultDeviceScaleFactorInCompositor):
(WebKit):
* src/WebSettingsImpl.h:
(WebSettingsImpl):
(WebKit::WebSettingsImpl::applyDefaultDeviceScaleFactorInCompositor):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setPageScaleFactor):
(WebKit::WebViewImpl::setDeviceScaleFactor):
(WebKit::WebViewImpl::enableFixedLayoutMode):
(WebKit::WebViewImpl::computePageScaleFactorLimits):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::updateLayerTreeViewport):
* src/WebViewImpl.h:
* tests/CCLayerTreeHostTest.cpp:
(MockLayerTreeHostImpl):
(WTF::MockLayerTreeHost::createLayerTreeHostImpl):
(CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers):
(WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers):
(WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::beginTest):
(WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::afterTest):
(WTF):
(WTF::TEST_F):
* tests/LayerRendererChromiumTest.cpp:
* tests/WebFrameTest.cpp:
(WebKit::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Shadow DOM] Add an assertion to make sure a visited node is not an active insertion...
hayato@chromium.org [Fri, 18 May 2012 03:24:44 +0000 (03:24 +0000)]
[Shadow DOM] Add an assertion to make sure a visited node is not an active insertion point.
https://bugs.webkit.org/show_bug.cgi?id=86708

Reviewed by Eric Seidel.

Since InsertionPoint now has isActive() member function,
we can add an assertion to ComposedShadowTreeWalker::assertPrecondition()
using that function.

No new tests, no change in behavior.

* dom/ComposedShadowTreeWalker.h:
(WebCore::ComposedShadowTreeWalker::assertPrecondition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r117526.
pkasting@chromium.org [Fri, 18 May 2012 03:16:23 +0000 (03:16 +0000)]
Unreviewed, rolling out r117526.
http://trac.webkit.org/changeset/117526
https://bugs.webkit.org/show_bug.cgi?id=86801

broke Chromium Mac 10.5 layout test canaries (Requested by
pkasting on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-17

* Scripts/webkitpy/common/checkout/scm/scm.py:
(SCM):
(SCM.in_working_directory):
* Scripts/webkitpy/common/checkout/scm/svn.py:
(SVN):
(SVN.in_working_directory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Prune unnecessary failure expectations.
pkasting@chromium.org [Fri, 18 May 2012 03:01:54 +0000 (03:01 +0000)]
[chromium] Prune unnecessary failure expectations.
http://code.google.com/p/chromium/issues/detail?id=32670
https://bugs.webkit.org/show_bug.cgi?id=74694
https://bugs.webkit.org/show_bug.cgi?id=82129
https://bugs.webkit.org/show_bug.cgi?id=83503
https://bugs.webkit.org/show_bug.cgi?id=86439

Unreviewed, test expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Prune unnecessary failure expectations.
pkasting@chromium.org [Fri, 18 May 2012 02:45:11 +0000 (02:45 +0000)]
[chromium] Prune unnecessary failure expectations.
http://code.google.com/p/chromium/issues/detail?id=23489
http://code.google.com/p/chromium/issues/detail?id=67540
http://code.google.com/p/chromium/issues/detail?id=68436
http://code.google.com/p/chromium/issues/detail?id=77706
https://bugs.webkit.org/show_bug.cgi?id=47949
https://bugs.webkit.org/show_bug.cgi?id=65462
https://bugs.webkit.org/show_bug.cgi?id=68436
https://bugs.webkit.org/show_bug.cgi?id=73838
https://bugs.webkit.org/show_bug.cgi?id=74694
https://bugs.webkit.org/show_bug.cgi?id=83185

Unreviewed, test expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Store HTTP version in WebURLResponse
fischman@chromium.org [Fri, 18 May 2012 02:36:45 +0000 (02:36 +0000)]
[Chromium] Store HTTP version in WebURLResponse
https://bugs.webkit.org/show_bug.cgi?id=86522

Reviewed by Adam Barth.

Source/Platform:

* chromium/public/WebURLResponse.h:
(WebURLResponse):

Source/WebCore:

No new tests; this isn't exposed to the web platform.

* platform/chromium/support/WebURLResponse.cpp:
(WebKit::WebURLResponse::httpVersion):
(WebKit):
(WebKit::WebURLResponse::setHTTPVersion):
* platform/network/chromium/ResourceResponse.h:
(ResourceResponse):
(WebCore::ResourceResponse::ResourceResponse):
(WebCore::ResourceResponse::httpVersion):
(WebCore::ResourceResponse::setHTTPVersion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFloor y coordinate in Chromium's GraphicsContext::drawLineForText to avoid anti-aliasing
leviw@chromium.org [Fri, 18 May 2012 02:14:17 +0000 (02:14 +0000)]
Floor y coordinate in Chromium's GraphicsContext::drawLineForText to avoid anti-aliasing
https://bugs.webkit.org/show_bug.cgi?id=86775

Reviewed by Eric Seidel.

Despite operating in floats, we always want to draw lines for text aligned to pixel boundaries.
There are similar functions to do this in other platforms, but to get proper results, we only
need to floor the y value, as we always draw these lines horizontally.

No tests. No change in behavior prior to sub-pixel change.

* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::drawLineForText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Prune unnecessary failure expectations.
pkasting@chromium.org [Fri, 18 May 2012 02:12:45 +0000 (02:12 +0000)]
[chromium] Prune unnecessary failure expectations.
http://code.google.com/p/chromium/issues/detail?id=11251
http://code.google.com/p/chromium/issues/detail?id=69181
http://code.google.com/p/chromium/issues/detail?id=124313
http://code.google.com/p/chromium/issues/detail?id=124779
https://bugs.webkit.org/show_bug.cgi?id=80067
https://bugs.webkit.org/show_bug.cgi?id=84125
https://bugs.webkit.org/show_bug.cgi?id=85553

Unreviewed, test expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoscm.add() doesn't work properly with svn 1.7
dpranke@chromium.org [Fri, 18 May 2012 02:05:10 +0000 (02:05 +0000)]
scm.add() doesn't work properly with svn 1.7
https://bugs.webkit.org/show_bug.cgi?id=86779

Reviewed by Ojan Vafai.

The code relied on '.svn' directories being present
in order to tell if a directory had already been added to the
repository; this is no longer true in SVN 1.7.

* Scripts/webkitpy/common/checkout/scm/scm.py:
(SCM):
(SCM.in_working_directory):
* Scripts/webkitpy/common/checkout/scm/svn.py:
(SVN):
(SVN.in_working_directory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Fix bad baseline from http://trac.webkit.org/changeset/117480/.
pkasting@chromium.org [Fri, 18 May 2012 01:46:16 +0000 (01:46 +0000)]
[chromium] Fix bad baseline from trac.webkit.org/changeset/117480/.
https://bugs.webkit.org/show_bug.cgi?id=84167

Unreviewed, test expectations update.

* platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLinux amd64 platform reported as i686
commit-queue@webkit.org [Fri, 18 May 2012 01:40:56 +0000 (01:40 +0000)]
Linux amd64 platform reported as i686
https://bugs.webkit.org/show_bug.cgi?id=86778
http://code.google.com/p/chromium/issues/detail?id=128167

Remove the old hard-coded gyp define and allow the more recent (but
still quite old) code in Source/WebCore/page/NavigatorBase.cpp to take
precedence and detect this at runtime.

Patch by Michael Moss <mmoss@chromium.org> on 2012-05-17
Reviewed by Tony Chang.

No new tests because it's hardware dependent.

* WebCore.gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSetting array index -1 and looping over array causes bad behavior
fpizlo@apple.com [Fri, 18 May 2012 01:34:01 +0000 (01:34 +0000)]
Setting array index -1 and looping over array causes bad behavior
https://bugs.webkit.org/show_bug.cgi?id=86733
<rdar://problem/11477670>

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

* dfg/DFGOperations.cpp:

LayoutTests:

* fast/js/dfg-negative-array-index-expected.txt: Added.
* fast/js/dfg-negative-array-index.html: Added.
* fast/js/script-tests/dfg-negative-array-index.js: Added.
(foo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] More rebaselines/expectation updates.
pkasting@chromium.org [Fri, 18 May 2012 01:28:03 +0000 (01:28 +0000)]
[chromium] More rebaselines/expectation updates.
https://bugs.webkit.org/show_bug.cgi?id=86441

Unreviewed, test expectations update.

* platform/chromium-linux/fast/borders/border-antialiasing-expected.png:
* platform/chromium-linux/fast/multicol/shadow-breaking-expected.png:
* platform/chromium-mac-leopard/fast/multicol/shadow-breaking-expected.png:
* platform/chromium-mac-snowleopard/fast/multicol/shadow-breaking-expected.png:
* platform/chromium-mac/fast/multicol/shadow-breaking-expected.png:
* platform/chromium-win/fast/multicol/shadow-breaking-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/Platform: [chromium] Expose layer tiling size options to WebSettings
vangelis@chromium.org [Fri, 18 May 2012 01:20:41 +0000 (01:20 +0000)]
Source/Platform: [chromium] Expose layer tiling size options to WebSettings
https://bugs.webkit.org/show_bug.cgi?id=86425

Adding entries for tile size and max untiled layer size.

Reviewed by Adrienne Walker.

* chromium/public/WebLayerTreeView.h:
(WebKit):
(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):

Source/WebCore: [chromium] Expose layer tiling size options to WebSettings.
https://bugs.webkit.org/show_bug.cgi?id=86425

Removing hardcoded tile size and max untiled layer size from TiledLayerChromium
and instead have the values passed in via the LTH CCSettings. This will allow
different compositor instances to adjust tiling parameters as needed and makes
it possible to set the values via command line arguments.

Reviewed by Adrienne Walker.

* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::TiledLayerChromium):
(WebCore::TiledLayerChromium::updateTileSizeAndTilingOption):
Made some additional adjustments to the single-tile heuristic
to make it work better with arbitrary sizes while still avoiding
to create unreasonably large layers.
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::initializeLayerRenderer):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCSettings::CCSettings):
(CCSettings):

Source/WebKit/chromium: Expose layer tiling size options to WebSettings.
https://bugs.webkit.org/show_bug.cgi?id=86425

This will allow tiling parameters to be set via command line flags
passed to the Renderer.

Reviewed by Adrienne Walker.

* public/WebSettings.h:
* src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::Settings::operator CCSettings):
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setDefaultTileSize):
(WebKit):
(WebKit::WebSettingsImpl::setMaxUntiledLayerSize):
* src/WebSettingsImpl.h:
(WebSettingsImpl):
(WebKit::WebSettingsImpl::defaultTileSize):
(WebKit::WebSettingsImpl::maxUntiledLayerSize):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Move fileUtilities to Platform.h
pilgrim@chromium.org [Fri, 18 May 2012 01:12:35 +0000 (01:12 +0000)]
[Chromium] Move fileUtilities to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=86777

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/Platform:

* Platform.gypi:
* chromium/public/Platform.h:
(WebKit):
(Platform):
(WebKit::Platform::fileUtilities):
* chromium/public/WebFileUtilities.h: Added.
(WebKit):
(WebFileUtilities):
(WebKit::WebFileUtilities::revealFolderInOS):
(WebKit::WebFileUtilities::fileExists):
(WebKit::WebFileUtilities::deleteFile):
(WebKit::WebFileUtilities::deleteEmptyDirectory):
(WebKit::WebFileUtilities::getFileSize):
(WebKit::WebFileUtilities::getFileModificationTime):
(WebKit::WebFileUtilities::directoryName):
(WebKit::WebFileUtilities::pathByAppendingComponent):
(WebKit::WebFileUtilities::makeAllDirectories):
(WebKit::WebFileUtilities::getAbsolutePath):
(WebKit::WebFileUtilities::isDirectory):
(WebKit::WebFileUtilities::filePathToURL):
(WebKit::WebFileUtilities::openFile):
(WebKit::WebFileUtilities::closeFile):
(WebKit::WebFileUtilities::seekFile):
(WebKit::WebFileUtilities::truncateFile):
(WebKit::WebFileUtilities::readFromFile):
(WebKit::WebFileUtilities::writeToFile):
(WebKit::WebFileUtilities::~WebFileUtilities):

Source/WebKit/chromium:

* WebKit.gyp:
* public/WebFileUtilities.h:
* public/platform/WebKitPlatformSupport.h:
(WebKit):
(WebKitPlatformSupport):
* src/PlatformSupport.cpp:
(WebCore::PlatformSupport::fileExists):
(WebCore::PlatformSupport::deleteFile):
(WebCore::PlatformSupport::deleteEmptyDirectory):
(WebCore::PlatformSupport::getFileSize):
(WebCore::PlatformSupport::revealFolderInOS):
(WebCore::PlatformSupport::getFileModificationTime):
(WebCore::PlatformSupport::directoryName):
(WebCore::PlatformSupport::pathByAppendingComponent):
(WebCore::PlatformSupport::makeAllDirectories):
(WebCore::PlatformSupport::getAbsolutePath):
(WebCore::PlatformSupport::isDirectory):
(WebCore::PlatformSupport::filePathToURL):
(WebCore::PlatformSupport::openFile):
(WebCore::PlatformSupport::closeFile):
(WebCore::PlatformSupport::seekFile):
(WebCore::PlatformSupport::truncateFile):
(WebCore::PlatformSupport::readFromFile):
(WebCore::PlatformSupport::writeToFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNot reviewed.
ggaren@apple.com [Fri, 18 May 2012 00:55:43 +0000 (00:55 +0000)]
Not reviewed.

Rolled out r117495 because it caused som out of memory crashes.

* heap/Heap.cpp:
(JSC::Heap::collect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRefactored the Heap to move more MarkedSpace logic into MarkedSpace
ggaren@apple.com [Fri, 18 May 2012 00:40:30 +0000 (00:40 +0000)]
Refactored the Heap to move more MarkedSpace logic into MarkedSpace
https://bugs.webkit.org/show_bug.cgi?id=86790

Reviewed by Gavin Barraclough.

* heap/Heap.cpp:
(JSC::Heap::lastChanceToFinalize):
(JSC::Heap::markRoots):
(JSC):
(JSC::Heap::objectCount):
(JSC::Heap::size):
(JSC::Heap::capacity):
(JSC::Heap::collect):
* heap/Heap.h:
(Heap): Took all the functors from here...

* heap/MarkedBlock.h:
(CountFunctor):
(JSC::MarkedBlock::CountFunctor::CountFunctor):
(JSC::MarkedBlock::CountFunctor::count):
(JSC::MarkedBlock::CountFunctor::returnValue):
(MarkedBlock):
* heap/MarkedSpace.h:
(JSC::ClearMarks::operator()):
(JSC):
(JSC::Sweep::operator()):
(JSC::MarkCount::operator()):
(JSC::Size::operator()):
(JSC::Capacity::operator()):
(MarkedSpace):
(JSC::MarkedSpace::clearMarks):
(JSC::MarkedSpace::sweep):
(JSC::MarkedSpace::objectCount):
(JSC::MarkedSpace::size):
(JSC::MarkedSpace::capacity): and put them here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPlug-ins blacklist mechanism can tell clients about plug-in with null identifier
andersca@apple.com [Fri, 18 May 2012 00:12:48 +0000 (00:12 +0000)]
Plug-ins blacklist mechanism can tell clients about plug-in with null identifier
https://bugs.webkit.org/show_bug.cgi?id=86788
<rdar://problem/11479503>

Reviewed by John Sullivan.

Pass along the URL string of the blocked plug-in so we can find the plug-in even if there was no
MIME type specified in the <embed> or <object> tag.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didBlockInsecurePluginVersion):
* UIProcess/WebPageProxy.h:
(WebPageProxy):
* UIProcess/WebPageProxy.messages.in:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMemory leak in NetworkInfoClient
commit-queue@webkit.org [Thu, 17 May 2012 23:35:41 +0000 (23:35 +0000)]
Memory leak in NetworkInfoClient
https://bugs.webkit.org/show_bug.cgi?id=86603

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-17
Reviewed by Adam Barth.

Source/WebCore:

Fix a memory leak in NetworkInfoClient by using OwnPtr and
change the class not to inherite from RefCounted.

* Modules/networkinfo/NetworkInfoClient.h:

Source/WebKit/efl:

Fix a memory leak in NetworkInfoClient by using OwnPtr and making
the client to be owned by the View.

* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttps://bugs.webkit.org/show_bug.cgi?id=86786
beidson@apple.com [Thu, 17 May 2012 23:25:51 +0000 (23:25 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=86786
Two mathml/presentation tests fail on Mac

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttps://bugs.webkit.org/show_bug.cgi?id=86785
beidson@apple.com [Thu, 17 May 2012 23:25:46 +0000 (23:25 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=86785
Two fast/repaint tests fail on mac lion

* platform/mac-lion/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Remove IDBIndex.storeName
jsbell@chromium.org [Thu, 17 May 2012 23:20:26 +0000 (23:20 +0000)]
IndexedDB: Remove IDBIndex.storeName
https://bugs.webkit.org/show_bug.cgi?id=86676

Reviewed by Tony Chang.

Source/WebCore:

Older versions of the IDB spec exposed IDBIndex.storeName. While it's been removed
from the IDL, the additional storage/plumbing are unnecessary clutter. Nuke it!

No new tests - no functional changes.

* Modules/indexeddb/IDBIndexBackendImpl.cpp:
(WebCore::IDBIndexBackendImpl::IDBIndexBackendImpl): Remove storeName parameter, and
const declaration on object store param. The former was used to get a non-const pointer
via indirection in openCursorInternal.
(WebCore::IDBIndexBackendImpl::openCursorInternal): Use store pointer directly, don't
look it up by name in the transaction.
* Modules/indexeddb/IDBIndexBackendImpl.h:
(WebCore::IDBIndexBackendImpl::create): Remove storeName parameters.
(IDBIndexBackendImpl): Remove storeName() method.
* Modules/indexeddb/IDBIndexBackendInterface.h:
(IDBIndexBackendInterface): Remove storeName parameter.
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::createIndex): Remove storeName parameter.
(WebCore::IDBObjectStoreBackendImpl::loadIndexes): Remove storeName parameter.

Source/WebKit/chromium:

* public/WebIDBIndex.h:
(WebIDBIndex): Can't remove from here until Chromium is updated
* src/IDBIndexBackendProxy.cpp: Removed storeName()
* src/IDBIndexBackendProxy.h: Removed storeName()
(IDBIndexBackendProxy):
* src/WebIDBIndexImpl.cpp: Removed storeName()
* src/WebIDBIndexImpl.h: Removed storeName()
(WebIDBIndexImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] www.thestar.com/iphone Viewport Weirdness
zhajiang@rim.com [Thu, 17 May 2012 23:19:04 +0000 (23:19 +0000)]
[BlackBerry] thestar.com/iphone Viewport Weirdness
https://bugs.webkit.org/show_bug.cgi?id=86756

Reviewed by George Staikos.

PR 156710
On high DPI devices, the virtual viewport size of this page was smaller
than screen size. During the refreshing of the page, we reset the scale
when the state was Committed, then layouted and rendered contents based
on the virtual viewport size and default scale 1, which caused a small
size thumbnail before we restored the previous view state.
Fixed it by keeping the previous scale, user scalable and
m_userViewportArguments during the Committed state of refreshing.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setLoadState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDon't let -[CALayer renderInContext:] try to render WebView's root layer
aestes@apple.com [Thu, 17 May 2012 23:11:20 +0000 (23:11 +0000)]
Don't let -[CALayer renderInContext:] try to render WebView's root layer
https://bugs.webkit.org/show_bug.cgi?id=86773
<rdar://problem/10950075>

Reviewed by Dan Bernstein.

-[CALayer renderInContext:] doesn't correctly render our layer tree, so
don't let it try. Calling drawRect: with a bitmap context will already
do the right thing for WebViews.

* WebView/WebHTMLView.mm: Create a subclass of CALayer called WebLayerHostingLayer.
(-[WebLayerHostingLayer renderInContext:]): override renderInContext: to be a NOOP.
(-[WebHTMLView attachRootLayer:]): Create a WebLayerHostingLayer rather than a CALayer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Implement IDBObjectStore.autoIncrement
jsbell@chromium.org [Thu, 17 May 2012 23:03:05 +0000 (23:03 +0000)]
IndexedDB: Implement IDBObjectStore.autoIncrement
https://bugs.webkit.org/show_bug.cgi?id=86662

Reviewed by Dimitri Glazkov.

Source/WebCore:

Simple boolean accessor defined in the IDB spec, which reflects the
object store's internal autoIncrement flag.

Test: storage/indexeddb/objectstore-basics.html

* Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::autoIncrement): Forward call to back end.
(WebCore):
* Modules/indexeddb/IDBObjectStore.h: Expose attribute as method.
(IDBObjectStore):
* Modules/indexeddb/IDBObjectStore.idl: Define the attribute.
* Modules/indexeddb/IDBObjectStoreBackendInterface.h: Expose in interface.
(IDBObjectStoreBackendInterface):

Source/WebKit/chromium:

* src/IDBObjectStoreBackendProxy.cpp:
(WebKit::IDBObjectStoreBackendProxy::autoIncrement):
(WebKit):
* src/IDBObjectStoreBackendProxy.h:
(IDBObjectStoreBackendProxy):
* src/WebIDBObjectStoreImpl.cpp:
(WebKit::WebIDBObjectStoreImpl::autoIncrement):
(WebKit):
* src/WebIDBObjectStoreImpl.h:
(WebIDBObjectStoreImpl):

LayoutTests:

* storage/indexeddb/objectstore-basics-expected.txt:
* storage/indexeddb/objectstore-basics-workers-expected.txt:
* storage/indexeddb/resources/objectstore-basics.js:
(setVersionSuccess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate Apple buildbots to prioritize latest changelists
jonlee@apple.com [Thu, 17 May 2012 22:44:30 +0000 (22:44 +0000)]
Update Apple buildbots to prioritize latest changelists
https://bugs.webkit.org/show_bug.cgi?id=86766

Reviewed by Brady Eidson.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(pickLatestBuild): Function to get the most pick the most recent build request.
(loadBuilderConfig): Configure builders in the AppleMac and AppleWin categories to
use the pickLatestBuild function when choosing which request to build next.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8][Refactoring] Remove throwError("message", XXXError) from CodeGeneratorV8.pm
haraken@chromium.org [Thu, 17 May 2012 22:35:07 +0000 (22:35 +0000)]
[V8][Refactoring] Remove throwError("message", XXXError) from CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=86744

Reviewed by Adam Barth.

As commented in https://bugs.webkit.org/show_bug.cgi?id=84074#c5,
I am refactoring a series of confusing throwError()s.

This patch removes throwError("message", XXXError) in CodeGeneratorV8.pm
and replaces it with throwTypeError("message") or throwError(XXXError, "message").

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateParametersCheck):
(GenerateConstructorCallback):
(GenerateEventConstructorCallback):
(GenerateNamedConstructorCallback):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::constructorCallback):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::constructorCallback):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructorConstructorCallback):
* bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::constructorCallback):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::optionsObjectCallback):
(WebCore::V8TestObj::constructorCallback):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::TestSerializedScriptValueInterfaceV8Internal::acceptTransferListCallback):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::multiTransferListCallback):
(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd more descriptive warnings for framebuffer incomplete conditions
commit-queue@webkit.org [Thu, 17 May 2012 22:27:48 +0000 (22:27 +0000)]
Add more descriptive warnings for framebuffer incomplete conditions
https://bugs.webkit.org/show_bug.cgi?id=86774

Patch by Gregg Tavares <gman@google.com> on 2012-05-17
Reviewed by Kenneth Russell.

No new tests as there is no new functionality

* html/canvas/WebGLFramebuffer.cpp:
(WebCore::WebGLFramebuffer::checkStatus):
(WebCore::WebGLFramebuffer::onAccess):
(WebCore::WebGLFramebuffer::initializeRenderbuffers):
* html/canvas/WebGLFramebuffer.h:
(WebGLFramebuffer):
* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::checkFramebufferStatus):
(WebCore::WebGLRenderingContext::clear):
(WebCore::WebGLRenderingContext::copyTexImage2D):
(WebCore::WebGLRenderingContext::copyTexSubImage2D):
(WebCore::WebGLRenderingContext::drawArrays):
(WebCore::WebGLRenderingContext::drawElements):
(WebCore::WebGLRenderingContext::readPixels):
(WebCore::WebGLRenderingContext::printGLWarningToConsole):
* html/canvas/WebGLRenderingContext.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Rebaseline.
pkasting@chromium.org [Thu, 17 May 2012 22:26:59 +0000 (22:26 +0000)]
[chromium] Rebaseline.
https://bugs.webkit.org/show_bug.cgi?id=86441

Unreviewed, test expecations update.

* platform/chromium-mac-leopard/css3/unicode-bidi-isolate-basic-expected.png:
* platform/chromium-mac-leopard/fast/multicol/column-count-with-rules-expected.png:
* platform/chromium-mac-leopard/fast/multicol/column-rules-expected.png:
* platform/chromium-mac-leopard/fast/multicol/layers-in-multicol-expected.png:
* platform/chromium-mac-leopard/fast/multicol/overflow-unsplittable-expected.png:
* platform/chromium-mac-leopard/fast/multicol/positioned-with-constrained-height-expected.png:
* platform/chromium-mac-leopard/fast/multicol/positive-leading-expected.png:
* platform/chromium-mac-snowleopard/css3/unicode-bidi-isolate-basic-expected.png:
* platform/chromium-mac-snowleopard/fast/multicol/column-count-with-rules-expected.png:
* platform/chromium-mac-snowleopard/fast/multicol/column-rules-expected.png:
* platform/chromium-mac-snowleopard/fast/multicol/layers-in-multicol-expected.png:
* platform/chromium-mac-snowleopard/fast/multicol/overflow-unsplittable-expected.png:
* platform/chromium-mac-snowleopard/fast/multicol/positioned-with-constrained-height-expected.png:
* platform/chromium-mac-snowleopard/fast/multicol/positive-leading-expected.png:
* platform/chromium-mac/css3/unicode-bidi-isolate-basic-expected.png:
* platform/chromium-mac/fast/multicol/column-count-with-rules-expected.png:
* platform/chromium-mac/fast/multicol/column-rules-expected.png:
* platform/chromium-mac/fast/multicol/layers-in-multicol-expected.png:
* platform/chromium-mac/fast/multicol/overflow-unsplittable-expected.png:
* platform/chromium-mac/fast/multicol/positioned-with-constrained-height-expected.png:
* platform/chromium-mac/fast/multicol/positive-leading-expected.png:
* platform/chromium-mac/fast/multicol/vertical-lr/column-count-with-rules-expected.png: Added.
* platform/chromium-mac/fast/multicol/vertical-lr/column-rules-expected.png:
* platform/chromium-mac/fast/multicol/vertical-rl/column-count-with-rules-expected.png: Added.
* platform/chromium-mac/fast/multicol/vertical-rl/column-rules-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEndeavour to make the windows test bot actually able to run tests.
oliver@apple.com [Thu, 17 May 2012 22:09:29 +0000 (22:09 +0000)]
Endeavour to make the windows test bot actually able to run tests.
https://bugs.webkit.org/show_bug.cgi?id=86772

Reviewed by Sam Weinig.

Source/WebCore:

Use WEBKIT_EXPORT to get correct export behaviour on windows, rather than
relying on the .def files.

* bindings/js/JSDOMGlobalObject.h:
(JSDOMGlobalObject):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):

Source/WebKit2:

Remove the ClassInfo exports from the .def files as we're now using
WEBKIT_EXPORT declarations to get expected behaviour on windows.

* win/WebKit2.def:
* win/WebKit2CFLite.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[perf-test] Add a micro benchmark for div.firstChild getter for an undefined firstChild
haraken@chromium.org [Thu, 17 May 2012 22:04:49 +0000 (22:04 +0000)]
[perf-test] Add a micro benchmark for div.firstChild getter for an undefined firstChild
https://bugs.webkit.org/show_bug.cgi?id=86725

Reviewed by Ryosuke Niwa.

We are going to remove Bindings/dom-attributes.html and instead add more
reasonable micro benchmarks by classifying DOM binding call paths.

In this bug, we add a micro benchmark for div.firstChild getter for an
undefined firstChild. This benchmark covers other undefined DOM attributes
that return a null.

(Note: In V8, div.firstChild for an undefined firstChild is currently slower
than div.firstChild for a defined firstChild.)

Test results in my Linux desktop:

RESULT Bindings: undefined-first-child= 541.408311042 runs/s
median= 541.205412054 runs/s, stdev= 1.29841219187 runs/s, min= 537.897310513 runs/s, max= 543.209876543 runs/s

RESULT Bindings: undefined-first-child= 541.00750695 runs/s
median= 540.540540541 runs/s, stdev= 0.967521230965 runs/s, min= 539.215686275 runs/s, max= 543.209876543 runs/s

RESULT Bindings: undefined-first-child= 523.630714897 runs/s
median= 523.560209424 runs/s, stdev= 1.01570919645 runs/s, min= 522.193211488 runs/s, max= 525.624178712 runs/s

RESULT Bindings: undefined-first-child= 553.077663588 runs/s
median= 553.459119497 runs/s, stdev= 0.805697397863 runs/s, min= 551.378446115 runs/s, max= 554.156171285 runs/s

RESULT Bindings: undefined-first-child= 541.5401432 runs/s
median= 541.538666618 runs/s, stdev= 0.954301364767 runs/s, min= 539.877300613 runs/s, max= 543.209876543 runs/s

* Bindings/undefined-first-child.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttps://bugs.webkit.org/show_bug.cgi?id=86266
bdakin@apple.com [Thu, 17 May 2012 21:59:05 +0000 (21:59 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=86266
r112643/r116697 break Webview form input fields
-and corresponding-
<rdar://problem/11400430>

Reviewed by Dan Bernstein.

There is a recent history of changes in this are that seem worth documenting.
First was the change to switch to using NSTextFieldCell to draw text fields:
http://trac.webkit.org/changeset/104240

That led to problems because of the clear background that I thought at the time
were specific to MountainLion. To fix that, I made this change:
http://trac.webkit.org/changeset/110480

But that change resulted in styled text fields getting an un-themed border, which
led to this change on the branch: http://trac.webkit.org/changeset/112643 and a
change on TOT that was identical for Lion and SnowLeopard but introduced new
behavior for MountainLion: http://trac.webkit.org/changeset/116697

And that brings us to this bug, where it turns out the clear background is a
problem on Lion and SnowLeopard too. This patch fixes the bug by using the
original WebCoreSystemInterface function to paint all text fields on Lion and
SnowLeopard that are styled. This is what we used to paint all text fields before
r104240, which is the first change listed above. Un-styled text fields will still
use NSTextFieldCell on these platforms, but with a hardcoded white background.
* rendering/RenderThemeMac.h:
(RenderThemeMac):
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintTextField):
(WebCore::RenderThemeMac::textField):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIconDatabase: Move icon retain/release off of the main thread.
kling@webkit.org [Thu, 17 May 2012 21:49:43 +0000 (21:49 +0000)]
IconDatabase: Move icon retain/release off of the main thread.
<http://webkit.org/b/85799>
<rdar://problem/9507113>

Reviewed by Brady Eidson.

Batch up the retain/release operations and execute them as part of the sync thread loop.
The batch execution is guarded by a new mutex (m_urlsToRetainOrReleaseLock.)
This avoids blocking the main thread on m_urlAndIconLock for basic retain/release.

There is one exception; if there are pending retain/release operations in synchronousIconForPageURL,
it will acquire the lock and flush the operations.

There should be no behavior change, this is only meant to reduce lock contention.

* loader/icon/PageURLRecord.h:
(WebCore::PageURLRecord::retain):
(WebCore::PageURLRecord::release):

    Added a 'count' argument to these so we can batch up the operations in IconDatabase.

* loader/icon/IconDatabase.h:
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::performScheduleOrDeferSyncTimer):
(WebCore::IconDatabase::performScheduleOrDeferSyncTimerOnMainThread):
(WebCore::IconDatabase::scheduleOrDeferSyncTimer):

    Perform the the timer scheduling on the main thread as it can be done on a different
    thread by way of retainIconForPageURL or releaseIconForPageURL.

(WebCore::IconDatabase::synchronousIconForPageURL):
(WebCore::IconDatabase::retainIconForPageURL):
(WebCore::IconDatabase::performRetainIconForPageURL):
(WebCore::IconDatabase::releaseIconForPageURL):
(WebCore::IconDatabase::performReleaseIconForPageURL):
(WebCore::IconDatabase::retainedPageURLCount):
(WebCore::IconDatabase::IconDatabase):
(WebCore::IconDatabase::performURLImport):
(WebCore::IconDatabase::syncThreadMainLoop):
(WebCore::IconDatabase::performPendingRetainAndReleaseOperations):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoKill RenderLayer::relativePositionOffset(LayoutUnit& relX, LayoutUnit& relY) and...
jchaffraix@webkit.org [Thu, 17 May 2012 21:31:10 +0000 (21:31 +0000)]
Kill RenderLayer::relativePositionOffset(LayoutUnit& relX, LayoutUnit& relY) and cleanup RenderInline::clippedOverflowRectForRepaint
https://bugs.webkit.org/show_bug.cgi?id=86551

Reviewed by Abhishek Arya.

No test since there is no expected change in behavior.

* rendering/RenderInline.cpp:
(WebCore::RenderInline::clippedOverflowRectForRepaint):
Changed the function to use LayoutRect arithmetics instead of calculating
top / left manually. While at it, improved the naming, removed some local
variables and removed an unneeded style() NULL-check.

* rendering/RenderLayer.h: Removed the function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIncrease the GC allocation trigger
ggaren@apple.com [Thu, 17 May 2012 21:23:22 +0000 (21:23 +0000)]
Increase the GC allocation trigger
https://bugs.webkit.org/show_bug.cgi?id=86699

Reviewed by Sam Weinig.

This helps a lot when the heap is growing, and helps to resolve
the regression caused by r116484.

* heap/Heap.cpp:
(JSC::Heap::collect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake the docked Web Inspector use autoresizing masks so the view doesn't jitter when
timothy@apple.com [Thu, 17 May 2012 21:21:26 +0000 (21:21 +0000)]
Make the docked Web Inspector use autoresizing masks so the view doesn't jitter when
resizing the window.

https://webkit.org/b/86765

Reviewed by John Sullivan.

* UIProcess/mac/WebInspectorProxyMac.mm:
(-[WKWebInspectorProxyObjCAdapter close]): Added. Zero out _inspectorProxy.
(-[WKWebInspectorProxyObjCAdapter inspectedViewFrameDidChange:]): Preform the work on a delay to
prevent interfering with Cocoa's resizing.
(WebKit::WebInspectorProxy::createInspectorWindow): Added setAutoresizingMask: call.
(WebKit::WebInspectorProxy::platformCreateInspectorPage): Removed setAutoresizingMask: call.
createInspectorWindow and platformAttach do this now.
(WebKit::WebInspectorProxy::platformDidClose): Call close on WKWebInspectorProxyObjCAdapter.
(WebKit::WebInspectorProxy::platformAttach): Added setAutoresizingMask: call.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Fix linking errors
rwlbuis@webkit.org [Thu, 17 May 2012 21:17:36 +0000 (21:17 +0000)]
[BlackBerry] Fix linking errors
https://bugs.webkit.org/show_bug.cgi?id=86768

Reviewed by Antonio Gomes.

Add some missing stubs so we can link again.

* platform/blackberry/ContextMenuBlackBerry.cpp:
(WebCore::ContextMenu::itemCount):
(WebCore):
* platform/blackberry/PlatformScreenBlackBerry.cpp:
(WebCore::screenHorizontalDPI):
(WebCore):
(WebCore::screenVerticalDPI):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Gardening, update test number tracking media-continues-playing-after-replace...
rakuco@webkit.org [Thu, 17 May 2012 21:06:53 +0000 (21:06 +0000)]
[EFL] Gardening, update test number tracking media-continues-playing-after-replace-source.html

* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Remove passing tests, re-number some still-present issues.
pkasting@chromium.org [Thu, 17 May 2012 21:05:03 +0000 (21:05 +0000)]
[chromium] Remove passing tests, re-number some still-present issues.
https://bugs.webkit.org/show_bug.cgi?id=86441
https://bugs.webkit.org/show_bug.cgi?id=86701
https://bugs.webkit.org/show_bug.cgi?id=86712

Unreviewed, test expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix rounding in paintSelection
eae@chromium.org [Thu, 17 May 2012 20:57:38 +0000 (20:57 +0000)]
Fix rounding in paintSelection
https://bugs.webkit.org/show_bug.cgi?id=86693

Reviewed by Eric Seidel.

Break out rounding logic from InlineTextBox::paintSelection into separate
function and use it for all the EllipsisBox paintSelection implementation
and selection gap calculation. This ensures that selections are painted
without gaps and overlaps once we turn on subpixel layout.

No new tests, covered by existing tests in editing/selection and
editing/style.

* rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::paintSelection):
* rendering/InlineTextBox.cpp:
(WebCore::alignSelectionRectToDevicePixels):
(WebCore):
(WebCore::InlineTextBox::paintSelection):
* rendering/InlineTextBox.h:
(WebCore):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::logicalLeftSelectionGap):
(WebCore::RenderBlock::logicalRightSelectionGap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Gardening, update expectations after r117426.
rakuco@webkit.org [Thu, 17 May 2012 20:55:31 +0000 (20:55 +0000)]
[EFL] Gardening, update expectations after r117426.

* platform/efl/editing/unsupported-content/list-type-before-expected.txt:
* platform/efl/editing/unsupported-content/table-type-after-expected.txt:
* platform/efl/editing/unsupported-content/table-type-before-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline Chromium results after r117477
robert@webkit.org [Thu, 17 May 2012 20:46:14 +0000 (20:46 +0000)]
Rebaseline Chromium results after r117477

Unreviewed gardening.

* platform/chromium-linux/css2.1/20110323/table-height-algorithm-023-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/table-height-algorithm-023-expected.png.
* platform/chromium-linux/css2.1/20110323/table-height-algorithm-024-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/table-height-algorithm-024-expected.png.
* platform/chromium-linux/fast/table/mozilla-bug10296-vertical-align-1-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/table/mozilla-bug10296-vertical-align-1-expected.png.
* platform/chromium-linux/fast/table/mozilla-bug10296-vertical-align-2-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/table/mozilla-bug10296-vertical-align-2-expected.png.
* platform/chromium-mac-leopard/css2.1/20110323/table-height-algorithm-023-expected.png: Added.
* platform/chromium-mac-leopard/css2.1/20110323/table-height-algorithm-024-expected.png: Added.
* platform/chromium-mac-leopard/fast/table/mozilla-bug10296-vertical-align-1-expected.png: Added.
* platform/chromium-mac-leopard/fast/table/mozilla-bug10296-vertical-align-2-expected.png: Added.
* platform/chromium-mac-snowleopard/css2.1/20110323/table-height-algorithm-023-expected.png: Added.
* platform/chromium-mac-snowleopard/css2.1/20110323/table-height-algorithm-024-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/table/mozilla-bug10296-vertical-align-1-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/table/mozilla-bug10296-vertical-align-2-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug10296-1-expected.txt: Added.
* platform/chromium-mac/css2.1/20110323/table-height-algorithm-023-expected.png: Added.
* platform/chromium-mac/css2.1/20110323/table-height-algorithm-023-expected.txt: Added.
* platform/chromium-mac/css2.1/20110323/table-height-algorithm-024-expected.png: Added.
* platform/chromium-mac/css2.1/20110323/table-height-algorithm-024-expected.txt: Added.
* platform/chromium-mac/fast/table/mozilla-bug10296-vertical-align-1-expected.png: Added.
* platform/chromium-mac/fast/table/mozilla-bug10296-vertical-align-1-expected.txt: Added.
* platform/chromium-mac/fast/table/mozilla-bug10296-vertical-align-2-expected.png: Added.
* platform/chromium-mac/fast/table/mozilla-bug10296-vertical-align-2-expected.txt: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug10296-1-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug10296-1-expected.txt: Added.
* platform/chromium-win/css2.1/20110323/table-height-algorithm-023-expected.png: Added.
* platform/chromium-win/css2.1/20110323/table-height-algorithm-023-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/table-height-algorithm-023-expected.txt.
* platform/chromium-win/css2.1/20110323/table-height-algorithm-024-expected.png: Added.
* platform/chromium-win/css2.1/20110323/table-height-algorithm-024-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/table-height-algorithm-024-expected.txt.
* platform/chromium-win/fast/table/mozilla-bug10296-vertical-align-1-expected.png: Added.
* platform/chromium-win/fast/table/mozilla-bug10296-vertical-align-1-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/table/mozilla-bug10296-vertical-align-1-expected.txt.
* platform/chromium-win/fast/table/mozilla-bug10296-vertical-align-2-expected.png: Added.
* platform/chromium-win/fast/table/mozilla-bug10296-vertical-align-2-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/table/mozilla-bug10296-vertical-align-2-expected.txt.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Gtk] fast/dom/gc-10.html behaves badly
zandobersek@gmail.com [Thu, 17 May 2012 20:30:51 +0000 (20:30 +0000)]
[Gtk] fast/dom/gc-10.html behaves badly
https://bugs.webkit.org/show_bug.cgi?id=86771

Unreviewed, skipping fast/dom/gc-10.html as it badly affects other tests.

* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Cleanup headers in SelectionHandler.cpp
mifenton@rim.com [Thu, 17 May 2012 20:10:35 +0000 (20:10 +0000)]
[BlackBerry] Cleanup headers in SelectionHandler.cpp
https://bugs.webkit.org/show_bug.cgi?id=86760

Reviewed by Antonio Gomes.

Clean up includes in SelectionHandler.cpp.

* WebKitSupport/SelectionHandler.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline two tests on Mac and update Mac expectations after r117339
robert@webkit.org [Thu, 17 May 2012 20:08:23 +0000 (20:08 +0000)]
Rebaseline two tests on Mac and update Mac expectations after r117339

Unreviewed gardening.

* platform/mac/fast/repaint/float-overflow-expected.txt:
* platform/mac/fast/repaint/float-overflow-right-expected.txt:
* platform/mac/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Limiting render surface texture manager memory to 0 when contentsMemoryUse...
commit-queue@webkit.org [Thu, 17 May 2012 20:04:08 +0000 (20:04 +0000)]
[chromium] Limiting render surface texture manager memory to 0 when contentsMemoryUseBytes is large.
https://bugs.webkit.org/show_bug.cgi?id=86764

Patch by Michal Mocny <mmocny@google.com> on 2012-05-17
Reviewed by Adrienne Walker.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::beginDrawingFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIn vertical writing modes, pagination may split a line after a block shifts
mitz@apple.com [Thu, 17 May 2012 20:01:50 +0000 (20:01 +0000)]
In vertical writing modes, pagination may split a line after a block shifts
https://bugs.webkit.org/show_bug.cgi?id=86763

Reviewed by Sam Weinig.

Source/WebCore:

Test: fast/multicol/pageLogicalOffset-vertical.html

LayoutState::pageLogicalOffset() was returning bogus results in vertical writing modes,
because it was always using physical heights. Changed it to take a RenderBox and use its
writing mode to choose between heights and widths.

* rendering/LayoutState.cpp:
(WebCore::LayoutState::pageLogicalOffset):
(WebCore::LayoutState::addForcedColumnBreak):
* rendering/LayoutState.h:
(LayoutState):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::markForPaginationRelayoutIfNeeded):
(WebCore::RenderBlock::layoutColumns):
(WebCore::RenderBlock::applyBeforeBreak):
(WebCore::RenderBlock::applyAfterBreak):
* rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::layout):
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::layout):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows):

LayoutTests:

* fast/multicol/pageLogicalOffset-vertical-expected.html: Added.
* fast/multicol/pageLogicalOffset-vertical.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] expandSelectionToGranularity should only use VisibleSelection and not...
mifenton@rim.com [Thu, 17 May 2012 19:58:35 +0000 (19:58 +0000)]
[BlackBerry] expandSelectionToGranularity should only use VisibleSelection and not range.
https://bugs.webkit.org/show_bug.cgi?id=86759

Reviewed by Antonio Gomes.

expandSelectionToGranularity unnecesarily converted the
selection to range and back. Using the selection
directly is preferred.

* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::expandSelectionToGranularity):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove run-in handling to addChild, instead of in layout.
inferno@chromium.org [Thu, 17 May 2012 19:43:26 +0000 (19:43 +0000)]
Move run-in handling to addChild, instead of in layout.
https://bugs.webkit.org/show_bug.cgi?id=86387

Reviewed by Julien Chaffraix.

Source/WebCore:

Tests: fast/runin/insert-before-run-in.html
       fast/runin/run-in-after-run-in.html
       fast/runin/run-in-parent-add-child.html
       fast/runin/run-in-parent-block-child-add-and-intrude.html
       fast/runin/run-in-parent-block-child-add.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks): handle run-ins here
instead of layout. We do run-in handling when we see a new child with run-in display
or add a new block whose previous sibling is run-in.
(WebCore::RenderBlock::makeChildrenNonInline): if we will have block children, need
to move run-in back to its original position.
(WebCore::RenderBlock::handleSpecialChild): no longer need to handle run-ins during layout.
(WebCore::destroyRunIn): helper to destroy a block or inline run-in.
(WebCore):
(WebCore::RenderBlock::createReplacementRunIn): helper to create the new replacement run-in.
For moveRunInUnderSiblingBlockIfNeeded, it will be used to create a new inline run-in
that goes into the next sibling block. For moveRunInToOriginalPosition, it creates a new
block run-in that goes back to where it came from.
(WebCore::RenderBlock::moveRunInUnderSiblingBlockIfNeeded): almost same as previous
handleRunInChild function, but with the return type removed. Also, we don't allow
a run-in to intrude into a block that already has a run-in.
(WebCore::RenderBlock::moveRunInToOriginalPosition): moves run-in back to where it came from.
* rendering/RenderBlock.h:
(RenderBlock):
* rendering/RenderBox.cpp:
* rendering/RenderBox.h:
(RenderBox):
* rendering/RenderBoxModelObject.cpp: move all moveChild* functions from RenderBox, since
they can now be used to move children of inlines.
(WebCore::RenderBoxModelObject::moveChildTo): same.
(WebCore):
(WebCore::RenderBoxModelObject::moveChildrenTo): same.
* rendering/RenderBoxModelObject.h:
(RenderBoxModelObject):
(WebCore::RenderBoxModelObject::moveChildTo): same.
(WebCore::RenderBoxModelObject::moveAllChildrenTo): same.
(WebCore::RenderBoxModelObject::moveChildrenTo): same.

LayoutTests:

The following tests need the render tree results as they help
to show the positioning of the run-in with respect to the next
sibling block.

* fast/runin/insert-before-run-in-expected.png: Added.
* fast/runin/insert-before-run-in-expected.txt: Added.
* fast/runin/insert-before-run-in.html: Added.
* fast/runin/run-in-after-run-in-expected.png: Added.
* fast/runin/run-in-after-run-in-expected.txt: Added.
* fast/runin/run-in-after-run-in.html: Added.
* fast/runin/run-in-parent-add-child-expected.png: Added.
* fast/runin/run-in-parent-add-child-expected.txt: Added.
* fast/runin/run-in-parent-add-child.html: Added.
* fast/runin/run-in-parent-block-child-add-and-intrude-expected.png: Added.
* fast/runin/run-in-parent-block-child-add-and-intrude-expected.txt: Added.
* fast/runin/run-in-parent-block-child-add-and-intrude.html: Added.
* fast/runin/run-in-parent-block-child-add-expected.png: Added.
* fast/runin/run-in-parent-block-child-add-expected.txt: Added.
* fast/runin/run-in-parent-block-child-add.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSupport Copy ... actions for the Web Inspector remote debugging mode.
mnaganov@chromium.org [Thu, 17 May 2012 19:38:37 +0000 (19:38 +0000)]
Support Copy ... actions for the Web Inspector remote debugging mode.
https://bugs.webkit.org/show_bug.cgi?id=86621

Reviewed by Pavel Feldman.

Source/WebCore:

* English.lproj/localizedStrings.js:
* inspector/front-end/InspectorFrontendHostStub.js:
(.WebInspector.InspectorFrontendHostStub):
(.WebInspector.InspectorFrontendHostStub.prototype.documentCopy):
(.WebInspector.InspectorFrontendHostStub.prototype.copyText):
(.WebInspector.clipboardAccessDeniedMessage):
(.WebInspector.ClipboardAccessDeniedScreen):
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
(WebInspector.documentCopy):
(WebInspector.documentCopyEventFired):

Source/WebKit/chromium:

* src/js/DevTools.js:
(WebInspector.clipboardAccessDeniedMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline results after r117339
robert@webkit.org [Thu, 17 May 2012 19:36:25 +0000 (19:36 +0000)]
Rebaseline results after r117339

Unreviewed gardening.

* fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt:
* platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.txt:
* platform/chromium-mac-leopard/editing/pasteboard/innerText-inline-table-expected.png:
* platform/chromium-mac-leopard/editing/selection/inline-table-expected.png:
* platform/chromium-mac-leopard/editing/selection/table-caret-3-expected.png:
* platform/chromium-mac-leopard/fast/css-generated-content/inline-display-types-expected.png:
* platform/chromium-mac-leopard/fast/inline-block/001-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-2-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/innerText-inline-table-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/inline-table-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/table-caret-3-expected.png:
* platform/chromium-mac-snowleopard/fast/css-generated-content/inline-display-types-expected.png:
* platform/chromium-mac-snowleopard/fast/inline-block/001-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-2-expected.png:
* platform/chromium-mac/editing/pasteboard/innerText-inline-table-expected.png:
* platform/chromium-mac/editing/pasteboard/innerText-inline-table-expected.txt: Added.
* platform/chromium-mac/editing/selection/inline-table-expected.png:
* platform/chromium-mac/editing/selection/inline-table-expected.txt: Added.
* platform/chromium-mac/editing/selection/table-caret-3-expected.png:
* platform/chromium-mac/editing/selection/table-caret-3-expected.txt: Added.
* platform/chromium-mac/fast/css-generated-content/inline-display-types-expected.png:
* platform/chromium-mac/fast/css-generated-content/inline-display-types-expected.txt: Added.
* platform/chromium-mac/fast/inline-block/001-expected.png:
* platform/chromium-mac/fast/inline-block/001-expected.txt: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.txt: Added.
* platform/chromium-win-vista/fast/css-generated-content/inline-display-types-expected.png: Removed.
* platform/chromium-win-vista/fast/inline-block/001-expected.png: Removed.
* platform/chromium-win-xp/fast/css-generated-content/inline-display-types-expected.png: Removed.
* platform/chromium-win-xp/fast/inline-block/001-expected.png: Removed.
* platform/chromium-win/tables/mozilla/bugs/bug2479-2-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug2479-2-expected.txt:
* platform/chromium/test_expectations.txt:
* platform/efl/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Copied from LayoutTests/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt.
* platform/gtk/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Removed.
* platform/qt/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Gardening, unskip test after r117205.
rakuco@webkit.org [Thu, 17 May 2012 19:10:14 +0000 (19:10 +0000)]
[EFL] Gardening, unskip test after r117205.

* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoThis is not a joke: 3.7X speedup from removing a call to sleep
ggaren@apple.com [Thu, 17 May 2012 19:08:03 +0000 (19:08 +0000)]
This is not a joke: 3.7X speedup from removing a call to sleep
https://bugs.webkit.org/show_bug.cgi?id=86702

Reviewed by Eric Seidel.

The speedup was on a GC benchmark, with a custom VM caching layer
not in TOT yet.

Instruments showed most GC threads spending the majority of their
time sleeping instead of doing useful work. Removing the call to
sleep sped up the benchmark.

* wtf/TCSpinLock.h:
(TCMalloc_SlowLock): Since a spin lock is only ever held for a short
amount of time, don't sleep for a long amount of time waiting for it
to unlock -- yielding to the scheduler is sufficient.

If we find a case where someone is sitting on a spin lock for over 2ms,
we should fix the spin lock holder, not the spin lock.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCSS 2.1 failure: table-height-algorithm-023 and -024 fail
robert@webkit.org [Thu, 17 May 2012 19:07:57 +0000 (19:07 +0000)]
CSS 2.1 failure: table-height-algorithm-023 and -024 fail
https://bugs.webkit.org/show_bug.cgi?id=85405

Reviewed by Eric Seidel.

Source/WebCore:

Treat vertical-align: [length] the same as vertical-align: baseline.

Tests: css2.1/20110323/table-height-algorithm-023.htm
       css2.1/20110323/table-height-algorithm-024.htm
       fast/table/mozilla-bug10296-vertical-align-1.html
       fast/table/mozilla-bug10296-vertical-align-2.html

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layoutRows):

LayoutTests:

* css2.1/20110323/table-height-algorithm-023.htm: Added.
* css2.1/20110323/table-height-algorithm-024.htm: Added.
    Tests from the CSS test suite.
* fast/table/mozilla-bug10296-vertical-align-1.html: Added.
* fast/table/mozilla-bug10296-vertical-align-2.html: Added.
    I split out the part of bug10296-1.html that gets rebaselined here so that the new results
    are visible. I also changed the text so that the expected result is less mysterious.

* platform/chromium-linux-x86/css2.1/20110323/table-height-algorithm-023-expected.png: Added.
* platform/chromium-linux-x86/css2.1/20110323/table-height-algorithm-023-expected.txt: Added.
* platform/chromium-linux-x86/css2.1/20110323/table-height-algorithm-024-expected.png: Added.
* platform/chromium-linux-x86/css2.1/20110323/table-height-algorithm-024-expected.txt: Added.
* platform/chromium-linux-x86/fast/table/mozilla-bug10296-vertical-align-1-expected.png: Added.
* platform/chromium-linux-x86/fast/table/mozilla-bug10296-vertical-align-1-expected.txt: Added.
* platform/chromium-linux-x86/fast/table/mozilla-bug10296-vertical-align-2-expected.png: Added.
* platform/chromium-linux-x86/fast/table/mozilla-bug10296-vertical-align-2-expected.txt: Added.
* platform/chromium-win/tables/mozilla/bugs/bug10296-1-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix rounding in RenderFlowThread::paintIntoRegion
eae@chromium.org [Thu, 17 May 2012 19:04:53 +0000 (19:04 +0000)]
Fix rounding in RenderFlowThread::paintIntoRegion
https://bugs.webkit.org/show_bug.cgi?id=86695

Reviewed by Eric Seidel.

Fix rounding of offset in paintIntoRegion to ensure that we paint on
device pixel boundaries.

Covered by existing tests in fast/regions.

* platform/graphics/FractionalLayoutPoint.h:
(WebCore::roundedIntPoint):
Add roundedIntPoint(FractionalLayoutSize) function.
(WebCore):
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::paintIntoRegion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Gardening after r116339.
rakuco@webkit.org [Thu, 17 May 2012 19:04:08 +0000 (19:04 +0000)]
[EFL] Gardening after r116339.

Add platform-specific results for the tests below.

* platform/efl/fast/repaint/float-overflow-expected.txt: Added.
* platform/efl/fast/repaint/float-overflow-right-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix MiniBrowser by using correct syntax for qrc URLs
caio.oliveira@openbossa.org [Thu, 17 May 2012 18:58:40 +0000 (18:58 +0000)]
[Qt] Fix MiniBrowser by using correct syntax for qrc URLs
https://bugs.webkit.org/show_bug.cgi?id=86761

Reviewed by Alexis Menard.

* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
(BrowserWindow::updateVisualMockTouchPoints):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoParser: Avoid unnecessary ref count churn in token constructors.
kling@webkit.org [Thu, 17 May 2012 18:57:16 +0000 (18:57 +0000)]
Parser: Avoid unnecessary ref count churn in token constructors.
<http://webkit.org/b/86667>

Reviewed by Antti Koivisto.

Pass AtomicString by const reference to avoid useless ref count churn
in AtomicHTMLToken() and AtomicXMLToken().

* html/parser/HTMLToken.h:
(WebCore::AtomicHTMLToken::AtomicHTMLToken):
* xml/parser/MarkupTokenBase.h:
(WebCore::AtomicMarkupTokenBase::AtomicMarkupTokenBase):
* xml/parser/XMLToken.h:
(WebCore::AtomicXMLToken::AtomicXMLToken):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Gardening, unskip another passing test after r117426.
rakuco@webkit.org [Thu, 17 May 2012 18:50:00 +0000 (18:50 +0000)]
[EFL] Gardening, unskip another passing test after r117426.

* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake PluginInfoStore properly thread-safe.
kling@webkit.org [Thu, 17 May 2012 18:48:29 +0000 (18:48 +0000)]
Make PluginInfoStore properly thread-safe.
<http://webkit.org/b/86648>
<rdar://problem/11451178>

Reviewed by Darin Adler.

Source/WebCore:

* plugins/PluginData.h:
(WebCore::MimeClassInfo::isolatedCopy):
(WebCore::PluginInfo::isolatedCopy):

Source/WebKit2:

Deep copy the internal storage of PluginInfoStore after constructing it, as we can
be doing this from a secondary thread.

* Shared/Plugins/PluginModuleInfo.h:
(WebKit::PluginModuleInfo::isolatedCopy):
* UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::deepIsolatedCopyPluginInfoVector):
(WebKit::PluginInfoStore::loadPluginsIfNecessary):
(WebKit::PluginInfoStore::plugins):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Refactoring] Move platform-specific code in Editor::respondToChangedSelection to...
hbono@chromium.org [Thu, 17 May 2012 18:44:39 +0000 (18:44 +0000)]
[Refactoring] Move platform-specific code in Editor::respondToChangedSelection to the WebKit layer
https://bugs.webkit.org/show_bug.cgi?id=86591

Reviewed by Ryosuke Niwa.

This change adds a TextCheckerClient::shouldEraseMarkersAfterChangeSelection
function to remove platform-specific code from Editor::respondToChangedSelection
function.

No new tests, no change in behavior.

Source/WebCore:

* editing/Editor.cpp:
(WebCore::Editor::respondToChangedSelection):
* loader/EmptyClients.h:
(WebCore::EmptyTextCheckerClient::shouldEraseMarkersAfterChangeSelection):
* platform/text/TextCheckerClient.h:
(TextCheckerClient):

Source/WebKit/blackberry:

* WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::shouldEraseMarkersAfterChangeSelection):
(WebCore):
* WebCoreSupport/EditorClientBlackBerry.h:
(EditorClientBlackBerry):

Source/WebKit/chromium:

* src/EditorClientImpl.cpp:
(WebKit::EditorClientImpl::shouldEraseMarkersAfterChangeSelection):
(WebKit):
* src/EditorClientImpl.h:
(EditorClientImpl):

Source/WebKit/efl:

* WebCoreSupport/EditorClientEfl.cpp:
(WebCore::EditorClientEfl::shouldEraseMarkersAfterChangeSelection):
(WebCore):
* WebCoreSupport/EditorClientEfl.h:
(EditorClientEfl):

Source/WebKit/gtk:

* WebCoreSupport/TextCheckerClientGtk.cpp:
(WebKit::TextCheckerClientGtk::shouldEraseMarkersAfterChangeSelection):
(WebKit):
* WebCoreSupport/TextCheckerClientGtk.h:
(TextCheckerClientGtk):

Source/WebKit/mac:

* WebCoreSupport/WebEditorClient.h:
* WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::shouldEraseMarkersAfterChangeSelection):

Source/WebKit/qt:

* WebCoreSupport/TextCheckerClientQt.cpp:
(WebCore::TextCheckerClientQt::shouldEraseMarkersAfterChangeSelection):
(WebCore):
* WebCoreSupport/TextCheckerClientQt.h:
(TextCheckerClientQt):

Source/WebKit/win:

* WebCoreSupport/WebEditorClient.cpp:
(WebEditorClient::shouldEraseMarkersAfterChangeSelection):
* WebCoreSupport/WebEditorClient.h:
(WebEditorClient):

Source/WebKit/wince:

* WebCoreSupport/EditorClientWinCE.cpp:
(WebKit::EditorClientWinCE::shouldEraseMarkersAfterChangeSelection):
(WebKit):
* WebCoreSupport/EditorClientWinCE.h:
(EditorClientWinCE):

Source/WebKit/wx:

* WebKitSupport/EditorClientWx.cpp:
(WebCore::EditorClientWx::shouldEraseMarkersAfterChangeSelection):
(WebCore):
* WebKitSupport/EditorClientWx.h:
(EditorClientWx):

Source/WebKit2:

* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::shouldEraseMarkersAfterChangeSelection):
(WebKit):
* WebProcess/WebCoreSupport/WebEditorClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Convert GraphicsLayerChromium to use WebLayer types
jamesr@google.com [Thu, 17 May 2012 18:41:27 +0000 (18:41 +0000)]
[chromium] Convert GraphicsLayerChromium to use WebLayer types
https://bugs.webkit.org/show_bug.cgi?id=86269

Reviewed by Adrienne Walker.

Source/Platform:

Adds some new WebLayer / WebContentLayer APIs that WebCore::GraphicsLayerChromium needs.

* chromium/public/WebContentLayer.h:
(WebCore):
(WebKit):
(WebContentLayer):
* chromium/public/WebLayer.h:
(WebKit):
(WebKit::WebLayer::isNull):
(WebLayer):
* chromium/public/WebTransformationMatrix.h:
(WebKit::WebTransformationMatrix::~WebTransformationMatrix):
    Fix a memory leak - WebPrivateOwnPtr<>s have to be explicitly cleared.
(WebTransformationMatrix):

Source/WebCore:

This converts GraphicsLayerChromium over to use WebLayer and WebContentLayer. The conversion is not completely
as the Web*Layer APIs are not yet quite complete enough to use everywhere, and the PlatformLayer typedef is not
changed in this patch. The places where we have to punch out through API layer are marked by
unwrap<*LayerChromium>() calls and FIXME's in the Web*Layer.h files.  There aren't many.

Refactor only, existing tests apply.

* platform/chromium/support/WebTransformationMatrix.cpp:
(WebKit):
(WebKit::WebTransformationMatrix::reset):
(WebKit::WebTransformationMatrix::projectPoint):
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::willBeDestroyed):
(WebCore::GraphicsLayerChromium::setName):
(WebCore::GraphicsLayerChromium::updateNames):
(WebCore::GraphicsLayerChromium::removeFromParent):
(WebCore::GraphicsLayerChromium::setSize):
(WebCore::GraphicsLayerChromium::setTransform):
(WebCore::GraphicsLayerChromium::setBackgroundColor):
(WebCore::GraphicsLayerChromium::clearBackgroundColor):
(WebCore::GraphicsLayerChromium::setContentsOpaque):
(WebCore::GraphicsLayerChromium::setFilters):
(WebCore::GraphicsLayerChromium::setMaskLayer):
(WebCore::GraphicsLayerChromium::setBackfaceVisibility):
(WebCore::GraphicsLayerChromium::setOpacity):
(WebCore::GraphicsLayerChromium::setReplicatedByLayer):
(WebCore::GraphicsLayerChromium::setContentsNeedsDisplay):
(WebCore::GraphicsLayerChromium::setNeedsDisplay):
(WebCore::GraphicsLayerChromium::setNeedsDisplayInRect):
(WebCore::GraphicsLayerChromium::setContentsToImage):
(WebCore::GraphicsLayerChromium::setContentsToCanvas):
(WebCore::GraphicsLayerChromium::addAnimation):
(WebCore::GraphicsLayerChromium::pauseAnimation):
(WebCore::GraphicsLayerChromium::removeAnimation):
(WebCore::GraphicsLayerChromium::suspendAnimations):
(WebCore::GraphicsLayerChromium::resumeAnimations):
(WebCore::GraphicsLayerChromium::setContentsToMedia):
(WebCore::GraphicsLayerChromium::hostLayerForChildren):
(WebCore::GraphicsLayerChromium::layerForParent):
(WebCore::GraphicsLayerChromium::platformLayer):
(WebCore::GraphicsLayerChromium::setDebugBackgroundColor):
(WebCore::GraphicsLayerChromium::setDebugBorder):
(WebCore::GraphicsLayerChromium::updateChildList):
(WebCore::GraphicsLayerChromium::updateLayerPosition):
(WebCore::GraphicsLayerChromium::updateLayerSize):
(WebCore::GraphicsLayerChromium::updateAnchorPoint):
(WebCore::GraphicsLayerChromium::updateTransform):
(WebCore::GraphicsLayerChromium::updateChildrenTransform):
(WebCore::GraphicsLayerChromium::updateMasksToBounds):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
(WebCore::GraphicsLayerChromium::updateLayerIsDrawable):
(WebCore::GraphicsLayerChromium::updateLayerBackgroundColor):
(WebCore::GraphicsLayerChromium::updateContentsRect):
(WebCore::GraphicsLayerChromium::updateContentsScale):
(WebCore::GraphicsLayerChromium::setupContentsLayer):
* platform/graphics/chromium/GraphicsLayerChromium.h:
(WebCore::GraphicsLayerChromium::hasContentsLayer):
(WebCore::GraphicsLayerChromium::contentsLayer):
(WebCore::GraphicsLayerChromium::primaryLayer):
(GraphicsLayerChromium):
* platform/graphics/chromium/LayerChromium.h:
(LayerChromium):

Source/WebKit/chromium:

* WebKit.gyp:
* src/WebContentLayer.cpp:
(WebKit::WebContentLayer::clearClient):
(WebKit):
(WebKit::WebContentLayer::setDrawsContent):
(WebKit::WebContentLayer::drawsContent):
(WebKit::WebContentLayer::WebContentLayer):
(WebKit::WebContentLayer::operator=):
(WebKit::WebContentLayer::operator PassRefPtr<ContentLayerChromium>):
* src/WebContentLayerImpl.cpp:
* src/WebContentLayerImpl.h:
(WebContentLayerImpl):
* src/WebLayer.cpp:
(WebKit::WebLayer::setSublayerTransform):
(WebKit):
(WebKit::WebLayer::setTransform):
(WebKit::WebLayer::setIsDrawable):
(WebKit::WebLayer::setPreserves3D):
(WebKit::WebLayer::setDoubleSided):
(WebKit::WebLayer::setBackgroundColor):
(WebKit::WebLayer::setContentsScale):
* tests/ImageLayerChromiumTest.cpp:
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoremove bit rotted comment about css properties
tony@chromium.org [Thu, 17 May 2012 18:34:37 +0000 (18:34 +0000)]
remove bit rotted comment about css properties
https://bugs.webkit.org/show_bug.cgi?id=86750

Reviewed by Alexis Menard.

It's not clear to me what the first block was even referring to.
Aural doesn't seem to exist anymore. It might be worth keeping,
"All the CSS properties are not supported by the renderer at the
moment.", but it seems obvious to me.

No new tests, just removing a comment.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Remove unnecessary expectations for passing tests.
pkasting@chromium.org [Thu, 17 May 2012 18:33:33 +0000 (18:33 +0000)]
[chromium] Remove unnecessary expectations for passing tests.
https://bugs.webkit.org/show_bug.cgi?id=86698

Unreviewed, test expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoInsert source file and line number for v8 function calls into tracing
enne@google.com [Thu, 17 May 2012 18:22:38 +0000 (18:22 +0000)]
Insert source file and line number for v8 function calls into tracing
https://bugs.webkit.org/show_bug.cgi?id=84613

Reviewed by Kentaro Hara.

The trace for v8 function calls doesn't include any information about
what function is being called. Pass this information along so it can
be less opaque.

* bindings/v8/V8Proxy.cpp:
(WebCore::resourceInfo):
(WebCore):
(WebCore::resourceString):
(WebCore::V8Proxy::instrumentedCallFunction):
* platform/chromium/TraceEvent.h:
(WebCore::TraceEvent::TraceStringWithCopy::TraceStringWithCopy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Gardening, unskip some tests after r117426.
rakuco@webkit.org [Thu, 17 May 2012 18:21:02 +0000 (18:21 +0000)]
[EFL] Gardening, unskip some tests after r117426.

* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Add API for Web Database handling
commit-queue@webkit.org [Thu, 17 May 2012 18:09:37 +0000 (18:09 +0000)]
[EFL] Add API for Web Database handling
https://bugs.webkit.org/show_bug.cgi?id=85178

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-17
Reviewed by Antonio Gomes.

Source/WebKit:

Added the new Web Database API to the buildsystem.

* PlatformEfl.cmake:

Source/WebKit/efl:

Add API for Web Database. This API will allow a browser
to query information about size, name, filename and remove
databases based on the origin. It will be also possible to
list all databases for a given origin.

* ewk/EWebKit.h:
* ewk/ewk_security_origin.cpp:
(ewk_security_origin_web_database_get_all):
* ewk/ewk_security_origin.h:
* ewk/ewk_settings.cpp:
* ewk/ewk_settings.h:
* ewk/ewk_web_database.cpp: Added.
(_Ewk_Web_Database):
(ewk_web_database_display_name_get):
(ewk_web_database_expected_size_get):
(ewk_web_database_filename_get):
(ewk_web_database_name_get):
(ewk_web_database_security_origin_get):
(ewk_web_database_size_get):
(ewk_web_database_remove):
(ewk_web_database_remove_all):
(ewk_web_database_free):
(ewk_web_database_list_free):
(ewk_web_database_new):
* ewk/ewk_web_database.h: Added.
* ewk/ewk_web_database_private.h: Copied from Source/WebKit/efl/ewk/EWebKit.h.
(WebCore):

Tools:

Use the newly introduced Web Database API in EFL's DRT.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::clearAllDatabases):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] REGRESSION(101967): It made editing/style/iframe-onload-crash-mac.html timeout
caio.oliveira@openbossa.org [Thu, 17 May 2012 17:54:40 +0000 (17:54 +0000)]
[Qt] REGRESSION(101967): It made editing/style/iframe-onload-crash-mac.html timeout
https://bugs.webkit.org/show_bug.cgi?id=73802

Reviewed by Ryosuke Niwa.

Source/WebCore:

Timeout was caused by an infinite in the outer loop of
pushDownInlineStyleAroundNode(). The outer loop variable 'current' should point at the
node containing 'targetNode'. The inner loop traverse the children of 'current'
and discover the children that contains 'targetNode'.

However, before the inner loop, we call removeInlineStyleFromElement() that can
potentially remove the 'current' node from the tree, moving its children to
'current' former parent. For that reason 'child' and 'lastChild' are collected
before this call.

The tricky part is that changing the 'current' children parent, we might trigger
further side-effects, that can remove either 'child' or 'lastChild' from the tree
too. The infinite loop was due to 'child' being off the document, so it's
nextSibling() is 0, and we go another run of outer loop without changing
'current' because the 'targetNode' wasn't in the first child that inner loop
couldn't reach.

When testing Qt on Mac, there was also a crash in RenderTextControl when the font
family was empty, this patch fixes it as well.

* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Use NodeVector
instead of relying on first/last child being valid after
removeInlineStyleFromElement() is called. Skip the child if it has no parent,
this is an indication that it was removed from the tree.

* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::hasValidAvgCharWidth): Empty AtomicStrings aren't
supported by HashSet, so we have to early return in this case.

LayoutTests:

* platform/qt/Skipped: Unskipped. Note that it is still skipped for wk2 because
setEditingBehavior is not implemented for WebKitTestRunner yet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: implement Go To selector for stylesheet files.
pfeldman@chromium.org [Thu, 17 May 2012 17:52:33 +0000 (17:52 +0000)]
Web Inspector: implement Go To selector for stylesheet files.
https://bugs.webkit.org/show_bug.cgi?id=86751

Reviewed by Yury Semikhatsky.

StyleSheetOutlineDialog is introduced.

* English.lproj/localizedStrings.js:
* inspector/front-end/FilteredItemSelectionDialog.js:
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._createDebugToolbar):
(WebInspector.ScriptsPanel.prototype._createButtonAndRegisterShortcuts):
(WebInspector.ScriptsPanel.prototype._showOutlineDialog):
* inspector/front-end/StylesPanel.js:
(WebInspector.StyleSheetOutlineDialog):
(WebInspector.StyleSheetOutlineDialog.show):
(WebInspector.StyleSheetOutlineDialog.prototype.itemTitleAt):
(WebInspector.StyleSheetOutlineDialog.prototype.itemKeyAt):
(WebInspector.StyleSheetOutlineDialog.prototype.itemsCount):
(WebInspector.StyleSheetOutlineDialog.prototype.requestItems):
(WebInspector.StyleSheetOutlineDialog.prototype.requestItems.didGetStyleSheet):
(WebInspector.StyleSheetOutlineDialog.prototype.selectItem):
* inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.prototype._generateTabId):
(WebInspector.TabbedEditorContainer.prototype.currentFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r117449): Unreviewed, rolling out r117449.
rakuco@webkit.org [Thu, 17 May 2012 17:50:30 +0000 (17:50 +0000)]
REGRESSION (r117449): Unreviewed, rolling out r117449.
https://bugs.webkit.org/show_bug.cgi?id=86753

Broke many unskipped tests which lack expectations

* platform/efl/Skipped:
* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r117428): WebKit API/SPI was removed
mitz@apple.com [Thu, 17 May 2012 17:27:50 +0000 (17:27 +0000)]
REGRESSION (r117428): WebKit API/SPI was removed
https://bugs.webkit.org/show_bug.cgi?id=86748

Reverted r117428.

.:

* Source/autotools/symbols.filter:

Source/WebCore:

* testing/InternalSettings.cpp:
(WebCore::InternalSettings::setMediaPlaybackRequiresUserGesture):
* testing/InternalSettings.h:
(InternalSettings):
* testing/InternalSettings.idl:

Source/WebKit/chromium:

* public/WebView.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setDomainRelaxationForbidden):
(WebKit):
* src/WebViewImpl.h:
(WebViewImpl):

Source/WebKit/gtk:

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::setDomainRelaxationForbiddenForURLScheme):
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):

Source/WebKit/mac:

* WebKit.order:
* WebView/WebView.mm:
(+[WebView _setDomainRelaxationForbidden:forURLScheme:]):
* WebView/WebViewPrivate.h:

Source/WebKit/qt:

* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::setDomainRelaxationForbiddenForURLScheme):
* WebCoreSupport/DumpRenderTreeSupportQt.h:

Source/WebKit/win:

* Interfaces/IWebViewPrivate.idl:
* WebView.cpp:
(WebView::setDomainRelaxationForbiddenForURLScheme):
* WebView.h:
(WebView):

Source/WebKit2:

* win/WebKit2.def:

Tools:

* DumpRenderTree/LayoutTestController.cpp:
(setDomainRelaxationForbiddenForURLSchemeCallback):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
* DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
(LayoutTestController):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):

LayoutTests:

* http/tests/security/setDomainRelaxationForbiddenForURLScheme.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Fix link error caused by not directly linking with edbus
commit-queue@webkit.org [Thu, 17 May 2012 17:25:58 +0000 (17:25 +0000)]
[EFL] Fix link error caused by not directly linking with edbus
https://bugs.webkit.org/show_bug.cgi?id=86747

Unreviewed build fix.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-17

.:

* Source/cmake/FindEFL.cmake:

Source/WebKit:

* PlatformEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Build fix, SelectionHandler extra debug logs
mifenton@rim.com [Thu, 17 May 2012 17:20:07 +0000 (17:20 +0000)]
[BlackBerry] Build fix, SelectionHandler extra debug logs
https://bugs.webkit.org/show_bug.cgi?id=86743

Reviewed by Antonio Gomes.

Add include for BlackBerryPlatformLog to SelectionHandler.cpp

* WebKitSupport/SelectionHandler.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, adding GTK baselines for new tests added in r115641, r116975 and r117339.
zandobersek@gmail.com [Thu, 17 May 2012 17:05:36 +0000 (17:05 +0000)]
Unreviewed, adding GTK baselines for new tests added in r115641, r116975 and r117339.

* platform/gtk/css2.1/20110323/inline-table-001-expected.txt: Added.
* platform/gtk/css2.1/20110323/inline-table-002a-expected.txt: Added.
* platform/gtk/css2.1/20110323/inline-table-003-expected.txt: Added.
* platform/gtk/fast/hidpi/image-set-border-image-comparison-expected.txt: Added.
* platform/gtk/mathml/presentation/mroot-pref-width-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Thu, 17 May 2012 16:35:33 +0000 (16:35 +0000)]
[Qt] Unreviewed gardening.

* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0/Skipped:
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: create SourceFrames with content providers.
pfeldman@chromium.org [Thu, 17 May 2012 16:05:41 +0000 (16:05 +0000)]
Web Inspector: create SourceFrames with content providers.
https://bugs.webkit.org/show_bug.cgi?id=86742

Reviewed by Vsevolod Vlasov.

Simple refactoring.

* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype.commitEditing):
(WebInspector.JavaScriptSourceFrame.prototype.afterTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype._didEditContent):
* inspector/front-end/ResourceView.js:
(WebInspector.ResourceSourceFrame):
(WebInspector.ResourceSourceFrame.prototype.get resource):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._createSourceFrame):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype._ensureContentLoaded):
* inspector/front-end/StylesPanel.js:
(WebInspector.StyleSourceFrame):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.contentURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: error when expanding an HTMLAllCollection object in the console
yurys@chromium.org [Thu, 17 May 2012 16:00:36 +0000 (16:00 +0000)]
Web Inspector: error when expanding an HTMLAllCollection object in the console
https://bugs.webkit.org/show_bug.cgi?id=86741

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/console/inspect-html-all-collection.html

* inspector/InjectedScriptSource.js: take into account that typeof HTMLAllCollection is "undefined"
when checking if object resolved by id is valid.

LayoutTests:

Test that RemoteObject.callFunctionOn can be successfully invoked on a
remote object representing HTMLAllCollection instance.

* inspector/console/inspect-html-all-collection-expected.txt: Added.
* inspector/console/inspect-html-all-collection.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed build fix attempt. Changing class to struct in forward declaration.
kinuko@chromium.org [Thu, 17 May 2012 15:57:40 +0000 (15:57 +0000)]
Unreviewed build fix attempt. Changing class to struct in forward declaration.

* fileapi/File.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: convert styles panel into UISourceCodeProvider in the scripts panel.
pfeldman@chromium.org [Thu, 17 May 2012 15:51:11 +0000 (15:51 +0000)]
Web Inspector: convert styles panel into UISourceCodeProvider in the scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=86734

Reviewed by Vsevolod Vlasov.

This change also makes Scripts render ans Source Code under that experiment.

* English.lproj/localizedStrings.js:
* inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.get toolbarItemLabel):
(WebInspector.ScriptsPanel.prototype.canShowAnchorLocation):
(WebInspector.ScriptsPanel.prototype._createSourceFrame):
* inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
* inspector/front-end/StylesPanel.js:
(WebInspector.StylesUISourceCodeProvider):
(WebInspector.StylesUISourceCodeProvider.prototype.uiSourceCodes):
(WebInspector.StylesUISourceCodeProvider.prototype._initialize):
(WebInspector.StylesUISourceCodeProvider.prototype._resourceAdded):
(WebInspector.StylesUISourceCodeProvider.prototype._reset):
(WebInspector.StyleSource):
(WebInspector.StyleSourceFrame):
(WebInspector.StyleSourceFrame.prototype.canEditSource):
(WebInspector.StyleSourceFrame.prototype.requestContent):
(WebInspector.StyleSourceFrame.prototype.commitEditing):
(WebInspector.StyleSourceFrame.prototype.afterTextChanged):
(WebInspector.StyleSourceFrame.prototype._clearIncrementalUpdateTimer):
(WebInspector.StyleSourceFrame.prototype._contentChanged):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection):
(WebInspector.StylePropertiesSection.prototype._createRuleOriginNode):
* inspector/front-end/UISourceCode.js:
* inspector/front-end/inspector.js:
(WebInspector._createPanels):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFrame flattening should not expand tiny frames
antti@apple.com [Thu, 17 May 2012 15:42:17 +0000 (15:42 +0000)]
Frame flattening should not expand tiny frames
https://bugs.webkit.org/show_bug.cgi?id=86736

Source/WebCore:

Reviewed by Kenneth Rohde Christiansen.

If a frame has so small fixed size that it is not usefully scrollable on desktop it is probably
not meant to be scrolled. Displaying any otherwise invisible content by expanding the frame
may end up looking like a rendering error.

The patch prevents expansion of frames that have fixed width or height less than 8px.

Test: fast/frames/flattening/iframe-tiny.html

* rendering/RenderFrameBase.cpp:
(WebCore::shouldExpandFrame):
(WebCore):
(WebCore::RenderFrameBase::layoutWithFlattening):

LayoutTests:

Reviewed by Kenneth Rohde Christiansen.

* fast/frames/flattening/iframe-tiny-expected.txt: Added.
* fast/frames/flattening/iframe-tiny.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Web Inspector: assertion failure when inspecting a shared worker in debug...
yurys@chromium.org [Thu, 17 May 2012 15:21:08 +0000 (15:21 +0000)]
[Chromium] Web Inspector: assertion failure when inspecting a shared worker in debug mode
https://bugs.webkit.org/show_bug.cgi?id=86726

Reviewed by Pavel Feldman.

No need to keep RefPtr to WorkerThread in a task that will be executed on
that thread, raw pointer can be used instead.

* inspector/WorkerDebuggerAgent.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Gardening failure test cases.
commit-queue@webkit.org [Thu, 17 May 2012 15:19:03 +0000 (15:19 +0000)]
[EFL] Gardening failure test cases.
https://bugs.webkit.org/show_bug.cgi?id=86728

Unreviewed EFL gardening.

Patch by Krzysztof Czech  <k.czech@samsung.com>, Mariusz Grzegorczyk <mariusz.g@samsung.com> on 2012-05-17

* platform/efl/Skipped: removing tests related to editing callbacks functionality.
* platform/efl/test_expectations.txt: adding new bugs regarding drag'n'drop and spell checking.
Merging tests with particular bugs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8][Refactoring] Support an optional 'message' argument for throwTypeError()
haraken@chromium.org [Thu, 17 May 2012 15:17:20 +0000 (15:17 +0000)]
[V8][Refactoring] Support an optional 'message' argument for throwTypeError()
https://bugs.webkit.org/show_bug.cgi?id=86576

Reviewed by Adam Barth.

As commented in https://bugs.webkit.org/show_bug.cgi?id=84074#c5,
I am planning to refactor a series of confusing throwError()s into
throwError() and throwTypeError().

This patch supports an optional 'message' argument for V8Proxy::throwTypeError().
Also this patch replaces throwError("message", V8Proxy::TypeError) in custom bindings
with V8Proxy::throwTypeError("message").

No tests. No change in behavior.

* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::throwTypeError):
* bindings/v8/V8Proxy.h:
(V8Proxy):
* bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore::constructWebGLArray):
* bindings/v8/custom/V8AudioContextCustom.cpp:
(WebCore::V8AudioContext::constructorCallback):
* bindings/v8/custom/V8BlobCustom.cpp:
(WebCore::V8Blob::constructorCallback):
* bindings/v8/custom/V8DOMFormDataCustom.cpp:
(WebCore::V8DOMFormData::constructorCallback):
* bindings/v8/custom/V8DataViewCustom.cpp:
(WebCore::V8DataView::constructorCallback):
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore::v8HTMLImageElementConstructorCallback):
* bindings/v8/custom/V8IntentConstructor.cpp:
(WebCore::V8Intent::constructorCallback):
* bindings/v8/custom/V8MessageChannelConstructor.cpp:
(WebCore::V8MessageChannel::constructorCallback):
* bindings/v8/custom/V8NotificationCenterCustom.cpp:
(WebCore::V8NotificationCenter::requestPermissionCallback):
* bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:
(WebCore::V8WebKitMutationObserver::constructorCallback):
* bindings/v8/custom/V8WebKitPointConstructor.cpp:
(WebCore::V8WebKitPoint::constructorCallback):
* bindings/v8/custom/V8WebSocketCustom.cpp:
(WebCore::V8WebSocket::constructorCallback):
* bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
(WebCore::V8XMLHttpRequest::constructorCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Extensions API] pages shown in sidebar are limited in height to 150px
caseq@chromium.org [Thu, 17 May 2012 14:21:41 +0000 (14:21 +0000)]
Web Inspector: [Extensions API] pages shown in sidebar are limited in height to 150px
https://bugs.webkit.org/show_bug.cgi?id=86659

Reviewed by Vsevolod Vlasov.

* inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionView):
(WebInspector.ExtensionSidebarPane.prototype.setPage): set default iframe height to 150px, unless already set by user.
* inspector/front-end/inspector.css: set extension view and iframe elements to "fill", iframe to 100% height.
(iframe.extension):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] run-webkit-tests can't work on ubuntu 12.04
commit-queue@webkit.org [Thu, 17 May 2012 14:08:58 +0000 (14:08 +0000)]
[chromium] run-webkit-tests can't work on ubuntu 12.04
https://bugs.webkit.org/show_bug.cgi?id=86565

Patch by Li Yin <li.yin@intel.com> on 2012-05-17
Reviewed by Kent Tamura.

On ubuntu 12.04, the package ttf-thai-tlwg install the Garuda.ttf
into /usr/share/fonts/truetype/tlwg/Garuda.ttf, not /usr/share/fonts/truetype/thai/Garuda.ttf

* DumpRenderTree/chromium/TestShellLinux.cpp:
(checkAndLoadFontFile):
(setupFontconfig):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Hover on a breakpoint in breakpoint-pane does not get differentiated.
commit-queue@webkit.org [Thu, 17 May 2012 13:54:13 +0000 (13:54 +0000)]
Web Inspector: Hover on a breakpoint in breakpoint-pane does not get differentiated.
https://bugs.webkit.org/show_bug.cgi?id=86711

Changed color values with background on hover over breakpoints.

Patch by Sam D <dsam2912@gmail.com> on 2012-05-17
Reviewed by Yury Semikhatsky.

UI change, No new tests.

* inspector/front-end/inspector.css:
(.breakpoint-list li:hover):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening, adding platform-specific baselines for
zandobersek@gmail.com [Thu, 17 May 2012 13:35:29 +0000 (13:35 +0000)]
Unreviewed GTK gardening, adding platform-specific baselines for
two tests affected by r117339.

* platform/gtk/fast/repaint/float-overflow-expected.txt: Added.
* platform/gtk/fast/repaint/float-overflow-right-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd setting of additional_expectations option to
epoger@chromium.org [Thu, 17 May 2012 13:35:10 +0000 (13:35 +0000)]
Add setting of additional_expectations option to
chromium_unittest.test_overrides_and_builder_names(),
so we can test order in which the base and chromium expectations files
are combined.

https://bugs.webkit.org/show_bug.cgi?id=86642

Reviewed by Dirk Pranke.

* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
(ChromiumPortTest.test_overrides_and_builder_names):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: DOM Breakpoints Pane should allow to Remove All the breakpoints
commit-queue@webkit.org [Thu, 17 May 2012 13:32:09 +0000 (13:32 +0000)]
Web Inspector: DOM Breakpoints Pane should allow to Remove All the breakpoints
https://bugs.webkit.org/show_bug.cgi?id=86716

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-05-17
Reviewed by Yury Semikhatsky.

Added a new context menu to provide Remove All DOM breakpoint option.

UI Feature. Tests not required.

* English.lproj/localizedStrings.js:
* inspector/front-end/DOMBreakpointsSidebarPane.js:
(WebInspector.DOMBreakpointsSidebarPane.prototype._removeAllBreakpoints):
(WebInspector.DOMBreakpointsSidebarPane.prototype._contextMenu):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening. Added platform specific expectation.
kkristof@inf.u-szeged.hu [Thu, 17 May 2012 13:29:51 +0000 (13:29 +0000)]
[Qt] Unreviewed gardening. Added platform specific expectation.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-05-17

* platform/qt-5.0-wk2/editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable-expected.txt: Added after r117419.
* platform/qt-5.0-wk2/svg/css/text-gradient-shadow-expected.txt: Added after r117289.
* platform/qt/editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable-expected.txt: Added after r117419.
* platform/qt/fast/block/float/overhanging-tall-block-expected.txt: Update after r117429.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117441 268f45cc-cd09-0410-ab3c-d52691b4dbfc