WebKit-https.git
6 years agoUnreviewed EFL gardening
m.pakula@samsung.com [Fri, 15 Nov 2013 10:35:35 +0000 (10:35 +0000)]
Unreviewed EFL gardening

Mark flaky and incorrectly passing tests.

* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:
* platform/efl/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.txt: Removed wrong test expectation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Bumping GStreamer version to 1.2.1 for the dependencies
calvaris@igalia.com [Fri, 15 Nov 2013 10:23:43 +0000 (10:23 +0000)]
[GTK] Bumping GStreamer version to 1.2.1 for the dependencies
https://bugs.webkit.org/show_bug.cgi?id=124360

Reviewed by Philippe Normand.

Tools:

* gtk/jhbuild.modules: Bumped GStreamer version up to 1.2.1

LayoutTests:

* platform/gtk/TestExpectations: Flagged
media/video-canvas-drawing-output.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Layout tests with international text properties need to be rebaselined.
commit-queue@webkit.org [Fri, 15 Nov 2013 09:21:52 +0000 (09:21 +0000)]
[EFL] Layout tests with international text properties need to be rebaselined.
https://bugs.webkit.org/show_bug.cgi?id=124389

Unreviewed, EFL rabaseline.

EFL international text rebaselined after r147668.
Move some expectation files to efl common place because those files in wk1 are
in exact accordance with files in wk2, and then delete the files in wk1 and wk2.

Patch by Sun-woo Nam <sunny.nam@samsung.com> on 2013-11-15

* platform/efl-wk1/fast/text/international/003-expected.txt: Removed.
* platform/efl-wk1/fast/text/international/bidi-layout-across-linebreak-expected.txt: Removed.
* platform/efl-wk2/TestExpectations:
* platform/efl/fast/text/international/002-expected.txt:
* platform/efl/fast/text/international/003-expected.txt:
Renamed from LayoutTests/platform/efl-wk2/fast/text/international/003-expected.txt.
* platform/efl/fast/text/international/bidi-layout-across-linebreak-expected.txt:
Renamed from LayoutTests/platform/efl-wk2/fast/text/international/bidi-layout-across-linebreak-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Win] Improve support for command line builds of 64-bit JSC
bfulgham@apple.com [Fri, 15 Nov 2013 04:58:12 +0000 (04:58 +0000)]
[Win] Improve support for command line builds of 64-bit JSC
https://bugs.webkit.org/show_bug.cgi?id=124380

Patch by Brent Fulgham <bfulgham@apple.com> on 2013-11-14
Reviewed by David Kilzer.

* Scripts/webkitdirs.pm:
(argumentsForConfiguration): Recognize all flavors of Debug and Release (i.e., 'Debug',
'Debug|Win32', 'Debug|x64') when passing arguments to child processes.
(determinePassedConfiguration): Don't suffix configuration with "|Win32" or "|x64". That's
what the "$configurationForVisualStudio" value is for.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate WebCrypto tests
ap@apple.com [Fri, 15 Nov 2013 02:50:37 +0000 (02:50 +0000)]
Update WebCrypto tests
https://bugs.webkit.org/show_bug.cgi?id=124388

Reviewed by Anders Carlsson.

Updated tests for newer common.js. Changed some tests from just dumping results
to comparing them to known expected ones. Fixed a syntax error in
aes-cbc-invalid-length.html, so it now actually runs.

* crypto/subtle/resources/common.js: Update to a new version from Blink, because
it's much nicer than the old one, and it's good to be compatible at test level.
Moved crypto.subtle definition from webkitSubtle here to avoid repeating it in all
tests. Added a quick and dirty Promise.all implementation.

* crypto/subtle/aes-cbc-192-encrypt-decrypt-expected.txt:
* crypto/subtle/aes-cbc-192-encrypt-decrypt.html:
* crypto/subtle/aes-cbc-256-encrypt-decrypt-expected.txt:
* crypto/subtle/aes-cbc-256-encrypt-decrypt.html:
* crypto/subtle/aes-cbc-encrypt-decrypt-expected.txt:
* crypto/subtle/aes-cbc-encrypt-decrypt-with-padding-expected.txt:
* crypto/subtle/aes-cbc-encrypt-decrypt-with-padding.html:
* crypto/subtle/aes-cbc-encrypt-decrypt.html:
* crypto/subtle/aes-cbc-generate-key.html:
* crypto/subtle/aes-cbc-import-jwk-expected.txt:
* crypto/subtle/aes-cbc-import-jwk.html:
* crypto/subtle/aes-cbc-invalid-length-expected.txt:
* crypto/subtle/aes-cbc-invalid-length.html:
* crypto/subtle/aes-cbc-wrong-key-class.html:
* crypto/subtle/aes-export-key-expected.txt:
* crypto/subtle/aes-export-key.html:
* crypto/subtle/argument-conversion-expected.txt:
* crypto/subtle/argument-conversion.html:
* crypto/subtle/hmac-export-key-expected.txt:
* crypto/subtle/hmac-export-key.html:
* crypto/subtle/hmac-generate-key.html:
* crypto/subtle/hmac-import-jwk-expected.txt:
* crypto/subtle/hmac-import-jwk.html:
* crypto/subtle/hmac-sign-verify-empty-key-expected.txt:
* crypto/subtle/hmac-sign-verify-empty-key.html:
* crypto/subtle/hmac-sign-verify-expected.txt:
* crypto/subtle/hmac-sign-verify.html:
* crypto/subtle/import-jwk-expected.txt:
* crypto/subtle/import-jwk.html:
* crypto/subtle/rsassa-pkcs1-v1_5-generate-key-expected.txt:
* crypto/subtle/rsassa-pkcs1-v1_5-generate-key.html:
* crypto/subtle/rsassa-pkcs1-v1_5-import-jwk-expected.txt:
* crypto/subtle/rsassa-pkcs1-v1_5-import-jwk.html:
* crypto/subtle/rsassa-pkcs1-v1_5-sign-verify-expected.txt:
* crypto/subtle/rsassa-pkcs1-v1_5-sign-verify.html:
* crypto/subtle/sha-1-expected.txt:
* crypto/subtle/sha-1.html:
* crypto/subtle/sha-224-expected.txt:
* crypto/subtle/sha-224.html:
* crypto/subtle/sha-256-expected.txt:
* crypto/subtle/sha-256.html:
* crypto/subtle/sha-384-expected.txt:
* crypto/subtle/sha-384.html:
* crypto/subtle/sha-512-expected.txt:
* crypto/subtle/sha-512.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoXMLSerializer escapes < > & correctly inside <script> and <style> tags.
commit-queue@webkit.org [Fri, 15 Nov 2013 02:27:59 +0000 (02:27 +0000)]
XMLSerializer escapes < > & correctly inside <script> and <style> tags.
https://bugs.webkit.org/show_bug.cgi?id=123914

Patch by Victor Costan <costan@gmail.com> on 2013-11-14
Reviewed by Darin Adler.

Source/WebCore:

Test: fast/dom/XMLSerializer-entities.html

* editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::serializeNodesWithNamespaces): vim removed some whitespace.
(WebCore::MarkupAccumulator::entityMaskForText): Fixed the returned value for <script> etc in XML.

LayoutTests:

* fast/dom/SelectorAPI/resig-SelectorsAPI-test-expected.txt: fix incorrect expectations.
* fast/dom/SelectorAPI/resig-SelectorsAPI-test.xhtml: use CDATA consistently.
* fast/dom/XMLSerializer-entities-expected.txt: Added.
* fast/dom/XMLSerializer-entities.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoASSERTION FAILED: rangesIntersect(m_renderer.pixelSnappedLogicalTopForFloat(floatingO...
bjonesbe@adobe.com [Fri, 15 Nov 2013 01:34:50 +0000 (01:34 +0000)]
ASSERTION FAILED: rangesIntersect(m_renderer.pixelSnappedLogicalTopForFloat(floatingObject), m_renderer.pixelSnappedLogicalBottomForFloat(floatingObject), m_lineTop, m_lineBottom) ../../Source/WebCore/rendering/FloatingObjects.cpp(463)
https://bugs.webkit.org/show_bug.cgi?id=124375

Reviewed by Alexandru Chiculita.

When moving the placed floats tree over to LayoutUnit, I forgot to
update these asserts, which causes issues on ports with subpixel
layout enabled.

No new tests, no behavior change.

* rendering/FloatingObjects.cpp:
(WebCore::FindNextFloatLogicalBottomAdapter::collectIfNeeded):
(WebCore::::collectIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoClean up sequence handling in Blob constructor
commit-queue@webkit.org [Fri, 15 Nov 2013 00:55:45 +0000 (00:55 +0000)]
Clean up sequence handling in Blob constructor
https://bugs.webkit.org/show_bug.cgi?id=124343

Patch by Victor Costan <costan@gmail.com> on 2013-11-14
Reviewed by Alexey Proskuryakov.

Source/WebCore:

Added test case to LayoutTests/fast/files/blob-constructor.html

* bindings/js/JSBlobCustom.cpp:
(WebCore::JSBlobConstructor::constructJSBlob):
    Handle exceptions in sequences, eliminate double type-checking for
    ArrayBuffer, ArrayBufferView and Blob parts.

LayoutTests:

* fast/files/blob-constructor-expected.txt:
* fast/files/script-tests/blob-constructor.js:
    Add test with sequence that throws an error on property access.
(get Object):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Cocoa] WKBrowsingContextController's policy client implementation over-releases...
mitz@apple.com [Fri, 15 Nov 2013 00:28:38 +0000 (00:28 +0000)]
[Cocoa] WKBrowsingContextController's policy client implementation over-releases WKURLRequests and WKURLResponses
https://bugs.webkit.org/show_bug.cgi?id=124386

Reviewed by Sam Weinig.

* UIProcess/API/mac/WKBrowsingContextController.mm:
(setUpPagePolicyClient): Changed to release the Cocoa objects we copy out of the WK objects
passed into the client callbacks, but not the WK objects themselves, which are not owned by
the callbacks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMake CLoop easier to build, and make it work
oliver@apple.com [Fri, 15 Nov 2013 00:12:51 +0000 (00:12 +0000)]
Make CLoop easier to build, and make it work
https://bugs.webkit.org/show_bug.cgi?id=124359

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Add --cloop to build-jsc, build-webkit and friends.

Also make CLoop build and work again - This meant adding a
couple of missing ENABLE(DFG_JIT) blocks, and fixing a few
other references.

* Configurations/FeatureDefines.xcconfig:
* bytecode/BytecodeLivenessAnalysis.cpp:
(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):
* bytecode/DFGExitProfile.cpp:
* dfg/DFGCapabilities.cpp:
* dfg/DFGCompilationKey.cpp:
* dfg/DFGCompilationMode.cpp:
* jit/JITExceptions.cpp:
(JSC::genericUnwind):

Source/WebCore:

Add cloop configuration info to WebCore FeatureDefines
so that it's consistent with JSC

* Configurations/FeatureDefines.xcconfig:

Source/WTF:

Make building with the CLoop forcibly enabled manually
disable the JITs

* wtf/Platform.h:

Tools:

Add --cloop support to forcibly enable to CLoop build

* Scripts/build-jsc:
* Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoReplace calls to deprecated CFPropertyList functions in WebKit2
aestes@apple.com [Fri, 15 Nov 2013 00:11:33 +0000 (00:11 +0000)]
Replace calls to deprecated CFPropertyList functions in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=124384

Reviewed by Anders Carlsson.

* UIProcess/cf/WebPageProxyCF.cpp:
(WebKit::WebPageProxy::sessionStateData): Replaced CFPropertyListWriteToStream() with CFPropertyListWrite().
(WebKit::WebPageProxy::restoreFromSessionStateData): Replaced CFPropertyListCreateFromXMLData() with CFPropertyListCreateWithData().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoChange Fail->Failure in some recent expectations.
timothy_horton@apple.com [Thu, 14 Nov 2013 23:27:59 +0000 (23:27 +0000)]
Change Fail->Failure in some recent expectations.

Suddenly, everything is clear.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd webkit slave.
lforschler@apple.com [Thu, 14 Nov 2013 23:26:33 +0000 (23:26 +0000)]
Add webkit slave.

Unreviewed.

* BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agohttp/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html is slow, freque...
timothy_horton@apple.com [Thu, 14 Nov 2013 23:23:35 +0000 (23:23 +0000)]
http/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html is slow, frequently > 30 second timeout
https://bugs.webkit.org/show_bug.cgi?id=124373

* platform/mac/TestExpectations:
Mark test as flaky on Mountain Lion Release bot.
Marking as slow seems to have no effect on the notifyDone timeout, just the outer timeouts.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Cairo] Avoid extra copy when drawing images
commit-queue@webkit.org [Thu, 14 Nov 2013 23:15:24 +0000 (23:15 +0000)]
[Cairo] Avoid extra copy when drawing images
https://bugs.webkit.org/show_bug.cgi?id=124209

Patch by Aloisio Almeida Jr <aloisio.almeida@openbossa.org> on 2013-11-14
Reviewed by Martin Robinson.

To solve the bug #58309 a cairo subsurface is being used to limit the
source image boundaries.
In many cases, when a cairo subsurface is used for drawing an image,
it occurs an image copy, causing performance penalty. In the case of
the function PlatformContextCairo::drawSurfaceToContext, the image
copy always happens.
So, we should use the subsurface only when it's really necessary.
In cases where we're drawing the whole image, the subsurface is
unnecessary.

The proposed patch avoid the use of subsurfaces when sampling the whole
image.

No new tests. It's an enhancement. Already covered by existing tests.

* platform/graphics/cairo/PlatformContextCairo.cpp:
(WebCore::PlatformContextCairo::drawSurfaceToContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agobuild.webkit.org/dashboard can’t open different results in two new tabs
timothy_horton@apple.com [Thu, 14 Nov 2013 23:03:32 +0000 (23:03 +0000)]
build.webkit.org/dashboard can’t open different results in two new tabs
https://bugs.webkit.org/show_bug.cgi?id=124383

Reviewed by Alexey Proskuryakov.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
(BuildbotQueueView.prototype.revisionLinksForIteration):
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
(StatusLineView.prototype._clicked):
Use _blank (which is effectively open-in-new-tab, in Safari) instead of _new (which isn't a
real pseudo-target and instead acts as a named target and will end up causing all link clicks
to open in the same secondary tab).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agogenerate-message-receiver.py can't handle nested #ifs
commit-queue@webkit.org [Thu, 14 Nov 2013 22:20:04 +0000 (22:20 +0000)]
generate-message-receiver.py can't handle nested #ifs
https://bugs.webkit.org/show_bug.cgi?id=121877

Patch by Gergo Balogh <geryxyz@inf.u-szeged.hu> on 2013-11-14
Reviewed by Darin Adler.

parser.py was modifieded to collect and combine conditions of nested #ifs.
messages_unittest.py extended to check these modifications.

* Scripts/webkit2/messages_unittest.py:
(LoadSomething):
(std):
(AddEvent):
(LoadSomethingElse):
* Scripts/webkit2/parser.py:
(combine_condition):
(bracket_if_needed):
(parse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoReimplement getDayBoundaries using NSCalendar on 10.9
andersca@apple.com [Thu, 14 Nov 2013 22:02:47 +0000 (22:02 +0000)]
Reimplement getDayBoundaries using NSCalendar on 10.9
https://bugs.webkit.org/show_bug.cgi?id=124379

Reviewed by Dan Bernstein.

* History/WebHistory.mm:
(getDayBoundaries):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoImplement raw format for WebCrypto key export
ap@apple.com [Thu, 14 Nov 2013 21:44:25 +0000 (21:44 +0000)]
Implement raw format for WebCrypto key export
https://bugs.webkit.org/show_bug.cgi?id=124376

Reviewed by Anders Carlsson.

Source/WebCore:

Tests: crypto/subtle/aes-export-key.html
       crypto/subtle/hmac-export-key.html

A CryptoKey just exports its native CryptoKeyData, which will also work nicely for
JWK format soon. For spki and pkcs8, we'll need to figure out the best way to
utilize platform library support for ASN.1, but we are not there yet.

* bindings/js/JSSubtleCryptoCustom.cpp:
(WebCore::JSSubtleCrypto::exportKey):
* crypto/CryptoKey.h:
* crypto/SubtleCrypto.idl:
* crypto/keys/CryptoKeyAES.cpp:
(WebCore::CryptoKeyAES::exportData):
* crypto/keys/CryptoKeyAES.h:
* crypto/keys/CryptoKeyHMAC.cpp:
(WebCore::CryptoKeyHMAC::exportData):
* crypto/keys/CryptoKeyHMAC.h:

* crypto/keys/CryptoKeyRSA.h:
* crypto/mac/CryptoKeyRSAMac.cpp:
(WebCore::CryptoKeyRSA::exportData):
Added a dummy implementation for RSA.

LayoutTests:

* crypto/subtle/aes-export-key-expected.txt: Added.
* crypto/subtle/aes-export-key.html: Added.
* crypto/subtle/hmac-export-key-expected.txt: Added.
* crypto/subtle/hmac-export-key.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Cocoa] WKAction keys are not exported
mitz@apple.com [Thu, 14 Nov 2013 21:40:53 +0000 (21:40 +0000)]
[Cocoa] WKAction keys are not exported
https://bugs.webkit.org/show_bug.cgi?id=124378

Reviewed by Anders Carlsson.

* UIProcess/API/mac/WKBrowsingContextController.mm: Made the keys constant pointers.
* UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h: Exported the keys.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Simply generated domain dispatch methods for domains with few commands
commit-queue@webkit.org [Thu, 14 Nov 2013 21:30:48 +0000 (21:30 +0000)]
Web Inspector: Simply generated domain dispatch methods for domains with few commands
https://bugs.webkit.org/show_bug.cgi?id=124374

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-11-14
Reviewed by Timothy Hatcher.

* inspector/CodeGeneratorInspector.py:
(Generator.go):
(Generator.process_command):
* inspector/CodeGeneratorInspectorStrings.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Shapes] Accept the new <box> value for shape-outside
betravis@adobe.com [Thu, 14 Nov 2013 21:26:53 +0000 (21:26 +0000)]
[CSS Shapes] Accept the new <box> value for shape-outside
https://bugs.webkit.org/show_bug.cgi?id=124227

Reviewed by David Hyatt.

Source/WebCore:

The shape-outside property can now be set to the box values [margin/border/padding/content]-box.
This patch adds the parsing code required to accept the new values, and the layout code
to create a rectangle shape that has the size and position of the appropriate box.

Tests: fast/shapes/shape-outside-floats/shape-outside-boxes-001.html
       fast/shapes/shape-outside-floats/shape-outside-boxes-002.html
       fast/shapes/shape-outside-floats/shape-outside-boxes-003.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue): Output the new box values.
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue): Accept the new box values.
* css/CSSValueKeywords.in: Add margin-box value.
* css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyShape::applyValue): Accept the new box values.
* rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::borderLogicalWidth): Added new utility methods to help
with box sizing.
(WebCore::RenderBoxModelObject::borderLogicalHeight): Ditto.
(WebCore::RenderBoxModelObject::paddingLogicalWidth): Ditto.
(WebCore::RenderBoxModelObject::paddingLogicalHeight): Ditto.
* rendering/shapes/Shape.cpp:
(WebCore::Shape::createShape): You can create a shape from a box's dimensions, rather
than always using a BasicShape or RasterShape value.
* rendering/shapes/Shape.h:
* rendering/shapes/ShapeInfo.cpp:
(WebCore::::computedShape): Create the appropriate shape based on the box values.
* rendering/shapes/ShapeInfo.h:
(WebCore::ShapeInfo::setShapeSize): Adjust for the box size when using a box value.
(WebCore::ShapeInfo::logicalTopOffset): Ditto.
(WebCore::ShapeInfo::logicalLeftOffset): Ditto.
* rendering/shapes/ShapeInsideInfo.cpp:
(WebCore::ShapeInsideInfo::isEnabledFor): Enable for the box values.
* rendering/shapes/ShapeOutsideInfo.cpp:
(WebCore::ShapeOutsideInfo::isEnabledFor): Disable for shape-inside.
* rendering/style/ShapeValue.h:
(WebCore::ShapeValue::createBoxValue): Create the appropriate shape value for a box.
(WebCore::ShapeValue::box): Return the box value for this ShapeValue.
(WebCore::ShapeValue::ShapeValue): Create a ShapeValue from a box value.

LayoutTests:

Test the different box values with different writing modes.

* fast/shapes/parsing/parsing-shape-inside-expected.html: Adding box values as invalid.
* fast/shapes/parsing/parsing-shape-inside.html: Ditto.
* fast/shapes/parsing/parsing-shape-outside-expected.html: Adding box values as valid.
* fast/shapes/parsing/parsing-shape-outside.html: Ditto.
* fast/shapes/shape-outside-floats/shape-outside-boxes-001-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-boxes-001.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-boxes-002-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-boxes-002.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-boxes-003-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-boxes-003.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFlaky Test: media/video-fast-seek.html
jer.noble@apple.com [Thu, 14 Nov 2013 21:26:06 +0000 (21:26 +0000)]
Flaky Test: media/video-fast-seek.html
https://bugs.webkit.org/show_bug.cgi?id=124298

Reviewed by Eric Carlson.

Don't check for the precise results of currentTime, as MediaTime -> double
rounding will occasionally result in errors.

* media/video-fast-seek-expected.txt:
* media/video-fast-seek.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoStop using deprecated NSPropertyListSerialization methods
andersca@apple.com [Thu, 14 Nov 2013 21:14:40 +0000 (21:14 +0000)]
Stop using deprecated NSPropertyListSerialization methods
https://bugs.webkit.org/show_bug.cgi?id=124377

Reviewed by Mark Rowe.

* History/WebHistory.mm:
(-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
* Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::NetscapePluginHostManager::spawnPluginHost):
(WebKit::NetscapePluginHostManager::instantiatePlugin):
* Plugins/Hosted/NetscapePluginHostProxy.mm:
(WKPCIdentifierInfo):
* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::enumerate):
(WebKit::NetscapePluginInstanceProxy::marshalValue):
(WebKit::NetscapePluginInstanceProxy::marshalValues):
(WebKit::NetscapePluginInstanceProxy::demarshalValue):
(WebKit::NetscapePluginInstanceProxy::demarshalValues):
* Plugins/Hosted/ProxyInstance.mm:
(WebKit::ProxyInstance::getPropertyNames):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agofullscreen/anonymous-block-merge-crash.html often times out in WebKit1
timothy_horton@apple.com [Thu, 14 Nov 2013 20:13:39 +0000 (20:13 +0000)]
fullscreen/anonymous-block-merge-crash.html often times out in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=124318

* platform/mac/TestExpectations:
Used the wrong kind of failure for a notifyDone timeout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRubber-stamped by Tim Horton.
bdakin@apple.com [Thu, 14 Nov 2013 20:12:25 +0000 (20:12 +0000)]
Rubber-stamped by Tim Horton.

Post-checkin review comment! StickToViewportBounds sounds better and more accurate
than StickToWindowBounds.

* platform/ScrollTypes.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed build failure; update MediaPlayerPrivateAVFFoundationCF::seekToTime after...
bfulgham@apple.com [Thu, 14 Nov 2013 20:10:36 +0000 (20:10 +0000)]
Unreviewed build failure; update MediaPlayerPrivateAVFFoundationCF::seekToTime after r159208.

After r159208, seekToTime takes tolerance parameters.

Patch by Jer Noble <jer.noble@apple.com> on 2013-11-13

* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::MediaPlayerPrivateAVFoundationCF::seekToTime):
(WebCore::AVFWrapper::seekToTime):
* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agohttp/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html is slow, freque...
timothy_horton@apple.com [Thu, 14 Nov 2013 20:05:48 +0000 (20:05 +0000)]
http/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html is slow, frequently > 30 second timeout
https://bugs.webkit.org/show_bug.cgi?id=124373

* platform/mac/TestExpectations:
Mark test as slow on Mountain Lion Release bot.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd a new mode where fixed elements don't constrain their positions during a
bdakin@apple.com [Thu, 14 Nov 2013 20:03:59 +0000 (20:03 +0000)]
Add a new mode where fixed elements don't constrain their positions during a
rubber band
https://bugs.webkit.org/show_bug.cgi?id=124260

Reviewed by Tim Horton.

This patch adds a new enum called ScrollBehaviorForFixedElements, which has
two values, StickToDocumentBounds or StickToWindowBounds. StickToDocumentBounds
corresponds to our current behavior, where fixed elements constrain
their positions during a rubber-band so that they stay stuck to the document.
The new mode, StickToWindowBounds, will cause fixed elements to always stay
fixed relative to the window.

scrollOffsetForFixedPosition() now takes a new parameter for the fixed behavior
so that it knows whether or not to constrain the position.
* page/FrameView.cpp:
(WebCore::FrameView::scrollOffsetForFixedPosition):

Right now, just return StickToDocumentBounds and retain existing behavior.
(WebCore::FrameView::scrollBehaviorForFixedElements):
* page/FrameView.h:

The scrolling thread needs to know about the fixed element scroll behavior,
so this code makes ScrollingStateScrollingNodes keep track of that
information to pass over to the scrolling thread.
* page/scrolling/ScrollingStateScrollingNode.cpp:
(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode):
(WebCore::ScrollingStateScrollingNode::setScrollBehaviorForFixedElements):
* page/scrolling/ScrollingStateScrollingNode.h:
* page/scrolling/ScrollingTreeScrollingNode.cpp:
(WebCore::ScrollingTreeScrollingNode::ScrollingTreeScrollingNode):
(WebCore::ScrollingTreeScrollingNode::updateBeforeChildren):
* page/scrolling/ScrollingTreeScrollingNode.h:
(WebCore::ScrollingTreeScrollingNode::scrollBehaviorForFixedElements):
* page/scrolling/mac/ScrollingCoordinatorMac.h:
* page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::frameViewRootLayerDidChange):
(WebCore::ScrollingCoordinatorMac::setScrollBehaviorForFixedElementsForNode):
* page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::setScrollLayerPosition):

Here is the new enum.
* platform/ScrollTypes.h:

Another place where we only want to constrain scroll position if that is the
mode we are in.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::customPositionForVisibleRectComputation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Mac] HMAC sign/verify crashes when key is empty
ap@apple.com [Thu, 14 Nov 2013 19:56:37 +0000 (19:56 +0000)]
[Mac] HMAC sign/verify crashes when key is empty
https://bugs.webkit.org/show_bug.cgi?id=124372

Reviewed by Sam Weinig.

Source/WebCore:

Test: crypto/subtle/hmac-sign-verify-empty-key.html

* crypto/mac/CryptoAlgorithmHMACMac.cpp: (WebCore::calculateSignature): Give it
a non-null pointer then.

LayoutTests:

* crypto/subtle/hmac-sign-verify-empty-key-expected.txt: Added.
* crypto/subtle/hmac-sign-verify-empty-key.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION (r159276): Fix lots of crashes for arm_traditional architecture.
msaboff@apple.com [Thu, 14 Nov 2013 19:43:08 +0000 (19:43 +0000)]
REGRESSION (r159276): Fix lots of crashes for arm_traditional architecture.
https://bugs.webkit.org/show_bug.cgi?id=124365

Reviewed by Oliver Hunt.

Crashes were caused by a mixup between regular registers and temporary registers in ARM_EXTRA_GPRS.

* llint/LowLevelInterpreter32_64.asm: Warning, t3 != a3. It's safer to use an implementation using aX
registers like the MIPS one for cCallX macros.
* offlineasm/arm.rb: Rearrange ARM_EXTRA_GPRS according to the new register distribution in LLINT.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove duplicate entry.
andersca@apple.com [Thu, 14 Nov 2013 19:16:31 +0000 (19:16 +0000)]
Remove duplicate entry.

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoImplement RSASSA-PKCS1-v1_5 sign/verify
ap@apple.com [Thu, 14 Nov 2013 19:00:58 +0000 (19:00 +0000)]
Implement RSASSA-PKCS1-v1_5 sign/verify
https://bugs.webkit.org/show_bug.cgi?id=124335

Build fix.

* crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAX: Calling NSAccessibilityColumnsAttribute and NSAccessibilityRowsAttribute simply...
samuel_white@apple.com [Thu, 14 Nov 2013 18:57:11 +0000 (18:57 +0000)]
AX: Calling NSAccessibilityColumnsAttribute and NSAccessibilityRowsAttribute simply to get column/row count can be very expensive.
https://bugs.webkit.org/show_bug.cgi?id=124293

Reviewed by Chris Fleizach.

Source/WebCore:

Added ability to get accessibility table column or row count without fetching all columns or rows.

Test: platform/mac/accessibility/table-column-and-row-count.html

* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

LayoutTests:

Added test to ensure NSAccessibilityColumnsAttribute and NSAccessibilityRowsAttribute
behave as expected. Also updated existing table tests to reflect this additional API.

* platform/mac/accessibility/table-column-and-row-count-expected.txt: Added.
* platform/mac/accessibility/table-column-and-row-count.html: Added.
* platform/mac/accessibility/table-detection-expected.txt:
* platform/mac/accessibility/table-with-rules-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoVersioning.
lforschler@apple.com [Thu, 14 Nov 2013 18:51:45 +0000 (18:51 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoImplement RSASSA-PKCS1-v1_5 sign/verify
ap@apple.com [Thu, 14 Nov 2013 18:26:36 +0000 (18:26 +0000)]
Implement RSASSA-PKCS1-v1_5 sign/verify
https://bugs.webkit.org/show_bug.cgi?id=124335

Reviewed by Sam Weinig.

Source/WebCore:

Test: crypto/subtle/rsassa-pkcs1-v1_5-sign-verify.html

* WebCore.xcodeproj/project.pbxproj: Added new files, removed Mac SHA algorithm files.

* crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:
(WebCore::getCommonCryptoDigestAlgorithm):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::sign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::verify):
Implemented. These take two steps, first a digest is computed, and then it's signed.

* crypto/CryptoDigest.h: Added.
* crypto/mac/CryptoDigestMac.cpp: Added.
(WebCore::CryptoDigest::CryptoDigest):
(WebCore::CryptoDigest::~CryptoDigest):
(WebCore::CryptoDigest::create):
(WebCore::CryptoDigest::addBytes):
(WebCore::CryptoDigest::computeHash):
Added a cross-platform interface and Mac implementation to compute a digest. It
should be possible to use it outside WebCrypto if we need to (perhaps even merge
with  WTF SHA-1 class).
The Mac implementation is kind of ugly, but at least it encapsulates the ugliness.

* crypto/algorithms/CryptoAlgorithmSHA1.cpp: (WebCore::CryptoAlgorithmSHA1::digest):
* crypto/algorithms/CryptoAlgorithmSHA224.cpp: (WebCore::CryptoAlgorithmSHA224::digest):
* crypto/algorithms/CryptoAlgorithmSHA256.cpp: (WebCore::CryptoAlgorithmSHA256::digest):
* crypto/algorithms/CryptoAlgorithmSHA384.cpp: (WebCore::CryptoAlgorithmSHA384::digest):
* crypto/algorithms/CryptoAlgorithmSHA512.cpp: (WebCore::CryptoAlgorithmSHA512::digest):
* crypto/mac/CryptoAlgorithmSHA1Mac.cpp: Removed.
* crypto/mac/CryptoAlgorithmSHA224Mac.cpp: Removed.
* crypto/mac/CryptoAlgorithmSHA256Mac.cpp: Removed.
* crypto/mac/CryptoAlgorithmSHA384Mac.cpp: Removed.
* crypto/mac/CryptoAlgorithmSHA512Mac.cpp: Removed.
These are all cross-platform now.

LayoutTests:

* crypto/subtle/rsassa-pkcs1-v1_5-sign-verify-expected.txt: Added.
* crypto/subtle/rsassa-pkcs1-v1_5-sign-verify.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Shapes] Empty polygons with non-zero shape-padding cause an ASSERT crash
hmuller@adobe.com [Thu, 14 Nov 2013 18:21:29 +0000 (18:21 +0000)]
[CSS Shapes] Empty polygons with non-zero shape-padding cause an ASSERT crash
https://bugs.webkit.org/show_bug.cgi?id=124324

Reviewed by Andreas Kling.

Source/WebCore:

PolygonShape::shapePaddingBounds() and PolygonShape::shapeMarginBounds() no
longer attempt to compute a new FloatPolygon when the original is empty, i.e.
when it has less than three vertices.

Tests: fast/shapes/shape-inside/shape-inside-empty-polygon-crash.html
       fast/shapes/shape-outside-floats/shape-outside-floats-empty-polygon-crash.html

* rendering/shapes/PolygonShape.cpp:
(WebCore::PolygonShape::shapePaddingBounds): Don't compute a padding FloatPolygon if the original polygon is empty.
(WebCore::PolygonShape::shapeMarginBounds): Don't compute a margin FloatPolygon if the original polygon is empty.

LayoutTests:

* fast/shapes/shape-inside/shape-inside-empty-polygon-crash-expected.txt: Added.
* fast/shapes/shape-inside/shape-inside-empty-polygon-crash.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-empty-polygon-crash-expected.txt: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-empty-polygon-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION (r159276): rbp register overwritten in Win 64 version of callToJavascript...
msaboff@apple.com [Thu, 14 Nov 2013 18:13:17 +0000 (18:13 +0000)]
REGRESSION (r159276): rbp register overwritten in Win 64 version of callToJavascript stub
https://bugs.webkit.org/show_bug.cgi?id=124361

Reviewed by Oliver Hunt.

Swapped operand ordering to: mov rax, rbp

* jit/JITStubsMSVC64.asm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Cleaner Backend Method Calling Code Generation
commit-queue@webkit.org [Thu, 14 Nov 2013 17:45:37 +0000 (17:45 +0000)]
Web Inspector: Cleaner Backend Method Calling Code Generation
https://bugs.webkit.org/show_bug.cgi?id=124333

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-11-14
Reviewed by Timothy Hatcher.

No change in functionality, just improved generated code.

* inspector/CodeGeneratorInspector.py:
(Generator.process_command):
* inspector/CodeGeneratorInspectorStrings.py:
* inspector/InspectorBackendDispatcher.cpp:
* inspector/InspectorBackendDispatcher.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION (r159276): Fix lots of crashes for sh4 architecture.
commit-queue@webkit.org [Thu, 14 Nov 2013 16:52:48 +0000 (16:52 +0000)]
REGRESSION (r159276): Fix lots of crashes for sh4 architecture.
https://bugs.webkit.org/show_bug.cgi?id=124347

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-14
Reviewed by Michael Saboff.

Since r159276, we have (t4 == a0 == r4) and (t5 == a1 == r5) in LLINT for sh4.
This leads to argument register trampling in cCallX macros, especially with cCall2
macro when arg1 == t4.

* llint/LowLevelInterpreter32_64.asm: Use a new "setargs" pseudo-op to setup arguments for sh4.
* offlineasm/instructions.rb:
* offlineasm/sh4.rb: Lower "setargs" pseudo-op to setup argument registers and prevent register trampling issues.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[ATK] Change WKTR/DRT AX methods to use nullptr
commit-queue@webkit.org [Thu, 14 Nov 2013 16:49:29 +0000 (16:49 +0000)]
[ATK] Change WKTR/DRT AX methods to use nullptr
https://bugs.webkit.org/show_bug.cgi?id=124352

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-11-14
Reviewed by Anders Carlsson.

Change WKTR/DRT accessibility related methods to use nullptr.

* DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
(AccessibilityController::AccessibilityController):
(AccessibilityController::elementAtPoint):
(AccessibilityController::removeNotificationListener):
(AccessibilityController::childElementById):
* DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.cpp:
(AccessibilityNotificationHandler::AccessibilityNotificationHandler):
* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::elementAtPoint):
(AccessibilityUIElement::linkedUIElementAtIndex):
(AccessibilityUIElement::getChildAtIndex):
(AccessibilityUIElement::titleUIElement):
(AccessibilityUIElement::parentElement):
(AccessibilityUIElement::subrole):
(AccessibilityUIElement::roleDescription):
(AccessibilityUIElement::orientation):
(AccessibilityUIElement::ariaDropEffects):
(AccessibilityUIElement::uiElementForSearchPredicate):
(AccessibilityUIElement::cellForColumnAndRow):
(AccessibilityUIElement::disclosedRowAtIndex):
(AccessibilityUIElement::ariaOwnsElementAtIndex):
(AccessibilityUIElement::ariaFlowToElementAtIndex):
(AccessibilityUIElement::selectedRowAtIndex):
(AccessibilityUIElement::rowAtIndex):
(AccessibilityUIElement::disclosedByRow):
(AccessibilityUIElement::removeNotificationListener):
(AccessibilityUIElement::classList):
* WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
(WTR::AccessibilityController::logAccessibilityEvents):
(WTR::AccessibilityController::resetToConsistentState):
(WTR::childElementById):
(WTR::AccessibilityController::accessibleElementById):
(WTR::AccessibilityController::removeNotificationListener):
* WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
(WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
(WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::elementAtPoint):
(WTR::AccessibilityUIElement::childAtIndex):
(WTR::AccessibilityUIElement::linkedUIElementAtIndex):
(WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
(WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
(WTR::AccessibilityUIElement::disclosedRowAtIndex):
(WTR::AccessibilityUIElement::rowAtIndex):
(WTR::AccessibilityUIElement::selectedChildAtIndex):
(WTR::AccessibilityUIElement::selectedRowAtIndex):
(WTR::AccessibilityUIElement::titleUIElement):
(WTR::AccessibilityUIElement::parentElement):
(WTR::AccessibilityUIElement::disclosedByRow):
(WTR::AccessibilityUIElement::uiElementAttributeValue):
(WTR::AccessibilityUIElement::orientation):
(WTR::AccessibilityUIElement::uiElementForSearchPredicate):
(WTR::AccessibilityUIElement::cellForColumnAndRow):
(WTR::AccessibilityUIElement::horizontalScrollbar):
(WTR::AccessibilityUIElement::verticalScrollbar):
(WTR::AccessibilityUIElement::removeNotificationListener):
(WTR::AccessibilityUIElement::textMarkerRangeForElement):
(WTR::AccessibilityUIElement::previousTextMarker):
(WTR::AccessibilityUIElement::nextTextMarker):
(WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
(WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
(WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
(WTR::AccessibilityUIElement::endTextMarkerForBounds):
(WTR::AccessibilityUIElement::startTextMarkerForBounds):
(WTR::AccessibilityUIElement::textMarkerForPoint):
(WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
(WTR::AccessibilityUIElement::textMarkerForIndex):
(WTR::AccessibilityUIElement::supportedActions):
(WTR::AccessibilityUIElement::pathDescription):
(WTR::AccessibilityUIElement::mathPostscriptsDescription):
(WTR::AccessibilityUIElement::mathPrescriptsDescription):
(WTR::AccessibilityUIElement::classList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Popovers may shrink unnecessarily
graouts@apple.com [Thu, 14 Nov 2013 16:03:30 +0000 (16:03 +0000)]
Web Inspector: Popovers may shrink unnecessarily
https://bugs.webkit.org/show_bug.cgi?id=124350

Reviewed by Timothy Hatcher.

Because we always get the intersection of the preferred frame and the container frame to
ensure the popover fits within its container based on a preferred frame that would place
the arrow within the center of the attachment edge, we get in situations where we may
shrink the popover instead of shifting it to fit within the container frame. We now first
shift the preferred frame before getting its intersection with the container frame to
avoid such situations.

* UserInterface/Popover.js:
(WebInspector.Popover.prototype._bestMetricsForEdge):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agorun-perf-tests should warn loudly if you're using a Debug build.
commit-queue@webkit.org [Thu, 14 Nov 2013 15:38:12 +0000 (15:38 +0000)]
run-perf-tests should warn loudly if you're using a Debug build.
https://bugs.webkit.org/show_bug.cgi?id=105236

Patch by Éva Balázsfalvi <balazsfalvi.eva@stud.u-szeged.hu> on 2013-11-14
Reviewed by Csaba Osztrogonác.

* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner.run):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUse [ImplementedAs=defaultStatus] for Window.defaultstatus
seokju@webkit.org [Thu, 14 Nov 2013 13:48:09 +0000 (13:48 +0000)]
Use [ImplementedAs=defaultStatus] for Window.defaultstatus
https://bugs.webkit.org/show_bug.cgi?id=124334

Reviewed by Christophe Dumez.

No new tests, this is just refactoring.

Use [ImplementedAs=defaultStatus] for Window.defaultstatus
and remove unnecessary code from DOMWindow.
Because 'defaultstatus' is an alias of defaultStatus.

* page/DOMWindow.h:
* page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix build for sh4 architectures (broken since r159276).
commit-queue@webkit.org [Thu, 14 Nov 2013 13:28:05 +0000 (13:28 +0000)]
Fix build for sh4 architectures (broken since r159276).
https://bugs.webkit.org/show_bug.cgi?id=124344

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-14
Reviewed by Csaba Osztrogonác.

* offlineasm/sh4.rb: There is no fp alias for r14 register for sh4.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix Tools/Scripts/webkitpy/port/factory.py --help to display which configuration...
commit-queue@webkit.org [Thu, 14 Nov 2013 12:50:07 +0000 (12:50 +0000)]
Fix Tools/Scripts/webkitpy/port/factory.py --help to display which configuration is default
https://bugs.webkit.org/show_bug.cgi?id=124143

Patch by Éva Balázsfalvi <balazsfalvi.eva@stud.u-szeged.hu> on 2013-11-14
Reviewed by Csaba Osztrogonác.

* Scripts/webkitpy/port/factory.py:
(configuration_options):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoGenerate toSVGPolyline|gonElement() to replace static_cast<>
gyuyoung.kim@samsung.com [Thu, 14 Nov 2013 11:25:40 +0000 (11:25 +0000)]
Generate toSVGPolyline|gonElement() to replace static_cast<>
https://bugs.webkit.org/show_bug.cgi?id=124341

Reviewed by Andreas Kling.

toSVGFoo() supports more plenty helper functions. So, toSVGFoo() needs
to be used instead of static_cast<>.

Additionally, cleanup other static_cast<> as well.

No new tests, no behavior changes.

* rendering/svg/SVGPathData.cpp:
(WebCore::updatePathFromEllipseElement):
(WebCore::updatePathFromLineElement):
(WebCore::updatePathFromPolygonElement):
(WebCore::updatePathFromPolylineElement):
* svg/SVGPolygonElement.h:
* svg/SVGPolylineElement.h:
* svg/svgtags.in: Add *generateTypeHelpers* keyword to polygon, polyline

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Layout tests with text areas need to be rebaselined.
commit-queue@webkit.org [Thu, 14 Nov 2013 11:07:25 +0000 (11:07 +0000)]
[EFL] Layout tests with text areas need to be rebaselined.
https://bugs.webkit.org/show_bug.cgi?id=124337

Unreviewed, EFL gatdening.

EFL text areas rebaselined after r129492.

Patch by Sun-woo Nam <sunny.nam@samsung.com> on 2013-11-14

* platform/efl/TestExpectations:
* platform/efl/fast/forms/basic-textareas-expected.txt:
* platform/efl/fast/forms/basic-textareas-quirks-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFontDescription copies should share families list, not duplicate it.
akling@apple.com [Thu, 14 Nov 2013 11:01:42 +0000 (11:01 +0000)]
FontDescription copies should share families list, not duplicate it.
<https://webkit.org/b/124338>

Source/WebCore:

Turn FontDescription::m_families into a RefCountedArray<AtomicString>
instead of a Vector<AtomicString, 1>. This allows FontDescription to
share the families list between copies, instead of each object having
its own Vector.

Also, FontDescription itself shrinks by 16 bytes.

Reviewed by Antti Koivisto.

Source/WTF:

Add RefCountedArray::operator==.

Reviewed by Antti Koivisto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WK2] Move Coordinated Graphics related code out of DrawingAreaProxy
ryuan.choi@samsung.com [Thu, 14 Nov 2013 09:12:12 +0000 (09:12 +0000)]
[WK2] Move Coordinated Graphics related code out of DrawingAreaProxy
https://bugs.webkit.org/show_bug.cgi?id=124328

Reviewed by Andreas Kling.

Refactored for DrawingAreaProxy not to include Coordinated Graphics specific code.

* PlatformEfl.cmake:
* UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp: Moved from DrawingAreaProxy.cpp.
(WebKit::CoordinatedDrawingAreaProxy::updateViewport):
(WebKit::CoordinatedDrawingAreaProxy::contentsRect):
* UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.h: Ditto.
(WebKit::CoordinatedDrawingAreaProxy::coordinatedLayerTreeHostProxy): Refactored to return reference instead of pointer.
(WebKit::CoordinatedDrawingAreaProxy::viewportVisibleRect):
(WebKit::CoordinatedDrawingAreaProxy::page):
* UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:
(WebKit::CoordinatedLayerTreeHostProxy::CoordinatedLayerTreeHostProxy):
* UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
* UIProcess/CoordinatedGraphics/PageViewportController.cpp:
Renamed from Source/WebKit2/UIProcess/PageViewportController.cpp because it depends on Coordinated Graphics.
(WebKit::fuzzyCompare):
(WebKit::PageViewportController::PageViewportController):
(WebKit::PageViewportController::innerBoundedViewportScale):
(WebKit::PageViewportController::outerBoundedViewportScale):
(WebKit::PageViewportController::deviceScaleFactor):
(WebKit::isIntegral):
(WebKit::PageViewportController::pixelAlignedFloatPoint):
(WebKit::PageViewportController::boundContentsPositionAtScale):
(WebKit::PageViewportController::boundContentsPosition):
(WebKit::PageViewportController::didCommitLoad):
(WebKit::PageViewportController::didChangeContentsSize):
(WebKit::PageViewportController::didRenderFrame):
(WebKit::PageViewportController::pageTransitionViewportReady):
(WebKit::PageViewportController::pageDidRequestScroll):
(WebKit::PageViewportController::didChangeViewportSize):
(WebKit::PageViewportController::didChangeContentsVisibility):
(WebKit::PageViewportController::syncVisibleContents): Added cast to access CoordinatedDrawingAreaProxy method.
(WebKit::PageViewportController::didChangeViewportAttributes):
(WebKit::PageViewportController::visibleContentsSize):
(WebKit::PageViewportController::applyScaleAfterRenderingContents):
(WebKit::PageViewportController::applyPositionAfterRenderingContents):
(WebKit::PageViewportController::updateMinimumScaleToFit):
* UIProcess/CoordinatedGraphics/PageViewportController.h:
Renamed from Source/WebKit2/UIProcess/PageViewportController.cpp because it depends on Coordinated Graphics.
(WebKit::PageViewportController::~PageViewportController):
(WebKit::PageViewportController::hadUserInteraction):
(WebKit::PageViewportController::allowsUserScaling):
(WebKit::PageViewportController::contentsLayoutSize):
(WebKit::PageViewportController::minimumScale):
(WebKit::PageViewportController::maximumScale):
(WebKit::PageViewportController::currentScale):
(WebKit::PageViewportController::setHadUserInteraction):
* UIProcess/CoordinatedGraphics/WebView.cpp: Added some casts to access CoordinatedDrawingAreaProxy methods.
(WebKit::WebView::coordinatedGraphicsScene): Simplified code using reference.
(WebKit::WebView::updateViewportSize):
* UIProcess/DrawingAreaProxy.cpp: Removed Coordinated Graphics macro and related codes.
* UIProcess/DrawingAreaProxy.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoIntroduce FILTER_TYPE_CASTS for child filter class
gyuyoung.kim@samsung.com [Thu, 14 Nov 2013 09:04:34 +0000 (09:04 +0000)]
Introduce FILTER_TYPE_CASTS for child filter class
https://bugs.webkit.org/show_bug.cgi?id=124332

Reviewed by Andreas Kling.

To use TYPE_CASTS_BASE, define FILTER_TYPE_CASTS macro. Thanks to
it, static_cast<SVGFilter*> can be replaced by toSVGFilter().

No new tests, no behavior changes.

* platform/graphics/filters/Filter.h:
    Add isSVGFilter() to check if casting object is SVGFilter object.
(WebCore::Filter::isSVGFilter):
* rendering/svg/RenderSVGResourceFilterPrimitive.cpp:
(WebCore::RenderSVGResourceFilterPrimitive::determineFilterPrimitiveSubregion):
* svg/graphics/filters/SVGFEImage.cpp:
(WebCore::FEImage::determineAbsolutePaintRect):
(WebCore::FEImage::platformApplySoftware):
* svg/graphics/filters/SVGFilter.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoChange callToJavaScript thunk into an offline assembled stub
msaboff@apple.com [Thu, 14 Nov 2013 07:39:30 +0000 (07:39 +0000)]
Change callToJavaScript thunk into an offline assembled stub
https://bugs.webkit.org/show_bug.cgi?id=124251

Reviewed by Geoffrey Garen.

Changed callToJavaScript and throwNotCaught into stubs generated by the offline assembler.
Added popCalleeSaves and pushCalleeSaves pseudo ops to the offline assembler to handle
the saving and restoring of callee save registers.  Fixed callFrameRegister differences
between arm traditional (r11) and arm Thumb2 (r7) in GPRInfo.h.  Also fixed implementation
of pop & push in arm.rb.

Since the offline assembler and therefore the LLInt don't work on Windows, the Windows stubs
are handled as inline assembly in JITStubsX86.h and JITStubsMSVC64.asm.

* dfg/DFGDriver.cpp:
(JSC::DFG::compileImpl):
* jit/GPRInfo.h:
(JSC::GPRInfo::toIndex):
(JSC::GPRInfo::debugName):
* jit/JITCode.cpp:
(JSC::JITCode::execute):
* jit/JITExceptions.cpp:
(JSC::genericUnwind):
* jit/JITStubs.h:
* jit/JITStubsMSVC64.asm:
* jit/JITStubsX86.h:
* jit/ThunkGenerators.cpp:
* jit/ThunkGenerators.h:
* llint/LLIntThunks.h:
* llint/LowLevelInterpreter.asm:
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:
* offlineasm/arm.rb:
* offlineasm/arm64.rb:
* offlineasm/instructions.rb:
* offlineasm/mips.rb:
* offlineasm/registers.rb:
* offlineasm/sh4.rb:
* offlineasm/x86.rb:
* runtime/VM.cpp:
(JSC::VM::VM):
* runtime/VM.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSource/WebCore: Blob constructor accepts a sequence (array-like object) as first...
commit-queue@webkit.org [Thu, 14 Nov 2013 05:46:10 +0000 (05:46 +0000)]
Source/WebCore: Blob constructor accepts a sequence (array-like object) as first arg.
https://bugs.webkit.org/show_bug.cgi?id=124175

Patch by Victor Costan <costan@gmail.com> on 2013-11-13
Reviewed by Christophe Dumez.

Added test cases to fast/files/script-tests/blob-constructor.js.

* bindings/js/JSBlobCustom.cpp: Make the constructor work with sequences.
(WebCore::JSBlobConstructor::constructJSBlob):
* bindings/js/JSDOMBinding.h:
(WebCore::toJSSequence): Slightly better error message when conversion fails.
(WebCore::toJS): Whitespace.
(WebCore::jsArray): Whitespace.

LayoutTests: Blob constructor accepts a sequence (array-like object) as first arg.
https://bugs.webkit.org/show_bug.cgi?id=124175

Patch by Victor Costan <costan@gmail.com> on 2013-11-13
Reviewed by Christophe Dumez.

* crypto/subtle/argument-conversion-expected.txt: Updated sequence error expectations.
* fast/dom/Window/window-postmessage-args-expected.txt: Updated sequence error expectations.
* fast/events/constructors/message-event-constructor-expected.txt: Updated sequence error expectations.
* fast/events/message-port-multi-expected.txt: Updated sequence error expectations.
* fast/files/blob-constructor-expected.txt: Updated error text and added expectations.
* fast/files/script-tests/blob-constructor.js: Added sequence test cases.
* fast/workers/worker-context-multi-port-expected.txt: Updated sequence error expectations.
* fast/workers/worker-multi-port-expected.txt: Updated sequence error expectations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Layout tests with css3 selectors3 properties need to be rebaselined.
commit-queue@webkit.org [Thu, 14 Nov 2013 05:06:00 +0000 (05:06 +0000)]
[EFL] Layout tests with css3 selectors3 properties need to be rebaselined.
https://bugs.webkit.org/show_bug.cgi?id=124266

Unreviewed, EFL gardening.

EFL css3 rebaselined after r111644.

Patch by Sun-woo Nam <sunny.nam@samsung.com> on 2013-11-13

* platform/efl-wk2/TestExpectations:
* platform/efl/css3/selectors3/html/css3-modsel-1-expected.txt:
* platform/efl/css3/selectors3/xhtml/css3-modsel-1-expected.txt:
* platform/efl/css3/selectors3/xml/css3-modsel-1-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed rollout of r159271, broke Mountain Lion build.
joepeck@webkit.org [Thu, 14 Nov 2013 03:08:27 +0000 (03:08 +0000)]
Unreviewed rollout of r159271, broke Mountain Lion build.

Source/WebKit:

* WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

* History/WebHistory.h:
* History/WebHistory.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: InspectorBackendDispatcher improvements
joepeck@webkit.org [Thu, 14 Nov 2013 03:01:16 +0000 (03:01 +0000)]
Web Inspector: InspectorBackendDispatcher improvements
https://bugs.webkit.org/show_bug.cgi?id=124330

Reviewed by Timothy Hatcher.

* inspector/InspectorBackendDispatcher.cpp:
(WebCore::InspectorBackendDispatcher::sendResponse):
(WebCore::InspectorBackendDispatcher::reportProtocolError):
* inspector/InspectorBackendDispatcher.h:
(WebCore::InspectorSupplementalBackendDispatcher::InspectorSupplementalBackendDispatcher):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDeprecate WebHistory methods that use NSCalendarDate
andersca@apple.com [Thu, 14 Nov 2013 02:58:05 +0000 (02:58 +0000)]
Deprecate WebHistory methods that use NSCalendarDate
https://bugs.webkit.org/show_bug.cgi?id=124329
<rdar://problem/15441122>

Reviewed by Mark Rowe.

Source/WebKit:

* WebKit.xcodeproj/project.pbxproj:
Add a shell script phase that uses unifdef to remove the __NSd_10_9 #define from
WebHistory on Mavericks.

Source/WebKit/mac:

* History/WebHistory.h:
Add NS_DEPRECATED_MAC to orderedLastVisitedDays and orderedItemsLastVisitedOnDay:.
In order to not break the Mountain Lion build, define __NSd_10_9 if necessary.

* History/WebHistory.mm:
Ignore deprecation warnings in methods where NSCalendarDate is used.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed Windows Build Fix after r159268.
joepeck@webkit.org [Thu, 14 Nov 2013 02:39:10 +0000 (02:39 +0000)]
Unreviewed Windows Build Fix after r159268.

Missed adding InspectorBackendDispatcher.h and cpp to the Windows build.

* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRename some ImmutableArray leftovers
commit-queue@webkit.org [Thu, 14 Nov 2013 02:28:24 +0000 (02:28 +0000)]
Rename some ImmutableArray leftovers
https://bugs.webkit.org/show_bug.cgi?id=124320

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-13
Reviewed by Anders Carlsson.

ImmutableArray has been renamed to API::Array in r159234.

* Shared/API/c/WKContextMenuItem.cpp:
* Shared/WebContextMenuItem.cpp:
* Shared/WebContextMenuItem.h:
* UIProcess/API/C/WKBackForwardListRef.cpp:
* UIProcess/API/Cocoa/WKBackForwardList.mm:
* UIProcess/API/gtk/WebKitBackForwardList.cpp:
* UIProcess/API/gtk/WebKitWebViewGroup.cpp:
* UIProcess/WebBackForwardList.cpp:
* UIProcess/WebBackForwardList.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Generate Individual InspectorBackendDispatchers, add base InspectorBac...
joepeck@webkit.org [Thu, 14 Nov 2013 02:24:46 +0000 (02:24 +0000)]
Web Inspector: Generate Individual InspectorBackendDispatchers, add base InspectorBackendDispatcher
https://bugs.webkit.org/show_bug.cgi?id=124296

Reviewed by Timothy Hatcher.

No new tests, this is just refactoring without changing functionality.
Set of changes made:

  - Add inspector/InspectorBackendDispatcher.{h,cpp}. This used to be almost entirely
    written in the code generator strings file, but make it actual source files
    because there is nothing changing in the code. Also clean this up a bit.
  - Give the base dispatcher a list of domain dispatchers and a way to register.
  - Make InspectorBackendDispatcher::dispatch read the domain of incoming request
    and pass the request on to the domain dispatcher.
  - Create per-domain dispatcher classes named "InspectorFooBackendDispatcher"
  - Convert "InspectorBackendDispatcher::FooCommandHandler" interfaces to
    "InspectorFooBackendDispatcherHandler" interfaces.
  - Convert all "InspectorBackendDispatcherImpl::FooDomain_fooMethod" methods to
    "InspectorFooBackendDispatcher::fooMethod" methods. These can also remove their
    "if (!agent)" checks because that can never be the case anymore.
  - Remove InspectorBackendDispatcherImpl, now that there are base and domain dispatchers.
  - Add ASCIILiteral in many places in generated code where possible.
  - In all agents, create dispatchers in didCreateFrontendAndBackend and clear
    them in willDestroyFrontendAndBackend, right alongside frontend dispatchers.

* inspector/CodeGeneratorInspector.py:
(DomainNameFixes.get_fixed_data.Res):
(TypeBindings.create_type_declaration_.EnumBinding.get_code_generator.CodeGenerator.generate_type_builder):
(Generator):
(Generator.go):
(Generator.process_command):
(Generator.generate_send_method):
* inspector/CodeGeneratorInspectorStrings.py:
(void):
(HashMap):
(InspectorBackendDispatchers_h):
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::didCreateFrontendAndBackend):
(WebCore::InspectorAgent::willDestroyFrontendAndBackend):
* inspector/InspectorAgent.h:
* inspector/InspectorAllInOne.cpp:
* inspector/InspectorApplicationCacheAgent.cpp:
(WebCore::InspectorApplicationCacheAgent::didCreateFrontendAndBackend):
(WebCore::InspectorApplicationCacheAgent::willDestroyFrontendAndBackend):
* inspector/InspectorApplicationCacheAgent.h:
* inspector/InspectorBackendDispatcher.cpp: Added.
(WebCore::InspectorBackendDispatcher::CallbackBase::CallbackBase):
(WebCore::InspectorBackendDispatcher::CallbackBase::isActive):
(WebCore::InspectorBackendDispatcher::CallbackBase::sendFailure):
(WebCore::InspectorBackendDispatcher::CallbackBase::sendIfActive):
(WebCore::InspectorBackendDispatcher::create):
(WebCore::InspectorBackendDispatcher::registerDispatcherForDomain):
(WebCore::InspectorBackendDispatcher::dispatch):
(WebCore::InspectorBackendDispatcher::sendResponse):
(WebCore::InspectorBackendDispatcher::reportProtocolError):
(WebCore::InspectorBackendDispatcher::getPropertyValue):
(WebCore::AsMethodBridges::asInt):
(WebCore::AsMethodBridges::asDouble):
(WebCore::AsMethodBridges::asString):
(WebCore::AsMethodBridges::asBoolean):
(WebCore::AsMethodBridges::asObject):
(WebCore::AsMethodBridges::asArray):
(WebCore::InspectorBackendDispatcher::getInt):
(WebCore::InspectorBackendDispatcher::getDouble):
(WebCore::InspectorBackendDispatcher::getString):
(WebCore::InspectorBackendDispatcher::getBoolean):
(WebCore::InspectorBackendDispatcher::getObject):
(WebCore::InspectorBackendDispatcher::getArray):
* inspector/InspectorBackendDispatcher.h: Added.
(WebCore::InspectorSupplementalBackendDispatcher::InspectorSupplementalBackendDispatcher):
(WebCore::InspectorSupplementalBackendDispatcher::~InspectorSupplementalBackendDispatcher):
(WebCore::InspectorBackendDispatcher::~InspectorBackendDispatcher):
(WebCore::InspectorBackendDispatcher::clearFrontend):
(WebCore::InspectorBackendDispatcher::isActive):
(WebCore::InspectorBackendDispatcher::InspectorBackendDispatcher):
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::didCreateFrontendAndBackend):
(WebCore::InspectorCSSAgent::willDestroyFrontendAndBackend):
* inspector/InspectorCSSAgent.h:
* inspector/InspectorCanvasAgent.cpp:
(WebCore::InspectorCanvasAgent::didCreateFrontendAndBackend):
(WebCore::InspectorCanvasAgent::willDestroyFrontendAndBackend):
* inspector/InspectorCanvasAgent.h:
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::didCreateFrontendAndBackend):
(WebCore::InspectorConsoleAgent::willDestroyFrontendAndBackend):
* inspector/InspectorConsoleAgent.h:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::didCreateFrontendAndBackend):
(WebCore::InspectorDOMAgent::willDestroyFrontendAndBackend):
* inspector/InspectorDOMAgent.h:
* inspector/InspectorDOMDebuggerAgent.cpp:
(WebCore::InspectorDOMDebuggerAgent::didCreateFrontendAndBackend):
(WebCore::InspectorDOMDebuggerAgent::willDestroyFrontendAndBackend):
* inspector/InspectorDOMDebuggerAgent.h:
* inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::didCreateFrontendAndBackend):
(WebCore::InspectorDOMStorageAgent::willDestroyFrontendAndBackend):
* inspector/InspectorDOMStorageAgent.h:
* inspector/InspectorDatabaseAgent.cpp:
(WebCore::InspectorDatabaseAgent::didCreateFrontendAndBackend):
(WebCore::InspectorDatabaseAgent::willDestroyFrontendAndBackend):
* inspector/InspectorDatabaseAgent.h:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::didCreateFrontendAndBackend):
(WebCore::InspectorDebuggerAgent::willDestroyFrontendAndBackend):
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorHeapProfilerAgent.cpp:
(WebCore::InspectorHeapProfilerAgent::didCreateFrontendAndBackend):
(WebCore::InspectorHeapProfilerAgent::willDestroyFrontendAndBackend):
* inspector/InspectorHeapProfilerAgent.h:
* inspector/InspectorIndexedDBAgent.cpp:
(WebCore::InspectorIndexedDBAgent::didCreateFrontendAndBackend):
(WebCore::InspectorIndexedDBAgent::willDestroyFrontendAndBackend):
* inspector/InspectorIndexedDBAgent.h:
* inspector/InspectorInputAgent.cpp:
(WebCore::InspectorInputAgent::didCreateFrontendAndBackend):
(WebCore::InspectorInputAgent::willDestroyFrontendAndBackend):
* inspector/InspectorInputAgent.h:
* inspector/InspectorLayerTreeAgent.cpp:
(WebCore::InspectorLayerTreeAgent::didCreateFrontendAndBackend):
(WebCore::InspectorLayerTreeAgent::willDestroyFrontendAndBackend):
* inspector/InspectorLayerTreeAgent.h:
* inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::didCreateFrontendAndBackend):
(WebCore::InspectorMemoryAgent::willDestroyFrontendAndBackend):
* inspector/InspectorMemoryAgent.h:
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::didCreateFrontendAndBackend):
(WebCore::InspectorPageAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorPageAgent::getScriptExecutionStatus):
* inspector/InspectorPageAgent.h:
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::didCreateFrontendAndBackend):
(WebCore::InspectorProfilerAgent::willDestroyFrontendAndBackend):
* inspector/InspectorProfilerAgent.h:
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::didCreateFrontendAndBackend):
(WebCore::InspectorResourceAgent::willDestroyFrontendAndBackend):
* inspector/InspectorResourceAgent.h:
* inspector/InspectorRuntimeAgent.h:
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::didCreateFrontendAndBackend):
(WebCore::InspectorTimelineAgent::willDestroyFrontendAndBackend):
* inspector/InspectorTimelineAgent.h:
* inspector/InspectorWorkerAgent.cpp:
(WebCore::InspectorWorkerAgent::didCreateFrontendAndBackend):
(WebCore::InspectorWorkerAgent::willDestroyFrontendAndBackend):
* inspector/InspectorWorkerAgent.h:
* inspector/PageRuntimeAgent.cpp:
(WebCore::PageRuntimeAgent::didCreateFrontendAndBackend):
(WebCore::PageRuntimeAgent::willDestroyFrontendAndBackend):
* inspector/PageRuntimeAgent.h:
* inspector/WorkerRuntimeAgent.cpp:
(WebCore::WorkerRuntimeAgent::didCreateFrontendAndBackend):
(WebCore::WorkerRuntimeAgent::willDestroyFrontendAndBackend):
* inspector/WorkerRuntimeAgent.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION (r159263): caused 50+ crashes on all mac webkit2 bots
mitz@apple.com [Thu, 14 Nov 2013 01:59:52 +0000 (01:59 +0000)]
REGRESSION (r159263): caused 50+ crashes on all mac webkit2 bots
https://bugs.webkit.org/show_bug.cgi?id=124327

Reviewed by Tim Horton.

* Shared/Cocoa/APIObject.mm:
(API::Object::newObject): Allocate extra memory for the WebError inside the WKNSError.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoLayout Test animations/resume-after-page-cache.html is flaky
timothy_horton@apple.com [Thu, 14 Nov 2013 01:20:57 +0000 (01:20 +0000)]
Layout Test animations/resume-after-page-cache.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=124321

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUse NSCalendarIdentifierGregorian instead of NSGregorianCalendar on OS X 10.9 and iOS
aestes@apple.com [Thu, 14 Nov 2013 01:18:32 +0000 (01:18 +0000)]
Use NSCalendarIdentifierGregorian instead of NSGregorianCalendar on OS X 10.9 and iOS
https://bugs.webkit.org/show_bug.cgi?id=124323

Reviewed by Mark Rowe.

NSGregorianCalendar was deprecated in OS X 10.9 and iOS 7.

* platform/text/mac/LocaleMac.mm:
(WebCore::LocaleMac::LocaleMac):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Rename InspectorBackendDispatcher.h to InspectorBackendDispatchers.h
joepeck@webkit.org [Thu, 14 Nov 2013 00:53:18 +0000 (00:53 +0000)]
Web Inspector: Rename InspectorBackendDispatcher.h to InspectorBackendDispatchers.h
https://bugs.webkit.org/show_bug.cgi?id=124257

Reviewed by Timothy Hatcher.

Soon each domain will generate its own dispatcher, and the generic
InspectorBackendDispatcher will no longer be generated, it will just
live in WebCore/inspector.

* CMakeLists.txt:
* GNUmakefile.am:
* GNUmakefile.list.am:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* inspector/CodeGeneratorInspector.py:
* inspector/CodeGeneratorInspectorStrings.py:
(InspectorBackendDispatchers_h):
* inspector/InspectorBaseAgent.h:
* inspector/InspectorController.cpp:
* inspector/InspectorFrontendClientLocal.cpp:
* inspector/WorkerInspectorController.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Cocoa] Add WKNSError
mitz@apple.com [Thu, 14 Nov 2013 00:49:43 +0000 (00:49 +0000)]
[Cocoa] Add WKNSError
https://bugs.webkit.org/show_bug.cgi?id=124295

Reviewed by Anders Carlsson.

* Shared/Cocoa/APIObject.mm:
(API::Object::newObject): Allocate a WKNSError if the object is a WebError.
* Shared/Cocoa/WKNSError.h: Added.
(WebKit::wrapper): Added. Returns a WebError’s wrapper as an NSError.
* Shared/Cocoa/WKNSError.mm: Added.
(-[WKNSError _web_createTarget]): Override this WKObject method to return a copy of the
underlying CFError.
(-[WKNSError copyWithZone:]): Retains self.
* WebKit2.xcodeproj/project.pbxproj: Added new files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoTweak the property syntax after https://bugs.webkit.org/show_bug.cgi?id=124317
simon.fraser@apple.com [Thu, 14 Nov 2013 00:46:41 +0000 (00:46 +0000)]
Tweak the property syntax after https://bugs.webkit.org/show_bug.cgi?id=124317

Reviewed by Dan Bernstein.

* UIProcess/API/mac/WKViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix the ARM64 build after recent JavaScriptCore changes
aestes@apple.com [Thu, 14 Nov 2013 00:44:22 +0000 (00:44 +0000)]
Fix the ARM64 build after recent JavaScriptCore changes
https://bugs.webkit.org/show_bug.cgi?id=124315

Reviewed by Michael Saboff.

Based on patches by myself, Filip Pizlo, Benjamin Poulain, and Michael Saboff.

* Configurations/JavaScriptCore.xcconfig: Hid the symbol for
std::bad_function_call.
* JavaScriptCore.xcodeproj/project.pbxproj: Marked
MacroAssemblerARM64.h and ARM64Assembler.h as Private headers.
* assembler/ARM64Assembler.h:
(JSC::ARM64Assembler::executableOffsetFor):
* assembler/MacroAssemblerARM64.h: Removed ARM64's executableCopy(),
which was removed from other assembler backends in r157690.
(JSC::MacroAssemblerARM64::shouldBlindForSpecificArch): Added.
(JSC::MacroAssemblerARM64::lshift64): Added.
(JSC::MacroAssemblerARM64::mul64): Added.
(JSC::MacroAssemblerARM64::rshift64): Added.
(JSC::MacroAssemblerARM64::convertInt64ToDouble): Added.
(JSC::MacroAssemblerARM64::branchMul64): Added.
(JSC::MacroAssemblerARM64::branchNeg64): Added.
(JSC::MacroAssemblerARM64::scratchRegisterForBlinding): Added.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileArithDiv): Changed
SpeculateIntegerOperand to SpeculateInt32Operand,
nodeCanIgnoreNegativeZero() to bytecodeCanIgnoreNegativeZero(), and
nodeUsedAsNumber() to bytecodeUsesAsNumber().
(JSC::DFG::SpeculativeJIT::compileArithMod): Changed
nodeCanIgnoreNegativeZero() to bytecodeCanIgnoreNegativeZero().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agofullscreen/anonymous-block-merge-crash.html often times out in WebKit1
timothy_horton@apple.com [Wed, 13 Nov 2013 23:57:46 +0000 (23:57 +0000)]
fullscreen/anonymous-block-merge-crash.html often times out in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=124318

* platform/mac-wk2/TestExpectations:
* platform/mac/TestExpectations:
Mark test as timing out on WebKit1 only.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove more state tracking to FrameLoadState
andersca@apple.com [Wed, 13 Nov 2013 23:55:18 +0000 (23:55 +0000)]
Move more state tracking to FrameLoadState
https://bugs.webkit.org/show_bug.cgi?id=124316

Reviewed by Simon Fraser.

* UIProcess/FrameLoadState.cpp:
(WebKit::FrameLoadState::didStartProvisionalLoad):
(WebKit::FrameLoadState::didReceiveServerRedirectForProvisionalLoad):
(WebKit::FrameLoadState::didFailProvisionalLoad):
(WebKit::FrameLoadState::didCommitLoad):
(WebKit::FrameLoadState::didFinishLoad):
(WebKit::FrameLoadState::didFailLoad):
(WebKit::FrameLoadState::didSameDocumentNotification):
(WebKit::FrameLoadState::setUnreachableURL):
* UIProcess/FrameLoadState.h:
* UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::didCommitLoad):
(WebKit::WebFrameProxy::didFinishLoad):
(WebKit::WebFrameProxy::didFailLoad):
(WebKit::WebFrameProxy::didSameDocumentNavigation):
(WebKit::WebFrameProxy::setUnreachableURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoExpose a private flag on WKView to indicate whether it's using a remote layer tree...
simon.fraser@apple.com [Wed, 13 Nov 2013 23:53:04 +0000 (23:53 +0000)]
Expose a private flag on WKView to indicate whether it's using a remote layer tree drawing area
https://bugs.webkit.org/show_bug.cgi?id=124317

Reviewed by Anders Carlsson.

Expose isUsingUISideCompositing on WKView in the private header,
which returns YES if the view is using a DrawingAreaTypeRemoteLayerTree.

* UIProcess/API/mac/WKView.mm:
(-[WKView isUsingUISideCompositing]):
* UIProcess/API/mac/WKViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMaybe the last attempt to fix the GTK build.
ossy@webkit.org [Wed, 13 Nov 2013 23:36:22 +0000 (23:36 +0000)]
Maybe the last attempt to fix the GTK build.

* UIProcess/API/gtk/WebKitBackForwardListPrivate.h:
* UIProcess/API/gtk/WebKitContextMenuPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoOne more attempt to fix the GTK build.
ossy@webkit.org [Wed, 13 Nov 2013 23:30:16 +0000 (23:30 +0000)]
One more attempt to fix the GTK build.

* UIProcess/API/gtk/WebKitWebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemoved deprecated download delegates.
commit-queue@webkit.org [Wed, 13 Nov 2013 23:20:27 +0000 (23:20 +0000)]
Removed deprecated download delegates.
https://bugs.webkit.org/show_bug.cgi?id=124309
<rdar://problem/13570414>

Patch by Gordon Sheridan <gordon_sheridan@apple.com> on 2013-11-13
Reviewed by Anders Carlsson.

* Misc/WebDownload.mm:
(-[WebDownloadInternal respondsToSelector:]):
Removed download:shouldBeginChildDownloadOfSource:delegate and
download:didBeginChildDownload.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoPlug-in processes hang around for 10 sec after Safari quits
andersca@apple.com [Wed, 13 Nov 2013 23:18:08 +0000 (23:18 +0000)]
Plug-in processes hang around for 10 sec after Safari quits
https://bugs.webkit.org/show_bug.cgi?id=124314
<rdar://problem/15460613>

Reviewed by Simon Fraser.

Call stopRunLoop instead of instead of RunLoop::stop().

* PluginProcess/PluginProcess.cpp:
(WebKit::PluginProcess::didClose):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoURTBF after r159234.
ossy@webkit.org [Wed, 13 Nov 2013 23:11:59 +0000 (23:11 +0000)]
URTBF after r159234.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Shared/efl/WebEventFactory.cpp:
(WebKit::WebEventFactory::createWebTouchEvent):
* UIProcess/API/C/WKGrammarDetail.cpp:
* UIProcess/API/C/efl/WKEventEfl.cpp:
* UIProcess/API/gtk/WebKitBackForwardList.cpp:
(webkitBackForwardListCreateList):
(webkitBackForwardListChanged):
(webkit_back_forward_list_get_back_list_with_limit):
(webkit_back_forward_list_get_forward_list_with_limit):
* UIProcess/API/gtk/WebKitBackForwardListPrivate.h:
* UIProcess/API/gtk/WebKitContextMenu.cpp:
(webkitContextMenuCreate):
* UIProcess/API/gtk/WebKitContextMenuItem.cpp:
(webkitContextMenuItemCreate):
* UIProcess/API/gtk/WebKitContextMenuPrivate.h:
* UIProcess/API/gtk/WebKitCookieManager.cpp:
(webkitCookieManagerGetDomainsWithCookiesCallback):
* UIProcess/API/gtk/WebKitFileChooserRequest.cpp:
(webkit_file_chooser_request_get_mime_types):
(webkit_file_chooser_request_get_mime_types_filter):
(webkit_file_chooser_request_select_files):
(webkit_file_chooser_request_get_selected_files):
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewPopulateContextMenu):
* UIProcess/API/gtk/WebKitWebViewGroup.cpp:
(toImmutableArray):
(webkit_web_view_group_add_user_style_sheet):
* UIProcess/API/gtk/WebKitWebViewPrivate.h:
* UIProcess/WebGrammarDetail.cpp:
(WebKit::WebGrammarDetail::create):
(WebKit::WebGrammarDetail::WebGrammarDetail):
(WebKit::WebGrammarDetail::guesses):
* UIProcess/WebGrammarDetail.h:
* UIProcess/WebTextCheckerClient.cpp:
(WebKit::WebTextCheckerClient::checkGrammarOfString):
(WebKit::WebTextCheckerClient::guessesForWord):
* UIProcess/efl/WebUIPopupMenuClient.cpp:
(WebUIPopupMenuClient::showPopupMenu):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove Document::m_savedRenderView pointer.
akling@apple.com [Wed, 13 Nov 2013 23:10:30 +0000 (23:10 +0000)]
Remove Document::m_savedRenderView pointer.
<https://webkit.org/b/124310>

This pointer held a copy of m_renderView while the document was in
page cache, and null while it wasn't. It was not used for anything.

Reviewed by Anders Carlsson.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove setIndexKeys() to the IDBServerConnection
beidson@apple.com [Wed, 13 Nov 2013 23:08:53 +0000 (23:08 +0000)]
Move setIndexKeys() to the IDBServerConnection
https://bugs.webkit.org/show_bug.cgi?id=124301

Reviewed by Anders Carlsson.

This is a big step towards moving knowledge of the backing store out of the frontend.

* Modules/indexeddb/IDBBackingStoreInterface.h:

* Modules/indexeddb/IDBDatabaseBackend.cpp:
(WebCore::IDBDatabaseBackend::setIndexKeys):

* Modules/indexeddb/IDBServerConnection.h:
* Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp:
(WebCore::IDBServerConnectionLevelDB::setIndexKeys):
* Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.h:

* Modules/indexeddb/IDBTransactionBackendOperations.cpp:
(WebCore::PutOperation::perform):

* Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
(WebCore::IDBBackingStoreLevelDB::makeIndexWriters):
* Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Extract InspectorFrontendDispatchers from InspectorFrontend
joepeck@webkit.org [Wed, 13 Nov 2013 22:58:16 +0000 (22:58 +0000)]
Web Inspector: Extract InspectorFrontendDispatchers from InspectorFrontend
https://bugs.webkit.org/show_bug.cgi?id=124246

Reviewed by NOBODY (OOPS!).

No new tests, this is just refactoring without changing functionality.
Set of changes made:

  - Remove "class InspectorFrontend" that currently does nothing but hold
    sub-frontend dispatcher classes. Catches some stale code.
  - Generate individual "class InspectorFooFrontendDispatcher" classes for
    domains that have events. Catches some unnecessary classes.
  - Simplify the Base Agent interface from optional set/clearFrontend/register
    to required didCreateFrontendAndBackend/willDestroyFrontendAndBackend.
    New agents must implement this and this will be their cue to setup
    frontend and backend dispatchers.
  - Base Agent no longer needs to be templated or have an Interface class.
  - While we are changing subclass BaseAgent superclass calls, use ASCIILiteral
  - In agents with events, convert "InspectorFrontend::Foo* m_frontend" to
    "unique_ptr<InspectorFooFrontendDispatcher> m_frontendDispatcher" and
    update uses as appropriate within the classes.
  - In agents with events, create dispatchers in didCreateFrontendAndBackend
    and clear them in willDestroyFrontendAndBackend.

* inspector/CodeGeneratorInspector.py:
(Generator):
(Generator.go):
(Generator.process_event):
* inspector/CodeGeneratorInspectorStrings.py:
(InspectorFrontendChannel):
* inspector/ConsoleMessage.cpp:
(WebCore::ConsoleMessage::addToFrontend):
(WebCore::ConsoleMessage::updateRepeatCountInConsole):
* inspector/ConsoleMessage.h:
* inspector/InjectedScriptHost.h:
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent):
(WebCore::InspectorAgent::didCreateFrontendAndBackend):
(WebCore::InspectorAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorAgent::enable):
(WebCore::InspectorAgent::evaluateForTestInFrontend):
(WebCore::InspectorAgent::inspect):
* inspector/InspectorAgent.h:
(WebCore::InspectorAgent::hasFrontend):
* inspector/InspectorAgentRegistry.cpp:
(WebCore::InspectorAgentRegistry::append):
(WebCore::InspectorAgentRegistry::didCreateFrontendAndBackend):
(WebCore::InspectorAgentRegistry::willDestroyFrontendAndBackend):
* inspector/InspectorAgentRegistry.h:
* inspector/InspectorApplicationCacheAgent.cpp:
(WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
(WebCore::InspectorApplicationCacheAgent::didCreateFrontendAndBackend):
(WebCore::InspectorApplicationCacheAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorApplicationCacheAgent::updateApplicationCacheStatus):
(WebCore::InspectorApplicationCacheAgent::networkStateChanged):
* inspector/InspectorApplicationCacheAgent.h:
* inspector/InspectorBaseAgent.h:
(WebCore::InspectorBaseAgent::discardAgent):
(WebCore::InspectorBaseAgent::InspectorBaseAgent):
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::InspectorCSSAgent):
(WebCore::InspectorCSSAgent::didCreateFrontendAndBackend):
(WebCore::InspectorCSSAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorCSSAgent::mediaQueryResultChanged):
(WebCore::InspectorCSSAgent::didCreateNamedFlow):
(WebCore::InspectorCSSAgent::willRemoveNamedFlow):
(WebCore::InspectorCSSAgent::regionLayoutUpdated):
(WebCore::InspectorCSSAgent::regionOversetChanged):
(WebCore::InspectorCSSAgent::didRegisterNamedFlowContentElement):
(WebCore::InspectorCSSAgent::didUnregisterNamedFlowContentElement):
(WebCore::InspectorCSSAgent::stopSelectorProfilerImpl):
(WebCore::InspectorCSSAgent::styleSheetChanged):
* inspector/InspectorCSSAgent.h:
* inspector/InspectorCanvasAgent.cpp:
(WebCore::InspectorCanvasAgent::InspectorCanvasAgent):
(WebCore::InspectorCanvasAgent::didCreateFrontendAndBackend):
(WebCore::InspectorCanvasAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorCanvasAgent::notifyRenderingContextWasWrapped):
(WebCore::InspectorCanvasAgent::findFramesWithUninstrumentedCanvases):
(WebCore::InspectorCanvasAgent::frameNavigated):
* inspector/InspectorCanvasAgent.h:
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
(WebCore::InspectorConsoleAgent::enable):
(WebCore::InspectorConsoleAgent::clearMessages):
(WebCore::InspectorConsoleAgent::didCreateFrontendAndBackend):
(WebCore::InspectorConsoleAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorConsoleAgent::addMessageToConsole):
(WebCore::InspectorConsoleAgent::didFinishXHRLoading):
(WebCore::InspectorConsoleAgent::addConsoleMessage):
* inspector/InspectorConsoleAgent.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::disconnectFrontend):
(WebCore::InspectorController::show):
(WebCore::InspectorController::close):
* inspector/InspectorController.h:
(WebCore::InspectorController::hasFrontend):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::didCreateFrontendAndBackend):
(WebCore::InspectorDOMAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorDOMAgent::setDocument):
(WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
(WebCore::InspectorDOMAgent::pushNodePathToFrontend):
(WebCore::InspectorDOMAgent::focusNode):
(WebCore::InspectorDOMAgent::mainFrameDOMContentLoaded):
(WebCore::InspectorDOMAgent::didCommitLoad):
(WebCore::InspectorDOMAgent::didInsertDOMNode):
(WebCore::InspectorDOMAgent::didRemoveDOMNode):
(WebCore::InspectorDOMAgent::didModifyDOMAttr):
(WebCore::InspectorDOMAgent::didRemoveDOMAttr):
(WebCore::InspectorDOMAgent::styleAttributeInvalidated):
(WebCore::InspectorDOMAgent::characterDataModified):
(WebCore::InspectorDOMAgent::didPushShadowRoot):
(WebCore::InspectorDOMAgent::willPopShadowRoot):
* inspector/InspectorDOMAgent.h:
* inspector/InspectorDOMDebuggerAgent.cpp:
(WebCore::InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent):
(WebCore::InspectorDOMDebuggerAgent::didCreateFrontendAndBackend):
(WebCore::InspectorDOMDebuggerAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorDOMDebuggerAgent::didInvalidateStyleAttr):
(WebCore::InspectorDOMDebuggerAgent::willInsertDOMNode):
(WebCore::InspectorDOMDebuggerAgent::willRemoveDOMNode):
(WebCore::InspectorDOMDebuggerAgent::willModifyDOMAttr):
(WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):
(WebCore::InspectorDOMDebuggerAgent::willSendXMLHttpRequest):
* inspector/InspectorDOMDebuggerAgent.h:
* inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
(WebCore::InspectorDOMStorageAgent::didCreateFrontendAndBackend):
(WebCore::InspectorDOMStorageAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorDOMStorageAgent::didDispatchDOMStorageEvent):
* inspector/InspectorDOMStorageAgent.h:
* inspector/InspectorDatabaseAgent.cpp:
(WebCore::InspectorDatabaseAgent::didOpenDatabase):
(WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
(WebCore::InspectorDatabaseAgent::didCreateFrontendAndBackend):
(WebCore::InspectorDatabaseAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorDatabaseAgent::enable):
* inspector/InspectorDatabaseAgent.h:
* inspector/InspectorDatabaseResource.cpp:
(WebCore::InspectorDatabaseResource::bind):
* inspector/InspectorDatabaseResource.h:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
(WebCore::InspectorDebuggerAgent::enable):
(WebCore::InspectorDebuggerAgent::didCreateFrontendAndBackend):
(WebCore::InspectorDebuggerAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorDebuggerAgent::addMessageToConsole):
(WebCore::InspectorDebuggerAgent::schedulePauseOnNextStatement):
(WebCore::InspectorDebuggerAgent::scriptExecutionBlockedByCSP):
(WebCore::InspectorDebuggerAgent::didParseSource):
(WebCore::InspectorDebuggerAgent::failedToParseSource):
(WebCore::InspectorDebuggerAgent::didPause):
(WebCore::InspectorDebuggerAgent::didContinue):
(WebCore::InspectorDebuggerAgent::breakProgram):
(WebCore::InspectorDebuggerAgent::clearBreakDetails):
(WebCore::InspectorDebuggerAgent::reset):
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorHeapProfilerAgent.cpp:
(WebCore::InspectorHeapProfilerAgent::InspectorHeapProfilerAgent):
(WebCore::InspectorHeapProfilerAgent::resetFrontendProfiles):
(WebCore::InspectorHeapProfilerAgent::didCreateFrontendAndBackend):
(WebCore::InspectorHeapProfilerAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorHeapProfilerAgent::getHeapSnapshot):
(WebCore::InspectorHeapProfilerAgent::takeHeapSnapshot):
* inspector/InspectorHeapProfilerAgent.h:
* inspector/InspectorIndexedDBAgent.cpp:
(WebCore::InspectorIndexedDBAgent::InspectorIndexedDBAgent):
(WebCore::InspectorIndexedDBAgent::didCreateFrontendAndBackend):
(WebCore::InspectorIndexedDBAgent::willDestroyFrontendAndBackend):
* inspector/InspectorIndexedDBAgent.h:
* inspector/InspectorInputAgent.cpp:
(WebCore::InspectorInputAgent::InspectorInputAgent):
(WebCore::InspectorInputAgent::didCreateFrontendAndBackend):
(WebCore::InspectorInputAgent::willDestroyFrontendAndBackend):
* inspector/InspectorInputAgent.h:
* inspector/InspectorLayerTreeAgent.cpp:
(WebCore::InspectorLayerTreeAgent::InspectorLayerTreeAgent):
(WebCore::InspectorLayerTreeAgent::didCreateFrontendAndBackend):
(WebCore::InspectorLayerTreeAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorLayerTreeAgent::layerTreeDidChange):
* inspector/InspectorLayerTreeAgent.h:
* inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::didCreateFrontendAndBackend):
(WebCore::InspectorMemoryAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorMemoryAgent::InspectorMemoryAgent):
* inspector/InspectorMemoryAgent.h:
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::didCreateFrontendAndBackend):
(WebCore::InspectorPageAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
(WebCore::InspectorPageAgent::domContentEventFired):
(WebCore::InspectorPageAgent::loadEventFired):
(WebCore::InspectorPageAgent::frameNavigated):
(WebCore::InspectorPageAgent::frameDetached):
(WebCore::InspectorPageAgent::frameStartedLoading):
(WebCore::InspectorPageAgent::frameStoppedLoading):
(WebCore::InspectorPageAgent::frameScheduledNavigation):
(WebCore::InspectorPageAgent::frameClearedScheduledNavigation):
(WebCore::InspectorPageAgent::willRunJavaScriptDialog):
(WebCore::InspectorPageAgent::didRunJavaScriptDialog):
(WebCore::InspectorPageAgent::scriptsEnabled):
* inspector/InspectorPageAgent.h:
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
(WebCore::InspectorProfilerAgent::addProfile):
(WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole):
(WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):
(WebCore::InspectorProfilerAgent::getHeapSnapshot):
(WebCore::InspectorProfilerAgent::resetFrontendProfiles):
(WebCore::InspectorProfilerAgent::didCreateFrontendAndBackend):
(WebCore::InspectorProfilerAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorProfilerAgent::takeHeapSnapshot):
(WebCore::InspectorProfilerAgent::toggleRecordButton):
* inspector/InspectorProfilerAgent.h:
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::didCreateFrontendAndBackend):
(WebCore::InspectorResourceAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorResourceAgent::willSendRequest):
(WebCore::InspectorResourceAgent::markResourceAsCached):
(WebCore::InspectorResourceAgent::didReceiveResponse):
(WebCore::InspectorResourceAgent::didReceiveData):
(WebCore::InspectorResourceAgent::didFinishLoading):
(WebCore::InspectorResourceAgent::didFailLoading):
(WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
(WebCore::InspectorResourceAgent::didCreateWebSocket):
(WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest):
(WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse):
(WebCore::InspectorResourceAgent::didCloseWebSocket):
(WebCore::InspectorResourceAgent::didReceiveWebSocketFrame):
(WebCore::InspectorResourceAgent::didSendWebSocketFrame):
(WebCore::InspectorResourceAgent::didReceiveWebSocketFrameError):
(WebCore::InspectorResourceAgent::enable):
(WebCore::InspectorResourceAgent::InspectorResourceAgent):
* inspector/InspectorResourceAgent.h:
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
* inspector/InspectorRuntimeAgent.h:
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::~InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::didCreateFrontendAndBackend):
(WebCore::InspectorTimelineAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorTimelineAgent::start):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::sendEvent):
* inspector/InspectorTimelineAgent.h:
* inspector/InspectorWorkerAgent.cpp:
(WebCore::InspectorWorkerAgent::WorkerFrontendChannel::WorkerFrontendChannel):
(WebCore::InspectorWorkerAgent::WorkerFrontendChannel::dispatchMessageFromWorker):
(WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
(WebCore::InspectorWorkerAgent::didCreateFrontendAndBackend):
(WebCore::InspectorWorkerAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorWorkerAgent::enable):
(WebCore::InspectorWorkerAgent::disable):
(WebCore::InspectorWorkerAgent::didStartWorkerGlobalScope):
(WebCore::InspectorWorkerAgent::workerGlobalScopeTerminated):
(WebCore::InspectorWorkerAgent::createWorkerFrontendChannel):
* inspector/InspectorWorkerAgent.h:
* inspector/PageRuntimeAgent.cpp:
(WebCore::PageRuntimeAgent::PageRuntimeAgent):
(WebCore::PageRuntimeAgent::didCreateFrontendAndBackend):
(WebCore::PageRuntimeAgent::willDestroyFrontendAndBackend):
(WebCore::PageRuntimeAgent::didCreateMainWorldContext):
(WebCore::PageRuntimeAgent::didCreateIsolatedContext):
(WebCore::PageRuntimeAgent::notifyContextCreated):
* inspector/PageRuntimeAgent.h:
* inspector/TimelineRecordFactory.h:
* inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::connectFrontend):
(WebCore::WorkerInspectorController::disconnectFrontend):
* inspector/WorkerInspectorController.h:
(WebCore::WorkerInspectorController::hasFrontend):
* inspector/WorkerRuntimeAgent.cpp:
(WebCore::WorkerRuntimeAgent::didCreateFrontendAndBackend):
(WebCore::WorkerRuntimeAgent::willDestroyFrontendAndBackend):
* inspector/WorkerRuntimeAgent.h:
* inspector/protocol/Input.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agocompositing/regions/transform-transparent-positioned-video-inside-region.html is...
timothy_horton@apple.com [Wed, 13 Nov 2013 22:25:54 +0000 (22:25 +0000)]
compositing/regions/transform-transparent-positioned-video-inside-region.html is flaky on all bots
https://bugs.webkit.org/show_bug.cgi?id=124311

* platform/mac/TestExpectations:
Mark as flaky image fail.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRename FrameView's repaintFixedElementsAfterScrolling and updateFixedElementsAfterScr...
simon.fraser@apple.com [Wed, 13 Nov 2013 22:22:14 +0000 (22:22 +0000)]
Rename FrameView's repaintFixedElementsAfterScrolling and updateFixedElementsAfterScrolling
https://bugs.webkit.org/show_bug.cgi?id=124306

Reviewed by Tim Horton.

FrameView::repaintFixedElementsAfterScrolling() didn't do any repainting, and didn't
just apply to fixed elements. Rename it to updateLayerPositionsAfterScrolling().

updateFixedElementsAfterScrolling() was also confusingly named; rename it
to updateCompositingLayersAfterScrolling().

* page/FrameView.cpp:
(WebCore::FrameView::setFixedVisibleContentRect):
(WebCore::FrameView::scrollPositionChangedViaPlatformWidget):
(WebCore::FrameView::updateLayerPositionsAfterScrolling):
(WebCore::FrameView::shouldUpdateCompositingLayersAfterScrolling):
(WebCore::FrameView::updateCompositingLayersAfterScrolling):
* page/FrameView.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::scrollTo):
* platform/ScrollView.h:
(WebCore::ScrollView::updateLayerPositionsAfterScrolling):
(WebCore::ScrollView::updateCompositingLayersAfterScrolling):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoGenerate casting helpers for SVGPaint and SVGColor.
akling@apple.com [Wed, 13 Nov 2013 22:19:33 +0000 (22:19 +0000)]
Generate casting helpers for SVGPaint and SVGColor.
<https://webkit.org/b/124285>

Use CSS_VALUE_TYPE_CASTS to generate type casting helpers for the
SVGPaint and SVGColor classes.

Reviewed by Anders Carlsson.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix build.
andersca@apple.com [Wed, 13 Nov 2013 22:17:54 +0000 (22:17 +0000)]
Fix build.

Not sure why these weren't added.

* Shared/APIArray.cpp: Added.
* Shared/APIArray.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate ResourceHandleCF to use the didReceiveBuffer() callback
benjamin@webkit.org [Wed, 13 Nov 2013 22:06:39 +0000 (22:06 +0000)]
Update ResourceHandleCF to use the didReceiveBuffer() callback
https://bugs.webkit.org/show_bug.cgi?id=124256

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-11-13
Reviewed by Alexey Proskuryakov.

Use didReceiveBuffer() instead of didReceiveData() to pass data back to
the ResourceHandleClient. This unify the update code with the NSURLConnection loader.

* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::didReceiveData):
(WebCore::ResourceHandle::handleDataArray):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRename ImmutableArray to API::Array
andersca@apple.com [Wed, 13 Nov 2013 22:05:12 +0000 (22:05 +0000)]
Rename ImmutableArray to API::Array
https://bugs.webkit.org/show_bug.cgi?id=124307

Reviewed by Andreas Kling.

* Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(ensureObjectStream):
(-[WKRemoteObjectDecoder initWithInterface:rootObjectDictionary:WebKit::]):
* Shared/API/c/WKArray.cpp:
(WKArrayGetTypeID):
(WKArrayCreate):
(WKArrayCreateAdoptingValues):
* Shared/API/c/WKContextMenuItem.cpp:
* Shared/API/c/WKDictionary.cpp:
(WKDictionaryCopyKeys):
* Shared/API/c/WKMutableArray.cpp:
(WKMutableArrayCreate):
* Shared/API/c/WKRenderObject.cpp:
(WKRenderObjectGetChildren):
* Shared/API/c/WKSharedAPICast.h:
(WebKit::toImpl):
* Shared/API/c/mac/WKWebArchive.cpp:
(WKWebArchiveCopySubresources):
(WKWebArchiveCopySubframeArchives):
* Shared/APIArray.cpp: Renamed from Source/WebKit2/Shared/ImmutableArray.cpp.
(API::Array::create):
(API::Array::createStringArray):
(API::Array::Array):
(API::Array::~Array):
* Shared/APIArray.h: Renamed from Source/WebKit2/Shared/ImmutableArray.h.
* Shared/Cocoa/WKNSArray.h:
(wrapper):
* Shared/Cocoa/WKNSArray.mm:
(-[WKNSArray dealloc]):
(-[WKNSArray count]):
(-[WKNSArray objectAtIndex:]):
(-[WKNSArray API::]):
* Shared/ImmutableDictionary.cpp:
(WebKit::ImmutableDictionary::keys):
* Shared/ImmutableDictionary.h:
* Shared/SecurityOriginData.cpp:
(WebKit::performAPICallbackWithSecurityOriginDataVector):
* Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
* Shared/WebArchive.cpp:
(WebKit::WebArchive::create):
(WebKit::WebArchive::WebArchive):
(WebKit::WebArchive::subresources):
(WebKit::WebArchive::subframeArchives):
* Shared/WebArchive.h:
* Shared/WebContextMenuItem.cpp:
(WebKit::WebContextMenuItem::create):
(WebKit::WebContextMenuItem::submenuItemsAsImmutableArray):
* Shared/WebContextMenuItem.h:
* Shared/WebOpenPanelParameters.cpp:
(WebKit::WebOpenPanelParameters::acceptMIMETypes):
(WebKit::WebOpenPanelParameters::selectedFileNames):
* Shared/WebOpenPanelParameters.h:
* Shared/WebRenderLayer.cpp:
(WebKit::WebRenderLayer::create):
(WebKit::WebRenderLayer::createArrayFromLayerList):
(WebKit::WebRenderLayer::WebRenderLayer):
* Shared/WebRenderLayer.h:
(WebKit::WebRenderLayer::negativeZOrderList):
(WebKit::WebRenderLayer::normalFlowList):
(WebKit::WebRenderLayer::positiveZOrderList):
* Shared/WebRenderObject.cpp:
(WebKit::WebRenderObject::create):
(WebKit::WebRenderObject::WebRenderObject):
(WebKit::WebRenderObject::~WebRenderObject):
* Shared/WebRenderObject.h:
(WebKit::WebRenderObject::children):
(WebKit::WebRenderObject::elementClassNames):
* UIProcess/API/C/WKBackForwardListRef.cpp:
* UIProcess/API/C/WKOpenPanelParameters.cpp:
* UIProcess/API/C/WKPage.cpp:
* UIProcess/API/C/mac/WKContextPrivateMac.mm:
(WKContextGetInfoForInstalledPlugIns):
* UIProcess/API/Cocoa/WKBackForwardList.mm:
(-[WKBackForwardList backListWithLimit:]):
(-[WKBackForwardList forwardListWithLimit:]):
* UIProcess/API/mac/WKBrowsingContextGroup.mm:
(createWKArray):
* UIProcess/Notifications/WebNotificationManagerProxy.cpp:
(WebKit::WebNotificationManagerProxy::populateCopyOfNotificationPermissions):
(WebKit::WebNotificationManagerProxy::providerDidCloseNotifications):
(WebKit::WebNotificationManagerProxy::providerDidRemoveNotificationPolicies):
* UIProcess/Notifications/WebNotificationManagerProxy.h:
* UIProcess/Notifications/WebNotificationProvider.cpp:
(WebKit::WebNotificationProvider::clearNotifications):
* UIProcess/Plugins/PlugInAutoStartProvider.cpp:
(WebKit::PlugInAutoStartProvider::setAutoStartOriginsArray):
* UIProcess/Plugins/PlugInAutoStartProvider.h:
* UIProcess/Plugins/WebPluginSiteDataManager.cpp:
(WebKit::WebPluginSiteDataManager::didGetSitesWithData):
(WebKit::WebPluginSiteDataManager::clearSiteData):
* UIProcess/Plugins/WebPluginSiteDataManager.h:
* UIProcess/StatisticsRequest.cpp:
(WebKit::StatisticsRequest::completedRequest):
* UIProcess/WebApplicationCacheManagerProxy.h:
* UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::backListAsImmutableArrayWithLimit):
(WebKit::WebBackForwardList::forwardListAsImmutableArrayWithLimit):
* UIProcess/WebBackForwardList.h:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::setPlugInAutoStartOrigins):
(WebKit::WebContext::pluginInfoStoreDidLoadPlugins):
* UIProcess/WebContext.h:
* UIProcess/WebContextClient.cpp:
(WebKit::WebContextClient::plugInInformationBecameAvailable):
* UIProcess/WebContextClient.h:
* UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::didGetHostnamesWithCookies):
* UIProcess/WebCookieManagerProxy.h:
* UIProcess/WebDatabaseManagerProxy.cpp:
(WebKit::WebDatabaseManagerProxy::didGetDatabasesByOrigin):
(WebKit::WebDatabaseManagerProxy::didGetDatabaseOrigins):
* UIProcess/WebFindClient.cpp:
(WebKit::WebFindMatchesClient::didFindStringMatches):
* UIProcess/WebFindClient.h:
* UIProcess/WebFrameProxy.h:
* UIProcess/WebKeyValueStorageManager.cpp:
(WebKit::didGetKeyValueStorageOrigins):
* UIProcess/WebKeyValueStorageManager.h:
* UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::didChangeBackForwardList):
* UIProcess/WebMediaCacheManagerProxy.cpp:
(WebKit::WebMediaCacheManagerProxy::didGetHostnamesWithMediaCache):
* UIProcess/WebMediaCacheManagerProxy.h:
* UIProcess/WebOpenPanelResultListenerProxy.cpp:
(WebKit::WebOpenPanelResultListenerProxy::chooseFiles):
* UIProcess/WebOpenPanelResultListenerProxy.h:
* UIProcess/WebOriginDataManagerProxy.h:
* UIProcess/WebPageContextMenuClient.cpp:
(WebKit::WebPageContextMenuClient::getContextMenuFromProposedMenu):
(WebKit::WebPageContextMenuClient::showContextMenu):
* UIProcess/WebPageGroup.cpp:
(WebKit::toStringVector):
(WebKit::WebPageGroup::addUserStyleSheet):
(WebKit::WebPageGroup::addUserScript):
* UIProcess/WebPageGroup.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::relatedPages):
(WebKit::WebPageProxy::didFindStringMatches):
* UIProcess/WebPageProxy.h:
* UIProcess/WebResourceCacheManagerProxy.cpp:
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleCopyOriginsWithApplicationCache):
* WebProcess/InjectedBundle/API/c/WKBundleBackForwardListItem.cpp:
* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(contextMenuItems):
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::originsWithApplicationCache):
(WebKit::toStringVector):
(WebKit::InjectedBundle::addUserScript):
(WebKit::InjectedBundle::addUserStyleSheet):
* WebProcess/InjectedBundle/InjectedBundle.h:
* WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.cpp:
(WebKit::InjectedBundleBackForwardListItem::children):
* WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.h:
* WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.cpp:
(WebKit::InjectedBundlePageContextMenuClient::getCustomMenuFromDefaultItems):
* WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:
(WebKit::InjectedBundlePageEditorClient::getPasteboardDataForRange):
* WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:
(WebKit::InjectedBundlePageFormClient::didAssociateFormControls):
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::featuresUsedInPage):
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::findLargestFrameInFrameSet):
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::childFrames):
* WebProcess/WebPage/WebFrame.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::trackedRepaintRects):
* WebProcess/WebPage/WebPage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Split Inspector.json into individual domain json files
joepeck@webkit.org [Wed, 13 Nov 2013 21:40:41 +0000 (21:40 +0000)]
Web Inspector: Split Inspector.json into individual domain json files
https://bugs.webkit.org/show_bug.cgi?id=124098

Reviewed by Timothy Hatcher.

Source/WebCore:

Split the Inspector domains into their own json file. Generate a
combined Inspector.json from all of the json files at build time
so that the CodeGenerator is unchanged.

* .gitattributes:
* CMakeLists.txt:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.xcodeproj/project.pbxproj:
* inspector/CodeGeneratorInspector.py:
(TypeMap.__init__):
* inspector/Inspector.json: Removed.
* inspector/Scripts/generate-combined-inspector-json.py: Added.
* inspector/protocol/ApplicationCache.json: Added.
* inspector/protocol/CSS.json: Added.
* inspector/protocol/Canvas.json: Added.
* inspector/protocol/Console.json: Added.
* inspector/protocol/DOM.json: Added.
* inspector/protocol/DOMDebugger.json: Added.
* inspector/protocol/DOMStorage.json: Added.
* inspector/protocol/Database.json: Added.
* inspector/protocol/Debugger.json: Added.
* inspector/protocol/FileSystem.json: Added.
* inspector/protocol/HeapProfiler.json: Added.
* inspector/protocol/IndexedDB.json: Added.
* inspector/protocol/Input.json: Added.
* inspector/protocol/InspectorDomain.json: Added.
* inspector/protocol/LayerTree.json: Added.
* inspector/protocol/Memory.json: Added.
* inspector/protocol/Network.json: Added.
* inspector/protocol/Page.json: Added.
* inspector/protocol/Profiler.json: Added.
* inspector/protocol/Runtime.json: Added.
* inspector/protocol/Timeline.json: Added.
* inspector/protocol/Worker.json: Added.

Source/WebInspectorUI:

Removed now stale comments referring to the combined Inspector.json.
Make update-InspectorBackendCommands helper script generate a
combined Inspector.json to still work for tip of tree.

* Scripts/update-InspectorBackendCommands.rb:
* UserInterface/ApplicationCacheObserver.js:
* UserInterface/CSSObserver.js:
* UserInterface/CanvasObserver.js:
* UserInterface/ConsoleObserver.js:
* UserInterface/DOMObserver.js:
* UserInterface/DOMStorageObserver.js:
* UserInterface/DatabaseObserver.js:
* UserInterface/DebuggerObserver.js:
* UserInterface/InspectorBackendCommands.js:
* UserInterface/InspectorObserver.js:
* UserInterface/LayerTreeObserver.js:
* UserInterface/NetworkObserver.js:
* UserInterface/PageObserver.js:
* UserInterface/ProfilerObserver.js:
* UserInterface/Resource.js:
* UserInterface/RuntimeObserver.js:
* UserInterface/TimelineObserver.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove a crash expectation from a test that seems fixed by r159218.
timothy_horton@apple.com [Wed, 13 Nov 2013 21:33:35 +0000 (21:33 +0000)]
Remove a crash expectation from a test that seems fixed by r159218.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCode cleanup: change FrameView::doLayoutWithFrameFlattening() to make it more explicit.
zalan@apple.com [Wed, 13 Nov 2013 21:28:55 +0000 (21:28 +0000)]
Code cleanup: change FrameView::doLayoutWithFrameFlattening() to make it more explicit.
https://bugs.webkit.org/show_bug.cgi?id=124238

Reviewed by Simon Fraser.

Rename doLayoutWithFrameFlattening() and change its signature so that it's inline with
what it does.

Covered by existing tests.

* page/FrameView.cpp:
(WebCore::FrameView::layout):
(WebCore::FrameView::startLayoutAtMainFrameViewIfNeeded):
* page/FrameView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoModifying RTCSessionDescription object construction to match the spec
commit-queue@webkit.org [Wed, 13 Nov 2013 21:26:48 +0000 (21:26 +0000)]
Modifying RTCSessionDescription object construction to match the spec
https://bugs.webkit.org/show_bug.cgi?id=124212

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-13
Reviewed by Eric Carlson.

According to the spec the RTCSessionDescriptionInit parameter in RTCSessionDescription constructor is optional,
which must not be nullable. If the 'type' and/or 'sdp' keys are not present, the string object that stores
them in the RTCSessionDescription class, must be null in those cases. Also, if an object that is not a
Dictionary is passed as argument to the constructor, an exception must be raised.

Source/WebCore:

Existing test was updated.

* GNUmakefile.list.am:
* Modules/mediastream/RTCSessionDescription.cpp:
(WebCore::RTCSessionDescription::create):
* Modules/mediastream/RTCSessionDescription.idl:
* UseJSC.cmake:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSRTCSessionDescriptionCustom.cpp: Added.
(WebCore::JSRTCSessionDescriptionConstructor::constructJSRTCSessionDescription):

LayoutTests:

* fast/mediastream/RTCSessionDescription-expected.txt:
* fast/mediastream/RTCSessionDescription.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Fix build after r159222
commit-queue@webkit.org [Wed, 13 Nov 2013 21:26:33 +0000 (21:26 +0000)]
[GTK] Fix build after r159222
https://bugs.webkit.org/show_bug.cgi?id=124305

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-13
Reviewed by Tim Horton.

WebGraphicsContext and its API has been removed.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Shared/API/c/gtk/WKGraphicsContextGtk.cpp: Removed.
* Shared/API/c/gtk/WKGraphicsContextGtk.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove redundant return after r159173
timothy_horton@apple.com [Wed, 13 Nov 2013 21:22:04 +0000 (21:22 +0000)]
Remove redundant return after r159173
https://bugs.webkit.org/show_bug.cgi?id=124303

Reviewed by Geoff Garen.

* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::loadResourceSynchronously):
Remove redundant return.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed EFL build fix after r159222.
m.pakula@samsung.com [Wed, 13 Nov 2013 20:58:11 +0000 (20:58 +0000)]
Unreviewed EFL build fix after r159222.

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix release build after r159224.
timothy_horton@apple.com [Wed, 13 Nov 2013 20:54:27 +0000 (20:54 +0000)]
Fix release build after r159224.

* WebCore.exp.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix debug build.
oliver@apple.com [Wed, 13 Nov 2013 20:44:55 +0000 (20:44 +0000)]
Fix debug build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove ChromeClient::paintCustomOverhangArea
andersca@apple.com [Wed, 13 Nov 2013 20:44:41 +0000 (20:44 +0000)]
Remove ChromeClient::paintCustomOverhangArea
https://bugs.webkit.org/show_bug.cgi?id=124304

Reviewed by Beth Dakin.

This function always returns false now; get rid of it.

* page/Chrome.cpp:
* page/ChromeClient.h:
* page/FrameView.cpp:
(WebCore::FrameView::paintOverhangAreas):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove WebGraphicsContext
andersca@apple.com [Wed, 13 Nov 2013 20:29:37 +0000 (20:29 +0000)]
Remove WebGraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=124302

Reviewed by Dan Bernstein.

WebGraphicsContext and its API "object", WKGraphicsContextRef was only used
for the overhang paint callback which has been removed.

* Shared/API/c/WKDeprecatedFunctions.cpp:
(WKGraphicsContextGetCGContext):
* Shared/API/c/WKGraphicsContext.cpp: Removed.
* Shared/API/c/WKGraphicsContext.h: Removed.
* Shared/API/c/cg/WKGraphicsContextCG.cpp: Removed.
* Shared/API/c/cg/WKGraphicsContextCG.h: Removed.
* Shared/APIObject.h:
* Shared/WebGraphicsContext.cpp: Removed.
* Shared/WebGraphicsContext.h: Removed.
* UIProcess/API/C/WebKit2_C.h:
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[MathML] The double bar vertical delimiter does not stretch properly
mrobinson@webkit.org [Wed, 13 Nov 2013 20:23:47 +0000 (20:23 +0000)]
[MathML] The double bar vertical delimiter does not stretch properly
https://bugs.webkit.org/show_bug.cgi?id=123543

Reviewed by Chris Fleizach.

Source/WebCore:

* rendering/mathml/RenderMathMLOperator.cpp: Add stretching support for U+2225, which
is another version of the vertical bar.

LayoutTests:

* mathml/presentation/mo-stretch.html: Add &DoubleVerticalBar; to this test,
which covers the other version of the vertical bar.
* platform/gtk/mathml/presentation/mo-stretch-expected.png:
* platform/gtk/mathml/presentation/mo-stretch-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoASSERTION FAILED: m_repaintRect == renderer().clippedOverflowRectForRepaint(renderer...
simon.fraser@apple.com [Wed, 13 Nov 2013 20:03:53 +0000 (20:03 +0000)]
ASSERTION FAILED: m_repaintRect == renderer().clippedOverflowRectForRepaint(renderer().containerForRepaint()) after r135816
https://bugs.webkit.org/show_bug.cgi?id=103432

Reviewed by Dave Hyatt.

RenderLayer caches repaint rects in m_repaintRect, and on updating layer
positions after scrolling, asserts that the cached rect is correct. However,
this assertion would sometimes fail if we were scrolling as a result of
doing adjustViewSize() in the middle of layout, because we haven't updated
layer positions post-layout yet.

Fix by having the poorly named FrameView::repaintFixedElementsAfterScrolling()
skip the layer updating if this FrameView is inside of adjusetViewSize() in
layout.

In order to know if we're inside view size adjusting, add a LayoutPhase
member to FrameView, replacing two existing bools that track laying out state.

Investigative work showed that there are many, many ways to re-enter FrameView::layout(),
which makes it hard (but desirable) to more assertions about state changes, but
indicated that saving and restoring the state (via TemporaryChange<LayoutPhase>)
was a good idea.

* page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::reset):
(WebCore::FrameView::updateCompositingLayersAfterStyleChange):
(WebCore::FrameView::layout):
(WebCore::FrameView::repaintFixedElementsAfterScrolling):
* page/FrameView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWKArrayIsMutable should not be mangled
andersca@apple.com [Wed, 13 Nov 2013 20:03:43 +0000 (20:03 +0000)]
WKArrayIsMutable should not be mangled
https://bugs.webkit.org/show_bug.cgi?id=124299

Reviewed by Andreas Kling.

* Shared/API/c/WKDeprecatedFunctions.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agor159210 added a period where there previously wasn't one, breaking >100 tests
timothy_horton@apple.com [Wed, 13 Nov 2013 20:01:49 +0000 (20:01 +0000)]
r159210 added a period where there previously wasn't one, breaking >100 tests

Rubber-stamped by Oliver Hunt.

* parser/Parser.cpp:
(JSC::::logError):
Remove the extra period.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Windows] Unreviewed gardening of some canvas tests.
roger_fong@apple.com [Wed, 13 Nov 2013 19:54:16 +0000 (19:54 +0000)]
[Windows] Unreviewed gardening of some canvas tests.

* platform/win/fast/canvas/canvas-draw-canvas-on-canvas-shadow-expected.txt:
* platform/win/fast/canvas/canvas-fillRect-gradient-shadow-expected.txt:
* platform/win/fast/canvas/canvas-render-layer-expected.txt:
* platform/win/fast/canvas/canvas-scale-shadowBlur-expected.txt:
* platform/win/fast/canvas/canvas-scale-strokePath-shadow-expected.txt:
* platform/win/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt:
* platform/win/fast/canvas/canvas-strokeRect-alpha-shadow-expected.txt:
* platform/win/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt:
* platform/win/fast/forms/range/slider-mouse-events-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159215 268f45cc-cd09-0410-ab3c-d52691b4dbfc