WebKit-https.git
6 years agoFix compilation with new MSVC compiler for Windows CE
paroga@webkit.org [Thu, 26 Sep 2013 02:03:45 +0000 (02:03 +0000)]
Fix compilation with new MSVC compiler for Windows CE
https://bugs.webkit.org/show_bug.cgi?id=121914

Reviewed by Darin Adler.

Remove code to support older Windows CE versions, since those old
versions do not support C+11, which is required in the meantime.

* wtf/Atomics.h:
* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agohtmlediting.cpp: unnecessary local variable cleanup
commit-queue@webkit.org [Thu, 26 Sep 2013 02:01:01 +0000 (02:01 +0000)]
htmlediting.cpp: unnecessary local variable cleanup
https://bugs.webkit.org/show_bug.cgi?id=121903

Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-09-25
Reviewed by Darin Adler.

Code cleanup.

* editing/htmlediting.cpp:
(WebCore::lowestEditableAncestor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Windows] Unreviewed Build fix.
roger_fong@apple.com [Thu, 26 Sep 2013 01:49:44 +0000 (01:49 +0000)]
[Windows] Unreviewed Build fix.

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemoved check for Apple Application Support directory in WinCairo port.
commit-queue@webkit.org [Thu, 26 Sep 2013 01:05:12 +0000 (01:05 +0000)]
Removed check for Apple Application Support directory in WinCairo port.
https://bugs.webkit.org/show_bug.cgi?id=121869

Patch by Alex Christensen <achristensen@webkit.org> on 2013-09-25
Reviewed by Brent Fulgham.

* DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
* DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
* WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
Use DLLLauncherWinCairo.props for WinCairo ports.
* win/DLLLauncher/DLLLauncherMain.cpp:
(wWinMain):
Don't call modifyPath to check for AAS in the WinCairo port.
* win/DLLLauncher/DLLLauncherWinCairo.props: Added to define WIN_CAIRO.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r156432.
commit-queue@webkit.org [Thu, 26 Sep 2013 01:03:17 +0000 (01:03 +0000)]
Unreviewed, rolling out r156432.
http://trac.webkit.org/changeset/156432
https://bugs.webkit.org/show_bug.cgi?id=121932

some integer conversion things that need brady to fix
(Requested by thorton on #webkit).

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:
* Modules/indexeddb/IDBFactory.h:
(WebCore::IDBFactory::create):
* WebCore.xcodeproj/project.pbxproj:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove KeyValuePairTraits inside HashMap
andersca@apple.com [Thu, 26 Sep 2013 00:53:43 +0000 (00:53 +0000)]
Move KeyValuePairTraits inside HashMap
https://bugs.webkit.org/show_bug.cgi?id=121931

Reviewed by Sam Weinig.

Source/JavaScriptCore:

* tools/ProfileTreeNode.h:

Source/WTF:

Also rename the ValueType typedef to KeyValuePairType since it's always a key value pair.

* wtf/HashMap.h:
(WTF::HashMap::KeyValuePairTraits::isEmptyValue):
(WTF::HashMap::find):
(WTF::HashMap::contains):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoEnabled AssembleBuildLogs on WinCairo port.
commit-queue@webkit.org [Thu, 26 Sep 2013 00:48:27 +0000 (00:48 +0000)]
Enabled AssembleBuildLogs on WinCairo port.
https://bugs.webkit.org/show_bug.cgi?id=121923

Patch by Alex Christensen <achristensen@webkit.org> on 2013-09-25
Reviewed by Brent Fulgham.

Source/WebKit:

* WebKit.vcxproj/WebKit.sln:
Build AssembleBuildLogs in WinCairo port.

Tools:

* win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
Fixed reference to README, added WinCairo configurations.
* win/AssembleBuildLogs/AssembleBuildLogs.vcxproj.filters:
Fixed reference to README.
* win/AssembleBuildLogs/AssembleLogs.cmd:
Added ANGLE projects, skipped QTMovieWin for WinCairo, use PlatformArchitecture for Win64.
* win/AssembleBuildLogs/README: Fixed spelling.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWin64 compile fix after r155226.
alex.christensen@flexsim.com [Thu, 26 Sep 2013 00:41:44 +0000 (00:41 +0000)]
Win64 compile fix after r155226.
https://bugs.webkit.org/show_bug.cgi?id=120969

Reviewed by Brent Fulgham.

* WebCore.vcxproj/WebCore.vcxproj:
Disable building StructuredExceptionHandlerSuppressor.cpp and makesafeseh.asm on Win64.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFlaky Test: platform/mac/fonts/han-disunification.html
ap@apple.com [Wed, 25 Sep 2013 23:51:46 +0000 (23:51 +0000)]
Flaky Test: platform/mac/fonts/han-disunification.html
https://bugs.webkit.org/show_bug.cgi?id=114207

Reviewed by Anders Carlsson.

This test was affected by preceding tests changing font settings.

Save original font if it's changed, and restore it in Backup::restoreTo().

* WebCore.exp.in:
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setStandardFontFamily):
(WebCore::InternalSettings::setSerifFontFamily):
(WebCore::InternalSettings::setSansSerifFontFamily):
(WebCore::InternalSettings::setFixedFontFamily):
(WebCore::InternalSettings::setCursiveFontFamily):
(WebCore::InternalSettings::setFantasyFontFamily):
(WebCore::InternalSettings::setPictographFontFamily):
* testing/InternalSettings.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUn-indent HashMap.h.
andersca@apple.com [Wed, 25 Sep 2013 23:26:48 +0000 (23:26 +0000)]
Un-indent HashMap.h.

Rubber-stamped by Andreas Kling.

* wtf/HashMap.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Windows] Attempting to scroll from a non-scrollable layer results the main document...
roger_fong@apple.com [Wed, 25 Sep 2013 23:24:48 +0000 (23:24 +0000)]
[Windows] Attempting to scroll from a non-scrollable layer results the main document getting scrolled.
https://bugs.webkit.org/show_bug.cgi?id=121889.
<rdar://problem/15072441>

* WebView.cpp:
(WebView::gesture):
Call scrollByRecursively on the current RenderLayer's enclosingScrollableLayer to make sure that the method
doesn't bail early and end up just scrolling the main document instead of the next scrollable layer in the RenderLayer tree.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoEnable the IndexedDB build on Mac, but leave the feature non-functional
beidson@apple.com [Wed, 25 Sep 2013 23:21:55 +0000 (23:21 +0000)]
Enable the IndexedDB build on Mac, but leave the feature non-functional
https://bugs.webkit.org/show_bug.cgi?id=121918

Reviewed by Alexey Proskuryakov.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig: Enable the feature.

* Modules/indexeddb/IDBFactory.h:
(WebCore::IDBFactory::create): If the IDBFactoryBackend is null (which it is for on-levelDB platforms),
  don't create an IDBFactory. This hides the feature from javascript even though upport code is in the build.

* WebCore.xcodeproj/project.pbxproj: Remove the Modules/indexedDB/leveldb directory now that Mac has no
  further use for it.

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFlaky Test: fast/history/history-subframe-with-name.html
ap@apple.com [Wed, 25 Sep 2013 23:18:39 +0000 (23:18 +0000)]
Flaky Test: fast/history/history-subframe-with-name.html
https://bugs.webkit.org/show_bug.cgi?id=51039

Reviewed by Brady Eidson.

* fast/history/history-subframe-with-name.html: In state 3, there was a race between
history.forward() and navigating to a new URL. Not sure how this resulted in an
extra load, but let's get rid of that. Also, extended failure logging.

* fast/history/resources/history-subframe-with-name-2.html: No longer do the
navigation unconditionally. We need it in state 1, but not in state 3.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WIN] Replace CF time functions with Windows API functions in WebHistory
paroga@webkit.org [Wed, 25 Sep 2013 23:18:10 +0000 (23:18 +0000)]
[WIN] Replace CF time functions with Windows API functions in WebHistory
https://bugs.webkit.org/show_bug.cgi?id=121599

Reviewed by Brent Fulgham.

This reduces the dependencies on the CoreFoundation library.

* WebHistory.cpp:
(addDayToSystemTime):
(getDayBoundaries):
(beginningOfDay):
(dateKey):
(WebHistory::orderedLastVisitedDays):
* WebHistory.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUn-indent HashTraits.h.
andersca@apple.com [Wed, 25 Sep 2013 22:54:54 +0000 (22:54 +0000)]
Un-indent HashTraits.h.

Rubber-stamped by Andreas Kling.

* wtf/HashTraits.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix the build.
timothy@apple.com [Wed, 25 Sep 2013 22:51:04 +0000 (22:51 +0000)]
Fix the build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMake EventTarget::hasEventListeners() a const method.
akling@apple.com [Wed, 25 Sep 2013 22:42:45 +0000 (22:42 +0000)]
Make EventTarget::hasEventListeners() a const method.

This class needs a lot of love in the const correctness department
but for now let's limit ourselves to fixing the IndexedDB build.

* dom/EventTarget.h:
(WebCore::EventTarget::hasEventListeners):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Disable more CSS_SHAPES tests on AppleWin port.
roger_fong@apple.com [Wed, 25 Sep 2013 22:35:59 +0000 (22:35 +0000)]
Unreviewed. Disable more CSS_SHAPES tests on AppleWin port.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDoYouEvenBench: Add a test case for FlightJS
rniwa@webkit.org [Wed, 25 Sep 2013 22:18:52 +0000 (22:18 +0000)]
DoYouEvenBench: Add a test case for FlightJS
https://bugs.webkit.org/show_bug.cgi?id=121926

Reviewed by Antti Koivisto.

Add a FlightJS test case.

* DoYouEvenBench/benchmark.html:
* DoYouEvenBench/benchmark.js:
* DoYouEvenBench/flightjs-example-app: Added.
* DoYouEvenBench/flightjs-example-app/LICENSE.md: Added.
* DoYouEvenBench/flightjs-example-app/README.md: Added.
* DoYouEvenBench/flightjs-example-app/app: Added.
* DoYouEvenBench/flightjs-example-app/app/boot: Added.
* DoYouEvenBench/flightjs-example-app/app/boot/page.js: Added.
* DoYouEvenBench/flightjs-example-app/app/component_data: Added.
* DoYouEvenBench/flightjs-example-app/app/component_data/compose_box.js: Added.
* DoYouEvenBench/flightjs-example-app/app/component_data/mail_items.js: Added.
* DoYouEvenBench/flightjs-example-app/app/component_data/move_to.js: Added.
* DoYouEvenBench/flightjs-example-app/app/component_ui: Added.
* DoYouEvenBench/flightjs-example-app/app/component_ui/compose_box.js: Added.
* DoYouEvenBench/flightjs-example-app/app/component_ui/folders.js: Added.
* DoYouEvenBench/flightjs-example-app/app/component_ui/mail_controls.js: Added.
* DoYouEvenBench/flightjs-example-app/app/component_ui/mail_items.js: Added.
* DoYouEvenBench/flightjs-example-app/app/component_ui/move_to_selector.js: Added.
* DoYouEvenBench/flightjs-example-app/app/component_ui/with_select.js: Added.
* DoYouEvenBench/flightjs-example-app/app/css: Added.
* DoYouEvenBench/flightjs-example-app/app/css/custom.css: Added.
* DoYouEvenBench/flightjs-example-app/app/data.js: Added.
* DoYouEvenBench/flightjs-example-app/app/templates.js: Added.
* DoYouEvenBench/flightjs-example-app/components: Added.
* DoYouEvenBench/flightjs-example-app/components/bootstrap: Added.
* DoYouEvenBench/flightjs-example-app/components/bootstrap/css: Added.
* DoYouEvenBench/flightjs-example-app/components/bootstrap/css/bootstrap-responsive.css: Added.
* DoYouEvenBench/flightjs-example-app/components/bootstrap/css/bootstrap-responsive.min.css: Added.
* DoYouEvenBench/flightjs-example-app/components/bootstrap/css/bootstrap.css: Added.
* DoYouEvenBench/flightjs-example-app/components/bootstrap/css/bootstrap.min.css: Added.
* DoYouEvenBench/flightjs-example-app/components/bootstrap/img: Added.
* DoYouEvenBench/flightjs-example-app/components/bootstrap/img/glyphicons-halflings-white.png: Added.
* DoYouEvenBench/flightjs-example-app/components/bootstrap/img/glyphicons-halflings.png: Added.
* DoYouEvenBench/flightjs-example-app/components/bootstrap/js: Added.
* DoYouEvenBench/flightjs-example-app/components/bootstrap/js/bootstrap.js: Added.
* DoYouEvenBench/flightjs-example-app/components/bootstrap/js/bootstrap.min.js: Added.
* DoYouEvenBench/flightjs-example-app/components/es5-shim: Added.
* DoYouEvenBench/flightjs-example-app/components/es5-shim/.gitignore: Added.
* DoYouEvenBench/flightjs-example-app/components/es5-shim/CHANGES: Added.
* DoYouEvenBench/flightjs-example-app/components/es5-shim/CONTRIBUTORS.md: Added.
* DoYouEvenBench/flightjs-example-app/components/es5-shim/LICENSE: Added.
* DoYouEvenBench/flightjs-example-app/components/es5-shim/README.md: Added.
* DoYouEvenBench/flightjs-example-app/components/es5-shim/component.json: Added.
* DoYouEvenBench/flightjs-example-app/components/es5-shim/es5-sham.js: Added.
* DoYouEvenBench/flightjs-example-app/components/es5-shim/es5-sham.min.js: Added.
* DoYouEvenBench/flightjs-example-app/components/es5-shim/es5-shim.js: Added.
* DoYouEvenBench/flightjs-example-app/components/es5-shim/es5-shim.min.js: Added.
* DoYouEvenBench/flightjs-example-app/components/es5-shim/package.json: Added.
* DoYouEvenBench/flightjs-example-app/components/es5-shim/tests: Added.
* DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/helpers: Added.
* DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/helpers/h-kill.js: Added.
* DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/helpers/h-matchers.js: Added.
* DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/helpers/h.js: Added.
* DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/index.html: Added.
* DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/lib: Added.
* DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/lib/jasmine-html.js: Added.
* DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/lib/jasmine.css: Added.
* DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/lib/jasmine.js: Added.
* DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/lib/jasmine_favicon.png: Added.
* DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/lib/json2.js: Added.
* DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/spec: Added.
* DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/spec/s-array.js: Added.
* DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/spec/s-date.js: Added.
* DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/spec/s-function.js: Added.
* DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/spec/s-object.js: Added.
* DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/spec/s-string.js: Added.
* DoYouEvenBench/flightjs-example-app/components/flight: Added.
* DoYouEvenBench/flightjs-example-app/components/flight/.travis.yml: Added.
* DoYouEvenBench/flightjs-example-app/components/flight/lib: Added.
* DoYouEvenBench/flightjs-example-app/components/flight/lib/advice.js: Added.
* DoYouEvenBench/flightjs-example-app/components/flight/lib/component.js: Added.
* DoYouEvenBench/flightjs-example-app/components/flight/lib/compose.js: Added.
* DoYouEvenBench/flightjs-example-app/components/flight/lib/index.js: Added.
* DoYouEvenBench/flightjs-example-app/components/flight/lib/logger.js: Added.
* DoYouEvenBench/flightjs-example-app/components/flight/lib/registry.js: Added.
* DoYouEvenBench/flightjs-example-app/components/flight/lib/utils.js: Added.
* DoYouEvenBench/flightjs-example-app/components/flight/tools: Added.
* DoYouEvenBench/flightjs-example-app/components/flight/tools/debug: Added.
* DoYouEvenBench/flightjs-example-app/components/flight/tools/debug/debug.js: Added.
* DoYouEvenBench/flightjs-example-app/components/jasmine-flight: Added.
* DoYouEvenBench/flightjs-example-app/components/jasmine-flight/LICENSE.md: Added.
* DoYouEvenBench/flightjs-example-app/components/jasmine-flight/README.md: Added.
* DoYouEvenBench/flightjs-example-app/components/jasmine-flight/bower.json: Added.
* DoYouEvenBench/flightjs-example-app/components/jasmine-flight/lib: Added.
* DoYouEvenBench/flightjs-example-app/components/jasmine-flight/lib/jasmine-flight.js: Added.
* DoYouEvenBench/flightjs-example-app/components/jasmine-jquery: Added.
* DoYouEvenBench/flightjs-example-app/components/jasmine-jquery/lib: Added.
* DoYouEvenBench/flightjs-example-app/components/jasmine-jquery/lib/jasmine-jquery.js: Added.
* DoYouEvenBench/flightjs-example-app/components/jquery: Added.
* DoYouEvenBench/flightjs-example-app/components/jquery/component.json: Added.
* DoYouEvenBench/flightjs-example-app/components/jquery/composer.json: Added.
* DoYouEvenBench/flightjs-example-app/components/jquery/jquery.js: Added.
* DoYouEvenBench/flightjs-example-app/components/jquery/jquery.min.js: Added.
* DoYouEvenBench/flightjs-example-app/components/mustache: Added.
* DoYouEvenBench/flightjs-example-app/components/mustache/mustache.js: Added.
* DoYouEvenBench/flightjs-example-app/components/requirejs: Added.
* DoYouEvenBench/flightjs-example-app/components/requirejs/require.js: Added.
* DoYouEvenBench/flightjs-example-app/index.html: Added.
* DoYouEvenBench/flightjs-example-app/karma.conf.js: Added.
* DoYouEvenBench/flightjs-example-app/package.json: Added.
* DoYouEvenBench/flightjs-example-app/requireMain.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago../WebCore: [Windows] Refactor RuntimeEnabledFeatures as a Singleton
bfulgham@apple.com [Wed, 25 Sep 2013 22:18:34 +0000 (22:18 +0000)]
../WebCore: [Windows] Refactor RuntimeEnabledFeatures as a Singleton
https://bugs.webkit.org/show_bug.cgi?id=121883

Windows is experiencing crashes when client programs (such as
DumpRenderTree) attemp to change settings on the RuntimeEnabledFeatures
object. The inlined static accessor methods are not accessing
memory safely (when compiled by Visual Studio) resulting in
crashes.

Reviewed by Jer Noble.

* WebCore.exp.in: Remove static accessors for RuntimeEnabledFeatures.
* bindings/generic/RuntimeEnabledFeatures.cpp: Switch methods to
conform to a singleton pattern.
(WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::sharedRuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::fileSystemEnabled):
(WebCore::RuntimeEnabledFeatures::javaScriptI18NAPIEnabled):
(WebCore::RuntimeEnabledFeatures::audioEnabled):
(WebCore::RuntimeEnabledFeatures::htmlMediaElementEnabled):
(WebCore::RuntimeEnabledFeatures::htmlAudioElementEnabled):
(WebCore::RuntimeEnabledFeatures::htmlVideoElementEnabled):
(WebCore::RuntimeEnabledFeatures::htmlSourceElementEnabled):
(WebCore::RuntimeEnabledFeatures::mediaControllerEnabled):
(WebCore::RuntimeEnabledFeatures::mediaErrorEnabled):
(WebCore::RuntimeEnabledFeatures::timeRangesEnabled):
(WebCore::RuntimeEnabledFeatures::sharedWorkerEnabled):
(WebCore::RuntimeEnabledFeatures::webSocketEnabled):
(WebCore::RuntimeEnabledFeatures::openDatabaseEnabled):
(WebCore::RuntimeEnabledFeatures::openDatabaseSyncEnabled):
* bindings/generic/RuntimeEnabledFeatures.h: Ditto.
(WebCore::RuntimeEnabledFeatures::setLocalStorageEnabled):
(WebCore::RuntimeEnabledFeatures::localStorageEnabled):
(WebCore::RuntimeEnabledFeatures::setSessionStorageEnabled):
(WebCore::RuntimeEnabledFeatures::sessionStorageEnabled):
(WebCore::RuntimeEnabledFeatures::setWebkitNotificationsEnabled):
(WebCore::RuntimeEnabledFeatures::webkitNotificationsEnabled):
(WebCore::RuntimeEnabledFeatures::setApplicationCacheEnabled):
(WebCore::RuntimeEnabledFeatures::applicationCacheEnabled):
(WebCore::RuntimeEnabledFeatures::setDataTransferItemsEnabled):
(WebCore::RuntimeEnabledFeatures::dataTransferItemsEnabled):
(WebCore::RuntimeEnabledFeatures::setGeolocationEnabled):
(WebCore::RuntimeEnabledFeatures::geolocationEnabled):
(WebCore::RuntimeEnabledFeatures::setWebkitIndexedDBEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIndexedDBEnabled):
(WebCore::RuntimeEnabledFeatures::indexedDBEnabled):
(WebCore::RuntimeEnabledFeatures::setCanvasPathEnabled):
(WebCore::RuntimeEnabledFeatures::canvasPathEnabled):
(WebCore::RuntimeEnabledFeatures::setCSSExclusionsEnabled):
(WebCore::RuntimeEnabledFeatures::cssExclusionsEnabled):
(WebCore::RuntimeEnabledFeatures::setCSSShapesEnabled):
(WebCore::RuntimeEnabledFeatures::cssShapesEnabled):
(WebCore::RuntimeEnabledFeatures::setCSSRegionsEnabled):
(WebCore::RuntimeEnabledFeatures::cssRegionsEnabled):
(WebCore::RuntimeEnabledFeatures::setCSSCompositingEnabled):
(WebCore::RuntimeEnabledFeatures::cssCompositingEnabled):
(WebCore::RuntimeEnabledFeatures::setFontLoadEventsEnabled):
(WebCore::RuntimeEnabledFeatures::fontLoadEventsEnabled):
(WebCore::RuntimeEnabledFeatures::webkitFullScreenAPIEnabled):
(WebCore::RuntimeEnabledFeatures::setWebkitFullScreenAPIEnabled):
(WebCore::RuntimeEnabledFeatures::webkitRequestFullScreenEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIsFullScreenEnabled):
(WebCore::RuntimeEnabledFeatures::webkitFullScreenKeyboardInputAllowedEnabled):
(WebCore::RuntimeEnabledFeatures::webkitCurrentFullScreenElementEnabled):
(WebCore::RuntimeEnabledFeatures::webkitCancelFullScreenEnabled):
(WebCore::RuntimeEnabledFeatures::webkitFullscreenEnabledEnabled):
(WebCore::RuntimeEnabledFeatures::webkitFullscreenElementEnabled):
(WebCore::RuntimeEnabledFeatures::webkitExitFullscreenEnabled):
(WebCore::RuntimeEnabledFeatures::webkitRequestFullscreenEnabled):
(WebCore::RuntimeEnabledFeatures::touchEnabled):
(WebCore::RuntimeEnabledFeatures::setTouchEnabled):
(WebCore::RuntimeEnabledFeatures::setDeviceMotionEnabled):
(WebCore::RuntimeEnabledFeatures::deviceMotionEnabled):
(WebCore::RuntimeEnabledFeatures::deviceMotionEventEnabled):
(WebCore::RuntimeEnabledFeatures::ondevicemotionEnabled):
(WebCore::RuntimeEnabledFeatures::setDeviceOrientationEnabled):
(WebCore::RuntimeEnabledFeatures::deviceOrientationEnabled):
(WebCore::RuntimeEnabledFeatures::deviceOrientationEventEnabled):
(WebCore::RuntimeEnabledFeatures::ondeviceorientationEnabled):
(WebCore::RuntimeEnabledFeatures::setSpeechInputEnabled):
(WebCore::RuntimeEnabledFeatures::speechInputEnabled):
(WebCore::RuntimeEnabledFeatures::webkitSpeechEnabled):
(WebCore::RuntimeEnabledFeatures::webkitGrammarEnabled):
(WebCore::RuntimeEnabledFeatures::setScriptedSpeechEnabled):
(WebCore::RuntimeEnabledFeatures::scriptedSpeechEnabled):
(WebCore::RuntimeEnabledFeatures::webkitSpeechRecognitionEnabled):
(WebCore::RuntimeEnabledFeatures::webkitSpeechRecognitionErrorEnabled):
(WebCore::RuntimeEnabledFeatures::webkitSpeechRecognitionEventEnabled):
(WebCore::RuntimeEnabledFeatures::webkitSpeechGrammarEnabled):
(WebCore::RuntimeEnabledFeatures::webkitSpeechGrammarListEnabled):
(WebCore::RuntimeEnabledFeatures::setFileSystemEnabled):
(WebCore::RuntimeEnabledFeatures::setJavaScriptI18NAPIEnabled):
(WebCore::RuntimeEnabledFeatures::mediaStreamEnabled):
(WebCore::RuntimeEnabledFeatures::setMediaStreamEnabled):
(WebCore::RuntimeEnabledFeatures::webkitGetUserMediaEnabled):
(WebCore::RuntimeEnabledFeatures::webkitMediaStreamEnabled):
(WebCore::RuntimeEnabledFeatures::peerConnectionEnabled):
(WebCore::RuntimeEnabledFeatures::setPeerConnectionEnabled):
(WebCore::RuntimeEnabledFeatures::webkitRTCPeerConnectionEnabled):
(WebCore::RuntimeEnabledFeatures::setLegacyCSSVendorPrefixesEnabled):
(WebCore::RuntimeEnabledFeatures::legacyCSSVendorPrefixesEnabled):
(WebCore::RuntimeEnabledFeatures::setWebkitGetGamepadsEnabled):
(WebCore::RuntimeEnabledFeatures::webkitGetGamepadsEnabled):
(WebCore::RuntimeEnabledFeatures::quotaEnabled):
(WebCore::RuntimeEnabledFeatures::setQuotaEnabled):
(WebCore::RuntimeEnabledFeatures::mediaSourceEnabled):
(WebCore::RuntimeEnabledFeatures::setMediaSourceEnabled):
(WebCore::RuntimeEnabledFeatures::encryptedMediaEnabled):
(WebCore::RuntimeEnabledFeatures::setEncryptedMediaEnabled):
(WebCore::RuntimeEnabledFeatures::webkitVideoTrackEnabled):
(WebCore::RuntimeEnabledFeatures::setWebkitVideoTrackEnabled):
(WebCore::RuntimeEnabledFeatures::shadowDOMEnabled):
(WebCore::RuntimeEnabledFeatures::setShadowDOMEnabled):
(WebCore::RuntimeEnabledFeatures::authorShadowDOMForAnyElementEnabled):
(WebCore::RuntimeEnabledFeatures::setAuthorShadowDOMForAnyElementEnabled):
(WebCore::RuntimeEnabledFeatures::customDOMElementsEnabled):
(WebCore::RuntimeEnabledFeatures::setCustomDOMElements):
(WebCore::RuntimeEnabledFeatures::styleScopedEnabled):
(WebCore::RuntimeEnabledFeatures::setStyleScopedEnabled):
(WebCore::RuntimeEnabledFeatures::inputTypeDateEnabled):
(WebCore::RuntimeEnabledFeatures::setInputTypeDateEnabled):
(WebCore::RuntimeEnabledFeatures::inputTypeDateTimeEnabled):
(WebCore::RuntimeEnabledFeatures::setInputTypeDateTimeEnabled):
(WebCore::RuntimeEnabledFeatures::inputTypeDateTimeLocalEnabled):
(WebCore::RuntimeEnabledFeatures::setInputTypeDateTimeLocalEnabled):
(WebCore::RuntimeEnabledFeatures::inputTypeMonthEnabled):
(WebCore::RuntimeEnabledFeatures::setInputTypeMonthEnabled):
(WebCore::RuntimeEnabledFeatures::inputTypeTimeEnabled):
(WebCore::RuntimeEnabledFeatures::setInputTypeTimeEnabled):
(WebCore::RuntimeEnabledFeatures::inputTypeWeekEnabled):
(WebCore::RuntimeEnabledFeatures::setInputTypeWeekEnabled):
(WebCore::RuntimeEnabledFeatures::experimentalContentSecurityPolicyFeaturesEnabled):
(WebCore::RuntimeEnabledFeatures::setExperimentalContentSecurityPolicyFeaturesEnabled):
(WebCore::RuntimeEnabledFeatures::seamlessIFramesEnabled):
(WebCore::RuntimeEnabledFeatures::setSeamlessIFramesEnabled):
(WebCore::RuntimeEnabledFeatures::langAttributeAwareFormControlUIEnabled):
(WebCore::RuntimeEnabledFeatures::setLangAttributeAwareFormControlUIEnabled):
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::getCSSPropertyNamePrefix): Use singleton accessors.
(WebCore::cssPropertyIDForJSCSSPropertyName): Ditto.
* bindings/scripts/CodeGeneratorJS.pm:
(GetRuntimeEnableFunctionName): Generate singleton version of
accessors.
* css/CSSFontFace.cpp:
(WebCore::CSSFontFace::fontLoaded): Use singleton accessors.
(WebCore::CSSFontFace::getFontData): Ditto.
* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule): Ditto.
* css/CSSParser.cpp:
(WebCore::isSimpleLengthPropertyID): Ditto.
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::rewriteSpecifiers):
* css/CSSSegmentedFontFace.cpp:
(WebCore::CSSSegmentedFontFace::fontLoaded): Ditto.
* css/StyleResolver.h:
(WebCore::StyleResolver::ensureScopeResolver): Ditto.
* dom/Document.cpp:
(WebCore::Document::cssRegionsEnabled): Ditto.
(WebCore::Document::cssCompositingEnabled):
(WebCore::Document::shouldDisplaySeamlesslyWithParent):
(WebCore::Document::getCachedLocale):
* dom/Element.cpp:
(WebCore::Element::createShadowRoot): Ditto.
* dom/Position.cpp:
(WebCore::Position::Position): Ditto.
(WebCore::Position::findParent):
* dom/TreeScope.cpp:
(WebCore::TreeScope::getSelection): Ditto.
* dom/make_names.pl:
(printConstructorInterior): Generate singleton version of accessors.
(printWrapperFunctions): Ditto.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::isSpeechEnabled): Use singleton accessors.
(WebCore::HTMLInputElement::setupDateTimeChooserParameters): Ditto.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::finishParsingChildren): Ditto.
(WebCore::HTMLMediaElement::scheduleDelayedAction):
(WebCore::HTMLMediaElement::loadTimerFired):
(WebCore::HTMLMediaElement::prepareForLoad):
(WebCore::HTMLMediaElement::loadInternal):
(WebCore::HTMLMediaElement::setReadyState):
(WebCore::HTMLMediaElement::playbackProgressTimerFired):
(WebCore::HTMLMediaElement::mediaPlayerDidAddAudioTrack):
(WebCore::HTMLMediaElement::mediaPlayerDidAddTextTrack):
(WebCore::HTMLMediaElement::mediaPlayerDidAddVideoTrack):
(WebCore::HTMLMediaElement::addAudioTrack):
(WebCore::HTMLMediaElement::addTextTrack):
(WebCore::HTMLMediaElement::addVideoTrack):
(WebCore::HTMLMediaElement::removeAudioTrack):
(WebCore::HTMLMediaElement::removeTextTrack):
(WebCore::HTMLMediaElement::removeVideoTrack):
(WebCore::HTMLMediaElement::audioTracks):
(WebCore::HTMLMediaElement::textTracks):
(WebCore::HTMLMediaElement::videoTracks):
(WebCore::HTMLMediaElement::didAddTextTrack):
(WebCore::HTMLMediaElement::didRemoveTextTrack):
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
(WebCore::HTMLMediaElement::userCancelledLoad):
(WebCore::HTMLMediaElement::hasClosedCaptions):
(WebCore::HTMLMediaElement::setClosedCaptionsVisible):
(WebCore::HTMLMediaElement::configureTextTrackDisplay):
* html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::parseAttribute): Ditto.
(WebCore::HTMLStyleElement::scopedAttributeChanged):
(WebCore::HTMLStyleElement::unregisterWithScopingNode):
(WebCore::HTMLStyleElement::scoped):
* html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::parseAttribute): Ditto.
(WebCore::HTMLTrackElement::scheduleLoad):
(WebCore::HTMLTrackElement::canLoadUrl):
* html/InputType.cpp:
(WebCore::createInputTypeFactoryMap): Ditto.
* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::experimentalFeaturesEnabled): Ditto.
* page/DOMWindow.cpp:
(WebCore::DOMWindow::addEventListener): Ditto.
* page/FrameView.cpp:
(WebCore::FrameView::performPostLayoutTasks): Ditto.
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup): Ditto.
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setShadowDOMEnabled):
(WebCore::InternalSettings::setAuthorShadowDOMForAnyElementEnabled):
(WebCore::InternalSettings::setStyleScopedEnabled):
(WebCore::InternalSettings::setCSSExclusionsEnabled):
(WebCore::InternalSettings::setCSSShapesEnabled):
(WebCore::InternalSettings::setLangAttributeAwareFormControlUIEnabled):

../WebKit: [Windows] Refactor RuntimeEnabledFeatures as a Singleton
https://bugs.webkit.org/show_bug.cgi?id=121883

Reviewed by Jer Noble.

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Expose singleton accessor for DLL clients.

../WebKit/blackberry: Refactor RuntimeEnabledFeatures as a Singleton.
https://bugs.webkit.org/show_bug.cgi?id=121883.

Reviewed by Jer Noble.

* WebKitSupport/DumpRenderTreeSupport.cpp:
(DumpRenderTreeSupport::setStyleScopedEnabled): use
singleton accessor.

../WebKit/efl: Refactor RuntimeEnabledFeatures as a Singleton.
https://bugs.webkit.org/show_bug.cgi?id=121883.

Reviewed by Jer Noble.

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::setCSSRegionsEnabled): Use singleton.
(DumpRenderTreeSupportEfl::setSeamlessIFramesEnabled): Ditto.
* ewk/ewk_settings.cpp:
(ewk_settings_shadow_dom_enable_get): Ditto.
(ewk_settings_shadow_dom_enable_set):
* ewk/ewk_view.cpp:
(_ewk_view_priv_new): Ditto.

../WebKit/gtk: Refactor RuntimeEnabledFeatures as a Singleton.
https://bugs.webkit.org/show_bug.cgi?id=121883.

Reviewed by Jer Noble.

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::setCSSRegionsEnabled): Use singleton.
(DumpRenderTreeSupportGtk::setExperimentalContentSecurityPolicyFeaturesEnabled):
(DumpRenderTreeSupportGtk::setSeamlessIFramesEnabled):
(DumpRenderTreeSupportGtk::setShadowDOMEnabled):
(DumpRenderTreeSupportGtk::setStyleScopedEnabled):
* webkit/webkitwebview.cpp:
(webkit_web_view_update_settings): Ditto.

../WebKit/mac: Refactor RuntimeEnabledFeatures as a Singleton.
https://bugs.webkit.org/show_bug.cgi?id=121883.

Reviewed by Jer Noble.

* WebView/WebView.mm:
(-[WebView _preferencesChanged:]): Use singleton accessor.
(-[WebView _setDashboardBehavior:to:]): Ditto.

../WebKit/qt: Refactor RuntimeEnabledFeatures as a Singleton.
https://bugs.webkit.org/show_bug.cgi?id=121883.

Reviewed by Jer Noble.

* Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply): Use singleton accessor.
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::setSeamlessIFramesEnabled): Ditto.

../WebKit/win: [Windows] Refactor RuntimeEnabledFeatures as a Singleton.
https://bugs.webkit.org/show_bug.cgi?id=121883

Reviewed by Jer Noble.

* WebView.cpp:
(WebView::notifyPreferencesChanged): Use singleton accessor

../WebKit2: Refactor RuntimeEnabledFeatures as a Singleton.
https://bugs.webkit.org/show_bug.cgi?id=121883.

Reviewed by Jer Noble.

* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner): Use
Singleton accessor.
(WebKit::InjectedBundle::setShadowDOMEnabled):
(WebKit::InjectedBundle::setCSSRegionsEnabled):
(WebKit::InjectedBundle::setCSSCompositingEnabled):
(WebKit::InjectedBundle::setSeamlessIFramesEnabled):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Ditto.
* WebProcess/qt/WebProcessQt.cpp:
(WebKit::WebProcess::platformInitializeWebProcess): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed build fix for IDBDatabase.
akling@apple.com [Wed, 25 Sep 2013 22:08:38 +0000 (22:08 +0000)]
Unreviewed build fix for IDBDatabase.

Turns out there was a much cleaner way to express this.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoTie the life of DocumentStyleSheetCollection and Document together
benjamin@webkit.org [Wed, 25 Sep 2013 21:13:38 +0000 (21:13 +0000)]
Tie the life of DocumentStyleSheetCollection and Document together
https://bugs.webkit.org/show_bug.cgi?id=121892

Reviewed by Andreas Kling.

DocumentStyleSheetCollection had an odd destruction pattern for no apparent reason.

The two objects strictly depend on eachother, this patch make that explicit by making
DocumentStyleSheetCollection a plain object in Document's memory space.

* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::didMutateRules):
* css/DocumentRuleSets.cpp:
(WebCore::DocumentRuleSets::initUserStyle):
* css/DocumentRuleSets.h:
* css/InspectorCSSOMWrappers.cpp:
(WebCore::InspectorCSSOMWrappers::collectFromDocumentStyleSheetCollection):
(WebCore::InspectorCSSOMWrappers::getWrapperForRuleInSheets):
* css/InspectorCSSOMWrappers.h:
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::matchRecursively):
(WebCore::SelectorChecker::checkOne):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::StyleResolver):
* css/StyleSheetList.cpp:
(WebCore::StyleSheetList::styleSheets):
(WebCore::StyleSheetList::detachFromDocument):
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::setCompatibilityMode):
(WebCore::Document::recalcStyle):
(WebCore::Document::createStyleResolver):
(WebCore::Document::processHttpEquiv):
(WebCore::Document::preferredStylesheetSet):
(WebCore::Document::selectedStylesheetSet):
(WebCore::Document::setSelectedStylesheetSet):
(WebCore::Document::scheduleOptimizedStyleSheetUpdate):
(WebCore::Document::styleResolverChanged):
(WebCore::Document::haveStylesheetsLoaded):
* dom/Document.h:
(WebCore::Document::styleSheetCollection):
* dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::combineCSSFeatureFlags):
(WebCore::DocumentStyleSheetCollection::resetCSSFeatureFlags):
(WebCore::DocumentStyleSheetCollection::pageUserSheet):
(WebCore::DocumentStyleSheetCollection::clearPageUserSheet):
(WebCore::DocumentStyleSheetCollection::updatePageUserSheet):
(WebCore::DocumentStyleSheetCollection::updateInjectedStyleSheetCache):
(WebCore::DocumentStyleSheetCollection::invalidateInjectedStyleSheetCache):
(WebCore::DocumentStyleSheetCollection::addAuthorSheet):
(WebCore::DocumentStyleSheetCollection::addUserSheet):
(WebCore::DocumentStyleSheetCollection::removePendingSheet):
(WebCore::DocumentStyleSheetCollection::addStyleSheetCandidateNode):
(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):
(WebCore::DocumentStyleSheetCollection::analyzeStyleSheetChange):
(WebCore::collectActiveCSSStyleSheetsFromSeamlessParents):
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):
* dom/DocumentStyleSheetCollection.h:
* dom/Element.cpp:
(WebCore::Element::createPseudoElementIfNeeded):
* dom/InlineStyleSheetOwner.cpp:
(WebCore::InlineStyleSheetOwner::insertedIntoDocument):
(WebCore::InlineStyleSheetOwner::removedFromDocument):
(WebCore::InlineStyleSheetOwner::clearDocumentData):
(WebCore::InlineStyleSheetOwner::createSheet):
(WebCore::InlineStyleSheetOwner::sheetLoaded):
(WebCore::InlineStyleSheetOwner::startLoadingDynamicSheet):
* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::~ProcessingInstruction):
(WebCore::ProcessingInstruction::checkStyleSheet):
(WebCore::ProcessingInstruction::sheetLoaded):
(WebCore::ProcessingInstruction::insertedInto):
(WebCore::ProcessingInstruction::removedFrom):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::~HTMLLinkElement):
(WebCore::HTMLLinkElement::insertedInto):
(WebCore::HTMLLinkElement::removedFrom):
(WebCore::HTMLLinkElement::addPendingSheet):
(WebCore::HTMLLinkElement::removePendingSheet):
* html/HTMLQuoteElement.cpp:
(WebCore::HTMLQuoteElement::insertedInto):
* html/HTMLViewSourceDocument.cpp:
(WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::willMatchRule):
* inspector/InspectorCSSAgent.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willMatchRuleImpl):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::willMatchRule):
* mathml/MathMLMathElement.cpp:
(WebCore::MathMLMathElement::insertedInto):
* page/Page.cpp:
(WebCore::Page::userStyleSheetLocationChanged):
* page/PageGroup.cpp:
(WebCore::PageGroup::invalidateInjectedStyleSheetCacheInAllFrames):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::lineHeight):
(WebCore::RenderBlock::updateFirstLetter):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::updateAlwaysCreateLineBoxes):
(WebCore::RenderInline::lineHeight):
* rendering/RenderLineBreak.cpp:
(WebCore::RenderLineBreak::lineHeight):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::uncachedFirstLineStyle):
(WebCore::RenderObject::cachedFirstLineStyle):
* rendering/RenderObject.h:
(WebCore::RenderObject::firstLineStyle):
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::verticalPositionForBox):
* style/StyleResolveTree.cpp:
(WebCore::Style::resolveLocal):
* testing/Internals.cpp:
(WebCore::Internals::insertAuthorCSS):
(WebCore::Internals::insertUserCSS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFeatureDefine.xcconfig cleanup (They should all be identical).
beidson@apple.com [Wed, 25 Sep 2013 20:58:30 +0000 (20:58 +0000)]
FeatureDefine.xcconfig cleanup (They should all be identical).
https://bugs.webkit.org/show_bug.cgi?id=121921

Reviewed by Mark Rowe.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUse tuples for encoding IPC messages
andersca@apple.com [Wed, 25 Sep 2013 20:57:16 +0000 (20:57 +0000)]
Use tuples for encoding IPC messages
https://bugs.webkit.org/show_bug.cgi?id=121924

Reviewed by Andreas Kling.

Yet another step towards getting rid of the Arguments hierarchy.

* Platform/CoreIPC/Connection.h:
(CoreIPC::Connection::send):
(CoreIPC::Connection::sendSync):
* Platform/CoreIPC/HandleMessage.h:
(CoreIPC::handleMessage):
(CoreIPC::handleMessageVariadic):
(CoreIPC::handleMessageDelayed):
* Platform/CoreIPC/MessageSender.h:
(CoreIPC::MessageSender::send):
* Scripts/webkit2/messages.py:
(arguments_type_old):
(arguments_type):
(reply_type):
(decode_type):
(delayed_reply_type):
(message_to_struct_declaration):
* Scripts/webkit2/messages_unittest.py:
(LoadURL):
(std):
(TouchEvent):
(DidReceivePolicyDecision):
(Close):
(PreferencesDidChange):
(SendDoubleAndFloat):
(SendInts):
(CreatePlugin):
(RunJavaScriptAlert):
(GetPlugins):
(GetPluginProcessConnection):
(TestMultipleAttributes):
(TestParameterAttributes):
(TemplateTest):
(DidCreateWebProcessConnection):
(InterpretKeyEvent):
(DeprecatedOperation):
(ExperimentalOperation):
* Shared/ChildProcessProxy.h:
(WebKit::ChildProcessProxy::send):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoJS wrappers should have strongly typed impl() functions.
akling@apple.com [Wed, 25 Sep 2013 20:01:26 +0000 (20:01 +0000)]
JS wrappers should have strongly typed impl() functions.
<https://webkit.org/b/121919>

Reviewed by Geoffrey Garen.

Generate strongly typed JSFoo::impl() functions for all wrappers,
not just those marked with JSGenerateToNativeObject.

Removed 8.8 million static_casts that are no longer needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WIN] Fix MSVC C4146 compiler warning
paroga@webkit.org [Wed, 25 Sep 2013 19:22:24 +0000 (19:22 +0000)]
[WIN] Fix MSVC C4146 compiler warning
https://bugs.webkit.org/show_bug.cgi?id=121838

Reviewed by Brent Fulgham.

Fix some variables from unsinged to int to fix the compiler warning
"unary minus operator applied to unsigned type, result still unsigned".

* DumpRenderTree/WorkQueueItem.h:
(BackItem::BackItem):
(ForwardItem::ForwardItem):
* DumpRenderTree/win/DumpRenderTree.cpp:
(createWebViewAndOffscreenWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Switch the 64-bit Release builder to testing layout tests under WK2
zandobersek@gmail.com [Wed, 25 Sep 2013 19:13:04 +0000 (19:13 +0000)]
[GTK] Switch the 64-bit Release builder to testing layout tests under WK2
https://bugs.webkit.org/show_bug.cgi?id=121256

Reviewed by Martin Robinson.

Switch the GTK 64-bit Release builder to testing the layout tests under WebKit2.
The GTK 64-bit Release WK2 testing builder is switched to now run layout tests under WebKit1.

* BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agohttps://bugs.webkit.org/show_bug.cgi?id=121885.
roger_fong@apple.com [Wed, 25 Sep 2013 19:04:05 +0000 (19:04 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=121885.
<rdar://problem/15072332>.

Reviewed by Brent Fulgham.

No new functionality added.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollByRecursively):
* rendering/RenderLayer.h:
* WebView.cpp:
(WebView::gestureNotify):
(WebView::gesture):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed GTK gardening. Moving WK1-specific failure expectations into the WK1-speci...
zandobersek@gmail.com [Wed, 25 Sep 2013 19:02:07 +0000 (19:02 +0000)]
Unreviewed GTK gardening. Moving WK1-specific failure expectations into the WK1-specific TestExpectations.
Also adding expectations for the currently failing tests on WK2.

* platform/gtk-wk1/TestExpectations:
* platform/gtk-wk2/TestExpectations:
* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Windows] Unreviewed build fix: Add new syntax of function declaration to
bfulgham@apple.com [Wed, 25 Sep 2013 18:56:35 +0000 (18:56 +0000)]
[Windows] Unreviewed build fix: Add new syntax of function declaration to
Windows export definition file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoReduce repetitive EventTarget subclassing.
akling@apple.com [Wed, 25 Sep 2013 18:52:53 +0000 (18:52 +0000)]
Reduce repetitive EventTarget subclassing.
<https://webkit.org/b/121915>

Reviewed by Antti Koivisto.

Add a EventTargetWithInlineData helper class to EventTarget.h.
It's a simple subclass with an EventTargetData member and FINAL
eventTargetData()/ensureEventTargetData() overrides.

Turns out that this fits almost every use case except Node and
SVGElementInstance.

Inlined most of the FINAL EventTarget overrides since they will
be called on tight pointers by generated bindings code and this
removes the need for virtual dispatch.

Spammed OVERRIDE FINAL as appropriate, we can't make the whole
classes FINAL until bug 121747 is fixed, so added FIXMEs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed GTK gardening. Moving around and updating the GTK baselines that are
zandobersek@gmail.com [Wed, 25 Sep 2013 18:51:59 +0000 (18:51 +0000)]
Unreviewed GTK gardening. Moving around and updating the GTK baselines that are
either specific to WK1 or WK2 or can be shared by both.

* platform/gtk-wk1/http: Added.
* platform/gtk-wk1/http/tests: Added.
* platform/gtk-wk1/http/tests/cache: Added.
* platform/gtk-wk1/http/tests/cache/cancel-multiple-post-xhrs-expected.txt: Added.
* platform/gtk-wk1/http/tests/security: Added.
* platform/gtk-wk1/http/tests/security/contentSecurityPolicy: Added.
* platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-and-enforce-expected.txt: Added.
* platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-blocked-data-uri-expected.txt: Added.
* platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-blocked-file-uri-expected.txt: Added.
* platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin-expected.txt: Added.
* platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-blocked-uri-expected.txt: Added.
* platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-only-expected.txt: Added.
* platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt: Added.
* platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-uri-expected.txt: Added.
* platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt: Added.
* platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-uri-from-inline-javascript-expected.txt: Added.
* platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-uri-from-javascript-expected.txt: Added.
* platform/gtk-wk2/http: Added.
* platform/gtk-wk2/http/tests: Added.
* platform/gtk-wk2/http/tests/loading: Added.
* platform/gtk-wk2/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt: Added.
* platform/gtk-wk2/http/tests/loading/basic-credentials-sent-automatically-expected.txt: Added.
* platform/gtk-wk2/http/tests/misc: Added.
* platform/gtk-wk2/http/tests/misc/401-alternative-content-expected.txt: Added.
* platform/gtk-wk2/http/tests/misc/authentication-redirect-1: Added.
* platform/gtk-wk2/http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin-expected.txt: Added.
* platform/gtk-wk2/http/tests/misc/authentication-redirect-2: Added.
* platform/gtk-wk2/http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin-expected.txt: Added.
* platform/gtk-wk2/http/tests/misc/authentication-redirect-4: Added.
* platform/gtk-wk2/http/tests/misc/authentication-redirect-4/authentication-sent-to-redirect-same-origin-url-expected.txt: Added.
* platform/gtk-wk2/http/tests/security: Added.
* platform/gtk-wk2/http/tests/security/401-logout: Added.
* platform/gtk-wk2/http/tests/security/401-logout/401-logout-expected.txt: Added.
* platform/gtk-wk2/http/tests/xmlhttprequest: Added.
* platform/gtk-wk2/http/tests/xmlhttprequest/failed-auth-expected.txt: Added.
* platform/gtk-wk2/http/tests/xmlhttprequest/remember-bad-password-expected.txt: Added.
* platform/gtk-wk2/js: Added.
* platform/gtk-wk2/js/dom: Added.
* platform/gtk-wk2/js/dom/constructor-length-expected.txt: Added.
* platform/gtk-wk2/js/dom/global-constructors-attributes-expected.txt: Added.
* platform/gtk/http/tests/cache: Removed.
* platform/gtk/http/tests/cache/cancel-multiple-post-xhrs-expected.txt: Removed.
* platform/gtk/http/tests/security/contentSecurityPolicy/report-and-enforce-expected.txt: Removed.
* platform/gtk/http/tests/security/contentSecurityPolicy/report-blocked-data-uri-expected.txt: Removed.
* platform/gtk/http/tests/security/contentSecurityPolicy/report-blocked-file-uri-expected.txt: Removed.
* platform/gtk/http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin-expected.txt: Removed.
* platform/gtk/http/tests/security/contentSecurityPolicy/report-blocked-uri-expected.txt: Removed.
* platform/gtk/http/tests/security/contentSecurityPolicy/report-only-expected.txt: Removed.
* platform/gtk/http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt: Removed.
* platform/gtk/http/tests/security/contentSecurityPolicy/report-uri-expected.txt: Removed.
* platform/gtk/http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt: Removed.
* platform/gtk/http/tests/security/contentSecurityPolicy/report-uri-from-inline-javascript-expected.txt: Removed.
* platform/gtk/http/tests/security/contentSecurityPolicy/report-uri-from-javascript-expected.txt: Removed.
* platform/gtk/userscripts: Added.
* platform/gtk/userscripts/script-run-at-end-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Windows] Unreviewed build fix after r156408.
bfulgham@apple.com [Wed, 25 Sep 2013 18:43:31 +0000 (18:43 +0000)]
[Windows] Unreviewed build fix after r156408.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoloader/go-back-to-different-window-size.html is flaky
ap@apple.com [Wed, 25 Sep 2013 18:29:22 +0000 (18:29 +0000)]
loader/go-back-to-different-window-size.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=96642

* platform/mac/TestExpectations: Marking it as flaky on Mac. I think that it's
a general issue with the tools that window resizing doesn't work well.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAX: WebKit doesn't map aria-sort=other on OS X
commit-queue@webkit.org [Wed, 25 Sep 2013 18:21:02 +0000 (18:21 +0000)]
AX: WebKit doesn't map aria-sort=other on OS X
https://bugs.webkit.org/show_bug.cgi?id=118511

Patch by Sam White <samuel_white@apple.com> on 2013-09-25
Reviewed by Chris Fleizach.

Source/WebCore:

No new tests, updated existing aria-sort test to validate addition of "other"
sort order per http://www.w3.org/TR/wai-aria/complete#aria-sort.

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::sortDirection):
* accessibility/AccessibilityObject.h:

LayoutTests:

Updated test to check "other" aria-sort order. Also added additional checks to
determine which elements expose aria-sort so our "none" case is more clear.

* accessibility/aria-sort-expected.txt:
* accessibility/aria-sort.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCTTE: More Document references please
weinig@apple.com [Wed, 25 Sep 2013 18:09:47 +0000 (18:09 +0000)]
CTTE: More Document references please
https://bugs.webkit.org/show_bug.cgi?id=121893

Reviewed by Anders Carlsson.

* Thread even more Document&s around. *

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoHasMemoryCostMemberFunction should work for final classes
andersca@apple.com [Wed, 25 Sep 2013 18:07:33 +0000 (18:07 +0000)]
HasMemoryCostMemberFunction should work for final classes
https://bugs.webkit.org/show_bug.cgi?id=121747

Reviewed by Sam Weinig.

Use decltype to check for the memoryCost() member function. This doesn't check that the return type is size_t, but
the build will fail anyway if that's the case (or if the return type is not convertible to size_t).

* bindings/js/JSDOMBinding.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMore refactoring to make the LevelDB dependencies of IDB more obvious.
beidson@apple.com [Wed, 25 Sep 2013 18:02:58 +0000 (18:02 +0000)]
More refactoring to make the LevelDB dependencies of IDB more obvious.
https://bugs.webkit.org/show_bug.cgi?id=121880

Reviewed by Alexey Proskuryakov.

This patch does three things:
1 - Moves some files to the indexeddb/leveldb subdirectory, renaming them in the process.
2 - Renames some classes.
3 - Adds "USE(LEVELDB)" guards in addition to the ENABLE(INDEXED_DATABASE) guard for those files.

Project file updates:
* GNUmakefile.am:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.xcodeproj/project.pbxproj:
* WebCore.vcxproj/WebCore.vcxproj:

File renames, class renames, and USE(LEVELDB) guards:
* Modules/indexeddb/IDBBackingStore.cpp: Removed.
* Modules/indexeddb/IDBFactoryBackendInterface.cpp:
(WebCore::IDBFactoryBackendInterface::create): Add a null return if USE(LEVELDB) is disabled as a stop gap measure until
  there is a non-LevelDB impl.
* Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
* Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h: Renamed from Source/WebCore/Modules/indexeddb/IDBBackingStore.h.
* Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBCursorBackendImpl.cpp.
* Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.h: Renamed from Source/WebCore/Modules/indexeddb/IDBCursorBackendImpl.h.
* Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp.
* Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.h: Renamed from Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.h.
* Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBFactoryBackendImpl.cpp.
* Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h: Renamed from Source/WebCore/Modules/indexeddb/IDBFactoryBackendImpl.h.
* Modules/indexeddb/leveldb/IDBLevelDBCoding.cpp:
* Modules/indexeddb/leveldb/IDBLevelDBCoding.h:
* Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.cpp.
* Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.h: Renamed from Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.h.
* Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBTransactionBackendImpl.cpp.
* Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.h: Renamed from Source/WebCore/Modules/indexeddb/IDBTransactionBackendImpl.h.
* Modules/indexeddb/leveldb/IDBTransactionCoordinatorLevelDB.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBTransactionCoordinator.cpp.
* Modules/indexeddb/leveldb/IDBTransactionCoordinatorLevelDB.h: Renamed from Source/WebCore/Modules/indexeddb/IDBTransactionCoordinator.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd style checker for CMake lists
paroga@webkit.org [Wed, 25 Sep 2013 18:00:18 +0000 (18:00 +0000)]
Add style checker for CMake lists
https://bugs.webkit.org/show_bug.cgi?id=121764

Reviewed by Ryosuke Niwa.

Add an additional check to make sure that list of files are sorted.
Exclude lists of include directories for now, since the order
can be importent for compilation of some files.

* Scripts/webkitpy/style/checkers/cmake.py:
(CMakeChecker.check):
(CMakeChecker._check_indent):
(CMakeChecker):
(CMakeChecker._check_list_order):
(CMakeChecker._list_item_path):
* Scripts/webkitpy/style/checkers/cmake_unittest.py:
(CMakeCheckerTest.test_check):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION (r156355) Links / interactive elements inside nested tables are unclickable
antti@apple.com [Wed, 25 Sep 2013 17:45:59 +0000 (17:45 +0000)]
REGRESSION (r156355) Links / interactive elements inside nested tables are unclickable
https://bugs.webkit.org/show_bug.cgi?id=121904

Reviewed by Andreas Kling.

Source/WebCore:

Test: fast/table/hittest-self-painting.html

Original reduction by Philippe Wittenbergh.

* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::styleDidChange):

    Tighten a bit.

(WebCore::RenderTableRow::nodeAtPoint):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::nodeAtPoint):

    These flipped accidentally in r156355.

LayoutTests:

* fast/table/hittest-self-painting-expected.txt: Added.
* fast/table/hittest-self-painting.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCMakeChecker takes unusually long time to run
paroga@webkit.org [Wed, 25 Sep 2013 17:40:19 +0000 (17:40 +0000)]
CMakeChecker takes unusually long time to run
https://bugs.webkit.org/show_bug.cgi?id=105662

Reviewed by Ryosuke Niwa.

Move the caching mechanism for regular expression of the C++ checker into
a common file and use it for the CMake and ChangeLog checkers too.

* Scripts/webkitpy/style/checkers/changelog.py:
(ChangeLogChecker.check_entry):
* Scripts/webkitpy/style/checkers/cmake.py:
(CMakeChecker._process_line):
(CMakeChecker._check_no_space_cmds):
(CMakeChecker._check_one_space_cmds):
(CMakeChecker._check_non_lowercase_cmd):
* Scripts/webkitpy/style/checkers/common.py:
(match):
(search):
(searchIgnorecase):
(sub):
(subn):
* Scripts/webkitpy/style/checkers/cpp.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBuild fix for WinCE after r155098.
paroga@webkit.org [Wed, 25 Sep 2013 16:33:12 +0000 (16:33 +0000)]
Build fix for WinCE after r155098.

Windows CE does not support getenv().

* jsc.cpp:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix template deduction for CollatorDefault
paroga@webkit.org [Wed, 25 Sep 2013 16:32:53 +0000 (16:32 +0000)]
Fix template deduction for CollatorDefault

* wtf/unicode/CollatorDefault.cpp:
(WTF::Collator::userDefault): Use nullptr instead of 0.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix warning in makeprop.pl
berto@igalia.com [Wed, 25 Sep 2013 16:08:08 +0000 (16:08 +0000)]
Fix warning in makeprop.pl
https://bugs.webkit.org/show_bug.cgi?id=121900

Reviewed by Ryosuke Niwa.

%nameIsInherited and %nameToId were incorrectly initialized using
references instead of lists.

Anyway there's no need to initialize those variables explicitly,
they're already empty by default.

* css/makeprop.pl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION(r156393): Build with !ENABLE(SVG_FONTS) broken
allan.jensen@digia.com [Wed, 25 Sep 2013 16:02:07 +0000 (16:02 +0000)]
REGRESSION(r156393): Build with !ENABLE(SVG_FONTS) broken

Unreviewed build-fix.

Protect SVG font code with #ifdef ENABLE(SVG_FONTS).

* platform/graphics/WidthIterator.cpp:
(WebCore::applyFontTransforms):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r156272.
commit-queue@webkit.org [Wed, 25 Sep 2013 15:41:58 +0000 (15:41 +0000)]
Unreviewed, rolling out r156272.
http://trac.webkit.org/changeset/156272
https://bugs.webkit.org/show_bug.cgi?id=121909

Has no real effect (Requested by carewolf on #webkit).

* platform/graphics/qt/TileQt.cpp:
(WebCore::TileQt::updateBackBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove wheel event dispatch from Node to Element.
akling@apple.com [Wed, 25 Sep 2013 15:40:58 +0000 (15:40 +0000)]
Move wheel event dispatch from Node to Element.
<https://webkit.org/b/121908>

Reviewed by Anders Carlsson.

Wheel events are only ever dispatched on Elements, so move the logic out of Node.

Had to make RenderBox::scroll() and friends return a stopElement instead of a
stopNode (out argument) to make this work, though it was only ever returning
Elements there anyway.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Unreviewed gardening. Unskip passing fast/text/font-kerning.html
commit-queue@webkit.org [Wed, 25 Sep 2013 15:06:53 +0000 (15:06 +0000)]
[EFL] Unreviewed gardening. Unskip passing fast/text/font-kerning.html
https://bugs.webkit.org/show_bug.cgi?id=121907

Unreviewed EFL gardening. Passes after r152411.

Patch by Sanghyup Lee <sh53.lee@samsung.com> on 2013-09-25

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Fix build with Qt 5.2 QtPosition module
allan.jensen@digia.com [Wed, 25 Sep 2013 14:57:19 +0000 (14:57 +0000)]
[Qt] Fix build with Qt 5.2 QtPosition module
https://bugs.webkit.org/show_bug.cgi?id=121089

Reviewed by Simon Hausmann.

.:

QtLocation -> QtPositioning

* Source/sync.profile:

Source/WebKit:

QtLocation -> QtPositioning

* WebKit1.pri:

Source/WebKit/qt:

QtLocation -> QtPositioning

* WebCoreSupport/GeolocationClientQt.cpp:

Source/WebKit2:

QtLocation -> QtPositioning

* Target.pri:
* UIProcess/qt/WebGeolocationProviderQt.cpp:
* WebKit2.pri:

Tools:

QtLocation -> QtPositioning. Make sure we set build type before doing configure checks
that might depend on them.

* qmake/mkspecs/features/default_pre.prf:
* qmake/mkspecs/features/features.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Fix build with !ENABLE(BLOB) after r156330
allan.jensen@digia.com [Wed, 25 Sep 2013 14:50:53 +0000 (14:50 +0000)]
[Qt] Fix build with !ENABLE(BLOB) after r156330

Unreviewed build-fix.

* platform/network/qt/ResourceRequestQt.cpp:
(WebCore::ResourceRequest::toNetworkRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSupport kerning with SVG web fonts
allan.jensen@digia.com [Wed, 25 Sep 2013 14:19:19 +0000 (14:19 +0000)]
Support kerning with SVG web fonts
https://bugs.webkit.org/show_bug.cgi?id=117540

Source/WebCore:

Reviewed by Stephen Chenney.

Adds the glue to WidthIterator to take advantage of kerning in SVG web fonts.
To supply SVG font kerning with its required text input, the signature of
applyFontTransforms has been extended.

Since SVG font kerning was extremely slow, it has been sped up by replacing
the iteration over all possible kerning definitions with a hash-map based
lookup of the leading symbol to be kerned. The new algorithm provides a
roughly 100x speed-up in SVG font kerning.

Test: fast/text/svg-font-face-with-kerning.html

* platform/graphics/TextRun.h:
(WebCore::TextRun::string):
* platform/graphics/WidthIterator.cpp:
(WebCore::applyFontTransforms):
(WebCore::WidthIterator::advanceInternal):
* rendering/svg/SVGTextRunRenderingContext.cpp:
(WebCore::SVGTextRunRenderingContext::applySVGKerning):
* rendering/svg/SVGTextRunRenderingContext.h:
* svg/SVGFontElement.cpp:
(WebCore::SVGFontElement::invalidateGlyphCache):
(WebCore::SVGFontElement::ensureGlyphCache):
(WebCore::SVGKerningMap::clear):
(WebCore::SVGKerningMap::insert):
(WebCore::stringMatchesUnicodeRange):
(WebCore::stringMatchesGlyphName):
(WebCore::stringMatchesUnicodeName):
(WebCore::matches):
(WebCore::kerningForPairOfStringsAndGlyphs):
(WebCore::SVGFontElement::horizontalKerningForPairOfStringsAndGlyphs):
(WebCore::SVGFontElement::verticalKerningForPairOfStringsAndGlyphs):
* svg/SVGFontElement.h:
(WebCore::SVGKerning::SVGKerning):
(WebCore::SVGKerningMap::isEmpty):
* svg/SVGHKernElement.cpp:
(WebCore::SVGHKernElement::buildHorizontalKerningPair):
* svg/SVGHKernElement.h:
* svg/SVGVKernElement.cpp:
(WebCore::SVGVKernElement::buildVerticalKerningPair):
* svg/SVGVKernElement.h:

LayoutTests:

Added test of SVG web font kerning.

Reviewed by Stephen Chenney.

* fast/text/svg-font-face-with-kerning-expected.png: Added.
* fast/text/svg-font-face-with-kerning-expected.txt: Added.
* fast/text/svg-font-face-with-kerning.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Update test expectations. Mark fast/images/exif-orientation.html as failing.
commit-queue@webkit.org [Wed, 25 Sep 2013 14:16:54 +0000 (14:16 +0000)]
[GTK] Update test expectations. Mark fast/images/exif-orientation.html as failing.
https://bugs.webkit.org/show_bug.cgi?id=121906

Unreviewed GTK gardening.

Patch by Anton Obzhirov <a.obzhirov@samsung.com> on 2013-09-25

* platform/gtk/TestExpectations: Mark fast/images/exif-orientation.html as failing,
as reported in webkit.org/b/121905.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago<https://webkit.org/b/120476> [CSS Masking] Implement luminance masking
commit-queue@webkit.org [Wed, 25 Sep 2013 13:53:08 +0000 (13:53 +0000)]
<https://webkit.org/b/120476> [CSS Masking] Implement luminance masking

Source/WebCore:

Added implementation for luminance masking. A luminance mask is applied by transforming its RGB values into
an alpha value, using luminance-to-alpha coefficients. Because this conversion is already implemented in
the ImageBuffer class, we used it in our implementation.

Patch by Andrei Parvu <parvu@adobe.com> on 2013-09-25
Reviewed by Dirk Schulze.

Tests: css3/masking/mask-luminance-gradient.html
       css3/masking/mask-luminance-png.html
       css3/masking/mask-luminance-svg.html

* platform/graphics/BitmapImage.cpp: Add a drawPattern method, in which an ImageBuffer is created and converted from alpha to luminance, if there is a luminance mask.
(WebCore::BitmapImage::BitmapImage):
(WebCore::BitmapImage::drawPattern):
* platform/graphics/BitmapImage.h:
* platform/graphics/GeneratorGeneratedImage.cpp: Convert the ImageBuffer to luminance, if necessary.
(WebCore::GeneratorGeneratedImage::drawPattern):
* platform/graphics/GraphicsContext.cpp: Add methods which set and check if a luminance mask is drawn.
(WebCore::GraphicsContext::setDrawLuminanceMask):
(WebCore::GraphicsContext::drawLuminanceMask):
* platform/graphics/GraphicsContext.h: Add property to ContextState for luminance drawing.
(WebCore::GraphicsContextState::GraphicsContextState):
* rendering/RenderBoxModelObject.cpp: Set the luminance property of the mask, if the layer has a mask source type of luminance.
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
* svg/graphics/SVGImage.cpp: Convert the ImageBuffer to luminance, if necessary.
(WebCore::SVGImage::drawPatternForContainer):
* svg/graphics/SVGImageForContainer.cpp: Pass the luminance property to the SVG image.
(WebCore::SVGImageForContainer::drawPattern):

LayoutTests:

Added tests to verify the implementation of luminance masking.

Patch by Andrei Parvu <parvu@adobe.com> on 2013-09-25
Reviewed by Dirk Schulze.

* css3/masking/mask-luminance-gradient-expected.html: Added.
* css3/masking/mask-luminance-gradient.html: Added.
* css3/masking/mask-luminance-png.html: Added.
* css3/masking/mask-luminance-svg-expected.html: Added.
* css3/masking/mask-luminance-svg.html: Added.
* css3/masking/resources/circle-alpha.svg: Added.
* css3/masking/resources/circle2.svg: Added.
* css3/masking/resources/dice.png: Added.
* platform/mac/css3/masking/mask-luminance-png-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove EventPathWalker.
akling@apple.com [Wed, 25 Sep 2013 13:02:20 +0000 (13:02 +0000)]
Remove EventPathWalker.
<https://webkit.org/b/121890>

Reviewed by Antti Koivisto.

Purge some more leftover Shadow DOM code.

* dom/EventPathWalker.cpp:
* dom/EventPathWalker.h:

    Removed.

* dom/EventRetargeter.cpp:
(WebCore::nodeOrHostIfPseudoElement):
(WebCore::EventRetargeter::calculateEventPath):
(WebCore::EventRetargeter::buildRelatedNodeMap):

    If starting at a pseudo element, e.g for events originating from
    a transition on :before/:after, retarget to the pseudo element's
    host as appropriate. This was the only real "feature" we were
    using in EventPathWalker.

* page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseDraggedEvent):
(WebCore::EventHandler::updateDragAndDrop):
(WebCore::EventHandler::updateMouseEventTargetNode):
(WebCore::EventHandler::handleWheelEvent):
(WebCore::EventHandler::handleTouchEvent):

    Replace use of EventPathWalker with parentOrShadowHostElement()
    parent chain climbing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Updated accessibility expectations after r154781 and r155599
commit-queue@webkit.org [Wed, 25 Sep 2013 12:50:16 +0000 (12:50 +0000)]
[EFL] Updated accessibility expectations after r154781 and r155599
https://bugs.webkit.org/show_bug.cgi?id=121901

Unreviewed EFL gardening.

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-09-25

* platform/efl/accessibility/menu-list-sends-change-notification-expected.txt:
* platform/efl/accessibility/notification-listeners-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[ATK] Fix style issues in AccessibilityUIElementAtk
mario@webkit.org [Wed, 25 Sep 2013 12:33:27 +0000 (12:33 +0000)]
[ATK] Fix style issues in AccessibilityUIElementAtk
https://bugs.webkit.org/show_bug.cgi?id=121898

Reviewed by Chris Fleizach.

Avoid the '.f' suffix for float literals and use G_VALUE_INIT
instead of { 0, { { 0 } } } to initialize a GValue.

* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::clickPointX): Remove suffix.
(AccessibilityUIElement::clickPointY): Ditto.
(AccessibilityUIElement::intValue): Use G_VALUE_INIT and remove suffix.
(AccessibilityUIElement::minValue): Ditto.
(AccessibilityUIElement::maxValue): Ditto.
(AccessibilityUIElement::numberAttributeValue): Remove suffix.
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::numberAttributeValue): Remove suffix.
(WTR::AccessibilityUIElement::x): Ditto.
(WTR::AccessibilityUIElement::y): Ditto.
(WTR::AccessibilityUIElement::width): Ditto.
(WTR::AccessibilityUIElement::height): Ditto.
(WTR::AccessibilityUIElement::clickPointX): Ditto.
(WTR::AccessibilityUIElement::clickPointY): Ditto.
(WTR::AccessibilityUIElement::intValue): Ditto.
(WTR::AccessibilityUIElement::minValue): Ditto.
(WTR::AccessibilityUIElement::maxValue): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago:read-write pseudo-class should not be applied on <input type="text" disabled>
commit-queue@webkit.org [Wed, 25 Sep 2013 12:21:41 +0000 (12:21 +0000)]
:read-write pseudo-class should not be applied on <input type="text" disabled>
https://bugs.webkit.org/show_bug.cgi?id=118236

Patch by Gurpreet Kaur <k.gurpreet@samsung.com> on 2013-09-25
Reviewed by Darin Adler.

Source/WebCore:

The :read-write pseudo-class must match any element falling into one
of the following categories i.e
input elements to which the readonly attribute applies, and that are mutable
(i.e. that do not have the readonly attribute specified and that are not disabled)
textarea elements that do not have a readonly attribute, and that are not disabled
elements that are editing hosts or editable and are neither input elements nor
textarea elements.

Test: fast/css/readwrite-pseudoclass-input.html

* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::matchesReadWritePseudoClass):
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::matchesReadWritePseudoClass):
Checking for both readonly and disabled attribute on input ane textarea element.

LayoutTests:

* fast/css/readwrite-pseudoclass-input-expected.txt: Added.
* fast/css/readwrite-pseudoclass-input.html: Added.
Added test case to verify that :read-write pseudo-class properties are
are not applied to disabled input and textarea elements.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] accessibility/loading-iframe-sends-notification.html is failing
commit-queue@webkit.org [Wed, 25 Sep 2013 11:02:23 +0000 (11:02 +0000)]
[EFL] accessibility/loading-iframe-sends-notification.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112003

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-09-25
Reviewed by Mario Sanchez Prada.

Source/WebCore:

Enabled AXLayoutComplete on EFL platform.

* dom/Document.cpp:
(WebCore::Document::implicitClose):
* page/FrameView.cpp:
(WebCore::FrameView::layout):

Tools:

Enabled addNotificationListener and removeNotificationListener for EFL port.

* WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
* WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
(WTR::AccessibilityController::removeNotificationListener):

LayoutTests:

* platform/efl-wk1/TestExpectations: Removed loading-iframe-sends-notification.html.
* platform/efl-wk2/TestExpectations: Removed loading-iframe-sends-notification.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove erroneous reference to libWTF.a in the WebKit2 Xcode project file.
weinig@apple.com [Wed, 25 Sep 2013 05:38:32 +0000 (05:38 +0000)]
Remove erroneous reference to libWTF.a in the WebKit2 Xcode project file.

Rubber-stamped by Alexey Proskuryakov.

* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove the Windows-specific rules from WebKit2's DerivedSources.make, Windows is...
weinig@apple.com [Wed, 25 Sep 2013 05:37:06 +0000 (05:37 +0000)]
Remove the Windows-specific rules from WebKit2's DerivedSources.make, Windows is not supported anymore
https://bugs.webkit.org/show_bug.cgi?id=121895

Reviewed by Alexey Proskuryakov.

* DerivedSources.make:
Remove Windows-specific rules, and, now that only the Mac is using this file, remove the
Mac checks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r156379.
commit-queue@webkit.org [Wed, 25 Sep 2013 05:22:59 +0000 (05:22 +0000)]
Unreviewed, rolling out r156379.
http://trac.webkit.org/changeset/156379
https://bugs.webkit.org/show_bug.cgi?id=121894

Caused many assertion failures (Requested by ap on #webkit).

* css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):
(WebCore::StyleResolver::createFilterOperations):
* css/TransformFunctions.cpp:
(WebCore::transformsForValue):
* css/WebKitCSSArrayFunctionValue.h:
* css/WebKitCSSFilterValue.h:
* css/WebKitCSSMatFunctionValue.h:
* css/WebKitCSSMixFunctionValue.h:
* css/WebKitCSSSVGDocumentValue.h:
* css/WebKitCSSShaderValue.h:
(WebCore::toWebKitCSSShaderValue):
* css/WebKitCSSTransformValue.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCrash in Document::setFocusedElement
rniwa@webkit.org [Wed, 25 Sep 2013 03:34:56 +0000 (03:34 +0000)]
Crash in Document::setFocusedElement
https://bugs.webkit.org/show_bug.cgi?id=121888

Reviewed by Andreas Kling.

Source/WebCore:

Merge https://chromium.googlesource.com/chromium/blink/+/4a594a3de7d9761462b55fb27a6850d767419af2

The crash was caused by attempting to call Chrome:focusedNodeChanged() after m_page had already
been cleared. This could happen when blur's event handler removes the iframe from which
the focus had been moved. Fixed the bug by adding a null pointer check.

Test: fast/events/blur-remove-parent-crash.html

* dom/Document.cpp:
(WebCore::Document::setFocusedElement):

LayoutTests:

* fast/events/blur-remove-parent-crash-expected.txt: Added.
* fast/events/blur-remove-parent-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove HTMLContentElement
antti@apple.com [Wed, 25 Sep 2013 03:09:41 +0000 (03:09 +0000)]
Remove HTMLContentElement
https://bugs.webkit.org/show_bug.cgi?id=121891

Reviewed by Andreas Kling.

Remove an unsused Shadow DOM type.

* DerivedSources.make:
* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:
* html/HTMLDetailsElement.cpp:
* html/HTMLSummaryElement.cpp:
* html/HTMLTagNames.in:
* html/shadow/ContentDistributor.cpp:
* html/shadow/HTMLContentElement.cpp: Removed.
* html/shadow/HTMLContentElement.h: Removed.
* html/shadow/HTMLContentElement.idl: Removed.
* html/shadow/InsertionPoint.h:
(WebCore::InsertionPoint::matchTypeFor):
* testing/Internals.cpp:
* testing/Internals.h:
* testing/Internals.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove a contradiction from SelectorChecker
benjamin@webkit.org [Wed, 25 Sep 2013 01:18:49 +0000 (01:18 +0000)]
Remove a contradiction from SelectorChecker
https://bugs.webkit.org/show_bug.cgi?id=121881

Reviewed by Andreas Kling.

The matching code for PseudoHover and PseudoActive is done on the current
selector pseudo type. The current selector match type must be CSSSelector::PseudoClass
in order to reach this code. Consequently, selector->m_match == CSSSelector::Tag can
never be true.

* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd toWebKitCSS*Value functions to cast from CSSValue
gyuyoung.kim@samsung.com [Wed, 25 Sep 2013 01:17:53 +0000 (01:17 +0000)]
Add toWebKitCSS*Value functions to cast from CSSValue
https://bugs.webkit.org/show_bug.cgi?id=121776

Reviewed by Darin Adler.

CSS_VALUE_TYPE_CASTS can't cover WebKitCSS*Value classes. So, this patch adds toWebKitCSS*Value manually.

No new tests, no behavior change.

* css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):
(WebCore::StyleResolver::createFilterOperations):
* css/TransformFunctions.cpp:
(WebCore::transformsForValue):
* css/WebKitCSSArrayFunctionValue.h:
(WebCore::toWebKitCSSArrayFunctionValue):
* css/WebKitCSSFilterValue.h:
(WebCore::toWebKitCSSFilterValue):
* css/WebKitCSSMatFunctionValue.h:
(WebCore::toWebKitCSSMatFunctionValue):
* css/WebKitCSSMixFunctionValue.h:
(WebCore::toWebKitCSSMixFunctionValue):
* css/WebKitCSSSVGDocumentValue.h:
(WebCore::toWebKitCSSSVGDocumentValue):
* css/WebKitCSSShaderValue.h:
(WebCore::toWebKitCSSShaderValue):
* css/WebKitCSSTransformValue.h:
(WebCore::toWebKitCSSTransformValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoOnly allow rvalues to be passed as synchronous message replies
andersca@apple.com [Wed, 25 Sep 2013 01:03:31 +0000 (01:03 +0000)]
Only allow rvalues to be passed as synchronous message replies
https://bugs.webkit.org/show_bug.cgi?id=121870

Reviewed by Andreas Kling.

This lets us get rid of a nasty const cast and is more logical.

* Platform/CoreIPC/Connection.h:
(CoreIPC::Connection::sendSync):
* Platform/CoreIPC/MessageSender.h:
(CoreIPC::MessageSender::send):
(CoreIPC::MessageSender::sendSync):
* Shared/ChildProcessProxy.h:
(WebKit::ChildProcessProxy::sendSync):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoClean up some uses of first/lastChildSlow
antti@apple.com [Wed, 25 Sep 2013 01:01:17 +0000 (01:01 +0000)]
Clean up some uses of first/lastChildSlow
https://bugs.webkit.org/show_bug.cgi?id=121882

Reviewed by Andreas Kling.

Tighten typing and use first/lastChild instead.

* dom/Position.cpp:
(WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
(WebCore::Position::isCandidate):
(WebCore::Position::getInlineBoxAndOffset):
* dom/Position.h:
* dom/PositionIterator.cpp:
(WebCore::PositionIterator::isCandidate):
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
* rendering/RenderBlock.cpp:
(WebCore::canMergeAnonymousBlock):
(WebCore::canMergeContiguousAnonymousBlocks):
(WebCore::RenderBlock::firstLineBlock):
(WebCore::RenderBlock::updateFirstLetter):
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::setRegionObjectsRegionStyle):
(WebCore::RenderRegion::computeChildrenStyleInRegion):
* rendering/RenderRegion.h:
* rendering/RenderRuby.cpp:
(WebCore::rubyBeforeBlock):
(WebCore::rubyAfterBlock):
(WebCore::lastRubyRun):
* rendering/RenderTreeAsText.cpp:
(WebCore::write):
(WebCore::writeCounterValuesFromChildren):
* rendering/svg/RenderSVGText.cpp:
(WebCore::findPreviousAndNextAttributes):
* style/StyleResolveTree.cpp:
(WebCore::Style::textRendererIsNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoop_get_callee shouldn't use value profiling
mhahnenberg@apple.com [Wed, 25 Sep 2013 00:37:57 +0000 (00:37 +0000)]
op_get_callee shouldn't use value profiling
https://bugs.webkit.org/show_bug.cgi?id=121821

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Currently it's one of the two opcodes that uses m_singletonValue, which is unnecessary.
Our current plan is to remove m_singletonValue so that GenGC can have a simpler story
for handling CodeBlocks/FunctionExecutables during nursery collections.

Instead of using a ValueProfile op_get_callee now has a simple inline cache of the most
recent JSFunction that we saw.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::finalizeUnconditionally):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitCreateThis):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* jit/JIT.cpp:
(JSC::JIT::privateCompileSlowCases):
* jit/JIT.h:
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_get_callee):
(JSC::JIT::emitSlow_op_get_callee):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_get_callee):
(JSC::JIT::emitSlow_op_get_callee):
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:
* runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
* runtime/CommonSlowPaths.h:

LayoutTests:

Added two tests to make sure we didn't regress the performance of op_get_callee.

* js/regress/get_callee_monomorphic-expected.txt: Added.
* js/regress/get_callee_monomorphic.html: Added.
* js/regress/get_callee_polymorphic-expected.txt: Added.
* js/regress/get_callee_polymorphic.html: Added.
* js/regress/script-tests/get_callee_monomorphic.js: Added.
* js/regress/script-tests/get_callee_polymorphic.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoinitial commit
betravis@adobe.com [Wed, 25 Sep 2013 00:14:46 +0000 (00:14 +0000)]
initial commit

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoChange JSC debug hooks to pass a CallFrame* instead of a DebuggerCallFrame.
mark.lam@apple.com [Tue, 24 Sep 2013 23:52:57 +0000 (23:52 +0000)]
Change JSC debug hooks to pass a CallFrame* instead of a DebuggerCallFrame.
https://bugs.webkit.org/show_bug.cgi?id=121867.

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

1. Removed the need for passing the line and column info to the debug hook
   callbacks. We now get the line and column info from the CallFrame.

2. Simplify BytecodeGenerator::emitDebugHook() to only take 1 line number
   argument. The caller can determine whether to pass in the first or last
   line number of the block of source code as appropriate.
   Note: we still need to pass in the line and column info to emitDebugHook()
   because it uses this info to emit expression info which is later used by
   the StackVisitor to determine the line and column info for its "pc".

3. Pass the exceptionValue explicitly to the exception() debug hook
   callback. It should not be embedded in the CallFrame / DebuggerCallFrame.

4. Change the op_debug opcode size to 2 (from 5) since we've removing 3 arg
   values. Update the LLINT and JIT code to handle this.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):
* bytecode/Opcode.h:
(JSC::padOpcodeName):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitDebugHook):
* bytecompiler/BytecodeGenerator.h:
* bytecompiler/NodesCodegen.cpp:
(JSC::ConstStatementNode::emitBytecode):
(JSC::EmptyStatementNode::emitBytecode):
(JSC::DebuggerStatementNode::emitBytecode):
(JSC::ExprStatementNode::emitBytecode):
(JSC::VarStatementNode::emitBytecode):
(JSC::IfElseNode::emitBytecode):
(JSC::DoWhileNode::emitBytecode):
(JSC::WhileNode::emitBytecode):
(JSC::ForNode::emitBytecode):
(JSC::ForInNode::emitBytecode):
(JSC::ContinueNode::emitBytecode):
(JSC::BreakNode::emitBytecode):
(JSC::ReturnNode::emitBytecode):
(JSC::WithNode::emitBytecode):
(JSC::SwitchNode::emitBytecode):
(JSC::LabelNode::emitBytecode):
(JSC::ThrowNode::emitBytecode):
(JSC::TryNode::emitBytecode):
(JSC::ProgramNode::emitBytecode):
(JSC::EvalNode::emitBytecode):
(JSC::FunctionBodyNode::emitBytecode):
* debugger/Debugger.h:
* debugger/DebuggerCallFrame.cpp:
(JSC::LineAndColumnFunctor::operator()):
(JSC::LineAndColumnFunctor::line):
(JSC::LineAndColumnFunctor::column):
(JSC::DebuggerCallFrame::DebuggerCallFrame):
(JSC::DebuggerCallFrame::clear):
* debugger/DebuggerCallFrame.h:
(JSC::DebuggerCallFrame::line):
(JSC::DebuggerCallFrame::column):
* interpreter/Interpreter.cpp:
(JSC::unwindCallFrame):
(JSC::UnwindFunctor::UnwindFunctor):
(JSC::UnwindFunctor::operator()):
(JSC::Interpreter::unwind):
(JSC::Interpreter::debug):
* interpreter/Interpreter.h:
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_debug):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_debug):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
* llint/LowLevelInterpreter.asm:

Source/WebCore:

No new tests.

* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::createCallFrame):
(WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):
(WebCore::ScriptDebugServer::callEvent):
(WebCore::ScriptDebugServer::atStatement):
(WebCore::ScriptDebugServer::returnEvent):
(WebCore::ScriptDebugServer::exception):
(WebCore::ScriptDebugServer::willExecuteProgram):
(WebCore::ScriptDebugServer::didExecuteProgram):
(WebCore::ScriptDebugServer::didReachBreakpoint):
* bindings/js/ScriptDebugServer.h:
* bindings/js/WorkerScriptDebugServer.cpp:
(WebCore::WorkerScriptDebugServer::willExecuteProgram):
* bindings/js/WorkerScriptDebugServer.h:

Source/WebKit/mac:

* WebView/WebScriptDebugDelegate.mm:
(-[WebScriptCallFrame _initWithGlobalObject:debuggerCallFrame:exceptionValue:JSC::]):
(-[WebScriptCallFrame exception]):
* WebView/WebScriptDebugger.h:
* WebView/WebScriptDebugger.mm:
(WebScriptDebugger::exception):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agowebgl/conformance/extensions/oes-element-index-uint.html failing after r156351 or...
dino@apple.com [Tue, 24 Sep 2013 23:47:57 +0000 (23:47 +0000)]
webgl/conformance/extensions/oes-element-index-uint.html failing after r156351 or 156352
https://bugs.webkit.org/show_bug.cgi?id=121863
<rdar://problem/15069481>

Reviewed by Beth Dakin.

This test was not querying the vertex attribute locations
before binding data to them. When we enabled symbol mangling
we started seeing attributes appear in a different order
than the order defined in the shader source. Update this test
to ask getAttribLocation first.

Note that there are two important issues.

Firstly, this is updating our local copy of the Khronos test.
I've opened pull request #377 to get it addressed in the source.
https://github.com/KhronosGroup/WebGL/pull/377

Secondly, this indicates that we might have a lot of problems
with existing content that does not expect the order of
attributes to change.

* webgl/resources/webgl_test_files/conformance/extensions/oes-element-index-uint.html:
* TestExpectations: Unskip test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove keyboard event dispatch from Node to Element.
akling@apple.com [Tue, 24 Sep 2013 23:39:51 +0000 (23:39 +0000)]
Move keyboard event dispatch from Node to Element.
<https://webkit.org/b/121873>

Reviewed by Antti Koivisto.

We only dispatch keyboard events on Elements so that logic shouldn't be in Node.

* dom/Document.cpp:
(WebCore::eventTargetElementForDocument):

    Reworked to return Element instead of Node.

* dom/Document.h:
* dom/Element.h:
* dom/Element.cpp:
(WebCore::Element::dispatchKeyEvent):

    Moved from Node to Element.

* editing/AlternativeTextController.cpp:
(WebCore::AlternativeTextController::insertDictatedText):
* page/EventHandler.cpp:
(WebCore::EventHandler::keyEvent):
(WebCore::EventHandler::handleTextInputEvent):

    Adjusted for above changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCrashing under JSC::DFG::SpeculativeJIT::spill visiting citicards.com
fpizlo@apple.com [Tue, 24 Sep 2013 23:27:51 +0000 (23:27 +0000)]
Crashing under JSC::DFG::SpeculativeJIT::spill visiting citicards.com
https://bugs.webkit.org/show_bug.cgi?id=121844

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

Fix some int52 bugs that caused this.

* bytecode/ValueRecovery.h:
(JSC::ValueRecovery::dumpInContext): There's no such thing as int53.
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::spill): Actually spill int52's, instead of hitting an assert and crashing.
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateInt32Internal): Use the right format (from before when we clobber it).

Tools:

Reviewed by Mark Hahnenberg.

* Scripts/run-javascriptcore-tests: Be more clear about what test suite failed.

LayoutTests:

Reviewed by Mark Hahnenberg.

* js/dfg-int52-spill-expected.txt: Added.
* js/dfg-int52-spill-trickier-expected.txt: Added.
* js/dfg-int52-spill-trickier.html: Added.
* js/dfg-int52-spill.html: Added.
* js/script-tests/dfg-int52-spill-trickier.js: Added.
(foo):
* js/script-tests/dfg-int52-spill.js: Added.
(foo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFlaky Test: compositing/reflections/load-video-in-reflection.html
ap@apple.com [Tue, 24 Sep 2013 23:18:05 +0000 (23:18 +0000)]
Flaky Test: compositing/reflections/load-video-in-reflection.html
https://bugs.webkit.org/show_bug.cgi?id=117427

* platform/mac/TestExpectations: Marking the test accordingly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed buildfix.
ossy@webkit.org [Tue, 24 Sep 2013 23:00:12 +0000 (23:00 +0000)]
Unreviewed buildfix.

* UIProcess/WebNetworkInfoManagerProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix Mac build now.
ap@apple.com [Tue, 24 Sep 2013 22:57:31 +0000 (22:57 +0000)]
Fix Mac build now.

* UIProcess/WebContext.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSVG Animations are flaky
ap@apple.com [Tue, 24 Sep 2013 22:45:36 +0000 (22:45 +0000)]
SVG Animations are flaky
https://bugs.webkit.org/show_bug.cgi?id=107018

* platform/mac-wk2/TestExpectations: Marked some frequently failing tests

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed buildfix after r156350.
ossy@webkit.org [Tue, 24 Sep 2013 22:40:55 +0000 (22:40 +0000)]
Unreviewed buildfix after r156350.

* UIProcess/WebContext.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Mac][WK2] Multiple font tests fail is there is a global setting for font antialiasin...
ap@apple.com [Tue, 24 Sep 2013 22:35:23 +0000 (22:35 +0000)]
[Mac][WK2] Multiple font tests fail is there is a global setting for font antialiasing threshold
https://bugs.webkit.org/show_bug.cgi?id=121854

Reviewed by Anders Carlsson.

* WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
(WTR::InjectedBundle::platformInitialize): Post a notification to update cached
settings in underlying frameworks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Shapes] Modify updateSegmentsForShapes function to use logical coordinates
zoltan@webkit.org [Tue, 24 Sep 2013 22:24:39 +0000 (22:24 +0000)]
[CSS Shapes] Modify updateSegmentsForShapes function to use logical coordinates
https://bugs.webkit.org/show_bug.cgi?id=121864

Reviewed by David Hyatt.

When I landed updateSegmentsForShapes in r156022, I didn't use logical coordinates. This change modifies the
code to use coordinates for positioning the float and the content around the float in a shape-inside. Now I
added only one writing mode tests, but I will add more later in bug #121866.

Source/WebCore:

Test: fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-vertical-lr-inline-content.html

* rendering/FloatingObjects.h:
(WebCore::FloatingObject::logicalHeight):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeLogicalLocationForFloat):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::updateSegmentsForShapes):

LayoutTests:

* fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-vertical-lr-inline-content-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-vertical-lr-inline-content.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed buildfix after r156354 and r156360.
ossy@webkit.org [Tue, 24 Sep 2013 22:18:17 +0000 (22:18 +0000)]
Unreviewed buildfix after r156354 and r156360.

* Platform/CoreIPC/unix/ConnectionUnix.cpp:
(CoreIPC::Connection::processMessage):
(CoreIPC::Connection::sendOutgoingMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFlaky Test: fast/history/history-subframe-with-name.html
ap@apple.com [Tue, 24 Sep 2013 22:09:19 +0000 (22:09 +0000)]
Flaky Test: fast/history/history-subframe-with-name.html
https://bugs.webkit.org/show_bug.cgi?id=51039

Reviewed by Anders Carlsson.

Speculative fix, I could not reproduce locally.

* fast/history/resources/history-subframe-with-name-container.html: Added a check
that onunload trick worked.

* fast/history/resources/history-subframe-with-name-2.html: Starting the navigation
used to race with loading another iframe in the parent. Wait until the parent loads.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed buildfix after r156349.
ossy@webkit.org [Tue, 24 Sep 2013 21:51:00 +0000 (21:51 +0000)]
Unreviewed buildfix after r156349.

* Platform/CoreIPC/unix/ConnectionUnix.cpp:
(CoreIPC::Connection::processMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUse std::unique_ptr for decoders as well
andersca@apple.com [Tue, 24 Sep 2013 21:46:18 +0000 (21:46 +0000)]
Use std::unique_ptr for decoders as well
https://bugs.webkit.org/show_bug.cgi?id=121868

Reviewed by Andreas Kling.

* Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::SyncMessageState::processIncomingMessage):
(CoreIPC::Connection::SyncMessageState::dispatchMessages):
(CoreIPC::Connection::waitForMessage):
(CoreIPC::Connection::sendSyncMessage):
(CoreIPC::Connection::sendSyncMessageFromSecondaryThread):
(CoreIPC::Connection::waitForSyncReply):
(CoreIPC::Connection::processIncomingSyncReply):
(CoreIPC::Connection::processIncomingMessage):
(CoreIPC::Connection::enqueueIncomingMessage):
(CoreIPC::Connection::dispatchMessage):
(CoreIPC::Connection::dispatchOneMessage):
* Platform/CoreIPC/Connection.h:
(CoreIPC::Connection::sendSync):
(CoreIPC::Connection::waitForAndDispatchImmediately):
* Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::createMessageDecoder):
(CoreIPC::Connection::receiveSourceEventHandler):
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::postSynchronousMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove IDBTransactionCallbacks.h from the .xcodeproj, as it's gone from the repository.
beidson@apple.com [Tue, 24 Sep 2013 21:25:58 +0000 (21:25 +0000)]
Remove IDBTransactionCallbacks.h from the .xcodeproj, as it's gone from the repository.

Rubberstamped by Anders Carlsson and Alexey Proskuryakov.

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Using Breakpoint Actions Breaks iOS inspection
commit-queue@webkit.org [Tue, 24 Sep 2013 21:23:33 +0000 (21:23 +0000)]
Web Inspector: Using Breakpoint Actions Breaks iOS inspection
https://bugs.webkit.org/show_bug.cgi?id=121862

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-09-24
Reviewed by Timothy Hatcher.

Only use DebuggerAgent.BreakpointActionType if it is available.
Otherwise leave options undefined for breakpoints since the backend
does not support it.

* UserInterface/DebuggerManager.js:
(WebInspector.DebuggerManager.prototype._setBreakpoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Include iOS 7 Inspector.json Version
commit-queue@webkit.org [Tue, 24 Sep 2013 21:19:23 +0000 (21:19 +0000)]
Web Inspector: Include iOS 7 Inspector.json Version
https://bugs.webkit.org/show_bug.cgi?id=121852

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-09-24
Reviewed by Timothy Hatcher.

* UserInterface/Legacy/7.0/InspectorBackendCommands.js: Added.
* Versions/Inspector-iOS-7.0.json: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agowebgl/conformance/extensions/oes-element-index-uint.html failing after r156351 or...
dino@apple.com [Tue, 24 Sep 2013 20:50:39 +0000 (20:50 +0000)]
webgl/conformance/extensions/oes-element-index-uint.html failing after r156351 or 156352
https://bugs.webkit.org/show_bug.cgi?id=121863
<rdar://problem/15069481>

Temporarily skipped while investigating.

* TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoTighten table rendering code
antti@apple.com [Tue, 24 Sep 2013 20:47:01 +0000 (20:47 +0000)]
Tighten table rendering code
https://bugs.webkit.org/show_bug.cgi?id=121860

Reviewed by Andreas Kling.

Hide firstChild/lastChild/nextSibling/previousSibling in table renderers,
expose correctly typed firstRow/nextCell etc instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove MessageEncoder and ArgumentEncoder to std::unique_ptr
andersca@apple.com [Tue, 24 Sep 2013 20:41:34 +0000 (20:41 +0000)]
Move MessageEncoder and ArgumentEncoder to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=121861

Reviewed by Andreas Kling.

* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::didReceiveSyncMessage):
* NetworkProcess/NetworkConnectionToWebProcess.h:
* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::didReceiveSyncMessage):
* NetworkProcess/NetworkProcess.h:
* Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::dispatchWorkQueueMessageReceiverMessage):
(CoreIPC::Connection::createSyncMessageEncoder):
(CoreIPC::Connection::sendMessage):
(CoreIPC::Connection::sendSyncReply):
(CoreIPC::Connection::sendSyncMessage):
(CoreIPC::Connection::sendSyncMessageFromSecondaryThread):
(CoreIPC::Connection::sendOutgoingMessages):
(CoreIPC::Connection::dispatchSyncMessage):
* Platform/CoreIPC/Connection.h:
(CoreIPC::Connection::send):
(CoreIPC::Connection::sendSync):
* Platform/CoreIPC/HandleMessage.h:
(CoreIPC::handleMessageDelayed):
* Platform/CoreIPC/MessageReceiver.h:
(CoreIPC::MessageReceiver::didReceiveSyncMessage):
* Platform/CoreIPC/MessageReceiverMap.cpp:
(CoreIPC::MessageReceiverMap::dispatchSyncMessage):
* Platform/CoreIPC/MessageReceiverMap.h:
* Platform/CoreIPC/MessageSender.cpp:
(CoreIPC::MessageSender::sendMessage):
* Platform/CoreIPC/MessageSender.h:
(CoreIPC::MessageSender::send):
* Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::Connection::open):
(CoreIPC::Connection::sendOutgoingMessage):
* PluginProcess/PluginControllerProxy.h:
* PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::didReceiveSyncMessage):
* PluginProcess/WebProcessConnection.h:
* Scripts/webkit2/messages.py:
(message_to_struct_declaration):
(generate_message_handler):
* Scripts/webkit2/messages_unittest.py:
* Shared/ChildProcessProxy.cpp:
(WebKit::ChildProcessProxy::sendMessage):
(WebKit::ChildProcessProxy::dispatchSyncMessage):
(WebKit::ChildProcessProxy::didFinishLaunching):
* Shared/ChildProcessProxy.h:
(WebKit::ChildProcessProxy::send):
* Shared/Plugins/NPObjectMessageReceiver.h:
* Shared/Plugins/NPRemoteObjectMap.cpp:
(WebKit::NPRemoteObjectMap::didReceiveSyncMessage):
* Shared/Plugins/NPRemoteObjectMap.h:
* Shared/WebConnection.cpp:
(WebKit::WebConnection::postMessage):
* UIProcess/Downloads/DownloadProxy.h:
* UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::didReceiveSyncMessage):
* UIProcess/Network/NetworkProcessProxy.h:
* UIProcess/Plugins/PluginProcessProxy.h:
* UIProcess/Storage/StorageManager.h:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::dispatchSyncMessage):
(WebKit::WebContext::didReceiveSyncMessage):
* UIProcess/WebContext.h:
* UIProcess/WebFullScreenManagerProxy.h:
* UIProcess/WebIconDatabase.h:
* UIProcess/WebInspectorProxy.h:
* UIProcess/WebPageProxy.h:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didReceiveSyncMessage):
* UIProcess/WebProcessProxy.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::postMessage):
(WebKit::InjectedBundle::postSynchronousMessage):
* WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::didReceiveSyncMessage):
* WebProcess/Network/NetworkProcessConnection.h:
* WebProcess/Plugins/PluginProcessConnection.cpp:
(WebKit::PluginProcessConnection::didReceiveSyncMessage):
* WebProcess/Plugins/PluginProcessConnection.h:
* WebProcess/Plugins/PluginProxy.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didReceiveSyncMessage):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didReceiveSyncMessage):
* WebProcess/WebProcess.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove encoder create functions
andersca@apple.com [Tue, 24 Sep 2013 19:59:12 +0000 (19:59 +0000)]
Remove encoder create functions
https://bugs.webkit.org/show_bug.cgi?id=121853

Reviewed by Sam Weinig.

Source/WebKit2:

* Platform/CoreIPC/ArgumentEncoder.cpp:
* Platform/CoreIPC/ArgumentEncoder.h:
* Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::dispatchWorkQueueMessageReceiverMessage):
(CoreIPC::Connection::createSyncMessageEncoder):
(CoreIPC::Connection::dispatchSyncMessage):
* Platform/CoreIPC/Connection.h:
(CoreIPC::Connection::send):
* Platform/CoreIPC/MessageEncoder.cpp:
(CoreIPC::MessageEncoder::setIsSyncMessage):
* Platform/CoreIPC/MessageEncoder.h:
* Platform/CoreIPC/MessageSender.h:
(CoreIPC::MessageSender::send):
* Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::Connection::open):
* Shared/ChildProcessProxy.h:
(WebKit::ChildProcessProxy::send):
* Shared/WebConnection.cpp:
(WebKit::WebConnection::postMessage):
* UIProcess/WebContext.cpp:
(WebKit::WebContext::createNewWebProcess):
(WebKit::WebContext::postMessageToInjectedBundle):
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::postMessage):
* WebProcess/WebPage/EncoderAdapter.cpp:
(WebKit::EncoderAdapter::EncoderAdapter):
(WebKit::EncoderAdapter::dataReference):
(WebKit::EncoderAdapter::encodeBytes):
(WebKit::EncoderAdapter::encodeBool):
(WebKit::EncoderAdapter::encodeUInt16):
(WebKit::EncoderAdapter::encodeUInt32):
(WebKit::EncoderAdapter::encodeUInt64):
(WebKit::EncoderAdapter::encodeInt32):
(WebKit::EncoderAdapter::encodeInt64):
(WebKit::EncoderAdapter::encodeFloat):
(WebKit::EncoderAdapter::encodeDouble):
(WebKit::EncoderAdapter::encodeString):
* WebProcess/WebPage/EncoderAdapter.h:

Source/WTF:

Add a variadic version of createOwned.

* wtf/OwnPtr.h:
(WTF::createOwned):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoImplement symbol name hashing for WebGL shaders
dino@apple.com [Tue, 24 Sep 2013 19:43:25 +0000 (19:43 +0000)]
Implement symbol name hashing for WebGL shaders
https://bugs.webkit.org/show_bug.cgi?id=121849

Reviewed by Anders Carlsson.

Turn on ANGLE's symbol name mapping for shader programs.
This avoids compilation failures (or worse, crashers)
on some hardware that doesn't like it when shaders redefine
symbols like "sin", even though that is valid.

The way ANGLE exposes this is via setting a pointer
to a char* -> uint64_t hash function. Since we only have
a 32-bit hash in WebKit, I combine the 32-bit value with
a counter value that exists over the lifetime of a GC3D context.
Before calling ANGLE, I point the global hash map to the local
hash map, and then clean up after we're done. This introduces
a memory hit, in that the symbol table will build up until
the context is released.

Covered by Khronos WebGL tests, including
conformance/glsl/misc/shader-with-non-reserved-words.html

* platform/graphics/GraphicsContext3D.h: Define a ShaderNameHash type,
and add an OwnPtr to one as a member variable.
* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::nameHashForShader): Global function used for ANGLE hashing.
(WebCore::GraphicsContext3D::compileShader): Set up the ANGLE properties,
point to the local hash map, and call compile/translate.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUse mapped name in attribute location binding
dino@apple.com [Tue, 24 Sep 2013 19:43:22 +0000 (19:43 +0000)]
Use mapped name in attribute location binding
https://bugs.webkit.org/show_bug.cgi?id=121847
<rdar://problem/15067526>

Reviewed by Eric Carlson.

Source/WebCore:

The shader that we send down to OpenGL to compile
may have been translated by ANGLE, so we keep a
table around that maps input symbols to output symbols.
We used the table when binding to and looking up
uniforms, and when looking up attributes, but not
when actually binding to attribute locations.

Test: fast/canvas/webgl/gl-bind-attrib-mapped-names.html

* platform/graphics/ANGLEWebKitBridge.cpp:
(WebCore::getSymbolInfo): Add logging of symbol mapping.
* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::bindAttribLocation): Used the mapped name.
(WebCore::GraphicsContext3D::getAttribLocation): Remove comment since
we do the lookup everywhere.
(WebCore::GraphicsContext3D::getUniformLocation): Ditto.

LayoutTests:

New test that has an attribute name long enough
to trigger symbol mapping in all cases.

* fast/canvas/webgl/gl-bind-attrib-mapped-names-expected.txt: Added.
* fast/canvas/webgl/gl-bind-attrib-mapped-names.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpstream changes to Pasteboard implementation for iOS.
enrica@apple.com [Tue, 24 Sep 2013 19:35:30 +0000 (19:35 +0000)]
Upstream changes to Pasteboard implementation for iOS.
https://bugs.webkit.org/show_bug.cgi?id=121818

Reviewed by Darin Adler.

Source/WebCore:

* WebCore.xcodeproj/project.pbxproj:
* editing/Editor.cpp:
(WebCore::Editor::cut):
(WebCore::Editor::copyImage):
* editing/ios/EditorIOS.mm:
(WebCore::attributedStringForRange):
(WebCore::dataInRTFDFormat):
(WebCore::dataInRTFFormat):
(WebCore::Editor::stringSelectionForPasteboardWithImageAltText):
(WebCore::Editor::selectionInWebArchiveFormat):
(WebCore::Editor::writeSelectionToPasteboard):
(WebCore::getImage):
(WebCore::Editor::writeImageToPasteboard):
* platform/Pasteboard.h:
* platform/PasteboardStrategy.h:
* platform/PlatformPasteboard.h:
* platform/ios/PasteboardIOS.mm:
* platform/ios/PlatformPasteboardIOS.mm: Added.
(WebCore::PlatformPasteboard::PlatformPasteboard):
(WebCore::PlatformPasteboard::getTypes):
(WebCore::PlatformPasteboard::bufferForType):
(WebCore::PlatformPasteboard::getPathnamesForType):
(WebCore::PlatformPasteboard::stringForType):
(WebCore::PlatformPasteboard::color):
(WebCore::PlatformPasteboard::url):
(WebCore::PlatformPasteboard::copy):
(WebCore::PlatformPasteboard::addTypes):
(WebCore::PlatformPasteboard::setTypes):
(WebCore::PlatformPasteboard::setBufferForType):
(WebCore::PlatformPasteboard::setPathnamesForType):
(WebCore::PlatformPasteboard::setStringForType):
(WebCore::PlatformPasteboard::changeCount):
(WebCore::PlatformPasteboard::uniqueName):
(WebCore::PlatformPasteboard::write):

Source/WebKit/mac:

* WebCoreSupport/WebPlatformStrategies.h:
* WebCoreSupport/WebPlatformStrategies.mm:
(WebPlatformStrategies::writeToPasteboard):

Source/WebKit2:

* Scripts/webkit2/messages.py:
(struct_or_class):
(headers_for_type):
* Shared/WebCoreArgumentCoders.cpp:
(CoreIPC::encodeSharedBuffer):
(CoreIPC::decodeSharedBuffer):
(CoreIPC::::encode):
(CoreIPC::::decode):
* Shared/WebCoreArgumentCoders.h:
* UIProcess/WebContext.h:
* UIProcess/WebContext.messages.in:
* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::writeWebContentToPasteboard):
(WebKit::WebContext::writeImageToPasteboard):
(WebKit::WebContext::writeStringToPasteboard):
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::writeToPasteboard):
* WebProcess/WebCoreSupport/WebPlatformStrategies.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove create functions from MessageDecoder and ArgumentDecoder
andersca@apple.com [Tue, 24 Sep 2013 19:23:13 +0000 (19:23 +0000)]
Remove create functions from MessageDecoder and ArgumentDecoder
https://bugs.webkit.org/show_bug.cgi?id=121850

Reviewed by Antti Koivisto.

* Platform/CoreIPC/ArgumentDecoder.cpp:
(CoreIPC::ArgumentDecoder::ArgumentDecoder):
* Platform/CoreIPC/ArgumentDecoder.h:
* Platform/CoreIPC/MessageDecoder.cpp:
(CoreIPC::MessageDecoder::MessageDecoder):
* Platform/CoreIPC/MessageDecoder.h:
* Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::createMessageDecoder):
* WebProcess/WebPage/DecoderAdapter.cpp:
(WebKit::DecoderAdapter::DecoderAdapter):
(WebKit::DecoderAdapter::decodeBytes):
(WebKit::DecoderAdapter::decodeBool):
(WebKit::DecoderAdapter::decodeUInt16):
(WebKit::DecoderAdapter::decodeUInt32):
(WebKit::DecoderAdapter::decodeUInt64):
(WebKit::DecoderAdapter::decodeInt32):
(WebKit::DecoderAdapter::decodeInt64):
(WebKit::DecoderAdapter::decodeFloat):
(WebKit::DecoderAdapter::decodeDouble):
(WebKit::DecoderAdapter::decodeString):
* WebProcess/WebPage/DecoderAdapter.h:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::postInjectedBundleMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago<rdar://problem/14971518> WebKit should build against the Xcode default toolchain...
mrowe@apple.com [Tue, 24 Sep 2013 19:18:46 +0000 (19:18 +0000)]
<rdar://problem/14971518> WebKit should build against the Xcode default toolchain when targeting OS X 10.8

Reviewed by Dan Bernstein.

Source/JavaScriptCore:

* Configurations/Base.xcconfig:

Source/ThirdParty/ANGLE:

* Configurations/Base.xcconfig:

Source/WebCore:

* Configurations/Base.xcconfig:

Source/WebInspectorUI:

* Configurations/Base.xcconfig:

Source/WebKit/mac:

* Configurations/Base.xcconfig:

Source/WebKit2:

* Configurations/Base.xcconfig:

Source/WTF:

* Configurations/Base.xcconfig:

Tools:

* DumpRenderTree/mac/Configurations/Base.xcconfig:
* MiniBrowser/Configurations/Base.xcconfig:
* TestWebKitAPI/Configurations/Base.xcconfig:
* WebKitLauncher/Configurations/Base.xcconfig:
* WebKitTestRunner/Configurations/Base.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[iOS] Upstream -webkit-touch-callout
dbates@webkit.org [Tue, 24 Sep 2013 19:14:42 +0000 (19:14 +0000)]
[iOS] Upstream -webkit-touch-callout
https://bugs.webkit.org/show_bug.cgi?id=121507

Reviewed by Antti Koivisto.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSPropertyNames.in: Added -webkit-touch-callout.
* css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::willRespondToMouseClickEvents): Added.
* html/HTMLImageElement.h:
* rendering/style/RenderStyle.h:
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
* rendering/style/StyleRareInheritedData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoProperly handle bottom margin on float with shape-outside
bjonesbe@adobe.com [Tue, 24 Sep 2013 19:02:59 +0000 (19:02 +0000)]
Properly handle bottom margin on float with shape-outside
https://bugs.webkit.org/show_bug.cgi?id=121808

Reviewed by David Hyatt.

Source/WebCore:

When a float has a shape-outside, inline content must conform to the
shape, not to the margin box. Thus, if a float with shape-outside has
a bottom margin and the shape does not intrude into that margin, then
the inline content should ignore the margin. Before this patch, inline
content would drop below the margin box instead of obeying the shape.

Note that content that should clear the float still clears the margin
box, not the shape's contour.

Tests: csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-002.html
       csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-003.html
       csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-004.html

* rendering/LineWidth.cpp:
(WebCore::LineWidth::fitBelowFloats): Compute the logical bottom based
on the shape.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::nextFloatLogicalBottomBelow): Add option to
compute the logical bottom based on the shape instead of on the margin
box.
* rendering/RenderBlock.h:

LayoutTests:

Import new tests for floats wish shape-outside and bottom margins.

* csswg/contributors/adobe/submitted/shapes/shape-outside/resources/w3c-import.log:
* csswg/contributors/adobe/submitted/shapes/shape-outside/resources/rounded-rectangle.js: Remove whitespace at ends of lines.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-002.html: Added.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-003-expected.html: Added.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-003.html: Added.
* csswg/contributors/adobe/submitted/shapes/shape-outside/w3c-import.log:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Fix compilation problems when setting ENABLE_DRAG_SUPPORT = FALSE
commit-queue@webkit.org [Tue, 24 Sep 2013 18:58:12 +0000 (18:58 +0000)]
[GTK] Fix compilation problems when setting ENABLE_DRAG_SUPPORT = FALSE
https://bugs.webkit.org/show_bug.cgi?id=121782

Patch by Lorenzo Tilve <ltilve@igalia.com> on 2013-09-24
Reviewed by Martin Robinson.

Disabled drag functions.

Source/WebCore:

* page/gtk/EventHandlerGtk.cpp:
* platform/gtk/PasteboardGtk.cpp:

Source/WebKit/gtk:

* WebCoreSupport/DragClientGtk.cpp:
* WebCoreSupport/DragClientGtk.h:

Source/WebKit2:

* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkit_web_view_base_class_init):
* WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Windows] Unreviewed crash fix after r156321.
bfulgham@apple.com [Tue, 24 Sep 2013 18:42:05 +0000 (18:42 +0000)]
[Windows] Unreviewed crash fix after r156321.

Fix a few mistakes in the use of Vectors and counting that introduced test crashes.

* WebHistory.cpp:
(WebHistory::removeAllItems): Loop termination tried to test an unsigned for negative size.
(WebHistory::removeItemFromDateCaches): Vector was being created with empty entries.
(WebHistory::addItemToDateCaches): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156344 268f45cc-cd09-0410-ab3c-d52691b4dbfc