WebKit-https.git
8 years agoFix the SnowLeoaprd build.
weinig@apple.com [Mon, 5 Mar 2012 23:45:40 +0000 (23:45 +0000)]
Fix the SnowLeoaprd build.

* WebKitSystemInterface.h:
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceLion.a:
* libWebKitSystemInterfaceSnowLeopard.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CSSRegions][CSSOM]Prevent creation of NamedFlow object for invalid flow name
mihnea@adobe.com [Mon, 5 Mar 2012 23:31:50 +0000 (23:31 +0000)]
[CSSRegions][CSSOM]Prevent creation of NamedFlow object for invalid flow name
https://bugs.webkit.org/show_bug.cgi?id=79685

Reviewed by David Hyatt.

Asking for a named flow with an invalid flow name should return a null object.

Source/WebCore:

Test: fast/regions/webkit-named-flow-invalid-name.html

* css/CSSParser.cpp:
(WebCore::CSSParser::parseFlowThread):
(WebCore):
* css/CSSParser.h:
* dom/Document.cpp:
(WebCore::validFlowName):
(WebCore):
(WebCore::Document::webkitGetFlowByName):

LayoutTests:

* fast/regions/webkit-named-flow-invalid-name-expected.txt: Added.
* fast/regions/webkit-named-flow-invalid-name.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agounicode-bidi should support isolate override and override isolate
rniwa@webkit.org [Mon, 5 Mar 2012 23:09:22 +0000 (23:09 +0000)]
unicode-bidi should support isolate override and override isolate
https://bugs.webkit.org/show_bug.cgi?id=73164

Reviewed by Eric Seidel.

Source/WebCore:

Updated CSS parser and CSS style selector to support the union of bidi-override and isolate in
unicode-bidi property. Added OverrideIsolate to EUnicodeBidi instead of turning Override and Isolate
into bit flags to avoid increasing the number of bits required to store the unicodeBidi flag.

Also fixed a bug in RenderBlock::constructTextRun to actually check whether an isolated run's direction
is overridden or not when constructing one.

Tests: fast/css/unicode-bidi-computed-value.html
       fast/text/bidi-override-isolate.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::renderUnicodeBidiFlagsToCSSValue): Added; Create a CSSValueList when unicode-bidi has both
isolate and bidi-override specified.
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):  Calls renderUnicodeBidiFlagsToCSSValue.
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue): Support parsing combinations of -webkit-isolate and bidi-override;
Create a CSSValueList in such cases.
* css/CSSPrimitiveValueMappings.h:
(WebCore):
* css/CSSStyleApplyProperty.cpp:
(ApplyPropertyUnicodeBidi):
(WebCore::ApplyPropertyUnicodeBidi::applyValue): Support combinations of -webkit-isolate and
bidi-override. Set the unicodeBidi flag to OverrideIsolate in such cases.
(WebCore::ApplyPropertyUnicodeBidi::createHandler):
(WebCore):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawTextInternal):
* platform/text/UnicodeBidi.h: Added OverrideIsolate. We don't use bit flags to avoid increasing the
number of bits required to store flags especially because isolate and bidi-override are only values
that can be combined.
(WebCore::isIsolated):
(WebCore):
(WebCore::isOverride):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::constructTextRun):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::statusWithDirection): Takes isOverride; we used to assume it's always false.
(WebCore::constructBidiRuns): Instantiate isolatedResolver with a proper value of isOverride.
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::determineStartPosition):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::paintItemForeground):
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::itemStyle):
(WebCore::RenderMenuList::menuStyle):
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::menuStyle):
* rendering/svg/SVGTextMetrics.cpp:
(WebCore::SVGTextMetrics::constructTextRun):

LayoutTests:

Added a test for retrieving computed value of unicode-bidi property
and also added a test to render "unicode-bidi: -webkit-isolate bidi-override".

* fast/css/unicode-bidi-computed-value-expected.txt: Added.
* fast/css/unicode-bidi-computed-value.html: Added.
* fast/text/bidi-override-isolate-expected.html: Added.
* fast/text/bidi-override-isolate.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoReplace uses of x(), y() and width(), height() pairs with locationOffset and size()
eae@chromium.org [Mon, 5 Mar 2012 22:58:55 +0000 (22:58 +0000)]
Replace uses of x(), y() and width(), height() pairs with locationOffset and size()
https://bugs.webkit.org/show_bug.cgi?id=80196

Reviewed by Julien Chaffraix.

Replace IntSize(x(), y()) with locationOffset()
Replace IntSize(width(), height()) with size()
Replace IntRect(0, 0, width(), height()) with IntRect(IntPoint(), size())
Replace IntRect::move(x(), y()) with IntRect::move(locationOffset())

No new tests.

* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::createImageBuffer):
(WebCore::HTMLCanvasElement::baseTransform):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::simplifiedLayout):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::mapLocalToContainer):
(WebCore::RenderBox::computeRectForRepaint):
* rendering/RenderBox.h:
(WebCore::RenderBox::borderBoxRect):
* rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::localSelectionRect):
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::localSelectionRect):
* rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::updateScrollbarParts):
(WebCore::RenderScrollbar::buttonRect):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::setCellLogicalWidths):
(WebCore::RenderTableSection::layoutRows):
* rendering/RenderView.cpp:
(WebCore::RenderView::viewRect):
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::layout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd support for hosting layers in the window server in WebKit2
weinig@apple.com [Mon, 5 Mar 2012 22:53:43 +0000 (22:53 +0000)]
Add support for hosting layers in the window server in WebKit2
<rdar://problem/10400246>
https://bugs.webkit.org/show_bug.cgi?id=80310

Reviewed by Anders Carlsson.

Source/JavaScriptCore:

* wtf/Platform.h:
Add HAVE_LAYER_HOSTING_IN_WINDOW_SERVER.

Source/WebKit2:

This currently only works if you are using TiledCoreAnimation drawing model.

* Platform/mac/LayerHostingContext.h: Renamed from Source/WebKit2/Platform/mac/RemoteLayerClient.h.
* Platform/mac/LayerHostingContext.mm: Renamed from Source/WebKit2/Platform/mac/RemoteLayerClient.mm.
(WebKit::LayerHostingContext::createForPort):
(WebKit::LayerHostingContext::LayerHostingContext):
(WebKit::LayerHostingContext::createForWindowServer):
(WebKit::LayerHostingContext::~LayerHostingContext):
(WebKit::LayerHostingContext::setRootLayer):
(WebKit::LayerHostingContext::rootLayer):
(WebKit::LayerHostingContext::contextID):
(WebKit::LayerHostingContext::invalidate):
Renamed RemoteLayerClient to LayerHostingContext and add ability to use the window server
as the remote context.

* PluginProcess/PluginControllerProxy.cpp:
* PluginProcess/PluginControllerProxy.h:
* PluginProcess/mac/PluginControllerProxyMac.mm:
Update for new names.

* Shared/LayerTreeContext.h:
Add LayerHostingMode enum.

* UIProcess/PageClient.h:
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::layerHostingMode):
(WebKit::PageClientImpl::updateAcceleratedCompositingMode):
Add PageClient access points to get the current layer hosting mode,
and a hook to tell the underlying view that the layer hosting context
has changed.

* UIProcess/API/mac/WKViewInternal.h:
* UIProcess/API/mac/WKView.mm:
(-[WKView _updateAcceleratedCompositingMode:WebKit::]):
Implement responding to a new layer hosting context as a simple
exit and re-entrance of compositing.

* UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::layerHostingModeDidChange):
(WebKit::DrawingAreaProxy::updateAcceleratedCompositingMode):
* UIProcess/DrawingAreaProxy.messages.in:
* UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
(TiledCoreAnimationDrawingAreaProxy):
* UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
(WebKit::TiledCoreAnimationDrawingAreaProxy::layerHostingModeDidChange):
(WebKit::TiledCoreAnimationDrawingAreaProxy::updateAcceleratedCompositingMode):
Pipe layer hosting changes around.

* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::layerHostingMode):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::viewStateDidChange):
Cache the current layer hosting mode so we don't overzealously
tell the WebProcess to reset its context. Re-check layer hosting
mode each time we are added/removed from a window.

* WebProcess/FullScreen/mac/WebFullScreenManagerMac.h:
* WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:
Update for new names.

* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::setDeviceScaleFactor):
(WebKit::DrawingArea::setLayerHostingMode):
* WebProcess/WebPage/DrawingArea.messages.in:
Pipe layer hosting changes around.

* WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.h:
* WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm:
(WebKit::LayerTreeHostCAMac::~LayerTreeHostCAMac):
(WebKit::LayerTreeHostCAMac::platformInitialize):
(WebKit::LayerTreeHostCAMac::invalidate):
Update for new names.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::setLayerHostingMode):
Respond to a change in the layer hosting mode by invalidating our old context,
making a new one of the right type, and informing the UIProcess of our new context.

* WebKit2.xcodeproj/project.pbxproj:
Add new files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Add missing method to PasteboardBlackBerry.cpp
rwlbuis@webkit.org [Mon, 5 Mar 2012 22:33:20 +0000 (22:33 +0000)]
[BlackBerry] Add missing method to PasteboardBlackBerry.cpp
https://bugs.webkit.org/show_bug.cgi?id=80326

Reviewed by Antonio Gomes.

Add missing method.

* platform/blackberry/PasteboardBlackBerry.cpp:
(WebCore::Pasteboard::writeClipboard):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, attempted build fix for !ENABLE(JIT) after r109705.
fpizlo@apple.com [Mon, 5 Mar 2012 22:10:57 +0000 (22:10 +0000)]
Unreviewed, attempted build fix for !ENABLE(JIT) after r109705.

* bytecode/ExecutionCounter.cpp:
(JSC::ExecutionCounter::applyMemoryUsageHeuristics):
* bytecode/ExecutionCounter.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAlways update the scroll layer position on the main thread when we have an overlay
andersca@apple.com [Mon, 5 Mar 2012 22:01:15 +0000 (22:01 +0000)]
Always update the scroll layer position on the main thread when we have an overlay
https://bugs.webkit.org/show_bug.cgi?id=80324

Reviewed by Sam Weinig.

Source/WebCore:

Add a way to ensure that scroll layer position updates happen on the main thread.

* WebCore.exp.in:
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::ScrollingCoordinator):
(WebCore::ScrollingCoordinator::updateShouldUpdateScrollLayerPositionOnMainThread):
(WebCore):
(WebCore::ScrollingCoordinator::setForceMainThreadScrollLayerPositionUpdates):
* page/scrolling/ScrollingCoordinator.h:
(ScrollingCoordinator):

Source/WebKit2:

Call setForceMainThreadScrollLayerPositionUpdates when installing and uninstalling page overlays,
so we'll be able to synchronize painting between the tile cache and the page overlays.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::didInstallPageOverlay):
(WebKit::TiledCoreAnimationDrawingArea::didUninstallPageOverlay):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement flex-wrap: wrap
tony@chromium.org [Mon, 5 Mar 2012 21:59:10 +0000 (21:59 +0000)]
Implement flex-wrap: wrap
https://bugs.webkit.org/show_bug.cgi?id=79930

Reviewed by David Hyatt.

Source/WebCore:

Tests: css3/flexbox/multiline-align.html
       css3/flexbox/multiline.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::sizesToIntrinsicLogicalWidth): Don't apply column+stretch optimization to multiline.
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::FlexOrderIterator::FlexOrderIterator):
(WebCore::RenderFlexibleBox::FlexOrderIterator::currentChild): Expose the current child so we can pause
in the middle of iteration and resume later.
(RenderFlexibleBox::FlexOrderIterator):
(WebCore::RenderFlexibleBox::isMultiline):
(WebCore):
(WebCore::RenderFlexibleBox::layoutFlexItems): Loop per line.
(WebCore::RenderFlexibleBox::availableAlignmentSpaceForChild): Use the line space, not the whole container space.
(WebCore::RenderFlexibleBox::computeFlexOrder): Return true for each line.
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren): Use the line offset. Also compute the line height as we go.
(WebCore::RenderFlexibleBox::layoutColumnReverse): Use the line offset.
(WebCore::RenderFlexibleBox::alignChildren): Align based on the line height. For multiline + column, we have to relayout
since the width may change (same as the row case above). We'll have to do something smarter when we implement flex-line-pack.
* rendering/RenderFlexibleBox.h:
(RenderFlexibleBox):

LayoutTests:

* css3/flexbox/multiline-align-expected.txt: Added.
* css3/flexbox/multiline-align.html: Added.
* css3/flexbox/multiline-expected.txt: Added.
* css3/flexbox/multiline.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement WebGL extension EXT_texture_filter_anisotropic
commit-queue@webkit.org [Mon, 5 Mar 2012 21:52:07 +0000 (21:52 +0000)]
Implement WebGL extension EXT_texture_filter_anisotropic
https://bugs.webkit.org/show_bug.cgi?id=79541

This exports the EXT_texture_filter_anisotropic extension with the WEBKIT_ prefix as defined at
https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/extensions/proposals/EXT_texture_filter_anisotropic/index.html

Patch by Ben Vanik <benvanik@google.com> on 2012-03-05
Reviewed by Kenneth Russell.

Tested with the Khronos conformance test for the extension, available at https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/sdk/tests/conformance/extensions/ext-texture-filter-anisotropic.html

* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::toJS):
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toV8Object):
* html/canvas/EXTTextureFilterAnisotropic.cpp: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
(WebCore):
(WebCore::EXTTextureFilterAnisotropic::EXTTextureFilterAnisotropic):
(WebCore::EXTTextureFilterAnisotropic::~EXTTextureFilterAnisotropic):
(WebCore::EXTTextureFilterAnisotropic::getName):
(WebCore::EXTTextureFilterAnisotropic::create):
* html/canvas/EXTTextureFilterAnisotropic.h: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
(WebCore):
(EXTTextureFilterAnisotropic):
* html/canvas/EXTTextureFilterAnisotropic.idl: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
* html/canvas/WebGLExtension.h:
* html/canvas/WebGLObject.cpp:
* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getParameter):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
(WebCore::WebGLRenderingContext::getTexParameter):
(WebCore::WebGLRenderingContext::texParameter):
* html/canvas/WebGLRenderingContext.h:
(WebCore):
(WebGLRenderingContext):
* platform/graphics/Extensions3D.h:
(Extensions3D):
* platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::supports):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromim] Mark http/tests/incremental/partial-jpeg.html as failing.
senorblanco@chromium.org [Mon, 5 Mar 2012 21:49:25 +0000 (21:49 +0000)]
[chromim] Mark http/tests/incremental/partial-jpeg.html as failing.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChange how the Web Inspector Develop menu actions work.
timothy@apple.com [Mon, 5 Mar 2012 21:45:32 +0000 (21:45 +0000)]
Change how the Web Inspector Develop menu actions work.

This removes the methods used by Safari's Develop menu. They can now be implemented in Safari.

https://webkit.org/b/80308

Reviewed by John Sullivan.

* UIProcess/API/C/mac/WKInspectorPrivateMac.h: Renamed from Source/WebKit2/UIProcess/API/C/mac/WKInspectorMac.h.
* UIProcess/mac/WebInspectorProxyMac.mm:
(-[WKWebInspectorProxyObjCAdapter inspectorRef]): Added.
* WebKit2.xcodeproj/project.pbxproj: Renamed WKInspectorPrivateMac.h to better reflect its private nature.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Unreviewed, marking a test that is passing on linux as such.
tony@chromium.org [Mon, 5 Mar 2012 21:42:21 +0000 (21:42 +0000)]
[chromium] Unreviewed, marking a test that is passing on linux as such.

platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html
is passing on the flakiness dashboard.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago FileReader crashes when file is not readable
ap@apple.com [Mon, 5 Mar 2012 21:40:59 +0000 (21:40 +0000)]
    FileReader crashes when file is not readable
        https://bugs.webkit.org/show_bug.cgi?id=79715

        Unreviewed follow-up - skip the test as uses unimplemented beginDragWithFiles.

        * platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r109760.
commit-queue@webkit.org [Mon, 5 Mar 2012 21:33:44 +0000 (21:33 +0000)]
Unreviewed, rolling out r109760.
http://trac.webkit.org/changeset/109760
https://bugs.webkit.org/show_bug.cgi?id=80320

Caused many GTK+ tests to crash (Requested by mrobinson on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-05

.:

* configure.ac:

Source/WebCore:

* platform/network/ResourceHandleClient.h:
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCoreSynchronousLoader):
(WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
(WebCore):
(WebCore::WebCoreSynchronousLoader::~WebCoreSynchronousLoader):
(WebCore::WebCoreSynchronousLoader::didReceiveResponse):
(WebCore::WebCoreSynchronousLoader::didReceiveData):
(WebCore::WebCoreSynchronousLoader::didFinishLoading):
(WebCore::WebCoreSynchronousLoader::didFail):
(WebCore::WebCoreSynchronousLoader::run):
(WebCore::closeCallback):
(WebCore::readCallback):
(WebCore::ResourceHandle::defaultSession):

Tools:

* gtk/jhbuild.modules:

LayoutTests:

* http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers-expected.txt: Removed.
* http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNever dispatch mutation events in shadow DOM
adamk@chromium.org [Mon, 5 Mar 2012 21:29:44 +0000 (21:29 +0000)]
Never dispatch mutation events in shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=79278

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/dom/shadow/suppress-mutation-events-in-shadow.html

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeChildren): Move allowEventDispatch() call later,
now that childrenChanged won't trigger mutation events in shadow dom.
(WebCore::dispatchChildInsertionEvents): Bail out if in shadow tree.
(WebCore::dispatchChildRemovalEvents): ditto.
* dom/Node.cpp:
(WebCore::Node::dispatchSubtreeModifiedEvent): ditto.

LayoutTests:

* fast/dom/shadow/suppress-mutation-events-in-shadow-expected.txt: Added.
* fast/dom/shadow/suppress-mutation-events-in-shadow.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago BlobResourceHandle should keep a reference to itself when calling client...
ap@apple.com [Mon, 5 Mar 2012 21:16:30 +0000 (21:16 +0000)]
    BlobResourceHandle should keep a reference to itself when calling client code.
        https://bugs.webkit.org/show_bug.cgi?id=80318

        Reviewed by Brady Eidson.

        * platform/network/BlobResourceHandle.cpp:
        (WebCore::BlobResourceHandle::doStart):
        (WebCore::BlobResourceHandle::getSizeForNext):
        (WebCore::BlobResourceHandle::readSync):
        (WebCore::BlobResourceHandle::readDataAsync):
        (WebCore::BlobResourceHandle::consumeData):
        (WebCore::BlobResourceHandle::failed):
        Added RefPtrs in functions that can result in calling client code, and use "this" object afterwards.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoLet RenderLayerCompositor set the tile cache visible rect
andersca@apple.com [Mon, 5 Mar 2012 21:10:23 +0000 (21:10 +0000)]
Let RenderLayerCompositor set the tile cache visible rect
https://bugs.webkit.org/show_bug.cgi?id=80317

Reviewed by Simon Fraser.

We can't compute the visible rect from CALayers, because that breaks when we're updating
the scroll layer position on the main thread (since by the time visibleRectChanged() is called,
the CALayers won't yet have been updated).

* platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::visibleRectChanged):
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::visibleRectChanged):
* platform/graphics/ca/GraphicsLayerCA.h:
(GraphicsLayerCA):
* platform/graphics/ca/PlatformCALayer.h:
(PlatformCALayer):
* platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayer::visibleRectChanged):
* platform/graphics/ca/mac/TileCache.h:
(TileCache):
* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::visibleRectChanged):
(WebCore::TileCache::revalidateTiles):
* platform/graphics/ca/mac/WebTileCacheLayer.h:
(WebCore):
* platform/graphics/ca/mac/WebTileCacheLayer.mm:
(-[WebTileCacheLayer visibleRectChanged:]):
* platform/graphics/ca/win/PlatformCALayerWin.cpp:
(PlatformCALayer::visibleRectChanged):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::frameViewDidScroll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CMake][DRT] Add WebCoreTestSupport.
paroga@webkit.org [Mon, 5 Mar 2012 21:02:31 +0000 (21:02 +0000)]
[CMake][DRT] Add WebCoreTestSupport.
https://bugs.webkit.org/show_bug.cgi?id=79896

Patch by Kangil Han <kangil.han@samsung.com> on 2012-03-05
Reviewed by Daniel Bates.

Add WebCoreTestSupport library for DRT in CMake.
We will use internals object by linking this library on DRT.

.:

* CMakeLists.txt:

Source/WebCore:

* CMakeLists.txt:
* UseJSC.cmake:
* UseV8.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate WebKitSystemInterface for WKCAContext additions.
weinig@apple.com [Mon, 5 Mar 2012 21:00:02 +0000 (21:00 +0000)]
Update WebKitSystemInterface for WKCAContext additions.

* WebKitSystemInterface.h:
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceLion.a:
* libWebKitSystemInterfaceSnowLeopard.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r109656.
commit-queue@webkit.org [Mon, 5 Mar 2012 20:44:00 +0000 (20:44 +0000)]
Unreviewed, rolling out r109656.
http://trac.webkit.org/changeset/109656
https://bugs.webkit.org/show_bug.cgi?id=80316

This seems to have regressed Parser/html5-full-render by about
10% (Requested by anttik on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-05

Source/WebCore:

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::getPositionOffsetValue):
(WebCore::getBorderRadiusCornerValues):
(WebCore::getBorderRadiusCornerValue):
(WebCore::getBorderRadiusShorthandValue):
(WebCore::lineHeightFromStyle):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSGrammar.y:
* css/CSSParser.cpp:
(WebCore::CSSParser::validUnit):
(WebCore::CSSParser::createPrimitiveNumericValue):
(WebCore::unitFromString):
(WebCore::CSSParser::parseValidPrimitive):
(WebCore::CSSParser::detectNumberToken):
* css/CSSPrimitiveValue.cpp:
(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::unitCategory):
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::canonicalUnitTypeForCategory):
(WebCore::CSSPrimitiveValue::customCssText):
* css/CSSPrimitiveValue.h:
(CSSPrimitiveValue):
* css/CSSPrimitiveValue.idl:
* css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
* dom/Document.cpp:
(WebCore::Document::pageSizeAndMarginsInPixels):
(WebCore):
* dom/Document.h:
(Document):
* html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::getRegion):
* platform/Length.h:
(WebCore::Length::calcValue):
(WebCore::Length::calcMinValue):
(WebCore::Length::calcFloatValue):
(WebCore::Length::blend):
* rendering/RenderBR.cpp:
(WebCore::RenderBR::lineHeight):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::lineHeight):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::reflectionOffset):
(WebCore::RenderBox::paintBoxDecorations):
(WebCore::RenderBox::clipRect):
(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):
(WebCore::RenderBox::computeInlineDirectionMargins):
(WebCore::RenderBox::computeLogicalHeightUsing):
(WebCore::RenderBox::computePercentageLogicalHeight):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
(WebCore::RenderBox::computeBlockDirectionMargins):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::relativePositionOffsetX):
(WebCore::RenderBoxModelObject::relativePositionOffsetY):
(WebCore::RenderBoxModelObject::paddingTop):
(WebCore::RenderBoxModelObject::paddingBottom):
(WebCore::RenderBoxModelObject::paddingLeft):
(WebCore::RenderBoxModelObject::paddingRight):
(WebCore::RenderBoxModelObject::paddingBefore):
(WebCore::RenderBoxModelObject::paddingAfter):
(WebCore::RenderBoxModelObject::paddingStart):
(WebCore::RenderBoxModelObject::paddingEnd):
(WebCore::RenderBoxModelObject::getBackgroundRoundedRect):
(WebCore::RenderBoxModelObject::calculateFillTileSize):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
(WebCore::computeBorderImageSide):
(WebCore::RenderBoxModelObject::paintNinePieceImage):
(WebCore::RenderBoxModelObject::paintBorder):
(WebCore::RenderBoxModelObject::paintBoxShadow):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild):
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithm):
* rendering/RenderInline.cpp:
(WebCore::computeMargin):
(WebCore::RenderInline::lineHeight):
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::updateOptionsWidth):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintAfterLayoutIfNeeded):
* rendering/RenderObject.h:
(RenderObject):
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::paint):
* rendering/RenderScrollbarPart.cpp:
(WebCore::calcScrollbarThicknessUsing):
(WebCore::RenderScrollbarPart::computeScrollbarWidth):
(WebCore::RenderScrollbarPart::computeScrollbarHeight):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::computeLogicalWidth):
(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth):
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::logicalHeightForRowSizing):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight):
* rendering/RenderText.h:
(WebCore::RenderText::marginLeft):
(WebCore::RenderText::marginRight):
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMenuListButtonGradients):
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::paint):
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::verticalPositionForBox):
* rendering/style/RenderStyle.cpp:
(WebCore::calcRadiiFor):
(WebCore::RenderStyle::getRoundedBorderFor):
* rendering/style/RenderStyle.h:
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::resolveLengthAttributeForSVG):
(WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight):

LayoutTests:

* css3/viewport-relative-lengths/css3-viewport-relative-lengths-getStyle-expected.txt: Removed.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-getStyle.html: Removed.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-absolute-expected.html: Removed.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-absolute.html: Removed.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-expected.html: Removed.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh.html: Removed.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-absolute-expected.html: Removed.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-absolute.html: Removed.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-expected.html: Removed.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin.html: Removed.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-absolute-expected.html: Removed.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-absolute.html: Removed.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-expected.html: Removed.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw.html: Removed.
* fast/dom/Window/window-properties-expected.txt:
* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/mac/fast/dom/Window/window-properties-expected.txt:
* platform/qt/fast/dom/Window/window-properties-expected.txt:
* platform/win/fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Build fix for !ENABLE(JIT) after r109705.
paroga@webkit.org [Mon, 5 Mar 2012 20:35:55 +0000 (20:35 +0000)]
Unreviewed. Build fix for !ENABLE(JIT) after r109705.

* bytecode/ExecutionCounter.cpp:
* bytecode/ExecutionCounter.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] UTF chars printed back from cookie through php shows as ???
rwlbuis@webkit.org [Mon, 5 Mar 2012 20:28:18 +0000 (20:28 +0000)]
[BlackBerry] UTF chars printed back from cookie through php shows as ???
https://bugs.webkit.org/show_bug.cgi?id=80307

Reviewed by Antonio Gomes.

PR: 130055

we need to check the cookies encoding first and encode the cookie header data
to pass to the request.

* platform/network/blackberry/NetworkManager.cpp:
(WebCore::NetworkManager::startJob):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse a proper closing tag for shadow element layout test
adamk@chromium.org [Mon, 5 Mar 2012 20:15:29 +0000 (20:15 +0000)]
Use a proper closing tag for shadow element layout test
https://bugs.webkit.org/show_bug.cgi?id=80305

Reviewed by Adam Barth.

* fast/dom/shadow/shadow-element.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Remove old cleanupResources() code
commit-queue@webkit.org [Mon, 5 Mar 2012 20:05:43 +0000 (20:05 +0000)]
[chromium] Remove old cleanupResources() code
https://bugs.webkit.org/show_bug.cgi?id=80290

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-05
Reviewed by Adrienne Walker.

cleanupResources() is only called by destructors, and adds no
value, any more, beyond the destructors themselves, but complicates
the code path.

Covered by existing tests.

* platform/graphics/chromium/cc/CCLayerImpl.cpp:
* platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
* platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:
(WebCore::CCPluginLayerImpl::~CCPluginLayerImpl):
* platform/graphics/chromium/cc/CCPluginLayerImpl.h:
* platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::~CCRenderSurface):
* platform/graphics/chromium/cc/CCRenderSurface.h:
(CCRenderSurface):
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::~CCVideoLayerImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPartially loaded JPEGs should have alpha channel
commit-queue@webkit.org [Mon, 5 Mar 2012 19:54:58 +0000 (19:54 +0000)]
Partially loaded JPEGs should have alpha channel
https://bugs.webkit.org/show_bug.cgi?id=78239

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-03-05
Reviewed by Kenneth Russell.

Source/WebCore:

While a JPEG image is loading, the area outside the decoded region
should be fully transparent. Since currently all JPEG frames are marked
as opaque, a renderer respecting this flag will draw the partially
loaded image with garbage outside the valid image region.

Hence, a partially loaded JPEG image should be marked as having an alpha
channel while decoding is in progress. For performance reasons we mark
the image opaque after decoding has finished.

Graphics corruption caused by this bug was recently observed on
Chromium (http://code.google.com/p/chromium/issues/detail?id=113171). A
recent Skia change (r3036) changed SkBitmap::extractSubset() to produce
a bitmap with the same opaqueness flag as the parent. This meant that
the renderer was now seeing an opaque image from the JPEG decoder, and
drawing it appropriately resulted in garbage outside the decoded region.

Test: http/tests/incremental/partial-jpeg.html

* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::JPEGImageDecoder::outputScanlines):
(WebCore::JPEGImageDecoder::jpegComplete):

LayoutTests:

While a JPEG image is being loaded, the parts which have not been
decoded yet should show whatever is behind the image. This tests
verifies this by displaying a JPEG which never fully completes
loading. This is achieved by serving the JPEG from a PHP script that
strips the end of image marker (ff d9) from the data.

The test image is 32x32 pixels, so compresses to 4x4 JPEG MCU blocks.
The expected result is that the final row of MCU blocks (32x4 pixels)
never finishes loading due to the missing end of image marker and the
indicator div is shown through this area.

* http/tests/incremental/partial-jpeg-expected.png: Added.
* http/tests/incremental/partial-jpeg-expected.txt: Added.
* http/tests/incremental/partial-jpeg.html: Added.
* http/tests/incremental/resources/checkerboard.jpg: Added.
* http/tests/incremental/resources/partial-jpeg.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Pass WebNavigationPolicy to WebViewClient::createView
commit-queue@webkit.org [Mon, 5 Mar 2012 19:50:05 +0000 (19:50 +0000)]
[chromium] Pass WebNavigationPolicy to WebViewClient::createView
https://bugs.webkit.org/show_bug.cgi?id=80057

Patch by Charlie Reis <creis@chromium.org> on 2012-03-05
Reviewed by Darin Fisher.

Source/WebKit/chromium:

* public/WebViewClient.h:
(WebViewClient):
(WebKit::WebViewClient::createView):
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::ChromeClientImpl):
(WebKit::ChromeClientImpl::createWindow):
(WebKit::ChromeClientImpl::getNavigationPolicy):
(WebKit):
(WebKit::ChromeClientImpl::show):
(WebKit::ChromeClientImpl::setNewWindowNavigationPolicy):
* src/ChromeClientImpl.h:
(ChromeClientImpl):
* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::dispatchCreatePage):
(WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNewWindowAction):

Tools:

* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::createView):
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Initialize CCOverdrawCounts struct to zero
commit-queue@webkit.org [Mon, 5 Mar 2012 19:47:25 +0000 (19:47 +0000)]
[chromium] Initialize CCOverdrawCounts struct to zero
https://bugs.webkit.org/show_bug.cgi?id=80204

Patch by James Robinson <jamesr@chromium.org> on 2012-03-05
Reviewed by Adrienne Walker.

Source/WebCore:

CCOverdrawCounts is stack allocated but not explicitly initialized, so the values are garbage. This adds a c'tor
to zero out the fields, which is the desired behavior.  Bug was initially caught by valgrind, see
http://crbug.com/116475

* platform/graphics/chromium/cc/CCRenderPass.h:
(WebCore::CCOverdrawCounts::CCOverdrawCounts):

Source/WebKit/chromium:

Update test to use c'tor instead of {} struct initialization.

* tests/CCQuadCullerTest.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd media control css for chromium on android
commit-queue@webkit.org [Mon, 5 Mar 2012 19:38:04 +0000 (19:38 +0000)]
Add media control css for chromium on android
https://bugs.webkit.org/show_bug.cgi?id=79550

Patch by Min Qin <qinmin@google.com> on 2012-03-05
Reviewed by Adam Barth.

This should not change the any test results as it does not affect the any current bots. New test expectations will be added if we have a android bot on webkit.

* WebCore.gyp/WebCore.gyp:
* css/mediaControlsChromiumAndroid.css: Added.
(body:-webkit-full-page-media):
(audio):
(audio:-webkit-full-page-media, video:-webkit-full-page-media):
(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
(video:-webkit-full-page-media::-webkit-media-controls-panel):
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
(audio::-webkit-media-controls-timeline-container):
(video::-webkit-media-controls-timeline-container):
(audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
(audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
(video::-webkit-media-controls-fullscreen-button):
(audio::-webkit-media-controls-fullscreen-button):
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
(audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):
* rendering/RenderMediaControlsChromium.cpp:
(WebCore::paintMediaFullscreenButton):
(WebCore):
(WebCore::RenderMediaControlsChromium::paintMediaControlsPart):
* rendering/RenderThemeChromiumAndroid.cpp:
(WebCore::RenderThemeChromiumAndroid::extraMediaControlsStyleSheet):
(WebCore):
(WebCore::RenderThemeChromiumAndroid::paintMediaFullscreenButton):
* rendering/RenderThemeChromiumAndroid.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix crash in ScrollingCoordinator::updateMainFrameScrollPositionAndScrollLayerPosition
andersca@apple.com [Mon, 5 Mar 2012 19:26:02 +0000 (19:26 +0000)]
Fix crash in ScrollingCoordinator::updateMainFrameScrollPositionAndScrollLayerPosition
https://bugs.webkit.org/show_bug.cgi?id=80303
<rdar://problem/10953682>

Reviewed by Beth Dakin.

Add the same null checks that already exist in updateMainFrameScrollPosition.

* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::updateMainFrameScrollPositionAndScrollLayerPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed test expectations update: widen slowness of jquery/offset.html.
adamk@chromium.org [Mon, 5 Mar 2012 19:00:26 +0000 (19:00 +0000)]
Unreviewed test expectations update: widen slowness of jquery/offset.html.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: CSS inactive property check should account for vendor prefixes
apavlov@chromium.org [Mon, 5 Mar 2012 18:57:48 +0000 (18:57 +0000)]
Web Inspector: CSS inactive property check should account for vendor prefixes
https://bugs.webkit.org/show_bug.cgi?id=80225

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/styles/vendor-prefixes.html

* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::populateObjectWithStyleProperties):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.alteredHexNumber):
(WebInspector.StylesSidebarPane.canonicalPropertyName):
(WebInspector.StylesSidebarPane.prototype._markUsedProperties):
(WebInspector.StylePropertiesSection.prototype.isPropertyOverloaded):

LayoutTests:

* inspector/styles/vendor-prefixes-expected.txt: Added.
* inspector/styles/vendor-prefixes.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] [WebSocket] use OVERRIDE in WebSocketImpl.h
toyoshim@chromium.org [Mon, 5 Mar 2012 18:57:38 +0000 (18:57 +0000)]
[Chromium] [WebSocket] use OVERRIDE in WebSocketImpl.h
https://bugs.webkit.org/show_bug.cgi?id=80192

Reviewed by Kent Tamura.

* src/WebSocketImpl.h: use OVERRIDE macro.
(WebSocketImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoVersioning.
lforschler@apple.com [Mon, 5 Mar 2012 18:57:18 +0000 (18:57 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoLexer: Specialize character predicates for LChar, UChar
wingo@igalia.com [Mon, 5 Mar 2012 18:56:29 +0000 (18:56 +0000)]
Lexer: Specialize character predicates for LChar, UChar
https://bugs.webkit.org/show_bug.cgi?id=79677

Reviewed by Oliver Hunt.

This patch specializes isIdentStart, isIdentPart, isWhiteSpace,
and isLineTerminator to perform a more limited number of checks if
the lexer is being instantiated to work on LChar sequences.  This
is about a 1.5% win on the --parse-only suite, here.

* parser/Lexer.cpp:
(JSC::isLatin1): New static helper, specialized for LChar and
UChar.
(JSC::typesOfLatin1Characters): Rename from
typesOfASCIICharacters, and expand to the range of the LChar
type.  All uses of isASCII are changed to use isLatin1.  Generated
using libunistring.
(JSC::isNonLatin1IdentStart):
(JSC::isIdentStart):
(JSC::isNonLatin1IdentPart):
(JSC::isIdentPart):
(JSC::Lexer::shiftLineTerminator):
(JSC::Lexer::parseIdentifier):
(JSC::Lexer::parseIdentifierSlowCase):
(JSC::Lexer::parseStringSlowCase):
(JSC::Lexer::parseMultilineComment):
(JSC::Lexer::lex):
(JSC::Lexer::scanRegExp):
(JSC::Lexer::skipRegExp): Sprinkle static_cast<T>(_) around.
* parser/Lexer.h:
(JSC::Lexer::isWhiteSpace):
(JSC::Lexer::isLineTerminator):
* KeywordLookupGenerator.py:
(Trie.printAsC): Declare specialized isIdentPart static functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemoved the svn:executable properties from a couple of expected test results
mitz@apple.com [Mon, 5 Mar 2012 18:50:11 +0000 (18:50 +0000)]
Removed the svn:executable properties from a couple of expected test results

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agofast/text/international/spaces-combined-in-vertical-text.html has incorrect expected...
mitz@apple.com [Mon, 5 Mar 2012 18:36:18 +0000 (18:36 +0000)]
fast/text/international/spaces-combined-in-vertical-text.html has incorrect expected results
https://bugs.webkit.org/show_bug.cgi?id=80284

Reviewed by Alexey Proskuryakov.

The test was added in r104322 with results from the Chromium port, which are incorrect. This
is the subject of <https://bugs.webkit.org/show_bug.cgi?id=80293>.

* fast/text/international/spaces-combined-in-vertical-text-expected.txt:
* platform/chromium/fast/text/international/spaces-combined-in-vertical-text-expected.txt: Copied from LayoutTests/fast/text/international/spaces-combined-in-vertical-text-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd support for notification replaceId in Mac WebKit and WK2
jonlee@apple.com [Mon, 5 Mar 2012 18:34:14 +0000 (18:34 +0000)]
Add support for notification replaceId in Mac WebKit and WK2
https://bugs.webkit.org/show_bug.cgi?id=80206
<rdar://problem/10965574>

Reviewed by Sam Weinig.

Source/WebKit/mac:

* WebView/WebNotification.h: Add replaceID method.
* WebView/WebNotification.mm:
(-[WebNotification replaceID]):

Source/WebKit2:

* UIProcess/API/C/WKNotification.cpp: Add WK API.
(WKNotificationCopyReplaceID):
* UIProcess/API/C/WKNotification.h:
* UIProcess/Notifications/WebNotification.cpp:
(WebKit::WebNotification::WebNotification):
* UIProcess/Notifications/WebNotification.h: Add replaceID member.
(WebKit::WebNotification::create):
(WebKit::WebNotification::replaceID):
(WebNotification):
* UIProcess/Notifications/WebNotificationManagerProxy.cpp:
(WebKit::WebNotificationManagerProxy::show):
* UIProcess/Notifications/WebNotificationManagerProxy.h:
(WebNotificationManagerProxy):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showNotification):
* UIProcess/WebPageProxy.h:
(WebPageProxy):
* UIProcess/WebPageProxy.messages.in: Add replaceID to the showNotification message.
* WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::show):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agofast/regions/select-in-region-crash.html has incorrect expected results
mitz@apple.com [Mon, 5 Mar 2012 18:22:19 +0000 (18:22 +0000)]
fast/regions/select-in-region-crash.html has incorrect expected results
https://bugs.webkit.org/show_bug.cgi?id=80289

Reviewed by Alexey Proskuryakov.

* fast/regions/select-in-region-crash-expected.txt: Updated.
* platform/chromium/fast/regions/select-in-region-crash-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoGeolocation should use a ScriptExecutionContext as its context object
abarth@webkit.org [Mon, 5 Mar 2012 18:17:58 +0000 (18:17 +0000)]
Geolocation should use a ScriptExecutionContext as its context object
https://bugs.webkit.org/show_bug.cgi?id=80248

Reviewed by Kentaro Hara.

Source/WebCore:

This patch updates Geolocation to use some more modern WebCore
mechanisms.  Previously, Geolocation used a Frame as a context object,
which required a bunch of manual integration with the PageCache as well
as custom signaling for Geolocation::reset().  After this patch,
Geolocation subclasses ActiveDOMObject, which does all this work
automatically.

* Modules/geolocation/Geolocation.cpp:
(WebCore::Geolocation::create):
(WebCore):
(WebCore::Geolocation::Geolocation):
(WebCore::Geolocation::~Geolocation):
(WebCore::Geolocation::document):
(WebCore::Geolocation::frame):
(WebCore::Geolocation::page):
(WebCore::Geolocation::stop):
(WebCore::Geolocation::getCurrentPosition):
(WebCore::Geolocation::watchPosition):
(WebCore::Geolocation::requestPermission):
(WebCore::Geolocation::clearWatch):
(WebCore::Geolocation::setIsAllowed):
* Modules/geolocation/Geolocation.h:
(WebCore):
(Geolocation):
* Modules/geolocation/NavigatorGeolocation.cpp:
(WebCore):
(WebCore::NavigatorGeolocation::geolocation):
* Modules/geolocation/NavigatorGeolocation.h:
(NavigatorGeolocation):
* dom/Document.cpp:
(WebCore::Document::Document):
* dom/Document.h:
(Document):
* history/PageCache.cpp:
(WebCore::logCanCacheFrameDecision):
(WebCore::PageCache::canCachePageContainingThisFrame):

Source/WebKit/chromium:

Rather than indirecting through the Frame to get the SecurityOrigin, we
should get the SecurityOrigin directly from ScriptExecutionContext.

* src/WebGeolocationPermissionRequest.cpp:
(WebKit::WebGeolocationPermissionRequest::securityOrigin):

Source/WebKit/mac:

* WebView/WebFrame.mm:
(-[WebFrame _cacheabilityDictionary]):
    - We no longer special-case Geolocation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[soup] Crash while loading http://www.jusco.cn
mrobinson@webkit.org [Mon, 5 Mar 2012 18:15:32 +0000 (18:15 +0000)]
[soup] Crash while loading http://www.jusco.cn
https://bugs.webkit.org/show_bug.cgi?id=68238

Reviewed by Philippe Normand.

.:

* configure.ac: Bumped the libsoup dependency to 2.37.90.

Source/WebCore:

Test: http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers.html

When running synchronous XMLHttpRequests, push a new inner thread default
context, so that other sources from timers and network activity do not run.
This will make synchronous requests truly synchronous with the rest of
WebCore.

* platform/network/soup/ResourceHandleSoup.cpp:
(WebCoreSynchronousLoader): Clean up the method definitions a bit by writing them inline.
(WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader): Push a new thread default
context to prevent other sources from running.
(WebCore::WebCoreSynchronousLoader::~WebCoreSynchronousLoader): Pop the inner thread default context.
(WebCore::closeCallback): If the client is synchronous call didFinishLoading now.
(WebCore::readCallback): Only call didFinishLoading if the client isn't synchronous.
(WebCore::ResourceHandle::defaultSession): Activate use-thread-context so that the soup session
respects the inner thread context.
(ResourceHandleClient):
(WebCore::ResourceHandleClient::isSynchronousClient): Added this virtual method.

Tools:

* gtk/jhbuild.modules: Bumped the libsoup and glib dependencies
in the jhbuild file.

LayoutTests:

* http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers-expected.txt: Added.
* http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r109748.
commit-queue@webkit.org [Mon, 5 Mar 2012 17:15:48 +0000 (17:15 +0000)]
Unreviewed, rolling out r109748.
http://trac.webkit.org/changeset/109748
https://bugs.webkit.org/show_bug.cgi?id=80296

Made some tests crash, will fix and recommit (Requested by
noamr on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-05

Source/WebKit2:

* Target.pri:
* UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPagePrivate::paintToCurrentGLContext):
(PageProxyNode::PageProxyNode):
(PageProxyNode):
(PageProxyNode::changedStates):
(PageProxyNode::render):
(PageProxyNode::~PageProxyNode):
(QQuickWebPage::updatePaintNode):
(QQuickWebPagePrivate::updateSize):
(QQuickWebPagePrivate::resetPaintNode):
(QQuickWebPagePrivate::~QQuickWebPagePrivate):
* UIProcess/API/qt/qquickwebpage_p_p.h:
(QQuickWebPagePrivate):
* UIProcess/DrawingAreaProxy.h:
(WebKit):
(WebKit::DrawingAreaProxy::layerTreeHostProxy):
(DrawingAreaProxy):
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl):
(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
* UIProcess/LayerTreeHostProxy.h:
(LayerTreeHostProxy):
* UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit::LayerTreeHostProxy::syncAnimations):
(WebKit::LayerTreeHostProxy::updateViewport):
(WebKit::LayerTreeHostProxy::syncLayerParameters):
(WebKit::LayerTreeHostProxy::flushLayerChanges):
(WebKit::LayerTreeHostProxy::ensureRootLayer):
(WebKit::LayerTreeHostProxy::syncRemoteContent):
(WebKit::LayerTreeHostProxy::dispatchUpdate):
(WebKit):
(WebKit::LayerTreeHostProxy::createDirectlyCompositedImage):
(WebKit::LayerTreeHostProxy::purgeGLResources):
* UIProcess/qt/QtWebPageSGNode.cpp: Removed.
* UIProcess/qt/QtWebPageSGNode.h: Removed.

Tools:

* MiniBrowser/qt/main.cpp:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] zlib link error with --enable-webkit2
joone.hur@collabora.co.uk [Mon, 5 Mar 2012 16:55:37 +0000 (16:55 +0000)]
[GTK] zlib link error with --enable-webkit2
https://bugs.webkit.org/show_bug.cgi?id=79877

Reviewed by Martin Robinson.

zlib should be linked properly.

* GNUmakefile.am: Link $(ZLIB_LIBS) with libwebkit2gtk instead of
linking it with WebKitWebProcess.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] plugins/netscape-plugin-page-cache-works.html fails
commit-queue@webkit.org [Mon, 5 Mar 2012 16:54:58 +0000 (16:54 +0000)]
[GTK] plugins/netscape-plugin-page-cache-works.html fails
https://bugs.webkit.org/show_bug.cgi?id=74409

Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-03-05
Reviewed by Martin Robinson.

Source/WebKit/gtk:

Add a method to override page-cache-for-plugins preference.

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::setPageCacheSupportsPlugins):
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):

Tools:

Add support for overriding the page-cache-for-plugins preference
through DumpRenderTreeSupport.

* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(booleanFromValue): A helper function to convert a string to boolean.
(LayoutTestController::overridePreference):

LayoutTests:

Unskip one new passing test and reclassify one failure.

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Mon, 5 Mar 2012 16:38:57 +0000 (16:38 +0000)]
[Qt] Unreviewed gardening.

* platform/qt/Skipped: Skip a new flakey test, unskip a passing test.
* platform/qt/svg/custom/bug78807-expected.txt: Added. (https://bugs.webkit.org/show_bug.cgi?id=80156)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake accelerated compositing work again with direct rendering.
jpetsovits@rim.com [Mon, 5 Mar 2012 16:37:29 +0000 (16:37 +0000)]
Make accelerated compositing work again with direct rendering.
https://bugs.webkit.org/show_bug.cgi?id=80181
RIM PR: 139110

Reviewed by Antonio Gomes.
Internally reviewed by Arvid Nilsson.

The significant amount of refactoring and optimization work
that has gone into accelerated compositing missed out on
some of the code paths that are being used in direct rendering.

Animations were relying on blitVisibleContents() only (which
is a no-op in direct rendering mode). There were early returns
which are suitable to determine whether screen contents need
to be updated at all; however, when we're already forcing a
re-render then those checks would cause the composition surface
not to appear at all, or avoid drawing new animation frames.

We went through dispatchMessage(), potentially causing
mismatches between rendered (but not yet posted) back content
and layers composited on top of it. As we're rendering onto
the sole target surface (the window) directly and posting
from the same thread, we have to wait for compositing on the
UI thread to finish before posting the window.

In turn, this patch combines both drawSubLayers() and
blendCompositingSurface() calls into one method, reducing
the number of messages to the UI thread within
renderDirectToWindow() to one.

blendCompositingMessage() in renderDirectToScreen() was called
with contents coordinates rather than viewport coordinates.
That caused some of the composited content to be cut off when
the scroll position wasn't (0, 0).

We called copyPreviousContentsToBackSurfaceOfWindow() twice for
one frame, in both renderDirectToWindow() and invalidateWindow().
Only one of those (the latter one) is necessary.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::renderDirectToWindow):
(BlackBerry::WebKit::BackingStorePrivate::drawSubLayers):
(WebKit):
(BlackBerry::WebKit::BackingStorePrivate::drawAndBlendLayersForDirectRendering):
* Api/BackingStore.h:
(WebKit):
* Api/BackingStore_p.h:
(BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::isDirectRenderingAnimationMessageScheduled):
(BlackBerry::WebKit::BackingStorePrivate::setDirectRenderingAnimationMessageScheduled):
* Api/WebPage_p.h:
(BlackBerry::WebKit::WebPagePrivate::isAcceleratedCompositingActive):
(WebPagePrivate):
* WebKitSupport/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositor::WebPageCompositor):
(BlackBerry::WebKit::WebPageCompositor::~WebPageCompositor):
(BlackBerry::WebKit::WebPageCompositor::drawLayers):
(BlackBerry::WebKit::WebPageCompositor::animationTimerFired):
* WebKitSupport/WebPageCompositor.h:
(WebPageCompositor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2] WKPageGetContextMenuFromProposedContextMenuCallback should pass a HitTestResult
carlosgc@webkit.org [Mon, 5 Mar 2012 16:34:29 +0000 (16:34 +0000)]
[WK2] WKPageGetContextMenuFromProposedContextMenuCallback should pass a HitTestResult
https://bugs.webkit.org/show_bug.cgi?id=77208

Reviewed by Anders Carlsson.

A HitTestResultData is now passed to ShowContextMenu WebPageProxy
message instead of the ContextMenuState. ContextMenu client has
been updated to pass the HitTestResult to the
getContextMenuFromProposedMenu callback.

* GNUmakefile.am: Remove ContextMenuState.h.
* Shared/APIClientTraits.h:
* Shared/ContextMenuState.h: Removed.
* Shared/WebHitTestResult.h:
(WebKit::WebHitTestResult::Data::Data): Add constructor that takes
a WebCore::HitTestResult.
* UIProcess/API/C/WKPage.h: Add HitTestResult parameter to
getContextMenuFromProposedMenu callback and deprecate the old
version.
* UIProcess/WebPageContextMenuClient.cpp:
(WebKit::WebPageContextMenuClient::getContextMenuFromProposedMenu):
Pass a HitTestResult to getContextMenuFromProposedMenu or use the
deprecated one if client version is an old one.
* UIProcess/WebPageContextMenuClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showContextMenu):
(WebKit::WebPageProxy::internalShowContextMenu): Save the
WebHitTestResult::Data to use it for handling context menu actions.
(WebKit::WebPageProxy::contextMenuItemSelected): Use the saved
WebHitTestResult::Data.
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* WebKit2.xcodeproj/project.pbxproj: Remove ContextMenuState.h.
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::mouseDidMoveOverElement): Use the new
WebHitTestResult::Data constructor that takes a WebCore::HitTestResult.
* WebProcess/WebPage/WebContextMenu.cpp:
(WebKit::WebContextMenu::show): Create a WebHitTestResult::Data
instead of a ContextMenuState and pass it to ShowContextMenu message.
* win/WebKit2.vcproj: ContextMenuState.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Update Tools/DumpRenderTree
rwlbuis@webkit.org [Mon, 5 Mar 2012 16:26:55 +0000 (16:26 +0000)]
[BlackBerry] Update Tools/DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=80287

Reviewed by Antonio Gomes.

Update so we are sure we can build our implementation of DRT.

* DumpRenderTree/DumpRenderTree.h: include DumpRenderTreeBlackBerry.h.
* DumpRenderTree/PixelDumpSupport.cpp: include PixelDumpSupportBlackBerry.h.
* DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp:
(AccessibilityController::addNotificationListener): add missing hook.
(AccessibilityController::removeNotificationListener): add missing hook.
* DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
(AccessibilityUIElement::isSelectedOptionActive): add missing hook.
* DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
(LayoutTestController::setMockSpeechInputDumpRect): add missing hook.
(LayoutTestController::simulateDesktopNotificationClick): add missing hook.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] [WK2] Support threaded renderer in WK2
noam.rosenthal@nokia.com [Mon, 5 Mar 2012 15:52:16 +0000 (15:52 +0000)]
[Qt] [WK2] Support threaded renderer in WK2
https://bugs.webkit.org/show_bug.cgi?id=76661

Source/WebKit2:

Made the appropriate fixes in the UI process code to make rendering thread-safe.
- Separated the scenegraph node code to QtWebPageSGNode. QtWebPageSGNode has direct access
  to LayerTreeHostProxy.

- Each function in LayerTreeHostProxy can be either called from the main thread (handling
  messages from the web process), or from the renderer thread (handling the GL context).
  The render-queue is locked with a mutex, and messages back to the web process are sent
  via callOnMainThread.

- LayerTreeHostProxy is now ThreadSafeRefCounted. That is done to make sure that the GL
  resources it creates are only freed when the QtWebPageSGNode is deleted, which can be
  before or after the owning DrawingAreaProxy is deleted. This ensures that the class is
  deleted only after its GL resources are freed, otherwise those resources may leak.

Based on a patch by Viatcheslav Ostapenko.

Reviewed by Kenneth Rohde Christiansen.

* Target.pri: Added new files.
* UIProcess/API/qt/qquickwebpage.cpp: Moved QtWebPageSGNode out.
(QQuickWebPage::updatePaintNode): Call QtWebPageSGNode
(QQuickWebPagePrivate::updateSize): Call QtWebPageSGNode
(QQuickWebPagePrivate::didDeleteSGWebPageNode): Override QtWebPageSGNode::Client
(QQuickWebPagePrivate::~QQuickWebPagePrivate):
* UIProcess/API/qt/qquickwebpage_p_p.h:
(QQuickWebPagePrivate):
* UIProcess/DrawingAreaProxy.h:
(WebKit):
(WebKit::DrawingAreaProxy::layerTreeHostProxy): Made LayerTreeHostProxy ref-counted.
(DrawingAreaProxy):
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl):
(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
* UIProcess/LayerTreeHostProxy.h:
(WebKit):
(WebKit::LayerTreeHostProxy::create):
(LayerTreeHostProxy):
* UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit::LayerTreeHostProxy::paintToCurrentGLContext):
(WebKit):
(MainThreadGuardedInvoker):
    A class that allows invoking functions in the main thread, while guarding a ref-
    counted object.

(WebKit::MainThreadGuardedInvoker::call):
(WebKit::MainThreadGuardedInvoker::MainThreadGuardedInvoker):
(WebKit::MainThreadGuardedInvoker::invoke):
(WebKit::LayerTreeHostProxy::syncAnimations):
(WebKit::LayerTreeHostProxy::updateViewport):
(WebKit::LayerTreeHostProxy::detachDrawingArea):
(WebKit::LayerTreeHostProxy::syncLayerParameters):
(WebKit::LayerTreeHostProxy::setShouldRenderNextFrame):
(WebKit::LayerTreeHostProxy::flushLayerChanges):
(WebKit::LayerTreeHostProxy::ensureRootLayer):
(WebKit::LayerTreeHostProxy::syncRemoteContent):
(WebKit::LayerTreeHostProxy::dispatchUpdate):
(WebKit::LayerTreeHostProxy::createDirectlyCompositedImage):
(WebKit::LayerTreeHostProxy::purgeGLResources):
* UIProcess/qt/QtWebPageSGNode.cpp: Added.
* UIProcess/qt/QtWebPageSGNode.h: Added.

Tools:

Remove the QML_NO_THREADED_RENDERER environment variable from MiniBrowser.

Reviewed by Kenneth Rohde Christiansen.

* MiniBrowser/qt/main.cpp:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] DOMSupport visibleSelectionForRangeInputElement incorrectly dereferences...
commit-queue@webkit.org [Mon, 5 Mar 2012 15:37:19 +0000 (15:37 +0000)]
[BlackBerry] DOMSupport visibleSelectionForRangeInputElement incorrectly dereferences a null range.
https://bugs.webkit.org/show_bug.cgi?id=80274

Patch by George Staikos <gstaikos@rim.com> on 2012-03-05
Reviewed by Antonio Gomes.

A null range can be returned so we should not blindly deref it.
Reviewed Internally by Mike Fenton.

* WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::visibleSelectionForRangeInputElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove pointer to timer and use the timers directly in the tiled backing store https...
ahf@0x90.dk [Mon, 5 Mar 2012 15:36:19 +0000 (15:36 +0000)]
Remove pointer to timer and use the timers directly in the tiled backing store https://bugs.webkit.org/show_bug.cgi?id=80283

Patch by Kenneth Rohde Christiansen and Alexander Færøy.

Reviewed by Simon Hausmann.

* platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::TiledBackingStore):
(WebCore::TiledBackingStore::~TiledBackingStore):
(WebCore::TiledBackingStore::createTiles):
(WebCore::TiledBackingStore::startTileBufferUpdateTimer):
(WebCore::TiledBackingStore::startTileCreationTimer):
* platform/graphics/TiledBackingStore.h:
(TiledBackingStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [Styles] Tabbing an empty new property in the middle of style moves...
apavlov@chromium.org [Mon, 5 Mar 2012 15:35:13 +0000 (15:35 +0000)]
Web Inspector: [Styles] Tabbing an empty new property in the middle of style moves the editor to the next section
https://bugs.webkit.org/show_bug.cgi?id=80264

Reviewed by Pavel Feldman.

* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype.element.userInput.previousContent.context.moveDirection.alreadyNew):
(WebInspector.StylePropertyTreeElement.prototype):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Update LocalizedStringsBlackBerry.cpp
rwlbuis@webkit.org [Mon, 5 Mar 2012 15:30:54 +0000 (15:30 +0000)]
[BlackBerry] Update LocalizedStringsBlackBerry.cpp
https://bugs.webkit.org/show_bug.cgi?id=80278

Reviewed by Antonio Gomes.

Update LocalizedStringsBlackBerry.cpp to current HEAD.

* platform/blackberry/LocalizedStringsBlackBerry.cpp:
(WebCore::inputElementAltText): fall back to "Submit".
(WebCore::imageTitle): choose the format "filename(widthxheight)" like Chrome does.
(WebCore::fileButtonNoFilesSelectedLabel): fall back to "No File Chosen" translation like Chrome does.
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [chromium] introduce HeapSnapshot performance test.
loislo@chromium.org [Mon, 5 Mar 2012 15:24:45 +0000 (15:24 +0000)]
Web Inspector: [chromium] introduce HeapSnapshot performance test.
https://bugs.webkit.org/show_bug.cgi?id=80280

Reviewed by Pavel Feldman.

PerformanceTests:

* inspector/detailed-heapshots-smoke-test.html: Added.

Source/WebCore:

* inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotLoaderProxy.prototype.finishLoading.updateStaticData):
(WebInspector.HeapSnapshotLoaderProxy.prototype.finishLoading):
(WebInspector.HeapSnapshotLoaderProxy.prototype._callLoadCallbacks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: cannot be launched when localStorage is disabled
pfeldman@chromium.org [Mon, 5 Mar 2012 15:14:38 +0000 (15:14 +0000)]
Web Inspector: cannot be launched when localStorage is disabled
https://bugs.webkit.org/show_bug.cgi?id=80252

Reviewed by Vsevolod Vlasov.

* inspector/front-end/Settings.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: check for the number of parsed css properties.
pfeldman@chromium.org [Mon, 5 Mar 2012 15:07:50 +0000 (15:07 +0000)]
Web Inspector: check for the number of parsed css properties.
https://bugs.webkit.org/show_bug.cgi?id=80268

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Test: inspector/styles/set-property-boundaries.html

* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::didRemoveDOMNode):
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::setPropertyText):

LayoutTests:

* inspector/styles/set-property-boundaries-expected.txt: Added.
* inspector/styles/set-property-boundaries.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Tabbed pane should redraw tab elements when tab is closed.
vsevik@chromium.org [Mon, 5 Mar 2012 15:00:52 +0000 (15:00 +0000)]
Web Inspector: Tabbed pane should redraw tab elements when tab is closed.
https://bugs.webkit.org/show_bug.cgi?id=80273

Reviewed by Pavel Feldman.

* inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPane.prototype.closeTab):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImprove comments in the tiled backing store https://bugs.webkit.org/show_bug.cgi...
ahf@0x90.dk [Mon, 5 Mar 2012 14:54:54 +0000 (14:54 +0000)]
Improve comments in the tiled backing store https://bugs.webkit.org/show_bug.cgi?id=80279

Patch by Kenneth Rohde Christiansen and Alexander Færøy.

Reviewed by Simon Hausmann.

* platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::createTiles):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTiledBackingStore.{h,cpp} contains unclear variable names https://bugs.webkit.org...
ahf@0x90.dk [Mon, 5 Mar 2012 14:26:00 +0000 (14:26 +0000)]
TiledBackingStore.{h,cpp} contains unclear variable names https://bugs.webkit.org/show_bug.cgi?id=80276

Patch by Kenneth Rohde Christiansen and Alexander Færøy.

Reviewed by Simon Hausmann.

This patch renames some of the variables in TiledBackingStore.cpp to
enhance the clearity and for consistence.

The visibleContentsRect is renamed to visibleRect as it is not in
contents coordinates.

The panningTrajectoryVector and m_visibleRectTrajectoryVector are
renamed to just *[m_]trajectoryVector, as that is descriptive enough.

The previous prefix has also been removed, as it is being used as the
current one in the code. This avoids confusion.

* platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::coverWithTilesIfNeeded):
(WebCore::TiledBackingStore::visibleRect):
(WebCore::TiledBackingStore::visibleAreaIsCovered):
(WebCore::TiledBackingStore::createTiles):
(WebCore::TiledBackingStore::computeCoverAndKeepRect):
(WebCore::TiledBackingStore::removeAllNonVisibleTiles):
* platform/graphics/TiledBackingStore.h:
(TiledBackingStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Fix build with Qt 5 and OpenGL ES 2.0
hausmann@webkit.org [Mon, 5 Mar 2012 14:16:15 +0000 (14:16 +0000)]
[Qt] Fix build with Qt 5 and OpenGL ES 2.0

Reviewed by Noam Rosenthal.

* platform/graphics/texmap/TextureMapper.h: Since we don't do QT += opengl with Qt 5 anymore
here in WebCore, we cannot check for QT_OPENGL_LIB. But since this is Qt5, we know that the
GLES setting comes qconfig.h and we can rely on it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWhitespace clean-up of TiledBackingStore.cpp.
ahf@0x90.dk [Mon, 5 Mar 2012 14:00:22 +0000 (14:00 +0000)]
Whitespace clean-up of TiledBackingStore.cpp.

Rubber-stamped by Kenneth Rohde Christiansen.

Already covered by existing tests.

* platform/graphics/TiledBackingStore.cpp:
(WebCore):
(WebCore::TiledBackingStore::updateTileBuffers):
(WebCore::TiledBackingStore::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Fix make distcheck.
carlosgc@webkit.org [Mon, 5 Mar 2012 13:57:12 +0000 (13:57 +0000)]
Unreviewed. Fix make distcheck.

Source/JavaScriptCore:

* GNUmakefile.list.am: Add missing header file.

Source/WebCore:

* GNUmakefile.list.am: Add missing header file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Add myself to committer list.
ahf@0x90.dk [Mon, 5 Mar 2012 13:29:47 +0000 (13:29 +0000)]
Unreviewed. Add myself to committer list.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Use config test to determine if the compiler supports -MD
vestbo@webkit.org [Mon, 5 Mar 2012 13:00:09 +0000 (13:00 +0000)]
[Qt] Use config test to determine if the compiler supports -MD

We used to assume that unix systems building against Qt5 would have
a compiler that supported -MD. Although this was usually the case,
we failed to take into account broken tools for distributed builds
(e.g. teambuilder or icecream) which would end up producing .d files
in the root of the build dir instead of along-side the object file.

Now that we use a config-test to determine the support, we'll capture
those cases, unless distributed builds are enabled after the initial
build-webkit run.

Reviewed by Csaba Osztrogonác.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Incorrect appropriateSelectorFor() suggestion for when a DOMNode has...
apavlov@chromium.org [Mon, 5 Mar 2012 12:03:53 +0000 (12:03 +0000)]
Web Inspector: Incorrect appropriateSelectorFor() suggestion for when a DOMNode has more than 2 CSS classes
https://bugs.webkit.org/show_bug.cgi?id=80258

Reviewed by Pavel Feldman.

* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype.appropriateSelectorFor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWTF: Micro-optimize cleanup of empty vectors and hash tables
wingo@igalia.com [Mon, 5 Mar 2012 11:55:53 +0000 (11:55 +0000)]
WTF: Micro-optimize cleanup of empty vectors and hash tables
https://bugs.webkit.org/show_bug.cgi?id=79903

Reviewed by Michael Saboff and Geoffrey Garen.

This patch speeds up cleanup of vectors and hash tables whose
backing store was never allocated.  This is the case by default
for most vectors / hash tables that never had any entries added.

The result for me is that calling checkSyntax 1000 times on
concat-jquery-mootools-prototype.js goes from 6.234s to 6.068s, a
2.4% speedup.

* wtf/HashTable.h:
(WTF::HashTable::~HashTable):
(WTF::::clear): Don't deallocate the storage or frob member
variables if there is no backing storage.
* wtf/Vector.h:
(WTF::VectorBufferBase::deallocateBuffer): Likewise.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [Styles] [CRASH] Handle rule addition and inline style editing failure...
apavlov@chromium.org [Mon, 5 Mar 2012 10:44:40 +0000 (10:44 +0000)]
Web Inspector: [Styles] [CRASH] Handle rule addition and inline style editing failure due to Content-Security-Policy in the page
https://bugs.webkit.org/show_bug.cgi?id=80024

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/styles/add-new-rule-inline-style-csp.html

* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):
* inspector/InspectorCSSAgent.h:
(InlineStyleOverrideScope):
(WebCore::InspectorCSSAgent::InlineStyleOverrideScope::InlineStyleOverrideScope):
(WebCore::InspectorCSSAgent::InlineStyleOverrideScope::~InlineStyleOverrideScope):
(InspectorCSSAgent):
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheetForInlineStyle::setStyleText):
* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::ContentSecurityPolicy):
(WebCore::ContentSecurityPolicy::allowInlineStyle):
(WebCore::ContentSecurityPolicy::setOverrideAllowInlineStyle):
(WebCore):
* page/ContentSecurityPolicy.h:
(ContentSecurityPolicy):

LayoutTests:

* inspector/styles/add-new-rule-inline-style-csp-expected.txt: Added.
* inspector/styles/add-new-rule-inline-style-csp.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Forms] The "optgroup" element should not be a form-associated element
commit-queue@webkit.org [Mon, 5 Mar 2012 10:26:53 +0000 (10:26 +0000)]
[Forms] The "optgroup" element should not be a form-associated element
https://bugs.webkit.org/show_bug.cgi?id=80234

Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-05
Reviewed by Kent Tamura.

This patch changes base class of HTMLOptGroup to HTMLElement from
HTMLFormControlElement to avoid the "optgroup" element in form-associate
elements collection.

This patch doesn't affect HTMLOptionElement::disabled's static_cast. However,
it doesn't good at coding style. This patch also fix it.

No new tests. No behavior changes.

* html/HTMLOptGroupElement.cpp:
(WebCore::HTMLOptGroupElement::HTMLOptGroupElement): Remove "form" parameter.
(WebCore::HTMLOptGroupElement::create): Remove "form" parameter.
(WebCore::HTMLOptGroupElement::childrenChanged): Replace base method call.
(WebCore::HTMLOptGroupElement::parseAttribute): Replace base method call.
(WebCore::HTMLOptGroupElement::attach): Replace base method call.
(WebCore::HTMLOptGroupElement::detach): Replace base method call.
* html/HTMLOptGroupElement.h:
(HTMLOptGroupElement): Change base class to HTMLElement.
* html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::disabled): Replace static_cast<HTMLFormControlElement*> to static_cast<HTMLElement*> with checking isHTMLElement.
* html/HTMLTagNames.in: Remove "constructorNeedsFormElement" for not passing "form" parameter in HTMLElementFactory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: fix extensions-resource.html test.
podivilov@chromium.org [Mon, 5 Mar 2012 10:01:11 +0000 (10:01 +0000)]
Web Inspector: fix extensions-resource.html test.
https://bugs.webkit.org/show_bug.cgi?id=80183

Reviewed by Vsevolod Vlasov.

Source/WebCore:

* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.Linkifier.prototype._updateAnchor):

LayoutTests:

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Rebaseline search-field-cancel.html for r109503.
tkent@chromium.org [Mon, 5 Mar 2012 09:49:15 +0000 (09:49 +0000)]
[Chromium] Rebaseline search-field-cancel.html for r109503.
Fix an error of the previous rebaseline.

* platform/chromium-mac-snowleopard/fast/repaint/search-field-cancel-expected.txt: Removed.
* platform/chromium-win/fast/repaint/search-field-cancel-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoQt API test buildstep throws exception after buildmaster update
ossy@webkit.org [Mon, 5 Mar 2012 09:24:50 +0000 (09:24 +0000)]
Qt API test buildstep throws exception after buildmaster update
https://bugs.webkit.org/show_bug.cgi?id=80249

Reviewed by Zoltan Herczeg.

* BuildSlaveSupport/build.webkit.org-config/master.cfg: Disable API tests on the Qt bot temporarily.
(BuildAndTestFactory.__init__):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening, skip a new failing test.
ossy@webkit.org [Mon, 5 Mar 2012 09:05:57 +0000 (09:05 +0000)]
Unreviewed gardening, skip a new failing test.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd instrumentation for frame start/end on timeline.
caseq@chromium.org [Mon, 5 Mar 2012 08:48:29 +0000 (08:48 +0000)]
Add instrumentation for frame start/end on timeline.

Web Inspector: add timeline instrumentation for frame events
https://bugs.webkit.org/show_bug.cgi?id=80127

Reviewed by Pavel Feldman.

Source/WebCore:

- display frame boundaries when vertical overview mode is on
- aggregate by frame in vertical overview mode
- switched event filtering criteria from index to time in vertical overview mode

* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didBeginFrameImpl):
(WebCore):
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didBeginFrame):
(WebCore):
* inspector/InspectorTimelineAgent.cpp:
(TimelineRecordType):
(WebCore::InspectorTimelineAgent::didBeginFrame):
(WebCore):
* inspector/InspectorTimelineAgent.h:
(InspectorTimelineAgent):
* inspector/front-end/TimelineModel.js:
* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype._showMemoryGraph):
(WebInspector.TimelineOverviewPane.prototype.setStartAtZero):
(WebInspector.TimelineOverviewPane.prototype.updateEventDividers):
(WebInspector.TimelineOverviewPane.prototype.sidebarResized):
(WebInspector.TimelineOverviewPane.prototype.reset):
(WebInspector.TimelineOverviewPane.prototype.accept):
(WebInspector.TimelineOverviewPane.prototype.windowStartTime):
(WebInspector.TimelineOverviewPane.prototype.windowEndTime):
(WebInspector.TimelineOverviewPane.prototype._onWindowChanged):
(WebInspector.TimelineStartAtZeroOverview):
(WebInspector.TimelineStartAtZeroOverview.prototype.reset):
(WebInspector.TimelineStartAtZeroOverview.prototype.update):
(WebInspector.TimelineStartAtZeroOverview.prototype._aggregateFrames):
(WebInspector.TimelineStartAtZeroOverview.prototype._aggregateFrameStatistics):
(WebInspector.TimelineStartAtZeroOverview.prototype._aggregateRecords):
(WebInspector.TimelineStartAtZeroOverview.prototype._buildBar):
(WebInspector.TimelineStartAtZeroOverview.prototype.getWindowTimes):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._updateEventDividers):
(WebInspector.TimelinePanel.prototype._createEventDivider):
(WebInspector.TimelinePanel.prototype._toggleStartAtZeroButtonClicked):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline.addTimestampRecords):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype._refresh):
(WebInspector.TimelinePanel.prototype._refreshRecords):
(WebInspector.TimelineCategoryFilter.prototype.accept):
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.prototype.get _recordStyles):
* inspector/front-end/inspectorCommon.css:
* inspector/front-end/timelinePanel.css:
(#timeline-container):
(.timeline .resources-event-divider):
(.timeline.timeline-start-at-zero .resources-divider):
(.timeline .resources-event-divider.timeline-frame-divider):

Source/WebKit/chromium:

- expose an instrumentation method from WebWidget to mark frame update start

* public/WebWidget.h:
(WebWidget):
(WebKit::WebWidget::instrumentBeginFrame):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::instrumentBeginFrame):
(WebKit):
* src/WebViewImpl.h:
(WebViewImpl):

LayoutTests:

* inspector/timeline/timeline-enum-stability-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed build fix for !ENABLE(SHADOW_DOM).
morrita@google.com [Mon, 5 Mar 2012 08:44:56 +0000 (08:44 +0000)]
Unreviewed build fix for !ENABLE(SHADOW_DOM).

* html/shadow/HTMLContentElement.cpp:
(WebCore::contentTagName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Unit tests are noisy when run under jhbuild
mrobinson@webkit.org [Mon, 5 Mar 2012 08:42:06 +0000 (08:42 +0000)]
[GTK] Unit tests are noisy when run under jhbuild
https://bugs.webkit.org/show_bug.cgi?id=80241

Reviewed by Philippe Normand.

Force the 'memory' backend in GSettings so that each unit
test doesn't produce a warning when it's forced to fall back
to the 'memory' backend.

* Scripts/run-gtk-tests:
(TestRunner.run): Force the 'memory' backend.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoInternally used HTMLContentElement subclasses should have correct wrapper.
morrita@google.com [Mon, 5 Mar 2012 08:37:51 +0000 (08:37 +0000)]
Internally used HTMLContentElement subclasses should have correct wrapper.
https://bugs.webkit.org/show_bug.cgi?id=80237

Reviewed by Kent Tamura.

Source/WebCore:

DetailsContentElement and DetailsSummaryElement used to use
<div> as their tag name. But this means they are wrapped by
wrapper objects for HTMLDivElement, which is wrong. This happened
to work though because HTMLDivElement has no extra state or API.

This change introduces "noConstructor" keyword for make_name.pl
sources.  This keyword allows a tag name to specify its own
wrapper without making the tag name visible from the parser, or
HTMLElementFactory in precise.

Following this addition, this change also adds a new tag name
"webkitShadowContent" for DetailsContentElement and DetailsSummaryElement,
which has no constructor, and whose wrapper type is HTMLElement.

This change isn't visible from the page author and only matters for testing.

Test: fast/dom/shadow/content-element-user-agent-shadow.html

* dom/make_names.pl:
(defaultTagPropertyHash):
(buildConstructorMap):
(printConstructors):
(printFunctionInits):
* html/HTMLDetailsElement.cpp:
(WebCore::DetailsContentElement::DetailsContentElement):
(WebCore::DetailsSummaryElement::DetailsSummaryElement):
* html/HTMLTagNames.in:
* html/shadow/HTMLContentElement.cpp:
(WebCore::contentTagName):

LayoutTests:

* fast/dom/shadow/content-element-user-agent-shadow-expected.txt: Added.
* fast/dom/shadow/content-element-user-agent-shadow.html: Added.
* platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.txt:
* platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.txt:
* platform/gtk/fast/html/details-remove-summary-1-and-click-expected.txt:
* platform/gtk/fast/html/details-remove-summary-4-and-click-expected.txt:
* platform/mac/fast/html/details-remove-summary-1-and-click-expected.txt:
* platform/mac/fast/html/details-remove-summary-4-and-click-expected.txt:
* platform/qt/fast/html/details-remove-summary-1-and-click-expected.txt:
* platform/qt/fast/html/details-remove-summary-4-and-click-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] "Console: undefined @0: ReferenceError: Can't find variable: WebInspector"...
mrobinson@webkit.org [Mon, 5 Mar 2012 08:35:15 +0000 (08:35 +0000)]
[GTK] "Console: undefined @0: ReferenceError: Can't find variable: WebInspector" during testwebinspector
https://bugs.webkit.org/show_bug.cgi?id=80235

Reviewed by Philippe Normand.

Source/WebKit/gtk:

Wait to inspect the WebView until the page has finished loading. Also
clean up some minor style errors.

* tests/testwebinspector.c:
(closeInspector): Small style fixes.
(showInspector): Ditto.
(loadFinished): Ditto.
(test_webkit_web_inspector_close_and_inspect): Wait to inspect until the page has loaded.
(test_webkit_web_inspector_destroy_inspected_web_view): Ditto.
(main): Small style fixes.

Tools:

* Scripts/run-gtk-tests:
(TestRunner.run): Use the WEBKIT_INSPECTOR_PATH environment variable so that
inspector resources path determination is shared by all tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] REGRESSION: r108278 broke some tests that expect focus
mrobinson@webkit.org [Mon, 5 Mar 2012 08:28:59 +0000 (08:28 +0000)]
[GTK] REGRESSION: r108278 broke some tests that expect focus
https://bugs.webkit.org/show_bug.cgi?id=79084

Reviewed by Philippe Normand.

Source/WebKit/gtk:

Grab focus before running the test. This ensures that if the
WebView lost focus, it has it before sending events.

* tests/testcopyandpaste.c:
(test_copy_and_paste): Grab focus.

Tools:

Grab focus when dumping test results and also when sending
events. During the course of testing, the WebView may lose
focus and this seems to snap it back when tests demand it.

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(dump): Grab focus.
* DumpRenderTree/gtk/EventSender.cpp:
(dispatchEvent): Ditto.

LayoutTests:

* platform/gtk/Skipped: Unskip passing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRefactoring: Move HTMLContentElement::attach to InsertionPoint::attach.
shinyak@chromium.org [Mon, 5 Mar 2012 08:22:33 +0000 (08:22 +0000)]
Refactoring: Move HTMLContentElement::attach to InsertionPoint::attach.
https://bugs.webkit.org/show_bug.cgi?id=80243

Reviewed by Hajime Morita.

Since the current code in HTMLContentElement::attach() will be used for coming <shadow>
elements, it is natural that InsertionPoint::attach() has such code.

No new tests, no change in behavior.

* html/shadow/HTMLContentElement.cpp:
* html/shadow/HTMLContentElement.h:
(HTMLContentElement):
* html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::attach):
(WebCore):
(WebCore::InsertionPoint::detach):
* html/shadow/InsertionPoint.h:
(InsertionPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Rebaseline search-field-cancel.html for r109503.
tkent@chromium.org [Mon, 5 Mar 2012 08:18:11 +0000 (08:18 +0000)]
[Chromium] Rebaseline search-field-cancel.html for r109503.

* platform/chromium-linux/fast/repaint/search-field-cancel-expected.png:
* platform/chromium-mac-leopard/fast/repaint/search-field-cancel-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/repaint/search-field-cancel-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/repaint/search-field-cancel-expected.txt: Added.
* platform/chromium-win/fast/repaint/search-field-cancel-expected.png:
* platform/chromium-win/fast/repaint/search-field-cancel-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoallowDatabaseAccess and databaseExceededQuota should be part of DatabaseContext not...
abarth@webkit.org [Mon, 5 Mar 2012 08:13:42 +0000 (08:13 +0000)]
allowDatabaseAccess and databaseExceededQuota should be part of DatabaseContext not ScriptExecutionContext
https://bugs.webkit.org/show_bug.cgi?id=80178

Reviewed by Eric Seidel.

These functions are only used by SQLDatabase, which means we can move
them to DatabaseContext, removing one more tendril of the SQLDatabase
code.

* dom/Document.cpp:
(WebCore):
* dom/Document.h:
(Document):
* dom/ScriptExecutionContext.h:
(ScriptExecutionContext):
* storage/DatabaseContext.cpp:
(WebCore::DatabaseContext::DatabaseContext):
(WebCore::DatabaseContext::from):
(WebCore::DatabaseContext::allowDatabaseAccess):
(WebCore):
(WebCore::DatabaseContext::databaseExceededQuota):
* storage/DatabaseContext.h:
(DatabaseContext):
* storage/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::canEstablishDatabase):
* storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::executeSQL):
* storage/SQLTransactionClient.cpp:
(WebCore::SQLTransactionClient::didExceedQuota):
* storage/SQLTransactionSync.cpp:
(WebCore::SQLTransactionSync::executeSQL):
* workers/WorkerContext.cpp:
(WebCore):
* workers/WorkerContext.h:
(WorkerContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, mark two tests as flaky in GTK.
philn@webkit.org [Mon, 5 Mar 2012 08:03:08 +0000 (08:03 +0000)]
Unreviewed, mark two tests as flaky in GTK.

* platform/gtk/test_expectations.txt:
editing/selection/select-line-break-with-opposite-directionality.html
and fast/css/hover-update.html are flaky.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r107551.
commit-queue@webkit.org [Mon, 5 Mar 2012 07:57:36 +0000 (07:57 +0000)]
Unreviewed, rolling out r107551.
http://trac.webkit.org/changeset/107551
https://bugs.webkit.org/show_bug.cgi?id=80245

caused incorrect style sharing (Requested by kling on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-04

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove unused macro HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE_WITH_VALUE.
macpherson@chromium.org [Mon, 5 Mar 2012 06:57:40 +0000 (06:57 +0000)]
Remove unused macro HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE_WITH_VALUE.
https://bugs.webkit.org/show_bug.cgi?id=80236

Reviewed by Eric Seidel.

No new tests / unused code deletion only.

* css/CSSStyleSelector.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoJIT heuristics should be hyperbolic
fpizlo@apple.com [Mon, 5 Mar 2012 06:52:44 +0000 (06:52 +0000)]
JIT heuristics should be hyperbolic
https://bugs.webkit.org/show_bug.cgi?id=80055
<rdar://problem/10922260>

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

Added tracking of the amount of executable memory typically used for a bytecode
instruction. Modified the execution counter scheme to use this, and the amount
of free memory, to determine how long to wait before invoking the JIT.

The result is that even if we bomb the VM with more code than can fit in our
executable memory pool, we still keep running and almost never run out of
executable memory - which ensures that if we have to JIT something critical, then
we'll likely have enough memory to do so. This also does not regress performance
on the three main benchmarks.

* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::predictedMachineCodeSize):
(JSC):
(JSC::CodeBlock::usesOpcode):
* bytecode/CodeBlock.h:
(CodeBlock):
(JSC::CodeBlock::checkIfJITThresholdReached):
(JSC::CodeBlock::dontJITAnytimeSoon):
(JSC::CodeBlock::jitAfterWarmUp):
(JSC::CodeBlock::jitSoon):
(JSC::CodeBlock::llintExecuteCounter):
(JSC::CodeBlock::counterValueForOptimizeAfterWarmUp):
(JSC::CodeBlock::counterValueForOptimizeAfterLongWarmUp):
(JSC::CodeBlock::addressOfJITExecuteCounter):
(JSC::CodeBlock::offsetOfJITExecuteCounter):
(JSC::CodeBlock::offsetOfJITExecutionActiveThreshold):
(JSC::CodeBlock::offsetOfJITExecutionTotalCount):
(JSC::CodeBlock::jitExecuteCounter):
(JSC::CodeBlock::checkIfOptimizationThresholdReached):
(JSC::CodeBlock::optimizeNextInvocation):
(JSC::CodeBlock::dontOptimizeAnytimeSoon):
(JSC::CodeBlock::optimizeAfterWarmUp):
(JSC::CodeBlock::optimizeAfterLongWarmUp):
(JSC::CodeBlock::optimizeSoon):
* bytecode/ExecutionCounter.cpp: Added.
(JSC):
(JSC::ExecutionCounter::ExecutionCounter):
(JSC::ExecutionCounter::checkIfThresholdCrossedAndSet):
(JSC::ExecutionCounter::setNewThreshold):
(JSC::ExecutionCounter::deferIndefinitely):
(JSC::ExecutionCounter::applyMemoryUsageHeuristics):
(JSC::ExecutionCounter::applyMemoryUsageHeuristicsAndConvertToInt):
(JSC::ExecutionCounter::hasCrossedThreshold):
(JSC::ExecutionCounter::setThreshold):
(JSC::ExecutionCounter::reset):
* bytecode/ExecutionCounter.h: Added.
(JSC):
(ExecutionCounter):
(JSC::ExecutionCounter::formattedTotalCount):
* dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* jit/ExecutableAllocator.cpp:
(JSC::DemandExecutableAllocator::allocateNewSpace):
(JSC::ExecutableAllocator::underMemoryPressure):
(JSC):
(JSC::ExecutableAllocator::memoryPressureMultiplier):
* jit/ExecutableAllocator.h:
* jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::ExecutableAllocator::memoryPressureMultiplier):
(JSC):
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::jitCompileAndSetHeuristics):
* llint/LowLevelInterpreter32_64.asm:
* runtime/JSGlobalData.h:
(JSGlobalData):
* runtime/Options.cpp:
(Options):
(JSC::Options::initializeOptions):
* runtime/Options.h:
(Options):
* wtf/SimpleStats.h: Added.
(WTF):
(SimpleStats):
(WTF::SimpleStats::SimpleStats):
(WTF::SimpleStats::add):
(WTF::SimpleStats::operator!):
(WTF::SimpleStats::count):
(WTF::SimpleStats::sum):
(WTF::SimpleStats::sumOfSquares):
(WTF::SimpleStats::mean):
(WTF::SimpleStats::variance):
(WTF::SimpleStats::standardDeviation):

Source/WebCore:

Reviewed by Oliver Hunt.

No new tests, since there's no new functionality.

* ForwardingHeaders/wtf/SimpleStats.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: Methods like firstRendererOf of NodeRenderingContext should be extracted.
shinyak@chromium.org [Mon, 5 Mar 2012 06:30:22 +0000 (06:30 +0000)]
Source/WebCore: Methods like firstRendererOf of NodeRenderingContext should be extracted.
https://bugs.webkit.org/show_bug.cgi?id=79902

Reviewed by Hajime Morita.

firstRendererOfInsertionPoint should return the first renderer of its child, however
it returns next renderer of parent. The same thing happens lastRendererOfInsertionPoint.

Test: content-element-move.html has another test case.

* dom/NodeRenderingContext.cpp:
(WebCore):
(WebCore::nextRendererOfInsertionPoint):
(WebCore::previousRendererOfInsertionPoint):
(WebCore::firstRendererOfInsertionPoint):
(WebCore::lastRendererOfInsertionPoint):
(WebCore::firstRendererOf):
(WebCore::lastRendererOf):
(WebCore::NodeRenderingContext::nextRenderer):
(WebCore::NodeRenderingContext::previousRenderer):

LayoutTests: Refactoring: Methods like firstRendererOf of NodeRenderingContext should be extracted.
https://bugs.webkit.org/show_bug.cgi?id=79902

Reviewed by Hajime Morita.

Added a new test case.

* fast/dom/shadow/content-element-move-expected.txt:
* fast/dom/shadow/content-element-move.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed build fix for ENABLE(MATHML).
morrita@google.com [Mon, 5 Mar 2012 04:43:00 +0000 (04:43 +0000)]
Unreviewed build fix for ENABLE(MATHML).

* mathml/MathMLElement.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebKit needs toHTMLUnknownElement() and isUnknown() for sanity check.
morrita@google.com [Mon, 5 Mar 2012 04:09:39 +0000 (04:09 +0000)]
WebKit needs toHTMLUnknownElement() and isUnknown() for sanity check.
https://bugs.webkit.org/show_bug.cgi?id=80229

Reviewed by Kent Tamura.

The code generator has naked static_cast<> which could be unsafe.
We can turn it into toHTMLUnknownElement() and the like.

No new tests. Just added a sanity check.

* dom/make_names.pl:
(printWrapperFactoryCppFile):
* html/HTMLElement.h:
(HTMLElement):
(WebCore::HTMLElement::isHTMLUnknownElement):
* html/HTMLUnknownElement.h:
(HTMLUnknownElement):
(WebCore::toHTMLUnknownElement):
(WebCore):
* mathml/MathMLElement.h:
(toMathMLElement):
* svg/SVGElement.h:
(WebCore::toSVGElement):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, Add myself to committer list.
charles.wei@torchmobile.com.cn [Mon, 5 Mar 2012 04:02:12 +0000 (04:02 +0000)]
Unreviewed, Add myself to committer list.
https://bugs.webkit.org/show_bug.cgi?id=80232

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHandle CSSPropertyWebkitColumnBreakAfter, CSSPropertyWebkitColumnBreakBefore and...
macpherson@chromium.org [Mon, 5 Mar 2012 03:38:58 +0000 (03:38 +0000)]
Handle CSSPropertyWebkitColumnBreakAfter, CSSPropertyWebkitColumnBreakBefore and CSSPropertyWebkitColumnBreakInside in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=80226

Reviewed by Eric Seidel.

No new tests / refactoring only.

* css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] upstream CredentialManager and CredentialTransformData implementation
commit-queue@webkit.org [Mon, 5 Mar 2012 03:29:28 +0000 (03:29 +0000)]
[BlackBerry] upstream CredentialManager and CredentialTransformData implementation
https://bugs.webkit.org/show_bug.cgi?id=80107

Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-03-04
Reviewed by Antonio Gomes.

Initial upstream of CredentialManager.[h|cpp] and
CredentialTransformData.[h|cpp].
No new test.

Source/WebKit:

* PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

* WebCoreSupport/CredentialManager.cpp: Added.
(WebCore):
(WebCore::CredentialManager::CredentialManager):
(WebCore::CredentialManager::autofillAuthenticationChallenge):
(WebCore::CredentialManager::autofillPasswordForms):
(WebCore::CredentialManager::saveCredentialIfConfirmed):
* WebCoreSupport/CredentialManager.h: Added.
(WebKit):
(WebCore):
(CredentialManager):
* WebCoreSupport/CredentialTransformData.cpp: Added.
(WebCore::CredentialTransformData::CredentialTransformData):
(WebCore):
(WebCore::CredentialTransformData::url):
(WebCore::CredentialTransformData::credential):
(WebCore::CredentialTransformData::setCredential):
(WebCore::CredentialTransformData::findPasswordFormFields):
* WebCoreSupport/CredentialTransformData.h: Added.
(WebCore):
(CredentialTransformData):
(WebCore::CredentialTransformData::isValid):
(WebCore::CredentialTransformData::protectionSpace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Credential backing store implementation
commit-queue@webkit.org [Mon, 5 Mar 2012 03:23:58 +0000 (03:23 +0000)]
[BlackBerry] Credential backing store implementation
https://bugs.webkit.org/show_bug.cgi?id=79650

Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-03-04
Reviewed by Antonio Gomes.

Opened Credential database in CedentialBackingStore::instance().
Added never_remember table and associated sql statment
members to store the never remember sites.
Removed CredentialStorage initialize codes because that
won't give users a chance to re-enter the new credential
information for an already stored site.
Changed login update and has statement to support
autofill feature of multiple credential forms in the
same page; Also added url as a parameter of hasLogin() function.
Added calling reset() after each statement calls step(),
to make it work correctly next time.
Also fixed a macro typo in HANDLE_SQL_EXEC_FAILURE.

No new tests.

* platform/network/blackberry/CredentialBackingStore.cpp:
(WebCore::CredentialBackingStore::instance):
(WebCore::CredentialBackingStore::CredentialBackingStore):
(WebCore::CredentialBackingStore::open):
(WebCore::CredentialBackingStore::close):
(WebCore::CredentialBackingStore::addLogin):
(WebCore::CredentialBackingStore::updateLogin):
(WebCore::CredentialBackingStore::hasLogin):
(WebCore::CredentialBackingStore::getLogin):
(WebCore):
(WebCore::CredentialBackingStore::removeLogin):
(WebCore::CredentialBackingStore::addNeverRemember):
(WebCore::CredentialBackingStore::hasNeverRemember):
(WebCore::CredentialBackingStore::getNeverRemember):
(WebCore::CredentialBackingStore::removeNeverRemember):
(WebCore::CredentialBackingStore::clearLogins):
(WebCore::CredentialBackingStore::clearNeverRemember):
* platform/network/blackberry/CredentialBackingStore.h:
(CredentialBackingStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Evas_GL initialization and destruction in GraphicsContext3DPrivate
commit-queue@webkit.org [Mon, 5 Mar 2012 03:15:18 +0000 (03:15 +0000)]
[EFL] Evas_GL initialization and destruction in GraphicsContext3DPrivate
https://bugs.webkit.org/show_bug.cgi?id=80211

Patch by Hyowon Kim <hw1008.kim@samsung.com> on 2012-03-04
Reviewed by Noam Rosenthal.

This patch adds initialization and destruction codes using Evas_GL APIs to GC3DPrivate.

No new tests. No behavior change.

* platform/graphics/efl/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::create):
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::initialize):
(WebCore::GraphicsContext3DPrivate::createSurface):
(WebCore::GraphicsContext3DPrivate::makeContextCurrent):
* platform/graphics/efl/GraphicsContext3DPrivate.h:
(GraphicsContext3DPrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CMake] Libraries are installed to /usr/lib and not /usr/lib64 on x86_64
kubo@profusion.mobi [Mon, 5 Mar 2012 03:01:38 +0000 (03:01 +0000)]
[CMake] Libraries are installed to /usr/lib and not /usr/lib64 on x86_64
https://bugs.webkit.org/show_bug.cgi?id=71507

Reviewed by Antonio Gomes.

.:

* Source/cmake/OptionsCommon.cmake: Provide two variables which
can be changed via CMake: LIB_SUFFIX, which is often used in CMake
projects to let the user choose whether a suffix should be added
to the library installation directory (such as 32 or 64), and
LIB_INSTALL_DIR, which takes LIB_SUFFIX into account to determine
whether to install libraries.

Source/JavaScriptCore:

* CMakeLists.txt: Use ${LIB_INSTALL_DIR} instead of hardcoding "lib".

Source/WebCore:

No new tests, buildsystem change.

* CMakeLists.txt: Use ${LIB_INSTALL_DIR} instead of hardcoding "lib".

Source/WebKit:

* CMakeLists.txt: Use ${LIB_INSTALL_DIR} instead of hardcoding "lib".

Source/WebKit2:

* CMakeLists.txt: Use ${LIB_INSTALL_DIR} instead of hardcoding "lib".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Implementation of missing functions in GraphicsContext3DPrivate
commit-queue@webkit.org [Mon, 5 Mar 2012 02:43:37 +0000 (02:43 +0000)]
[EFL] Implementation of missing functions in GraphicsContext3DPrivate
https://bugs.webkit.org/show_bug.cgi?id=79759

Patch by Hyowon Kim <hw1008.kim@samsung.com> on 2012-03-04
Reviewed by Noam Rosenthal.

The initial patch (Bug 62961) only contains implementations for simple functions
which call GL functions through Evas_GL_API.
This patch implements a little complicated functions such as getActiveAttrib(),
getShaderSource() and so on.

No new tests. No behavior change.

* platform/graphics/efl/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::getActiveAttrib):
(WebCore::GraphicsContext3DPrivate::getActiveUniform):
(WebCore::GraphicsContext3DPrivate::getError):
(WebCore::GraphicsContext3DPrivate::getIntegerv):
(WebCore::GraphicsContext3DPrivate::getProgramInfoLog):
(WebCore::GraphicsContext3DPrivate::getShaderInfoLog):
(WebCore::GraphicsContext3DPrivate::getShaderSource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRevert SVG-related APIs from DOMWindowSVG.idl back to DOMWindow.idl
haraken@chromium.org [Mon, 5 Mar 2012 02:33:21 +0000 (02:33 +0000)]
Revert SVG-related APIs from DOMWindowSVG.idl back to DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=80139

Reviewed by Adam Barth.

Based on the discussion on webkit-dev@
(http://markmail.org/message/kagvswmah67zmrry#query:+page:1+mid:h34vzbiu5suub3ld+state:results),
this patch reverts SVG-related APIs from DOMWindowSVG.idl back to DOMWindow.idl.

No tests. No change in behavior.

* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* page/DOMWindow.idl:
* svg/DOMWindowSVG.idl: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] We should reset mouse position before calling eventSender.mouseMove in...
tkent@chromium.org [Mon, 5 Mar 2012 02:32:00 +0000 (02:32 +0000)]
[Chromium] We should reset mouse position before calling eventSender.mouseMove in LayoutTest
https://bugs.webkit.org/show_bug.cgi?id=79748

* platform/chromium/test_expectations.txt: Removed flaky expectations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRevert WebGL-related APIs from DOMWindowWebGL.idl back to DOMWindow.idl
haraken@chromium.org [Mon, 5 Mar 2012 02:24:20 +0000 (02:24 +0000)]
Revert WebGL-related APIs from DOMWindowWebGL.idl back to DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=80144

Reviewed by Adam Barth.

Based on the discussion on webkit-dev@
(http://markmail.org/message/kagvswmah67zmrry#query:+page:1+mid:h34vzbiu5suub3ld+state:results),
this patch reverts WebGL-related APIs from DOMWindowWebGL.idl back to DOMWindow.idl.

No tests. No change in behavior.

* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* html/canvas/DOMWindowWebGL.idl: Removed.
* page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, gardening.
haraken@chromium.org [Mon, 5 Mar 2012 02:01:45 +0000 (02:01 +0000)]
Unreviewed, gardening.

* platform/chromium/fast/files/xhr-response-blob-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed build fix.
morrita@google.com [Mon, 5 Mar 2012 01:59:51 +0000 (01:59 +0000)]
Unreviewed build fix.

* rendering/RenderButton.cpp:
(WebCore::RenderButton::canHaveGeneratedChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109689 268f45cc-cd09-0410-ab3c-d52691b4dbfc