WebKit-https.git
7 months agovideo.currentTime is not being updated in iOS 13.4 Beta
eric.carlson@apple.com [Tue, 11 Feb 2020 21:14:44 +0000 (21:14 +0000)]
video.currentTime is not being updated in iOS 13.4 Beta
https://bugs.webkit.org/show_bug.cgi?id=207489
<rdar://problem/59322640>

Reviewed by Youenn Fablet.

Source/WebKit:

Allow the Web process and the GPU process to communicate with
'com.apple.coremedia.audiodeviceclock.xpc' because it is necessary to use a
CMTimeBase, which is used by MediaPlayerPrivateMediaStreamAVFObjC for currentTime.

Test: fast/mediastream/media-element-current-time.html

* Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

LayoutTests:

* fast/mediastream/media-element-current-time.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months agoDeprecate _WKUserContentWorld replaced by WKContentWorld
achristensen@apple.com [Tue, 11 Feb 2020 21:09:21 +0000 (21:09 +0000)]
Deprecate _WKUserContentWorld replaced by WKContentWorld
https://bugs.webkit.org/show_bug.cgi?id=207514

Add the rest of the SPI to convert between the two.

* UIProcess/API/Cocoa/_WKUserContentWorld.h:
* UIProcess/API/Cocoa/_WKUserContentWorld.mm:
(-[_WKUserContentWorld contentWorld]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[ Mac wk2 ] http/tests/ssl/applepay/ApplePayBillingAddress.html is flaky failing.
lawrence.j@apple.com [Tue, 11 Feb 2020 21:08:09 +0000 (21:08 +0000)]
[ Mac wk2 ] http/tests/ssl/applepay/ApplePayBillingAddress.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=207577

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months agoKeyboardInputTests.SupportsImagePaste fails on recent versions of UIKit
wenson_hsieh@apple.com [Tue, 11 Feb 2020 20:59:13 +0000 (20:59 +0000)]
KeyboardInputTests.SupportsImagePaste fails on recent versions of UIKit
https://bugs.webkit.org/show_bug.cgi?id=207557

Reviewed by Jonathan Bedard.

The exception occurs because UIKit attempts to create a QoS interval upon setting the initially selected row in
a UITableView when we focus a date picker. This fails because TestWebKitAPI isn't actually an app, so the call
to `work_interval_create` with `WORK_INTERVAL_TYPE_CA_CLIENT` as the option flag fails. For the time being, work
around this by focusing an empty select element instead (for which we won't attempt to create and select any
table view cells).

* TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[ macOS wk2 ] http/tests/IndexedDB/collect-IDB-objects.https.html is flaky failing
jacob_uphoff@apple.com [Tue, 11 Feb 2020 19:41:55 +0000 (19:41 +0000)]
[ macOS wk2 ] http/tests/IndexedDB/collect-IDB-objects.https.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=207571

Unreviewed test gardening

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months agoDeprecate _WKUserContentWorld replaced by WKContentWorld
achristensen@apple.com [Tue, 11 Feb 2020 19:40:03 +0000 (19:40 +0000)]
Deprecate _WKUserContentWorld replaced by WKContentWorld
https://bugs.webkit.org/show_bug.cgi?id=207514

Reviewed by Brady Eidson.

I also add SPI to convert between the two to aid a smooth transition.

* Shared/Cocoa/APIObject.mm:
(API::Object::newObject):
* UIProcess/API/APIContentWorld.cpp:
(API::ContentWorld::fromUserContentWorld):
(API::ContentWorld::ContentWorld):
* UIProcess/API/APIContentWorld.h:
(API::ContentWorldBase::ContentWorldBase):
* UIProcess/API/APIUserContentWorld.cpp:
(API::UserContentWorld::fromContentWorld):
(API::UserContentWorld::UserContentWorld):
* UIProcess/API/APIUserContentWorld.h:
* UIProcess/API/Cocoa/WKContentWorld.mm:
(-[WKContentWorld _userContentWorld]):
* UIProcess/API/Cocoa/WKContentWorldInternal.h:
* UIProcess/API/Cocoa/WKContentWorldPrivate.h: Added.
* UIProcess/API/Cocoa/WKUserContentController.mm:
* UIProcess/API/Cocoa/WKUserScript.mm:
* UIProcess/API/Cocoa/_WKUserContentWorld.h:
* UIProcess/API/Cocoa/_WKUserContentWorld.mm:
* UIProcess/API/Cocoa/_WKUserContentWorldInternal.h:
* UIProcess/API/Cocoa/_WKUserStyleSheet.h:
* UIProcess/API/Cocoa/_WKUserStyleSheet.mm:
* WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[ macOS wk1 ] legacy-animation-engine/animations/3d/transform-origin-vs-functions...
jacob_uphoff@apple.com [Tue, 11 Feb 2020 19:25:47 +0000 (19:25 +0000)]
[ macOS wk1 ] legacy-animation-engine/animations/3d/transform-origin-vs-functions.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=207569

Unreviewed test gardening

* platform/mac-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[ macOS wk1 ] inspector/page/overrideUserAgent.html is a flaky failure
jacob_uphoff@apple.com [Tue, 11 Feb 2020 19:16:51 +0000 (19:16 +0000)]
[ macOS wk1 ] inspector/page/overrideUserAgent.html  is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=207568

Unreviewed test gardening

* platform/mac-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[ macOS wk1 ] imported/w3c/web-platform-tests/web-animations/timing-model/animations...
jacob_uphoff@apple.com [Tue, 11 Feb 2020 19:06:46 +0000 (19:06 +0000)]
[ macOS wk1 ] imported/w3c/web-platform-tests/web-animations/timing-model/animations/pausing-an-animation.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=207566

Unreviewed test gardening

* platform/mac-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[ iOS ] imported/w3c/web-platform-tests/content-security-policy/frame-ancestors/frame...
tsavell@apple.com [Tue, 11 Feb 2020 19:04:05 +0000 (19:04 +0000)]
[ iOS ] imported/w3c/web-platform-tests/content-security-policy/frame-ancestors/frame-ancestors-from-serviceworker.https.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=207563

Unreviewed test gardening

* platform/ios/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months agoAX: Wrong includes for internal SDK
cfleizach@apple.com [Tue, 11 Feb 2020 18:58:19 +0000 (18:58 +0000)]
AX: Wrong includes for internal SDK
https://bugs.webkit.org/show_bug.cgi?id=207554

Reviewed by Chris Dumez.

* pal/spi/mac/HIServicesSPI.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[ macOS iOS ] animations/animation-callback-timestamp.html is flaky failing.
jacob_uphoff@apple.com [Tue, 11 Feb 2020 18:49:14 +0000 (18:49 +0000)]
[ macOS iOS ] animations/animation-callback-timestamp.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=207153

Unreviewed test gardening

* platform/mac-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months agoBOTWATCH: editing/selection/5354455-1.html causes nasty crash
jacob_uphoff@apple.com [Tue, 11 Feb 2020 18:38:20 +0000 (18:38 +0000)]
BOTWATCH: editing/selection/5354455-1.html causes nasty crash
rdar://problem/13448458

Unreviewed test gardening

* platform/mac-wk2/TestExpectations: unskip test because it no longer crashes locally

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months agoREGRESSION (r256009): [ Mojave wk2 Debug ] ASSERTION FAILED: Completion handler shoul...
youenn@apple.com [Tue, 11 Feb 2020 18:26:51 +0000 (18:26 +0000)]
REGRESSION (r256009): [ Mojave wk2 Debug ] ASSERTION FAILED: Completion handler should always be called under WebKit::WebMDNSRegister::PendingRegistration
https://bugs.webkit.org/show_bug.cgi?id=207521
<rdar://problem/59331313>

Reviewed by Eric Carlson.

Source/WebKit:

Covered by debug assertion not hit in layout tests.

* WebProcess/Network/webrtc/WebMDNSRegister.cpp:
(WebKit::WebMDNSRegister::finishedRegisteringMDNSName):
Call completion handler even if the document entry has been cleared, which can happen in suspend/destruction case.
If the entry is not there, all MDNS names for the document have been unregistered. We then report a registration error.

LayoutTests:

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[ macOS wk1 ] media/airplay-target-availability.html is flaky failing
jacob_uphoff@apple.com [Tue, 11 Feb 2020 18:18:37 +0000 (18:18 +0000)]
[ macOS wk1 ] media/airplay-target-availability.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=207560

Unreviewed test gardening

* platform/mac-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months agoAdd WKHTTPCookieStore._getCookiesForURL SPI
commit-queue@webkit.org [Tue, 11 Feb 2020 18:14:10 +0000 (18:14 +0000)]
Add WKHTTPCookieStore._getCookiesForURL SPI
https://bugs.webkit.org/show_bug.cgi?id=207527

Patch by Alex Christensen <achristensen@webkit.org> on 2020-02-11
Reviewed by Brady Eidson.

Source/WebKit:

This is needed to implement rdar://problem/57193106 without re-implementing the cookie/URL matching logic that exists in CFNetwork.
Covered by an API test with a great pun in it.

* UIProcess/API/APIHTTPCookieStore.cpp:
(API::HTTPCookieStore::cookiesForURL):
* UIProcess/API/APIHTTPCookieStore.h:
* UIProcess/API/Cocoa/WKHTTPCookieStore.mm:
(-[WKHTTPCookieStore _getCookiesForURL:completionHandler:]):
* UIProcess/API/Cocoa/WKHTTPCookieStorePrivate.h: Added.
* WebKit.xcodeproj/project.pbxproj:

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
(TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months agoWebSWServerConnection::registerServiceWorkerClient is not sending IPC message to...
youenn@apple.com [Tue, 11 Feb 2020 17:57:16 +0000 (17:57 +0000)]
WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
https://bugs.webkit.org/show_bug.cgi?id=207537

Reviewed by Chris Dumez.

Source/WebKit:

Covered by added API test.

* NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:
(WebKit::WebSWServerConnection::registerServiceWorkerClient):
Fix use after move so that we can get the context connection and send the IPC message to UIProcess as expected.

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[ macOS iOS ] fast/parser/parser-yield-timing.html is a flaky failure
jacob_uphoff@apple.com [Tue, 11 Feb 2020 17:51:00 +0000 (17:51 +0000)]
[ macOS iOS ] fast/parser/parser-yield-timing.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=207559

Unreviewed test gardening

* platform/ios-wk2/TestExpectations:
* platform/mac-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months agoAdd WKContentWorld.h to WebKit.h
achristensen@apple.com [Tue, 11 Feb 2020 17:48:15 +0000 (17:48 +0000)]
Add WKContentWorld.h to WebKit.h
https://bugs.webkit.org/show_bug.cgi?id=207351

Suggested by Alex Christensen.

Patch by Brady Eidson <beidson@apple.com> on 2020-02-11

* Shared/API/Cocoa/WebKit.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[LFC] Introduce Layout::LineBreakBox
zalan@apple.com [Tue, 11 Feb 2020 17:12:44 +0000 (17:12 +0000)]
[LFC] Introduce Layout::LineBreakBox
https://bugs.webkit.org/show_bug.cgi?id=207550
<rdar://problem/59348274>

Reviewed by Antti Koivisto.

This is in preparation for making Layout::Box an abstract box (so that it stops being a leaf type of box).

* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::collectInlineContentIfNeeded):
* layout/integration/LayoutIntegrationBoxTree.cpp:
(WebCore::LayoutIntegration::BoxTree::buildTree):
* layout/layouttree/LayoutBox.h:
(WebCore::Layout::Box::isImage const):
(WebCore::Layout::Box::isLineBreakBox const):
* layout/layouttree/LayoutTreeBuilder.cpp:
(WebCore::Layout::TreeBuilder::createLineBreakBox):
(WebCore::Layout::TreeBuilder::createLayoutBox):
* layout/layouttree/LayoutTreeBuilder.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[ iOS ] imported/w3c/IndexedDB-private-browsing/idbcursor_update_objectstore8.html...
jacob_uphoff@apple.com [Tue, 11 Feb 2020 17:11:02 +0000 (17:11 +0000)]
[ iOS ] imported/w3c/IndexedDB-private-browsing/idbcursor_update_objectstore8.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=207555

Unreviewed test gardening

* platform/ios-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[ iOS ] imported/w3c/IndexedDB-private-browsing/abort-in-initial-upgradeneeded.html...
jacob_uphoff@apple.com [Tue, 11 Feb 2020 16:50:46 +0000 (16:50 +0000)]
[ iOS ] imported/w3c/IndexedDB-private-browsing/abort-in-initial-upgradeneeded.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=207553

Unreviewed test gardening

* platform/ios-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months agoLayout Test imported/w3c/web-platform-tests/service-workers/service-worker/redirected...
jacob_uphoff@apple.com [Tue, 11 Feb 2020 16:42:43 +0000 (16:42 +0000)]
Layout Test imported/w3c/web-platform-tests/service-workers/service-worker/redirected-response.https.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=190852

Updating expectations to include ios

Unreviewed test gardening

* platform/ios-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[ iOS ] http/tests/storageAccess/has-storage-access-false-by-default-ephemeral-databa...
jacob_uphoff@apple.com [Tue, 11 Feb 2020 16:36:57 +0000 (16:36 +0000)]
[ iOS ] http/tests/storageAccess/has-storage-access-false-by-default-ephemeral-database.html is flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=207552

Unreviewed test gardening

* platform/ios-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[ iOS ] http/tests/adClickAttribution/store-disabled-in-ephemeral-session.html is...
jacob_uphoff@apple.com [Tue, 11 Feb 2020 16:15:08 +0000 (16:15 +0000)]
[ iOS ] http/tests/adClickAttribution/store-disabled-in-ephemeral-session.html is flaky timing out
https://bugs.webkit.org/show_bug.cgi?id=207551

Unreviewed test gardening

* platform/ios-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months agoREGRESSION (r253312): imported/w3c/web-platform-tests/content-security-policy/reporti...
jacob_uphoff@apple.com [Tue, 11 Feb 2020 15:58:20 +0000 (15:58 +0000)]
REGRESSION (r253312): imported/w3c/web-platform-tests/content-security-policy/reporting/report-same-origin-with-cookies.html is super flaky
https://bugs.webkit.org/show_bug.cgi?id=205216

Updated test expectations to include ios.

Unreviewed test gardening

* platform/ios-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[LFC] Introduce Layout::InlineTextBox
zalan@apple.com [Tue, 11 Feb 2020 15:13:15 +0000 (15:13 +0000)]
[LFC] Introduce Layout::InlineTextBox
https://bugs.webkit.org/show_bug.cgi?id=207530
<rdar://problem/59336020>

Reviewed by Antti Koivisto.

Any text that is directly contained inside a block container element (not inside an inline element) must be treated as an anonymous inline element.

* Sources.txt:
* layout/Verification.cpp:
(WebCore::Layout::checkForMatchingTextRuns):
* layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::collectInlineContentIfNeeded):
* layout/inlineformatting/InlineLineBreaker.cpp:
(WebCore::Layout::LineBreaker::tryBreakingTextRun const):
* layout/inlineformatting/InlineLineBuilder.cpp:
(WebCore::Layout::m_textContext):
* layout/inlineformatting/InlineSoftLineBreakItem.h:
(WebCore::Layout::InlineSoftLineBreakItem::createSoftLineBreakItem):
(WebCore::Layout::InlineSoftLineBreakItem::InlineSoftLineBreakItem):
* layout/inlineformatting/InlineTextItem.cpp:
(WebCore::Layout::InlineTextItem::createAndAppendTextItems):
(WebCore::Layout::InlineTextItem::isEmptyContent const):
* layout/inlineformatting/InlineTextItem.h:
(WebCore::Layout::InlineTextItem::inlineTextBox const):
(WebCore::Layout::InlineTextItem::createWhitespaceItem):
(WebCore::Layout::InlineTextItem::createNonWhitespaceItem):
(WebCore::Layout::InlineTextItem::createEmptyItem):
(WebCore::Layout::InlineTextItem::InlineTextItem):
(WebCore::Layout::InlineTextItem::left const):
(WebCore::Layout::InlineTextItem::right const):
* layout/inlineformatting/LineLayoutContext.cpp:
(WebCore::Layout::endsWithSoftWrapOpportunity):
* layout/inlineformatting/text/TextUtil.cpp:
(WebCore::Layout::TextUtil::width):
(WebCore::Layout::TextUtil::split):
* layout/inlineformatting/text/TextUtil.h:
* layout/integration/LayoutIntegrationBoxTree.cpp:
(WebCore::LayoutIntegration::BoxTree::buildTree):
* layout/layouttree/LayoutBox.cpp:
(WebCore::Layout::Box::Box):
(): Deleted.
* layout/layouttree/LayoutBox.h:
(WebCore::Layout::Box::isInlineTextBox const):
(WebCore::Layout::Box::hasTextContent const): Deleted.
(WebCore::Layout::Box::textContext const): Deleted.
* layout/layouttree/LayoutContainer.cpp:
(WebCore::Layout::Container::Container):
(): Deleted.
* layout/layouttree/LayoutInlineTextBox.cpp: Copied from Source/WebCore/layout/layouttree/TextContext.h.
(WebCore::Layout::InlineTextBox::InlineTextBox):
(WebCore::Layout::m_canUseSimplifiedContentMeasuring):
* layout/layouttree/LayoutInlineTextBox.h: Renamed from Source/WebCore/layout/layouttree/TextContext.h.
(WebCore::Layout::InlineTextBox::content const):
(WebCore::Layout::InlineTextBox::canUseSimplifiedContentMeasuring const):
* layout/layouttree/LayoutTreeBuilder.cpp:
(WebCore::Layout::TreeBuilder::createTextBox):
(WebCore::Layout::TreeBuilder::createLayoutBox):
(WebCore::Layout::outputLayoutBox):
* layout/layouttree/LayoutTreeBuilder.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months agoUse ObjectIdentifier for WebSocketStream/WebSocketChannel
youenn@apple.com [Tue, 11 Feb 2020 14:08:30 +0000 (14:08 +0000)]
Use ObjectIdentifier for WebSocketStream/WebSocketChannel
https://bugs.webkit.org/show_bug.cgi?id=207507

Reviewed by Alex Christensen.

Replace uint64_t by ObjectIdentifier.
This adds type safety and ensures we get valid identifiers from IPC.
We still need to check for destinationID being not null in a few places.
No observable change of behavior.

* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::didReceiveMessage):
(WebKit::NetworkConnectionToWebProcess::createSocketStream):
(WebKit::NetworkConnectionToWebProcess::createSocketChannel):
(WebKit::NetworkConnectionToWebProcess::removeSocketChannel):
* NetworkProcess/NetworkConnectionToWebProcess.h:
* NetworkProcess/NetworkConnectionToWebProcess.messages.in:
* NetworkProcess/NetworkSocketChannel.cpp:
(WebKit::NetworkSocketChannel::create):
(WebKit::NetworkSocketChannel::NetworkSocketChannel):
* NetworkProcess/NetworkSocketChannel.h:
* NetworkProcess/NetworkSocketStream.cpp:
(WebKit::NetworkSocketStream::create):
(WebKit::NetworkSocketStream::NetworkSocketStream):
(WebKit::NetworkSocketStream::messageSenderDestinationID const):
* NetworkProcess/NetworkSocketStream.h:
* Scripts/webkit/messages.py:
* WebKit.xcodeproj/project.pbxproj:
* WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::didReceiveMessage):
* WebProcess/Network/WebSocketChannel.cpp:
(WebKit::WebSocketChannel::WebSocketChannel):
(WebKit::WebSocketChannel::messageSenderDestinationID const):
(WebKit::WebSocketChannel::connect):
* WebProcess/Network/WebSocketChannel.h:
(WebKit::WebSocketChannel::identifier const):
* WebProcess/Network/WebSocketChannelManager.cpp:
(WebKit::WebSocketChannelManager::didReceiveMessage):
* WebProcess/Network/WebSocketChannelManager.h:
* WebProcess/Network/WebSocketIdentifier.h: Added.
* WebProcess/Network/WebSocketStream.cpp:
(WebKit::WebSocketStream::streamWithIdentifier):
(WebKit::WebSocketStream::WebSocketStream):
(WebKit::WebSocketStream::~WebSocketStream):
(WebKit::WebSocketStream::messageSenderDestinationID const):
* WebProcess/Network/WebSocketStream.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[WPE][WebDriver] MiniBrowser should react to close session commands
commit-queue@webkit.org [Tue, 11 Feb 2020 13:09:59 +0000 (13:09 +0000)]
[WPE][WebDriver] MiniBrowser should react to close session commands
https://bugs.webkit.org/show_bug.cgi?id=207529

Patch by Lauro Moura <lmoura@igalia.com> on 2020-02-11
Reviewed by Carlos Garcia Campos.

WebDriver delete session command asks to close the WebView associated to the
current automation session. We must react to it to avoid lots of
timeouts and errors.

* MiniBrowser/wpe/main.cpp:
(main): Listen to "close" signal on the main WebView.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months agoUnreviewed. Fix WPE build after r256298
carlosgc@webkit.org [Tue, 11 Feb 2020 13:03:46 +0000 (13:03 +0000)]
Unreviewed. Fix WPE build after r256298

It started to fail in r256298 because of unified builds, but the issue was introduced in r256013.

* platform/network/soup/ResourceRequestSoup.cpp: Add missing header include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months agoREGRESSION: [ Mac ] legacy-animation-engine/fast/animation/request-animation-frame...
commit-queue@webkit.org [Tue, 11 Feb 2020 11:31:58 +0000 (11:31 +0000)]
REGRESSION: [ Mac ] legacy-animation-engine/fast/animation/request-animation-frame-iframe2.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=206624

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2020-02-11
Reviewed by Antoine Quint.

Rewrite test to have a reliable asynchronous execution order.

* fast/animation/script-tests/request-animation-frame-subframe.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[GTK][WPE] imported/w3c/web-platform-tests/css/css-lists/counter-* tests consistently...
commit-queue@webkit.org [Tue, 11 Feb 2020 10:47:26 +0000 (10:47 +0000)]
[GTK][WPE] imported/w3c/web-platform-tests/css/css-lists/counter-* tests consistently pass
https://bugs.webkit.org/show_bug.cgi?id=207533

Unreviewed test gardening.

Patch by Chris Lord <clord@igalia.com> on 2020-02-11

* platform/gtk/TestExpectations:
* platform/wpe/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[WPE] Add initial support for rendering scrollbars
carlosgc@webkit.org [Tue, 11 Feb 2020 09:35:23 +0000 (09:35 +0000)]
[WPE] Add initial support for rendering scrollbars
https://bugs.webkit.org/show_bug.cgi?id=206999

Reviewed by Michael Catanzaro.

Show overlay scrollbars with a style similar to Adwaita.

* SourcesWPE.txt: Add ScrollAnimatorGeneric.cpp to the build.
* platform/ScrollAnimator.cpp: Switch to use ScrollAnimatorGeneric, required to show/hide the overlay scrollbars.
* platform/wpe/ScrollbarThemeWPE.cpp:
(WebCore::ScrollbarThemeWPE::scrollbarThickness):
(WebCore::ScrollbarThemeWPE::minimumThumbLength):
(WebCore::ScrollbarThemeWPE::hasButtons):
(WebCore::ScrollbarThemeWPE::hasThumb):
(WebCore::ScrollbarThemeWPE::backButtonRect):
(WebCore::ScrollbarThemeWPE::forwardButtonRect):
(WebCore::ScrollbarThemeWPE::trackRect):
(WebCore::ScrollbarThemeWPE::paint):
* platform/wpe/ScrollbarThemeWPE.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[iOS] Non-internal API test runners frequently crash due to Objective-C exceptions
wenson_hsieh@apple.com [Tue, 11 Feb 2020 08:24:47 +0000 (08:24 +0000)]
[iOS] Non-internal API test runners frequently crash due to Objective-C exceptions
https://bugs.webkit.org/show_bug.cgi?id=207525
<rdar://problem/59110543>

Reviewed by Tim Horton.

After the fix for <rdar://problem/56301207>, some scroll view content offset changes will attempt to call into
CoreAnalytics API to try and report data about scrolling velocities. In the iOS 13.3 simulator, this involves
creating a dictionary, of which one of the keys is the bundle identifier of the application. The value is
unconditionally inserted into the dictionary. Since TestWebKitAPI does not run in the context of a
UIApplication, the bundle identifier (that is, `NSBundle.mainBundle.bundleIdentifier`) ends up being nil,
causing us to crash upon trying to create the dictionary.

While it would make things easier, we can't just swizzle -bundleIdentifier for the entirely of every test, since
some tests expect the bundle identifier to be nil (or call into system frameworks that expect the bundle
identifier to be nil). These tests fail or time out when -bundleIdentifier is unconditionally swizzled
throughout the test run. To work around this bug for the time being, simply pretend that we have a bundle
identifier when running API tests on iOS, by swizzling `-[NSBundle bundleIdentifier]` to return a string at the
beginning of each API test.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/cocoa/TestWKWebView.mm:
(overrideBundleIdentifier):

Move this to the top of the file, so it can be shared.

(+[WKWebView initialize]):

At the start of each test, force UIKit to cache a fake value for `_UIMainBundleIdentifier()` by invoking an
internal class method that calls into the internal helper function, with no other side effects.

* TestWebKitAPI/ios/UIKitSPI.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months agoAX: Unable to build webkit open source - build errors related to AXClientType
cfleizach@apple.com [Tue, 11 Feb 2020 08:10:59 +0000 (08:10 +0000)]
AX: Unable to build webkit open source - build errors related to AXClientType
https://bugs.webkit.org/show_bug.cgi?id=207524
<rdar://problem/59279722>

Reviewed by Mark Lam.

Source/WebCore/PAL:

* pal/spi/mac/HIServicesSPI.h:

Source/WebKit:

* Platform/spi/mac/ApplicationServicesSPI.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[WebAuthn] Move the async code from WebAuthenticationPanelClient to AuthenticatorManager
jiewen_tan@apple.com [Tue, 11 Feb 2020 03:35:25 +0000 (03:35 +0000)]
[WebAuthn] Move the async code from WebAuthenticationPanelClient to AuthenticatorManager
https://bugs.webkit.org/show_bug.cgi?id=206248

Reviewed by Alex Christensen.

No change of behaviors.

* UIProcess/API/APIWebAuthenticationPanelClient.h:
(API::WebAuthenticationPanelClient::selectAssertionResponse const):
* UIProcess/WebAuthentication/AuthenticatorManager.cpp:
(WebKit::AuthenticatorManager::serviceStatusUpdated):
(WebKit::AuthenticatorManager::authenticatorStatusUpdated):
(WebKit::AuthenticatorManager::requestPin):
(WebKit::AuthenticatorManager::selectAssertionResponse):
(WebKit::AuthenticatorManager::runPanel):
(WebKit::AuthenticatorManager::invokePendingCompletionHandler):
(WebKit::AuthenticatorManager::dispatchPanelClientCall const):
* UIProcess/WebAuthentication/AuthenticatorManager.h:
* UIProcess/WebAuthentication/Cocoa/WebAuthenticationPanelClient.h:
* UIProcess/WebAuthentication/Cocoa/WebAuthenticationPanelClient.mm:
(WebKit::WebAuthenticationPanelClient::updatePanel const):
(WebKit::WebAuthenticationPanelClient::dismissPanel const):
(WebKit::WebAuthenticationPanelClient::requestPin const):
(WebKit::WebAuthenticationPanelClient::selectAssertionResponse const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months agoTestWebKitAPI: Support ClipboardTests.ReadMultipleItems on Catalyst
jbedard@apple.com [Tue, 11 Feb 2020 03:32:16 +0000 (03:32 +0000)]
TestWebKitAPI: Support ClipboardTests.ReadMultipleItems on Catalyst
https://bugs.webkit.org/show_bug.cgi?id=207501
<rdar://problem/59323414>

Reviewed by Alex Christensen.

* TestWebKitAPI/Tests/WebKitCocoa/ClipboardTests.mm:
(writeMultipleObjectsToPlatformPasteboard): All iOS family ports should have
The same behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months agoAdd a variant of -[WKWebViewPrivate _getContentsAsStringWithCompletionHandler:] that...
commit-queue@webkit.org [Tue, 11 Feb 2020 02:18:05 +0000 (02:18 +0000)]
Add a variant of -[WKWebViewPrivate _getContentsAsStringWithCompletionHandler:] that includes contents from subframes
https://bugs.webkit.org/show_bug.cgi?id=207352
<rdar://problem/59115798>

Patch by Alan Sien Wei Hshieh <hshieh@apple.com> on 2020-02-10
Reviewed by Alex Christensen.

Source/WebKit:

A number of intelligence features like Spotlight rely on -_getContentsAsStringWithCompletionHandler:. However, this
method does not return content strings for subframes. This means that Spotlight and others are not able to get
text for things like AMP pages, that live in subframes. -_getContentsAsStringWithCompletionHandler: has clients outside
of just intelligence features, and we don't want to wholesale change their behavior. As a result, introduce a new
-_getContentsAsStringInAllFrames:withCompletionHandler: which clients can adopt as necessary. Providing NO for the first
parameter allows clients to get the same contents as -_getContentsAsStringWithCompletionHandler:. Otherwise, we enumerate
all subframes and extract text from there. Finally, append a test for getting stuff out of frames.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _getContentsAsStringWithCompletionHandler:]):
(-[WKWebView _getContentsOfAllFramesAsStringWithCompletionHandler:]): Call the new function to extract contents from all
frames.

* UIProcess/API/Cocoa/WKWebViewPrivate.h: Expose a new SPI for clients.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::getContentsAsStringInAllFrames): Piping. This emulates what getContentsAsString() does.

* UIProcess/WebPageProxy.h: Expose new method.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::getContentsAsString): Augment to take a flag saying whether or not we want to extract
from all frames. If we do, iterate over all the frames and get their content strings, appending two
new lines in the middle.

* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in: Piping.

* Shared/ContentAsStringIncludesChildFrames.h: Add a new header to expose an enum.

Tools:

Add a test to exercise the new SPI.

* TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm: Add a test for getting text from all frames with
a webpage that contains text in subframes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months agoREGRESSION: (253807) [ macOS iOS ] storage/indexeddb/intversion-long-queue-private...
sihui_liu@apple.com [Tue, 11 Feb 2020 02:08:05 +0000 (02:08 +0000)]
REGRESSION: (253807) [ macOS iOS ] storage/indexeddb/intversion-long-queue-private.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=206965
<rdar://problem/59005652>

Reviewed by Ryosuke Niwa.

Modify a test to make it less flaky. Based on our current implementation, there is no guarantee that Block event on
delete request would be fired before Complete event on transaction from connection2 in this test. The events
sequence we are sure are:
1. UpgradeNeeded event on openRequest2 -> VersionChange event on connection2 -> Complete event on VersionChange
transaction on connection2 -> Success event on openRequest2.
2. VersionChange event on connection2 -> Block event on delete request.
Therefore I am changing the test to ensure sequence 1.

* platform/ios-wk2/TestExpectations:
* platform/mac/TestExpectations:
* storage/indexeddb/intversion-long-queue-expected.txt:
* storage/indexeddb/intversion-long-queue-private-expected.txt:
* storage/indexeddb/resources/intversion-long-queue.js:
(connection2Blocked):
(connection2UpgradeNeeded):
(connection2VersionChangeCallback):
(deleteDatabaseBlockedCallback): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[iOS] Crash when granting access to asset services
pvollan@apple.com [Tue, 11 Feb 2020 01:46:03 +0000 (01:46 +0000)]
[iOS] Crash when granting access to asset services
https://bugs.webkit.org/show_bug.cgi?id=207520
Source/WebKit:

<rdar://problem/59321848>

Reviewed by Brent Fulgham.

Pass correct handle when calling SandboxExtension::createHandleForMachLookup.

API test: WebKit.GrantAccessToMobileAssetsCrash

* UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::grantAccessToAssetServices):

Tools:

Reviewed by Brent Fulgham.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit/GrantAccessToMobileAssets.mm: Added.
(TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months agoWebKit::WebProcessPool::initializeClassesForParameterCoding() should keep a copy...
ddkilzer@apple.com [Tue, 11 Feb 2020 01:13:01 +0000 (01:13 +0000)]
WebKit::WebProcessPool::initializeClassesForParameterCoding() should keep a copy of CString
<https://webkit.org/b/207519>
<rdar://problem/59043436>

Reviewed by Brent Fulgham.

* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::initializeClassesForParameterCoding):
- Change `className` to keep a copy of the CString object.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[DRT] InternalSettingsGenerated::resetToConsistentState() may override TestOptions
cdumez@apple.com [Tue, 11 Feb 2020 00:53:36 +0000 (00:53 +0000)]
[DRT] InternalSettingsGenerated::resetToConsistentState() may override TestOptions
https://bugs.webkit.org/show_bug.cgi?id=207481

Reviewed by Alexey Proskuryakov.

InternalSettingsGenerated::resetToConsistentState() may override TestOptions such as enableBackForwardCache.
This is causing issues such as the back/forward cache sometimes getting enabled on tests where
TestOptions::enableBackForwardCache() is false, because a previous test has enabled the back/forward cache.

* DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebViewToConsistentStateBeforeTesting):
Make sure we reset preferences after we call WebCoreTestSupport::resetInternalsObject(), since
resetInternalsObject() updates settings and TestOptions / DRT preferences should have priority
over internal settings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months agoRegression: (r256009?) [ Mojave wk2 Debug ] webrtc/peerconnection-page-cache-long...
lawrence.j@apple.com [Tue, 11 Feb 2020 00:49:02 +0000 (00:49 +0000)]
Regression: (r256009?) [ Mojave wk2 Debug ] webrtc/peerconnection-page-cache-long.html is crashing.
https://bugs.webkit.org/show_bug.cgi?id=207521

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months agoAdjust the minor version number for the desktop user agent string.
cdumez@apple.com [Tue, 11 Feb 2020 00:44:31 +0000 (00:44 +0000)]
Adjust the minor version number for the desktop user agent string.
https://bugs.webkit.org/show_bug.cgi?id=207498
<rdar://problem/59274765>

Patch by Keith Rollin <krollin@apple.com> on 2020-02-10
Reviewed by Wenson Hsieh.

This helps with Netflix compatibility on the iPad.

No new tests -- no new or changed functionality.

* platform/ios/UserAgentIOS.mm:
(WebCore::standardUserAgentWithApplicationName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[ Mac wk2 ] tiled-drawing/simple-document-with-margin-tiles.html is flaky failing.
lawrence.j@apple.com [Tue, 11 Feb 2020 00:30:48 +0000 (00:30 +0000)]
[ Mac wk2 ] tiled-drawing/simple-document-with-margin-tiles.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=207518

unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[iOS] REGRESSION (r255592): The simulated mouse event dispatch quirk should not be...
wenson_hsieh@apple.com [Tue, 11 Feb 2020 00:22:20 +0000 (00:22 +0000)]
[iOS] REGRESSION (r255592): The simulated mouse event dispatch quirk should not be on by default
https://bugs.webkit.org/show_bug.cgi?id=207513
<rdar://problem/59326119>

Reviewed by Tim Horton.

Turn `shouldDispatchSimulatedMouseEvents` back off by default (r255592 enabled it by default on all web pages).

* page/Quirks.cpp:
(WebCore::Quirks::shouldDispatchSimulatedMouseEvents const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[ Mac Debug ] inspector/animation/lifecycle-css-transition.html is flaky failing.
lawrence.j@apple.com [Tue, 11 Feb 2020 00:12:52 +0000 (00:12 +0000)]
[ Mac Debug ] inspector/animation/lifecycle-css-transition.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=207517

Unreviewed test gardening.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[ Mac wk2 ] http/wpt/service-workers/service-worker-spinning-fetch.https.html is...
lawrence.j@apple.com [Mon, 10 Feb 2020 23:57:56 +0000 (23:57 +0000)]
[ Mac wk2 ] http/wpt/service-workers/service-worker-spinning-fetch.https.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=207515

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[watchOS] Notification listener is never unregistered
pvollan@apple.com [Mon, 10 Feb 2020 23:49:15 +0000 (23:49 +0000)]
[watchOS] Notification listener is never unregistered
https://bugs.webkit.org/show_bug.cgi?id=207459
Source/WebKit:

<rdar://problem/58923393>

Reviewed by Maciej Stachowiak.

On watchOS, the backlight changed notification is registered in WebProcessPool::registerNotificationObservers(),
but not unregistered in WebProcessPool::unregisterNotificationObservers().

API test: WebKit.BacklightLevelNotificationCrash

* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::unregisterNotificationObservers):

Tools:

Reviewed by Maciej Stachowiak.

Add a test which tests that posting a backlight level change notification will not cause a crash.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit/BacklightLevelNotification.mm: Added.
(TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[WebCore] Shrink Vectors passed to SharedBuffer
basuke.suzuki@sony.com [Mon, 10 Feb 2020 23:17:18 +0000 (23:17 +0000)]
[WebCore] Shrink Vectors passed to SharedBuffer
https://bugs.webkit.org/show_bug.cgi?id=207503

Reviewed by Yusuke Suzuki.

Once SharedBuffer::DataSegment is created, the content won't change in its life cycle. Shrink the passed vector
before assigning to member variable to save space.

With the quick research, when displaying Apple's website, 1~3% RSS usage reduction on PlayStation port.

No new tests because there's no behavior change.

* platform/SharedBuffer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months agoREGRESSION: [ Win ] ( r254044 ) css1/box_properties/padding_left.html is failing
antti@apple.com [Mon, 10 Feb 2020 23:14:39 +0000 (23:14 +0000)]
REGRESSION: [ Win ] ( r254044 ) css1/box_properties/padding_left.html is failing
https://bugs.webkit.org/show_bug.cgi?id=207480
<rdar://problem/59316463>

Unreviewed test gardening.

* platform/win/css1/box_properties/padding_left-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months agoREGRESSION (r246055): Data detected URLs are no longer blue
timothy@apple.com [Mon, 10 Feb 2020 22:40:26 +0000 (22:40 +0000)]
REGRESSION (r246055): Data detected URLs are no longer blue
https://bugs.webkit.org/show_bug.cgi?id=207490
rdar://problem/58760796

Reviewed by Tim Horton.

This matches how the old code ended up working, since the old approach inlined the blue link color when
"shouldUseLightLinks" was false. This change allows the link style color to naturally apply as expected.
DD only uses light links when the category is "link" or "phone number" and not in the email signature.

* editing/cocoa/DataDetection.mm:
(WebCore::DataDetection::detectContentInRange): Only set color: currentColor when setting underline color.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months agoStandard gamepad mapping for GameControllerGamepads
commit-queue@webkit.org [Mon, 10 Feb 2020 22:38:22 +0000 (22:38 +0000)]
Standard gamepad mapping for GameControllerGamepads
https://bugs.webkit.org/show_bug.cgi?id=206033

Patch by James Howard <jameshoward@mac.com> on 2020-02-10
Reviewed by Dean Jackson.
Source/WebCore:

Extend PlatformGamepad to add a field for the gamepad mapping.
The mapping defines the order and interpretation of the axes and
buttons vectors, and is passed along to users of the Gamepad
API[1].

Letting PlatformGamepad subclassers define their mapping is the
natural place for this functionality. The PlatformGamepad
already defines the order of the axes and buttons and
PlatformGamepad subclassers may know something about the
physical layout of the gamepad they represent.

This change modifies the GameControllerGamepad subclass of
PlatformGamepad to set the mapping to "standard" when a
GCExtendedGamepad is detected, and to bind the axes and buttons
appropriately. Previously, the buttons and axes were bound
arbitrarily, and in some cases incompletely. While that wasn't a
bug per se, because with the mapping set to the empty string an
implementation is free to provide any interpretation of the
gamepad elements it likes, it was certainly less useful than the
"standard" mapping.

[1] https://www.w3.org/TR/gamepad/#remapping

* Modules/gamepad/Gamepad.cpp:
(WebCore::Gamepad::Gamepad):
* platform/gamepad/PlatformGamepad.h:
(WebCore::PlatformGamepad::mapping const):
* platform/gamepad/cocoa/GameControllerGamepad.mm:
(WebCore::GameControllerGamepad::setupAsExtendedGamepad):
* testing/MockGamepad.cpp:
(WebCore::MockGamepad::MockGamepad):
(WebCore::MockGamepad::updateDetails):
* testing/MockGamepad.h:
* testing/MockGamepadProvider.cpp:
(WebCore::MockGamepadProvider::setMockGamepadDetails):
* testing/MockGamepadProvider.h:
* testing/js/WebCoreTestSupport.cpp:
(WebCoreTestSupport::setMockGamepadDetails):
* testing/js/WebCoreTestSupport.h:

Source/WebKit:

Make the mapping as provided by PlatformGamepad
available in UIGamepad, and pass it along to
GamepadData so it can be correctly reflected
in the Gamepad API.

* Shared/Gamepad/GamepadData.cpp:
(WebKit::GamepadData::GamepadData):
(WebKit::GamepadData::encode const):
(WebKit::GamepadData::decode):
* Shared/Gamepad/GamepadData.h:
(WebKit::GamepadData::mapping const):
* UIProcess/Gamepad/UIGamepad.cpp:
(WebKit::UIGamepad::UIGamepad):
(WebKit::UIGamepad::fullGamepadData const):
* UIProcess/Gamepad/UIGamepad.h:
* WebProcess/Gamepad/WebGamepad.cpp:
(WebKit::WebGamepad::WebGamepad):

Tools:

* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setMockGamepadDetails):
* WebKitTestRunner/InjectedBundle/TestRunner.h:
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

LayoutTests:

* gamepad/gamepad-polling-access-expected.txt:
* gamepad/gamepad-polling-access.html:
* gamepad/gamepad-timestamp.html:
* gamepad/gamepad-visibility-1.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months agoWebContent jetsams on Sony lens webpage due to spike of IOSurfaces
simon.fraser@apple.com [Mon, 10 Feb 2020 22:27:47 +0000 (22:27 +0000)]
WebContent jetsams on Sony lens webpage due to spike of IOSurfaces
https://bugs.webkit.org/show_bug.cgi?id=207493
rdar://problem/59020443

Reviewed by Zalan Bujtas.
Source/WebCore:

There were three issues that contributed to massive backing store allocation on
<https://www.sony.com/electronics/lenses/t/camera-lenses>.

The first, fixed in r256095, was that the Web Animations code unioned the untransitioning
bounds with the transitioning bounds, causing the computation of large extent rects.

The second, fixed in r256181, was that GraphicsLayerCA would keep hold of a transform
animation for an extra frame, causing a rendering update where
RenderLayerBacking::updateGeometry() would have cleared the extent, but GraphicsLayerCA
still thought transform was animating, causing GraphicsLayerCA::updateCoverage() to keep
backing store attached.

This patch is the final fix; when animations start and end, we need to ensure that
RenderLayerBacking::updateGeometry() is called so that we compute the animation extent in
the same frame that adds the animation.

Test: compositing/backing/transition-extent.html

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::startAnimation):
(WebCore::RenderLayerBacking::animationFinished):

LayoutTests:

Test with an out-of-view transitioning element which should not get backing store.

* compositing/backing/transition-extent-expected.txt: Added.
* compositing/backing/transition-extent.html: Added.
* platform/ios-wk2/compositing/backing/transition-extent-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[ Mac Debug wk2 ] imported/w3c/web-platform-tests/fetch/api/request/destination/fetch...
lawrence.j@apple.com [Mon, 10 Feb 2020 22:24:08 +0000 (22:24 +0000)]
[ Mac Debug wk2 ] imported/w3c/web-platform-tests/fetch/api/request/destination/fetch-destination-worker.https.html is flaky crashing.
https://bugs.webkit.org/show_bug.cgi?id=207509

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[ews] Display flaky layout test names in build summary
aakash_jain@apple.com [Mon, 10 Feb 2020 22:08:58 +0000 (22:08 +0000)]
[ews] Display flaky layout test names in build summary
https://bugs.webkit.org/show_bug.cgi?id=207504

Reviewed by Jonathan Bedard.

* BuildSlaveSupport/ews-build/steps.py:
(ReRunWebKitTests.evaluateCommand): Drive-by fix to correct the pluralization.
(AnalyzeLayoutTestsResults.report_pre_existing_failures): Append the flaky failure information.
(AnalyzeLayoutTestsResults.start):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[ Mac wk2 ] webgpu/whlsl/textures-load.html is flaky failing.
lawrence.j@apple.com [Mon, 10 Feb 2020 22:08:49 +0000 (22:08 +0000)]
[ Mac wk2 ] webgpu/whlsl/textures-load.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=207508

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[ iOS wk2 ] http/wpt/cache-storage/cache-put-keys.https.any.html is flaky failing.
lawrence.j@apple.com [Mon, 10 Feb 2020 21:35:12 +0000 (21:35 +0000)]
[ iOS wk2 ] http/wpt/cache-storage/cache-put-keys.https.any.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=207496

Unreviewed test gardening.

* platform/ios-simulator-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months agoFolloup to r256193 to set the proper ImageOnlyFailure expectation.
tsavell@apple.com [Mon, 10 Feb 2020 21:29:21 +0000 (21:29 +0000)]
Folloup to r256193 to set the proper ImageOnlyFailure expectation.
https://bugs.webkit.org/show_bug.cgi?id=207477

unreviewed test gardening.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[ Win ] (r255593) webanimations/transform-accelerated-animation-finishes-before-remov...
tsavell@apple.com [Mon, 10 Feb 2020 21:27:53 +0000 (21:27 +0000)]
[ Win ] (r255593) webanimations/transform-accelerated-animation-finishes-before-removal.html is failing
https://bugs.webkit.org/show_bug.cgi?id=207499

Unreviewed test gardening.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months agoDon't update selection when calling setSelectionRange on a disconnected input element
rniwa@webkit.org [Mon, 10 Feb 2020 21:23:12 +0000 (21:23 +0000)]
Don't update selection when calling setSelectionRange on a disconnected input element
https://bugs.webkit.org/show_bug.cgi?id=207357

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

Rebaselined the test that progressed a little. The test now passes offset checks but still fails direction check.

* web-platform-tests/html/semantics/forms/textfieldselection/selection-not-application-textarea-expected.txt:

Source/WebCore:

Don't update FrameSelection when the text form control element is disconnected from document.

* html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::setSelectionRange):

LayoutTests:

Rebaselined the test that has progressed with this change.

* platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/type-change-state-expected.txt:
* platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/type-change-state-expected.txt:
* platform/mac/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/type-change-state-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[ews] Use SetBuildSummary instead of buildFinished in Layout tests
aakash_jain@apple.com [Mon, 10 Feb 2020 21:14:39 +0000 (21:14 +0000)]
[ews] Use SetBuildSummary instead of buildFinished in Layout tests
https://bugs.webkit.org/show_bug.cgi?id=207492

Reviewed by Jonathan Bedard.

* BuildSlaveSupport/ews-build/steps.py:
(RunWebKitTests.evaluateCommand):
(ReRunWebKitTests.evaluateCommand):
(AnalyzeLayoutTestsResults.report_pre_existing_failures):
* BuildSlaveSupport/ews-build/factories.py:
(TestFactory.__init__):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[ Win ] (r255383) webanimations/width-and-opacity-separate-animation-yields-compositi...
tsavell@apple.com [Mon, 10 Feb 2020 21:06:45 +0000 (21:06 +0000)]
[ Win ] (r255383) webanimations/width-and-opacity-separate-animation-yields-compositing.html is failing
https://bugs.webkit.org/show_bug.cgi?id=207495

Unreviewed test gardening.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months agoUnreviewed, speculative build fix on watchOS simulator
ysuzuki@apple.com [Mon, 10 Feb 2020 20:51:45 +0000 (20:51 +0000)]
Unreviewed, speculative build fix on watchOS simulator
https://bugs.webkit.org/show_bug.cgi?id=207183

* wtf/HashTable.h:
(WTF::HashTableCapacityForSize::capacityForSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months agoPlacate exception check validator in GenericArguments<Type>::put().
mark.lam@apple.com [Mon, 10 Feb 2020 20:40:00 +0000 (20:40 +0000)]
Placate exception check validator in GenericArguments<Type>::put().
https://bugs.webkit.org/show_bug.cgi?id=207485
<rdar://problem/59302535>

Reviewed by Robin Morisset.

JSTests:

* stress/placate-exception-check-validator-in-GenericArguments-put.js: Added.

Source/JavaScriptCore:

* runtime/GenericArgumentsInlines.h:
(JSC::GenericArguments<Type>::put):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[WebAuthn] Merge some of the CTAP response decoder's code
jiewen_tan@apple.com [Mon, 10 Feb 2020 20:26:04 +0000 (20:26 +0000)]
[WebAuthn] Merge some of the CTAP response decoder's code
https://bugs.webkit.org/show_bug.cgi?id=205375

Reviewed by Darin Adler.

This patch makes those code more compact and maintainable.

No change of behaviors.

* Modules/webauthn/fido/DeviceResponseConverter.cpp:
(fido::decodeResponseMap):
(fido::readCTAPMakeCredentialResponse):
(fido::readCTAPGetAssertionResponse):
(fido::readCTAPGetInfoResponse):
* Modules/webauthn/fido/DeviceResponseConverter.h:
* Modules/webauthn/fido/Pin.cpp:
(fido::pin::encodePinCommand):
(fido::pin::RetriesResponse::parse):
(fido::pin::KeyAgreementResponse::parse):
(fido::pin::TokenResponse::parse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[CMake] Prepend -Wno-noexcept-type only to global CXX flags
commit-queue@webkit.org [Mon, 10 Feb 2020 20:24:03 +0000 (20:24 +0000)]
[CMake] Prepend -Wno-noexcept-type only to global CXX flags
https://bugs.webkit.org/show_bug.cgi?id=207468

Patch by Michael Catanzaro <mcatanzaro@gnome.org> on 2020-02-10
Reviewed by Adrian Perez de Castro.

-Wno-noexcept-type is a C++-specific flag that should not be passed to the C compiler. This
causes a warning spam in GCC 10.

* Source/cmake/WebKitCompilerFlags.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months agoarm64_32: microbenchmarks/delete-property-keeps-cacheable-structure.js is timing out
justin_michaud@apple.com [Mon, 10 Feb 2020 20:09:45 +0000 (20:09 +0000)]
arm64_32: microbenchmarks/delete-property-keeps-cacheable-structure.js is timing out
https://bugs.webkit.org/show_bug.cgi?id=207484

Reviewed by Yusuke Suzuki.

* microbenchmarks/delete-property-keeps-cacheable-structure.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months agoMissing exception check in GenericArguments<Type>::deletePropertyByIndex().
mark.lam@apple.com [Mon, 10 Feb 2020 19:47:58 +0000 (19:47 +0000)]
Missing exception check in GenericArguments<Type>::deletePropertyByIndex().
https://bugs.webkit.org/show_bug.cgi?id=207483
<rdar://problem/59302616>

Reviewed by Yusuke Suzuki.

JSTests:

* stress/missing-exception-check-in-GenericArguments-deletePropertyByIndex.js: Added.

Source/JavaScriptCore:

* runtime/GenericArgumentsInlines.h:
(JSC::GenericArguments<Type>::deletePropertyByIndex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months agoREGRESSION: (256055) http/tests/resourceLoadStatistics/log-cross-site-load-with-link...
katherine_cheney@apple.com [Mon, 10 Feb 2020 19:36:42 +0000 (19:36 +0000)]
REGRESSION: (256055) http/tests/resourceLoadStatistics/log-cross-site-load-with-link-decoration.html is failing
https://bugs.webkit.org/show_bug.cgi?id=207479
<rdar://problem/59316238>

Unreviewed test gardening

* http/tests/resourceLoadStatistics/log-cross-site-load-with-link-decoration-expected.txt:
* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months agoRename SelectionData classes and structures HighlightData, etc to be more inclusive...
megan_gardner@apple.com [Mon, 10 Feb 2020 19:32:19 +0000 (19:32 +0000)]
Rename SelectionData classes and structures HighlightData, etc to be more inclusive for their new use cases
https://bugs.webkit.org/show_bug.cgi?id=206340

Reviewed by Ryosuke Niwa.

Rename only, no behaviour change.

With the new Highlight API, we will be using these data structures to support Highlights as well as Selection,
rename to Highlight, as a Selection is a type of Highlight.

* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* platform/DragImage.cpp:
(WebCore::ScopedFrameSelectionState::~ScopedFrameSelectionState):
(WebCore::createDragImageForRange):
* rendering/ComplexLineLayout.cpp:
(WebCore::ComplexLineLayout::constructLine):
* rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::paint):
* rendering/EllipsisBox.h:
* rendering/HighlightData.cpp: Renamed from Source/WebCore/rendering/SelectionRangeData.cpp.
(WebCore::isValidRendererForSelection):
(WebCore::collect):
(WebCore::HighlightData::HighlightData):
(WebCore::HighlightData::setRenderRange):
(WebCore::HighlightData::selectionStateForRenderer):
(WebCore::HighlightData::set):
(WebCore::HighlightData::clear):
(WebCore::HighlightData::repaint const):
(WebCore::HighlightData::collectBounds const):
(WebCore::HighlightData::apply):
* rendering/HighlightData.h: Renamed from Source/WebCore/rendering/SelectionRangeData.h.
(WebCore::HighlightData::RenderRange::RenderRange):
(WebCore::HighlightData::RenderRange::operator== const):
(WebCore::HighlightData::get const):
(WebCore::HighlightData::start const):
(WebCore::HighlightData::end const):
(WebCore::HighlightData::startOffset const):
(WebCore::HighlightData::endOffset const):
* rendering/InlineBox.cpp:
(WebCore::InlineBox::selectionState):
* rendering/InlineBox.h:
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::selectionState):
* rendering/InlineFlowBox.h:
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::selectionState):
(WebCore::InlineTextBox::verifySelectionState const):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::clampedStartEndForState const):
(WebCore::InlineTextBox::highlightStartEnd const):
(WebCore::InlineTextBox::collectMarkedTextsForHighlights const):
* rendering/InlineTextBox.h:
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::shouldPaintSelectionGaps const):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::blockSelectionGaps):
(WebCore::RenderBlock::getSelectionGapInfo):
* rendering/RenderBlock.h:
* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::setSelectionState):
(WebCore::RenderBlockFlow::inlineSelectionGaps):
* rendering/RenderBlockFlow.h:
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::setSelectionState):
* rendering/RenderBoxModelObject.h:
* rendering/RenderLineBreak.cpp:
(WebCore::RenderLineBreak::setSelectionState):
* rendering/RenderLineBreak.h:
* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::paint):
(WebCore::RenderListMarker::setSelectionState):
(WebCore::RenderListMarker::selectionRectForRepaint):
* rendering/RenderListMarker.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::isSelectionBorder const):
* rendering/RenderObject.h:
(WebCore::RenderObject::selectionState const):
(WebCore::RenderObject::setSelectionState):
(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
(WebCore::RenderObject::RenderObjectBitfields::selectionState const):
(WebCore::RenderObject::RenderObjectBitfields::setSelectionState):
(WebCore::RenderObject::setSelectionStateIfNeeded):
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::shouldDrawSelectionTint const):
(WebCore::RenderReplaced::paint):
(WebCore::RenderReplaced::setSelectionState):
(WebCore::RenderReplaced::isSelected const):
* rendering/RenderReplaced.h:
* rendering/RenderSelectionInfo.h:
(WebCore::RenderSelectionInfoBase::state const):
* rendering/RenderText.cpp:
(WebCore::RenderText::setSelectionState):
(WebCore::RenderText::collectSelectionRectsForLineBoxes):
* rendering/RenderText.h:
* rendering/RenderTextLineBoxes.cpp:
(WebCore::RenderTextLineBoxes::setSelectionState):
* rendering/RenderTextLineBoxes.h:
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintAttachment):
* rendering/RenderView.h:
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setSelectionState):
* rendering/RenderWidget.h:
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::lineSelectionGap):
(WebCore::RootInlineBox::selectionState):
(WebCore::RootInlineBox::firstSelectedBox):
(WebCore::RootInlineBox::lastSelectedBox):
(WebCore::RootInlineBox::selectionTopAdjustedForPrecedingBlock const):
* rendering/RootInlineBox.h:
* rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseForWithReason):
* rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::paintSelectionBackground):
(WebCore::SVGInlineTextBox::paint):
* rendering/svg/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months agoREGRESSION: [ Win ] css1/box_properties/padding_left.html is failing
tsavell@apple.com [Mon, 10 Feb 2020 18:49:57 +0000 (18:49 +0000)]
REGRESSION: [ Win ] css1/box_properties/padding_left.html is failing
https://bugs.webkit.org/show_bug.cgi?id=207480

Unreviewed test gardening

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months agoUnreviewed, fix build failure on watchOS simulator
ysuzuki@apple.com [Mon, 10 Feb 2020 18:35:02 +0000 (18:35 +0000)]
Unreviewed, fix build failure on watchOS simulator
https://bugs.webkit.org/show_bug.cgi?id=207183

* wtf/HashTable.h:
(WTF::HashTableCapacityForSize::capacityForSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months agoREGRESSION: [ Win ] animations/stacking-context-not-fill-forwards.html is failing
tsavell@apple.com [Mon, 10 Feb 2020 18:25:58 +0000 (18:25 +0000)]
REGRESSION: [ Win ] animations/stacking-context-not-fill-forwards.html is failing
https://bugs.webkit.org/show_bug.cgi?id=207477

unreviewed test gardening.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months agoUnreachable code hit in WebCore::Shape::createShape
said@apple.com [Mon, 10 Feb 2020 18:21:56 +0000 (18:21 +0000)]
Unreachable code hit in WebCore::Shape::createShape
https://bugs.webkit.org/show_bug.cgi?id=207399

Reviewed by Darin Adler.

Source/WebCore:

CSS parser should not consume the 'shape-outside' property with type 'path'
since it has not been implemented yet. This will prevent an assertion in
the debug build and null dref in the release build.

Test: css3/shapes/shape-outside-path-no-crash.html

* css/parser/CSSPropertyParser.cpp:
(WebCore::consumeBasicShape):
(WebCore::consumeShapeOutside):

LayoutTests:

* css3/shapes/shape-outside-path-no-crash-expected.txt: Added.
* css3/shapes/shape-outside-path-no-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months agoDisallow setting base URL to a data or JavaScript URL
dbates@webkit.org [Mon, 10 Feb 2020 18:16:49 +0000 (18:16 +0000)]
Disallow setting base URL to a data or JavaScript URL
https://bugs.webkit.org/show_bug.cgi?id=207136

Source/WebCore:

Reviewed by Brent Fulgham.

Inspired by <https://bugs.chromium.org/p/chromium/issues/detail?id=679318>.

Block setting the base URL to a data URL or JavaScript URL as such usage is questionable.
This makes WebKit match the behavior of Chrome and Firefox and is in the spirit of the
discussion in <https://github.com/whatwg/html/issues/2249>.

On Mac and iOS, this restriction is applied only to apps linked against a future SDK to
avoid breaking shipped apps.

For all other ports, this restriction is enabled by default.

Tests: fast/url/relative2.html
       fast/url/segments-from-data-url2.html
       http/tests/security/allowed-base-url-data-url-via-setting.html
       http/tests/security/denied-base-url-data-url.html
       http/tests/security/denied-base-url-javascript-url.html

* dom/Document.cpp:
(WebCore::Document::processBaseElement): Condition updating the parsed
base URL on whether is has an allowed scheme, if restrictions are enabled. Otherwise,
do what we do now. If the scheme is disallowed then log a message to the console to
explain this to web developers.
* html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::scan): Pass whether to apply restrictons to the base URL
to updatePredictedBaseURL(). This depends on whether the setting is enabled or not.
(WebCore::TokenPreloadScanner::updatePredictedBaseURL): Modifed to take a boolean as to
whether to apply restrictions. If restrictions are not to be applied do what we do now.
Otherwise, only do what we do now if the scheme for the predicated base URL is allowed.
* html/parser/HTMLPreloadScanner.h:
* page/SecurityPolicy.cpp:
(WebCore::SecurityPolicy::isBaseURLSchemeAllowed): Added.
* page/SecurityPolicy.h:
* page/Settings.yaml: Add a setting to toggle restrictions on the base URL scheme.

Source/WebKit:

Reviewed by Brent Fulgham.

Apply base URL restrictions to apps linked to a future WebKit to avoid breaking existing apps.

* Shared/WebPreferences.yaml:
* UIProcess/API/Cocoa/WKWebView.mm:
(shouldRestrictBaseURLSchemes): Added.
(-[WKWebView _setupPageConfiguration:]): Update settings.
* UIProcess/Cocoa/VersionChecks.h:

Source/WebKitLegacy/mac:

Reviewed by Brent Fulgham.

Apply base URL restrictions to apps linked to a future WebKit to avoid breaking existing apps.

* Misc/WebKitVersionChecks.h:
* WebView/WebView.mm:
(shouldRestrictBaseURLSchemes): Added.
(-[WebView _commonInitializationWithFrameName:groupName:]): Update settings.

Source/WTF:

Reviewed by Brent Fulgham.

Add some more macro definitions.

* wtf/spi/darwin/dyldSPI.h:

LayoutTests:

RReviewed by Brent Fulgham.

Add some tests. Update others to toggle the setting to apply or unapply the new behavior.

The test denied-base-url-javascript-url.html is derived from the test base-url-javascript.html,
included in <https://chromium.googlesource.com/chromium/src.git/+/c133efa0b915430701930b76a7cfe35608b9a403>.

* fast/url/relative-expected.txt:
* fast/url/relative.html:
* fast/url/relative2-expected.txt: Copied from LayoutTests/fast/url/relative-expected.txt.
* fast/url/relative2.html: Copied from LayoutTests/fast/url/relative.html.
* fast/url/resources/utilities.js:
(setShouldEllipsizeFileURLPaths): Added. Toggles ellipsizing the path portion of a file URL to simplify matching.
Otherwise, file URLs could be machine-specific.
(canonicalizedPathname): Added.
(segments): Modified to optionally call canonicalizedPathname.
(canonicalize): Ditto.
* fast/url/segments-from-data-url-expected.txt:
* fast/url/segments-from-data-url.html:
* fast/url/segments-from-data-url2-expected.txt: Copied from LayoutTests/fast/url/segments-from-data-url-expected.txt.
* fast/url/segments-from-data-url2.html: Copied from LayoutTests/fast/url/segments-from-data-url.html.
* fetch/fetch-url-serialization-expected.txt:
* http/tests/plugins/navigation-during-load-embed.html:
* http/tests/plugins/navigation-during-load.html:
* http/tests/security/allowed-base-url-data-url-via-setting-expected.txt: Added.
* http/tests/security/allowed-base-url-data-url-via-setting.html: Added.
* http/tests/security/denied-base-url-data-url-expected.txt: Added.
* http/tests/security/denied-base-url-data-url.html: Added.
* http/tests/security/denied-base-url-javascript-url-expected.txt: Added.
* http/tests/security/denied-base-url-javascript-url.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[ macOS wk2 ] webgpu/whlsl/store-to-property-updates-properly.html is flaky failing
jacob_uphoff@apple.com [Mon, 10 Feb 2020 18:14:15 +0000 (18:14 +0000)]
[ macOS wk2 ] webgpu/whlsl/store-to-property-updates-properly.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=207476

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months agoRegression (r255961): fast/loader/data-url-load-denied.html is consistently timing...
tsavell@apple.com [Mon, 10 Feb 2020 18:08:43 +0000 (18:08 +0000)]
Regression (r255961): fast/loader/data-url-load-denied.html is consistently timing out on windows
https://bugs.webkit.org/show_bug.cgi?id=207373

Unreviewed test gardening.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[ macOS wk2 ] http/tests/cache-storage/cache-records-persistency.https.html is flaky...
jacob_uphoff@apple.com [Mon, 10 Feb 2020 18:00:06 +0000 (18:00 +0000)]
[ macOS wk2 ] http/tests/cache-storage/cache-records-persistency.https.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=207474

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months agoCrash under WebProcessProxy::shouldSendPendingMessage()
cdumez@apple.com [Mon, 10 Feb 2020 17:57:30 +0000 (17:57 +0000)]
Crash under WebProcessProxy::shouldSendPendingMessage()
https://bugs.webkit.org/show_bug.cgi?id=207464
<rdar://problem/59293825>

Reviewed by Alex Christensen.

I suspect the WebProcessProxy object is getting destroyed as we are iterating over the
pending messages in AuxiliaryProcessProxy::didFinishLaunching(), thus crashing when
calling WebProcessProxy::shouldSendPendingMessage() inside the loop. As a speculative
fix, protect |this| at the beginning of WebProcessProxy::didFinishLaunching().

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didFinishLaunching):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[ macOS wk1 ] imported/w3c/web-platform-tests/workers/WorkerGlobalScope_ErrorEvent_co...
jacob_uphoff@apple.com [Mon, 10 Feb 2020 17:36:53 +0000 (17:36 +0000)]
[ macOS wk1 ] imported/w3c/web-platform-tests/workers/WorkerGlobalScope_ErrorEvent_colno.htm is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=207470

Unreviewed test gardening.

* platform/mac-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months agoUse ObjectIdentifier for WebRTC resolvers
youenn@apple.com [Mon, 10 Feb 2020 17:29:45 +0000 (17:29 +0000)]
Use ObjectIdentifier for WebRTC resolvers
https://bugs.webkit.org/show_bug.cgi?id=207381

Reviewed by Eric Carlson.

Use ObjectIdentifier instead of uint64_t which gives type safety and ensures we do not receive wrong identifiers from IPC.
No change of behavior.

* NetworkProcess/webrtc/NetworkRTCProvider.cpp:
(WebKit::NetworkRTCProvider::close):
(WebKit::NetworkRTCProvider::createResolver):
Remove empty string check case since DNS resolver should be robust to null/empty strings.
(WebKit::NetworkRTCProvider::stopResolver):
* NetworkProcess/webrtc/NetworkRTCProvider.h:
* NetworkProcess/webrtc/NetworkRTCProvider.messages.in:
* NetworkProcess/webrtc/NetworkRTCResolver.cpp:
(WebKit::NetworkRTCResolver::create):
(WebKit::NetworkRTCResolver::NetworkRTCResolver):
(WebKit::NetworkRTCResolver::start):
(WebKit::NetworkRTCResolver::stop):
* NetworkProcess/webrtc/NetworkRTCResolver.h:
* NetworkProcess/webrtc/NetworkRTCResolverCocoa.cpp:
(WebKit::NetworkRTCResolver::create):
(WebKit::NetworkRTCResolverCocoa::NetworkRTCResolverCocoa):
* NetworkProcess/webrtc/NetworkRTCResolverCocoa.h:
* Scripts/webkit/messages.py:
* WebKit.xcodeproj/project.pbxproj:
* WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::didReceiveMessage):
* WebProcess/Network/webrtc/LibWebRTCNetwork.h:
(WebKit::LibWebRTCNetwork::resolver):
* WebProcess/Network/webrtc/LibWebRTCResolver.cpp:
(WebKit::LibWebRTCResolver::Start):
(WebKit::LibWebRTCResolver::Destroy):
* WebProcess/Network/webrtc/LibWebRTCResolver.h:
* WebProcess/Network/webrtc/LibWebRTCResolverIdentifier.h: Copied from Source/WebKit/WebProcess/Network/webrtc/WebRTCResolver.h.
* WebProcess/Network/webrtc/LibWebRTCSocketFactory.cpp:
(WebKit::LibWebRTCSocketFactory::createAsyncResolver):
* WebProcess/Network/webrtc/LibWebRTCSocketFactory.h:
(WebKit::LibWebRTCSocketFactory::resolver):
(WebKit::LibWebRTCSocketFactory::takeResolver):
* WebProcess/Network/webrtc/WebRTCResolver.cpp:
(WebKit::WebRTCResolver::WebRTCResolver):
* WebProcess/Network/webrtc/WebRTCResolver.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months agoUnreviewed, rolling out r256091.
tsavell@apple.com [Mon, 10 Feb 2020 17:28:29 +0000 (17:28 +0000)]
Unreviewed, rolling out r256091.

Broke internal builds

Reverted changeset:

"Move trivial definitions from FeatureDefines.xcconfig to
PlatformEnableCocoa.h"
https://bugs.webkit.org/show_bug.cgi?id=207155
https://trac.webkit.org/changeset/256091

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months agoUnreviewed, rolling out r256103.
tsavell@apple.com [Mon, 10 Feb 2020 17:26:55 +0000 (17:26 +0000)]
Unreviewed, rolling out r256103.

This patch is blocking the rollout of r256091

Reverted changeset:

"Move JavaScriptCore related feature defines from
FeatureDefines.xcconfig to PlatformEnableCocoa.h"
https://bugs.webkit.org/show_bug.cgi?id=207436
https://trac.webkit.org/changeset/256103

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[ macOS wk1 ] imported/w3c/web-platform-tests/svg/animations/slider-switch.html is...
jacob_uphoff@apple.com [Mon, 10 Feb 2020 17:25:50 +0000 (17:25 +0000)]
[ macOS wk1 ] imported/w3c/web-platform-tests/svg/animations/slider-switch.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=207469

Unreviewed test gardening.

* platform/mac-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months agoThere's an event loop cycle between an animation finishing, and it being removed...
graouts@webkit.org [Mon, 10 Feb 2020 17:24:49 +0000 (17:24 +0000)]
There's an event loop cycle between an animation finishing, and it being removed from GraphicsLayerCA
https://bugs.webkit.org/show_bug.cgi?id=207361
<rdar://problem/59280370>

Reviewed by Simon Fraser.

Source/WebCore:

Animations should be removed from GraphicsLayersCAs in the same rendering update that changes the playState of the
animation to "finished", to avoid layer flush where a GraphicsLayersCAs has no extent set, but thinks there is
an active transform animation.

To do this, instead of enqueuing accelerated actions when resolving animations during style resolution, in
KeyframeAnimation::apply(), we enqueue them as soon as an animation's current time may have changed: in
WebAnimation::tick() and WebAnimation::play() with supporting functions newly exposed on AnimationEffect.

Now, accelerated animations are enqueued and applied during the "update animations and send events" procedure.

* animation/AnimationEffect.h:
* animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::apply):
(WebCore::KeyframeEffect::updateAcceleratedActions):
(WebCore::KeyframeEffect::animationDidTick):
(WebCore::KeyframeEffect::animationDidPlay):
* animation/KeyframeEffect.h:
* animation/WebAnimation.cpp:
(WebCore::WebAnimation::play):
(WebCore::WebAnimation::tick):

LayoutTests:

Lower the number of frames to wait after an animation completes by one to check that the accelerated animation has been removed
to show that we enqueue accelerated actions as part of the "update animations and send events" procedure.

* webanimations/accelerated-animation-removal-upon-transition-completion.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[ macOS iOS wk2 ] http/wpt/service-workers/service-worker-networkprocess-crash.html...
jacob_uphoff@apple.com [Mon, 10 Feb 2020 17:13:52 +0000 (17:13 +0000)]
[ macOS iOS wk2 ] http/wpt/service-workers/service-worker-networkprocess-crash.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=207466

Unreviewed test gardening.

* platform/ios-wk2/TestExpectations:
* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[Web Animations] Fix animations/stop-animation-on-suspend.html
graouts@webkit.org [Mon, 10 Feb 2020 17:11:13 +0000 (17:11 +0000)]
[Web Animations] Fix animations/stop-animation-on-suspend.html
https://bugs.webkit.org/show_bug.cgi?id=184580
<rdar://problem/39406014>

Reviewed by Simon Fraser.

The expectations of this test were incorrect. The test animates a transform from 0 to 400px across 400ms with a linear timing function. The test suspends
animations from 100ms to 300ms with timers, and polls animations at 200ms and 400ms. At 200ms, it expects a value of 100px, which is correct since the animation
is suspended and so the value at 100ms (when it was suspended) is expected.

However, the test expected the value at 400ms to be 200px, which leads me to think this test assumes that animations, when resumed, account for the time suspended
and subtracts it from the page time. This is incorrect: when animations resume, they resume at the current time, no matter how long they were suspended. So the expected
value should be 400px.

* animations/stop-animation-on-suspend-expected.txt:
* animations/stop-animation-on-suspend.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[ macOS iOS wk2 ] storage/indexeddb/intversion-long-queue.html is a flaky failure.
jacob_uphoff@apple.com [Mon, 10 Feb 2020 16:54:31 +0000 (16:54 +0000)]
[ macOS iOS wk2 ] storage/indexeddb/intversion-long-queue.html is a flaky failure.
https://bugs.webkit.org/show_bug.cgi?id=207465

Unreviewed test gardening.

* platform/ios-wk2/TestExpectations:
* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[ macOS ] inspector/runtime/getCollectionEntries.html is flaky failing
jacob_uphoff@apple.com [Mon, 10 Feb 2020 16:37:27 +0000 (16:37 +0000)]
[ macOS ] inspector/runtime/getCollectionEntries.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=207463

Unreviewed test gardening

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months agoRegression (~r252261): [ Mac wk2 ] inspector/heap/getPreview.html is flaky failing
jacob_uphoff@apple.com [Mon, 10 Feb 2020 16:20:06 +0000 (16:20 +0000)]
Regression (~r252261): [ Mac wk2 ] inspector/heap/getPreview.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=207209

Correcting test expectations.

Unreviewed test gardening

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months agoMake FormDataElement::lengthInBytes() safe to call on a non-main thread
cdumez@apple.com [Mon, 10 Feb 2020 16:17:32 +0000 (16:17 +0000)]
Make FormDataElement::lengthInBytes() safe to call on a non-main thread
https://bugs.webkit.org/show_bug.cgi?id=207419
<rdar://problem/54386521>

Reviewed by Youenn Fablet.

Make FormDataElement::lengthInBytes() safe to call on a non-main thread by using the
ThreadableBlobRegistry. DOMCache code in workers may call this on worker threads for
example.

* platform/network/FormData.cpp:
(WebCore::FormDataElement::lengthInBytes const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months agoresults.webkit.org: Abstract archive storage solutions
jbedard@apple.com [Mon, 10 Feb 2020 16:10:22 +0000 (16:10 +0000)]
results.webkit.org: Abstract archive storage solutions
https://bugs.webkit.org/show_bug.cgi?id=207277

Rubber-stamped by Aakash Jain.

* resultsdbpy/resultsdbpy/model/archive_context.py:
(ArchiveContext):
(ArchiveContext.ArchiveMetaDataByCommit.unpack):
(ArchiveContext.__init__): Add archiver member.
(ArchiveContext.__enter__): archiver is a context manager.
(ArchiveContext.__exit__): Ditto.
(ArchiveContext.register): The archiver member owns saving an archive.
(ArchiveContext.find_archive): The archiver member owns retrieving an archive.
(ArchiveContext.ArchiveChunks): Move to CassandraArchiver.
* resultsdbpy/resultsdbpy/model/archiver.py: Added.
(Archiver): Base class for all Archiving systems.
(Archiver.archive_digest): Given a file-like archive, calculate it's digest.
(Archiver.archive_size): Given a file-like archive, calculate it's size.
(Archiver.save):
(Archiver.retrieve):
* resultsdbpy/resultsdbpy/model/cassandra_archiver.py: Added.
(CassandraArchiver):
(CassandraArchiver.ArchiveChunks): Moved from ArchiveContext.
(CassandraArchiver.__init__):
(CassandraArchiver.__enter__):
(CassandraArchiver.__exit__):
(CassandraArchiver.save): Split the provided archive into chunks for saving, moved
from ArchiveContext.
(CassandraArchiver.retrieve): Retrieve an archive with the provided hash, moved
from ArchiveContext.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[ macOS ] imported/w3c/web-platform-tests/wasm/jsapi/constructor/instantiate-bad...
jacob_uphoff@apple.com [Mon, 10 Feb 2020 16:02:36 +0000 (16:02 +0000)]
[ macOS ] imported/w3c/web-platform-tests/wasm/jsapi/constructor/instantiate-bad-imports.any.worker.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=207461

Unreviewed test gardening

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[ macOS wk2 ] webgpu/whlsl/buffer-vertex.html is flaky failing
jacob_uphoff@apple.com [Mon, 10 Feb 2020 15:46:01 +0000 (15:46 +0000)]
[ macOS wk2 ] webgpu/whlsl/buffer-vertex.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=207127

Correcting test expectations for ImageOnlyFailure

Unreviewed test gardening

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[ macOS wk2 ] webgpu/whlsl/separate-shader-modules/separate-shader-modules-7.html...
jacob_uphoff@apple.com [Mon, 10 Feb 2020 15:34:32 +0000 (15:34 +0000)]
[ macOS wk2 ] webgpu/whlsl/separate-shader-modules/separate-shader-modules-7.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=207460

Unreviewed test gardening

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[geolocation] Fix non-unified build issues
aperez@igalia.com [Mon, 10 Feb 2020 14:48:38 +0000 (14:48 +0000)]
[geolocation] Fix non-unified build issues
https://bugs.webkit.org/show_bug.cgi?id=207457

Unreviewed build fix.

No new tests needed.

* UIProcess/GeolocationPermissionRequestManagerProxy.h: Add missing includes.
* UIProcess/WebGeolocationManagerProxy.cpp: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months agoRemove setHTTPAccept call for main resources
commit-queue@webkit.org [Mon, 10 Feb 2020 14:01:19 +0000 (14:01 +0000)]
Remove setHTTPAccept call for main resources
https://bugs.webkit.org/show_bug.cgi?id=207441

Patch by Rob Buis <rbuis@igalia.com> on 2020-02-10
Reviewed by Darin Adler.

Remove setHTTPAccept call for main resources since all main resource loading goes
through CachedResourceLoader, which sets the Accept header as specified in:
https://fetch.spec.whatwg.org/#fetching (Step 1.3).

This patch also removed unused Accept header related functionality
in ResourceRequest.

No test since no change in behavior, tested by http/tests/misc/xhtml.php.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::addExtraFieldsToRequest):
* platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::httpAccept const): Deleted.
(WebCore::ResourceRequestBase::setHTTPAccept): Deleted.
(WebCore::ResourceRequestBase::clearHTTPAccept): Deleted.
* platform/network/ResourceRequestBase.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[GTK][WebInspector] Do not make Web Inspector windows transient
aperez@igalia.com [Mon, 10 Feb 2020 11:21:37 +0000 (11:21 +0000)]
[GTK][WebInspector] Do not make Web Inspector windows transient
https://bugs.webkit.org/show_bug.cgi?id=207455

Reviewed by Carlos Garcia Campos.

Stop setting Web Inspector windows as transient for the window
containing the web view being inspected, to allow changing their
relative stacking order. No changes are needed for inspector windows
to continue being destroyed correctly when the corresponding web view
is destroyed because code for handling that was already present in
WebInspectorProxyGtk.cpp.

No new tests needed.

* UIProcess/Inspector/gtk/RemoteWebInspectorProxyGtk.cpp:
(WebKit::RemoteWebInspectorProxy::platformCreateFrontendPageAndWindow):
Do not pass a parent window parameter to webkitInspectorWindowNew().
* UIProcess/Inspector/gtk/WebInspectorProxyGtk.cpp:
(WebKit::WebInspectorProxy::platformCreateFrontendWindow): Remove code
to obtain the top level window of the WebKitWebView, which no longer
needs being passed to webkitInspectorWindowNew().
* UIProcess/Inspector/gtk/WebKitInspectorWindow.cpp:
(webkitInspectorWindowNew): Do not set the GtkWindow.transient-for
property for the Web Inspector window. Remove the parent window
parameter.
* UIProcess/Inspector/gtk/WebKitInspectorWindow.h: Remove the parent
window parameter for webkitInspectorWindowNew().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 months ago[GTK] Mouse pointer no longer hidden during fullscreen video playback
eocanha@igalia.com [Mon, 10 Feb 2020 10:13:38 +0000 (10:13 +0000)]
[GTK] Mouse pointer no longer hidden during fullscreen video playback
https://bugs.webkit.org/show_bug.cgi?id=197346

Reviewed by Adrian Perez de Castro.

.:

Enabled the CURSOR_VISIBILITY feature on the GTK port.

* Source/cmake/OptionsGTK.cmake:

Source/WebKit:

Covered by existing tests.

* UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::setCursorHiddenUntilMouseMoves): Added implementation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256113 268f45cc-cd09-0410-ab3c-d52691b4dbfc