WebKit-https.git
7 years agoCorrected reviewer that webkit-patch got wrong.
msaboff@apple.com [Tue, 9 Oct 2012 14:48:49 +0000 (14:48 +0000)]
Corrected reviewer that webkit-patch got wrong.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAfter r130344, OpaqueJSString::identifier() adds wrapped String to identifier table
msaboff@apple.com [Tue, 9 Oct 2012 14:46:53 +0000 (14:46 +0000)]
After r130344, OpaqueJSString::identifier() adds wrapped String to identifier table
https://bugs.webkit.org/show_bug.cgi?id=98693
REGRESSION (r130344): Install failed in Install Environment
<rdar://problem/12450118>

Reviewed by Filip Pizlo.

Use Identifier(LChar*, length) or Identifier(UChar*, length) constructors so that we don't
add the String instance in the OpaqueJSString to any identifier tables.

* API/OpaqueJSString.cpp:
(OpaqueJSString::identifier):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed trivial Qt build fix: Remove stray closing braces from r130758.
hausmann@webkit.org [Tue, 9 Oct 2012 14:15:49 +0000 (14:15 +0000)]
Unreviewed trivial Qt build fix: Remove stray closing braces from r130758.

* qmake/mkspecs/features/features.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix build with QtMultimedia
hausmann@webkit.org [Tue, 9 Oct 2012 14:03:21 +0000 (14:03 +0000)]
[Qt] Fix build with QtMultimedia

Reviewed by Tor Arne Vestbø.

Source/WebCore:

This is an initial rudimentary port to of the QtMultimedia back-end,
adapted to slight API changes and (more importantly) to the
implementation of QAbstractVideoSurface instead of using
QGraphicsVideoItem (which is in QtMultimediaWidgets).

* WebCore.pri:
* platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivateQt::supportsType):
(WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
(WebCore::MediaPlayerPrivateQt::~MediaPlayerPrivateQt):
(WebCore::MediaPlayerPrivateQt::didLoadingProgress):
(WebCore::MediaPlayerPrivateQt::totalBytes):
(WebCore::MediaPlayerPrivateQt::setVisible):
(WebCore::MediaPlayerPrivateQt::surfaceFormatChanged):
(WebCore::MediaPlayerPrivateQt::setSize):
(WebCore::MediaPlayerPrivateQt::removeVideoItem):
(WebCore::MediaPlayerPrivateQt::restoreVideoItem):
(WebCore):
(WebCore::MediaPlayerPrivateQt::start):
(WebCore::MediaPlayerPrivateQt::supportedPixelFormats):
(WebCore::MediaPlayerPrivateQt::present):
(WebCore::MediaPlayerPrivateQt::paint):
(WebCore::MediaPlayerPrivateQt::paintCurrentFrameInContext):
(WebCore::MediaPlayerPrivateQt::paintToTextureMapper):
* platform/graphics/qt/MediaPlayerPrivateQt.h:
(MediaPlayerPrivateQt):

Source/WebKit:

* WebKit1.pri: WK1 needs QtMultimediaWidgets for QVideoWidget and friends.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Clean up Qt module detection
hausmann@webkit.org [Tue, 9 Oct 2012 14:02:52 +0000 (14:02 +0000)]
[Qt] Clean up Qt module detection

Reviewed by Tor Arne Vestbø.

Replace the use of MOBILITY_CONFIG (not supported anymore) with modern use of haveQtModule.

* qmake/mkspecs/features/features.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Respect WEBKITOUTPUTDIR in run-with-jhbuild.
rakuco@webkit.org [Tue, 9 Oct 2012 13:45:52 +0000 (13:45 +0000)]
[GTK] Respect WEBKITOUTPUTDIR in run-with-jhbuild.
https://bugs.webkit.org/show_bug.cgi?id=98732

Reviewed by Gustavo Noronha Silva.

Follow-up to r113066: if the WEBKITOUTPUTDIR environment variable
was used when running update-webkitgtk-libs,
WebKitBuild/Dependencies will not exist, so we now check its
contents first and then fall back to WebKitBuild/.

* gtk/run-with-jhbuild:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAllow users to specify a different hover image for TextFieldDecorationElement
commit-queue@webkit.org [Tue, 9 Oct 2012 13:43:14 +0000 (13:43 +0000)]
Allow users to specify a different hover image for TextFieldDecorationElement
https://bugs.webkit.org/show_bug.cgi?id=93662

Patch by Garrett Casto <gcasto@chromium.org> on 2012-10-09
Reviewed by Kent Tamura.

Source/WebCore:

* html/shadow/TextFieldDecorationElement.cpp:
(WebCore::TextFieldDecorationElement::TextFieldDecorationElement):
(WebCore::TextFieldDecorationElement::updateImage):
(WebCore::TextFieldDecorationElement::defaultEventHandler): Handles mouseover and mouseout events.
(WebCore::TextFieldDecorationElement::willRespondToMouseMoveEvents): Now returns true if the element is not disabled.
(WebCore):
* html/shadow/TextFieldDecorationElement.h:
(TextFieldDecorator):
(TextFieldDecorationElement):

Source/WebKit/chromium:

* public/WebTextFieldDecoratorClient.h:
(WebTextFieldDecoratorClient):
(WebKit::WebTextFieldDecoratorClient::imageNameForHoverState): Allow users to specify the name of the image for mouseover.
* src/TextFieldDecoratorImpl.cpp:
(WebKit::TextFieldDecoratorImpl::imageForReadonlyState):
(WebKit::TextFieldDecoratorImpl::imageForHoverState):
(WebKit):
* src/TextFieldDecoratorImpl.h:
(TextFieldDecoratorImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Add support for running JavaScript from GResources
commit-queue@webkit.org [Tue, 9 Oct 2012 13:31:18 +0000 (13:31 +0000)]
[GTK] Add support for running JavaScript from GResources
https://bugs.webkit.org/show_bug.cgi?id=98488

Patch by Simon Pena <spena@igalia.com> on 2012-10-09
Reviewed by Carlos Garcia Campos.

GResources allow embedding certain resources, frequently used, in a "bundle"
which can be kept separated or stored in the binary. This patch adds
support for running JavaScript from GResources.

.:

* configure.ac: Add support for compiling GResources

Source/WebKit2:

For this, methods run_javascript_from_gresource and
run_javascript_from_gresource_finish are added, which load the resource
asynchronously and, when it is ready, run the JavaScript.

* UIProcess/API/gtk/WebKitWebView.cpp: Include the new methods.
(resourcesStreamReadCallback):
(webkit_web_view_run_javascript_from_gresource):
(webkit_web_view_run_javascript_from_gresource_finish):
* UIProcess/API/gtk/WebKitWebView.h:
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Include the new
methods in the documentation.
* UIProcess/API/gtk/tests/GNUmakefile.am: Add the test resources to the
build infrastructure.
* UIProcess/API/gtk/tests/TestMain.cpp: Register the resources in the tests,
so that they can be accessed in all of them.
(register_gresource):
(main):
* UIProcess/API/gtk/tests/TestWebKitWebView.cpp: Test the
run_javascript_from_gresource method.
(testWebViewRunJavaScript):
* UIProcess/API/gtk/tests/WebViewTest.cpp: Add a method for testing the
new run_javascript_from_gresource method.
(runJavaScriptFromGResourceReadyCallback):
(WebViewTest::runJavaScriptFromGResourceAndWaitUntilFinished):
* UIProcess/API/gtk/tests/WebViewTest.h:
* UIProcess/API/gtk/tests/resources/webkit2gtk-tests.gresource.xml: Added.
Resource bundle containing the resources.
* UIProcess/API/gtk/tests/resources/webkit2gtk-tests.test.js: Added.
Example JavaScript file to test the GResources support.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Rebaseline some svg/text tests.
rakuco@webkit.org [Tue, 9 Oct 2012 13:07:47 +0000 (13:07 +0000)]
[EFL] Rebaseline some svg/text tests.

Some pixel tests now have the red rectangle drawn around some
areas like other ports.

While here, also add an expectation for selection-tripleclick.svg,
which seems to be passing now.

* platform/efl/TestExpectations:
* platform/efl/svg/text/foreignObject-text-clipping-bug-expected.png:
* platform/efl/svg/text/selection-tripleclick-expected.png: Added.
* platform/efl/svg/text/selection-tripleclick-expected.txt: Added.
* platform/efl/svg/text/text-align-01-b-expected.png:
* platform/efl/svg/text/text-align-02-b-expected.png:
* platform/efl/svg/text/text-align-03-b-expected.png:
* platform/efl/svg/text/text-align-04-b-expected.png:
* platform/efl/svg/text/text-align-05-b-expected.png:
* platform/efl/svg/text/text-align-06-b-expected.png:
* platform/efl/svg/text/text-altglyph-01-b-expected.png:
* platform/efl/svg/text/text-deco-01-b-expected.png:
* platform/efl/svg/text/text-fonts-01-t-expected.png:
* platform/efl/svg/text/text-fonts-02-t-expected.png:
* platform/efl/svg/text/text-intro-05-t-expected.png:
* platform/efl/svg/text/text-path-01-b-expected.png:
* platform/efl/svg/text/text-spacing-01-b-expected.png:
* platform/efl/svg/text/text-text-01-b-expected.png:
* platform/efl/svg/text/text-text-03-b-expected.png:
* platform/efl/svg/text/text-text-04-t-expected.png:
* platform/efl/svg/text/text-text-05-t-expected.png:
* platform/efl/svg/text/text-text-06-t-expected.png:
* platform/efl/svg/text/text-text-07-t-expected.png:
* platform/efl/svg/text/text-text-08-b-expected.png:
* platform/efl/svg/text/text-tref-01-b-expected.png:
* platform/efl/svg/text/text-tselect-01-b-expected.png:
* platform/efl/svg/text/text-tselect-02-f-expected.png:
* platform/efl/svg/text/text-tspan-01-b-expected.png:
* platform/efl/svg/text/text-ws-01-t-expected.png:
* platform/efl/svg/text/text-ws-02-t-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Uploading images to Google+ using QtWebKit does not work.
allan.jensen@digia.com [Tue, 9 Oct 2012 13:00:45 +0000 (13:00 +0000)]
[Qt] Uploading images to Google+ using QtWebKit does not work.
https://bugs.webkit.org/show_bug.cgi?id=72329

Reviewed by Jocelyn Turcotte.

Source/WebCore:

Implement handling of Blob FormData, including its extensions to the File FormData.

* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::FormDataIODevice::FormDataIODevice):
(WebCore::appendBlobResolved):
(WebCore::FormDataIODevice::prepareFormElements):
(WebCore::FormDataIODevice::computeSize):
(WebCore::FormDataIODevice::moveToNextElement):
(WebCore::FormDataIODevice::prepareCurrentElement):
(WebCore::FormDataIODevice::openFileForCurrentElement):
(WebCore::FormDataIODevice::readData):
(WebCore::QNetworkReplyHandler::sendNetworkRequest):
* platform/network/qt/QNetworkReplyHandler.h:
(FormDataIODevice):

LayoutTests:

Unskip the two BLOB tests that now passes. The rest of the BLOB tests unfortunately depend
on features we do not have.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unskip and rebase now passing tests.
ossy@webkit.org [Tue, 9 Oct 2012 12:47:10 +0000 (12:47 +0000)]
[Qt] Unskip and rebase now passing tests.

* platform/qt/TestExpectations:
* platform/qt/compositing/overflow/clip-descendents-expected.txt: Added.
* platform/qt/css1/formatting_model/floating_elements-expected.png:
* platform/qt/css1/formatting_model/floating_elements-expected.txt:
* platform/qt/editing/selection/caret-ltr-2-expected.png:
* platform/qt/editing/selection/caret-ltr-2-expected.txt:
* platform/qt/editing/selection/caret-ltr-2-left-expected.png:
* platform/qt/editing/selection/caret-ltr-2-left-expected.txt:
* platform/qt/editing/selection/caret-ltr-expected.png:
* platform/qt/editing/selection/caret-ltr-expected.txt:
* platform/qt/editing/selection/caret-ltr-right-expected.png:
* platform/qt/editing/selection/caret-ltr-right-expected.txt:
* platform/qt/editing/selection/caret-rtl-2-left-expected.png:
* platform/qt/editing/selection/caret-rtl-2-left-expected.txt:
* platform/qt/editing/selection/caret-rtl-right-expected.png:
* platform/qt/editing/selection/caret-rtl-right-expected.txt:
* platform/qt/fast/backgrounds/size/zero-expected.png: Added.
* platform/qt/fast/backgrounds/size/zero-expected.txt:
* platform/qt/fast/block/basic/fieldset-stretch-to-legend-expected.png:
* platform/qt/fast/block/basic/fieldset-stretch-to-legend-expected.txt:
* platform/qt/fast/forms/basic-buttons-expected.png:
* platform/qt/fast/forms/basic-buttons-expected.txt:
* platform/qt/fast/multicol/overflow-across-columns-expected.png: Added.
* platform/qt/fast/multicol/overflow-across-columns-expected.txt: Added.
* platform/qt/fast/multicol/overflow-unsplittable-expected.png: Added.
* platform/qt/fast/multicol/overflow-unsplittable-expected.txt: Added.
* platform/qt/fast/multicol/positive-leading-expected.png: Added.
* platform/qt/fast/multicol/positive-leading-expected.txt: Added.
* platform/qt/fast/multicol/shadow-breaking-expected.png:
* platform/qt/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
* platform/qt/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
* platform/qt/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
* platform/qt/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
* platform/qt/fast/overflow/003-expected.png:
* platform/qt/fast/overflow/003-expected.txt:
* platform/qt/fast/regions/overflow-size-change-with-stacking-context-expected.txt: Added.
* platform/qt/fast/replaced/table-percent-height-expected.txt:
* platform/qt/fast/text/line-initial-and-final-swashes-expected.txt: Added.
* platform/qt/fonts/cursive-expected.png: Added.
* platform/qt/fonts/cursive-expected.txt: Added.
* platform/qt/fonts/default-expected.png: Added.
* platform/qt/fonts/default-expected.txt: Added.
* platform/qt/fonts/fantasy-expected.png: Added.
* platform/qt/fonts/fantasy-expected.txt: Added.
* platform/qt/fonts/monospace-expected.png: Added.
* platform/qt/fonts/monospace-expected.txt: Added.
* platform/qt/fonts/sans-serif-expected.png: Added.
* platform/qt/fonts/sans-serif-expected.txt: Added.
* platform/qt/fonts/serif-expected.png: Added.
* platform/qt/fonts/serif-expected.txt: Added.
* platform/qt/printing/page-count-relayout-shrink-expected.txt: Added.
* platform/qt/printing/return-from-printing-mode-expected.png: Added.
* platform/qt/printing/return-from-printing-mode-expected.txt: Added.
* platform/qt/printing/setPrinting-expected.png: Added.
* platform/qt/printing/setPrinting-expected.txt: Added.
* platform/qt/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Added.
* platform/qt/svg/custom/clip-mask-negative-scale-expected.png: Added.
* platform/qt/tables/mozilla/bugs/bug10296-1-expected.png:
* platform/qt/tables/mozilla/bugs/bug10296-1-expected.txt:
* platform/qt/tables/mozilla/bugs/bug12384-expected.png: Added.
* platform/qt/tables/mozilla/bugs/bug12384-expected.txt:
* platform/qt/tables/mozilla/bugs/bug99948-expected.png: Added.
* platform/qt/tables/mozilla/bugs/bug99948-expected.txt:
* platform/qt/tables/mozilla/marvin/colgroup_width_pct-expected.png: Added.
* platform/qt/tables/mozilla/marvin/colgroup_width_pct-expected.txt:
* platform/qt/tables/mozilla/marvin/table_overflow_hidden_td-expected.png: Added.
* platform/qt/tables/mozilla/marvin/table_overflow_hidden_td-expected.txt:
* platform/qt/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
* platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.png: Added.
* platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.txt:
* platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.png: Added.
* platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.txt:
* platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.png: Added.
* platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.txt:
* platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.png: Added.
* platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.txt:
* platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.png: Added.
* platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.txt:
* platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.png: Added.
* platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.txt:
* platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.png: Added.
* platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.txt:
* platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.png: Added.
* platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] remove duplicate failure expectations
commit-queue@webkit.org [Tue, 9 Oct 2012 11:55:05 +0000 (11:55 +0000)]
[EFL] remove duplicate failure expectations
https://bugs.webkit.org/show_bug.cgi?id=98736

Unreviewed gardening.

Many tests are listed in both efl and wk2 expectations. Remove the efl expectations
in cases where the bug seems to be a wk2 issue.

Most expectations are also added into the efl-wk1 expectations (which is where
they should have been all along).

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-10-09

* platform/efl-wk1/TestExpectations:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoText decorations specified on the containing block are not properly applied when...
commit-queue@webkit.org [Tue, 9 Oct 2012 11:42:11 +0000 (11:42 +0000)]
Text decorations specified on the containing block are not properly applied when ::first-line is present.
https://bugs.webkit.org/show_bug.cgi?id=93829

Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2012-10-09
Reviewed by Abhishek Arya.

Source/WebCore:

If a container's style and its pseudo :first-line style have unique
text-decorations specified for them, only the :first-line text-decoarations
were being applied.

The uploaded patch intends to first compute the text decoration colors
for the containing box, followed by that of the first-line (if specified).

This thus avoids the condition wherein our containing box's text-decorations
were not getting applied at all since initially we were only computing
for the first-line style.

Test: fast/css/text-decorations-on-first-line-and-containing-block.html

* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintDecoration):
getTextDecorationColors() is first called for computing the containing box's
text-decoration values and then for first-line style's text-decorations,
if specified.

LayoutTests:

* fast/css/text-decorations-on-first-line-and-containing-block-expected.html: Added.
* fast/css/text-decorations-on-first-line-and-containing-block.html: Added.
Tests added for verifying the behavior of text-decorations when specified
both for the ::first-line as well as its containing block.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r130746.
commit-queue@webkit.org [Tue, 9 Oct 2012 11:33:42 +0000 (11:33 +0000)]
Unreviewed, rolling out r130746.
http://trac.webkit.org/changeset/130746
https://bugs.webkit.org/show_bug.cgi?id=98749

It made 45 tests crash on Qt (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-09

Source/WebCore:

* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::FormDataIODevice::FormDataIODevice):
(WebCore::FormDataIODevice::computeSize):
(WebCore::FormDataIODevice::moveToNextElement):
(WebCore::FormDataIODevice::openFileForCurrentElement):
(WebCore::FormDataIODevice::readData):
(WebCore::QNetworkReplyHandler::getIODevice):
(WebCore::QNetworkReplyHandler::sendNetworkRequest):
* platform/network/qt/QNetworkReplyHandler.h:
(QNetworkReplyHandler):
(FormDataIODevice):

LayoutTests:

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Tue, 9 Oct 2012 11:05:27 +0000 (11:05 +0000)]
Unreviewed GTK gardening.

Skipping the accept-policy test in TestCookieManager API test that's
currently failing. The test failure is covered by
https://bugs.webkit.org/show_bug.cgi?id=98738.

* Scripts/run-gtk-tests:
(TestRunner):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Mark a few tests skipped in r130745 as failures instead of timeouts.
rakuco@webkit.org [Tue, 9 Oct 2012 10:49:29 +0000 (10:49 +0000)]
[EFL] Mark a few tests skipped in r130745 as failures instead of timeouts.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Uploading images to Google+ using QtWebKit does not work.
allan.jensen@digia.com [Tue, 9 Oct 2012 10:18:38 +0000 (10:18 +0000)]
[Qt] Uploading images to Google+ using QtWebKit does not work.
https://bugs.webkit.org/show_bug.cgi?id=72329

Reviewed by Jocelyn Turcotte.

Source/WebCore:

Implement handling of Blob FormData, including its extensions to the File FormData.

* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::FormDataIODevice::FormDataIODevice):
(WebCore::FormDataIODevice::computeSize):
(WebCore::FormDataIODevice::moveToNextElement):
(WebCore::FormDataIODevice::prepareCurrentElement):
(WebCore::FormDataIODevice::openFileForCurrentElement):
(WebCore::FormDataIODevice::readData):
(WebCore::QNetworkReplyHandler::getIODevice):
(WebCore::QNetworkReplyHandler::handleBlobDataIfAny):
(WebCore::QNetworkReplyHandler::sendNetworkRequest):
* platform/network/qt/QNetworkReplyHandler.h:
(QNetworkReplyHandler):
(FormDataIODevice):

LayoutTests:

Unskip the two BLOB tests that now passes. The rest of the BLOB tests unfortunately depend
on features we do not have.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Skip a few tests after r130699.
rakuco@webkit.org [Tue, 9 Oct 2012 09:44:47 +0000 (09:44 +0000)]
[EFL] Skip a few tests after r130699.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Remove comment added in r130650 now that I've run the GTK+ tests.
rakuco@webkit.org [Tue, 9 Oct 2012 09:35:40 +0000 (09:35 +0000)]
[EFL] Remove comment added in r130650 now that I've run the GTK+ tests.

* platform/efl-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Tue, 9 Oct 2012 09:18:48 +0000 (09:18 +0000)]
Unreviewed GTK gardening.

Adding more failure expectations for regressions after r130699.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unskip now passing tests.
ossy@webkit.org [Tue, 9 Oct 2012 09:11:06 +0000 (09:11 +0000)]
[Qt] Unskip now passing tests.

* platform/qt-5.0-wk2/TestExpectations:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] /editing/selection/caret-bidi-first-and-last-letters.html fails
commit-queue@webkit.org [Tue, 9 Oct 2012 09:09:38 +0000 (09:09 +0000)]
[Qt] /editing/selection/caret-bidi-first-and-last-letters.html fails
https://bugs.webkit.org/show_bug.cgi?id=51884

Patch by Tullio Lucena <tullio.lucena@openbossa.org> on 2012-10-09
Reviewed by Ryosuke Niwa.

This test pass with this change in testfonts https://gitorious.org/qtwebkit/testfonts/merge_requests/1

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] editing/selection/caret-at-bidi-boundary.html fails
commit-queue@webkit.org [Tue, 9 Oct 2012 09:04:50 +0000 (09:04 +0000)]
[Qt] editing/selection/caret-at-bidi-boundary.html fails
https://bugs.webkit.org/show_bug.cgi?id=66514

Patch by Tullio Lucena <tullio.lucena@openbossa.org> on 2012-10-09
Reviewed by Yuta Kitamura.

Unskipping test. The update in testfonts solved this bug.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unskip and rebase a now passing test.
ossy@webkit.org [Tue, 9 Oct 2012 08:55:16 +0000 (08:55 +0000)]
[Qt] Unskip and rebase a now passing test.

* platform/qt/TestExpectations:
* platform/qt/fast/repaint/line-flow-with-floats-in-regions-expected.png:
* platform/qt/fast/repaint/line-flow-with-floats-in-regions-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unskip fast/transforms/scrollIntoView-transformed.html.
ossy@webkit.org [Tue, 9 Oct 2012 08:50:40 +0000 (08:50 +0000)]
[Qt] Unskip fast/transforms/scrollIntoView-transformed.html.

* platform/qt-5.0-wk2/TestExpectations:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unskip and rebase now passing tests.
ossy@webkit.org [Tue, 9 Oct 2012 08:46:53 +0000 (08:46 +0000)]
[Qt] Unskip and rebase now passing tests.

* platform/qt-5.0/TestExpectations:
* platform/qt/TestExpectations:
* platform/qt/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png:
* platform/qt/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.txt:
* platform/qt/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png:
* platform/qt/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Tue, 9 Oct 2012 08:37:15 +0000 (08:37 +0000)]
Unreviewed GTK gardening.

Adding failure expectations for regressions after r130699 and
a failing multipart test introduced in r130651.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unskip and rebasing now passing tests.
ossy@webkit.org [Tue, 9 Oct 2012 08:27:20 +0000 (08:27 +0000)]
[Qt] Unskip and rebasing now passing tests.

* platform/qt-5.0-wk1/TestExpectations:
* platform/qt/fast/css/word-space-extra-expected.png:
* platform/qt/fast/css/word-space-extra-expected.txt:
* platform/qt/fast/history/history-back-initial-vs-final-url-expected.txt: Added.
* platform/qt/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
* platform/qt/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
* platform/qt/fast/transforms/transformed-focused-text-input-expected.png:
* platform/qt/fast/transforms/transformed-focused-text-input-expected.txt:
* platform/qt/http/tests/navigation/postredirect-frames-expected.txt:
* platform/qt/http/tests/navigation/postredirect-goback2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPage popup should be smarter about its layout
keishi@webkit.org [Tue, 9 Oct 2012 08:17:44 +0000 (08:17 +0000)]
Page popup should be smarter about its layout
https://bugs.webkit.org/show_bug.cgi?id=98499

Reviewed by Kent Tamura.

Source/WebCore:

This change fixes these two issues:
1. Page popup should reposition itself so it won't get clipped by screen(Win/Linux) or rootview(Mac) bounds.
2. Page popup should resize itself when it doesn't fit.

Test: platform/chromium/fast/forms/page-popup/page-popup-adjust-rect.html

* Resources/pagepopups/calendarPicker.js:
(initialize): We need to set global.params at the beginning because we need it for resizeWindow().
* Resources/pagepopups/colorSuggestionPicker.js: Added global.params.
(handleMessage):
(initialize):
(handleArgumentsTimeout):
* Resources/pagepopups/pickerCommon.js:
(Rect): Represents an axis aligned rectangle.
(Rect.prototype.get maxX): Gets position of right edge.
(Rect.prototype.get maxY): Gets position of bottom edge.
(Rect.prototype.toString):
(Rect.intersection): Returns the intersection of two rectangles.
(resizeWindow): Resize window to a certain size. Don't allow shrinking.
(adjustWindowRect): Calculates the best position and size for the popup.
(_adjustWindowRectVertically):
(_adjustWindowRectHorizontally):
(setWindowRect): Sets the position and size of the popup to the given rect.
* Resources/pagepopups/suggestionPicker.css:
(.suggestion-list): Don't show horizontal scroll bar.
* Resources/pagepopups/suggestionPicker.js:
(SuggestionPicker.prototype._fixWindowSize):
* page/PagePopupClient.cpp:
(WebCore::PagePopupClient::addProperty): For adding an int to JSON.
(WebCore::PagePopupClient::addProperty): For adding an IntRect to JSON.
(WebCore):
* page/PagePopupClient.h:
(PagePopupClient):

Source/WebKit/chromium:

* src/ColorChooserUIController.cpp:
(WebKit::ColorChooserUIController::writeDocument): Send anchorRectInScreen, rootViewRectInScreen, and confineToRootView.
* src/DateTimeChooserImpl.cpp:
(WebKit::DateTimeChooserImpl::writeDocument): Send anchorRectInScreen, rootViewRectInScreen, and confineToRootView.
* src/WebPagePopupImpl.cpp:
(WebKit::WebPagePopupImpl::init): We keep the originBoundsInRootView argument for MockPagePopupDriver.
(WebKit::WebPagePopupImpl::resize): WebPagePopupImpl isn't in charge of setting the popup position any more.
* src/WebPagePopupImpl.h:
(WebPagePopupImpl):

LayoutTests:

* platform/chromium/fast/forms/page-popup/page-popup-adjust-rect-expected.txt: Added.
* platform/chromium/fast/forms/page-popup/page-popup-adjust-rect.html: Added.
* platform/chromium-android/TestExpectations: Added platform/chromium/fast/forms/page-popup.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unskip now passing tests.
ossy@webkit.org [Tue, 9 Oct 2012 08:07:56 +0000 (08:07 +0000)]
[Qt] Unskip now passing tests.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Refactoring] Scoped Style related code should have its own class.
morrita@google.com [Tue, 9 Oct 2012 08:00:53 +0000 (08:00 +0000)]
[Refactoring] Scoped Style related code should have its own class.
https://bugs.webkit.org/show_bug.cgi?id=98244

Reviewed by Dimitri Glazkov.

This change extracts StyleScopeResolver from StyleResolver to clarify
the responsibility of the style scope handling. Now we can easily see
where the style scoping needs to be involed.

Coming Shadow DOM related change like @host rules will fit within this class.

No new tests, refactoring.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSAllInOne.cpp:
* css/StyleResolver.cpp:
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::collectFeatures):
(WebCore::StyleResolver::appendAuthorStylesheets):
(WebCore::StyleResolver::pushParentElement):
(WebCore::StyleResolver::popParentElement):
(WebCore::StyleResolver::pushParentShadowRoot):
(WebCore::StyleResolver::popParentShadowRoot):
(WebCore::StyleResolver::matchScopedAuthorRules):
(WebCore::StyleResolver::collectMatchingRulesForList):
(WebCore::StyleResolver::reportMemoryUsage):
* css/StyleResolver.h:
(StyleResolver):
* css/StyleScopeResolver.cpp: Added.
(WebCore):
(WebCore::StyleScopeResolver::StyleScopeResolver):
(WebCore::StyleScopeResolver::~StyleScopeResolver):
(WebCore::StyleScopeResolver::scopeFor):
(WebCore::StyleScopeResolver::ruleSetFor):
(WebCore::StyleScopeResolver::ensureRuleSetFor):
(WebCore::StyleScopeResolver::setupStack):
(WebCore::StyleScopeResolver::push):
(WebCore::StyleScopeResolver::pop):
(WebCore::StyleScopeResolver::collectFeaturesTo):
(WebCore::StyleScopeResolver::reportMemoryUsage):
* css/StyleScopeResolver.h: Added.
(WebCore):
(StyleScopeResolver):
(WebCore::StyleScopeResolver::StackFrame::StackFrame):
(StackFrame):
(WebCore::StyleScopeResolver::hasScopedStyles):
(WebCore::StyleScopeResolver::stackSize):
(WebCore::StyleScopeResolver::stackFrameAt):
(WebCore::StyleScopeResolver::matchesStyleBounds):
(WebCore::StyleScopeResolver::stackIsConsistent):
(WebCore::StyleScopeResolver::ensureStackConsistency):
(WebCore::StyleScopeResolver::scopeFor):
(WebCore::StyleScopeResolver::ensureRuleSetFor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unskip now passing tests.
ossy@webkit.org [Tue, 9 Oct 2012 07:58:40 +0000 (07:58 +0000)]
[Qt] Unskip now passing tests.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unskip now passing tests.
ossy@webkit.org [Tue, 9 Oct 2012 07:50:30 +0000 (07:50 +0000)]
[Qt] Unskip now passing tests.

* platform/qt-5.0-wk1/TestExpectations:
* platform/qt-5.0-wk2/TestExpectations:
* platform/qt-5.0/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Need API to control the DNS Prefetching
charles.wei@torchmobile.com.cn [Tue, 9 Oct 2012 07:40:05 +0000 (07:40 +0000)]
[BlackBerry] Need API to control the DNS Prefetching
https://bugs.webkit.org/show_bug.cgi?id=98713

Reviewed by George Staikos.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPage::enableDNSPrefetch):
(WebKit):
(BlackBerry::WebKit::WebPage::disableDNSPrefetch):
(BlackBerry::WebKit::WebPage::isDNSPrefetchEnabled):
* Api/WebPage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Remove redundant JAVASCRIPTCORE_JIT variable
commit-queue@webkit.org [Tue, 9 Oct 2012 07:22:53 +0000 (07:22 +0000)]
[Qt] Remove redundant JAVASCRIPTCORE_JIT variable
https://bugs.webkit.org/show_bug.cgi?id=50000

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2012-10-09
Reviewed by Simon Hausmann.

Use ENABLE_JIT instead.

* qmake/mkspecs/features/valgrind.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gadening after r130709.
ossy@webkit.org [Tue, 9 Oct 2012 07:18:10 +0000 (07:18 +0000)]
Unreviewed gadening after r130709.

* fast/harness/results-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRenamed RegisterFile to JSStack, and removed prototype of the
mark.lam@apple.com [Tue, 9 Oct 2012 07:12:56 +0000 (07:12 +0000)]
Renamed RegisterFile to JSStack, and removed prototype of the
previously deleted Interpreter::privateExecute().
https://bugs.webkit.org/show_bug.cgi?id=98717.

Reviewed by Filip Pizlo.

* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.order:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* bytecode/BytecodeConventions.h:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::nameForRegister):
* bytecode/CodeBlock.h:
(CodeBlock):
* bytecode/ValueRecovery.h:
(JSC::ValueRecovery::alreadyInJSStack):
(JSC::ValueRecovery::alreadyInJSStackAsUnboxedInt32):
(JSC::ValueRecovery::alreadyInJSStackAsUnboxedCell):
(JSC::ValueRecovery::alreadyInJSStackAsUnboxedBoolean):
(JSC::ValueRecovery::alreadyInJSStackAsUnboxedDouble):
(JSC::ValueRecovery::displacedInJSStack):
(JSC::ValueRecovery::isAlreadyInJSStack):
(JSC::ValueRecovery::virtualRegister):
(JSC::ValueRecovery::dump):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::resolveCallee):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitConstruct):
* bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::registerFor):
* dfg/DFGAbstractState.h:
(AbstractState):
* dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::emitGetFromCallFrameHeaderPtr):
(JSC::DFG::AssemblyHelpers::emitPutToCallFrameHeader):
(JSC::DFG::AssemblyHelpers::emitPutImmediateToCallFrameHeader):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getDirect):
(JSC::DFG::ByteCodeParser::findArgumentPositionForLocal):
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::InlineStackEntry::remapOperand):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
* dfg/DFGGenerationInfo.h:
(GenerationInfo):
(JSC::DFG::GenerationInfo::needsSpill):
* dfg/DFGGraph.h:
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::compileFunction):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::beginCall):
* dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
* dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGRepatch.cpp:
(JSC::DFG::tryBuildGetByIDList):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
* dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::spill):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillInteger):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGThunks.cpp:
(JSC::DFG::throwExceptionFromCallSlowPathGenerator):
(JSC::DFG::slowPathFor):
(JSC::DFG::virtualForThunkGenerator):
* dfg/DFGValueSource.cpp:
(JSC::DFG::ValueSource::dump):
* dfg/DFGValueSource.h:
(JSC::DFG::dataFormatToValueSourceKind):
(JSC::DFG::valueSourceKindToDataFormat):
(JSC::DFG::isInJSStack):
(JSC::DFG::ValueSource::forSpeculation):
(JSC::DFG::ValueSource::isInJSStack):
(JSC::DFG::ValueSource::valueRecovery):
* dfg/DFGVariableEventStream.cpp:
(JSC::DFG::VariableEventStream::reconstruct):
* heap/Heap.cpp:
(JSC::Heap::stack):
(JSC::Heap::getConservativeRegisterRoots):
(JSC::Heap::markRoots):
* heap/Heap.h:
(JSC):
(Heap):
* interpreter/CallFrame.cpp:
(JSC::CallFrame::stack):
* interpreter/CallFrame.h:
(JSC::ExecState::calleeAsValue):
(JSC::ExecState::callee):
(JSC::ExecState::codeBlock):
(JSC::ExecState::scope):
(JSC::ExecState::callerFrame):
(JSC::ExecState::returnPC):
(JSC::ExecState::hasReturnPC):
(JSC::ExecState::clearReturnPC):
(JSC::ExecState::bytecodeOffsetForNonDFGCode):
(JSC::ExecState::setBytecodeOffsetForNonDFGCode):
(JSC::ExecState::inlineCallFrame):
(JSC::ExecState::codeOriginIndexForDFG):
(JSC::ExecState::currentVPC):
(JSC::ExecState::setCurrentVPC):
(JSC::ExecState::setCallerFrame):
(JSC::ExecState::setScope):
(JSC::ExecState::init):
(JSC::ExecState::argumentCountIncludingThis):
(JSC::ExecState::offsetFor):
(JSC::ExecState::setArgumentCountIncludingThis):
(JSC::ExecState::setCallee):
(JSC::ExecState::setCodeBlock):
(JSC::ExecState::setReturnPC):
(JSC::ExecState::setInlineCallFrame):
(ExecState):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::slideRegisterWindowForCall):
(JSC::eval):
(JSC::loadVarargs):
(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::throwException):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):
(JSC::Interpreter::endRepeatCall):
* interpreter/Interpreter.h:
(JSC::Interpreter::stack):
(Interpreter):
(JSC::Interpreter::execute):
(JSC):
* interpreter/JSStack.cpp: Copied from Source/JavaScriptCore/interpreter/RegisterFile.cpp.
(JSC::stackStatisticsMutex):
(JSC::JSStack::~JSStack):
(JSC::JSStack::growSlowCase):
(JSC::JSStack::gatherConservativeRoots):
(JSC::JSStack::releaseExcessCapacity):
(JSC::JSStack::initializeThreading):
(JSC::JSStack::committedByteCount):
(JSC::JSStack::addToCommittedByteCount):
* interpreter/JSStack.h: Copied from Source/JavaScriptCore/interpreter/RegisterFile.h.
(JSStack):
(JSC::JSStack::JSStack):
(JSC::JSStack::shrink):
(JSC::JSStack::grow):
* interpreter/RegisterFile.cpp: Removed.
* interpreter/RegisterFile.h: Removed.
* interpreter/VMInspector.cpp:
(JSC::VMInspector::dumpFrame):
* jit/JIT.cpp:
(JSC::JIT::JIT):
(JSC::JIT::privateCompile):
* jit/JIT.h:
(JSC):
(JIT):
* jit/JITCall.cpp:
(JSC::JIT::compileLoadVarargs):
(JSC::JIT::compileCallEval):
(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCall):
* jit/JITCall32_64.cpp:
(JSC::JIT::emit_op_ret):
(JSC::JIT::emit_op_ret_object_or_this):
(JSC::JIT::compileLoadVarargs):
(JSC::JIT::compileCallEval):
(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCall):
* jit/JITCode.h:
(JSC):
(JSC::JITCode::execute):
* jit/JITInlineMethods.h:
(JSC::JIT::emitPutToCallFrameHeader):
(JSC::JIT::emitPutCellToCallFrameHeader):
(JSC::JIT::emitPutIntToCallFrameHeader):
(JSC::JIT::emitPutImmediateToCallFrameHeader):
(JSC::JIT::emitGetFromCallFrameHeaderPtr):
(JSC::JIT::emitGetFromCallFrameHeader32):
(JSC::JIT::updateTopCallFrame):
(JSC::JIT::unmap):
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::emit_op_end):
(JSC::JIT::emit_op_ret):
(JSC::JIT::emit_op_ret_object_or_this):
(JSC::JIT::emit_op_create_this):
(JSC::JIT::emit_op_get_arguments_length):
(JSC::JIT::emit_op_get_argument_by_val):
(JSC::JIT::emit_op_resolve_global_dynamic):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::emit_op_end):
(JSC::JIT::emit_op_create_this):
(JSC::JIT::emit_op_get_arguments_length):
(JSC::JIT::emit_op_get_argument_by_val):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_scoped_var):
(JSC::JIT::emit_op_put_scoped_var):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_get_scoped_var):
(JSC::JIT::emit_op_put_scoped_var):
* jit/JITStubs.cpp:
(JSC::ctiTrampoline):
(JSC::JITThunks::JITThunks):
(JSC):
(JSC::DEFINE_STUB_FUNCTION):
* jit/JITStubs.h:
(JSC):
(JITStackFrame):
* jit/JSInterfaceJIT.h:
* jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::SpecializedThunkJIT):
(JSC::SpecializedThunkJIT::returnJSValue):
(JSC::SpecializedThunkJIT::returnDouble):
(JSC::SpecializedThunkJIT::returnInt32):
(JSC::SpecializedThunkJIT::returnJSCell):
* llint/LLIntData.cpp:
(JSC::LLInt::Data::performAssertions):
* llint/LLIntOffsetsExtractor.cpp:
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::genericCall):
* llint/LLIntSlowPaths.h:
(LLInt):
* llint/LowLevelInterpreter.asm:
* runtime/Arguments.cpp:
(JSC::Arguments::tearOffForInlineCallFrame):
* runtime/CommonSlowPaths.h:
(JSC::CommonSlowPaths::arityCheckFor):
* runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
* runtime/JSActivation.cpp:
(JSC::JSActivation::visitChildren):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::globalExec):
* runtime/JSGlobalObject.h:
(JSC):
(JSGlobalObject):
* runtime/JSLock.cpp:
(JSC):
* runtime/JSVariableObject.h:
(JSVariableObject):
* runtime/MemoryStatistics.cpp:
(JSC::globalMemoryStatistics):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK build fix after r130689.
zandobersek@gmail.com [Tue, 9 Oct 2012 07:10:56 +0000 (07:10 +0000)]
Unreviewed GTK build fix after r130689.

Adding a required symbol to symbols.filter.

* Source/autotools/symbols.filter:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Unskip now passing tests.
ossy@webkit.org [Tue, 9 Oct 2012 07:06:52 +0000 (07:06 +0000)]
[Qt][WK2] Unskip now passing tests.

* platform/qt-5.0-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Make RenderThemeQStyle/ScrollbarThemeQStyle compile without QStyle/QtWidgets
hausmann@webkit.org [Tue, 9 Oct 2012 07:06:37 +0000 (07:06 +0000)]
[Qt] Make RenderThemeQStyle/ScrollbarThemeQStyle compile without QStyle/QtWidgets
https://bugs.webkit.org/show_bug.cgi?id=98268

Reviewed by Tor Arne Vestbø.

Source/WebCore:

Extracted QStyle/QWidget related code into a QWebStyle class that implements the QStyleFacade interface.

QStyleFacade is a pure interface that lives in WebCore/platform/qt
(next to RenderThemeQStyle and ScrollbarThemeQStyle) and provides a
minimal interface of what we need to draw with QStyle as well as basic
hit testing and metric retrieval. It also provides a
QStyleFacadeOption class that aggregates common meta-data for
rendering primitives, such as direction, rectangle, state (sunken,
enabled, etc.) or palette. It also provides some more slider/scrollbar
specific fields in a slider sub-structure.

RenderThemeQStyle/ScrollbarThemeQStyle used to instantiate specific QStyleOption sub-classes and populate
them with state information from render objects, before calling straight to QStyle. Most of the common code
was encapsulated in StylePainterQStyle.

The new RenderThemeQStyle/ScrolllbarThemeQStyle uses common code in
StylePainterQStyle to populate state into QStyleFacadeOption before
calling into QStyleFacade.

The style facade is then implemented by QStyleFacadeImp, which extracts
meta-data from QStyleFacadeOption arguments, populates style
primitive specific QStyleOption objects and then calls on QStyle.

RenderThemeQStyle/ScrollbarThemeQStyle can only use interface methods
from QStyleFacade. QStyleFacadeImp on the other hand will live in the
separate QtWebKitWidgets library in the future and therefore cannot use
any WebCore types.

* Target.pri:
* platform/qt/QStyleFacade.cpp: Added.
(WebCore):
(WebCore::QStyleFacade::styleForPage):
* platform/qt/QStyleFacade.h: Added.
(WebCore):
(QStyleFacade):
(WebCore::QStyleFacade::~QStyleFacade):
(WebCore::QStyleFacadeOption::QStyleFacadeOption):
(QStyleFacadeOption):
* platform/qt/RenderThemeQStyle.cpp: Renamed from Source/WebKit/qt/WebCoreSupport/RenderThemeQStyle.cpp.
(WebCore):
(WebCore::RenderThemeQStyle::getStylePainter):
(WebCore::StylePainterQStyle::StylePainterQStyle):
(WebCore::StylePainterQStyle::init):
(WebCore::RenderThemeQStyle::create):
(WebCore::RenderThemeQStyle::setStyleFactoryFunction):
(WebCore::RenderThemeQStyle::styleFactory):
(WebCore::RenderThemeQStyle::RenderThemeQStyle):
(WebCore::RenderThemeQStyle::~RenderThemeQStyle):
(WebCore::RenderThemeQStyle::setPaletteFromPageClientIfExists):
(WebCore::RenderThemeQStyle::inflateButtonRect):
(WebCore::RenderThemeQStyle::computeSizeBasedOnStyle):
(WebCore::RenderThemeQStyle::adjustButtonStyle):
(WebCore::RenderThemeQStyle::setButtonPadding):
(WebCore::RenderThemeQStyle::paintButton):
(WebCore::RenderThemeQStyle::paintTextField):
(WebCore::RenderThemeQStyle::adjustTextAreaStyle):
(WebCore::RenderThemeQStyle::paintTextArea):
(WebCore::RenderThemeQStyle::setPopupPadding):
(WebCore::RenderThemeQStyle::colorPalette):
(WebCore::RenderThemeQStyle::paintMenuList):
(WebCore::RenderThemeQStyle::adjustMenuListButtonStyle):
(WebCore::RenderThemeQStyle::paintMenuListButton):
(WebCore::RenderThemeQStyle::animationDurationForProgressBar):
(WebCore::RenderThemeQStyle::paintProgressBar):
(WebCore::RenderThemeQStyle::paintSliderTrack):
(WebCore::RenderThemeQStyle::adjustSliderTrackStyle):
(WebCore::RenderThemeQStyle::paintSliderThumb):
(WebCore::RenderThemeQStyle::adjustSliderThumbStyle):
(WebCore::RenderThemeQStyle::paintSearchField):
(WebCore::RenderThemeQStyle::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldDecoration):
(WebCore::RenderThemeQStyle::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeQStyle::paintInnerSpinButton):
(WebCore::RenderThemeQStyle::initializeCommonQStyleOptions):
(WebCore::RenderThemeQStyle::adjustSliderThumbSize):
* platform/qt/RenderThemeQStyle.h: Renamed from Source/WebKit/qt/WebCoreSupport/RenderThemeQStyle.h.
(WebCore):
(RenderThemeQStyle):
(WebCore::RenderThemeQStyle::qStyle):
(StylePainterQStyle):
(WebCore::StylePainterQStyle::isValid):
(WebCore::StylePainterQStyle::paintButton):
(WebCore::StylePainterQStyle::paintTextField):
(WebCore::StylePainterQStyle::paintComboBox):
(WebCore::StylePainterQStyle::paintComboBoxArrow):
(WebCore::StylePainterQStyle::paintSliderTrack):
(WebCore::StylePainterQStyle::paintSliderThumb):
(WebCore::StylePainterQStyle::paintInnerSpinButton):
(WebCore::StylePainterQStyle::paintProgressBar):
(WebCore::StylePainterQStyle::paintScrollCorner):
(WebCore::StylePainterQStyle::paintScrollBar):
* platform/qt/ScrollbarThemeQStyle.cpp: Renamed from Source/WebKit/qt/WebCoreSupport/ScrollbarThemeQStyle.cpp.
(WebCore):
(WebCore::ScrollbarThemeQStyle::ScrollbarThemeQStyle):
(WebCore::ScrollbarThemeQStyle::~ScrollbarThemeQStyle):
(WebCore::scPart):
(WebCore::scrollbarPart):
(WebCore::initSliderStyleOption):
(WebCore::ScrollbarThemeQStyle::paint):
(WebCore::ScrollbarThemeQStyle::hitTest):
(WebCore::ScrollbarThemeQStyle::shouldCenterOnThumb):
(WebCore::ScrollbarThemeQStyle::invalidatePart):
(WebCore::ScrollbarThemeQStyle::scrollbarThickness):
(WebCore::ScrollbarThemeQStyle::thumbPosition):
(WebCore::ScrollbarThemeQStyle::thumbLength):
(WebCore::ScrollbarThemeQStyle::trackPosition):
(WebCore::ScrollbarThemeQStyle::trackLength):
(WebCore::ScrollbarThemeQStyle::paintScrollCorner):
* platform/qt/ScrollbarThemeQStyle.h: Renamed from Source/WebKit/qt/WebCoreSupport/ScrollbarThemeQStyle.h.
(WebCore):
(ScrollbarThemeQStyle):
(WebCore::ScrollbarThemeQStyle::qStyle):

Source/WebKit:

* WebKit1.pro: Add new files to the build.

Source/WebKit/qt:

Extracted QStyle/QWidget related code into a QWebStyle class that implements the QStyleFacade interface.

QStyleFacade is a pure interface that lives in WebCore/platform/qt
(next to RenderThemeQStyle and ScrollbarThemeQStyle) and provides a
minimal interface of what we need to draw with QStyle as well as basic
hit testing and metric retrieval. It also provides a
QStyleFacadeOption class that aggregates common meta-data for
rendering primitives, such as direction, rectangle, state (sunken,
enabled, etc.) or palette. It also provides some more slider/scrollbar
specific fields in a slider sub-structure.

RenderThemeQStyle/ScrollbarThemeQStyle used to instantiate specific QStyleOption sub-classes and populate
them with state information from render objects, before calling straight to QStyle. Most of the common code
was encapsulated in StylePainterQStyle.

The new RenderThemeQStyle/ScrolllbarThemeQStyle uses common code in
StylePainterQStyle to populate state into QStyleFacadeOption before
calling into QStyleFacade.

The style facade is then implemented by QStyleFacadeImp, which extracts
meta-data from QStyleFacadeOption arguments, populates style
primitive specific QStyleOption objects and then calls on QStyle.

RenderThemeQStyle/ScrollbarThemeQStyle can only use interface methods
from QStyleFacade. QStyleFacadeImp on the other hand will live in the
separate QtWebKitWidgets library in the future and therefore cannot use
any WebCore types.

* WebCoreSupport/InitWebCoreQt.cpp:
(WebCore::initializeWebCoreQt):
* WebCoreSupport/QStyleFacadeImp.cpp: Added.
(WebKit):
(WebKit::convertToQStyleState):
(WebKit::convertToQStyleSubControl):
(WebKit::initGenericStyleOption):
(WebKit::initSpecificStyleOption):
(MappedStyleOption):
(WebKit::MappedStyleOption::MappedStyleOption):
(WebKit::convertPixelMetric):
(WebKit::convertToQStyleFacadeSubControl):
(WebKit::QStyleFacadeImp::QStyleFacadeImp):
(WebKit::QStyleFacadeImp::~QStyleFacadeImp):
(WebKit::QStyleFacadeImp::buttonSubElementRect):
(WebKit::QStyleFacadeImp::findFrameLineWidth):
(WebKit::QStyleFacadeImp::simplePixelMetric):
(WebKit::QStyleFacadeImp::buttonMargin):
(WebKit::QStyleFacadeImp::sliderLength):
(WebKit::QStyleFacadeImp::sliderThickness):
(WebKit::QStyleFacadeImp::progressBarChunkWidth):
(WebKit::QStyleFacadeImp::getButtonMetrics):
(WebKit::QStyleFacadeImp::sizeFromContents):
(WebKit::QStyleFacadeImp::paintButton):
(WebKit::QStyleFacadeImp::paintTextField):
(WebKit::QStyleFacadeImp::paintComboBox):
(WebKit::QStyleFacadeImp::paintComboBoxArrow):
(WebKit::QStyleFacadeImp::paintSliderTrack):
(WebKit::QStyleFacadeImp::paintSliderThumb):
(WebKit::QStyleFacadeImp::paintInnerSpinButton):
(WebKit::QStyleFacadeImp::paintProgressBar):
(WebKit::QStyleFacadeImp::scrollBarExtent):
(WebKit::QStyleFacadeImp::scrollBarMiddleClickAbsolutePositionStyleHint):
(WebKit::QStyleFacadeImp::paintScrollCorner):
(WebKit::QStyleFacadeImp::hitTestScrollBar):
(WebKit::QStyleFacadeImp::scrollBarSubControlRect):
(WebKit::QStyleFacadeImp::paintScrollBar):
(WebKit::QStyleFacadeImp::widgetForPainter):
(WebKit::QStyleFacadeImp::style):
* WebCoreSupport/QStyleFacadeImp.h: Added.
(WebCore):
(WebKit):
(QStyleFacadeImp):
(WebKit::QStyleFacadeImp::create):
(WebKit::QStyleFacadeImp::isValid):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt]REGRESSION(r128699): It made 2 fast/js/dfg tests assert
ossy@webkit.org [Tue, 9 Oct 2012 06:35:53 +0000 (06:35 +0000)]
[Qt]REGRESSION(r128699): It made 2 fast/js/dfg tests assert
https://bugs.webkit.org/show_bug.cgi?id=96907

Patch by Tullio Lucena <tullio.lucena@openbossa.org> on 2012-10-08
Reviewed by Csaba Osztrogonác.

Unskipping tests.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoThrottle DOM timers on hidden pages.
commit-queue@webkit.org [Tue, 9 Oct 2012 05:45:48 +0000 (05:45 +0000)]
Throttle DOM timers on hidden pages.
https://bugs.webkit.org/show_bug.cgi?id=98474

Patch by Kiran Muppala <cmuppala@apple.com> on 2012-10-08
Reviewed by Maciej Stachowiak.

Source/JavaScriptCore:

Add HIDDEN_PAGE_DOM_TIMER_THROTTLING feature define.

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

When the visibility of a page changes to "hidden", all it's DOM timers are
updated to align their fire times on one second intervals.  This limits the
number of CPU wakes due to a hidden pages to one per second.

Test: fast/dom/timer-throttling-hidden-page.html

* Configurations/FeatureDefines.xcconfig:
* WebCore.exp.in:
* dom/Document.cpp:
(WebCore):
(WebCore::Document::timerAlignmentInterval):
Read Page::timerAlignmentInterval and pass it along to DOMTimer.

* dom/Document.h:
(Document):
* dom/ScriptExecutionContext.cpp:
(WebCore):
(WebCore::ScriptExecutionContext::didChangeTimerAlignmentInterval):
Scan through self DOM Timers and tell them to recompute their fire
time based on the updated alignment interval.
(WebCore::ScriptExecutionContext::timerAlignmentInterval):

* dom/ScriptExecutionContext.h:
(ScriptExecutionContext):
* page/DOMTimer.cpp:
(WebCore):
(WebCore::DOMTimer::alignedFireTime):
If the document's alignment interval is non zero, round up the fire
time to the next multiple of alignment interval.

* page/DOMTimer.h:
(DOMTimer):
(WebCore::DOMTimer::defaultTimerAlignmentInterval):
(WebCore::DOMTimer::setDefaultTimerAlignmentInterval):
* page/Page.cpp:
(WebCore::Page::Page):
(WebCore):
(WebCore::Page::setTimerAlignmentInterval):
(WebCore::Page::timerAlignmentInterval):
(WebCore::Page::setVisibilityState):
Getter and Setter for alignment interval.  Expose setVisibilityState
if either PAGE_VISIBILITY_API is enabled or if HIDDEN_PAGE_DOM_TIMER_REDUCTION
is enabled.

* page/Page.h:
(Page):
* page/Settings.cpp:
(WebCore):
(WebCore::Settings::setDefaultDOMTimerAlignmentInterval):
(WebCore::Settings::defaultDOMTimerAlignmentInterval):
(WebCore::Settings::setDOMTimerAlignmentInterval):
(WebCore::Settings::domTimerAlignmentInterval):
* page/Settings.h:
(Settings):
* page/SuspendableTimer.cpp:
(WebCore::SuspendableTimer::suspend):
Save the time remaining to the original unaligned fire time, so that
on resuming, the fire time will be correctly aligned using the latest
alignment interval.

* platform/ThreadTimers.cpp:
(WebCore::ThreadTimers::sharedTimerFiredInternal):
Clear m_unalignedNextFireTime along with m_nextFireTime to keep
them always in sync.

* platform/Timer.cpp:
(WebCore::TimerBase::TimerBase):
(WebCore::TimerBase::setNextFireTime):
Save the requested fire time in m_unalignedNextFireTime and
set m_nextFireTime to the aligned value.  The unalinged value
is used to recompute fire time if alignment interval changes.
(WebCore):
(WebCore::TimerBase::didChangeAlignmentInterval):
Recompute next fire time from m_unalignedNextFireTime.
(WebCore::TimerBase::nextUnalignedFireInterval):
Interval from current time to the original unaligned fire time.

* platform/Timer.h:
(TimerBase):
(WebCore::TimerBase::alignedFireTime):

Source/WebKit/mac:

Add HIDDEN_PAGE_DOM_TIMER_THROTTLING feature define and provide a SPI for
DumpRenderTree to modify the visibility state of a page.  The latter
is needed to test throttling of timers on hidden pages through DumpRenderTree.

* Configurations/FeatureDefines.xcconfig:
* WebView/WebView.mm:
(-[WebView _setVisibilityState:isInitialState:]):
* WebView/WebViewPrivate.h:

Source/WebKit2:

Add HIDDEN_PAGE_DOM_TIMER_THROTTLING feature define.  Use existing code of
PAGE_VISIBILITY_API to detect changes to page visibility state.

* Configurations/FeatureDefines.xcconfig:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
Check visibility state on construction.
(WebKit::WebPageProxy::initializeWebPage):
Send initial visibility state message if HIDDEN_PAGE_DOM_TIMER_THROTTLING
is enabled or if PAGE_VISIBILITY_API is enabled.
(WebKit::WebPageProxy::viewStateDidChange):
When PAGE_VISIBILITY_API is not enabled, compare new visibility against
WebPageProxy::m_isVisible, to minimize number of messages sent.
Remove unnecessary second call to PageClient::isViewVisible for updating
visibility state.

* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setPageVisibilityState):
WebKitTestRunner uses this method to implement testRunner.setPageVisibility(),
hence enable it for testing hidden page timer throttling as well.

* WebProcess/WebPage/WebPage.cpp:
(WebKit):
(WebKit::WebPage::setVisibilityState):
Ensure Page::setVisibilityState is called either if PAGE_VISIBILITY_API is
enabled or if HIDDEN_PAGE_DOM_TIMER_THROTTLING is enabled.

* WebProcess/WebPage/WebPage.h:
(WebPage):
* WebProcess/WebPage/WebPage.messages.in:

Tools:

Implement testRunner.setPageVisibility on mac for testing throttling
of timers on hidden pages using DumpRenderTree.

* DumpRenderTree/mac/Configurations/Base.xcconfig:
Fix build error on mac-ews bot.  Add JSC copy of ICU headers to search path.

* DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::resetPageVisibility):
(TestRunner::setPageVisibility):

WebKitLibraries:

Add HIDDEN_PAGE_DOM_TIMER_THROTTLING feature define.

* win/tools/vsprops/FeatureDefines.vsprops:
* win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

Add a test for DOM timer throttling on hidden pages.

* fast/dom/timer-throttling-hidden-page-expected.txt: Added.
* fast/dom/timer-throttling-hidden-page.html: Added.
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/qt/TestExpectations:
* platform/win/TestExpectations:
Skip the test since HIDDEN_PAGE_DOM_TIMER_THROTTLING is not enabled by default.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago1.18MB below RenderTableSection::setCachedCollapsedBorderValue() on Membuster3.
kling@webkit.org [Tue, 9 Oct 2012 05:12:56 +0000 (05:12 +0000)]
1.18MB below RenderTableSection::setCachedCollapsedBorderValue() on Membuster3.
<http://webkit.org/b/98670>
<rdar://problem/12454276>

Reviewed by Anders Carlsson.

Refactor CollapsedBorderValue to only store the bits and pieces from the BorderValue
that it actually needs. Packed the whole thing into 64 bits.

Reduces memory consumption by 547kB on Membuster3.

* rendering/RenderTableCell.cpp:

    Add compile-time size assertion for CollapsedBorderValue.

* rendering/style/CollapsedBorderValue.h:
(WebCore::CollapsedBorderValue::CollapsedBorderValue):
(WebCore::CollapsedBorderValue::width):
(WebCore::CollapsedBorderValue::style):
(WebCore::CollapsedBorderValue::color):
(WebCore::CollapsedBorderValue::isTransparent):
(WebCore::CollapsedBorderValue::precedence):
(WebCore::CollapsedBorderValue::isSameIgnoringColor):
(CollapsedBorderValue):

    Apply shrinkwrap to CollapsedBorderValue. Removed specialized copy constructor since
    the class only has primitive members now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoHTMLSelectElement::typeAheadFind depends on implementation dependent behavior
yosin@chromium.org [Tue, 9 Oct 2012 04:47:07 +0000 (04:47 +0000)]
HTMLSelectElement::typeAheadFind depends on implementation dependent behavior
https://bugs.webkit.org/show_bug.cgi?id=98710

Reviewed by Kent Tamura.

Source/WebCore:

This patch gets rid of C/C++ implementation dependent behavior from
HTMLSelectElement::typeAheadFind() which does modulo operation with
a negative operand.

HTMLSelectElement::typeAheadFind() contains expression with modulo
operator and dividend can be -1 when the "select" element without
"option" element but "optgroup" element.

Test: fast/forms/select/select-typeahead-crash.html

* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::typeAheadFind): Changed to do modulo
operation with both operands are non-negative.

LayoutTests:

This patch adds a test for checking HTMLSelectElement::typeAheadFind
doesn't crash.

* fast/forms/select/select-typeahead-crash-expected.txt: Added.
* fast/forms/select/select-typeahead-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTake account of overflowing values for width calculation of a year sub-field
tkent@chromium.org [Tue, 9 Oct 2012 02:18:20 +0000 (02:18 +0000)]
Take account of overflowing values for width calculation of a year sub-field
https://bugs.webkit.org/show_bug.cgi?id=98506

Reviewed by Eric Seidel.

Source/WebCore:

When we decide the width of a year field of an input[type=date]
with the multiple fields UI, we need to take account of the
current value width because we allow to set overflowing values to
the input[type=date].

This change affects only platforms with INPUT_TYPE_DATE &&
INPUT_MULTIPLE_FIELDS_UI.

Test: fast/forms/date-multiple-fields/date-multiple-fields-change-layout-by-value.html

* html/shadow/DateTimeNumericFieldElement.cpp:
(WebCore::DateTimeNumericFieldElement::customStyleForRenderer):
Take account of the current value width.

LayoutTests:

* fast/forms/date-multiple-fields/date-multiple-fields-change-layout-by-value-expected.txt: Added.
* fast/forms/date-multiple-fields/date-multiple-fields-change-layout-by-value.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChromium DEPS roll r160657:160764.
dpranke@chromium.org [Tue, 9 Oct 2012 01:52:58 +0000 (01:52 +0000)]
Chromium DEPS roll r160657:160764.

Unreviewed.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoimage not displayed in flexbox
tony@chromium.org [Tue, 9 Oct 2012 01:52:21 +0000 (01:52 +0000)]
image not displayed in flexbox
https://bugs.webkit.org/show_bug.cgi?id=98611

Reviewed by Ojan Vafai.

Source/WebCore:

Flexbox will override the width of a child and when stretching, will override the height of the child.
When this happens, when an image loads, it checks to see if it's width/height has
changed, and if so, does a relayout.  The overridden width/height was preventing this
relayout from happening.

To fix, we clear all the override sizes when we're done laying out the flex children.

Test: css3/flexbox/relayout-image-load.html

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock): Clear child override sizes.
(WebCore::RenderFlexibleBox::clearChildOverrideSizes):
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes): No longer need to clear the override size
here since it should have already been cleared.
* rendering/RenderFlexibleBox.h:

LayoutTests:

Load an image after flexbox layout has happened.

* css3/flexbox/relayout-image-load-expected.txt: Added.
* css3/flexbox/relayout-image-load.html: Added.
* platform/chromium/TestExpectations: Remove css3/flexbox/flexitem-stretch-image.html
since it should no longer be flaky.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSkip Layout/subtree-detaching.html temporarily as it's very noisy and
rniwa@webkit.org [Tue, 9 Oct 2012 01:48:12 +0000 (01:48 +0000)]
Skip Layout/subtree-detaching.html temporarily as it's very noisy and
takes 112s to run on Chromium Mac. This is tracked by the bug 98708.

* Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r130643): editing/pasteboard/data-transfer-item is failing on chromium.
kling@webkit.org [Tue, 9 Oct 2012 01:44:55 +0000 (01:44 +0000)]
REGRESSION(r130643): editing/pasteboard/data-transfer-item is failing on chromium.
<http://webkit.org/b/98686>

Reviewed by Tony Chang.

Change ChromiumDataObject::createFromPasteboard() to use a ListHashSet instead of a HashSet so that
item order is preserved.

* platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::createFromPasteboard):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPerf. test results page is broken when runs have different sets of tests
rniwa@webkit.org [Tue, 9 Oct 2012 01:43:08 +0000 (01:43 +0000)]
Perf. test results page is broken when runs have different sets of tests
https://bugs.webkit.org/show_bug.cgi?id=98691

Reviewed by Daniel Bates.

Add "missing" columns for tests that are missing some runs.

Also fix regressions from the previous patch:
- Make reference run switch work again
- Load jquery plugins from the remote server when the jquery is loaded from the remote server.

* resources/results-template.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoInline logicalHeightForRowSizing to shave another 2-3% off robohornet's resizecol...
eric@webkit.org [Tue, 9 Oct 2012 01:39:20 +0000 (01:39 +0000)]
Inline logicalHeightForRowSizing to shave another 2-3% off robohornet's resizecol.html
https://bugs.webkit.org/show_bug.cgi?id=98703

Reviewed by Emil A Eklund.

This is very small potatoes.  There are much bigger wins for table layout yet, but
this was an easy win.

This function should probably be converted to use int's only, as table cells are pixel-sized
according to our subpixel-experts.

Also, I suspect there should be ways to early return with less-math in the common cases, but
I've saved such for a later patch.

Note that I changed from using paddingBefore/paddingAfter (which include the instrinsic padding)
to calling computedCSSPaddingBefore/computedCSSPaddingAfter directly as well.

This single function is about 11% of total time for robohornet's resizecol.

* rendering/RenderTableCell.cpp:
* rendering/RenderTableCell.h:
(WebCore::RenderTableCell::logicalHeightForRowSizing):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoresults.html and garden-o-matic are ignoring IMAGE failures when expected to FAIL
dpranke@chromium.org [Tue, 9 Oct 2012 01:36:26 +0000 (01:36 +0000)]
results.html and garden-o-matic are ignoring IMAGE failures when expected to FAIL
https://bugs.webkit.org/show_bug.cgi?id=98706

Reviewed by Ojan Vafai.

FAIL is supposed to map onto Failure which is supposed to map
onto the old [ TEXT, IMAGE_PLUS_TEXT, AUDIO ] mapping.
results.html was including IMAGE in this and garden-o-matic was
including CRASH and TIMEOUT as well :(.

Tools:

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:

LayoutTests:

* fast/harness/resources/results-test.js:
* fast/harness/results.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: remove autogenerated objectStore/index id code
alecflett@chromium.org [Tue, 9 Oct 2012 01:17:59 +0000 (01:17 +0000)]
IndexedDB: remove autogenerated objectStore/index id code
https://bugs.webkit.org/show_bug.cgi?id=98085

Reviewed by Tony Chang.

Source/WebCore:

Remove support for backend-generated objectstore and index
ids. The frontend objects now manage that state during
versionchange transactions. The IDBDatabaseBackendInterface and
IDBObjectStoreBackendInterface methods will go away when
https://bugs.webkit.org/show_bug.cgi?id=98682 lands.

No new tests as this is part of a refactoring, existing indexeddb
tests cover correctness.

* Modules/indexeddb/IDBBackingStore.h:
(IDBBackingStore):
* Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::createObjectStore):
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::createObjectStoreInternal):
(WebCore::IDBDatabaseBackendImpl::loadObjectStores):
* Modules/indexeddb/IDBDatabaseBackendInterface.h:
(IDBDatabaseBackendInterface):
* Modules/indexeddb/IDBLevelDBBackingStore.cpp:
(WebCore::IDBLevelDBBackingStore::createObjectStore):
(WebCore::setMaxIndexId):
(WebCore::IDBLevelDBBackingStore::createIndex):
* Modules/indexeddb/IDBLevelDBBackingStore.h:
(IDBLevelDBBackingStore):
* Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::createIndex):
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::IDBObjectStoreBackendImpl):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::createIndexInternal):
* Modules/indexeddb/IDBObjectStoreBackendInterface.h:

Source/WebKit/chromium:

Remove support for unused createObjectStore/createIndex. These
methods will go away entirely when
https://bugs.webkit.org/show_bug.cgi?id=98682 is fixed.

* src/IDBDatabaseBackendProxy.cpp:
(WebKit::IDBDatabaseBackendProxy::createObjectStore):
* src/WebIDBDatabaseImpl.cpp:
* src/WebIDBDatabaseImpl.h:
(WebIDBDatabaseImpl):
* src/WebIDBObjectStoreImpl.cpp:
* src/WebIDBObjectStoreImpl.h:
(WebIDBObjectStoreImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Build ControlTheme only when necessary
ryuan.choi@samsung.com [Tue, 9 Oct 2012 00:59:13 +0000 (00:59 +0000)]
[EFL] Build ControlTheme only when necessary
https://bugs.webkit.org/show_bug.cgi?id=98519

Reviewed by Eric Seidel.

* EWebLauncher/ControlTheme/CMakeLists.txt:
Added custom command keyword not to build ControlTheme every time.
In addition, removed `ALL` keyword because targets, which use ControlTheme,
already have dependency.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CAIRO] Adjust the source rect size when IMAGE_DECODER_DOWN_SAMPLING is enabled
commit-queue@webkit.org [Tue, 9 Oct 2012 00:55:34 +0000 (00:55 +0000)]
[CAIRO] Adjust the source rect size when IMAGE_DECODER_DOWN_SAMPLING is enabled
https://bugs.webkit.org/show_bug.cgi?id=98630

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2012-10-08
Reviewed by Martin Robinson.

IMAGE_DECODER_DOWN_SAMPLING scales down the size of the big image.
CAIRO needs to adjust the source size to the scaled value.

No new tests.

* platform/graphics/cairo/BitmapImageCairo.cpp:
(WebCore::BitmapImage::draw):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove unused features of BlobBuilder
abarth@webkit.org [Tue, 9 Oct 2012 00:08:57 +0000 (00:08 +0000)]
Remove unused features of BlobBuilder
https://bugs.webkit.org/show_bug.cgi?id=98331

Reviewed by Eric Seidel.

Now that we don't expose BlobBuilder as a web platform API, we can
strip down the class to handle only those cases that are needed by the
Blob constructor.

I've also renamed the class from WebKitBlobBuilder to BlobBuilder and
made it stack allocated rather than RefCounted. A future patch will
actually move the files around. (I didn't want to mix moving code
around with modifying the code.)

* bindings/js/JSBlobCustom.cpp:
(WebCore::JSBlobConstructor::constructJSBlob):
* bindings/v8/custom/V8BlobCustom.cpp:
(WebCore::V8Blob::constructorCallback):
* fileapi/WebKitBlobBuilder.cpp:
(WebCore):
(WebCore::BlobBuilder::BlobBuilder):
(WebCore::BlobBuilder::getBuffer):
(WebCore::BlobBuilder::append):
(WebCore::BlobBuilder::appendBytesData):
(WebCore::BlobBuilder::getBlob):
* fileapi/WebKitBlobBuilder.h:
(WebCore):
(BlobBuilder):
* page/FeatureObserver.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTry to fix the debug build after r130699
mrobinson@webkit.org [Tue, 9 Oct 2012 00:02:53 +0000 (00:02 +0000)]
Try to fix the debug build after r130699

Move the assignment of the ResourceHandleInternal local to before
the include statement where it is used.

* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::createSoupMessageForHandleAndRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDo not swallow fatal messages in qt/DumpRenderTree
commit-queue@webkit.org [Mon, 8 Oct 2012 23:33:55 +0000 (23:33 +0000)]
Do not swallow fatal messages in qt/DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=98211

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-10-08
Reviewed by Eric Seidel.

Fix condition in message type filtering.

* DumpRenderTree/qt/DumpRenderTreeMain.cpp:
(messageHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNot reviewed. Rebaselines for Chromium.
hclam@chromium.org [Mon, 8 Oct 2012 23:31:40 +0000 (23:31 +0000)]
Not reviewed. Rebaselines for Chromium.

Rebaseline after r130412 which affected image scaling pixel tests.

* platform/chromium-linux-x86/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png: Added.
* platform/chromium-linux-x86/fast/backgrounds/size/backgroundSize15-expected.png: Added.
* platform/chromium-linux-x86/fast/backgrounds/size/contain-and-cover-expected.png: Added.
* platform/chromium-linux-x86/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
* platform/chromium-linux-x86/fast/borders/border-image-scale-transform-expected.png: Added.
* platform/chromium-linux-x86/fast/borders/border-image-scaled-expected.png: Added.
* platform/chromium-linux-x86/fast/borders/border-image-slice-constrained-expected.png: Added.
* platform/chromium-linux-x86/fast/borders/inline-mask-overlay-image-outset-expected.png: Added.
* platform/chromium-linux-x86/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png: Added.
* platform/chromium-linux-x86/fast/borders/scaled-border-image-expected.png: Added.
* platform/chromium-linux-x86/fast/repaint/background-misaligned-expected.png:
* platform/chromium-linux-x86/scrollbars/overflow-scrollbar-combinations-expected.png: Added.
* platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png: Added.
* platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png: Added.
* platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png: Added.
* platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png: Added.
* platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png: Added.
* platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png: Added.
* platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png: Added.
* platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png: Added.
* platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png: Added.
* platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png: Added.
* platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png: Added.
* platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png: Added.
* platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png: Added.
* platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png: Added.
* platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png: Added.
* platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-no-markup-expected.png: Added.
* platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png: Added.
* platform/chromium-linux-x86/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png: Added.
* platform/chromium-linux-x86/svg/as-border-image/svg-as-border-image-expected.png: Added.
* platform/chromium-linux-x86/svg/custom/clip-mask-negative-scale-expected.png: Added.
* platform/chromium-linux-x86/svg/custom/image-small-width-height-expected.png: Added.
* platform/chromium-linux-x86/svg/custom/pointer-events-image-css-transform-expected.png: Added.
* platform/chromium-linux-x86/svg/custom/pointer-events-image-expected.png: Added.
* platform/chromium-linux-x86/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
* platform/chromium-linux-x86/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
* platform/chromium-linux-x86/svg/zoom/page/zoom-background-images-expected.png: Added.
* platform/chromium-linux/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
* platform/chromium-linux/fast/backgrounds/size/backgroundSize15-expected.png:
* platform/chromium-linux/fast/backgrounds/size/contain-and-cover-expected.png:
* platform/chromium-linux/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
* platform/chromium-linux/fast/borders/border-image-scale-transform-expected.png:
* platform/chromium-linux/fast/borders/border-image-scaled-expected.png:
* platform/chromium-linux/fast/borders/border-image-slice-constrained-expected.png: Added.
* platform/chromium-linux/fast/borders/inline-mask-overlay-image-outset-expected.png:
* platform/chromium-linux/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png:
* platform/chromium-linux/fast/borders/scaled-border-image-expected.png:
* platform/chromium-linux/fast/repaint/background-misaligned-expected.png:
* platform/chromium-linux/scrollbars/overflow-scrollbar-combinations-expected.png:
* platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
* platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
* platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
* platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
* platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
* platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
* platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
* platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
* platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
* platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
* platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
* platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
* platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
* platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
* platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
* platform/chromium-linux/svg/W3C-I18N/text-anchor-no-markup-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
* platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.png:
* platform/chromium-linux/svg/custom/clip-mask-negative-scale-expected.png:
* platform/chromium-linux/svg/custom/image-small-width-height-expected.png:
* platform/chromium-linux/svg/custom/pointer-events-image-css-transform-expected.png:
* platform/chromium-linux/svg/custom/pointer-events-image-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-background-images-expected.png:
* platform/chromium-mac-snowleopard/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
* platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize15-expected.png:
* platform/chromium-mac-snowleopard/fast/backgrounds/size/contain-and-cover-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/borders/border-image-scale-transform-expected.png:
* platform/chromium-mac-snowleopard/fast/borders/border-image-scaled-expected.png:
* platform/chromium-mac-snowleopard/fast/borders/border-image-slice-constrained-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/borders/inline-mask-overlay-image-outset-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/borders/scaled-border-image-expected.png:
* platform/chromium-mac-snowleopard/fast/repaint/background-misaligned-expected.png:
* platform/chromium-mac-snowleopard/scrollbars/overflow-scrollbar-combinations-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-no-markup-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
* platform/chromium-mac-snowleopard/svg/as-border-image/svg-as-border-image-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/clip-mask-negative-scale-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/image-small-width-height-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/pointer-events-image-css-transform-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/pointer-events-image-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-background-images-expected.png: Added.
* platform/chromium-mac/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
* platform/chromium-mac/fast/backgrounds/size/backgroundSize15-expected.png:
* platform/chromium-mac/fast/backgrounds/size/contain-and-cover-expected.png:
* platform/chromium-mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
* platform/chromium-mac/fast/borders/border-image-scale-transform-expected.png:
* platform/chromium-mac/fast/borders/border-image-scaled-expected.png:
* platform/chromium-mac/fast/borders/border-image-slice-constrained-expected.png:
* platform/chromium-mac/fast/borders/inline-mask-overlay-image-outset-expected.png:
* platform/chromium-mac/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png:
* platform/chromium-mac/fast/borders/scaled-border-image-expected.png:
* platform/chromium-mac/fast/repaint/background-misaligned-expected.png:
* platform/chromium-mac/scrollbars/overflow-scrollbar-combinations-expected.png:
* platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
* platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
* platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
* platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
* platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
* platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
* platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
* platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
* platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
* platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
* platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
* platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
* platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
* platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
* platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
* platform/chromium-mac/svg/W3C-I18N/text-anchor-no-markup-expected.png:
* platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
* platform/chromium-mac/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
* platform/chromium-mac/svg/as-border-image/svg-as-border-image-expected.png:
* platform/chromium-mac/svg/custom/clip-mask-negative-scale-expected.png:
* platform/chromium-mac/svg/custom/image-small-width-height-expected.png:
* platform/chromium-mac/svg/custom/pointer-events-image-css-transform-expected.png:
* platform/chromium-mac/svg/custom/pointer-events-image-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
* platform/chromium-mac/svg/zoom/page/zoom-background-images-expected.png:
* platform/chromium-win-xp/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png: Added.
* platform/chromium-win-xp/fast/backgrounds/size/backgroundSize15-expected.png: Added.
* platform/chromium-win-xp/fast/backgrounds/size/contain-and-cover-expected.png: Added.
* platform/chromium-win-xp/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
* platform/chromium-win-xp/fast/borders/border-image-scale-transform-expected.png: Added.
* platform/chromium-win-xp/fast/borders/border-image-scaled-expected.png: Added.
* platform/chromium-win-xp/fast/borders/border-image-slice-constrained-expected.png: Added.
* platform/chromium-win-xp/fast/borders/inline-mask-overlay-image-outset-expected.png: Added.
* platform/chromium-win-xp/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png: Added.
* platform/chromium-win-xp/fast/borders/scaled-border-image-expected.png: Added.
* platform/chromium-win-xp/fast/repaint/background-misaligned-expected.png:
* platform/chromium-win-xp/scrollbars/overflow-scrollbar-combinations-expected.png: Added.
* platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
* platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
* platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
* platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
* platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
* platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
* platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
* platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
* platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
* platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
* platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
* platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
* platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
* platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
* platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
* platform/chromium-win-xp/svg/W3C-I18N/text-anchor-no-markup-expected.png:
* platform/chromium-win-xp/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png: Added.
* platform/chromium-win-xp/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png: Added.
* platform/chromium-win-xp/svg/as-border-image/svg-as-border-image-expected.png: Added.
* platform/chromium-win-xp/svg/custom/clip-mask-negative-scale-expected.png: Added.
* platform/chromium-win-xp/svg/custom/image-small-width-height-expected.png: Added.
* platform/chromium-win-xp/svg/custom/pointer-events-image-css-transform-expected.png: Added.
* platform/chromium-win-xp/svg/custom/pointer-events-image-expected.png: Added.
* platform/chromium-win-xp/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
* platform/chromium-win-xp/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
* platform/chromium-win-xp/svg/zoom/page/zoom-background-images-expected.png: Added.
* platform/chromium-win/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
* platform/chromium-win/fast/backgrounds/size/backgroundSize15-expected.png:
* platform/chromium-win/fast/backgrounds/size/contain-and-cover-expected.png:
* platform/chromium-win/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
* platform/chromium-win/fast/borders/border-image-scale-transform-expected.png:
* platform/chromium-win/fast/borders/border-image-scaled-expected.png:
* platform/chromium-win/fast/borders/border-image-slice-constrained-expected.png:
* platform/chromium-win/fast/borders/inline-mask-overlay-image-outset-expected.png:
* platform/chromium-win/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png:
* platform/chromium-win/fast/borders/scaled-border-image-expected.png:
* platform/chromium-win/fast/repaint/background-misaligned-expected.png:
* platform/chromium-win/scrollbars/overflow-scrollbar-combinations-expected.png:
* platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
* platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
* platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
* platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
* platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
* platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
* platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
* platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
* platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
* platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
* platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
* platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
* platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
* platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
* platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
* platform/chromium-win/svg/W3C-I18N/text-anchor-no-markup-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
* platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.png:
* platform/chromium-win/svg/custom/clip-mask-negative-scale-expected.png:
* platform/chromium-win/svg/custom/image-small-width-height-expected.png:
* platform/chromium-win/svg/custom/pointer-events-image-css-transform-expected.png:
* platform/chromium-win/svg/custom/pointer-events-image-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-background-images-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoVersioning.
lforschler@apple.com [Mon, 8 Oct 2012 23:24:03 +0000 (23:24 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPost-r130226 Cleanup: Comment a complicated if statement and make it a helper.
japhet@chromium.org [Mon, 8 Oct 2012 23:20:33 +0000 (23:20 +0000)]
Post-r130226 Cleanup: Comment a complicated if statement and make it a helper.
https://bugs.webkit.org/show_bug.cgi?id=98463

Reviewed by Eric Seidel.

No new tests, refactor only.

* rendering/RenderLayer.cpp:
(WebCore::frameElementAndViewPermitScroll):
(WebCore::RenderLayer::scrollRectToVisible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Soup] Simplify the way that requests are started
mrobinson@webkit.org [Mon, 8 Oct 2012 23:12:33 +0000 (23:12 +0000)]
[Soup] Simplify the way that requests are started
https://bugs.webkit.org/show_bug.cgi?id=98532

Reviewed by Gustavo Noronha Silva.

Simplify the creation of the libsoup request and message when kicking off
requests, by elminating a bit of duplicate code.

No new tests. This should not change any behavior.

* platform/network/ResourceHandle.h:
(ResourceHandle):
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore):
(WebCore::ResourceHandleInternal::soupSession): Ensure the session
is initialized when passing it to the caller.
(WebCore::createSoupMessageForHandleAndRequest): Added this helper which
takes care of creating the SoupMessage for HTTP/HTTPS requests.
(WebCore::createSoupRequestAndMessageForHandle): Collapsed the HTTP and
non-HTTP request creation into this helper.
(WebCore::ResourceHandle::start): Call the new helper now and then sendPendingRequest.
(WebCore::ResourceHandle::sendPendingRequest): Instead of having special
helpers to create and send the request, duplicating the logic for sending it
across the file, add this method which can be used in both cases.
(WebCore::waitingToSendRequest): Reworked the hasBeenSent method to answer
the question of whether or not the request is ready to be sent, but is unsent.
(WebCore::ResourceHandle::platformSetDefersLoading): Use the new helper.
* platform/network/soup/ResourceRequest.h:
(ResourceRequest): Added a new method for getting the URL string for soup.
* platform/network/soup/ResourceRequestSoup.cpp:
(WebCore::ResourceRequest::urlStringForSoup): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake no-column table-layout cases a little faster with inlining
eric@webkit.org [Mon, 8 Oct 2012 22:59:36 +0000 (22:59 +0000)]
Make no-column table-layout cases a little faster with inlining
https://bugs.webkit.org/show_bug.cgi?id=98566

Reviewed by Julien Chaffraix.

This change is almost not worth it at only a couple percent boost on
http://www.robohornet.org/tests/resizecol.html
However, I think the logicalWidthFromTableColumn split it kinda nice
so I've decided to post it anyway.

* rendering/RenderTable.cpp:
(WebCore::RenderTable::slowColElement):
* rendering/RenderTable.h:
(WebCore::RenderTable::colElement):
(RenderTable):
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::logicalWidthFromTableColumn):
* rendering/RenderTableCell.h:
(WebCore::RenderTableCell::styleOrColLogicalWidth):
(RenderTableCell):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed Chromium gardening.
jchaffraix@webkit.org [Mon, 8 Oct 2012 22:58:06 +0000 (22:58 +0000)]
Unreviewed Chromium gardening.

* platform/chromium/TestExpectations:
Marked a test as crashing on Lion.

* platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-expected.png:
* platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-expected.png:
* platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
* platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-expected.png:
* platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
* platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
Rebaselined these tests after a change in Chromium compositor (Chromium r160671).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Moving myself from Committer to Reviewer list.
caio.oliveira@openbossa.org [Mon, 8 Oct 2012 22:41:55 +0000 (22:41 +0000)]
Unreviewed. Moving myself from Committer to Reviewer list.
http://lists.webkit.org/pipermail/webkit-dev/2012-October/022460.html

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGeneralize moving URLComponent's begin position
benjamin@webkit.org [Mon, 8 Oct 2012 22:31:45 +0000 (22:31 +0000)]
Generalize moving URLComponent's begin position
https://bugs.webkit.org/show_bug.cgi?id=98626

Reviewed by Adam Barth.

The patch r130609 introduced moving URLComponents's position.
It turns out this concept is really useful in the parser so
this patch generalize the idea.

* wtf/url/api/ParsedURL.cpp:
(WTF::ParsedURL::removePort):
* wtf/url/src/URLCanonEtc.cpp:
* wtf/url/src/URLComponent.h:
(WTF::URLComponent::moveBy):
Rename URLComponent::move() to URLComponent::moveBy() for consistency
with some of WebCore types.

* wtf/url/src/URLParse.cpp:
* wtf/url/src/URLParseFile.cpp:

* wtf/url/src/URLSegments.cpp:
(WTF::URLSegments::moveFromComponentBy):
Change the semantic to everything from a certain component. This is
useful to move everything, including the scheme.

* wtf/url/src/URLSegments.h:
(URLSegments):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRename RenderObject::firstLineStyleSlowCase() to a more appropriate cachedFirstLineSt...
commit-queue@webkit.org [Mon, 8 Oct 2012 22:30:22 +0000 (22:30 +0000)]
Rename RenderObject::firstLineStyleSlowCase() to a more appropriate cachedFirstLineStyle()
https://bugs.webkit.org/show_bug.cgi?id=98631

Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2012-10-08
Reviewed by Eric Seidel.

Renaming firstLineStyleSlowCase() to cachedFirstLineStyle().

The current name is confusing since the function actually gets the
the cached first-line styles.
It also makes the name more descriptive of its functionality
and in accordance with RenderObject::uncachedFirstLineStyle().

No new tests required for this change since no change in behavior is expected.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::cachedFirstLineStyle):
* rendering/RenderObject.h:
(WebCore::RenderObject::firstLineStyle):
(RenderObject):
Renamed RenderObject::firstLineStyleSlowCase() to cachedFirstLineStyle()
and made the associated changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTry to fix Windows build by exporting Frame::layerTreeAsText().
simon.fraser@apple.com [Mon, 8 Oct 2012 22:22:43 +0000 (22:22 +0000)]
Try to fix Windows build by exporting Frame::layerTreeAsText().

* win/WebKit2.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSome non-scrollable elements are added to non-fast-scrollable region
commit-queue@webkit.org [Mon, 8 Oct 2012 22:15:44 +0000 (22:15 +0000)]
Some non-scrollable elements are added to non-fast-scrollable region
https://bugs.webkit.org/show_bug.cgi?id=97927

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-10-08
Reviewed by James Robinson.

Source/WebCore:

Only RenderLayers that can actually be scrolled should be added to the
ScrollingCoordinator's non-fast scrollable region. Otherwise we may
needlessly fall back to main thread scrolling.

Test: ScrollingCoordinatorChromiumTest.clippedBodyTest

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateScrollbarsAfterLayout):
(WebCore::RenderLayer::updateScrollbarsAfterStyleChange):

Source/WebKit/chromium:

Test that a non-scrollable RenderLayer isn't added to the non-fast scrollable
region.

The test in this patch consists of a web page where both the html and
body elements clip horizontal overflow. This results in a hierarchy
where the body element gets a scrollable RenderLayer. However, that
layer isn't (interactively) scrollable because while the scroll geometry
is calculated based on the amount of overflow, the scroll bars are
hidden because of the "overflow-x: hidden" style.

Previously this layer would have made the entire page part of the
non-fast scrollable region. With this patch,
RenderLayer::allowScrolling() is used as a pre-requisite for expanding
the region, thus avoiding the problem.

* tests/ScrollingCoordinatorChromiumTest.cpp:
(WebKit::TEST_F):
(WebKit):
* tests/data/clipped-body.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMac Chromium: Ignore system numpad modifier
commit-queue@webkit.org [Mon, 8 Oct 2012 22:07:19 +0000 (22:07 +0000)]
Mac Chromium: Ignore system numpad modifier
https://bugs.webkit.org/show_bug.cgi?id=97161

Patch by Sailesh Agrawal <sail@chromium.org> on 2012-10-08
Reviewed by Tony Chang.

On Mac, arrow key events have numpad modifier set. This is inconsistent with other platforms.

My fix is to only rely on keycode to decide when to set the numpad modifier.

This code is not exersided by layout tests so I added a new unit test for this.

* WebKit.gypi:
* WebKitUnitTests.gyp:
* src/mac/WebInputEventFactory.mm:
(WebKit::isKeypadEvent): Removed check for numpad modifier.
* tests/WebInputEventFactoryTestMac.mm: Added.
(TEST): Added new test for WebInputEventFactory::keyboardEvent().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonrwt: [chromium] run http tests in parallel on bigger machines
dpranke@chromium.org [Mon, 8 Oct 2012 22:06:07 +0000 (22:06 +0000)]
nrwt: [chromium] run http tests in parallel on bigger machines
https://bugs.webkit.org/show_bug.cgi?id=98562

Reviewed by Eric Seidel.

The "locked tests" shard (which includes the http tests and the
perf tests) is the long pole on machines where we have 4 or more
workers, so we should start making sure that
we can run http tests in parallel, following the normal sharding
rules (all tests in the same directory are in the same shard by
default). We should still probably limit the number of workers
hitting the web server in parallel where we can; a heuristic of
no more than 25% of them seems okay for a start. This will
likely only affect developer workstations and a couple of bots
at first, so should be low risk and a good reward.

* Scripts/webkitpy/layout_tests/port/base.py:
(Port.default_max_locked_shards):
* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort.default_max_locked_shards):
* Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
(ChromiumPortTestCase.test_default_max_locked_shards):
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
(PortTestCase.test_default_max_locked_shards):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(_set_up_derived_options):
(parse_args):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_max_locked_shards):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove layerTreeAsText to window.internals
simon.fraser@apple.com [Mon, 8 Oct 2012 21:55:10 +0000 (21:55 +0000)]
Move layerTreeAsText to window.internals
https://bugs.webkit.org/show_bug.cgi?id=98690

Reviewed by James Robinson.

Add window.internals.layerTreeAsText(document), and change the tests to use it.
I'll remove testRunner.layerTreeAsText() in a later patch.

Source/WebCore:

* testing/Internals.cpp:
(WebCore::Internals::layerTreeAsText):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:

LayoutTests:

* compositing/animation/animation-compositing.html:
* compositing/backing/no-backing-for-clip-overlap.html:
* compositing/backing/no-backing-for-clip.html:
* compositing/backing/no-backing-for-perspective.html:
* compositing/bounds-in-flipped-writing-mode.html:
* compositing/clip-child-by-non-stacking-ancestor.html:
* compositing/columns/composited-in-paginated.html:
* compositing/geometry/ancestor-overflow-change.html:
* compositing/geometry/bounds-clipped-composited-child.html:
* compositing/geometry/bounds-ignores-hidden-composited-descendant.html:
* compositing/geometry/bounds-ignores-hidden-dynamic-negzindex.html:
* compositing/geometry/bounds-ignores-hidden-dynamic.html:
* compositing/geometry/bounds-ignores-hidden.html:
* compositing/geometry/clip.html:
* compositing/geometry/composited-in-columns.html:
* compositing/geometry/fixed-position-composited-switch.html:
* compositing/geometry/flipped-writing-mode.html:
* compositing/geometry/foreground-layer.html:
* compositing/geometry/layer-due-to-layer-children-deep-switch.html:
* compositing/geometry/layer-due-to-layer-children-switch.html:
* compositing/geometry/limit-layer-bounds-clipping-ancestor.html:
* compositing/geometry/limit-layer-bounds-fixed-positioned.html:
* compositing/geometry/limit-layer-bounds-opacity-transition.html:
* compositing/geometry/limit-layer-bounds-overflow-root.html:
* compositing/geometry/limit-layer-bounds-positioned-transition.html:
* compositing/geometry/limit-layer-bounds-positioned.html:
* compositing/geometry/limit-layer-bounds-transformed-overflow.html:
* compositing/geometry/limit-layer-bounds-transformed.html:
* compositing/geometry/preserve-3d-switching.html:
* compositing/iframes/become-composited-nested-iframes.html:
* compositing/iframes/become-overlapped-iframe.html:
* compositing/iframes/composited-parent-iframe.html:
* compositing/iframes/connect-compositing-iframe-delayed.html:
* compositing/iframes/connect-compositing-iframe.html:
* compositing/iframes/connect-compositing-iframe2.html:
* compositing/iframes/connect-compositing-iframe3.html:
* compositing/iframes/enter-compositing-iframe.html:
* compositing/iframes/iframe-resize.html:
* compositing/iframes/iframe-size-from-zero.html:
* compositing/iframes/iframe-size-to-zero.html:
* compositing/iframes/iframe-src-change.html:
* compositing/iframes/invisible-nested-iframe-hide.html:
* compositing/iframes/invisible-nested-iframe-show.html:
* compositing/iframes/leave-compositing-iframe.html:
* compositing/iframes/overlapped-iframe-iframe.html:
* compositing/iframes/overlapped-iframe.html:
* compositing/iframes/overlapped-nested-iframes.html:
* compositing/iframes/page-cache-layer-tree.html:
* compositing/iframes/resizer.html:
* compositing/iframes/scrolling-iframe.html:
* compositing/images/clip-on-directly-composited-image.html:
* compositing/layer-creation/animation-overlap-with-children.html:
* compositing/layer-creation/fixed-position-and-transform.html:
* compositing/layer-creation/fixed-position-out-of-view.html:
* compositing/layer-creation/fixed-position-under-transform.html:
* compositing/layer-creation/no-compositing-for-preserve-3d.html:
* compositing/layer-creation/overflow-scroll-overlap.html:
* compositing/layer-creation/overlap-animation.html:
* compositing/layer-creation/overlap-child-layer.html:
* compositing/layer-creation/overlap-clipping.html:
* compositing/layer-creation/overlap-transformed-and-clipped.html:
* compositing/layer-creation/overlap-transformed-layer.html:
* compositing/layer-creation/overlap-transforms.html:
* compositing/layer-creation/rotate3d-overlap.html:
* compositing/layer-creation/scroll-partial-update.html:
* compositing/layer-creation/spanOverlapsCanvas.html:
* compositing/layer-creation/stacking-context-overlap-nested.html:
* compositing/layer-creation/stacking-context-overlap.html:
* compositing/layer-creation/translatez-overlap.html:
* compositing/overflow-trumps-transform-style.html:
* compositing/overflow/clip-descendents.html:
* compositing/overflow/content-gains-scrollbars.html:
* compositing/overflow/content-loses-scrollbars.html:
* compositing/overflow/overflow-auto-with-touch-no-overflow.html:
* compositing/overflow/overflow-auto-with-touch-toggle.html:
* compositing/overflow/overflow-auto-with-touch.html:
* compositing/overflow/overflow-hidden-with-touch.html:
* compositing/overflow/overflow-overlay-with-touch-no-overflow.html:
* compositing/overflow/overflow-overlay-with-touch.html:
* compositing/overflow/overflow-scroll-with-touch-no-overflow.html:
* compositing/overflow/overflow-scrollbar-layers.html:
* compositing/overflow/overflow-visible-with-touch.html:
* compositing/overflow/resize-painting.html:
* compositing/overflow/scrolling-content-clip-to-viewport.html:
* compositing/overflow/textarea-scroll-touch.html:
* compositing/plugins/1x1-composited-plugin.html:
* compositing/plugins/large-to-small-composited-plugin.html:
* compositing/plugins/no-backing-store.html:
* compositing/plugins/small-to-large-composited-plugin.html:
* compositing/rtl/rtl-absolute-overflow-scrolled.html:
* compositing/rtl/rtl-absolute-overflow.html:
* compositing/rtl/rtl-absolute.html:
* compositing/rtl/rtl-fixed-overflow-scrolled.html:
* compositing/rtl/rtl-fixed-overflow.html:
* compositing/rtl/rtl-fixed.html:
* compositing/rtl/rtl-iframe-absolute-overflow-scrolled.html:
* compositing/rtl/rtl-iframe-absolute-overflow.html:
* compositing/rtl/rtl-iframe-absolute.html:
* compositing/rtl/rtl-iframe-fixed-overflow-scrolled.html:
* compositing/rtl/rtl-iframe-fixed-overflow.html:
* compositing/rtl/rtl-iframe-fixed.html:
* compositing/rtl/rtl-iframe-relative.html:
* compositing/rtl/rtl-relative.html:
* compositing/tiled-layers-hidpi.html:
* compositing/tiling/crash-reparent-tiled-layer.html:
* compositing/tiling/huge-layer-add-remove-child.html-disabled:
* compositing/tiling/huge-layer-img.html-disabled:
* compositing/tiling/huge-layer-resize.html-disabled:
* compositing/tiling/huge-layer-with-layer-children-resize.html-disabled:
* compositing/tiling/huge-layer-with-layer-children.html-disabled:
* compositing/tiling/huge-layer.html-disabled:
* compositing/video/video-poster.html:
* compositing/visibility/layer-visible-content.html:
* compositing/visibility/visibility-image-layers-dynamic.html:
* css3/compositing/should-have-compositing-layer.html:
* css3/filters/composited-during-animation-layertree.html:
* css3/filters/composited-during-transition-layertree.html:
* css3/filters/filtered-compositing-descendant.html:
* css3/filters/should-not-have-compositing-layer.html:
* platform/chromium-android/compositing/layer-creation/overflow-scrolling-touch.html:
* platform/chromium/compositing/force-compositing-mode/force-composite-empty.html:
* platform/chromium/compositing/force-compositing-mode/no-overflow-iframe-layer.html:
* platform/chromium/compositing/force-compositing-mode/overflow-hidden-iframe-layer.html:
* platform/chromium/compositing/force-compositing-mode/overflow-iframe-enter-compositing.html:
* platform/chromium/compositing/force-compositing-mode/overflow-iframe-layer.html:
* platform/chromium/compositing/force-compositing-mode/overflow-iframe-leave-compositing.html:
* platform/mac/compositing/canvas/accelerated-canvas-compositing.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd render object that paints plugin snapshots
jonlee@apple.com [Mon, 8 Oct 2012 21:27:29 +0000 (21:27 +0000)]
Add render object that paints plugin snapshots
https://bugs.webkit.org/show_bug.cgi?id=98322
<rdar://problem/12426546>

Reviewed by Simon Fraser.

First, teach plugins to maintain a set of states when plugin snapshotting is enabled.

Second, a new RenderSnapshottedPlugIn class is a RenderEmbeddedObject that knows how to paint
snapshots when the plugin is not visibly playing. It maintains a RenderImageResource to
the generated poster image.

* html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::HTMLPlugInElement): By default all plugins play on load.
* html/HTMLPlugInElement.h: Move the inheritance of ImageLoaderClientBase down to
HTMLPlugInImageElement, since that is the class that actually deals with image-based plugins.
(WebCore::HTMLPlugInElement::displayState): Add bit for display state.
(WebCore::HTMLPlugInElement::setDisplayState):
(WebCore::HTMLPlugInElement::updateSnapshot):

* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): If plugin snapshotting is
enabled, plugin state is set to wait for a poster image.
(WebCore::HTMLPlugInImageElement::createRenderer): Create RenderSnapshottedPlugIn if
plugin snapshotting is enabled.
(WebCore::HTMLPlugInImageElement::updateSnapshot): Once a snapshot is available, update the
renderer and set its state to wait for user input to start the plugin.
* html/HTMLPlugInImageElement.h:
(HTMLPlugInImageElement):

* rendering/RenderObject.h:
(WebCore::RenderObject::isSnapshottedPlugIn): Add new function to identify
RenderSnapshottedPlugIn instances. Since RenderSnapshottedPlugIn inherits from
RenderEmbeddedObject, isEmbeddedObject() still returns true.
* rendering/RenderEmbeddedObject.h:
(RenderEmbeddedObject): Elevate a few virtual methods to protected for
RenderSnapshottedPlugIn to override.

* rendering/RenderSnapshottedPlugIn.cpp: Added.
(WebCore::RenderSnapshottedPlugIn::RenderSnapshottedPlugIn): Initialize snapshot
resource.
(WebCore::RenderSnapshottedPlugIn::~RenderSnapshottedPlugIn): Shut down snapshot
image resource to remove the renderer as a client, and remove image from memory cache.
(WebCore::RenderSnapshottedPlugIn::plugInImageElement): Convenience function to get the
HTML element.
(WebCore::RenderSnapshottedPlugIn::updateSnapshot): Cache the snapshot, and repaint.
(WebCore::RenderSnapshottedPlugIn::paint): If the plugin is not playing, paint like a
RenderImage does.
(WebCore::RenderSnapshottedPlugIn::paintReplaced): Paint the snapshot and overlay if the
plugin is not playing.
(WebCore::RenderSnapshottedPlugIn::paintReplacedSnapshot): Inspired by
RenderImage::paintReplaced() and RenderImage::paintIntoRect().
* rendering/RenderSnapshottedPlugIn.h: Added.
(WebCore::RenderSnapshottedPlugIn::isSnapshottedPlugin): Returns true.

* rendering/RenderTheme.h: Add a function that paints the overlay on top of the snapshot.
* rendering/RenderThemeMac.h:
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintPlugInSnapshotOverlay):

* WebCore.xcodeproj/project.pbxproj: Add new RenderSnapshottedPlugIn class.
* CMakeLists.txt: Ditto.
* GNUmakefile.list.am: Ditto.
* Target.pri: Ditto.
* WebCore.gypi: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* rendering/RenderingAllInOne.cpp: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Exclusions] Add support for polygonal shapes
commit-queue@webkit.org [Mon, 8 Oct 2012 21:20:15 +0000 (21:20 +0000)]
[CSS Exclusions] Add support for polygonal shapes
https://bugs.webkit.org/show_bug.cgi?id=96811

Patch by Hans Muller <hmuller@adobe.com> on 2012-10-08
Reviewed by Dirk Schulze.

Source/WebCore:

Initial version of the layout support for polygonal exclusion shapes: the ExclusionPolygon class.
Supports the public ExclusionShape operations using the algorithm described here:
http://hansmuller-webkit.blogspot.com/2012/06/horizontal-box-polygon-intersection-for.html.
Although both the "included" and "excluded" operations are supported, only the former is
used, since only shape-inside is supported at the moment.

The ExclusionPolygon class stores the polygon's edges in an interval tree.

Polygon edges are represented by the ExclusionPolygonEdge struct, which records the indices of
the pair of vertices joined by the edge.  Edge vertex index1 is usually less than index2, except
the last edge where index2 is 0.  We plan to improve the algorithm that creates the edges
by spanning vertices contained in sequences of more than two colinear vertices. For example,
a triangular polygon might be specified with 5 vertices like this: 3,0 5,0, 5,5, 4,4 2,2, 0,0.
By spanning the extra colinear points: 0,0 5,0, 5,5, which implies index1-index2 edges: 5-1 1-2 2-5.

Although the implementation supports complex polygons, the layout code is limited to
essentially rectangular shapes until a patch for https://bugs.webkit.org/show_bug.cgi?id=96813
lands.

Tests: fast/exclusions/shape-inside/shape-inside-polygon-rectangle.html
       fast/exclusions/shape-inside/shape-inside-simple-polygon-001.html
       fast/exclusions/shape-inside/shape-inside-simple-polygon-002.html
       fast/exclusions/shape-inside/shape-inside-simple-polygon-003.html
       fast/exclusions/shape-inside/shape-inside-simple-polygon-004.html

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* rendering/ExclusionPolygon.cpp: Added.
(WebCore):
(EdgeIntersection): Internal description of the intersection of a polygon edge and a horizontal line.
(WebCore::ExclusionPolygon::ExclusionPolygon): See the introductory text above for a description of this type.
(WebCore::computeXIntersection): Find and classify the X intercept of a polygon edge with horizontal line, if any.
(WebCore::ExclusionPolygon::rightVertexY): This method is used to decide if a horizontal line "crosses" a vertex.
(WebCore::appendIntervalX): Append an x coordinate to a vector of ExclusionIntervals.
(WebCore::ExclusionPolygon::computeXIntersections): Return a vector of the intersections of a horizontal line with the polygon's edges.
(WebCore::ExclusionPolygon::computeEdgeIntersections): Return a vector of the X projections of the edges that overlap a horizonal rectangle.
(WebCore::ExclusionPolygon::getExcludedIntervals): Return a SegmentList of the X intervals within a horizontal rectangle that overlap the polygon.
(WebCore::ExclusionPolygon::getIncludedIntervals): Return the X intervals within a horizontal rectangle that fit inside the polygon.
* rendering/ExclusionPolygon.h: Added.
(WebCore):
(ExclusionPolygon):
(WebCore::ExclusionPolygon::getXAt): X coordinate of a polygon vertex
(WebCore::ExclusionPolygon::getYAt): Y coordinate of a polygon vertex
(WebCore::ExclusionPolygon::numberOfVertices):
(WebCore::ExclusionPolygon::fillRule): A WindRule value that defines "inside" for self-intersecting polygons.
(ExclusionPolygonEdge):
(WebCore::ExclusionPolygonEdge::ExclusionPolygonEdge):
(WebCore::ExclusionPolygonEdge::vertex1):
(WebCore::ExclusionPolygonEdge::vertex2):
(WebCore::ExclusionPolygonEdge::minX):
(WebCore::ExclusionPolygonEdge::minY):
(WebCore::ExclusionPolygonEdge::maxX):
(WebCore::ExclusionPolygonEdge::maxY):
* rendering/ExclusionShape.cpp:
(WebCore::createExclusionPolygon): Return a new ExclusionPolygon.
(WebCore):
(WebCore::ExclusionShape::createExclusionShape): Added support for BasicShape::BASIC_SHAPE_POLYGON.
* rendering/ExclusionShapeInsideInfo.cpp:
(WebCore::ExclusionShapeInsideInfo::isExclusionShapeInsideInfoEnabledForRenderBlock): Enable BASIC_SHAPE_POLYGON shapes for RenderBlocks.

LayoutTests:

Verify that a rectangular shape-inside specified as a polygon works as expected for all
writing-modes.

Added exclusions tests for non-complex concave shape-inside polygons as well.
The shapes in this set of tests are "rectangular" in the sense that
horizontal lines that overlap the polygon only cross the polygon twice.
The expected part of each test uses float "sandbags" to simulate the
shape-inside area in the test expectations. The  tests use SVG to
display the polygon itself, to simplify visual inspection.
(See http://www.alistapart.com/articles/sandbags/).

* fast/exclusions/shape-inside/shape-inside-polygon-rectangle-expected.html: Added.
* fast/exclusions/shape-inside/shape-inside-polygon-rectangle.html: Added.
* fast/exclusions/resources/simple-polygon.js: Added.
(createPolygon):
(polygonXIntercepts):
(generatePolygonContentString):
(simulatePolygonShape):
(generateSimulatedPolygonShapeInsideElement):
(positionInformativeText):
(createPolygonShapeInsideTestCase):
(createPolygonShapeInsideTestCaseExpected):
* fast/exclusions/shape-inside/shape-inside-simple-polygon-001-expected.html: Added.
* fast/exclusions/shape-inside/shape-inside-simple-polygon-001.html: Added.
* fast/exclusions/shape-inside/shape-inside-simple-polygon-002-expected.html: Added.
* fast/exclusions/shape-inside/shape-inside-simple-polygon-002.html: Added.
* fast/exclusions/shape-inside/shape-inside-simple-polygon-003-expected.html: Added.
* fast/exclusions/shape-inside/shape-inside-simple-polygon-003.html: Added.
* fast/exclusions/shape-inside/shape-inside-simple-polygon-004-expected.html: Added.
* fast/exclusions/shape-inside/shape-inside-simple-polygon-004.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoReplace 2 uses of updateLogicalHeight with computeLogicalHeight
tony@chromium.org [Mon, 8 Oct 2012 21:16:27 +0000 (21:16 +0000)]
Replace 2 uses of updateLogicalHeight with computeLogicalHeight
https://bugs.webkit.org/show_bug.cgi?id=98677

Reviewed by Ojan Vafai.

This is part of bug 96804.  Convert RenderTextControl and RenderSVGForeignObject to
override the const computeLogicalHeight method rather than the updateLogicalHeight
setter method.

No new tests, there should be no behavior change as this is just a refactor.

* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::computeLogicalHeight): Pass logicalHeight through rather than setting height.
This is a slight correctness fix, although we don't support vertical inputs yet.
* rendering/RenderTextControl.h:
(RenderTextControl):
* rendering/svg/RenderSVGForeignObject.cpp:
(WebCore::RenderSVGForeignObject::computeLogicalHeight):
* rendering/svg/RenderSVGForeignObject.h:
(RenderSVGForeignObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening. Add PNGs after r130653,
ossy@webkit.org [Mon, 8 Oct 2012 21:16:06 +0000 (21:16 +0000)]
[Qt] Unreviewed gardening. Add PNGs after r130653,
and skip tests on Qt-WK2, because they fail on it.

* platform/qt-5.0-wk2/TestExpectations:
* platform/qt/fast/ruby/rubyDOM-insert-rt-expected.png: Added.
* platform/qt/fast/ruby/rubyDOM-insert-text1-expected.png: Added.
* platform/qt/fast/ruby/rubyDOM-insert-text2-expected.png: Added.
* platform/qt/fast/ruby/rubyDOM-insert-text3-expected.png: Added.
* platform/qt/fast/ruby/rubyDOM-remove-rt1-expected.png: Added.
* platform/qt/fast/ruby/rubyDOM-remove-rt2-expected.png: Added.
* platform/qt/fast/ruby/rubyDOM-remove-text1-expected.png: Added.
* platform/qt/fast/ruby/rubyDOM-remove-text2-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed Chromium gardening.
jchaffraix@webkit.org [Mon, 8 Oct 2012 21:10:56 +0000 (21:10 +0000)]
Unreviewed Chromium gardening.

Rebaselined those 2 tables/ tests that were forgotten in the rebaselining after r103875.
https://bugs.webkit.org/show_bug.cgi?id=74888 was opened to track those rebaselining but
it looks like some platform fell through the cracks.

* platform/chromium/TestExpectations:
Removed the 2 entries.

* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/core/captions1-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/core/captions2-expected.png: Added.
* platform/chromium-mac/tables/mozilla_expected_failures/core/captions1-expected.png: Added.
* platform/chromium-mac/tables/mozilla_expected_failures/core/captions1-expected.txt: Added.
* platform/chromium-mac/tables/mozilla_expected_failures/core/captions2-expected.png: Added.
* platform/chromium-mac/tables/mozilla_expected_failures/core/captions2-expected.txt: Added.
Progression: the table captions are larger, which matches other browsers and other platforms' baselines.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpstream some tweaks for overlay play button on Android
commit-queue@webkit.org [Mon, 8 Oct 2012 20:58:38 +0000 (20:58 +0000)]
Upstream some tweaks for overlay play button on Android
https://bugs.webkit.org/show_bug.cgi?id=98671

Patch by Min Qin <qinmin@chromium.org> on 2012-10-08
Reviewed by Adam Barth.

This change stops displaying the overlay play button if video height is too small
No test for this. Will rebase layout test expectations for android later.

* css/mediaControlsChromiumAndroid.css:
(video::-webkit-media-controls-overlay-enclosure):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGTK port should warn if bug modifier is missing in TestExpectations
zandobersek@gmail.com [Mon, 8 Oct 2012 20:54:48 +0000 (20:54 +0000)]
GTK port should warn if bug modifier is missing in TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=98678

Reviewed by Dirk Pranke.

Tools:

Reimplement the warn_if_bug_missing_in_test_expectations method in
GtkPort, returning True for producing a warning in such cases.

* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort.warn_if_bug_missing_in_test_expectations):

LayoutTests:

Add generic Bug(GTK) modifiers for two test expectations.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSuppress editing/pasteboard/data-transfer-items.html failure.
dpranke@chromium.org [Mon, 8 Oct 2012 20:48:09 +0000 (20:48 +0000)]
Suppress editing/pasteboard/data-transfer-items.html failure.
https://bugs.webkit.org/show_bug.cgi?id=98686

Unreviewed, expectations change.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd missing compile flag for compositing
commit-queue@webkit.org [Mon, 8 Oct 2012 20:47:44 +0000 (20:47 +0000)]
Add missing compile flag for compositing
https://bugs.webkit.org/show_bug.cgi?id=98681

Patch by Rik Cabanier <cabanier@adobe.com> on 2012-10-08
Reviewed by Dirk Schulze.

This flag is needed in case there is a difference in API
when compositing is enabled

* Configurations/FeatureDefines.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed rebaselining after r130598 and r130600.
jchaffraix@webkit.org [Mon, 8 Oct 2012 20:26:18 +0000 (20:26 +0000)]
Unreviewed rebaselining after r130598 and r130600.

* platform/chromium-linux-x86/svg/filters/filterRes-expected.txt:
This baseline was forgotten.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] EWK2UnitTestBase.ewk_cookie_manager_accept_policy unit test is failing
commit-queue@webkit.org [Mon, 8 Oct 2012 20:22:42 +0000 (20:22 +0000)]
[EFL][WK2] EWK2UnitTestBase.ewk_cookie_manager_accept_policy unit test is failing
https://bugs.webkit.org/show_bug.cgi?id=98663

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-08
Reviewed by Laszlo Gombos.

EWK2UnitTestBase.ewk_cookie_manager_accept_policy unit test was
failing because the elements of a list were checked in a given
order but the list was not sorted beforehand.

* UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:
(sortHostNames):
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSome GraphicsLayer cleanup to separate the concepts of using a tile cache, and being...
simon.fraser@apple.com [Mon, 8 Oct 2012 20:10:22 +0000 (20:10 +0000)]
Some GraphicsLayer cleanup to separate the concepts of using a tile cache, and being the main tile cache layer
https://bugs.webkit.org/show_bug.cgi?id=98574

Reviewed by Dean Jackson.

GraphicsLayerCA assumed that using a TileCache equated to being the main page tile
cache layer, which has some special considerations. Make these two concepts separate
to get closer to being able to use TileCaches in place of CATiledLayer.

Source/WebCore:

* platform/graphics/GraphicsLayer.h:
(GraphicsLayer): Remove m_usingTileCache member, which was not appropriate
for this class to have.
* platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::GraphicsLayer): Remove init of m_usingTileCache.
(WebCore::GraphicsLayer::debugBorderInfo): Can no longer use m_usingTileCache to
get the blue color, so moved code into a virtual debugBorderInfo() method.
(WebCore::GraphicsLayer::updateDebugIndicators): Call the virtual debugBorderInfo().
* platform/graphics/GraphicsLayerClient.h: Remove the usingTileCache() callback;
we now just cache this information in the GraphicsLayerCA on creation.
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::GraphicsLayerCA): Init m_isPageTileCacheLayer to false,
then set to m_isPageTileCacheLayer if the client says we should create a tile cache.
(WebCore::GraphicsLayerCA::platformCALayerShowRepaintCounter): Overidden to avoid duplicate repaint
counters in the top-left tile.
(WebCore::GraphicsLayerCA::updateLayerBackgroundColor): If this layer is the page tile cache layer,
we allow setting of its background color.
(WebCore::GraphicsLayerCA::debugBorderInfo): Overidden to use a blue color for tiles.
(WebCore::GraphicsLayerCA::requiresTiledLayer): Don't make CATiledLayers for the page tile cache.
* platform/graphics/ca/GraphicsLayerCA.h:
(GraphicsLayerCA):
* platform/graphics/ca/PlatformCALayerClient.h:
(PlatformCALayerClient): Need to pass the platform layer into platformCALayerShowRepaintCounter()
so we can distinguish between calls for tiles, and calls for the tile cache layer itself.
* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::shouldShowRepaintCounters): Pass 0 to platformCALayerShowRepaintCounter() to
indicate that we're asking about a tile.
* platform/graphics/mac/WebLayer.mm:
(drawLayerContents): Now we can just rely on platformCALayerShowRepaintCounter() to tell us whether
to draw the repaint counter.
(-[WebLayer setNeedsDisplayInRect:]):
* platform/graphics/mac/WebTiledLayer.mm:
(-[WebTiledLayer setNeedsDisplayInRect:]):
* rendering/RenderLayerBacking.h:
(WebCore::RenderLayerBacking::usingTileCache):
(RenderLayerBacking):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::documentBackgroundColorDidChange): We can ask the RenderLayerBacking
whether it's for the tile cache, rather than going to the GraphicsLayer.
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::LayerClient::platformCALayerShowRepaintCounter):

Source/WebKit/win:

* FullscreenVideoController.cpp:
(FullscreenVideoController::LayerClient::platformCALayerShowRepaintCounter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] new test introduced in r120354 fails on Qt
commit-queue@webkit.org [Mon, 8 Oct 2012 19:46:06 +0000 (19:46 +0000)]
[Qt] new test introduced in r120354 fails on Qt
https://bugs.webkit.org/show_bug.cgi?id=91968

Patch by Tullio Lucena <tullio.lucena@openbossa.org> on 2012-10-08
Reviewed by Kenneth Rohde Christiansen.

Unskipping test.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled DEPS.
abarth@webkit.org [Mon, 8 Oct 2012 19:33:39 +0000 (19:33 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-08

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][DRT] Switch default backing store to single
ryuan.choi@samsung.com [Mon, 8 Oct 2012 19:18:27 +0000 (19:18 +0000)]
[EFL][DRT] Switch default backing store to single
https://bugs.webkit.org/show_bug.cgi?id=98591

Reviewed by Eric Seidel.

There are two backing stores for WebKit/Efl, Single Backing Store(SBS) and
Tiled Backing Store(TBS), and DRT/Efl has used TBS.
But, TBS is not suitable to run pixel tests because it does not have a good way
to render mock scrollbars well.

So, this patch changes the default backing store to SBS.
In addition, this changes the environment variable from DRT_USE_SINGLE_BACKING_STORE
to DRT_USE_TILED_BACKING_STORE.

* DumpRenderTree/efl/DumpRenderTreeView.cpp:
(shouldUseTiledBackingStore):
(chooseAndInitializeAppropriateSmartClass):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Make ImageBufferQt use premultiplied converting functions in Color.h instead...
commit-queue@webkit.org [Mon, 8 Oct 2012 19:14:53 +0000 (19:14 +0000)]
[Qt] Make ImageBufferQt use premultiplied converting functions in Color.h instead of its own mechanism.
https://bugs.webkit.org/show_bug.cgi?id=98582

Patch by Huang Dongsung <luxtella@company100.net> on 2012-10-08
Reviewed by Eric Seidel.

Source/WebCore:

Only Qt port failed canvas/philip/tests/2d.imageData.put.unchanged.html because
ImageBufferQt converts from or to a premultiplied color using its own code. When
we convert twice from an unmultiplied color to a premultiplied color and then to
an unmultiplied color using this code, the calculated result are pretty
different against the input color. It is why Gtk passes this test although Qt
fails. Gtk port uses them in Color.h.

In addition, Qt should use the functions in Color.h to reduce duplicated codes.

Tests: canvas/philip/tests/2d.imageData.put.unchanged.html: Fixed a test case

* platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::getImageData):
(WebCore::convertBGRAToRGBA):
(WebCore::ImageBuffer::putByteArray):

LayoutTests:

Unskipping canvas/philip/tests/2d.imageData.put.unchanged.html that is passing.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Avoid useless converting to WKPage
commit-queue@webkit.org [Mon, 8 Oct 2012 19:10:58 +0000 (19:10 +0000)]
[EFL][WK2] Avoid useless converting to WKPage
https://bugs.webkit.org/show_bug.cgi?id=98516

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-10-08
Reviewed by Eric Seidel.

Use priv->pageProxy->findString() and priv->pageProxy->hideFindUI()
to avoid useless converting to WK.

* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_text_find):
(ewk_view_text_find_highlight_clear):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix video-test.js relativeURL() bug
commit-queue@webkit.org [Mon, 8 Oct 2012 19:07:33 +0000 (19:07 +0000)]
Fix video-test.js relativeURL() bug
https://bugs.webkit.org/show_bug.cgi?id=98546

Patch by Shadi Khalek <shadi@chromium.org> on 2012-10-08
Reviewed by Eric Seidel.

Some layout tests failed due to this bug (crbug.com/154157)

* media/video-test.js:
(testArraysEqual):
(relativeURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPerf test pesults page takes forever to load on a machine with a slow Internet connection
rniwa@webkit.org [Mon, 8 Oct 2012 19:02:06 +0000 (19:02 +0000)]
Perf test pesults page takes forever to load on a machine with a slow Internet connection
https://bugs.webkit.org/show_bug.cgi?id=98561

Reviewed by Ojan Vafai.

Try loading jquery both locally and remotely, and use the same method to load the remaining
jquery plugins when either one succeeds.

* resources/results-template.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove "orphaned units" quirk
commit-queue@webkit.org [Mon, 8 Oct 2012 19:00:38 +0000 (19:00 +0000)]
Remove "orphaned units" quirk
https://bugs.webkit.org/show_bug.cgi?id=98553

Patch by Tab Atkins <jackalmage@gmail.com> on 2012-10-08
Reviewed by Eric Seidel.

This patch removes our "orphaned units" quirk.
We have an "orphaned units" quirk to match IE, which allows things like "width: 20 px;".
But FF and Opera don't have it and aren't aware of bugs for it,
and it's not in Simon Pieters' Quirks Mode spec <http://dvcs.w3.org/hg/quirks-mode/raw-file/tip/Overview.html>

No new tests, because I'm killing a quirk.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSParser.h:
(CSSParser):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdditional fast/repaint Chromium rebaseline.
jchaffraix@webkit.org [Mon, 8 Oct 2012 18:57:05 +0000 (18:57 +0000)]
Additional fast/repaint Chromium rebaseline.

Rebaselined more tests on Chromium Mac. Same as r130654 but there
is some anti-aliasing differences on transformed lines.

* platform/chromium/TestExpectations:
Removed the rebaselined tests.

* fast/repaint/table-section-repaint-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/repaint/overflow-outline-repaint-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/repaint/table-collapsed-border-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/repaint/text-append-dirty-lines-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/repaint/text-selection-rect-in-overflow-2-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/repaint/text-selection-rect-in-overflow-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/repaint/transform-relative-position-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/repaint/transform-repaint-descendants-expected.png: Added.
* platform/chromium-mac/fast/repaint/overflow-outline-repaint-expected.png: Added.
* platform/chromium-mac/fast/repaint/table-col-background-expected.png: Added.
* platform/chromium-mac/fast/repaint/table-collapsed-border-expected.png: Added.
* platform/chromium-mac/fast/repaint/table-outer-border-expected.png: Added.
* platform/chromium-mac/fast/repaint/table-row-expected.png: Added.
* platform/chromium-mac/fast/repaint/table-section-overflow-expected.png: Added.
* platform/chromium-mac/fast/repaint/table-section-repaint-expected.png: Added.
* platform/chromium-mac/fast/repaint/table-two-pass-layout-overpaint-expected.png: Added.
* platform/chromium-mac/fast/repaint/text-append-dirty-lines-expected.png: Added.
* platform/chromium-mac/fast/repaint/text-selection-rect-in-overflow-2-expected.png: Added.
* platform/chromium-mac/fast/repaint/text-selection-rect-in-overflow-expected.png: Added.
* platform/chromium-mac/fast/repaint/transform-absolute-child-expected.png: Added.
* platform/chromium-mac/fast/repaint/transform-disable-layoutstate-expected.png: Added.
* platform/chromium-mac/fast/repaint/transform-relative-position-expected.png: Added.
* platform/chromium-mac/fast/repaint/transform-repaint-descendants-expected.png: Added.
* platform/chromium-win/fast/repaint/table-section-repaint-expected.txt: Removed.
* platform/chromium/fast/repaint/table-section-repaint-expected.txt: Added.
* platform/efl/fast/repaint/table-section-repaint-expected.txt: Removed.
* platform/gtk/fast/repaint/table-section-repaint-expected.txt: Removed.
* platform/qt/fast/repaint/table-section-repaint-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Mon, 8 Oct 2012 18:50:23 +0000 (18:50 +0000)]
Unreviewed GTK gardening.

Rebaselining SVG tests after changes in r130599.

* platform/gtk/TestExpectations:
* platform/gtk/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.txt:
* platform/gtk/svg/W3C-SVG-1.1/coords-units-01-b-expected.png:
* platform/gtk/svg/W3C-SVG-1.1/coords-units-01-b-expected.txt:
* platform/gtk/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.png:
* platform/gtk/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt:
* platform/gtk/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.png:
* platform/gtk/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt:
* platform/gtk/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.png:
* platform/gtk/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
* platform/gtk/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
* platform/gtk/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
* platform/gtk/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png:
* platform/gtk/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
* platform/gtk/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.png:
* platform/gtk/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt:
* platform/gtk/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
* platform/gtk/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.txt:
* platform/gtk/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png:
* platform/gtk/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt:
* platform/gtk/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.png:
* platform/gtk/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.txt:
* platform/gtk/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt:
* platform/gtk/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.png:
* platform/gtk/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt:
* platform/gtk/svg/batik/paints/gradientLimit-expected.png:
* platform/gtk/svg/batik/paints/gradientLimit-expected.txt:
* platform/gtk/svg/batik/paints/patternRegions-expected.png:
* platform/gtk/svg/batik/paints/patternRegions-expected.txt:
* platform/gtk/svg/batik/paints/patternRegions-positioned-objects-expected.png:
* platform/gtk/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
* platform/gtk/svg/batik/text/textEffect-expected.png:
* platform/gtk/svg/batik/text/textEffect-expected.txt: Added.
* platform/gtk/svg/batik/text/textEffect3-expected.png:
* platform/gtk/svg/batik/text/textEffect3-expected.txt: Added.
* platform/gtk/svg/custom/gradient-deep-referencing-expected.png:
* platform/gtk/svg/custom/gradient-deep-referencing-expected.txt:
* platform/gtk/svg/custom/gradient-with-1d-boundingbox-expected.png: Added.
* platform/gtk/svg/custom/gradient-with-1d-boundingbox-expected.txt:
* platform/gtk/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png:
* platform/gtk/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.txt: Added.
* platform/gtk/svg/custom/radialGradient-focal-radius-expected.png: Added.
* platform/gtk/svg/custom/radialGradient-focal-radius-expected.txt: Added.
* platform/gtk/svg/custom/recursive-gradient-expected.png:
* platform/gtk/svg/custom/recursive-gradient-expected.txt:
* platform/gtk/svg/custom/relative-sized-content-with-resources-expected.png:
* platform/gtk/svg/custom/relative-sized-content-with-resources-expected.txt:
* platform/gtk/svg/custom/stroked-pattern-expected.png:
* platform/gtk/svg/custom/stroked-pattern-expected.txt:
* platform/gtk/svg/hixie/perf/006-expected.png:
* platform/gtk/svg/hixie/perf/006-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoaudiobuffer.html need to include audio-testing.js file.
commit-queue@webkit.org [Mon, 8 Oct 2012 18:46:21 +0000 (18:46 +0000)]
audiobuffer.html need to include audio-testing.js file.
https://bugs.webkit.org/show_bug.cgi?id=98641

Patch by Dongwoo Joshua Im <dw.im@samsung.com> on 2012-10-08
Reviewed by Eric Seidel.

As we discussed at the bug https://bugs.webkit.org/show_bug.cgi?id=88624,
WebAudio tests need to include audio-testing.js file to set WebKitWebAudioEnabled.

* webaudio/audiobuffer.html: Include audio-testing.js file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAfter r130344, OpaqueJSString() creates an empty string which should be a null string
msaboff@apple.com [Mon, 8 Oct 2012 18:46:20 +0000 (18:46 +0000)]
After r130344, OpaqueJSString() creates an empty string which should be a null string
https://bugs.webkit.org/show_bug.cgi?id=98417

Reviewed by Sam Weinig.

Changed create() of a null string to return 0. This is the same behavior as before r130344.

* API/OpaqueJSString.cpp:
(OpaqueJSString::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBorder, margin and padding of an inline's inline ancestors counted twice
robert@webkit.org [Mon, 8 Oct 2012 18:44:03 +0000 (18:44 +0000)]
Border, margin and padding of an inline's inline ancestors counted twice
https://bugs.webkit.org/show_bug.cgi?id=63074

Reviewed by David Hyatt.

Source/WebCore:

In a line such as '<span><span><img>Text' the border, padding and margin belonging
to the two spans was counted twice by RenderBlockLineLayout::nextLineBreak(): once
when adding the width of the <img> object to the line, and a second time when adding
the 'Text'. The result was that nextLineBreak() now had a length for the line that
exceeded the line's maximum length and inserted a bogus line break.

This all happened because the helper function that is used to add in the border etc.
from inline ancestors was crawling up the tree each time. It doesn't need to do that, it
should stop crawling up the tree when the current object is not the first or last sibling below a parent.

Test: fast/inline/bpm-inline-ancestors.html

* rendering/RenderBlockLineLayout.cpp:
(WebCore::shouldAddBorderPaddingMargin): Broke this check out into a helper function so that it
can help inlineLogicalWidth() return early and also treat empty RenderTexts the same as no previous/next
sibling on the line. This ensures that collapsed leading space does not interfere with the decision to
crawl up the ancestors accumulating border, padding, and margin.
(WebCore):
(WebCore::inlineLogicalWidth): Return early once the current child is no longer on the edge of its line -
this ensures the border, padding and margin of ancestors is not counted twice.

LayoutTests:

* fast/inline/bpm-inline-ancestors-expected.html: Added.
* fast/inline/bpm-inline-ancestors.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2][WTR] WebKitTestRunner needs testRunner.dispatchPendingLoadRequests
commit-queue@webkit.org [Mon, 8 Oct 2012 18:40:58 +0000 (18:40 +0000)]
[WK2][WTR] WebKitTestRunner needs testRunner.dispatchPendingLoadRequests
https://bugs.webkit.org/show_bug.cgi?id=98638

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-08
Reviewed by Eric Seidel.

Source/WebKit2:

Add implementation for testRunner.dispatchPendingLoadRequests in
WebKitTestRunner.

* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleDispatchPendingLoadRequests):
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::dispatchPendingLoadRequests):
(WebKit):
* WebProcess/InjectedBundle/InjectedBundle.h:
(InjectedBundle):

Tools:

Add implementation for testRunner.dispatchPendingLoadRequests in
WebKitTestRunner.

* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::dispatchPendingLoadRequests):
(WTR):
* WebKitTestRunner/InjectedBundle/TestRunner.h:
(TestRunner):

LayoutTests:

Unskip http/tests/loading/deleted-host-in-resource-load-delegate-callback.html

* platform/wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Skip http/tests/multipart/multipart-html.php while we wait for kov's patch.
rakuco@webkit.org [Mon, 8 Oct 2012 18:37:57 +0000 (18:37 +0000)]
[EFL] Skip http/tests/multipart/multipart-html.php while we wait for kov's patch.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Add support for window.close in Minibrowser
commit-queue@webkit.org [Mon, 8 Oct 2012 18:37:40 +0000 (18:37 +0000)]
[EFL][WK2] Add support for window.close in Minibrowser
https://bugs.webkit.org/show_bug.cgi?id=98667

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-08
Reviewed by Laszlo Gombos.

When calling window.close() from JavaScript, MiniBrowser
now closes the given window.

* MiniBrowser/efl/main.c:
(window_close):
(on_ecore_evas_delete):
(on_close_window):
(window_create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130660 268f45cc-cd09-0410-ab3c-d52691b4dbfc