mrobinson@webkit.org [Thu, 17 May 2012 00:28:28 +0000 (00:28 +0000)]
Fix the indexed database build for GTK+.
* GNUmakefile.list.am: Add missing files to the build.
* bindings/gobject/GNUmakefile.am: Be smarter about filtering out deactivating indexed database.
* bindings/scripts/CodeGeneratorGObject.pm:
(SkipAttribute): Always skip attributes that return indexed database types.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117368
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jchaffraix@webkit.org [Thu, 17 May 2012 00:19:13 +0000 (00:19 +0000)]
Unreviewed gardening after r117339 (table baseline computation change).
* fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Added.
* platform/chromium-linux-x86/css2.1/
20110323: Removed.
* platform/chromium-linux-x86/css2.1/
20110323/inline-table-001-expected.png: Removed.
* platform/chromium-linux-x86/css2.1/
20110323/inline-table-001-expected.txt: Removed.
* platform/chromium-linux-x86/css2.1/
20110323/inline-table-002a-expected.png: Removed.
* platform/chromium-linux-x86/css2.1/
20110323/inline-table-002a-expected.txt: Removed.
* platform/chromium-linux-x86/css2.1/
20110323/inline-table-003-expected.png: Removed.
* platform/chromium-linux-x86/css2.1/
20110323/inline-table-003-expected.txt: Removed.
* platform/chromium-linux/css2.1/
20110323/inline-table-001-expected.png: Added.
* platform/chromium-linux/css2.1/
20110323/inline-table-002a-expected.png: Added.
* platform/chromium-linux/css2.1/
20110323/inline-table-003-expected.png: Added.
* platform/chromium-mac-leopard/css2.1/
20110323/inline-table-001-expected.png: Added.
* platform/chromium-mac-leopard/css2.1/
20110323/inline-table-002a-expected.png: Added.
* platform/chromium-mac-leopard/css2.1/
20110323/inline-table-003-expected.png: Added.
* platform/chromium-mac-leopard/editing/selection/iframe-expected.png:
* platform/chromium-mac-snowleopard/css2.1/
20110323/inline-table-001-expected.png: Added.
* platform/chromium-mac-snowleopard/css2.1/
20110323/inline-table-002a-expected.png: Added.
* platform/chromium-mac-snowleopard/css2.1/
20110323/inline-table-003-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/selection/iframe-expected.png:
* platform/chromium-mac/css2.1/
20110323/inline-table-001-expected.png: Added.
* platform/chromium-mac/css2.1/
20110323/inline-table-001-expected.txt: Added.
* platform/chromium-mac/css2.1/
20110323/inline-table-002a-expected.png: Added.
* platform/chromium-mac/css2.1/
20110323/inline-table-002a-expected.txt: Added.
* platform/chromium-mac/css2.1/
20110323/inline-table-003-expected.png: Added.
* platform/chromium-mac/css2.1/
20110323/inline-table-003-expected.txt: Added.
* platform/chromium-mac/editing/selection/iframe-expected.png:
* platform/chromium-mac/editing/selection/iframe-expected.txt: Added.
* platform/chromium-mac/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.png: Added.
* platform/chromium-win-vista/editing/selection: Removed.
* platform/chromium-win-vista/fast/css-generated-content: Added.
* platform/chromium-win-vista/fast/css-generated-content/inline-display-types-expected.png: Added.
* platform/chromium-win-vista/fast/inline-block: Added.
* platform/chromium-win-vista/fast/inline-block/001-expected.png: Added.
* platform/chromium-win-xp/fast/css-generated-content: Added.
* platform/chromium-win-xp/fast/css-generated-content/inline-display-types-expected.png: Added.
* platform/chromium-win-xp/fast/inline-block: Added.
* platform/chromium-win-xp/fast/inline-block/001-expected.png: Added.
* platform/chromium-win/css2.1/
20110323/inline-table-001-expected.png: Added.
* platform/chromium-win/css2.1/
20110323/inline-table-001-expected.txt: Added.
* platform/chromium-win/css2.1/
20110323/inline-table-002a-expected.png: Added.
* platform/chromium-win/css2.1/
20110323/inline-table-002a-expected.txt: Added.
* platform/chromium-win/css2.1/
20110323/inline-table-003-expected.png: Added.
* platform/chromium-win/css2.1/
20110323/inline-table-003-expected.txt: Added.
* platform/chromium-win/editing/pasteboard/innerText-inline-table-expected.png:
* platform/chromium-win/editing/selection/iframe-expected.png:
* platform/chromium-win/editing/selection/inline-table-expected.png:
* platform/chromium-win/editing/selection/table-caret-3-expected.png:
* platform/chromium-win/fast/css-generated-content/inline-display-types-expected.png:
* platform/chromium-win/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.png:
* platform/chromium-win/fast/inline-block/001-expected.png:
* platform/chromium/test_expectations.txt:
* platform/efl/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Removed.
* platform/qt/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117367
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jonlee@apple.com [Thu, 17 May 2012 00:09:07 +0000 (00:09 +0000)]
Animated GIFs in page cache get updated
https://bugs.webkit.org/show_bug.cgi?id=86668
<rdar://problem/
11395549>
Reviewed by Brady Eidson.
Source/WebCore:
Test: fast/loader/image-in-page-cache.html
* rendering/RenderImage.cpp:
(WebCore::RenderImage::imageChanged): When we are notified by the CachedImage that the image has
changed, we check to see if the document is in the page cache. If so, we should not be updating,
so we bail out early.
LayoutTests:
This test loads pages with subframes that display the same animated gif. When one of
the pages goes into the page cache, we want to make sure that we do not crash as a
side effect of the page's images getting updated.
* fast/loader/image-in-page-cache-expected.txt: Added.
* fast/loader/image-in-page-cache.html: Added.
* fast/loader/resources/animated-image-subframe.html: Added.
* fast/loader/resources/animated-image.html: Added.
* fast/loader/resources/animated-image2.html: Added.
* fast/loader/resources/animated-image3.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117366
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy_horton@apple.com [Thu, 17 May 2012 00:07:16 +0000 (00:07 +0000)]
Crash if SVG gradient stop has display: none set
https://bugs.webkit.org/show_bug.cgi?id=86686
<rdar://problem/
10751905>
Reviewed by Dean Jackson.
Source/WebCore:
Create a renderer for SVGStopElement regardless of the "display" property.
This matches the behavior of Opera and the SVG specification.
Test: svg/custom/gradient-stop-display-none-crash.svg
* svg/SVGStopElement.cpp:
(WebCore::SVGStopElement::rendererIsNeeded):
(WebCore):
* svg/SVGStopElement.h:
(SVGStopElement):
LayoutTests:
Add a test that ensures that we don't crash if "display: none" is set on an SVGStopElement.
* svg/custom/gradient-stop-display-none-crash-expected.txt: Added.
* svg/custom/gradient-stop-display-none-crash.svg: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117365
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Wed, 16 May 2012 23:42:57 +0000 (23:42 +0000)]
Unreviewed, GTK rebaseline after r116069 and r117339.
* platform/gtk/editing/pasteboard/innerText-inline-table-expected.txt:
* platform/gtk/editing/selection/iframe-expected.txt:
* platform/gtk/editing/selection/inline-table-expected.txt:
* platform/gtk/editing/selection/table-caret-3-expected.txt:
* platform/gtk/fast/css-generated-content/inline-display-types-expected.txt:
* platform/gtk/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt:
* platform/gtk/fast/forms/input-align-image-expected.txt:
* platform/gtk/fast/forms/preserveFormDuringResidualStyle-expected.txt:
* platform/gtk/fast/inline-block/001-expected.txt:
* platform/gtk/media/media-document-audio-repaint-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug2479-2-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117363
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
danakj@chromium.org [Wed, 16 May 2012 23:35:15 +0000 (23:35 +0000)]
[chromium] Clear the m_private pointer when destroying WebFilterOperations to avoid assert in WebPrivateOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=86654
Reviewed by James Robinson.
Source/Platform:
* chromium/public/WebFilterOperations.h:
(WebKit::WebFilterOperations::~WebFilterOperations):
(WebFilterOperations):
Source/WebCore:
* platform/chromium/support/WebFilterOperations.cpp:
(WebKit::WebFilterOperations::reset):
(WebKit::WebFilterOperations::destroy):
(WebKit):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117362
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 16 May 2012 23:30:16 +0000 (23:30 +0000)]
REGRESSION(r92823): WebKit strips font-weight: normal from b element when copying
https://bugs.webkit.org/show_bug.cgi?id=86663
Reviewed by Tony Chang.
The bug was caused by removeStyleFromRulesAndContext incorrectly stripping font-weight property
even when the context had no font-weight property because of a property name mismatch in getPropertiesNotIn.
Fixed the mismatch.
Test: editing/pasteboard/paste-text-with-style-5.html
* editing/EditingStyle.cpp:
(WebCore::getPropertiesNotIn):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117361
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pkasting@chromium.org [Wed, 16 May 2012 23:29:56 +0000 (23:29 +0000)]
[chromium] Mark a test as failing.
https://bugs.webkit.org/show_bug.cgi?id=86683
Unreviewed, expectations update.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117360
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 16 May 2012 23:24:34 +0000 (23:24 +0000)]
Merge nextRootInlineBox with nextLinePosition
https://bugs.webkit.org/show_bug.cgi?id=81593
Reviewed by Enrica Casucci.
Call previousRootInlineBox and nextRootInlineBox in previousLinePosition and nextLinePosition respectively
to share the code. Moved out the nullity check of startBox and extracted the renderer's node from the former
two, and added editableType to their argument lists to match the interface in both use cases.
Also moved out the code to extract root inline box using RenderedPosition from those two functions and
expanded in call sites since previousLinePosition and nextLinePosition need to return the candidate position
even when the root inline box doesn't exist. To this end, renamed previousRootInlineBox and nextRootInlineBox
to previousRootInlineBoxCandidatePosition and nextRootInlineBoxCandidatePosition respectively.
In addition, got rid of one version of nextLeafWithSameEditability that adjusted node with respect to offset
This variant did:
Node* child = node->childNode(offset);
node = child ? child->nextLeafNode() : node->lastDescendant()->nextLeafNode();
instead of:
node = node->nextLeafNode();
at the beginning of the function. Observe that the former code is logically equivalent to:
Node* child = node->childNode(offset);
node = child ? child : node->lastDescendant();
node = node->nextLeafNode();
Thus, the first two lines of this logically equivalent code is added in nextLinePosition wherein we used to
call the removed variant.
This refactoring with no behavioral change would help us resolving the bug 81490.
* editing/visible_units.cpp:
(WebCore::previousRootInlineBoxCandidatePosition): Renamed from previousRootInlineBox.
(WebCore::nextRootInlineBoxCandidatePosition): Renamed from nextRootInlineBox.
(WebCore::logicallyPreviousBox): Checks the nullity of startBox's renderer and node. Also extracts the root
inline box out of the position per the interface change.
(WebCore::logicallyNextBox): Ditto.
(WebCore::previousLinePosition): Calls previousRootInlineBoxCandidatePosition.
(WebCore::nextLinePosition): Calls nextRootInlineBoxCandidatePosition.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117359
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Wed, 16 May 2012 22:56:29 +0000 (22:56 +0000)]
Unreviewed, GTK gardening.
* platform/gtk/test_expectations.txt: Unflag tests needing
rebaseline. I'll pull them from the bot ASAP.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117357
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noel.gordon@gmail.com [Wed, 16 May 2012 22:37:39 +0000 (22:37 +0000)]
[chromium] Remove ImageDecoderCG.cpp from platform/image-decoders
https://bugs.webkit.org/show_bug.cgi?id=86346
Reviewed by Adam Barth.
ImageDecoderCG.cpp was added for use in the Chromium port in r70846. Remove the
implementation now that Chromium uses Skia on Mac OSX by default.
No new tests. No change in behavior.
* WebCore.gypi: Remove ImageDecoderCG.cpp from the gyp project.
* platform/graphics/ImageSource.h: Revert the r70846 changes.
* platform/image-decoders/ImageDecoder.cpp: Remove copyReferenceToBitmapData().
(WebCore::ImageFrame::operator=): Return to using copyBitmapData() (as it was)
given the removal of copyReferenceToBitmapData() above.
* platform/image-decoders/ImageDecoder.h:
(ImageFrame): Remove copyReferenceToBitmapData() declaration.
* platform/image-decoders/cg/ImageDecoderCG.cpp: Removed, and it was the only
decoder with a port-specific implementation of copyReferenceToBitmapData().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117355
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 16 May 2012 22:27:08 +0000 (22:27 +0000)]
Simplify AudioNode ref-counting by removing RefTypeDisabled
https://bugs.webkit.org/show_bug.cgi?id=85681
Patch by Raymond Toy <rtoy@google.com> on 2012-05-16
Reviewed by Chris Rogers.
Existing tests should cover these changes.
* Modules/webaudio/AudioNode.cpp: Remove RefTypeDiabled and m_disabledRefCount.
(WebCore::AudioNode::AudioNode):
(WebCore::AudioNode::~AudioNode):
(WebCore::AudioNode::enableOutputsIfNecessary): New
(WebCore::AudioNode::ref):
(WebCore::AudioNode::disableOutputsIfNecessary): New
(WebCore::AudioNode::finishDeref):
* Modules/webaudio/AudioNode.h: Remove RefTypeDisabled and m_disabledRefCount.
* Modules/webaudio/AudioNodeInput.cpp: Removed uses of RefTypeDisbled.
(WebCore::AudioNodeInput::disconnect):
(WebCore::AudioNodeInput::disable):
(WebCore::AudioNodeInput::enable):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117354
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Wed, 16 May 2012 22:25:10 +0000 (22:25 +0000)]
Fix perf regression from r116487
https://bugs.webkit.org/show_bug.cgi?id=86680
Reviewed by Ryosuke Niwa.
http://trac.webkit.org/changeset/116487 caused a 6% regression on
Dromaeo's dom-attr test. The issue is that we invalidated NodeList
caches whenever an id/checked/type attribute changed.
First, we don't need to invalidate on checked/type since that only
affects the values return by NodeList items, not the list of items.
Second, we only need to invalidate NodeList caches when an id attribute
changes on a FormControlElement.
Incidentally, we also don't need to invalidate caches for changes
to attributes that don't have an ownerElement.
No new tests. This is strictly a performance improvement.
* dom/Attr.cpp:
(WebCore::Attr::setValue):
(WebCore::Attr::childrenChanged):
* dom/Element.cpp:
(WebCore::Element::attributeChanged):
* dom/Node.cpp:
(WebCore::Node::invalidateNodeListsCacheAfterAttributeChanged):
* dom/Node.h:
(Node):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117353
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 16 May 2012 22:16:13 +0000 (22:16 +0000)]
[BlackBerry] The FCC shows up on an empty input field
https://bugs.webkit.org/show_bug.cgi?id=86657
Patch by Yongxin Dai <yodai@rim.com> on 2012-05-16
Reviewed by Antonio Gomes.
Turn off the caret by sending a caret changed notification with empty caret.
PR #120620
Reviewed Internally by Mike Fenton.
* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117352
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 16 May 2012 22:10:17 +0000 (22:10 +0000)]
Unreviewed, rolling out r117332.
http://trac.webkit.org/changeset/117332
https://bugs.webkit.org/show_bug.cgi?id=86679
It makes the Qt Linux bot very unhappy (Requested by darktears
on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-16
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117351
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
arv@chromium.org [Wed, 16 May 2012 21:58:03 +0000 (21:58 +0000)]
Make window-property-shadowing-name.html fail faster
https://bugs.webkit.org/show_bug.cgi?id=86664
Reviewed by Ojan Vafai.
This makes test sync instead of async by checking the return value of window.open.
* fast/dom/Window/window-property-shadowing-name.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117349
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pkasting@chromium.org [Wed, 16 May 2012 21:55:35 +0000 (21:55 +0000)]
[chromium] Mark test as flakily timing out.
https://bugs.webkit.org/show_bug.cgi?id=82698
Unreviewed, expectations update.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117348
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eae@chromium.org [Wed, 16 May 2012 21:31:06 +0000 (21:31 +0000)]
Unreviewed chromium rebaseline for change in r117310.
* platform/chromium-mac/fast/block/float/overhanging-tall-block-expected.png:
* platform/chromium-mac/fast/block/float/overhanging-tall-block-expected.txt: Removed.
* platform/chromium-win/fast/block/float/overhanging-tall-block-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117344
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mhahnenberg@apple.com [Wed, 16 May 2012 21:21:44 +0000 (21:21 +0000)]
GC in the middle of JSObject::allocatePropertyStorage can cause badness
https://bugs.webkit.org/show_bug.cgi?id=83839
Reviewed by Geoff Garen.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* jit/JITStubs.cpp: Making changes to use the new return value of growPropertyStorage.
(JSC::DEFINE_STUB_FUNCTION):
* runtime/JSObject.cpp:
(JSC::JSObject::growPropertyStorage): Renamed to more accurately reflect that we're
growing our already-existing PropertyStorage.
* runtime/JSObject.h:
(JSObject):
(JSC::JSObject::setPropertyStorage): "Atomically" sets the new property storage
and the new structure so that we can be sure a GC never occurs when our Structure
info is out of sync with our PropertyStorage.
(JSC):
(JSC::JSObject::putDirectInternal): Moved the check to see if we should
allocate more backing store before the actual property insertion into
the structure.
(JSC::JSObject::putDirectWithoutTransition): Ditto.
(JSC::JSObject::transitionTo): Ditto.
* runtime/Structure.cpp:
(JSC::Structure::suggestedNewPropertyStorageSize): Added to keep the resize policy
for property backing stores contained within the Structure class.
(JSC):
* runtime/Structure.h:
(JSC::Structure::shouldGrowPropertyStorage): Lets clients know if another insertion
into the Structure would require resizing the property backing store so that they can
preallocate the required storage.
(Structure):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117343
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pkasting@chromium.org [Wed, 16 May 2012 21:18:20 +0000 (21:18 +0000)]
Fix bad expectation added in r117249.
https://bugs.webkit.org/show_bug.cgi?id=82698
Unreviewed, test expectation fix.
* editing/shadow/selection-of-orphan-shadowroot-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117342
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jsbell@chromium.org [Wed, 16 May 2012 21:14:39 +0000 (21:14 +0000)]
[Chromium] IndexedDB: WebKit API for IDBObjectStore.autoIncrement property
https://bugs.webkit.org/show_bug.cgi?id=86661
Reviewed by Dimitri Glazkov.
* public/WebIDBObjectStore.h:
(WebKit::WebIDBObjectStore::autoIncrement):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117341
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Wed, 16 May 2012 21:06:53 +0000 (21:06 +0000)]
GC is not thread-safe when moving values between C stacks
https://bugs.webkit.org/show_bug.cgi?id=86672
Reviewed by Phil Pizlo.
GC pauses thread A while marking thread A, and then B while marking B,
which isn't safe against A and B moving values between each others'
stacks.
This is a theoretical bug -- I haven't been able to reproduce it
in the wild.
* heap/MachineStackMarker.cpp:
(JSC::MachineThreads::gatherFromOtherThread):
(JSC::MachineThreads::gatherConservativeRoots): Pause all C stacks for the
duration of stack marking, to avoid missing values that might be moving
between C stacks.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117340
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Wed, 16 May 2012 21:06:10 +0000 (21:06 +0000)]
CSS 2.1 failure: inline-table-001 fails
https://bugs.webkit.org/show_bug.cgi?id=84167
Reviewed by Julien Chaffraix.
Source/WebCore:
Override lastLineBoxBaseline() in RenderTable so that it picks up the baseline
of the text in the first row of the table. This allows inline tables to find the
correct baseline to align to.
Tests:
css2.1/
20110323/inline-table-001.htm
css2.1/
20110323/inline-table-002a.htm
css2.1/
20110323/inline-table-003.htm
fast/css/empty-cell-baseline.html
* rendering/RenderTable.cpp:
(WebCore::getLineBoxBaseline):
(WebCore):
(WebCore::RenderTable::lastLineBoxBaseline):
(WebCore::RenderTable::firstLineBoxBaseline):
* rendering/RenderTable.h:
(RenderTable):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::firstLineBoxBaseline): if a cell is empty it cannot provide a
baseline. Tested by fast/css/empty-cell-baseline.html
LayoutTests:
* css2.1/
20110323/inline-table-001.htm: Added.
* css2.1/
20110323/inline-table-002a.htm: Added.
* css2.1/
20110323/inline-table-003.htm: Added.
From the CSS 2.1 test suite.
* fast/css/empty-cell-baseline-expected.html: Added.
* fast/css/empty-cell-baseline.html: Added.
This ensures we don't take a baseline from an empty cell.
* fast/inline-block/001.html: Modified to make expected results clearer.
* platform/chromium-linux-x86/css2.1/
20110323/inline-table-001-expected.png: Added.
* platform/chromium-linux-x86/css2.1/
20110323/inline-table-001-expected.txt: Added.
* platform/chromium-linux-x86/css2.1/
20110323/inline-table-002a-expected.png: Added.
* platform/chromium-linux-x86/css2.1/
20110323/inline-table-002a-expected.txt: Added.
* platform/chromium-linux-x86/css2.1/
20110323/inline-table-003-expected.png: Added.
* platform/chromium-linux-x86/css2.1/
20110323/inline-table-003-expected.txt: Added.
* platform/chromium-linux/editing/pasteboard/innerText-inline-table-expected.png:
Progression, the baseline of the text in each cell has moved up to where it should be.
* platform/chromium-linux/editing/selection/iframe-expected.png:
Progression, 'Inline Table' and 'The End' line up with the first row of the inline table.
* platform/chromium-linux/editing/selection/inline-table-expected.png:
Progression, 'Inline Table' and 'The End' line up with the first row of the inline table.
* platform/chromium-linux/editing/selection/table-caret-3-expected.png:
Progression, 'foo' and 'baz' line up with the first row of the inline table.
* platform/chromium-linux/fast/css-generated-content/inline-display-types-expected.png:
Progression, 'Test' and 'content' now line up.
* platform/chromium-linux/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.png:
Progression, the two boxes now line up.
* platform/chromium-linux/fast/inline-block/001-expected.png:
Progression, the boxes now line up in the same way as FF and Opera.
* platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.txt:
Progression, the baseline of the text in each cell has moved up to where it should be.
* platform/chromium-win/editing/pasteboard/innerText-inline-table-expected.txt:
* platform/chromium-win/editing/selection/iframe-expected.txt:
* platform/chromium-win/editing/selection/inline-table-expected.txt:
* platform/chromium-win/editing/selection/table-caret-3-expected.txt:
* platform/chromium-win/fast/css-generated-content/inline-display-types-expected.txt:
* platform/chromium-win/fast/inline-block/001-expected.txt:
* platform/chromium-win/fast/repaint/float-overflow-expected.txt:
* platform/chromium-win/fast/repaint/float-overflow-right-expected.txt:
* platform/chromium/test_expectations.txt:
* platform/efl/test_expectations.txt:
* platform/gtk/test_expectations.txt:
* platform/mac/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt:
* platform/mac/test_expectations.txt:
* platform/qt/test_expectations.txt:
* platform/win/Skipped:
Text rebaselines.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117339
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jsbell@chromium.org [Wed, 16 May 2012 21:02:21 +0000 (21:02 +0000)]
IndexedDB: Rename valid/finished methods to isValid/isFinished to match coding standard
https://bugs.webkit.org/show_bug.cgi?id=86655
Reviewed by Tony Chang.
No new tests - no functional changes.
* Modules/indexeddb/IDBKey.h:
(WebCore::IDBKey::isValid): valid() => isValid()
* Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::deleteFunction):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::transactionFinished):
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteFunction):
* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::onSuccess):
* Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::isFinished): finished() => isFinished()
* Modules/indexeddb/IDBTransaction.h:
* inspector/InspectorIndexedDBAgent.cpp:
(WebCore):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117338
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 16 May 2012 20:57:22 +0000 (20:57 +0000)]
[WK2] Support layoutTestController.dumpProgressFinishedCallback() in WKTR
https://bugs.webkit.org/show_bug.cgi?id=81613
Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-05-16
Reviewed by Brady Eidson.
Unskip the related test from mac-kw2 and gtk-wk2 as support has been added.
* platform/gtk-wk2/Skipped:
* platform/mac-wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117337
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jpfau@apple.com [Wed, 16 May 2012 20:56:50 +0000 (20:56 +0000)]
ImageLoader can still dispatch beforeload events for ImageDocuments
https://bugs.webkit.org/show_bug.cgi?id=86658
<rdar://problem/
11465863>
Reviewed by Brady Eidson.
Prevent flags regarding sending beforeload events from being set on ImageDocuments.
No new tests; testing framework doesn't allow for testing ImageDocuments with injected JavaScript.
* loader/ImageLoader.cpp:
(WebCore::ImageLoader::updateFromElement):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117336
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jchaffraix@webkit.org [Wed, 16 May 2012 20:50:53 +0000 (20:50 +0000)]
layerX/layerY warning should be removed
https://bugs.webkit.org/show_bug.cgi?id=86264
Reviewed by James Robinson.
Source/WebCore:
Covered by: fast/dom/Window/window-xy-properties.html
fast/events/init-events.html
fast/events/mouse-relative-position.html
fast/events/mouseclick-target-and-positioning.html
fast/events/simulated-click-coords.html
jquery/event.html
This change just removes the warning pending proper investigation.
Longer explanation: The layerX/layerY warning was added prematurely
as we didn't assess the web-compatibility potential breakage vs the
maintenance cost. There is also not readily available replacement.
* dom/MouseRelatedEvent.cpp:
(WebCore::MouseRelatedEvent::layerX):
(WebCore::MouseRelatedEvent::layerY):
* dom/UIEvent.cpp:
(WebCore::UIEvent::layerX):
(WebCore::UIEvent::layerY):
* dom/UIEvent.h:
Removed warnDeprecatedLayerXYUsage and all the associated calls.
LayoutTests:
Removed console message about layerX/layerY deprecation.
* fast/dom/Window/window-xy-properties-expected.txt:
* fast/events/init-events-expected.txt:
* fast/events/mouse-relative-position-expected.txt:
* fast/events/mouseclick-target-and-positioning-expected.txt:
* fast/events/simulated-click-coords-expected.txt:
* jquery/event-expected.txt:
* platform/qt/fast/events/mouse-relative-position-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117335
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jsbell@chromium.org [Wed, 16 May 2012 20:41:26 +0000 (20:41 +0000)]
IndexedDB: Use accessors for backing store / database id in store/index backends
https://bugs.webkit.org/show_bug.cgi?id=86652
Reviewed by Tony Chang.
Hide the private members m_backingStore and m_databaseId of IDBObjectStoreBackendImpl
and IDBIndexBackendImpl behind accessors. This is preparation for removing these
members and only holding references to the IDBDatabaseBackendImpl: webkit.org/b/83074
No new tests - no functional changes.
* Modules/indexeddb/IDBIndexBackendImpl.cpp:
(WebCore::IDBIndexBackendImpl::openCursorInternal):
(WebCore::IDBIndexBackendImpl::countInternal):
(WebCore::IDBIndexBackendImpl::getInternal):
(WebCore::IDBIndexBackendImpl::getByRangeInternal):
(WebCore::IDBIndexBackendImpl::getKeyInternal):
(WebCore::IDBIndexBackendImpl::getKeyByRangeInternal):
(WebCore::IDBIndexBackendImpl::addingKeyAllowed):
* Modules/indexeddb/IDBIndexBackendImpl.h:
(WebCore::IDBIndexBackendImpl::backingStore): Added.
(WebCore::IDBIndexBackendImpl::databaseId): Added.
(IDBIndexBackendImpl):
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::getByRangeInternal):
(WebCore::IDBObjectStoreBackendImpl::getInternal):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):
(WebCore::IDBObjectStoreBackendImpl::clearInternal):
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::createIndexInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteIndexInternal):
(WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
(WebCore::IDBObjectStoreBackendImpl::countInternal):
(WebCore::IDBObjectStoreBackendImpl::loadIndexes):
(WebCore::IDBObjectStoreBackendImpl::genAutoIncrementKey):
* Modules/indexeddb/IDBObjectStoreBackendImpl.h:
(WebCore::IDBObjectStoreBackendImpl::backingStore): Added.
(WebCore::IDBObjectStoreBackendImpl::databaseId): Added.
(IDBObjectStoreBackendImpl):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117334
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pkasting@chromium.org [Wed, 16 May 2012 20:36:40 +0000 (20:36 +0000)]
Malformed GIF can cause decoder to read off end of heap buffer
https://bugs.webkit.org/show_bug.cgi?id=86531
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/images/read-past-end-of-buffer.html
This test is only expected to catch problems if run under Address
Sanitizer or a similar memory-checking utility.
* platform/image-decoders/gif/GIFImageReader.cpp:
(GIFImageReader::read):
LayoutTests:
The test here is only expected to catch problems if run under Address
Sanitizer or a similar memory-checking utility.
* fast/images/read-past-end-of-buffer-expected.txt: Added.
* fast/images/read-past-end-of-buffer.html: Added.
* fast/images/resources/wrong-block-length.gif: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117333
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alexis.menard@openbossa.org [Wed, 16 May 2012 20:31:17 +0000 (20:31 +0000)]
[Qt] REGRESSION?(62951): media tests fail
https://bugs.webkit.org/show_bug.cgi?id=42094
Reviewed by Noam Rosenthal.
Enable some media layout tests so that our coverage is more than inexistant.
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117332
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
efidler@rim.com [Wed, 16 May 2012 20:20:10 +0000 (20:20 +0000)]
[BlackBerry] Don't reset the default font families in WebSettings
https://bugs.webkit.org/show_bug.cgi?id=86660
Reviewed by Rob Buis.
PR 152467
The default families are also set definitively in WebCore/page/blackberry/SettingsBlackBerry.cpp
* Api/WebSettings.cpp:
(BlackBerry::WebKit::WebSettings::standardSettings):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117330
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Wed, 16 May 2012 20:15:27 +0000 (20:15 +0000)]
[chromium] Add WebKit API to access inner text value of input element
https://bugs.webkit.org/show_bug.cgi?id=85353
Patch by Keishi Hattori <keishi@webkit.org> on 2012-05-16
Reviewed by Kent Tamura.
* Source/autotools/symbols.filter: Added HTMLInputElement::setEditingValue
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117329
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zandobersek@gmail.com [Wed, 16 May 2012 20:07:33 +0000 (20:07 +0000)]
Unreviewed GTK gardening, rebaselining after r117310.
* platform/gtk/fast/block/float/overhanging-tall-block-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117328
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 16 May 2012 20:04:36 +0000 (20:04 +0000)]
[chromium] No modifier flags (shift/ctrl/alt) in drag&drop events on chromium linux
https://bugs.webkit.org/show_bug.cgi?id=86236
Patch by Varun Jain <varunjain@google.com> on 2012-05-16
Reviewed by Tony Chang.
.:
* ManualTests/chromium/modifiers-during-drag-and-drop.html: Added.
Source/WebCore:
ManualTests: ManualTests/chromium/modifiers-during-drag-and-drop.html
* page/DragController.cpp:
(WebCore::createMouseEvent):
* platform/DragData.cpp:
(WebCore):
(WebCore::DragData::modifierKeyState):
* platform/DragData.h:
(DragData):
* platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::ChromiumDataObject):
* platform/chromium/ChromiumDataObject.h:
(WebCore::ChromiumDataObject::modifierKeyState):
(WebCore::ChromiumDataObject::setModifierKeyState):
(ChromiumDataObject):
* platform/chromium/DragDataChromium.cpp:
(WebCore::DragData::modifierKeyState):
(WebCore):
Source/WebKit/chromium:
* public/WebView.h:
(WebView):
* src/WebViewImpl.cpp:
(WebKit::webInputEventKeyStateToPlatformEventKeyState):
(WebKit):
(WebKit::WebViewImpl::dragTargetDragEnter):
(WebKit::WebViewImpl::dragTargetDragOver):
(WebKit::WebViewImpl::dragTargetDrop):
(WebKit::WebViewImpl::dragTargetDragEnterOrOver):
* src/WebViewImpl.h:
(WebViewImpl):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117327
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Wed, 16 May 2012 19:55:05 +0000 (19:55 +0000)]
<video> elements with no video tracks report false for webkitSupportsFullscreen.
https://bugs.webkit.org/show_bug.cgi?id=86650
Reviewed by Eric Carlson.
Source/WebCore:
No new tests; updated media/media-fullscreen-inline.html.
With the new Full Screen API, the restriction that only video elements with
video tracks can enter full screen seems arbitrary. Some media types will
occasionally determine they have video tracks long after loadedmetadata, which
breaks websites who check for webkitSupportsFullscreen(). Relax the restriction
on webkitSupportsFullscreen() for ports where the Full Screen API is enabled and
supported so as to no longer require hasVideo().
* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::supportsFullscreen):
LayoutTests:
Fix media-fullscreen.js to support the new FULLSCREEN_API events, if present.
Fix the media-fullscreen-inline.html test and unskip on Lion.
* media/media-fullscreen-inline-expected.txt:
* media/media-fullscreen-inline.html:
* media/media-fullscreen.js:
(fullscreenchange):
(loadedmetadata):
(addEventListeners):
* platform/mac-lion/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117326
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 16 May 2012 19:48:12 +0000 (19:48 +0000)]
[Qt][Mac]REGRESSION?(r89397) It made fast/css/custom-font-xheight.html crash
https://bugs.webkit.org/show_bug.cgi?id=63132
Removed test from skipped list, since it now passes on mac.
Patch by Marcelo Lira <marcelo.lira@openbossa.org> on 2012-05-16
Reviewed by Alexis Menard.
* platform/qt-mac/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117325
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Wed, 16 May 2012 19:40:52 +0000 (19:40 +0000)]
[WinCairo] Unreviewed build change after exported symbol
updates (r114790) and expansion of CG routines in WebPage
PDF output (r114476).
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::drawRectToPDF): Exclude CG use on WinCairo.
(WebKit::WebPage::drawPagesToPDF): Exclude CG use on WinCairo.
* win/WebKit2CFLite.def: Don't claim to export symbols we don't
provide (e.g., full screen API calls).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117324
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Wed, 16 May 2012 19:31:40 +0000 (19:31 +0000)]
Avoid reparsing the style attribute when cloning elements.
<http://webkit.org/b/86574>
Reviewed by Antti Koivisto.
Refactor cloning of attributes a bit to dodge the styleAttr reparse previously
caused by ElementAttributeData::setAttributes().
Introduced Element::cloneDataFromElement() which takes care of cloning the
ElementAttributeData as well as "non-attribute properties" (which is currently
specific to HTMLInputElement.)
Also includes some additional dodging of attribute vector traversal to find
old/new 'id' and 'name' attributes.
I'm seeing a ~10% improvement on PerformanceTests/DOM/CloneNodes locally.
* dom/Document.cpp:
(WebCore::Document::importNode):
* dom/Element.cpp:
(WebCore::Element::cloneElementWithoutChildren):
(WebCore::Element::cloneAttributesFromElement):
(WebCore::Element::cloneDataFromElement):
* dom/Element.h:
(WebCore::Element::copyNonAttributePropertiesFromElement):
* dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::cloneDataFrom):
* dom/ElementAttributeData.h:
(ElementAttributeData):
* dom/Node.h:
* dom/StyledElement.cpp:
(WebCore::StyledElement::styleAttributeChanged):
(WebCore::StyledElement::parseAttribute):
* dom/StyledElement.h:
* editing/ReplaceNodeWithSpanCommand.cpp:
(WebCore::swapInNodePreservingAttributesAndChildren):
* html/HTMLElement.cpp:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::copyNonAttributePropertiesFromElement):
* html/HTMLInputElement.h:
* inspector/DOMPatchSupport.cpp:
(WebCore::DOMPatchSupport::innerPatchNode):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::setNodeName):
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::expandSymbolElementsInShadowTree):
(WebCore::SVGUseElement::transferUseAttributesToReplacedElement):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117323
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Wed, 16 May 2012 19:25:25 +0000 (19:25 +0000)]
[WinCairo] Unreviewed build change after r115385. Several Cairo
image routines were modified to use new wrapper classes, but the
relevant WinCairo sources were not updated to match.
* WebCore.vcproj/WebCore.vcproj:
* platform/graphics/win/ImageCairoWin.cpp:
(WebCore::BitmapImage::create):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):
* platform/win/DragImageCairoWin.cpp:
(WebCore::createDragImageFromImage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117322
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy_horton@apple.com [Wed, 16 May 2012 18:45:03 +0000 (18:45 +0000)]
Scrollbar layers should respect accelerated drawing setting
https://bugs.webkit.org/show_bug.cgi?id=86644
<rdar://problem/
11462038>
Reviewed by Simon Fraser.
When creating scrollbar layers, pass through the accelerated drawing setting.
No new tests.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117314
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy_horton@apple.com [Wed, 16 May 2012 18:41:38 +0000 (18:41 +0000)]
FrameView::scrollContentsFastPath should use painted area to determine whether to drop out of the fast path
https://bugs.webkit.org/show_bug.cgi?id=86651
<rdar://problem/
11459243>
Reviewed by Simon Fraser.
Previously, we decided to fall out of the fast scrolling path by the number of fixed-position elements
on the page. This was less than ideal if a single fixed position element took up a significant portion
of the page, or if there were many small, cheap-to-paint fixed elements.
Instead, we should use the fast path if less than 50% of the page will be repainted by fixed-position
elements, and otherwise fall back to the slow path.
I've tested a few different thresholds with an internal test; 50% seems to work relatively well,
but the ideal value is hard to determine and likely depends on hardware.
No new tests, performance improvement with few large fixed-position objects or many small ones.
* page/FrameView.cpp:
(WebCore::FrameView::scrollContentsFastPath):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117313
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 16 May 2012 18:31:53 +0000 (18:31 +0000)]
[Chromium] Use ThrottledTextureUploader with threaded compositing.
https://bugs.webkit.org/show_bug.cgi?id=85848
Patch by David Reveman <reveman@chromium.org> on 2012-05-16
Reviewed by Adrienne Walker.
Switch to ThrottledUploader in CCThreadProxy.
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117312
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Wed, 16 May 2012 18:31:12 +0000 (18:31 +0000)]
Make things build with DUMP_HASHTABLE_STATS=1
https://bugs.webkit.org/show_bug.cgi?id=86571
Reviewed by Geoffrey Garen.
DUMP_HASHTABLE_STATS bitrotted after the WTF separation. This patch
makes it build.
Added WTF_EXPORTDATA to the global data, and WTF_EXPORT_PRIVATE to
the static HashTableStats methods. Added a dumpStats() method
that is not yet called anywhere; we can no longer rely on destroying
a global object to dump the stats because global destructors are
disallowed.
* wtf/HashTable.cpp:
(WTF):
(WTF::HashTableStats::recordCollisionAtCount):
(WTF::HashTableStats::dumpStats):
* wtf/HashTable.h:
(HashTableStats):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117311
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eae@chromium.org [Wed, 16 May 2012 18:30:09 +0000 (18:30 +0000)]
Change ascents and descent back to ints for now
https://bugs.webkit.org/show_bug.cgi?id=86518
Reviewed by Eric Seidel.
Change ascents and descent calculation back to integers for now as it
looks like we'll need to support both the 1/60 and 1/1 implementations of
FractionalLayoutUnit for the immediate future to ensure that text is
rendered at the same offset and with the height regardless of the
ENABLE_SUBPIXEL_LAYOUT flag.
This ensures that most websites will look the same at 100% zoom
regardless of the flag and also allows us to the same test expectations
for the vast majority of layout tests.
Eventually we want to move those back to FractionalLayoutUnits as that
will result in more correct rendering.
Source/WebCore:
No new tests, no change in functionality.
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::computeLogicalBoxHeights):
* rendering/RootInlineBox.cpp:
(WebCore::setAscentAndDescent):
(WebCore::RootInlineBox::ascentAndDescentForBox):
* rendering/RootInlineBox.h:
(RootInlineBox):
LayoutTests:
* platform/chromium-win/fast/block/float/overhanging-tall-block-expected.txt:
* platform/mac/fast/block/float/overhanging-tall-block-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117310
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kenrb@chromium.org [Wed, 16 May 2012 18:18:43 +0000 (18:18 +0000)]
Crash due to first-letter not getting computed on RenderTableCell
https://bugs.webkit.org/show_bug.cgi?id=86133
Reviewed by Abhishek Arya.
Source/WebCore:
RenderTableCell overrides RenderBlock::layout() but doesn't call
updateFirstLetter() in it. This is normally not a problem because
updateFirstLetter() gets called during preferred logical width
computation, but there exist rare occasions when layout of the table
cell happens without preferred logical widths being dirty, in which
case the first-letter update can be skipped.
This patch adds a call to updateFirstLetter() to
RenderTableCell::layout(). This ensures that the first-letter is up
to date before commencing block layout.
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::layout)
LayoutTests:
Test to exercise crashing condition in bug 86133.
* fast/css-generated-content/first-letter-table-cell-format-block-crash-expected.txt: Added
* fast/css-generated-content/first-letter-table-cell-format-block-crash.html: Added
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117309
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
senorblanco@chromium.org [Wed, 16 May 2012 17:53:18 +0000 (17:53 +0000)]
New baselines required after r117187.
https://bugs.webkit.org/show_bug.cgi?id=86486
Unreviewed gardening.
* platform/chromium-linux/svg/custom/pointer-events-image-css-transform-expected.png:
* platform/chromium-linux/svg/custom/pointer-events-image-expected.png:
* platform/chromium-mac-leopard/svg/custom/pointer-events-image-css-transform-expected.png:
* platform/chromium-mac-leopard/svg/custom/pointer-events-image-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/pointer-events-image-css-transform-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/pointer-events-image-expected.png:
* platform/chromium-mac/svg/custom/pointer-events-image-css-transform-expected.png:
* platform/chromium-mac/svg/custom/pointer-events-image-expected.png:
* platform/chromium-win/svg/custom/pointer-events-image-css-transform-expected.png:
* platform/chromium-win/svg/custom/pointer-events-image-expected.png:
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117308
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Wed, 16 May 2012 17:45:32 +0000 (17:45 +0000)]
Avoid jumpscroll when entering new text in a multi-line editor.
https://bugs.webkit.org/show_bug.cgi?id=82875
Reviewed by Ryosuke Niwa
Scroll caret to the edge of the viewport in case if a line break or a paragraph
separator is inserted at the end of a multi-line editor. This avoids
undesirable jumpscroll in cases when there is content under the editor.
Tests: editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable.html
editing/input/scroll-to-edge-if-line-break-at-end-of-document-textarea.html
editing/input/scroll-to-edge-if-paragraph-separator-at-end-of-document-contenteditable.html
* editing/Editor.cpp:
(WebCore::Editor::insertLineBreak):
(WebCore::Editor::insertParagraphSeparator):
(WebCore::Editor::revealSelectionAfterEditingOperation):
* editing/Editor.h:
(Editor):
* editing/input/resources/reveal-utilities.js:
(performJumpAtTheEdgeTest):
* editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable-expected.txt: Added.
* editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable.html: Added.
* editing/input/scroll-to-edge-if-line-break-at-end-of-document-textarea-expected.txt: Added.
* editing/input/scroll-to-edge-if-line-break-at-end-of-document-textarea.html: Added.
* editing/input/scroll-to-edge-if-paragraph-separator-at-end-of-document-contenteditable-expected.txt: Added.
* editing/input/scroll-to-edge-if-paragraph-separator-at-end-of-document-contenteditable.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117307
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Wed, 16 May 2012 17:36:23 +0000 (17:36 +0000)]
Web Inspector: Pressing esc after requesting snippet creation should remove snippet.
https://bugs.webkit.org/show_bug.cgi?id=86639
Reviewed by Pavel Feldman.
Added committed parameter to NavigatorView.rename() callback.
* inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorView.prototype.rename.commitHandler):
(WebInspector.NavigatorView.prototype.rename.cancelHandler):
(WebInspector.NavigatorView.prototype.rename.afterEditing):
* inspector/front-end/ScriptsNavigator.js:
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._snippetCreationRequested.callback):
(WebInspector.ScriptsPanel.prototype._snippetCreationRequested):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117306
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Wed, 16 May 2012 17:29:31 +0000 (17:29 +0000)]
[GTK] Add API to get plugins to WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=86356
Reviewed by Martin Robinson.
* GNUmakefile.list.am: Add new files to compilation.
* UIProcess/API/gtk/WebKitMimeInfo.cpp: Added.
(_WebKitMimeInfo): Boxed type to represent MIME type information.
(webkitMimeInfoCreate): Ceate a new WebKitMimeInfo.
(webkit_mime_info_ref):
(webkit_mime_info_unref):
(webkit_mime_info_get_mime_type): Return the mime type.
(webkit_mime_info_get_description): Return the mime type
description.
(webkit_mime_info_get_extensions): Return the list of extensions
associated to the mime type.
* UIProcess/API/gtk/WebKitMimeInfo.h: Added.
* UIProcess/API/gtk/WebKitMimeInfoPrivate.h: Added.
* UIProcess/API/gtk/WebKitPlugin.cpp: Added.
(webkitPluginFinalize):
(webkit_plugin_init):
(webkit_plugin_class_init):
(webkitPluginCreate): Create a new WebKitPlugin for the given
PluginModuleInfo.
(webkit_plugin_get_name): Return the plugin name.
(webkit_plugin_get_description): Return the plugin description.
(webkit_plugin_get_path): Return the path where the plugin is
installed.
(webkit_plugin_get_mime_info_list): Return the list of mime types
handled by the plugin.
* UIProcess/API/gtk/WebKitPlugin.h: Added.
* UIProcess/API/gtk/WebKitPluginPrivate.h: Added.
* UIProcess/API/gtk/WebKitWebContext.cpp:
(webkit_web_context_set_additional_plugins_directory): Set an
additional directory to be scanned for plugins.
(GetPluginsAsyncData): Helper struct used to asynchronously get
the list of plugins.
(getPluginsAsyncDataCreate): Create a GetPluginsAsyncData struct.
(getPluginsAsyncDataDestroy): Destroy a GetPluginsAsyncData
struct.
(webkitWebContextGetPluginThread): Thread body to get the list of
plugins installed.
(webkit_web_context_get_plugins): Asynchronously get the list of
plugins installed.
(webkit_web_context_get_plugins_finish): Finish async operation
started by webkit_web_context_get_plugins() returning a list of
WebKitPlugin.
* UIProcess/API/gtk/WebKitWebContext.h:
* UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add new section for
WebKitPlugin.
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
* UIProcess/API/gtk/docs/webkit2gtk.types: Add new types.
* UIProcess/API/gtk/tests/GNUmakefile.am:
* UIProcess/API/gtk/tests/TestWebKitWebContext.cpp:
(testWebContextGetPlugins):
(beforeAll):
* UIProcess/API/gtk/webkit2.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117305
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Wed, 16 May 2012 17:22:38 +0000 (17:22 +0000)]
Missing RenderApplet cast check in HTMLAppletElement::renderWidgetForJSBindings.
https://bugs.webkit.org/show_bug.cgi?id=86627
Reviewed by Andreas Kling.
Source/WebCore:
Test: java/inline-applet-crash.html
* html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::renderWidgetForJSBindings):
LayoutTests:
* java/inline-applet-crash-expected.txt: Added.
* java/inline-applet-crash.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117304
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Wed, 16 May 2012 16:56:17 +0000 (16:56 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=86643
http/tests/security/contentSecurityPolicy/script-src-redirect.html fails on Mac bots
* platform/mac/Skipped: Add to skipped list while Oliver and Michael are exploring it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117303
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 16 May 2012 16:38:33 +0000 (16:38 +0000)]
Web Inspector: extract CompositeUISourceCodeProvider from DebuggerScriptMapping.
https://bugs.webkit.org/show_bug.cgi?id=86634
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Extract refactoring.
* inspector/front-end/DebuggerScriptMapping.js:
(WebInspector.DebuggerScriptMapping):
(WebInspector.DebuggerScriptMapping.prototype.uiSourceCodeProviders):
(WebInspector.DebuggerScriptMapping.prototype._parsedScriptSource):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._loadUISourceCodes):
(WebInspector.ScriptsPanel.prototype._toggleFormatSource):
(WebInspector.CompositeUISourceCodeProvider):
(WebInspector.CompositeUISourceCodeProvider.prototype._registerUISourceCodeProvider):
(WebInspector.CompositeUISourceCodeProvider.prototype._handleUISourceCodeAdded):
(WebInspector.CompositeUISourceCodeProvider.prototype._handleUISourceCodeReplaced):
(WebInspector.CompositeUISourceCodeProvider.prototype._handleUISourceCodeRemoved):
(WebInspector.CompositeUISourceCodeProvider.prototype.uiSourceCodes):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCodeProvider.prototype.uiSourceCodes):
(WebInspector.UISourceCodeProvider.prototype.addEventListener):
(WebInspector.UISourceCodeProvider.prototype.removeEventListener):
LayoutTests:
* http/tests/inspector/compiler-script-mapping.html:
* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
* inspector/debugger/linkifier.html:
* inspector/debugger/scripts-panel.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117302
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Wed, 16 May 2012 16:30:10 +0000 (16:30 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=86638
Bump the version number on the WKBundlePageLoaderClient
Reviewed by Dan Bernstein.
* WebProcess/InjectedBundle/API/c/WKBundlePage.h: s/1/2/
* Shared/APIClientTraits.cpp: Update client traits for the BundlePageLoaderClient
* Shared/APIClientTraits.h: Update client traits for the BundlePageLoaderClient
* ChangeLog: Change a confusing ChangeLog entry to reflect the actual client that was changed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117301
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Wed, 16 May 2012 16:22:25 +0000 (16:22 +0000)]
Web Inspector: Double Clicking on "No watch expressions" should add an expression
https://bugs.webkit.org/show_bug.cgi?id=86631
Reviewed by Vsevolod Vlasov.
A double-click listener for the section element adds a new watch expression if the correct element
has been clicked.
Drive-by: do not persist deleted (null) watch expressions.
* inspector/front-end/WatchExpressionsSidebarPane.js:
(WebInspector.WatchExpressionsSection.prototype._sectionDoubleClick):
(WebInspector.WatchExpressionsSection.prototype.updateExpression):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117300
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Wed, 16 May 2012 16:11:43 +0000 (16:11 +0000)]
Web Inspector: Support script snippets saving.
https://bugs.webkit.org/show_bug.cgi?id=86632
Reviewed by Pavel Feldman.
Source/WebCore:
Added SnippetJavaScriptSource extending JavaScriptSource and overriding isEditable() and commitWorkingCopy() methods.
ScriptSnippetModel now creates instances of this new class for snippets.
Also maps in ScriptSnippetModel simplified.
* inspector/front-end/JavaScriptSource.js:
(WebInspector.JavaScriptSource.prototype.commitWorkingCopy):
(WebInspector):
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.commitEditing):
* inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel):
(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype.deleteScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype.renameScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype.setScriptSnippetContent):
(WebInspector.ScriptSnippetModel.prototype._uiSourceCodeList):
(WebInspector.ScriptSnippetModel.prototype._releasedUISourceCodes):
(WebInspector.SnippetJavaScriptSource):
(WebInspector.SnippetJavaScriptSource.prototype.isEditable):
(WebInspector.SnippetJavaScriptSource.prototype.commitWorkingCopy):
(WebInspector.SnippetJavaScriptSource.prototype.get snippetId):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.set _fileRenamed):
(WebInspector.ScriptsPanel.prototype._snippetCreationRequested.callback):
(WebInspector.ScriptsPanel.prototype._snippetCreationRequested):
LayoutTests:
* inspector/debugger/script-snippet-model.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117299
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 16 May 2012 16:09:41 +0000 (16:09 +0000)]
[EFL] Rounding errors on 32-bit machines causes tests to fail
https://bugs.webkit.org/show_bug.cgi?id=86194
Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-16
Reviewed by Martin Robinson.
Pass additional CXXFLAGS to CMake in an attempt to harmonize floating
point values between 32-bit and 64-bit architectures.
Same flags are already used by Qt and GTK ports.
* Scripts/webkitdirs.pm:
(determineArchitecture):
(generateBuildSystemFromCMakeProject):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117298
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 16 May 2012 16:00:54 +0000 (16:00 +0000)]
[EFL] Memory leak in RenderThemeEfl
https://bugs.webkit.org/show_bug.cgi?id=86609
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-16
Reviewed by Martin Robinson.
Fix a memory leak by freeing the cairo surface with
cairo_surface_destroy.
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::cacheThemePartFlush):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117297
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 16 May 2012 15:49:36 +0000 (15:49 +0000)]
Web Inspector: Speedup heap snapshot postprocessing
https://bugs.webkit.org/show_bug.cgi?id=86635
Patch by Alexei Filippov <alexeif@chromium.org> on 2012-05-16
Reviewed by Yury Semikhatsky.
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype._markQueriableHeapObjects):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117296
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Wed, 16 May 2012 15:48:01 +0000 (15:48 +0000)]
Unreviewed, followup for r117273 that fixes the Web Inspector's Computed Style pane layout.
* inspector/front-end/elementsPanel.css:
(.styles-section.computed-style.expanded .properties > li):
(.styles-section.computed-style.expanded .properties > li .webkit-css-property):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117295
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 16 May 2012 15:42:12 +0000 (15:42 +0000)]
[Qt] New failing and flakey tests with newer Qt 5
https://bugs.webkit.org/show_bug.cgi?id=86452
Unreviewed gardening, skip new failing/flakey tests to paint
the bots green. (To be able to catch new and new regressions.)
* platform/qt-5.0-wk1/Skipped:
* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117294
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Wed, 16 May 2012 15:41:08 +0000 (15:41 +0000)]
Web Inspector: [Extensions API] expose evaluateOptions in audit formatters
https://bugs.webkit.org/show_bug.cgi?id=86617
Reviewed by Pavel Feldman.
Source/WebCore:
Test: inspector/extensions/extensions-audits-content-script.html
- apply extension-specific audit formatters earlier (in ExtensionAduitCategory, not along with the rest in AuditFormatters);
- use ExtensionServer.evaluate() to handle evaluateOptions instead of PageAgent.evaluate();
* inspector/front-end/AuditFormatters.js: Move node and object formatters to ExtensionAuditCategory.
(WebInspector.partiallyApplyFormatters): Added a method to traverse formatters tree and apply formatters that are passed as input.
* inspector/front-end/ExtensionAuditCategory.js:
(WebInspector.ExtensionAuditCategory): Pass extensionOrigin.
(WebInspector.ExtensionAuditCategoryResults.prototype._addNode): Apply extensions formatters before adding the result.
(WebInspector.ExtensionAuditCategoryResults.prototype._addResult):
(WebInspector.ExtensionAuditCategoryResults.prototype.evaluate): moved from AuditFormatters.
(WebInspector.ExtensionAuditFormatters.object.onEvaluate):
(WebInspector.ExtensionAuditFormatters.object):
(WebInspector.ExtensionAuditFormatters.node.onNodeAvailable):
(WebInspector.ExtensionAuditFormatters.node.onEvaluate):
(WebInspector.ExtensionAuditFormatters.node):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onAddAuditCategory): Plumb extensionOrigin through to audit category.
LayoutTests:
* inspector/extensions/extensions-audits-content-script-expected.txt: Added.
* inspector/extensions/extensions-audits-content-script.html: Added.
* platform/gtk/test_expectations.txt:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117293
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 16 May 2012 15:27:10 +0000 (15:27 +0000)]
Add missing include that was causing build errors.
https://bugs.webkit.org/show_bug.cgi?id=86502
Patch by Genevieve Mak <gmak@rim.com> on 2012-05-16
Reviewed by Rob Buis.
Reviewed Internally by Liam Quinn.
* WebKitSupport/InputHandler.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117292
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 16 May 2012 14:56:52 +0000 (14:56 +0000)]
Fixes the build with Qt 5 HEAD
Patch by Donald Carr <donald.carr@nokia.com> on 2012-05-16
Reviewed by Csaba Osztrogonác.
* WebCore.pri:
* platform/graphics/texmap/TextureMapperGL.cpp:
* plugins/qt/PluginViewQt.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117291
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Wed, 16 May 2012 14:52:56 +0000 (14:52 +0000)]
[Chromium] Web Inspector: DevToolsSanityTest.TestScriptsTabIsPopulatedOnInspectedPageRefresh is broken
https://bugs.webkit.org/show_bug.cgi?id=86629
Reviewed by Pavel Feldman.
Listen to DebuggerModel instead of DebuggerPresentationModel which is gone.
* src/js/Tests.js:
(.TestSuite.prototype.testScriptsTabIsPopulatedOnInspectedPageRefresh.waitUntilScriptIsParsed):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117290
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis@webkit.org [Wed, 16 May 2012 14:47:05 +0000 (14:47 +0000)]
SVGSVGElement checkIntersection and checkEnclosure Mem corruption
https://bugs.webkit.org/show_bug.cgi?id=67923
Patch by Rob Buis <rbuis@rim.com> on 2012-05-16
Reviewed by Nikolas Zimmermann.
Source/WebCore:
Only call checkIntersection/checkEnclosure when we have a valid renderer.
Test: svg/custom/intersection-list-null.svg
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::checkIntersection):
(WebCore::SVGSVGElement::checkEnclosure):
LayoutTests:
Add test to check that checkIntersection/checkEnclosure do not
crash when null is used for the element parameter.
* svg/custom/intersection-list-null-expected.txt: Added.
* svg/custom/intersection-list-null.svg: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117289
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Wed, 16 May 2012 14:23:43 +0000 (14:23 +0000)]
[Qt] Web process hangs while waiting for plugin process connection during layouttests
https://bugs.webkit.org/show_bug.cgi?id=86620
Reviewed by Csaba Osztrogonác.
Temporary workaround not to fail layout tests.
* Tools.pro: Disable TestNetscapePlugin.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117288
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Wed, 16 May 2012 14:22:30 +0000 (14:22 +0000)]
[Chromium] Web Inspector: debugger browser tests are broken
https://bugs.webkit.org/show_bug.cgi?id=86624
Reviewed by Vsevolod Vlasov.
Use WebInspector.panels.scripts._scriptMapping instead of
WebInspector.panels.scripts._presentationModel as the latter
has been deleted.
* src/js/Tests.js:
(.TestSuite.prototype.nonAnonymousUISourceCodes_):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117287
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Wed, 16 May 2012 14:21:02 +0000 (14:21 +0000)]
Source/WebCore: Unreviewed, rolling out r110699.
http://trac.webkit.org/changeset/110699
https://bugs.webkit.org/show_bug.cgi?id=80982
Not needed anymore and broke modal event loops
* platform/qt/RunLoopQt.cpp:
(WebCore::RunLoop::TimerObject::TimerObject):
(WebCore::RunLoop::TimerObject::performWork):
(RunLoop::TimerObject):
LayoutTests: Unskip fast/animation/request-animation-frame-during-modal.html that was
skipped due to r110699.
* platform/qt-5.0-wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117286
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 16 May 2012 14:08:05 +0000 (14:08 +0000)]
[EFL] Fix uninitialized struct member added by r117258
https://bugs.webkit.org/show_bug.cgi?id=86611
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-16
Reviewed by Gustavo Noronha Silva.
When adding a new member to _Ewk_View_Smart_Class,
EWK_VIEW_SMART_CLASS_VERSION needs to be updated.
* ewk/ewk_view.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117285
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 16 May 2012 13:58:53 +0000 (13:58 +0000)]
Unreviewed gardening: updating expectations after r117259
https://bugs.webkit.org/show_bug.cgi?id=86463
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt: Added.
* platform/qt-5.0-wk2/svg/custom/altglyph-expected.png: Added.
* platform/qt-5.0-wk2/svg/custom/altglyph-expected.txt: Added.
* platform/qt-5.0-wk2/svg/custom/font-face-simple-expected.png: Added.
* platform/qt-5.0-wk2/svg/custom/font-face-simple-expected.txt: Added.
* platform/qt-5.0-wk2/svg/text/kerning-expected.png: Added.
* platform/qt-5.0-wk2/svg/text/kerning-expected.txt: Added.
* platform/qt-5.0-wk2/svg/text/multichar-glyph-expected.png: Added.
* platform/qt-5.0-wk2/svg/text/multichar-glyph-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1/animate-elem-06-t-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1/filters-light-04-f-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1/render-elems-06-t-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1/render-elems-07-t-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1/render-elems-08-t-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1/render-groups-01-b-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1/render-groups-03-t-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1/text-text-01-b-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1/text-text-01-b-expected.txt: Added.
* platform/qt-5.0/svg/batik/text/smallFonts-expected.png: Added.
* platform/qt-5.0/svg/batik/text/smallFonts-expected.txt: Added.
* platform/qt-5.0/svg/batik/text/textAnchor-expected.png: Added.
* platform/qt-5.0/svg/batik/text/textAnchor-expected.txt: Added.
* platform/qt-5.0/svg/batik/text/textEffect-expected.png: Added.
* platform/qt-5.0/svg/batik/text/textEffect-expected.txt: Added.
* platform/qt-5.0/svg/batik/text/textEffect3-expected.png: Added.
* platform/qt-5.0/svg/batik/text/textEffect3-expected.txt: Added.
* platform/qt-5.0/svg/batik/text/textPosition2-expected.png: Added.
* platform/qt-5.0/svg/batik/text/textPosition2-expected.txt:
* platform/qt-5.0/svg/carto.net/window-expected.png: Added.
* platform/qt-5.0/svg/carto.net/window-expected.txt: Added.
* platform/qt-5.0/svg/custom/glyph-selection-arabic-forms-expected.png: Added.
* platform/qt-5.0/svg/custom/glyph-selection-arabic-forms-expected.txt:
* platform/qt-5.0/svg/custom/glyph-selection-bidi-mirror-expected.png: Added.
* platform/qt-5.0/svg/custom/glyph-selection-bidi-mirror-expected.txt:
* platform/qt-5.0/svg/custom/glyph-selection-non-bmp-expected.png: Added.
* platform/qt-5.0/svg/custom/glyph-selection-non-bmp-expected.txt:
* platform/qt-5.0/svg/custom/glyph-transformation-with-hkern-expected.png: Added.
* platform/qt-5.0/svg/custom/glyph-transformation-with-hkern-expected.txt: Added.
* platform/qt-5.0/svg/custom/preserve-aspect-ratio-syntax-expected.png: Added.
* platform/qt-5.0/svg/custom/preserve-aspect-ratio-syntax-expected.txt: Added.
* platform/qt-5.0/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
* platform/qt-5.0/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
* platform/qt-5.0/svg/custom/svg-features-expected.txt: Added.
* platform/qt-5.0/svg/custom/svg-fonts-in-html-expected.png: Added.
* platform/qt-5.0/svg/custom/svg-fonts-in-html-expected.txt: Added.
* platform/qt-5.0/svg/custom/svg-fonts-segmented-expected.png: Added.
* platform/qt-5.0/svg/custom/svg-fonts-segmented-expected.txt: Added.
* platform/qt-5.0/svg/custom/text-linking-expected.png: Added.
* platform/qt-5.0/svg/custom/text-linking-expected.txt: Added.
* platform/qt-5.0/svg/foreignObject/text-tref-02-b-expected.png: Added.
* platform/qt-5.0/svg/foreignObject/text-tref-02-b-expected.txt: Added.
* platform/qt-5.0/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.png: Added.
* platform/qt-5.0/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt: Added.
* platform/qt-5.0/svg/text/text-align-01-b-expected.png: Added.
* platform/qt-5.0/svg/text/text-align-01-b-expected.txt: Added.
* platform/qt-5.0/svg/text/text-align-02-b-expected.png: Added.
* platform/qt-5.0/svg/text/text-align-02-b-expected.txt: Added.
* platform/qt-5.0/svg/text/text-align-04-b-expected.png: Added.
* platform/qt-5.0/svg/text/text-align-04-b-expected.txt: Added.
* platform/qt-5.0/svg/text/text-align-06-b-expected.png: Added.
* platform/qt-5.0/svg/text/text-align-06-b-expected.txt: Added.
* platform/qt-5.0/svg/text/text-overflow-ellipsis-svgfont-expected.png: Added.
* platform/qt-5.0/svg/text/text-overflow-ellipsis-svgfont-expected.txt: Added.
* platform/qt-5.0/svg/text/text-text-01-b-expected.png: Added.
* platform/qt-5.0/svg/text/text-text-01-b-expected.txt: Added.
* platform/qt-5.0/svg/text/text-text-04-t-expected.png: Added.
* platform/qt-5.0/svg/text/text-text-04-t-expected.txt: Added.
* platform/qt-5.0/svg/text/text-tselect-01-b-expected.png: Added.
* platform/qt-5.0/svg/text/text-tselect-01-b-expected.txt: Added.
* platform/qt-5.0/svg/text/text-tspan-01-b-expected.png: Added.
* platform/qt-5.0/svg/text/text-tspan-01-b-expected.txt: Added.
* platform/qt-5.0/svg/transforms/text-with-mask-with-svg-transform-expected.png: Added.
* platform/qt-5.0/svg/transforms/text-with-mask-with-svg-transform-expected.txt: Added.
* platform/qt-5.0/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Added.
* platform/qt-5.0/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt: Added.
* platform/qt-5.0/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Added.
* platform/qt-5.0/svg/transforms/text-with-pattern-with-svg-transform-expected.txt: Added.
* platform/qt-5.0/svg/wicd/test-rightsizing-b-expected.png: Added.
* platform/qt-5.0/svg/wicd/test-rightsizing-b-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117284
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 16 May 2012 13:55:04 +0000 (13:55 +0000)]
Web Inspector: split ScriptMapping into UISourceCodeProvider and SourceMapping.
https://bugs.webkit.org/show_bug.cgi?id=86616
Reviewed by Vsevolod Vlasov.
Source/WebCore:
This change simply splits the interface.
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/CompilerScriptMapping.js:
(WebInspector.CompilerScriptMapping.prototype.get uiSourceCodes):
(WebInspector.CompilerScriptMapping.prototype.reset):
* inspector/front-end/DebuggerModel.js:
* inspector/front-end/DebuggerResourceBinding.js:
(WebInspector.DebuggerResourceBinding):
(WebInspector.DebuggerResourceBinding.prototype._uiSourceCodeForResource):
* inspector/front-end/DebuggerScriptMapping.js:
(WebInspector.DebuggerScriptMapping):
(WebInspector.DebuggerScriptMapping.prototype.uiSourceCodes):
(WebInspector.DebuggerScriptMapping.prototype._handleUISourceCodeAdded):
(WebInspector.DebuggerScriptMapping.prototype._handleUISourceCodeReplaced):
(WebInspector.DebuggerScriptMapping.prototype._handleUISourceCodeRemoved):
* inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.OpenScriptDialog):
(WebInspector.OpenScriptDialog.install):
(WebInspector.OpenScriptDialog._show):
* inspector/front-end/PresentationConsoleMessageHelper.js:
(WebInspector.PresentationConsoleMessageHelper):
(WebInspector.PresentationConsoleMessageHelper.prototype._consoleCleared):
* inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype.uiSourceCodes):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeAdded):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeReplaced):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeRemoved):
* inspector/front-end/Script.js:
* inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel.prototype._uiSourceCodes):
(WebInspector.SnippetScriptMapping.prototype.uiSourceCodes):
(WebInspector.SnippetScriptMapping.prototype._fireUISourceCodeAdded):
(WebInspector.SnippetScriptMapping.prototype._fireUISourceCodeRemoved):
* inspector/front-end/ScriptsPanel.js:
* inspector/front-end/ScriptsSearchScope.js:
(WebInspector.ScriptsSearchScope):
(WebInspector.ScriptsSearchScope.prototype._sortedUISourceCodes):
* inspector/front-end/SourceMapping.js: Renamed from Source/WebCore/inspector/front-end/ScriptMapping.js.
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCodeProvider):
(WebInspector.UISourceCodeProvider.prototype.uiSourceCodes):
(WebInspector.UILocation):
(WebInspector.UILocation.prototype.uiLocationToRawLocation):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
LayoutTests:
* http/tests/inspector/compiler-script-mapping.html:
* inspector/debugger/scripts-panel.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117277
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 16 May 2012 13:47:38 +0000 (13:47 +0000)]
Add didFinishProgress BundleUIClient callback
https://bugs.webkit.org/show_bug.cgi?id=86541
Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-05-16
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
Added didFinishProgress BundleUIClient callback needed by
WebKitTestRunner. This callback is invoked in postProgressFinishedNotification.
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::didFinishProgress):
(WebKit):
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
(InjectedBundlePageLoaderClient):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::postProgressFinishedNotification):
* WebProcess/qt/QtBuiltinBundlePage.cpp:
(WebKit::QtBuiltinBundlePage::QtBuiltinBundlePage):
Tools:
Added support for dumpProgressFinishedCallback.
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::didFinishProgress):
(WTR):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
(InjectedBundlePage):
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::LayoutTestController):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(WTR::LayoutTestController::dumpProgressFinishedCallback):
(WTR::LayoutTestController::setShouldDumpProgressFinishedCallback):
(WTR::LayoutTestController::shouldDumpProgressFinishedCallback):
(LayoutTestController):
LayoutTests:
Unskip passing test.
* platform/qt-5.0-wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117276
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kkristof@inf.u-szeged.hu [Wed, 16 May 2012 13:44:41 +0000 (13:44 +0000)]
[Qt] Unreviewed gardening. Fix my typo.
Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-05-16
* platform/qt/Skipped: After r117262.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117275
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Wed, 16 May 2012 13:40:58 +0000 (13:40 +0000)]
Web Inspector: Implement snippet creation/renaming in ScriptsNavigator.
https://bugs.webkit.org/show_bug.cgi?id=82622
Reviewed by Pavel Feldman.
Implemented snippet creation and renaming.
Added TitleChanged event to UISourceCode.
* inspector/front-end/NavigatorOverlayController.js:
(WebInspector.NavigatorOverlayController.prototype._containingElementFocused):
(WebInspector.NavigatorOverlayController.prototype.isNavigatorPinned):
(WebInspector.NavigatorOverlayController.prototype.isNavigatorHidden):
* inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorView.prototype._uiSourceCodeTitleChanged):
(WebInspector.NavigatorView.prototype._updateScriptTitle):
(WebInspector.NavigatorView.prototype._addUISourceCodeListeners):
(WebInspector.NavigatorView.prototype._removeUISourceCodeListeners):
(WebInspector.NavigatorView.prototype._fileRenamed):
(WebInspector.NavigatorScriptTreeElement.prototype.onattach):
* inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
* inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator):
(WebInspector.ScriptsNavigator.prototype._snippetsNavigatorViewForUISourceCode):
(WebInspector.ScriptsNavigator.prototype.addUISourceCode):
(WebInspector.ScriptsNavigator.prototype.isScriptSourceAdded):
(WebInspector.ScriptsNavigator.prototype.revealUISourceCode):
(WebInspector.ScriptsNavigator.prototype.replaceUISourceCode):
(WebInspector.ScriptsNavigator.prototype.rename):
(WebInspector.ScriptsNavigator.prototype._fileRenamed):
(WebInspector.ScriptsNavigator.prototype._snippetCreationRequested):
(WebInspector.SnippetsNavigatorView.prototype._handleCreateSnippet):
(WebInspector.SnippetsNavigatorView.prototype._snippetCreationRequested):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.set _hideDebuggerSidebar):
(WebInspector.ScriptsPanel.prototype.set _fileRenamed):
(WebInspector.ScriptsPanel.prototype._snippetCreationRequested.callback):
(WebInspector.ScriptsPanel.prototype._snippetCreationRequested):
* inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.prototype._appendFileTab):
(WebInspector.TabbedEditorContainer.prototype._tabClosed):
(WebInspector.TabbedEditorContainer.prototype._uiSourceCodeTitleChanged):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.urlChanged):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117274
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Wed, 16 May 2012 13:25:53 +0000 (13:25 +0000)]
Web Inspector: gradient properties are painful to inspect / author.
https://bugs.webkit.org/show_bug.cgi?id=86379
Reviewed by Pavel Feldman.
The CSS styles layout has been changed to allow property values to wrap onto subsequent lines
to let the users see the entire value text.
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.): Avoid line breaks between the color swatch and value.
* inspector/front-end/elementsPanel.css:
(.styles-section .properties li.not-parsed-ok img.exclamation-mark):
(.styles-section .properties li):
(.styles-section .properties li .webkit-css-property):
(.styles-section.expanded .properties > li):
(.styles-section .properties > li .webkit-css-property):
(.styles-section .properties > li.child-editing):
(.styles-section .properties > li.child-editing .webkit-css-property):
(.styles-section .properties .enabled-button):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117273
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Wed, 16 May 2012 13:16:57 +0000 (13:16 +0000)]
Web Inspector: rename ProfileView.js to CPUProfileView.js
https://bugs.webkit.org/show_bug.cgi?id=86612
Reviewed by Pavel Feldman.
Renamed ProfileView.js to CPUProfileView.js to match the file content.
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/CPUProfileView.js: Renamed from Source/WebCore/inspector/front-end/ProfileView.js.
(WebInspector.CPUProfileView.profileCallback):
(WebInspector.CPUProfileView.prototype.get statusBarItems):
(WebInspector.CPUProfileView.prototype.get profile):
(WebInspector.CPUProfileView.prototype.set profile):
(WebInspector.CPUProfileView.prototype.get bottomUpProfileDataGridTree):
(WebInspector.CPUProfileView.prototype.get topDownProfileDataGridTree):
(WebInspector.CPUProfileView.prototype.get currentTree):
(WebInspector.CPUProfileView.prototype.set currentTree):
(WebInspector.CPUProfileView.prototype.willHide):
(WebInspector.CPUProfileView.prototype.refresh):
(WebInspector.CPUProfileView.prototype.refreshVisibleData):
(WebInspector.CPUProfileView.prototype.refreshShowAsPercents):
(WebInspector.CPUProfileView.prototype.searchCanceled):
(WebInspector.CPUProfileView.prototype.performSearch.matchesQuery):
(WebInspector.CPUProfileView.prototype.performSearch):
(WebInspector.CPUProfileView.prototype.jumpToFirstSearchResult):
(WebInspector.CPUProfileView.prototype.jumpToLastSearchResult):
(WebInspector.CPUProfileView.prototype.jumpToNextSearchResult):
(WebInspector.CPUProfileView.prototype.jumpToPreviousSearchResult):
(WebInspector.CPUProfileView.prototype.showingFirstSearchResult):
(WebInspector.CPUProfileView.prototype.showingLastSearchResult):
(WebInspector.CPUProfileView.prototype._jumpToSearchResult):
(WebInspector.CPUProfileView.prototype._changeView.set else):
(WebInspector.CPUProfileView.prototype._focusClicked):
(WebInspector.CPUProfileView.prototype._excludeClicked):
(WebInspector.CPUProfileView.prototype._resetClicked):
(WebInspector.CPUProfileView.prototype._dataGridNodeSelected):
(WebInspector.CPUProfileView.prototype._dataGridNodeDeselected):
(WebInspector.CPUProfileView.prototype._sortProfile):
(WebInspector.CPUProfileView.prototype._assignParentsInProfile):
(WebInspector.CPUProfileType):
(WebInspector.CPUProfileType.prototype.get buttonTooltip):
(WebInspector.CPUProfileType.prototype.buttonClicked):
(WebInspector.CPUProfileType.prototype.get treeItemTitle):
(WebInspector.CPUProfileType.prototype.get description):
(WebInspector.CPUProfileType.prototype.isRecordingProfile):
(WebInspector.CPUProfileType.prototype.startRecordingProfile):
(WebInspector.CPUProfileType.prototype.stopRecordingProfile):
(WebInspector.CPUProfileType.prototype.setRecordingProfile):
(WebInspector.CPUProfileType.prototype.createSidebarTreeElementForProfile):
(WebInspector.CPUProfileType.prototype.createView):
(WebInspector.CPUProfileType.prototype.createTemporaryProfile):
(WebInspector.CPUProfileType.prototype.createProfile):
* inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.prototype.performSearch.matchesByName):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117272
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 16 May 2012 12:53:28 +0000 (12:53 +0000)]
"border: collapse" + "display: none" rows in the tbody while having thead or tfoot doesn't render the opposite border
https://bugs.webkit.org/show_bug.cgi?id=67877
Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2012-05-16
Reviewed by Antti Koivisto.
Source/WebCore:
Test: fast/css/table-collapsed-borders.html
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::computeCollapsedBeforeBorder):
When getting the previous row group's after border, pass SkipEmptySections as the second param
to the RenderTable::sectionAbove() call. Thus if the currSection is the top most section of the
table passing SkipEmptySections to sectionAbove() would return null which should be the expected
behavior.
(WebCore::RenderTableCell::computeCollapsedAfterBorder):
When getting the following row group's before border, pass SkipEmptySections as the second param
to the RenderTable::sectionBelow() call. Thus if the currSection is the bottom most section of the
table passing SkipEmptySections to sectionBelow() would return null which should be the expected
behavior.
LayoutTests:
* fast/css/table-collapsed-borders-expected.html: Added.
* fast/css/table-collapsed-borders.html: Added.
Added new reftest for testing table with collapsed borders.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117271
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 16 May 2012 12:48:50 +0000 (12:48 +0000)]
Web Inspector: follow up to r117267 - fixing typo and removing unnecessary dispatch.
https://bugs.webkit.org/show_bug.cgi?id=86613
Reviewed by Vsevolod Vlasov.
* inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeAdded):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeReplaced):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117270
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Wed, 16 May 2012 12:41:26 +0000 (12:41 +0000)]
Web Inspector: Move edit/save script source logic to JavaScriptSource.
https://bugs.webkit.org/show_bug.cgi?id=86604
Reviewed by Pavel Feldman.
Source/WebCore:
Added working copy notion to UISourceCode.
Moved DebuggerResourceBinding content edit calls to JavaScriptSource.
Added WorkingCopyChanged event to UISourceCode.
* inspector/front-end/CompilerScriptMapping.js:
* inspector/front-end/DebuggerResourceBinding.js:
(WebInspector.DebuggerResourceBinding.prototype.canSetContent):
* inspector/front-end/JavaScriptSource.js:
(WebInspector.JavaScriptSource):
(WebInspector.JavaScriptSource.prototype.breakpointStorageId):
(WebInspector.JavaScriptSource.prototype.isEditable):
(WebInspector.JavaScriptSource.prototype.commitWorkingCopy):
(WebInspector):
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.wasShown):
(WebInspector.JavaScriptSourceFrame.prototype.canEditSource):
(WebInspector.JavaScriptSourceFrame.prototype.commitEditing):
(WebInspector.JavaScriptSourceFrame.prototype.afterTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype.beforeTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype._didEditContent):
(WebInspector.JavaScriptSourceFrame.prototype._onMouseDown):
* inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorView.prototype._uiSourceCodeWorkingCopyChanged):
(WebInspector.NavigatorView.prototype._uiSourceCodeContentChanged):
(WebInspector.NavigatorView.prototype._updateScriptTitle):
(WebInspector.NavigatorView.prototype._removeUISourceCode):
(WebInspector.NavigatorView.prototype._addUISourceCodeListeners):
(WebInspector.NavigatorView.prototype._removeUISourceCodeListeners):
(WebInspector.NavigatorView.prototype.reset):
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype._createUISourceCode):
* inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):
* inspector/front-end/ScriptsPanel.js:
* inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer):
(WebInspector.TabbedEditorContainer.prototype._titleForFile):
(WebInspector.TabbedEditorContainer.prototype._appendFileTab):
(WebInspector.TabbedEditorContainer.prototype._tabClosed):
(WebInspector.TabbedEditorContainer.prototype._updateFileTitle.get if):
(WebInspector.TabbedEditorContainer.prototype._updateFileTitle):
(WebInspector.TabbedEditorContainer.prototype._uiSourceCodeWorkingCopyChanged):
(WebInspector.TabbedEditorContainer.prototype._uiSourceCodeContentChanged):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.contentChanged):
(WebInspector.UISourceCode.prototype.isEditable):
(WebInspector.UISourceCode.prototype.workingCopy):
(WebInspector.UISourceCode.prototype.setWorkingCopy):
(WebInspector.UISourceCode.prototype.isDirty):
(WebInspector.UISourceCode.prototype.commitWorkingCopy):
LayoutTests:
* inspector/debugger/breakpoint-manager.html:
* inspector/debugger/scripts-panel.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117269
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 16 May 2012 12:36:22 +0000 (12:36 +0000)]
[EFL] A few tests need expected result or rebaselining
https://bugs.webkit.org/show_bug.cgi?id=86595
Unreviewed EFL gardening. Add missing EFL text expectation for
media/video-frame-accurate-seek.html.
Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-16
* platform/efl/media/video-frame-accurate-seek-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117268
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 16 May 2012 12:22:29 +0000 (12:22 +0000)]
Web Inspector: get rid of UISourceCodeListChanged event.
https://bugs.webkit.org/show_bug.cgi?id=86601
Reviewed by Vsevolod Vlasov.
Source/WebCore:
There was unnecessary conversion between this event and UISourceCodeAdded/Removed/Replaced.
* inspector/front-end/CompilerScriptMapping.js:
(WebInspector.CompilerScriptMapping.prototype.reset):
* inspector/front-end/DebuggerScriptMapping.js:
(WebInspector.DebuggerScriptMapping):
(WebInspector.DebuggerScriptMapping.prototype._handleUISourceCodeAdded):
(WebInspector.DebuggerScriptMapping.prototype._handleUISourceCodeReplaced):
(WebInspector.DebuggerScriptMapping.prototype._handleUISourceCodeRemoved):
* inspector/front-end/NavigatorView.js:
* inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype.addScript):
(WebInspector.ResourceScriptMapping.prototype._handleUISourceCodeChanged):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeAdded):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeReplaced):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeRemoved):
(WebInspector.ResourceScriptMapping.prototype.reset):
* inspector/front-end/ScriptMapping.js:
* inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):
(WebInspector.ScriptSnippetModel.prototype._reset):
(WebInspector.SnippetScriptMapping.prototype._fireUISourceCodeAdded):
(WebInspector.SnippetScriptMapping.prototype._fireUISourceCodeRemoved):
* inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator.prototype.replaceUISourceCode):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced):
* inspector/front-end/TabbedEditorContainer.js:
LayoutTests:
* http/tests/inspector/compiler-script-mapping.html:
* inspector/debugger/scripts-panel.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117267
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Wed, 16 May 2012 12:07:25 +0000 (12:07 +0000)]
[chromium] Layout tests under inspector/profiler are failing on chromium win
https://bugs.webkit.org/show_bug.cgi?id=86495
Unreviewed. Remove custom expectations for heap profiler tests. They should pass
after r117241.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117266
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 16 May 2012 12:00:33 +0000 (12:00 +0000)]
[EFL] Remove full-screen-keyboard-disabled.html from test_expectation.txt
https://bugs.webkit.org/show_bug.cgi?id=86596
Unreviewed EFL gardening.
Remove full-screen-keyboard-disabled.html from test_expectation.txt.
This case is not failed since r117205.
Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-05-16
* platform/efl/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117265
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 16 May 2012 11:58:01 +0000 (11:58 +0000)]
[EFL] [DRT] Unskip passing tests related to computedStyleIncludingVisitedInfo and display
https://bugs.webkit.org/show_bug.cgi?id=86473
Unreviewed gardening, partially reverts r117073.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-16
* platform/efl/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117264
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
keishi@webkit.org [Wed, 16 May 2012 11:55:20 +0000 (11:55 +0000)]
[chromium] Add WebKit API to access inner text value of input element
https://bugs.webkit.org/show_bug.cgi?id=85353
Reviewed by Kent Tamura.
.:
* Source/autotools/symbols.filter: Added HTMLInputElement::setEditingValue
Source/WebCore:
Test: fast/forms/editing-value.html
We need this to implement the datalist UI for <input type=email multiple>.
HTMLInputElement.value gives you the sanitized value so the whitespace between values are trimmed.
We need to append the selected suggestion to the end without modifying the rest of the text.
* WebCore.exp.in: Added HTMLInputElement::setEditingValue
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setEditingValue):
(WebCore):
* html/HTMLInputElement.h:
(HTMLInputElement):
* testing/Internals.cpp:
(WebCore::Internals::setEditingValue):
(WebCore):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:
Source/WebKit/chromium:
* public/WebInputElement.h:
(WebInputElement):
* src/WebInputElement.cpp:
(WebKit::WebInputElement::editingValue):
(WebKit):
(WebKit::WebInputElement::setEditingValue):
Source/WebKit2:
* win/WebKit2.def: Added HTMLInputElement::setEditingValue
* win/WebKit2CFLite.def: Added HTMLInputElement::setEditingValue
LayoutTests:
* fast/forms/editing-value-expected.txt: Added.
* fast/forms/editing-value.html: Added. Tests that setting the editing value takes care of the style and placeholder, and that it fires an input event.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117263
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kkristof@inf.u-szeged.hu [Wed, 16 May 2012 11:47:13 +0000 (11:47 +0000)]
[Qt] Gardening. Skip failing test after 117246.
https://bugs.webkit.org/show_bug.cgi?id=86606
Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-05-16
Reviewed by Csaba Osztrongonác.
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117262
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 16 May 2012 11:43:14 +0000 (11:43 +0000)]
[BlackBerry] Cookies should be checked during parsing to improve performance.
https://bugs.webkit.org/show_bug.cgi?id=85028
Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-05-16
Reviewed by George Staikos.
We shouldn't waste time and memery on invalid cookies. It is better to drop them during parsing.
We shouldn't check the default domain since it is set with host. So we only check domains which are parsed
from response headers.
No new tests. No functionality change.
* platform/blackberry/CookieManager.cpp:
(WebCore::CookieManager::setCookies):
* platform/blackberry/CookieManager.h:
* platform/blackberry/CookieParser.cpp:
(WebCore::CookieParser::parseOneCookie):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117261
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pierre.rossi@gmail.com [Wed, 16 May 2012 11:36:30 +0000 (11:36 +0000)]
Unreviewed gardening: updating expectations after r117259
https://bugs.webkit.org/show_bug.cgi?id=86463
* platform/qt/http/tests/misc/SVGFont-delayed-load-expected.txt: Added.
* platform/qt/svg/W3C-SVG-1.1/animate-elem-03-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/animate-elem-24-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png: Added.
* platform/qt/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt: Added.
* platform/qt/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/struct-cond-03-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/struct-cond-03-t-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1/struct-image-02-b-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/text-align-08-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1/text-align-08-b-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/text-fonts-03-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/text-fonts-03-t-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/text-intro-01-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/text-intro-01-t-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/text-intro-02-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1/text-intro-02-b-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/text-intro-03-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1/text-intro-03-b-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/text-intro-04-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/text-intro-04-t-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/text-text-04-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/text-text-04-t-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/text-text-05-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/text-text-05-t-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/text-text-06-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/text-text-06-t-expected.txt:
* platform/qt/svg/custom/acid3-test-77-expected.txt: Added.
* platform/qt/svg/custom/altglyph-expected.png:
* platform/qt/svg/custom/altglyph-expected.txt:
* platform/qt/svg/custom/font-face-simple-expected.png:
* platform/qt/svg/custom/font-face-simple-expected.txt:
* platform/qt/svg/custom/global-constructors-expected.txt: Added.
* platform/qt/svg/custom/glyph-selection-lang-attribute-expected.png:
* platform/qt/svg/custom/glyph-selection-lang-attribute-expected.txt:
* platform/qt/svg/custom/glyph-setting-d-attribute-expected.png:
* platform/qt/svg/custom/glyph-setting-d-attribute-expected.txt: Added.
* platform/qt/svg/custom/insertItemBefore-from-non-list-origin-expected.txt: Added.
* platform/qt/svg/custom/missing-xlink-expected.png: Added.
* platform/qt/svg/custom/missing-xlink-expected.txt: Added.
* platform/qt/svg/custom/path-bad-data-expected.png: Added.
* platform/qt/svg/custom/path-bad-data-expected.txt: Added.
* platform/qt/svg/custom/stroke-width-click-expected.txt: Added.
* platform/qt/svg/custom/svg-fonts-with-no-element-reference-expected.png:
* platform/qt/svg/custom/svg-fonts-with-no-element-reference-expected.txt:
* platform/qt/svg/custom/svg-fonts-without-missing-glyph-expected.png:
* platform/qt/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
* platform/qt/svg/custom/svg-fonts-word-spacing-expected.png: Added.
* platform/qt/svg/custom/svg-fonts-word-spacing-expected.txt: Added.
* platform/qt/svg/custom/visibility-override-filter-expected.png: Copied from LayoutTests/platform/qt/svg/custom/glyph-setting-d-attribute-expected.png.
* platform/qt/svg/custom/visibility-override-filter-expected.txt: Added.
* platform/qt/svg/dom/altGlyph-dom-expected.txt:
* platform/qt/svg/dom/baseVal-animVal-crash-expected.txt: Added.
* platform/qt/svg/dom/font-face-elements-expected.txt: Added.
* platform/qt/svg/text/kerning-expected.png:
* platform/qt/svg/text/kerning-expected.txt:
* platform/qt/svg/text/multichar-glyph-expected.png:
* platform/qt/svg/text/multichar-glyph-expected.txt:
* platform/qt/svg/text/text-altglyph-01-b-expected.png:
* platform/qt/svg/text/text-altglyph-01-b-expected.txt:
* platform/qt/svg/text/text-fonts-01-t-expected.png: Added.
* platform/qt/svg/text/text-fonts-01-t-expected.txt: Added.
* platform/qt/svg/text/text-hkern-expected.png:
* platform/qt/svg/text/text-hkern-expected.txt:
* platform/qt/svg/text/text-hkern-on-vertical-text-expected.png:
* platform/qt/svg/text/text-intro-05-t-expected.png: Added.
* platform/qt/svg/text/text-intro-05-t-expected.txt: Added.
* platform/qt/svg/text/text-text-04-t-expected.png:
* platform/qt/svg/text/text-text-04-t-expected.txt:
* platform/qt/svg/text/text-text-05-t-expected.png:
* platform/qt/svg/text/text-text-05-t-expected.txt:
* platform/qt/svg/text/text-text-06-t-expected.png:
* platform/qt/svg/text/text-text-06-t-expected.txt:
* platform/qt/svg/text/text-tselect-02-f-expected.png: Added.
* platform/qt/svg/text/text-tselect-02-f-expected.txt: Added.
* platform/qt/svg/text/text-vkern-expected.png:
* platform/qt/svg/text/text-vkern-expected.txt:
* platform/qt/svg/text/text-vkern-on-horizontal-text-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117260
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pierre.rossi@gmail.com [Wed, 16 May 2012 11:29:14 +0000 (11:29 +0000)]
[Qt] Enable SVG Fonts by default
https://bugs.webkit.org/show_bug.cgi?id=86463
Reviewed by Nikolas Zimmermann.
Source/WebCore:
Another feature we can get for free after switching to using
the font fast path with QRawFont.
It will get disabled in features.prf if either SVG support is
disabled or if we are not using QRawFont (e.g. for Qt 4).
Covered by a series of tests that were skipped for the
Qt port up until now.
* platform/graphics/qt/FontPlatformData.h:
(WebCore::FontPlatformDataPrivate::FontPlatformDataPrivate):
Initialize the platform data used as fallback in conjunction with SVG
fonts so it will honor size, weight and oblique-ness.
* rendering/svg/SVGTextMetricsBuilder.cpp: Avoid forcing the complex path.
(WebCore::SVGTextMetricsBuilder::advance):
(WebCore::SVGTextMetricsBuilder::advanceSimpleText):
(WebCore::SVGTextMetricsBuilder::initializeMeasurementWithTextRenderer):
* svg/SVGFontElement.cpp:
(WebCore::SVGFontElement::ensureGlyphCache): avoid ambiguity with String(const QString&)
Tools:
* qmake/mkspecs/features/features.pri:
LayoutTests:
* platform/qt-4.8/Skipped: Skipped the relevant tests...
* platform/qt/Skipped: ... and unskipped them here.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117259
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 16 May 2012 11:26:49 +0000 (11:26 +0000)]
[EFL] EFL's LayoutTestController does not implement setApplicationCacheOriginQuota
https://bugs.webkit.org/show_bug.cgi?id=85585
Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-16
Reviewed by Gustavo Noronha Silva.
Source/WebKit/efl:
Add new function to Ewk_Security_Origin to set the application cache
quota. Implement reachedApplicationCacheOriginQuota in
ChromeClientEfl. Add function to the Ewk_View to report that the
application cache quota was reached.
* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::reachedApplicationCacheOriginQuota):
* ewk/ewk_security_origin.cpp:
(ewk_security_origin_application_cache_quota_set):
* ewk/ewk_security_origin.h:
* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(ewk_view_exceeded_application_cache_quota):
* ewk/ewk_view.h:
* ewk/ewk_view_private.h:
Tools:
Implement setApplicationCacheOriginQuota in EFL's
LayoutTestController.
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
* DumpRenderTree/efl/DumpRenderTreeView.cpp:
(onExceededApplicationCacheQuota):
(drtViewAdd):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setApplicationCacheOriginQuota):
LayoutTests:
Unskip the test cases that require implementation of
setApplicationCacheOriginQuota in EFL's LayoutTestController.
* platform/efl/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117258
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bashi@chromium.org [Wed, 16 May 2012 11:20:21 +0000 (11:20 +0000)]
[Chromium] WebTransformationMatrixTest.verifyDefaultConstructorCreatesIdentityMatrix is failing
https://bugs.webkit.org/show_bug.cgi?id=86589
Reviewed by Kent Tamura.
Source/Platform:
* chromium/public/WebTransformationMatrix.h: Added destructor.
(WebTransformationMatrix):
Source/WebCore:
Need to call m_private.reset(0) before destructing WebTransformationMatrix objects.
No new tests. WebTransformationMatrixTest should pass on debug build.
* platform/chromium/support/WebTransformationMatrix.cpp:
(WebKit::WebTransformationMatrix::~WebTransformationMatrix):
(WebKit):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117257
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 16 May 2012 11:13:06 +0000 (11:13 +0000)]
[EFL] A few tests need expected result or rebaselining
https://bugs.webkit.org/show_bug.cgi?id=86595
Unreviewed EFL gardening. Add expected results for a few tests and
unskip them.
Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-16
* platform/efl/Skipped:
* platform/efl/fast/forms/input-text-double-click-expected.png: Added.
* platform/efl/fast/forms/input-text-double-click-expected.txt:
* platform/efl/http/tests/misc/slow-loading-mask-expected.png: Added.
* platform/efl/http/tests/misc/slow-loading-mask-expected.txt: Added.
* platform/efl/media/video-frame-accurate-seek-expected.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117256
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 16 May 2012 11:03:47 +0000 (11:03 +0000)]
[EFL] EFL's LayoutTestController evaluateScriptInIsolatedWorld implementation
https://bugs.webkit.org/show_bug.cgi?id=83776
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-16
Reviewed by Tor Arne Vestbø.
Source/WebKit/efl:
Added helper new function implementing JS script evaluation in an isolated world.
Worlds are cached by their id.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::evaluateScriptInIsolatedWorld):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:
Tools:
Added missing implementation of LayoutTestController::evaluateScriptInIsolatedWorld().
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::evaluateScriptInIsolatedWorld):
LayoutTests:
Unskipped corresponding testcases.
* platform/efl/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117255
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 16 May 2012 10:43:17 +0000 (10:43 +0000)]
[Qt][WK2] Move WebFrameNetworkingContext to WebKit namespace.
https://bugs.webkit.org/show_bug.cgi?id=86590
Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-05-16
Reviewed by Simon Hausmann.
* WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.cpp:
(WebKit::WebFrameNetworkingContext::WebFrameNetworkingContext):
(WebKit::WebFrameNetworkingContext::create):
* WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.h:
(WebKit):
(WebFrameNetworkingContext):
(WebKit::WebFrameNetworkingContext::originatingObject):
(WebKit::WebFrameNetworkingContext::~WebFrameNetworkingContext):
(WebKit::WebFrameNetworkingContext::networkAccessManager):
(WebKit::WebFrameNetworkingContext::mimeSniffingEnabled):
(WebKit::WebFrameNetworkingContext::thirdPartyCookiePolicyPermission):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117254
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 16 May 2012 10:34:01 +0000 (10:34 +0000)]
[EFL] http/tests/misc/iframe-reparenting-id-collision.html can be unskipped
https://bugs.webkit.org/show_bug.cgi?id=86588
Unreviewed EFL gardening. Unskip
http/tests/misc/iframe-reparenting-id-collision.html which is passing
now that Bug 64085 is closed.
Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-16
* platform/efl/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117253
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
g.czajkowski@samsung.com [Wed, 16 May 2012 10:27:52 +0000 (10:27 +0000)]
Unreviewed. Add myself as a committer.
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117252
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hans@chromium.org [Wed, 16 May 2012 10:24:51 +0000 (10:24 +0000)]
Speech JavaScript API: pass WebSecurityOrigin to embedder
https://bugs.webkit.org/show_bug.cgi?id=86348
Reviewed by Adam Barth.
Pass the WebSecurityOrigin of the SpeecReco object to the embedder when calling
start(). The origin will be used to determine whether speech recognition is
allowed or not.
* public/WebSpeechRecognitionParams.h:
(WebKit::WebSpeechRecognitionParams::WebSpeechRecognitionParams):
(WebKit::WebSpeechRecognitionParams::origin):
(WebSpeechRecognitionParams):
* src/SpeechRecognitionClientProxy.cpp:
(WebKit::SpeechRecognitionClientProxy::start):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117251
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zandobersek@gmail.com [Wed, 16 May 2012 10:19:35 +0000 (10:19 +0000)]
Unreviewed GTK gardening after r117123 and r117225.
* platform/gtk/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117250
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
shinyak@chromium.org [Wed, 16 May 2012 10:08:23 +0000 (10:08 +0000)]
ShadowRoot.selection should return the seleciton whose range is in a shadow tree.
https://bugs.webkit.org/show_bug.cgi?id=82698
Reviewed by Ryosuke Niwa.
Source/WebCore:
The selection object returned from shadowRoot.selection should be able to see
the inner object of the shadowRoot.
In the previous code, the node out of the shadow subtree was returned for
anchorNode, focusNode, baseNode, and extentNode. This patch enables us to get
the corresponding shadow ancestor in the specified TreeScope (m_treeScope).
Tests: editing/shadow/selection-of-orphan-shadowroot.html
editing/shadow/selection-of-shadowroot.html
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::selection):
* dom/ShadowRoot.h:
(ShadowRoot):
* dom/TreeScope.cpp:
(WebCore::TreeScope::getSelection): When shadow DOM feature is not enabled, we want to use the same
instance of DOMSelection among Document and ShadowRoot.
* dom/TreeScopeAdjuster.cpp:
(WebCore::TreeScopeAdjuster::TreeScopeAdjuster):
(WebCore::TreeScopeAdjuster::ancestorInThisScope): Since node could be null, I've added a node check code.
* dom/TreeScopeAdjuster.h:
(TreeScopeAdjuster):
(WebCore::TreeScopeAdjuster::treeScope):
* page/DOMSelection.cpp:
(WebCore::DOMSelection::anchorNode):
(WebCore::DOMSelection::anchorOffset):
(WebCore::DOMSelection::focusNode):
(WebCore::DOMSelection::focusOffset):
(WebCore::DOMSelection::baseNode):
(WebCore::DOMSelection::baseOffset):
(WebCore::DOMSelection::extentNode):
(WebCore::DOMSelection::extentOffset):
(WebCore::DOMSelection::shadowAdjustedNode): Gets the corresponding node in the m_treeScope from the Position.
(WebCore):
(WebCore::DOMSelection::shadowAdjustedOffset): Gets the corresponding node offset in the m_treeScope from the Position.
* page/DOMSelection.h:
(WebCore):
(DOMSelection):
LayoutTests:
This patch contains 2 tests:
- Generates a complex HTML tree having a ShadowRoot, an older ShadowRoot, a nested ShadowRoot,
nested ShadowRoot in an older ShadowRoot, etc., and try to drag from a nested shadow root of
older shadow root to a nested shadow root of younger shadow root. Then checks nodes of Shadowroot.selection
are in the same tree scope or null.
- Generates a ShadowDOM which is not inserted into a document, and confirms nodes taken from
the selection are all null.
Also, this patch deprecates old shadowRoot.selection tests, because they test to check
window.getSelection() and shadowRoot.selection is the same. This behavior is changed by this patch.
* editing/shadow/selection-of-orphan-shadowroot-expected.txt: Added.
* editing/shadow/selection-of-orphan-shadowroot.html: Added.
* editing/shadow/selection-of-shadowroot-expected.txt: Added.
* editing/shadow/selection-of-shadowroot.html: Added.
* fast/dom/resources/event-sender-util.js:
(mouseMoveToElem):
(dragFromTo):
* fast/dom/shadow/resources/shadow-dom-util.js: Added.
(getElementByIdConsideringShadowDOM.iter):
(getElementByIdConsideringShadowDOM):
* fast/dom/shadow/selection-in-shadow.html: Removed.
* platform/chromium-mac-snowleopard/fast/dom/shadow/selection-in-shadow-expected.txt: Removed.
* platform/chromium/fast/dom/shadow/selection-in-shadow-expected.txt: Removed.
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117249
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abecsi@webkit.org [Wed, 16 May 2012 09:58:59 +0000 (09:58 +0000)]
[WTR] Visited link tracking is not disabled properly
https://bugs.webkit.org/show_bug.cgi?id=76699
Reviewed by Jocelyn Turcotte.
Source/WebKit2:
If PLATFORM_STRATEGIES is enabled visited link tracking is done through
VisitedLinkProvider and not through PageGroup.
InjectedBundle sets the shouldTrackVisitedLinks flag on the PageGroup,
thus the shared VisitedLinkTable does get populated with visited links
regardless of the flag.
The WebProcess should only track visited links if tracking is specifically
enabled for a test through WTR's LayoutTestController.
This patch fixes several flacky and failing layout tests on Qt-WK2.
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setShouldTrackVisitedLinks): Let the WebProcess
know about visited link tracking.
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::setShouldTrackVisitedLinks):
(WebKit::WebProcess::addVisitedLink):
* WebProcess/WebProcess.h:
(WebProcess):
LayoutTests:
* platform/qt-5.0-wk2/Skipped: Unskip passing tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117248
268f45cc-cd09-0410-ab3c-
d52691b4dbfc